Packages/TYPO3.CMS.git
5 years ago[RELEASE] Release of TYPO3 6.0.4 77/18777/1 TYPO3_6-0-4
TYPO3 Release Team [Thu, 7 Mar 2013 09:26:03 +0000 (10:26 +0100)]
[RELEASE] Release of TYPO3 6.0.4

Change-Id: I83f8cb459f776820f939ceff98d318fd3ad8a542

5 years ago[BUFIX] External URL regression by jumpurl security fix 65/18765/2
Helmut Hummel [Wed, 6 Mar 2013 14:47:57 +0000 (15:47 +0100)]
[BUFIX] External URL regression by jumpurl security fix

With the jumpurl security fix, pages of type
'Link to external URL' throw a jumpurl
hash exception if called in the frontend. This typically
happens if a HMENU renders such page links.

The patch adapts the TSFE logic to write the required
hash dynamically to _GET to make the jumpurl check happy
that is called later on within the same process if
calling such a 'external url' link.

Change-Id: Ie73cd9710929c72aad4e75543f90c8618797997b
Fixes: #46071
Related: #28587
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/18765
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Set TYPO3 version to 6.0.4-dev 48/18748/2
TYPO3 Release Team [Wed, 6 Mar 2013 11:35:42 +0000 (12:35 +0100)]
[TASK] Set TYPO3 version to 6.0.4-dev

Change-Id: Ied84dbe8f0b087b325705329414b7db0dc73b773
Reviewed-on: https://review.typo3.org/18748
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.0.3 47/18747/2
TYPO3 Release Team [Wed, 6 Mar 2013 11:35:33 +0000 (12:35 +0100)]
[RELEASE] Release of TYPO3 6.0.3

Change-Id: I962e723070598c7cf235bd7ff91432a38bb179ce
Reviewed-on: https://review.typo3.org/18747
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[TASK] Raise submodule pointer 39/18739/2
TYPO3 Release Team [Wed, 6 Mar 2013 11:02:55 +0000 (12:02 +0100)]
[TASK] Raise submodule pointer

Change-Id: I4c87c157f5b71a13cdb7b60ec695f15bee260b48
Reviewed-on: https://review.typo3.org/18739
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[SECURITY] Open redirection with jumpurl 32/18732/2
Franz G. Jahn [Wed, 6 Mar 2013 10:49:12 +0000 (11:49 +0100)]
[SECURITY] Open redirection with jumpurl

jumpurl allows redirect to any given URL. A hash on the url
is now required to know if the jumpurl has been created
by the system or by the outside.

The hook "jumpurlRedirectHandler" can be used to allow
redirects without hash or to custom redirects.

Fixes: #28587
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: I63da18b1963ec50cd95dd49d1669c9873b7bab54
Security-Commit: db8748be003fdbd7fd179c239dd3dc92543e90bf
Security-Bulletin: TYPO3-CORE-SA-2013-001
Reviewed-on: https://review.typo3.org/18732
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Fix warning in adapter service 00/18700/2
Helmut Hummel [Tue, 5 Mar 2013 16:39:26 +0000 (17:39 +0100)]
[BUGFIX] Fix warning in adapter service

The merge of #45415 introduced a warning
because the new meta column name was
used as array key.

Skip this step when the meta column
is found to fix this issue.

Fixes: #45415
Releases: 6.1, 6.0

Change-Id: I5446104359816d0ccacf6c239b86b9b073783174
Reviewed-on: https://review.typo3.org/18700
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Do not overwrite imagecaption in content adapter 99/18699/2
Helmut Hummel [Tue, 12 Feb 2013 16:57:19 +0000 (17:57 +0100)]
[BUGFIX] Do not overwrite imagecaption in content adapter

Problem:
Create a new content element of type file links,
add a file relation and a description to this file.
Switch this element to be an image element,
add an image and a description of the image

Expected result:
An image with the image description is shown

Actual result:
An image with the description of the file is shown.

Solution:
Check if the field actually is shown in the selected
content element type.

Fixes: #45415
Releases: 6.0, 6.1

Change-Id: I3aa0e47b336cfa881c637b7f5a9e68476ded88ae
Reviewed-on: https://review.typo3.org/18222
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18699

5 years ago[BUGFIX] Fix inconsitency of file reference property getters 98/18698/2
Helmut Hummel [Tue, 12 Feb 2013 17:32:23 +0000 (18:32 +0100)]
[BUGFIX] Fix inconsitency of file reference property getters

The FileReference object has the following getters
for getting properties:

getProperties()
getReferenceProperties()
getProperty($key)
getReferenceProperty($key)

The result from these getters is inconsistent:

getReferenceProperty($key)
Returns the value of a property which is only
in the reference properties

getReferenceProperties()
Returns merged properties form the original
file and the reference properties without
respecting overriding of reference properties
if they are not set to NULL

getProperty($key)
Returns the merged value from original file
and reference, respecting the NULL override
handling. But if a property is only available
in the original file an Exception is thrown.

getProperties()
Returns merged properties form the original
file and the reference properties
respecting overriding of reference properties
if they are not set to NULL
Properties only available in the original file
will be available in the resulting array.

Streamline the behaviour so that all getters
starting with "getReference" will only return
the properties of the reference record and all
other will return the merged properties but
respecting the NULL override handling.

Resolves: #45416
Releases: 6.0, 6.1

Change-Id: I35a84da83be765991b357c5cee89ce018a1f1e24
Reviewed-on: https://review.typo3.org/18223
Reviewed-by: Steffen Ritter
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18698

5 years ago[BUGFIX] Wrong usage of array_unique() 94/18694/2
Andreas Lingott [Tue, 5 Mar 2013 07:31:16 +0000 (08:31 +0100)]
[BUGFIX] Wrong usage of array_unique()

RootlineUtility.php does not use return value of array_unique() call,
which makes the call ineffective.

This causes some huge SQL queries and increases page load time heavily.

Resolves: #46000
Releases: 6.1, 6.0
Change-Id: Ic614a22a97927cc433eab9e5bf1b6125d53b5882
Reviewed-on: https://review.typo3.org/18694
Tested-by: Andreas Lingott
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
5 years ago[BUGFIX] Invalid replacement hints in t3lib/ 84/18584/2
Xavier Perseguers [Mon, 4 Mar 2013 07:38:56 +0000 (08:38 +0100)]
[BUGFIX] Invalid replacement hints in t3lib/

The comment and require_once call in deprecated classes are wrong.

Change-Id: I1d3e49bc977eef1c69551809596a5917a7ccf1f0
Fixes: #45998
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18584
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Invalid SQL result after four login failures 83/18583/2
Philipp Gampe [Sun, 3 Mar 2013 20:07:32 +0000 (21:07 +0100)]
[BUGFIX] Invalid SQL result after four login failures

sql_free_result is called too early.
Move the call after the error handling at the end of the method.

Fixes: #45996
Releases: 6.0, 6.1
Change-Id: I54f1edb48e4c3b70629b46cbba365416c01c0917
Reviewed-on: https://review.typo3.org/18579
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/18583

5 years ago[TASK] Raise submodule pointer 66/18566/2
TYPO3 Release Team [Sun, 3 Mar 2013 08:41:45 +0000 (09:41 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ie62df0cce2b394c2cbb4120d7638c2287befb7cb
Reviewed-on: https://review.typo3.org/18566
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] Make backend user global available early 87/18487/2
Helmut Hummel [Thu, 21 Feb 2013 14:01:02 +0000 (15:01 +0100)]
[BUGFIX] Make backend user global available early

The global must be available very early, because methods below
might trigger code which relies on it. In particular the workspace
overlay of the rootline which is done in certain cases.

Fixes: #45625
Releases: 6.0, 6.1
Change-Id: I035f27e11cd56fc284442b66ad8357060f76e52c
Reviewed-on: https://review.typo3.org/18420
Reviewed-by: Mattias Nilsson
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18487

5 years ago[BUGFIX] Fix of .zip exports of extension 44/18344/2
Jost Baron [Sat, 16 Feb 2013 13:43:22 +0000 (14:43 +0100)]
[BUGFIX] Fix of .zip exports of extension

Before this, all files of an extension where included into its
.zip export. Now $TYPO3_CONF_VARS['EXT']['excludeForPackaging']
is respected.

Also the function responsible for the export is cleaned up and uses
more core API than before.

Change-Id: I1c06084e4da3ee18014563572fd270ea1e4d3ec5
Fixes: #45404
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18344
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Invalid RSA key when submitting form twice 40/18340/2
Benjamin Mack [Tue, 15 Jan 2013 12:05:27 +0000 (13:05 +0100)]
[BUGFIX] Invalid RSA key when submitting form twice

When submitting a RSA-supported form twice, the JS error
"Invalid RSA public key" is thrown. In order to suppress
this double RSA decryption, an additional JS check is needed.
The change also modifies the minified version of the JS
done with http://refresh-sf.com/yui/

Change-Id: I7133e320c76e14a6f6855f477ba5a34e50eecf58
Resolves: #40085
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17541
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18340

5 years ago[BUGFIX] Fix the display of references in filelist 35/18335/2
Helmut Hummel [Sat, 16 Feb 2013 20:53:31 +0000 (21:53 +0100)]
[BUGFIX] Fix the display of references in filelist

Currently references are not displayed
in the filelist module when trying to delete a file
which has been referenced.

Fixes: #45538
Releases: 6.0, 6.1
Change-Id: Id88bc954ab0002585ec6bb75dabba901784ddab5
Reviewed-on: https://review.typo3.org/18335
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Cleanup "beuser" sysext 22/18322/2
Wouter Wolters [Sun, 10 Feb 2013 14:53:14 +0000 (15:53 +0100)]
[TASK] Cleanup "beuser" sysext

This is a non-functional change that reformats the code, removes
unnecessary empty lines and fixes namespaces in phpDoc. In addition
the following to changes are made:
- add $GLOBALS['TYPO3_DB']->sql_free_result() calls to free some memory
- change bu:SpriteIconForRecord to bu:spriteIconForRecord in templates

Change-Id: I6e832921c46f828c9db0c796d662bd8390b5ac5f
Resolves: #45343
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18322
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Cleanup "belog" sysext 21/18321/3
Wouter Wolters [Mon, 11 Feb 2013 21:08:49 +0000 (22:08 +0100)]
[TASK] Cleanup "belog" sysext

Reformats the code, fixes indents and removes extra empty lines. This is
not a functional change but a visual clean up.

Change-Id: I0d11dd7c43eee5d181c4bc0565c85d651c5c29e1
Resolves: #45392
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18321
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] LocalDriver needs to respect "is_writeable" 17/18317/2
Georg Ringer [Thu, 10 Jan 2013 09:37:21 +0000 (10:37 +0100)]
[BUGFIX] LocalDriver needs to respect "is_writeable"

The LocalDriver needs also to respect the flag "is_writeable".
This means: if the flag is not set, no folder/file can be edited/moved...

Fixes: #44370
Releases: 6.0, 6.1

Change-Id: I404ed51c62ab96d9b5eaaf6c0b7b255bdea3538b
Reviewed-on: https://review.typo3.org/18317
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Set TYPO3 version to 6.0.3-dev 84/18284/2
TYPO3 Release Team [Thu, 14 Feb 2013 15:50:27 +0000 (16:50 +0100)]
[TASK] Set TYPO3 version to 6.0.3-dev

Change-Id: I99ae446f9ecfef13b7f6e0b553f826446fd0504a
Reviewed-on: https://review.typo3.org/18284
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.0.2 83/18283/2
TYPO3 Release Team [Thu, 14 Feb 2013 15:50:17 +0000 (16:50 +0100)]
[RELEASE] Release of TYPO3 6.0.2

Change-Id: I9c9635363f5022c8c21fe34b7b6d67bb676cfbd4
Reviewed-on: https://review.typo3.org/18283
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] L10n fallback does not work for TS labels 70/18270/2
Xavier Perseguers [Thu, 20 Dec 2012 06:59:15 +0000 (07:59 +0100)]
[BUGFIX] L10n fallback does not work for TS labels

When retrieving a label in TypoScript in a locale that is not
available locally, the English label is returned instead of
using the locale fallback mechanism introduced in TYPO3 4.6.

Change-Id: I29f4b25e3fc23497d6afe74659810ca8995a39df
Fixes: #44099
Relates: #41996
Releases: 4.6, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/17247
Reviewed-by: Mattias Nilsson
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/18270

5 years ago[BUGFIX] L10n fallback does not work for ExtJS in BE 66/18266/2
Xavier Perseguers [Wed, 2 Jan 2013 17:56:09 +0000 (18:56 +0100)]
[BUGFIX] L10n fallback does not work for ExtJS in BE

PageRenderer does not take language dependency into account when reading
localization files to be included as JavaScript labels.

Change-Id: I23d12dd06a99e72968a26d5930decb87901e8af6
Fixes: #44273
Releases: 4.6, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/17313
Reviewed-by: Mattias Nilsson
Reviewed-by: Begoña Garea Garcia
Tested-by: Begoña Garea Garcia
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/18266

5 years ago[TASK] Raise submodule pointer 74/18274/2
TYPO3 Release Team [Thu, 14 Feb 2013 15:08:16 +0000 (16:08 +0100)]
[TASK] Raise submodule pointer

Change-Id: I59d84f42d187ba46006fe33af62e640388a936e5
Reviewed-on: https://review.typo3.org/18274
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] Allow "en" as language key 62/18262/2
Daniel Alder [Tue, 8 Jan 2013 10:21:25 +0000 (11:21 +0100)]
[BUGFIX] Allow "en" as language key

Fix a bug which was introduced by #25397 (commit:cb390c79).
If the selected language key is "en", do not override it to "default".
This allows custom updates to translations even for the English language.

Change-Id: I3fcbd35f0144a0cc152acd45d0861d153cc8b495
Resolves: #42084
Related: #25397
Releases: 4.6, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/17414
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/18262

5 years ago[BUGFIX] FAL: file properties are not updated 12/18212/2
Stefan Froemken [Wed, 16 Jan 2013 22:43:06 +0000 (23:43 +0100)]
[BUGFIX] FAL: file properties are not updated

The fileproperties are not updated correctly. In
case of this issue it is the filesize which was not
updated in filelist-module

Resolves: #44585
Releases: 6.0, 6.1
Change-Id: I539b6ab94c4f5aa90933302687f0c666953270fa
Reviewed-on: https://review.typo3.org/18212
Reviewed-by: Stefan Froemken
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Remove not used viewhelper in beuser 83/18183/2
Markus Günther [Sun, 10 Feb 2013 11:11:16 +0000 (12:11 +0100)]
[TASK] Remove not used viewhelper in beuser

The SelectDefaultValueViewHelper in beuser is
not used at the moment and since TYPO3 fluid
6.1 it is possible to add a prependOption
with the default selectViewHelper.

Fixes: #45338
Releases: 6.1, 6.0

Change-Id: Ie47021c2d74441243d116cc6cfcbfbb8fd5fdb1e
Reviewed-on: https://review.typo3.org/18183
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Exception when scheduling "at" execution time 73/18173/2
Andreas Wolf [Sun, 10 Feb 2013 00:00:25 +0000 (01:00 +0100)]
[BUGFIX] Exception when scheduling "at" execution time

If a recurring task is converted to a single task and the endtime is set
before now, then the exception "Task is past end date" is thrown as the
next execution time for the "at" daemon is calculated.

The fix is to catch the exceptions and ignore them, as we don't care
about tasks that will never run again when calculating the next
execution date.

Fixes: #45265
Releases: 6.1, 6.0
Change-Id: If6fd368e6c11c0b9058eb8a82a736220ef538b70
Reviewed-on: https://review.typo3.org/18173
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Processed files get corrupted when regenerated 53/18153/2
Andreas Wolf [Sat, 9 Feb 2013 10:02:05 +0000 (11:02 +0100)]
[BUGFIX] Processed files get corrupted when regenerated

After a file is being (re)processed, the information about it is updated
in the database by the ProcessedFileRepository. The repository gathers
information for the update from the processed file.

For unprocessed files (i.e. those where the original file should be
used), the ProcessedFile class does a fallback to the original file
object. Unfortunately, this fallback is also applied for the uid
property, which makes the repository overwrite a random record in
sys_file_processedfile. This leads to wrong images being displayed in
the frontend.

This patch makes the processed file only return its own uid.

IMPORTANT: To make sure your sys_file_processedfile data is not
corrupted, empty the table and your processed files folder (usually
fileadmin/_processed_/). This will slow down your site as all processed
files are regenerated, but afterwards all data will be correct.

Change-Id: I40685d5748a5a0fcf015c7d876a374f42154831d
Resolves: #45308
Related: #44616 #45168
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18153
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
5 years ago[TASK] Raise submodule pointer 25/18125/2
Christian Kuhn [Fri, 8 Feb 2013 16:29:56 +0000 (17:29 +0100)]
[TASK] Raise submodule pointer

Change-Id: I7db7cffae997b20990b29de4f2668fd5e7d0293e
Reviewed-on: https://review.typo3.org/18125
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX][Cache][PDO] Duplicate cache entry possible 98/18098/2
Leon Dietsch [Tue, 27 Nov 2012 01:12:52 +0000 (02:12 +0100)]
[BUGFIX][Cache][PDO] Duplicate cache entry possible

An identifier must be unique in the database. If some entry is set(),
the PdoBackend removes any entry with a given identifier if the cache
entry exists already. The remove() call is encapsulated with has(),
but has() returns FALSE if a cache entry is expired, so entries with
expired lifetime are not removed properly.
This leads to a \PDOException because of duplicate identifier.

The patch removes the check to has(), so set() will also remove
expired cache entries with this identifier before creating a new one.

Change-Id: Ife4e35223394805fc6d9e0b820a5d42789133f7b
Fixes: #34129
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/18098
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX][Cache] Method parameter CGL fixes 93/18093/2
Christian Kuhn [Thu, 7 Feb 2013 20:13:15 +0000 (21:13 +0100)]
[BUGFIX][Cache] Method parameter CGL fixes

Change-Id: Ie237c62fcd25d0f4ac2430983183756c7aebc633
Resolves: #45257
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18093
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Raise submodule pointer 51/18051/2
Christian Kuhn [Wed, 6 Feb 2013 12:14:18 +0000 (13:14 +0100)]
[TASK] Raise submodule pointer

Change-Id: I65c1d48dab1bab034ecb7b2021e0be5e634aaa1e
Reviewed-on: https://review.typo3.org/18051
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Crash after file upload on Windows without finfo 49/18049/2
Christian Weiske [Fri, 11 Jan 2013 15:52:54 +0000 (16:52 +0100)]
[BUGFIX] Crash after file upload on Windows without finfo

This patch checks if the finfo extension is available before using it
to determine the MIME type of a file.
If it is not available, the old function mime_content_type is used as
fallback.
When none of them are available, we give up.

This fixes a crash on Windows after uploading a file, since finfo
is by default not installed on PHP windows distributions.

Change-Id: I53a0eef3ee839c17ddaaeb303b9a0b9bae3ee485
Fixes: #37440
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18049
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Wrong SQL statements in TCA for sys_category 44/18044/2
Thomas Löffler [Tue, 5 Feb 2013 21:46:01 +0000 (22:46 +0100)]
[BUGFIX] Wrong SQL statements in TCA for sys_category

Copy and Paste problem. Table name
'tx_taxonomy_domain_model_concept' instead of
'sys_category'

Resolves: #44911
Releases: 6.0, 6.1
Change-Id: I92130a8dc5416b822edc71be148e35f193b5ea3b
Reviewed-on: https://review.typo3.org/18044
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Additional extTables script might not exist 01/18001/2
Philipp Gampe [Sun, 3 Feb 2013 21:59:25 +0000 (22:59 +0100)]
[BUGFIX] Additional extTables script might not exist

During https://review.typo3.org/17381, the constant
TYPO3_extTableDef_script is now always defined.

Change the bootstrap to only include the file if it really
exists.

Related: #44331
Fixes: #45122
Releases: 6.0, 6.1
Change-Id: I547c5e141b2395eb8b684ce245bb0440096f14df
Reviewed-on: https://review.typo3.org/18001
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Misspelling in scheduler documentation 83/17983/2
Tomita Militaru [Sat, 2 Feb 2013 13:38:11 +0000 (15:38 +0200)]
[BUGFIX] Misspelling in scheduler documentation

Corrects certain words / phrases from the documentation manual.

Fixes: #33936
Releases: 6.1, 6.0
Change-Id: I89ad923280cd1df6d126884e88987abaa9d5f7df
Reviewed-on: https://review.typo3.org/17983
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] tools_dbint needs to be called via mod.php 82/17982/2
Philipp Gampe [Sun, 3 Feb 2013 16:34:39 +0000 (17:34 +0100)]
[BUGFIX] tools_dbint needs to be called via mod.php

Fixes: #45112
Releases: 6.0, 6.1
Change-Id: I69b22d8d5fcb94e9b3cefcce600fd6b154de6c9d
Reviewed-on: https://review.typo3.org/17982
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] IE9 compatibility clear cache menu 71/17971/2
Andreas Kiessling [Sun, 3 Feb 2013 09:54:02 +0000 (10:54 +0100)]
[BUGFIX] IE9 compatibility clear cache menu

The prototype library shipped with TYPO3 is not compatible with IE9
anymore. Since prototype will be replaced in the near future the easiest
solution is to use plain JavaScript.

Change-Id: I1dc732a61531fa585ed8e0ba6ce8df1b23f3b8bd
Resolves: #36364
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17971
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Hook call modifyDBRow in ContentContentObject 48/17948/4
Alina Fleser [Sat, 2 Feb 2013 11:11:28 +0000 (13:11 +0200)]
[BUGFIX] Hook call modifyDBRow in ContentContentObject

Replace $this->TYPO3_CONF_VARS with $GLOBALS['TYPO3_CONF_VARS']

Fixes: #44416
Releases: 6.0, 6.1, 4.7, 4.6, 4.5
Change-Id: I1f2b6a2479cc879c2a9144d03e176b74d895d52f
Reviewed-on: https://review.typo3.org/17948
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Install tool documentation default installTollPassword 47/17947/4
Tomita Militaru [Sat, 2 Feb 2013 10:55:40 +0000 (12:55 +0200)]
[BUGFIX] Install tool documentation default installTollPassword

The fatal error message instructs to use array position EXT instead
of position BE for installToolPassword.
Replaces EXT with BE in the error message.

Fixes: #44682
Releases: 6.0, 6.1
Change-Id: Ic262e9c9838dc07dc523e9a85cf92e8f1f79e634
Reviewed-on: https://review.typo3.org/17947
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Labels for grouping bookmarks are missing 51/17951/2
Bindea Silviu [Sat, 2 Feb 2013 13:55:25 +0000 (15:55 +0200)]
[BUGFIX] Labels for grouping bookmarks are missing

Using function sL to load locallang with labels for bookmarks

Fixes: #44691
Releases: 6.1, 6.0
Change-Id: I509aa06e379e1397fea50c6a2c137db3994eff2a
Reviewed-on: https://review.typo3.org/17951
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix misspelling in RTE meta menu 56/17956/2
Tomita Militaru [Sat, 2 Feb 2013 09:55:26 +0000 (11:55 +0200)]
[BUGFIX] Fix misspelling in RTE meta menu

Corrects the label for inserting unordered bullet lists.

Fixes: #43886
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: I4190dbcc8cadc90ae00d1ec1aa405a5a75863594
Reviewed-on: https://review.typo3.org/17956
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Impossible to save the TCA configuration 44/17944/2
Philipp Gampe [Sat, 5 Jan 2013 22:59:39 +0000 (23:59 +0100)]
[BUGFIX] Impossible to save the TCA configuration

The configuration module allows to save changes to the TCA array.

If no extTablesDefinitionScript is defined, constant
TYPO3_extTableDef_script is defined as empty. This results in an
attempt to write to a directory (because the filename is empty).
This is not obvious as the constant is not needed much and the
error message is misleading.

Solution is to fall back to the default value during bootstrap if
extTablesDefinitionScript is not set in LocalConfiguration.php.

Change-Id: Id759aa73146669cccae9a83d8452340f9f78927b
Fixes: #44331
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17944
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] load TCA before manipulation 40/17940/2
Jigal van Hemert [Sat, 15 Dec 2012 08:58:54 +0000 (09:58 +0100)]
[BUGFIX] load TCA before manipulation

Load the TCA before manipulating the contents in form and
css_styled_content, otherwise the checks for later calls to
loadTCA will fail while the TCA is not fully loaded.

Change-Id: Id2d96d8dab0fc53661689f778871ebb078272062
Resolves: #38505
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17940
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Restore support for Update script 38/17938/2
Francois Suter [Tue, 29 Jan 2013 19:31:52 +0000 (20:31 +0100)]
[BUGFIX] Restore support for Update script

The new EM is missing support for the class.ext_update.php script.
This patch restores it, giving it its own icon in the extension
list view.

Change-Id: Id5ea243bb689882959aa85cdbe700e784d83b2c0
Resolves: #43244
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17938
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Misspelled class name FrontendUserAuthtenication 26/17926/2
Christian Kuhn [Fri, 1 Feb 2013 15:21:54 +0000 (16:21 +0100)]
[BUGFIX] Misspelled class name FrontendUserAuthtenication

Fix class name, rename file, fix usage
FrontendUserAuth*ten*ication
FrontendUserAuth*ent*ication

Change-Id: Id851db64a50a5938496dd4411caaec0bf7ba85af
Fixes: #43464
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17926
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] add check for empty form values in FORM View 22/17922/2
Alexander Stehlik [Fri, 1 Feb 2013 12:32:15 +0000 (13:32 +0100)]
[BUGFIX] add check for empty form values in FORM View

If a FORM is submitted without any value a Fatal Error is thrown in
typo3/sysext/form/Classes/View/Confirmation/Confirmation.php on line
101. The patch adds a check for that case.

Fixes: #28606
Releases: 6.1, 6.0, 4.7, 4.6

Change-Id: I77cd57f0d56e9bdcf9517683ea21c3dc9ec1bc45
Reviewed-on: https://review.typo3.org/17922
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] StorageRepository must respect 'deleted' flag 19/17919/2
Sebastian Michaelsen [Fri, 18 Jan 2013 10:44:47 +0000 (11:44 +0100)]
[BUGFIX] StorageRepository must respect 'deleted' flag

The FAL's Storage Repository find* methods also load
deleted file storages at the moment.

Reproduce:
* Create some "File Storage" records on the root page and
delete some of them
* Open the File module, it will showdeleted File Storages

Resolves: #44630
Releases: 6.1, 6.0
Change-Id: I5c60f16261508978ddbe47aa26b52be5b05a82bc
Reviewed-on: https://review.typo3.org/17919
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Remove delete button for sys_file 16/17916/2
Helmut Hummel [Fri, 1 Feb 2013 10:27:16 +0000 (11:27 +0100)]
[BUGFIX] Remove delete button for sys_file

The edit view of file meta data currently has
a delete button, which sets the record of this
file to deleted, but does not delete the file itself.

It might be useful at some point
to use this to implement some recycler
functionality, but currently the FAL layer
has no support for it and a file with a deleted
meta data record is an inconsistent state
which has to be avoided by all means.

Resolves: #45065
Releases: 6.0, 6.1

Change-Id: I5033107cf4021d127e274bbe12e3aa08ea1b4ef6
Reviewed-on: https://review.typo3.org/17916
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[CLEANUP] Cleanup calls and docheaders in Core/Classes/Resource 13/17913/2
Anja Leichsenring [Sat, 12 Jan 2013 15:40:07 +0000 (16:40 +0100)]
[CLEANUP] Cleanup calls and docheaders in Core/Classes/Resource

In the Core/Classes/Resource Folder many calls to classes can be
used with shorthand syntax (without the namespace).

Many docheaders miss one or more @throws clauses for Exceptions to throw.

Resolves: #44476
Releases: 6.1, 6.0

Change-Id: Ia9c4b6e29fa924d42df8ff0e1e68ed607ce8256f
Reviewed-on: https://review.typo3.org/17913
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper 12/17912/2
Sebastian Michaelsen [Tue, 15 Jan 2013 10:05:09 +0000 (11:05 +0100)]
[TASK] Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper

Remove EXT:lang FormEngineBasedCheckboxGroupViewHelper this
is not used anymore in the core.

Resolves: #44527
Releases: 6.1, 6.0

Change-Id: I06925b20d7399181be6bb2d5f5439cade1fca7c1
Reviewed-on: https://review.typo3.org/17540
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-on: https://review.typo3.org/17912

5 years ago[TASK] DataHandler::getAutoVersionId() should be public 07/17907/2
Oliver Hader [Thu, 31 Jan 2013 18:17:41 +0000 (19:17 +0100)]
[TASK] DataHandler::getAutoVersionId() should be public

The method getAutoVersionId() in DataHandler/t3lib_TCEmain
should be public. The method is a helper to access the accordant
member variable that get's filled during workspace actions and
thus is useful in hooks as well.

Change-Id: Ie1f55d92b8e72e6ab68a563f0c1c52762239e102
Resolves: #45050
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17907
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Remove save and new button for sys_file 99/17899/2
Helmut Hummel [Thu, 31 Jan 2013 16:46:22 +0000 (17:46 +0100)]
[BUGFIX] Remove save and new button for sys_file

The save and new button does not make any sense for file
meta data, so we should not display it.

Resolves: #45044
Releases: 6.0,6.1

Change-Id: Ic25edee5b208103f74c7d566acb93099bdd3c19f
Reviewed-on: https://review.typo3.org/17899
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] ext:aboutmodules broken link to ext:reports 77/17877/3
Christian Kuhn [Wed, 30 Jan 2013 21:11:36 +0000 (22:11 +0100)]
[BUGFIX] ext:aboutmodules broken link to ext:reports

ext:aboutmodules shows some message box if ext:reports
is installed and found some serious problem. The message
has a link to reports module that is broken and fixed
by the patch.

Change-Id: I7d0b2b6573eb960028cb1de0463808eaf5860fbc
Resolves: #40218
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17877
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] displayWarningMessages uses wrong returnUrl 75/17875/2
Sebastian Michaelsen [Tue, 15 Jan 2013 13:29:33 +0000 (14:29 +0100)]
[BUGFIX] displayWarningMessages uses wrong returnUrl

The warning in the "About Modules" module about an
insecure admin offers a link to edit this user. Following
this link and then closing the form again leads to a 404.
The reason is a wrong returnUrl in
BackendUtility:: displayWarningMessages.

Resolves: #44537
Releases: 6.1, 6.0
Change-Id: I41d361d8b7314ac0bace8b8a5979a6f69128657c
Reviewed-on: https://review.typo3.org/17875
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] LocalConfiguration extListArray should be written without keys 72/17872/2
Jan-Erik Revsbech [Tue, 29 Jan 2013 19:46:05 +0000 (20:46 +0100)]
[BUGFIX] LocalConfiguration extListArray should be written without keys

When writing LocalConfiguration.php, arrays should be written without keys
if all the keys are numeric, even if the keys contain leaps.

Fixes: #44938
Releases: 6.1, 6.0
Change-Id: Ic1d929d54a75b091ecbe4f0f4b82049d507ccd95
Reviewed-on: https://review.typo3.org/17872
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Reset legacy fields if no relations are found 71/17871/2
Helmut Hummel [Wed, 30 Jan 2013 16:39:28 +0000 (17:39 +0100)]
[BUGFIX] Reset legacy fields if no relations are found

If you add multiple images to a tt_content element
but mark all of them hidden, an image is shown which has
the uid of the number of images added to the element.

This is the case because TYPO3 puts the relation count in the
field and the frontend adapter service does not reset
the field if no relations are found.

The solution is to set the legacy fields in any case.

This change adds a test which fails without a fix
and another test which shows that the original behaviour
is not affected.

Change-Id: I2cacfe185e1371331ab7564413e43c7d6cce8556
Resolves: #44988
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17871
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Add missing labels for Extension Manager 70/17870/2
Wouter Wolters [Tue, 29 Jan 2013 21:18:01 +0000 (22:18 +0100)]
[BUGFIX] Add missing labels for Extension Manager

The Extension Manager is missing the labels when opening
the About Modules in the backend.

Change-Id: I4ea3a312e707dd1af22f6a693298170c32e19ecc
Fixes: #44941
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17870
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Compatibility fix for get_html_translation_table() 80/17180/3
Michael Stucki [Tue, 27 Nov 2012 00:12:31 +0000 (01:12 +0100)]
[BUGFIX] Compatibility fix for get_html_translation_table()

t3lib_cs::entities_to_utf8() triggers a PHP warning on versions
lower than 5.3.4 because too many parameters were given.
See http://php.net/manual/en/function.get-html-translation-table.php

Change-Id: Ic302f2b8c2902ec8685dfb2d974273071bbbdcb7
Fixes: #39287
Releases: 6.0, 4.7
Reviewed-on: https://review.typo3.org/17180
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
5 years ago[BUGFIX] Remove obsolete flushByTags() from wincache 10/17810/2
Christian Kuhn [Tue, 29 Jan 2013 19:29:31 +0000 (20:29 +0100)]
[BUGFIX] Remove obsolete flushByTags() from wincache

Method flushByTags() was removed from the cache backend interface
since core version 4.6 and fully removed in 6.0. The wincache
backend still implements this method, but it is never used
anywhere, so it can be removed.

Change-Id: I038f1839f77b33173122bb8a0485dd005ee8a5a4
Fixes: #44937
Related: #35818
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17810
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Register suite integrity tests again 08/17808/2
Christian Kuhn [Tue, 29 Jan 2013 19:13:13 +0000 (20:13 +0100)]
[BUGFIX] Register suite integrity tests again

The integrity unit tests executed at the very bottom of the
test suite very accidentally removed during issue #40950.
Add them again.

Change-Id: Ifc59f201c98a79e1cf376e1c1e1124408cd37c10
Fixes: #44936
Related: #40950
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17808
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Set TYPO3 version to 6.0.2-dev 02/17802/2
TYPO3 Release Team [Tue, 29 Jan 2013 16:48:30 +0000 (17:48 +0100)]
[TASK] Set TYPO3 version to 6.0.2-dev

Change-Id: I88c4aa51d1aea00cab2e7fc546230b32e41f5bdf
Reviewed-on: https://review.typo3.org/17802
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.0.1 01/17801/2
TYPO3 Release Team [Tue, 29 Jan 2013 16:48:19 +0000 (17:48 +0100)]
[RELEASE] Release of TYPO3 6.0.1

Change-Id: Ic05e7a2a5edba74ca6ff8bfc90b388440a54515f
Reviewed-on: https://review.typo3.org/17801
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] FLUIDTEMPLATE cObj uses wrong template file 00/17800/3
Christian Kuhn [Tue, 29 Jan 2013 16:09:03 +0000 (17:09 +0100)]
[BUGFIX] FLUIDTEMPLATE cObj uses wrong template file

Due to some weird instance re-usage in the content object renderer
the view object in FLUIDTEMPLATE content object must be re-created
for every call to render() to avoid some nasty cache issues.

Change-Id: If2ec0b171b8227aba9204d343a9e9010b69ecc78
Resolves: #44610
Related: #42182
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17800
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] EXT:reports Improve xclass reporting 78/17778/2
Christian Kuhn [Mon, 28 Jan 2013 22:19:47 +0000 (23:19 +0100)]
[TASK] EXT:reports Improve xclass reporting

Since TYPO3 CMS 6.0, the XCLASS registration changed and the old
registration style does not work anymore. Additionally, 6.0 comes
with a basic check for old XCLASS registration to warn users about
that.

The patch adds a new report for newly registered XCLASS'es and
adapts the messages to better notify that neither old nor new
registrations are a real problem, but that those classes should
be kept an eye on during upgrading.

Change-Id: I8c0052b9c7fb0e88aff62a71c9592bf51bcec7ad
Resolves: #44895
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17778
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove function usage ctype_alnum in PageRenderer 73/17773/2
Ingo Pfennigstorf [Fri, 7 Dec 2012 15:18:44 +0000 (16:18 +0100)]
[TASK] Remove function usage ctype_alnum in PageRenderer

This fixes the problem that on some servers the PHP ctype extension
is not installed by default and results in a blank backend screen
when trying to edit a page.

Fixes: #43726
Releases: 6.1, 6.0

Change-Id: Icb029a39107c092c06c9e70bbde0b2217e5860f7
Reviewed-on: https://review.typo3.org/17773
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] tt_content: exclude config fields 72/17772/2
Felix Kopp [Mon, 28 Jan 2013 15:45:44 +0000 (16:45 +0100)]
[BUGFIX] tt_content: exclude config fields

Adds missing option to restrict access for properties
in tt_content elements within backend user group:

* imageorient (Image orientation)
* imagecols (Image columns)

Without those options no minimal configuration
for backend user privileges can be setup.

Fixes: #44890
Release: 6.0, 6.1
Change-Id: Ia5ed4779db27f90fb7d44eb47c3290c523027a21
Reviewed-on: https://review.typo3.org/17772
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Backend groups: exclude config fields 71/17771/2
Felix Kopp [Mon, 28 Jan 2013 15:21:52 +0000 (16:21 +0100)]
[BUGFIX] Backend groups: exclude config fields

Adds missing option to restrict access to the fields:

* content_from_pid (Show content from different page)
* alias (Url alias)

within backend user group configuration.

Without these exclude fields backend user right can not
be stripped to the minimum: edit page title only.

Fixes: #40866
Releases: 6.0, 6.1
Change-Id: I1d5a1f08ea72cbeb11ade0302ebb0ecb7a5bfe2a
Reviewed-on: https://review.typo3.org/17771
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Possible warning in about module 69/17769/2
Christian Kuhn [Mon, 28 Jan 2013 16:47:21 +0000 (17:47 +0100)]
[BUGFIX] Possible warning in about module

ext:about includes ext_emconf.php files of loaded extensions.
The code raises a warning if those files are not found. This
can happen for example, if some extension is loaded in
LocalConfiguration "extList", but does not exist in the file
system.

Solution is to check for file existance before include.

Change-Id: Ic58adfc908ff02d5f0d9e79b69719d02c6b429ab
Fixes: #44892
Releases: 6.1, 6.0, 4.7
Reviewed-on: https://review.typo3.org/17769
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Make submit button save all tabs in extension manager 60/17760/2
Jan-Erik Revsbech [Mon, 28 Jan 2013 10:29:13 +0000 (11:29 +0100)]
[BUGFIX] Make submit button save all tabs in extension manager

Each category is rendered as separate sheets/tabs, but should
share a single form and submit button. Otherwise changes to
one sheet are not saved when clikting submit in another sheet.

Fixes: #44876
Related: #44559
Releases: 6.1, 6.0

Change-Id: Idce5c70c20faebe495b9241ac0f2f0ea0aec6c2a
Reviewed-on: https://review.typo3.org/17760
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] EM: Refactor Configuration handling 59/17759/2
Christian Kuhn [Sat, 26 Jan 2013 16:29:33 +0000 (17:29 +0100)]
[TASK] EM: Refactor Configuration handling

Classes ConfigurationUtility and ConfigurationItemRepository handle
the extension managers extension configuration settings.

Configuration sources are ext_conf_template.txt files,
LocalConfiguration.php and the extension manager configuration
forms. They all have different formats and structures, thus
the code to merge all that is not exactly easy.

This patch shifts some code around in order to make the current
handling better understandable for easier debugging. The API is
still not as simple as it should be, but for now some
code smell is solved:

* Use @inject annotation for dependency injection to reduce
  number of code lines.
* Remove dependency injected objects if possible and rely on
  injection of objectManager only if the object is not widely
  used in the class.
* Disentangle a method call chain from InstallUtility to
  ConfigurationUtility back to InstallUtility by removing method
  writeExtensionTypoScriptStyleConfigurationToLocalconf() from
  InstallUtility and merging functionality with
  ConfigurationUtility->writeConfiguration().
* Remove public method createArrayFromConstants() from
  ConfigurationItemRepository and move to ConfigurationUtility
  under new name
  getDefaultConfigurationFromExtConfTemplateAsFlatItemArray().
* Rename ConfigurationItemRepository->findByExtension() to
  findByExtensionKey() and always let it return an
  ObjectStorage, even if empty.
* Simplify several method signatures, mostly of protected methods
  to one parameter only, moving only the extension key around.
* Better encapsulating of low level code in protected methods
  instead of duplicated low level code in in entry methods
  or controller logic.
* Resolve code smell in unit tests with better mocking and
  structured tests.

Change-Id: I441280a3907e2487cd7fe7ba1856e9ef04c72a42
Resolves: #44818
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17759
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Raise submodule pointer 43/17743/2
Christian Kuhn [Sat, 26 Jan 2013 21:57:32 +0000 (22:57 +0100)]
[TASK] Raise submodule pointer

Change-Id: I6318323b43636e8e71b09e153ff1fed05f7b671d
Reviewed-on: https://review.typo3.org/17743
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Add cursor:pointer to inline header 28/17728/2
Georg Ringer [Fri, 25 Jan 2013 14:01:41 +0000 (15:01 +0100)]
[TASK] Add cursor:pointer to inline header

the header + icon of a IRRE header should have a cursor:pointer as this is
the area which opens the related record

Change-Id: I71b91f049bf912661d6b6a1e38cb56ba0a9fea1e
Resolves: #44808
Releases: 6.1,6.0
Reviewed-on: https://review.typo3.org/17704
Reviewed-by: Wouter Wolters
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
Reviewed-on: https://review.typo3.org/17728
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Invalid description of noPHPscriptInclude 27/17727/2
dprecup [Sun, 9 Dec 2012 11:20:12 +0000 (13:20 +0200)]
[BUGFIX] Invalid description of noPHPscriptInclude

default of ['FE']['noPHPscriptInclude'] as documented in
t3lib/stddb/DefaultConfiguration.php is not 'media/scripts/' but
one one of 'typo3/ext/', 'typo3/sysext/' or 'typo3conf/ext'

Resolves: #43730
Releases: 6.1, 6.0

Change-Id: Idb5f63ffc3c555a6b096077302b8e56cd0b82983
Reviewed-on: https://review.typo3.org/17727
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix error listing in belog 26/17726/2
Tomita Militaru [Sun, 9 Dec 2012 14:29:04 +0000 (16:29 +0200)]
[BUGFIX] Fix error listing in belog

Added an array with the error codes into the query constraint when
action Errors (-1) was selected.

Fixes: #43797
Releases: 6.0, 6.1
Change-Id: Iccf5db777d1e93bcad24fc72b3eef935464d3582
Reviewed-on: https://review.typo3.org/17726
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Use property injection in LanguageController 22/17722/2
Sebastian Michaelsen [Tue, 15 Jan 2013 09:03:51 +0000 (10:03 +0100)]
[TASK] Use property injection in LanguageController

\TYPO3\CMS\Lang\Controller\LanguageController has 4
inject* Methods which a pretty vanilla and can be replaced
by property injection.

Change-Id: I37181e2bbbd12c9c7fe7b34fe8adafe6f4becec3
Resolves: #44526
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17722
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Cleanups for sysext belog 21/17721/2
Sebastian Michaelsen [Wed, 23 Jan 2013 11:11:20 +0000 (12:11 +0100)]
[TASK] Cleanups for sysext belog

* Fix references to old classes
* Use property injection where possible

Resolves: #44744
Releases: 6.1, 6.0
Change-Id: I3076f48876fdc7566e85810eaf22aaa87d5c71e8
Reviewed-on: https://review.typo3.org/17721
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix problem with saving extension configuration in different tabs 20/17720/2
Jan-Erik Revsbech [Thu, 8 Nov 2012 00:38:58 +0000 (01:38 +0100)]
[BUGFIX] Fix problem with saving extension configuration in different tabs

The new ConfigurationUtility is working internally with configuration as
valued array, but the existing configuration is serialized in the old
nested format. When merging these two, exising configuration was not
merged correctly, resulting in error where configuration set in other tabs
was lost when saving.

Change-Id: I9007a0f80974A72610b3afc1e1dc76f7cad31fca
Fixes: #42775
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17720
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Correct TCA inclusion for uploads rendering 15/17715/2
Alexander Stehlik [Thu, 20 Dec 2012 10:08:03 +0000 (11:08 +0100)]
[BUGFIX] Correct TCA inclusion for uploads rendering

In the method that renders the uploads in css_styled_content
the call to load the TCA was replaced with its Frontend
counterpart to enable access to the configuration of custom
fields in tt_content.

Fixes: #44145
Branches: 4.5, 4.6, 4.7, 6.0, 6.1

Change-Id: I26f67fcfbf11db25c80ebe93ddd1e81167d828a9
Reviewed-on: https://review.typo3.org/17250
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-on: https://review.typo3.org/17715

5 years ago[BUGFIX] EM: un/install visual feedback 14/17714/2
Felix Kopp [Tue, 11 Dec 2012 06:27:07 +0000 (07:27 +0100)]
[BUGFIX] EM: un/install visual feedback

Adds a visual feedback to the un/install button action in EM:
Masks the extension manager during un/install operations
are in progress - after success a page redirect is fired.

Introduces a CSS class that class can be added to any link in EM:
.onClickMaskExtensionManager

Change-Id: If7aa0b15eeab1afb162b103662a10920f4da149f
Fixes: #43856
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17091
Reviewed-by: Sebastian Michaelsen
Tested-by: Sebastian Michaelsen
Reviewed-by: Tobias Liebig
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-on: https://review.typo3.org/17714

5 years ago[BUGFIX] Avoid PHP Warning in Page Module 12/17712/4
Roland Waldner [Wed, 16 Jan 2013 07:18:46 +0000 (08:18 +0100)]
[BUGFIX] Avoid PHP Warning  in Page Module

Change-Id: I218065a3445211d88ce131ecf23da3a947eb2e70
Resolves: #44540
Branches: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17562
Reviewed-by: Mattias Nilsson
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-on: https://review.typo3.org/17712

6 years ago[TASK] Add save only button to Scheduler task 81/17681/2
Lorenz Ulrich [Fri, 18 Jan 2013 14:17:06 +0000 (15:17 +0100)]
[TASK] Add save only button to Scheduler task

Scheduler tasks currently miss a save only button. Since Firefox and
Opera don't send the value of an <input type="submit">, the save and
save & close buttons are wrapped in a <button type="submit"> to ensure
saving and saving & closing is cross-browser compatible.

Change-Id: Ia5e32efc2e5e2af2943374c9a570a3a94b0511b4
Fixes: #44152
Releases: 6.1, 6.0, 4.7
Reviewed-on: https://review.typo3.org/17681
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Missing subcategories labels in EM 80/17680/2
Francois Suter [Tue, 22 Jan 2013 22:16:28 +0000 (23:16 +0100)]
[BUGFIX] Missing subcategories labels in EM

The (new) Extension Manager correctly uses subcategories for sorting
and grouping extension configuration options (in the configuration
form), but does not display the related labels. This makes the form
rather weird and unhelpful. This information must be restored.

Resolves: #44701
Releases: 6.0, 6.1
Change-Id: I0dde1d294edc403404ad39985f91e3772ef0b710
Reviewed-on: https://review.typo3.org/17680
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] IRRE forms not using full width 62/17662/2
Ingo Renner [Wed, 16 Jan 2013 00:09:51 +0000 (16:09 -0800)]
[BUGFIX] IRRE forms not using full width

In 4.7 IRRE forms used to be full width of the parent form.
A change introduced in 6.0 now causes the forms to collapse
to less than the full width.

Change-Id: Ie326a339c762c539440e6f70cc51b467e39a666c
Fixes: #44549
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17662
Reviewed-by: Ingo Renner
Tested-by: Ingo Renner
6 years ago[BUGFIX] Instantiate new classes in typo3/* files 56/17656/2
Francois Suter [Tue, 22 Jan 2013 13:11:33 +0000 (14:11 +0100)]
[BUGFIX] Instantiate new classes in typo3/* files

Most typo3/*.php files instantiate the new controllers, but some have
been forgotten. This doesn't break the backend thanks to the legacy
classes mapping, but breaks the XCLASSing mechanism.

Resolves: #44718
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/17650
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Change-Id: Ide89f4053d8cdbdebda638d53bb41269078f4c57
Reviewed-on: https://review.typo3.org/17656
Reviewed-by: Francois Suter
Tested-by: Francois Suter
6 years ago[BUGFIX] ConfigurationUtility loses extension key 01/17601/2
Francois Suter [Sat, 19 Jan 2013 20:56:44 +0000 (21:56 +0100)]
[BUGFIX] ConfigurationUtility loses extension key

The EM's ConfigurationUtility::getCurrentConfiguration() method looks for
the extension key at the wrong place. Rather than using the key
it receives as a parameter, it tries to get it from
$GLOBALS['TYPO3_LOADED_EXT'] where it does not exist.

Releases: 6.0, 6.1
Resolves: #44665
Reviewed-on: https://review.typo3.org/17600
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Change-Id: I45b8577254b21183adeb90cb02a10b40098f6d8c
Reviewed-on: https://review.typo3.org/17601

6 years ago[BUGFIX] array_merge_recursive_overrule: __UNSET for array values 29/17529/4
Sebastian Michaelsen [Tue, 11 Dec 2012 10:43:57 +0000 (11:43 +0100)]
[BUGFIX] array_merge_recursive_overrule: __UNSET for array values

Using __UNSET on keys that hold array values does not unset them.
However the documentation does not mention this restriction.
Therefore this is considered a bug and fixed by this patch.

Resolves: #43874
Releases: 6.1, 6.0, 4.7

Change-Id: Ie9f96c6f608da7e91fec2bc639dba9f3bcc8f426
Reviewed-on: https://review.typo3.org/17529
Reviewed-by: Markus Klein
Reviewed-by: Sebastian Michaelsen
Tested-by: Sebastian Michaelsen
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig
6 years ago[TASK] Remove references to oldstyle Login News (TYPO3_CONF_VARS) 24/17524/2
Sebastian Michaelsen [Mon, 14 Jan 2013 11:16:58 +0000 (12:16 +0100)]
[TASK] Remove references to oldstyle Login News (TYPO3_CONF_VARS)

Adding Login News via
$GLOBALS['TYPO3_CONF_VARS']['BE']['loginNews'] is not longer
supported but there are still references to it in the code that should be
removed.

Resolves: #44506
Releases: 6.0, 6.1

Change-Id: I2c91c3209dc4a1dc55e570e569825acb3167150e
Reviewed-on: https://review.typo3.org/17519
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-on: https://review.typo3.org/17524
Reviewed-by: Wouter Wolters
6 years ago[BUGFIX] Fix incomplete mocking in ResourceStorage test 08/17508/2
Helmut Hummel [Sun, 13 Jan 2013 17:24:51 +0000 (18:24 +0100)]
[BUGFIX] Fix incomplete mocking in ResourceStorage test

Due to a not mocked FileRepository object, a warning
is issued which leads to a failed test.

Add a FileRepository mock and clean up all usage
of the FileRepository in ResourceStorage.

Fixes: #44439
Releases: 6.0, 6.1

Change-Id: I214fce4635d452764bd9edc8e11f863bd76961a6
Reviewed-on: https://review.typo3.org/17508
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Persist files that are updated in ResourceStorage 06/17506/2
Helmut Hummel [Sat, 12 Jan 2013 14:46:39 +0000 (15:46 +0100)]
[BUGFIX] Persist files that are updated in ResourceStorage

When renaming or moving folders all files in that
folder needs to be updated. ResourceStorage handles
that, but the changes to the properties are not
persisted, which leads to inconsistent file records.

Persist updated files using the FileRepository and
clean up the code a bit.

Fixes: #44439
Releases: 6.0, 6.1

Change-Id: I9a21040fdd6741e030d812df165cd33959dd8db1
Reviewed-on: https://review.typo3.org/17478
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/17506

6 years ago[BUGFIX] Use array in check for new CE button 03/17503/2
Jigal van Hemert [Sun, 13 Jan 2013 09:42:41 +0000 (10:42 +0100)]
[BUGFIX] Use array in check for new CE button

After #44470 the content elements in a column are stored in an array.
Checks for the new content element button, etcetera must check that
array instead of counting the elements in the query result that was used
before.

Change-Id: Iea75afd343db82a4950b4a9b7587177940398b2b
Fixes: #44481
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17503
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years agoRevert "[BUGFIX] LocalDriver needs to respect "is_writeable"" 99/17499/2
Helmut Hummel [Sat, 12 Jan 2013 18:27:53 +0000 (19:27 +0100)]
Revert "[BUGFIX] LocalDriver needs to respect "is_writeable""

This change broke the tests

This reverts commit af01ce40933c79162dfb9984d948363fc6199811

Change-Id: I29c9c5893e42278b7e1f645e60874b2cdb20074c
Reviewed-on: https://review.typo3.org/17499
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix typos in stdWrap_crop description 92/17492/2
Markus Klein [Wed, 12 Dec 2012 22:45:09 +0000 (23:45 +0100)]
[BUGFIX] Fix typos in stdWrap_crop description

Fixes: #43919
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: Ib4b447f825122ea069802a7c9139602362430bdc
Reviewed-on: https://review.typo3.org/17492
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Syslog error icons problem 91/17491/2
Tomita Militaru [Wed, 12 Dec 2012 13:31:36 +0000 (15:31 +0200)]
[BUGFIX] Syslog error icons problem

Add an array with the possible error messages and shows
the corresponding icon.

Fixes: #43796
Releases: 6.1, 6.0
Change-Id: I6cbdcdf92147c438a443d29664965bee17c29d51
Reviewed-on: https://review.typo3.org/17491
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Content elements in wrong column in page module 96/17496/2
Oliver Hader [Fri, 11 Jan 2013 17:29:34 +0000 (18:29 +0100)]
[BUGFIX] Content elements in wrong column in page module

If working on workspaces, it might happen that content elements
just appear in the wrong column. The reason is, that live(!)
content elements are selected using a specific column value and
then are overlaid with workspace data.

If the column value has been modified in a workspace, this is
currently just ignored during rendering.

Change-Id: I6669ea096d93269591727b20d92ef5250898900f
Fixes: #44470
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17496
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] BE login shows unaesthetic scrollbars 67/17067/3
Torben Hansen [Mon, 10 Dec 2012 13:34:15 +0000 (14:34 +0100)]
[BUGFIX] BE login shows unaesthetic scrollbars

CSS adjustments for login screen in t3skin

Fixes: #43330
Releases: 6.1, 6.0

Change-Id: Ifeb141ff9963f54e35c26ca41bc73bc12d79b7c2
Reviewed-on: https://review.typo3.org/17067
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] LocalDriver needs to respect "is_writeable" 90/17490/2
Georg Ringer [Thu, 10 Jan 2013 09:37:21 +0000 (10:37 +0100)]
[BUGFIX] LocalDriver needs to respect "is_writeable"

The LocalDriver needs also to respect the flag "is_writeable".
This means: if the flag is not set, no folder/file can be edited/moved...

Change-Id: I6fc1edd452555381388bd5bfaa46dd8241dc853b
Fixes: #44370
Releases: 6.0,6.1
Reviewed-on: https://review.typo3.org/17413
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/17490

6 years ago[BUGFIX] FAL: update wizard fails if file does not exist 89/17489/2
Andreas Wolf [Sat, 17 Nov 2012 16:02:40 +0000 (17:02 +0100)]
[BUGFIX] FAL: update wizard fails if file does not exist

The FAL update wizard throws an exception during migration if a file is
missing. As we cannot do that much about a missing source file, we
should at least not fatal here, but give the user a warning message in
the logs instead.

Change-Id: I3ab0ecd8d8f60e782b7459d7f92f89d2c0a9fd40
Resolves: #42882
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/16533
Reviewed-by: Franz Holzinger
Tested-by: Franz Holzinger
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/17489