Packages/TYPO3.CMS.git
6 years ago[RELEASE] Release of TYPO3 6.0.0alpha1 10/11510/1 TYPO3_6-0-0alpha1
TYPO3 v4 Release Team [Tue, 22 May 2012 22:09:35 +0000 (00:09 +0200)]
[RELEASE] Release of TYPO3 6.0.0alpha1

Change-Id: I68f99111a53217f6b05ac6656b84763051516402

6 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 22 May 2012 09:57:43 +0000 (11:57 +0200)]
[TASK] Raise submodule pointer

Change-Id: I5018a3800a8a3553251ae0a79dfec7e7e5e9cb15
Reviewed-on: http://review.typo3.org/11438
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
6 years ago[BUGFIX] PHP warning when a language pack does not exist
Xavier Perseguers [Wed, 9 May 2012 07:48:05 +0000 (09:48 +0200)]
[BUGFIX] PHP warning when a language pack does not exist

If PHP warnings are not catched, file_get_contents issues a warning
message whenever a file cannot be retrieved.

Change-Id: Ibecfebf5ff4c89ca6c7c43370d87fc4e546a02c1
Fixes: #36976
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/11093
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Add a comment for the require_once in t3lib_error_ErrorHandler
Oliver Klee [Sun, 20 May 2012 16:03:51 +0000 (18:03 +0200)]
[TASK] Add a comment for the require_once in t3lib_error_ErrorHandler

These require_once calls are needed to make the exception classes
available even if the autoloaded is not loaded at this point yet.

The comment point this out and (hopefully) keeps people from deleting
the require_once calls as part of some clean up.

Resolves: #37335
Relates: #23444, #36061

Change-Id: Ie226b67f44ea0c3cbd17fa9e52018dbf8d8b58d4
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11340
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Missing argument 3 for t3lib_DB::exec_SELECTgetRows()
Philipp Gampe [Sun, 20 May 2012 13:45:02 +0000 (15:45 +0200)]
[BUGFIX] Missing argument 3 for t3lib_DB::exec_SELECTgetRows()

Change-Id: I063ff48e2f1d6f9dceaf910405d2f510818120c0
Fixes: #37324
Releases: 6.0
Reviewed-on: http://review.typo3.org/11337
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
6 years ago[BUGFIX] Pagetree: Copying large branches duplicates branch
Steffen Gebert [Sat, 11 Feb 2012 15:52:03 +0000 (16:52 +0100)]
[BUGFIX] Pagetree: Copying large branches duplicates branch

Copying large branches (500+ pages, depending on the server) has a big
problem: The AJAX request is answered too late (after Ext.Direct
timeout), so Ext.Direct will resend the request. This will copy the
branch once again. So the copied branch appears twice after copying.

The whole process fails with a connection timeout error message and the
user has to reload the page tree.

Change-Id: If0307586ec3196c3c3dedde92cfb6aee07bc9064
Resolves: #26993
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8981
Reviewed-by: Stefan Neufeind
Reviewed-by: Stefan Galinski
Reviewed-by: Philipp Gampe
Tested-by: Stefan Galinski
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
6 years ago[BUGFIX] CGL violations FunctionCallArgument in class.browse_links.php
Roland Waldner [Sun, 20 May 2012 12:22:56 +0000 (14:22 +0200)]
[BUGFIX] CGL violations FunctionCallArgument in class.browse_links.php

Fix some CGL violations in class.browse_links.php against rule
"FunctionCallArgumentSpacingNoSpaceAfterComma".

Change-Id: Ie0d3e471cb7ff443269c0d391b3a40752ce29ad3
Resolves: #37327
Releases: 6.0
Reviewed-on: http://review.typo3.org/11328
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] CGL violations FunctionCallArgumentSpacing in alt_clickmenu.php
Roland Waldner [Sun, 20 May 2012 11:57:07 +0000 (13:57 +0200)]
[BUGFIX] CGL violations FunctionCallArgumentSpacing in alt_clickmenu.php

Fix some CGL violations in alt_clickmenu.php against rule
"FunctionCallArgumentSpacingNoSpaceAfterComma".

Change-Id: Ie7b6da34e1ce1a0ecd23aaac29476dde13a7afd8
Resolves: #37323
Releases: 6.0
Reviewed-on: http://review.typo3.org/11323
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up the phpDoc of t3lib_fullsearch
Wouter Wolters [Sun, 20 May 2012 12:10:40 +0000 (14:10 +0200)]
[TASK] Clean up the phpDoc of t3lib_fullsearch

Clean up the phpDoc of t3lib_fullsearch

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I0889c1272feda994e564d28704a6c31b6494c230
Resolves: #37326
Releases: 6.0
Reviewed-on: http://review.typo3.org/11325
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] CGL violations FunctionCallArgumentSpacing in /tests/
Roland Waldner [Sun, 20 May 2012 11:02:01 +0000 (13:02 +0200)]
[BUGFIX] CGL violations FunctionCallArgumentSpacing in /tests/

Fix some CGL violations in /tests/ against rule
"FunctionCallArgumentSpacingNoSpaceAfterComma".

Change-Id: I5a35bf48de79d9f1a7945b2191b5be9bd94146c8
Resolves: #37319
Releases: 6.0
Reviewed-on: http://review.typo3.org/11317
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Properly quote regexp in Install Tool
Jigal van Hemert [Fri, 30 Mar 2012 20:46:39 +0000 (22:46 +0200)]
[BUGFIX] Properly quote regexp in Install Tool

Characters with a special meaning must be properly quoted
if they appear in a regular expression.

Change-Id: I2587acb9d0f61a441be6e13dcaba7b7ca0fc82bc
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #35410
Reviewed-on: http://review.typo3.org/10103
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
6 years ago[BUGFIX] Regression of "better condition in versionOL of t3lib_tstemplate"
andy.grunwald [Wed, 9 May 2012 08:45:56 +0000 (10:45 +0200)]
[BUGFIX] Regression of "better condition in versionOL of t3lib_tstemplate"

versionOL in t3lib_tstemplate can cause a fatal error for
scripts like eID that run in frontend mode, but without a full
blown frontend environment.

The patch replaces the frontend check with a more specific test
for the required methods.

Change-Id: Ib3f9ebf355ee820e5144dd484d9a3a5e7708ebd4
Related: #31139, #25144
Resolves: #36981
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11096
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
6 years ago[FEATURE] Bootstrap: Introduce shutdown and use in autoloader
Christian Kuhn [Thu, 17 May 2012 20:23:57 +0000 (22:23 +0200)]
[FEATURE] Bootstrap: Introduce shutdown and use in autoloader

The patch introduces a shutdown method to the bootstrap that
can be used to perform clean up and shutdown things at the
end of a script run. It is used in the most important entry
scripts like FE, mod.php, cli and backend.

First usage of shutdown() is the autoloader: If new classes are found
during script run, for example because they stick to the extbase naming
scheme and do not have a ext_autoload entry, the autoloader wrote a new
cache file for each class it found. Now, the autoloader remembers that
the cache file should be updated and delays of writing the cache file
until it is unregistered.
This way the full cache entry is only written once during shutdown.

Change-Id: Ibb84a7db65eb28e792c0b5ee9bedec00b29dbbb9
Resolves: #37268
Releases: 6.0
Reviewed-on: http://review.typo3.org/11279
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
6 years ago[TASK] Add unit test for t3lib_div::callUserFunction
Tolleiv Nietsch [Sun, 20 May 2012 07:58:55 +0000 (09:58 +0200)]
[TASK] Add unit test for t3lib_div::callUserFunction

Releates to #36784 which would have brought some basic tests.
This patchset now has full coverage for the entire functionality
of callUserFunction and #36784 can be reduced to its actual purpose.

Change-Id: I02cfe3e963f90aa3c3986e57bdba4a08c6e4c0d5
Resolves: #37317
Releases: 6.0
Reviewed-on: http://review.typo3.org/11316
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
6 years ago[BUGFIX] DB field names exceed max length with 'zzz_deleted'
Tolleiv Nietsch [Wed, 1 Feb 2012 08:30:40 +0000 (09:30 +0100)]
[BUGFIX] DB field names exceed max length with 'zzz_deleted'

MySQL allows a maximum of 64 characters for column and table names.
When prefixing them with 'zzz_deleted' this limit might be reached
by accident. (e.g. with
'zzz_deleted_tx_powermail_tellAFriendForm_receiverEmailContentField')

The patch avoids the overstepping 64 characters.

At the same time the prefixed and shortened field names are more
likely to have the same name, therefore the names are cut
from the beginning.

Change-Id: Id423a5bc0bee8509c6da89793812b1399d6a14c0
Fixes: #33580
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/8791
Reviewed-by: Oliver Klee
Reviewed-by: Xavier Perseguers
Reviewed-by: Ingo Pfennigstorf
Tested-by: Ingo Pfennigstorf
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
6 years ago[TASK] Add unit tests for string related functions in t3lib_div
Tolleiv Nietsch [Sun, 20 May 2012 07:14:00 +0000 (09:14 +0200)]
[TASK] Add unit tests for string related functions in t3lib_div

Adds tests for htmlspecialchars_decode, deHSCentities, slashJS,
rawUrlEncodeJS, rawUrlEncodeFP, strtoupper and strtolower.

Change-Id: I1c68da9ac6bb187c1db559da03a2de6b20c4ab46
Resolves: #37315
Releases: 6.0
Reviewed-on: http://review.typo3.org/11315
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
6 years ago[BUGFIX] Reduce spacing CGL violations in /typo3/sysext/
Roland Waldner [Sun, 20 May 2012 05:52:33 +0000 (07:52 +0200)]
[BUGFIX] Reduce spacing CGL violations in /typo3/sysext/

There were a lot spacing CGL violations in /typo3/sysext/.
These will be reduced by this commit.

Change-Id: Iae4dc7bfbca79f5e71446d850eebfceeb20e4a18
Resolves: #37310
Releases: 6.0
Reviewed-on: http://review.typo3.org/11311
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Reduce spacing CGL violations in /t3lib/
Roland Waldner [Sat, 19 May 2012 21:13:29 +0000 (23:13 +0200)]
[BUGFIX] Reduce spacing CGL violations in /t3lib/

There were a lot spacing CGL violations in /t3lib/.
These will be reduced by this commit.

Change-Id: I66981be01ecb4f289de2ccbc0363d2f02bd98f6a
Resolves: #37309
Releases: 6.0
Reviewed-on: http://review.typo3.org/11310
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Reduce spacing CGL violations in /typo3/
Roland Waldner [Sat, 19 May 2012 20:57:26 +0000 (22:57 +0200)]
[BUGFIX] Reduce spacing CGL violations in /typo3/

There were a lot spacing CGL violations in /typo3/.
These will be reduced by this commit.

As there are really a lot of violations this fixes
these, which are NOT in /typo3/sysext/.

Change-Id: I71184548d54880905407ab6a80ac3feeee1123ee
Resolves: #37308
Releases: 6.0
Reviewed-on: http://review.typo3.org/11309
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Reduce spacing CGL violations in class.tslib_menu.php
Roland Waldner [Sat, 19 May 2012 20:38:14 +0000 (22:38 +0200)]
[BUGFIX] Reduce spacing CGL violations in class.tslib_menu.php

There were a lot spacing CGL violations in
class.tslib_menu.php. These will be reduced by
this commit.

Change-Id: I0c925ad2706d597906e830464f22a7ee939c6e98
Resolves: #37307
Releases: 6.0
Reviewed-on: http://review.typo3.org/11308
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Reduce spacing CGL violations in tslib_fe.php
Roland Waldner [Sat, 19 May 2012 19:58:07 +0000 (21:58 +0200)]
[BUGFIX] Reduce spacing CGL violations in tslib_fe.php

There were a lot spacing CGL violations in
tslib_fe.php. These will be reduced by this commit.

Change-Id: Id105b331df8a7970b52113228a6ab3bfda974e4e
Resolves: #37304
Releases: 6.0
Reviewed-on: http://review.typo3.org/11305
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up the phpDoc of t3lib_div
Wouter Wolters [Sat, 19 May 2012 20:02:35 +0000 (22:02 +0200)]
[TASK] Clean up the phpDoc of t3lib_div

Clean up the phpDoc of t3lib_div

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: I682d552d7cbf7ee3882f93d608390a50d57b1c41
Resolves: #37305
Releases: 6.0
Reviewed-on: http://review.typo3.org/11304
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
6 years ago[BUGFIX] Reduce spacing CGL violations in class.tx_impexp.php
Roland Waldner [Sat, 19 May 2012 20:21:43 +0000 (22:21 +0200)]
[BUGFIX] Reduce spacing CGL violations in class.tx_impexp.php

There were a lot spacing CGL violations in
class.tx_impexp.php. These will be reduced
by this commit.

Change-Id: I075a5ef7df9f2f33d89f90db409bc788a4786410
Resolves: #37306
Releases: 6.0
Reviewed-on: http://review.typo3.org/11306
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Add unittests for array related functions in t3lib_div
Tolleiv Nietsch [Sat, 19 May 2012 13:03:31 +0000 (15:03 +0200)]
[TASK] Add unittests for array related functions in t3lib_div

Some of the most basic functions should be covered with unit tests.

The change creates tests for inArray, array_merge, remapArrayKeys
and keepItemsInArray.

Change-Id: Id57148bc0d0418ed7308b9647c63af2d82ec94f2
Resolves: #37299
Releases: 6.0
Reviewed-on: http://review.typo3.org/11298
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
6 years ago[TASK] Add unittests for t3lib_div::formatSize
Tolleiv Nietsch [Sat, 19 May 2012 11:49:26 +0000 (13:49 +0200)]
[TASK] Add unittests for t3lib_div::formatSize

Some of the most basic functions should be covered with unit tests.

Change-Id: If9466ebdf9d7177de298db14c5460cddfcc5cbe1
Resolves: #37297
Releases: 6.0
Reviewed-on: http://review.typo3.org/11296
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
6 years ago[BUGFIX] Reduce spacing CGL violations in alt_clickmenu.php
Roland Waldner [Sat, 19 May 2012 19:41:55 +0000 (21:41 +0200)]
[BUGFIX] Reduce spacing CGL violations in alt_clickmenu.php

There were a lot spacing CGL violations in
/typo3/alt_clickmenu.php. These will be reduced
by this commit.

Change-Id: I5c209b0f05843412820d81f317ef7fafe19cadfc
Resolves: #37303
Releases: 6.0
Reviewed-on: http://review.typo3.org/11303
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Fri, 18 May 2012 20:28:49 +0000 (22:28 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_tsfebeuserauth.php
* t3lib/class.t3lib_tsparser.php
* t3lib/class.t3lib_tsparser_ext.php
* t3lib/class.t3lib_tsparser_tsconfig.php
* t3lib/class.t3lib_tsstyleconfig.php
* t3lib/class.t3lib_tstemplate.php
* t3lib/class.t3lib_xml.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I312660e9da1964cff90b3998155d77bb3f4f0edd
Resolves: #37291
Releases: 6.0
Reviewed-on: http://review.typo3.org/11289
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Fri, 18 May 2012 19:18:11 +0000 (21:18 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_svbase.php
* t3lib/class.t3lib_syntaxhl.php
* t3lib/class.t3lib_tceforms_fe.php
* t3lib/class.t3lib_timetrack.php
* t3lib/class.t3lib_timetracknull.php
* t3lib/class.t3lib_transferdata.php
* t3lib/class.t3lib_transl8tools.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I30f3f6819505751ff9339e0584ee58bff2944cc8
Resolves: #37290
Releases: 6.0
Reviewed-on: http://review.typo3.org/11288
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up the phpDoc of t3lib_stdgraphic
Wouter Wolters [Fri, 18 May 2012 18:30:34 +0000 (20:30 +0200)]
[TASK] Clean up the phpDoc of t3lib_stdgraphic

Clean up the phpDoc of t3lib_stdgraphic

So I made a patch doing mostly:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)
* CGLify method signatures (the first line of the method)

Change-Id: Ic5797a1a33e75d1f8f474e855ba78198f4350c36
Resolves: #37289
Releases: 6.0
Reviewed-on: http://review.typo3.org/11287
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Fri, 18 May 2012 16:55:28 +0000 (18:55 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_refindex.php
* t3lib/class.t3lib_scbase.php
* t3lib/class.t3lib_softrefproc.php
* t3lib/class.t3lib_sqlparser.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I1297ce2e244c7d19c590537d93b090f75a6043ce
Resolves: #37288
Releases: 6.0
Reviewed-on: http://review.typo3.org/11286
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Whitespace CGL
Felix Kopp [Sat, 19 May 2012 11:19:13 +0000 (13:19 +0200)]
[TASK] Whitespace CGL

Corrects several whitespace related issues.

Special focus lies on files
* typo3/class.db_list_extra.inc (127 violations)
* typo3/template.php (148 violations)
* EXT: rtehtmlarea/class.tx_rtehtmlarea_base.php (129 violations)

Sonar / metrics terms to be improved:

* OpeningFunctionBraceKernighanRitchieSpaceBeforeBrace
* FunctionCallArgumentSpacingSpaceBeforeComma
* FunctionCallArgumentSpacingTooMuchSpaceAfterComma
* SemicolonSpacingIncorrect

Change-Id: I18a971c64e62ad976d9da5daf6d9a4d5aa463425
Fixes: #37295
Releases: 6.0
Reviewed-on: http://review.typo3.org/11295
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Wrong DB fields usage in TCEmain
Felix Nagel [Wed, 16 May 2012 13:11:52 +0000 (15:11 +0200)]
[BUGFIX] Wrong DB fields usage in TCEmain

The fix for issue #35260 introduced a new bug in method
t3lib_TCEmain::getPreviousLocalizedRecordUid() by adding a
field in a query in the wrong place. In particular, this breaks
the localization of tt_content elements used with IRRE.

This patch fixes the problem by separating the list of fields
used for selecting and for sorting.

Change-Id: I66101071a0320b7c2b1826c3422e7bf99671a122
Fixes: #37221
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11250
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Philipp Gampe
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[BUGFIX] Fix CGL violations "SemicolonSpacingIncorrect"
Roland Waldner [Thu, 17 May 2012 18:48:09 +0000 (20:48 +0200)]
[BUGFIX] Fix CGL violations "SemicolonSpacingIncorrect"

Change-Id: Id5bf3756e215b50eb9d789648b2bca57bb8bb712
Resolves: #37264
Releases: 6.0
Reviewed-on: http://review.typo3.org/11277
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Bootstrap: Exit cli with valid keys if no key is given
Christian Kuhn [Wed, 16 May 2012 20:19:02 +0000 (22:19 +0200)]
[TASK] Bootstrap: Exit cli with valid keys if no key is given

If no cli key is given, cli_dispatch.phpsh exits with a generic
error message that a key must supplied to run the script. If a
key is given, but it is no registered cli script, the script
exits with a list of valid keys.

The patch removes the first test to also show the list of valid
keys if there is no key at all and adapts the error message a bit.

Change-Id: I4d356a1837218aaeb92ef85d9c5b8833b2737e08
Resolves: #37238
Releases: 6.0
Reviewed-on: http://review.typo3.org/11263
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Klee
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Reduce CGL violations in class.tx_install.php
Roland Waldner [Thu, 17 May 2012 13:40:20 +0000 (15:40 +0200)]
[BUGFIX] Reduce CGL violations in class.tx_install.php

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in typo3/sysext/install/mod/class.tx_install.php.

There are over 500 violations against this rule. This is fixed/reduced.

Change-Id: Iad13d9b4f2bad80cb7921ae44f46c3723f82cc20
Resolves: #37254
Releases: 6.0
Reviewed-on: http://review.typo3.org/11274
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Reduce CGL violations in class.tslib_fe.php
Roland Waldner [Thu, 17 May 2012 12:29:52 +0000 (14:29 +0200)]
[BUGFIX] Reduce CGL violations in class.tslib_fe.php

Fix/Reduce CGL violations "FunctionCallArgumentSpacingNoSpaceAfterComma"
in class.tslib_fe.php.

There are over 500 violations against this rule. This is fixed/reduced.

Change-Id: Ib4a8d95b99e06e1342a4f5c5a53df5582a9b7d86
Resolves: #37253
Releases: 6.0
Reviewed-on: http://review.typo3.org/11272
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Thu, 17 May 2012 11:13:35 +0000 (13:13 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_parsehtml_proc.php
* t3lib/class.t3lib_positionmap.php
* t3lib/class.t3lib_querygenerator.php
* t3lib/class.t3lib_readmail.php
* t3lib/class.t3lib_recordlist.php
* t3lib/class.t3lib_registry.php
* t3lib/class.t3lib_rteapi.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I42a5b48a8eda5d77605a963ba8168d1d4342fa5f
Resolves: #37252
Releases: 6.0
Reviewed-on: http://review.typo3.org/11271
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Remove invalid/unused FAL TCA config
Ingmar Schlecht [Thu, 17 May 2012 10:46:03 +0000 (12:46 +0200)]
[FEATURE] Remove invalid/unused FAL TCA config

Change-Id: I255e5067c3d2608870e4b35d35faf305af0f6b22
Releases: 6.0
Resolves: #37250
Reviewed-on: http://review.typo3.org/11269
Reviewed-by: Ingmar Schlecht
Tested-by: Ingmar Schlecht
6 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Thu, 17 May 2012 00:12:48 +0000 (02:12 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_pagerenderer.php
* t3lib/class.t3lib_pagetree.php
* t3lib/class.t3lib_parsehtml.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I56ffee774456d7712cf68cbd74652aad1b0f07bb
Resolves: #37242
Releases: 6.0
Reviewed-on: http://review.typo3.org/11265
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] CGL cleanup in bootstrap
Christian Kuhn [Wed, 16 May 2012 19:30:30 +0000 (21:30 +0200)]
[TASK] CGL cleanup in bootstrap

Fix some cgl flaws that slipped through during the bootstrap refactoring.

Change-Id: Id2d122d0afdb3e0e1091a13eeecf62c1c67236f4
Resolves: #37236
Releases: 6.0
Reviewed-on: http://review.typo3.org/11261
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_page
Wouter Wolters [Wed, 16 May 2012 18:17:49 +0000 (20:17 +0200)]
[TASK] Clean up phpDoc comments in t3lib_page

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ibbb16ff84edf3dfae9ca4152b62211f37afb4cda
Resolves: #37235
Releases: 6.0
Reviewed-on: http://review.typo3.org/11256
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Bootstrap: Disentangle cli and install from init.php
Christian Kuhn [Wed, 9 May 2012 19:27:53 +0000 (21:27 +0200)]
[TASK] Bootstrap: Disentangle cli and install from init.php

Extract code from init.php and put it to methods in Bootstrap.php.
Additionally, cli_dispatch and install/index.php do not require
init.php anymore and have a uncoupled bootstrap now.

There is still room for improvement,
this patch is just another intermediate step.

Change-Id: I5c6d84b8acb7760c8a77f192b2b5ba063b417b0d
Resolves: #37130
Releases: 6.0
Reviewed-on: http://review.typo3.org/11153
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] BE preview for non standard SSL port
Bas van de Wiel [Tue, 15 May 2012 17:56:50 +0000 (19:56 +0200)]
[FEATURE] BE preview for non standard SSL port

Make sure port number gets appended when backend
is locked to SSL and port number is set to something
other than the standard 443.

Change-Id: I5fcb04fa0e0b8cbde3f19e9c54366e11d14fdf8e
Fixes: #37076
Releases: 6.0
Reviewed-on: http://review.typo3.org/11225
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove old compatibility constructor
Christian Kuhn [Wed, 16 May 2012 09:03:06 +0000 (11:03 +0200)]
[TASK] Remove old compatibility constructor

typo3/class.show_rechis.inc was forgotten
during the cleanup round for 6.0

Change-Id: I1805b0845fa4e9f44ec2ec37cbceb02bcdcd015d
Resolves: #37207
Releases: 6.0
Reviewed-on: http://review.typo3.org/11231
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove deprecated class.alt_menu_functions.inc
Christian Kuhn [Wed, 16 May 2012 08:57:43 +0000 (10:57 +0200)]
[TASK] Remove deprecated class.alt_menu_functions.inc

Change-Id: I941fc2dfd028235ee0988d7e96cb374333987ae8
Resolves: #37206
Releases: 6.0
Reviewed-on: http://review.typo3.org/11230
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Fix whitespace in t3lib_befunc
Christian Kuhn [Wed, 16 May 2012 08:41:37 +0000 (10:41 +0200)]
[TASK] Fix whitespace in t3lib_befunc

This made jenkins unhappy with
https://review.typo3.org/#/c/11225/3

Change-Id: I02ae564546eea8982300e2c42b9abe72c463bb51
Resolves: #37205
Releases: 6.0
Reviewed-on: http://review.typo3.org/11229
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Sun, 13 May 2012 12:10:44 +0000 (14:10 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_formmail.php
* t3lib/class.t3lib_frontendedit.php
* t3lib/class.t3lib_iconworks.php
* t3lib/class.t3lib_install.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I48a245d96f760c8957bebc8970cbe76446287084
Resolves: #37137
Releases: 6.0
Reviewed-on: http://review.typo3.org/11154
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib classes
Wouter Wolters [Tue, 15 May 2012 21:52:49 +0000 (23:52 +0200)]
[TASK] Clean up phpDoc comments in t3lib classes

Clean up phpDoc comments for the following classes:

* t3lib/class.t3lib_install_sql.php
* t3lib/class.t3lib_loaddbgroup.php
* t3lib/class.t3lib_loadmodules.php
* t3lib/class.t3lib_lock.php
* t3lib/class.t3lib_modsettings.php

Clean up provides:

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I0465b7d41e492ae4746f0649b676eae4ad2a145a
Resolves: #37202
Releases: 6.0
Reviewed-on: http://review.typo3.org/11228
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Missing bottom margin in the page tree
Stefan Galinski [Fri, 13 Apr 2012 14:01:04 +0000 (16:01 +0200)]
[BUGFIX] Missing bottom margin in the page tree

This fixes the UI issue with the deletion overlay and drag&drop
with nodes at the very bottom of the page tree viewport too.

Change-Id: I5cee23ea9441fcd1910a998547772bc3f2e53fb5
Fixes: #35182
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/10411
Reviewed-by: Philipp Gampe
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[Task] CGL Cleanup LogicalOperatorSpacing*
Stefano Kowalke [Tue, 15 May 2012 10:16:51 +0000 (12:16 +0200)]
[Task] CGL Cleanup LogicalOperatorSpacing*

This is a follow-up to 37142.
It removes the last violation for this topic.

Change-Id: Ia788655833a5ab3778ce0ca16d3105f4a479fd6a
Fixes: #37178
Releases: 6.0
Reviewed-on: http://review.typo3.org/11204
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Re-enable indexed_search $TCA for index_config
Felix Kopp [Fri, 11 May 2012 13:31:48 +0000 (15:31 +0200)]
[BUGFIX] Re-enable indexed_search $TCA for index_config

EXT: indexed_search $TCA for table index_config is only loaded
when EXT: crawler is installed but $TCA must always be included.
Removes condition to limit $TCA inclusion.

Change-Id: I9768ae18c40fa95084fbca54880ffc7b31e1f0a1
Fixes: #32815
Releases: 4.7, 6.0
Reviewed-on: http://review.typo3.org/11145
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] Wrong label reference for backend_layout
Markus Klein [Mon, 14 May 2012 12:37:08 +0000 (14:37 +0200)]
[BUGFIX] Wrong label reference for backend_layout

tbl_pages.php references non-existing labels.
Actually they have different names.

Change-Id: I9b89fd5dcc7355480e534c2b48130a8461f03ef4
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #37158
Reviewed-on: http://review.typo3.org/11178
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Pagetree doesn't expands to the last saved state
Stefan Galinski [Thu, 10 May 2012 17:51:11 +0000 (19:51 +0200)]
[BUGFIX] Pagetree doesn't expands to the last saved state

Change-Id: I0518d9dd06c7d126dfe5d885e4b2751b7e7462b6
Releases: 6.0, 4.7, 4.6, 4.5
Fixes: #36459
Reviewed-on: http://review.typo3.org/11138
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Fix 2 CGL violations in alt_shortcut.php.
Roland Waldner [Sun, 13 May 2012 17:15:32 +0000 (19:15 +0200)]
[BUGFIX] Fix 2 CGL violations in alt_shortcut.php.

on metrics.typo3.org the violations drilldown says
that is 1 violation against
"FunctionCallArgumentSpacingNoSpaceAfterEquals"
and 1 violation against
"FunctionCallArgumentSpacingNoSpaceBeforeEquals":
both in typo3/alt_shortcut.php.

this should be fixed.

after that i guess these 2 coding guidline sniffs
could be activated in the CI-server jobs?

Change-Id: I4ff9d4f57f97e2f502088d8d6026544615331cd6
Fixes: #37139
Releases: 6.0
Reviewed-on: http://review.typo3.org/11157
Reviewed-by: Roland Waldner
Tested-by: Roland Waldner
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] CGL:ArrayBracketSpacingSpaceBeforeBracket
Roland Waldner [Sun, 13 May 2012 17:39:41 +0000 (19:39 +0200)]
[BUGFIX] CGL:ArrayBracketSpacingSpaceBeforeBracket

on metrics.typo3.org the violations drilldown
says that are 2 violations against
"ArrayBracketSpacingSpaceBeforeBracket" in
tests/Unit/t3lib/utility/
class.t3lib_utility_mailTest.php.

this should be fixed.

after that i guess this coding guidline sniff
could be activated in the CI-server jobs?

Change-Id: I6fb7c6b67611ebac903466b28c7c473b3d36ee51
Fixes: #37141
Releases: 6.0
Reviewed-on: http://review.typo3.org/11159
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Fix 4 CGL viol.: LogicalOperatorSpacing*
Roland Waldner [Sun, 13 May 2012 19:19:21 +0000 (21:19 +0200)]
[BUGFIX] Fix 4 CGL viol.: LogicalOperatorSpacing*

on metrics.typo3.org the violations drilldown
says that are some violations against:

LogicalOperatorSpacingNoSpaceBefore (19)
LogicalOperatorSpacingNoSpaceAfter (18)
LogicalOperatorSpacingTooMuchSpaceAfter (17)
LogicalOperatorSpacingTooMuchSpaceBefore (6)

this should be fixed.

after that i guess these coding guidline sniffs
could be activated in the CI-server jobs?

Change-Id: Iffe732fdb94992f814dfaa8e34ccb04d71d8bd7d
Fixes: #37142
Releases: 6.0
Reviewed-on: http://review.typo3.org/11160
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Add unittests for t3lib_div::*List functions
Tolleiv Nietsch [Tue, 8 May 2012 23:35:24 +0000 (01:35 +0200)]
[TASK] Add unittests for t3lib_div::*List functions

Some of the most basic functions should be covered with unit tests.

The change creates tests for inList, expandList, rmFromList
and uniqueList.

Change-Id: I0fd1e47d7aec96e950b69b4c44898e55920ff4fd
Resolves: #36968
Releases: 6.0
Reviewed-on: http://review.typo3.org/11089
Reviewed-by: Oliver Klee
Tested-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Allow camelCased class names in ext_autoload
Christian Kuhn [Fri, 11 May 2012 17:52:04 +0000 (19:52 +0200)]
[FEATURE] Allow camelCased class names in ext_autoload

Remove the hurdle that class names in ext_autoload (the key part of
the returned array) have to be lower cased.

The patch adds two tests, the first one expects that a case sensitive
class name in ext_autoload.php in actually lowercases before it is
written to the autoload cache file. It fails if the autoloader patch
is not applied.
The second tests that camel cased classes can be successfully autoloaded.

Change-Id: I2ccf916d43a288a520f6f89e9002bdc4df2da0b2
Resolves: #37110
Releases: 6.0
Reviewed-on: http://review.typo3.org/11148
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Philipp Gampe
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[FEATURE] Add Progress bar for task progress
Ingo Renner [Wed, 2 May 2012 21:03:45 +0000 (23:03 +0200)]
[FEATURE] Add Progress bar for task progress

Some tasks may want to provide the user with information about how
far progress of their jobs has come.

Currently there is no way to do this in a nice way. The existing
method getAdditionalInformation() does not allow to output HTML.

Fixes: #36802
Releases: 6.0
Change-Id: I86877b3a3ec70e8c6ef5deae7e54442c35afada3
Reviewed-on: http://review.typo3.org/10946
Reviewed-by: Philipp Gampe
Reviewed-by: Nikolas Hagelstein
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Page module content element min-width (CSS)
Felix Kopp [Fri, 13 Apr 2012 10:39:36 +0000 (12:39 +0200)]
[BUGFIX] Page module content element min-width (CSS)

Adds min-width to content elements in page backend module
to fix problem with line breaking icons.

Change-Id: Id66622c91433782e0813b6fb20097fa7a0c48793
Fixes: #35962
Releases: 6.0
Reviewed-on: http://review.typo3.org/10390
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
6 years ago[Task] Replace space indent into tab indent
Thorsten Kahler [Thu, 10 May 2012 13:45:49 +0000 (15:45 +0200)]
[Task] Replace space indent into tab indent

CGL cleanup: this patch replaces a space indentation in two SQL
statements with tabs.

Change-Id: I88d4461a635fcadb3725a9c5178b439298356374
Resolves: #36871
Related: #37020
Releases: 6.0
Reviewed-on: http://review.typo3.org/11128
Reviewed-by: Thorsten Kahler
Tested-by: Thorsten Kahler
6 years ago[Task] Change whitespaces in indentions into tabs
Stefano Kowalke [Wed, 9 May 2012 20:44:46 +0000 (22:44 +0200)]
[Task] Change whitespaces in indentions into tabs

This is a follow up to #36871.
Some whitespace indentions came back into core.
This patch removes them.

Change-Id: Iabc8eb2fed79ae6de8e8e9e12fcdb7a5bcb65a40
Related: #36871
Resolves: #37020
Releases: 6.0
Reviewed-on: http://review.typo3.org/11120
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Page cache expiry calculation fails
Francois Suter [Wed, 4 Apr 2012 13:21:52 +0000 (15:21 +0200)]
[BUGFIX] Page cache expiry calculation fails

The calculation of the page cache expirationy timestamp based on
property config.cache.xx = table:yy fails in some specific
scenarios, name when there are records having either a start time
in the future but no end time, or an end time in the future
and no start time. Contrary to what is being done so far, calculation
must be performed separately for each time field to avoid
interferences.

Change-Id: I4e4e259083a10f7125760d14ede11ff6a68022fe
Fixes: #35684
Releases: 6.0, 4.7, 4.6
Reviewed-on: http://review.typo3.org/10156
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Xavier Perseguers
Reviewed-by: Francois Suter
Tested-by: Francois Suter
6 years ago[BUGFIX] Regression: SQL error inserting tables for statictemplates
Philipp Gampe [Fri, 9 Mar 2012 14:13:00 +0000 (15:13 +0100)]
[BUGFIX] Regression: SQL error inserting tables for statictemplates

Removing one column was forgotten which results in an SQL error while
inserting the static data.

Change-Id: Ia54b7fc3121f6a50620d64223d610d633b3c76f0
Fixes: #34692
Releases: 4.7,4.8
Reviewed-on: http://review.typo3.org/9516
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Tested-by: Oliver Hader
Reviewed-by: Sebastian Fischer
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[TASK] Refactor t3lib_mail_Mailer and add unit tests
Helmut Hummel [Tue, 8 May 2012 07:40:38 +0000 (09:40 +0200)]
[TASK] Refactor t3lib_mail_Mailer and add unit tests

This change also cleans up some comments and the existing unit test.

Change-Id: Ifb80b7b6f70d06f6531656c579e673a0b0e5ad0b
Resolves: #36942
Releases: 6.0
Reviewed-on: http://review.typo3.org/11068
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[FEATURE] Enable further fields which are used for the suggest wizard
Franz Koch [Wed, 2 May 2012 14:51:53 +0000 (16:51 +0200)]
[FEATURE] Enable further fields which are used for the suggest wizard

Currently the suggest wizard only searches through the label fields
of the records. In some setups other data might be useful to find
records.

The patch adds an configuration option to extend the wizard configuration
to include further fields into the search.

Change-Id: I14e88912a664195467502678eedb3bcdb9e4cf5f
Resolves: #36780
Releases: 6.0
Reviewed-on: http://review.typo3.org/10930
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[TASK] Remove page related icons from docHeader in page/list
Felix Kopp [Fri, 20 Apr 2012 09:58:04 +0000 (11:58 +0200)]
[TASK] Remove page related icons from docHeader in page/list

Removes page action related icons from the docHeader in work area
within page module:

* Create new page
* Move page
* Page history

and within list module:

* Up one level
* Hide/unhide
* Move page

Also removes "New content element" from page, these are added to columns.

Change-Id: I6bf996437e7af6e2149e6962990af2580655eced
Fixes: #34705
Releases: 6.0
Reviewed-on: http://review.typo3.org/10115
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] CE with "All languages" isn't shown in Page module
Georg Ringer [Fri, 23 Mar 2012 11:12:57 +0000 (12:12 +0100)]
[BUGFIX] CE with "All languages" isn't shown in Page module

The page module should also list the content elements
with language set to "All"

Change-Id: I6d8aaf4829a70b3945508884d9a09cf23d1e4842
Resolves: #24087
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9840
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Andreas Otto
Tested-by: Andreas Otto
Reviewed-by: Max Roesch
Tested-by: Max Roesch
Tested-by: Klaus Weidenbach
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] use fileInfo functions instead of mime_content_type
Jigal van Hemert [Tue, 1 May 2012 05:58:57 +0000 (07:58 +0200)]
[BUGFIX] use fileInfo functions instead of mime_content_type

FAL needs mime type info. Use fileInfo functions here and make
fileinfo PHP extension mandatory.

Change-Id: If6fc39d4b42e0264927ecf6918e7deeb7ef9823c
Fixes: #36706
Releases: 6.0
Reviewed-on: http://review.typo3.org/10914
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
6 years ago[BUGFIX] Check if user is allowed to paste page to pagetree
Max Roesch [Sat, 14 Apr 2012 17:41:48 +0000 (19:41 +0200)]
[BUGFIX] Check if user is allowed to paste page to pagetree

The user rights have checks for new / edit / delete, but paste was missing
leading to an error. Page actions 'paste into' and 'page after' now checks
if the user has rights for adding new pages to the current page.

Change-Id: Ief80a511d61ba386d667c62263d6f5335d1c87b8
Fixes: #33546
Releases: 4.5, 4.6, 4.7, 6.0
Reviewed-on: http://review.typo3.org/10483
Reviewed-by: Kilian Hann
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Custom Swift_Transport impossible
Georg Ringer [Mon, 7 May 2012 21:20:38 +0000 (23:20 +0200)]
[BUGFIX] Custom Swift_Transport impossible

Because of using a wrong variable for checking,
it is impossible to use a custom Swift_Transport
implementation.

Change-Id: Id1a337581642414ff8007de06e7d2e7df153cd79
Resolves: #36937
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/11062
Reviewed-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Remove unreachable cli code in typo3/init.php
Christian Kuhn [Mon, 7 May 2012 21:06:48 +0000 (23:06 +0200)]
[TASK] Remove unreachable cli code in typo3/init.php

This cli process code at the end of typo3/init.php could never be
reached since valid keys are already checked before and 'status' is
not registered as valid key. This code snipped is dead for a long time
now and did not work for ages. The information was semi useful and
undocumented. It is removed without substitution.

Change-Id: I97db67b18e414ca2b75ae9fcac2a1e892fad2a26
Resolves: #36936
Releases: 6.0
Reviewed-on: http://review.typo3.org/11061
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Remove superfluous LF in install/index.php
Christian Kuhn [Mon, 7 May 2012 20:38:49 +0000 (22:38 +0200)]
[BUGFIX] Remove superfluous LF in install/index.php

The constant refactoring of #36889 introduced a minor issue with
not already defined constants early in install/index.php. The
constant access is not really needed anyway, so it is removed now.

Change-Id: Ic16fbb4106d8773b94bc2c4aa7ecc937e19ab4d2
Related: #36889
Resolves: #36935
Releases: 6.0
Reviewed-on: http://review.typo3.org/11060
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_foldertree
Wouter Wolters [Mon, 7 May 2012 19:00:15 +0000 (21:00 +0200)]
[TASK] Clean up phpDoc comments in t3lib_foldertree

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I22b49acdb7e45be062719f6f736229ebc16a88ca
Resolves: #36933
Releases: 6.0
Reviewed-on: http://review.typo3.org/11058
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_flexformtools
Wouter Wolters [Mon, 7 May 2012 18:53:22 +0000 (20:53 +0200)]
[TASK] Clean up phpDoc comments in t3lib_flexformtools

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: If970314ff552ae1b64469ea2ecca2052dc70987e
Resolves: #36932
Releases: 6.0
Reviewed-on: http://review.typo3.org/11057
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_flashmessagequeue
Wouter Wolters [Mon, 7 May 2012 18:42:12 +0000 (20:42 +0200)]
[TASK] Clean up phpDoc comments in t3lib_flashmessagequeue

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I199f1cf186402c354ca0c2482c006f862409a1de
Resolves: #36931
Releases: 6.0
Reviewed-on: http://review.typo3.org/11056
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_flashmessage
Wouter Wolters [Mon, 7 May 2012 18:37:50 +0000 (20:37 +0200)]
[TASK] Clean up phpDoc comments in t3lib_flashmessage

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I13b0b178fe06a4a1d331b8365401229a58d07b48
Resolves: #36929
Releases: 6.0
Reviewed-on: http://review.typo3.org/11055
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_extobjbase
Wouter Wolters [Mon, 7 May 2012 18:34:28 +0000 (20:34 +0200)]
[TASK] Clean up phpDoc comments in t3lib_extobjbase

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ie27db5a6601a73459fa07e5a191d6b887a65242e
Resolves: #36928
Releases: 6.0
Reviewed-on: http://review.typo3.org/11054
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_diff
Wouter Wolters [Sun, 6 May 2012 21:43:12 +0000 (23:43 +0200)]
[TASK] Clean up phpDoc comments in t3lib_diff

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I4399c4c4d2a4eca02e40c46133ee07b6ba3d5348
Resolves: #36902
Releases: 6.0
Reviewed-on: http://review.typo3.org/11042
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_cs
Wouter Wolters [Sun, 6 May 2012 20:43:36 +0000 (22:43 +0200)]
[TASK] Clean up phpDoc comments in t3lib_cs

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I12ebcbd0014121369c6a93e63dba137774e7c5bb
Resolves: #36897
Releases: 6.0
Reviewed-on: http://review.typo3.org/11040
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_extmgm
Wouter Wolters [Mon, 7 May 2012 17:04:17 +0000 (19:04 +0200)]
[TASK] Clean up phpDoc comments in t3lib_extmgm

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ib685cbbf39d9f025acc222116cf83ed49bf55867
Resolves: #36927
Releases: 6.0
Reviewed-on: http://review.typo3.org/11053
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[!!!][TASK] Bootstrap: Central constants and path handling
Christian Kuhn [Sat, 5 May 2012 14:26:47 +0000 (16:26 +0200)]
[!!!][TASK] Bootstrap: Central constants and path handling

Introduce a class to define main constants and all basic
path evaluations at an early point in bootstrap.

The patch streamlines a lot of the duplicated code for the different
entry points to TYPO3 and moves especially the path handling to a
well documented central location.

Until now, it was documented that is is possible to define own names
for the directories "typo3/", "tslib", "typo3conf/" and "t3lib/".
This never worked without core hacks and was probably never used in
production by anyone for that reason.
This feature is now officially dropped.

Change-Id: Id1ec1082a2572f20500c23357ef5fdbdb05c8498
Resolves: #36889
Releases: 6.0
Reviewed-on: http://review.typo3.org/11030
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_clipboard
Wouter Wolters [Sun, 6 May 2012 18:53:07 +0000 (20:53 +0200)]
[TASK] Clean up phpDoc comments in t3lib_clipboard

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I599ecfd602da9ebc4a7778eb65701a1b4c6dfba2
Resolves: #36895
Releases: 6.0
Reviewed-on: http://review.typo3.org/11034
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_befunc
Wouter Wolters [Sun, 6 May 2012 13:24:42 +0000 (15:24 +0200)]
[TASK] Clean up phpDoc comments in t3lib_befunc

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Iab137d8c601aa543abdd5dcf4aeae55454a77fd4
Resolves: #36886
Releases: 6.0
Reviewed-on: http://review.typo3.org/11028
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_db
Wouter Wolters [Sun, 6 May 2012 21:29:24 +0000 (23:29 +0200)]
[TASK] Clean up phpDoc comments in t3lib_db

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I8a8b4340a568bde06eaf5bd0de8c654eebdcf8dd
Resolves: #36900
Releases: 6.0
Reviewed-on: http://review.typo3.org/11041
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Clean up phpDoc comments in t3lib_extfilefunc
Wouter Wolters [Mon, 7 May 2012 16:42:15 +0000 (18:42 +0200)]
[TASK] Clean up phpDoc comments in t3lib_extfilefunc

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I9ed6c40c406632546c6376175295449d3f0fc9e2
Resolves: #36926
Releases: 6.0
Reviewed-on: http://review.typo3.org/11052
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] New menu type "Sitemaps of selected pages" in CE "Menu/Sitemap"
Marco Huber [Fri, 13 Apr 2012 09:59:40 +0000 (11:59 +0200)]
[FEATURE] New menu type "Sitemaps of selected pages" in CE "Menu/Sitemap"

In the content element "Menu/Sitemap" it would be nice to be able to select
the root page for the sitemap, because the current menu type "Sitemap"
always uses the tree root. We could enable this with introducing a new
menu type "Sitemaps of selected pages".

Change-Id: Ia71dc2486a173c9c4b0aaf7293639b323dee35dd
Resolves: #35945
Releases: 6.0
Reviewed-on: http://review.typo3.org/10388
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Max Roesch
Tested-by: Max Roesch
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[TASK] Clean up phpDoc comments in t3lib_exec
Wouter Wolters [Sun, 6 May 2012 21:52:26 +0000 (23:52 +0200)]
[TASK] Clean up phpDoc comments in t3lib_exec

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I301aa2ee3d1ddcbe8395c98a6a8edb5ac0221796
Resolves: #36903
Releases: 6.0
Reviewed-on: http://review.typo3.org/11043
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[TASK] Clean up phpDoc comments in t3lib_beuserauth
Wouter Wolters [Sun, 6 May 2012 15:34:55 +0000 (17:34 +0200)]
[TASK] Clean up phpDoc comments in t3lib_beuserauth

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I26a662b3da0e23e63e7e81abcf2844bb8df01fcd
Resolves: #36888
Releases: 6.0
Reviewed-on: http://review.typo3.org/11029
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[BUGFIX] Slider Wizard value not set when used in a flexform
Wouter Wolters [Tue, 27 Mar 2012 17:19:57 +0000 (19:19 +0200)]
[BUGFIX] Slider Wizard value not set when used in a flexform

When the Slider Wizard is used in a flexform the value is given
as XML, which is not handled correctly. When the Slider is used in
a flexform, retrieve the value with t3lib_flexformtools.

Change-Id: Ifeb9f29fe356d062f027f7fba32f912d66743e24
Fixes: #34012
Releases: 4.5,4.6,4.7,6.0
Reviewed-on: http://review.typo3.org/9932
Reviewed-by: Claus Due
Reviewed-by: Arjen Hoekema
Tested-by: Arjen Hoekema
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[!!!][FEATURE] Filename filters: pass additional information
Andreas Wolf [Tue, 24 Apr 2012 12:42:21 +0000 (14:42 +0200)]
[!!!][FEATURE] Filename filters: pass additional information

The file/folder name filter methods now get an additional
parameter, $additionalInformation, that can be filled by
the driver as necessary. It could e.g. contain additional
information fetched from the storage, that might be relevant
for a filter.

This change requires adding this parameter in all filters, so it is
considered a breaking API change. Apart from that, driver authors have
to adjust their driver if they use the dispatch method from
AbstractDriver, as the parameter order changed there.

Change-Id: I24b43cc02c0bf79fb637b51081f65ef3321c5b99
Resolves: #36783
Releases: 6.0
Reviewed-on: http://review.typo3.org/10932
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[TASK] Clean up phpDoc comments in t3lib_cli
Wouter Wolters [Sun, 6 May 2012 18:28:03 +0000 (20:28 +0200)]
[TASK] Clean up phpDoc comments in t3lib_cli

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: Ibbc7a2bfa942c65a48ff9b373b63e7c1c5eb163a
Resolves: #36893
Releases: 6.0
Reviewed-on: http://review.typo3.org/11033
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[TASK] Clean up phpDoc comments in t3lib_browsetree
Wouter Wolters [Sun, 6 May 2012 16:04:44 +0000 (18:04 +0200)]
[TASK] Clean up phpDoc comments in t3lib_browsetree

* Provide correct parameter names in phpDoc
* Provide correct data types in phpDoc
* CGLify phpDoc (remove tabs)

Change-Id: I9b21dae460e34700f8a1248d92780fd9c73caa22
Resolves: #36890
Releases: 6.0
Reviewed-on: http://review.typo3.org/11031
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[TASK] Clean up phpDoc comments in t3lib_cache
Wouter Wolters [Sun, 6 May 2012 18:12:02 +0000 (20:12 +0200)]
[TASK] Clean up phpDoc comments in t3lib_cache

* CGLify phpDoc (remove tabs)

Change-Id: Ia3f897c3710ba2628076bb5d62beb0ff52d33406
Resolves: #36892
Releases: 6.0
Reviewed-on: http://review.typo3.org/11032
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[TASK] Replace Space Indent into Tab indent (CGL Cleanup)
Stefano Kowalke [Sat, 5 May 2012 23:00:22 +0000 (01:00 +0200)]
[TASK] Replace Space Indent into Tab indent (CGL Cleanup)

This patch replaces some forgotten and/or
overseen space chars in indention into tab chars.

Change-Id: I1118488ee3e06d5529d741b2811095548ca818a5
Resolves: #36871
Reviewed-on: http://review.typo3.org/11018
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix typos in browse_links class
Ingmar Schlecht [Sun, 6 May 2012 05:14:33 +0000 (07:14 +0200)]
[BUGFIX] Fix typos in browse_links class

Change-Id: Ied73a05fcb636153ab205f600b60475d585f7d86
Fixes: #36875
Releases: 6.0
Reviewed-on: http://review.typo3.org/11019
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] FAL broke rendering of image with RECORDS cObj
Susanne Moog [Sat, 5 May 2012 16:02:10 +0000 (18:02 +0200)]
[BUGFIX] FAL broke rendering of image with RECORDS cObj

Due to the backwardsCompatibilityService only
being called in tslib_content_content all other
places related to tslib_content don't work anymore
(especially RECORDS, this is used quite often
both via TypoScript and in TemplaVoila and therefore
has quite some impact).

Patch is to call the backwardsCompatibilityService at
the start of tslib_content to fix the data array for
all content types.

Change-Id: I57d1a86468a7836c7c12ca3e91b233c1671a1b9e
Fixes: #36866
Releases: 6.0
Reviewed-on: http://review.typo3.org/11017
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[FEATURE] Item filters for TCA types "group" and "inline"
Ingmar Schlecht [Thu, 3 May 2012 12:34:50 +0000 (14:34 +0200)]
[FEATURE] Item filters for TCA types "group" and "inline"

Releases: 6.0
Resolves: #36810
Change-Id: Ib8a7c30e19dab9cff72412f7dfe51aa8e94343e4
Reviewed-on: http://review.typo3.org/10953
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
6 years ago[TASK] Remove init code from showpic.php
Christian Kuhn [Sat, 5 May 2012 15:08:46 +0000 (17:08 +0200)]
[TASK] Remove init code from showpic.php

showpic.php is called through eiD for several versions now,
so the initialization code can be removed.

Change-Id: I2f428e8bbf678dde3a20c91adfb536ee61a65aa8
Resolves: #36865
Releases: 6.0
Reviewed-on: http://review.typo3.org/11016
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Move unit tests to tests/Unit folder
Christian Kuhn [Sat, 5 May 2012 14:32:38 +0000 (16:32 +0200)]
[TASK] Move unit tests to tests/Unit folder

FAL introduced first functional tests in a new tests/Functional directory.
Therefore all unit tests are now moved to tests/Unit.

Change-Id: Ied463e171b2dcaecf66cc9f6411de47b95b5bee7
Resolves: #36864
Releases: 6.0
Reviewed-on: http://review.typo3.org/11015
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn