Packages/TYPO3.CMS.git
7 years ago[RELEASE] Release of TYPO3 4.6.5 17/9417/1 TYPO3_4-6-5
TYPO3 v4 Release Team [Tue, 6 Mar 2012 10:38:06 +0000 (11:38 +0100)]
[RELEASE] Release of TYPO3 4.6.5

Change-Id: Ibce9cb837ff8392c7023a842de7ce1d3e20730c3

7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 6 Mar 2012 10:15:53 +0000 (11:15 +0100)]
[TASK] Raise submodule pointer

Change-Id: I66694ed8b5e58ad6cb430e02d3a3c88aab384137
Reviewed-on: http://review.typo3.org/9412
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Form: Confirmation value relies on label value
Oliver Hader [Thu, 3 Nov 2011 20:07:35 +0000 (21:07 +0100)]
[BUGFIX] Form: Confirmation value relies on label value

The confirmation action (back to form or send mail) relies
only on the label value. To solve this, the confirmation-true
and confirmation-false arguments are introduced.

Change-Id: Ibfb269762ed49faf37612584a14ac38c15d96357
Fixes: #31560
Releases: 4.6, 4.7
Reviewed-on: http://review.typo3.org/6982
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Form: Add more semantic classes for elements
Oliver Hader [Thu, 3 Nov 2011 20:35:30 +0000 (21:35 +0100)]
[BUGFIX] Form: Add more semantic classes for elements

The system extension form renders elements with a wrapped class like
"csc-form-1" which just states the order of elements. To enable more
specific styling, a schema like the following is integrated:

csc-form-<id> csc-form-element csc-form-element-<type>

Change-Id: If1cce3e54779fbe004cb9e31acc392234c82c52d
Fixes: #31561
Releases: 4.6, 4.7
Reviewed-on: http://review.typo3.org/6981
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Translated mailform should use localized email
Michael Stucki [Sun, 15 Jan 2012 22:09:10 +0000 (23:09 +0100)]
[BUGFIX] Translated mailform should use localized email

In case mailforms are translated the email adress from the
translated record is ignored.

Change-Id: I55913d42815f7da53a05b3bfd635b589ecc3f1ae
Fixes: #17061
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8957
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Check minitems for TCAtree
Georg Ringer [Tue, 3 Jan 2012 14:36:44 +0000 (15:36 +0100)]
[BUGFIX] Check minitems for TCAtree

The TCAtree ignores currently the minitems.
This is however e.g. needed to require input for a relation field.

Change-Id: Id972b0e065adf7e0702a8d8f85c469c7fe9ac827
Resolves: #25003
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7661
Reviewed-by: Steffen Ritter
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Validation for multiple forms on one page
Niki Mueller [Fri, 11 Nov 2011 13:25:59 +0000 (14:25 +0100)]
[BUGFIX] Validation for multiple forms on one page

Since the class tx_form_System_Validate is a singleton, it was not
possible to use more than one form on a page. This patch changes
the arrays $rules, $messages and $errors, using the current form-
prefix as key, allowing for validation of several different forms
on one page.

Change-Id: I681c509c8884093dfe6ead527d2b44264f433fa6
Fixes: #31711
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8920
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Sporadic memcache error on server load
Dmitry Dulepov [Thu, 6 Oct 2011 14:00:54 +0000 (17:00 +0300)]
[BUGFIX] Sporadic memcache error on server load

Memcache server sometimes closes connection under heavy load. In
such cases TYPO3 shows error messages in Frontend when setting
the value to cache fails. This should not happen because it is
not such a error that should cause server down times. Change the
exception to a warning in sys_log instead. Admins can see the
error and work on it.

Change-Id: I43e9356658d06f9101e1b488519ec76af6319d2d
Fixes: #30162
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7411
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] t3lib_BEfunc::getViewDomain() returns wrong or no domain
Jaume Prat [Tue, 22 Nov 2011 09:57:14 +0000 (10:57 +0100)]
[BUGFIX] t3lib_BEfunc::getViewDomain() returns wrong or no domain

If the TYPO3 BE host name is not configured as a sys_domain record
t3lib_BEfunc::getViewDomain() will always return TYPO3 BE host name
and not the first domain of the root line of the page which is
being previewed.

Furthermore, if the TYPO3 BE host name is configured as a sys_domain
but the current root line does not contain a valid domain record,
t3lib_BEfunc::getViewDomain() will return only 'http://' ie. no domain.

Change-Id: I5290ac965234fad7e8980e84a13ec5877f5119fc
Fixes: #30892
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9319
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Media element does not recognize short YouTube links
Robert Heel [Tue, 17 Jan 2012 13:57:35 +0000 (14:57 +0100)]
[BUGFIX] Media element does not recognize short YouTube links

Change-Id: I97a0071aec31b6d45ee4a164bb0dc2ffafacd03c
Fixes: #33089
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7828
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Unset stdWrap of select.pidInList
Marc Bastian Heinrichs [Fri, 2 Dec 2011 15:23:20 +0000 (16:23 +0100)]
[BUGFIX] Unset stdWrap of select.pidInList

Using stdWrap features on select.pidInList together with slide will
result in an endless loop because the same parentPids are
selected over and over again till the max execution time is reached.

This patch unsets the stdWrap properties after the first run.

Change-Id: I25a3cb0f8143ac01ce604c4be6fbeab39c53ec90
Fixes: #28526
Releases: 4.4, 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8943
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Remove early return in PageTreeDataProvider
Georg Ringer [Wed, 8 Feb 2012 12:21:12 +0000 (13:21 +0100)]
[BUGFIX] Remove early return in PageTreeDataProvider

t3lib_tree_pagetree_Data_Provider does an early
return which makes it impossible to use the hook
which comes some lines later.

Change-Id: I5c8a28a1b9a4fdba9b08fdb78191b9a3755416e0
Fixes: #33761
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8954
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Warnings in tcemain on iterating over unset columns
Mario Rimann [Thu, 16 Feb 2012 21:30:18 +0000 (22:30 +0100)]
[BUGFIX] Warnings in tcemain on iterating over unset columns

Adds a check if the TCA for the table has a columns setting at all
before iterating over the columns of that table.

Change-Id: Ic532c4582091043a5e24f228d21e05ac983c54e1
Fixes: #32467
Branches: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9076
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] TypoLink: absolute urls when installed in subfolder
Nils Seinschedt [Mon, 16 Jan 2012 09:59:46 +0000 (10:59 +0100)]
[BUGFIX] TypoLink: absolute urls when installed in subfolder

If you have TYPO3 installed in a subfolder and a domain
record with that subfolder (localhost/subfolder/ for
example) TYPO3 only generates absolute links in the
frontend.

This is because the typoLink function compares the
HTTP_HOST var with the domainRecord. HTTP_HOST is in
this case "localhost", the domain record has the subfolder
attached. The subfolder needs to be there, as otherwise
t3lib_pageSelect::getDomainStartPage does not find the
start page anymore. typoLink should check for HTTP_HOST +
path of SCRIPT_NAME to determine which domain record
to use (same as getDomainStartPage already does).

Change-Id: I50fc642ca4fb4c4522e0fc1e2dc4a4c391f54e4f
Fixes: #33214
Releases: 4.5,4.6,4.7
Reviewed-on: http://review.typo3.org/9074
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Add the title and increase width of the multiple select boxes
Thomas Layh [Fri, 10 Feb 2012 14:02:35 +0000 (15:02 +0100)]
[BUGFIX] Add the title and increase width of the multiple select boxes

The db, file and select boxes are too narrow. This makes it hard to
to impossible to read long entries.
Increase the width of those fields and add a title to each entry in
order to allow the user to see the full entry on hover.

Also add a parameter to the javascript function that takes care of the
selection of entries to support the new title attribute.

Change-Id: Ica18813c293e1d3c7a5e1447aad41b6ed5f35446
Fixes: #32732
Releases: 4.7,4.6,4.5
Reviewed-on: http://review.typo3.org/8978
Reviewed-by: Thomas Layh
Tested-by: Thomas Layh
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Misleading error with empty USER_INT
Philipp Gampe [Mon, 13 Feb 2012 17:50:22 +0000 (18:50 +0100)]
[BUGFIX] Misleading error with empty USER_INT

Just skip rendering of a USER_INT which does not have any properties.

Change-Id: I5025cf834d1d0ff687f8460e212f0a6224649b5f
Fixes: #23347, #30623
Releases: 4.5,4.6,4.7,4.8
Reviewed-on: http://review.typo3.org/9394
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] tslib_pibase: Outdated PHPDoc comment for pi_loadLL()
Stefan Rotsch [Fri, 13 Jan 2012 07:57:46 +0000 (08:57 +0100)]
[BUGFIX] tslib_pibase: Outdated PHPDoc comment for pi_loadLL()

The PHPDoc comment for function pi_loadLL() still refers to a
"locallang.php" file, but other file extensions are now in use

Change-Id: I0996e22ead2c4be5fafa411748824a4add54ff81
Fixes: #33160
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9391
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Remove typo3/logomenu.php
Christian Kuhn [Wed, 29 Feb 2012 22:30:16 +0000 (23:30 +0100)]
[TASK] Remove typo3/logomenu.php

typo3/logomenu.php contains class SC_logomenu that extends t3lib_topmenubase.
But t3lib_topmenubase does not exist anymore since TYPO3 4.2, so SC_logomenu
is broken.

Change-Id: Ia7b0227145f51fc178fb37584b7f959c6eaf29ed
Resolves: #34427
Releases: 4.8, 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9313
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 28 Feb 2012 21:21:00 +0000 (22:21 +0100)]
[TASK] Raise submodule pointer

Change-Id: I5c7ff1bd4060fc8d9812f4b59f021c2097452913
Reviewed-on: http://review.typo3.org/9283
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[TASK] Add clear l10n cache when the user clear all cache
Dominique Feyer [Thu, 15 Dec 2011 14:47:52 +0000 (15:47 +0100)]
[TASK] Add clear l10n cache when the user clear all cache

Currently the l10n parser cache can only be cleared manually, by adding this in locallang.php:

$GLOBALS['TYPO3_CONF_VARS']['SYS']['lang']['cache']['clear_menu'] = TRUE;

This patch change the default behavior. By default the l10n cache is cleared on "clear all cache",
if the clear l10n menu item is enabled, it's not cleared on clear all cache.

Change-Id: I61568b93ccec35ccb6d7f2f362c29ddf8b3365cd
Fixes: #32600
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/7358
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Dominique Feyer
Tested-by: Dominique Feyer
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] flock() calls in TYPO3 prevent NFS hosting
Dmitry Dulepov [Mon, 21 Nov 2011 14:13:28 +0000 (16:13 +0200)]
[BUGFIX] flock() calls in TYPO3 prevent NFS hosting

flock() happens in several places in TYPO3. This function does
not work properly on NFS shares. t3lib_lock should be used
instead.

Change-Id: I30392bf06c5e20e27e929fb06d77ee9f96978902
Resolves: #31460
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7504
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Steffen Ritter
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Fatal error if pear package http_request2 is installed
Philipp Gampe [Wed, 23 Nov 2011 09:21:08 +0000 (10:21 +0100)]
[BUGFIX] Fatal error if pear package http_request2 is installed

The wrong path is used for include once which leads to double
inclusion of the same class from different files.

Change-Id: I20256935e299e2d0c0a42d1d6b5381dd0fc5d6c5
Fixes: #32013
Branches: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8828
Reviewed-by: Andy Grunwald
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] show uid of reference in show_item.php
Johannes Feustel [Sun, 12 Feb 2012 13:20:43 +0000 (14:20 +0100)]
[BUGFIX] show uid of reference in show_item.php

The uid of referenced records is not shown anymore and if there are
more items with same title, there is no easy way to identify the
record in the backend.

Solution is to add a column for the uid and page information in the
title attribute of the uid.

Change-Id: I998a87cac7c01df50b8bc884794b0418e967a191
Fixes: #33866
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9005
Reviewed-by: Sebastian Fischer
Reviewed-by: Georg Ringer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[TASK] Invalid SQL and bad code in tslib_fe
Dmitry Dulepov [Tue, 29 Nov 2011 13:21:10 +0000 (15:21 +0200)]
[TASK] Invalid SQL and bad code in tslib_fe

tslibe_fe::determineId() contains invalid SQL statement (using "!=")
and bad code (variable "$idQ", missing check for start/stop dates).

Change-Id: I49e8e04e1e53db49dbb4044061917d28e168b5ea
Resolves: #32159
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7410
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] PHP Warning when moving a record
Xavier Perseguers [Mon, 27 Feb 2012 16:45:07 +0000 (17:45 +0100)]
[BUGFIX] PHP Warning when moving a record

Call to t3lib_TCEmain::moveL10nOverlayRecords() misses 4th parameter.

Change-Id: I5e0814497791fd904df809b5c19171f3e5d2936a
Fixes: #34135
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9258
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Content rendering: Definition lists in RTE are wrapped in p
Stanislas Rolland [Mon, 6 Feb 2012 20:20:28 +0000 (15:20 -0500)]
[BUGFIX] Content rendering: Definition lists in RTE are wrapped in p

Definition lists entered in the RTE are wrapped in paragraph tags when
rendered in the frontend. This is not valid HTML.

Solution: Add dl and dd to lib.parseFunc_RTE.externalBlocks and
process them recursively like div. Add dt to
nonTypoTagStdWrap.encapsLines.encapsTagList

Resolves: #25083
Releases: 4.5, 4.6, 4.7

Change-Id: Ia73d01105beeaba59f91dd87754c7528796d4d07
Reviewed-on: http://review.typo3.org/9077
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Don't save form protection error messages in session
Helmut Hummel [Sun, 25 Sep 2011 14:52:53 +0000 (16:52 +0200)]
[BUGFIX] Don't save form protection error messages in session

Do not persist flash messages in the session if we are in an Ajax context
because then the flash message is rendered out of context the next time
the flash message queue is flushed.

Change-Id: Ib63e33b7b57a0058e2b5face375bfecf5a6efed2
Resolves: #30272
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9109
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] TCE: error message if no label has been set in TCA
Mario Rimann [Tue, 29 Nov 2011 21:46:51 +0000 (22:46 +0100)]
[BUGFIX] TCE: error message if no label has been set in TCA

Avoids an invalid SQL query if no label column is specified by the
TCA for a certain table.

Change-Id: I32ef7120464602cea56131953d53bd404d5cf217
Fixes: #17947
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9106
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] getAllowedItems called with one parameter too much
Stefan Neufeind [Fri, 17 Feb 2012 09:47:35 +0000 (10:47 +0100)]
[BUGFIX] getAllowedItems called with one parameter too much

getAllowedItems() is called with two parameters. However
the second one is not in the function-definition and not used.

Change-Id: I69cd3c4362c36adc3e6f1e2bc1ae1ba7bfb38c77
Fixes: #34030
Releases: 4.4, 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9086
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Scheduler BE module fails to load due to autoloader issues
Christian Kuhn [Sun, 29 Jan 2012 12:04:03 +0000 (13:04 +0100)]
[BUGFIX] Scheduler BE module fails to load due to autoloader issues

When displaying a list of tasks, scheduler unserializes exceptions.
If the exception class is not known to the autoloader, PHP will
return an instance of _PHP_Incomplete_Class. This instance is
tested for to prevent a fatal error.

Change-Id: Ic3a4bf4bb9281602ca396641f5fbff0470feaeae
Resolves: #33116
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8896
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Additional unit tests for t3lib_div::mkdir and mkdir_deep
Loek Hilgersom [Thu, 8 Dec 2011 01:02:57 +0000 (02:02 +0100)]
[TASK] Additional unit tests for t3lib_div::mkdir and mkdir_deep

Added tests check if permissions and group ownership gets correctly
set when creating directories, also when a whole path is created
with mkdir_deep. These tests are created specifically for
https://review.typo3.org/7022

Change-Id: I2593ab9e785e19c46c9662e6f8acc2d9b5aa2592
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8749
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] htmlArea RTE: Target of localized string may be empty
Stanislas Rolland [Mon, 13 Feb 2012 19:40:34 +0000 (14:40 -0500)]
[BUGFIX] htmlArea RTE: Target of localized string may be empty

Solution: Do not allow an empty localized string to overrule the
default string.

Change-Id: Ie74ce6a398c3172f4197bb07de329dcd27d0b4e3
Fixes: #33897
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9016
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX][t3editor] (De-)Activating does not work in Chrome
Steffen Gebert [Fri, 10 Feb 2012 21:48:00 +0000 (22:48 +0100)]
[BUGFIX][t3editor] (De-)Activating does not work in Chrome

The checkbox "Deactivate t3editor" does not work in modern Chrome
versions (e.g. 18). It works in Firefox, but didn't even work while
integrating the code into TYPO3 in Chrome.

Prototype recognizes it as Webkit and thus does not disable/enable it,
which was a pretty weird implementation, which is now removed.

Change-Id: I9660af7c754d25b1321c329e9d67f80ba6d71db8
Fixes: #33515
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/9010
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] htmlArea RTE: Default skin inconsistent with ExtJS xtheme-blue
Stanislas Rolland [Mon, 13 Feb 2012 16:56:40 +0000 (11:56 -0500)]
[BUGFIX] htmlArea RTE: Default skin inconsistent with ExtJS xtheme-blue

The default RTE skin, used as default skin in FE, has colors
inconsistent with ExtJS skin xtheme-blue which is loaded by default
in FE.

Change-Id: I0f5ee1aa32a67a0ab1286c032ba8ad8b1624de6f
Fixes: #33889
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/9008
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] IRRE translation links shouldn't be shown if no parent
Georg Ringer [Fri, 25 Nov 2011 06:45:13 +0000 (07:45 +0100)]
[BUGFIX] IRRE translation links shouldn't be shown if no parent

IRRE provides some links like "localize records" or "synchronize with
original language" which is great but those links should not be
shown if a record got no parent record

Change-Id: I53d2bd3edd1b8126fae83b370c3ade58e8670818
Fixes: #32073
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8898
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Confusing error message in reports module
Markus Klein [Sun, 18 Dec 2011 04:48:51 +0000 (22:48 -0600)]
[BUGFIX] Confusing error message in reports module

The saltedpasswords status report shows "INSECURE" warnings
although the configuration is totally fine.

Change-Id: Ibb3a26080831215ccb2d866bd39fa21673e3c024
Fixes: #32650
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8894
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] .inc files still call cObj->checkEmail
Markus Klein [Fri, 4 Nov 2011 16:58:36 +0000 (11:58 -0500)]
[BUGFIX] .inc files still call cObj->checkEmail

The cObj->checkEmail function has been removed in 4.6,
but *.inc scripts still call this function.

This patch replaces these calls with t3lib_div::validEmail().

Change-Id: I8c9d039332835f8d6da597061b28f44f0f938b4d
Fixes: #31573
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8980
Reviewed-by: Thorsten Kahler
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Resetting of input field to default when having a range fails
Philipp Kitzberger [Wed, 28 Dec 2011 10:28:01 +0000 (11:28 +0100)]
[BUGFIX] Resetting of input field to default when having a range fails

When trying to reset a endtime (datetime or date) having a range (like tt_news
articles) the lower range limit will be stored instead of the default value.

Change-Id: I6b1240336bbeb3b3430b7d0f2de82baf6288dff5
Fixes: #28298
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8959
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] IRRE: Selected items remain in selector with foreign_unique
Stanislas Rolland [Wed, 8 Feb 2012 05:15:32 +0000 (00:15 -0500)]
[BUGFIX] IRRE: Selected items remain in selector with foreign_unique

Problem: When an inline field is defined as unique (foreign_unique
is set), selected items are removed neither from the inline record
selector, nor from the children record selectors.

Solution: Remove the used records from all selectors. Also, when
updating and collapseAll is set, remove records already used from
the child record after its ajax-retrieval/expansion.

Change-Id: I84c7fa3bfd8139f07604c05ab80c5bf4d90af736
Fixes: #21102
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8955
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Formmail doesn't always use correct character set
Jigal van Hemert [Sat, 19 Nov 2011 08:32:09 +0000 (09:32 +0100)]
[BUGFIX] Formmail doesn't always use correct character set

To work around a bug in SwitfMailer the character set of a message part
should always be set. When no character set is explicitly defined use
the renderCharset instead.

Change-Id: Id04ea398b616b38583bce8517fec8e53bc482144
Fixes: #28684
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8910
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] RTE: Removing div from formatblock selector may not work
Stanislas Rolland [Thu, 9 Feb 2012 05:11:28 +0000 (00:11 -0500)]
[BUGFIX] RTE: Removing div from formatblock selector may not work

Problem: RTE.default.buttons.formatblock.removeItems = div is not
honoured when indent/outdent is configured.
Solution: Honour the removal/restriction even when indent/outdent is
configured.

Change-Id: Ia571b5058d9d70e34eeebc4151e9291cfe90ff43
Fixes: #33457
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8952
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] htmlArea RTE: CSS class names are lowercase in WebKit
Stanislas Rolland [Fri, 10 Feb 2012 01:37:05 +0000 (20:37 -0500)]
[BUGFIX] htmlArea RTE: CSS class names are lowercase in WebKit

Problem: See https://bugs.webkit.org/show_bug.cgi?id=55619
Solution: Add doctype to the iframe source

Change-Id: Ib775e836403d9711db4585b84351c700f1eec65c
Resolves: #32408
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8950
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] *IFSUB ignores l18n_cfg field
Stefan Galinski [Fri, 23 Sep 2011 18:55:00 +0000 (20:55 +0200)]
[BUGFIX] *IFSUB ignores l18n_cfg field

The l18n_cfg field is used to prevent the appearance of the default
language record or any alternative language records that haven't a translation
in the menu. At the first glance it seems to work like expected, because the
expected page records are not visible in a configured frontend menu. If we have a
closer look at this part, we will see that the flag is badly ignored for the
"*IFSUB" record states. This causes that a page record which has no visible
subpages is marked with the hasSubmenu flag.

Change-Id: Icc335a838732612cba2abb04b9996628bc129b55
Resolves: #19925
Releases: 4.7, 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/8938
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[BUGFIX] Shortcut redirect ignores linkVars syntax
Stefan Galinski [Thu, 1 Dec 2011 17:52:15 +0000 (18:52 +0100)]
[BUGFIX] Shortcut redirect ignores linkVars syntax

Currently the code that creates the redirect url for a shortcut
page only respects the linkVars option as list of parameters without
additional validation informations like it's documented in the
TSRef. Unfortunatly such paramaters are completely dropped and
this leads to major problems on multilanguage sites with the new
shortcut redirect feature.

Change-Id: I0abcaa56fdeb251c2333f4d807fbef3eeb0299a2
Fixes: #32253
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8922
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[BUGFIX] Loading of an IRRE element with subtabs freezes and breaks browsers
Stefan Galinski [Fri, 27 Jan 2012 15:38:29 +0000 (16:38 +0100)]
[BUGFIX] Loading of an IRRE element with subtabs freezes and breaks browsers

Change-Id: Id159587d19e969bbce3bf00a8862a41f3fc645b2
Fixes: #33448
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8923
Reviewed-by: Georg Ringer
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[BUGFIX] saltedpasswords update task only updates 42 records
Mario Rimann [Sun, 4 Dec 2011 19:29:08 +0000 (20:29 +0100)]
[BUGFIX] saltedpasswords update task only updates 42 records

The scheduler task to convert the fe_user and be_user passwords
to salted passwords took only 42 records per run. Now it should
take 250 per run. This will lead to an approx. run-time of about
50s (given 2 * 100ms * 250 records)

Change-Id: I009f50c2a92a430091197c442098f238b6180ae7
Resolves: #31252
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8924
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] TSconfig option hides table pages_language_overlay
Stefan Geith [Mon, 19 Dec 2011 14:40:22 +0000 (15:40 +0100)]
[BUGFIX] TSconfig option hides table pages_language_overlay

If page TSconfig

mod.web_list.hideTranslations=*

is set, then also the table 'pages_language_overlay' is hidden,
which should be visible.

Change-Id: I5904b7955b6ecdffb34c075de781985ac4e52e1e
Fixes: #32693
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8919
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] SQL error in extension manager
Philipp Gampe [Mon, 6 Feb 2012 00:17:01 +0000 (01:17 +0100)]
[BUGFIX] SQL error in extension manager

Since #32161 all extension list updates fail because the single
quotes are added twice.

Also fix the other occurence in tx_em_connection_extdirectsoap.

Change-Id: I19f3e4ce6a8444fdce653e6d0fbafae5bbf8d434
Fixes: #33697
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8903
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Invalid "unequal"-statement and string-quoting in SQL
Stefan Neufeind [Mon, 19 Dec 2011 13:24:31 +0000 (14:24 +0100)]
[BUGFIX] Invalid "unequal"-statement and string-quoting in SQL

There are multiple "!=" in SQL statements. They should be "<>".
MySQL understands "!=" for the compatibility with early versions
but it is not a standard SQL and should not be used.

Strings should be enclosed in single-quotes. Some systems use
double-quotes to mark identifiers in contrast to literals.

(Added some small fullQuote-calls along the way for
completeness or dropped quotes where uid is clearly just
an intval.)

Change-Id: If183e3451dac4cebb179b4c1f8c2e0ef6d5a6efd
Resolves: #32161
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8900
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Live search must implement search properties
Francois Suter [Sat, 28 Jan 2012 16:23:11 +0000 (17:23 +0100)]
[BUGFIX] Live search must implement search properties

Implement the new TCA properties introduced in TYPO3 4.5 (#26829)
in the live search, so that it produces the same results as the
traditional BE search.

Change-Id: I3a297f2b9c02bc4458f6b0e5af8bd1588f3fcae3
Fixes: #31761
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8882
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Release locked records during logout
Tolleiv Nietsch [Sat, 4 Feb 2012 08:08:34 +0000 (09:08 +0100)]
[BUGFIX] Release locked records during logout

The sys_lockedrecords tables isn't cleared during the users logout.

Change-Id: Ia7cd222934af35721a0a70f58ff65c947b62eded
Fixes: #20211
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8883
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Prevent compression of scripts that use ajax.php
Steffen Kamper [Tue, 11 Oct 2011 12:49:08 +0000 (14:49 +0200)]
[BUGFIX] Prevent compression of scripts that use ajax.php

When registering ajax calls, a pseudo JS file is registered within the
pageRenderer with a source like 'ajax.php?parameters'.

As it does not make sense to compress or concatenate those pseudo JS files,
the pageRenderer should ensure they are properly included.

Change-Id: I386663b9ea77426ea3d8e804eac0f3c8ca72cd7a
Fixes: #24274
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8880
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] SQL parser does not support NULL as default value
Xavier Perseguers [Mon, 6 Feb 2012 13:04:27 +0000 (14:04 +0100)]
[BUGFIX] SQL parser does not support NULL as default value

When preparing a database schema with proper referential integrity,
one typically has to choose NULL as default value for foreign keys.
However, database analyzer does not support NULL as default value and
shows an empty string ('') instead.

Change-Id: If4271e1edd078b9a19fbb82c04e265f181e07d9d
Fixes: #33704
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8879
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] "Show page" does not use a proper URL scheme
Dmitry Dulepov [Mon, 21 Nov 2011 12:16:35 +0000 (14:16 +0200)]
[BUGFIX] "Show page" does not use a proper URL scheme

"Show page" context menu and Web>View do not use proper scheme if
that is set in the page properties. They always use the scheme of
the Backend.

Change-Id: I0fc117d3ef81c5f9da81f9573c330fa6ff3a4279
Fixes: #31959
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7413
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[TASK] Reports module uses internal data of salted passwords
Dmitry Dulepov [Mon, 28 Nov 2011 12:12:39 +0000 (14:12 +0200)]
[TASK] Reports module uses internal data of salted passwords

Reports module changes from issue #30695 introduced a check
for the saltedpasswords extension and a report about users,
whose passwords are not protected by the saltedpasswords.
That check queries database directly and uses internal
knowledge of saltedpasswords about marking the password
with certain characters. This can break reports module
if saltedpasswords adds a new scheme to salt passwords.
Only saltedpasswords should know about those prefixes.
Other extensions should use the API of saltedpasswords
to query the information.

Change-Id: Ifd1eefb8e823e17612e72253ad3594c3956099c2
Resolves: #32136
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7407
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[BUGFIX] RTE: Some toolbar elements may not be correctly initialized
Stanislas Rolland [Thu, 2 Feb 2012 18:05:33 +0000 (13:05 -0500)]
[BUGFIX] RTE: Some toolbar elements may not be correctly initialized

The language and font dropdowns need to initialized after their data
stores are loaded. The text indicator needs to be initialized after
the style sheets are loaded.

Change-Id: I3862df875c497a3f012d49b3a299db12e45b0944
Resolves: #33637
Releases: 4.6
Reviewed-on: http://review.typo3.org/8855
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years agoRevert "[BUGFIX] RTE: Some toolbar elements may not be correctly initialized"
Stanislas Rolland [Fri, 3 Feb 2012 19:28:25 +0000 (20:28 +0100)]
Revert "[BUGFIX] RTE: Some toolbar elements may not be correctly initialized"

This reverts commit 21757151ecf10119a05ef80e055fe3a3bf338ecc

Change-Id: If154e6b4b452ccefd2aadffe6dba50005e558bbd
Reviewed-on: http://review.typo3.org/8834
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Encoding error in TCEforms inline JavaScript
Manuel Stofer [Wed, 1 Feb 2012 09:17:02 +0000 (10:17 +0100)]
[BUGFIX] Encoding error in TCEforms inline JavaScript

JavaScript encoding is broken, when the link browser is used to add a
new item and sections are used.

Change-Id: Id366d078841a3decd0256f98df497956a494ecb8
Fixes: #32422
Related: #29067
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8831
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] Bookmarks to pages don't work
Stefan Galinski [Tue, 31 Jan 2012 20:40:05 +0000 (21:40 +0100)]
[BUGFIX] Bookmarks to pages don't work

Change-Id: I1d253bae07b67d8a1cccba09de9666af252aad0a
Fixes: #30352
Releases: 4.7. 4.6, 4.5
Reviewed-on: http://review.typo3.org/8829
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years ago[BUGFIX] t3lib_div::validPathStr() fails on certain file names
Dmitry Dulepov [Fri, 2 Dec 2011 15:22:56 +0000 (17:22 +0200)]
[BUGFIX] t3lib_div::validPathStr() fails on certain file names

Function t3lib_div::validPathStr() fails on file names with Unicode
characters. Adding 'u' modifier to the regular expression solves
the problem.

Change-Id: I7f8fa432bdc864dfc242f8d2675464aafcdbb05b
Resolves: #32046
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7797
Reviewed-by: Steffen Ritter
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[BUGFIX] htmlArea RTE: Changing the text color to black does not work
Stanislas Rolland [Fri, 3 Feb 2012 02:18:24 +0000 (21:18 -0500)]
[BUGFIX] htmlArea RTE: Changing the text color to black does not work

Solution: Fix colorToHex conversion utility

Change-Id: I9983e97970ba82d44a53bdffbe36e544755ac9c6
Resolves: #32877
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8821
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] htmlArea RTE: Firefox may report error when setting a color
Stanislas Rolland [Fri, 3 Feb 2012 00:36:20 +0000 (19:36 -0500)]
[BUGFIX] htmlArea RTE: Firefox may report error when setting a color

Problem: The color does get assigned, but Firefox reports a JS error.
Solution: The RTE may incorrectly detach the selection range.

Change-Id: Ic457aa38bb01909ced8c55906108a37b974c3fb5
Resolves: #33644
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8818
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE: Some toolbar elements may not be correctly initialized
Stanislas Rolland [Thu, 2 Feb 2012 18:05:33 +0000 (13:05 -0500)]
[BUGFIX] RTE: Some toolbar elements may not be correctly initialized

The language and font dropdowns need to initialized after their data
stores are loaded. The text indicator needs to be initialized after
the style sheets are loaded.

Change-Id: I6e65730856127ff4d58088b0426541ea162852b8
Resolves: #33637
Releases: 4.6
Reviewed-on: http://review.typo3.org/8812
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Adjust shortcut mode labels for selected/current page
Stefan Neufeind [Sat, 17 Sep 2011 17:05:13 +0000 (19:05 +0200)]
[BUGFIX] Adjust shortcut mode labels for selected/current page

If a certain page is selected then shortcut mode refers to that page.
Only otherwise the current page is the point of reference for
first/random/parent.

Change-Id: I0820b8b51df8097ed172fe9dea50c1f2b068b0f8
Fixes: #26690
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/7474
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
7 years agoRevert "[BUGFIX] Scheduler BE module fails to load due to autoloader issues"
Christian Kuhn [Sat, 28 Jan 2012 19:20:53 +0000 (20:20 +0100)]
Revert "[BUGFIX] Scheduler BE module fails to load due to autoloader issues"

The patch has an unwanted side-effect: It sometimes throws a php warning "Function spl_autoload_call() hasn't defined the class it was called for".
Reverted for now.

This reverts commit 545b2a9eb174000f22ef20a6c5f9eaaf529aabe0

Change-Id: Ia55d410e364a39f7d956bd825ad61d2653924668
Reviewed-on: http://review.typo3.org/8754
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Reports module shows unnecessary info text
Markus Klein [Thu, 15 Dec 2011 01:49:26 +0000 (19:49 -0600)]
[BUGFIX] Reports module shows unnecessary info text

Do not show saltedpasswords info text in reports module
unless problems have been detected.

Change-Id: Ic0a456bb6128c7024150a22152228d6ddce842db
Fixes: #32580
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8751
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Scheduler BE module fails to load due to autoloader issues
Dmitry Dulepov [Wed, 11 Jan 2012 12:15:00 +0000 (14:15 +0200)]
[BUGFIX] Scheduler BE module fails to load due to autoloader issues

When displaying a list of tasks, scheduler unserializes exceptions.
By default, unserialize() does not call autoloader to load classes
and it is possible that the exception class will not be loaded. In
such case scheduler BE module will fail with a PHP fatal error
when the scheduler will try to use a _PHP_Incomplete_Class.

The fix makes sure that autoloader is called during unserialize().
However this still may fail, so the scheduler now checks that the
exception is loaded properly before trying to use it.

Change-Id: Iaf80515f54d35bd09f1c78e7f69e671044e203af
Resolves: #33116
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8747
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Broken datepicker on unsaved flexform sections
Stefan Rotsch [Tue, 24 Jan 2012 10:41:55 +0000 (11:41 +0100)]
[BUGFIX] Broken datepicker on unsaved flexform sections

The onClick event for opening the datepicker is attached to the
datepicker icons only once on page load. There currently is no update
method which adds the onClick event to new sections, so the datepicker
icons are without function until the form is saved.

Related to this, IDs of input fields are not unique when adding more than
one new section before saving. They have to be randomized when inserting a
new section in order to make the datepicker work properly.

This patch implements an update() method in tceforms.js which is called
every time a new section is added to a flexform. The IDs of tceforms
date/datetime fields get randomized by adding a timestamp when adding a
new section.

Change-Id: I6acee7f570be3314350c1ae1ca952096cf416746
Fixes: #23843
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8745
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] TYPO3 prompts to select position when there are no pages
Dmitry Dulepov [Mon, 5 Dec 2011 14:37:33 +0000 (16:37 +0200)]
[BUGFIX] TYPO3 prompts to select position when there are no pages

When adding the very first page to the page tree, TYPO3 asks to
select a position and offers a weird looking selector (see the
attachment in the bug report). Instead, it should proceed
straight to the page properties window (or redirect to it).

Change-Id: I4b5b1cd66967a1eb50fbc2ba6839aa42ae53c3b8
Resolves: #32111
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7801
Reviewed-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Unlimited memory limit handling in system status report
Mario Rimann [Fri, 2 Dec 2011 21:10:25 +0000 (22:10 +0100)]
[BUGFIX] Unlimited memory limit handling in system status report

According to the documentation, "-1" is a valid setting for PHP's
memory_limit and means "unlimited". So far this value has caused
the system status report to report this value as an error.

Change-Id: If27985d95147c5720ac81c1ac6afc0f1b0061d4b
Fixes: #32231
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7792
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Warnings in BE when using "Find filename"
Dmitry Dulepov [Wed, 23 Nov 2011 13:14:58 +0000 (15:14 +0200)]
[BUGFIX] Warnings in BE when using "Find filename"

When using "Tools">"DB Check">"Find filename" with a slash
character (for example, "</title>"), there are warnings about
wrong regular expression in the Backend and nothing is found.

Change-Id: I4717ccc8fe3ee2f1e10e121cd86d86f3495f0af4
Resolves: #21591
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8638
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Fix permissions and create group in mkdir_deep
Loek Hilgersom [Fri, 2 Dec 2011 00:48:45 +0000 (01:48 +0100)]
[BUGFIX] Fix permissions and create group in mkdir_deep

t3lib_div::mkdir_deep does not properly create nested directories.
This is fixed by using API method t3lib_div::fixPermissions on the
first created directory with recursive flag set.

Change-Id: I5f250b25663b64b770c2308eccbc3da17a12c8ae
Fixes: #32261
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/8637
Reviewed-by: Ernesto Baschny
Reviewed-by: Loek Hilgersom
Tested-by: Loek Hilgersom
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] spriteManager for Clear RTE Cache icon
Felix Kopp [Sat, 31 Dec 2011 13:58:06 +0000 (14:58 +0100)]
[BUGFIX] spriteManager for Clear RTE Cache icon

RTE hooks into the clear cache menu to allow clearing RTE cache.
Changes the icon integration from iconWorks to spriteManager.
Solves styling issue caused by too small icon.

Change-Id: I7ac7f1dda0ccd4088a24b7be8f0d949d5e03cdac
Resolves: #32892
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/8743
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[TASK] Improve debugTrail() to better handle includes
Markus Klein [Wed, 26 Oct 2011 00:28:04 +0000 (19:28 -0500)]
[TASK] Improve debugTrail() to better handle includes

The deprecation log lacks specific and necessary information about
include and require calls, which makes it hard to actually follow
a stack trace.

Add special treatment of this sort of functions and display additional
path information.

Change-Id: If44397c4e6672932f95d3854105a20993fbdf9d9
Resolves: #31300
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7794
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] htmlArea RTE: Some attributes wrongly unset by "Edit element"
Stanislas Rolland [Thu, 26 Jan 2012 15:37:07 +0000 (10:37 -0500)]
[BUGFIX] htmlArea RTE: Some attributes wrongly unset by "Edit element"

The style, lang and dir attributes may be incorrect after unsetting
using "Edit element" dialogue.

Change-Id: I1c52ff8496b0ecbcb8282c6bea2c216bbab308ab
Resolves: #33466
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8712
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Misinterpretation of memory_limit setting in install tool
Mario Rimann [Sun, 4 Dec 2011 21:34:51 +0000 (22:34 +0100)]
[BUGFIX] Misinterpretation of memory_limit setting in install tool

Adds a different warning into the system checks of the basic
configuration section of the install tool in case the memory_limit
is set to "-1" which means unlimited according to the PHP docs.

Change-Id: I9df642e0e92945927330eba9713dd866f50c53d3
Fixes: #20069
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8709
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
7 years ago[BUGFIX] Marker not removed from file module
Ernesto Baschny [Thu, 26 Jan 2012 09:04:46 +0000 (10:04 +0100)]
[BUGFIX] Marker not removed from file module

If bookmarks are disabled, the ##SHORTCUT## marker is still shown.

Change-Id: I96ac76103fc07775e8f9a3bd94bd7a17aacd5922
Fixes: #33455
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/8707
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
7 years ago[BUGFIX] Sorting of localized records is wrong after copying
Stanislas Rolland [Wed, 19 Oct 2011 16:15:50 +0000 (12:15 -0400)]
[BUGFIX] Sorting of localized records is wrong after copying

Solution: When copying a record in original language, if a localized
record of the destination record exists for language A, then the
localized record of the copied record, if it exists for language A,
should be inserted after the localized record, in language A, of the
destination record.
The same applies when moving a record in original language.
Similar situation arises when a new localization record is created.

Note: Backport from 4.7

Change-Id: Idf4222171134a161b346d600427d460f6f74d62b
Resolves: #30469
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8680
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[TASK] Set TYPO3 version to 4.6.5-dev
TYPO3 v4 Release Team [Tue, 24 Jan 2012 10:42:15 +0000 (11:42 +0100)]
[TASK] Set TYPO3 version to 4.6.5-dev

Change-Id: Icaa0fd33df22bb465ed21eab20e96d42b1552a42
Reviewed-on: http://review.typo3.org/8672
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.6.4
TYPO3 v4 Release Team [Tue, 24 Jan 2012 10:42:00 +0000 (11:42 +0100)]
[RELEASE] Release of TYPO3 4.6.4

Change-Id: I0ca0216fbb46c5405dc3839fb9bb03303d378d76
Reviewed-on: http://review.typo3.org/8671
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 24 Jan 2012 10:20:02 +0000 (11:20 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ide6a185eb531809653a3eed3b84efb2c76c45949
Reviewed-on: http://review.typo3.org/8665
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] typolink prepends wrong domain when using url scheme
Dmitry Dulepov [Thu, 17 Nov 2011 14:16:45 +0000 (16:16 +0200)]
[BUGFIX] typolink prepends wrong domain when using url scheme

tslib_cObj::typoLink() uses a wrong domain if the target page
has a domain record and a URL scheme, which is different to
current. It prepends a current domain instead of the target
domain of the page.

Change-Id: I11d21d19731c8d5b9337dfef773cb43484a0b291
Resolves: #31771
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6709
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Regression in language handling
Nils Seinschedt [Mon, 16 Jan 2012 18:09:46 +0000 (19:09 +0100)]
[BUGFIX] Regression in language handling

If you request a translated string in a
language where no translation is available
you used to get the default language
labels in the [target] array attribute of
the LOCAL_LANG array for that language.
After the fix of #32573 you only get the
[source] element filled. Which breaks
extensions (like extbase/fluid) that rely on
always having the [target] attribute filled.

Change-Id: I750cd3a7385ed0ff0449f0478a1170251abd41f8
Resolves: #33227
Releases: 4.6, 4.7
Reviewed-on: http://review.typo3.org/8611
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] htmlArea RTE: magic image maxWidth is not working as expected
Stanislas Rolland [Sat, 21 Jan 2012 18:17:52 +0000 (13:17 -0500)]
[BUGFIX] htmlArea RTE: magic image maxWidth is not working as expected

Solution: Clarify the documentation of the option

Change-Id: Icbe9ecb870a241c81e19734f6e481390d71f7809
Resolves: #32301
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8628
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] htmlArea RTE : Adding link problem with IE
Stanislas Rolland [Tue, 17 Jan 2012 23:20:31 +0000 (18:20 -0500)]
[BUGFIX] htmlArea RTE : Adding link problem with IE

Problem: Link may not be created on cell, list element or paragraph
when following element of same type already contains a link.
Solution: Fix selection breaking procedure

Change-Id: Ia35f4eb1f756eb5abc9d9d641e4b2fc1402cbb8f
Resolves: #31763
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/8616
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] PHP warning if open_basedir is enabled
Dmitry Dulepov [Sun, 27 Nov 2011 09:51:54 +0000 (11:51 +0200)]
[BUGFIX] PHP warning if open_basedir is enabled

When using flexforms, a warning may appear in the Backend when
saving the form in BE (typically in a plugin). This happens
because TYPO3 checks if flexform DS is static (in the file)
using is_file. When the DS is not static, the parameter
to is_file is not a file name but an XML content. PHP
thinks this "file name" falls outside of the open_basedir
and complains with a warning. Possibly it can be solved
in other ways but this fix is the simplest possible.

Change-Id: Ie6081cda3dd5d95af687875392590d3a33e9fc78
Resolves: #32109
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7371
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] TCEmain::clear_cacheCmd relies on active BE_USER
Steffen Gebert [Thu, 29 Dec 2011 11:21:32 +0000 (12:21 +0100)]
[BUGFIX] TCEmain::clear_cacheCmd relies on active BE_USER

Several developers abuse t3lib_TCEmain and instantiate it also in other
contexts than BE, for which it never was made.

As this breaks several extensions that use it in FE or CLI mode and the
fix is trivial, avoid crashing.

Change-Id: I5d72375fe252184b3ed41c90cf7b06ae45052cc5
Fixes: #28007
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7806
Reviewed-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] MENU special = updated does not work anymore
Xavier Perseguers [Wed, 11 Jan 2012 14:31:26 +0000 (15:31 +0100)]
[BUGFIX] MENU special = updated does not work anymore

Since stdWrap has been introduced on HMENU properties, a wrong
test removes the condition pidInList=0 which prevents the inclusion
of a pid IN (current page) clause in the query used to retrieved
recently modified pages.

Change-Id: Ibaea85d6162653b45260d687f682706d9f372b88
Fixes: #32374
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/7839
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Usage of custom caching backends
Michael Klapper [Thu, 5 Jan 2012 09:02:09 +0000 (10:02 +0100)]
[BUGFIX] Usage of custom caching backends

The use of "require_once" statements will help to define custom caching backends.

Change-Id: I6c04644ca7711e4ca7b7e59df3f71c16115b3ae9
Fixes: #32986
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/7835
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] HTML entity &nbsp; is inserted before and after inline element
Stanislas Rolland [Thu, 12 Jan 2012 23:33:28 +0000 (18:33 -0500)]
[BUGFIX] HTML entity &nbsp; is inserted before and after inline element

Problem: This is a regression caused by patch to issue #16217.
The last two lines of the merged patch are wrong. They should replace
only leading and trailing spaces inside block elements.
Solution: Revert the last two replacement lines of the patch.

Change-Id: I94008b281bbe13189948862eda626264d0895ab1
Resolves: #32263
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/7753
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Module menu link wrap
Felix Kopp [Sun, 11 Dec 2011 23:27:58 +0000 (00:27 +0100)]
[BUGFIX] Module menu link wrap

Makes module links in menu on the left not wrap around in small frames.

Change-Id: I499d570a280ccec16ff10948676e9d32d62b3c0d
Fixes: #32448
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/7398
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] ENABLE_INSTALL_TOOL does not respect fileCreateMask
Dmitry Dulepov [Wed, 23 Nov 2011 14:24:52 +0000 (16:24 +0200)]
[BUGFIX] ENABLE_INSTALL_TOOL does not respect fileCreateMask

When this file is created by the Install tool, the fileCreateMask
is not respected. That does not allow to delete this file through
FTP or from SSH if the web server user and group is different
from logged in user.

Change-Id: I0e3c69d0cfd06b8e3d389b191ba95f0bfc0729ba
Resolves: #21740
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/7349
Reviewed-by: Markus Klein
Reviewed-by: Mario Rimann
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Fix permissions of downloaded translations into l10n folder
Michael Klapper [Mon, 21 Nov 2011 15:36:54 +0000 (16:36 +0100)]
[BUGFIX] Fix permissions of downloaded translations into l10n folder

The downloaded extension translation files should have proper permissions
set after having been unzipped into l10n directory.

Change-Id: I59169bc26cf3a03dc5d9379b5b496ef5b51fd05b
Fixes: #31964
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/6781
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Joh. Feustel
Tested-by: Joh. Feustel
Reviewed-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Vague error message in t3lib_div
Dmitry Dulepov [Tue, 22 Nov 2011 14:44:08 +0000 (16:44 +0200)]
[BUGFIX] Vague error message in t3lib_div

If the web server cannot write to typo3temp/, a vague error
message may appear: "File not written to disk! Write
permission error in filesystem?". Fix the issue by hinting
the user where he should check permissions.

Change-Id: I168da1dc3006e0bb26c580e93f04672904fe6c9b
Resolves: #18545
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7509
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
7 years ago[BUGFIX] Link to mounted shortcut page lacks &MP parameter
Xavier Perseguers [Tue, 3 Jan 2012 08:26:42 +0000 (09:26 +0100)]
[BUGFIX] Link to mounted shortcut page lacks &MP parameter

Menu generation for a shortcut page within a mount point does not
include the &MP parameter and other configured additional parameters.

Change-Id: Idb19f260fa0af8f73c8bc3441702a2b644017272
Fixes: #32938
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7749
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Typo in Install Tool
Georg Ringer [Wed, 4 Jan 2012 17:37:18 +0000 (18:37 +0100)]
[BUGFIX] Typo in Install Tool

Fix a simple typo in mail of Install Tool.

Change-Id: Ibe8b8003cbf6d2b98210bc22bf5e2a5678e0e137
Resolves: #32970
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7699
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[TASK] Scheduler: Add "Add Task" button to header
Markus Klein [Wed, 21 Dec 2011 22:24:01 +0000 (16:24 -0600)]
[TASK] Scheduler: Add "Add Task" button to header

This patch adds a "Add Task" button to the left area of
the module header.
It improves usability for long task lists and enforces
the standard layout of backend modules.
The "Add Task" link below the table is removed at the
same time.

Change-Id: Id5647861b1ec31ac5c3401153ea58c5d525f99c3
Resolves: #32753
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/7511
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[BUGFIX] Reports are called twice
Philipp Gampe [Thu, 22 Dec 2011 00:20:34 +0000 (01:20 +0100)]
[BUGFIX] Reports are called twice

The code in getReport(), directly before the call to getSystemStatus(),
is exactly the same as in getSystemStatus().

Change-Id: Id3924580f4b4dbc0c9a4ce0d2c92037c7f47449c
Fixes: #32768
Releases: 4.5,4.6,4.7
Reviewed-on: http://review.typo3.org/7505
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[BUGFIX] locallangXMLOverride is broken since the switch to XLIFF
Lars Patrick Heß [Thu, 15 Dec 2011 10:22:46 +0000 (11:22 +0100)]
[BUGFIX] locallangXMLOverride is broken since the switch to XLIFF

locallangXMLOverride mechanism does not work anymore since
target language is mixed with the default language.

Change-Id: I435e79d01fcdbd993e0ae47ab15eee745ae39752
Fixes: #32573
Releases: 4.7, 4.6
Reviewed-on: http://review.typo3.org/7467
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 20 Dec 2011 17:31:26 +0000 (18:31 +0100)]
[TASK] Raise submodule pointer

Change-Id: Iea630c43265f36c71c612fa1574757ca8a2399e8
Reviewed-on: http://review.typo3.org/7447
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team