Packages/TYPO3.CMS.git
7 years ago[RELEASE] Release of TYPO3 4.5.8 54/6854/1 TYPO3_4-5-8
TYPO3 v4 Release Team [Tue, 22 Nov 2011 14:59:47 +0000 (15:59 +0100)]
[RELEASE] Release of TYPO3 4.5.8

Change-Id: I0138efdcac887ab8c43358e50ffb0ae602034df1

7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 22 Nov 2011 14:41:31 +0000 (15:41 +0100)]
[TASK] Raise submodule pointer

Change-Id: Id3aebf7cb8f79e5f467e55db311fb26354622ab5
Reviewed-on: http://review.typo3.org/6849
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Error in the pageNotFound_handling with USER_FUNCTION
Dmitry Dulepov [Thu, 17 Nov 2011 15:53:50 +0000 (17:53 +0200)]
[BUGFIX] Error in the pageNotFound_handling with USER_FUNCTION

When using USER_FUNCTION in the pageNotFound_handling, an exception
or a blank screen appears in the Frontend (depending on error
handling settings) because $GLOBALS['TSFE']->sys_page is not
initialized.

Change-Id: Ieb2ef07d4977ebceeee7e68c390f53f9646337b0
Resolves: #31839
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6846
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Vimeo mediawizardprovider needs new syntax
Georg Ringer [Tue, 8 Nov 2011 07:58:02 +0000 (08:58 +0100)]
[BUGFIX] Vimeo mediawizardprovider needs new syntax

Vimeo changed its behaviour and there is always the
vimeo error "no video" shown. Their change is strange
as vimeo required the argument clip_id as the 1st one

Change-Id: I6f4e1758175a2bda1eb7bfd9083fb769e1c6eeca
Resolves: #31661
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6841
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] magic_quotes_gpc does not exist anymore in PHP 5.4
Xavier Perseguers [Tue, 20 Sep 2011 09:36:58 +0000 (11:36 +0200)]
[BUGFIX] magic_quotes_gpc does not exist anymore in PHP 5.4

PHP INI magic_quotes_gpc got deprecated in PHP 5.3 and is removed in
PHP 5.4, init.php should then behave as if it were set to "Off".

Change-Id: Ifcd4fb7cc9c2cb23ba6d910ffbe6cc034a66cdbd
Fixes: #30083
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6833
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Multiple values not displayed for simple items lists
Francois Suter [Fri, 28 Oct 2011 12:09:00 +0000 (14:09 +0200)]
[BUGFIX] Multiple values not displayed for simple items lists

t3lib_BEfunc::getProcessedValue() is used throughout the Core to
transform values stored as indices into human-readable values.

However for select-type fields based on a list of items
(and not a foreign table) where multiple selections are possible,
t3lib_BEfunc::getProcessedValue() fails to display anything.
This is due to t3lib_BEfunc::getLabelFromItemlist(),
being unable to handle several values.

This patch introduces a new method to avoid breaking compatibility.

Change-Id: I5fa6f385a3efa11db9aae82399102e67a96ec700
Resolves: #31374
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6370
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[TASK] Update ADOdb library to version 5.14
Xavier Perseguers [Tue, 1 Nov 2011 11:46:31 +0000 (12:46 +0100)]
[TASK] Update ADOdb library to version 5.14

Change-Id: Ib30675a445160b455dced98e6db6361f44b8bf51
Resolves: #31486
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/6766
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Error after hide/show element in list module
Simon Schaufelberger [Wed, 16 Nov 2011 18:22:36 +0000 (12:22 -0600)]
[BUGFIX] Error after hide/show element in list module

Showing or hiding an element with workspace selected will result in
Error: Could not be edited in offline workspace...

Change-Id: I768320084fd24917d22cbc1d01b47387da863605
Resolves: #20598
Releases: 4.7, 4.6, 4,5
Reviewed-on: http://review.typo3.org/6703
Reviewed-by: Georg Ringer
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[BUGFIX] RTE doesn't allow to create links around images in IE8
Stanislas Rolland [Thu, 10 Nov 2011 15:17:42 +0000 (10:17 -0500)]
[BUGFIX] RTE doesn't allow to create links around images in IE8

Solution: Workaround IE bookmarking not being possible on control range

Change-Id: I101ce32a9319a020fe72df237f10b9146313e18b
Resolves: #30631
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/6616
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
7 years ago[BUGFIX] Recycler: Wrong placed brackets
Marc Bastian Heinrichs [Mon, 8 Aug 2011 22:38:09 +0000 (00:38 +0200)]
[BUGFIX] Recycler: Wrong placed brackets

Change-Id: I925f89a0f786c9976ae7779696ffa76c823a9367
Resolves: #28835
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/6696
Reviewed-by: Simon Schaufelberger
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[BUGFIX] Live search does not find all tables
Francois Suter [Fri, 11 Nov 2011 15:07:29 +0000 (16:07 +0100)]
[BUGFIX] Live search does not find all tables

To find anything in a given table, the live search loops on all that
table's columns. However it forgets to load the full TCA beforehand
and thus fails to find anything in tables for which it is not
fully loaded yet.

Change-Id: Ief94a26d5ba9ead77930835e61ebae3b01980368
Fixes: #31760
Releases: 4.5
Reviewed-on: http://review.typo3.org/6631
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[BUGFIX] Extension configuration of saltedpasswords broken
Markus Klein [Wed, 2 Nov 2011 07:40:20 +0000 (02:40 -0500)]
[BUGFIX] Extension configuration of saltedpasswords broken

Back ported code from task #31501 breaks the the configuration page
of the saltedpasswords extension in EM.

Change-Id: Iccc74028261184e3ee74339b384a4598eb5fb3c5
Fixes: #31501
Relates: #31178
Releases: 4.5, 4.4
Reviewed-on: http://review.typo3.org/6498
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Marcus Krause
Tested-by: Marcus Krause
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] Deprecation warning with disabled ImageMagick
Steffen Gebert [Sat, 5 Nov 2011 12:29:57 +0000 (13:29 +0100)]
[BUGFIX] Deprecation warning with disabled ImageMagick

Although the use of ImageMagick is disabled (by setting
$TYPO3_CONF_VARS['GFX']['im'] = 0), an deprecation log entry is
generated, because the configuration setting for a recent ImageMagick
or GraphicsMagick version (im_version_5) is not used.

Change-Id: Ia578d056f2909a6b86a95a4989942e50ace8ddd2
Fixes: #31596
Releases: 4.5
Reviewed-on: http://review.typo3.org/6556
Reviewed-by: Georg Ringer
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Tested-by: Steffen Gebert
7 years ago[BUGFIX] Disambiguate labels in exclude fields list
Francois Suter [Fri, 4 Nov 2011 12:54:26 +0000 (13:54 +0100)]
[BUGFIX] Disambiguate labels in exclude fields list

When defining access lists for be_groups, all exclude fields are
listed for selection, ordered alphabetically per table and field
label. It may happen that some fields have the same label within
the same table. This causes confusion.

This patch adds the field's name next to its label to avoid
confusion.

Change-Id: I503c8a2e547c749a8bdcc19d70abe2d2471e6650
Fixes: #25236
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6559
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[TASK] Add missing tslib_content_abstract::getContentObject()
Rens [Mon, 17 Oct 2011 09:15:39 +0000 (11:15 +0200)]
[TASK] Add missing tslib_content_abstract::getContentObject()

Without this getter method there's no clean way to access the current
tslib_cObj object from a custom media renderer for example.

Change-Id: I984f7cd6b6bae3245f0804f9b6bf35a9e20e15ca
Resolves: #30994
Releases: 4.5, 4.6, 5.7
Reviewed-on: http://review.typo3.org/6526
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Options checkboxes are hidden in BE admin user form
Markus Klein [Mon, 31 Oct 2011 18:34:44 +0000 (13:34 -0500)]
[BUGFIX] Options checkboxes are hidden in BE admin user form

The options field is hidden in the BE user form if the user is admin.
This is a problem if the admin has assigned groups with db_mounts,
as the default value for the options is to mount also the group's mounts,
which is undesired for most instances.

Change-Id: I5f0d46162b58f7d5f9cb998830b0c39a39467376
Fixes: #30492
Releases: 4.7, 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/6524
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[BUGFIX] Fix typo in class.t3lib_div.php
Stefano Kowalke [Mon, 31 Oct 2011 15:21:41 +0000 (10:21 -0500)]
[BUGFIX] Fix typo in class.t3lib_div.php

Change "$includeEmtpyValues" into "$includeEmptyValues"

Change-Id: I1866c388f48d488fd2abcc2aade90064960f1c8e
Fixes: #26351
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/6397
Reviewed-by: Marcus Krause
Tested-by: Marcus Krause
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Preview message causes javascript errors
Jigal van Hemert [Mon, 17 Oct 2011 20:21:06 +0000 (22:21 +0200)]
[BUGFIX] Preview message causes javascript errors

Placing the preview message just before the closing body tag prevents it from
interfering with the (x)HTML structure.

Change-Id: I029099989678c011ecaf1397ef6932323fbd0d85
Fixes: #30897
Releases: 4.5
Reviewed-on: http://review.typo3.org/5919
Reviewed-by: Georg Ringer
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] Install tool stays open if ENABLE_INSTALL_TOOL is not writable
Lucas Jenss [Sun, 11 Sep 2011 23:10:26 +0000 (01:10 +0200)]
[BUGFIX] Install tool stays open if ENABLE_INSTALL_TOOL is not writable

Recognize if the ENABLE_INSTALL_TOOL file deletion fails
and keep the install tool closed in this case.

Change-Id: I9804e2c6455768699a8b2ad11be4854bd3e359c6
Fixes: #29674
Releases: 4.7, 4.6, 4.5
Reviewed-on: http://review.typo3.org/6356
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] EM: Confusing error message when uploading an extension to TER that is not...
Ernesto Baschny [Wed, 26 Oct 2011 10:29:14 +0000 (12:29 +0200)]
[BUGFIX] EM: Confusing error message when uploading an extension to TER that is not registered

Change-Id: I3e063e41929306b880f638bc268b5e221f44c77b
Fixes: #31309
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/6346
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[CLEANUP] Remove code duplication in saltedpasswords
Andreas Wolf [Mon, 6 Jun 2011 21:12:45 +0000 (23:12 +0200)]
[CLEANUP] Remove code duplication in saltedpasswords

There is some duplicate code in tx_saltedpasswords_sv1::authUser(). This
patch removes the code, making it more readable.

Change-Id: Iba2ce5605ba0fb5ca9ce510cc33eca1bf19b69b2
Resolves: #29157
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3041
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[BUGFIX] showAccessRestrictedPages doesn't replace links to restricted subpages
Sven Teuber [Thu, 17 Mar 2011 10:25:28 +0000 (11:25 +0100)]
[BUGFIX] showAccessRestrictedPages doesn't replace links to restricted subpages

When creating a menu with showAccessRestrictedPages set to any PID, links to pages
that inherit an access restriction ("include subpages" set on a parent page)
won't be substituted.

Change-Id: I459aa01a8aba89ce361accd3dd84ea0329c5d1e4
Resolves: #15984
Reviewed-on: http://review.typo3.org/2545
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 25 Oct 2011 09:54:36 +0000 (11:54 +0200)]
[TASK] Raise submodule pointer

Change-Id: I9c82be427e90d0ff4100e4df639b7ddc75be77bf
Reviewed-on: http://review.typo3.org/6312
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[TASK] Update INSTALL.txt
Oliver Hader [Tue, 25 Oct 2011 08:18:19 +0000 (10:18 +0200)]
[TASK] Update INSTALL.txt

Change-Id: I0ad7fe51b1f918a95430f190e3ab430ca8e67b0d
Reviewed-on: http://review.typo3.org/6291
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Incorrect display of Flexform UTF8 labels
Juergen Kussmann [Mon, 24 Oct 2011 00:29:48 +0000 (19:29 -0500)]
[BUGFIX] Incorrect display of Flexform UTF8 labels

UTF8 labels and options are displayed incorrectly in Flexforms.

Change-Id: Ib0ef81b995f1b6c35b7a216c4415f81b1dd8ded6
Resolves: #28952, #29067
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6209
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] TCA: Suggest wizard doesn't work in wizard_edit popup
Laurent Cherpit [Thu, 11 Aug 2011 15:48:02 +0000 (17:48 +0200)]
[BUGFIX] TCA: Suggest wizard doesn't work in wizard_edit popup

When suggest wizard is used in a form open from the wizard_edit
popup wizard, javascript cannot access to "top.TS.PATH_typo3" value.

Change-Id: I9456e5cb632520aa64e4c107cb29ff84e47460ec
Resolves: #28930
Related: #23789
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/6250
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] FlexForm field selector missing
Armin Ruediger Vieweg [Wed, 12 Oct 2011 12:02:31 +0000 (14:02 +0200)]
[BUGFIX] FlexForm field selector missing

Change-Id: I2773e482d0e2c4b263394d2456dcc32afac343a8
Resolves: #30768
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6252
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Fatal Error in Page Tree filter
Steffen Ritter [Sun, 23 Oct 2011 21:34:50 +0000 (23:34 +0200)]
[BUGFIX] Fatal Error in Page Tree filter

When entering short numeric values in the Page Tree filter of a large
tree, a PHP Fatal Error can occur:
Call to a member function offsetExists() on a non-object.

Change-Id: I8d05c34741ec40dfa15b414e206cde8495df73ec
Resolves: #28297
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6248
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Fix misleading SQL error message in TCEforms
Xavier Perseguers [Mon, 24 Oct 2011 18:48:24 +0000 (20:48 +0200)]
[BUGFIX] Fix misleading SQL error message in TCEforms

When an SQL error occurs, TCEforms shows the error message
"This may indicate a table defined in tables.php is not
existing in the database!"

The error can be caused by any schema mismatch, not only
missing table, so this is misleading.

The error message is now localizable and gives a hint to
run the database compare in the install tool.

Change-Id: I8083463f70dd27a83bb681577ba751b1b6044f2a
Resolves: #16306
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6257
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Check for rsaauth being usable
Steffen Gebert [Fri, 21 Oct 2011 19:39:44 +0000 (21:39 +0200)]
[BUGFIX] Check for rsaauth being usable

The Extension Manager shows the results of some checks in the
Configuration section of the extension "saltedpasswords", whether
"rsaauth" is loaded and whether it is enabled.

However, it lacks a check for "rsaauth" being really able to work.
If "rsaauth" fails, tell the user that OpenSSL extension is not available
or not working correctly.

Change-Id: I80186c989d399fc88b601475a83637f0b71cbb3c
Resolves: #31178
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/6267
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Leading and trailing blanks can't be edited by the RTE
Stanislas Rolland [Fri, 2 Sep 2011 21:08:14 +0000 (17:08 -0400)]
[BUGFIX] Leading and trailing blanks can't be edited by the RTE

This patch will:
1. collapse repeating spaces into a single one;
2. replace leading and trailing spaces with non-breaking spaces;
3. replace any space following > and any space preceding < by a
   non-breaking space.

Change-Id: I630249ddf143c401706688a10867ddd33493f971
Resolves: #16217
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/6258
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Enable "0" as token for TypoScript split function
Sebastiaan de Jonge [Fri, 21 Oct 2011 13:21:51 +0000 (15:21 +0200)]
[BUGFIX] Enable "0" as token for TypoScript split function

Change-Id: I35f997ba166e80d4d504bca02eeb10784b1a6117
Resolves: #31062
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/6194
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] impexp links to invalid EM path
Markus Klein [Fri, 21 Oct 2011 23:59:05 +0000 (18:59 -0500)]
[BUGFIX] impexp links to invalid EM path

impexp sysext links to invalid Extension Manager path,
in order to install extension dependencies.

Change-Id: I517fed495d6280f4839e157083c7de2abc6bf129
Resolves: #31173
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6193
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Improve check for started session in rsaauth
Helmut Hummel [Sun, 25 Sep 2011 10:54:31 +0000 (12:54 +0200)]
[BUGFIX] Improve check for started session in rsaauth

Checking if the superglobal $_SESSION is an array is not reliable.
Change the check to use session_id() which is an empty string
if the session has not been started.

Resolves: #30270
Releases: 4.3, 4.4, 4.5, 4.6

Change-Id: I00d03ae70f3953e8efa3c5c473efa1852ba4c5ec
Reviewed-on: http://review.typo3.org/6190
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Limit workspace access checks if extension not used
Tolleiv Nietsch [Mon, 17 Oct 2011 16:47:35 +0000 (18:47 +0200)]
[BUGFIX] Limit workspace access checks if extension not used

In some cases the access to a workspace is checked even
if EXT:workspaces is not installed. This should be avoided
whenever possible.

Change-Id: Ief4f030134359e9d2b27b82ae4c5de6a7b5b800e
Fixes: #30870
Branches: 4.6, 4.5
Reviewed-on: http://review.typo3.org/6073
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] date expects parameter 2 to be long, string given
Simon Schaufelberger [Sat, 15 Oct 2011 09:38:13 +0000 (11:38 +0200)]
[BUGFIX] date expects parameter 2 to be long, string given

Any zero length string value is replaced with the current timestamp.
(Just like the default value for the second parameter of date/gmdate.)

Change-Id: I231b704c3df181486c37497e0dc6f10baf1d267e
Fixes: #30931
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/5970
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Set TYPO3 version to 4.5.8-dev
TYPO3 v4 Release Team [Tue, 18 Oct 2011 09:21:58 +0000 (11:21 +0200)]
[TASK] Set TYPO3 version to 4.5.8-dev

Change-Id: Iec43828019dc1a9152eb0d0b0b8379df680a66c2
Reviewed-on: http://review.typo3.org/5948
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.5.7
TYPO3 v4 Release Team [Tue, 18 Oct 2011 09:21:49 +0000 (11:21 +0200)]
[RELEASE] Release of TYPO3 4.5.7

Change-Id: I39e002ca9870dc814f45dca7617d35f59be8fbe3
Reviewed-on: http://review.typo3.org/5947
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[TASK][SECURITY] Merge linkvalidator for 4.5.7
Philipp Gampe [Tue, 18 Oct 2011 09:02:26 +0000 (11:02 +0200)]
[TASK][SECURITY] Merge linkvalidator for 4.5.7

The only change is:
f9d0263 [TASK] Merge linkvalidator for 4.5.7
4050d07 [BUGFIX][SECURITY] SQL Injection in Scheduler Task of
Linkvalidator

Change-Id: Idd6d9701f1e153e9f510728445b72917592eec96
Resolves: #31051
Releases: 4.5
Reviewed-on: http://review.typo3.org/5941
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
7 years ago[BUGFIX] Old EM: t3lib_DB::exec_INSERTquery errors
Jigal van Hemert [Sat, 6 Aug 2011 09:01:04 +0000 (11:01 +0200)]
[BUGFIX] Old EM: t3lib_DB::exec_INSERTquery errors

storeXMLResult() fails to filter non-existing database fields and
tries to insert all fields which it parses from the XML. Solution
is to use a default record structure to only use existing column names.

Change-Id: I3b51a819e13602e767e3790c81e22f29debc845d
Fixes: #28637
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5937
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Skip missing icons in tceforms select options
Peter Niederlag(office) [Wed, 28 Sep 2011 07:55:32 +0000 (09:55 +0200)]
[BUGFIX] Skip missing icons in tceforms select options

Check existance of file before adding background style url

Change-Id: I78619069090d7af64b858f93b9d7fedeb8014324
Fixes: #24591
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5887
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 11 Oct 2011 11:44:37 +0000 (13:44 +0200)]
[TASK] Raise submodule pointer

Change-Id: I1554a3fe365b6c1a6d6c4b86f59ad14bf0ebfe22
Reviewed-on: http://review.typo3.org/5717
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Showmodule cannot be called before Store is loaded
Oliver Hader [Mon, 10 Oct 2011 21:24:41 +0000 (23:24 +0200)]
[BUGFIX] Showmodule cannot be called before Store is loaded

Example: Using the direct page edit feature (backend.php?edit=xxx)
the BE responds with "Module loader No module found. If this is a
temporary error, please reload the Backend!" error.

Since the AJAX request is not finished at the time this is called,
it has to be checked whether the store was completely loaded.

Change-Id: I555427d61845678c1f90e2039c41cdd2055e5b6a
Releases: 4.6,4.5
Resolves: #28951
Reviewed-on: http://review.typo3.org/5712
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Replace debug with call to deprecationLog
Tolleiv Nietsch [Mon, 10 Oct 2011 01:03:08 +0000 (03:03 +0200)]
[BUGFIX] Replace debug with call to deprecationLog

Commit 0eb4686afb2ed871adf3376ad12cb069d4a3f88d wrongly introduced
a debug() statement instead of a call to the deprecationLog()
method.

Change-Id: I996203d09e9557cfb301d079bbb026a32626c0d5
Resolves: #30759
Branches: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5696
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] EM: Remove nested form tag
Helmut Hummel [Mon, 10 Oct 2011 20:56:28 +0000 (22:56 +0200)]
[BUGFIX] EM: Remove nested form tag

In the new EM in the extension configuration settings it is not possible
to switch between extension configuration categories in some browsers.
This is caused by a nested form tag which will be removed with this commit.

Change-Id: Ie4e4d5f33d319467626aa4923abe07d608af9bbb
Resolves: #30257
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5708
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Wrong alignment of French labels for login screen
Eric Chavaillaz [Sun, 9 Oct 2011 15:14:53 +0000 (17:14 +0200)]
[BUGFIX] Wrong alignment of French labels for login screen

Since the username label changed from "Utilisateur" to "Nom d'utilisateur"
in French, the alignment of labels and text fields is broken.

Change-Id: Ie48a1150be04e0959f4db45ff602efbd2504cd5c
Fixes: #30688
Releases: 4.5,4.6
Reviewed-on: http://review.typo3.org/5704
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] handler is undefined when resizing the backend
Simon Schaufelberger [Sat, 8 Oct 2011 16:20:48 +0000 (18:20 +0200)]
[BUGFIX] handler is undefined when resizing the backend

Resizing the backend browser window results in a JavaScript error.
The function that handles the re-positioning of the menus does not
work correctly. The observer requires a reference to a callback
function - currently the method was directly executed and the return
value used as function reference, which was undefined in this case.

Change-Id: I15f3bab4c3c59c5c96633423ac7cd0ebd1736a1a
Resolves: #25787
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5694
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Race-condition while updating extension list
Steffen Gebert [Sat, 8 Oct 2011 22:18:16 +0000 (00:18 +0200)]
[BUGFIX] Race-condition while updating extension list

There is a race-condition in the EM while updating the extension list.

If the update takes more than 30 seconds, Ext.Direct reaches its Ajax
timeout and sends the Ajax request (to update the list) again. As the EM
updates the extensions.xml.gz file at the beginning of the update
process, the second request immediately sees that the repository is
already up-to-date and respons this status to the client.

Thus, the user gets a "Repository is already up-to-date" message shown,
although it was not.

Change-Id: I7b45fc4e4ec8482d58eb771bba9d64a8c034daef
Resolves: #30673
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5686
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] Copyright year in HTML comment is hardcoded
Andreas Wolf [Mon, 10 Oct 2011 12:05:33 +0000 (14:05 +0200)]
[BUGFIX] Copyright year in HTML comment is hardcoded

The copyright year in the HTML comment is hardcoded as 1998-2009. This
should be changed to using the constant.

Change-Id: Idd07e50b515fc495512295c5557c4aeafbc8b549
Resolves: #30725
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5668
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Typo in gifbuilder
Simon Schaufelberger [Thu, 6 Oct 2011 10:13:31 +0000 (12:13 +0200)]
[BUGFIX] Typo in gifbuilder

stdWrap features GIFBUILDER transparentBackground and reduceColors
are broken

Change-Id: Ie162c1cf851dc237d3fa9a569c6dfb705c5f339c
Resolves: #29445
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5628
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] PHP warning on each Extension Manager invocation
Dmitry Dulepov [Thu, 6 Oct 2011 07:48:04 +0000 (10:48 +0300)]
[BUGFIX] PHP warning on each Extension Manager invocation

Extension manager produces a PHP warning on each invocation due to
incorrect parameters passed to t3lib_div::trimExplode().

Change-Id: I7f33221cb9068b6d914951f045ce4dc1e0bcaa37
Resolves: #30598
Releases: 4.6,4.5
Reviewed-on: http://review.typo3.org/5621
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] EM, Error when downloading extension files
Markus Klein [Wed, 5 Oct 2011 23:59:44 +0000 (18:59 -0500)]
[BUGFIX] EM, Error when downloading extension files

Trying to download a file using the Edit Files page of the old EM
leads to a fatal error, because URL is not decoded properly.

Change-Id: Ibd8f71fbc0ff8d9761b35cde713c3c021c6eb31e
Resolves: #27098
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5579
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Stefan
Tested-by: Stefan
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] EM installs outdated versions of depending extensions
Steffen Gebert [Wed, 5 Oct 2011 20:11:13 +0000 (22:11 +0200)]
[BUGFIX] EM installs outdated versions of depending extensions

When installing an extension with a dependency to another extension,
which is not available on the server, EM retrieves it from TER. However,
by mistake it always retrieves the oldest version, not the newest.

Change-Id: I5b630ddc744670c48fc5d86856ca6ae46806fcf6
Resolves: #29243
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5598
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] RTE: Tag attributes are reversed on save
Stanislas Rolland [Wed, 5 Oct 2011 01:07:21 +0000 (21:07 -0400)]
[BUGFIX] RTE: Tag attributes are reversed on save

Problem: When saving a content element, the order of attributes of tags
is reversed. This clutters the workspace diffs with many changes. The
problem arises in WebKit and Opera.
Solution: Reverse the order of attributes.

Change-Id: I8de914e0f10b043c106c1cacba3e17579d43e699
Resolves: #29855
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5536
Reviewed-by: Markus Klein
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] meaningfulTempFilePrefix is not multi-byte safe
Steffen Gebert [Sun, 2 Oct 2011 08:23:59 +0000 (10:23 +0200)]
[BUGFIX] meaningfulTempFilePrefix is not multi-byte safe

On a utf-8 file system meaningful prefixes can contain utf-8 characters. To
prevent truncating in the middle of a multi-byte character the API functions
must be used instead of substr().

Change-Id: Icf1a0cd1c095402cd31768ac732ec9bc9dfe7519
Resolves: #30416
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5572
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] t3lib_Compressor breaks absolute paths in CSS
Andreas Bouche [Tue, 20 Sep 2011 13:45:57 +0000 (15:45 +0200)]
[BUGFIX] t3lib_Compressor breaks absolute paths in CSS

Adds a negative lookahead for trailing slash to the regular
Expressions in method "cssFixRelativeUrlPaths" to exclude
absolute paths from being rewritten.

Change-Id: I4f306e314cab748a24d3e25fcb9a86a28e12384a
Resolves: #29904
Releases: 4.5
Reviewed-on: http://review.typo3.org/5123
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[BUGFIX] Email links marked as external when preceded by external link
Stanislas Rolland [Tue, 4 Oct 2011 16:46:47 +0000 (12:46 -0400)]
[BUGFIX] Email links marked as external when preceded by external link

Variable is not initialized leading to incorrect transformation
on way to RTE.

Change-Id: If83c2c8b04def953cbc95f617a14111e7641a867
Resolves: #29782
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5539
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE: Add TYPO3 version to hash of cached scripts
Stanislas Rolland [Tue, 4 Oct 2011 03:51:22 +0000 (23:51 -0400)]
[BUGFIX] RTE: Add TYPO3 version to hash of cached scripts

Problem: Fixed JS scripts may not be loaded when a new version of
TYPO3 is released. This may happen if the version of htmlArea RTE was
not incremented. This is an error-prone situation.
Solution: Add TYPO3 version to hash of cached scripts

Change-Id: I8c4c63060034aafc5ac75bd17196c1847fa6357e
Resolves: #30534
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5512
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[TASK] Update reference from SVN to Git
Helmut Hummel [Thu, 22 Sep 2011 20:22:25 +0000 (22:22 +0200)]
[TASK] Update reference from SVN to Git

Module About TYPO3 shows this text:
The SVN Repository and the ChangeLog can be found here.

This has to be updated to read "Git" instead of "SVN".

Change-Id: I8e708f9e47e5afa5f4528bd308ca13b7f2535364
Resolves: #30171
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5240
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX][t3editor] typolinkEnableLinksAcrossDomains missing
Steffen Gebert [Thu, 22 Sep 2011 10:34:03 +0000 (12:34 +0200)]
[BUGFIX][t3editor] typolinkEnableLinksAcrossDomains missing

The description for config.typolinkEnableLinksAcrossDomains is missing
in the t3editor auto-completion.

Change-Id: I65ca26340dae7d960bdab162cb6d3729c85d19e7
Fixes: #27697
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5204
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] Label status_configuration_PhpSafeModeEnabled is not retrieved
Xavier Perseguers [Tue, 20 Sep 2011 09:21:36 +0000 (11:21 +0200)]
[BUGFIX] Label status_configuration_PhpSafeModeEnabled is not retrieved

Wrong method is used to retrieve label status_configuration_PhpSafeModeEnabled.

Change-Id: Ia870d88ea4ce3c8582f02dd40a8655fd115145fd
Fixes: #30081
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5103
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] t3editor not visible with TYPO3 on Windows
Jigal van Hemert [Mon, 19 Sep 2011 11:51:31 +0000 (13:51 +0200)]
[BUGFIX] t3editor not visible with TYPO3 on Windows

The template for t3editor contains CRLF line endings on Windows systems. To
prevent JS errors and to make the t3editor visible the CR parts of the line
endings must be removed.

Change-Id: I6e4e7d3b7045c1327f79300874f1539e407f77a5
Fixes: #30026
Branches: 4.5
Reviewed-on: http://review.typo3.org/5069
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig
7 years ago[BUGFIX] Don't unnecessarily start PHP session
Helmut Hummel [Sat, 17 Sep 2011 15:59:51 +0000 (17:59 +0200)]
[BUGFIX] Don't unnecessarily start PHP session

Because of an information disclosure problem in the backend login
we moved the session_start() in t3lib_userauth in a place which caused
unwanted side effects with 3rd party extensions.

Revert that change to avoid compatibility and performance problems
and instead send no cache headers earlier in t3lib_userauth
to also fix the information disclosure.

Releases: 4.3, 4.4, 4.5, 4.6
Resolves: #29274
Related: #24456, #28694

Change-Id: I87226a21d9b1955773ceb3c377fa1b4c9938e6b2
Reviewed-on: http://review.typo3.org/5070
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Show extension configuration after extension update
Helmut Hummel [Sat, 10 Sep 2011 10:28:27 +0000 (12:28 +0200)]
[BUGFIX] Show extension configuration after extension update

When updating an extension, updates of database tables are not
shown and not offered to be updated. Thus they remain unnoticed
and this leads to unexpected results.

Show extension configuration and database updates after updating an extension.

Resolves: #29625
Releases: 4.5, 4.6

Change-Id: I82281494b71cd9fa38235ebafaa2b2423d15436d
Reviewed-on: http://review.typo3.org/5036
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Fix backpath for add wizards in IRRE records (Backport fix from master)
Sebastian Fischer [Wed, 14 Sep 2011 13:09:37 +0000 (15:09 +0200)]
[BUGFIX] Fix backpath for add wizards in IRRE records (Backport fix from master)

As in typo3/init.php the TYPO3_mainDir is set to 'typo3/' the replacement in
renderForeignRecord could not work because it uses the TYPO3_mainDir . '%2Fajax.php'
which results in typo3//ajax.php
By this the backpath of the add wizard in IRRE foreign records is fixed.

Change-Id: I1a3c5274783609127ba29d0546c55450cecd1cd2
Resolves: #29770
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/5017
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] About modules: Adjust bgcolor of sections
Tomas Norre Mikkelsen [Sat, 17 Sep 2011 13:55:17 +0000 (15:55 +0200)]
[BUGFIX] About modules: Adjust bgcolor of sections

Adjust the background color of the module section table cells to match
the "body" background color.

Change-Id: I23389a7099bc67b3aa51d27feb5276360110e877
Resolves: #27589
Reviewed-on: http://review.typo3.org/5005
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[TASK] Add SwiftMailer license exception to be included in TYPO3v4
Ernesto Baschny [Thu, 15 Sep 2011 10:00:03 +0000 (12:00 +0200)]
[TASK] Add SwiftMailer license exception to be included in TYPO3v4

Change-Id: Iaf1420f28b1bc4945aacd4f8183cd2ec33513270
Resolves: #29802
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4978
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Set TYPO3 version to 4.5.7-dev
TYPO3 v4 Release Team [Wed, 14 Sep 2011 09:45:42 +0000 (11:45 +0200)]
[TASK] Set TYPO3 version to 4.5.7-dev

Change-Id: I2e00897f141ca4c39160af6a026b579e64346545
Reviewed-on: http://review.typo3.org/4967
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.5.6
TYPO3 v4 Release Team [Wed, 14 Sep 2011 09:45:33 +0000 (11:45 +0200)]
[RELEASE] Release of TYPO3 4.5.6

Change-Id: I28d6e97414da1188993de8fdbd5337cd1d2b18cc
Reviewed-on: http://review.typo3.org/4966
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] SQL Injection vulnerability in prepared statements
Helmut Hummel [Tue, 13 Sep 2011 18:32:19 +0000 (20:32 +0200)]
[BUGFIX] SQL Injection vulnerability in prepared statements

Change-Id: Id8a12b1782d9169d650249e06520b4046d504fd2
Resolves: #29400
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4960
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Disabling the cache does not work on invalid cHash value
Daniel Pötzinger [Tue, 30 Aug 2011 20:40:31 +0000 (22:40 +0200)]
[BUGFIX] Disabling the cache does not work on invalid cHash value

Change-Id: Ia58a6eafc9cf6d02ee6066d2c2d4b976505399f1
Releases: 4.6, 4.5, 4.4, 4.3
Resolves: #29366
Reviewed-on: http://review.typo3.org/4942
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] RTE: External links not updated to internal by link dialogue
Stanislas Rolland [Mon, 5 Sep 2011 15:10:59 +0000 (11:10 -0400)]
[BUGFIX] RTE: External links not updated to internal by link dialogue

Solution: Remove external attribute when switching to other type
of link.

Change-Id: I94762da2fe19cf2cf91f6af755234347aef942ab
Resolves: #29167
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4773
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE may overwrite link text in IE
Stanislas Rolland [Fri, 9 Sep 2011 03:42:10 +0000 (23:42 -0400)]
[BUGFIX] RTE may overwrite link text in IE

Problem: In IE, setting the link node href attribute may update the link
content when the content is recognized by IE as an url.
Solution: Workaround the IE feature and restore the link content.

Change-Id: Ic1ed947206aa756296c25d4e3f9c40b9fc1e26e5
Resolves: #29527, #25464
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4864
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] FE session transfer is broken
Dmitry Dulepov [Mon, 4 Jul 2011 14:41:13 +0000 (16:41 +0200)]
[BUGFIX] FE session transfer is broken

The fix for #M13740 (revision 3a3a8d81) breaks FE session
transfer across top level domains.

Method tslib_fe::initFEuser() checks if there is a special
URL parameter named FE_SESSION_KEY. If that exists, it sets
$_COOKIE[$this->fe_user->name] to the passed session value.
This is very useful when using RealURL's feature to make
different language domains but use the same user for all
domains (multilanguage countries like Switzerland
or Belgium love that). However this is broken by using
$_SERVER['HTTP_COOKIE'] for FE session cookie. tslib_fe
has to be adjusted to set the same cookie.

Change-Id: I9042b8668cd392bfd95262481918683e886da32d
Resolves: #27740
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/3034
Reviewed-by: Stefan Neufeind
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[BUGFIX] Padding of RTE statusbar is too big
Stanislas Rolland [Wed, 7 Sep 2011 17:18:39 +0000 (13:18 -0400)]
[BUGFIX] Padding of RTE statusbar is too big

onLayout produces incorrect results when executed on a hidden element.

Change-Id: Iebba44be9e51812458d14c525ad30136939f3f30
Resolves: #29485
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4831
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE only loads styles from external css file on reload in IE8
Stanislas Rolland [Thu, 25 Aug 2011 02:49:30 +0000 (22:49 -0400)]
[BUGFIX] RTE only loads styles from external css file on reload in IE8

Problem: The script fails to detect that a stylesheet is not loaded
Solution: Check for empty rules and imports arrays of skin and
content stylesheets.

Change-Id: Ia8bdac51f52f07b4028af2c8613ee8f7324a6e91
Resolves: #29234
Releases: 4.4, 4.5
Reviewed-on: http://review.typo3.org/4833
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] High CPU load in IE8/9 when using context menu in htmlArea RTE
Stanislas Rolland [Thu, 1 Sep 2011 16:55:05 +0000 (12:55 -0400)]
[BUGFIX] High CPU load in IE8/9 when using context menu in htmlArea RTE

Cleanup event listeners.

Change-Id: Ic92ef7df49c9b6266e51f6193ec2611ea3431fe3
Resolves: #29361
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4732
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE context menu adds unwanted id attribute to target
Stanislas Rolland [Thu, 1 Sep 2011 14:23:22 +0000 (10:23 -0400)]
[BUGFIX] RTE context menu adds unwanted id attribute to target

The context menu plugin uses Ext.get on the target element. ExtJs thus adds an unwanted id attribute to content.

Solution: Use Ext.fly rather than Ext.get.

Change-Id: I02d706badc8c3cacbb9ed39baf1ae058359c0a23
Resolves: #29421
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4721
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Incorrect behaviour of style selector in RTE
Stanislas Rolland [Wed, 24 Aug 2011 15:31:14 +0000 (11:31 -0400)]
[BUGFIX] Incorrect behaviour of style selector in RTE

When all classes allowed on an element have been assigned to a single
element, the block/text style selector becomes disabled. It is then not
possible to remove the assigned classes from this element.

Change-Id: If81a43cb4768848863bfade78f661eba3331685d
Resolves: #27801
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4574
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 30 Aug 2011 12:23:11 +0000 (14:23 +0200)]
[TASK] Raise submodule pointer

Change-Id: I45d2f86b7096ec8ed7302375be0213b88c15903c
Reviewed-on: http://review.typo3.org/4679
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Bring back recStatInfoHooks hook in Page Tree
Georg Ringer [Tue, 30 Aug 2011 12:03:14 +0000 (14:03 +0200)]
[BUGFIX] Bring back recStatInfoHooks hook in Page Tree

There was a hook 'recStatInfoHooks' in class.webpagetree.php, which is
missing in the current implementation with ExtJS.

Change-Id: Ie334ba0289e7cc49a0cbcdeb4b2f8e16d9c141fb
Resolves: #27247
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4677
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[TASK] Improve description of $TYPO3_CONF_VARS['SYS']['no_pconnect']
Christopher [Mon, 29 Aug 2011 17:50:55 +0000 (19:50 +0200)]
[TASK] Improve description of $TYPO3_CONF_VARS['SYS']['no_pconnect']

Improve the description of $TYPO3_CONF_VARS['SYS']['no_pconnect'],
so that people at least get a keyword, which they can put into
Google, when they don't know, what to set here.

Change-Id: I0a00e03b91daed62c973f4e92c1e4e9ce2c30e74
Resolves: #29304
Reviewed-on: http://review.typo3.org/4667
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] HTMLparser, treat fixAttrib.unset as boolean
Markus Klein [Thu, 25 Aug 2011 18:12:37 +0000 (13:12 -0500)]
[BUGFIX] HTMLparser, treat fixAttrib.unset as boolean

HTMLparser_tags fixAttrib.unset is documented to be boolean, but is
currently treated as string.
This patch corrects for the expected behavior.

Change-Id: Ie063cfd2f7aab0a09c712faefb31c3894f651d79
Resolves: #29246
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/4644
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] RTE breaks mailto links in Firefox
Stanislas Rolland [Sun, 28 Aug 2011 14:15:18 +0000 (10:15 -0400)]
[BUGFIX] RTE breaks mailto links in Firefox

mailto link are incorrectly prefixed with base url

Change-Id: Ic386148279228c9f3397ccf6480800f033782cc2
Resolves: #29141
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4665
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] t3lib_div::cmpFQDN() lacks support for IPv6 and hostnames
Stefan Neufeind [Tue, 12 Jul 2011 08:16:01 +0000 (10:16 +0200)]
[BUGFIX] t3lib_div::cmpFQDN() lacks support for IPv6 and hostnames

Add checks for IPv4 and IPv6. Otherwise take input as hostname.
Implement correct (recursive) wildcard-checks.
Add unit tests.

Change-Id: I15328839d28746c68d7ef108b783c1ffe40d99cd
Resolves: #27217
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3924
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Add DB structure update pre-processing hook in EM
Xavier Perseguers [Fri, 26 Aug 2011 10:04:27 +0000 (12:04 +0200)]
[BUGFIX] Add DB structure update pre-processing hook in EM

Extension Manager lacks a way to perform actions prior to modifying the database
structure (create new tables or add additional fields in existing ones) when
installing an extension.

This would be very handy for DBAL to let user update mapping definition from within
TYPO3 without the need to first manually edit typo3conf/localconf.php.

This is a bugfix as the feature had been accepted for 4.5.0beta1 and was wrongly
removed during Extension Manager refactoring task. In fact, the interface is still
here but never used.

Change-Id: Ia7e7035193c3448333cecc268cc3f61479e6f13d
Fixes: #23877
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4615
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Message about missing db credentials is misleading
Christopher [Sun, 28 Aug 2011 18:57:49 +0000 (20:57 +0200)]
[BUGFIX] Message about missing db credentials is misleading

If persistent connections are not allowed by MySQL the error message
"Can only select database if username/password/host is correctly set
first." is shown. Add an explanation that
$TYPO3_CONF_VARS['SYS']['no_pconnect'] must be set to 1, if persistent
connections are not allowed.

Change-Id: I4e52a3e8aefa4b4b716aba39e3bee8d1e681bca7
Fixes: #29245
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4643
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] TCA Tree should respect requestUpdate and type
Marco Huber [Thu, 24 Mar 2011 08:50:04 +0000 (09:50 +0100)]
[BUGFIX] TCA Tree should respect requestUpdate and type

TCA Tree should respect $TCA['myTable']['ctrl']['requestUpdate']
and $TCA['myTable']['type'], but the onChange Javascript is missing.

Change-Id: If2c7997c9627249e3f643c9670a2a9d4ba94103a
Resolves: #25382
Reviewed-on: http://review.typo3.org/3402
Reviewed-by: Lars Trebing
Tested-by: Lars Trebing
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] 'Update settings' button does not work in new em
Susanne Moog [Mon, 22 Aug 2011 18:55:28 +0000 (20:55 +0200)]
[BUGFIX] 'Update settings' button does not work in new em

After installing an extension you get a popup where you can
update the configuration settings of an extension. In the new
extension manager the update button there will not work as it
is a submit button but the form around the fields is missing.

Attached patch simply inserts the form in this case, too.

Change-Id: Iaa2eb8876e96bbe7d3120cd124c37d29815647fb
Resolves: #29172
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4629
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] exec_SELECTcountRows returns string
Georg Ringer [Tue, 23 Aug 2011 04:04:06 +0000 (06:04 +0200)]
[BUGFIX] exec_SELECTcountRows returns string

PHPdoc states that return value is either FALSE if
something strange happened or integer with the count of
records.

MySql returns strings, so an intval is needed to have integers

Change-Id: Ia4e7ff88620ac861f40035ab4f97a20d81115ea7
Resolves: #29169
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4567
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Remove check for invalid prefix in addService
Christian Kuhn [Mon, 22 Aug 2011 14:53:17 +0000 (16:53 +0200)]
[BUGFIX] Remove check for invalid prefix in addService

t3lib_extMgm::addService() checks that $serviceType (eg. 'auth') does not start
with a valid class prefix. While it is probably not a good idea to prefix a
service type with 'user_' or 'tx_', there is no technical reason to enforce
this. The check especially leads to problems if
TYPO3_CONF_VARS['FE']['userFuncClassPrefix'] is set to an empty string.
This patch removes the check.

Change-Id: Iaf60da0eae61a2c64bb4626f5629b8c262d00cc2
Resolves: #29165
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4528
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Fix isAbsPath() on Windows
Daniel Hoffmann [Mon, 25 Jul 2011 06:45:42 +0000 (08:45 +0200)]
[BUGFIX] Fix isAbsPath() on Windows

Paths starting with a slash are absolute on Windows, too.

Change-Id: Ie16b9f15d384b0da07e19eea68c37bbaee5094f5
Resolves: #16798
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4465
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Some TCEforms elements are displaced
Francois Suter [Wed, 17 Aug 2011 08:50:55 +0000 (10:50 +0200)]
[BUGFIX] Some TCEforms elements are displaced

When a TCEforms field is part of a palette, a specific span tag
is added around it. A similar span tag must be added around fields
which are not part of a palette, so that we have similar behaviors.

Change-Id: If13c130423c4839b89c7f03e015feffd8ae3bd94
Resolves: #29029
Related: #28030
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4389
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Broken links representation gets saved to the database
Stanislas Rolland [Mon, 15 Aug 2011 20:31:08 +0000 (16:31 -0400)]
[BUGFIX] Broken links representation gets saved to the database

Solution: Avoid wrapping the a tag with span tag when style attribute
is set when rteerror attribute is also set.

Change-Id: I1f68a0f9a67934b9ac3288117f831219e8d30f99
Resolves: #25302
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4352
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] TYPO3 tries to connect to typo3.org on every login
Susanne Moog [Sun, 21 Aug 2011 15:42:31 +0000 (17:42 +0200)]
[BUGFIX] TYPO3 tries to connect to typo3.org on every login

If the extension cache is disabled,
the extension manager tries to establish a connection to the TER
as soon as user credentials for a user are given.

This patch changes that behavior so that it is only done for
the functions that actually need a TER call.

Additionally I did some cleanup.

Change-Id: I1633334d762d713fcf39097192ed6fa8fcfcf343
Resolves: #28949
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4456
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Fix security level "normal" for backend login
Helmut Hummel [Sat, 20 Aug 2011 17:02:45 +0000 (19:02 +0200)]
[BUGFIX] Fix security level "normal" for backend login

Only change the object property to something different than "superchallenged"
if the configuration is not set to a "standard" security level.

Resolves: #29130
Releases: 4.6, 4.5, 4.4, 4.3

Change-Id: Ibf1194d04a7159ade9ef33701e92930f98cfb90e
Reviewed-on: http://review.typo3.org/4439
Reviewed-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Also check if cache files are not empty
Jigal van Hemert [Sat, 20 Aug 2011 14:36:05 +0000 (16:36 +0200)]
[BUGFIX] Also check if cache files are not empty

If the temp_CACHED* files exist, but they are empty a lot of functions
produce incorrect result due to missing TCA data. Checking the fileSize
prevents the use of empty cache files.

Change-Id: I6c1ce468bfeec88bf8445e64e7b1bd6387f117f7
Resolves: #29075
Branches: 4.5
Reviewed-on: http://review.typo3.org/4435
Reviewed-by: Christian Kuhn
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] feedit: Use skinImage for edit icons
Bjoern Pedersen [Thu, 21 Jul 2011 09:19:24 +0000 (11:19 +0200)]
[BUGFIX] feedit: Use skinImage for edit icons

Replace hardcoded icons with t3lib_iconWorks::skinImage calls

Change-Id: I9c5270061e1355f7689eebcc35d27078931afe89
Resolves: #24920
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4443
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] "New record" button in Template mod broken
Jigal van Hemert [Thu, 18 Aug 2011 09:18:16 +0000 (11:18 +0200)]
[BUGFIX] "New record" button in Template mod broken

Recent browsers follow HTML5 standards for submitting image input
elements. The result is that the name of the image input element is
not submitted anymore, only the name with the x and y coordinates.
Checking for createExtension_x or createExtension being set makes the
button work again.

Change-Id: Ic8925930f8aee31463666ea70d0b97d5ea717d28
Resolves: #28455
Branches: 4.5
Reviewed-on: http://review.typo3.org/4441
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Indent/outdent does not work if formatblock button is disabled
Stanislas Rolland [Sun, 14 Aug 2011 15:41:25 +0000 (11:41 -0400)]
[BUGFIX] Indent/outdent does not work if formatblock button is disabled

Problem: If the "formatblock" button is disabled, the current paragraph
gets a css class "indent" but a wrapping div is not created with that
css class.

Solution: When formatblock is not configured, allow all standard block
elements. When formatblock and indent are both configured, ensure div is
allowed.

Change-Id: Ib5d3087198904bb86a4901c57f5e0f2292f4b36e
Resolves: #28903
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4321
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland