Packages/TYPO3.CMS.git
7 years ago[RELEASE] Release of TYPO3 4.5.7 47/5947/1 TYPO3_4-5-7
TYPO3 v4 Release Team [Tue, 18 Oct 2011 09:21:49 +0000 (11:21 +0200)]
[RELEASE] Release of TYPO3 4.5.7

Change-Id: I39e002ca9870dc814f45dca7617d35f59be8fbe3

7 years ago[TASK][SECURITY] Merge linkvalidator for 4.5.7
Philipp Gampe [Tue, 18 Oct 2011 09:02:26 +0000 (11:02 +0200)]
[TASK][SECURITY] Merge linkvalidator for 4.5.7

The only change is:
f9d0263 [TASK] Merge linkvalidator for 4.5.7
4050d07 [BUGFIX][SECURITY] SQL Injection in Scheduler Task of
Linkvalidator

Change-Id: Idd6d9701f1e153e9f510728445b72917592eec96
Resolves: #31051
Releases: 4.5
Reviewed-on: http://review.typo3.org/5941
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
7 years ago[BUGFIX] Old EM: t3lib_DB::exec_INSERTquery errors
Jigal van Hemert [Sat, 6 Aug 2011 09:01:04 +0000 (11:01 +0200)]
[BUGFIX] Old EM: t3lib_DB::exec_INSERTquery errors

storeXMLResult() fails to filter non-existing database fields and
tries to insert all fields which it parses from the XML. Solution
is to use a default record structure to only use existing column names.

Change-Id: I3b51a819e13602e767e3790c81e22f29debc845d
Fixes: #28637
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5937
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Skip missing icons in tceforms select options
Peter Niederlag(office) [Wed, 28 Sep 2011 07:55:32 +0000 (09:55 +0200)]
[BUGFIX] Skip missing icons in tceforms select options

Check existance of file before adding background style url

Change-Id: I78619069090d7af64b858f93b9d7fedeb8014324
Fixes: #24591
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5887
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 11 Oct 2011 11:44:37 +0000 (13:44 +0200)]
[TASK] Raise submodule pointer

Change-Id: I1554a3fe365b6c1a6d6c4b86f59ad14bf0ebfe22
Reviewed-on: http://review.typo3.org/5717
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Showmodule cannot be called before Store is loaded
Oliver Hader [Mon, 10 Oct 2011 21:24:41 +0000 (23:24 +0200)]
[BUGFIX] Showmodule cannot be called before Store is loaded

Example: Using the direct page edit feature (backend.php?edit=xxx)
the BE responds with "Module loader No module found. If this is a
temporary error, please reload the Backend!" error.

Since the AJAX request is not finished at the time this is called,
it has to be checked whether the store was completely loaded.

Change-Id: I555427d61845678c1f90e2039c41cdd2055e5b6a
Releases: 4.6,4.5
Resolves: #28951
Reviewed-on: http://review.typo3.org/5712
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Replace debug with call to deprecationLog
Tolleiv Nietsch [Mon, 10 Oct 2011 01:03:08 +0000 (03:03 +0200)]
[BUGFIX] Replace debug with call to deprecationLog

Commit 0eb4686afb2ed871adf3376ad12cb069d4a3f88d wrongly introduced
a debug() statement instead of a call to the deprecationLog()
method.

Change-Id: I996203d09e9557cfb301d079bbb026a32626c0d5
Resolves: #30759
Branches: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5696
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] EM: Remove nested form tag
Helmut Hummel [Mon, 10 Oct 2011 20:56:28 +0000 (22:56 +0200)]
[BUGFIX] EM: Remove nested form tag

In the new EM in the extension configuration settings it is not possible
to switch between extension configuration categories in some browsers.
This is caused by a nested form tag which will be removed with this commit.

Change-Id: Ie4e4d5f33d319467626aa4923abe07d608af9bbb
Resolves: #30257
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5708
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Wrong alignment of French labels for login screen
Eric Chavaillaz [Sun, 9 Oct 2011 15:14:53 +0000 (17:14 +0200)]
[BUGFIX] Wrong alignment of French labels for login screen

Since the username label changed from "Utilisateur" to "Nom d'utilisateur"
in French, the alignment of labels and text fields is broken.

Change-Id: Ie48a1150be04e0959f4db45ff602efbd2504cd5c
Fixes: #30688
Releases: 4.5,4.6
Reviewed-on: http://review.typo3.org/5704
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] handler is undefined when resizing the backend
Simon Schaufelberger [Sat, 8 Oct 2011 16:20:48 +0000 (18:20 +0200)]
[BUGFIX] handler is undefined when resizing the backend

Resizing the backend browser window results in a JavaScript error.
The function that handles the re-positioning of the menus does not
work correctly. The observer requires a reference to a callback
function - currently the method was directly executed and the return
value used as function reference, which was undefined in this case.

Change-Id: I15f3bab4c3c59c5c96633423ac7cd0ebd1736a1a
Resolves: #25787
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5694
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Race-condition while updating extension list
Steffen Gebert [Sat, 8 Oct 2011 22:18:16 +0000 (00:18 +0200)]
[BUGFIX] Race-condition while updating extension list

There is a race-condition in the EM while updating the extension list.

If the update takes more than 30 seconds, Ext.Direct reaches its Ajax
timeout and sends the Ajax request (to update the list) again. As the EM
updates the extensions.xml.gz file at the beginning of the update
process, the second request immediately sees that the repository is
already up-to-date and respons this status to the client.

Thus, the user gets a "Repository is already up-to-date" message shown,
although it was not.

Change-Id: I7b45fc4e4ec8482d58eb771bba9d64a8c034daef
Resolves: #30673
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5686
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] Copyright year in HTML comment is hardcoded
Andreas Wolf [Mon, 10 Oct 2011 12:05:33 +0000 (14:05 +0200)]
[BUGFIX] Copyright year in HTML comment is hardcoded

The copyright year in the HTML comment is hardcoded as 1998-2009. This
should be changed to using the constant.

Change-Id: Idd07e50b515fc495512295c5557c4aeafbc8b549
Resolves: #30725
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5668
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Typo in gifbuilder
Simon Schaufelberger [Thu, 6 Oct 2011 10:13:31 +0000 (12:13 +0200)]
[BUGFIX] Typo in gifbuilder

stdWrap features GIFBUILDER transparentBackground and reduceColors
are broken

Change-Id: Ie162c1cf851dc237d3fa9a569c6dfb705c5f339c
Resolves: #29445
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5628
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] PHP warning on each Extension Manager invocation
Dmitry Dulepov [Thu, 6 Oct 2011 07:48:04 +0000 (10:48 +0300)]
[BUGFIX] PHP warning on each Extension Manager invocation

Extension manager produces a PHP warning on each invocation due to
incorrect parameters passed to t3lib_div::trimExplode().

Change-Id: I7f33221cb9068b6d914951f045ce4dc1e0bcaa37
Resolves: #30598
Releases: 4.6,4.5
Reviewed-on: http://review.typo3.org/5621
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] EM, Error when downloading extension files
Markus Klein [Wed, 5 Oct 2011 23:59:44 +0000 (18:59 -0500)]
[BUGFIX] EM, Error when downloading extension files

Trying to download a file using the Edit Files page of the old EM
leads to a fatal error, because URL is not decoded properly.

Change-Id: Ibd8f71fbc0ff8d9761b35cde713c3c021c6eb31e
Resolves: #27098
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5579
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Stefan
Tested-by: Stefan
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] EM installs outdated versions of depending extensions
Steffen Gebert [Wed, 5 Oct 2011 20:11:13 +0000 (22:11 +0200)]
[BUGFIX] EM installs outdated versions of depending extensions

When installing an extension with a dependency to another extension,
which is not available on the server, EM retrieves it from TER. However,
by mistake it always retrieves the oldest version, not the newest.

Change-Id: I5b630ddc744670c48fc5d86856ca6ae46806fcf6
Resolves: #29243
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5598
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] RTE: Tag attributes are reversed on save
Stanislas Rolland [Wed, 5 Oct 2011 01:07:21 +0000 (21:07 -0400)]
[BUGFIX] RTE: Tag attributes are reversed on save

Problem: When saving a content element, the order of attributes of tags
is reversed. This clutters the workspace diffs with many changes. The
problem arises in WebKit and Opera.
Solution: Reverse the order of attributes.

Change-Id: I8de914e0f10b043c106c1cacba3e17579d43e699
Resolves: #29855
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5536
Reviewed-by: Markus Klein
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] meaningfulTempFilePrefix is not multi-byte safe
Steffen Gebert [Sun, 2 Oct 2011 08:23:59 +0000 (10:23 +0200)]
[BUGFIX] meaningfulTempFilePrefix is not multi-byte safe

On a utf-8 file system meaningful prefixes can contain utf-8 characters. To
prevent truncating in the middle of a multi-byte character the API functions
must be used instead of substr().

Change-Id: Icf1a0cd1c095402cd31768ac732ec9bc9dfe7519
Resolves: #30416
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5572
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] t3lib_Compressor breaks absolute paths in CSS
Andreas Bouche [Tue, 20 Sep 2011 13:45:57 +0000 (15:45 +0200)]
[BUGFIX] t3lib_Compressor breaks absolute paths in CSS

Adds a negative lookahead for trailing slash to the regular
Expressions in method "cssFixRelativeUrlPaths" to exclude
absolute paths from being rewritten.

Change-Id: I4f306e314cab748a24d3e25fcb9a86a28e12384a
Resolves: #29904
Releases: 4.5
Reviewed-on: http://review.typo3.org/5123
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[BUGFIX] Email links marked as external when preceded by external link
Stanislas Rolland [Tue, 4 Oct 2011 16:46:47 +0000 (12:46 -0400)]
[BUGFIX] Email links marked as external when preceded by external link

Variable is not initialized leading to incorrect transformation
on way to RTE.

Change-Id: If83c2c8b04def953cbc95f617a14111e7641a867
Resolves: #29782
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5539
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE: Add TYPO3 version to hash of cached scripts
Stanislas Rolland [Tue, 4 Oct 2011 03:51:22 +0000 (23:51 -0400)]
[BUGFIX] RTE: Add TYPO3 version to hash of cached scripts

Problem: Fixed JS scripts may not be loaded when a new version of
TYPO3 is released. This may happen if the version of htmlArea RTE was
not incremented. This is an error-prone situation.
Solution: Add TYPO3 version to hash of cached scripts

Change-Id: I8c4c63060034aafc5ac75bd17196c1847fa6357e
Resolves: #30534
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/5512
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[TASK] Update reference from SVN to Git
Helmut Hummel [Thu, 22 Sep 2011 20:22:25 +0000 (22:22 +0200)]
[TASK] Update reference from SVN to Git

Module About TYPO3 shows this text:
The SVN Repository and the ChangeLog can be found here.

This has to be updated to read "Git" instead of "SVN".

Change-Id: I8e708f9e47e5afa5f4528bd308ca13b7f2535364
Resolves: #30171
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5240
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX][t3editor] typolinkEnableLinksAcrossDomains missing
Steffen Gebert [Thu, 22 Sep 2011 10:34:03 +0000 (12:34 +0200)]
[BUGFIX][t3editor] typolinkEnableLinksAcrossDomains missing

The description for config.typolinkEnableLinksAcrossDomains is missing
in the t3editor auto-completion.

Change-Id: I65ca26340dae7d960bdab162cb6d3729c85d19e7
Fixes: #27697
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/5204
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] Label status_configuration_PhpSafeModeEnabled is not retrieved
Xavier Perseguers [Tue, 20 Sep 2011 09:21:36 +0000 (11:21 +0200)]
[BUGFIX] Label status_configuration_PhpSafeModeEnabled is not retrieved

Wrong method is used to retrieve label status_configuration_PhpSafeModeEnabled.

Change-Id: Ia870d88ea4ce3c8582f02dd40a8655fd115145fd
Fixes: #30081
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/5103
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] t3editor not visible with TYPO3 on Windows
Jigal van Hemert [Mon, 19 Sep 2011 11:51:31 +0000 (13:51 +0200)]
[BUGFIX] t3editor not visible with TYPO3 on Windows

The template for t3editor contains CRLF line endings on Windows systems. To
prevent JS errors and to make the t3editor visible the CR parts of the line
endings must be removed.

Change-Id: I6e4e7d3b7045c1327f79300874f1539e407f77a5
Fixes: #30026
Branches: 4.5
Reviewed-on: http://review.typo3.org/5069
Reviewed-by: Tobias Liebig
Tested-by: Tobias Liebig
7 years ago[BUGFIX] Don't unnecessarily start PHP session
Helmut Hummel [Sat, 17 Sep 2011 15:59:51 +0000 (17:59 +0200)]
[BUGFIX] Don't unnecessarily start PHP session

Because of an information disclosure problem in the backend login
we moved the session_start() in t3lib_userauth in a place which caused
unwanted side effects with 3rd party extensions.

Revert that change to avoid compatibility and performance problems
and instead send no cache headers earlier in t3lib_userauth
to also fix the information disclosure.

Releases: 4.3, 4.4, 4.5, 4.6
Resolves: #29274
Related: #24456, #28694

Change-Id: I87226a21d9b1955773ceb3c377fa1b4c9938e6b2
Reviewed-on: http://review.typo3.org/5070
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Show extension configuration after extension update
Helmut Hummel [Sat, 10 Sep 2011 10:28:27 +0000 (12:28 +0200)]
[BUGFIX] Show extension configuration after extension update

When updating an extension, updates of database tables are not
shown and not offered to be updated. Thus they remain unnoticed
and this leads to unexpected results.

Show extension configuration and database updates after updating an extension.

Resolves: #29625
Releases: 4.5, 4.6

Change-Id: I82281494b71cd9fa38235ebafaa2b2423d15436d
Reviewed-on: http://review.typo3.org/5036
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[BUGFIX] Fix backpath for add wizards in IRRE records (Backport fix from master)
Sebastian Fischer [Wed, 14 Sep 2011 13:09:37 +0000 (15:09 +0200)]
[BUGFIX] Fix backpath for add wizards in IRRE records (Backport fix from master)

As in typo3/init.php the TYPO3_mainDir is set to 'typo3/' the replacement in
renderForeignRecord could not work because it uses the TYPO3_mainDir . '%2Fajax.php'
which results in typo3//ajax.php
By this the backpath of the add wizard in IRRE foreign records is fixed.

Change-Id: I1a3c5274783609127ba29d0546c55450cecd1cd2
Resolves: #29770
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/5017
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
7 years ago[BUGFIX] About modules: Adjust bgcolor of sections
Tomas Norre Mikkelsen [Sat, 17 Sep 2011 13:55:17 +0000 (15:55 +0200)]
[BUGFIX] About modules: Adjust bgcolor of sections

Adjust the background color of the module section table cells to match
the "body" background color.

Change-Id: I23389a7099bc67b3aa51d27feb5276360110e877
Resolves: #27589
Reviewed-on: http://review.typo3.org/5005
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[TASK] Add SwiftMailer license exception to be included in TYPO3v4
Ernesto Baschny [Thu, 15 Sep 2011 10:00:03 +0000 (12:00 +0200)]
[TASK] Add SwiftMailer license exception to be included in TYPO3v4

Change-Id: Iaf1420f28b1bc4945aacd4f8183cd2ec33513270
Resolves: #29802
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4978
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
7 years ago[TASK] Set TYPO3 version to 4.5.7-dev
TYPO3 v4 Release Team [Wed, 14 Sep 2011 09:45:42 +0000 (11:45 +0200)]
[TASK] Set TYPO3 version to 4.5.7-dev

Change-Id: I2e00897f141ca4c39160af6a026b579e64346545
Reviewed-on: http://review.typo3.org/4967
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.5.6
TYPO3 v4 Release Team [Wed, 14 Sep 2011 09:45:33 +0000 (11:45 +0200)]
[RELEASE] Release of TYPO3 4.5.6

Change-Id: I28d6e97414da1188993de8fdbd5337cd1d2b18cc
Reviewed-on: http://review.typo3.org/4966
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] SQL Injection vulnerability in prepared statements
Helmut Hummel [Tue, 13 Sep 2011 18:32:19 +0000 (20:32 +0200)]
[BUGFIX] SQL Injection vulnerability in prepared statements

Change-Id: Id8a12b1782d9169d650249e06520b4046d504fd2
Resolves: #29400
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4960
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Disabling the cache does not work on invalid cHash value
Daniel Pötzinger [Tue, 30 Aug 2011 20:40:31 +0000 (22:40 +0200)]
[BUGFIX] Disabling the cache does not work on invalid cHash value

Change-Id: Ia58a6eafc9cf6d02ee6066d2c2d4b976505399f1
Releases: 4.6, 4.5, 4.4, 4.3
Resolves: #29366
Reviewed-on: http://review.typo3.org/4942
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] RTE: External links not updated to internal by link dialogue
Stanislas Rolland [Mon, 5 Sep 2011 15:10:59 +0000 (11:10 -0400)]
[BUGFIX] RTE: External links not updated to internal by link dialogue

Solution: Remove external attribute when switching to other type
of link.

Change-Id: I94762da2fe19cf2cf91f6af755234347aef942ab
Resolves: #29167
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4773
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE may overwrite link text in IE
Stanislas Rolland [Fri, 9 Sep 2011 03:42:10 +0000 (23:42 -0400)]
[BUGFIX] RTE may overwrite link text in IE

Problem: In IE, setting the link node href attribute may update the link
content when the content is recognized by IE as an url.
Solution: Workaround the IE feature and restore the link content.

Change-Id: Ic1ed947206aa756296c25d4e3f9c40b9fc1e26e5
Resolves: #29527, #25464
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4864
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] FE session transfer is broken
Dmitry Dulepov [Mon, 4 Jul 2011 14:41:13 +0000 (16:41 +0200)]
[BUGFIX] FE session transfer is broken

The fix for #M13740 (revision 3a3a8d81) breaks FE session
transfer across top level domains.

Method tslib_fe::initFEuser() checks if there is a special
URL parameter named FE_SESSION_KEY. If that exists, it sets
$_COOKIE[$this->fe_user->name] to the passed session value.
This is very useful when using RealURL's feature to make
different language domains but use the same user for all
domains (multilanguage countries like Switzerland
or Belgium love that). However this is broken by using
$_SERVER['HTTP_COOKIE'] for FE session cookie. tslib_fe
has to be adjusted to set the same cookie.

Change-Id: I9042b8668cd392bfd95262481918683e886da32d
Resolves: #27740
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/3034
Reviewed-by: Stefan Neufeind
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
7 years ago[BUGFIX] Padding of RTE statusbar is too big
Stanislas Rolland [Wed, 7 Sep 2011 17:18:39 +0000 (13:18 -0400)]
[BUGFIX] Padding of RTE statusbar is too big

onLayout produces incorrect results when executed on a hidden element.

Change-Id: Iebba44be9e51812458d14c525ad30136939f3f30
Resolves: #29485
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4831
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE only loads styles from external css file on reload in IE8
Stanislas Rolland [Thu, 25 Aug 2011 02:49:30 +0000 (22:49 -0400)]
[BUGFIX] RTE only loads styles from external css file on reload in IE8

Problem: The script fails to detect that a stylesheet is not loaded
Solution: Check for empty rules and imports arrays of skin and
content stylesheets.

Change-Id: Ia8bdac51f52f07b4028af2c8613ee8f7324a6e91
Resolves: #29234
Releases: 4.4, 4.5
Reviewed-on: http://review.typo3.org/4833
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] High CPU load in IE8/9 when using context menu in htmlArea RTE
Stanislas Rolland [Thu, 1 Sep 2011 16:55:05 +0000 (12:55 -0400)]
[BUGFIX] High CPU load in IE8/9 when using context menu in htmlArea RTE

Cleanup event listeners.

Change-Id: Ic92ef7df49c9b6266e51f6193ec2611ea3431fe3
Resolves: #29361
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4732
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE context menu adds unwanted id attribute to target
Stanislas Rolland [Thu, 1 Sep 2011 14:23:22 +0000 (10:23 -0400)]
[BUGFIX] RTE context menu adds unwanted id attribute to target

The context menu plugin uses Ext.get on the target element. ExtJs thus adds an unwanted id attribute to content.

Solution: Use Ext.fly rather than Ext.get.

Change-Id: I02d706badc8c3cacbb9ed39baf1ae058359c0a23
Resolves: #29421
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4721
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Incorrect behaviour of style selector in RTE
Stanislas Rolland [Wed, 24 Aug 2011 15:31:14 +0000 (11:31 -0400)]
[BUGFIX] Incorrect behaviour of style selector in RTE

When all classes allowed on an element have been assigned to a single
element, the block/text style selector becomes disabled. It is then not
possible to remove the assigned classes from this element.

Change-Id: If81a43cb4768848863bfade78f661eba3331685d
Resolves: #27801
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4574
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 30 Aug 2011 12:23:11 +0000 (14:23 +0200)]
[TASK] Raise submodule pointer

Change-Id: I45d2f86b7096ec8ed7302375be0213b88c15903c
Reviewed-on: http://review.typo3.org/4679
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Bring back recStatInfoHooks hook in Page Tree
Georg Ringer [Tue, 30 Aug 2011 12:03:14 +0000 (14:03 +0200)]
[BUGFIX] Bring back recStatInfoHooks hook in Page Tree

There was a hook 'recStatInfoHooks' in class.webpagetree.php, which is
missing in the current implementation with ExtJS.

Change-Id: Ie334ba0289e7cc49a0cbcdeb4b2f8e16d9c141fb
Resolves: #27247
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4677
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[TASK] Improve description of $TYPO3_CONF_VARS['SYS']['no_pconnect']
Christopher [Mon, 29 Aug 2011 17:50:55 +0000 (19:50 +0200)]
[TASK] Improve description of $TYPO3_CONF_VARS['SYS']['no_pconnect']

Improve the description of $TYPO3_CONF_VARS['SYS']['no_pconnect'],
so that people at least get a keyword, which they can put into
Google, when they don't know, what to set here.

Change-Id: I0a00e03b91daed62c973f4e92c1e4e9ce2c30e74
Resolves: #29304
Reviewed-on: http://review.typo3.org/4667
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] HTMLparser, treat fixAttrib.unset as boolean
Markus Klein [Thu, 25 Aug 2011 18:12:37 +0000 (13:12 -0500)]
[BUGFIX] HTMLparser, treat fixAttrib.unset as boolean

HTMLparser_tags fixAttrib.unset is documented to be boolean, but is
currently treated as string.
This patch corrects for the expected behavior.

Change-Id: Ie063cfd2f7aab0a09c712faefb31c3894f651d79
Resolves: #29246
Releases: 4.6, 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/4644
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] RTE breaks mailto links in Firefox
Stanislas Rolland [Sun, 28 Aug 2011 14:15:18 +0000 (10:15 -0400)]
[BUGFIX] RTE breaks mailto links in Firefox

mailto link are incorrectly prefixed with base url

Change-Id: Ic386148279228c9f3397ccf6480800f033782cc2
Resolves: #29141
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4665
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] t3lib_div::cmpFQDN() lacks support for IPv6 and hostnames
Stefan Neufeind [Tue, 12 Jul 2011 08:16:01 +0000 (10:16 +0200)]
[BUGFIX] t3lib_div::cmpFQDN() lacks support for IPv6 and hostnames

Add checks for IPv4 and IPv6. Otherwise take input as hostname.
Implement correct (recursive) wildcard-checks.
Add unit tests.

Change-Id: I15328839d28746c68d7ef108b783c1ffe40d99cd
Resolves: #27217
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3924
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Add DB structure update pre-processing hook in EM
Xavier Perseguers [Fri, 26 Aug 2011 10:04:27 +0000 (12:04 +0200)]
[BUGFIX] Add DB structure update pre-processing hook in EM

Extension Manager lacks a way to perform actions prior to modifying the database
structure (create new tables or add additional fields in existing ones) when
installing an extension.

This would be very handy for DBAL to let user update mapping definition from within
TYPO3 without the need to first manually edit typo3conf/localconf.php.

This is a bugfix as the feature had been accepted for 4.5.0beta1 and was wrongly
removed during Extension Manager refactoring task. In fact, the interface is still
here but never used.

Change-Id: Ia7e7035193c3448333cecc268cc3f61479e6f13d
Fixes: #23877
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4615
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Message about missing db credentials is misleading
Christopher [Sun, 28 Aug 2011 18:57:49 +0000 (20:57 +0200)]
[BUGFIX] Message about missing db credentials is misleading

If persistent connections are not allowed by MySQL the error message
"Can only select database if username/password/host is correctly set
first." is shown. Add an explanation that
$TYPO3_CONF_VARS['SYS']['no_pconnect'] must be set to 1, if persistent
connections are not allowed.

Change-Id: I4e52a3e8aefa4b4b716aba39e3bee8d1e681bca7
Fixes: #29245
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4643
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] TCA Tree should respect requestUpdate and type
Marco Huber [Thu, 24 Mar 2011 08:50:04 +0000 (09:50 +0100)]
[BUGFIX] TCA Tree should respect requestUpdate and type

TCA Tree should respect $TCA['myTable']['ctrl']['requestUpdate']
and $TCA['myTable']['type'], but the onChange Javascript is missing.

Change-Id: If2c7997c9627249e3f643c9670a2a9d4ba94103a
Resolves: #25382
Reviewed-on: http://review.typo3.org/3402
Reviewed-by: Lars Trebing
Tested-by: Lars Trebing
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] 'Update settings' button does not work in new em
Susanne Moog [Mon, 22 Aug 2011 18:55:28 +0000 (20:55 +0200)]
[BUGFIX] 'Update settings' button does not work in new em

After installing an extension you get a popup where you can
update the configuration settings of an extension. In the new
extension manager the update button there will not work as it
is a submit button but the form around the fields is missing.

Attached patch simply inserts the form in this case, too.

Change-Id: Iaa2eb8876e96bbe7d3120cd124c37d29815647fb
Resolves: #29172
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4629
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] exec_SELECTcountRows returns string
Georg Ringer [Tue, 23 Aug 2011 04:04:06 +0000 (06:04 +0200)]
[BUGFIX] exec_SELECTcountRows returns string

PHPdoc states that return value is either FALSE if
something strange happened or integer with the count of
records.

MySql returns strings, so an intval is needed to have integers

Change-Id: Ia4e7ff88620ac861f40035ab4f97a20d81115ea7
Resolves: #29169
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4567
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Remove check for invalid prefix in addService
Christian Kuhn [Mon, 22 Aug 2011 14:53:17 +0000 (16:53 +0200)]
[BUGFIX] Remove check for invalid prefix in addService

t3lib_extMgm::addService() checks that $serviceType (eg. 'auth') does not start
with a valid class prefix. While it is probably not a good idea to prefix a
service type with 'user_' or 'tx_', there is no technical reason to enforce
this. The check especially leads to problems if
TYPO3_CONF_VARS['FE']['userFuncClassPrefix'] is set to an empty string.
This patch removes the check.

Change-Id: Iaf60da0eae61a2c64bb4626f5629b8c262d00cc2
Resolves: #29165
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4528
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Fix isAbsPath() on Windows
Daniel Hoffmann [Mon, 25 Jul 2011 06:45:42 +0000 (08:45 +0200)]
[BUGFIX] Fix isAbsPath() on Windows

Paths starting with a slash are absolute on Windows, too.

Change-Id: Ie16b9f15d384b0da07e19eea68c37bbaee5094f5
Resolves: #16798
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4465
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Some TCEforms elements are displaced
Francois Suter [Wed, 17 Aug 2011 08:50:55 +0000 (10:50 +0200)]
[BUGFIX] Some TCEforms elements are displaced

When a TCEforms field is part of a palette, a specific span tag
is added around it. A similar span tag must be added around fields
which are not part of a palette, so that we have similar behaviors.

Change-Id: If13c130423c4839b89c7f03e015feffd8ae3bd94
Resolves: #29029
Related: #28030
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4389
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] Broken links representation gets saved to the database
Stanislas Rolland [Mon, 15 Aug 2011 20:31:08 +0000 (16:31 -0400)]
[BUGFIX] Broken links representation gets saved to the database

Solution: Avoid wrapping the a tag with span tag when style attribute
is set when rteerror attribute is also set.

Change-Id: I1f68a0f9a67934b9ac3288117f831219e8d30f99
Resolves: #25302
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4352
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
7 years ago[BUGFIX] TYPO3 tries to connect to typo3.org on every login
Susanne Moog [Sun, 21 Aug 2011 15:42:31 +0000 (17:42 +0200)]
[BUGFIX] TYPO3 tries to connect to typo3.org on every login

If the extension cache is disabled,
the extension manager tries to establish a connection to the TER
as soon as user credentials for a user are given.

This patch changes that behavior so that it is only done for
the functions that actually need a TER call.

Additionally I did some cleanup.

Change-Id: I1633334d762d713fcf39097192ed6fa8fcfcf343
Resolves: #28949
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4456
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Fix security level "normal" for backend login
Helmut Hummel [Sat, 20 Aug 2011 17:02:45 +0000 (19:02 +0200)]
[BUGFIX] Fix security level "normal" for backend login

Only change the object property to something different than "superchallenged"
if the configuration is not set to a "standard" security level.

Resolves: #29130
Releases: 4.6, 4.5, 4.4, 4.3

Change-Id: Ibf1194d04a7159ade9ef33701e92930f98cfb90e
Reviewed-on: http://review.typo3.org/4439
Reviewed-by: Philipp Gampe
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Also check if cache files are not empty
Jigal van Hemert [Sat, 20 Aug 2011 14:36:05 +0000 (16:36 +0200)]
[BUGFIX] Also check if cache files are not empty

If the temp_CACHED* files exist, but they are empty a lot of functions
produce incorrect result due to missing TCA data. Checking the fileSize
prevents the use of empty cache files.

Change-Id: I6c1ce468bfeec88bf8445e64e7b1bd6387f117f7
Resolves: #29075
Branches: 4.5
Reviewed-on: http://review.typo3.org/4435
Reviewed-by: Christian Kuhn
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
7 years ago[BUGFIX] feedit: Use skinImage for edit icons
Bjoern Pedersen [Thu, 21 Jul 2011 09:19:24 +0000 (11:19 +0200)]
[BUGFIX] feedit: Use skinImage for edit icons

Replace hardcoded icons with t3lib_iconWorks::skinImage calls

Change-Id: I9c5270061e1355f7689eebcc35d27078931afe89
Resolves: #24920
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4443
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] "New record" button in Template mod broken
Jigal van Hemert [Thu, 18 Aug 2011 09:18:16 +0000 (11:18 +0200)]
[BUGFIX] "New record" button in Template mod broken

Recent browsers follow HTML5 standards for submitting image input
elements. The result is that the name of the image input element is
not submitted anymore, only the name with the x and y coordinates.
Checking for createExtension_x or createExtension being set makes the
button work again.

Change-Id: Ic8925930f8aee31463666ea70d0b97d5ea717d28
Resolves: #28455
Branches: 4.5
Reviewed-on: http://review.typo3.org/4441
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Indent/outdent does not work if formatblock button is disabled
Stanislas Rolland [Sun, 14 Aug 2011 15:41:25 +0000 (11:41 -0400)]
[BUGFIX] Indent/outdent does not work if formatblock button is disabled

Problem: If the "formatblock" button is disabled, the current paragraph
gets a css class "indent" but a wrapping div is not created with that
css class.

Solution: When formatblock is not configured, allow all standard block
elements. When formatblock and indent are both configured, ensure div is
allowed.

Change-Id: Ib5d3087198904bb86a4901c57f5e0f2292f4b36e
Resolves: #28903
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4321
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE: Table tag left over after cutting table in Firefox
Stanislas Rolland [Tue, 16 Aug 2011 19:33:38 +0000 (15:33 -0400)]
[BUGFIX] RTE: Table tag left over after cutting table in Firefox

Solution: In case of selecting a table in the status bar, select the
whole node.

Change-Id: I13cd4e7e612c1e98d2cde8a57eae4323d94e9f03
Resolves: #29023
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4381
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[TASK] Set TYPO3 version to 4.5.6-dev
TYPO3 v4 Release Team [Tue, 16 Aug 2011 10:40:44 +0000 (12:40 +0200)]
[TASK] Set TYPO3 version to 4.5.6-dev

Change-Id: Icc98e1717ff3691a523cc79ec865b0ae15bc7e3c
Reviewed-on: http://review.typo3.org/4370
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.5.5
TYPO3 v4 Release Team [Tue, 16 Aug 2011 10:40:37 +0000 (12:40 +0200)]
[RELEASE] Release of TYPO3 4.5.5

Change-Id: I0a91385ec4525b348f6fbff7c9ac0669f792259c
Reviewed-on: http://review.typo3.org/4369
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[TASK] Merge changes from linkvalidator
Philipp Gampe [Mon, 15 Aug 2011 20:42:10 +0000 (22:42 +0200)]
[TASK] Merge changes from linkvalidator

The following issues have been fixed:
 2d04961 [TASK] Prepare for release of TYPO3 4.5.5
 b9405f2 [TASK] Update ChangeLog
 73570b3 [BUGFIX] Correct initialisation of BACK_PATH

Change-Id: I6117b0cd1dd36ef27fe66bfd99a160ecc4495464
Resolves: #28992
Releases: 4.5
Reviewed-on: http://review.typo3.org/4354
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Unit tests for tslib_content query arguments fail
Oliver Hader [Fri, 12 Aug 2011 10:30:19 +0000 (12:30 +0200)]
[BUGFIX] Unit tests for tslib_content query arguments fail

Since security fixes in July 2011 introduced a better encoding of URL
arguments, checks in the unit tests have to be modified as well.

Change-Id: I4162b93ef30ea6539f4f5a858629697ceccea48d
Resolves: #28946
Releases: 4.6, 4.5, 4.4
Reviewed-on: http://review.typo3.org/4285
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Maintain compatibility with changed headline rendering
Helmut Hummel [Mon, 8 Aug 2011 22:21:58 +0000 (00:21 +0200)]
[BUGFIX] Maintain compatibility with changed headline rendering

If the fontTag property is set and the dataWrap property is set to the
default value, replace the dataWrap with the fontTag property value and
disable insertData on this level (if set).

This is to retain compatibility with versions before 4.5.4 while
compatibility with modified templates (before and after 4.5.4) is still
provided.

Change-Id: I376c9fe013a21ac3e2e82a23d8d194fba9ac21f5
Resolves: #28847
Related: #26876
Releases: 4.5, 4.4, 4.3
Reviewed-on: http://review.typo3.org/4230
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
Reviewed-by: Ernesto Baschny
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Wrong usage of Ext.encodeURL in TBE_EDITOR.rawurlencode
Marco Huber [Thu, 2 Jun 2011 19:22:23 +0000 (21:22 +0200)]
[BUGFIX] Wrong usage of Ext.encodeURL in TBE_EDITOR.rawurlencode

If we want to use Ext.encodeURL() here, we have to change many other
things, too. Better use encodeURIComponent() here.
Ext.encodeURL() was introduced with #25350.

Change-Id: Ia1ab2aa20aeb8fd6afaba581738f35678d5b05dd
Resolves: #27028
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/4273
Reviewed-by: Eric Chavaillaz
Tested-by: Eric Chavaillaz
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] RTE Spellchecker dialogue fails to open in IE
Stanislas Rolland [Mon, 8 Aug 2011 03:56:18 +0000 (23:56 -0400)]
[BUGFIX] RTE Spellchecker dialogue fails to open in IE

ExtJs raises js error in IE due to 'auto' window height.

Change-Id: I7ba3477b62b513e273039e6937438821ac0d71e2
Resolves: #28820
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4210
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] htmlArea RTE: Relative url's on pasted links/images in Firefox
Stanislas Rolland [Sat, 30 Jul 2011 22:12:31 +0000 (18:12 -0400)]
[BUGFIX] htmlArea RTE: Relative url's on pasted links/images in Firefox

When copying/pasting an internal link or image from and to the RTE
editing area, Firefox changes the href or src to a relative url.
After save, the url ends up being wrong.

Similar issues arises when moving images or links inside the editing
area and when dropping images in the RTE from the image dialogue
window.

This change works around Firefox issue
https://bugzilla.mozilla.org/show_bug.cgi?id=613517,
by making the url absolute again before saving or toggling
to source text mode, as well as on paste and drop events.

Change-Id: I3b43291b9c8fa50763d649ac0fdc9b9e692869bf
Resolves: #28497, #24852, #27353
Releases: 4.4, 4.5, 4.6
Reviewed-on: http://review.typo3.org/3918
Reviewed-by: Stefan Neufeind
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] RTE Remove format: German fieldset legend does not wrap in IE
Stanislas Rolland [Sat, 6 Aug 2011 14:39:51 +0000 (10:39 -0400)]
[BUGFIX] RTE Remove format: German fieldset legend does not wrap in IE

Workaround IE bug by floating the legend to the left.

Change-Id: If0521f6be0f4505b99701f045064406a82f3e939
Fixes: #25484
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4176
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Colors not selectable in RTE table properties with IE 7/8
Stanislas Rolland [Sat, 6 Aug 2011 03:57:53 +0000 (23:57 -0400)]
[BUGFIX] Colors not selectable in RTE table properties with IE 7/8

When having many colors defined, it is only possible to select one
of the first colors. If a color at the end of the list is selected,
nothing happens.

Solution: Fix missing closing span tag in ExtJs template object.

Change-Id: Ied18dcfc4057e115db765d14b0112fe3f67aa1de
Fixes: #28760
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4165
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Wrong link if felogin reset password
Francois Suter [Wed, 22 Jun 2011 14:14:35 +0000 (16:14 +0200)]
[BUGFIX] Wrong link if felogin reset password

When the reset password link for felogin is generated (to be sent in
the mail), config.absRefPrefix overrides
plugin.tx_felogin_pi1.feloginBaseURL, but feloginBaseURL is specifically
designed to be used when needing a different base URL. This patch
makes feloginBaseURL prevail.

Thanks to Stephan Bauer for the original patch.

Change-Id: I05e3e63a3ad4628e07396e2dd8f089cd18dfc7f9
Resolves: #22434
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/2878
Reviewed-by: Helmut Hummel
Reviewed-by: Markus Klein
Reviewed-by: Stefan Neufeind
Reviewed-by: Francois Suter
Tested-by: Francois Suter
7 years ago[BUGFIX] htmlArea RTE: .titleText not localized to English
Stanislas Rolland [Thu, 4 Aug 2011 15:46:42 +0000 (11:46 -0400)]
[BUGFIX] htmlArea RTE: .titleText not localized to English

classesAnchor.[id-string].titleText is not localized when the
language of the content element is English, English being an
alternate language.

Change-Id: I15bf95534c51bcd4f80b08e04ed2bcc9042f3656
Resolves: #28767
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/4110
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[BUGFIX] Unprivileged backend user can read arbitrarily from database
Helmut Hummel [Wed, 3 Aug 2011 10:55:01 +0000 (12:55 +0200)]
[BUGFIX] Unprivileged backend user can read arbitrarily from database

Change-Id: I3035dad3b9b620fc9db05ccc9b2cd59553a050a2
Resolves: #26876
Reviewed-on: http://review.typo3.org/4057
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[TASK] Raise submodule pointer
TYPO3 v4 Release Team [Tue, 2 Aug 2011 14:25:52 +0000 (16:25 +0200)]
[TASK] Raise submodule pointer

Change-Id: I49cb0041f0af67bd18ae6c027e8a74197eb4fce9
Reviewed-on: http://review.typo3.org/4030
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[BUGFIX] Mirror selection is not respected
Xavier Perseguers [Mon, 1 Aug 2011 20:56:46 +0000 (22:56 +0200)]
[BUGFIX] Mirror selection is not respected

When a specific mirror is selected in Extension Manager,
the method used to return it fails.

Change-Id: I976a2f8ffe04af3f4c6eaffc99b407964b72fe42
Resolves: #27755
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/4001
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
7 years ago[BUGFIX] Cache FileBackend does not respect fileCreateMask
Steffen Gebert [Tue, 19 Jul 2011 20:00:57 +0000 (22:00 +0200)]
[BUGFIX] Cache FileBackend does not respect fileCreateMask

Change-Id: I8aa31c1c806d5424f2da9b3b3d37593da59a062a
Resolves: #28323
Releases: 4.5,4.6
Reviewed-on: http://review.typo3.org/3436
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] ImageMagick path detection fails on Mac OS X
Oliver Hader [Sun, 31 Jul 2011 21:50:19 +0000 (23:50 +0200)]
[BUGFIX] ImageMagick path detection fails on Mac OS X

The ImageMagick path detection fails on Mac OS X. If MacPorts
is used the additional folder /opt/local/bin should be checked.

Change-Id: Ia5fe02c42a61cbc542954b9c297cc78304be3b84
Resolves: #28625
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3962
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Call to stdWrap() of non-existant $this->cObj in GifBuilder
Steffen Gebert [Mon, 18 Apr 2011 20:19:06 +0000 (22:19 +0200)]
[BUGFIX] Call to stdWrap() of non-existant $this->cObj in GifBuilder

A PHP Fatal Error occurs in tslib_gifBuilder::checkTextObj(), because
$this->cObj is not set, however this->cObj->stdWrap() is called.

A few lines later, a local variable $cObj is initialized. This
initialization should be moved before the stdWrap() call.

Change-Id: I1ee8a8ecc4245af49e4f698734b66d95a835d57d
Resolves: #26091
Reviewed-on: http://review.typo3.org/3948
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] Error when opening TYPO3 manual
Markus Klein [Sun, 24 Jul 2011 19:17:17 +0000 (21:17 +0200)]
[BUGFIX] Error when opening TYPO3 manual

A missing parameter for SC_view_help::render_Table() causes
TYPO3 manual to produce a PHP warning.
This patch makes the second parameter optional.

Change-Id: I5aee7ea455ac37c7f287b9f5bd96d6bef22b83e8
Resolves: #28330
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3705
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] JSwindow-typolink URLs are encoded twice
Helmut Hummel [Sat, 30 Jul 2011 11:10:39 +0000 (13:10 +0200)]
[BUGFIX] JSwindow-typolink URLs are encoded twice

In #28189 a bug was introduced for JSwindow-typolink URLs.
Because t3lib_div::quoteJSvalue is called without second paramter,
the value passed to it will also be encoded with htmlspecialchars()
which is then done a second time when putting the link together.

Change the t3lib_div::quoteJSvalue call to not encode
the result with htmlspecailchars()

Resolves: #28536
Related: #28189

Releases: 4.3, 4.4, 4.5, 4.6

Change-Id: If6bcad4d2bf1e0a4b3f5a6f04e4718df8e4e7150
Reviewed-on: http://review.typo3.org/3913
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
7 years ago[BUGFIX] Extension Manager: Cursor on hover of required extensions
Mario Rimann [Thu, 21 Jul 2011 22:11:44 +0000 (00:11 +0200)]
[BUGFIX] Extension Manager: Cursor on hover of required extensions

The new extension manager shows the "hand" cursor when hovering over
the icon of a required extension. This change just disables that by
enforcing the browser to show the default "arrow" cursor.

Change-Id: I05c075710effb9de3de147ba716495362c39da0a
Resolves: #13267
Releases: 4.6, 4.5
Reviewed-on: http://review.typo3.org/3900
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
7 years ago[BUGFIX] htmlArea RTE: localized acronym popup window misses window title
Stanislas Rolland [Fri, 29 Jul 2011 18:51:29 +0000 (14:51 -0400)]
[BUGFIX] htmlArea RTE: localized acronym popup window misses window title

Change-Id: I28539f92425dbbf6a18f11ec1a5e99c2fa6b077e
Fixes: #28575
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3893
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
7 years ago[FEATURE] Backport t3lib_utility_Version
Xavier Perseguers [Wed, 27 Jul 2011 07:54:12 +0000 (09:54 +0200)]
[FEATURE] Backport t3lib_utility_Version

Deprecating t3lib_div::int_from_ver() in 4.6 leads to major developer
annoyance because this method is used to switch to compatibility code
for older versions of TYPO3 in extensions and a hocus-pocus is needed
to prevent calling it if using 4.6.

Prepare this major deprecation by backporting
t3lib_utility_Version::convertVersionNumberToInteger() but without
refactoring existing code to use it.

Change-Id: I72673a483e5e716b24ebb6a89aaee3e09aaa7e65
Resolves: #28499
Releases: 4.5
Reviewed-on: http://review.typo3.org/3732
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Benjamin Mack
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
7 years ago[TASK] Set TYPO3 version to 4.5.5-dev
TYPO3 v4 Release Team [Wed, 27 Jul 2011 11:22:47 +0000 (13:22 +0200)]
[TASK] Set TYPO3 version to 4.5.5-dev

Change-Id: Icfca8f1d8f4868515253f0257e220cb0ee2d706b
Reviewed-on: http://review.typo3.org/3790
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[RELEASE] Release of TYPO3 4.5.4
TYPO3 v4 Release Team [Wed, 27 Jul 2011 11:22:39 +0000 (13:22 +0200)]
[RELEASE] Release of TYPO3 4.5.4

Change-Id: I0d1fac6d5384faca0342731fc62bf2d0277b04f6
Reviewed-on: http://review.typo3.org/3789
Reviewed-by: TYPO3 v4 Release Team
Tested-by: TYPO3 v4 Release Team
7 years ago[FEATURE] Move "Appearance" tab before "Access" tab
Xavier Perseguers [Fri, 22 Jul 2011 13:55:59 +0000 (15:55 +0200)]
[FEATURE] Move "Appearance" tab before "Access" tab

The use of settings in the "Appearance" tab are most likely related to
setting in tabs placed before the "Access" tab.

The "Appearance" should be moved before the "Access" tab to give a
correct workflow

Change-Id: Ia49c2d600de7ec81582175cac248feb0c660fdf9
Resolves: #27345
Releases: 4.5, 4.6
Reviewed-on: http://review.typo3.org/3475
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
7 years ago[BUGFIX] Ext Direct API lacks the possibility of adding access control
Stefan Galinski [Wed, 27 Jul 2011 10:51:19 +0000 (12:51 +0200)]
[BUGFIX] Ext Direct API lacks the possibility of adding access control

Change-Id: I15498ca3623701f3a11f1a8c41f0ea99cbb918a4
Resolves: #25307
Reviewed-on: http://review.typo3.org/3781
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Untrusted GP data is unserialized in wizard_colorpicker.php and view_help.php
Christian Kuhn [Wed, 27 Jul 2011 10:50:46 +0000 (12:50 +0200)]
[BUGFIX] Untrusted GP data is unserialized in wizard_colorpicker.php and view_help.php

Change-Id: I173ee6c20b4eca5cbdec37a117e7caf191f2b9af
Resolves: #24577
Reviewed-on: http://review.typo3.org/3778
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Unprivileged backend user can read arbitrarily from database
Helmut Hummel [Wed, 27 Jul 2011 10:50:05 +0000 (12:50 +0200)]
[BUGFIX] Unprivileged backend user can read arbitrarily from database

Change-Id: Ie7702f7c4dc323a6200be01b148655f127de19eb
Resolves: #26876
Reviewed-on: http://review.typo3.org/3774
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] Backend user without accordant language permissions can see workspace changes
Michael Klapper [Wed, 27 Jul 2011 10:43:13 +0000 (12:43 +0200)]
[BUGFIX] Backend user without accordant language permissions can see workspace changes

Change-Id: I35f3daee2f08e189a8a9b3a3eeda50c6165dacf1
Resolves: #27414
Reviewed-on: http://review.typo3.org/3767
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] XSS in TYPO3 core when using typolink.parameter JS-Popup Window
Marco Bresch [Wed, 27 Jul 2011 10:30:04 +0000 (12:30 +0200)]
[BUGFIX] XSS in TYPO3 core when using typolink.parameter JS-Popup Window

Change-Id: Id1cd396d56358519be2b312d39e25b26cf943253
Resolves: #28189
Reviewed-on: http://review.typo3.org/3765
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] XSS in tcemain flash message
Georg Ringer [Wed, 27 Jul 2011 10:29:47 +0000 (12:29 +0200)]
[BUGFIX] XSS in tcemain flash message

Change-Id: I41c91d929b8c018e4fdb7b452cd1fabf583c697a
Resolves: #24535
Reviewed-on: http://review.typo3.org/3761
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] XSS in Recycler
Steffen Gebert [Wed, 27 Jul 2011 10:29:26 +0000 (12:29 +0200)]
[BUGFIX] XSS in Recycler

Change-Id: I82c3241804a9bc956c6e13e5ef5c61e2668acc01
Resolves: #24519
Reviewed-on: http://review.typo3.org/3757
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] XSS in browse_links
Georg Ringer [Wed, 27 Jul 2011 10:29:11 +0000 (12:29 +0200)]
[BUGFIX] XSS in browse_links

Change-Id: Id9147d23bd1db22f346e938fabeffa5b1bce0eb5
Resolves: #24497
Reviewed-on: http://review.typo3.org/3753
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] t3lib_div::removeXSS does not remove some XSS
Jigal van Hemert [Wed, 27 Jul 2011 10:28:47 +0000 (12:28 +0200)]
[BUGFIX] t3lib_div::removeXSS does not remove some XSS

Change-Id: I136052f3296a17a021f0e30deca7e34fd5869ab3
Resolves: #20775
Reviewed-on: http://review.typo3.org/3749
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
7 years ago[BUGFIX] The delay if wrong credentials are provided during backend login can be...
Helmut Hummel [Wed, 27 Jul 2011 10:27:29 +0000 (12:27 +0200)]
[BUGFIX] The delay if wrong credentials are provided during backend login can be circumvented

Change-Id: Id12333d7b9c24dc511da05000e0539ba473b6ad5
Resolves: #24457
Reviewed-on: http://review.typo3.org/3743
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader