Packages/TYPO3.CMS.git
3 months ago[RELEASE] Release of TYPO3 8.7.21 13/59113/2 8.7.21 TYPO3_8-7-21 v8.7.21
Oliver Hader [Tue, 11 Dec 2018 12:39:50 +0000 (13:39 +0100)]
[RELEASE] Release of TYPO3 8.7.21

Change-Id: I1ced38699bc6d545e871a36b76cc2aee0fd4ff7d
Reviewed-on: https://review.typo3.org/59113
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Adjust modal window processing 08/59108/4
Oliver Hader [Tue, 11 Dec 2018 11:47:39 +0000 (12:47 +0100)]
[BUGFIX] Adjust modal window processing

Resolves: #87123
Releases: master, 8.7, 7.6
Change-Id: Idceecb174682261b967ea284e12e1836bb7e7bea
Reviewed-on: https://review.typo3.org/59108
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[TASK] Skip IPv6 related dns resolution tests 81/59081/3
Markus Klein [Mon, 10 Dec 2018 19:04:08 +0000 (20:04 +0100)]
[TASK] Skip IPv6 related dns resolution tests

Skip those tests on systems which do not properly resolve ::1 to localhost.
Travis CI is one example.

Resolves: #87119
Releases: 8.7, 7.6
Change-Id: I8d96f8da1c19f3d9924dcc048466b5f88d8f18dd
Reviewed-on: https://review.typo3.org/59081
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Add feature toggle to disable record registration 98/59098/2
Benni Mack [Tue, 11 Dec 2018 09:56:43 +0000 (10:56 +0100)]
[SECURITY] Add feature toggle to disable record registration

The "recs" query parameter allows to write
arbitrary entries into a session, leading
to a possibility to create a reasonable amount
of frontend user sessions.

In order to prevent this situation, a new configuration
option $TYPO3_CONF_VARS[FE][enableRecordRegistration]
is added to disable the functionality completely.

The feature is disabled per default in order to apply
strong security defaults. Installations that rely on this
functionality have to manually enable the feauture and
its vulnerability by changing the according TYPO3_CONF_VARS
setting in the install tool.

A security report is added to display a warning
in the TYPO3 Backend.

Resolves: #80979
Releases: 8.7, 7.6
Security-Commit: 32762f9654fba3e8ddcf1f67d1c0fbf4967b5149
Security-Bulletin: TYPO3-CORE-SA-2018-012
Change-Id: I488bdf412361a0c56290deb842b16a3958501430
Reviewed-on: https://review.typo3.org/59098
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Avoid DoS in Online Media Helper 97/59097/2
Oliver Hader [Tue, 11 Dec 2018 09:56:37 +0000 (10:56 +0100)]
[SECURITY] Avoid DoS in Online Media Helper

Using large media files (*.youtube, *.vimeo in the TYPO3 core)
might lead to denial of service scenarios. In order to avoid
that, media files are limited to have a content size of 2048
bytes as a maximum. Usually these files contain just the remote
identifier - thus, ~20 bytes should have been sufficient already.

Resolves: #85381
Releases: master, 8.7, 7.6
Security-Commit: 38eec2deace776ed34d30b8e1e5e95fffec5db8a
Security-Bulletin: TYPO3-CORE-SA-2018-011
Change-Id: I0af4f27e2de6db43c2801f1f3143c9cdb6e21867
Reviewed-on: https://review.typo3.org/59097
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Remove TYPO3 version from installer 96/59096/2
Benni Mack [Tue, 11 Dec 2018 09:56:30 +0000 (10:56 +0100)]
[SECURITY] Remove TYPO3 version from installer

When installing TYPO3, the current version
is shown without any kind of authentication
provided (no FIRST_INSTALL). This information
disclosure is solved.

Resolves: #86254
Releases: master, 8.7, 7.6
Security-Commit: c7f8829609ac20081500ea486eb74a11428313dd
Security-Bulletin: TYPO3-CORE-SA-2018-010
Change-Id: I7358f181e5b93c596aa460040dee53a1485f3759
Reviewed-on: https://review.typo3.org/59096
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Make InstallTool session cookie HTTP-only 95/59095/2
Oliver Hader [Tue, 11 Dec 2018 09:56:24 +0000 (10:56 +0100)]
[SECURITY] Make InstallTool session cookie HTTP-only

Resolves: #86955
Releases: master, 8.7, 7.6, 6.2
Security-Commit: c7326315b4c80d8563419be040c8a2435ed925ea
Security-Bulletin: TYPO3-CORE-SA-2018-009
Change-Id: I669fdd0de055554511c39de6c0f3f1efd19874b9
Reviewed-on: https://review.typo3.org/59095
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Prevent XSS with fe_users data in felogin/TSFE 94/59094/2
Benni Mack [Tue, 11 Dec 2018 09:56:17 +0000 (10:56 +0100)]
[SECURITY] Prevent XSS with fe_users data in felogin/TSFE

Two occurrences allow to render data of the currently logged in
frontend user that is not sanitized and thus allow XSS attacks
by frontend users.

1. EXT:fe_login adds ###FEUSER_{fieldname}### for each
field that exists in the fe_users DB table, which CAN be processed
by TypoScript but is insecure by default.

2. config.USERNAME_substToken = <!--###USERNAME###-->
sets the username dynamically, which is then insecure.

Adding htmlspecialchars as a default configuration
solves this problem.

Resolves: #87053
Releases: master, 8.7, 7.6
Security-Commit: 3ef6a5c97381742eb6699923e9ed44224ab1e72e
Security-Bulletin: TYPO3-CORE-SA-2018-008
Change-Id: Ic0a48a36d1e5b394b6e829c5e209bdd2321b654e
Reviewed-on: https://review.typo3.org/59094
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Prevent XSS in modal component 93/59093/2
Frank Naegler [Tue, 11 Dec 2018 09:56:10 +0000 (10:56 +0100)]
[SECURITY] Prevent XSS in modal component

Resolves: #84190
Releases: master, 8.7, 7.6
Security-Commit: e991d9ac10b78f360bff386d9a822f0caa7c781d
Security-Bulletin: TYPO3-CORE-SA-2018-007
Change-Id: I41f0d6bdb5e06b6f08b19feaf59ea47e3a197549
Reviewed-on: https://review.typo3.org/59093
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Properly escape videoId for YouTube/Vimeo 92/59092/2
Susanne Moog [Tue, 11 Dec 2018 09:56:04 +0000 (10:56 +0100)]
[SECURITY] Properly escape videoId for YouTube/Vimeo

Resolves: #83184
Releases: master, 8.7, 7.6
Security-Commit: 20b6cff301205505b620bffb5be4807636b014e7
Security-Bulletin: TYPO3-CORE-SA-2018-006
Change-Id: Ifb6b7588c7a06ca29a7c2a6382f95bbfb52f392e
Reviewed-on: https://review.typo3.org/59092
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[SECURITY] Update library CKEditor to 4.11.1 91/59091/2
Benni Mack [Tue, 11 Dec 2018 09:55:49 +0000 (10:55 +0100)]
[SECURITY] Update library CKEditor to 4.11.1

CKEditor 4.11 was released including a XSS fix where
an attacker could add invalid HTML markup by switching
to the Source mode of CKEditor and back.

Latest CKEditor version 4.11.1 is used automatically per
default. In TYPO3 v8 it is possible to select previous and
insecure version 4.7.1 due to backaward compatibility reasons.
This can be configured in Extension Manager for cke_editor.

Used commands:
  cp -r typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib/ \
        typo3/sysext/rte_ckeditor/Resources/Public/JavaScript/Contrib-47
  cd Build/
  yarn add ckeditor#4.11.1 --dev
  grunt build

Resolves: #84800
Releases: master, 8.7
Security-Commit: 1c44c5ef1753b03ebff2a83b5bf1bc43cf187dff
Security-Bulletin: TYPO3-CORE-SA-2018-005
Change-Id: I1abe5639f82e42b9c12453d1b301e5c4ca1f2aa7
Reviewed-on: https://review.typo3.org/59091
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 months ago[BUGFIX] Backport essential features into TypoLinkViewHelper classes 33/58933/3
Andreas Fernandez [Thu, 22 Nov 2018 14:48:18 +0000 (15:48 +0100)]
[BUGFIX] Backport essential features into TypoLinkViewHelper classes

This patch backports essential support for `forceAbsoluteUrl` and
`addQueryString` to the TypoLinkViewHelper classes.

Resolves: #86977
Related: #84120
Related: #81358
Releases: 8.7
Change-Id: Iab4d1c49a2be46108d6e7578ba418eb89d24b532
Reviewed-on: https://review.typo3.org/58933
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 months ago[TASK] bamboo 8.7 nightly supports paches on-top 67/59067/2
Christian Kuhn [Sat, 8 Dec 2018 17:52:22 +0000 (18:52 +0100)]
[TASK] bamboo 8.7 nightly supports paches on-top

Change-Id: I1830314fa79a218429f6210d7bc12a17a51daa8a
Resolves: #87110
Releases: 8.7
Reviewed-on: https://review.typo3.org/59067
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[TASK] Simplify bamboo variable to label handling 64/59064/3
Christian Kuhn [Sat, 8 Dec 2018 13:52:56 +0000 (14:52 +0100)]
[TASK] Simplify bamboo variable to label handling

Intercept has been adapted, the variable to label handing
can be simplified a bit.

Resolves: #87109
Releases: master, 8.7, 7.6
Change-Id: I27255ef9f5eb515c89f5d89e7061fc473e2abec1
Reviewed-on: https://review.typo3.org/59064
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Simplify test setup to avoid double exception codes 61/59061/5
Anja Leichsenring [Sat, 8 Dec 2018 10:50:46 +0000 (11:50 +0100)]
[BUGFIX] Simplify test setup to avoid double exception codes

The setup just needs to make sure the exception is expected.
More details are not required.

Change-Id: Id9c27078ddeb2817f3d34c4134c0eca4aa20589a
Resolves: #87108
Relates: #87103
Releases: 8.7
Reviewed-on: https://review.typo3.org/59061
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Prevent double pointer parameter in record list 54/59054/2
Vladimir Falcon Piva [Mon, 26 Nov 2018 14:59:06 +0000 (15:59 +0100)]
[BUGFIX] Prevent double pointer parameter in record list

This fix makes sure that the pointer parameter is added just once into
the record list pagination urls

Resolves: #87007
Releases: master, 8.7
Change-Id: I6db00dd0af0d09277aa9a005e561330acb386809
Reviewed-on: https://review.typo3.org/59054
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 months ago[BUGFIX] Set FE/loginSecurityLevel to normal for no ext:rsaauth loaded 58/59058/6
Florian Peters [Fri, 7 Dec 2018 19:44:04 +0000 (20:44 +0100)]
[BUGFIX] Set FE/loginSecurityLevel to normal for no ext:rsaauth loaded

Provide a silent upgrader the same way as for BE/loginSecurityLevel
to avoid FE login to fail after upgrade.

Resolves: #87103
Releases: 8.7
Related: #86417
Change-Id: Ie2cc2bfe9b542534de6d04259c1e5fc8bcd84fab
Reviewed-on: https://review.typo3.org/59058
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[BUGFIX] Mark changes in `selectMultipleSideBySide` 57/59057/2
Andreas Fernandez [Fri, 7 Dec 2018 18:50:39 +0000 (19:50 +0100)]
[BUGFIX] Mark changes in `selectMultipleSideBySide`

A `selectMultipleSideBySide` field is now marked as "changed" when either
the order of items has changed or when an item has been removed.

Resolves: #87082
Releases: master, 8.7
Change-Id: I9f50576270db667751c14e3513d1a7cd31c1135e
Reviewed-on: https://review.typo3.org/59057
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Send payload of image cropping wizard via POST 86/58786/3
Andreas Fernandez [Mon, 29 Oct 2018 22:17:55 +0000 (23:17 +0100)]
[BUGFIX] Send payload of image cropping wizard via POST

The image cropper wizard configuration can become very large, which
might break the wizard as the configuration is sent via query parameters
and "Request-URI Too Long" might kick in.

The payload is now sent via POST to bypass this issue. As our Modal API
is currently not capable of sending AJAX requests via POST, the logic
regarding the icon spinner is duplicated for the time being.

Resolves: #82225
Releases: master, 8.7
Change-Id: I7106b62fcc09101bc5147277225d1b8e89133d5c
Reviewed-on: https://review.typo3.org/58786
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Add missing translation value for Modals 53/59053/3
Anja Leichsenring [Fri, 7 Dec 2018 14:24:57 +0000 (15:24 +0100)]
[BUGFIX] Add missing translation value for Modals

Changes syntax for translation key and add default language value.

Resolves: #87001
Releases: master, 8.7
Change-Id: I5a634aff013f6d4af68f25b8288ed04bc340e823
Reviewed-on: https://review.typo3.org/59053
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 months ago[BUGFIX] Fix return type annotation in ResourceStorage::sanitizeFileName() 50/59050/2
Andreas Fernandez [Fri, 7 Dec 2018 10:53:08 +0000 (11:53 +0100)]
[BUGFIX] Fix return type annotation in ResourceStorage::sanitizeFileName()

Resolves: #87096
Releases: master, 8.7
Change-Id: I0a46420cb910d19223a8bb133d9e7457fbd29ee2
Reviewed-on: https://review.typo3.org/59050
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 months ago[BUGFIX] Upgrade linkhandler syntax to new link syntax 46/59046/2
Johannes Kasberger [Tue, 27 Nov 2018 16:24:56 +0000 (17:24 +0100)]
[BUGFIX] Upgrade linkhandler syntax to new link syntax

The \TYPO3\CMS\Core\LinkHandling\RecordLinkHandler::asString method
expects the parameters to hold the identifier and uid as top-level
array elements.
The legacy syntax converter now ensures that this nesting is correct.

Besides that we now also upgrade the very old linkhandler syntax
with no identifier.

Therefore we accept
 - record:<identifier>:<table>:<uid>
 - record:<table>:<uid>

Resolves: #80806
Releases: master, 8.7
Change-Id: I01c3d525de43a56d610dc882ef406de631a8762e
Reviewed-on: https://review.typo3.org/59046
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 months ago[BUGFIX] Get only valid template records in backend -> Template -> PID 0 72/58472/5
Ioulia Kondratovitch [Sat, 29 Sep 2018 18:41:01 +0000 (20:41 +0200)]
[BUGFIX] Get only valid template records in backend -> Template -> PID 0

Get only template records, where corresponding parent page really exists
in the database.

Resolves: #86453
Releases: 8.7
Change-Id: Ie9d403fd3979ae76d1192ccd39408310d8938e8d
Reviewed-on: https://review.typo3.org/58472
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 months ago[BUGFIX] Remove expired cache_treelist entries during runtime 31/59031/2
Alexander Schnitzler [Mon, 26 Nov 2018 09:58:48 +0000 (10:58 +0100)]
[BUGFIX] Remove expired cache_treelist entries during runtime

When \TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer::getTreeList
checked for an existing cache_treelist entry, the given md5hash and the
expiry timestamp had been compared. As caches do not expire at all by
default, there a very few cases when an entry is actually expired.

However, if a cache entry has been expired, the cache entry hasn't been
removed and therefore the creation of a new cache entry with the same
md5hash identifier resulted in a duplicate entry exception.

To solve this, the affected, expired entry will be removed during runtime.

Releases: master, 8.7
Resolves: #86028
Resolves: #86491
Change-Id: If1a907607db29f7edd0fa77a8bb47a69bdfc0df9
Reviewed-on: https://review.typo3.org/59031
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 months ago[BUGFIX] Add getter for tsfe->pageCacheTags 28/59028/2
Benni Mack [Tue, 4 Dec 2018 16:03:08 +0000 (17:03 +0100)]
[BUGFIX] Add getter for tsfe->pageCacheTags

Resolves: #87066
Releases: master, 8.7
Change-Id: I9ed1d82d03f3518018699402d5b3a93930e49457
Reviewed-on: https://review.typo3.org/59028
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Log a warning if fluid-based preview template couldn't be rendered 66/58966/3
Josef Glatz [Wed, 28 Nov 2018 04:41:50 +0000 (05:41 +0100)]
[TASK] Log a warning if fluid-based preview template couldn't be rendered

A warning is logged if the fluid-based preview template for a
content element could not be rendered.

The logged warning includes
- the UID of the content element
- the resulting path to the template file
- and the exception message

Resolves: #87015
Releases: master, 8.7
Change-Id: I2cd100a5140a07845145b16259b7cbe3e5eed852
Reviewed-on: https://review.typo3.org/58966
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
3 months ago[BUGFIX] Rename invalid file name of RST 07/59007/2
Benni Mack [Sat, 1 Dec 2018 21:39:36 +0000 (22:39 +0100)]
[BUGFIX] Rename invalid file name of RST

Due to a bug within Gerrit's editing interface, a file got renamed with a "\t"
filename at the end.

Resolves: #87054
Related: #65636
Releases: 8.7
Change-Id: Id9440309ef48000465e927fabe49a3d4a851e7ee
Reviewed-on: https://review.typo3.org/59007
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Make meta data editable for non-writable storages 78/58978/3
Nicole Cordes [Tue, 25 Aug 2015 16:29:28 +0000 (18:29 +0200)]
[BUGFIX] Make meta data editable for non-writable storages

Decouple check for writable files/storage from permission
to edit meta data. Permission to edit meta data is now
only denied when users have only access to the file
via a readonly file mount.

Resolves: #65636
Resolves: #66507
Releases: master, 8.7
Change-Id: I25a0fbc9cf761898dbdb95dec1d3d39bb2f4b7fd
Reviewed-on: https://review.typo3.org/58978
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[TASK] Update bamboo to gerrit notification url 71/58971/3
Christian Kuhn [Wed, 28 Nov 2018 15:21:23 +0000 (16:21 +0100)]
[TASK] Update bamboo to gerrit notification url

Resolves: #87026
Releases: master, 8.7, 7.6
Change-Id: Idfbf4bbf0bab8a6e4bedc37e92903ed2c85af494
Reviewed-on: https://review.typo3.org/58971
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 months ago[BUGFIX] Allow `<s>` tag in RTE processing in CSS styled content too 69/58969/2
Jigal van Hemert [Wed, 28 Nov 2018 10:37:39 +0000 (11:37 +0100)]
[BUGFIX] Allow `<s>` tag in RTE processing in CSS styled content too

Resolves: #87024
Relates: #87012
Releases: 8.7
Change-Id: Idcfbea18615ce89b47152ecee1220df42a39751e
Reviewed-on: https://review.typo3.org/58969
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 months ago[BUGFIX] Allow `<s>` tag in RTE processing 58/58958/3
Andreas Fernandez [Tue, 27 Nov 2018 09:40:32 +0000 (10:40 +0100)]
[BUGFIX] Allow `<s>` tag in RTE processing

`lib.parseFunc` is now capable of handling the `<s>` tag by adding it to
`allowTags`. The list already contains `<strike>`, but this is a
non-valid tag in HTML5. For compatibility reasons, both tags exist now.

Resolves: #87012
Releases: master, 8.7
Change-Id: I113b7721c9483735dff0875f8c7bffb276f09e5b
Reviewed-on: https://review.typo3.org/58958
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
3 months ago[BUGFIX] Drop GROUP BY clause in Info > PageTS Config 65/58965/3
Andreas Fernandez [Tue, 27 Nov 2018 15:18:22 +0000 (16:18 +0100)]
[BUGFIX] Drop GROUP BY clause in Info > PageTS Config

The GROUP BY clause used in InfoPageTypoScriptConfigController's
`getOverviewOfPagesUsingTSConfig()` is dropped, as grouping by
a unique value doesn't make any sense.

Resolves: #87019
Related: #76484
Releases: master, 8.7
Change-Id: I0054064fb6f0bba9b65737bf323db364377bb4e6
Reviewed-on: https://review.typo3.org/58965
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 months ago[BUGFIX] Enlarge scheduler object DB field 55/58955/2
Benni Mack [Mon, 26 Nov 2018 14:51:45 +0000 (15:51 +0100)]
[BUGFIX] Enlarge scheduler object DB field

The serialized PHP object is stored within the database field
"serialized_task_object". When serializing this could lead to several
issues.

One particular issue is that the object has lots of data or dependencies,
it cannot be stored at all in this database field.

Although we know that this implementation detail of scheduler is a rather
bad idea, we can only fix this by enlarging the field from "blob" to
"mediumblob" for now.

Resolves: #87006
Releases: master, 8.7
Change-Id: I2b335f258fe18b494033bde28eff76f2e67d34bb
Reviewed-on: https://review.typo3.org/58955
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
4 months ago[BUGFIX] Fix outdated link in docs 18/58918/2
Philipp Kitzberger [Tue, 20 Nov 2018 09:37:35 +0000 (10:37 +0100)]
[BUGFIX] Fix outdated link in docs

That linked resource is just not available under that URL anymore.

Releases: master, 8.7
Resolves: #86951
Change-Id: I22ca04e00d7ce74f5d3a7f072c27d20bbfd193a2
Reviewed-on: https://review.typo3.org/58918
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[BUGFIX] Strip tags only from strings in ArrayUtility::stripTagsFromValuesRecursive 14/58914/2
Wolfgang Klinger [Thu, 15 Nov 2018 16:45:15 +0000 (17:45 +0100)]
[BUGFIX] Strip tags only from strings in ArrayUtility::stripTagsFromValuesRecursive

Prevent an implicit type cast to string through strip_tags.
Ignore any scalar values other than string,
but preserve the possibility of an object's __toString conversion.

Resolves: #86938
Releases: master, 8.7
Change-Id: I27cb7834dc9e838f60f0d1bda94ab2c4e4011043
Reviewed-on: https://review.typo3.org/58914
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Check number of file extensions 13/58913/2
Benni Mack [Mon, 19 Nov 2018 08:36:48 +0000 (09:36 +0100)]
[TASK] Check number of file extensions

Show the add media and text form only if at least
one file extension exists.

Resolves: #86925
Releases: master, 8.7
Change-Id: I37c23800f1ddda78b7f248c0de9e970a73976c4a
Reviewed-on: https://review.typo3.org/58913
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Add searchFields in TCA for sys_news, sys_action and sys_note 12/58912/2
Wolfgang Klinger [Fri, 16 Nov 2018 17:06:02 +0000 (18:06 +0100)]
[TASK] Add searchFields in TCA for sys_news, sys_action and sys_note

Resolves: #86932
Releases: master, 8.7
Change-Id: Ic699b0af99fb73bfdb91e3dbbb3e6f3e41335b5b
Reviewed-on: https://review.typo3.org/58912
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Cast file resource pointer in UploadFileReferenceConverter 11/58911/2
Georg Ringer [Wed, 7 Nov 2018 21:39:40 +0000 (22:39 +0100)]
[BUGFIX] Cast file resource pointer in UploadFileReferenceConverter

The return value of the hmac check is a string and must be casted to
an integer as the method using the value requires an integer.

Resolves: #86878
Releases: master, 8.7
Change-Id: Ic6db911c213eb668141ba0c849ff8a627a6f94dc
Reviewed-on: https://review.typo3.org/58911
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Select proper records in DBAL workspace restrictions 02/58902/2
Benni Mack [Thu, 15 Nov 2018 10:28:11 +0000 (11:28 +0100)]
[BUGFIX] Select proper records in DBAL workspace restrictions

A new WorkspaceRestriction is added to solve all issues
once and for all.

For now, this restriction is only added in v8.7 but not in use yet.

Resolves: #84985
Releases: master, 8.7
Change-Id: I22d5f276460107802bef3d390e6781434f1c28d3
Reviewed-on: https://review.typo3.org/58902
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Check Tsconfig in page module for value of content element 92/58892/2
Georg Ringer [Tue, 13 Nov 2018 12:46:53 +0000 (13:46 +0100)]
[BUGFIX] Check Tsconfig in page module for value of content element

In case a content element is added with TsConfig its label can't be
loaded from TCA but the TsConfig must be checked.

Resolves: #86909
Releases: master, 8.7
Change-Id: I2de2b73dcd4799a45aece330f377e86bd2bf596f
Reviewed-on: https://review.typo3.org/58892
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Show frontend user image migration wizard again 95/58895/2
Markus Klein [Wed, 14 Nov 2018 12:21:24 +0000 (13:21 +0100)]
[BUGFIX] Show frontend user image migration wizard again

Resolves: #82068
Releases: 8.7
Change-Id: Id972e5531cf9e85fd7a1ecf8bd69a9912a384084
Reviewed-on: https://review.typo3.org/58895
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Remove leftovers of "options.uploadFieldsInTopOfEB" 76/58876/2
Georg Ringer [Thu, 8 Nov 2018 20:08:37 +0000 (21:08 +0100)]
[TASK] Remove leftovers of "options.uploadFieldsInTopOfEB"

With #80463 - before v8 LTS - the setting
"options.uploadFieldsInTopOfEB" has been removed from the templates,
no need to check the value inside the PHP code anymore.

Resolves: #86885
Related: #86848
Releases: master, 8.7
Change-Id: I40c333aeba2987a57fe26353f00ac55a74da7878
Reviewed-on: https://review.typo3.org/58876
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Ignore provided pages for sitemap menu 75/58875/2
Georg Ringer [Tue, 6 Nov 2018 07:15:02 +0000 (08:15 +0100)]
[BUGFIX] Ignore provided pages for sitemap menu

The sitemap menu doesn't show the pages field and therefore
it must not be used in the MenuProcessor configuration as well.

Resolves: #85693
Releases: master, 8.7

Change-Id: I286054cc58982fa0db4fed0af82d7c065b1700a4
Reviewed-on: https://review.typo3.org/58852
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-on: https://review.typo3.org/58875
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Hide internal prefix "cat:" in tags of upgrade docs 63/58863/2
Georg Ringer [Mon, 5 Nov 2018 19:28:52 +0000 (20:28 +0100)]
[BUGFIX] Hide internal prefix "cat:" in tags of upgrade docs

The prefix "cat:" is used internally and it doesn't make sense to
show it to a regular user. Neither does it provide more output nor is
"cat" a regular word.

Resolves: #86858
Releases: master, 8.7
Change-Id: I8c48819814767c1ef4367c49da9ab3685081dceb
Reviewed-on: https://review.typo3.org/58863
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Fix isMissing called on Null error 50/58850/2
Bernhard Sirlinger [Mon, 5 Nov 2018 21:12:40 +0000 (22:12 +0100)]
[BUGFIX] Fix isMissing called on Null error

Add a Null check in FileLinktype->checkLink
function

Resolves: #86857
Releases: master,8.7
Change-Id: I2cc270dd7b8392fa8fd240c6efca3894f0ce3273
Reviewed-on: https://review.typo3.org/58850
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Changed label for page_tree_stop 31/58831/2
Steffen Dietrich [Fri, 2 Nov 2018 16:51:54 +0000 (17:51 +0100)]
[TASK] Changed label for page_tree_stop

Clearified the message of the label of the field.
Added tooltip for a better explanation.

Resolves: #84580
Releases: master, 8.7
Change-Id: I13488115161a949193b2c5765b29407437f6b1ea
Reviewed-on: https://review.typo3.org/58831
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Keep existing validation errors for recursive domain relations 33/58833/3
Markus Klösges [Mon, 16 Apr 2018 08:43:24 +0000 (10:43 +0200)]
[BUGFIX] Keep existing validation errors for recursive domain relations

Do not overwrite already generated validation errors when a property
validator leads to a recursive validate() call to the currently
validated GenericObjectValidator.

Resolves: #84475
Releases: master, 8.7
Change-Id: Ifbdb28ddcf6a8e7f1517801ebcd6634149b2bd5d
Reviewed-on: https://review.typo3.org/58833
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Fix translated file relation with sql_mode=ONLY_FULL_GROUP_BY 26/58826/2
Mathias Brodala [Wed, 31 Oct 2018 16:34:11 +0000 (17:34 +0100)]
[BUGFIX] Fix translated file relation with sql_mode=ONLY_FULL_GROUP_BY

The SQL mode ONLY_FULL_GROUP_BY enforces all fields used in "GROUP BY"
to be present in "SELECT".

See https://dev.mysql.com/doc/refman/8.0/en/sql-mode.html#sqlmode_only_full_group_by

Resolves: #85159
Releases: master, 8.7
Change-Id: Iff7895dd9703557ca0b91613516bdb3391b4d4f6
Reviewed-on: https://review.typo3.org/58826
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Provide effectivePid for flexforms segment 23/58823/2
Patrick Lenk [Tue, 30 Oct 2018 11:20:36 +0000 (12:20 +0100)]
[BUGFIX] Provide effectivePid for flexforms segment

Custom ckeditor config is now loaded in flexforms.

Resolves: #83809
Related: #81748
Releases: master, 8.7
Change-Id: I9c0fe85d81f3e34209cd52afee18594e49020f54
Reviewed-on: https://review.typo3.org/58823
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Adding 3 to "TYPO" 12/58812/2
Mathias Brodala [Wed, 31 Oct 2018 15:41:11 +0000 (16:41 +0100)]
[BUGFIX] Adding 3 to "TYPO"

On other "TYPO3" references the "3" is present but not on this occurence.
Add the "3" to "TYPO" in order to have "TYPO3".

Releases: master, 8.7
Resolves: #86816
Change-Id: I21cfe6b10ca1757645c407014b3acbc41b7d7570
Reviewed-on: https://review.typo3.org/58812
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[TASK] Add PHP 7.3 to bamboo core v8 testing 08/58808/2
Christian Kuhn [Wed, 31 Oct 2018 10:09:57 +0000 (11:09 +0100)]
[TASK] Add PHP 7.3 to bamboo core v8 testing

Change-Id: I84575fb973027c184ac2f9a65d227adc38d57d07
Resolves: #86812
Releases: 8.7
Reviewed-on: https://review.typo3.org/58808
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[BUGFIX] Execute scheduler tasks ordered by next execution time 06/58806/2
Sascha Egerer [Tue, 30 Oct 2018 09:52:04 +0000 (10:52 +0100)]
[BUGFIX] Execute scheduler tasks ordered by next execution time

When executing scheduler tasks the next execution time of the task
should be used to define the execution order.

Resolves: #86795
Releases: master, 8.7
Change-Id: Id678c74a60491aa3c8be8a33534b71ac37245217
Reviewed-on: https://review.typo3.org/58806
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Make the "Stop preview" link clickable when previewing a page (workspaces) 16/58316/4
Guillaume Germain [Tue, 18 Sep 2018 14:28:30 +0000 (16:28 +0200)]
[BUGFIX] Make the "Stop preview" link clickable when previewing a page (workspaces)

Resolves: #86298
Releases: 8.7
Change-Id: I95bde368cff46e0fd02251ad673aefdd6b5f2e6d
Reviewed-on: https://review.typo3.org/58316
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[TASK] Run functional tests without xdebug on bamboo 02/58802/2
Christian Kuhn [Tue, 30 Oct 2018 14:41:54 +0000 (15:41 +0100)]
[TASK] Run functional tests without xdebug on bamboo

With the increased number of functional tests in v9 we
should squeeze out as much performance as possible from
the tests so waiting for bamboo is not so annoying. Not
loading xdebug gives us roughly 10-30% for functionals.

Resolves: #86801
Releases: master, 8.7
Change-Id: Ic7b9dd4dd0c71799ecb7207fc0e7170f98729545
Reviewed-on: https://review.typo3.org/58802
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Show correct namespace in example block of CommaSeparatedValueProcessor 00/58800/3
Joerg Boesche [Tue, 30 Oct 2018 13:27:29 +0000 (14:27 +0100)]
[BUGFIX] Show correct namespace in example block of CommaSeparatedValueProcessor

Resolves: #86800
Releases: master, 8.7
Change-Id: I243589ee7e619f26e99e27d34c626e848a1ee80a
Reviewed-on: https://review.typo3.org/58800
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
4 months ago[BUGFIX] Update karma 98/58798/3
Andreas Fernandez [Tue, 30 Oct 2018 11:49:07 +0000 (12:49 +0100)]
[BUGFIX] Update karma

karma is used for JavaScript based unit tests. The currently installed
version is aged and doesn't compile on newer systems anymore, thus the
package is updated to a recent version.

Used command:
yarn add karma@^3.1.0 --dev

Resolves: #86798
Releases: master, 8.7
Change-Id: I1cea78cf3759227a2cd09b8560f37121ae580202
Reviewed-on: https://review.typo3.org/58798
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Test fully built css in bamboo 91/58791/2
Christian Kuhn [Tue, 30 Oct 2018 08:28:11 +0000 (09:28 +0100)]
[TASK] Test fully built css in bamboo

Extend the "Lint scss ts" bamboo job to also build css
next to js and only after that verify with git status
no file changed. This should prevent outdated css as
recently fixed with #86789.
Additionally switch from npm to direct grunt calls,
to be in sync with runTests.sh and to allow kicking
npm from the docker images entirely.

Change-Id: I5134d43c5f5d524005242eee59aa743b6e49219a
Resolves: #86794
Related: #86789
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58791
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Set TYPO3 version to 8.7.21-dev 93/58793/2
Oliver Hader [Tue, 30 Oct 2018 10:41:02 +0000 (11:41 +0100)]
[TASK] Set TYPO3 version to 8.7.21-dev

Change-Id: I133eea5842cb0fc03d7f0b8b3bbbf6180e971d64
Reviewed-on: https://review.typo3.org/58793
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[RELEASE] Release of TYPO3 8.7.20 92/58792/2 8.7.20 TYPO3_8-7-20 v8.7.20
Oliver Hader [Tue, 30 Oct 2018 10:39:35 +0000 (11:39 +0100)]
[RELEASE] Release of TYPO3 8.7.20

Change-Id: I0ac38a40730cc8fa5766a79a09ff3e6b739054ee
Reviewed-on: https://review.typo3.org/58792
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Re-build backend.css 89/58789/3
Christian Kuhn [Tue, 30 Oct 2018 09:37:20 +0000 (10:37 +0100)]
[BUGFIX] Re-build backend.css

v8 is affected by outdated css similar to master.
`# t3-form-structure-panel` vs `#t3-form-structure-panel`
caused by https://review.typo3.org/#/c/55797/

Change-Id: Ied9227d60637e59b57102be240a4d21bf022a74b
Resolves: #86789
Releases: 8.7
Reviewed-on: https://review.typo3.org/58789
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Use typo3/phar-stream-wrapper package 77/58777/3
Oliver Hader [Sun, 26 Aug 2018 20:38:59 +0000 (22:38 +0200)]
[TASK] Use typo3/phar-stream-wrapper package

PharStreamWrapper has been released as standalone package under
the MIT license: https://github.com/TYPO3/phar-stream-wrapper

Stream invocation is handled by the new composer package, previous
classes PharStreamWrapper and PharStreamWrapperException have been
removed from the TYPO3 core but are still kept in class alias maps
for compatibility reasons. Since the standalone package is now
independent from TYPO3 constraints, the TYPO3 specific logic to
intercept Phar invocations has been moved to the new class
PharStreamWrapperInterceptor.

`composer require typo3/phar-stream-wrapper:^3.0.1`

Related: #85984
Resolves: #86666
Releases: 8.7, 7.6
Change-Id: I724c4238d1a8184a8c7c908f16d71c06f87244d8
Reviewed-on: https://review.typo3.org/58777
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Render correct paging label 80/58780/2
Andreas Fernandez [Mon, 29 Oct 2018 15:29:16 +0000 (16:29 +0100)]
[BUGFIX] Render correct paging label

In case of paging in any record list, the page browser is rendered in top
and on bottom of ther record list.

The upper browser now renders the paging correctly by calculating the
offset of items of the previous page instead of hard-coding a "1".

Resolves: #86787
Releases: master, 8.7
Change-Id: Ib7c8856f248107ea9d17aeabe83a564189f69abf
Reviewed-on: https://review.typo3.org/58780
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser 75/58775/5
Frans Saris [Fri, 31 Aug 2018 08:21:13 +0000 (10:21 +0200)]
[BUGFIX] Pass record info when determining defaultUploadFolder in FileBrowser

The fileBrowser now passes the related pid, table and field to
getDefaultUploadFolder().

Resolves: #86053
Releases: master, 8.7
Change-Id: I954753ee84b4107b37ba45cbd08917f4c4be17d9
Reviewed-on: https://review.typo3.org/58775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Add url for linkToTop in css_styled_content 75/57775/3
Joerg Kummer [Thu, 2 Aug 2018 11:17:38 +0000 (13:17 +0200)]
[BUGFIX] Add url for linkToTop in css_styled_content

This adds current URL to the ToTop link when css_styled_content is used.
Fixes broken linkToTop URL's since config.prefixLocalAnchors was removed.
Also compatible with TYPO3 v7 where compatibility6 is installed
and typoscript config.prefixLocalAnchors is configured.

Resolves: #81202
Releases: 8.7, 7.6
Change-Id: Id7b9f1c24575de297d2ca60af686fd6d299343e2
Reviewed-on: https://review.typo3.org/57775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Vollebregt <richard.vollebregt@maxserv.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Allow unicode characters in verifyFileNameAgainstDenyPattern 72/58772/2
Pascal Rinker [Mon, 25 Jun 2018 14:43:32 +0000 (16:43 +0200)]
[BUGFIX] Allow unicode characters in verifyFileNameAgainstDenyPattern

Using (valid) unicode characters in
GeneralUtility::verifyFilenameAgainstDenyPattern was not possible due
to a missing unicode modifier when evaluating regular expressions.
The unicode modifier has been added.
Since unicode errors in regular expressions will lead to `false`
results, it is important to perform type-safe checks against `0`.

Resolves: #67061
Releases: master, 8.7
Change-Id: If3eea7129c92b296b85b93a1f1c81a446a2f5f90
Reviewed-on: https://review.typo3.org/58772
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Pass FlexForm context to USER display condition 70/58770/2
Nicole Cordes [Thu, 27 Sep 2018 14:23:21 +0000 (16:23 +0200)]
[BUGFIX] Pass FlexForm context to USER display condition

If using a user display condition within a FlexForm field,
the passed information is insufficient and information about the
parsed FlexForm is missing.

Resolves: #86403
Releases: master, 8.7
Change-Id: I9917b3f98f7d7eb4fa3370e1cd2e9a9cd0eef627
Reviewed-on: https://review.typo3.org/58770
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Registration of multiple additional view models 68/58768/2
Ralf Zimmermann [Fri, 31 Aug 2018 17:17:22 +0000 (19:17 +0200)]
[BUGFIX] Registration of multiple additional view models

The form setup properties within "additionalViewModelModules" must be
written as numerical associative arrays to make it possible that
multiple extensions can extend the form editor with javascript modules.

Resolves: #85710
Releases: master, 8.7
Change-Id: Iaddf1bfd6f4df8d0c01e0c18be9cef458d8d2caf
Reviewed-on: https://review.typo3.org/58768
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Correctly resolve parameter for USER display condition 67/58767/2
Nicole Cordes [Thu, 27 Sep 2018 13:56:11 +0000 (15:56 +0200)]
[BUGFIX] Correctly resolve parameter for USER display condition

According to the documentation there is no limit of the used
additional parameters. However during parameter processing, there
is a limit of 4 parameters applied. This limit needs to be unset
when dealing with a USER display condition.

Resolves: #85274
Releases: master, 8.7
Change-Id: Ieff6d089cbb5540ab1d3b389eb0511ef993b900d
Reviewed-on: https://review.typo3.org/58767
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] BE checkFullLanguagesAccess check all translated records 65/58765/2
Benni Mack [Sun, 28 Oct 2018 14:12:11 +0000 (15:12 +0100)]
[BUGFIX] BE checkFullLanguagesAccess check all translated records

All translated records are checked for language access in the method
checkFullLanguagesAccess of BackendUserAuthentication

Resolves: #86778
Releases: master, 8.7
Change-Id: I9c0101507c741471a8537a92329a9a66b78fa559
Reviewed-on: https://review.typo3.org/58765
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use different placeholder than ### 63/58763/2
Benni Mack [Sun, 28 Oct 2018 13:38:22 +0000 (14:38 +0100)]
[TASK] Use different placeholder than ###

preg_quote since PHP 7.3.0 also quotes #.
Simply use a different placeholder.

Resolves: #86586
Releases: master, 8.7, 7.6
Change-Id: I8ed9bd39605341a09347e21dd38c9a1824a01ee5
Reviewed-on: https://review.typo3.org/58763
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Fix continue-statement inside a switch-block 61/58761/2
Stefan Neufeind [Sun, 7 Oct 2018 23:37:18 +0000 (01:37 +0200)]
[TASK] Fix continue-statement inside a switch-block

Calling continue inside a switch-block would work just like break.
This is usually not intended and thus triggers a warning since
PHP 7.3.0.

Resolves: #86589
Releases: master, 8.7, 7.6
Change-Id: Ic35998b8a37bd35110b9d3494f1cf258e845097a
Reviewed-on: https://review.typo3.org/58761
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Keep update button in linkbrowser for RTE CKEditor on edit 60/58760/2
Joerg Kummer [Sat, 27 Oct 2018 18:21:42 +0000 (20:21 +0200)]
[BUGFIX] Keep update button in linkbrowser for RTE CKEditor on edit

This patch moves the current value of the link into the parameter array
for the linkbrowser to keep the value in all linked actions inside the
linkbrowser for the RTE CKEditor.

This keeps the update button in the page linkhandler,
if an existing page link will be edited.

Resolves: #83545
Releases: master, 8.7
Change-Id: Ia9217057e45a5d94668bb5ac2f111198da9a69d1
Reviewed-on: https://review.typo3.org/58760
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Fix the extbase CoreCommand with lowest requirements 11/58711/3
Oliver Klee [Fri, 26 Oct 2018 13:00:30 +0000 (15:00 +0200)]
[BUGFIX] Fix the extbase CoreCommand with lowest requirements

The extbase CoreCommand class calls a method that was introduced in
symfony/console 3.2. So the CoreCommand class needs to check whether
the method-to-call actually exists before calling it.

This only affects the 8.7 branch as the master/9LTS branch already
requires a higher version of symfony/console, and 7.6 does not have
the class with the corresponding call yet.

Resolves: #86753
Releases: 8.7
Change-Id: I8dad6abd4b07c23b7520726f120a6116227c33a7
Reviewed-on: https://review.typo3.org/58711
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Process large list of hashes in chunks updating reference index 56/58756/2
Benni Mack [Sun, 28 Oct 2018 12:12:52 +0000 (13:12 +0100)]
[BUGFIX] Process large list of hashes in chunks updating reference index

The list of old hashes by cleaning up the reference index can
be very long. To avoid exceeding query limits like maximum number
of placeholder per query or the max allowed statement length these
large lists are split into chunks of safe length before processing.

Resolves: #85795
Releases: master, 8.7
Change-Id: Iaebc555fe791f9e41f336bcd30d5b6eb149ad4e9
Reviewed-on: https://review.typo3.org/58756
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Performance optimizations for the form manager module 75/58375/4
Ralf Zimmermann [Mon, 27 Aug 2018 23:10:07 +0000 (01:10 +0200)]
[TASK] Performance optimizations for the form manager module

Speeds up the form manager module and the form plugin especially
if there are many forms within the TYPO3 instance.

Resolves: #86000
Releases: master, 8.7
Change-Id: Ic483029e0d1b1955d58e04496f97862c00b6d6a4
Reviewed-on: https://review.typo3.org/58375
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Correctly resolve parent folder in AbstractHierarchicalFilesystemDriver 57/58757/2
Nicole Cordes [Wed, 13 Jun 2018 10:08:15 +0000 (12:08 +0200)]
[BUGFIX] Correctly resolve parent folder in AbstractHierarchicalFilesystemDriver

This patch ensures that
AbstractHierarchicalFilesystemDriver::getParentFolderIdentifierOfIdentifier
always returns a file identifier using forward slashes. Furthermore
it removes double forward slashes for a root folder identifier.

Resolves: #85249
Releases: master, 8.7
Change-Id: I562eaade7353e5235d4f65725a4159f6c0b71d75
Reviewed-on: https://review.typo3.org/58757
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Catch Exceptions in RTE with invalid links 55/58755/2
Benni Mack [Sat, 27 Oct 2018 21:35:40 +0000 (23:35 +0200)]
[BUGFIX] Catch Exceptions in RTE with invalid links

Only one area is covered with catching invalid links when setting
an ugly external URL without proper scheme.

The other area is caught now too.

Resolves: #84009
Releases: master, 8.7
Change-Id: Ief7549009b114803daacf39e36528523718a0d36
Reviewed-on: https://review.typo3.org/58755
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Allow more tags when no RTE processing is available 49/58749/2
Benni Mack [Sat, 27 Oct 2018 21:28:41 +0000 (23:28 +0200)]
[BUGFIX] Allow more tags when no RTE processing is available

If somebody has no RTE extension available, there is also no
RTE processing information available, so the default
from RteHtmlParser is used. However, tags like <abbr>
are then not provided by the yaml configuration, so they are
not allowed, and thus - escaped.

The patch adds abbr,acronym and dfn to be allowed all the time.

Resolves: #83424
Releases: master, 8.7
Change-Id: Ifdc0e7f155bef95a7c397584f2cf7b1eab61f6bb
Reviewed-on: https://review.typo3.org/58749
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Respect saveDocNew TSConfig option 03/58603/2
Susanne Moog [Tue, 9 Oct 2018 14:21:07 +0000 (16:21 +0200)]
[BUGFIX] Respect saveDocNew TSConfig option

For translated tt_content elements the saveDocNew button
was solely dependent on the free vs. connected mode setup.
However, if the button has been hidden via TSConfig
completely it should not magically reappear when editing a
translation in free mode.

(This patch only applies to TYPO3 8 as the buttons
changed for version 9).

Change-Id: I0f74e87acbac127b8bbc09f4fee39c633a3a49f6
Resolves: #85774
Releases: 8.7
Reviewed-on: https://review.typo3.org/58603
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Adjust headline decoration in documentation file 54/58754/2
Anja [Sun, 28 Oct 2018 09:36:54 +0000 (10:36 +0100)]
[BUGFIX] Adjust headline decoration in documentation file

Change-Id: Ic30290ba8548049b2c053d1e3bfa4beae1615e24
Resolves: #86775
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58754
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Have LF line endings for .sh scripts in .gitattributes 53/58753/2
Christian Kuhn [Sun, 28 Oct 2018 09:26:04 +0000 (10:26 +0100)]
[TASK] Have LF line endings for .sh scripts in .gitattributes

Resolves: #86774
Releases: master, 8.7
Change-Id: I8b677426c6011a0b3115f83380ae567582dc9c17
Reviewed-on: https://review.typo3.org/58753
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Linkvalidator validates linked content elements 35/58735/3
Patrick Broens [Mon, 16 Jul 2018 13:49:45 +0000 (15:49 +0200)]
[BUGFIX] Linkvalidator validates linked content elements

This patch makes the LinkValidator check typolinks to tt_content
elements like t3://page?uid=x#y by calling InternalLinktype twice, once
for the page as first part of the SoftReferenceIndex and again for the
tt_content element as second part.

Resolves: #85576
Related: #84016
Releases: master, 8.7
Change-Id: I94243e66f5eff38c9a0b0859a85aac48885e38ba
Reviewed-on: https://review.typo3.org/58735
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] EvaluteDisplayCondition should throw proper error message 36/58736/2
Benni Mack [Sat, 29 Sep 2018 23:42:41 +0000 (01:42 +0200)]
[BUGFIX] EvaluteDisplayCondition should throw proper error message

When an extension author writes a display condition in TCA and
by incident uses a wrong format for the displayCondition (see ticket)
the strtoupper fails due to the lack of an associative array
because it's a numeric-key array.

An additional check fixes the issue.

Resolves: #79692
Releases: master, 8.7
Change-Id: I4455bdc908e0be1a373f86680e718e876aa5ddd7
Reviewed-on: https://review.typo3.org/58736
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Streamline EM dependency resolving 39/58739/2
Josef Glatz [Tue, 18 Sep 2018 20:50:20 +0000 (22:50 +0200)]
[TASK] Streamline EM dependency resolving

Adjust the style of the action accordingly and
add a small description to the main header.

Resolves: #86304
Releases: master, 8.7
Change-Id: I37a199d0a9626d4c87354ada7bce662bb089418f
Reviewed-on: https://review.typo3.org/58739
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] Allow relative URLs in locationHeaderUrl 32/58732/4
Susanne Moog [Thu, 25 Oct 2018 20:18:45 +0000 (22:18 +0200)]
[BUGFIX] Allow relative URLs in locationHeaderUrl

Resolves: #81720
Releases: master, 8.7
Change-Id: I099c905bf335a13fafa920c2849fd88971dc0e44
Reviewed-on: https://review.typo3.org/58732
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Recover switched items in maxitems=1 selectMultipleSideBySide 29/58729/2
Kevin von Spiczak [Tue, 9 Oct 2018 11:32:37 +0000 (13:32 +0200)]
[BUGFIX] Recover switched items in maxitems=1 selectMultipleSideBySide

Shows and re-enables all the options, that are currently not selected
when using maxitems = 1

Resolves: #86594
Releases: master, 8.7
Change-Id: I1f5e727ec42203981edaaf4b79bb6e201352d296
Reviewed-on: https://review.typo3.org/58729
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Prevent null value being passed to hash_equals 13/58713/2
Benni Mack [Fri, 26 Oct 2018 13:41:09 +0000 (15:41 +0200)]
[BUGFIX] Prevent null value being passed to hash_equals

The second parameter of hash_equals must be a string but could be a
null value in the FileDumpController. It is ensured now that the
value is always a string.

Resolves: #86599
Releases: master, 8.7
Change-Id: Iaf682b405be6712aa31603521a2d873b4c3bcb89
Reviewed-on: https://review.typo3.org/58713
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Remove surrounding &nsbp; in the tables with ol or ul in CKEditor 19/58719/2
Benni Mack [Fri, 26 Oct 2018 15:07:42 +0000 (17:07 +0200)]
[BUGFIX] Remove surrounding &nsbp; in the tables with ol or ul in CKEditor

This patch removes generated &nbsp; in tables with ol or ul inside. This
is unintented behaviour, and we can't manually remove them from table.

Also, I moved HTMLparser section into existing nonTypoTagStdWrap

Resolves: #83795
Releases: master, 8.7
Change-Id: I711e4cbab8249fe6f43c8abe6f63183eaac9131f
Reviewed-on: https://review.typo3.org/58719
Reviewed-by: Nicolai Schirawski <ns@t3magic.de>
Tested-by: Nicolai Schirawski <ns@t3magic.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Avoid exception of renderType selectCheckBox in workspace 14/58714/2
Alexey Atsyn [Fri, 6 Jul 2018 14:03:50 +0000 (19:03 +0500)]
[BUGFIX] Avoid exception of renderType selectCheckBox in workspace

Resolves: #85109
Releases: master, 8.7
Change-Id: I34a269ec2d564a546d4dc2036a97eb1027d2352f
Reviewed-on: https://review.typo3.org/58714
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] CleanerTask processes all FileResource Fields 10/58710/2
Sven Jürgens [Fri, 1 Jun 2018 13:19:32 +0000 (15:19 +0200)]
[BUGFIX] CleanerTask processes all FileResource Fields

By removing an errorous break in a loop, all FileResource Fields are found
and therefor all connected files can be deleted.

Resolves: #85140
Releases: master, 8.7
Change-Id: I0aea4427dd9e74b1a11ab04e8aa235e17ae1a031
Reviewed-on: https://review.typo3.org/58710
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Register "then"/"else" in IfHasRoleViewHelper again 02/58702/2
Mathias Brodala [Thu, 25 Oct 2018 09:07:58 +0000 (11:07 +0200)]
[BUGFIX] Register "then"/"else" in IfHasRoleViewHelper again

This fixes the usage of "then" and "else" for the inline notation.

Resolves: #86743
Releases: master, 8.7
Change-Id: Ia0a749fedcb3b3d4ffe7f90ac40ab604fd7c340a
Reviewed-on: https://review.typo3.org/58702
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[TASK] Update php-cs-fixer configuration to exclude _generated directory 84/58684/2
Sybille Peters [Wed, 24 Oct 2018 08:21:38 +0000 (10:21 +0200)]
[TASK] Update php-cs-fixer configuration to exclude _generated directory

Resolves: #86730
Releases: master, 8.7
Change-Id: I9e707e6d9c1305baa92b7f2c4c0f83bbeea52daa
Reviewed-on: https://review.typo3.org/58684
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[BUGFIX] Remove `fbclid` argument from chash calculation 72/58672/3
Andreas Fernandez [Tue, 23 Oct 2018 06:19:27 +0000 (08:19 +0200)]
[BUGFIX] Remove `fbclid` argument from chash calculation

Facebook adds the `fbclid` argument to outbound URLs which triggers a
recalculcation of the cache hash. The argument is now added to the
blacklist for chash parameters.

Resolves: #86715
Releases: master, 8.7, 7.6
Change-Id: I8cd66fdfa2c549c65750d6ef896261cccba4b54d
Reviewed-on: https://review.typo3.org/58672
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Update Build/yarn.lock 64/58664/2
Christian Kuhn [Sat, 20 Oct 2018 13:01:09 +0000 (15:01 +0200)]
[TASK] Update Build/yarn.lock

Younger yarn versions contain sha sums in the lock file.
Adapt the file so testing has current state again.

Change-Id: I356b00845aee7c7a9ec1e20a1466fa9869b588c8
Resolves: #86702
Releases: 8.7
Reviewed-on: https://review.typo3.org/58664
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Enable v8 acceptance testing again 45/58645/31
Christian Kuhn [Tue, 16 Oct 2018 15:26:18 +0000 (17:26 +0200)]
[TASK] Enable v8 acceptance testing again

core master and typo3/testing-framework received lots
of patches to stabilize the acceptance tests while these
tests remained inactive in v8 branch. The patch ports
the meanwhile pretty stable test changes from master
back to v8 and activates ac testing in bamboo as pre-merge
and nightly again.

composer remove enm1989/chromedriver
composer require --dev typo3/testing-framework ~1.3.0

Change-Id: I68294e1304bf8fd0f7f5a2a35199c6728189286a
Resolves: #86677
Releases: 8.7
Reviewed-on: https://review.typo3.org/58645
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Activate bamboo nightly mssql functional tests 43/58643/4
Christian Kuhn [Tue, 16 Oct 2018 12:45:31 +0000 (14:45 +0200)]
[TASK] Activate bamboo nightly mssql functional tests

The functional tests on mssql in 8.7 were disabled for
while. Enable them for the nightly build again.

* bamboo php70 & php71 contain sqlsrv driver again
* docker setup for mssql
* execute mssql nightly functionals, not pre-merge (too slow)
* backport minor test changes in impexp fixtures

Change-Id: Iae5e9602a0141a236e7765be2ff0ddb18aa7bb24
Resolves: #86673
Releases: 8.7
Reviewed-on: https://review.typo3.org/58643
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Use correct variable name in OnlineMedia.js 22/58622/2
Tymoteusz Motylewski [Fri, 12 Oct 2018 13:23:41 +0000 (15:23 +0200)]
[BUGFIX] Use correct variable name in OnlineMedia.js

Resolves: #86630
Releases: master, 8.7
Change-Id: I4bce2665ed54cddc3a151445c5863c24ffac6df6
Reviewed-on: https://review.typo3.org/58622
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Correct inline foreign_unique with target type="group" handling 22/58422/4
Cyril Janody [Thu, 27 Sep 2018 22:31:10 +0000 (18:31 -0400)]
[BUGFIX] Correct inline foreign_unique with target type="group" handling

Using type="inline" and MM relations having type="group" (instead of
type="select") and foreign_unique defined results in a fatal since
group db relations have been resolved to an array in TcaGroup data
provider already.

Change-Id: I20d138e7622aafb097a11e60014f9e4398bae811
Resolves: #82104
Resolves: #84735
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58422
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself 13/58613/2
Josef Glatz [Tue, 9 Oct 2018 03:51:46 +0000 (05:51 +0200)]
[BUGFIX] pages.content_from_pid suggest wizard should not suggest itself

Make it impossible to select the page you are currently
working on within the suggest wizard result set.

In addition, the suggest has been improved to search also in the
following fields of page records:
* nav_title
* alias
* url

Releases: master, 8.7
Resolves: #86600
Related: #54867
Change-Id: Ifce04fc5f01b5585f2320901b56be8b9970d4762
Reviewed-on: https://review.typo3.org/58613
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Let FileBrowser render the readable directory path 10/58610/2
Andreas Fernandez [Tue, 9 Oct 2018 12:46:32 +0000 (14:46 +0200)]
[BUGFIX] Let FileBrowser render the readable directory path

The FileBrowser is changed to render the human readable path of a
directory instead of the raw identifier.

Resolves: #86603
Releases: master, 8.7
Change-Id: I437075cfdeb6adaeddd38a55ff6f4fbd5415a351
Reviewed-on: https://review.typo3.org/58610
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>