Packages/TYPO3.CMS.git
5 months ago[TASK] Add HTTP headers to Frontend Response object 99/58499/10
Benni Mack [Sun, 30 Sep 2018 13:23:28 +0000 (15:23 +0200)]
[TASK] Add HTTP headers to Frontend Response object

HTTP Headers are added to the PSR-7 response object now
within TSFE.

They are then sent at the very end of the request process.

A bw compat layer is added as well.

Resolves: #86486
Releases: master
Change-Id: Ifdeaab26868d0cf60dd87d52046a2565c4971488
Reviewed-on: https://review.typo3.org/58499
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Remove hardcoded index.php indexed search links 87/58387/3
Frank Naegler [Tue, 25 Sep 2018 10:53:18 +0000 (12:53 +0200)]
[BUGFIX] Remove hardcoded index.php indexed search links

Resolves: #86326
Releases: master
Change-Id: Ifbe8c5067c5a7e47188ea89f4e6df3db9192ac61
Reviewed-on: https://review.typo3.org/58387
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[TASK] Reintroduce tooltips for new SVG Pagetree 81/58481/6
Nikita Hovratov [Sun, 30 Sep 2018 00:06:06 +0000 (02:06 +0200)]
[TASK] Reintroduce tooltips for new SVG Pagetree

When hovering over a page-icon in the pagetree, a tooltip with the
id and status is now shown instead of a browser default title tooltip.

Resolves: #86314
Releases: master
Change-Id: I7d39841fa5085ea5bedb138e1d3e0eb036a3f402
Reviewed-on: https://review.typo3.org/58481
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[TASK] Adapt FAL dumpFile to use PSR-7 response objects 85/55585/15
Benjamin Franzke [Wed, 2 Aug 2017 14:06:54 +0000 (16:06 +0200)]
[TASK] Adapt FAL dumpFile to use PSR-7 response objects

A new driver method streamFile() is added (specified
in a new, internal StreamableDriverInterface).
streamFile() returns a PSR-7 response which serves
the contents of the file.

Once this interface will be marked as public, third party drivers
will be allowed to return an own response (e.g. containing a redirect
to a CDN), providing full controls to headers. It also opens
possibilties for optimizations like X-SendFile (apache) or
X-Accell-Redirect (nginx) to be used by drivers.

We also add SelfEmittableStreamInterface (marked as internal) to support
the same fast file sending using readfile() – the interface provides
a hook which is called by the AbstractApplication in sendResponse.
That means that file contents do not need to be read into memory, stored
into a stream, and then read again, but can be piped to stdout by php
directly.

For all existing drivers backward compatibility is provided by
wrapping their dumpFileContents() method into a decorator stream which
calls dumpFileContents *when* the response is sent.
That means middlewares are able to prevent/stop/enhance
the response, but the driver method dumpFileContents is still used –
it's delayed until Application::sendResponse.

The dumpFileContents method of the ResourceStorage class
is now deprecated. ResourceStorage->streamFile() should be used instead.

Change-Id: I64e707c1f8350e409ff2505b98531b92b2936e02
Releases: master
Resolves: #83793
Reviewed-on: https://review.typo3.org/55585
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[BUGFIX] Do not trigger tooltip automatically after hide/unhide 79/58479/2
Nikita Hovratov [Sat, 29 Sep 2018 22:47:02 +0000 (00:47 +0200)]
[BUGFIX] Do not trigger tooltip automatically after hide/unhide

The tooltip is not shown now, when you move the cursor away, while the
spinning icon is active. The new label still updates, if you keep the
cursor the whole time on the button.

Resolves: #85319
Releases: master, 8.7
Change-Id: Id653a9f6d43c1ca1f6a24112edde18b50286843f
Reviewed-on: https://review.typo3.org/58479
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[TASK] Use PageRepository in indexed search menu generation 92/58492/2
Benni Mack [Sun, 30 Sep 2018 11:33:26 +0000 (13:33 +0200)]
[TASK] Use PageRepository in indexed search menu generation

Use your own instance of PageRepository instead of depending
on TSFE, and use the menu by using the global context
and restrictions by using PageRepository instead of custom
DB queries.

Resolves: #86472
Releases: master
Change-Id: Ia480caace4d7415a8b43abc36b7dda5e314c0712
Reviewed-on: https://review.typo3.org/58492
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[TASK] Streamline labels of site configuration 08/58508/2
Susanne Moog [Sun, 30 Sep 2018 19:18:54 +0000 (21:18 +0200)]
[TASK] Streamline labels of site configuration

Labels have been rewritten to consequently use
title case. Additionally, the layout of the
main site tab has been adjusted.

Resolves: #86485
Releases: master
Change-Id: I5186c3a4506d546dc61ef8e4e9e41491b123ace4
Reviewed-on: https://review.typo3.org/58508
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Migrate BackendWorkspaceRestriction to Context API 84/58484/5
Benni Mack [Sun, 30 Sep 2018 09:50:44 +0000 (11:50 +0200)]
[TASK] Migrate BackendWorkspaceRestriction to Context API

This patch also streamlines the Context API usage of
Workspaces in the main AbstractDataHandlerActionTestCase
class.

Resolves: #86465
Releases: master
Change-Id: I99e2a379e745494f9c23cca40ca4ad7ee1fc887f
Reviewed-on: https://review.typo3.org/58484
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Ensure deleted scheduler tasks are never run 39/58439/5
Benni Mack [Sun, 30 Sep 2018 16:03:24 +0000 (18:03 +0200)]
[BUGFIX] Ensure deleted scheduler tasks are never run

In #79777 a new "tx_scheduler_task.deleted" field was
added, but is not always considered when tasks are run.

Resolves: #86420
Related: #79777
Releases: master
Change-Id: Ide025bda13504bd56dc5f9cc090f5e7e54da6695
Reviewed-on: https://review.typo3.org/58439
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[TASK] Streamline Page Argument merge strategies 07/58507/2
Benni Mack [Sun, 30 Sep 2018 17:36:18 +0000 (19:36 +0200)]
[TASK] Streamline Page Argument merge strategies

PageArguments are fetched and added on top of PSR-7 request
queryParams right after they are validated from the PageRouter.

They are also re-populated after config.defaultGetVars has
modified global state.

But they do not need to be set to TSFE again within the
the PageArgumentValidator middleware.

Resolves: #86483
Releases: master
Change-Id: I03df4223832845038d4207417cfcab7cbcc687dc
Reviewed-on: https://review.typo3.org/58507
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Installer should use 50% of its space 06/58506/5
Benni Mack [Sun, 30 Sep 2018 16:52:33 +0000 (18:52 +0200)]
[BUGFIX] Installer should use 50% of its space

The Installer uses a full grid which is a lot of white space if not needed.

So, the whole layout is put into a col-md-6 grid with a col-md-offset-3
offset.

Resolves: #86482
Releases: master
Change-Id: If2e409deae98c0cf23eb7606a6cf35b950834874
Reviewed-on: https://review.typo3.org/58506
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[BUGFIX] Fix panel-collapse and modal-body padding-bottom in firefox 60/58460/2
Nikita Hovratov [Sat, 29 Sep 2018 15:55:29 +0000 (17:55 +0200)]
[BUGFIX] Fix panel-collapse and modal-body padding-bottom in firefox

* The last item in panel-collapse has now proper padding to its bottom.
* With a different behaviour of firefox a container having overflow-y
  ignores padding-bottom. A workaround is a pseudo-element reserving
  the same space as the padding attribute would have.

Resolves: #86445
Releases: master
Change-Id: I55b6318f1b59ceda65857726828deab5bc8a306f
Reviewed-on: https://review.typo3.org/58460
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[BUGFIX] Skip special doktype parent pages in slug generation 73/58473/4
Benni Mack [Sat, 29 Sep 2018 18:57:24 +0000 (20:57 +0200)]
[BUGFIX] Skip special doktype parent pages in slug generation

When checking the parent page for an existing slug, the parent page
should not be used if the parent page is a sys folder, spacer or
recycler (pages.doktype), but the traversal goes up.

This makes it a bit easier for editors to work with better-speaking
URLs and keep the rootline traversal as best practice.

Resolves: #86456
Releases: master
Change-Id: I2c46d096e41fb3a325fd42bf86b8968b79d6305b
Reviewed-on: https://review.typo3.org/58473
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Ensure workspace preview works with Site Handling 02/58502/3
Benni Mack [Sun, 30 Sep 2018 15:23:02 +0000 (17:23 +0200)]
[BUGFIX] Ensure workspace preview works with Site Handling

While introducing Page URL handling, the workspace functionality
still built the URL with `/index.php` although the Router should
take care of that now.

As drive-by fix, the BackendUtility preview URL hook now works again
due to some refactoring back in TYPO3 9.2.

Another drive-by fix allows to register the middleware at the
right place to render the workspace preview in general.

Resolves: #86480
Releases: master
Change-Id: Icfa5a5eee304c27db39cf25903b9a14452c81168
Reviewed-on: https://review.typo3.org/58502
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Avoid double slashes in slug generation 03/58503/2
Oliver Hader [Sun, 30 Sep 2018 15:34:58 +0000 (17:34 +0200)]
[BUGFIX] Avoid double slashes in slug generation

When generating slugs it might happen, that double slashes
are generated. This basically results from both prepending
and appending slashes at the same time.

Resolves: #86479
Releases: master
Change-Id: I441fee333cd0b3fbad3dde1a130eb08356bd4c2d
Reviewed-on: https://review.typo3.org/58503
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[TASK] Improve processing of mappable aspects 83/58483/3
Oliver Hader [Sun, 30 Sep 2018 08:40:21 +0000 (10:40 +0200)]
[TASK] Improve processing of mappable aspects

Improve processing by deferring those mappers that invoke persistence
the latest possible time. In case mappers do not match the processing
is stopped earlier to avoid superfluous checks and invocations.

Resolves: #86464
Releases: master
Change-Id: I4f9ec66611e84b49a54223f77aee824033a2fb7a
Reviewed-on: https://review.typo3.org/58483
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[TASK] Shorten the extend class in all unit tests 01/58501/2
Wouter Wolters [Sun, 30 Sep 2018 14:28:57 +0000 (16:28 +0200)]
[TASK] Shorten the extend class in all unit tests

Shorten \TYPO3\TestingFramework\Core\Unit\UnitTestCase to UnitTestCase

Resolves: #86478
Releases: master
Change-Id: I5dc7704fb2776cff26f1bbf89b35e28fecd9a79e
Reviewed-on: https://review.typo3.org/58501
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Display correct original state when invertStateDisplay is true 38/58238/4
Jigal van Hemert [Sun, 9 Sep 2018 11:01:24 +0000 (13:01 +0200)]
[BUGFIX] Display correct original state when invertStateDisplay is true

In the fieldWizard defaultLanguageDifferences the opposite value must be
displayed if invertStateDisplay is active in fields of type "check".

Resolves: #86205
Releases: master
Change-Id: Iac8fa73406b076b3d26a6ed3aed7e21b79220750
Reviewed-on: https://review.typo3.org/58238
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] Remove unreachable return statement 98/58498/2
Christian Kuhn [Sun, 30 Sep 2018 13:20:22 +0000 (15:20 +0200)]
[BUGFIX] Remove unreachable return statement

Resolves: #86476
Releases: master
Change-Id: I182bd77895744d13ba535b43e46b802def49cb45
Reviewed-on: https://review.typo3.org/58498
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Avoid count() in test conditions 96/58496/3
Christian Kuhn [Sun, 30 Sep 2018 13:15:30 +0000 (15:15 +0200)]
[TASK] Avoid count() in test conditions

Resolves: #86474
Releases: master
Change-Id: I2265e9167dc0604f8d2605121028c029fe3eebfc
Reviewed-on: https://review.typo3.org/58496
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Add rule to prevent the @access annotation entering the core 97/58497/4
Wouter Wolters [Sun, 30 Sep 2018 13:19:14 +0000 (15:19 +0200)]
[TASK] Add rule to prevent the @access annotation entering the core

Add the phpdoc_no_access rule to the php-cs-fixer configuration to
prevent the @access annotation from entering the core again.

Resolves: #86475
Related: #86446
Releases: master
Change-Id: I9db729ae1375434bea49f92468f7d490a554b4fb
Reviewed-on: https://review.typo3.org/58497
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Fix sprintf argument mismatch in FormManagerController 00/58500/2
Wouter Wolters [Sun, 30 Sep 2018 13:28:50 +0000 (15:28 +0200)]
[BUGFIX] Fix sprintf argument mismatch in FormManagerController

Resolves: #86477
Releases: master
Change-Id: I9595a1f1a4d90566d732dcf3c3f8b883a08a6bbe
Reviewed-on: https://review.typo3.org/58500
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] Make Extbase translation handling consistent with TypoScript 74/53974/116
Tymoteusz Motylewski [Mon, 16 Jul 2018 16:02:09 +0000 (18:02 +0200)]
[BUGFIX] Make Extbase translation handling consistent with TypoScript

Make Extbase fetch records in the same way as in TypoScript rendering,
making QuerySettings options mean the same as corresponding settings
from TypoScript.

This change allows e.g. to filter and sort by translated values
of the aggregate root.

To make upgrades easier a feature switch is introduced which
enables the new behavior. It can be disabled with TypoScript if
somebody relies on the old behavior.

The feature switch is enabled by default in v9 and will be gone in v10
so in version 10 the fixed way will be the only way to fetch records
in Extbase.

Releases: master
Resolves: #82363
Resolves: #84011
Change-Id: I58d0a24c1f73debc6b9251efea9c28c9cf09d6d0
Reviewed-on: https://review.typo3.org/53974
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
5 months ago[BUGFIX] Remove nested form-group class 68/58468/2
Georg Ringer [Sat, 29 Sep 2018 17:54:05 +0000 (19:54 +0200)]
[BUGFIX] Remove nested form-group class

Remove nested class "form-group" in backend user module form

Resolves: #86450
Releases: master
Change-Id: I15a46b772d55ee8c0ea6fe9de00ef5a3cf53f27e
Reviewed-on: https://review.typo3.org/58468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Mark various TypoScript parsing functionality as internal 77/58477/6
Benni Mack [Sat, 29 Sep 2018 22:02:54 +0000 (00:02 +0200)]
[TASK] Mark various TypoScript parsing functionality as internal

The TypoScript Parser has been around since PHP 4 and hasn't
been touched much since 12ys. In order to speed up TypoScript
processing in the future, it is important to first streamline
all usages and mark internal functionality as "protected" instead
of "public".

Some other parts for sys_template rendering has been
marked as internal as well.

Resolves: #86461
Releases: master
Change-Id: I4ab0852bc0fb386aa9016b8845f7f8f15a7c3166
Reviewed-on: https://review.typo3.org/58477
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
5 months ago[BUGFIX] Install typo3db_legacy v1.1.1 to use new API 95/58495/2
Benni Mack [Sun, 30 Sep 2018 12:13:48 +0000 (14:13 +0200)]
[BUGFIX] Install typo3db_legacy v1.1.1 to use new API

The extracted extension should use the new DB API.

Resolves: #86373
Releases: master
Change-Id: Ibcb58f3c795cc888285b61bc7f3e2251f15cd328
Reviewed-on: https://review.typo3.org/58495
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Do not depend on a database connection in CLI authentication 27/58427/5
Benjamin Franzke [Wed, 26 Sep 2018 20:54:22 +0000 (22:54 +0200)]
[BUGFIX] Do not depend on a database connection in CLI authentication

Neither the backend user authentication should try to perform
database queries, nor the extbase services.

As a side effect this allows to run the cli tool when
LocalConfiguration.php or PackageStates.php are missing,
which allows to run commands like `dumpautoload` in that case.
Note: *Only* in that case, not if a database connection
is configured, but not available – for that usecase failsafe
booting will be needed, as proposed in https://review.typo3.org/c/58298/
and/or https://review.typo3.org/c/58300/

As a drive-by we also add a null coalescing operator to
IconRegistry::registerModuleIcons() which is currently
required because ext_tables.php files are loaded in
incorrect order if PackageStates.php is missing (reported
in another bug: #86408). Although this workaround will
not be strictly required when that bug is fixed, that functions
should still properly handle that case.

Change-Id: I7d339e21160d25b5aee5dd0e2f25491a22ec83e9
Releases: master
Resolves: #86416
Related: #86408
Reviewed-on: https://review.typo3.org/58427
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Minor adjustments to wordings, variables and docs 93/58493/3
Benni Mack [Sun, 30 Sep 2018 11:57:50 +0000 (13:57 +0200)]
[BUGFIX] Minor adjustments to wordings, variables and docs

Resolves: #86473
Releases: master
Change-Id: I19f499533636b6a187adde51f2a4ca96149cc45f
Reviewed-on: https://review.typo3.org/58493
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Clean up FormEngine fields for Site Handling 89/58489/2
Benni Mack [Sun, 30 Sep 2018 11:14:34 +0000 (13:14 +0200)]
[TASK] Clean up FormEngine fields for Site Handling

The descriptions and listings of site language in FormEngine
hasn't been worked on since its introduction.

This is now streamlined in terms of wording and grouping,
to help people find things in a better way.

Resolves: #86470
Releases: master
Change-Id: I3692b8466c779b32d8a52d58469e5b87874643fa
Reviewed-on: https://review.typo3.org/58489
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Replace class property caching with runtime cache 53/51953/11
Claus Due [Sat, 4 Mar 2017 16:00:19 +0000 (17:00 +0100)]
[BUGFIX] Replace class property caching with runtime cache

PageRepository is now used independantly from TSFE
most of the time, and a new instance is created each time a
content element gets rendered. This means that the current
cache strategy using class properties gets flushed repeatedly
and multiple identical SQL requests to be sent to the DB.

By replacing the class property caching with runtime cache
which survives across instances, the problem is solved.

On some sites this represents a reduction of several hundred
SQL requests.

Change-Id: Ib606ada46c3c262fd9004a12166b79d80bbc5edb
Resolves: #80138
Releases: master
Reviewed-on: https://review.typo3.org/51953
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Respect mountpoint variable in cObj menu runtime cache 32/57532/5
Sascha Egerer [Wed, 11 Jul 2018 14:59:22 +0000 (16:59 +0200)]
[BUGFIX] Respect mountpoint variable in cObj menu runtime cache

The mountpoint variable must be respected in the key used for the
menu runtime cache. Without that part in the key all links generated
to a mount-point sub-page will link to the first mount target page
in the menu.

Resolves: #80970
Resolves: #62248
Releases: master, 8.7, 7.6
Change-Id: I8ccfebabd515d6da9f78388de51d24603e9fe532
Reviewed-on: https://review.typo3.org/57532
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Adjust broken extension scanner config 88/58488/2
Christian Kuhn [Sun, 30 Sep 2018 11:01:23 +0000 (13:01 +0200)]
[BUGFIX] Adjust broken extension scanner config

Resolves: #86469
Related: #86441
Releases: master
Change-Id: Iff35a1be7c436ff3aceab7b9eb82af773278b363
Reviewed-on: https://review.typo3.org/58488
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Tag .rst file 86440 with PHP-API 87/58487/2
Christian Kuhn [Sun, 30 Sep 2018 10:55:07 +0000 (12:55 +0200)]
[TASK] Tag .rst file 86440 with PHP-API

Resolves: #86468
Related: #86440
Releases: master
Change-Id: I1e0cf65d487b8ea95edb7acdad50c671da3277a5
Reviewed-on: https://review.typo3.org/58487
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Mark .rst file 86439 FullyScanned 86/58486/2
Christian Kuhn [Sun, 30 Sep 2018 10:52:59 +0000 (12:52 +0200)]
[TASK] Mark .rst file 86439 FullyScanned

Resolves: #86467
Related: #86439
Releases: master
Change-Id: If14e53972535458ec493454d8e42c48eb67dc35c
Reviewed-on: https://review.typo3.org/58486
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Deprecate AbstractUserAuthentication->fetchUserRecord 85/58485/3
Christian Kuhn [Sun, 30 Sep 2018 10:34:52 +0000 (12:34 +0200)]
[TASK] Deprecate AbstractUserAuthentication->fetchUserRecord

To untie authentication services from user authentication a bit better,
the fetchUserRecord() method of AbstractAuthenticationService now
implements fetchUserRecord() on its own instead of calling the method
with the same name of $pObj.
AbstractUserAuthentication->fetchUserRecord() is then unused and can
be deprecated.

Resolves: #86466
Releases: master
Change-Id: Ia144ea2dfb8a7c7462ed12875ee35caab9763ba2
Reviewed-on: https://review.typo3.org/58485
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] synchronize flags in registry with TCA 76/58476/2
Jigal van Hemert [Sat, 29 Sep 2018 20:54:16 +0000 (22:54 +0200)]
[BUGFIX] synchronize flags in registry with TCA

Flag icons that come with core, the flags that are registered in the icon
registry, the lists in sys_language and site_language are now in sync again.

Releases: master
Resolves: #86460
Change-Id: I1e274b3e274b305486b6e37d600a915177ef484c
Reviewed-on: https://review.typo3.org/58476
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[TASK] Remove leftover .htaccess files in Resources/Private folders 82/58482/2
Josef Glatz [Sun, 30 Sep 2018 06:26:55 +0000 (08:26 +0200)]
[TASK] Remove leftover .htaccess files in Resources/Private folders

Leftover .htaccess files were savedly removed, as the root
.htaccess (for Apache webserver) / .web.config (for IIS webserver)
already takes care of access rules.

Resolves: #86463
Releases: master
Change-Id: I1186a5cdd068c2052d3d6ab2a4210d931d8684cd
Reviewed-on: https://review.typo3.org/58482
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] EvaluteDisplayCondition should throw proper error message 80/58480/3
Benni Mack [Sat, 29 Sep 2018 23:42:41 +0000 (01:42 +0200)]
[BUGFIX] EvaluteDisplayCondition should throw proper error message

When an extension author writes a display condition in TCA and
by incident uses a wrong format for the displayCondition (see ticket)
the strtoupper fails due to the lack of an associative array
because it's a numeric-key array.

An additional check fixes the issue.

Resolves: #79692
Releases: master, 8.7
Change-Id: I4455bdc908e0be1a373f86680e718e876aa5ddd7
Reviewed-on: https://review.typo3.org/58480
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[TASK] Remove comments mentioning "branch versioning" 61/57261/3
Tymoteusz Motylewski [Mon, 18 Jun 2018 16:11:38 +0000 (18:11 +0200)]
[TASK] Remove comments mentioning "branch versioning"

Resolves: #85305
Releases: master
Change-Id: I01c62adede04f5f74c506c15e28d471ad3185593
Reviewed-on: https://review.typo3.org/57261
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[FEATURE] Make prepending slash in TCA slug configurable 74/58474/3
Benni Mack [Sat, 29 Sep 2018 19:05:45 +0000 (21:05 +0200)]
[FEATURE] Make prepending slash in TCA slug configurable

A new TCA option for TCA type "slug" is added, called "prependSlash",
which adds a "/" in front of the field. For pages (pages.slug),
this is mandatory and cannot be configured, as the slug field
has to be filled and set to "/" as a base for the root page.

For other database fields, this is optional (and disabled by default),
and can be enabled via "prependSlash" in TCA config.

This option is mostly useful for recursive records, like categories,
but for most "flat" structures like "news" or "events", this is not
suitable. For pages, it is hard-coded and cannot be (un-)set.

Resolves: #86457
Releases: master
Change-Id: I997908ed74af7ca21873b0793674e9185cc581ce
Reviewed-on: https://review.typo3.org/58474
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
5 months ago[TASK] Add functional test for route enhanced link handling 61/58461/7
Oliver Hader [Sat, 29 Sep 2018 15:44:42 +0000 (17:44 +0200)]
[TASK] Add functional test for route enhanced link handling

* adds test cases for resolving and generating enhanced links
* fixes locale issues when dealing with persisted mappers
* removes PersistedAliasMapper.valueFieldName and uses TCA
  'uid' field per default, which is required for proper
  language based resolving as well
* introduces language based resolving to PersistedAliasMapper
  and PersistedPatternMapper

Resolves: #86444
Releases: master
Change-Id: Ib9c9ea8efc25a8a5adb727f8402a2b6b1e6a1602
Reviewed-on: https://review.typo3.org/58461
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[TASK] Remove @internal on new UpgradeWizard interfaces 66/58466/2
Susanne Moog [Sat, 29 Sep 2018 17:28:52 +0000 (19:28 +0200)]
[TASK] Remove @internal on new UpgradeWizard interfaces

To allow others to use the new upgrade wizard API the
interfaces are no longer marked as @internal.

Resolves: #86448
Releases: master
Change-Id: I2e146e6d27c5aaed922a004054b3df2bbea88cb8
Reviewed-on: https://review.typo3.org/58466
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[TASK] Merge PSR-7 request and _GET/_POST parameters 43/58443/4
Benni Mack [Fri, 28 Sep 2018 20:24:53 +0000 (22:24 +0200)]
[TASK] Merge PSR-7 request and _GET/_POST parameters

When hooks modify _GET or _POST parameters,
it is important that these changes reflect the PSR-7 request
for now, as long as TYPO3 access the _GET/_POST parameters
via GeneralUtility::_GP().

In order to move away from global access, we still want to avoid
places where it is unclear to use $_GET/$_POST vs.
$GLOBALS['TYPO3_REQUEST'] until all parts are completely
"global-scope free" for GET/POST parameters.

The change adds the initial GET/POST parameters to the
request object in the very first middleware of the frontend.

If these have been modified when the RequestHandler builds
up the content, they are added on top of the PSR-7 request object.

Additionally, if the PSR-7 request object has been modified,
these changes are put back in the global scope to reliably use
_GPmerged within Extbase and

Additionally, if _GET/_POST have been modified, a warning will
be shown in the TimeTracker to find out that there have been
modifications.

Until then, it is safe to continue to access _GET/_POST within
Hooks and Frontend, however it is highly discouraged to *modify*
_GET/_POST directly as this functionality will be breaking in TYPO3 v10.0.

Bottom line: This safety net can now trigger deprecation warnings
if _GET/_POST have been modified during PSR-15 middleware hooks.

Bottom line 2: If these have been modified, they are put inside the
current request object.

Bottom line 3: If the request object has been modified, global state
will be modified ONCE in one place to ensure that we work with
the same object during the request phase.

Bottom line 4: We cannot get away from the current state of
running a TYPO3 Frontend Request from another source, and
we try to maintain compatibilty for legacy scripts for now. However,
this will be breaking in TYPO3 v10.0.

Resolves: #86458
Releases: master
Change-Id: Ic8f4f123bb5ea0d660e500494cf06a965dea03c4
Reviewed-on: https://review.typo3.org/58443
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[TASK] Mark several parts within RteHtmlParser as internal 57/58457/4
Benni Mack [Sat, 29 Sep 2018 14:23:06 +0000 (16:23 +0200)]
[TASK] Mark several parts within RteHtmlParser as internal

RteHtmlParser has never received a good clean up, that's
because it was there since PHP 4 ages.

In order to rename, reorder code, all internal methods
and properties are now declared as protected.

Resolves: #86440
Releases: master
Change-Id: I204efa8156abcf9ae07a607fa03fa04fbb269885
Reviewed-on: https://review.typo3.org/58457
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[TASK] CKEditor RTE: Re-add the wordcount functionality 05/58405/6
Josef Glatz [Wed, 26 Sep 2018 17:36:17 +0000 (19:36 +0200)]
[TASK] CKEditor RTE: Re-add the wordcount functionality

This patch re-adds a missing functionality to CKEditor.

Due to the move from htmlArea to CKEditor, the well-known
wordcount information was gone.

The wordcount information is added to all existing CKEditor presets
per default. In addition, it is now possible to customize the displayed
information below the editor.

- It's possible to switch paragraph-, word- and/or character count.
- You can define if spaces are counted as charactars.
- You can define if HTML tags are taken into account.
- You can define if linebreaks are taken into account.

Beside that, the used plugin enables also setting up maximum
values for word- and/or character count. This can be easily used
for custom RTE presets. The fact that the global configuration is
located in the Base.yaml makes it possible to overwrite settings
partially or completely in any inherited RTE preset. With that it is
easy possible to realize word/character limits.

Following commands were used to add the external package as
a dependency and copy the plugin files/folders to the final location:
`yarn add --dev ckeditor-wordcount-plugin && yarn build`

Resolves: #86395
Releases: master
Change-Id: I2c76d7bfebc9a5a57c1f105788af206bdffb00f2
Reviewed-on: https://review.typo3.org/58405
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Use NormalizedParams with simplified arguments 71/58471/4
Benni Mack [Sat, 29 Sep 2018 18:32:46 +0000 (20:32 +0200)]
[TASK] Use NormalizedParams with simplified arguments

Normalized Params only needs serverParams and
$TYPO3_CONF_VARS[SYS] to work with, so the object is modified
in order to simplify further work on the object.

Resolves: #86454
Releases: master
Change-Id: I30f2c6195468b275e61570c1de67b39f281bb494
Reviewed-on: https://review.typo3.org/58471
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[BUGFIX] Remove tooltip over delete button when it's clicked 63/58463/3
Nikita Hovratov [Sat, 29 Sep 2018 17:11:46 +0000 (19:11 +0200)]
[BUGFIX] Remove tooltip over delete button when it's clicked

The tooltip has to be removed at that point, because as soon as any data
is deleted the row disappears and it's not possible to trigger the
mouseout event manually.

Resolves: #81856
Releases: master, 8.7
Change-Id: I2f7388b6a278de9ba19e81ec20ed3ae0052b1698
Reviewed-on: https://review.typo3.org/58463
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
5 months ago[TASK] Sort extensions in Install Tool module by name 70/58470/2
Georg Ringer [Sat, 29 Sep 2018 18:27:55 +0000 (20:27 +0200)]
[TASK] Sort extensions in Install Tool module by name

Sort the extension settings by the extension key.

Resolves: #86452
Releases: master
Change-Id: I6fb0110820d4a8406f01b617b3279640be9aa743
Reviewed-on: https://review.typo3.org/58470
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[TASK] Deprecate PageRenderer->loadJQuery() 55/58455/11
Benni Mack [Sat, 29 Sep 2018 13:11:00 +0000 (15:11 +0200)]
[TASK] Deprecate PageRenderer->loadJQuery()

Instead of explicitly call loadJQuery() this should be handled
by requireJS or - even better - use vanilla JavaScript instead.

Resolves: #86438
Releases: master
Change-Id: Iecc2ceb7fa01578b00a63262f393bd1b92fa13e1
Reviewed-on: https://review.typo3.org/58455
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
5 months ago[TASK] Mark several methods within TemplateService as internal 56/58456/8
Benni Mack [Sat, 29 Sep 2018 14:06:31 +0000 (16:06 +0200)]
[TASK] Mark several methods within TemplateService as internal

The following methods will trigger a deprecation warning if
they are called from the outside:

- TemplateService->prependStaticExtra()
- TemplateService->versionOL()
- TemplateService->processIncludes()
- TemplateService->mergeConstantsFromPageTSconfig()
- TemplateService->flattenSetup()
- TemplateService->substituteConstants()

Several other methods have been marked as internal.

Resolves: #86439
Releases: master
Change-Id: Ifabbda8048449e6919d054da4111f01065a5eeab
Reviewed-on: https://review.typo3.org/58456
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Use PSR-15 RequestHandler in Install Tool 69/58469/3
Benni Mack [Sat, 29 Sep 2018 18:13:30 +0000 (20:13 +0200)]
[TASK] Use PSR-15 RequestHandler in Install Tool

Install Tool still uses TYPO3's own RequestHandler interface which
exists since TYPO3 v7, but is superseded with PSR-15's
RequestHandler concept.

Install Tool now uses PSR-15 and the old interface in order
to still use the priority concept.

In a further step, both RequestHandlers should be migrated to
Middleware+RequestHandler concept.

Resolves: #86451
Releases: master
Change-Id: I55cf31a2b803951491ba072969a4cff68ef2c2ac
Reviewed-on: https://review.typo3.org/58469
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[TASK] phpDoc: replace @access private with @internal 62/58462/4
Benni Mack [Sat, 29 Sep 2018 17:12:19 +0000 (19:12 +0200)]
[TASK] phpDoc: replace @access private with @internal

The phpDoc comment "@internal" is used in most places
during the development of TYPO3 v7, TYPO3 v8 and TYPO3 v9
and denotes that this specific method, class or property is not
part of the Public API, and does not even need any notice if it
is removed.

However, we still have/had various places in TYPO3 core
where "@access private" was used. This is now migrated to
"@internal". "@access public" is not needed and is removed.

Resolves: #86446
Releases: master
Change-Id: Iaef206b04aee13c280d62b107dd7eac04a38c700
Reviewed-on: https://review.typo3.org/58462
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[TASK] Fix spelling of 'analyze' 54/58454/3
Susanne Moog [Sat, 29 Sep 2018 12:32:35 +0000 (14:32 +0200)]
[TASK] Fix spelling of 'analyze'

As the core uses American English, 'analyze' should be
spelled with a `z`. This looked especially strange in the
install tool, where both spellings were mixed on one card.

Resolves: #86447
Releases: master
Change-Id: I484f75a05d3cf988baaebf91df30cd936f454eac
Reviewed-on: https://review.typo3.org/58454
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[TASK] Deprecate various methods inside BE_USER 58/58458/4
Benni Mack [Sat, 29 Sep 2018 14:26:08 +0000 (16:26 +0200)]
[TASK] Deprecate various methods inside BE_USER

The property "checkWorkspaceCurrent_cache" is now protected.

Second method argument of "modAccess()" is deprecated.

"isPSet()" is not in use anymore, and will be removed in TYPO3 v10.0.

Some other methods, which are workspace-related, are marked
as internal in order to properly move them into EXT:workspaces
in the next version.

Resolves: #86441
Releases: master
Change-Id: Ie776e71cdc7485937b2a38e7cfc93c13aba925ab
Reviewed-on: https://review.typo3.org/58458
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[TASK] Mark various functionality as internal within TSFE 59/58459/2
Benni Mack [Sat, 29 Sep 2018 14:39:46 +0000 (16:39 +0200)]
[TASK] Mark various functionality as internal within TSFE

Use @internal where access private was marked, also add
some meaning to currently public methods that should only
be used by TYPO3 Core.

Resolves: #86442
Releases: master
Change-Id: If90f1a6dc6cad1edb0db2179cb87f5e6eb18f2ec
Reviewed-on: https://review.typo3.org/58459
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
5 months ago[FEATURE] Introduce RouteEnhancers for Page-based Routing 84/58384/72
Benni Mack [Wed, 26 Sep 2018 22:46:43 +0000 (00:46 +0200)]
[FEATURE] Introduce RouteEnhancers for Page-based Routing

Page-based routing can now be configured within a site
configuration to add so-called "route enhancers" which
allow to add more placeholders to a route for a page.

There are three Enhancers that TYPO3 now ships with:
- SimpleEnhancer
- PluginEnhancer
- ExtbasePluginEnhancer

It is also possible to add custom enhancers by third-
party extensions.

Each placeholder within an enhancer can receive a
so-called "Aspect", usually used for mapping speaking
values instead of IDs, or month-names in an archive
link, and "modifiers" to modify a placeholder.

The simple enhancer transfers a link parameter,
previously maybe used to add a `&product=123`,
which will now result into `/product/123` for a
page. PluginEnhancer adds a namespace, common
for simple plugins or Pi-Based plugins, and
the ExtbasePluginEnhancer adds logic for multiple
route variants to be added, depending on the
controller/action combinations.

Aspects are processors / modifiers / mappers to
transfer a placeholder value back & forth to
make each placeholder value more "speaking".

TYPO3 Core ships with the following aspects:
* LocaleModifier (for localized path segments)
* StaticValueMapper (for path segments with a static list)
* StaticRangeMapper (for pagination)
* PersistedAliasMapper (for slug fields)
* PersistedPatternMapper (for database records without slug fields)

Routing now returns a so-called "PageArguments" object
which is then used for evaluating site-based URL
handling and the cHash calculation.

It is highly discouraged to access _GET or _POST
variables within any kind of code now, instead
the PSR-7 request object should be used as much
as possible.

Releases: master
Resolves: #86365
Change-Id: I77e001a5790f1ab3bce75695ef0e1615411e2bd9
Reviewed-on: https://review.typo3.org/58384
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[TASK] Create .htaccess or web.config file upon installation 51/58451/3
Christian Kuhn [Sat, 29 Sep 2018 10:25:22 +0000 (12:25 +0200)]
[TASK] Create .htaccess or web.config file upon installation

With the new routing, TYPO3 relies on a default redirect to index.php
for FE requests. The patch checks during installation if apache or IIS
are used and creates the default .htaccess / web.config files.

Change-Id: I9406a7e4d91050d3f5bf96dd63e4bf63e8f71250
Resolves: #86173
Releases: master
Reviewed-on: https://review.typo3.org/58451
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[TASK] Move documentation files into 9.5 folder 48/58448/3
Anja [Sat, 29 Sep 2018 08:50:32 +0000 (10:50 +0200)]
[TASK] Move documentation files into 9.5 folder

Change-Id: I6fccf8db0ab996139692a07be8d08ceb8feee86f
Releases: master
Resolves: #86434
Reviewed-on: https://review.typo3.org/58448
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
5 months ago[BUGFIX] Sql query export to use search_result_labels setting 06/58406/3
lsascha [Wed, 26 Sep 2018 22:43:34 +0000 (00:43 +0200)]
[BUGFIX] Sql query export to use search_result_labels setting

Releases: master, 8.7
Resolves: #86396
Change-Id: I198fe52a8024dcf392582a78c3fce0f134ed6b7a
Reviewed-on: https://review.typo3.org/58406
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[TASK] Add informational upgrade wizard for argon2i 11/58411/7
Christian Kuhn [Thu, 27 Sep 2018 13:35:39 +0000 (15:35 +0200)]
[TASK] Add informational upgrade wizard for argon2i

This adds a dummy wizard to remind admins during upgrade
to check the live system for argon2i support if the local
instance uses it, or to select a different hash algorithm.
Having this wizard gives this information to admins early
in the upgrade phase, so they have time to check the live
system or to select a different mechanism before too many
passwords have been upgraded.

Resolves: #86402
Releases: master
Change-Id: I2b1f75ecf079dc2e29d2675dda558c79b67f77e0
Reviewed-on: https://review.typo3.org/58411
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Resolve correct processed folder when on different storage 10/58410/3
Helmut Hummel [Thu, 27 Sep 2018 09:34:23 +0000 (11:34 +0200)]
[BUGFIX] Resolve correct processed folder when on different storage

During generation of processed files a wrong processed folder
is evaluated when the processed folder resides on a different storage.

We now ensure to ask the correct storage for the processed folder.

Also ensure that correct storage is used for checking file existence
when original file and processed files are on different storages.

Fixes: #86399
Releases: master, 8.7
Change-Id: I254b9a0bf86a156ae135510a4439e87737ec1a29
Reviewed-on: https://review.typo3.org/58410
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
5 months ago[TASK] Replace further usages with Environment API 00/57600/6
Benni Mack [Fri, 13 Jul 2018 21:45:47 +0000 (23:45 +0200)]
[TASK] Replace further usages with Environment API

Most of the occurrences have been replaced by using
Environment API.

On top, labels are now moved into "var/labels"
for existing composer-based installations, moving
XLF files out of the document root when the environment
is configured to allow files outside of the document
root.

For non-composer-based installations, labels are still
available under "typo3conf/l10n".

Resolves: #85560
Releases: master
Change-Id: Ib0a9e8e3dcd685109b9d922aee1970e68b265179
Reviewed-on: https://review.typo3.org/57600
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[BUGFIX] Allow to edit legacy site configuration files in BE 49/58449/2
Benni Mack [Sat, 29 Sep 2018 10:07:45 +0000 (12:07 +0200)]
[BUGFIX] Allow to edit legacy site configuration files in BE

We recently removed the "site" base prefix within the yaml
configuration file of a site configuration.

However, the indention is wrong when using FormEngine
to edit the site configuration within the "old" syntax.

Resolves: #86437
Related: #86323
Releases: master
Change-Id: I487940188b04c4977d179337cb142f2452c3bace
Reviewed-on: https://review.typo3.org/58449
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
5 months ago[TASK] Update composer dependencies 47/58447/3
Benni Mack [Fri, 28 Sep 2018 21:53:50 +0000 (23:53 +0200)]
[TASK] Update composer dependencies

We want the latest dependencies in our LTS version,
so this should ship the latest versions in the
zip/tarballs.

Used command:
    composer update symfony/* \
        doctrine/* \
        friendsofphp/* \
        nikic/php-parser \
        --with-dependencies

Resolves: #86432
Releases: master
Change-Id: I46b7ea46033d4f2c4d0148de537728d2b9ff22c2
Reviewed-on: https://review.typo3.org/58447
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[TASK] Set FE/loginSecurityLevel to normal for no ext:rsaauth loaded 29/58429/12
Anja [Fri, 28 Sep 2018 10:44:30 +0000 (12:44 +0200)]
[TASK] Set FE/loginSecurityLevel to normal for no ext:rsaauth loaded

Provide a silent upgrader the same way as for BE/loginSecurityLevel
to avoid FE login to fail after upgrade.

Change-Id: I8c27c370206effc1f88fd5334b9f20f01a628757
Resolves: #86417
Releases: master
Reviewed-on: https://review.typo3.org/58429
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
5 months ago[TASK] Deprecate several stdWrap / cObj functions 18/58418/5
Benni Mack [Thu, 27 Sep 2018 19:24:28 +0000 (21:24 +0200)]
[TASK] Deprecate several stdWrap / cObj functions

The following legacy TypoScript options have been deprecated
- stdWrap.filelist
- stdWrap.filelink
- stdWrap.addParams

The acompanied methods are deprecated as well
- cObj->stdWrap_addParams
- cObj->stdWrap_filelink
- cObj->stdWrap_filelist
- cObj->addParams
- cObj->filelink
- cObj->filelist
- cObj->typolinkWrap
- cObj->currentPageUrl

These are not in use anymore, due to removal of CSS Styled Content.

Resolves: #86433
Releases: master
Change-Id: Ie90dce49c050092c1a359491301ad3f3dd04ee4f
Reviewed-on: https://review.typo3.org/58418
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
5 months ago[TASK] Rename PageParameterValidator middleware 46/58446/2
Benni Mack [Fri, 28 Sep 2018 21:42:46 +0000 (23:42 +0200)]
[TASK] Rename PageParameterValidator middleware

In order to be in line with the new PageArguments object,
this newly introduced class is now renamed.

Resolves: #86431
Releases: master
Change-Id: I96575338538641fc27a578c49868b21100b61ed3
Reviewed-on: https://review.typo3.org/58446
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
5 months ago[BUGFIX] Use correct icon for editing query in ActionTask 36/58436/2
Tymoteusz Motylewski [Fri, 28 Sep 2018 13:03:15 +0000 (15:03 +0200)]
[BUGFIX] Use correct icon for editing query in ActionTask

Resolves: #86423
Releases: master, 8.7
Change-Id: I5c1e0f92fe5f9d28eaaf0250677cd3dedcbd6082
Reviewed-on: https://review.typo3.org/58436
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Set missing `data-title` attribute for upgrade wizard 42/58442/2
Andreas Fernandez [Fri, 28 Sep 2018 19:38:10 +0000 (21:38 +0200)]
[BUGFIX] Set missing `data-title` attribute for upgrade wizard

To render the „Executing foo“ text in the progress bar when a upgrade
wizard is executed correctly, a missing `data-title` attribute is added.

Resolves: #86430
Releases: master
Change-Id: I53f6f1a551de132452695a400561e46e9c1e4fb4
Reviewed-on: https://review.typo3.org/58442
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[TASK] Improve styling of infobox in ImageManipulationElement 41/58441/8
Georg Ringer [Fri, 28 Sep 2018 19:35:11 +0000 (21:35 +0200)]
[TASK] Improve styling of infobox in ImageManipulationElement

The cropping element shows an information if no dimensions are known.
The styling of this information is now improved.

Resolves: #86429
Releases: master, 8.7
Change-Id: I28b6e4da560e591a57e6c849488f59ddf5cd5736
Reviewed-on: https://review.typo3.org/58441
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Transform language parameter when previewing translated pages 38/58438/3
Oliver Hader [Fri, 28 Sep 2018 16:35:40 +0000 (18:35 +0200)]
[BUGFIX] Transform language parameter when previewing translated pages

When previewing translated pages in the backend, URLs contain `&L=x` at
the end. This is due to a missing transformation into the `_language`
parameter as well a missing SiteLanguage resolving.

Resolves: #86421
Releases: master
Change-Id: I5da496d0224635b1ee849dd7a724145ad2c0d408
Reviewed-on: https://review.typo3.org/58438
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Get extensionKey from package 37/58437/2
Frank Naegler [Fri, 28 Sep 2018 15:29:51 +0000 (17:29 +0200)]
[BUGFIX] Get extensionKey from package

Resolves: #86427
Related:  #86404
Releases: master
Change-Id: Iec990bd910ac62805d4584c468b265f57c0fd17d
Reviewed-on: https://review.typo3.org/58437
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[FEATURE] Allow site in TypoScript getText 34/58434/3
Susanne Moog [Fri, 28 Sep 2018 12:31:34 +0000 (14:31 +0200)]
[FEATURE] Allow site in TypoScript getText

A new key "site" for TypoScript "getText" has been introduced
which allows accessing site configuration.

Resolves: #86422
Releases: master
Change-Id: Id0efae08445b8890021fb2b68a88c4ac8db5a6fa
Reviewed-on: https://review.typo3.org/58434
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Register FileBrowser for file_reference mode 31/58431/2
Christian Kuhn [Fri, 28 Sep 2018 11:42:35 +0000 (13:42 +0200)]
[BUGFIX] Register FileBrowser for file_reference mode

Using the element browser for a type=group, internal_type=file_reference
TCA field leads to an exception due to a missing registration for
this mode. Register the file browser, similar to internal_type=file.

Resolves: #80541
Releases: master, 8.7
Change-Id: I54be7084f10d63ed262e903c296294589521f3df
Reviewed-on: https://review.typo3.org/58431
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Change visibility of two properties to public 30/58430/2
Christian Kuhn [Fri, 28 Sep 2018 11:10:26 +0000 (13:10 +0200)]
[BUGFIX] Change visibility of two properties to public

Properties $MOD_SETTINGS and $modTSconfig of RecordListController
are still used by DatabaseRecordList through $GLOBALS['SOBE'].
These two have to stay public for the time being to not trigger
a bunch of deprecation log entries on each call of the list module.

Change-Id: I87188b2065f4933e45203de58027f92db98bf840
Resolves: #86418
Related: #86198
Releases: master
Reviewed-on: https://review.typo3.org/58430
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
5 months ago[BUGFIX] Respect "disablePrependAtCopy" during translation 24/58424/3
Gianluigi Martino [Fri, 28 Sep 2018 06:40:01 +0000 (08:40 +0200)]
[BUGFIX] Respect "disablePrependAtCopy" during translation

During the translation process the option "disablePrependAtCopy" is not
respected. With this patch the option is respected again for pages and
tt_content.

Resolves: #86293
Releases: master, 8.7
Change-Id: I821f3fed7d3e0637298262c4bd2c11003618f1c5
Reviewed-on: https://review.typo3.org/58424
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] VimeoRenderer render private links 04/58404/4
Guido Schmechel [Wed, 26 Sep 2018 18:24:31 +0000 (20:24 +0200)]
[BUGFIX] VimeoRenderer render private links

Now it is also possible to add private Vimeo links.

Releases: master, 8.7
Resolves: #83852
Change-Id: Icb425d4aea98a687b91216fefcd69b5fecc1a01e
Reviewed-on: https://review.typo3.org/58404
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
5 months ago[BUGFIX] Only display pages in default language after creating new pages 93/58393/2
Jigal van Hemert [Tue, 25 Sep 2018 19:22:40 +0000 (21:22 +0200)]
[BUGFIX] Only display pages in default language after creating new pages

The Create Multiple Pages action now only displays the new structure in the
default language and hides pages in other languages that are already in the
pagetree.

Resolves: #86378
Releases: master
Change-Id: I14e45436d62300465d93ee87408523372007e394
Reviewed-on: https://review.typo3.org/58393
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] FailsafePackageManager: do not prevent package sorting 16/58416/2
Benjamin Franzke [Thu, 27 Sep 2018 18:10:27 +0000 (20:10 +0200)]
[BUGFIX] FailsafePackageManager: do not prevent package sorting

FailsafePackageManager prevents saving PackageStates.php in
failsafe mode by overwriting sortAndSavePackageStates(). That works
to prevent saving, but also prevents sorting when initially loading
packages when PackageStates.php is missing.

Currently this does not really produce problems, as the install
tool creates a new PackageStates.php later on and saves (and
implicitly sorts them) using forceSortAndPackageStates().

To fix the intermediate state we now only prevent saving,
but not the sorting of packages.

Releases: master
Resolves: #86408
Change-Id: I02ccb20653700e696d89b0a6ff39253f4f1ebc73
Reviewed-on: https://review.typo3.org/58416
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[TASK] Do not create caches during ext_localconf.php phase 71/58371/7
Benjamin Franzke [Fri, 7 Sep 2018 09:26:43 +0000 (11:26 +0200)]
[TASK] Do not create caches during ext_localconf.php phase

CacheManager has a design problem:
The CacheManager is used to create the core_cache. That core_cache
is used to read the (possibly) cached CacheManager configuration,
which is then used to configure the already-being-used CacheManager.

That means the initialization sequence currently is like:

new CacheManager(!$failsafe) | setInitialCacheConfiguration() |
    loadExtLocalconf() | setFinalCachingFrameworkConfiguration()

Between initial creation of the CacheManager and
setFinalCachingFrameworkConfiguration() the CacheManager is in a limbo
state, as it may already be used to create a cache although the final
configuration (which may be configured in ext_localconf.php) for that
cache has not been set. The final configuration (for that created cache)
will then be ignored, as the cache has already been created.

This is not a theoretical problem, but is actually happening in core
for two caches (introduced due to patches in the v9 development
phase, more on those later).

In v10 we want to change the sequence to the following:

$coreCache = createCoreCache() | loadExtLocalconf |
    new CacheManager(!$failsafe, $cachingConfiguration, $coreCache);

We want to delay CacheManager until ext_localconf.php has been loaded
(maybe also after baseTca loading) in v10.
Therefore GeneralUtility::makeInstance(CacheManager::class) usage in
ext_localconf.php is deprecated now.

Note: The core cache cannot be modified in ext_localconf.php - that was
always the case and wouldn't make sense (as that cache is used to actually
load the cached ext_localconf.php)

Two caches are actually loaded too early during ext_localconf.php loading
currently. We fix these as a drive-by:
 * extbase_reflection: the extbase Object\Container is instanciated in
   EXT:extbase/ext_localconf.php. The Object\Container then instanciates
   the ReflectionService in its constructor which itself creates the
   extbase_reflection using the CacheManager (all of that during
   ext_localconf.php loading).
   This is actually a regression introduced in
   https://review.typo3.org/54381
   We change the Container to load the reflection cache on demand.
 * assets:
   * IconRegistry uses the 'assets' cache and loads cached backend
     icons during object construction.
     This cache was introduced in https://review.typo3.org/c/54020/
     using  the core cache, and was later changed to 'assets' in
     https://review.typo3.org/54061
   * PageRenderer loads cached requireJS configuration from 'assets'

   We inject assetsCache to these services from Bootstrap for now. We'll
   only be able to properly refactor this, when dropping support for
   ext_localconf.php altogether.

We also adapt the ExtensionManagementUtility to retrieve the coreCache
as parameter, instead of statically. Although these methods are marked
@internal, we keep them for 9LTS to not break extensions (using this
regardless of being @internal, e.g. helhum/typo3-console) shortly before
the release.

Change-Id: I22935dae3acb6e8de14fa98a6b88f3477a3ea313
Releases: master
Resolves: #86353
Resolves: #86371
Resolves: #86372
Reviewed-on: https://review.typo3.org/58371
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[TASK] Deprecate TSFE->makeCacheHash() 20/58420/5
Benni Mack [Thu, 27 Sep 2018 22:46:52 +0000 (00:46 +0200)]
[TASK] Deprecate TSFE->makeCacheHash()

The functionality is moved into a new PSR-15 middleware
to base the logic on the request object directly, and
to make the validation more flexible when validating
page parameters for site-based routing.

The previous deprecation to add the request object
to the method has been reverted.

Resolves: #86411
Releases: master
Change-Id: I294fae7e7c0f9eb1e128a88238dabdd8ed27619f
Reviewed-on: https://review.typo3.org/58420
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] pages.shortcut suggest wizard should not suggest itself 23/58423/2
Josef Glatz [Fri, 28 Sep 2018 04:30:53 +0000 (06:30 +0200)]
[BUGFIX] pages.shortcut suggest wizard should not suggest itself

Make it impossible to select the page you are currently
working on within the suggest wizard result set.

Releases: master, 8.7
Resolves: #86412
Related: #54867
Change-Id: Ibeaacf86061f79cc3d75f181466e5caf96657401
Reviewed-on: https://review.typo3.org/58423
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
5 months ago[FEATURE] Allow environment variables in site config 58/58358/13
Susanne Moog [Thu, 20 Sep 2018 19:19:59 +0000 (21:19 +0200)]
[FEATURE] Allow environment variables in site config

To enable easy configuration of environment specific
site setting, usage of environment variables in site
configuration yaml has been introduced.

The TYPO3 Core Yaml loader is now able to resolve
variables from environment variables.

Resolves: #86409
Releases: master
Change-Id: Ic1e32d231aa7e92b3feb4ed4c31bed72520d71fb
Reviewed-on: https://review.typo3.org/58358
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Fix linked issue number 25/58425/2
nebrot [Fri, 28 Sep 2018 06:55:13 +0000 (08:55 +0200)]
[BUGFIX] Fix linked issue number

Releases: master
Resolves: #86415
Change-Id: Ib8002843376e651446a16143699844a98baebc0b
Reviewed-on: https://review.typo3.org/58425
Reviewed-by: Daniel Siepmann <daniel.siepmann@typo3.org>
Tested-by: Daniel Siepmann <daniel.siepmann@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
5 months ago[TASK] Make XML Sitemap cachable 17/58417/3
Richard Haeser [Thu, 27 Sep 2018 18:42:08 +0000 (20:42 +0200)]
[TASK] Make XML Sitemap cachable

Cache the XML Sitemaps for 15 minutes by default.

Resolves: #86060
Releases: master
Change-Id: Ia8ded8d0885565e636519bcd92f51154e0817946
Reviewed-on: https://review.typo3.org/58417
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Tested-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[TASK] Prepare Site handling for extended page routing 19/58419/4
Benni Mack [Thu, 27 Sep 2018 20:05:35 +0000 (22:05 +0200)]
[TASK] Prepare Site handling for extended page routing

An additional trait for site languages and some minor simplifications
when fetching the PageRouter from a Site.

Resolves: #86410
Releases: master
Change-Id: I88fd8fccbd19aada7014e7dca04c964e87fdd0cd
Reviewed-on: https://review.typo3.org/58419
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Resolve relative file path during copy correctly 15/58415/2
Oliver Hader [Thu, 27 Sep 2018 18:11:30 +0000 (20:11 +0200)]
[BUGFIX] Resolve relative file path during copy correctly

In composer mode several directories are arranged outside the
public root-path. When trying to copy to those folders, the
public root-path is prefixed due an invalid check which is
too strict. The expectation is to use public root-path
(PATH_site) when resolving relative paths here.

Resolves: #86407
Releases: master
Change-Id: I666b08311e06289c64943518682ab4a970b35a2b
Reviewed-on: https://review.typo3.org/58415
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[TASK] Deprecate internal_type=file and file_reference 14/58414/3
Benni Mack [Thu, 27 Sep 2018 16:57:26 +0000 (18:57 +0200)]
[TASK] Deprecate internal_type=file and file_reference

TCA "type=group" with "internal_type=file" and "internal_type=file_reference"
are the last parts of content related file handling that circumvent FAL.

All usages in the core have been changed since TYPO3 v6 until TYPO3 v9.

To prepare and unlock further file system related works in v10, it is
important we finally get rid of these parts that low level handles
uploads/ and other legacy functionality.

The patch finds any usages via TcaMigration, notes them as
deprecated and adds a series of hints to core places that can be
removed in v10. Note there is probably some hidden handling
left in the core, this is partially hard to find. We may stumble
upon more details in v10, but will have the freedom to remove
them then.

Resolves: #86406
Releases: master
Change-Id: I94f2fa6364277497e85e513f1bfd34cc0acf1390
Reviewed-on: https://review.typo3.org/58414
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
5 months ago[TASK] Deprecate $GLOBALS['TYPO3_LOADED_EXT'] 08/58408/6
Benjamin Franzke [Thu, 27 Sep 2018 08:31:08 +0000 (10:31 +0200)]
[TASK] Deprecate $GLOBALS['TYPO3_LOADED_EXT']

$GLOBALS['TYPO3_LOADED_EXT'] is defined as the "old" way
since the introduction of the PackageManager in 2013:
https://review.typo3.org/19605
(The class description of LoadExtensionArrayElement states:
Class to simulate the "old" extension information array element)

This old way should finally be removed to reduce site effects
(pollution of the global scope) of the PackageManager class.
It's marked as deprecated now, to be removed in v10.

All existing usaged are rewritten to use the PackageManager API.

Releases: master
Resolves: #86404
Change-Id: Ic53f5155828ef2ea711a1961e08f8e020e3f836a
Reviewed-on: https://review.typo3.org/58408
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
5 months ago[BUGFIX] Use interface SiteInterface as return type instead of Site 03/58403/2
Georg Ringer [Wed, 26 Sep 2018 18:07:46 +0000 (20:07 +0200)]
[BUGFIX] Use interface SiteInterface as return type instead of Site

To avoid exceptions the proper return type must be used.

Resolves: #86390
Releases: master
Change-Id: I3741582936cb1e1b530012a1c7fb8ff3ab6da934
Reviewed-on: https://review.typo3.org/58403
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
5 months ago[BUGFIX] Use correct column order in override dialog 89/58389/2
Andreas Fernandez [Tue, 25 Sep 2018 16:25:49 +0000 (18:25 +0200)]
[BUGFIX] Use correct column order in override dialog

Resolves: #86152
Releases: master, 8.7
Change-Id: I677c6d0405b833caf8a62f7f560b2e9b97679b36
Reviewed-on: https://review.typo3.org/58389
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Fix formEngine SelectCheckBox word-wrap on small screens 00/58400/2
Josef Glatz [Wed, 26 Sep 2018 17:00:09 +0000 (19:00 +0200)]
[BUGFIX] Fix formEngine SelectCheckBox word-wrap on small screens

This patch enables word-wrap in a form element `type=select`
with `renderType=selectCheckBox` on small screen devices like
tablet portrait. It prevents the list from sticking out of the right
viewport border.

Only the case when TYPO3_CONF_VARS/BE/debug = false was
taken into account.

Resolves: #86391
Releases: master
Change-Id: Ia894b0a7481feb7a083bc583ff037063093f4e9c
Reviewed-on: https://review.typo3.org/58400
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Tested-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Run silent upgraders after install tool login 98/58398/2
Christian Kuhn [Wed, 26 Sep 2018 15:19:23 +0000 (17:19 +0200)]
[BUGFIX] Run silent upgraders after install tool login

On successful login to standalone install tool, the routing
should jump to the silent upgraders and not to the main layout
directy to make sure the upgraders are executed at least once
before the maintenance view is loaded.

Resolves: #86386
Releases: master
Change-Id: I1246493671645d899780bb9ff1b08ed5682115a3
Reviewed-on: https://review.typo3.org/58398
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[BUGFIX] Allow linking to a targetSite without currentSite 97/58397/2
Susanne Moog [Wed, 26 Sep 2018 08:49:15 +0000 (10:49 +0200)]
[BUGFIX] Allow linking to a targetSite without currentSite

In case no current site exists in a context (for example currently
eID or other scripting contexts), the pageLinkBuilder threw an error
when linking to a page with a site configuration. The necessity for
having a current site config has been removed, the pageLinkBuilder
can now be used without a current site object and will then always
generate absolute URLs to the target site.

Resolves: #86384
Releases: master
Change-Id: Id8c984c4ac3837d7b4da37a99d43410c6db34187
Reviewed-on: https://review.typo3.org/58397
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[TASK] Mitigate argon2i hash issues 02/58402/4
Christian Kuhn [Wed, 26 Sep 2018 17:30:55 +0000 (19:30 +0200)]
[TASK] Mitigate argon2i hash issues

* Let the "stored hash uses not supported mechanism" bubble up.
  Instead of just a "login failed", an error is raised hinting
  that something is broken.
* Improve exception message #1533818591: If an upgrade or new
  installation has been performed on a system that does support
  argon2i, users are upgraded to this mechanism. If the instance
  is later deployed to a server that does not support argon2i, the
  hash comparison will fail.
* Improve exception message #1533822084: This one is usually only
  raised if a core upgrade from v8 to v9 has just been performed on
  an instance that does not support argon2i, and a backend login is
  executed before the install tool silent configuration upgrader
  configured the system properly.
* Wiki pages with more details:
  https://wiki.typo3.org/Exception/CMS/1533818591
  https://wiki.typo3.org/Exception/CMS/1533822084

Resolves: #86392
Releases: master
Change-Id: I51e4ee9a198b9b92feec43c37a8b6b9b41c1b6f9
Reviewed-on: https://review.typo3.org/58402
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[TASK] Further improvements for the site configuration 99/58399/4
Josef Glatz [Wed, 26 Sep 2018 14:01:43 +0000 (16:01 +0200)]
[TASK] Further improvements for the site configuration

This patch enhances the self declaration of the site
configuration form elements.

- TCA descriptions were added to specific elements to
  provide a better clarity on how to use them.
- First char uppercase on existing descriptions.
- Input fields gets properly trimmed now.
- Additional placeholders were added.

Beside that, all missing PHPDoc blocks are added to
the previously added UserFunctions class.

Releases: master
Resolves: #86387
Related: #85887
Change-Id: I684bb2044e4bb7ce3a6c60bf4656e83260fedafe
Reviewed-on: https://review.typo3.org/58399
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
5 months ago[TASK] Deprecate GeneralUtility::_GETset() 44/58344/7
Benni Mack [Thu, 20 Sep 2018 06:44:41 +0000 (08:44 +0200)]
[TASK] Deprecate GeneralUtility::_GETset()

The functionality of _GETset() is really broken by design
when thinking about having a non-global state.

On top $TSFE->mergingWithGetVars(), which was mainly used
in RealURL, is deprecated, as this needs to go within a PSR-15
middlware (I actually did that in a fork already for realurl v1).

Resolves: #86389
Releases: master
Change-Id: I7081ed48131237f9d1b0da6a4ddf252a34a02072
Reviewed-on: https://review.typo3.org/58344
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[TASK] Fix syntax highlighting in Changelog for ImplementStaticRoutes 09/58409/2
Daniel Siepmann [Thu, 27 Sep 2018 08:39:14 +0000 (10:39 +0200)]
[TASK] Fix syntax highlighting in Changelog for ImplementStaticRoutes

Use yaml as default highlighting. Add markup for code blocks.

Also add highlighting for file names.

Resolves: #86214
Releases: master
Change-Id: I716c9bf80f86e3188409d173d767469a84a28e82
Reviewed-on: https://review.typo3.org/58409
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
5 months ago[BUGFIX] Prevent closing a record after changes made with „toggle all“ 92/58392/4
Josef Glatz [Tue, 25 Sep 2018 18:20:16 +0000 (20:20 +0200)]
[BUGFIX] Prevent closing a record after changes made with „toggle all“

This patch prevents closing a form without showing the modal
to inform the backend user about unsaved changes if values of
an element with renderType `selectCheckBox` were changed
through a „toggle all“ checkbox.

Resolves: #86377
Releases: master, 8.7
Change-Id: I8a0ffd7ae0104739fdb66a1863e7012c0d30c84e
Reviewed-on: https://review.typo3.org/58392
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
5 months ago[TASK] Add facades for symfony/routing components 01/58401/4
Benni Mack [Wed, 26 Sep 2018 17:42:21 +0000 (19:42 +0200)]
[TASK] Add facades for symfony/routing components

We heavily rely on Symfony Routing for TYPO3 routing,
however we want to encapsulate this as much as possible
to allow us to use a different routing system if a better one
comes up.

In order to proceed with Route Enhancers we introduce
our own objects to extend them, and to typehint against
these objects in the next patches.

Some minor code preparations have been made as well.

Resolves: #86393
Releases: master
Change-Id: Id50186aa1a5ad57e097e6ff85e15d0f925bd63ef
Reviewed-on: https://review.typo3.org/58401
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>