Packages/TYPO3.CMS.git
19 months ago[BUGFIX] Correctly reference sys_file_metadata.language in TCA 99/56099/5
Christian Heindl [Sun, 11 Mar 2018 19:14:38 +0000 (20:14 +0100)]
[BUGFIX] Correctly reference sys_file_metadata.language in TCA

Palette "language" does not exists on table "sys_file_metadata" resulting
in an empty "language" tab, when editing a file's metadata.
Thus referencing language field directly.

Releases: master, 8.7
Resolves: #84200
Change-Id: I44b2b169bbce7948826fdade9f10a760b32df2c7
Reviewed-on: https://review.typo3.org/56099
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Use ServerRequestInterface in EditDocumentController 18/56018/17
Christian Kuhn [Tue, 6 Mar 2018 01:07:56 +0000 (02:07 +0100)]
[TASK] Use ServerRequestInterface in EditDocumentController

A controller reads information from the request object and creates
and returns a response object.

Backend controllers in TYPO3 however have a history of being messy:
They read information from GET/POST using these super globals
directly, or by calling helper methods like _GP(), getIndpEnv()
and others.
Some controllers don't even return a response object to be further
processable by PSR-15 middlewares, but call stuff like
HttpUtility::redirect() to write a response and die.
Furthermore, especially the old and most important backend
controllers have tons of public properties and methods. This makes
refactoring towards good controller code hard. But controllers
shouldn't expose much public API: They usually should not be called from
outside, except their main entry methods that take the request object
in order to turn it into a response object. Everything else should be
protected and used internally only.

The patch takes EditDocumentController as one of the most complex
and important backend controllers and refactors it:

* (Nearly) all methods and properties are protected.
* All request dependant data is read from $request->getParsedBody(),
  $request->getQueryParams() or $request->getAttribute('serverParams').

This patch is very careful and tries to be fully backwards compatible in
v9. In case some extension still uses properties or methods of this
controller, a series of different strategies have been used to retain
compatibility:

* Properties made protected use PublicPropertyDeprecationTrait
  to trigger_error() if accessed.
* Nearly all properties are kept, keep their state and type to not
  break a possible 3rd party usage.
* Nearly everything made protected or deprecated is configured to be
  scanned by extension scanner, except a couple of properties that
  would create too many false positives. Those are marked as not scanned
  in the deprecation ReST file.
* Various methods need $request now. They are always called with that
  argument, but fall back to $GLOBALS['TYPO3_REQUEST'] and
  trigger_error() if not given.
* Some methods are kept with their old signature as public and are
  set to deprecated, but trigger_error() to then call a new protected
  method with a better name and a more strict sigature.
* Some methods are kept public in v9, but test if they were called from
  outside to then trigger_error() telling they will be set to protected
  in v10.
* A couple of properties still must be public since other core
  functionality reads from them directly. Those are marked with
  an @todo and @internal to have freedom in v10 for further cleanup.
* Some (non core) hooks or signals may now trigger deprecation log
  entries if they try to set properties or call methods. Those need
  detailed handling later and may hand over specific properties instead
  of full "pObj". This will be a topic later if the main signal/hook
  handling gets more love. As a general alternative, some hooks or signal
  usages could also be turned into a PSR-15 middleware instead. In case
  of EditDocumentController, the write access of the two existing signal
  may eventually be removed altogether later, since an existing slot
  could probably better achieve the same job by being converted into a
  middleware that manipulates $request if it needs to write.

Changing controllers this way gives the core much more freedom
to refactor and significantly improve controller code in v10, after
now deprecated code from patches like these have been removed.

Change-Id: I3527c43c52f6e738f34ac0a21efc1ac904a3f6d2
Resolves: #84195
Releases: master
Reviewed-on: https://review.typo3.org/56018
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Streamline/Fix backend labels by removing superfluous colons 30/56130/7
Josef Glatz [Sat, 10 Mar 2018 17:45:32 +0000 (18:45 +0100)]
[TASK] Streamline/Fix backend labels by removing superfluous colons

Column labels across common tables have many mixed labels
with/without colons. Many longer existing labels still have colons.

Streamlining the backend makes the appearance more uniform.

Releases: master
Resolves: #84241
Change-Id: I456f85973a8220760303efb47600e8bcea01029e
Reviewed-on: https://review.typo3.org/56130
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Make hidden records searchable in top search 40/56140/2
Georg Ringer [Wed, 14 Mar 2018 07:06:06 +0000 (08:06 +0100)]
[BUGFIX] Make hidden records searchable in top search

Hidden records must be found by the top search again.

Resolves: #84248
Releases: master, 8.7
Change-Id: Ic41eff5ab3300746c7fe6a78f9ce2a305372f7ab
Reviewed-on: https://review.typo3.org/56140
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Create instance of ToggleSearchToolbox 41/56141/2
Andreas Fernandez [Wed, 14 Mar 2018 07:11:17 +0000 (08:11 +0100)]
[BUGFIX] Create instance of ToggleSearchToolbox

Resolves: #84251
Releases: master
Change-Id: Ib4f62be18d8175f03fe0456f61a7eed56a3b877a
Reviewed-on: https://review.typo3.org/56141
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[BUGFIX] Remove HTML from Install Tool ajax response. 38/56138/2
Georg Ringer [Tue, 13 Mar 2018 15:16:23 +0000 (16:16 +0100)]
[BUGFIX] Remove HTML from Install Tool ajax response.

Remove the not needed <i> tag which is escaped and looks strange.

Resolves: #84194
Releases: master

Change-Id: I19a8bdc6eee65487fc0d8317895b8fa44ba917ea
Reviewed-on: https://review.typo3.org/56138
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Add missing documentation files and correct errors 31/56131/3
Susanne Moog [Tue, 13 Mar 2018 11:33:16 +0000 (12:33 +0100)]
[TASK] Add missing documentation files and correct errors

Resolves: #84242
Releases: master, 8.7, 7.6
Change-Id: I049c053dee291e7c31dbf5c81aacde0619d0f244
Reviewed-on: https://review.typo3.org/56131
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Ensure TSconfig order is identical in BE and FE 22/56122/2
Markus Klein [Mon, 12 Mar 2018 22:04:29 +0000 (23:04 +0100)]
[BUGFIX] Ensure TSconfig order is identical in BE and FE

Make sure the inclusion order of TSconfig (files and record field)
are identical in BE and FE. As BE and FE use different algorithms,
FE is adjusted to match the BE behaviour, which is the expected one.

Resolves: #84227
Releases: master, 8.7
Change-Id: Idb4afbd736ed65890850ee75d572a55c3a5ab24d
Reviewed-on: https://review.typo3.org/56122
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Handle config.absRefPrefix on JS/CSS files correctly again 08/56108/8
Oliver Hader [Mon, 12 Mar 2018 12:10:42 +0000 (13:10 +0100)]
[BUGFIX] Handle config.absRefPrefix on JS/CSS files correctly again

Issue #77589 introduced automatic resolving of relative paths during
v8.4.0 development in the PageRenderer component. Doing this in some
backend context is fine - however if applied for frontend rendering,
config.absRefPrefix was not applied anymore to these files.

Reason for this behavior is applying PathUtility::getAbsoluteWebPath
which prefixes files with /<TYPO3_SITE_PATH>/ - however absRefPrefix
only works on relative URIs. Extending the absRefPrefix patterns in
TypoScriptFrontendController::setAbsRefPrefix() by mentioned prefix
would adjust explicitly defined absolute paths as well.

To solve this bug, the prefix /<TYPO3_SITE_PATH>/ is
not applied in frontend rendering contexts anymore.

Resolves: #83630
Releases: master, 8.7
Change-Id: Ib01f698c14fb646173ec24e26027c7d657700f87
Reviewed-on: https://review.typo3.org/56108
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Add upgrade wizard to keep sorting of sys_language records 30/55930/6
Georg Ringer [Tue, 27 Feb 2018 20:40:12 +0000 (21:40 +0100)]
[BUGFIX] Add upgrade wizard to keep sorting of sys_language records

To keep the sorting after an upgrade from 7.6 to 8.7 and later, an
upgrade wizard is added.

Resolves: #82538
Releases: master, 8.7
Change-Id: If1b5fbc56d445239bc6e4eaecb695889aeb9819b
Reviewed-on: https://review.typo3.org/55930
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
19 months ago[TASK] Apply code cleanup 80/56080/3
Ralf Zimmermann [Fri, 9 Mar 2018 17:28:25 +0000 (18:28 +0100)]
[TASK] Apply code cleanup

* Reapply usage of null coalescing operator from review:54810 that have
  been lost by the revert review:55422
* Prevent E_NOTICES within InheritancesResolverService
* Fix typos in unit tests

Releases: master
Resolves: #84189
Change-Id: If77ff3eddf51fa821314800cebaaf76d482b22e7
Reviewed-on: https://review.typo3.org/56080
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Add functional test for runtimeActivatedPackages 12/56112/4
Nicole Cordes [Mon, 12 Mar 2018 14:32:44 +0000 (15:32 +0100)]
[TASK] Add functional test for runtimeActivatedPackages

Resolves: #84215
Releases: master, 8.7, 7.6
Change-Id: I9a642bb90278b22e61b97634022d3ab7af514e10
Reviewed-on: https://review.typo3.org/56112
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Extract html into fluid template from cache module in admin panel 10/56110/7
Joerg Boesche [Mon, 12 Mar 2018 13:31:29 +0000 (14:31 +0100)]
[TASK] Extract html into fluid template from cache module in admin panel

The Cache module should use a fluid template instead of
the old php-html mixed data structure.

Resolves: #84209
Releases: master
Change-Id: Ib1a564c7af7e99007b890017037b9b095e7208b0
Reviewed-on: https://review.typo3.org/56110
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Render tags in ReST files 15/56115/3
Andreas Fernandez [Mon, 12 Mar 2018 15:41:09 +0000 (16:41 +0100)]
[TASK] Render tags in ReST files

This patch renders the tags of the ReST files in the panel of each change
log. The color of each tag is automatically adjusted to the severity of
the change.

Resolves: #84226
Releases: master
Change-Id: Iadc4fe1f01bb3d10b2ffd85fd85a516b22a685c3
Reviewed-on: https://review.typo3.org/56115
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Sort tags in „View Upgrade Documentation“ by name 13/56113/2
Andreas Fernandez [Mon, 12 Mar 2018 15:13:21 +0000 (16:13 +0100)]
[TASK] Sort tags in „View Upgrade Documentation“ by name

Resolves: #84217
Releases: master
Change-Id: Icd5e917f0b3d8fcd3f0a9ab5f9f763f87189f3a9
Reviewed-on: https://review.typo3.org/56113
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Add missing element description field to form editor 16/56116/4
Benjamin Kott [Mon, 12 Mar 2018 17:47:23 +0000 (18:47 +0100)]
[BUGFIX] Add missing element description field to form editor

To avoid the unsetting of previously set element descriptions for
input fields in the form editor, the field elementDescription was
added to all supported element types and is now available to editors.

Resolves: #84225
Releases: master, 8.7
Change-Id: Ide68a1fc95670d98df4e243436e93aa812bf9290
Reviewed-on: https://review.typo3.org/56116
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Correct automatic grid column calculation for forms 03/56103/5
Benjamin Kott [Mon, 12 Mar 2018 09:23:15 +0000 (10:23 +0100)]
[BUGFIX] Correct automatic grid column calculation for forms

The calculation now only includes direct children of the
row elements to produce a meaningful division
of the available space. If the available space is already
consumed by elements the next auto calculated
elements will now consume the space of a full row.

Resolves: #84207
Releases: master, 8.7
Change-Id: I5dabddbcd8c7b84236fdbbef3925d27197e99a39
Reviewed-on: https://review.typo3.org/56103
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Update fluid from 2.5.2 to 2.5.3 06/56106/2
Christian Kuhn [Mon, 12 Mar 2018 12:09:18 +0000 (13:09 +0100)]
[BUGFIX] Update fluid from 2.5.2 to 2.5.3

composer update typo3fluid/fluid

This fixes a count bug in if conditions and
a template resolving issue.

Resolves: #83812
Releases: master, 8.7
Change-Id: Ie5845614ffeac50dc5a5796d587d61015c4f1059
Reviewed-on: https://review.typo3.org/56106
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Streamline package management in PackageManager 87/55687/42
Nicole Cordes [Mon, 12 Feb 2018 20:30:43 +0000 (21:30 +0100)]
[BUGFIX] Streamline package management in PackageManager

This bugfix resolves an issue that all available Packages
are scanned at each request. At the same time, it fixes
an issue related to runtimeActivatedPackages.

We now
- resolve package key with api usage
- distinguish between registered and available packages
- remove superfluous exception annotations
- prevent superfluous scans on getPackage() and isPackageAvailable() calls

Releases: master, 8.7
Resolves: #83820
Change-Id: I2b8bff3d4bb5287fd76418217653477c77467a8e
Reviewed-on: https://review.typo3.org/55687
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] For links across domains check if absRefPrefix is set 79/56079/2
Stefan Neufeind [Fri, 9 Mar 2018 16:42:27 +0000 (17:42 +0100)]
[BUGFIX] For links across domains check if absRefPrefix is set

Prevent PHP-error if absRefPrefix is not set.

Resolves: #84188
Releases: master, 8.7
Change-Id: Ic04184554281cdcaa74037290930aa0110696a07
Reviewed-on: https://review.typo3.org/56079
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[BUGFIX] Two forgotten calls use inline action map 05/56105/3
Christian Kuhn [Mon, 12 Mar 2018 10:52:22 +0000 (11:52 +0100)]
[BUGFIX] Two forgotten calls use inline action map

Follow up for #84199 changing two call to use the
new map.

Resolves: #84210
Related: #84199
Releases: master
Change-Id: I1b251c5a759470ad97ca70bed2f5c0cb921f3159
Reviewed-on: https://review.typo3.org/56105
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[BUGFIX] Protect a forgotten AbstractFormEngineAjaxController method 00/56100/3
Christian Kuhn [Sun, 11 Mar 2018 19:41:27 +0000 (20:41 +0100)]
[BUGFIX] Protect a forgotten AbstractFormEngineAjaxController method

With refactoring in #79159 one method has accidently been set
public while it is obvious it should be protected. Fix that. Patch
is not considered to be breaking since the method is an internal
method of that abstract class.

Resolves: #84201
Related: #79159
Releases: master, 8.7
Change-Id: I0c04ff2d3fe9d68420c80af8831df361eb6f8a13
Reviewed-on: https://review.typo3.org/56100
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Move IRRE actions to a map and export inline 98/56098/2
Andreas Fernandez [Sun, 11 Mar 2018 17:55:17 +0000 (18:55 +0100)]
[TASK] Move IRRE actions to a map and export inline

The possible requests done in jsfunc.inline.js are now stored in a map
that holds the method (e.g. "create") and points to a specific route for
AJAX requests.
Additionally, the inline object is made public for the time being and
explicitly marked as internal.

This allows overriding specific routes, which is required for the
upcoming "Sites" module.

Resolves: #84199
Releases: master
Change-Id: Ief9fc1382e60a6b894e2970f9349f9b03913d021
Reviewed-on: https://review.typo3.org/56098
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[BUGFIX] Unify value for $report['lib'] to GuzzleHttp 40/56040/3
Felix Buenemann [Wed, 7 Mar 2018 19:30:43 +0000 (20:30 +0100)]
[BUGFIX] Unify value for $report['lib'] to GuzzleHttp

GeneralUtility::getUrl() now always returns 'GuzzleHttp' as lib
in the report, instead of returning
"GuzzleHttp" if an exception was caught and "http" otherwise.

Resolves: #84170
Related: #70056
Releases: master, 8.7
Change-Id: I6a28cb7921a3d784c37912c12f9b250f6b4d493c
Reviewed-on: https://review.typo3.org/56040
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Simulate submit button for rsaauth form submit 71/48371/5
Nicole Cordes [Sat, 28 May 2016 17:12:38 +0000 (19:12 +0200)]
[BUGFIX] Simulate submit button for rsaauth form submit

This patch adds the name and value of the first submit button found in a
form to the input field used to send the form.

Resolves: #76120
Releases: master, 8.7, 7.6
Change-Id: I3f0fdc7e933267689114d5bcf62d3fcfe2db5146
Reviewed-on: https://review.typo3.org/48371
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[BUGFIX] Set correct default connection charset "utf8" 81/56081/2
Wolfgang Klinger [Fri, 9 Mar 2018 21:12:14 +0000 (22:12 +0100)]
[BUGFIX] Set correct default connection charset "utf8"

Resolves: #84180
Releases: master, 8.7
Change-Id: Id868d3f379d131c3a51e039e6a862e4dcabf2fda
Reviewed-on: https://review.typo3.org/56081
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Properly HTML encode site name in page module 83/56083/2
Helmut Hummel [Fri, 9 Mar 2018 21:14:09 +0000 (22:14 +0100)]
[BUGFIX] Properly HTML encode site name in page module

Resolves: #84191
Releases: master, 8.7, 7.6
Change-Id: Id0f2da6f77b3c01293478329503dc922ccd7e72c
Reviewed-on: https://review.typo3.org/56083
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[TASK] Remove duplicate IconFactory instantiation 75/56075/2
Ralf Zimmermann [Fri, 9 Mar 2018 12:00:15 +0000 (13:00 +0100)]
[TASK] Remove duplicate IconFactory instantiation

Remove duplicate IconFactory instantiation within PageLayoutView

Releases: master
Resolves: #84186
Change-Id: I2fded29170ded49901c02ae4cdb0bcf056dce591
Reviewed-on: https://review.typo3.org/56075
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Assign elementClassAttribute to ImageUpload element 61/56061/3
Benjamin Kott [Thu, 8 Mar 2018 14:22:52 +0000 (15:22 +0100)]
[BUGFIX] Assign elementClassAttribute to ImageUpload element

Resolves: #84179
Releases: master, 8.7
Change-Id: I061674ab878dbfbd2483c17e46a48e2f606ddd87
Reviewed-on: https://review.typo3.org/56061
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Proper returnUrl editing permissions from context menu 71/56071/3
Christian Kuhn [Fri, 9 Mar 2018 00:03:44 +0000 (01:03 +0100)]
[BUGFIX] Proper returnUrl editing permissions from context menu

Context menu on pages -> More options -> Access call the
permissions module without proper returnUrl, doc header
"save and close" then fails redirecting to last view.
Fix using similar tec as used in other places like filelist
by providing a proper returnUrl.

Resolves: #83685
Releases: master, 8.7
Change-Id: Ib2136caaee8278438de3ff56faf5a940b7caf1d1
Reviewed-on: https://review.typo3.org/56071
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Do not mark "current" links as broken 54/56054/2
Susanne Moog [Thu, 8 Mar 2018 09:53:25 +0000 (10:53 +0100)]
[BUGFIX] Do not mark "current" links as broken

The linkhandler can resolve pages by uid or by using the
special keyword "current" which links the current page id.

The RteHtmlParser marked links to "current" as broken as the check
on whether the page record exists fails with a non-int uid.

The check has been disabled for links to the current page, as in that
context "current" has to be a valid page record (else content could
not be edited on it).

Resolves: #83423
Releases: master, 8.7
Change-Id: Iefde294a5f84e28a5faa1bc1262b7cc84e625f7e
Reviewed-on: https://review.typo3.org/56054
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Let RedirectCacheService not rely on having redirects cached 50/56050/2
Andreas Fernandez [Thu, 8 Mar 2018 07:58:15 +0000 (08:58 +0100)]
[BUGFIX] Let RedirectCacheService not rely on having redirects cached

RedirectCacheService::getRedirects() relies on having the redirects
cached. This assumption may lead to issues (e.g. in case a Redis server
fails), causing TypeErrors.

The code is changed to return the composed array in case the initial
cache request misses.

Resolves: #84070
Releases: master
Change-Id: I148db9ccbf28a2f93761fbf4b2cb632e27787b2d
Reviewed-on: https://review.typo3.org/56050
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] DatabaseRecordLinkBuilder respect now other typoscript settings 26/55426/4
René Pflamm [Mon, 22 Jan 2018 15:02:04 +0000 (16:02 +0100)]
[BUGFIX] DatabaseRecordLinkBuilder respect now other typoscript settings

If typolinks are generated using LinkHandler, the values defined in
typoscript (such as classes and titles) are now retained.

Resolves: #81903
Releases: master, 8.7
Change-Id: I9ec63e2cf972a3c4e7439b9259c63e2ab9b4b60d
Reviewed-on: https://review.typo3.org/55426
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Decouple Bootstrap and Application engaging a PSR-11 container 73/55773/51
Benjamin Franzke [Thu, 8 Feb 2018 20:21:05 +0000 (21:21 +0100)]
[TASK] Decouple Bootstrap and Application engaging a PSR-11 container

In order to avoid global state and to support full-application
subrequests (later on), bootstraping, application initialization
and application execution needs to be decoupled.
(To be able to initialize a frontend Application in backend
Application context, the frontend Application may not re-execute
bootstraping code.)

That means from now on:
 * Bootstrap is limited to stateless bootstrapping
   => setting up package manager and configuration
 * A (new) Container (PSR-11) performs class initialization
   => e.g. `new Frontend/Http/Application()`
 * Application performs execution
   => checking possible (application specific) redirects
   => offloading work to the request handler

This commit transforms Bootstrap into a (static) bootstrap utility
that returns a container (minimal, static PSR-11 implementation).
The entry-point scripts execute the bootstraper and use
the returned container to initialize and run the application.

This commit acts as a starting point for a broader PSR-11 container
support in TYPO3. We do – on purpose – use an own, very limited, anonymous
and static there is no configuration) PSR-11 implemententation for now.
This interim container implementation will be replaced by whatever
PSR-11 supporting container solution we use later on.
That keeps the necessary Bootstrap refactoring seperate from the
introduction of a full dependency injection container implementation.

All existing bootstrap methods keep working as before but the non-static
method invocation should be deprecated at some point.

typo3/cms-cli is adapted for the changed entry point script with:
https://github.com/TYPO3/cms-cli/pull/1

typo3/testing-framework is adapted in
https://github.com/TYPO3/testing-framework/pull/55

This patch brings one important behavioral change:

The install tool redirect (if essential configuration is missing) is
perfomed during application execution – after the configuration has been
loaded (falling back to failsafe mode if missing) – now. Previously the
application performed the redirect before it would call Bootstraps
configure() method. Now that the Application is decoupled from bootstrap,
the bootstrapper ensures it can always create an Application class, in
order for the application to be in charge of the decision what should
happen if essential configuration is missing.

Dependency changes:

composer require psr/container:^1.0
composer require typo3/cms-cli:^2.0
composer require typo3/testing-framework:^3.2 --dev

Change-Id: Idc59665dfcf7250a8a42b3d908a5a2376067700c
Releases: master
Resolves: #83951
Reviewed-on: https://review.typo3.org/55773
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Assign elementErrorClassAttribute to ImageUpload and FileUpload element 63/56063/3
Benjamin Kott [Thu, 8 Mar 2018 15:16:21 +0000 (16:16 +0100)]
[BUGFIX] Assign elementErrorClassAttribute to ImageUpload and FileUpload element

Resolves: #84181
Releases: master, 8.7
Change-Id: If55767b54071809e9622f9c29829bf4a76c66409
Reviewed-on: https://review.typo3.org/56063
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Allow empty date/time in strict database modes 62/56062/3
Oliver Hader [Thu, 8 Mar 2018 14:57:53 +0000 (15:57 +0100)]
[BUGFIX] Allow empty date/time in strict database modes

Empty date/time values are represented by the FormEngine as empty
string (''). Trying to persist this value in database management systems
using strict mode (which is enabled per default in MySQL 5.7),
will cause an SQL error since field types do not match.

Since it's known for the TYPO3 core which field types are used in
particular database tables, it's also possible to enforce this
type to be casted to integer values. This is done by using the
according TCA evaluation function 'int'.

Resolves: #82756
Releases: master, 8.7
Change-Id: I487caae785a3943916bceebc0c484d58e900a841
Reviewed-on: https://review.typo3.org/56062
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Allow range options to work for date/time fields 20/56020/7
Jigal van Hemert [Tue, 6 Mar 2018 10:22:35 +0000 (11:22 +0100)]
[BUGFIX] Allow range options to work for date/time fields

Date and time fields can contain ISO-8601 values. To apply lower and
upper limits the value must first be converted to a UNIX timestamp.

Resolves: #83240
Releases: master, 8.7
Change-Id: Ic15e9486cf7a4bcdf557c8a197d957ad88302b61
Reviewed-on: https://review.typo3.org/56020
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Recycler selectall feature has wrong data in rst file 59/56059/2
Oskar Dydo [Thu, 8 Mar 2018 13:15:05 +0000 (14:15 +0100)]
[BUGFIX] Recycler selectall feature has wrong data in rst file

Feature #81310 has wrong .rst file. The file should be corresponding to forge id not review id.

Resolves: #84176
Related: #81310
Releases: master
Change-Id: Iefddf9ba82534cb978d8ec3915d5fc34085646f3
Reviewed-on: https://review.typo3.org/56059
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[TASK] Migrate ModuleMenu to TypeScript 00/56000/6
Andreas Fernandez [Sun, 4 Mar 2018 16:56:47 +0000 (17:56 +0100)]
[TASK] Migrate ModuleMenu to TypeScript

This commit migrates the ModuleMenu to TypeScript. The following changes
are additionally done with with patch:

- NavigationComponentInterface requires a `initialize()` method
- Storage/Persistent.set() accepts objects as value
- ModuleMenu.App.ensurePageInTreeSelected is broken since #82426
  and has been removed

Resolves: #82597
Releases: master
Change-Id: I1dc8a79f7953a1e2504b0e7fd978c2e841ec93f4
Reviewed-on: https://review.typo3.org/56000
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Remove a duplicate ReST file 55/56055/2
Christian Kuhn [Thu, 8 Mar 2018 10:37:24 +0000 (11:37 +0100)]
[BUGFIX] Remove a duplicate ReST file

ReST file back ported to v8 should be added to 8.7.x/ folder in
core master branch only. Patch for issue #82093 copied the file
to master/ folder, this dupe is removed again.

https://docs.typo3.org/typo3cms/extensions/core/latest/Changelog/Howto.html
for more details on this.

Resolves: #84175
Related: #82093
Releases: master
Change-Id: Ibcd26da62b2c5d7a270a54c5fbe0d72964da6675
Reviewed-on: https://review.typo3.org/56055
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Change getUrl() $report['content_type'] to string 43/56043/3
Felix Buenemann [Thu, 8 Mar 2018 08:18:34 +0000 (09:18 +0100)]
[BUGFIX] Change getUrl() $report['content_type'] to string

In the conversion of \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl()
from cURL to GuzzleHttp the type of the $report['content_type'] field
was changed from a string to an array of strings.

This changes the field back to a string.

Also updated ErrorController getUrl test double to reflect the changes.

Resolves: #84173
Related: #84167
Releases: master, 8.7
Change-Id: Ia0eb60c42e920d66ce63afd0bd659c4b56d6d05b
Reviewed-on: https://review.typo3.org/56043
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Catch all exceptions in page module of form framework 33/55833/5
Ralf Zimmermann [Tue, 20 Feb 2018 16:40:22 +0000 (17:40 +0100)]
[BUGFIX] Catch all exceptions in page module of form framework

Catch the toplevel \Exception within the preview renderer hook. This
prevents that the page module shows an exception stacktrace if a
formDefinition - which is referenced within a form plugin - is moved
manually to a different location.
The problem occurs because the TYPO3\CMS\Core\Resource\Driver\LocalDriver
throws some top level exceptions (e.g. within getFileInfoByIdentifier()).

Resolves: #83777
Releases: master, 8.7
Change-Id: I686adb9e38b6f1b0bcb9830fe71d318ba0199a75
Reviewed-on: https://review.typo3.org/55833
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Fix a little grammar issue. 52/56052/2
Robert Wildling [Thu, 8 Mar 2018 09:40:05 +0000 (10:40 +0100)]
[TASK] Fix a little grammar issue.

Releases: master
Resolves: #84174
Change-Id: Ic762fbff61a4d7d932c9bc534706bb55fb369f5a
Reviewed-on: https://review.typo3.org/56052
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[!!!][BUGFIX] Fix wrong error path of validation 50/54150/8
Daniel Siepmann [Fri, 15 Sep 2017 22:55:34 +0000 (00:55 +0200)]
[!!!][BUGFIX] Fix wrong error path of validation

Add the form name as top level property to the validation results to let
the form field viewhelper attribute "errorClass" work.

Releases: master, 8.7
Resolves: #82093
Change-Id: I2d1c0845c5ab15d68393d5b491bf26db8f3f17c0
Reviewed-on: https://review.typo3.org/54150
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
19 months ago[BUGFIX] Convert URLs to punycode 58/55858/14
Sybille Peters [Wed, 21 Feb 2018 20:15:42 +0000 (21:15 +0100)]
[BUGFIX] Convert URLs to punycode

Resolves: #55155
Releases: master, 8.7
Change-Id: If7c099647a73d25f86ac38bdda67935deb4930e0
Reviewed-on: https://review.typo3.org/55858
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Pass original extbase response object to form framework finishers 49/55849/2
Benjamin Franzke [Wed, 21 Feb 2018 00:21:50 +0000 (01:21 +0100)]
[BUGFIX] Pass original extbase response object to form framework finishers

The original extbase response was passed as second parameter
to ObjectManager->get() – that did effectively nothing. The second get()
parameter is not a fallback parameter (as probably supposed by the author)
but the first constructor argument (but Response has no constructor).
Now, rather use a coalesce operator to use the original response or create
an own, if required.

Also handle the StopActionException in case no extbase response
is available (e.g. when rendered through FluidTemplateContentObject).

Due to this fixes the redirect finisher can be adapted to stop echo'ing
the response content on it's own. Directly echo'ing the response content
caused wrong Content-Length headers to be generated as the core didn't
know that content has been echo'ed. (The redirect response contains both a
header based redirect and html meta redirect; due to early echo that meta
redirect is prepended to the regular html output, and is missing in the
Content-Length calculation.)
That casused certain server environments (e.g. gzip, keep-alive,
proxy) and browsers (e.g. Android, Opera desktop) to display gzip
compressed data as garbage in the browser.

Resolves: #83822
Releases: master, 8.7
Change-Id: I4cb56e7626ea786d4b5265782b5940e60e3d2ec0
Reviewed-on: https://review.typo3.org/55849
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joonas Kauhanen <joonas.kauhanen@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Treat empty responses as error in GeneralUtility::getUrl 39/56039/5
Felix Buenemann [Wed, 7 Mar 2018 20:51:52 +0000 (21:51 +0100)]
[BUGFIX] Treat empty responses as error in GeneralUtility::getUrl

This fixes a negation bug introduced when the GeneralUtility::getUrl
code was converted to use GuzzleHttp instead of cURL.

Also updated ErrorController test doubles that where asserting the
wrong behavior.

Resolves: #84167
Releases: master, 8.7
Change-Id: I9b8982dc34f8a4ac22769beb7f837f090ce73f23
Reviewed-on: https://review.typo3.org/56039
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Merge the package DependencyResolver into the PackageManager 77/55977/16
Benjamin Franzke [Thu, 1 Mar 2018 18:19:21 +0000 (19:19 +0100)]
[TASK] Merge the package DependencyResolver into the PackageManager

The DependencyResolver and the PackageManager have a cyclic dependency to
each other which is currently resolved using GeneralUtility::makeInstance.
As the DependencyResolver is actually only used for the
PackageManager – and relies on it – it can be merged, saving a lot of
hassle.

The DependencyResolver class is not marked @internal and is therefore
deprecated.

Releases: master
Resolves: #84109
Change-Id: I71adccec3f13eb6de859f065937fbcde369758fe
Reviewed-on: https://review.typo3.org/55977
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Revert "[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths" 35/56035/2
Benjamin Franzke [Wed, 7 Mar 2018 12:06:28 +0000 (13:06 +0100)]
[BUGFIX] Revert "[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths"

This reverts commit 5c048a4c8017e4d50ab5f2343970a0fd33e4aaed
as introduced in https://review.typo3.org/54416

That workaround for a fluid bug had side effects when DataProviders
expected a ConfigurationManager instance to be available. That is
nothing officially supported but broke some (bad behaving) DataProviders.
As the fluid bug has been fixed in https://github.com/TYPO3/Fluid/pull/342
(contained in release 2.5.2) we can revert the workaround now.

The functional test that was introduced next to the bugfix is not reverted,
as do want to keep that obviously.

Resolves: #84071
Releases: master, 8.7
Change-Id: Ie6f5541f0f217fee7e85df954bb964a32fd27367
Reviewed-on: https://review.typo3.org/56035
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[FEATURE] Extract admin panel to own extension 30/56030/6
Susanne Moog [Wed, 7 Mar 2018 10:58:26 +0000 (11:58 +0100)]
[FEATURE] Extract admin panel to own extension

Extract all admin panel code to an own extension to
reduce cross-dependencies and allow clearer scoping.

See Epic / Initiative for background.

Related: #84044
Resolves: #84159
Releases: master
Change-Id: I0f6e2643746c94f0e10b87146ca7e86cbf8bc112
Reviewed-on: https://review.typo3.org/56030
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Avoid E_NOTICE reporting in ArrayUtility 32/56032/3
Ralf Zimmermann [Wed, 7 Mar 2018 12:08:44 +0000 (13:08 +0100)]
[BUGFIX] Avoid E_NOTICE reporting in ArrayUtility

In case of exception 1371758436, the dynamic exception message parts
must be converted to strings.

Releases: master
Resolves: #84161
Change-Id: Ibf3df93fef6c51945b21d6db8647419c41598e5d
Reviewed-on: https://review.typo3.org/56032
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Show icon in the page tree when page is edited by other user 33/56033/3
Tymoteusz Motylewski [Wed, 7 Mar 2018 12:11:22 +0000 (13:11 +0100)]
[BUGFIX] Show icon in the page tree when page is edited by other user

When a page is edited by other user it is "locked".
In this case an icon is shown in front of the page title.

Resolves: #84089
Releases: master
Change-Id: I4f3ab9266549212f66f26230e8d4bba4478878fa
Reviewed-on: https://review.typo3.org/56033
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Use the real page id for doesPageHaveUnallowedTables check 87/53687/5
Wolfgang Klinger [Sat, 12 Aug 2017 18:53:00 +0000 (20:53 +0200)]
[BUGFIX] Use the real page id for doesPageHaveUnallowedTables check

In case of handling a translated page record, use the according
proper uid value of the containing page of default language.

Resolves: #82053
Releases: master, 8.7
Change-Id: I0d0b5a268f4b87ef44d892f046ef474624b18058
Reviewed-on: https://review.typo3.org/53687
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[TASK] Update TYPO3 Icons to 1.6.0 36/56036/2
Susanne Moog [Wed, 7 Mar 2018 14:01:40 +0000 (15:01 +0100)]
[TASK] Update TYPO3 Icons to 1.6.0

New icons:
- content/content-clock.svg
- content/content-map.svg
- content/content-marker.svg
- content/content-menu-card.svg
- content/content-store.svg
- content/content-target.svg
- mimetypes/mimetypes-x-sys_redirect.svg

Resolves: #84162
Releases: master
Change-Id: Ic500110e48f221ae5c69d9ca85280da96f769114
Reviewed-on: https://review.typo3.org/56036
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
19 months ago[TASK] Update Fluid dependency to 2.5.2 31/56031/2
Claus Due [Wed, 7 Mar 2018 12:01:51 +0000 (13:01 +0100)]
[TASK] Update Fluid dependency to 2.5.2

This patch updates the Fluid dependency, to solve:

* Array keys now preserved when using reverse=1 on
   f:for - https://github.com/TYPO3/Fluid/commit/227a05a322bf584254544ef1c948d63e1af7bbd4
* TemplatePaths cache is made non-static -
   https://github.com/TYPO3/Fluid/commit/fa1b8aaeb957729478c958e495623dd7de1d14a1

Change-Id: Id10a80455f47300bfd29d734c83d9add87e17640
Releases: master, 8.7
Resolves: #84160
Reviewed-on: https://review.typo3.org/56031
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Avoid E_NOTICE reporting in ArrayUtility 29/56029/3
Ralf Zimmermann [Wed, 7 Mar 2018 08:29:11 +0000 (09:29 +0100)]
[BUGFIX] Avoid E_NOTICE reporting in ArrayUtility

In case of exception 1341397869, the dynamic exception message parts
must be converted to strings.

Releases: master, 8.7
Resolves: #84156
Change-Id: I3b86758495f9481a21691feaddd6000d484e2a5e
Reviewed-on: https://review.typo3.org/56029
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[FEATURE] Introduce an Environment API class 60/55960/6
Benni Mack [Thu, 1 Mar 2018 07:07:22 +0000 (08:07 +0100)]
[FEATURE] Introduce an Environment API class

A new class Environment is added, which is initialized right at the very
beginning of any TYPO3-based request.

The class contains a static list of properties commonly used throughout the
core to access paths, constants or global variables. The class also contains
methods that are relevant for ALL kind of PHP requests, CLI and web requests.

In order to avoid constants, and global variables, this is centralized in one
place, which allows to "re-define" values for testing purposes, making functional
tests a lot simpler.

This would better be stored in a dependency injection container and injected
as dependency/parameter into the respective classes that need the information.
We're not at that point to use dependency injection for every class, therefore
this class provides a static interface as a long-term interim solution.

Additionally, it adds a new functionality, basically finally allowing to move
code outside of the PATH_site constant with a proper API.

If the environment variable "TYPO3_PATH_APP" is set, this acts as a root path
for the project, which can be the same as PATH_site, or (usually) one level
up.
All typical new composer-based installations have this folder structure set up
automatically. Non-composer mode installations can set this environment variable
to make TYPO3 aware of non-public-accessable folders.

The following changes apply (with further patches):
- When TYPO3_PATH_APP is set, all logs / sessions / cache files are moved into $PROJECT_ROOT/var/.
- Same applies to typo3conf/l10n/, effectively moving this into a semi-writable
place, the same place where logs should be placed.
- LocalConfiguration.php, PackageStates.php and AdditionalConfiguration.php
  are now located at $PROJECT_ROOT/config/

The folder typo3conf then only contains code related to extensions.

The long-term goal until 9 LTS is that TYPO3 Core does not use any constants
anymore, which have been superseded by this class right now.

Resolves: #84153
Releases: master
Change-Id: I7ca35f752493d7e0d1c21c83a9ffbfb6a40eb463
Reviewed-on: https://review.typo3.org/55960
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[!!!][TASK] Remove language related JavaScript files 23/56023/5
Andreas Fernandez [Tue, 6 Mar 2018 14:15:54 +0000 (15:15 +0100)]
[!!!][TASK] Remove language related JavaScript files

The "language" extension has two JavaScript files left:

- Typo3Lang.js, was required for ExtJS, which has been removed
some time ago.
- Lang.js, is a RequireJS module that mimics the behavior of Typo3Lang.

As the desired functionality may be achieved with plain PHP, the module
is rendered obsolete and gets removed.

Resolves: #84148
Releases: master
Change-Id: Ice3df96195bb435da8df1004d1e9304ec7601d26
Reviewed-on: https://review.typo3.org/56023
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Migrate LiveSearch to TypeScript 99/55999/4
Andreas Fernandez [Sun, 4 Mar 2018 15:04:10 +0000 (16:04 +0100)]
[TASK] Migrate LiveSearch to TypeScript

Resolves: #82592
Releases: master
Change-Id: I1d07106cf79d552b62b4e9dedd61d4d1f7de007f
Reviewed-on: https://review.typo3.org/55999
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Call only clickOnLabel() in SVG based trees 27/56027/3
Andreas Fernandez [Tue, 6 Mar 2018 20:12:48 +0000 (21:12 +0100)]
[BUGFIX] Call only clickOnLabel() in SVG based trees

SVG based trees have a method called `clickOnLabel()`, which internally
calls `selectNode()` and also triggers a click event in `nodeBgEvents()`.

However, the latter two calls are repeated after `clickOnLabel()` is
called, causing issues like asking "Do you want to quit without saving?"
twice.

The calls are superfluous and are removed.

Resolves: #84152
Releases: master
Change-Id: Iabcb4ee5bfd0b7094cc52946f4e3be23f4372885
Reviewed-on: https://review.typo3.org/56027
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Tested-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
19 months ago[BUGFIX] Avoid associative array to be used in LocalizationUtility 24/56024/2
Oliver Hader [Tue, 6 Mar 2018 15:17:46 +0000 (16:17 +0100)]
[BUGFIX] Avoid associative array to be used in LocalizationUtility

On using associative array in LocalizationUtility which is e.g. used
by Fluid's TranslateViewHelper, the error Cannot unpack array with
string keys is thrown. The reason is that sprintf($value, ...$arguments)
cannot be used with $arguments being an associative array.

Resolves: #84149
Releases: master
Change-Id: Ifb60338bcf9095954969221cf08bd7e3d141ecc2
Reviewed-on: https://review.typo3.org/56024
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Use correct issue reference in allowLanguageSynchronization documentation 25/56025/3
Oliver Hader [Tue, 6 Mar 2018 15:42:51 +0000 (16:42 +0100)]
[TASK] Use correct issue reference in allowLanguageSynchronization documentation

Replace the Gerrit review ID by the related Forge ticket number.

Resolves: #84150
Releases: master, 8.7
Change-Id: I53fe0699e74949b4c64020a955294b3a1ef3f726
Reviewed-on: https://review.typo3.org/56025
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Upgrade Wizard must work also on records marked as deleted 39/52539/6
Christian Toffolo [Fri, 21 Apr 2017 05:36:58 +0000 (07:36 +0200)]
[BUGFIX] Upgrade Wizard must work also on records marked as deleted

Deleted records can be restored using the recycler, therefore the
wizards should check deleted records as well.

Resolves: #80836
Releases: master,8.7
Change-Id: I56a27c9dab4433c47c536edaa9649c5ebc73faad
Reviewed-on: https://review.typo3.org/52539
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[BUGFIX] RootlineUtility only resolves defined relation fields 15/56015/7
Benni Mack [Mon, 5 Mar 2018 18:49:50 +0000 (19:49 +0100)]
[BUGFIX] RootlineUtility only resolves defined relation fields

The RootlineUtility first selects all fields, which have been added
via the config option "addRootLineFields". After that, it iterates
over all(!) columns that are defined as relation.

The change modifies the loop so that only relations are resolved for
field pages.media (predefined) and those fields that have been added
to $GLOBALS[TYPO3_CONF_VARS][FE][addRootLineFields].

Resolves: #84144
Releases: master, 8.7
Change-Id: I3150f7cdd14aff3f25d5070f4ce190d510ba3614
Reviewed-on: https://review.typo3.org/56015
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
19 months ago[FEATURE] Add button to select all records 49/54849/18
Łukasz Uznański [Wed, 29 Nov 2017 09:37:15 +0000 (10:37 +0100)]
[FEATURE] Add button to select all records

Add and handle button to select all records from all pages in recycler.
Right now, there is pagination, which means that you can select 50 records max.

Resolves: #81310
Releases: master
Change-Id: Icfc0c93e5cff5cd9573a6a39b615ce0c6e1d273c
Reviewed-on: https://review.typo3.org/54849
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
19 months ago[TASK] Remove unused folder tree view option 16/56016/5
Christian Kuhn [Mon, 5 Mar 2018 19:57:20 +0000 (20:57 +0100)]
[TASK] Remove unused folder tree view option

Option ext_noTempRecyclerDirs is circularily used
and always false. It can be removed without harm
and ext_isLinkable() deprecated along the way.

Resolves: #84145
Releases: master
Change-Id: Ibeb949ddb81c919087f894c2839e9bf88c6eb290
Reviewed-on: https://review.typo3.org/56016
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] bamboo: Hard kill php web server processes 13/56013/2
Christian Kuhn [Mon, 5 Mar 2018 15:39:40 +0000 (16:39 +0100)]
[TASK] bamboo: Hard kill php web server processes

bamboo acceptance test shut down sometimes fails to stop
the 'php -S' web server process for unknown reasons.
A next job on the same agent then fails to bind to the
port, leading to broken builds.
Switch from SIGTERM to SIGKILL during test shut down
to see if that improves the situation.

Resolves: #84143
Releases: master, 8.7
Change-Id: I838a2341f1f8e25fa461b8747337406391b52241
Reviewed-on: https://review.typo3.org/56013
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Set COMPOSER_ROOT_VERSION to 9.2.0@dev for bamboo 65/55965/2
Benjamin Franzke [Thu, 1 Mar 2018 10:45:24 +0000 (11:45 +0100)]
[TASK] Set COMPOSER_ROOT_VERSION to 9.2.0@dev for bamboo

If typo3/testing-framework needs to be synced with changes
in core it needs to require the dev branch of the upcoming
release as the compatibility to previous releases needs to
be dropped.
Therefore it has to define a dependency in composer.json like:
  "typo3/cms-core": "^9.2@dev"

If composer install is executed with COMPOSER_ROOT_VERSION
set to 9.1.0 that produces a conflict, therefore we raise
the version to 9.2.0@dev. That actually aligns the setting
with the branch alias (9.2.x-dev) set in composer.json.

Releases: master
Resolves: #84102
Change-Id: Ib9a6f1027cd738bcc1ecf00ef4e059ad179fc7c0
Reviewed-on: https://review.typo3.org/55965
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Do not reinitialize cache and package manager in clearAllCache 88/55988/3
Benjamin Franzke [Fri, 2 Mar 2018 13:01:11 +0000 (14:01 +0100)]
[TASK] Do not reinitialize cache and package manager in clearAllCache

Those (re)initializations originate from https://review.typo3.org/19605
were reinitializeClassLoaderAndCachesAndPackageManagement()
was used to "Reinitialize the class loader during clear cache actions"
(according to phpdoc).

Then with the changes in https://review.typo3.org/29811
reinitializeClassLoaderAndCachesAndPackageManagement()
was dropped and splitted into unregisterClassLoader(),
flagCachingFrameworkForReinitialization().
initializeCachingFramework() and initializePackageManagement().
(just historical info, still all good)

Then http://review.typo3.org/39827 came and dropped unregisterClassLoader
but left the CacheManager and PackageManager reinitialization in place
superfluously. It's superfluous as the original usecase was to
reinitialize the class loader which is no longer required.

Note: InstallTool uses the FailsafePackageManager, although it's called
failsafe it still loads _all_ packages defined in PackageStates.php
into $GLOBALS['TYPO3_LOADED_EXT'] and therefore there is no requirement
for a new PackageManager instance to load ext_localconf.php from all
active extensions.

Change-Id: I844b0e3d8a63e64437ac57a716646e4902256e89
Releases: master
Resolves: #84117
Reviewed-on: https://review.typo3.org/55988
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Synchronize RST files 10/56010/2
Christian Kuhn [Mon, 5 Mar 2018 12:39:09 +0000 (13:39 +0100)]
[TASK] Synchronize RST files

* Various .rst file index fixes, NotScanned usually does not make
  sense on Important- and Feature- files.
* Add a missing extension scanner config
* Sync 7* and 8* folders to other core branches

Resolves: #84141
Releases: master, 8.7, 7.6
Change-Id: Ifc19d774d45395cb30bd51f50d9121af409f48bb
Reviewed-on: https://review.typo3.org/56010
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Access trigger element in modal correctly 07/56007/2
Andreas Fernandez [Mon, 5 Mar 2018 08:20:02 +0000 (09:20 +0100)]
[BUGFIX] Access trigger element in modal correctly

$(this) does not work in TypeScript, as this is bound to the class or the
method, but never to the element. Thus, the target element is fetched
from the event.

Resolves: #84138
Releases: master
Change-Id: I05545d19f5cb10adc3678fa81d81e3b181047bc4
Reviewed-on: https://review.typo3.org/56007
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[!!!][TASK] Make language module part of install extension 98/55998/19
Christian Kuhn [Sat, 3 Mar 2018 13:33:14 +0000 (14:33 +0100)]
[!!!][TASK] Make language module part of install extension

The language module changes configuration files and basic
instance system files and thus belongs to the install extension.

The patch moves the "Admin Tools" -> "Language" module to
"Maintenance" -> "Manage language packs" and comes with a
series of advantages:
* UX improvements and better overview
* Overall language pack update progress is much quicker
* Just a fraction of code needed
* No dependency to extension manager anymore
* Documentation extension has no hidden dependency to lang anymore

Change-Id: Ibcb9659dfacb5fda7c00ab2f39160f095e0cd154
Resolves: #84131
Releases: master
Reviewed-on: https://review.typo3.org/55998
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Remove double encoding of upgrade wizard. 87/55987/4
Georg Ringer [Fri, 2 Mar 2018 12:35:13 +0000 (13:35 +0100)]
[BUGFIX] Remove double encoding of upgrade wizard.

Replace the <br>-Tags with a LF char and render the linebreak
using CSS.

Resolves: #83875
Releases: master
Change-Id: I4429d2929104f922d5f9c0e5c048617848e805e5
Reviewed-on: https://review.typo3.org/55987
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[TASK] Cleanup code imports for all workspaces classes 06/56006/2
Benni Mack [Mon, 5 Mar 2018 06:42:35 +0000 (07:42 +0100)]
[TASK] Cleanup code imports for all workspaces classes

The system extension workspaces was never touched in terms of
checking if actually methods are needed, and a lot of code still uses
FQDN instead of the "use" keyword for a PHP class.

Some unused dependencies (e.g. to Extbase's objectmanager) are
removed as well.

Resolves: #84136
Releases: master
Change-Id: Ifa71ce9dddb6d0e68e09ee969d217d1514105a1a
Reviewed-on: https://review.typo3.org/56006
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[BUGFIX] Allow multi-byte characters in live search 97/55997/2
Sven Burkert [Sat, 3 Mar 2018 23:12:40 +0000 (00:12 +0100)]
[BUGFIX] Allow multi-byte characters in live search

Resolves: #83539
Releases: master, 8.7
Change-Id: I4d589d0654ab7ee091b664957fbb8c6d101be663
Reviewed-on: https://review.typo3.org/55997
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[TASK] Migrate Toolbar/ShortcutMenu to TypeScript 04/56004/2
Andreas Fernandez [Sun, 4 Mar 2018 18:21:13 +0000 (19:21 +0100)]
[TASK] Migrate Toolbar/ShortcutMenu to TypeScript

Resolves: #84128
Releases: master
Change-Id: I1bb613a5662071ef1003ee030389527904c771fb
Reviewed-on: https://review.typo3.org/56004
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Localize preview boxes 08/55108/14
Stephan Großberndt [Sat, 16 Dec 2017 10:45:18 +0000 (11:45 +0100)]
[TASK] Localize preview boxes

* Make the box shown when previewing in Frontend either a hidden page or
  an unpublished version in a workspace use translated labels
* Add missing htmlspecialchars() calls
* Restore the link to stop the preview
* Use translation of LanguageService to use the language of the current
  backend user

Resolves: #83352
Releases: master
Change-Id: I4a00965d02e549f4953d0a9b891e2469a7ff9a64
Reviewed-on: https://review.typo3.org/55108
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Migrate ValueSlider to TypeScript 75/55975/2
Andreas Fernandez [Thu, 1 Mar 2018 18:24:37 +0000 (19:24 +0100)]
[TASK] Migrate ValueSlider to TypeScript

Change-Id: Ibb233ab281052eba4a5cab267130cd50269fd0b2
Resolves: #82610
Releases: master
Reviewed-on: https://review.typo3.org/55975
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Migrate Toolbar/SystemInformationMenu to TypeScript 03/56003/2
Andreas Fernandez [Sun, 4 Mar 2018 17:50:26 +0000 (18:50 +0100)]
[TASK] Migrate Toolbar/SystemInformationMenu to TypeScript

Resolves: #84129
Releases: master
Change-Id: Ifafd271ff12de3bfab1ff57fcf51d178ddac0a2a
Reviewed-on: https://review.typo3.org/56003
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Migrate Toolbar/ClearCacheMenu to TypeScript 02/56002/2
Andreas Fernandez [Sun, 4 Mar 2018 17:35:45 +0000 (18:35 +0100)]
[TASK] Migrate Toolbar/ClearCacheMenu to TypeScript

Resolves: #84127
Releases: master
Change-Id: I60ee74644a04354e6939aa8e5acc452004e1f582
Reviewed-on: https://review.typo3.org/56002
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Refactor AdminPanelView - remove module specifics 85/55985/5
Susanne Moog [Fri, 2 Mar 2018 09:21:17 +0000 (10:21 +0100)]
[TASK] Refactor AdminPanelView - remove module specifics

This is the second step in the AdminPanelView refactoring. It
extracts module specific code and uses a more generic API to
initialize, configure and display admin panel modules.

Resolves: #84118
Releases: master
Change-Id: I85a1e11dfd7d9397fabbfbd7d5cf658387056644
Reviewed-on: https://review.typo3.org/55985
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[FEATURE] Make position of sys notes configurable 76/55976/8
Georg Ringer [Thu, 1 Mar 2018 18:30:44 +0000 (19:30 +0100)]
[FEATURE] Make position of sys notes configurable

Add a new field "position" to allow editors to define where the
sys_note record is rendered.

Resolves: #83965
Releases: master
Change-Id: I22c6b5c66ce5ab58a112f844fd763a18788552f9
Reviewed-on: https://review.typo3.org/55976
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Have extractFileInformation extract atime only once 93/55993/5
Guido Schmechel [Sat, 3 Mar 2018 09:25:57 +0000 (10:25 +0100)]
[BUGFIX] Have extractFileInformation extract atime only once

Remove duplicate "atime" entry to prevent duplicate
call of "atime" property extraction.

Resolves: #83992
Releases: master, 8.7
Change-Id: I2e09bc07b12b07eb89bd6fb247d0fed4431c8ef6
Reviewed-on: https://review.typo3.org/55993
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
19 months ago[TASK] Remove comments that contain v4 or FLOW information 94/55994/2
Benjamin Franzke [Sat, 3 Mar 2018 11:08:04 +0000 (12:08 +0100)]
[TASK] Remove comments that contain v4 or FLOW information

Whether a class or functionality is not available or available
differently in v4 or FLOW is not relevant for TYPO3 CMS.
Remove them.

Occurrences have been searched using:
git grep "TYPO3 4"
git grep " v4"
git grep -l "FLOW" | grep php$

Change-Id: I1e690c2b8eee2af0ade831600ee9a3e1cfe6437a
Releases: master
Resolves: #84126
Reviewed-on: https://review.typo3.org/55994
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[FEATURE] Add absolute option to typolink VHs 90/55990/3
Benni Mack [Fri, 2 Mar 2018 15:36:44 +0000 (16:36 +0100)]
[FEATURE] Add absolute option to typolink VHs

In order to generate absolute URLs through the
Typolink ViewHelpers of TYPO3 Fluid, a new
fluid parameter "absolute" is added to the following
ViewHelpers.

* <f:link.typolink>
* <f:uri.typolink>

As typolink() is allowing this option, the generation
of absolute URLs behaves the same way as typolink()
itself does it.

Use it like this:

The ViewHelper code:
- <f:link.typolink parameter="23">Link To My Page</f:link.typolink>
generates:
- <a href="index.php?id=23">Link to My Page</a>

The ViewHelper code:
- <f:link.typolink parameter="23" absolute="true">Link To My Page</f:link.typolink>
generates:
- <a href="https://www.mydomain.com/index.php?id=23">Link to My Page</a>

The ViewHelper code:
- <f:uri.typolink parameter="23" />
generates:
- "index.php?id=23"

The ViewHelper code:
- <f:uri.typolink parameter="23" absolute="true" />
generates:
- "https://www.mydomain.com/index.php?id=23"

Resolves: #84120
Releases: master
Change-Id: I6b6df0ebc8a7c257ab854959e5425debd0cadd5e
Reviewed-on: https://review.typo3.org/55990
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Remove unnecessary parentheses 91/55991/2
Frank Naegler [Fri, 2 Mar 2018 15:43:07 +0000 (16:43 +0100)]
[TASK] Remove unnecessary parentheses

The first patch https://review.typo3.org/#/c/55952/
missed two places because of a rebase issue.

Resolves: #84092
Releases: master
Change-Id: Ie646cdfdb4900a3a7b969b4745852f7c76139df5
Reviewed-on: https://review.typo3.org/55991
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[TASK] Add missing license headers to new PHP files 92/55992/2
Benni Mack [Fri, 2 Mar 2018 17:47:03 +0000 (18:47 +0100)]
[TASK] Add missing license headers to new PHP files

Resolves: #84121
Releases: master
Change-Id: Idf51b84880d56db4d54cbad2e556bccbcf888ba1
Reviewed-on: https://review.typo3.org/55992
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[TASK] Don't mark ConnectionPool::getConnectionByName() as internal 86/55986/4
Georg Ringer [Fri, 2 Mar 2018 12:18:22 +0000 (13:18 +0100)]
[TASK] Don't mark ConnectionPool::getConnectionByName() as internal

The method ConnectionPool::getConnectionByName() is no longer flagged
as internal as it is useful for extensions creating connections
to external databases.

Resolves: #84100
Releases: master, 8.7
Change-Id: I9bbf524905c436097264c465e92d8b689994c253
Reviewed-on: https://review.typo3.org/55986
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Use correct variables of sys_note records 84/55984/2
Georg Ringer [Fri, 2 Mar 2018 09:37:05 +0000 (10:37 +0100)]
[BUGFIX] Use correct variables of sys_note records

Since the removal of the models the field names of the database
must be used.

Resolves: #84113
Releases: master
Change-Id: I2d472b27455fdf37e418e9135dee81eeb8f125b0
Reviewed-on: https://review.typo3.org/55984
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Improve TranslateViewHelper compiling 83/55983/3
Mathias Brodala [Fri, 2 Mar 2018 08:21:42 +0000 (09:21 +0100)]
[TASK] Improve TranslateViewHelper compiling

Simplify string interpolation with positional arguments.

Resolves: #82454
Releases: master
Change-Id: If2bb56be5bba183ff5decbbb4a8f61eb01c61792
Reviewed-on: https://review.typo3.org/55983
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Remove unnecessary parentheses 52/55952/6
Wouter Wolters [Wed, 28 Feb 2018 20:34:17 +0000 (21:34 +0100)]
[TASK] Remove unnecessary parentheses

These parentheses are redundant and may be safely removed.

Resolves: #84092
Releases: master
Change-Id: I59f2b7454316ecd05f57d28e344f03a65d13e5c5
Reviewed-on: https://review.typo3.org/55952
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Add feature switch "unifiedPageTranslationHandling" 46/55446/8
Benni Mack [Wed, 24 Jan 2018 13:21:17 +0000 (14:21 +0100)]
[TASK] Add feature switch "unifiedPageTranslationHandling"

The feature switch "unifiedPageTranslationHandling" is active for all new
installations, but not active for existing installations.

It does the following when active:
- All DB schema migrations decide to drop "pages_language_overlay"
- TCA migration no longer throws a deprecation info (but still unsets "pages_language_overlay")

Once the Update Wizard for migrating pages_language_overlay records is done,
the feature is enabled.

Resolves: #83711
Releases: master
Change-Id: I478c8d5d745309889fa38b44b5eaab7226afdfc4
Reviewed-on: https://review.typo3.org/55446
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Improve LocalizationUtility logic and feedback 18/54118/6
Claus Due [Mon, 11 Sep 2017 14:43:19 +0000 (16:43 +0200)]
[TASK] Improve LocalizationUtility logic and feedback

This patch does two things to improve the translation
flow in LocalizationUtility::translate:

* Early return null on empty $key (would cause null anyway)
* Feedback message on failure to sprintf

In order to provide failure feedback for formatted
strings, vsprintf had to be replaced with sprintf and
array unrolling, since vsprintf does not return false
on errors and sprintf does. The error is returned as
translation result so even if an unexpected failure
occurs, at least a partially meaningful text is shown.

Change-Id: I568be30b701f0c374289ed44fc5b31b13f492483
Resolves: #82453
Releases: master
Reviewed-on: https://review.typo3.org/54118
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Improve TranslateViewHelper compiling 19/54119/9
Claus Due [Mon, 11 Sep 2017 15:03:37 +0000 (17:03 +0200)]
[TASK] Improve TranslateViewHelper compiling

This patch improves the TranslateViewHelper by letting
it be compiled to a single line of null-coalescing code
in the Fluidtemplate. Since the ViewHelper is one of the
most frequently used, saving method calls and condition
checks here gives a nice result.

Removes the need to load the VH class if all templates
are compiled, further saving some calls and checks.

Change-Id: Ifd3b051305d3cb631d3e8413bac40b4766136aef
Resolves: #82454
Releases: master
Reviewed-on: https://review.typo3.org/54119
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Add +repage option when cropping images 69/55269/3
Frans Saris [Thu, 4 Jan 2018 20:16:07 +0000 (21:16 +0100)]
[BUGFIX] Add +repage option when cropping images

To be sure the image (especialy gif format) is correctly repaged after
cropping it the +repage option needs to be added to the full command.

This patch adds the option for the LocalCropScaleMaskHelper and the
ImageBuilder cropscaling `crs` option.

Resolves: #83407
Releases: master, 8.7
Change-Id: I27b471d33acdc76c7af28ca0f114be72de91fcb9
Reviewed-on: https://review.typo3.org/55269
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Fix imagemagick commands when setting stripProfile to "0" 90/51990/5
Paul Golmann [Thu, 9 Mar 2017 11:12:50 +0000 (12:12 +0100)]
[BUGFIX] Fix imagemagick commands when setting stripProfile to "0"

Remove the ###SkipStripProfile### flag from command parameters added
by e.g. stripProfile in TypoScript if
GFX[processor_stripColorProfileByDefault] is disabled in global
configuration to prevent erroneous imagemagick commands.

Resolves: #80208
Releases: master, 8.7
Change-Id: I0860744ad4b27e44f1d9f7bb6da5dd646f4a1fc4
Reviewed-on: https://review.typo3.org/51990
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Properly append/prepend with "addRecord" wizard 26/55826/5
Mathias Brodala [Tue, 20 Feb 2018 14:47:59 +0000 (15:47 +0100)]
[BUGFIX] Properly append/prepend with "addRecord" wizard

For relations the internal field value contains a list of UIDs instead
of full related records.

Resolves: #82461
Releases: master, 8.7
Change-Id: Iec2a74fbc8d17636dd8751911984c337d4e99b63
Reviewed-on: https://review.typo3.org/55826
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Tested-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Stop monkey patching CacheManager configuration in InstallTool 71/55971/2
Benjamin Franzke [Thu, 1 Mar 2018 15:51:27 +0000 (16:51 +0100)]
[TASK] Stop monkey patching CacheManager configuration in InstallTool

Instead of creating the cacheManager and then disabling all cache
confiurations afterwards, the desired state is enforced inside the
CacheManager now (controlled through a constructor parameter).

Releases: master
Resolves: #84107
Change-Id: Ia3623a96246d97b74ee48eb2022ba35d5bcfcc04
Reviewed-on: https://review.typo3.org/55971
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Put commit hooks into Build/git-hooks directory 12/55712/26
Sybille Peters [Wed, 14 Feb 2018 09:41:20 +0000 (10:41 +0100)]
[TASK] Put commit hooks into Build/git-hooks directory

* commit-msg hook: change wiki link to link to official contribution guide
* commit-msg hook: rebase with original source
* commit-msg hook: add Change-Id on last line after footer
* pre-commit hook: check if staged php files conform to coding guidelines
* Build/Scripts/cglFixMyCommit.sh: extended
  parameters to be used by new pre-commit hook

Resolves: #83891
Releases: master, 8.7, 7.6
Change-Id: I6d00aa32ef3f9517d88e90c40059c7f73d7f6cfe
Reviewed-on: https://review.typo3.org/55712
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Update typo3fluid/fluid to 2.5.1 56/55956/2
Markus Klein [Wed, 28 Feb 2018 22:04:45 +0000 (23:04 +0100)]
[TASK] Update typo3fluid/fluid to 2.5.1

- Allows any protocol or wrapper for template sources
- Ignores empty path specifications

composer command used:
composer update typo3fluid/fluid

Resolves: #84095
Releases: master, 8.7
Change-Id: I52380fe465b112df73ab86c570f6a12d2eedf4d3
Reviewed-on: https://review.typo3.org/55956
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>