Packages/TYPO3.CMS.git
2 years ago[TASK] Move rst changelog files from master to 8.7 folder 99/52299/7
Frank Naegler [Fri, 31 Mar 2017 18:26:53 +0000 (20:26 +0200)]
[TASK] Move rst changelog files from master to 8.7 folder

Resolves: #80635
Releases: master
Change-Id: I39c2eb60a0c42e3c96a6a590e51074003239012b
Reviewed-on: https://review.typo3.org/52299
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move EXT:rtehtmlarea to TER and provide update wizard 13/52313/6
Benni Mack [Sat, 1 Apr 2017 15:58:12 +0000 (17:58 +0200)]
[TASK] Move EXT:rtehtmlarea to TER and provide update wizard

Resolves: #80628
Releases: master
Change-Id: I9db7ee577258cae6b25eb940000eab2b5be5ee37
Reviewed-on: https://review.typo3.org/52313
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Allow extended custom links in FormEngine and TypoLink 64/52264/16
Benni Mack [Thu, 30 Mar 2017 13:47:23 +0000 (15:47 +0200)]
[FEATURE] Allow extended custom links in FormEngine and TypoLink

This patch extracts TypoLink generation into separate classes based
on the link type calculated via the LinkService functionality.

Via the configuration $TYPO3_CONF_VARS[FE][typolinkBuilder][$linkType]
new types can be added or existing implementations can be overriden.

Resolves: #80619
Releases: master
Change-Id: Id1dc028cb306ac50352302b8a5c9725ab7f04b31
Reviewed-on: https://review.typo3.org/52264
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Prevent sending empty forms in FormEngine 15/52315/2
Frank Naegler [Sun, 2 Apr 2017 10:44:06 +0000 (12:44 +0200)]
[BUGFIX] Prevent sending empty forms in FormEngine

In some cases the FormEngine forms are send to the server with empty values.
Please see the issue for more details and testing instructions.

Resolves: #80633
Releases: master
Change-Id: I22ff7365e3dcb85bf6c3bc177f6cde674306ce6c
Reviewed-on: https://review.typo3.org/52315
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Show disabled state for navigation component toggle if not available 07/52307/3
Benjamin Kott [Fri, 31 Mar 2017 20:54:17 +0000 (22:54 +0200)]
[TASK] Show disabled state for navigation component toggle if not available

Resolves: #80621
Releases: master
Change-Id: I5a954cc2cecb8593e0ca9ae9b0f660752c522d29
Reviewed-on: https://review.typo3.org/52307
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Handle gallery position and alignment in fsc image content element 39/52039/3
Gianluigi Martino [Tue, 14 Mar 2017 12:28:50 +0000 (13:28 +0100)]
[TASK] Handle gallery position and alignment in fsc image content element

Add relevant classes to fsc image content element to
handle gallery position and alignment

Resolves: #80164
Releases: master
Change-Id: Ia4fbd3e8951a5f2f6ee92a55aca78477a54504f3
Reviewed-on: https://review.typo3.org/52039
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years agoRevert "[TASK] Deprecate f:format.html in the backend context" 06/52306/5
Frank Naegler [Fri, 31 Mar 2017 20:34:24 +0000 (21:34 +0100)]
Revert "[TASK] Deprecate f:format.html in the backend context"

This patch will be reverted, because the ViewHelper is still in use
and an alternative is not ready yet.

This reverts commit 0a59b27595da8ee48d112de3fe3a5c573103f183.

Releases: master
Resolves: #80620
Reverts: #72716
Change-Id: I9667dbc2acd3fec0ed9af29ae995fb6f25aaae92
Reviewed-on: https://review.typo3.org/52306
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Show "Edit Metadata of this file" icon in filelist search results 78/52278/2
Gianluigi Martino [Fri, 31 Mar 2017 06:57:00 +0000 (08:57 +0200)]
[TASK] Show "Edit Metadata of this file" icon in filelist search results

Releases: master
Resolves: #80591
Change-Id: I0a661f61f5e9bf6572903ff1de81095f95eb0b6a
Reviewed-on: https://review.typo3.org/52278
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[TASK] Install Tool: Use classes for AJAX calls as selectors 32/52232/5
Marc Wessels [Wed, 29 Mar 2017 09:49:39 +0000 (11:49 +0200)]
[TASK] Install Tool: Use classes for AJAX calls as selectors

This patch changes selectors for some AJAX calls from id to class

Resolves: #80545
Releases: master
Change-Id: Ic3805c180779a2b5b2f49993f6064555f26d1938
Reviewed-on: https://review.typo3.org/52232
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Add missing rst file for testing framework removal 04/52304/4
Susanne Moog [Fri, 31 Mar 2017 19:33:22 +0000 (21:33 +0200)]
[TASK] Add missing rst file for testing framework removal

Change-Id: I6ae49dd73c4ded8d6b1572c79d03ce48108d3957
Resolves: #80606
Releases: master
Reviewed-on: https://review.typo3.org/52304
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix travis after test framework extraction 03/52303/2
Christian Kuhn [Fri, 31 Mar 2017 18:58:03 +0000 (20:58 +0200)]
[TASK] Fix travis after test framework extraction

Change-Id: I258399a02020ba492a2e52d76360fe0d866ee965
Resolves: #80617
Releases: master
Reviewed-on: https://review.typo3.org/52303
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate itemListStyle and selectedListStyle 02/52302/2
Christian Kuhn [Fri, 31 Mar 2017 18:39:53 +0000 (20:39 +0200)]
[TASK] Deprecate itemListStyle and selectedListStyle

The two TCA properties itemListStyle and selectedListStyle which have
already been dropped in other elements are fully deprecated.
The concept of adding CSS at single places in the elements
is very limited and does not cope with bigger HTML changes planned
for v9.

Change-Id: I1d99b724b0caafe5e1feecc0f1f924498da6a354
Resolves: #80614
Releases: master
Reviewed-on: https://review.typo3.org/52302
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Finetune large modal size 00/52300/3
Benjamin Kott [Fri, 31 Mar 2017 18:38:25 +0000 (20:38 +0200)]
[TASK] Finetune large modal size

Resolves: #80615
Releases: master
Change-Id: If005ff9dfa1b7bd9c8305562564ce7c21385a887
Reviewed-on: https://review.typo3.org/52300
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Change duplicate icon identifiers to actions-add 89/52289/4
Marco Christian Krenn [Fri, 31 Mar 2017 10:56:14 +0000 (12:56 +0200)]
[TASK] Change duplicate icon identifiers to actions-add

The following icons which were previously used in the Install tool
were all replaced by "actions-add" which acts as a synonym.

* actions-edit-add

Releases: master
Resolves: #80603
Change-Id: Ie35e600799f49d53e68a2308d8e9f007189cdbdd
Reviewed-on: https://review.typo3.org/52289
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[BUGFIX] Correct element browser classes for record listing 01/52301/2
Benjamin Kott [Fri, 31 Mar 2017 18:41:38 +0000 (20:41 +0200)]
[BUGFIX] Correct element browser classes for record listing

Resolves: #80616
Releases: master
Change-Id: I729f34496b65486c9f72eab52d67b913edc5c548
Reviewed-on: https://review.typo3.org/52301
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Update TYPO3 Icons to 1.2.0 93/52293/3
Benjamin Kott [Fri, 31 Mar 2017 11:36:13 +0000 (13:36 +0200)]
[TASK] Update TYPO3 Icons to 1.2.0

Resolves: #80605
Releases: master
Change-Id: I9b591eff4e7168a9e8b1d4b80f0b8ec79925f4e7
Reviewed-on: https://review.typo3.org/52293
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[TASK] Extract target attribute resolving from typolink 82/52282/5
Benni Mack [Thu, 30 Mar 2017 23:58:06 +0000 (01:58 +0200)]
[TASK] Extract target attribute resolving from typolink

The repetitive code for each typolink method is moved to
a separate method in order to allow the LinkService to do the main job.

Resolves: #80602
Releases: master
Change-Id: I7c75a629a12e80258d025d18f6c9600e0872975c
Reviewed-on: https://review.typo3.org/52282
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Raise version of EXT:compatibility7 installation to 8.7.1 96/52296/5
Mona Muzaffar [Fri, 31 Mar 2017 14:11:20 +0000 (16:11 +0200)]
[TASK] Raise version of EXT:compatibility7 installation to 8.7.1

In order to ensure that when the upgrade wizard runs to install
EXT:compatibility7, it should not have a dependency on indexed_search
which it had until 8.7.1.

A new version (8.7.1) was released to TER to solve the issue.

Change-Id: I0b0cf9eb927cca627ca332f30219fe70f13dd4d9
Resolves: #80590
Releases: master
Reviewed-on: https://review.typo3.org/52296
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove testing framework from core and use package 83/52283/9
Susanne Moog [Mon, 27 Mar 2017 19:14:42 +0000 (21:14 +0200)]
[TASK] Remove testing framework from core and use package

Change-Id: I8e45a13762aa44b2c93dc8acff393c51cd883d94
Resolves: #80606
Releases: master
Reviewed-on: https://review.typo3.org/52283
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Change duplicate icon identifiers to actions-close 85/52285/6
Marco Christian Krenn [Fri, 31 Mar 2017 10:15:56 +0000 (12:15 +0200)]
[TASK] Change duplicate icon identifiers to actions-close

The following icons which were previously used in the Install tool
were all replaced by "actions-close" which acts as a synonym.

* actions-document-close
* actions-message-error-close

Resolves: #80601
Releases: master
Change-Id: I95358aa6e34237f0fa27049aadf0ae788fef2172
Reviewed-on: https://review.typo3.org/52285
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[TASK] Streamline workspace DataHandler functional tests 16/52216/11
Oliver Hader [Tue, 28 Mar 2017 13:32:01 +0000 (15:32 +0200)]
[TASK] Streamline workspace DataHandler functional tests

Streamline functional test cases for core and workspace system extension.

Change-Id: I1c8b2150b4d86730cfb00465abe4862f877c2270
Resolves: #80538
Releases: master
Reviewed-on: https://review.typo3.org/52216
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] Improved JavaScript Modal API 28/52228/14
Benjamin Kott [Wed, 29 Mar 2017 01:27:14 +0000 (03:27 +0200)]
[FEATURE] Improved JavaScript Modal API

To improve the usability and flexibility for a unified handling of
overlays in the backend we're opening the existing API for modals to be
more flexible and adjustable to your needs for advanced usage. With the
introduction of the advanded API it is now possible to pass configuration
via a json object. This enables more easy configuation and better
fallbacks if the modal is not correctly configured.

For a unified experience all modals are now centered by default, will be
kept in place automatically and are available in different sizes depending
on your needs. In addition to this there is also a new type for loading
content into an iframe. Buttons now have full support for the TYPO3 Icon
API and data attributes can also be set by configuration.

Resolves: #80579
Releases: master
Change-Id: Iddd260193a55335889db1068fbd8684011db6518
Reviewed-on: https://review.typo3.org/52228
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix scheduler task logging in case of an exception 86/52286/3
Christian Wolff [Fri, 31 Mar 2017 07:23:49 +0000 (09:23 +0200)]
[BUGFIX] Fix scheduler task logging in case of an exception

Correctly log the message if a Scheduler task throws an exception.
The exception code is now part of the logged message too.

Resolves: #80566
Releases: master, 7.6
Change-Id: Ic4eb25608094869733b4a23057d209fab1a1bccf
Reviewed-on: https://review.typo3.org/52286
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] FAL: Correctly iterate folder content with offset 75/52275/2
Markus Klein [Thu, 30 Mar 2017 22:06:58 +0000 (00:06 +0200)]
[BUGFIX] FAL: Correctly iterate folder content with offset

Whenever a list of files of a folder is queried with an offset
make sure we handle filtered files correctly by not taking them
into account when searching for the first eligible file for the
result.

A direct seek() to the start position is wrong as those first files
may contain files would be later on filtered.
The solution is to iterate the whole file list and only count
non-filtered elements to reach the correct starting point.

Releases: master, 7.6, 6.2
Resolves: #80589
Change-Id: I79a6d298599d31aa49c36fd51cc5bbe2cf2ccf3a
Reviewed-on: https://review.typo3.org/52275
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
2 years agoRevert "[BUGFIX] fix scheduler task logging in case of an Exception" 84/52284/2
Markus Klein [Fri, 31 Mar 2017 10:15:00 +0000 (11:15 +0100)]
Revert "[BUGFIX] fix scheduler task logging in case of an Exception"

This reverts commit 11deab5a29537490ed2b1492f9ac0ca0fb27465c.

Due to a wrong commit message this change is reverted.
There is no backport yet.

Change-Id: I3258a3aed4f1ec4ccb8a9cb9928d1876e6fd67ba
Resolves: #80566
Releases: master
Reviewed-on: https://review.typo3.org/52284
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] fix scheduler task logging in case of an Exception 79/52279/5
Christian Wolff [Fri, 31 Mar 2017 07:23:49 +0000 (09:23 +0200)]
[BUGFIX] fix scheduler task logging in case of an Exception

correctly Log the Message if a Schduler Task throws an Exception,
also the Exception code ins now Part of the Logged Message.

Resolves: #80566
Releases: master, 7.6
Change-Id: I177a52c17d5f40ce0a25418721d47ea9daa21881
Reviewed-on: https://review.typo3.org/52279
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Restyle Upgrade Analysis Panels 74/52274/3
Marco Christian Krenn [Thu, 30 Mar 2017 22:04:28 +0000 (00:04 +0200)]
[TASK] Restyle Upgrade Analysis Panels

Upgrade Analysis panel style changed to fit into the style guide.
Icons changed to check and ban.
Bootstrap Tooltip js added.

Resolves: #80588
Releases: master
Change-Id: Ib9a77ccee772904000e14cbea6da2f325a9f88de
Reviewed-on: https://review.typo3.org/52274
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Install tool dump autoload information with ajax 30/52230/9
Marc Wessels [Wed, 29 Mar 2017 09:07:33 +0000 (11:07 +0200)]
[TASK] Install tool dump autoload information with ajax

The 'Dump Autoload Information' buttons used a controller
action, improve usability by switching to an ajax call.

Resolves: #80543
Releases: master
Change-Id: I27e5cd65e611108692680d09e7710f0e1d1b3133
Reviewed-on: https://review.typo3.org/52230
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[FOLLOWUP][TASK] Restructure typolink tag generation 77/52277/2
Benni Mack [Thu, 30 Mar 2017 23:20:11 +0000 (01:20 +0200)]
[FOLLOWUP][TASK] Restructure typolink tag generation

The JSwindowParams was not initialized anymore at right place and is moved.

Additionally, the overhead for recurring aTagParams and URL has been moved outside
of the switch/case statement, as it was a leftover of the restructuring.

Resolves: #80586
Releases: master
Change-Id: Id8566227bb0884c7e487b236fbac534a2f15f550
Reviewed-on: https://review.typo3.org/52277
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update Fluid Styled Content documentation 76/52276/2
Benjamin Kott [Thu, 30 Mar 2017 22:49:06 +0000 (00:49 +0200)]
[TASK] Update Fluid Styled Content documentation

Resolves: #80051
Releases: master
Change-Id: I00c992e8e44759c14f27b91ace19290f3b57294d
Reviewed-on: https://review.typo3.org/52276
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Enhance install tool core update action 65/52265/6
Oliver Hader [Thu, 30 Mar 2017 14:35:21 +0000 (16:35 +0200)]
[TASK] Enhance install tool core update action

A missing typo3_src isn't necessary a warning,
so the warning is not shown during the first install step anymore.
If one doesn't have a linked source, the 'core update' action is disabled.

Change-Id: Ieea48f404f036edf1d75a3cfe41e6074ac1ad6c5
Resolves: #48999
Releases: master
Reviewed-on: https://review.typo3.org/52265
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Restructure typolink tag generation 76/51076/6
Benni Mack [Fri, 30 Dec 2016 22:23:43 +0000 (23:23 +0100)]
[TASK] Restructure typolink tag generation

Information for creating the target and the class information etc. is
spread through the main function. Putting everything in one place and
using an array for building the <a> tag seems to be more appropriate.

The functionality for building the tag could now be moved in to a
separate function in a next step. Alternative would be to move the
resolving of the "target" field into a separate method.

Resolves: #80586
Releases: master
Change-Id: I38d33b64d75abbae2ed541e16c44fac66ab03f2e
Reviewed-on: https://review.typo3.org/51076
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] List module does not work in workspaces with PostgreSQL 35/52235/3
Oliver Hader [Wed, 29 Mar 2017 10:45:45 +0000 (12:45 +0200)]
[BUGFIX] List module does not work in workspaces with PostgreSQL

Resolving a move-placeholder in the list-module using PostgreSQL does
not seem to be working and issues an SQL error. Rewriting the logic to
resolve the placeholder using QueryBuilder solves this problem.

Change-Id: Idbce178253cf60f4ef13a45c49fe23e15e26df1f
Resolves: #80550
Releases: master
Reviewed-on: https://review.typo3.org/52235
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix broken rst files in changelog folder 73/52273/2
Frank Naegler [Thu, 30 Mar 2017 21:26:19 +0000 (23:26 +0200)]
[BUGFIX] Fix broken rst files in changelog folder

Resolves: #80587
Releases: master
Change-Id: I3d841e1cbfd0eee47a1009489369951cdb4ed266
Reviewed-on: https://review.typo3.org/52273
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Improve rendering of long text 44/52144/3
Markus Sommer [Fri, 24 Mar 2017 14:56:50 +0000 (15:56 +0100)]
[BUGFIX] Improve rendering of long text

Resolves: #79670
Release: master
Change-Id: I63e0edc5785b1bb81fcaeb9009b0844056c922f0
Reviewed-on: https://review.typo3.org/52144
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][CLEANUP] Streamline backend toolbar items 70/52270/3
Daniel Goerz [Thu, 30 Mar 2017 18:16:08 +0000 (20:16 +0200)]
[FOLLOWUP][CLEANUP] Streamline backend toolbar items

Add missing closing brace in ClearCacheToolbarItemSingle.html

Change-Id: Ic17e40a6dd0780ee71d446209033fc78b658f720
Resolves: #80554
Releases: master
Reviewed-on: https://review.typo3.org/52270
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Deprecate TYPO3_CONF_VARS_extensionAdded 71/52271/3
Christian Kuhn [Thu, 30 Mar 2017 19:45:07 +0000 (21:45 +0200)]
[TASK] Deprecate TYPO3_CONF_VARS_extensionAdded

The global array $GLOBALS['TYPO3_CONF_VARS_extensionAdded'] is widely
unknown and of little use.
Deprecate it along with helper method
ExtensionManagementUtility::appendToTypoConfVars()

Change-Id: Ia21324bece77aefee05fc3ff96ad756c5a0f0a12
Resolves: #80583
Releases: master
Reviewed-on: https://review.typo3.org/52271
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Display edit metadata icon in filelist 79/52079/3
Gianluigi Martino [Fri, 17 Mar 2017 12:15:44 +0000 (13:15 +0100)]
[TASK] Display edit metadata icon in filelist

Editing metadata of a file is only possible by clicking the filename in
filelist. For editor is easier to find this function by clicking the edit
metadata icon in filelist control panel

Releases: master
Resolves: #80103
Change-Id: I0a7a1b96896c6bf6f3cb26cdcee3c819fc29d0d3
Reviewed-on: https://review.typo3.org/52079
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[TASK] Allow proper quoting of database identifiers in TypoScript 04/52204/5
Morton Jonuschat [Tue, 28 Mar 2017 03:40:12 +0000 (20:40 -0700)]
[TASK] Allow proper quoting of database identifiers in TypoScript

Add markup to TypoScript CONTENT object options dealing with database
fields so that SQL fragments can be created in a DBMS agnostic way
using the proper quoting for the active database.

Parsing in `sortBy` and `groupBy` is disabled as these parameters
already follow a stricter syntax that allow automatic parsing and
quoting.

Usage Example: `select.where = {#colPos}=0`

Change-Id: I95592b82de08e6cb6f9e952e6c456417878c23a8
Resolves: #80506
Releases: master
Reviewed-on: https://review.typo3.org/52204
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup and Redesign Upgrade Analysis 72/52172/21
Marco Christian Krenn [Mon, 27 Mar 2017 09:38:51 +0000 (11:38 +0200)]
[TASK] Cleanup and Redesign Upgrade Analysis

* removed unused variables from install.sass
* changes js to move entries from read to unread and the other way around
* add panel colors
* add risk levels
* fix old TER files

Resolves: #80465
Releases: master
Change-Id: I9dd6913c3c99df3e7b59cb7f3ea95b6d05918086
Reviewed-on: https://review.typo3.org/52172
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[TASK] Remove change 'encryption key' and 'site name' from Install Tool 45/52245/5
Marc Wessels [Wed, 29 Mar 2017 12:31:17 +0000 (14:31 +0200)]
[TASK] Remove change 'encryption key' and 'site name' from Install Tool

Important actions 'Change site name' is available in 'All configuration'
and has only been there for historical reasons.

'Change encryption key' can commit hazard to a system and shouldn't
be there as a casual button for non experienced users.

Resolves: #80553
Releases: master
Change-Id: I4751c394263d6d8185567b811816a14cdd82a515
Reviewed-on: https://review.typo3.org/52245
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FOLLOWUP][CLEANUP] Streamline backend toolbar items 63/52263/2
Benni Mack [Thu, 30 Mar 2017 13:31:53 +0000 (15:31 +0200)]
[FOLLOWUP][CLEANUP] Streamline backend toolbar items

Showing the composer mode label was not translated anymore while cleaning up.

Resolves: #80554
Releases: master
Change-Id: I61ad3087f10533b82870aedd4ee42d55d76d09e3
Reviewed-on: https://review.typo3.org/52263
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Allow to override PATH_site via environment variables 31/51331/10
Helmut Hummel [Mon, 16 Jan 2017 20:35:26 +0000 (21:35 +0100)]
[FEATURE] Allow to override PATH_site via environment variables

In order to make it possible to call TYPO3 from outside the document
root (e.g. CLI binaries) the patch allows to set TYPO3_PATH_ROOT via
environment variables.

This way it is possible to call binaries / external applications that
use the TYPO3 system environment builder.

The env variables are already set via the TYPO3 Console composer
plugin, and could also be incorporated in the composer-plugin of
the TYPO3 Core.

Resolves: #79343
Resolves: #79461
Releases: master
Change-Id: I078b050e35ef7de54744318386139859c2160a0b
Reviewed-on: https://review.typo3.org/51331
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Coalesce hook calls in DataHandler::processRemapStack() 52/51552/17
Thomas Hohn [Mon, 6 Feb 2017 11:01:25 +0000 (12:01 +0100)]
[BUGFIX] Coalesce hook calls in DataHandler::processRemapStack()

DataHandler's hook processDatamap_afterDatabaseOperations is processed
in two ways. In case modifications do not contain any new relation that
just has been created, the hook is executed directly. If that's not the
case, executing this hook is deferred and will happen after the remap
stack has been processed.

Calling the hook directly happens exactly once for each modified record,
where invocations in DataHandler::processRemapStack() might happen more
than once, depending on the amount of relation fields that contain new
references and have been remapped.

This change coalesces these invocations which results that the hooks
processDatamap_afterDatabaseOperations is exactly called once for each
modified record - which is the expected behavior.

Change-Id: Ib7e65ce170c8f9ba8f7577b79073b1ed9213a0b9
Resolves: #79635
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51552
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Place mixed tests at end of cObj test 37/52237/4
Elmar Hinz [Wed, 29 Mar 2017 11:36:32 +0000 (13:36 +0200)]
[TASK] Place mixed tests at end of cObj test

To not scatter the system of organising the test methods, create a
section for mixed tests at the very end of the test class.

Resolves: #80552
Releases: master
Change-Id: I56cda89055c79f492527fee6e29ba25426f5f996
Reviewed-on: https://review.typo3.org/52237
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[CLEANUP] Streamline backend toolbar items 09/51909/8
Benni Mack [Tue, 28 Feb 2017 20:13:38 +0000 (21:13 +0100)]
[CLEANUP] Streamline backend toolbar items

- Move everything to Fluid (also icon generation and labels)
- Remove a lot of get* shorthand protected methods
- Add PHP comments and remove PHP comments where applicable

Resolves: #80554
Releases: master
Change-Id: I9c417a02b2ac41fee95b815ee626ff44523c96f5
Reviewed-on: https://review.typo3.org/51909
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Improve wording in Install Tool 53/52253/4
Georg Ringer [Thu, 30 Mar 2017 03:48:51 +0000 (05:48 +0200)]
[TASK] Improve wording in Install Tool

- Fix typos
- Remove outdated text
- Wrap code into <code> tags

Resolves: #80563
Releases: master
Change-Id: Idfb65c294aaf62198d5581a89ab03b3678ab7ee1
Reviewed-on: https://review.typo3.org/52253
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FOLLOWUP][TASK] Unify TypoScript-related helper methods 52/52252/3
Frans Saris [Wed, 29 Mar 2017 19:50:36 +0000 (21:50 +0200)]
[FOLLOWUP][TASK] Unify TypoScript-related helper methods

Now the TypoScriptService is PHP strict we need to take care
the processed value is of the correct type.

Resolves: #78650
Releases: master
Change-Id: I1d79059c65676ce2e8126b6502c822d8b500379e
Reviewed-on: https://review.typo3.org/52252
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Prevent extbase persistance to try last_insert_id on relations 51/52251/3
Anja Leichsenring [Wed, 29 Mar 2017 18:39:02 +0000 (20:39 +0200)]
[BUGFIX] Prevent extbase persistance to try last_insert_id on relations

Postgres will fail with an error, if a table sequence is requested for
a table without auto_increment column. MySql will just return '0'.
Test the relation type before trying to persist mm relations to
prevent that error.

Resolves: #80562
Releases: master
Change-Id: Ia429e681a8ec1805996da03bd738b8347a00e40d
Reviewed-on: https://review.typo3.org/52251
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[!!!][BUGFIX] Resolve API based content element registration inconsistency 32/52132/10
Benjamin Kott [Wed, 22 Mar 2017 23:44:34 +0000 (00:44 +0100)]
[!!!][BUGFIX] Resolve API based content element registration inconsistency

To solve an inconsistency issue for API based content element
registration between CSS Styled Content (CSC) and Fluid Styled Content
(FSC) through `Extbase` or `addPItoST43` we are now Introducing a new
shared content object for content elements and drop the active usage of
lib.fluidContent.

The generated code relied on the existence of the removed lib.stdheader
and also ignored layouts, frames, spacebefore, spaceafter in context of
Fluid Styled Content.

For content element registration lib.contentElement is now used for CSC
and FSC and replaces the usage of lib.fluidContent. The generated code
was slightly adjusted to match the requirements of all content rendering
definitions and can be adapted to the specific needs of a content
element rendering definition anytime since a reference is used now
instead of a hard defintion.

Resolves: #80412
Resolves: #80095
Releases: master
Change-Id: I680a8968ad63774bc50a52f95ddb89d6f524dd15
Reviewed-on: https://review.typo3.org/52132
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Add TCA migration for columnsOverrides as well 89/52189/6
Helmut Hummel [Mon, 27 Mar 2017 16:27:26 +0000 (18:27 +0200)]
[BUGFIX] Add TCA migration for columnsOverrides as well

When migrating old TCA configuration to overrideChildTca,
we must respect columnsOverrides and do the migration there as well.

Also fix the examples for overriding cropVariants, which missed some
nesting levels

Resolves: #80493
Releases: master
Change-Id: If38f445e545b6f93eead5f30cfc16e787343b8c6
Reviewed-on: https://review.typo3.org/52189
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Unify TypoScript-related helper methods 89/50589/13
Benni Mack [Thu, 10 Nov 2016 23:30:26 +0000 (00:30 +0100)]
[TASK] Unify TypoScript-related helper methods

The method for OptionSplitting in TemplateService
is completely isolated from everything else, and creates
a very strong dependency to TSFE + TemplateService
in various places.

Additionally, the TypoScriptService of Extbase is used
in several places of the core and has nothing to do
with Extbase itself, thus, it can be moved to a central place
where these functions are called.

Moving this code to it's own service class in the core
helps to decouple TSFE, tmpl, Extbase and cObject more.

Resolves: #78650
Releases: master
Change-Id: I712c77c383171e93053caff0f89af8d1247f6d86
Reviewed-on: https://review.typo3.org/50589
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Upgrade wizard for form_legacy 49/52249/5
Christian Kuhn [Wed, 29 Mar 2017 12:56:33 +0000 (14:56 +0200)]
[TASK] Upgrade wizard for form_legacy

Upgrades wizard scans tt_content for not deleted 'mailform' content
elements and offers to download and install old extjs based form
extension called 'form_legacy' from TER, it's git is
located at https://github.com/FriendsOfTYPO3/form_legacy

Change-Id: Ic183c00a7b54ada57cce280f558f1b502e318dda
Resolves: #79733
Releases: master
Reviewed-on: https://review.typo3.org/52249
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Unify element- and linkbrowser styling 70/52170/11
Benjamin Kott [Mon, 27 Mar 2017 03:02:00 +0000 (05:02 +0200)]
[TASK] Unify element- and linkbrowser styling

Introducing a more adaptive and inclusive experience to the element-
and linkbrowser.

Resolves: #80463
Resolves: #80205
Releases: master
Change-Id: I78d631dbf3ea206c78d65c6e4d3a60ab984fa1c9
Reviewed-on: https://review.typo3.org/52170
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] JS: Fix FormEngine initialization 80/52180/7
Markus Klein [Mon, 27 Mar 2017 13:51:07 +0000 (15:51 +0200)]
[BUGFIX] JS: Fix FormEngine initialization

The FormEngine initialization process needs to be very careful
when the DOM is accessed.
This patch separates the routines and encapsulates those in
a DOMready handler, which are critical.

This solves a possible race condition when JS is executed faster
than DOM is built.

Releases: master, 7.6
Resolves: #80481
Resolves: #80366
Change-Id: I205aebc9f87a25f06942f923497f7f535fdb0c8f
Reviewed-on: https://review.typo3.org/52180
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Tested-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Fix wrong codeblock type in rst files 34/52234/2
Frank Naegler [Wed, 29 Mar 2017 10:33:54 +0000 (12:33 +0200)]
[BUGFIX] Fix wrong codeblock type in rst files

Resolves: #80403
Releases: master
Change-Id: I95e6e029723ba43d2af0690e835d447b1d6756ef
Reviewed-on: https://review.typo3.org/52234
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] EXT:form - set maximum field length as attribute "maxlength" 24/52224/3
Martin Kutschker [Tue, 28 Mar 2017 20:19:15 +0000 (20:19 +0000)]
[BUGFIX] EXT:form - set maximum field length as attribute "maxlength"

Also set minimum field length as attribute "minlength"

Resolves: #80126
Resolves: #80128
Releases: master
Change-Id: I1649dae4098f2b5f4ae1d99e3550c07bfc9af12a
Reviewed-on: https://review.typo3.org/52224
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jurian Janssen <jurian.janssen@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Update ConsoleOutput functions to new Symfony console 49/51949/3
Jigal van Hemert [Sat, 4 Mar 2017 07:58:38 +0000 (08:58 +0100)]
[BUGFIX] Update ConsoleOutput functions to new Symfony console

Symfony's Question and ChoiceQuestion define maxAttempts as null|int
with null as default. The ConsoleOutput functions are adjusted accordingly
to prevent an exception from being thrown.

Resolves: #80053
Releases: master
Change-Id: I0e23b8f6e3ff875f14a8f081059e869142ab5aa4
Reviewed-on: https://review.typo3.org/51949
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Database install tool driver selection 77/51977/37
Mona Muzaffar [Tue, 7 Mar 2017 15:01:53 +0000 (16:01 +0100)]
[TASK] Database install tool driver selection

Re-implement postgres connect.

Change-Id: Iba0c1c1316c0b473173b08889f213831edbfab65
Resolves: #80173
Releases: master
Reviewed-on: https://review.typo3.org/51977
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix not showing remaining characters count in IRRE element 26/52226/2
Wouter Wolters [Tue, 28 Mar 2017 21:11:22 +0000 (23:11 +0200)]
[BUGFIX] Fix not showing remaining characters count in IRRE element

When opening a record that has a closed IRRE element, the remaining
characters count is not initialized at all. Reinitialize this correctly
now by filtering out the already processed counters.

Resolves: #80470
Releases: master
Change-Id: I1f0f675ea968e1959f610fbfbdf236d843c1fd11
Reviewed-on: https://review.typo3.org/52226
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Deprecate GraphicalFunctions->tempPath and createTempSubDir() 12/52212/4
Benni Mack [Tue, 28 Mar 2017 11:02:11 +0000 (13:02 +0200)]
[TASK] Deprecate GraphicalFunctions->tempPath and createTempSubDir()

The short-hand functionality within GraphicalFunctions to create a
sub directory inside the hard-coded tempPath is a simple wrapper
of GeneralUtility::mkdir_deep().

The according change deprecates both the property $tempPath
and the method createTempSubDir().

Resolves: #80514
Releases: master
Change-Id: Ie0f0ac017e979ab67820182d16d7a4ebbc2fd4e4
Reviewed-on: https://review.typo3.org/52212
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use ajax call in Install tool 'clear all cache' 18/52218/6
Marc Wessels [Tue, 28 Mar 2017 15:22:45 +0000 (17:22 +0200)]
[TASK] Use ajax call in Install tool 'clear all cache'

The 'clear all cache' buttons is switche to an ajax action
to be more conveniently used.

Resolves: #80525
Releases: master
Change-Id: I3f8c49308c185f5855fe3d393c3874c21f144e8b
Reviewed-on: https://review.typo3.org/52218
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Deprecate GIFbuilder-related methods in ContentObjectRenderer 23/52223/2
Benni Mack [Tue, 28 Mar 2017 19:36:38 +0000 (21:36 +0200)]
[TASK] Deprecate GIFbuilder-related methods in ContentObjectRenderer

The following methods within ContentObjectRenderer (cObj) have been marked
as deprecated as all logic related to that have been moved to GifBuilder.

* clearTSProperties()
* gifBuilderTextBox()
* linebreaks()

Resolves: #80532
Releases: master
Change-Id: I064b0b22c944894ec358d95d50a4be72969a7567
Reviewed-on: https://review.typo3.org/52223
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Mark cObj method getWhere as deprecated 22/52222/3
Benni Mack [Tue, 28 Mar 2017 19:30:28 +0000 (21:30 +0200)]
[TASK] Mark cObj method getWhere as deprecated

When deprecating the method $cObj->getWhere() during the Doctrine
migration, it was forgotten to add a message to log the deprecated
function to the deprecation log.

The patch adds that.

Resolves: #80531
Releases: master
Change-Id: I7401116af35eca57cd01b5e7fb757834e9de905a
Reviewed-on: https://review.typo3.org/52222
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Add unit test to cover prefixComment 19/52219/6
Elmar Hinz [Tue, 28 Mar 2017 15:58:26 +0000 (17:58 +0200)]
[TASK] Add unit test to cover prefixComment

Add unit test to cover ContentObjectRenderer::prefixComment

Resolves: #80526
Releases: master
Change-Id: I37e89ecfdb2cea2f9290eced97337c0019e78ba9
Reviewed-on: https://review.typo3.org/52219
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Remove last mentions of Less in the core 21/52221/2
Wouter Wolters [Tue, 28 Mar 2017 18:36:45 +0000 (20:36 +0200)]
[TASK] Remove last mentions of Less in the core

Resolves: #80529
Releases: master
Change-Id: Ic90bf297baad33576509f9ff13ab67674ba658ac
Reviewed-on: https://review.typo3.org/52221
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[BUGFIX] Avoid calculating crop areas, when files have no size 92/52192/2
Helmut Hummel [Mon, 27 Mar 2017 17:09:29 +0000 (19:09 +0200)]
[BUGFIX] Avoid calculating crop areas, when files have no size

When file relations are added, the crop area of these is calculated,
even if they are not images.

We avoid that by only doing this processing, when the file
has a width property.

Resolves: #80071
Releases: master
Change-Id: I42924b271e5a6697d35ffb7d5f322f555139ec57
Reviewed-on: https://review.typo3.org/52192
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Remove deprecated localizationMode setting for file fields 01/52201/3
Oliver Hader [Mon, 27 Mar 2017 21:54:06 +0000 (23:54 +0200)]
[TASK] Remove deprecated localizationMode setting for file fields

The current behavior for file fields using TCA type inline is configured
to use localizationMode=select, which is deprecated. Actually files have
been copied along during the localization of the parent record - and
files can then be defined independently for the default language record
and in the translated record. The localizationMode synchronization
behavior was disabled in the user-interface.

With this change the default core behavior will stay the same. If the
localization buttons would have been enabled individually, this now can
be done with the more specific allowLanguageSynchronization feature.

Change-Id: I88668e3d0ce1dd192d32b93f0312796c59d62358
Resolves: #80504
Releases: master
Reviewed-on: https://review.typo3.org/52201
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Use direct array assignments instead of array_push 49/52049/4
Cedric Ziel [Wed, 15 Mar 2017 09:36:14 +0000 (10:36 +0100)]
[TASK] Use direct array assignments instead of array_push

Direct assignments are usually 2x faster and often more readable
when pushing one value only.

Releases: master
Fixes: #80283
Change-Id: I16fc1938f74550d1a3d9f9c0cbafe85dc2ff1c5b
Reviewed-on: https://review.typo3.org/52049
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move all marker-based logic from cObj to MarkerBasedTemplateService 20/52220/2
Benni Mack [Tue, 28 Mar 2017 15:21:02 +0000 (17:21 +0200)]
[TASK] Move all marker-based logic from cObj to MarkerBasedTemplateService

Now, all functionality for marker-based templates are encapsulated in
MarkerBasedTemplateService, instead of polluting cObjectRenderer which
is used a lot in the frontend, even though no markers are in use.

All methods within ContentObjectRenderer have been marked as deprecated.

Resolves: #80527
Releases: master
Change-Id: If7a27281470935af893d1a9838f06ca77a3041c1
Reviewed-on: https://review.typo3.org/52220
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Deprecate config.setJS_mouseOver and config.setJS_openPic 13/52213/3
Benni Mack [Tue, 28 Mar 2017 11:08:37 +0000 (13:08 +0200)]
[TASK] Deprecate config.setJS_mouseOver and config.setJS_openPic

The TypoScript properties config.setJS_mouseOver and config.setJS_openPic
have been marked as deprecated.

Resolves: #80516
Releases: master
Change-Id: Ida5de8b3e873adfe7e27decf6e43813e7dc5cc2e
Reviewed-on: https://review.typo3.org/52213
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate DocumentTemplate->extJScode property 10/52210/2
Benni Mack [Tue, 28 Mar 2017 10:34:00 +0000 (12:34 +0200)]
[TASK] Deprecate DocumentTemplate->extJScode property

The public property DocumentTemplate->extJScode can be used to fill in
ExtJS-specific code to be loaded on "onExtReady". The functionality is not
used in the core anymore, as there are better ways to include JavaScript
code in a backend response.

Resolves: #80512
Releases: master
Change-Id: I4cf24f6b096a79d76e1d30f587f25dcc8ca10fa4
Reviewed-on: https://review.typo3.org/52210
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate DataHandler->destPathFromUploadFolder() 11/52211/2
Benni Mack [Tue, 28 Mar 2017 10:52:16 +0000 (12:52 +0200)]
[TASK] Deprecate DataHandler->destPathFromUploadFolder()

The method in DataHandler->destPathFromUploadFolder is basically
useless nowadays and should be avoided, since it just prepends PATH_site
to a string.

The fourth parameter for extFileFunctions() is also useless as the method
only is triggered for "deleteAll" and no other value is allowed.

Resolves: #80513
Releases: master
Change-Id: I371fd9233bbe63dd2d3775e4ddd8212358164ced
Reviewed-on: https://review.typo3.org/52211
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate PageRepository::setHash and storeHash 17/52217/2
Benni Mack [Tue, 28 Mar 2017 14:49:40 +0000 (16:49 +0200)]
[TASK] Deprecate PageRepository::setHash and storeHash

The two static methods are sole wrappers for the Caching Framework nowadays
which can simply be dealt with in a custom way.

Use the Caching Framework directly instead!

Resolves: #80524
Releases: master
Change-Id: I8fced0800a2c72705f1a01e0a3d6e52aeaf5daef
Reviewed-on: https://review.typo3.org/52217
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Do not rely on sys_page when storing cached data in cObj 81/52181/3
Benni Mack [Mon, 27 Mar 2017 13:53:17 +0000 (15:53 +0200)]
[TASK] Do not rely on sys_page when storing cached data in cObj

ContentObject renderer has an unnecessary call to $TSFE->sys_page
for calling a static method in a non-static way.

It should directly use the caching framework instead.

Resolves: #80482
Releases: master
Change-Id: Iaa93de3c1e98cf5e639605dcf49cb5715a28b5d7
Reviewed-on: https://review.typo3.org/52181
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Do not mis-use sys_page for using cache_hash in ExtDirectApi 14/52214/2
Benni Mack [Tue, 28 Mar 2017 11:14:38 +0000 (13:14 +0200)]
[TASK] Do not mis-use sys_page for using cache_hash in ExtDirectApi

The ExtDirectApi simply calls PageRepository to store data in the "cache_hash"
cache. This can be simplified by just using the Caching Framework directly
without depending on a EXT:frontend class in a EXT:core class.

Resolves: #80517
Releases: master
Change-Id: I77825bf71264621fb984b39f79009baf71cfdec3
Reviewed-on: https://review.typo3.org/52214
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Finetune avatar size in backend toolbar 98/52198/4
Benjamin Kott [Mon, 27 Mar 2017 20:40:40 +0000 (22:40 +0200)]
[TASK] Finetune avatar size in backend toolbar

Resolves: #80501
Releases: master
Change-Id: I5371b546bb7ebffdfc78a5bbfe1b86699a4f4a43
Reviewed-on: https://review.typo3.org/52198
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Deprecate AbstractFunctionModule->incLocalLang() 09/52209/4
Benni Mack [Tue, 28 Mar 2017 10:17:14 +0000 (12:17 +0200)]
[TASK] Deprecate AbstractFunctionModule->incLocalLang()

Loading a locallang.xlf inside the abstract function module now uses the regular
$GLOBALS['LANG']->includeLLFile() of the current file, instead of doing a manual
check on .xml and .php extensions, which the LanguageService/LanguageFactory
is taking care of anyway.

The PHP method incLocalLang() and the now not necessarily needed $thisPath
are therefore marked as deprecated.

Resolves: #80511
Releases: master
Change-Id: I3a9d27bf794a4cd8c1f2d31ed9250d634aa68ee8
Reviewed-on: https://review.typo3.org/52209
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Replace clearable icon with SVG from TYPO3 icon set 95/52195/6
Benjamin Kott [Mon, 27 Mar 2017 19:53:54 +0000 (21:53 +0200)]
[TASK] Replace clearable icon with SVG from TYPO3 icon set

Resolves: #80498
Releases: master
Change-Id: I139922f0bb86e1ff1dc4bd9258491bd5eedaedc2
Reviewed-on: https://review.typo3.org/52195
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Check correct variable in BrowseLinksController 05/52205/3
Christer Vindberg [Tue, 28 Mar 2017 07:10:31 +0000 (09:10 +0200)]
[BUGFIX] Check correct variable in BrowseLinksController

Make sure to check the correct variable classesAnchorDefaultTitle
when fetching the title of anchors.

This affects CKeditor as well as htmlarea.

Resolves: #80209
Releases: master, 7.6
Change-Id: I1cdd760ee1fe2879ac53edff38f25515d656d706
Reviewed-on: https://review.typo3.org/52205
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Add preset for mail SMTP settings in install tool 67/52167/8
Frank Naegler [Sun, 26 Mar 2017 13:35:20 +0000 (15:35 +0200)]
[TASK] Add preset for mail SMTP settings in install tool

The current mail presets only allow to modify sendmail
settings, but it's not possible to configure SMTP settings.

Resolves: #80457
Releases: master
Change-Id: Ib70351c9048c0ceec2b2a585d43a3ad04c81424e
Reviewed-on: https://review.typo3.org/52167
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Deprecate cObj->URLqMark 82/52182/3
Benni Mack [Mon, 27 Mar 2017 14:03:54 +0000 (16:03 +0200)]
[TASK] Deprecate cObj->URLqMark

The method cObject->URLqMark() adds a question mark to a string
to append it. This method should not be in scope of cObject, but rather
be put in e.g. StringUtility or GeneralUtility... however, since the functionality
is rather simple, it can be achieved without any helper method as a one-liner.

Resolves: #80510
Releases: master
Change-Id: I5230c5a4e27f8ef198190defd15598023279c1c2
Reviewed-on: https://review.typo3.org/52182
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Ensure module menu is correctly closed after click on overlay 99/52199/4
Benjamin Kott [Mon, 27 Mar 2017 20:55:30 +0000 (22:55 +0200)]
[BUGFIX] Ensure module menu is correctly closed after click on overlay

Resolves: #80502
Releases: master
Change-Id: I01cac3870381c1783e0a1bb1226c0ab537619455
Reviewed-on: https://review.typo3.org/52199
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Streamline return tags in phpdocs 86/51686/12
Wouter Wolters [Tue, 14 Feb 2017 20:08:46 +0000 (21:08 +0100)]
[TASK] Streamline return tags in phpdocs

The TYPO3 Core currently has no guidline how to handle phpdoc
comments regarding @return annoations related to "void" and "null".

In practice, these annotations have no additional value if no additional
documentation is given.

With this change, the php-cs-fixer will remove any unnecessary linebreaks
within the comments above the @return annotation, as well as remove completely
empty phpdoc comments because the @return annotation is removed.

Please be aware, that once PSR-5 is accepted, this coding standard
within the TYPO3 Core will change again, where there are currently
some further proposal details like inheritance information.

Resolves: #80454
Releases: master
Change-Id: Ie969d720684c0a75919fe5addd1c36ef5b12eb04
Reviewed-on: https://review.typo3.org/51686
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix position of carets in accordions in install tool 06/52206/4
Frank Naegler [Tue, 28 Mar 2017 07:59:16 +0000 (09:59 +0200)]
[BUGFIX] Fix position of carets in accordions in install tool

Resolves: #80507
Releases: master
Change-Id: I5494a9a61829d6245fa2410c3bafe8c6bc4a9043
Reviewed-on: https://review.typo3.org/52206
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Use correct property for images in FrontendUser 46/52146/2
Georg Ringer [Sat, 25 Mar 2017 09:52:57 +0000 (10:52 +0100)]
[BUGFIX] Use correct property for images in FrontendUser

As the image field has been changed to FAL, also the model must
be adopted.

Resolves: #80437
Releases: master
Change-Id: I09b6ef8db190467ee5dfea67e5e66ded12b99dcd
Reviewed-on: https://review.typo3.org/52146
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Nikolai Townsend <info@nikolaitownsend.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Streamline indexed_search template files 19/52119/3
Benjamin Kott [Wed, 22 Mar 2017 10:02:50 +0000 (11:02 +0100)]
[TASK] Streamline indexed_search template files

For a more streamlined rendering this patch adds nessesary html tags
with fluid namespaces to all indexed_search templates, unifies indention
and adds an empty space before closing bracket of self-closing tags.

Resolves: #80392
Releases: master
Change-Id: Ia6bc46c8fb602b4f3592094ad963691bbf412d7d
Reviewed-on: https://review.typo3.org/52119
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Header should not disappear when page is dropped to trash 83/52183/4
Benjamin Kott [Mon, 27 Mar 2017 14:05:45 +0000 (16:05 +0200)]
[BUGFIX] Header should not disappear when page is dropped to trash

Resolves: #80484
Releases: master
Change-Id: Ie17a8cc5cb118c9ecd381355b96d9e60cd278712
Reviewed-on: https://review.typo3.org/52183
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Add proper comments to PHP code 00/52200/3
Benni Mack [Mon, 27 Mar 2017 20:58:56 +0000 (22:58 +0200)]
[TASK] Add proper comments to PHP code

There are some places where PHP comments have been done wrong (using doccomments)
or where there is no comment at all.

Resolves: #80503
Releases: master
Change-Id: Ib12d3b82755d801abcbefe7127f1189239f766af
Reviewed-on: https://review.typo3.org/52200
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Use SVG Icons for permission actions 02/52202/2
Benjamin Kott [Mon, 27 Mar 2017 22:02:28 +0000 (00:02 +0200)]
[TASK] Use SVG Icons for permission actions

Resolves: #80505
Releases: master
Change-Id: I8188f7c9c63776a41a2f4e5c5077139e55312281
Reviewed-on: https://review.typo3.org/52202
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Cleanup Localization Charset code 85/52185/3
Benni Mack [Mon, 27 Mar 2017 14:27:48 +0000 (16:27 +0200)]
[TASK] Cleanup Localization Charset code

The protected property "AbstractXmlParser->charset" is set from
the outside but never used anymore in either the abstract class nor
in the subclasses.

The protected method "getCharset()" is basically useless:
a) it's never called or in use
b) it has nothing to do with the XmlParser as it does not work
with any properties / functionalities of the XmlParser itself.

The protected method "initialize()" is called solely in the
contructor which can be dealt with directly in the constructor
(that's what a constructor is there for).

The third parameter $charset within getParsedData() is
now not needed anymore within the Parsers, as all expect
UTF-8 for files.

Resolves: #80486
Releases: master
Change-Id: I929c3960fb5b94f5448a2d29f4a73fbb5d81a500
Reviewed-on: https://review.typo3.org/52185
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] EXT:form - make 'grid rows' independent from 'grid containers' 66/52166/5
Ralf Zimmermann [Sun, 26 Mar 2017 10:54:07 +0000 (12:54 +0200)]
[TASK] EXT:form - make 'grid rows' independent from 'grid containers'

* Create 'grid rows' without 'grid container' wrappers
* Disable 'grid containers' within the form editor by default
  because twitter bootstrap prohibits container nesting

Resolves: #80455
Releases: master
Change-Id: I3997943858ac3b235094b765697f724cb1e4c95d
Reviewed-on: https://review.typo3.org/52166
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Restore highlighting of livesearch box 96/52196/2
Benjamin Kott [Mon, 27 Mar 2017 20:29:46 +0000 (22:29 +0200)]
[BUGFIX] Restore highlighting of livesearch box

Resolves: #80499
Releases: master
Change-Id: I820ac450c5bd32c9d992dcfd39983b20c304799f
Reviewed-on: https://review.typo3.org/52196
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Deprecate TSFE->whichWorkspace parameter 84/52184/3
Benni Mack [Mon, 27 Mar 2017 14:13:27 +0000 (16:13 +0200)]
[TASK] Deprecate TSFE->whichWorkspace parameter

The parameter of the $TSFE->whichWorkspace() method decides
whether the UID of the current workspace should be returned or
the actual "title" of the sys_workspace record.

As this parameter is not in use anymore and clearly makes this function
harder to understand why and when someone could use this, this property
is marked as deprecated.

Instead, fetching the workspace title should happen in the place where it
is needed.

Resolves: #80485
Releases: master
Change-Id: I06512e40c48b35826c0d0a89cc8c4cdcdc8773e6
Reviewed-on: https://review.typo3.org/52184
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Integrate tests for DataHandler hook invocations 90/52190/2
Oliver Hader [Mon, 27 Mar 2017 16:28:02 +0000 (18:28 +0200)]
[TASK] Integrate tests for DataHandler hook invocations

Change-Id: I69beabad3e4b9419778d1ed7d1b181349089b139
Resolves: #80494
Releases: master
Reviewed-on: https://review.typo3.org/52190
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Avoid live ID processing if EXT:version not loaded 70/50970/7
Thomas Hohn [Tue, 13 Dec 2016 20:08:07 +0000 (21:08 +0100)]
[BUGFIX] Avoid live ID processing if EXT:version not loaded

DataHandler does not need to force "live ID" processing to
be enabled on RelationHandler when EXT:version is not loaded.

Avoiding this saves some semi-expensive operations inside
the RelationHandler class.

Resolves: #78998
Releases: master
Change-Id: If53cdd73db15352d6f4854a5aef4b407836cb6ce
Reviewed-on: https://review.typo3.org/50970
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Do not allow dots in ratio IDs 94/52194/2
Helmut Hummel [Mon, 27 Mar 2017 18:01:04 +0000 (20:01 +0200)]
[BUGFIX] Do not allow dots in ratio IDs

Due to usage of Fluid dynamic variable parts in the template,
ratio IDs must not contain a "."

Resolves: #80214
Releases: master
Change-Id: I12dac926169c827c9e3022320dd90a058f72913b
Reviewed-on: https://review.typo3.org/52194
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Cleanup BE user authentication in Frontend 77/52177/3
Benni Mack [Mon, 27 Mar 2017 13:44:52 +0000 (15:44 +0200)]
[TASK] Cleanup BE user authentication in Frontend

The Frontend Controller (TSFE) does some initialization which
should belong to the FrontendBackendUserAuthentication directly.

Additionally, some further code cleanups are made for this area.

Resolves: #80479
Releases: master
Change-Id: I32d9c98bb511f1eaa1f56203c4678358107aa7bc
Reviewed-on: https://review.typo3.org/52177
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Extbase should not use deprecated CLI admin role methods 88/52188/3
Benni Mack [Mon, 27 Mar 2017 16:15:26 +0000 (18:15 +0200)]
[BUGFIX] Extbase should not use deprecated CLI admin role methods

Resolves: #80492
Releases: master
Change-Id: Id835329586bf0fa315dc46377bc195ace005da61
Reviewed-on: https://review.typo3.org/52188
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Do not rely on sys_page cache shortcut for fetching TSconfig 79/52179/2
Benni Mack [Mon, 27 Mar 2017 13:47:40 +0000 (15:47 +0200)]
[TASK] Do not rely on sys_page cache shortcut for fetching TSconfig

The TypoScript Frontend Controller has a unnecessary dependency
to a static call (which is made non-static !) of PageRepository
which can be done exactly 1:1 by instantiating the cacheManager
and fetching the "cache_hash" cache directly by storing and fetching
the contents itself.

Resolves: #80480
Releases: master
Change-Id: If6f5976a6c07ea754915b9c612264d733a6b1a41
Reviewed-on: https://review.typo3.org/52179
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>