Packages/TYPO3.CMS.git
5 years ago[BUGFIX] MySQL: Use ENGINE (not TYPE) for storage-engine 98/22798/2
Stefan Neufeind [Sat, 3 Aug 2013 22:44:07 +0000 (00:44 +0200)]
[BUGFIX] MySQL: Use ENGINE (not TYPE) for storage-engine

Using TYPE is deprecated since a MySQL 4.x and was removed in MySQL
5.5. Core already uses ENGINE but SqlParser turned that into TYPE,
leading to errors.

From https://dev.mysql.com/doc/refman/5.0/en/storage-engines.html:
"The older term TYPE is supported as a synonym for ENGINE for
backward compatibility, but ENGINE is the preferred term and TYPE
is deprecated."

Change-Id: I6607d3e726c43cb74ca00f33ec2332de4f6a76d8
Resolves: #50466
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22798
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Syntax error in class.tx_coreupdates_t3skin.php 96/22796/2
Wouter Wolters [Tue, 30 Jul 2013 12:18:00 +0000 (14:18 +0200)]
[BUGFIX] Syntax error in class.tx_coreupdates_t3skin.php

Fix Syntax Problem: Cannot use [] for reading

Change-Id: I9f5be90dbc9aa55475049bd8a8720cab0c321af4
Resolves: #35274
Releases: 4.7, 4.5
Reviewed-on: https://review.typo3.org/22796
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix fatal error in extension manager 56/22656/2
Michael Stucki [Mon, 29 Jul 2013 12:16:23 +0000 (14:16 +0200)]
[BUGFIX] Fix fatal error in extension manager

TER extensions which were uploaded just recently contain a change in
ext_emconf.php. This change conflicts with older TYPO3 releases:

If the extension has no conflicts, the constraint is written as an empty
string although it is expected to be an array in any case.

This fix adds a check to work around the problem.

Change-Id: Ibb361f82c39d99089ec6455935ddc3e775cebbc7
Resolves: #46642
Releases: 4.7, 4.5
Reviewed-on: https://review.typo3.org/22656
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Provide information about import action in TCEmain to hooks 45/22645/2
Stefan Galinski [Tue, 27 Nov 2012 01:31:50 +0000 (02:31 +0100)]
[TASK] Provide information about import action in TCEmain to hooks

While importing T3D files the TCEmain currently fires the required
processing on records just as if the editor is generating the records. If
extensions hook into TCEmain, there is no way to differenciate this
situation from the regular editing mode - which might provide unexpected
results, i.e. wrong IRRE relations.

Solution is to provide a boolean to indicate that TCEmain has been called
during an import action which extensions could use to recognize this
situation.

Change-Id: I4fe429fb88f8ec24a7fda885f38ddfbdb4a642f5
Resolves: #36031
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/22645
Reviewed-by: Jo Hasenau
Tested-by: Jo Hasenau
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Set TYPO3 version to 4.5.30-dev 14/22714/2
TYPO3 Release Team [Tue, 30 Jul 2013 12:43:01 +0000 (14:43 +0200)]
[TASK] Set TYPO3 version to 4.5.30-dev

Change-Id: If965931f73498172f9950382421c293ae417afd2
Reviewed-on: https://review.typo3.org/22714
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 4.5.29 13/22713/2 TYPO3_4-5-29
TYPO3 Release Team [Tue, 30 Jul 2013 12:42:36 +0000 (14:42 +0200)]
[RELEASE] Release of TYPO3 4.5.29

Change-Id: I51cad328946686b1aa0bb37a2c8744f77794fcb4
Reviewed-on: https://review.typo3.org/22713
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[SECURITY] XSS in 3rd party library Audio Player 01/22701/2
Oliver Hader [Tue, 30 Jul 2013 12:38:01 +0000 (14:38 +0200)]
[SECURITY] XSS in 3rd party library Audio Player

Update player.swf of version 2.0.4.6 from
http://wordpress.org/plugins/audio-player/

Change-Id: Ib9ba8c7f02279c42d619154b9b79cc38a8e2c41b
Fixes: #49210
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Security-Commit: 75b52f4080952e25b4387f3e9665f01803184591
Security-Bulletin: TYPO3-CORE-SA-2013-002
Reviewed-on: https://review.typo3.org/22701
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Fix double-stdWrapping of GIFBUILDER's TEXT object 32/20532/3
jyps [Sun, 5 May 2013 15:07:53 +0000 (17:07 +0200)]
[BUGFIX] Fix double-stdWrapping of GIFBUILDER's TEXT object

During extensive overhaul of stdWrap from TYPO3 v4.4 to v4.5 a
bug was introduced that led to double-stdWrapping of all
properties of GIFBUILDER's TEXT object.

Change-Id: Ib74fdc9899f3d0ee3f6fc96ffbb9c7dbc3ee01e2
Fixes: #41487
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/20532
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Remove empty .gitmodules file 17/22617/2
Christian Kuhn [Fri, 26 Jul 2013 21:02:46 +0000 (23:02 +0200)]
[TASK] Remove empty .gitmodules file

With removal of git submodules the .gitmodules file is empty
and can be removed now.

Change-Id: I453f63c0852825b46e9ea62f87385d9eace25134
Resolves: #50480
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22613
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 643f2e9cef2e7997e2c7ae5b8d8bbf279d9983c1)
Reviewed-on: https://review.typo3.org/22617

5 years ago[TASK] Revise typo3/sysext/README.txt 59/22559/2
Wouter Wolters [Wed, 24 Jul 2013 18:00:47 +0000 (20:00 +0200)]
[TASK] Revise typo3/sysext/README.txt

* Replace GIT repository link with the new one
* Remove information about submodules

Change-Id: I60db762ce831c7edea413d9f7780a5617b7f9e96
Resolves: #50410
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22559
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Set TYPO3 version to 4.5.29-dev 25/22525/2
TYPO3 Release Team [Tue, 23 Jul 2013 17:58:55 +0000 (19:58 +0200)]
[TASK] Set TYPO3 version to 4.5.29-dev

Change-Id: I73ac008099c789255f184785e52069d26764a03f
Reviewed-on: https://review.typo3.org/22525
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 4.5.28 24/22524/2 TYPO3_4-5-28
TYPO3 Release Team [Tue, 23 Jul 2013 17:58:31 +0000 (19:58 +0200)]
[RELEASE] Release of TYPO3 4.5.28

Change-Id: I60233a700dd013cc905f9b19bc5abf9d0b8cf26a
Reviewed-on: https://review.typo3.org/22524
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] Page within a mountpoint using Show Content from Page fatals 37/12837/5
Patrick [Mon, 5 Dec 2011 09:00:31 +0000 (10:00 +0100)]
[BUGFIX] Page within a mountpoint using Show Content from Page fatals

When pages:content_from_pid is used, the TSFE for the current object
will be cloned to a temporary object for the page to get the content
from.  In this temporary object, the id for the page will be changed to
the contents of content_from_pid.  However, the MP variable will not be
changed.

This results in a TSFE object with the wrong MP variable connected to
the id.  Within this temporary object the rootline will be calculated,
which will be empty, because of the wrong MP variable.  This triggers
"The requested page didn't have a proper connection to the tree-root"

This bugfix fixes this by emptying the MP variable.

Change-Id: I56fc25924a1766d2befaffee8abbed5466a04942
Fixes: #32292
Releases: 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/12837
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] PHP Module pgsql not supported 89/21089/2
Nicole Cordes [Tue, 20 Nov 2012 16:42:03 +0000 (17:42 +0100)]
[BUGFIX] PHP Module pgsql not supported

On some systems (e.g. current Debian system) the module for PostgreSQL is
called pgsql instead of postgres. So this has to be added to the module
list.

Change-Id: Id55170cefef6df32ae616c05696bec8fa59b9cb2
Fixes: #43163
Releases: 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21089
Reviewed-by: Stefan Neufeind
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] stdWrap for special.value applied twice 39/21739/2
Markus Klein [Sat, 29 Jun 2013 20:24:30 +0000 (22:24 +0200)]
[BUGFIX] stdWrap for special.value applied twice

In HMENU the stdWrap for special.value is applied twice.
This patches removes the superfluous call
in HierarchicalMenuContentObject.php.

Furthermore it also moves the stdWrap for excludeUidList
to AbstractMenuContentObject.php for consistency reasons.

Change-Id: Ia6594a76602acdab8b39d50803595343e65f6d02
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Fixes: #40855
Reviewed-on: https://review.typo3.org/21739
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix PHP warning trigged in initFEuser 41/22341/2
Markus Klein [Mon, 15 Jul 2013 18:32:18 +0000 (20:32 +0200)]
[BUGFIX] Fix PHP warning trigged in initFEuser

TypoScriptFrontendController::initFEuser() calls
$GLOBALS['TYPO3_DB']->cleanIntList() with a possible NULL argument.
This leads to a PHP warning in GeneralUtility::trimExplode().

Resolves: #42921
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Id33ee8fe5e4177716af6ce8c9084e098b86c280c
Reviewed-on: https://review.typo3.org/22341
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] requestUpdate sensitive to spaces 13/22313/2
Markus Klein [Mon, 15 Jul 2013 07:37:58 +0000 (09:37 +0200)]
[BUGFIX] requestUpdate sensitive to spaces

The TCA property "requestUpdate" is sensitive to spaces, although this
is documented nowhere. Indeed "foo1, foo2" will not work whereas
"foo1,foo2" does. This patch strips spaces from the "requestUpdate"
string before testing it.

Change-Id: Ifbb1fe5be59077207316e48204d65a978592f878
Resolves: #49872
Related: #42789
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/22313
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] requestUpdate sensitive to spaces 88/22188/2
Francois Suter [Wed, 10 Jul 2013 12:12:32 +0000 (14:12 +0200)]
[BUGFIX] requestUpdate sensitive to spaces

The TCA property "requestUpdate" is sensitive to spaces, although this
is documented nowhere. Indeed "foo1, foo2" will not work whereas
"foo1,foo2" does. This patch strips spaces from the "requestUpdate"
string before testing it.

Resolves: #42789
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I340090e93e7b8645493f8db0c8c374cb1227f684
Reviewed-on: https://review.typo3.org/22188
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Allow non-Admins to delete Records finally 56/21456/2
dkd-egerer Sascha Egerer [Tue, 27 Nov 2012 00:42:59 +0000 (01:42 +0100)]
[BUGFIX] Allow non-Admins to delete Records finally

This patch adds the posibility for non Admins to delete
records finally in the recycler.

Change-Id: I1fda11d621403758f4d78b7fa8f730d7b47d79a7
Fixes: #34156
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21456
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] t3lib_userAuthGroup::checkLogFailures() gives PHP notice 82/21482/5
Xavier Perseguers [Mon, 19 Sep 2011 20:47:00 +0000 (22:47 +0200)]
[BUGFIX] t3lib_userAuthGroup::checkLogFailures() gives PHP notice

Due to improper method signature in the parent class of t3lib_userAuthGroup,
a PHP notice is generated when calling method checkLogFailures().

Change-Id: Ic41cb88889ee18f2508ae5b2e96858e8bf16c349
Fixes: #30055
Releases: 4.5, 4.6
Reviewed-on: https://review.typo3.org/21482
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Invalid use of array_shift() in t3lib_div 13/21413/5
Xavier Perseguers [Mon, 19 Sep 2011 20:58:53 +0000 (22:58 +0200)]
[BUGFIX] Invalid use of array_shift() in t3lib_div

PHP Runtime Notice: Only variables should be passed by reference.

Change-Id: Ib1e9af4b58202f085d1afbba2b9bd0b288a8ef58
Fixes: #30056
Releases: 4.5, 4.6
Reviewed-on: https://review.typo3.org/21413
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Invalid method signature for t3lib_pageTree::init() 15/21415/5
Xavier Perseguers [Mon, 19 Sep 2011 22:11:17 +0000 (00:11 +0200)]
[BUGFIX] Invalid method signature for t3lib_pageTree::init()

Method t3lib_treeView::init() is not properly overriden in subclasses.

Change-Id: Ia39eb8ba775e1f217fb77f402dd8f2ab4e1d24ae
Fixes: #30062
Releases: 4.5, 4.6
Reviewed-on: https://review.typo3.org/21415
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Some methods in t3lib_TSparser should be static 83/21483/4
Xavier Perseguers [Mon, 19 Sep 2011 21:23:23 +0000 (23:23 +0200)]
[BUGFIX] Some methods in t3lib_TSparser should be static

A few methods in t3lib_TSparser are called statically but are not
declared as being static. This leads to PHP notices.

Change-Id: I7ea7cb659a830e74c4f8797f118662b517015614
Fixes: #30058
Releases: 4.5, 4.6
Reviewed-on: https://review.typo3.org/21483
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Add support for "outdated" extensions 42/21742/2
Jigal van Hemert [Sun, 30 Jun 2013 06:14:47 +0000 (08:14 +0200)]
[TASK] Add support for "outdated" extensions

Extension Manager displays installed extensions which are marked as
"outdated" with different styling. Reports module also checks for
installed and available "outdated" extensions.

Change-Id: I3050f3f7142e4153954f1b7f76b4bf64a3066223
Resolves: #49350
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21742
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] RTE: Importing google webfonts breaks style sheet parsing 64/21864/2
Stanislas Rolland [Wed, 3 Jul 2013 22:45:12 +0000 (18:45 -0400)]
[BUGFIX] RTE: Importing google webfonts breaks style sheet parsing

Problem: Firefox raises a security error because the file is not in the
same domain as the executing script. Probably a Firefox bug since the
file certainly has adequate headers: the font are indeed displayed in
the RTE.

Solution: Since the Webfont style sheet does not contain any css rules
anyways, we will catch the error, and if it is a security error, log it
to the Javascript console (or Firebug) and silently continue. Re-throw
any other type of error.

Resolves: #49648
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Change-Id: I225152ad5d84de50f29d3830be6f1f3e10f249c8
Reviewed-on: https://review.typo3.org/21864
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[TASK] Improve error message in NotFoundView to identify source 36/21736/2
Claus Due [Sat, 29 Jun 2013 12:43:54 +0000 (14:43 +0200)]
[TASK] Improve error message in NotFoundView to identify source

The error message before this change would only report the
action name, after this change it will reflect the controller and
extension name as well.

Set to apply to all maintained version since this changes no functions
whatsoever - it only improves error feedback.

Resolves: #49519
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I61dc32a4542b8664ca9443414278e983bc181c4a
Reviewed-on: https://review.typo3.org/21736
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Incorrect grouping of exclude fields in translated backend 36/21636/2
Jigal van Hemert [Sun, 5 May 2013 13:26:51 +0000 (15:26 +0200)]
[BUGFIX] Incorrect grouping of exclude fields in translated backend

If you use the backend in a language other than English, then the
grouping of the exclude fields in the be_group record is messed up when
flexform fields are included.

E.g. in a German backend, all tt_content fields are grouped below pages.

Sort the table names beforehand and afterwards all fields inside each
table.
Besides the patch converts some variables names into meaningful ones.

For TYPO3_4-5, the patch merges the existing unit test into this file.

Change-Id: I28ebc69d5cfc0316bdf44558276d3e939d011c2d
Fixes: #47839
Related: #34098
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21636
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] t3lib_utility_mailTest fails 17/21617/2
Philipp Gampe [Sun, 23 Jun 2013 15:22:38 +0000 (17:22 +0200)]
[BUGFIX] t3lib_utility_mailTest fails

The tested method always adds a From address to the mail header. This
is not reflected in the test.
Additionally clean up the test header a bit (backup globals).

Resolves: #49361
Releases: 4.5
Change-Id: I33d85916980eea34331d7d87682de9f71119af25
Reviewed-on: https://review.typo3.org/21617
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Insert rows only once in exec_INSERTmultipleRows 08/21408/2
Jigal van Hemert [Fri, 14 Jun 2013 00:30:42 +0000 (02:30 +0200)]
[BUGFIX] Insert rows only once in exec_INSERTmultipleRows

For native handler types multiple rows can be inserted using the mysql
INSERTmultipleRows API call. When another handler was used, the operation
was done twice, due to a missing else after the native handler condition.
This resulted in two database records for every INSERT statement.

The patch adds the missing else branch for the condition, preventing
the second run that was only meant to handle non-native handler types.

Change-Id: Ibab98a0c73b379bac063c8d1c19e30e93f38faf4
Resolves: #48220
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21408
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Flexform field is available but not passed to sub-function calls 79/21579/2
Claus Due [Fri, 21 Jun 2013 18:47:45 +0000 (20:47 +0200)]
[BUGFIX] Flexform field is available but not passed to sub-function calls

This change fixes three occurrences of calls to FlexForm DS
processing methods which accept a $fieldName argument but in
the current state of the code is given an empty string instead
of the $field variable which exists in all three contexts and
contains the proper value.

Passing the field name along to these sub functions allows hook
subscribers to use the field name - among other things. In any
case this fixes an unexpected behaviour turning it into an
expected one.

Resolves: #49331
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I078b0734f3bfa74a9acd61773c5c380f091286f8
Reviewed-on: https://review.typo3.org/21579
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Illegal string offset warning in AjaxLoginHandler 73/21573/2
Markus Klein [Fri, 21 Jun 2013 17:40:21 +0000 (19:40 +0200)]
[BUGFIX] Illegal string offset warning in AjaxLoginHandler

After logout $GLOBALS['BE_USER']->user['uid'] is checked.
This is done without isset() which triggers a warning, as ->user is unset,
if the logout was successful.

Resolves: #49327
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ia13af7f2a75090050113ff6a5d388b790df0bab1
Reviewed-on: https://review.typo3.org/21573
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix JS error with Context Sensitive Help 48/21548/2
Michel Nederlof [Wed, 19 Jun 2013 21:47:02 +0000 (23:47 +0200)]
[BUGFIX] Fix JS error with Context Sensitive Help

Using the edit form for records in a new pop window leads
to a JS error, as "top" is not defined in the new window.

Resolves: #26588
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I2eab83a2c9df2fed13fd5bcc1c829bf4f2b9a055
Reviewed-on: https://review.typo3.org/21548
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Illegal string offset 'translations' in DatabaseRecordList 60/21460/2
Philipp Gampe [Sat, 15 Jun 2013 14:55:32 +0000 (16:55 +0200)]
[BUGFIX] Illegal string offset 'translations' in DatabaseRecordList

The return value of TranslationConfigurationProvider->translationInfo
normally is an array, but it is a string in case of an error.
Move the line below the is_array() check, because it is only needed
inside.

Fixes: #47103
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ia781eae987d9295bc2b299f83c087669c96dfd00
Reviewed-on: https://review.typo3.org/21460
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[TASK] Merge submodule version into core
Thomas Maroschik [Mon, 27 May 2013 17:04:55 +0000 (19:04 +0200)]
[TASK] Merge submodule version into core

5 years ago[TASK] Merge submodule workspaces into core
Thomas Maroschik [Mon, 27 May 2013 17:04:54 +0000 (19:04 +0200)]
[TASK] Merge submodule workspaces into core

5 years ago[TASK] Merge submodule linkvalidator into core
Thomas Maroschik [Mon, 27 May 2013 17:04:53 +0000 (19:04 +0200)]
[TASK] Merge submodule linkvalidator into core

5 years ago[TASK] Merge submodule fluid into core
Thomas Maroschik [Mon, 27 May 2013 17:04:53 +0000 (19:04 +0200)]
[TASK] Merge submodule fluid into core

5 years ago[TASK] Merge submodule extbase into core
Thomas Maroschik [Mon, 27 May 2013 17:04:51 +0000 (19:04 +0200)]
[TASK] Merge submodule extbase into core

5 years ago[TASK] Merge submodule dbal into core
Thomas Maroschik [Mon, 27 May 2013 17:04:50 +0000 (19:04 +0200)]
[TASK] Merge submodule dbal into core

5 years ago[BUGFIX] Pass $field to BackendUtility::getFlexFormDS 74/21074/2
Wouter Wolters [Sun, 19 May 2013 14:21:37 +0000 (16:21 +0200)]
[BUGFIX] Pass $field to BackendUtility::getFlexFormDS

This bugfix just passes an already existing argument
along to the hook method, making the $field variable
available there.

Change-Id: I5337490920a96a8db0af8f8ecc01e967dba0c9ca
Fixes: #39527
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/21074
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Set TYPO3 version to 4.5.28-dev 27/21027/2
TYPO3 Release Team [Fri, 24 May 2013 14:27:35 +0000 (16:27 +0200)]
[TASK] Set TYPO3 version to 4.5.28-dev

Change-Id: I2ad5f71706e9caeaa0e1b2c32b95d075334b24ef
Reviewed-on: https://review.typo3.org/21027
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 4.5.27 26/21026/2 TYPO3_4-5-27
TYPO3 Release Team [Fri, 24 May 2013 14:27:08 +0000 (16:27 +0200)]
[RELEASE] Release of TYPO3 4.5.27

Change-Id: I340309f0355c3b2a1d976ea4cdcd067ac66e226a
Reviewed-on: https://review.typo3.org/21026
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years agoRevert "[BUGFIX] Extension Security Report goes green if TER was never fetched" 06/21006/3
Markus Klein [Thu, 23 May 2013 18:28:50 +0000 (20:28 +0200)]
Revert "[BUGFIX] Extension Security Report goes green if TER was never fetched"

The change does not consider the "old old EM", which does not update
the repository timestamp in sys_ter properly. Hence the reports module
does not show adequate information, even though the TER was fetched
properly by the "old old EM".

This reverts commit d4439a159896954b93cfbe020d879e0f8eab98f9

Change-Id: I142c0cdf2faff12deb57cb04aafb72e89406d96b
Releases: 4.5
Reviewed-on: https://review.typo3.org/21006
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix last line in table wizard 22/20922/2
Philipp Gampe [Sun, 19 May 2013 14:44:24 +0000 (16:44 +0200)]
[BUGFIX] Fix last line in table wizard

In the table wizard (table ce) you have the possibility to move first line
to the last line and vice versa. But on last line the false icon and
input field is set. We also have a FIXME comment there.

With the patch we fix the problem and you can again move the last
line on top of the lines.

Resolves: #16531
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I7fe69397ba595a6b2aec8cdfba05b286f3b8ebe4
Reviewed-on: https://review.typo3.org/20922
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] be_users.userMods is too small to hold all modules 91/20891/2
Philipp Gampe [Fri, 17 May 2013 20:42:51 +0000 (22:42 +0200)]
[BUGFIX] be_users.userMods is too small to hold all modules

It is impossible to assign all modules to a single user, because the
DB field is too small.  Saving such a record will result in a DB error
and a truncated modules list.

Solution: Change to field from varchar(255) to text to support a larger
number of modules.

This change requires a DB compare to become active. The fix is simply
not present otherwise, but also don't affect existing installations in
any way.

Resolves: #16762
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I67b2ed6b650f9eaf5bdcc9ef81ce93cbbdc54b7f
Reviewed-on: https://review.typo3.org/20891
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Multi-table relationship not recognized in t3lib_loadDBGroup 50/9150/3
Markus Opahle [Wed, 22 Feb 2012 14:54:29 +0000 (15:54 +0100)]
[BUGFIX] Multi-table relationship not recognized in t3lib_loadDBGroup

If a multi-table relationship has $MM_oppositeFieldConf['allowed']=='*',
then it is not recognized as such one in t3lib_loadDBGroup::start().

Change-Id: Ifbf8a71af8a9d0a0636d8a2332999c402a717559
Resolves: #34148
Releases: 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/9150
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Mario Rimann
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] undefined variable imgExt 40/12840/2
Simon Schaufelberger [Thu, 1 Mar 2012 14:32:55 +0000 (15:32 +0100)]
[BUGFIX] undefined variable imgExt

reducing colors in getImgResource function fails if not using
image-magick

Change-Id: I127ea54becd12a09cdd92a299e1f2d517d106763
Fixes: #34446
Releases: 4.7, 4.6, 4.5, 4.4
Reviewed-on: https://review.typo3.org/12840
Reviewed-by: Marcus Schwemer
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Sorting not respected for backend layout dropdowns 14/20714/2
Anja Leichsenring [Sun, 12 May 2013 07:02:02 +0000 (09:02 +0200)]
[BUGFIX] Sorting not respected for backend layout dropdowns

The core record backend_layout can be sorted manually, but this is not
reflected in the pages TCA for the dropdowns backend_layout and
backend_layout_next_level.

This patch fixes this issue by adding the sorting in the foreign_where
clause

Thanks to Frans Saris for reporting this issue

Change-Id: I04680278075ddc0de69600423be5fe783e34f562
Resolves: #47688
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/20714
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Wrong class in t3lib_TCEforms_Suggest 94/20694/2
Nicole Cordes [Fri, 10 May 2013 20:44:06 +0000 (22:44 +0200)]
[BUGFIX] Wrong class in t3lib_TCEforms_Suggest

Due to an backport error from #21588 a wrong class was introduced with. This
patch replaces the wrong class with the correct one so suggest wizard is
working again.

Change-Id: I9059452b2ceb9952ce6426a90872fee1b225c3b6
Resolves: #48052
Releases: 4.7, 4.5
Reviewed-on: https://review.typo3.org/20694
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Activate syntax check for PHP 5.4 47/20647/2
Helmut Hummel [Wed, 8 May 2013 21:30:32 +0000 (23:30 +0200)]
[TASK] Activate syntax check for PHP 5.4

Change-Id: I30cdec14a5841e27665b5fa3bf101b80549be6cb
Reviewed-on: https://review.typo3.org/20647
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Activate travis to check for syntax errors 45/20645/3
Helmut Hummel [Wed, 8 May 2013 18:11:53 +0000 (20:11 +0200)]
[TASK] Activate travis to check for syntax errors

Change-Id: I38aa9202703fda0c4a3cd9414551f2f936c5d509
Reviewed-on: https://review.typo3.org/20645
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix SQL error in Livesearch with empty TCA sortby setting 41/15541/2
Laurent Cherpit [Sat, 6 Oct 2012 15:18:43 +0000 (17:18 +0200)]
[BUGFIX] Fix SQL error in Livesearch with empty TCA sortby setting

If a searchable TCA field has a sortby setting which contains an empty
string or NULL, then BE Livesearch creates a query with one or more
'ORDER BY' without value, generating an SQL error. This fixes that.

Change-Id: I0457020ef31850458e3bd4286214f8e57278223e
Fixes: #40816
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/15541
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Mario Rimann
Reviewed-by: Steffen Ritter
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Ernesto Baschny
5 years ago[BUGFIX] Call to undefined function mime_content_type() 57/20557/2
Christian Kuhn [Mon, 6 May 2013 19:24:06 +0000 (21:24 +0200)]
[BUGFIX] Call to undefined function mime_content_type()

With PHP 5.2, it might happen that mime_content_type is not
available. This was introduced by #46126 and is now better
sanitized by the patch again.

Change-Id: I4145461d46fc12d0569bfffc0ad4750f67aeed2c
Resolves: #47969
Related: #46126
Releases: 4.5
Reviewed-on: https://review.typo3.org/20557
Reviewed-by: Steffen Ritter
Reviewed-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Raise submodule pointer 56/20556/2
Christian Kuhn [Mon, 6 May 2013 19:19:11 +0000 (21:19 +0200)]
[TASK] Raise submodule pointer

Change-Id: Ic7f81b0f77262d8b54688e3c0110de09d0fc74a7
Reviewed-on: https://review.typo3.org/20556
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Namespace usage -> fatal compile error in PHP 5.2
Wouter Wolters [Mon, 6 May 2013 16:38:39 +0000 (18:38 +0200)]
[BUGFIX] Namespace usage -> fatal compile error in PHP 5.2

There is a regression in Typo3DbBackend. The backport of
https://review.typo3.org/#/c/19866/ contains a namespaced
exception. For TYPO3 4.5 we need to support PHP 5.2.

Change-Id: I06c7890a6240fae235bb726771f55f98a32ece87
Fixes: #47978
Releases: 1.3
Reviewed-on: https://review.typo3.org/20553
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Resolve asterisk in allowed tables for suggest wizard 20/20520/3
Nicole Cordes [Sun, 21 Apr 2013 00:08:19 +0000 (02:08 +0200)]
[BUGFIX] Resolve asterisk in allowed tables for suggest wizard

In the suggest ajax script the setting of allowed tables is not parsed for
the asterisk (*). If it is set all TCA tables should be parsed and checked
for access and added to queryTables array.

Change-Id: Icc288bcd31595a5f653aa4ac4faa4602535ecbcf
Fixes: #21588
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/20520
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Extension Security Report goes green if TER was never fetched 93/20493/2
Mario Rimann [Tue, 17 Jul 2012 19:17:27 +0000 (21:17 +0200)]
[BUGFIX] Extension Security Report goes green if TER was never fetched

Shows a notice for both the extension security checks as long as
the check for the main repository is not showing an OK state.

As soon as the main repository check is OK, the status of the
extensions will be checked as before.

Change-Id: I41aaa6f4bbb36e32dcb1f734c2b491164a705c76
Resolves: #39043
Releases: 4.7, 4.5
Reviewed-on: https://review.typo3.org/20493
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Set TYPO3 version to 4.5.27-dev 51/20451/2
TYPO3 Release Team [Fri, 3 May 2013 07:18:28 +0000 (09:18 +0200)]
[TASK] Set TYPO3 version to 4.5.27-dev

Change-Id: I58f86edced0c72436a14ae9ed1ac57a3700bdc62
Reviewed-on: https://review.typo3.org/20451
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 4.5.26 50/20450/2 TYPO3_4-5-26
TYPO3 Release Team [Fri, 3 May 2013 07:17:36 +0000 (09:17 +0200)]
[RELEASE] Release of TYPO3 4.5.26

Change-Id: Icf32e527e7c19afe18e2b0ef89dfb9a34ae11942
Reviewed-on: https://review.typo3.org/20450
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[TASK] Raise submodule pointer 40/20340/2
TYPO3 Release Team [Tue, 30 Apr 2013 06:08:14 +0000 (08:08 +0200)]
[TASK] Raise submodule pointer

Change-Id: I0f6486381e788ef1400066ae193013034abd57f3
Reviewed-on: https://review.typo3.org/20340
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] Fix using doc instance in be.pageInfoVH
Marc Bastian Heinrichs [Mon, 29 Apr 2013 07:55:50 +0000 (09:55 +0200)]
[BUGFIX] Fix using doc instance in be.pageInfoVH

Since the merge of https://review.typo3.org/#/c/19000/
$GLOBALS['SOBE']->doc is not always set. Use the doc
object, which is returned from call $this->getDocInstance instead.

Change-Id: I5d254e115b73a898a12c48ebbe32fb4320934b35
Fixes: #47556
Releases: 4.7, 1.3
Related: #40519
Reviewed-on: https://review.typo3.org/20287
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Update URLs to documentation 51/20251/2
Jigal van Hemert [Sun, 28 Apr 2013 10:26:34 +0000 (12:26 +0200)]
[TASK] Update URLs to documentation

The documentation is now located at docs.typo3.org.
Update the URL accordingly.

Change-Id: Ib9b102e0705742fe0b1498f6a7c22cbc0d23a333
Resolves: #47621
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/20251
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Empty columns in Page Module view cause warnings 32/20232/2
Christian Zenker [Thu, 25 Apr 2013 16:32:10 +0000 (18:32 +0200)]
[BUGFIX] Empty columns in Page Module view cause warnings

The iteration over columns in the page module layout view
expects arrays. Since it might happen, that there is no element
for a particular column, variables need to be initialized with
an empty array.

Change-Id: I63b4b26a87f1520139c9d66d0c096a78d39e409c
Fixes: #47529
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/20232
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Set TYPO3 version to 4.5-dev 86/20086/2
TYPO3 Release Team [Mon, 22 Apr 2013 18:59:36 +0000 (20:59 +0200)]
[TASK] Set TYPO3 version to 4.5-dev

Change-Id: I67350696542cfd9a96f2d711e7349e6ea89a08dc
Reviewed-on: https://review.typo3.org/20086
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 4.5.26rc1 85/20085/2
TYPO3 Release Team [Mon, 22 Apr 2013 18:59:28 +0000 (20:59 +0200)]
[RELEASE] Release of TYPO3 4.5.26rc1

Change-Id: I3497e1cd620e6ed0ca49c6d143580a48cdcb501d
Reviewed-on: https://review.typo3.org/20085
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[TASK] Raise submodule pointer 81/20081/2
TYPO3 Release Team [Mon, 22 Apr 2013 18:39:50 +0000 (20:39 +0200)]
[TASK] Raise submodule pointer

Change-Id: I959ee641460ab17007d94e7760eef03ed45e8712
Reviewed-on: https://review.typo3.org/20081
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Select label element from suggest-list 70/20070/2
Stefan Neufeind [Sat, 20 Apr 2013 19:43:16 +0000 (21:43 +0200)]
[BUGFIX] Select label element from suggest-list

If a sprite is the first child in chosen item from
suggest-list no label is generated.

Therefore select the element depending on the class.
Besides that, e.g. Flexform elements use "invalid" CSS
IDs that contain "[" and "]" characters - using plain
CSS selectors on that does not work and needs to be
escaped first.

Fixes: #47409
Releases: 4.5, 4.7, 6.0, 6.1
Change-Id: I40fad4b6596923cc87889726794f115eb7b58eb5
Reviewed-on: https://review.typo3.org/20070
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] RTE: Tab key in Chrome inserts weird SPAN tags 60/20060/2
Stanislas Rolland [Sun, 21 Apr 2013 22:56:58 +0000 (18:56 -0400)]
[BUGFIX] RTE: Tab key in Chrome inserts weird SPAN tags

Problem: The problem arises when indent/outdent buttons are not
configured in toolbar. Default WebKit action inserts span tag with
special class.

Solution: Stop the event and avoid the default action: do nothing.

Fixes: #47274
Releases: 4.5, 4.7, 6.0, 6.1
Change-Id: Ie35ed75f6f3a625cbc3e856c2e9a44b3838e587e
Reviewed-on: https://review.typo3.org/20060
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
6 years ago[BUGFIX] Suggest wizard: Display record icon 44/20044/2
Jigal van Hemert [Sat, 20 Apr 2013 14:33:13 +0000 (16:33 +0200)]
[BUGFIX] Suggest wizard: Display record icon

Especially for pages the icon is not shown in the list of suggested
records. This patch switches the icons from background images to sprite
icons.

Change-Id: I5bf19c43b2979608270638895022517384f97bea
Fixes: #40731
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/20044
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] excludeUidList not checked for ifsub state 39/20039/2
Jigal van Hemert [Fri, 19 Apr 2013 19:17:31 +0000 (21:17 +0200)]
[BUGFIX] excludeUidList not checked for ifsub state

For menu item states IFSUB(RO), ACTIFSUB(RO) and CURIFSUB(RO) the
excludeUidList was not checked. If all submenu items are excluded the
menu item doesn't get the "ifsub" state anymore.

Change-Id: Ia113bb187b778718a501e0f2f6c0956c99cb1d8a
Fixes: #45254
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/20039
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Don't use folders as templates, partials and layouts
Marc Bastian Heinrichs [Sat, 13 Apr 2013 17:11:49 +0000 (19:11 +0200)]
[BUGFIX] Don't use folders as templates, partials and layouts

The file_exists checks in TemplateView and StandaloneView are true for
folders. This leads to unrendered partials with resorted paths.
Use is_file.

Releases: 6.1, 6.0, 4.7, 1.3
Fixes: #47186
Fluid Package Issue: #47188

Change-Id: Ib64e180e01d66777bb5b0683cce26d88ec2a9fd6
Reviewed-on: https://review.typo3.org/19970
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Add/drop usage of preg_quote() where needed 38/19938/2
Jigal van Hemert [Sat, 13 Apr 2013 16:24:45 +0000 (18:24 +0200)]
[TASK] Add/drop usage of preg_quote() where needed

In some places preg_quote() is not used or is used incorrectly.
In other places there are preg_quote() calls which had no
real function.

Change-Id: If201394036d17a68cea41903f849c6c5ea11b069
Releases: 4.5, 4.6, 4.7, 6.0, 6.1
Resolves: #36793
Reviewed-on: https://review.typo3.org/19938
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[TASK] Typo3DbBackend: Drop non-functional code
Stefan Neufeind [Sat, 13 Apr 2013 12:56:15 +0000 (14:56 +0200)]
[TASK] Typo3DbBackend: Drop non-functional code

array_fill_keys() used without function

Change-Id: Ib52e8d58a64fbba3eefc1fa28b0bb8a9dbbe30da
Resolves: #47185
Releases: 1.3, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/19933
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX] RequestBuilder must not call $request->setMethod with NULL
Anja Leichsenring [Sat, 13 Apr 2013 11:07:22 +0000 (13:07 +0200)]
[BUGFIX] RequestBuilder must not call $request->setMethod with NULL

If running a cli script the variable $_SERVER['REQUEST_METHOD'] is
not set at all. So when dispatching a sub webrequest the variable is
still not set and the RequestBuilder sets the method of Request to
NULL which is not allowed.

Therefore the variable will now be fetched from the Environment
and falls back to "GET" in case no value can be fetched this way.

Releases: 6.1, 6.0, 4.7, 1.3
Resolves: #13845
Change-Id: I5e33aba48605895f9eae1e3b710364091e7e84f0
Reviewed-on: https://review.typo3.org/19901
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Raise submodule pointer 00/19900/2
Christian Kuhn [Sat, 13 Apr 2013 11:05:41 +0000 (13:05 +0200)]
[TASK] Raise submodule pointer

Change-Id: I104c00a413c9a32652d969bbf9312478f02d69a7
Reviewed-on: https://review.typo3.org/19900
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Added handling for array in findOneByXXX result
Christian Kuhn [Sat, 13 Apr 2013 10:00:30 +0000 (12:00 +0200)]
[BUGFIX] Added handling for array in findOneByXXX result

If query findOneByXXX is configured to return an array, the first array
element is returned (instead of calling ->getFirst() on a non object).

Fixes: #46035
Releases: 6.1, 6.0, 4.7, 1.3
Change-Id: I2c9d3083ce0eaebd2929ce9f50ec2a7cc36fe222
Reviewed-on: https://review.typo3.org/19893
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] "stripOrderBy, stripGroupBy" should remove double occurrence 30/17630/3
Laurent Cherpit [Sat, 6 Oct 2012 16:16:43 +0000 (18:16 +0200)]
[BUGFIX] "stripOrderBy, stripGroupBy" should remove double occurrence

Sometimes the string handed over to stripOrderBy includes the ORDER BY
twice.
Tweak the regular expression to detect and fix that kind of errors.

The same applies to stripGroupBy.

Fixes: #41641
Releases: 6.0, 4.7, 4.6, 4.5
Change-Id: Ib1829fbf57ec281a54b5f940211a86c52723cfbe
Reviewed-on: https://review.typo3.org/17630
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 79/19879/2
Christian Kuhn [Fri, 12 Apr 2013 21:09:29 +0000 (23:09 +0200)]
[TASK] Raise submodule pointer

Change-Id: Ia56486b2ea602611e7b5ab0e53b50cd0ca1bfd65
Reviewed-on: https://review.typo3.org/19879
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Checkbox for mass-action also if only publish/swap-permission
Robert Heel [Sun, 20 Nov 2011 23:26:21 +0000 (00:26 +0100)]
[BUGFIX] Checkbox for mass-action also if only publish/swap-permission

If user has only publish/swap permission show the
mass-action checkbox as well.

Change-Id: I04ccd6f08f3f56021ab29d91ac8aba7619f1e9cd
Fixes: #31122
Releases: 4.5, 4.6, 4.7
Reviewed-on: http://review.typo3.org/6756
Reviewed-by: Stefan Neufeind
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Tolleiv Nietsch
Tested-by: Tolleiv Nietsch
Reviewed-on: https://review.typo3.org/13950

6 years ago[BUGFIX] Prevent building empty IN () query by throwing exception
Benjamin Bretz [Fri, 12 Apr 2013 19:55:19 +0000 (21:55 +0200)]
[BUGFIX] Prevent building empty IN () query by throwing exception

If $storagePageIds is empty Typo3DbBackend::addPageIdStatement()
InconsistentQuerySettingsException is thrown instead of creating
an invalid query

Fixes: #47167
Releases: 6.1, 6.0, 1.3
Change-Id: Ib52884573c9a09b791c0b090daaffc9b7d15b6a1
Reviewed-on: https://review.typo3.org/19861
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-on: https://review.typo3.org/19866

6 years ago[BUGFIX] Allow Setting colorspace in the Install Tool. 25/19725/6
Anja Leichsenring [Sun, 7 Apr 2013 09:41:32 +0000 (11:41 +0200)]
[BUGFIX] Allow Setting colorspace in the Install Tool.

Some versions of Imagemagick (6.7.0 and above) use the sRGB colorspace
instead RGB as before. This results in darker images after processing,
because TYPO3 hardcoded the RGB colorspace in graphical functions.

This patch introduces a setting in the GFX part of the Install Tool,
lets the user choose the sufficient colorspace.
This selection is used in graphical functions.

Additionaly a hint on the setting was added to the Image Processing Test
'Read Images' in the Install Tool.

Fixes: #36597
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: I50a26c414705afa3177a2f12fc3bb4532c2d0f7f
Reviewed-on: https://review.typo3.org/19725
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Make fetchUserRecord callable without username 76/19776/2
Robert Heel [Wed, 10 Apr 2013 10:32:30 +0000 (12:32 +0200)]
[BUGFIX] Make fetchUserRecord callable without username

t3lib_userAuth::fetchUserRecord is not callable without a username.
Fix the $usernameClause to generate a correct SQL query.

Change-Id: I56b5f8bf8b326e880f157c3b4a5a15409305c3d9
Fixes: #39248
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/19776
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] cli dispatcher throws notice on windows systems 72/19772/2
Nicole Cordes [Tue, 9 Apr 2013 21:12:31 +0000 (23:12 +0200)]
[BUGFIX] cli dispatcher throws notice on windows systems

In the CLI interface (cli_dispatch.phpsh) the server variable
$_SERVER['PWD'] is used which doesn't exists on windows
systems. PHP throws a notice, because the script doesn't check the
existence of the variable.

Change-Id: I425c48a7bd5a4e6fa9c86cc6e4dcae58493fd625
Fixes: #20392
Releases: 4.7, 4.5
Reviewed-on: https://review.typo3.org/19772
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
6 years ago[TASK] Raise submodule pointer 63/19763/2
Christian Kuhn [Tue, 9 Apr 2013 14:51:41 +0000 (16:51 +0200)]
[TASK] Raise submodule pointer

Change-Id: I8f18193b270c1ad3f11f3826820c10ea2e0bb411
Reviewed-on: https://review.typo3.org/19763
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] exec_INSERTmultipleRows doesn't check alternative handlers
Christian Kuhn [Tue, 9 Apr 2013 14:39:24 +0000 (16:39 +0200)]
[BUGFIX] exec_INSERTmultipleRows doesn't check alternative handlers

The function just passes the function call to it's parents insert
function when the type of the current handler is "native".
When using an alternative handler than "_DEFAULT" for a table, wich
connection is also "native", it will directly forward the call without
respecting my mapping for the table to another handler.

Similar to the other methods, this is solved by first fetching
the handler for the current table and then feeding the created
SQL string to mysql_query on given handler link.

The patch additionaly fixes db errors in 6.1 after mysqli switch.

Change-Id: I0c984b355916a99603ed72f0606e173608e4de81
Fixes: #34327
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/19760
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Numeric check for upper/lower bound of flexform-values 55/19755/2
Georg Ringer [Tue, 9 Apr 2013 13:09:22 +0000 (15:09 +0200)]
[BUGFIX] Numeric check for upper/lower bound of flexform-values

The range-check in Flexforms uses the same code as for normal
tables. Normally an integer field would be of type integer.
But in Flexforms the value is a string as is the value in DS.
Change-Id: I3512a961780a4bef91e04f61b8b9547f43f28f3e
Fixes: #15771
Releases: 4.5, 4.6, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/19753
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-on: https://review.typo3.org/19754
Reviewed-on: https://review.typo3.org/19755

6 years ago[BUGFIX] Pagetree - Prevent a call to moveNode while creating nodes 42/17642/2
Tobias Schultheiss [Thu, 16 Aug 2012 14:54:56 +0000 (16:54 +0200)]
[BUGFIX] Pagetree - Prevent a call to moveNode while creating nodes

Change-Id: I355cfb5ed4d2ebfac26376f5f774dca4d89a0c6c
Fixes: #39820
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17642
Reviewed-by: Mario Rimann
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Take versioned record into account for showHidden flag. 02/12802/3
Bart Dubelaar [Fri, 27 Jan 2012 12:02:49 +0000 (13:02 +0100)]
[BUGFIX] Take versioned record into account for showHidden flag.

The flag showHiddenPage is set if the requested uid is a hidden page.
The original code always looked at the original uid and not to version
in the active workspace. This is fixed.

Change-Id: I49017e874fc2accfc9c38789d8d73528afed3c6f
Fixes: #33392
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/12802
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Bart Dubelaar
Tested-by: Bart Dubelaar
Reviewed-by: Stefan Neufeind
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Invalid RSA key when submitting form twice 51/18351/2
Benjamin Mack [Tue, 15 Jan 2013 12:05:27 +0000 (13:05 +0100)]
[BUGFIX] Invalid RSA key when submitting form twice

When submitting a RSA-supported form twice, the JS error
"Invalid RSA public key" is thrown. In order to suppress
this double RSA decryption, an additional JS check is needed.
The change also modifies the minified version of the JS
done with http://refresh-sf.com/yui/

Change-Id: I7133e320c76e14a6f6855f477ba5a34e50eecf58
Resolves: #40085
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/18351
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
6 years ago[BUGFIX] Illegal string offset in EditDocumentController 17/19717/2
Philipp Gampe [Fri, 5 Apr 2013 22:22:34 +0000 (00:22 +0200)]
[BUGFIX] Illegal string offset in EditDocumentController

If a content element is opened from the opendocs module, a warning is
shown because overrideVals is used without checking if it is an array.

Fixes: #46965
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: If25b21121708226594cfac6436278c297f32ddb9
Reviewed-on: https://review.typo3.org/19717
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Hide move placeholder in WS preview 13/19713/2
Benjamin Mack [Sat, 6 Apr 2013 21:22:03 +0000 (23:22 +0200)]
[BUGFIX]  Hide move placeholder in WS preview

Move placeholder are visible in the navigation
during WS preview if they are moved for example
from the first to the second level.

Fixes: #38705
Releases: 6.1,6.0,4.7,4.5
Change-Id: I7bdeee0246bb34bdc5b8baf963fad6b262078877
Reviewed-on: https://review.typo3.org/19712
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-on: https://review.typo3.org/19713

6 years ago[BUGFIX] Write config to extTables destroys HTML output 10/19710/2
Philipp Gampe [Sat, 6 Apr 2013 18:47:43 +0000 (20:47 +0200)]
[BUGFIX] Write config to extTables destroys HTML output

If you enter HTML to update a field in e.g. TCA to write the value into
extTables.php, then the HTML will be printed into the configuration
module.
htmlspecialchar the output.

Fixes: #46999
Releases: 6.1,6.0,4.7,4.5
Change-Id: I390b4252316b8bdf01e5bbcc5a8b33833bdf73e8
Reviewed-on: https://review.typo3.org/19710
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] BE login form gives warnings in RteHtmlParser 05/19705/2
Anja Leichsenring [Sat, 6 Apr 2013 19:06:21 +0000 (21:06 +0200)]
[BUGFIX] BE login form gives warnings in RteHtmlParser

Intialize configuration as array to prevent PHP warnings for
Illegal string offset.

Change-Id: Ic7398ba2c041c3278a1bd5562968ac5183643d3d
Fixes: #43291
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/19705
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] swiftmaileradapter should ignore empty headers 87/19687/2
Stefan Neufeind [Wed, 17 Oct 2012 22:32:34 +0000 (00:32 +0200)]
[BUGFIX] swiftmaileradapter should ignore empty headers

Further processing empty header-values with
functions like parseAddress() can lead to
unexpected problems.

Change-Id: Ida436f384a6a6a86d7fbd119083a9037157f48df
Fixes: #42106
Releases: 4.5, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/19687
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Endless loop in flushOutputBuffers() 96/15496/2
Christian Kuhn [Wed, 10 Oct 2012 15:39:51 +0000 (17:39 +0200)]
[BUGFIX] Endless loop in flushOutputBuffers()

Change-Id: I87f998211d12f2d7c40a582f8b2c605f2edcaed0
Resolves: #40126
Releases: 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/15496
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
Reviewed-by: Mario Rimann
Reviewed-by: Sascha Egerer
Tested-by: Sascha Egerer
Reviewed-by: Steffen Gebert
Tested-by: Steffen Gebert
6 years ago[BUGFIX] Respect line breaks in stdWrap.cropHTML 01/19501/2
Benjamin Mack [Mon, 1 Apr 2013 20:20:59 +0000 (22:20 +0200)]
[BUGFIX] Respect line breaks in stdWrap.cropHTML

By using the PCRE_DOTALL (/s) pattern modifier in the cropHTML
regular expression for preserving HTML entities the dot in the
pattern will include line breaks.
Resolves: #28741
Releases: 6.1, 6.0, 4.7, 4.5

Change-Id: Idb12d85681b0304730b9d76843b8352013e88123
Reviewed-on: https://review.typo3.org/19501
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Fix breaking t3editor by using hsc() 87/19587/2
Georg Ringer [Tue, 2 Apr 2013 06:08:41 +0000 (08:08 +0200)]
[BUGFIX] Fix breaking t3editor by using hsc()

t3editor misses a htmlspecialchars() when displaying content of
the CE "HTML".

Change-Id: I84b65cd42bee971adc6fb77149f6789e76fc6567
Fixes: #33651
Releases: 6.1,6.0,4.7,4.6,4.5
Reviewed-on: https://review.typo3.org/19587
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 18/19518/2
TYPO3 Release Team [Tue, 2 Apr 2013 17:02:19 +0000 (19:02 +0200)]
[TASK] Raise submodule pointer

Change-Id: I1674b8fa6fa69964b6b58531490e39f5a9aaa767
Reviewed-on: https://review.typo3.org/19518
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Remove redundant layermenu files 61/19261/4
Michael Stucki [Mon, 25 Mar 2013 12:36:35 +0000 (13:36 +0100)]
[BUGFIX] Remove redundant layermenu files

These files were maintained as two individual version. A number of
bugfixes were only applied in one version bot not in the other.

This change adds all missing fixes to the files in "statictemplates" and
removes all code from the files in "cms".

Resolves: #46644
Releases: 4.5, 4.7
Change-Id: I56ce401c73933eda381ce52b4d906a12b6ed963c
Reviewed-on: https://review.typo3.org/19261
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] FormViewHelper creates inline styling
Anja Leichsenring [Mon, 1 Apr 2013 08:54:06 +0000 (10:54 +0200)]
[BUGFIX] FormViewHelper creates inline styling

Due to accessibility reasons the inline styling of a container is
removed.

Fixes: #40826
Fluid Package Issue: #42743
Releases: 6.0, 4.7, 1.3
Change-Id: Ic78187422b0f50c52da7c288b36ca640d780b15a
Reviewed-on: https://review.typo3.org/19479
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring