Packages/TYPO3.CMS.git
19 months ago[TASK] Add data attributes in backend toolbar and menu components 97/52197/8
Thomas Deuling [Mon, 27 Mar 2017 20:18:44 +0000 (22:18 +0200)]
[TASK] Add data attributes in backend toolbar and menu components

Add data attributes in backend toolbar and backend menu components,
to have general identifier for binding guided tours popover and
more features that can be based on this.

Resolves: #80500
Releases: master, 8.7
Change-Id: I2add8b8c28ecd37967b7b23f71392aa71f209da5
Reviewed-on: https://review.typo3.org/52197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[FEATURE] Provide setting to hide restricted columns in page module 59/55259/13
steffenk [Thu, 4 Jan 2018 09:11:43 +0000 (10:11 +0100)]
[FEATURE] Provide setting to hide restricted columns in page module

The following TSConfig setting hides columns restricted via
mod.SHARED.colPos_list:

mod.web_layout.hideRestrictedCols = 1

Resolves: #83460
Releases: master
Change-Id: I0ccaa027d9a37530e6362675bf29679edc1d2a3d
Reviewed-on: https://review.typo3.org/55259
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Do not repopulate $GLOBALS['TYPO3_CONF_VARS'] in installer 78/55778/6
Benjamin Franzke [Sat, 17 Feb 2018 14:12:03 +0000 (15:12 +0100)]
[TASK] Do not repopulate $GLOBALS['TYPO3_CONF_VARS'] in installer

This is a followup for Icc8a3482edaef1ea329e68638d5ef467548062fc
which missed to remove the TYPO3_CONF_VARS repopulation
from the installer controller.

Now that ExtensionConfiguration::set() updates changed properties,
the manual repopulation after calling
synchronizeExtConfTemplateWithLocalConfigurationOfAllExtensions()
is not needed anymore and should be removed for the same
reasons as described in the mentioned change.

Change-Id: I3ff24411d2f0807a09c49d19bc021e9a239e6cb0
Releases: master
Resolves: #83954
Related: #83958
Reviewed-on: https://review.typo3.org/55778
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Consolidate hooks in workspace preview 66/55866/2
Benni Mack [Thu, 22 Feb 2018 20:00:27 +0000 (21:00 +0100)]
[TASK] Consolidate hooks in workspace preview

The Workspace preview hooks first hook into TSFE->connectToDB
to see if ADMCMD_prev is set via GP/cookie. If so, the TSFE object gets
re-instantiated, which is utterly unnecessary.

Additionally, it unsets the BE user cookie, solely to use a SECOND hook
(initializePreviewUser()) to check if the BE_USER is null.

Instead, the hooks are consolidated and the one hook after a regular BE user
exists, gets used, and overridden by a custom BE user object as defined
in the preview configuration with the workspace preview.

Resolves: #84014
Releases: master
Change-Id: Id3caf9cd99ff13c906062ff95523f6066d90d322
Reviewed-on: https://review.typo3.org/55866
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Encode node name when editing in the page tree 70/55870/6
Paweł Rogowicz [Fri, 23 Feb 2018 08:14:43 +0000 (09:14 +0100)]
[BUGFIX] Encode node name when editing in the page tree

Pass page title through encodeURIComponent before using it as request
parameter value

Releases: master
Resolves: #84019
Change-Id: Ic7b18c752e67d143928e50ff14fcada6ff03c3f9
Reviewed-on: https://review.typo3.org/55870
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
19 months ago[TASK] Streamline size of email fields 68/55868/2
Guido Schmechel [Thu, 22 Feb 2018 20:54:17 +0000 (21:54 +0100)]
[TASK] Streamline size of email fields

Change email field definition to 255 characters for the rfc compatibility.
Extend the TCA max option, too.

Resolves: #83986
Releases: master
Change-Id: Ifdfc302b67b773dff8ac7d9db2d89f00253c315a
Reviewed-on: https://review.typo3.org/55868
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[TASK] Remove additional GET variables for sys_preview links 57/55857/3
Benni Mack [Wed, 21 Feb 2018 19:56:11 +0000 (20:56 +0100)]
[TASK] Remove additional GET variables for sys_preview links

The possibility of EXT:workspaces to add additional GET variables to
preview links was dropped with TYPO3 6.0, instead linking to the full
workspace was enabled, also of using workspaces instead of versioning.

This info (a string of additional GET vars) is now removed from adding
through the workspaces Hook class, instead the link to the whole
workspace is generated, and identified via a ADMCMD md5-hash.

Resolves: #84006
Releases: master
Change-Id: Ic62b106bb0d350214daf2deda9eae739a3ab9633
Reviewed-on: https://review.typo3.org/55857
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
19 months ago[TASK] Remove usage of extbase from viewpage module 50/55850/7
Georg Ringer [Wed, 21 Feb 2018 04:54:51 +0000 (05:54 +0100)]
[TASK] Remove usage of extbase from viewpage module

Remove the overhead of extbase from the backend extension "viewpage".

Resolves: #83987
Releases: master
Change-Id: I3020aa7a9cffd92d4b96afd4d4044979a771db5b
Reviewed-on: https://review.typo3.org/55850
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
19 months ago[BUGFIX] Don't download language packs of not loaded extensions 60/55860/4
Christian Kuhn [Wed, 21 Feb 2018 23:05:49 +0000 (00:05 +0100)]
[BUGFIX] Don't download language packs of not loaded extensions

The backend language module struggles with downloading
language packs of existing, but not loaded extensions
and fetchess old (non core version specific) packs
for core extensions.
This is hard to solve on a bugfix level for v7 and v8,
and in general it does not make much sense to have
language packs of not loaded extensions lying around
in typo3conf/l10n.
The patch ignores fetching of language packs for
not loaded extensions, it easily applies to all
maintained core versions.

Change-Id: I9ad885012a572368f7946f1027d870ee09550034
Resolves: #83406
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55860
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Prevent repopulating TYPO3_CONF_VARS 03/55703/15
Nicole Cordes [Tue, 13 Feb 2018 17:25:59 +0000 (18:25 +0100)]
[BUGFIX] Prevent repopulating TYPO3_CONF_VARS

Instead of using the native API when changing a TYPO3 Extension
configuration through the new ExtensionConfiguration API, the
method is now solely overwriting the global $TYPO3_CONF_VARS[EXTENSIONS]
and $TYPO3_CONF_VARS[EXT][extConf] options during runtime
to avoid deadlocks and to avoid the removal of existing configuration
of extensions.

The second parameter of ExtensionConfiguration->set() can be removed
separately once EXT:bootstrap_package is adapted to the new functionaliy.

Resolves: #83958
Resolves: #83954
Releases: master
Change-Id: Icc8a3482edaef1ea329e68638d5ef467548062fc
Reviewed-on: https://review.typo3.org/55703
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
19 months ago[BUGFIX] Set Severity object properly 59/55859/2
Andreas Fernandez [Wed, 21 Feb 2018 20:30:32 +0000 (21:30 +0100)]
[BUGFIX] Set Severity object properly

This patch fixes two issues with setting the `Severity` object:
* Check if TYPO3 is an available namespace
* Store the object in `TYPO3.Severity`

Change-Id: Ice2b410f1a588c09f7a689f54ed127d8ee90f9fa
Resolves: #84007
Related: #83955
Releases: master
Reviewed-on: https://review.typo3.org/55859
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Unit tests: Do not rely on CacheManager instance 55/55855/4
Christian Kuhn [Wed, 21 Feb 2018 17:39:46 +0000 (18:39 +0100)]
[TASK] Unit tests: Do not rely on CacheManager instance

The typo3/testing-framework bootstrap up until now
initialized the CacheManager singleton and put it
into GeneralUtility instance stack.
To better isolate the tests and as a next step in
side effect free uni testing, the test bootstrap
now cleans this instance after use:

composer update typo/testing-framework

About 300 tests fail with this and are fixed with
the patch by improving their mocking.

Change-Id: Ia3e9dd1f94af10b20e0463a0062ccde74be23660
Resolves: #84004
Releases: master
Reviewed-on: https://review.typo3.org/55855
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Migrate Notification to TypeScript 92/55792/6
Andreas Fernandez [Sun, 18 Feb 2018 20:51:04 +0000 (21:51 +0100)]
[TASK] Migrate Notification to TypeScript

Change-Id: I71cbf24dc540b5a5659be8848d08be7dc2e84b22
Resolves: #82599
Releases: master
Reviewed-on: https://review.typo3.org/55792
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Remove unused ADMCMD_previewWS GET parameter 53/55853/2
Benni Mack [Wed, 21 Feb 2018 15:36:39 +0000 (16:36 +0100)]
[TASK] Remove unused ADMCMD_previewWS GET parameter

The workspace GET parameter "ADMCMD_previewWS" is not used anymore
since TYPO3 4.7 and can be removed, as it was used before
the current workspace wasn't transferred via "ADMCMD_prev" keywords before.

Resolves: #84001
Releases: master
Change-Id: If0ec7284a0e6b87185c7773637459e61f6ab2232
Reviewed-on: https://review.typo3.org/55853
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
19 months ago[BUGFIX] Have ImageManipulationWizard return HTMLResponse 56/55856/2
Mathias Schreiber [Wed, 21 Feb 2018 17:46:42 +0000 (18:46 +0100)]
[BUGFIX] Have ImageManipulationWizard return HTMLResponse

ImageManipulationWizard now returns a proper HTMLResponse instead of a JsonResponse.
Furthermore an missing import has been added in LocalizationController.

Resolves: #84005
Releases: master
Change-Id: Ie02cdaca84afa0c7fcde109e0fbbe5237ee69600
Reviewed-on: https://review.typo3.org/55856
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
19 months ago[BUGFIX] Fix wrong type in "rootLevel" option 52/55852/2
Armin Vieweg [Wed, 21 Feb 2018 09:52:09 +0000 (10:52 +0100)]
[BUGFIX] Fix wrong type in "rootLevel" option

Several system tables used a wrong type for ctrl option "rootLevel"
in TCA. By definition in TCAref "rootLevel" is from type integer.

Resolves: #83990
Branches: master
Change-Id: Ic49464ce428a1d9a928f90231c77e0d445789ee7
Reviewed-on: https://review.typo3.org/55852
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[TASK] Streamline deprecation handling in icon API 29/55829/3
Oliver Hader [Tue, 20 Feb 2018 15:44:25 +0000 (16:44 +0100)]
[TASK] Streamline deprecation handling in icon API

Icon API supports some basic handling of deprecated icons
as well as keeping track of replacements. However, it is
not possible to automatically benefit from these
replacements in case they are defined.

This change tackles the following:

* bug when logging deprecated icon identifiers due to
  mismatching sprintf arguments
* automatically making use of available replacements
  instead of throwing exception
* possibility to retrieve deprecated icons and
  replacements (in order to render them in ext:styleguide)

Resolves: #83978
Releases: master
Change-Id: I7faceebc30cca0cd1f392b4845d85ac2e5bf7307
Reviewed-on: https://review.typo3.org/55829
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Avoid registering extension icons in IconRegistry 28/55828/4
Oliver Hader [Tue, 20 Feb 2018 15:42:31 +0000 (16:42 +0100)]
[BUGFIX] Avoid registering extension icons in IconRegistry

Extensions usually have an individual icon that can be loaded
from Resources/Public/Icons/Extension.*. For some system extensions
IconRegistry automatically registers icons available in the file
system. This leads to the fact that the "Extension.*"
icon of some extensions is registered multiple times.

Resolves: #83979
Releases: master
Change-Id: I1d2d02a5bbadd33d8d6abeefff0c2071193dbdf0
Reviewed-on: https://review.typo3.org/55828
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Use sys_file as soft reference for formDefinitions 30/55830/4
Ralf Zimmermann [Tue, 20 Feb 2018 15:55:03 +0000 (16:55 +0100)]
[BUGFIX] Use sys_file as soft reference for formDefinitions

Register an embedded form definition as sys_file soft reference to show
the usage of the form definition within the file list module.

Resolves: #83502
Releases: master, 8.7
Change-Id: Ifdba760b8ebd45a9b83e97c5a20cf23ede6a74d7
Reviewed-on: https://review.typo3.org/55830
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Streamline usage of form framework icons 03/55803/10
Ralf Zimmermann [Mon, 19 Feb 2018 18:21:26 +0000 (19:21 +0100)]
[TASK] Streamline usage of form framework icons

Use form icons provided by the core. Remove - the now unused - icons
from the form folder.

Resolves: #83964
Releases: master
Change-Id: I0030f648f48c28c9c08d730a429cd3a2d1997ff0
Reviewed-on: https://review.typo3.org/55803
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Notice free FormEngine testing 34/55834/4
Christian Kuhn [Tue, 20 Feb 2018 16:00:20 +0000 (17:00 +0100)]
[BUGFIX] Notice free FormEngine testing

Similar solutions as in issue #83975

Change-Id: I04c06f0e73f5e7d44f225ad9b60c9cbed1016308
Resolves: #83981
Related: #83975
Releases: master
Reviewed-on: https://review.typo3.org/55834
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Refactor record querying in deep nested structures in recycler 72/55472/11
Andreas Fernandez [Sat, 27 Jan 2018 23:14:11 +0000 (00:14 +0100)]
[BUGFIX] Refactor record querying in deep nested structures in recycler

This patch refactors how the recycler queries records in deep page
structures.
Instead of resolving each level of the page tree on demand and executing
the complex logic of creating query builders and paging all over again,
a list of page ids is generated once and stored in the Caching Framework
for the current request. This list is then used in an multiple `IN()`
statements (depending on the DBMS engine used).

Also, some wrong type hints and a wrong language file reference are
fixed.

Resolves: #83702
Releases: master, 8.7
Change-Id: Ie3314b5a9209fb5585f95a70c16b35639951c197
Reviewed-on: https://review.typo3.org/55472
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Add placeholder to date picker form elements 35/55835/3
Ralf Zimmermann [Tue, 20 Feb 2018 17:20:01 +0000 (18:20 +0100)]
[BUGFIX] Add placeholder to date picker form elements

Add the possibility to define a placeholder html attribute for
date picker form elements.

Resolves: #82514
Releases: master, 8.7
Change-Id: I7bf272d4e1e9b0af1c15e6ceeb6e1b91afba327e
Reviewed-on: https://review.typo3.org/55835
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
19 months ago[BUGFIX] Fix miscellaneous palette in pages table 22/55822/4
Armin Vieweg [Tue, 20 Feb 2018 11:30:15 +0000 (12:30 +0100)]
[BUGFIX] Fix miscellaneous palette in pages table

Removed unnecessary locallang reference for field "editlock"
in showitem string. This field has been moved to access tab.

Resolves: #83974
Branches: master, 8.7
Change-Id: I85201f552a67badca420386bb615bcc571a712db
Reviewed-on: https://review.typo3.org/55822
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] EXT:form - fix design glitches of new element modal 32/55832/5
Andreas Steiger [Tue, 20 Feb 2018 16:19:30 +0000 (17:19 +0100)]
[BUGFIX] EXT:form - fix design glitches of new element modal

Streamline the markup of the new element modal of the form editor and
fix some style glitches due to side effects with other extensions.

Resolves: #82444
Releases: master, 8.7
Change-Id: Ifceac76a70dd4744f52da3b08ca8baea5f4adb7d
Reviewed-on: https://review.typo3.org/55832
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Adjust side-effects for TcaSelectItems test cases 31/55831/6
Oliver Hader [Tue, 20 Feb 2018 16:13:19 +0000 (17:13 +0100)]
[BUGFIX] Adjust side-effects for TcaSelectItems test cases

Resolves: #83980
Related: #83975
Releases: master
Change-Id: I2e8a9f3a5682644ef1dd1f3746be961a93ccafca
Reviewed-on: https://review.typo3.org/55831
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Ensures call of synchronizeFieldValues with valid arguments 58/55758/3
Joerg Kummer [Fri, 16 Feb 2018 18:05:16 +0000 (19:05 +0100)]
[BUGFIX] Ensures call of synchronizeFieldValues with valid arguments

Let 8.7 installtool upgrade wizard L10nModeUpdater ignore synchronization if parent entry of given translations is set to deleted

Resolves: #83940
Releases: master, 8.7
Change-Id: Ie240f71ecf42564c0547abd2dfa5c5efb23c6385
Reviewed-on: https://review.typo3.org/55758
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Michael Semle <michael.semle@b13.de>
Tested-by: Michael Semle <michael.semle@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Notice free TcaSelectItems testing 23/55823/3
Christian Kuhn [Tue, 20 Feb 2018 11:41:48 +0000 (12:41 +0100)]
[BUGFIX] Notice free TcaSelectItems testing

Making FormEngine data providers notice free is a mixture of
fixing notices in the test subject, and improving test setup:
* It is assumed that stuff like BE_USER and LANG object exists,
  $subject access to these globals which throw notices is not
  fixed, instead the test setup is changed to mock these where
  needed.
* Data provider which have dependencies to other data prodivers
  assume their data is properly set, too. In those cases the
  test setup porperly sets this dependent data.
* Various other "real" notice fixes in test subject and code
  called by the test subject is actually fixed.

Change-Id: I7ae6444dc646ec114c15b2738ef4e30f67f88595
Resolves: #83975
Releases: master
Reviewed-on: https://review.typo3.org/55823
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Migrate Icons to TypeScript 91/55791/5
Andreas Fernandez [Sun, 18 Feb 2018 18:19:34 +0000 (19:19 +0100)]
[TASK] Migrate Icons to TypeScript

Change-Id: I4fa87602661e631adfe29d16e0f5bf31bb0f1104
Resolves: #82591
Releases: master
Reviewed-on: https://review.typo3.org/55791
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
19 months ago[TASK] EXT:form - Rename "Vendor" javascript folder to "Contrib" 15/55815/3
Ralf Zimmermann [Tue, 20 Feb 2018 06:50:42 +0000 (07:50 +0100)]
[TASK] EXT:form - Rename "Vendor" javascript folder to "Contrib"

Move folder typo3/sysext/form/Resources/Public/JavaScript/Backend/Vendor
to typo3/sysext/form/Resources/Public/JavaScript/Contrib.

Resolves: #83879
Releases: master, 8.7
Change-Id: I35cefa13bcfa621d4877273267d58ff4e26cd5bd
Reviewed-on: https://review.typo3.org/55815
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Remove unused Bootstrap dependency from frontend request handler 95/55795/6
Benjamin Franzke [Mon, 19 Feb 2018 13:05:36 +0000 (14:05 +0100)]
[TASK] Remove unused Bootstrap dependency from frontend request handler

Due to moving BE user authentication to a middleware, the Bootstrap
instance is no longer needed in the frontend request handler.

As the backend request handler is free of a Bootstrap dependency as well,
we can also remove the Bootstrap injection in Http\AbstractApplication.

The installer and legacy request handlers are unaffected:
 * The installer application instantiates the request handler on its own.
 * Legacy request handlers are dispatched by the legacy request handler
   middleware which keeps passing in a Bootstrap instance

Releases: master
Resolves: #83961
Related: #83959
Change-Id: I85552b4b1734cdf75d96395ae7610ab19f0bf29c
Reviewed-on: https://review.typo3.org/55795
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Remove ErrorIconViewHelper and move logic into model and template 63/55763/6
Georg Ringer [Fri, 16 Feb 2018 18:53:36 +0000 (19:53 +0100)]
[TASK] Remove ErrorIconViewHelper and move logic into model and template

Simplify generation of the error icon by removing the ViewHelper and
generate the icon identifier in the model instead.

As the ViewHelper is no public API it can be removed without a RST file.

Resolves: #83945
Releases: master
Change-Id: I7515ff69a729ccb66288437f5236a1ce8fa591c1
Reviewed-on: https://review.typo3.org/55763
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[BUGFIX] Use language fields as defined in TCA for „Duplicate“ 41/55741/4
Andreas Fernandez [Thu, 15 Feb 2018 19:03:55 +0000 (20:03 +0100)]
[BUGFIX] Use language fields as defined in TCA for „Duplicate“

Change-Id: I123e6dae9b0b6a5bb68261bc9ae5aaf75a64822d
Resolves: #83926
Related: #83892
Releases: master
Reviewed-on: https://review.typo3.org/55741
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Catch exception in record editing if current record is deleted 30/55730/2
Georg Ringer [Thu, 15 Feb 2018 07:08:29 +0000 (08:08 +0100)]
[TASK] Catch exception in record editing if current record is deleted

If an edit form is reloaded after the record has been deleted,
a message should be shown to the user instead of an exception.

Resolves: #83903
Releases: master, 8.7
Change-Id: Ib427ee8601a70c53d63f1afea7f1eacc71fd5da1
Reviewed-on: https://review.typo3.org/55730
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Remove unused ViewHelpers from extension manager 34/55734/6
Georg Ringer [Thu, 15 Feb 2018 12:52:27 +0000 (13:52 +0100)]
[TASK] Remove unused ViewHelpers from extension manager

Several ViewHelpers inside the extension maanger are not used and
can be removed. As those are not public API no RST file or deprecation
is required.

Resolves: #83937
Releases: master
Change-Id: I0bb551e14062e805ef8b23559bcc22ae32a8e399
Reviewed-on: https://review.typo3.org/55734
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Move BE User initialization into PSR-15 middleware 93/55793/3
Benni Mack [Mon, 19 Feb 2018 09:14:54 +0000 (10:14 +0100)]
[TASK] Move BE User initialization into PSR-15 middleware

The initialization of a Backend user for Frontend Contexts is currently
bound to TSFE, however, the only parts where TSFE is actually
needed is to set the flag "beUserLogin".

Additionally, the initialization of the Language object is now
moved into the middleware, directly after the set up of $GLOBALS['BE_USER']
to allow the admin panel to use $GLOBALS['LANG'] as well.

Further steps are to deprecate "$TSFE->initializeBackendUser()" method,
and to deprecate the hooks, as they can now be implemented as PSR-15
middlewares.

Additional cleanups on the Authentication object will follow separately
once all Middlewares and the Request object are in place.

For now, this patch aims to extract the logic and keep maximum backwards-
compatibility.

Resolves: #83959
Releases: master
Change-Id: Ia4055f2d3671e9c14e492baa4eea724d989e9521
Reviewed-on: https://review.typo3.org/55793
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Move FE User initialization into PSR-15 middleware 53/55753/4
Benni Mack [Fri, 16 Feb 2018 12:13:12 +0000 (13:13 +0100)]
[TASK] Move FE User initialization into PSR-15 middleware

The initialization of a frontend user is currently bound to TSFE,
however, the only parts where TSFE is actually needed is to
set the frontenduserauthentication object to $TSFE->fe_user
and to call a post-processing hook, which could be dealt with
through a middleware for extensions.

Further steps are to deprecate "initFEuser()" method, and to move
the transferring of the user session into the FrontendUser object
itself, once this is not using superglobals instead anymore.

Additional cleanups on the Authentication object will follow separately
once all Middlewares and the Request object are in place.

For now, this patch aims to extract the logic and keep maximum backwards-
compatibility.

Resolves: #83936
Releases: master
Change-Id: Id51b49f41336717fde4606a71ec6b2c805662b88
Reviewed-on: https://review.typo3.org/55753
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[TASK] Migrate ToggleSearchToolbox to TypeScript 76/55776/4
Andreas Fernandez [Sat, 17 Feb 2018 17:58:52 +0000 (18:58 +0100)]
[TASK] Migrate ToggleSearchToolbox to TypeScript

Change-Id: Ib06890d7697f0a819d436b679995162cba5543fe
Resolves: #82605
Releases: master
Reviewed-on: https://review.typo3.org/55776
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
19 months ago[TASK] Migrate Severity to TypeScript 80/55780/5
Andreas Fernandez [Sat, 17 Feb 2018 18:46:43 +0000 (19:46 +0100)]
[TASK] Migrate Severity to TypeScript

Change-Id: I5b738983f733da77100830b841419ba9d12fdf23
Resolves: #83955
Releases: master
Reviewed-on: https://review.typo3.org/55780
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
19 months ago[TASK] Deprecate array handling in AbstractTreeView 22/55722/3
Christian Kuhn [Wed, 14 Feb 2018 23:01:14 +0000 (00:01 +0100)]
[TASK] Deprecate array handling in AbstractTreeView

The array handling in AbstractTreeView has not been used
in the core for quite some while. To clean that class up
a bit, the functionality is now deprecated.

Deprecation is covered by the extension scanner, except the
class property $this->data which is too common and would
create way too many false positives.

Change-Id: I7bafdab242bf3d568c733cec669e895b87498241
Resolves: #83904
Releases: master
Reviewed-on: https://review.typo3.org/55722
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
19 months ago[TASK] Remove "Set" button in belog extension 17/55717/4
Gianluigi Martino [Wed, 14 Feb 2018 15:09:48 +0000 (16:09 +0100)]
[TASK] Remove "Set" button in belog extension

The "Set" button is obsolete because the filter change automatically on dropdown select.

Resolves: #83895
Releases: master, 8.7
Change-Id: I0f0acf05a5c06395bb8710829d68e5add9462d94
Reviewed-on: https://review.typo3.org/55717
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
19 months ago[BUGFIX] Show links to missing records in InputLink 51/55751/4
Alexander Opitz [Fri, 16 Feb 2018 10:10:21 +0000 (11:10 +0100)]
[BUGFIX] Show links to missing records in InputLink

If the linked record wasn't found (wrong uid, removed from database) we
check before trying to gather an icon for the non-existing record.

Resolves: #81804
Releases: master, 8.7
Change-Id: Ie06ec8a614650d8147f143cda8d8e6a9cb3e98e9
Reviewed-on: https://review.typo3.org/55751
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
19 months ago[TASK] Add composer.json integrity check 85/55785/7
Mathias Schreiber [Sat, 17 Feb 2018 20:40:05 +0000 (21:40 +0100)]
[TASK] Add composer.json integrity check

Each composer.json file in a system extension now has its dependencies
checked against the root composer.json to avoid errors after the subtree split.

Resolves: #83957
Releases: master, 8.7
Change-Id: Ibf37bd56fd1534b14e714dfdfaaf6374a48978c4
Reviewed-on: https://review.typo3.org/55785
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Synchronize root composer.json with ext:core composer.json 83/55783/2
Christian Kuhn [Sat, 17 Feb 2018 20:03:19 +0000 (21:03 +0100)]
[BUGFIX] Synchronize root composer.json with ext:core composer.json

Version constraints must be identical to not spoil
composer single extension installations.

Change-Id: Ic799ef5d5f695072618d8a500c4fca52a68f9803
Resolves: #83956
Releases: master
Reviewed-on: https://review.typo3.org/55783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Add CGL check for CSV fixtures 60/55760/12
Mathias Schreiber [Fri, 16 Feb 2018 18:25:49 +0000 (19:25 +0100)]
[TASK] Add CGL check for CSV fixtures

We now make sure that invalid CSV no longer gets merged
into TYPO3s core.

Resolves: #83943
Releases: master, 8.7
Change-Id: If8b6a20b3ccf9cbcdc3ffe0e74733dfd941c09d5
Reviewed-on: https://review.typo3.org/55760
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Unify installation tests 70/55770/6
Anja Leichsenring [Sat, 17 Feb 2018 10:24:52 +0000 (11:24 +0100)]
[TASK] Unify installation tests

MySql receives a test to install the introduction package, PgSql gets
one for the blank page preset.
With this change, both install suites check both kind of setup the
instance.

Change-Id: Ic21091f5bc3a0aa14a49e9e9fa65a5f9db829cdb
Resolves: #83949
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55770
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[FEATURE] Allow deactivation of FormDataProviders 24/55724/3
Christian Kuhn [Thu, 15 Feb 2018 00:18:44 +0000 (01:18 +0100)]
[FEATURE] Allow deactivation of FormDataProviders

To manipulate the FormEngine data provider list by extensions,
it can be helpful to just set a data provider as disabled
and add an own one after the disabled one and before the
next one. This avoids funny array munging and dependency
shuffling if an extension author needs to substitute an
entire data provider with an own solution.

The concept has been implemented for node expansion
render types in a similar way and is repeated here.

Change-Id: Ia1f2de94940248b60e851c7b9968539f5ab0ef79
Resolves: #83906
Releases: master
Reviewed-on: https://review.typo3.org/55724
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[FEATURE] Allow deactivation of PSR-15 middlewares 25/55725/5
Christian Kuhn [Thu, 15 Feb 2018 01:20:19 +0000 (02:20 +0100)]
[FEATURE] Allow deactivation of PSR-15 middlewares

Similar to other places that use dependency configurations
via arrays, the middleware stack configuration now allows
disabling single middlewares by setting disabled=true.

Change-Id: I42c741062b5f6952577e164939593f0553b1ad31
Resolves: #83907
Related: #83906
Related: #83725
Releases: master
Reviewed-on: https://review.typo3.org/55725
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Respect casing in CommandLineBackendUserRemovalUpdate 43/55743/15
Anja Leichsenring [Thu, 15 Feb 2018 19:27:13 +0000 (20:27 +0100)]
[BUGFIX] Respect casing in CommandLineBackendUserRemovalUpdate

System extensions used to create their _cli_* users lowercased.
The wizard queries only for uppercase varieties. Adding a LOWER
command to the where-clause catches now all casings.

Change-Id: I556f0181416067479ff579d2498389a564c6a5e3
Resolves: #83927
Relates: #79276
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55743
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Rewrite DragUploader in TypeScript 95/55295/13
Andreas Wolf [Sun, 7 Jan 2018 16:38:48 +0000 (17:38 +0100)]
[TASK] Rewrite DragUploader in TypeScript

Change-Id: If1aeff95d06e98e9c5a3725445bc616552c1eb14
Resolves: #82585
Releases: master
Reviewed-on: https://review.typo3.org/55295
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Move HTML generation in RemoveUserViewHelper to the view 33/55733/5
Georg Ringer [Thu, 15 Feb 2018 12:42:40 +0000 (13:42 +0100)]
[TASK] Move HTML generation in RemoveUserViewHelper to the view

Instead of creating the HTML in the ViewHelper it should be done in
the template.

Resolves: #83918
Releases: master
Change-Id: I8e9aaf51f23cd8808cc2910d6e8668f27671cf66
Reviewed-on: https://review.typo3.org/55733
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Use correct content types in backend ajax and eID responses 66/55766/6
Benjamin Franzke [Fri, 16 Feb 2018 19:38:44 +0000 (20:38 +0100)]
[BUGFIX] Use correct content types in backend ajax and eID responses

Due to the recent changes in the commit:
    e487cf526980570aa8f7a92d170bf439637c5972
    [TASK] Create own response instance in controller actions

..ajax routes and eID handlers that used a *pre-generated* Response
object (from the RequestHandler) now return different Content-Type
headers than before.

For backend ajax request applicaton/json was set by default,
for eID scripts no Content-Type was set (by default).

Change these controllers to use JsonResponse or a plain Response
to reflect the previous state..

The changes in this commit were intended to be squashed into the
mentioned commit – but this commit was too late. Therefore other (a bit)
unrelated optimizations to changes that patch made are included.

Change-Id: Icfdcd02d353dfaf48ad959c50be4802349eaaacd
Releases: master
Resolves: #83946
Related: #83939
Reviewed-on: https://review.typo3.org/55766
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Add UnitTest for Compatibility7ExtractionUpdate 71/55771/5
Anja Leichsenring [Sat, 17 Feb 2018 12:22:48 +0000 (13:22 +0100)]
[TASK] Add UnitTest for Compatibility7ExtractionUpdate

Change-Id: I2450313e4fb470a62f9bb4e371e0200c720bb4b5
Resolves: #83950
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55771
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Migrate DocumentHeader to TypeScript 74/55774/3
Andreas Fernandez [Sat, 17 Feb 2018 15:14:06 +0000 (16:14 +0100)]
[TASK] Migrate DocumentHeader to TypeScript

Change-Id: I44878243205274bac6e328ee8f1e4db79377869c
Resolves: #82584
Releases: master
Reviewed-on: https://review.typo3.org/55774
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Fix CSV fixtures in core 65/55765/4
Mathias Schreiber [Fri, 16 Feb 2018 20:33:41 +0000 (21:33 +0100)]
[BUGFIX] Fix CSV fixtures in core

All CSV fixtures are now a proper CSV file with a proper column count.
This makes editing them with a picky CSV editor possible again.

Resolves: #83941
Releases: master
Change-Id: Ic5f59c49fd3fa6ad98036f5392e36d450633d501
Reviewed-on: https://review.typo3.org/55765
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Test for dangling instances in unit test execution 69/55769/4
Christian Kuhn [Fri, 16 Feb 2018 22:11:35 +0000 (23:11 +0100)]
[TASK] Test for dangling instances in unit test execution

If a test adds some mock or prophecy revelation to the
GeneralUtility::makeInstance() stack using addInstance(),
it is important the test subject actually consumes that
instance. Otherwise, the dangling instance can have
side effects on other tests run afterwards.

The patch raises typo3/testing-framework from 3.0.0 to
3.1.0 which extends tearDown() with a test to verify the
instance stack is empty. If not, the test fails with
an accordig message.

composer command used:
composer update typo3/testing-framework

An @internal method to GeneralUtility is added to
retrieve the current instance stack, and one test
is fixed which violates this rule.

Change-Id: I769b82bf704834bf5d1718cbf39b9b411438e30c
Resolves: #83948
Releases: master
Reviewed-on: https://review.typo3.org/55769
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Flacky acceptance test 67/55767/2
Christian Kuhn [Fri, 16 Feb 2018 20:08:19 +0000 (21:08 +0100)]
[BUGFIX] Flacky acceptance test

Better safeguard a BookmarkCest detail to
stabilize that patch again.

Change-Id: Ia873d1c8a04d0ef329c280ff5d4d7518c6b73e22
Resolves: #83947
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55767
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Unit tests call parent::tearDown() 61/55761/2
Christian Kuhn [Fri, 16 Feb 2018 18:25:12 +0000 (19:25 +0100)]
[BUGFIX] Unit tests call parent::tearDown()

For the memory garbage collection of UnitTestCase to kick in,
it is important that unit tests which implement tearDown()
call parent after their own job.

Fix some missing parent calls, refactor some other tests
slightly to live without tearDown() and activate two tests
that come with an invalid @depends annotation.

Change-Id: I51c7534ea3220ec63fd8c3efa94e8bf295590e68
Resolves: #83944
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55761
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Create own response instance in controller actions 54/55754/10
Christian Kuhn [Fri, 16 Feb 2018 13:03:09 +0000 (14:03 +0100)]
[TASK] Create own response instance in controller actions

To further support the PSR-7 / PSR-15 and removal of
GeneralUtility::_GP() and friends efforts, all controllers
no longer use the second 'ResponseInterface $response'
argument given by dispatchers: Dispatchers should not
assume which type of response a controller returns, there
is no point in preparing this object.

Instead, controllers now always create one of
HtmlResponse, JsonResponse or RedirectResponse on
their own and return these objects.

Changes overview:
* Always use "new" to instantiate a response, PSR-15
  middlewares allow fiddling with the object if needed,
  xclassing these classes is never needed, we instead
  can rely on proper API usage.
* All controller actions drop the second $response argument
  and add ResponseInterface return type hint.
* Some controllers action also drop first $request argument,
  but only if the action does not need access to ServerParams
  at all. Those controllers that access _GP or _POST or similar
  currently, keep $request for now - they have to be refactored
  later anyway and then need $request.

Change-Id: Icce283b3c19be14ef1adeec761cfd63c90ab24c5
Resolves: #83939
Releases: master
Reviewed-on: https://review.typo3.org/55754
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Properly check for HTTPS 50/55750/6
Alexander Opitz [Fri, 16 Feb 2018 09:08:07 +0000 (10:08 +0100)]
[TASK] Properly check for HTTPS

Take into account empty and "off" values for the HTTPS request variable
to support ISAPI with IIS.

Resolves: #81837
Releases: master, 8.7
Change-Id: I5937c506d3e36a2009a8da6e66724728654b4001
Reviewed-on: https://review.typo3.org/55750
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Deprecate TypoScriptFrontendController->page_cache_reg1 23/55723/2
Christian Kuhn [Wed, 14 Feb 2018 23:38:46 +0000 (00:38 +0100)]
[TASK] Deprecate TypoScriptFrontendController->page_cache_reg1

Property page_cache_reg1 is a poor man limited way to manipulate
page cache tagging. It has been of very little use and is
deprecated now.

The usage in indexed_search (which always only added the default "0"
to database) is dropped along the way.

Change-Id: I9ea129fc6d20adb7a35a719f3d9d630aa663952f
Resolves: #83905
Releases: master
Reviewed-on: https://review.typo3.org/55723
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Remove ClickMenuOnIconViewHelper of filelist extension 35/55735/4
Georg Ringer [Thu, 15 Feb 2018 13:01:12 +0000 (14:01 +0100)]
[TASK] Remove ClickMenuOnIconViewHelper of filelist extension

Move the templating code into the template instead of using a
ViewHelper.

Resolves: #83919
Releases: master
Change-Id: I3df5fc096cbb7d53406f46abca1ab83fdaabc709
Reviewed-on: https://review.typo3.org/55735
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Fix table markup in DragDropUploader 56/55756/4
Mathias Schreiber [Fri, 16 Feb 2018 15:33:52 +0000 (16:33 +0100)]
[BUGFIX] Fix table markup in DragDropUploader

Resolves: #83938
Releases: master, 8.7
Change-Id: I71ddeb358cea2b24a4db46545a35ca956c6bc320
Reviewed-on: https://review.typo3.org/55756
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Unit test DataHandler->clearPrefixFromValue() 27/55727/6
Christian Kuhn [Thu, 15 Feb 2018 03:16:51 +0000 (04:16 +0100)]
[TASK] Unit test DataHandler->clearPrefixFromValue()

Add a unit test to support the change from issue #83870.

Change-Id: Ic8a1006c56989a1aa2ef2734e1320447875f1138
Resolves: #83909
Related: #83870
Releases: master
Reviewed-on: https://review.typo3.org/55727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[CLEANUP] Remove obsolete fixtures of Fluid unit tests 44/55744/4
Andreas Fernandez [Thu, 15 Feb 2018 19:29:24 +0000 (20:29 +0100)]
[CLEANUP] Remove obsolete fixtures of Fluid unit tests

Change-Id: I8a54c72090fc9e9d39fae1ddd13d8f72f691fcc0
Resolves: #83929
Related: #82414
Related: #79972
Related: #77127
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55744
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Move FE OutputCompression to PSR-15 46/55746/3
Benni Mack [Thu, 15 Feb 2018 20:25:53 +0000 (21:25 +0100)]
[TASK] Move FE OutputCompression to PSR-15

Output Compression should be separated from the request handling, and is
now moved into a PSR-15 middleware.

This change also decouples Output Compression from Bootstrap, and the
Request Handler, so it can be re-used in other areas.

Intentionally omitted is a proper cleanup (ob_get_clean) and an explicit
write to the response object (in the middleware). That's up for later
patches. The idea of this patch is to keep functionality identical for
now.

Resolves: #83931
Releases: master
Change-Id: Ic84707cac6c858698f290069f6aa492724ce0602
Reviewed-on: https://review.typo3.org/55746
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Move TSFE Initialization into a PSR-15 middleware 42/55742/2
Benni Mack [Thu, 15 Feb 2018 19:17:27 +0000 (20:17 +0100)]
[TASK] Move TSFE Initialization into a PSR-15 middleware

In order to have the main request handler only deal with content creation,
and especially to move fe_user / be_user initialization out of the RequestHandler,
and to remove dependencies from Bootstrap of the RequestHandler,
TSFE is now instantiated in a PSR-15 compatible middleware.

Resolves: #83928
Releases: master
Change-Id: I8a4dd4c10f5ea2eeb60f9870c34d04979a330826
Reviewed-on: https://review.typo3.org/55742
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Change the label for scheduler "Save and create" 36/55736/4
Tomas Norre Mikkelsen [Thu, 15 Feb 2018 13:10:50 +0000 (14:10 +0100)]
[TASK] Change the label for scheduler "Save and create"

The label for the "Save and create new document" in the scheduler module,
will be change to a more appropriate label "Save and create new task"

Resolves: #83920
Releases: master, 8.7, 7.6
Change-Id: Ic4d6ad9d4598aafbc16c03b5bc50789451f6cdaf
Reviewed-on: https://review.typo3.org/55736
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Simplify Frontend Request Handler 38/55738/2
Benni Mack [Thu, 15 Feb 2018 17:56:58 +0000 (18:56 +0100)]
[TASK] Simplify Frontend Request Handler

This patch improves the workflow readability by replacing variables,
simplifying if() clauses and orderings etc.

Resolves: #83922
Releases: master
Change-Id: I893ad348f8976dd65bf11a117f54433b46d0d896
Reviewed-on: https://review.typo3.org/55738
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Correct check for install tool requests in bootstrap 39/55739/2
Susanne Moog [Thu, 15 Feb 2018 18:32:49 +0000 (19:32 +0100)]
[BUGFIX] Correct check for install tool requests in bootstrap

Resolves: #83924
Releases: master, 8.7
Change-Id: If9f435c64addea63793586e131da19768749857c
Reviewed-on: https://review.typo3.org/55739
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Move "pageUnavailable_force" into a PSR-15 middleware 21/55721/5
Benni Mack [Wed, 14 Feb 2018 20:31:35 +0000 (21:31 +0100)]
[TASK] Move "pageUnavailable_force" into a PSR-15 middleware

The check if the frontend is in "maintenance mode",
set by $GLOBALS['TYPO3_CONF_VARS']['FE']['pageUnavailable_force'],
is moved into a custom PSR-15 based middleware,
effectively decoupling this logic from TSFE object.

Resolves: #83917
Releases: master
Change-Id: I38c42069b82ca2403df9aa4b0e66410a3dfe6404
Reviewed-on: https://review.typo3.org/55721
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Make PSR-15 middlewares use normalizedParams 31/55731/3
Benni Mack [Thu, 15 Feb 2018 10:35:15 +0000 (11:35 +0100)]
[TASK] Make PSR-15 middlewares use normalizedParams

This patch uses the newly introduced normalizedParams, marking
the first step away from GeneralUtility::getIndpEnv(), relying on a
given configuration instead of a superglobal option.

Resolves: #83915
Releases: master
Change-Id: I4b843a1b99c0ea4f30490ff80c4383653177c13b
Reviewed-on: https://review.typo3.org/55731
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Remove side effects from ErrorController tests 37/55737/4
Susanne Moog [Thu, 15 Feb 2018 15:23:58 +0000 (16:23 +0100)]
[BUGFIX] Remove side effects from ErrorController tests

Resolves: #83921
Releases: master
Change-Id: Icaa53e211ed2ca6ea9824a930960c2d9cee688ef
Reviewed-on: https://review.typo3.org/55737
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Notice free InlineStackProcessor testing 26/55726/2
Christian Kuhn [Thu, 15 Feb 2018 01:56:34 +0000 (02:56 +0100)]
[BUGFIX] Notice free InlineStackProcessor testing

Change-Id: I77a4782f250a4b37051eb321fd5c6670b4366e24
Resolves: #83908
Releases: master
Reviewed-on: https://review.typo3.org/55726
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Separate Error handling from TSFE 90/55690/20
Benni Mack [Mon, 12 Feb 2018 21:12:33 +0000 (22:12 +0100)]
[TASK] Separate Error handling from TSFE

The goal is to decouple error handling from TSFE.
For that, a new ErrorController is added which can be
called and returns a Response object instead of
exits the current request.

In order to keep full backwards-compatibility,
TSFE currently does not return a response, but
instead exists with a response object.

Next step:
- Move the pageUnavailable_force functionality into a middleware
- See what can be further abstracted to return a response

Resolves: #83883
Releases: master
Change-Id: I41f5f1a32a3f7edd48eb5c0464a26762ad4a946f
Reviewed-on: https://review.typo3.org/55690
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Allow chaining in class ModuleTemplate 28/55728/3
Christian Kuhn [Thu, 15 Feb 2018 03:55:37 +0000 (04:55 +0100)]
[TASK] Allow chaining in class ModuleTemplate

For slightly more dense code ModuleTemplate now
returns $this on setter methods to allow chaining.

Change-Id: Icd92d37370529a0535b4c2d5dcf2e588bd50a6ae
Resolves: #83910
Releases: master
Reviewed-on: https://review.typo3.org/55728
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Let Bamboo check for clean TypeScript build 16/55716/4
Andreas Fernandez [Wed, 14 Feb 2018 14:18:39 +0000 (15:18 +0100)]
[TASK] Let Bamboo check for clean TypeScript build

To avoid having stale TypeScript builds, Bamboo now recompiles every
TypeScript via grunt and checks for unwanted modifications.

Change-Id: I1d96bb81eff4d5c42332d0a27cce0a98a7d27478
Resolves: #83914
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55716
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Hide "Group by page" if only one page is shown in EXT:belog 18/55718/3
Gianluigi Martino [Wed, 14 Feb 2018 15:14:49 +0000 (16:14 +0100)]
[TASK] Hide "Group by page" if only one page is shown in EXT:belog

It is unnecessary to show the "Group by page" checkbox if "This page" is
selected in the "Depth" dropdown.
Thus, the checkbox is hidden in that case.

Resolves: #83896
Releases: master, 8.7
Change-Id: Idd3e0252c6bb06d2442ed4db95056e1e6d292c6c
Reviewed-on: https://review.typo3.org/55718
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Show duplicate button only if it makes sense 13/55713/4
Frank Naegler [Wed, 14 Feb 2018 12:10:00 +0000 (13:10 +0100)]
[BUGFIX] Show duplicate button only if it makes sense

Resolves: #83892
Related: #77685
Releases: master
Change-Id: I16a7d57efa7d75e712bba24724d4da365b0aa40a
Reviewed-on: https://review.typo3.org/55713
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Move check if workspaces extension is loaded to the controller 19/55719/2
Georg Ringer [Wed, 14 Feb 2018 16:11:55 +0000 (17:11 +0100)]
[TASK] Move check if workspaces extension is loaded to the controller

Instead of using a ViewHelper the logic can be moved to the controller
where it belongs.

As the ViewHelper is not a public API it can be dropped without a
RST file.

Resolves: #83900
Releases: master
Change-Id: I8d089761b8a168f00cb0739742fa658d40687379
Reviewed-on: https://review.typo3.org/55719
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Set about module free from Extbase 14/55714/6
Benni Mack [Wed, 14 Feb 2018 13:04:54 +0000 (14:04 +0100)]
[TASK] Set about module free from Extbase

The whole Extbase stack for the about module
is not necessary, as there is only one action
in this controller, and it's a simple Fluid
action.

The module name is kept as "help_AboutAbout"
due to the uncool naming handling of Extbase magic.

Resolves: #83899
Releases: master
Change-Id: I6353c30528d619f849ea77774b16ff0eb499e820
Reviewed-on: https://review.typo3.org/55714
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Update typo3/cms-styleguide 15/55715/2
Christian Kuhn [Wed, 14 Feb 2018 13:08:02 +0000 (14:08 +0100)]
[TASK] Update typo3/cms-styleguide

composer update typo3/cms-styleguide

Version 9.0.2 brings examples of the new checkbox renderTypes
and a fal example using allowLanguageSynchronization

Change-Id: Ia5e8f6627a15a1db9aa20f9a7c9be39a375fc401
Resolves: #83893
Releases: master
Reviewed-on: https://review.typo3.org/55715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Show ordered PSR-15 middlewares in Configuration module 97/55597/5
Benni Mack [Wed, 7 Feb 2018 21:53:45 +0000 (22:53 +0100)]
[TASK] Show ordered PSR-15 middlewares in Configuration module

In order to find out what middlewares are called in which order,
the Configuration module now has an additional list of all
registered middlewares for "frontend" and "backend" stack.

Resolves: #83882
Releases: master
Change-Id: I99d8478bb07437efa65d292221ccdb03d5dd3161
Reviewed-on: https://review.typo3.org/55597
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[FEATURE] Add normalized server parameters to PSR-7 requests 06/55506/22
Christian Kuhn [Sun, 11 Feb 2018 09:41:20 +0000 (10:41 +0100)]
[FEATURE] Add normalized server parameters to PSR-7 requests

To slowly substitute GeneralUtility::getIndpEnv() with a
better API, a new class is introduced that calculates all
normalized server parameters.
The object is added as PSR-7 request attribute in a frontend
and backend middleware.
For a transition phase, the request is made available
as $GLOBALS['TYPO3_REQUEST'] until enough core code has
been refactored to get rid of this again.

Resolves: #83736
Releases: master
Change-Id: I96c8cb6dda4cc38bbb51b64439b8e81f2c00d7ac
Reviewed-on: https://review.typo3.org/55506
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Remove overkill extension classes in about module 10/55710/4
Benni Mack [Tue, 13 Feb 2018 23:34:26 +0000 (00:34 +0100)]
[TASK] Remove overkill extension classes in about module

When the about module (EXT:about) was refactored into
Extbase, a Repository and Domain Model for Extensions was
added to render title, key and authors of an extension.

For modules this was done directly in the controller,
which is 100% sufficient in this one-time case, instead
of doing it the Extbase(tm) persistence way.

This way, all data is fetched the same way in the about module.

The two domain model / repository classes are removed,
and due to the fact that they are not part of the API,
a RST file is not added.

Resolves: #83890
Releases: master
Change-Id: I1169336452d7497ea0ed2e1a99553c164ec78612
Reviewed-on: https://review.typo3.org/55710
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[FEATURE] Add possibility to use session data in TS conditions 10/55310/15
Wolfgang Klinger [Tue, 9 Jan 2018 19:17:56 +0000 (20:17 +0100)]
[FEATURE] Add possibility to use session data in TS conditions

Since the session API has been adjusted it is no longer possible
to access the (now protected) sesData property of the fe_user object.
Using TSFE:fe_user|sesData|foo|bar in a TS condition will trigger
a deprecation log entry.

Instead a cleaner approach is now available:
 [globalVar = session:foo|bar = 1234567]

Resolves: #83506
Releases: master
Change-Id: Idbb079334186eac1dfe062a71a601e556a9bd247
Reviewed-on: https://review.typo3.org/55310
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[!!!][TASK] Handle E_NOTICE free unit tests 97/55697/10
Christian Kuhn [Tue, 13 Feb 2018 14:32:21 +0000 (15:32 +0100)]
[!!!][TASK] Handle E_NOTICE free unit tests

Raise typo3/testing-framework from 2.0.4 to 3.0.0:
composer require --dev typo3/testing-framework ^3.0

The new typo3/testing-framework version comes with a change
that no longer suppresses E_NOTICE PHP errors by default and lets
tests fail that raise them.

The static property $suppressNotices in unit test files is set to
true for all test cases that currently raise E_NOTICE errors to
suppress them on a by-file basis.

Further patches should remove this property one-by-one again by
fixing the system under test the unit test case handles.

Change-Id: I7d44fe3723ce5820a37051ae31f16b2f142ffba6
Resolves: #83889
Related: #83888
Releases: master
Reviewed-on: https://review.typo3.org/55697
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[BUGFIX] Cleanup Spool Mailer feature 07/55707/7
Benni Mack [Tue, 13 Feb 2018 21:51:19 +0000 (22:51 +0100)]
[BUGFIX] Cleanup Spool Mailer feature

The default file path is not set, so the admin has to set this
to a sensible default outside the web folder when he/she wants
to use it.

Additionally, some CGL fixes and cleanups are applied.

Resolves: #83880
Related: #76349
Releases: master
Change-Id: Ibb3ce564cdfeb474f963c5900fc4bb21e4b7d1a4
Reviewed-on: https://review.typo3.org/55707
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[TASK] Update typo3/testing-framework 08/55708/3
Christian Kuhn [Tue, 13 Feb 2018 21:57:59 +0000 (22:57 +0100)]
[TASK] Update typo3/testing-framework

Raise from 2.0.3 to 2.0.4 in master and
from 1.2.2 to 1.2.3 in v8. Brings a patch
to hopefully stabilize acceptance tests again.

composer command used:
composer update typo3/testing-framework

Change-Id: I87d5a65b52bca6eceae805c5edbb13c7eccd1010
Resolves: #83887
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55708
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Remove console.log() from compiled InfoWindow.js 06/55706/2
Andreas Fernandez [Tue, 13 Feb 2018 21:46:26 +0000 (22:46 +0100)]
[BUGFIX] Remove console.log() from compiled InfoWindow.js

Resolves: #83886
Related: #83844
Releases: master
Change-Id: I2eca96de481c9b3d4a660f7cfded99099ea87743
Reviewed-on: https://review.typo3.org/55706
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[BUGFIX] Handle settings for report / check in linkvalidator 28/52628/11
Thorben Nissen [Thu, 27 Apr 2017 08:13:03 +0000 (10:13 +0200)]
[BUGFIX] Handle settings for report / check in linkvalidator

The level and link type checkmark options are now handled seperately
for the "Report" and "Check Links" tab. This way, the options can
be changed independantly on each tab.

Resolves: #81035
Releases: master, 8.7
Change-Id: I772f885940791a17269c413185d3bea46695ff19
Reviewed-on: https://review.typo3.org/52628
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[FEATURE] Add interlace option for image conversion 53/47753/10
Richard Haeser [Mon, 18 Apr 2016 15:11:23 +0000 (17:11 +0200)]
[FEATURE] Add interlace option for image conversion

When the option $GLOBALS['TYPO3_CONF_VARS'][GFX][processor_interlace]
is set, all images will be generated with the given interlace scheme.

Resolves: #48013
Releases: master
Change-Id: I9b78f8f27dd5223ac8e96ff33d1c26b5d1d6e1c9
Reviewed-on: https://review.typo3.org/47753
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Add missing htmlspecialchars() calls and cleanup in QueryView 11/55111/12
Stephan Großberndt [Sat, 16 Dec 2017 12:41:21 +0000 (13:41 +0100)]
[BUGFIX] Add missing htmlspecialchars() calls and cleanup in QueryView

Add missing htmlspecialchars() calls in
EXT:core/Classes/Database/QueryView.php and do cleanup.

Resolves: #83354
Releases: master, 8.7
Change-Id: I71c463e1a2912aa20535c7a1bbc0c690560f7e63
Reviewed-on: https://review.typo3.org/55111
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Remove two unused settings from LocalConfiguration 96/55696/2
Christian Kuhn [Tue, 13 Feb 2018 12:02:33 +0000 (13:02 +0100)]
[TASK] Remove two unused settings from LocalConfiguration

The two (internal) settings 'SYS/isInitialInstallationInProgress' and
'SYS/isInitialDatabaseImportDone' have been obsoleted with
the install tool rewrite in v9 and can be removed from
LocalConfiguration using the SilentConfigurationUpgradeService.

Change-Id: I6c80506f2389004093f43ff9fc3df49b002e1438
Resolves: #83878
Releases: master
Reviewed-on: https://review.typo3.org/55696
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[FEATURE] Add duplicate button 01/53101/19
Willi Wehmeier [Sat, 3 Jun 2017 18:35:05 +0000 (20:35 +0200)]
[FEATURE] Add duplicate button

This patch provides a new "duplicate" button inside of the topbar of the
edit record form next to the close button. This button creates and opens
a new copy of the current element which is positioned right below the
existing one.
If there are unsaved changes in the currently open record, a modal
appears with options to cancel, dismiss the changes and clone or save
the changes and clone the changed record.

Resolves: #77685
Releases: master
Change-Id: I9e2a0f02fc9c4452f0a7d868ea17aeacb9375d95
Reviewed-on: https://review.typo3.org/53101
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Add missing space in regular expression 94/55694/5
Wolfgang Klinger [Tue, 13 Feb 2018 07:12:54 +0000 (08:12 +0100)]
[BUGFIX] Add missing space in regular expression

DataHandler::clearPrefixFromValue is missing a space
in the regular expression when removing the prependAtCopy
label. That leads to wrong headers in copied elements.

Releases: master
Resolves: #83870
Change-Id: I49cde9a9a20686715d9b042173f89bfeb2bd112f
Reviewed-on: https://review.typo3.org/55694
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Fix backend user check in ProductionExceptionHandler 88/55688/5
Benjamin Franzke [Mon, 12 Feb 2018 20:49:40 +0000 (21:49 +0100)]
[BUGFIX] Fix backend user check in ProductionExceptionHandler

Uncaught Error: Call to a member function isBackendUserLoggedIn() on null
in […]/typo3/sysext/core/Classes/Error/ProductionExceptionHandler.php:103

Change-Id: I0052c2c1cd617282dbc65320933f8577038ab41c
Releases: master, 8.7
Resolves: #83867
Reviewed-on: https://review.typo3.org/55688
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Show ImageMagick command on failure 89/55689/2
Tymoteusz Motylewski [Mon, 12 Feb 2018 21:02:44 +0000 (22:02 +0100)]
[BUGFIX] Show ImageMagick command on failure

Install tool now shows an ImageMagick command which
failed.

Resolves: #83868
Releases: master
Change-Id: I4555d2ccdf68eea9180b8c7d2671b11e9b637709
Reviewed-on: https://review.typo3.org/55689
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Directly wire Application and RequestHandler 42/55642/11
Benjamin Franzke [Thu, 8 Feb 2018 23:40:18 +0000 (00:40 +0100)]
[TASK] Directly wire Application and RequestHandler

The frontend and backend Application and RequestHandler classes
are tightly coupled since the frontend eID request handler was
moved into a middleware and the backend ajax request handler
was merged with the regular request handler. (1:1 relationship)

There is no (longer) need to resolve the request handler in
Bootstap. For the install application we are still using two
request handlers but will dispatch them from within the
application now.

That means the call chain is now:
 Application -> RequestHandler
instead of:
 Application -> Bootstrap -> RequestHandler

That allows us to deprecate all HTTP related code in Bootstrap (with
a separate commit) and instead implement that in an HTTP specific
ApplicationTrait.

This patch introduces a legacy RequestHandler dispatcher middleware
which ensures that registering custom request handlers using
Bootstrap::registerAdditionalRequestHandler() still works for the
frontend and backend.
(although it is marked @internal, there is interest to not just
drop this)

Change-Id: Id80158bb3d078719f6508ae950b2f32f018e1ac4
Releases: master
Resolves: #83864
Reviewed-on: https://review.typo3.org/55642
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Use Logging API for scheduler logging 70/55670/7
Benni Mack [Mon, 12 Feb 2018 08:49:07 +0000 (09:49 +0100)]
[TASK] Use Logging API for scheduler logging

The custom logging of the scheduler pollutes the sys_log table
by default in all installations.

Switching to proper logging API allows to log to more custom processors.

Resolves: #83866
Releases: master
Change-Id: I2bd0a13cf55f70f8accc6a799099f713c648aac2
Reviewed-on: https://review.typo3.org/55670
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>