Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Return InaccessibleFolder for non existing processed folder 97/36397/3
Frans Saris [Fri, 30 Jan 2015 08:50:03 +0000 (09:50 +0100)]
[BUGFIX] Return InaccessibleFolder for non existing processed folder

When the processed folder of a folder isn't present the ResourceStorage
tries to create it. When storage is offline or write-only this will fail
and as a result you run into exceptions on several places in BE.

This change makes sure there is a InaccessibleFolder object returned
in these cases.

Resolves: #61688
Releases: master, 6.2
Change-Id: Ie32c09f8d322914234860903c18ca44ff5cbf5db
Reviewed-on: http://review.typo3.org/36397
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Scheduler: Fix task group issues 59/35759/3
Mathias Schreiber [Sat, 3 Jan 2015 13:49:34 +0000 (14:49 +0100)]
[BUGFIX] Scheduler: Fix task group issues

Do not list deleted task groups as option when creating new tasks.
Display tasks assigned to a deleted group in the un-grouped block.

Resolves: #63973
Releases: master, 6.2
Change-Id: I0f9b4a01f03f49881883d9dafad2354bb7526fb2
Reviewed-on: http://review.typo3.org/35759
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] DateValidator fails to validate incorrect dates 69/36469/2
Nicole Cordes [Fri, 30 Jan 2015 18:35:11 +0000 (19:35 +0100)]
[BUGFIX] DateValidator fails to validate incorrect dates

If the function "strptime" is not present in the environment (mostly on
Windows systems) the fallback to check a given date in the dateValidator
fails to detect invalid dates. The conversion from the given string to
a date object respects invalid dates and just converts them to valid
ones (by moving in next month/year). Therefore the function returns an
object instead of false. This patch adds a value comparison between old
and new value to be sure still the same date string is returned.

Releases: master, 6.2
Resolves: #64661
Change-Id: I739d309278143bb5fc24c48ca7bb884a1e25a442
Reviewed-on: http://review.typo3.org/36469
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[BUGFIX] FAL Indexer follow symlinks now 70/36470/2
Roman Schuermann [Fri, 30 Jan 2015 14:14:37 +0000 (15:14 +0100)]
[BUGFIX] FAL Indexer follow symlinks now

Currently the indexing scheduler task from FAL ignores symlinks and all files behind symlinks are not indexed.

Resolves: #60511
Releases: master
Change-Id: If4eb503e96eccebaf39a9f3ba48ffc469e038f4b
Reviewed-on: http://review.typo3.org/36470
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Distributions: Import files before database 66/36466/2
Sascha Egerer [Fri, 21 Nov 2014 08:27:39 +0000 (09:27 +0100)]
[BUGFIX] Distributions: Import files before database

The distribution import does sometimes not import the Assets
(Resources/Files/) of the distribution. This is because the
t3d-file is imported before the files are imported.
That means that the t3d import will create FAL file relations
to files that do not exists. This will end up in an FAL exception.
Files should be imported before the t3d-file is imported.

Resolves: #63121
Releases: master,6.2
Change-Id: Ibb3695b0b92ed2a257380c8684e4451851a2248f
Reviewed-on: http://review.typo3.org/36466
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Always display errors when running the tests 65/36465/2
Oliver Klee [Fri, 30 Jan 2015 18:01:50 +0000 (19:01 +0100)]
[TASK] Always display errors when running the tests

With some default php.ini files (e.g., the file shipped with MAMP PRO),
display_errors is set to "off", and the memory limit is rather low.

As the bootstraps for the unit and functional tests do not read the
current installation's settings, the default values from the php.ini
are used. This can cause the tests to fail at some point due to
insufficient memory, but without any visible messages.

This change makes sure that PHP errors always are output when running
the unit or functional tests using the Core bootstrap files.

Resolves: #64659
Releases: master, 6.2
Change-Id: I28773515b354811a42f0ce262e950603218927b6
Reviewed-on: http://review.typo3.org/36465
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Failing unit test in SqlSchemaMigrationServiceTest 63/36463/2
Nicole Cordes [Fri, 30 Jan 2015 17:46:55 +0000 (18:46 +0100)]
[BUGFIX] Failing unit test in SqlSchemaMigrationServiceTest

Currently the test for handling multiple white spaces within the sql
field definitions fails on Windows systems because of a different key
for the table name within the expected and actual array. This is caused
by a strict lowercase converting in the code for Windows systems. As the
table name is irrelevant for the test itself, this patch simply converts
table name to lower case.

Releases: master, 6.2
Resolves: #64657
Change-Id: I8d083e988b9a7403f0ff514af1ebe54adf065383
Reviewed-on: http://review.typo3.org/36463
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Failing unit tests due to wrong path handling 58/36458/2
Nicole Cordes [Fri, 30 Jan 2015 17:07:21 +0000 (18:07 +0100)]
[BUGFIX] Failing unit tests due to wrong path handling

In some tests of the StandaloneViewTest case the configured expections
aren't met which results in failing tests on Windows systems. The mock
is configured to return values when calling with giving parameter. The
parameter contains the path to a layout root. During runtime the used
paths are converted to unix like paths but the tests are configured to
expect Windows paths (forward slashes vs. backward slashes). This patch
converts paths to unix like paths before the expectations are configured
to not fail on Windows systems.

Releases: master, 6.2
Resolves: #64656
Change-Id: Ie362cc4e2efa41b6cee068e60313c1bfb22340b2
Reviewed-on: http://review.typo3.org/36458
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Followup to remove PHP5.5 only syntax 57/36457/3
Anja Leichsenring [Fri, 30 Jan 2015 17:25:15 +0000 (18:25 +0100)]
[BUGFIX] Followup to remove PHP5.5 only syntax

Patch #36454 introduced by accident a ::class call, which will
break in PHP versions < 5.5

Change-Id: I0ce3b813fc8a176a9ce9e993474f2668bf2cab01
Resolves: #62829
Releases: 6.2
Reviewed-on: http://review.typo3.org/36457
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Proper error handling of ResourceDoesNotExistException 20/36420/2
ruud [Thu, 29 Jan 2015 17:44:19 +0000 (18:44 +0100)]
[BUGFIX] Proper error handling of ResourceDoesNotExistException

Handles and displaying a proper error message when
ResourceDoesNotExistException is thrown.

Resolves: #56997
Releases: master, 6.2
Change-Id: I193f9eac929f856d2d195307110d2c18122c8bb9
Reviewed-on: http://review.typo3.org/36420
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Wrong generation of metadata in FAL 54/36454/2
Frederic Gaus [Tue, 11 Nov 2014 18:35:36 +0000 (19:35 +0100)]
[BUGFIX] Wrong generation of metadata in FAL

This patch fixes the generation of metadata if the metadata
of a file is missing in sys_file_metadata. Without this patch
the metadata is generated without taking care of images and their
width and height. As a result, images are generated with
width=0 height=0. See bugreport for details.

The change also introduces the basic structure to fetch
general info of files via the SplFileInfo objects API.

Resolves: #62829
Releases: master, 6.2
Change-Id: Ie99fc74f3439cef5dbd3702e57596b37390da679
Reviewed-on: http://review.typo3.org/36454
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Change visibility of suhosin specific checks in SystemEnvironment 53/36453/2
Göran Bodenschatz [Fri, 30 Jan 2015 15:52:52 +0000 (16:52 +0100)]
[TASK] Change visibility of suhosin specific checks in SystemEnvironment

As the PHP extension suhosin is currently not distributed in a larger
manner (e. g. Debian dropped support), the checks for load status and
suhosin specific parameters in Install Tool are only displayed if the
extension is available and loaded.

Resolves: #64647
Releases: master, 6.2
Change-Id: Iac2e984031c84f28f2d41fb6cf69ffbe1d5f6045
Reviewed-on: http://review.typo3.org/36453
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Failing unit test in Dbal\DatabaseConnectionTest 52/36452/2
Nicole Cordes [Fri, 30 Jan 2015 16:15:15 +0000 (17:15 +0100)]
[BUGFIX] Failing unit test in Dbal\DatabaseConnectionTest

There is one test to be sure 64bit integer values are stored correctly
in the database. This test obviously has to fail on 32bit systems as
they can't handle 64bit values. The patch disables the test for
unsupported systems.

Releases: master, 6.2
Resolves: #64651
Change-Id: I4f1047c19f4ba79df79ffdc92e38fb4f151d0add
Reviewed-on: http://review.typo3.org/36452
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Display correct list of file ids in BE module list 45/36445/2
alinafleser [Thu, 29 Jan 2015 19:42:23 +0000 (21:42 +0200)]
[BUGFIX] Display correct list of file ids in BE module list

TYPO3\CMS\Backend\Utility\BackendUtility::getProcessedValue is now
considering foreign_match_fields when processing IRRE fields

Resolves: #62755
Releases: master, 6.2
Change-Id: I45c742bca0b3a2822411f5693d8b9129bb101b24
Reviewed-on: http://review.typo3.org/36445
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[BUGFIX] Failling unit test in GeneralUtilityTest for Windows system 42/36442/2
Nicole Cordes [Fri, 30 Jan 2015 15:13:20 +0000 (16:13 +0100)]
[BUGFIX] Failling unit test in GeneralUtilityTest for Windows system

In GeneralUtilityTest a test for the TYPO3_SITE_PATH parses the result
for a starting slash. This test fails on Windows system as the don't
provide slashes but drive letters. This patch skips the test on Windows
systems and provides a new test to check for absolute paths with drive
letters.

Releases: master, 6.2
Resolves: #64644
Change-Id: I87bb9c7df7debd6e5d44602330587eff3c1cf4fd
Reviewed-on: http://review.typo3.org/36442
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fix handling of TCA allowed flag in ElementBrowser 39/36439/2
Sascha Egerer [Thu, 29 Jan 2015 23:23:19 +0000 (00:23 +0100)]
[BUGFIX] Fix handling of TCA allowed flag in ElementBrowser

If the 'allowed' flag in the element browser contains a '*', which
means any type of file, no file is displayed. This is because a filter
is added that only files are displayed that have a '*' as file ext.

The filter should not be added if the allowed value is '*' or empty.

Change-Id: I63016050a80c4f9d9bc0a4cd7c0dc7523ad9f58f
Resolves: #54504
Documentation: #64609
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36439
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] Pid property not set after insert 23/36423/2
Mathias Brodala [Mon, 15 Dec 2014 11:13:25 +0000 (12:13 +0100)]
[BUGFIX] Pid property not set after insert

After adding and persisting a new object, its uid property is set,
the same should happen for its pid property. This way the caller
can get to know where the object ended up being stored.

Resolves: #60544
Releases: master, 6.2
Change-Id: Ibd11918c06b52deac69a8c3b83c454e3f24462a8
Reviewed-on: http://review.typo3.org/36423
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Remove only 'CType' keys from wizard 21/36421/3
Göran Bodenschatz [Fri, 30 Jan 2015 13:00:58 +0000 (14:00 +0100)]
[BUGFIX] Remove only 'CType' keys from wizard

Check for key name of 'CType' before removing the content
element from new content wizard.

This is a regression from #23864 where a hardcoded
CType column check was removed that is actually required
in this case.

Resolves: #61114
Related: #23864
Releases: master, 6.2
Change-Id: Ib65410dee4f7328a3b8bbceaa21c8367843905f3
Reviewed-on: http://review.typo3.org/36421
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Ensure salted passwords are written to DB 09/36409/2
Markus Klein [Sun, 21 Dec 2014 13:43:45 +0000 (14:43 +0100)]
[BUGFIX] Ensure salted passwords are written to DB

Ensure that salted passwords are written to DB also when importing
data from t3d files.

Resolves: #61506
Releases: master, 6.2
Change-Id: Ia3ec443def54dcc98d12784da17e7abb6243c8f9
Reviewed-on: http://review.typo3.org/36409
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Fix import for fields of type input with link wizard 84/36384/2
Marc Bastian Heinrichs [Fri, 16 May 2014 10:41:06 +0000 (12:41 +0200)]
[BUGFIX] Fix import for fields of type input with link wizard

Fields of type import and link wizard could also contain a path to
a local file in addition to a direct file reference (file:42). The
refindex correctly analyse this relation and saves a db relation to
the uid of the sys_file records.

On imports this is not correct resolved back, but a value
"sys_file_{uid}" is saved.

In addition this patch fixes also a redundant inclusion of files
stored in fileadmin for such a field type, because of having a
sys_file db relation and a softreference.

Change-Id: I1399006b44f6a9365a92e42911cc3daaa8a81d89
Resolves: #58843
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36384
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Increase Install Tool font-size to 75% 83/36383/2
Mathias Schreiber [Mon, 19 Jan 2015 23:13:39 +0000 (00:13 +0100)]
[FEATURE] Increase Install Tool font-size to 75%

Since the font-size of the backend is bigger, the Install Tools font-
size is now bigger too.

Resolves: #64366
Releases: master, 6.2
Change-Id: If659e61a51a22d9a1ee64ea06c149958e15ef952
Reviewed-on: http://review.typo3.org/36129
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit fd8d149c064c1bfae3c77e40a77d8fbd06f96d78)
Reviewed-on: http://review.typo3.org/36383

4 years ago[BUGFIX] Change highlight color on folder change 74/36374/2
Benjamin Mack [Thu, 29 Jan 2015 09:46:44 +0000 (10:46 +0100)]
[BUGFIX] Change highlight color on folder change

Clicking on folder in filelist results in JS error.

When using the filelist main frame
for navigation through the folder structure
there is still some leftover from the old
code, which changes the highlighted
item when clicking on a folder.

The patch solves the issue by properly
addressing the navigation frame and
the JS method.

This part is actually a leftover from pre-4.2
code which was not changed by me in 4.2
with the introduction of the AJAX-based
folder tree with prototype.js.

Resolves: #64572
Releases: master, 6.2
Change-Id: Iff7c7aff07454e428fe78194532ba95df2bd25d0
Reviewed-on: http://review.typo3.org/36342
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
(cherry picked from commit 68e1fdc7c54c7ba426e04b4f19a28c9b89196a93)
Reviewed-on: http://review.typo3.org/36374

4 years ago[BUGFIX] Improve file handling on Windows systems 72/36372/2
Nicole Cordes [Thu, 29 Jan 2015 14:26:43 +0000 (15:26 +0100)]
[BUGFIX] Improve file handling on Windows systems

Calling unlink() on a symlink that points to a directory
fails on Windows. Solution is to use rmdir() instead to
remove the symlink.
Furthermore it fixes a wrong usage of DIRECTORY_SEPARATOR
within the FileHandlingUtility.

Releases: master, 6.2
Resolves: #64409
Change-Id: Idc6ff3eb1214ed8f5cb0f69f15a2d5a6a3dcfafe
Reviewed-on: http://review.typo3.org/36372
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Update TYPO3 copyright in all branches 66/36366/2
Benjamin Mack [Thu, 29 Jan 2015 15:41:23 +0000 (16:41 +0100)]
[TASK] Update TYPO3 copyright in all branches

The copyright notice (e.g. shown in the footer
of Backend Login) should be updated to 2015.

Resolves: #64597
Releases: master, 6.2, 4.5
Change-Id: I84bfe7eb53acb8896c45fc0788f53da4edadbdf8
Reviewed-on: http://review.typo3.org/36366
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] RTE: itemscope, itemtype, itemprop not working in span tag 57/36357/2
Stanislas Rolland [Thu, 6 Nov 2014 23:14:06 +0000 (18:14 -0500)]
[BUGFIX] RTE: itemscope, itemtype, itemprop not working in span tag

Default PageTsConfig is incorrect when features using the style
attribute are enabled. Hardcoded list of attributes allowed on span tag
in RTE parser misses those attributes.

Releases: master, 6.2
Resolves: #61805
Change-Id: I0fb57aaaa76e595b2f9bf24df3942d826acd3c27
Reviewed-on: http://review.typo3.org/33207
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-on: http://review.typo3.org/36357
Reviewed-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] TYPO3 and RTE Link wizard with white space above tabs 52/36352/2
Benjamin Mack [Thu, 29 Jan 2015 13:34:20 +0000 (14:34 +0100)]
[BUGFIX] TYPO3 and RTE Link wizard with white space above tabs

Problem: In Internet Explorer and Google Chrome, white space appears
above tabs in the TYPO3 Link wizard and in the RTE Link and Image
dialogues.
Solution: Replace top margin of tab menu with padding in container.

Resolves: #55782
Releases: master, 6.2
Change-Id: I6817b83999115f2037b42bf398fdaa53af96c4dc
Reviewed-on: http://review.typo3.org/36352
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Use getForLocalProcessing() for FAL images in GIFBUILDER 40/36340/2
Torben Hansen [Thu, 22 Jan 2015 19:03:01 +0000 (20:03 +0100)]
[BUGFIX] Use getForLocalProcessing() for FAL images in GIFBUILDER

GIFBUILDER must use getForLocalProcessing() for FAL images, so
image processing is possible for files containing special
chars (e.g. umlauts) when using an UTF-8 filesystem.

Resolves: #64224
Releases: master, 6.2
Change-Id: Ib3b372ceea1afa839787c61a3f118b3f62f05dcc
Reviewed-on: http://review.typo3.org/36180
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit fd232edeab2c72a7bac582b454b8db6b788f017c)
Reviewed-on: http://review.typo3.org/36340

4 years ago[BUGFIX] Fix class cache corruption in chroot environment 01/36301/2
Martin Helmich [Mon, 26 Jan 2015 13:30:29 +0000 (14:30 +0100)]
[BUGFIX] Fix class cache corruption in chroot environment

This commit fixes an issue that occurs in the rare edge case when the
TYPO3 cli dispatcher is called in a chroot environment and the site
is delivered via a non-chrooted web server.

In this case, all classes in the class cache will be stored with
`PATH_typo3` as base path, except the `TYPO3\Flow` classes in the
"core" extension. These are based on the __DIR__ constant, which
according to [1] resolves symlinks that generate directory paths that
are invalid outside of the chroot environment.

[1] http://php.net/manual/en/language.constants.predefined.php

Change-Id: I34a15c7a9913afc11cdd1d179a14331b157cbd29
Releases: 6.2
Fixes: #64508
Reviewed-on: http://review.typo3.org/36301
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Call LOCALISATION_OBJECT_NAME 'static'ally 15/36315/2
Andreas Fernandez [Mon, 26 Jan 2015 15:00:21 +0000 (16:00 +0100)]
[BUGFIX] Call LOCALISATION_OBJECT_NAME 'static'ally

Use static:: instead of self:: to call the constant
LOCALISATION_OBJECT_NAME.

Resolves: #64506
Releases: master, 6.2
Change-Id: I855dd65c2ca9ca47003d5dc0816f96a89512bc62
Reviewed-on: http://review.typo3.org/36315
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Restore SelectElement.php 73/36273/2
Mathias Schreiber [Mon, 26 Jan 2015 14:00:40 +0000 (15:00 +0100)]
[BUGFIX] Restore SelectElement.php

While backporting https://review.typo3.org/#/c/33328/ SelectElement.php
got deleted by error.

Resolves: #64507
Releases: 6.2
Change-Id: I8c5040fd6d935dc0086b39475dc746394a00c09e
Reviewed-on: http://review.typo3.org/36273
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Extbase validator should not ask class loader for simple types 41/36241/3
Benjamin Mack [Sat, 24 Jan 2015 22:27:57 +0000 (23:27 +0100)]
[BUGFIX] Extbase validator should not ask class loader for simple types

Extbase calls class_exists multiple times to
check for valid classes during set up of Validator
classes. It does these checks even for types
like "string" and "integer" for each
This leads to unnecessary calls to
the TYPO3 class loader and can be avoided.

Change-Id: I33f39b2902c1b04ca3c014ba44741976960cbf45
Resolves: #64379
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36241
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Fix explicit translation buttons 64/36264/2
Mathias Schreiber [Sat, 24 Jan 2015 20:05:12 +0000 (21:05 +0100)]
[BUGFIX] Fix explicit translation buttons

Since t3skin has been introduced in 4.0 the buttons for explicit
translations have not been adopted to the new style (back then).
These buttons are now added.

Resolves: #55454
Releases: master, 6.2
Change-Id: Ic0302b61f1a353b559fa874dbc84df1f4c1b91aa
Reviewed-on: http://review.typo3.org/36237
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit 24b4537f44040a3fa1b8dae8421772a91e556825)
Reviewed-on: http://review.typo3.org/36264

4 years ago[BUGFIX] Scheduler now throws exception on SQL query error 61/36261/2
Mathias Schreiber [Sat, 24 Jan 2015 10:49:54 +0000 (11:49 +0100)]
[BUGFIX] Scheduler now throws exception on SQL query error

If the query for fetchTask fails for whatever reason, scheduler will
now gracefully throw an exception instead of assuming it had gotten
a valid resource pointer

Resolves: #39085
Releases: master, 6.2
Change-Id: If4d5e0866bf6e5e17fcafbf4287e330366d995fa
Reviewed-on: http://review.typo3.org/36261
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Wrapper for uniqid() fixes failing tests on Windows 33/36133/2
Stephan Großberndt [Tue, 20 Jan 2015 09:23:00 +0000 (10:23 +0100)]
[BUGFIX] Wrapper for uniqid() fixes failing tests on Windows

Create TYPO3\CMS\Core\Tests\BaseTestCase->getUniqueId() as a wrapper to
all uniqid()-calls from tests. This fixes fatal errors on tests in
Windows because multiple calls to uniqid() without parameters within
one second will return the same value.

TYPO3\CMS\Core\Tests\Functional\DataHandling\Framework\ActionService
does not inherit from BaseTestCase and thus gets its own implementation
for now.

Stabilize redis tests a bit with a clear order, otherwise tests may
fail sometimes.

Resolves: #64055
Releases: master, 6.2
Change-Id: I15536c0f1766ad89a3d8daf7260b0dbe81ef82f8
Reviewed-on: http://review.typo3.org/36133
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] EXT:form: Fix rendering of text-input-fields 59/36259/2
Stefan Neufeind [Sun, 25 Jan 2015 23:31:01 +0000 (00:31 +0100)]
[BUGFIX] EXT:form: Fix rendering of text-input-fields

Attribute-check needs to take NULL into account as well.

Regression caused by change-id
I624c7da38c23429f68000e085dbd82c23fb7e834

Change-Id: I13ebad66de296b5a7f1befa8d2795edab4114f83
Resolves: #64359
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36259
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Formmail: generates incorrect file upload error in syslog 56/36256/2
Ernesto Baschny [Tue, 17 Jul 2012 12:27:11 +0000 (14:27 +0200)]
[BUGFIX] Formmail: generates incorrect file upload error in syslog

Change-Id: Ia0b16429e41e2aae96b3020cb690f9fedea762b0
Fixes: #39019
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36256
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fix context parameter in Database Analyzer URL 51/36251/2
Andreas Fernandez [Thu, 22 Jan 2015 16:50:54 +0000 (17:50 +0100)]
[BUGFIX] Fix context parameter in Database Analyzer URL

The variable {context} cannot get resolved because the output is not
rendered by Fluid. The variable gets replaced by the context string.

Resolves: #64441
Releases: master, 6.2
Change-Id: I5beacf301dbf89428e696d94227b341fb7a22e4c
Reviewed-on: http://review.typo3.org/36251
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years agoRevert "[BUGFIX] Temporarily downgrade to sebastian/exporter 1.0.2" 44/36244/2
Mathias Schreiber [Sun, 25 Jan 2015 00:17:22 +0000 (01:17 +0100)]
Revert "[BUGFIX] Temporarily downgrade to sebastian/exporter 1.0.2"

Since Sebastian fixed PHPUnit we can now revert this temporary fix

Reverts: #64473
Resolves: #64486
Releases: master, 6.2

This reverts commit 0917236daf8c5946fc6e04201d79825187d8dadb.

Change-Id: I81481c31079b222bf0ed4bdfa8ce80c282781ffc
Reviewed-on: http://review.typo3.org/36244
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] Temporarily downgrade to sebastian/exporter 1.0.2 32/36232/2
Mathias Schreiber [Sat, 24 Jan 2015 13:37:50 +0000 (14:37 +0100)]
[BUGFIX] Temporarily downgrade to sebastian/exporter 1.0.2

sebastian/exporter is a dependency of phpunit and regression
in 1.1.0 triggering a fatal. Downgrade to 1.0.2 until that
is fixed.

Resolves: #64473
Releases: master, 6.2
Change-Id: Icce63c03d1ba29749d18ba2c6bcb96a488cc26f9
Reviewed-on: http://review.typo3.org/36232
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Web->Page now respects labels set by TSConfig for plugins 26/36226/2
Mathias Schreiber [Fri, 23 Jan 2015 10:58:10 +0000 (11:58 +0100)]
[BUGFIX] Web->Page now respects labels set by TSConfig for plugins

Overriding labels for list_type via TSConfig we not taken into account
when displaying CType list.

Using getLabelsFromItemListMerged fixes the issue.

Resolves: #54211
Releases: master, 6.2
Change-Id: I147f3cddd0cb9e156cdbb76434aa86f5276e6a5e
Reviewed-on: http://review.typo3.org/36226
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[FOLLOWUP][BUGFIX] DBAL: Repair AUTO_INCREMENT 91/36191/2
Markus Klein [Thu, 22 Jan 2015 21:26:51 +0000 (22:26 +0100)]
[FOLLOWUP][BUGFIX] DBAL: Repair AUTO_INCREMENT

Fix broken unit tests.
The number of statements changed now as AUTO_INCREMENT
is supported.

Resolves: #63705
Releases: master, 6.2
Change-Id: I855b43b9dda599f5588abdebffb460e7819d2a82
Reviewed-on: http://review.typo3.org/36191
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[CLEANUP] Correct phpdoc in extbase's validator classes 89/36189/2
Frederic Gaus [Tue, 20 Jan 2015 16:46:58 +0000 (17:46 +0100)]
[CLEANUP] Correct phpdoc in extbase's validator classes

Set the correct @return in phpdoc of extbase validators.
Further correct some typos and remove disabled code including a
not needed comment in ValidatorInterface

Change-Id: I0966176eb4079f6c6fcd6f182e5c608acac0a01c
Resolves: #57453
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36189
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Avoid getUserObj-call for eval 'null' and non-existing hooks 88/36188/2
Stephan Großberndt [Thu, 11 Dec 2014 09:32:49 +0000 (10:32 +0100)]
[BUGFIX] Avoid getUserObj-call for eval 'null' and non-existing hooks

If the 'eval' definition of a TCA input or text does contain 'null' or
a value without a matching hook, we skip the useless call to
GeneralUtility::getUserObj().

This improves performance especially for bulk inserts with many text
fields.

Resolves: #63750
Releases: master, 6.2
Change-Id: I328f6b3f5e737fa472f7385afc0a2407d16eb1f8
Reviewed-on: http://review.typo3.org/36188
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] DBAL: Repair AUTO_INCREMENT 87/36187/2
Andreas Fernandez [Tue, 9 Dec 2014 11:05:21 +0000 (12:05 +0100)]
[BUGFIX] DBAL: Repair AUTO_INCREMENT

This patch fixes the creation of fields with an AUTO_INCREMENT flag,
especially for DBMS that don't have built-in support for AI flags.

Resolves: #63705
Releases: master, 6.2
Change-Id: I7ebf743e0e0483af181b76f66a8cf158ebe775cc
Reviewed-on: http://review.typo3.org/36187
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Core should not use old class name 37/36137/2
Benjamin Mack [Tue, 20 Jan 2015 12:39:44 +0000 (13:39 +0100)]
[BUGFIX] Core should not use old class name

In 6.2 the naming of some old class names
still exists. So does one occurence which
still triggers the class alias map and thus
slows down the system.

Change-Id: I9ec0461ca4c688783e633cb2ccda7b3264485f9c
Resolves: #64377
Releases: 6.2
Reviewed-on: http://review.typo3.org/36137
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] RTE: Style config option allowedClasses not correctly handled 47/36147/3
Stanislas Rolland [Tue, 20 Jan 2015 20:31:21 +0000 (15:31 -0500)]
[BUGFIX] RTE: Style config option allowedClasses not correctly handled

RTE configuration properties
buttons.blockstyle.tags.[ tag-name ].allowedClasses and
buttons.textstyle.tags.[ tag-name ].allowedClasses
are not correctly processed.
Some classes configured for a tag may not appear in the
style dropdown.

Releases: 6.2
Resolves: #64389
Change-Id: I72652996ae121c42573c9da8bcf1a16918c41401
Reviewed-on: http://review.typo3.org/36147
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Followup: Install Tool: Make upgrade wizards DBAL-compatible 03/36003/4
Andreas Fernandez [Tue, 13 Jan 2015 13:00:45 +0000 (14:00 +0100)]
[BUGFIX] Followup: Install Tool: Make upgrade wizards DBAL-compatible

Additional upgrade wizards must be fixed in this backport, since they
were removed in the master.

Releases: 6.2
Resolves: #64263
Change-Id: If89ec1e7d04d87af2d90045ed17e845954b1c37f
Reviewed-on: http://review.typo3.org/36003
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] Use composer class loader for better performance 24/36124/5
Helmut Hummel [Sun, 18 Jan 2015 10:25:20 +0000 (11:25 +0100)]
[FEATURE] Use composer class loader for better performance

Require composer class loader early in the bootstrap gives us many benefits:

1. Very early classes can be found and loaded very early in the bootstrap
2. Get rid of complexity for default cases
3. Test classes will only loadable in testing context
4. Cache warmup will be much faster as much less files need to be written

Further details can be found on the wiki http://wiki.typo3.org/ComposerClassLoader

Resolves: #64361
Releases: master, 6.2
Change-Id: Ida22edf8383a9706726a8fdd11297b2983d17b1a
Reviewed-on: http://review.typo3.org/36124
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Followup: Fix folder selection in ElementBrowser 27/36127/2
Frans Saris [Sun, 11 Jan 2015 18:57:14 +0000 (19:57 +0100)]
[BUGFIX] Followup: Fix folder selection in ElementBrowser

With the introduction of FAL folders are now addressed with their
combinedIdentifier. Parts of the ElementBrowser were not adjusted yet.

This patch makes sure the combinedIdentifier is used for folders
so you can also use/select folders from non-public and remote storages.

Resolves: #63651
Releases: master, 6.2
Change-Id: Id2f2021040950ade48f664c9576f5cd191afe324
Reviewed-on: http://review.typo3.org/36127
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Fix fatal error for date validation in EXT:form on Windows 25/36125/2
Stephan Großberndt [Wed, 17 Dec 2014 00:54:14 +0000 (01:54 +0100)]
[BUGFIX] Fix fatal error for date validation in EXT:form on Windows

Use a mapping to date_create_from_format() in date validation of
EXT:form if strptime() is not available. This prevents a fatal error on
Windows because strptime() is not implemented on Windows platform.

Resolves: #63945
Releases: master, 6.2
Change-Id: I92f66597ce362cc8dae66b09ba19ed428055a6de
Reviewed-on: http://review.typo3.org/36125
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Post travis notification to #typo3-cms-coredev channel 15/36115/2
Helmut Hummel [Mon, 19 Jan 2015 16:59:19 +0000 (17:59 +0100)]
[TASK] Post travis notification to #typo3-cms-coredev channel

Change-Id: I4cd242dd7ae34b4d179acd494d4e84b10e37c6e6
Reviewed-on: http://review.typo3.org/36115
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Add missing "Folders" label in ElementBrowser 22/36122/2
Frans Saris [Sun, 11 Jan 2015 19:29:33 +0000 (20:29 +0100)]
[BUGFIX] Add missing "Folders" label in ElementBrowser

Resolves: #64241
Releases: master, 6.2
Change-Id: If55b4e05ccd697a973e938b50f5cfd2f32a5d5b7
Reviewed-on: http://review.typo3.org/36122
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Output broken file links with pid in csv format 37/35837/5
Urs Braem [Tue, 6 Jan 2015 16:12:04 +0000 (17:12 +0100)]
[TASK] Output broken file links with pid in csv format

When upgrading a site, manual correction of broken links
found by the RTE-FAL upgrade wizard is simplified:
from the error message, a spreadsheet can be created
and sorted by pid.

Resolves: #64122
Releases: 6.2
Change-Id: I1771757ce59e3c0c89d141b24a181d45b1616247
Reviewed-on: http://review.typo3.org/35837
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Add shutdown function while class cache build 14/36114/2
Alexander Opitz [Mon, 8 Dec 2014 17:50:21 +0000 (18:50 +0100)]
[TASK] Add shutdown function while class cache build

With shutdown function we can check if PHP is shutdown while
cache generation, so we can remove leftovers from this process.

Resolves: #63683
Releases: master, 6.2
Change-Id: I4038c10c50287ec4cceca1c0e5a73c954f2d8c1d
Reviewed-on: http://review.typo3.org/36114
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FOLLOWUP] Add PSR-4 autoload sections to composer.json 12/36112/2
Helmut Hummel [Mon, 19 Jan 2015 16:09:41 +0000 (17:09 +0100)]
[FOLLOWUP] Add PSR-4 autoload sections to composer.json

A bogus test, which tests Flow behavior which is not present
in TYPO3 CMS package management caused a test to fail.

Fix this test to actually test the correct thing.

Releases: master, 6.2
Change-Id: Ideff51a32c3cdf3471472f9df743da0b3387abdc
Reviewed-on: http://review.typo3.org/36112
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Faster garbage collection of caching framework 05/36105/2
Stephan Großberndt [Fri, 10 Oct 2014 22:03:31 +0000 (00:03 +0200)]
[BUGFIX] Faster garbage collection of caching framework

Do the garbage collection of the caching framework with a single DELETE
statement using JOIN instead of fetching all entries by identifier and
deleting them in a separate statement afterwards. This improves
performance especially for big installations.

For EXT:DBAL the old behaviour is kept since Oracle does neither
support subqueries nor DELETE statements with JOINs.

Removed test collectGarbageSelectsExpiredCacheEntries since
collectGarbage() doesn't perform a SELECT query anymore.

Resolves: #61814
Releases: master, 6.2
Change-Id: Ifca9065e274b85219ca81afa87724ce8884cc662
Reviewed-on: http://review.typo3.org/36105
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Add PSR composer definition to all sysexts 07/36107/2
Benjamin Mack [Sat, 17 Jan 2015 15:44:28 +0000 (16:44 +0100)]
[TASK] Add PSR composer definition to all sysexts

In order to deliver more information
in custom installations for use with composer,
the namespaces for using the composer
autoloader are added to each composer.json
of all system extensions.

Releases: master, 6.2
Resolves: #64356
Change-Id: Ic0fa9e0969a48f68cce8ceeb77dbef3b75e6e6f1
Reviewed-on: http://review.typo3.org/36107
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Disabled SystemEnvironment check in CLI context 04/36104/3
Frans Saris [Sun, 11 Jan 2015 16:47:25 +0000 (17:47 +0100)]
[BUGFIX] Disabled SystemEnvironment check in CLI context

SystemEnvironment check should not be run in CLI context as
this can give false results.

The php.ini used for CLI can be different from the one used
by the webserver. This may result in false warnings and/or
errors in the email report.

Resolves: #56569
Releases: master, 6.2
Change-Id: Id448853c98342e43f7d82fa7bab9954f2a26f949
Reviewed-on: http://review.typo3.org/36104
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Show FAL captions in Page module 99/36099/2
Mathias Schreiber [Wed, 14 Jan 2015 16:00:49 +0000 (17:00 +0100)]
[BUGFIX] Show FAL captions in Page module

The page module only showed the contents of the old field
tt_content.imagecaption.

With FAL in place we now show the description from the FAL references.

Resolves: #64281
Releases: 6.2, master
Change-Id: I868348e11e59dad3b2affc7114e3913e7f9e985a
Reviewed-on: http://review.typo3.org/36099
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] CSS3 function calc must retain whitespace 80/34180/3
Christian Futterlieb [Fri, 14 Nov 2014 18:17:10 +0000 (19:17 +0100)]
[BUGFIX] CSS3 function calc must retain whitespace

Whitespaces within CSS3 function 'calc' must not be stripped
because otherwise browsers won't recognize it anymore.

Although the CSS3 specification requires the whitespaces around
the additive expressions (+/-) only, it might be better to not
remove any whitespace within a calc function in terms of
simplicity.. the minifying is complex enough as it already is.

Resolves: #62463
Releases: master, 6.2
Change-Id: Ied0c02e132aafa97ce9fb6b0e9930898cb17efc1
Reviewed-on: http://review.typo3.org/34180
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] RTE: WebKit may insert a span tag when backspacing a heading 86/36086/3
Stanislas Rolland [Sat, 17 Jan 2015 19:32:23 +0000 (14:32 -0500)]
[BUGFIX] RTE: WebKit may insert a span tag when backspacing a heading

It may happen, for example, when deleting an empty heading which is
followed by a paragraph, or when backspacing a paragraph or heading
which becomes merged with a preceding heading.
Remove the unwanted span element.

Releases: master, 6.2
Resolves: #59562
Change-Id: I820dfd0e39f2686e07d10b86af6deff59a57cc38
Reviewed-on: http://review.typo3.org/36086
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Follow up: Fix broken SQL in DeprecatedRteProperties 80/36080/3
Andreas Fernandez [Sat, 17 Jan 2015 17:35:38 +0000 (18:35 +0100)]
[BUGFIX] Follow up: Fix broken SQL in DeprecatedRteProperties

Add a closing parenthesis that got lost in commit
I355893b51cf9e02c0cdfbdaf16fd7760c5687068. Also use $db instead of
$GLOBALS['TYPO3_DB'].

Resolves: #64333
Releases: master, 6.2
Change-Id: I53a7e166215b9fa18e94228194ed1f99a5bdb3ab
Reviewed-on: http://review.typo3.org/36080
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Tested-by: Andreas Fernandez <andreas.fernandez@aspedia.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] EXT:adodb: Table names in ALTER TABLE are broken 99/35999/2
Andreas Fernandez [Mon, 8 Dec 2014 09:12:18 +0000 (10:12 +0100)]
[BUGFIX] EXT:adodb: Table names in ALTER TABLE are broken

Updating a table using the Oracle DBMS does not work due to improper
quoting in the oci8 datadict.

Resolves: #63659
Releases: master, 6.2
Change-Id: I831f4affebd161cfd22580506714bc6c7d70f207
Reviewed-on: http://review.typo3.org/35999
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] RTE: No expand icon after collapsing folder in image dialogue 33/36033/2
Stanislas Rolland [Thu, 15 Jan 2015 21:58:54 +0000 (16:58 -0500)]
[BUGFIX] RTE: No expand icon after collapsing folder in image dialogue

Applies also to file tab of link dialogue.
Backpath setting is wrong.

Releases: 6.2
Resolves: #64305
Change-Id: I680cbab012c2da1782860bd22e0cb8c7bb63c2dc
Reviewed-on: http://review.typo3.org/36033
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Make output of additionalCSS valid 31/36031/2
Mathias Schreiber [Thu, 15 Jan 2015 17:13:07 +0000 (18:13 +0100)]
[BUGFIX] Make output of additionalCSS valid

INTincScript_loadJSCode no longer wraps CSS in CDATA tags.
Doing so resulted in invalid CSS markup.

Fixes: #20339
Releases: 6.2, master
Change-Id: I5e9d3ff8867c8ba5dfbdc711ba3942124e68b911
Reviewed-on: http://review.typo3.org/36031
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix regression in prefixLocalAchors feature 29/36029/2
Helmut Hummel [Mon, 12 Jan 2015 17:23:49 +0000 (18:23 +0100)]
[BUGFIX] Fix regression in prefixLocalAchors feature

The security fix for #62723 missed an edge case were the
TypoScriptFrontendController main cObj property is not yet initialized.

Check for this case and create it.

Resolves: #63896
Releases: 4.5, 6.2, master
Change-Id: Ief9338453517e095d120007d8d13ba6405d6fbb8
Reviewed-on: http://review.typo3.org/36029
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[BUGFIX] Show RTE tool tips in Internet Explorer 23/36023/2
Nicole Cordes [Wed, 10 Dec 2014 13:37:45 +0000 (14:37 +0100)]
[BUGFIX] Show RTE tool tips in Internet Explorer

This patch adds a font size to the tool tip header class to show tool
tips in Internet Explorer 8 and 9 again.

Resolves: #63739
Releases: master, 6.2
Change-Id: Ib82190cbfc11dc9b51f7c0bb447b3ae9ae45a8c9
Reviewed-on: http://review.typo3.org/36023
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] RTE: avoid exception on folder inaccessibility 46/35946/2
Stanislas Rolland [Sat, 10 Jan 2015 17:51:05 +0000 (12:51 -0500)]
[BUGFIX] RTE: avoid exception on folder inaccessibility

Catch exceptions that might occur when resolving the parent directory
of a file and the user does not have access to it.

Releases: master, 6.2
Resolves: #64187
Change-Id: I879b341e1eb4c639012da7bc7942d96131bf45b0
Reviewed-on: http://review.typo3.org/35946
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Support void elements without whitespace in parseFunc 18/36018/2
Steffen Müller [Tue, 13 Jan 2015 18:11:09 +0000 (19:11 +0100)]
[BUGFIX] Support void elements without whitespace in parseFunc

xhtml specs require void HTML elements like "<br>" to be
terminated with a "/", for example "<br />".
Whitespaces before the "/" are optional, so tags without
whitespaces are parsed by parseFunc, for example "<br/>"

Resolves: #64267
Releases: master, 6.2
Change-Id: I86a5857b93aeefbc457c309fe4fedd84578ac698
Reviewed-on: http://review.typo3.org/36018
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Hidden content is displayed in view module 17/36017/2
Stefan Froemken [Tue, 6 Jan 2015 12:22:23 +0000 (13:22 +0100)]
[BUGFIX] Hidden content is displayed in view module

Since TYPO3 4.2.3 hidden content elements and hidden
pages are displayed in view page module. There are many people
in the community who wants them to be hidden by default.
This patch reactivates the old way from TYPO3 4.2.2. If you
want to see the hidden elements again you have to add
config.admPanel = 1 in your TypoScript. The checkboxes
in admPanel to display hidden records works now again.

Resolves: #20335
Releases: master, 6.2
Change-Id: I146518fbacf0b381bc7c705aa8cb6275af175712
Reviewed-on: http://review.typo3.org/36017
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] RTE: Toolbar items do not wrap correctly 14/36014/3
Stanislas Rolland [Wed, 14 Jan 2015 16:22:47 +0000 (11:22 -0500)]
[BUGFIX] RTE: Toolbar items do not wrap correctly

Fix total height of some items.

Releases: 6.2
Resolves: #64284
Change-Id: I4c01fde183c0046885eccad37a43d3eb78fae75c
Reviewed-on: http://review.typo3.org/36014
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Install Tool: Make Upgrade Wizard compatible with Oracle 02/36002/2
Andreas Fernandez [Tue, 13 Jan 2015 14:50:46 +0000 (15:50 +0100)]
[BUGFIX] Install Tool: Make Upgrade Wizard compatible with Oracle

The wizards in the Install Tool crash with Oracle due to improper
quoting of the values. Wrap the values with fullQuoteStr() to
ensure correct quoting for the used DBMS.

Releases: master, 6.2
Resolves: #64263
Change-Id: I355893b51cf9e02c0cdfbdaf16fd7760c5687068
Reviewed-on: http://review.typo3.org/36000
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit f81d2dc542abf610cd986325962ff74d95b821a0)
Reviewed-on: http://review.typo3.org/36002

4 years ago[BUGFIX] Pagepath is displayed incorrectly with slash (/) in page title 82/35982/2
Benjamin Mack [Sat, 10 Jan 2015 19:16:12 +0000 (20:16 +0100)]
[BUGFIX] Pagepath is displayed incorrectly with slash (/) in page title

If the current (!) page has a slash in the Page Name,
the first part of that page name is also displayed
in the Path at the upper right, which is not correct.

Resolves: #23179
Releases: master, 6.2
Change-Id: I1070f36f02067c291503c22822e84ee068a3e4d6
Reviewed-on: http://review.typo3.org/35982
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix query in abbreviation plugin of rtehtmlarea 79/35979/3
Stanislas Rolland [Mon, 12 Jan 2015 20:13:11 +0000 (15:13 -0500)]
[BUGFIX] Fix query in abbreviation plugin of rtehtmlarea

The comma seperated list of PIDs is not wrapped in quotes any more
to allow more than one page to be searched in.

Additionally invalid SQL queries with an empty IN parameter are
prevented by avoiding any query if the PID list is empty
and the user is locked to DB mounts.

Resolves: #64169
Releases: master, 6.2
Change-Id: I3cf35a900ea84a5f7110e8b262f7aaccb27f3267
Reviewed-on: http://review.typo3.org/35979
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] cObjRenderer->prefixComment() needs parameter validation 77/35977/2
Philipp Gampe [Mon, 12 Jan 2015 17:14:17 +0000 (18:14 +0100)]
[BUGFIX] cObjRenderer->prefixComment() needs parameter validation

The method fails to validate the parameters leading to PHP notices
if the function is used incorrectly in TypoScript.

Resolves: #38969
Releases: master,6.2
Change-Id: If27d530cc70bb7ed4e9baa6f040b66ff2213223b
Reviewed-on: http://review.typo3.org/35977
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] DBAL: Log error if query fails 72/35972/2
Andreas Fernandez [Mon, 12 Jan 2015 09:19:41 +0000 (10:19 +0100)]
[TASK] DBAL: Log error if query fails

Log error if a SELECT query fails on DBAL.

Resolves: #64245
Releases: master, 6.2
Change-Id: I7e263a3a0157200b0570be68d8153e69306acad3
Reviewed-on: http://review.typo3.org/35972
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Make TCEMAIN.translateToMessage work with lang files 67/35967/2
Benjamin Mack [Sat, 10 Jan 2015 20:04:51 +0000 (21:04 +0100)]
[BUGFIX] Make TCEMAIN.translateToMessage work with lang files

The option TCEMAIN.translateToMessage that prepends
a certain text to a message was apparantly available
with the functionality of "LLL:" in the past.

TCEMAIN.translateToMessage = LLL:EXT:foobar/locallang_be.xml:translateTo

The patch re-introduces the functionality
again which was missing since at least 4.7.

See forge for further details.

Resolves: #41906
Releases: master, 6.2
Change-Id: I7f30ba7fc1d6577073e8a75840762c0912ca5d2c
Reviewed-on: http://review.typo3.org/35967
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] TypoScript: Unify line-endings to LF on save 39/35839/2
Stefan Neufeind [Tue, 6 Jan 2015 01:48:10 +0000 (02:48 +0100)]
[BUGFIX] TypoScript: Unify line-endings to LF on save

Coding Guidelines and t3editor demand LF as line-endings.
Some browsers send CRLF (Windows) or CR (instead).

Change-Id: I264dac962cb59a568dfba1220d6962202b93a71f
Resolves: #53893
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35839
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Properly check TS conditions with key '0' 50/35950/2
Christian Futterlieb [Thu, 8 Jan 2015 18:21:09 +0000 (19:21 +0100)]
[BUGFIX] Properly check TS conditions with key '0'

Global vars and strings from array expressions with key '0' must be
checked correctly in TS conditions.
E.g. when using [globalVar = GP:myoption|0 = 1] the 0 is now
correctly evaluated.

Resolves: #64192
Releases: master, 6.2
Change-Id: I1100042670ffd458dfb81e6a6eac126dbc01a531
Reviewed-on: http://review.typo3.org/35950
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Folders created from BE fail to set permissions 18/32918/7
Benjamin Mack [Sat, 10 Jan 2015 18:36:42 +0000 (19:36 +0100)]
[BUGFIX] Folders created from BE fail to set permissions

The created path during folder creation contains double slashes.
Therefore the function used to fix/set the permissions according to the
folderCreateMask setting aborts processing because it identifies the path
as invalid.

This patch causes the concatenation of the path elements to take care of
double slashes.

Resolves: #52309
Releases: master, 6.2
Change-Id: Ib96d6ebc40f155758bbd92cb60b87420bda34597
Reviewed-on: http://review.typo3.org/32917
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit 59671a2dfe152f01207a520c544967ba6b35f301)
Reviewed-on: http://review.typo3.org/32918

4 years ago[BUGFIX] Install Tool flash messages in Step Installer styling 45/35945/2
Ernesto Baschny [Tue, 11 Mar 2014 15:45:34 +0000 (16:45 +0100)]
[BUGFIX] Install Tool flash messages in Step Installer styling

Releases: master, 6.2
Resolves: #56770
Change-Id: I17683468f82542f627c886e9234ccd443994e84c
Reviewed-on: http://review.typo3.org/35945
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Make typolink respect property linkAccessRestrictedPages 23/35923/2
Frederic Gaus [Thu, 8 Jan 2015 17:10:32 +0000 (18:10 +0100)]
[BUGFIX] Make typolink respect property linkAccessRestrictedPages

With this patch typolink does link access restricted pages when
the typolink configuration has $conf['linkAccessRestrictedPages']
set and config.typolinkLinkAccessRestrictedPages is set.

Without the patch, typolink does not link access restricted pages
in this configuration but takes the configuration of
config.typolinkLinkAccessRestrictedPages into account.

Change-Id: Ief1e56fa68e6818e2739d642510cf016e094e399
Resolves: #63804
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35923
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Add stdWrap to sorting.direction for FILES 22/35922/2
Benjamin Mack [Fri, 2 Jan 2015 11:02:27 +0000 (12:02 +0100)]
[BUGFIX] Add stdWrap to sorting.direction for FILES

Add the missing stdWrap support for the sorting direction
property of the new FILES cObject.

Resolves: #59297
Releases: master, 6.2
Change-Id: I827f3318419824a9b125b04a09fdd4f7dde443fd
Reviewed-on: http://review.typo3.org/35922
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Shortcut icons now check permissions 09/35909/2
Wouter Wolters [Wed, 7 Jan 2015 18:22:41 +0000 (19:22 +0100)]
[BUGFIX] Shortcut icons now check permissions

Resolves: #36193
Releases: master, 6.2
Change-Id: Idcce6744d1b3d108daafb47103beefaf8d61c27c
Reviewed-on: http://review.typo3.org/35874
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Stefan Froemken <froemken@gmail.com>
(cherry picked from commit 903e9841cd4a711e25182237b3e9b6c023eef8cd)
Reviewed-on: http://review.typo3.org/35909
Reviewed-by: Stefan Froemken <froemken@gmail.com>
4 years ago[DB][BUGFIX] Change DB field sys_filemounts.base from tinyint to integer 56/35856/3
Benjamin Mack [Tue, 6 Jan 2015 23:06:04 +0000 (00:06 +0100)]
[DB][BUGFIX] Change DB field sys_filemounts.base from tinyint to integer

sys_filemounts.base holds a reference to a storage, which should
be of DB type "int" as the storage uid is an integer itself as well.

It was a tinyint(4) type and is changed now to int(11).

Resolves: #57584
Releases: master, 6.2
Change-Id: I015293c41d64ba9145a03a6c2b9316c93e7d9e1f
Reviewed-on: http://review.typo3.org/35856
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Avoid makeInstance calls starting with a backslash 36/35836/2
Benjamin Mack [Tue, 6 Jan 2015 16:12:34 +0000 (17:12 +0100)]
[BUGFIX] Avoid makeInstance calls starting with a backslash

When using singletons and calling makeInstance
with a beginning backslash in the class name
(see forge example), the singleton is not
correctly used.

Like inside the class loader, makeInstance and
the Extbase object manager should check for
a beginning backslash in the string of the
class name, and throw an exception, to give developers
a hint about broken code.

Change-Id: Ie7e0a6436fa8c5d983cd7e61b6ba96184440c657
Resolves: #60174
Releases: 6.2
Reviewed-on: http://review.typo3.org/35836
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Fix phpDoc of FluidTemplateContentObject::render 16/35816/2
Frederic Gaus [Tue, 6 Jan 2015 07:00:44 +0000 (08:00 +0100)]
[BUGFIX] Fix phpDoc of FluidTemplateContentObject::render

Change-Id: Ia91bac1ac2f26c500ce1fdc0d2eedece9ab30876
Resolves: #63380
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35816
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Linkvalidator: Fix invalid links 10/35810/2
Markus Klein [Mon, 5 Jan 2015 15:28:18 +0000 (16:28 +0100)]
[BUGFIX] Linkvalidator: Fix invalid links

Fix the generation of edit links of records to comply with the standards.

Resolves: #64128
Releases: master, 6.2
Change-Id: Ie1fd5a220cf045c1e093c8dfa3ad58f4fa9fd94f
Reviewed-on: http://review.typo3.org/35810
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Redirect to record after creating new root template 03/35803/2
Georg Ringer [Mon, 5 Jan 2015 15:58:22 +0000 (16:58 +0100)]
[BUGFIX] Redirect to record after creating new root template

After clicking the button "Create template for a new site", the
user is redirected to the new template record.

Resolves: #62195
Releases: master, 6.2
Change-Id: I8d999760f09f5e81a5286a9a3790f6292bf3eb39
Reviewed-on: http://review.typo3.org/35803
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Center icons vertically again in toolbar of page tree 25/35425/3
Stephan Großberndt [Fri, 31 Jan 2014 14:21:02 +0000 (15:21 +0100)]
[BUGFIX] Center icons vertically again in toolbar of page tree

The task #52497 introduced a regression. The default font-size 12px and
new default line-height of 18px set in body shifts the icons down. This
needs to be reset at least for toolbar icons in xtheme-t3skin.css.
Additionally removed the comment for styles no longer set in the
stylesheet.

Resolves: #55507
Related: #52497
Releases: 6.2
Change-Id: I02faf731ea41ad82338cbfc0b417f715ac0e13c1
Reviewed-on: http://review.typo3.org/35425
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Use correct label in indexed_search template 93/35793/2
Georg Ringer [Mon, 5 Jan 2015 16:09:21 +0000 (17:09 +0100)]
[BUGFIX] Use correct label in indexed_search template

The used label in the template must be changed to an existing one.

Resolves: #51113
Releases: master, 6.2
Change-Id: I8fbb2e69912a34a5203ca2342b39c94447fd77f7
Reviewed-on: http://review.typo3.org/35793
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Display BE layouts in correct order 89/35789/2
Markus Klein [Sat, 3 Jan 2015 15:43:30 +0000 (16:43 +0100)]
[BUGFIX] Display BE layouts in correct order

When using the Languages view in Page module the Backend Layout
columns are now sorted correctly.

Releases: master, 6.2
Resolves: #60389
Change-Id: I74c010512ff405b143352755f8c862a55ef6c391
Reviewed-on: http://review.typo3.org/35757
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
(cherry picked from commit 4b15d478511087237e3789b66d8eee07e3ce2355)
Reviewed-on: http://review.typo3.org/35789

4 years ago[BUGFIX] Fix error mode handling for lang file inclusion 88/35788/2
Markus Klein [Mon, 5 Jan 2015 13:33:33 +0000 (14:33 +0100)]
[BUGFIX] Fix error mode handling for lang file inclusion

Releases: master, 6.2
Resolves: #64126
Change-Id: I985cf10a97b742bc5f3357d3822aaa5256ff86e7
Reviewed-on: http://review.typo3.org/35788
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fixes position of suggest wizzard autocomplete result in IE 86/35786/2
Torben Hansen [Fri, 12 Dec 2014 09:49:12 +0000 (10:49 +0100)]
[BUGFIX] Fixes position of suggest wizzard autocomplete result in IE

A 5 years old bug in script.aculo.us leads to the problem, that
autocomplete results of the suggest wizzard are displayed at a
wrong position for Internet Explorer browsers. Depending on the
screen resolution, the autocomplete results may even be out of the
visual area of the users screen.

Since script.aculo.us seems to be unmaintained, the patch is directly
applied to the script.aculo.us source files, so we at least can
provide a bugfix for TYPO3 users using Internet Explorer.

This patch also fixes an IE fix in script.aculo.us. Instead of using
javascript:false we now use about:blank as source for the IE fix
iframe, which prevents the text “false” being displayed when
autocompletion results appear in IE.

Resolves: #63604
Releases: master, 6.2
Change-Id: Ib0421a308bb0652b9aed8be73ab6c78900ebe13d
Reviewed-on: http://review.typo3.org/35786
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Return string on non-existent CASE cObject 84/35784/3
Benjamin Mack [Sun, 4 Jan 2015 15:12:59 +0000 (16:12 +0100)]
[BUGFIX] Return string on non-existent CASE cObject

Currently, when using a TypoScript CASE cObject
and the key property is not available then the default
key is used. If the default key is not existent
a TS warning is thrown. According to the documentation
an empty string should be returned.

Releases: master, 6.2
Resolves: #39772
Change-Id: I2c7872b066523b8075983fb7cabb6821fdfef54d
Reviewed-on: http://review.typo3.org/35784
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[BUGFIX] Speed up BackendUtility->explodeSoftRefParserList 75/35775/2
Stephan Großberndt [Tue, 9 Dec 2014 12:00:31 +0000 (13:00 +0100)]
[BUGFIX] Speed up BackendUtility->explodeSoftRefParserList

Due to improper checking for an empty array in
BackendUtility->explodeSoftRefParserList multiple trimExplode-calls per
record are executed. Fixing this check leads to an early return and
speeds up bulk inserting.

Resolves: #63674
Releases: master, 6.2
Change-Id: Id8969c33d8ebb109018159ada6a277ab5bfdd13c
Reviewed-on: http://review.typo3.org/35187
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
(cherry picked from commit 522fba7db058c0c2783116d9772c2c2a561b6beb)
Reviewed-on: http://review.typo3.org/35775

4 years ago[TASK] Performance: Avoid using array_keys in foreach 08/35708/4
Mathias Schreiber [Mon, 29 Dec 2014 08:39:57 +0000 (09:39 +0100)]
[TASK] Performance: Avoid using array_keys in foreach

This lowers the memory usage.

Iterate on the original array instead of an array_keys()-copy
which lowers memory usage and enhances performance.

Change-Id: If65fae1665e242667d621f086a55a22a8d5309ed
Resolves: #64004
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35708
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Non modules can't check module access 61/35761/2
Wouter Wolters [Sat, 3 Jan 2015 16:35:51 +0000 (17:35 +0100)]
[BUGFIX] Non modules can't check module access

Resolves: #64098
Releases: master, 6.2
Change-Id: Ic71b026e18160fb92c8e215ecf2cfb6c86703661
Reviewed-on: http://review.typo3.org/35761
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Fix folder selection in ElementBrowser 60/35760/2
Markus Klein [Mon, 8 Dec 2014 01:25:13 +0000 (02:25 +0100)]
[BUGFIX] Fix folder selection in ElementBrowser

Resolves: #63651
Releases: master, 6.2
Change-Id: Ica4b9dab922be15bffd67f1dbd90ea8e4522838d
Reviewed-on: http://review.typo3.org/35760
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Autolink urls starting https:// as well 56/35756/2
Georg Ringer [Sat, 6 Dec 2014 20:34:50 +0000 (21:34 +0100)]
[BUGFIX] Autolink urls starting https:// as well

Currently only non ssl urls are automatically identified
and transformed to a link. Now also links starting with
https:// are identified.

Resolves: #63616
Releases: master, 6.2
Change-Id: I3a35c73263e2248c571ba835212ac59b3d7ec68b
Reviewed-on: http://review.typo3.org/35756
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>