Packages/TYPO3.CMS.git
5 years ago[BUGIFX] Fix Redirect after switch-to-user 97/27897/3
Helmut Hummel [Thu, 27 Feb 2014 13:18:14 +0000 (14:18 +0100)]
[BUGIFX] Fix Redirect after switch-to-user

The compatibility layer introduced in #55809
causes trouble with the user switch feature.

User switch intentionally redirects to index.php
but the compatibility layer kicks in and redirects
back to the user module, finally leading to an
endless redirect.

This can be resolved by checking for modules which
have been changed and need that compatibility layer.

Resolves: #56364
Releases: 6.2
Change-Id: I74d8c57335af66068383b49dc7d43ea480e631b8
Reviewed-on: https://review.typo3.org/27897
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Oliver Hader
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix reference to FileListLocalisation.js 61/27861/2
Markus Klein [Wed, 26 Feb 2014 00:13:37 +0000 (01:13 +0100)]
[BUGFIX] Fix reference to FileListLocalisation.js

FileListLocalisation.js was moved from backend to filelist
with #55810, but it was forgotten to adapt the reference
in InlineElement.

Resolves: #55979
Releases: 6.2
Change-Id: I102ffe25c255f8ac39a49d4022ee3ab73ff1914c
Reviewed-on: https://review.typo3.org/27861
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Frans Saris
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Revert "[TASK] Use a 401 header if login is not successful" 88/27888/9
Michael Knabe [Thu, 27 Feb 2014 11:27:51 +0000 (12:27 +0100)]
[BUGFIX] Revert "[TASK] Use a 401 header if login is not successful"

This reverts commit 9974f36d2736e21875a76d33a9dd7ceb440a100d.

The 401 header code is used with HTTP based authentication schemes,
based on RFC 2617.

This is not the case here.

Resolves: #55966
Reverts: #51803
Releases: 6.2, 6.1, 6.0, 4.5
Change-Id: I134f0f1d575f3e8d4c37c2af62df8eca3f01f817
Reviewed-on: https://review.typo3.org/27888
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Fix link for workspace preview 93/27893/2
Helmut Hummel [Thu, 27 Feb 2014 11:42:01 +0000 (12:42 +0100)]
[BUGFIX] Fix link for workspace preview

The absolute link generated for mailings to
workspace editors misses the page id.

The uid has been accidentally removed with
commit for #56359

Resolves: #56375
Releases: 6.2
Change-Id: I521aee2b96c542c27a911ffeab5d9bfffc8b9a46
Reviewed-on: https://review.typo3.org/27893
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix module access regressions 83/27883/3
Helmut Hummel [Wed, 26 Feb 2014 20:37:14 +0000 (21:37 +0100)]
[BUGFIX] Fix module access regressions

During the addition of the token check for mod.php
some places have been missed where a correct
token needs to be added.

Resolves: #56359
Releases: 6.2
Change-Id: I435cb36641fe96ecf050c915d200f94cbb31ce9f
Reviewed-on: https://review.typo3.org/27883
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Avoid to get a file object with the uid zero 04/27304/3
Marc Bastian Heinrichs [Mon, 3 Feb 2014 17:34:58 +0000 (18:34 +0100)]
[BUGFIX] Avoid to get a file object with the uid zero

At some points where a file object is retrieved, a check for
the interpretation as integer is done for the method
argument only. If the argument is 0 a exception will be
thrown from the ResourceFactory.
A file object should only be fetched if the uid is an integer
greater than zero.

Resolves: #55530
Releases: 6.2
Change-Id: I9399d58bac4a48344769ac00207b64e25eea630e
Reviewed-on: https://review.typo3.org/27304
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Do not save failed token messages in session 79/27879/2
Helmut Hummel [Wed, 26 Feb 2014 19:20:07 +0000 (20:20 +0100)]
[BUGFIX] Do not save failed token messages in session

In #30272 the backend formprotection has been changed
to not save flash messages in the user session if
the current request is an Ajax request.

Unfortunately the check for that is broken
since the TYPO3_AJAX global is reset in the
bootstrap now.

Introduce a method which uses the request type
constants and adapt the tests accordingly.

Resolves: #56357
Releases: 6.2
Change-Id: Idae8be036b3747ea71509cc37008a4d694390627
Reviewed-on: https://review.typo3.org/27879
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Respect all filemounts in file collection 19/27119/3
Alexander Stehlik [Thu, 30 Jan 2014 10:43:13 +0000 (11:43 +0100)]
[BUGFIX] Respect all filemounts in file collection

The directory selector in a file collection now displays the folders
of all filemounts of a user. Before only the folders of the first
filemount were displayed.

Resolves: #55414
Releases: 6.2
Change-Id: Ic47f5163e2cfc7c89edcba4119f06620ed0fd56e
Reviewed-on: https://review.typo3.org/27119
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[!!!][SECURITY] Add CSRF protection to mod.php 36/27636/8
Helmut Hummel [Fri, 14 Feb 2014 22:56:38 +0000 (23:56 +0100)]
[!!!][SECURITY] Add CSRF protection to mod.php

Add a token check in mod.php and token generation
to BackendUtility::getModuleUrl()

Adapt code to use BackendUtility::getModuleUrl()
in every place where links are hardcoded.

Releases: 6.2
Resolves: #55509
Change-Id: I952c40fc1004a0a8d77c929927d37e1d93dcfef4
Reviewed-on: https://review.typo3.org/27636
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Allow record insert on rootlevel 66/24166/9
Benjamin Serfhos [Mon, 30 Sep 2013 15:01:24 +0000 (17:01 +0200)]
[BUGFIX] Allow record insert on rootlevel

The DataHandler function checkRecordInsertAccess() does
now check the configuration for the root level.

Resolves: #52386
Releases: 6.2, 6.1, 6.0
Change-Id: I1810ea847e631ea6b242346a0271f491fd60fdf9
Reviewed-on: https://review.typo3.org/24166
Reviewed-by: Leon de Rijke
Tested-by: Leon de Rijke
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Followup: Ajax handler TYPO3_tcefile::process is broken 39/27739/11
Frans Saris [Wed, 19 Feb 2014 20:41:23 +0000 (21:41 +0100)]
[BUGFIX] Followup: Ajax handler TYPO3_tcefile::process is broken

Upload action was taken care of, but the ajax handler can be just
for all commands that ExtendedFileUtility->processData can handle.

This change checks the result set and flattens
data only when needed.

Resolves: #56084
Releases: 6.2, 6.1
Change-Id: Ic1a0bd9084b9eb206b9b53960890d22d2a9c56f5
Reviewed-on: https://review.typo3.org/27739
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Fixen broken tests for getTreeList 59/27859/2
Markus Klein [Tue, 25 Feb 2014 22:59:20 +0000 (23:59 +0100)]
[TASK] Fixen broken tests for getTreeList

Resolves: #56294
Releases: 6.2
Change-Id: I1d86f1899447feaa301474f4ed247a0ecc6c1a6e
Reviewed-on: https://review.typo3.org/27859
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Wrong usage of intExplode in getTreeList 89/27089/9
Stefan Froemken [Tue, 28 Jan 2014 10:44:46 +0000 (11:44 +0100)]
[BUGFIX] Wrong usage of intExplode in getTreeList

getTreeList calls intExplode which converts empty
arrays to 0. This patch removes empty arrays
within intExplode.

Resolves: #55384
Releases: 6.2
Change-Id: Id4ca1a15edf2cc2617d85bda765461c4cb1f105c
Reviewed-on: https://review.typo3.org/27089
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] Don't modify variables in tree view 50/27850/3
Jigal van Hemert [Tue, 25 Feb 2014 20:08:44 +0000 (21:08 +0100)]
[BUGFIX] Don't modify variables in tree view

The lowlevel array browser tries to modify the array that
is displayed if it's an object.
Now that TYPO3_LOADED_EXT is a simulated array (an object
which implements array access) modifying the data leads to
a fatal error. Instead the iterated value is now modified.

Releases: 6.2
Resolves: #54449
Change-Id: Ib1d3eb5cc76a4180ea0891d88c16191cd16f36e2
Reviewed-on: https://review.typo3.org/27850
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] Remove outdated $CLIENT[FORMSTYLE] 24/27824/4
Benjamin Mack [Tue, 25 Feb 2014 08:06:11 +0000 (09:06 +0100)]
[CLEANUP] Remove outdated $CLIENT[FORMSTYLE]

The functionality for having to deal with
browsers that did not support style="width: XYpx"
is not needed anymore, as any browser supported
in the TYPO3 universe can deal with that (even IE6).

This patch cleans up all the areas that dealt with
that part. Also, one dummy function in
FormEngine.php has been removed completely,
another in DocumentTemplate.php has been
deprecated.

Releases: 6.2
Resolves: #56254
Change-Id: I6f47a5f7cabfd340088c242f1ee15b83c7cba0fe
Reviewed-on: https://review.typo3.org/27824
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[CLEANUP] Superfluous Code in ElementBrowser and BrowseLinks 56/27856/2
Markus Klein [Tue, 25 Feb 2014 20:59:05 +0000 (21:59 +0100)]
[CLEANUP] Superfluous Code in ElementBrowser and BrowseLinks

Resolves: #56290
Releases: 6.2
Change-Id: I85348aea9fd514b9774b63846f444fcb9a8310e4
Reviewed-on: https://review.typo3.org/27856
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Fix JS error in ElementBrowser 54/27854/2
Markus Klein [Tue, 25 Feb 2014 20:37:46 +0000 (21:37 +0100)]
[BUGFIX] Fix JS error in ElementBrowser

Fix for #41413 did not remove a superfluous parentheses.
This is causing a JS error now.

Backports of the original patch are fixed already.

Resolves: #56289
Releases: 6.2
Change-Id: Iff0e73a28c9428d931f44b538106b6120ccc4e6a
Reviewed-on: https://review.typo3.org/27854
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Install Tool fatal with Oracle database 46/27846/11
Andreas Fernandez [Tue, 25 Feb 2014 15:40:34 +0000 (16:40 +0100)]
[BUGFIX] Install Tool fatal with Oracle database

Installing TYPO3 with an Oracle database (oci8) fails.
After selecting oci8 and passing the credentials,
the install wizard crashes with:

PHP Fatal error: Cannot use object of type
TYPO3\CMS\Core\Configuration\ConfigurationManager as array in
typo3/sysext/install/Classes/Controller/Action/Step/DatabaseConnect.php
on line 93

Obviously $config got mixed up with $configurationManager.
Fix this typo.

Resolves: #56253
Releases: 6.2
Change-Id: I58c1bc27f56b9a527d1d8fde7cf39b4ecd3ef7b6
Reviewed-on: https://review.typo3.org/27846
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
5 years ago[BUGFIX] Paginator in TER list not using ajax 43/27843/2
Jigal van Hemert [Tue, 25 Feb 2014 14:40:00 +0000 (15:40 +0100)]
[BUGFIX] Paginator in TER list not using ajax

The paginator in the extension list from TER is transformed into
using Ajax. This fails because this process searches for links inside
a class which is used by the frontend paginator widget. Changing it to
the id of the backend paginator widget makes the ajax calls work again.

Resolves: #56184
Releases: 6.2, 6.1, 6.0
Change-Id: I06c193b2657eb3edae623dc0126b06c240f486c6
Reviewed-on: https://review.typo3.org/27843
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] URL-encoded title in link wizard 40/23740/10
Helmut Hummel [Wed, 11 Sep 2013 10:49:39 +0000 (12:49 +0200)]
[BUGFIX] URL-encoded title in link wizard

The security fix introduced a bug that the title is encoded
every time the link wizard is opened, leading to multiple
encoded strings.

Solution is to not encode it centrally but encode it just
before using it in the JavaScript context.

Fixes: #41413
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Change-Id: I6b08db290d5457761edc4506105672d79840764d
Reviewed-on: https://review.typo3.org/23740
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Deprecate unused methods in ElementBrowser 47/27847/4
Tymoteusz Motylewski [Tue, 25 Feb 2014 16:23:15 +0000 (17:23 +0100)]
[TASK] Deprecate unused methods in ElementBrowser

There are 3 methods in ElementBrowser which are never used in the core.
We deprecate them, so they can be removed two versions later.

The methods are:
 * checkFolder
 * isWebFolder
 * setRecordList

Releases: 6.2
Resolves: #55985
Change-Id: I3e4f34e7ebaba9e8eeb0332e9f43c0e4acd2e706
Reviewed-on: https://review.typo3.org/27847
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Form sysext entry script cleanup 47/27347/12
Anja Leichsenring [Tue, 25 Feb 2014 15:18:48 +0000 (16:18 +0100)]
[TASK] Form sysext entry script cleanup

The form sysext contains a wizard to provide help for form creation.
This script used the init.php entry script. This is no longer wanted,
but the API can be used to add wizards.

To do so, some files were moved around and follow the same schema
as shown in openid sysext.

Change-Id: I6b6c41de6c271c56404151b1ec95f45e6f7786af
Resolves: #55669
Releases: 6.2
Reviewed-on: https://review.typo3.org/27347
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Use new way to register edit wizard 42/27842/2
Helmut Hummel [Tue, 25 Feb 2014 14:31:43 +0000 (15:31 +0100)]
[TASK] Use new way to register edit wizard

Resolves: #56272
Releases: 6.2
Change-Id: Idfcb04fac9f1c4e6637b7df929694b193266c825
Reviewed-on: https://review.typo3.org/27842
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[FEATURE] Add new way to register a TCA wizard 41/27841/4
Helmut Hummel [Tue, 25 Feb 2014 13:41:24 +0000 (14:41 +0100)]
[FEATURE] Add new way to register a TCA wizard

Wizards used to be registered by defining a script path
to an entry script. Since we now aim to reduce
the number of entry scripts, wizards should be called
through mod.php and be registered accordingly.
However with the additional requirement of adding
CSRF protection for all mod.php calls, we cannot
hard code the script URLs for wizards any more.
Instead BackendUtility::getModuleUrl should be used,
which adds the CSRF protection token.
Since this token depends on the current user session
and TCA might be cached, we need a new way to register
a wizard by just specifying the module name in TCA.

FormEngine should then take care to call
BackendUtility::getModuleUrl()

Resolves: #56268
Releases: 6.2
Change-Id: I8dfd2f49257f673e0490e2553da63359a8e68776
Reviewed-on: https://review.typo3.org/27841
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Rename update wizard to upgrade wizard 17/27617/3
Helmut Hummel [Thu, 13 Feb 2014 16:59:28 +0000 (17:59 +0100)]
[TASK] Rename update wizard to upgrade wizard

For the release of TYPO3 4.5 that the wizard in
install tool was renamed to "Upgrade Wizard"
to distinguish between patch level updates and
major version upgrades.

During the refactoring of the install tool for 6.2
the wizard was named "Update wizard again"

Fix the name again and name the upgrade wizard
"Upgrade Wizard" again.

Releases: 6.2
Resolves: #55970
Change-Id: I2cc75b7dfc5ddb3889a080270bf90a101fed935a
Reviewed-on: https://review.typo3.org/27617
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[TASK] Use DataHandler testing framework for simple import test 25/27325/3
Marc Bastian Heinrichs [Tue, 4 Feb 2014 17:10:28 +0000 (18:10 +0100)]
[TASK] Use DataHandler testing framework for simple import test

Adapt the impexp simple import test to the testing framework
available with #54855.

Resolves: #55664
Related: #54855
Releases: 6.2
Change-Id: I6f1e9eb6ef3bda5b984ac67af3964fed90ba41f2
Reviewed-on: https://review.typo3.org/27325
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Missing move placeholders in irre_tutorial tests 17/27817/2
Oliver Hader [Mon, 24 Feb 2014 16:08:38 +0000 (17:08 +0100)]
[BUGFIX] Missing move placeholders in irre_tutorial tests

The functional test cases using EXT:irre_tutorial need to
enable move placeholders. $TCA[<table>]['ctrl']['versioningWS']
needs to be "2" and not just TRUE

Resolves: #56244
Releases: 6.2
Change-Id: Ic47536f26fd23a15b2c31c3eb05c1f30acd82865
Reviewed-on: https://review.typo3.org/27817
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Can't remove static templates from selection in template module 20/27820/2
Wouter Wolters [Mon, 24 Feb 2014 22:00:14 +0000 (23:00 +0100)]
[BUGFIX] Can't remove static templates from selection in template module

Add missing '$' in front of formEl

Resolves: #56221
Releases: 6.2
Change-Id: Ia9b3260eebd007a60a34c33ac357fa84c572c8ac
Reviewed-on: https://review.typo3.org/27820
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jost Baron
Tested-by: Jost Baron
5 years ago[TASK] Remove unused $arrayConstraint in IndexerServiceTest 21/27821/2
Wouter Wolters [Mon, 24 Feb 2014 22:07:49 +0000 (23:07 +0100)]
[TASK] Remove unused $arrayConstraint in IndexerServiceTest

The array was used by a mock call which is removed from
the test.

Resolves: #56119
Releases: 6.2
Change-Id: I6aa5ad720a52a710e59b9570a769396d6acb37fb
Reviewed-on: https://review.typo3.org/27821
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefano Kowalke
Tested-by: Stefano Kowalke
5 years ago[BUGFIX] felogin reset password links not clickable 76/17176/6
Jigal van Hemert [Tue, 1 Jan 2013 10:28:18 +0000 (11:28 +0100)]
[BUGFIX] felogin reset password links not clickable

Encoding a few extra character besides the ones according to RFC3986
makes password reset links working again in various mail clients which
do not comply to this RFC (and which do not have plans to fix this in
the near future).

Change-Id: I0b42bef6cb732c5fc6cc2d900407271cb606e301
Fixes: #23984
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/17176
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Adding new menu types triggers error 91/27591/2
Francois Suter [Thu, 13 Feb 2014 08:10:53 +0000 (09:10 +0100)]
[BUGFIX] Adding new menu types triggers error

With the addition of categories-related menus, new fields were added
to the tt_content "menu" palette for handling categories relations.
This causes problems when people define new menu types.

This patch adds the categories-related fields in a more targeted
way using subtypes_addlist. The difference is that these fields
are not *in* the palette anymore, but just after it. I think
it is okay from a usability point of view and it makes the whole
categories thing less intrusive.

Resolves: #54041
Releases: 6.2
Change-Id: I923a6ec0d7716821626a31a95d80027987038bf1
Reviewed-on: https://review.typo3.org/27591
Tested-by: Dirk Klimpel
Reviewed-by: Dirk Klimpel
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove outdated upgrade wizards 76/26776/7
Steffen Ritter [Mon, 13 Jan 2014 09:25:16 +0000 (10:25 +0100)]
[TASK] Remove outdated upgrade wizards

The core ships upgrade wizards for all versions since TYPO3 CMS 4.2.
Users upgrading to TYPO3 CMS 6.2 LTS should have at least TYPO3 4.5 LTS
or later. Therefore all Upgrade-Wizards which already have been executed
to upgrade to TYPO3 CMS 4.5 LTS and below can be safely removed for the
current LTS.

This change removed all these wizards relating to changes in 4.2, 4.3 and
4.5.

Resolves: #54930
Releases: 6.2
Change-Id: Ia691e3ca7dd347c6748a8e9d753278b2247f75b9
Reviewed-on: https://review.typo3.org/26776
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Switch info and func module to mod dispatcher 08/27508/11
Anja Leichsenring [Sun, 9 Feb 2014 11:52:14 +0000 (12:52 +0100)]
[TASK] Switch info and func module to mod dispatcher

BE modules info and func now uses mod.php.

Changing the entry script for func and info module
will cause integrated submodules to fail in
case they use the old entry point index.php
with a relative path somewhere in funcMenu or in
other links or actions.

A compatibility layer is introduced in
typo3/index.php to catch those old
links and redirect to mod.php with proper parameters.

Change-Id: I83d31b6004ae3556dd8bf7c5c47b0fea39aaad55
Resolves: #55809
Resolves: #55672
Resolves: #55670
Releases: 6.2
Reviewed-on: https://review.typo3.org/27508
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix JS concat if first file is forced on top 93/27793/6
Benjamin Kott [Sun, 23 Feb 2014 12:00:32 +0000 (13:00 +0100)]
[BUGFIX] Fix JS concat if first file is forced on top

If a javascript file is forceOnTop the script uses array_unshift()
to put the file at the beginning of the section array. If this is
the first file that got processed, the array does not exist yet,
so the array_unshift function returns NULL and the file
will not added to the array.

The fix properly initalizes the section sub-array.

Resolves: #56242
Releases: 6.2, 6.1
Change-Id: I23af7862263fb0685032c34ded8736df87ddeb99
Reviewed-on: https://review.typo3.org/27793
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[!!!][TASK] Remove empty classes implementing AbstractTreeView 27/27527/8
Tymoteusz Motylewski [Mon, 10 Feb 2014 16:25:37 +0000 (17:25 +0100)]
[!!!][TASK] Remove empty classes implementing AbstractTreeView

The tree class hierachie contains 3 empty classes, removed
by the patch:

* \TYPO3\CMS\Rtehtmlarea\ImageFolderTree
* rteFolderTree extends localPageTree in class.browse_links.php
* rtePageTree extends localFoltderTree in class.browse_links.php

Resolves: #55847
Related: #55830
Releases: 6.2
Change-Id: I5d0d92a484c37b6c2812f3350ab3f4dd3dfd15c8
Reviewed-on: https://review.typo3.org/27527
Tested-by: Tymoteusz Motylewski
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Windows issues with long file names in Git sources 15/27815/3
Oliver Hader [Mon, 24 Feb 2014 14:21:18 +0000 (15:21 +0100)]
[TASK] Windows issues with long file names in Git sources

The recent DataHander functional tests integrate file names that
are very long since they contain a description of what actually
is expected in the accordant test assertion file.

However, Windows has a limit of 260 characters per file path.
The longest file path of the mentioned functional tests has been
223 characters and is now reduced to 166 characters.

Resolves: #56177
Releases: 6.2
Change-Id: I1490a3f0fae7ef40547d81e304cb98077ab6142b
Reviewed-on: https://review.typo3.org/27815
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[!!!][SECURITY] Add CSRF Protection for tce_file.php 91/27691/4
Alexander Schnitzler [Tue, 18 Feb 2014 13:37:57 +0000 (14:37 +0100)]
[!!!][SECURITY] Add CSRF Protection for tce_file.php

Add a token check in tce_file.php and token generation
everywhere forms for or links to tce_file.php are created.

Additionaly make sure, an instance of ExtendedFileUtility
is created in FileController on initialization to prevent
a fatal "Call to a member function on a non-object" error
in FileController::finish.

Releases: 6.2
Resolves: #55515
Change-Id: Ifd585661ac2cac6c88eaca5ad63b447d27e35395
Reviewed-on: https://review.typo3.org/27691
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Limit the exported record fields in impexp 03/27303/8
Marc Bastian Heinrichs [Mon, 3 Feb 2014 16:12:27 +0000 (17:12 +0100)]
[TASK] Limit the exported record fields in impexp

To be able to compare mostly only the data provided in the
database fixtures, the export needs to be limited to a given
set of fields of a record type.
This will loose the strict xml comparison of all existing fields
in the database and the tests would not break whenever we
change ext:core or ext:frontend ext_tables.sql.

Resolves: #55625
Releases: 6.2
Change-Id: Ie48e540ab1c9e271b64b893353a84c34ac982a50
Reviewed-on: https://review.typo3.org/27303
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[TASK] EXT: tstemplate - use treeline sprite icons 00/27800/2
Felix Kopp [Sun, 23 Feb 2014 22:20:13 +0000 (23:20 +0100)]
[TASK] EXT: tstemplate - use treeline sprite icons

Bring treeline sprite icons to t3-table in Template backend module.

Resolves: #56229
Releases: 6.2
Change-Id: I95cfad211fe5750d0786592986b4849f5f5b9826
Reviewed-on: https://review.typo3.org/27800
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
5 years ago[BUGFIX] Using files in eID results in fatal error 92/27692/2
Steffen Ritter [Tue, 18 Feb 2014 13:42:43 +0000 (14:42 +0100)]
[BUGFIX] Using files in eID results in fatal error

In TYPO3_MODE == 'FE' we attached language overlays for file metadata
via an Signal in the MetaDataRepository. Within this signal the
methods of the PageRepository in $GLOBALS['TSFE'] are used to do the
actual language overlay.

When using eID the Frontend is not initialized. When creating file
objects in eID these functions are accessed on non-objects which
obviously leads to a fatal error.

As a result the registration of the Slot is extended to not register
itself in case of eID requests.

Resolves: #54232
Releases: 6.2
Change-Id: I4ccf226f48eb85428ce281c4a941ff7e834c2f88
Reviewed-on: https://review.typo3.org/27692
Reviewed-by: Wouter Wolters
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] New Content Element: hide list style 04/27804/2
Felix Kopp [Sun, 23 Feb 2014 22:43:50 +0000 (23:43 +0100)]
[BUGFIX] New Content Element: hide list style

Hides bullet points in New Content Element Wizard.

Resolves: #56062
Releases: 6.2
Change-Id: Iead660b30df3cabea76d22dc962802c61be01ea7
Reviewed-on: https://review.typo3.org/27804
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] EXT: t3skin - .list-unstyled for ol & ul 01/27801/2
Felix Kopp [Sun, 23 Feb 2014 22:30:44 +0000 (23:30 +0100)]
[TASK] EXT: t3skin - .list-unstyled for ol & ul

Brings CSS class for lists that semantically need to be
UL or OL tags but do not have a visible list-style-item:

<ul class="list-unstyled">
<li>…</li>
</ul>
<ol class="list-unstyled">
<li>…</li>
</ol>

Resolves: #55834
Releases: 6.2
Change-Id: Ic51fbe1f0995b4504d5b10a4c83775a977a19e33
Reviewed-on: https://review.typo3.org/27801
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years agoRevert "[TASK] FrontendContentAdapterService processes record repeatedly" 88/27788/5
Markus Klein [Sat, 22 Feb 2014 11:16:24 +0000 (12:16 +0100)]
Revert "[TASK] FrontendContentAdapterService processes record repeatedly"

This reverts commit 3adf78359015401648fcec4befe70e9bd0b7a2ea

This patch breaks section menus as it introduces invalid caching.
The original patch has not yet been backported.

Resolves: #56209
Resolves: #54953
Releases: 6.2
Change-Id: Ia3fc8718ed3907913a5538eee102260425f2cf16
Reviewed-on: https://review.typo3.org/27788
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Upgrade normalize.css to version 3.0.0 46/27046/7
Wouter Wolters [Fri, 24 Jan 2014 18:22:03 +0000 (19:22 +0100)]
[TASK] Upgrade normalize.css to version 3.0.0

Resolves: #55316
Releases: 6.2
Change-Id: I945f0c033f3d69c1951ea9ee59b0a00c5f866175
Reviewed-on: https://review.typo3.org/27046
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years agoRevert "[CLEANUP] Replace strlen() with === for zero length check" 92/27792/2
Stefan Neufeind [Sun, 23 Feb 2014 11:34:13 +0000 (12:34 +0100)]
Revert "[CLEANUP] Replace strlen() with === for zero length check"

This reverts commit de27a20afbd8f413f60029afc5622c7b33212322

Change-Id: I078d2f7bbff605c91d83a9853e8feb9c31d57ccc
Reviewed-on: https://review.typo3.org/27792
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Installer rejects traling slash in link target 29/27229/2
Andreas Wolf [Sat, 1 Feb 2014 12:18:32 +0000 (13:18 +0100)]
[BUGFIX] Installer rejects traling slash in link target

When having e.g. the link for ``typo3/`` pointing to
``typo3_src/typo3/``, the install tool complains because the trailing
slash is not expected. This slash is however perfectly ok, as there is
no difference between typo3_src/typo3 and typo3_src/typo3/ – both point
to the same "file" (i.e. node in the filesystem structure).

This patch strips trailing slashes from the actual link target before
doing the check, so no change to existing configuration is necessary.

Change-Id: Ibcb2118a2bb8fcf004470f1a949824576ad4d1ec
Resolves: #55551
Releases: 6.2
Reviewed-on: https://review.typo3.org/27229
Reviewed-by: Benjamin Mack
Reviewed-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[CLEANUP] Replace strlen() with === for zero length check 91/27091/10
Markus Klein [Sun, 23 Feb 2014 10:21:20 +0000 (11:21 +0100)]
[CLEANUP] Replace strlen() with === for zero length check

It is faster to compare a string with === '' to find out if it's empty
than to run strlen() on it.

The replacement rules are applied as follows:
 *    if (strlen($str))
   => if ((string)$str !== '')
 *    if (!is_string($str) || strlen($str) === 0)
   => if (!is_string($str) || $str === '')
 * If it can be seen easily that $str is a string,
   the typecast is omitted.

Resolves: #54091
Releases: 6.2
Change-Id: I59c5cbccea4f98b8f282377e6aa67d970859a457
Reviewed-on: https://review.typo3.org/27091
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] New SignalSlot after preInit in EditDocumentController 77/27777/2
Julian Kleinhans [Fri, 21 Feb 2014 16:48:55 +0000 (17:48 +0100)]
[TASK] New SignalSlot after preInit in EditDocumentController

Adds a new SignalSlot possibility after the preInit method call.

Resolves: #56195
Releases: 6.2
Change-Id: Ia68734999a0e5fbe6c945d9e28d8571cd6192e75
Reviewed-on: https://review.typo3.org/27777
Reviewed-by: Tomas Norre Mikkelsen
Tested-by: Tomas Norre Mikkelsen
Reviewed-by: Erik Frister
Tested-by: Erik Frister
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Add additional configuration for functional tests 73/27773/4
Helmut Hummel [Fri, 21 Feb 2014 14:22:13 +0000 (15:22 +0100)]
[TASK] Add additional configuration for functional tests

Our functional test suit does not fail currently when
tested code emits a PHP warning. This is due to the
fact that the factory configuration uses the
production exception handler which silently discards
warnings.

This change adds additional configuration that
is merged with the factory configuration.

In this configuration the TYPO3 exception handling
is disabled and the core and classes cache is
disabled.

Additionally a new property is added to the base
class to easily add some configuration values that
might be needed for the test case.

Resolves: #56187
Related: #56086
Releases: 6.2
Change-Id: I5c7c2c0d495bae06a56d2285b8d521eaa4ab37d2
Reviewed-on: https://review.typo3.org/27773
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Use absolute path to check for extensions 86/27786/2
Helmut Hummel [Fri, 21 Feb 2014 15:33:52 +0000 (16:33 +0100)]
[BUGFIX] Use absolute path to check for extensions

The functional test utility assumes that the current
working directory is the document root, which must
not necessarily be true.

Use the absolute path to check for existence of
extension directories instead.

Resolves: #56204
Releases: 6.2
Change-Id: I9e5fa06f0e069c04586de7c23edc80e070ef4aa9
Reviewed-on: https://review.typo3.org/27786
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix PHP warnings in functional tests 85/27785/3
Helmut Hummel [Fri, 21 Feb 2014 21:50:46 +0000 (22:50 +0100)]
[BUGFIX] Fix PHP warnings in functional tests

Some PHP warnings occur in functional tests due
to missing initialization of arrays or unused
function parameters.

Resolves: #56203
Related: #56187
Releases: 6.0
Change-Id: I1cd75de253382759315a8f72cff6e497b31bcc07
Reviewed-on: https://review.typo3.org/27785
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Cleanup \TYPO3\CMS\Lang\LanguageService 45/27745/4
Michiel Roos [Wed, 19 Feb 2014 23:07:10 +0000 (00:07 +0100)]
[TASK] Cleanup \TYPO3\CMS\Lang\LanguageService

* Cache hsc values of calls to sL()
* Code cleanup
* Use !empty() instead of count() for objects known to be an array

Change-Id: Ie015f9755b98c41df185865325ea15ce42179e23
Resolves: #56109
Releases: 6.2
Reviewed-on: https://review.typo3.org/27745
Reviewed-by: Steffen Ritter
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] RTE cannot run in IE 11+ with ExtJS 3.4.1 76/27776/4
Stanislas Rolland [Fri, 21 Feb 2014 15:54:53 +0000 (10:54 -0500)]
[BUGFIX] RTE cannot run in IE 11+ with ExtJS 3.4.1

Solution: Configure a hook in frontend to add a meta tag just after
the head tag whenever rtehtmlarea is in use on the page and the user
agent is IE 11+. The meta tag instructs IE to emulate IE 10.

Resolves: #56192
Releases: 6.2
Change-Id: Icc81f14c107360a47a34403032e5fe7890f1d784
Reviewed-on: https://review.typo3.org/27776
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] Remove class loader in functional test tear down 75/27775/2
Helmut Hummel [Fri, 21 Feb 2014 15:15:50 +0000 (16:15 +0100)]
[BUGFIX] Remove class loader in functional test tear down

The functional test teardown does not remove the
class loader but removes the instance directories.
Because of this the TYPO3 class loader is still
triggered (by PHPUnit classes) and tries to write
things to a cache directory that does not exist any more.

Resolves: #56086
Releases: 6.2
Change-Id: Ib6acb588fb8b84c64d04882228822f6398838b6b
Reviewed-on: https://review.typo3.org/27775
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Use environment variable for functional test bootstrap 71/27771/3
Helmut Hummel [Fri, 21 Feb 2014 12:32:03 +0000 (13:32 +0100)]
[TASK] Use environment variable for functional test bootstrap

Make it possible to determine the original root path
of the installation by setting an environment variable
just like in unit test bootstrap.

Releases: 6.2
Resolves: #56182
Change-Id: I42af5d4db20a23eb5d1ce90fc87b6df818a11e88
Reviewed-on: https://review.typo3.org/27771
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Add functional tests for discarding created elements 69/27769/2
Oliver Hader [Fri, 21 Feb 2014 11:52:31 +0000 (12:52 +0100)]
[TASK] Add functional tests for discarding created elements

The workspaces API has the command "clearWSID" that reverts
elements that have been modified/created/deleted in a workspace.
The regular behavior is to keep the elements but mark it as
deleted and unset the value in "t3ver_wsid".

Resolves: #56179
Releases: 6.2
Change-Id: I55bc72add6f41449dd99f5b6b2816cd1cda3e092
Reviewed-on: https://review.typo3.org/27769
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Parent localization pointer missing in IRRE tests 68/27768/2
Oliver Hader [Fri, 21 Feb 2014 10:09:07 +0000 (11:09 +0100)]
[BUGFIX] Parent localization pointer missing in IRRE tests

The parent localization pointer (in this very case
l18n_parent, instead of l10n_parent) is missing in
the DataSet scenarios and assertions.

Resolves: #56161
Releases: 6.2
Change-Id: Ieac6dd15d84f15488e0ee4690186efe2fb8dead6
Reviewed-on: https://review.typo3.org/27768
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Integrate IRRE CSV Functional Tests 52/27752/2
Oliver Hader [Thu, 20 Feb 2014 10:20:07 +0000 (11:20 +0100)]
[TASK] Integrate IRRE CSV Functional Tests

Integrate comma separated value functional tests for Inline
Relational Record Editing for both live and workspace context.

Resolves: #56143
Releases: 6.2
Change-Id: I8750cabd2e4df41e229ada888a43a104339cc55c
Reviewed-on: https://review.typo3.org/27752
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Update file type on mimetype change 88/26288/6
Alexander Stehlik [Wed, 5 Feb 2014 16:05:09 +0000 (17:05 +0100)]
[BUGFIX] Update file type on mimetype change

If the mime type of a file has changed, the type property of a file
will be updated, too.

Resolves: #54305
Releases: 6.2
Change-Id: I013e2adbbb3d3cd3973ab50c8e88806b9477fe90
Reviewed-on: https://review.typo3.org/26288
Reviewed-by: Markus Klein
Reviewed-by: Marcin Sągol
Reviewed-by: Steffen Ritter
Tested-by: Markus Klein
Tested-by: Steffen Ritter
5 years ago[TASK] Fix a few variable names 62/27762/2
Fabien Udriot [Thu, 20 Feb 2014 19:53:51 +0000 (20:53 +0100)]
[TASK] Fix a few variable names

Fix a few typo in the variable names.

Change-Id: I334e31a1e8e37ce7a79a3b905758843d51463c26
Releases: 6.2
Resolves: #56165
Reviewed-on: https://review.typo3.org/27762
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] moveContentRecordToDifferentPageAndChangeSorting fails 33/27733/3
Oliver Hader [Wed, 19 Feb 2014 18:30:02 +0000 (19:30 +0100)]
[BUGFIX] moveContentRecordToDifferentPageAndChangeSorting fails

In a workspace, an existing content record is moved to an
existing page. Another existing record is moved after the
previously moved record on the target page. The Functional
Tests show, that the content records are faulty after the
processing and the first content record disappeared.

A similar behaviour has been discovered for pages which finally
lead to the regression causing this bug in issue #33104. Back
then a hook has been introduced for moving page records and
post-processing the database values. However, this hook has
been called for all move operations for any table and was wrong
in terms of the expected specific problem to be solved.

The hook gets reverted, since it's sufficient to resolve move
placeholders if a record shall be created after an existing one.

Resolves: #55573
Releases: 6.2
Change-Id: Ie5cbc95daf4d46f4204cf18e80e17ff4fa37f496
Reviewed-on: https://review.typo3.org/27733
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Make Typo3DbBackend use DatabaseConnection 54/27254/9
Felix Oertel [Sat, 1 Feb 2014 23:25:12 +0000 (00:25 +0100)]
[BUGFIX] Make Typo3DbBackend use DatabaseConnection

While Typo3DbBackend claims to be Extbase's connection to
the TYPO3 API, in reality it writes a lot of SQL state-
ments itself. This replaces self-written statements with
the according DatabaseConnection API call.

Releases: 6.2
Resolves: #55571
Change-Id: Ia4f6ef0aadda16b6c5e89c7b36c8f91b185aac25
Reviewed-on: https://review.typo3.org/27254
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Mathias Brodala
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] DatabaseConnection::listQuery wrong usage of strpos() 49/27749/2
Markus Klein [Thu, 20 Feb 2014 09:36:45 +0000 (10:36 +0100)]
[BUGFIX] DatabaseConnection::listQuery wrong usage of strpos()

In DatabaseConnection::listQuery strpos() is used with wrong
parameter order.

Resolves: #56135
Releases: 6.2, 6.1, 6.0
Change-Id: Iaa18d46442a2aac21a836216cb61ae376bbb2090
Reviewed-on: https://review.typo3.org/27749
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Rename tt_content.tx_irretutorial_hotels in tests 44/27744/2
Oliver Hader [Wed, 19 Feb 2014 22:03:12 +0000 (23:03 +0100)]
[TASK] Rename tt_content.tx_irretutorial_hotels in tests

This change affects EXT:irre_tutorial and functional tests only:
* rename tx_irretutorial_hotels to tx_irretutorial_1nff_hotels
* use constants for table and field names in functional tests

Resolves: #56132
Releases: 6.2
Change-Id: Iee2240c489c5523fbea208145ba667f349fde592
Reviewed-on: https://review.typo3.org/27744
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Category localization cannot be rendered 73/27673/5
Oliver Hader [Mon, 17 Feb 2014 22:11:45 +0000 (23:11 +0100)]
[BUGFIX] Category localization cannot be rendered

Localized sys_category records cannot be rendered in frontend,
since only records with a positive pid value are overlaid -
however, sys_category is stored on the root-level.

Resolves: #56059
Releases: 6.2, 6.1
Change-Id: I211dad5086adf30723ef4f44757fe6a3121ac29e
Reviewed-on: https://review.typo3.org/27673
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Use MM_oppositeUsage for category relations 31/27731/2
Oliver Hader [Wed, 19 Feb 2014 13:26:03 +0000 (14:26 +0100)]
[BUGFIX] Use MM_oppositeUsage for category relations

The MM_oppositeUsage property allows to apply match fields
of the opposite relation to MM records. This feature shall
be enabled for sys_category records as well.

Resolves: #56122
Related: #56061
Releases: 6.2
Change-Id: I33c9f3c471d66c4154be5c2fb5180254401096f0
Reviewed-on: https://review.typo3.org/27731
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[FEATURE] Introduce MM_oppositeUsage property 77/27677/4
Oliver Hader [Wed, 19 Feb 2014 13:17:11 +0000 (14:17 +0100)]
[FEATURE] Introduce MM_oppositeUsage property

On copying a sys_category record, a new MM reference is created,
however without setting the "fieldname". This value is basically
defined from the opposite entity with MM_match_fields, but
cannot be accessed.

This change introduces the MM_oppositeUsage property for MM
definitions in the TCA.

Example:
'config' => array(
  'allowed' => '*',
  'MM' => 'tx_myextension_first_second_mm',
  'MM_oppositeUsage' => array(
    'tt_content' => array('somefield'),
    'tx_myextension_domain_model' => array('some_property'),
  ),
),

Resolves: #56061
Documentation: #56123
Releases: 6.2
Change-Id: I26fd54688cf44d6a026ccdb3ca9276583b32acd3
Reviewed-on: https://review.typo3.org/27677
Reviewed-by: Wouter Wolters
Reviewed-by: Ernesto Baschny
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Optimize GeneralUtility::trimExplode() 86/27086/20
Michiel Roos [Tue, 28 Jan 2014 09:04:52 +0000 (10:04 +0100)]
[TASK] Optimize GeneralUtility::trimExplode()

This often used method can be about 5% more performant by rewriting it.

Change-Id: Iee80a35ebd98c3521a75977bc7ab45d170858e24
Resolves: #55198
Releases: 6.2
Reviewed-on: https://review.typo3.org/27086
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Categories as exclude field 73/27373/4
Francois Suter [Thu, 23 Jan 2014 12:29:34 +0000 (13:29 +0100)]
[BUGFIX] Categories as exclude field

When a table is marked as being categorizable, the
categories field is added with an "exclude" flag
hard-coded to 0. Thus it is not possible to hide
this field for editors.

This patch changes the default value to 1 and makes
overridable.

Resolves: #53454
Documentation: #55718
Releases: 6.2
Change-Id: Iff2431b4294b8d3b9cf3dff291186e1a6a2ebafb
Reviewed-on: https://review.typo3.org/27373
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[TASK] Enable DataHandler frontend rendering tests 11/27711/3
Oliver Hader [Wed, 19 Feb 2014 09:05:32 +0000 (10:05 +0100)]
[TASK] Enable DataHandler frontend rendering tests

After having performed changes to data structures using the
DataHandler, the correct impact for the frontend needs to be
asserted. This patch checks the correct behavior for DataHandler
action tests for regular, MM and IRRE disposal.

Resolves: #56104
Releases: 6.2
Change-Id: I99f11f6b039c31e08614caf8ee9bca9d47700b93
Reviewed-on: https://review.typo3.org/27711
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Add framework for frontend rendering functional tests 13/27413/19
Oliver Hader [Wed, 19 Feb 2014 09:04:28 +0000 (10:04 +0100)]
[TASK] Add framework for frontend rendering functional tests

To ensure that actions in the backend have an accordant and
correct impact in the frontend, a frontend request needs to
be triggered from the functional test execution.
The response of that simulated frontend request shall be
delivered as JSON, exceptions need to be caught and
forwarded to the test suite as well. Besides that, it is
required to have a possibility to set up TypoScript
configuration, modify TCA and TYPO3_CONF_VARS for further
hook processing.

Resolves: #55882
Releases: 6.2
Change-Id: I54d475e8f1ce01fd7cb8c64b68c2318b1e9f7bbe
Reviewed-on: https://review.typo3.org/27413
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] getFilesInDirCanOrderByMtime-test should use vfs 19/27719/3
Stefan Neufeind [Wed, 19 Feb 2014 12:33:05 +0000 (13:33 +0100)]
[TASK] getFilesInDirCanOrderByMtime-test should use vfs

Follow-up for PHP 5.3 compatiblity.

Resolves: #56121
Releases: 6.2
Change-Id: I948eb3063c2e6b014b8d69c2011789c7dbe58748
Reviewed-on: https://review.typo3.org/27719
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] getFilesInDirCanOrderByMtime-test should use vfs 17/27717/6
Stefan Neufeind [Wed, 19 Feb 2014 12:33:05 +0000 (13:33 +0100)]
[TASK] getFilesInDirCanOrderByMtime-test should use vfs

As the other tests in GeneralUtilityTest also
getFilesInDirCanOrderByMtime() should use vfs.
Otherwise we might run into random problems if some
mtimes are equal.

Change-Id: Ic5ad10bd5beedb26c00d48602ebd5455525e4826
Resolves: #56121
Releases: 6.2
Reviewed-on: https://review.typo3.org/27717
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Discard vs. Delete workspace changes in tests 12/27712/3
Oliver Hader [Wed, 19 Feb 2014 10:56:16 +0000 (11:56 +0100)]
[BUGFIX] Discard vs. Delete workspace changes in tests

Discarding workspace changes works with the version command
"clearWSID" which might come down to a "delete" action if the
versioned records have a delete or new placeholder (which is
the case for copied or localized elements).
However, the functional tests need to use the "clearWSID"
instead of the "delete" command.

Resolves: #56111
Releases: 6.2
Change-Id: Id10413048a68abdb5ef05bb6e20e6cb6460f9742
Reviewed-on: https://review.typo3.org/27712
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[CLEANUP] GeneralUtility::getFilesInDir() 68/25768/20
Michiel Roos [Fri, 29 Nov 2013 17:49:15 +0000 (18:49 +0100)]
[CLEANUP] GeneralUtility::getFilesInDir()

Refactor getFilesInDir to use scandir().

Change-Id: Iafca3e7b7610ef0b11441ef118c85c8e6cc481b8
Resolves: #54095
Releases: 6.2
Reviewed-on: https://review.typo3.org/25768
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Suppress EXIF warnings indexing images 60/27160/2
Felix Althaus [Thu, 30 Jan 2014 16:42:44 +0000 (17:42 +0100)]
[BUGFIX] Suppress EXIF warnings indexing images

FileContentParser used to issue a warning trying to index image
files with corrupted EXIF data. Suppress these warnings to fail
silently.

Resolves: #55286
Releases: 6.2, 6.1
Change-Id: I863601f5579ab74a0743ab684cf1d898b633edba
Reviewed-on: https://review.typo3.org/27160
Reviewed-by: Wouter Wolters
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] RTE: Required ExtJs css files are not loaded in frontend 47/27647/2
Stanislas Rolland [Sun, 16 Feb 2014 23:30:15 +0000 (18:30 -0500)]
[BUGFIX] RTE: Required ExtJs css files are not loaded in frontend

Solution: Add ExtJs css files required by the RTE

Resolves: #56027
Releases: 6.2
Change-Id: I56c81a0119a34097aa8c4a3dd15655cb5a6ca635
Reviewed-on: https://review.typo3.org/27647
Reviewed-by: Wouter Wolters
Reviewed-by: Stanislas Rolland
Tested-by: Stanislas Rolland
5 years ago[BUGFIX] FAL links in RTE not transformed when link has rel attribute 42/27142/3
Stanislas Rolland [Thu, 30 Jan 2014 02:04:52 +0000 (21:04 -0500)]
[BUGFIX] FAL links in RTE not transformed when link has rel attribute

Problem: When the RTE inserts the link, the href looks like
http://somedomain/?file:1234. If a rel attribute is present, the link
is not transformed into a typolink on the way to the database.
However, the href attribute is not transformed, as it should, into a
normal file url. It should because the a-tag will be rendered as is in
the frontend.

Solution: When a link is not be transformed into a typolink,
transform the href into a normal file url.

Resolves: #54944
Release: 6.2
Change-Id: I92c45363ffd62de0f4e89941944f55320d4fc708
Reviewed-on: https://review.typo3.org/27142
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Steffen Ritter
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Various static calls to non-static functions 79/27679/2
Markus Klein [Tue, 18 Feb 2014 09:14:53 +0000 (10:14 +0100)]
[BUGFIX] Various static calls to non-static functions

Resolves: #56067
Releases: 6.2, 6.1, 6.0
Change-Id: I6d1e19026afde81bec46cec3dff9060fa6042c43
Reviewed-on: https://review.typo3.org/27679
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Show labels of additional doktypes in new page drag area 34/24934/3
Caspar Stuebs [Mon, 21 Oct 2013 14:46:35 +0000 (16:46 +0200)]
[BUGFIX] Show labels of additional doktypes in new page drag area

Get the labels for the doktypes from TCA

Resolves: #52955
Releases: 6.2, 6.1
Change-Id: I6d70c11f1711bf191a4ce14a91796819224649da
Reviewed-on: https://review.typo3.org/24934
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Check identity map for existing objects 52/25252/11
Nico de Haen [Sun, 10 Nov 2013 23:35:36 +0000 (00:35 +0100)]
[BUGFIX] Check identity map for existing objects

The DataMapper should check if an object is already in the identityMap
before calling fetchRelated, since otherwise the object will be retrieved
from the database again.

Resolves: #53514
Releases: 6.1,6.2
Change-Id: I24e262322f1f0ba3c346fa01c50fa9063866aef7
Reviewed-on: https://review.typo3.org/25252
Reviewed-by: Nico de Haen
Reviewed-by: Fabien Udriot
Tested-by: Wouter Wolters
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
5 years ago[BUGFIX] No duplicate insertion in addToAllTCAtypes 83/27583/2
Alexander Stehlik [Wed, 12 Feb 2014 15:25:05 +0000 (16:25 +0100)]
[BUGFIX] No duplicate insertion in addToAllTCAtypes

This patch improves the regular expression in
ExtensionManagementUtility::executePositionedStringInsertion().

It is made sure that the field name ends with a comma or a line
ending to prevent duplicate insertions of the string when field
names start with the same substring.

Resolves: #55932
Releases: 6.2
Change-Id: I375c40760a38b7f939086bb851911bd7f52509ca
Reviewed-on: https://review.typo3.org/27583
Reviewed-by: Michiel Roos
Tested-by: Michiel Roos
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Indexer does not update the FileObjects 90/27690/2
Steffen Ritter [Tue, 18 Feb 2014 13:18:08 +0000 (14:18 +0100)]
[BUGFIX] Indexer does not update the FileObjects

If the Indexer updates metadata during runtimer (after a file object)
has been created, the file object itself is not updated.

This leads to possible errors with image rendering, if files are to be
shown which have not been indexed before.

Releases: 6.2
Resolves: #53772
Change-Id: I70be5ebefe1e00e903694a576847fa8fba167461
Reviewed-on: https://review.typo3.org/27690
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Extend DataHandler IRRE functional tests 93/27693/2
Oliver Hader [Tue, 18 Feb 2014 10:19:45 +0000 (11:19 +0100)]
[TASK] Extend DataHandler IRRE functional tests

* create and copy
* create and localize
* modify and discard
* create and copy and discard
* create and localize and discard

Resolves: #56072
Releases: 6.2
Change-Id: Iead056883f7bbb2072a0bd082b05094d7d46101d
Reviewed-on: https://review.typo3.org/27693
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Use Backend User fixture for DataHandler tests 81/27681/2
Oliver Hader [Tue, 18 Feb 2014 09:32:51 +0000 (10:32 +0100)]
[TASK] Use Backend User fixture for DataHandler tests

Resolves: #56070
Releases: 6.2
Change-Id: Iaae9944796311d7e453b5374827acf7030e6bdbf
Reviewed-on: https://review.typo3.org/27681
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Forms: Input/textarea :focus style 62/27562/2
Felix Kopp [Tue, 11 Feb 2014 21:55:13 +0000 (22:55 +0100)]
[TASK] Forms: Input/textarea :focus style

Brings a discreet :focus style for fields and buttons in ice
blue to complement our favorite TYPO3 orange.

Is introduced for all input fields, input submit & input reset,
buttons and textareas - generally and without exceptions.

Select and multi select fields do not get this focus definition.

Resolves: #55901
Releases: 6.2
Change-Id: I49d958199e29560a766f4687aa76541d07702901
Reviewed-on: https://review.typo3.org/27562
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Invalid shortcut target on translated pages 65/12765/6
Oliver Hader [Sat, 13 Oct 2012 11:38:19 +0000 (13:38 +0200)]
[BUGFIX] Invalid shortcut target on translated pages

A feature to resolve shortcut links directly in menu rendering
does not consider the overlay behaviour of the "shortcut" value.

TSFE first uses the "shortcut" value of the original/default
page and then serves for possible translated alternatives
(TypoScriptFrontendController::checkTranslatedShortcut()).
In menu rendering it's the other way round, the translated
overlay (if any) is used directly - the fallback to use the
"shortcut" value of the original/default page is not implemented.

This change introduces the fallback when rendering menus, which
will take the "shortcut" value of the default language if the
value in the overlay is empty.

Change-Id: I26a9eb4813c6b99327043b0a764ec7ff80b6a905
Fixes: #36822
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/12765
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Missing encoding in flexforms IRRE javascript 83/26283/3
Alexey Gafiulov [Tue, 10 Dec 2013 14:55:50 +0000 (20:55 +0600)]
[BUGFIX] Missing encoding in flexforms IRRE javascript

encodeURIComponent is added to escape all special characters in
parameters for AJAX call.

Resolves: #54304
Releases: 6.2, 6.1, 6.0
Change-Id: I3559104e1a26241b519f40a10000637852a4f114
Reviewed-on: https://review.typo3.org/26283
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] concatenateJs/Css does not consider forceOnTop 40/27640/4
Markus Klein [Sun, 16 Feb 2014 10:11:15 +0000 (11:11 +0100)]
[BUGFIX] concatenateJs/Css does not consider forceOnTop

Setting the forceOnTop property for a JS or CSS file is not
observed if concatenateJs/Css is set as well.

Resolves: #53116
Resolves: #56019
Releases: 6.2, 6.1
Change-Id: Ica31656bd72f4a0249513206bac45aa16b929761
Reviewed-on: https://review.typo3.org/27640
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Add missing htmlspecialchars for thumbnail URL 70/27670/2
Wouter Wolters [Mon, 17 Feb 2014 21:27:16 +0000 (22:27 +0100)]
[BUGFIX] Add missing htmlspecialchars for thumbnail URL

Resolves: #56057
Releases: 6.2, 6.1
Change-Id: I9c1ec60e7518867d27e99681d3d18957a27c4983
Reviewed-on: https://review.typo3.org/27670
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Load file meta data properties before return 52/27652/2
Nicole Cordes [Mon, 17 Feb 2014 09:16:41 +0000 (10:16 +0100)]
[BUGFIX] Load file meta data properties before return

Currently it is not possible to edit files as an editor because no file
uid is submitted. This happens because meta data properties are not
loaded. This patch makes sure they get loaded before returning them.

Resolves: #56035
Releases: 6.2
Change-Id: I610aa50d785ea22cd1f0bc6265369cccf5bdd719
Reviewed-on: https://review.typo3.org/27652
Reviewed-by: Michiel Roos
Reviewed-by: Steffen Ritter
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Ignore empty inputs when creating new folders 51/27651/2
Frans Saris [Mon, 17 Feb 2014 09:07:00 +0000 (10:07 +0100)]
[BUGFIX] Ignore empty inputs when creating new folders

When you try to create one of multiple folders in filemodule
and leave one of the new name input fields empty this results
in a non catched exeption.

This change filters out the empty input fields and gives a
error message when no name is given.

Resolves: #56034
Releases: 6.2
Change-Id: I1d341d1b7951dc8e8fe64190168f8b71c6f75676
Reviewed-on: https://review.typo3.org/27651
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Inline upload progress queue styles are missing 43/27643/2
Frans Saris [Sun, 16 Feb 2014 16:25:27 +0000 (17:25 +0100)]
[BUGFIX] Inline upload progress queue styles are missing

The cleanup done in #55810 breaks the styling of the
inline upload progress queue.

This patch is a followup that removes the use of css class
file_list_normal in for DragUploader. And adds the missing
table css class so the progress queue looks correct again.

Resolves: #56020
Releases: 6.2
Change-Id: I2889041a0d3be82be9b5df462b816a8d5a130d7d
Reviewed-on: https://review.typo3.org/27643
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix clipboard thumbnail rendering 53/27653/4
Frans Saris [Mon, 17 Feb 2014 09:38:48 +0000 (10:38 +0100)]
[BUGFIX] Fix clipboard thumbnail rendering

The thumbnail rendering in filelist clibboard isn't
updated to use FAL. And adding folders to clipboard
with thumbnails enabled results in a fatal error.

This changes makes sure the thumbnail is only rendered
for files and updates the thumbnail part so it uses FAL.

Resolves: #56037
Releases: 6.2, 6.1
Change-Id: I2a0eccd633f5313fed9ab94b5081c13e08892900
Reviewed-on: https://review.typo3.org/27653
Tested-by: Wouter Wolters
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Add FileCollectionRegistry 57/27257/9
Frans Saris [Sun, 2 Feb 2014 10:04:44 +0000 (11:04 +0100)]
[TASK] Add FileCollectionRegistry

The classes belonging to the FileCollection types are hardwired
in ResourceFactory::createCollectionObject(), therefore you can
not use your own types.

This change introduces a Registry API that makes it possible to
register your own FileCollection type + class and has a generic
way to add the new type to TCA[sys_file_collection].

How to use:
- Register type in ext_localconf.php
  $register->registerFileCollectionClass(full_class_name, your_type);
- Add type to TCA in Configuration/TCA/sys_file_collection.php
  $register->addTypeToTCA(your_type, label, needed_fields);
  return $GLOBALS['TCA']['sys_file_collection'];

Resolves: #53910
Documentation: #56032
Releases: 6.2
Change-Id: Id6cb1c7a59f741b28fee7bdfef32890f34a072a5
Reviewed-on: https://review.typo3.org/27257
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove unused variable $field 66/27666/2
Stefano Kowalke [Mon, 17 Feb 2014 16:04:57 +0000 (17:04 +0100)]
[TASK] Remove unused variable $field

Resolves: #56011
Releases: 6.2
Change-Id: Ia5773bb02c82828896573c8410988d04aa69de68
Reviewed-on: https://review.typo3.org/27666
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Cleanup GeneralUtility::rmFromList 23/25723/9
Tomita Militaru [Thu, 28 Nov 2013 10:31:25 +0000 (12:31 +0200)]
[TASK] Cleanup GeneralUtility::rmFromList

Simplifies the method. Avoids using array as intermediate. Work directly
with the string value instead.

Resolves: #53677
Releases: 6.2
Change-Id: I1abcd606a2699e959be1816c88cb147dbf557141
Reviewed-on: https://review.typo3.org/25723
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Oliver Klee
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[!!!][BUGFIX] Content Object instances are reused 86/27586/7
Oliver Hader [Wed, 12 Feb 2014 16:38:04 +0000 (17:38 +0100)]
[!!!][BUGFIX] Content Object instances are reused

The ContentObjectRenderer creates instances for each content
object to be rendered, e.g. TEXT, COA, CONTENT, etc. However,
these instances are re-used and therefore we introduced work
arounds since serialization of FLUIDTEMPLATE failed back then.
If dealing with nested record sets using RECORDS or CONTENT,
reusing objects might be tricky since the parent pointer to the
ContentObjectRenderer might be wrong and strange things happen.

This patch removes the pseudo singleton approach since the
objects are not state-less and might lead to unexpected
results in rare cases.

Resolves: #55941
Releases: 6.2
Change-Id: I043a31403c05b87e1591f0e0237effa21bf93c98
Reviewed-on: https://review.typo3.org/27586
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix possible language handling issue 29/23529/11
Markus Klein [Sun, 1 Sep 2013 11:01:49 +0000 (13:01 +0200)]
[BUGFIX] Fix possible language handling issue

The language initialization process is currently split in two main
methods (TypoScriptFrontendController->initLLvars and ->settingLanguage).

Only settingLanguage contains hooks and sets the "sys_language_uid"
property (and "sys_language_content") which determine the displayed
records in Frontend. On the opposite, initLLvars is not hookable and sets
the "lang" property, which may be used by charset conversion methods.

In order to determine display language within hooks, the only way
currently is to call initLLvars a second time after determining language,
but this method populates the "languageDependencies" property without
initializing it. So it is filled two times, which leads to incorrect
labels, especially if the displayed language is English and the
default language is not English (as "languageDependencies" is already
filled with "default language").

The three parts of the patch are:
 * The initLLvars method now pre-initializes the "languageDependencies"
   property.
 * The initLLvars is now called from "settingLanguage" method, right
   after the "settingLanguage_preProcess" hook to avoid a second call it.
 * The convPOSTCharset call is now moved after the language
   initialization, as the language determination done by initLLvars
   can have some impact on charset handling (multi-charset locallang.php
   legacy).

Change-Id: I6924345931342d5114b13e5d6fab417387559b9a
Resolves: #49499
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23529
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Usage of undefined variables in ShortcutToolbarItem 41/27641/3
Tim Lochmueller [Sun, 16 Feb 2014 12:08:04 +0000 (13:08 +0100)]
[BUGFIX] Usage of undefined variables in ShortcutToolbarItem

Fix a undefined variable and a wrong variable assignment in the
ShortcurtToolbarItem.

Resolves: #55998
Releases: 6.2, 6.1, 6.0
Change-Id: I0f0ebcc846a9aa56edd05e384d62aad8f0a5b05b
Reviewed-on: https://review.typo3.org/27641
Reviewed-by: Markus Klein
Reviewed-by: Stefano Kowalke
Tested-by: Markus Klein
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind