Packages/TYPO3.CMS.git
19 months ago[TASK] Update Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst 96/55096/2
Tizian Schmidlin [Fri, 15 Dec 2017 15:50:13 +0000 (16:50 +0100)]
[TASK] Update Breaking-82421-DroppedOldDBRelatedConfigurationOptions.rst

Releases: master
Resolves: #83344
Change-Id: I5653312697a2568b8b0937e96a315ed08068957d
Reviewed-on: https://review.typo3.org/55096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Change behavior of new element during drag & drop into node 61/55061/7
Tymoteusz Motylewski [Wed, 13 Dec 2017 14:32:07 +0000 (15:32 +0100)]
[BUGFIX] Change behavior of new element during drag & drop into node

- place input correctly
- open node with children while holding the mouse over
this node for one second (when drag-adding new node)
- add chevron and expand it when adding first child
- refactor node.open to node.expand because they did the same thing
- show icons for custom doktypes (fix regex)

Releases: master
Resolves: #83306
Change-Id: I0255fa50f836d002392ed7791eed1ac3517cb400
Reviewed-on: https://review.typo3.org/55061
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
19 months ago[TASK] Raise ext:styleguide extension versions 12/55112/4
Oliver Hader [Sat, 16 Dec 2017 12:42:30 +0000 (13:42 +0100)]
[TASK] Raise ext:styleguide extension versions

Raise ext:styleguide extension versions to
* 9.0.1
* 8.0.14

The styleguide extensions uses and invalid configuration for FAL
references using the table sys_file_reference as MM table - the
regular use case is to use that as 1:n foreign_field composite
assiciation. In a result the example in the styleguide extension
mixed the meaning and behavior of both fields uid_local and
uid_foreign.

Resolves: #83355
Releases: master, 8.7
Change-Id: I203b468b4a06e3196a98e2c5de1ba06419a65636
Reviewed-on: https://review.typo3.org/55112
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] AdminPanelView tries to count null value 97/55097/3
Oliver Hader [Fri, 15 Dec 2017 15:58:03 +0000 (16:58 +0100)]
[BUGFIX] AdminPanelView tries to count null value

Resolves: #83345
Releases: master, 8.7, 7.6
Change-Id: I49e0de26154430c8a93c6a25a7fa54d5e49be39d
Reviewed-on: https://review.typo3.org/55097
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Add editor permissions to pagetree 99/55099/2
Susanne Moog [Fri, 15 Dec 2017 17:05:11 +0000 (18:05 +0100)]
[BUGFIX] Add editor permissions to pagetree

The new pagetree repository implementation
did not check editor permissions and disallowed
any edit / show action for non-admins.

The fields to check permissions have been added.

Change-Id: I827d4b50302ee4d6c3268c44b43f93fa9ef0c870
Resolves: #83347
Releases: master
Reviewed-on: https://review.typo3.org/55099
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Use hash_equals for timing-safe comparison of hash-values 74/55074/5
Stefan Neufeind [Thu, 14 Dec 2017 13:51:32 +0000 (14:51 +0100)]
[TASK] Use hash_equals for timing-safe comparison of hash-values

To prevent timing-attacks on hash-comparions it is advised
to use hash_equals.

Resolves: #83329
Releases: master, 8.7
Change-Id: I7539ed27538d7d81767bfce582d568cff09d1610
Reviewed-on: https://review.typo3.org/55074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
19 months ago[TASK] EXT:scheduler: Last old image and cli_dispatch 88/55088/3
Michael Oehlhof [Thu, 14 Dec 2017 23:48:02 +0000 (00:48 +0100)]
[TASK] EXT:scheduler: Last old image and cli_dispatch

Exchanged the old BackendModuleMainView image and correct the examples
for the command line call.

Resolves: #83336
Releases: master
Change-Id: I53844f5bef4a5b52be58dc14d1fc260b7a97d775
Reviewed-on: https://review.typo3.org/55088
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
19 months ago[BUGFIX] Make sure that foreach loops are applied to arrays only 66/55066/6
Wolfgang Klinger [Thu, 14 Dec 2017 10:33:53 +0000 (11:33 +0100)]
[BUGFIX] Make sure that foreach loops are applied to arrays only

Fix some foreach loops so as not to run into potentially empty elements.
Use the ?? operator to accomplish that.

Change-Id: Id6306cea0546dfd4a20ba98c170335966cc2ae40
Resolves: #83322
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55066
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Script to check doc comments for invalid annotations 90/54790/11
Alexander Schnitzler [Mon, 27 Nov 2017 13:16:36 +0000 (14:16 +0100)]
[TASK] Script to check doc comments for invalid annotations

To prevent the introduction of further invalid
php doc annotations a build script should scan
all php files and report the usage of invalid
annotations.

Releases: master
Resolves: #83115
Change-Id: I56cc64ef43037c6c55f5337d07cf722a1927865c
Reviewed-on: https://review.typo3.org/54790
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Replace PHP 7.2 deprecated each() 64/55064/6
Patrick Schriner [Thu, 14 Dec 2017 09:19:51 +0000 (10:19 +0100)]
[BUGFIX] Replace PHP 7.2 deprecated each()

each() is deprecated in PHP 7.2 and has to be replaced.

Resolves: #83321
Releases: master, 8.7, 7.6
Change-Id: Ic318b50a9921cd6a55435cc9b2e0b254e61b9dbc
Reviewed-on: https://review.typo3.org/55064
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[TASK] EXT:Scheduler: Update documentation 77/55077/3
Michael Oehlhof [Thu, 14 Dec 2017 15:22:07 +0000 (16:22 +0100)]
[TASK] EXT:Scheduler: Update documentation

Replaced images with new ones from current master.
Adjust the description text where necessary.
Change presentation of the "class not found" group.

Resolves: #72628
Releases: master
Change-Id: Icf6845c72b34afbf0105aa844e321a18878f16dd
Reviewed-on: https://review.typo3.org/55077
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[TASK] Bamboo: use udiff format for php-cs-fixer diff option 81/55081/4
Nicole Cordes [Thu, 14 Dec 2017 17:21:49 +0000 (18:21 +0100)]
[TASK] Bamboo: use udiff format for php-cs-fixer diff option

The option produces nice compact output instead of printing whole file.

Resolves: #83335
Releases: master, 8.7
Change-Id: I3b5fb0ab004c653751c4bc3e7f8e1079fcc66235
Reviewed-on: https://review.typo3.org/55081
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Optimize structure of ChangeLog documentation 72/55072/4
Martin Bless [Thu, 14 Dec 2017 13:24:02 +0000 (14:24 +0100)]
[TASK] Optimize structure of ChangeLog documentation

Have a slightly different menu setup of the rendered
documentation, especially affects docs.typo3.org

Change-Id: I357c1f59ff7606361b680128d5a3934c981a4f43
Resolves: #83325
Releases: master
Reviewed-on: https://review.typo3.org/55072
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Update friendsofphp/php-cs-fixer to 2.9.0 76/55076/4
Nicole Cordes [Thu, 14 Dec 2017 14:57:59 +0000 (15:57 +0100)]
[TASK] Update friendsofphp/php-cs-fixer to 2.9.0

This also updates needed dependencies.

composer command used:

composer update friendsofphp/php-cs-fixer --with-dependencies

Resolves: #83331
Releases: master, 8.7
Change-Id: I32be2033acacb881c467b23462afa1f852b290fe
Reviewed-on: https://review.typo3.org/55076
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[TASK] Show complete diff for cglFixMyCommit on Bamboo 69/55069/5
Nicole Cordes [Thu, 14 Dec 2017 12:16:59 +0000 (13:16 +0100)]
[TASK] Show complete diff for cglFixMyCommit on Bamboo

Resolves: #83324
Releases: master, 8.7
Change-Id: Idf7b0119c6d25b1336d3fce04e1bd393f4dc945c
Reviewed-on: https://review.typo3.org/55069
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Use correct language file location 73/55073/2
Georg Ringer [Thu, 14 Dec 2017 13:33:04 +0000 (14:33 +0100)]
[BUGFIX] Use correct language file location

With the move of the PageInformationController with change #81865
some labels in the info module needs to be adopted.

Resolves: #83326
Releases: master
Change-Id: I1d171fd35acb555f8f9065e3700a2ed2324d64fd
Reviewed-on: https://review.typo3.org/55073
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[BUGFIX] Changelog docs compile warnings 63/55063/4
Christian Kuhn [Wed, 13 Dec 2017 17:32:00 +0000 (18:32 +0100)]
[BUGFIX] Changelog docs compile warnings

Fix a series of ReST documentation compile warnings, some of them
lead to missing segments in the rendered docs. Most notable changes:

* Always have an empty line after '.. code-block:: <highlight-indicator>'
* Introduce inline text role ":javascript:" and use it consistently over
  ":js:", but give it the same HTML class "js" during rendering. This is
  because highlight code-block existists for "javascript", too, so this
  can now be used both in blocks as well as inline
* Introduce inline text role ":sql:", can now be used inline, too, in
  addition to code-block
* Various minor things like indentings in numerations, some broken
  tables, ...

Change-Id: Id9c16257a76623dc9ee292253450865b95e13dc3
Resolves: #83313
Releases: master
Reviewed-on: https://review.typo3.org/55063
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Allow current dev versions of subtree split packages 62/55062/2
Helmut Hummel [Wed, 13 Dec 2017 12:44:39 +0000 (13:44 +0100)]
[BUGFIX] Allow current dev versions of subtree split packages

To be able to install subtree split packages in dev-master
the package dependencies between them need to allow exactly that.

Releases: master
Resolves: #83309
Change-Id: If2b8ea86958a425a6a047207bc064a41698215a4
Reviewed-on: https://review.typo3.org/55062
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
19 months ago[TASK] Salted Passwords: Add a ComposedSaltInterface 60/55060/2
Benni Mack [Tue, 12 Dec 2017 20:49:57 +0000 (21:49 +0100)]
[TASK] Salted Passwords: Add a ComposedSaltInterface

Add another interface, in order to allow to code
against interface instead of abstractions,
so composed salts that implement their own
password-hashing can implement this interface.

Relates: #79795
Relates: #79889
Resolves: #83294
Releases: master
Change-Id: Ica97f695b5f005e7b835078e89d17f8003141b3f
Reviewed-on: https://review.typo3.org/55060
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[TASK] Set TYPO3 version to 9.1.0-dev 55/55055/7
Benni Mack [Tue, 12 Dec 2017 16:49:44 +0000 (17:49 +0100)]
[TASK] Set TYPO3 version to 9.1.0-dev

Releases: master
Change-Id: Ia7f55a6f40ec6b80939a78b13aa3fafc6c11132a
Reviewed-on: https://review.typo3.org/55055
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Don't list records from tables without searchFields on search 48/55048/4
Stephan Großberndt [Tue, 12 Dec 2017 14:05:56 +0000 (15:05 +0100)]
[BUGFIX] Don't list records from tables without searchFields on search

When searching for a string in the database list do not show any records
from tables without a searchField definition, if the searchString is not
an integer which might be a uid.

Releases: master, 8.7
Resolves: #83301
Change-Id: I259a4d9b2f89c55f9a0ac307b812e950ab549b20
Reviewed-on: https://review.typo3.org/55048
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Hannes Lau <office@hanneslau.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[BUGFIX] Read TER XML entity value complete 36/54936/4
Alexander Opitz [Tue, 5 Dec 2017 12:46:27 +0000 (13:46 +0100)]
[BUGFIX] Read TER XML entity value complete

Improve reading the TER XML file while using the php xml extension.
The character data handler could be called multiple times, so we
shouldn't cut previous data away.

Resolves: #83227
Releases: master, 8.7, 7.6
Change-Id: I9e96ade88da6a4709d1f72cd49fe766758d265fe
Reviewed-on: https://review.typo3.org/54936
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
19 months ago[TASK] Add missing Documentation/9.0/Index.rst 56/55056/2
Christian Kuhn [Tue, 12 Dec 2017 18:31:28 +0000 (19:31 +0100)]
[TASK] Add missing Documentation/9.0/Index.rst

Due to the missing index file, the 9.0 doc files
are not yet rendered on docs.typo3.org

Change-Id: I65781b9de84dd4a0f1205ded175858a90dc01f85
Resolves: #83304
Releases: master
Reviewed-on: https://review.typo3.org/55056
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[RELEASE] Release of TYPO3 9.0.0 54/55054/2 v9.0.0
Benni Mack [Tue, 12 Dec 2017 16:48:17 +0000 (17:48 +0100)]
[RELEASE] Release of TYPO3 9.0.0

Change-Id: Iafe266ef8904526c9822576bfbab135d27b6ce27
Reviewed-on: https://review.typo3.org/55054
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Filelist folders not expandable 53/55053/2
Christian Kuhn [Tue, 12 Dec 2017 16:33:09 +0000 (17:33 +0100)]
[BUGFIX] Filelist folders not expandable

A wrong type given to JsonResponse->setPayload()
fatals the return type on expanding the filelist
folder tree.

Change-Id: I7510ba7d5098b8b91c5016472487f73c6ca77e2c
Resolves: #83303
Releases: master
Reviewed-on: https://review.typo3.org/55053
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
19 months ago[!!!][TASK] Upgrade to composer installers 2.0.0 49/55049/10
Helmut Hummel [Tue, 12 Dec 2017 14:16:57 +0000 (15:16 +0100)]
[!!!][TASK] Upgrade to composer installers 2.0.0

With this step, the typo3/cms package will not be
installable anymore with composer, but only the
single subtree splitted packages like typo3/cms-core.

To ease the usage, a new package typo3/minimal is
introduced, which has dependencies to all required
TYPO3 extensions, so that composer users can't install
an incomplete code base, at least not when using this package.

composer command used:

composer require typo3/cms-composer-installers ^2.0

Releases: master
Resolves: #83302
Change-Id: Ia1009f62d97be611a03cec5dd437b56cd7866eeb
Reviewed-on: https://review.typo3.org/55049
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Register page tree navigation component after it is initialized 43/55043/7
Tymoteusz Motylewski [Tue, 12 Dec 2017 12:13:05 +0000 (13:13 +0100)]
[BUGFIX] Register page tree navigation component after it is initialized

Now Viewport.NavigationContainer.setComponentInstance(tree);
is called after the tree is initialized.
A check to prevent multiple initialization calls is added.

Also position of the title edit imput is corrected
in case where there are multiple mount points.

Releases: master
Resolves: #83299
Change-Id: I5b9cc14b362ab20ecb7631babe3f3f83eb8bfb48
Reviewed-on: https://review.typo3.org/55043
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
19 months ago[!!!][TASK] Implement Salted Passwords against SaltInterface 37/52737/15
Christian Futterlieb [Mon, 11 Dec 2017 07:55:32 +0000 (08:55 +0100)]
[!!!][TASK] Implement Salted Passwords against SaltInterface

Salt classes must implement SaltInterface only. The AbstractSalt
class is renamed to AbstractComposedSalt and implements
SaltInterface. Methods for salt-classes that compose the
password-hash string themselves (which are currently all in
saltedpasswords) are moved to AbstractComposedSalt as well.

This cleanup change prepares for the integration of the
PHP password API in a following change.

Relates: #79795
Relates: #79889
Resolves: #83294
Releases: master
Change-Id: Ife24aa39be99c5ad391b0f10497a2bceb04084f3
Reviewed-on: https://review.typo3.org/52737
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Make daterange filtering in EXT:belog work again 37/55037/7
Susanne Moog [Tue, 12 Dec 2017 07:30:52 +0000 (08:30 +0100)]
[BUGFIX] Make daterange filtering in EXT:belog work again

Use ISO dates and date time objects consistently.

Change-Id: I1095f6690a3b73217657cc2577ebdaf6d7ff5fc0
Releases: master, 8.7
Resolves: #82126
Reviewed-on: https://review.typo3.org/55037
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Make ImageService independent from object manager 41/55041/7
Frans Saris [Tue, 12 Dec 2017 10:45:19 +0000 (11:45 +0100)]
[BUGFIX] Make ImageService independent from object manager

Resolves: #83295
Related: #82414
Releases: master
Change-Id: I048e8a406b04227e28021b4ad0082c6a6b174708
Reviewed-on: https://review.typo3.org/55041
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Fix branch alias to the current minor version 66/49966/7
Patrik Karisch [Sun, 18 Sep 2016 15:42:38 +0000 (17:42 +0200)]
[BUGFIX] Fix branch alias to the current minor version

It's better to fix the current minor release in the branch version too,
so depending projects can use the dev version of this specific minor
release and will not have any headaches when 9.0 gets released.

Resolves: #77984
Releases: master
Change-Id: I36def811213dd99a3bf938af0459026d6233f645
Reviewed-on: https://review.typo3.org/49966
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Make recycler PHP 7.2 compatible 42/55042/6
Susanne Moog [Tue, 12 Dec 2017 10:59:46 +0000 (11:59 +0100)]
[BUGFIX] Make recycler PHP 7.2 compatible

Change-Id: I36167b0a8b61532adbafea93c88c93097ea52d73
Resolves: #83297
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55042
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[TASK] Raise PHP requirement to 7.2.0 35/55035/10
Christian Kuhn [Mon, 11 Dec 2017 20:25:42 +0000 (21:25 +0100)]
[TASK] Raise PHP requirement to 7.2.0

As decided by core team leader, PHP minimum version
requirement for core version 9.0 is 7.2.0.

The patch sets this in root composer.json, together
with config.platform.php, and adapts sysext/core/composer.json.

Resolves: #83290
Related: #83289
Releases: master
Change-Id: I813d0a2b69005c84ba5dedb45b3d4bd0388e43d8
Reviewed-on: https://review.typo3.org/55035
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Install tool fails if LocalConfiguration EXT/extConf does not exist 44/55044/4
Christian Kuhn [Tue, 12 Dec 2017 11:45:04 +0000 (12:45 +0100)]
[TASK] Install tool fails if LocalConfiguration EXT/extConf does not exist

On fresh instances, the install tool may fail if path EXT/extConf
which is written as b/w compat layer does not exist, yet.
Patch catches the (generic) exception from ArrayUtility->getValueByPath()
and initializes the value to an empty array to continue in this case.

Resolves: #83298
Related: #82368
Releases: master
Change-Id: Iffac458a9e42183139ab4425082abb6f78944ffd
Reviewed-on: https://review.typo3.org/55044
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Repopulate localconfig before cache reload in ext mgr 45/55045/4
Susanne Moog [Tue, 12 Dec 2017 12:09:30 +0000 (13:09 +0100)]
[BUGFIX] Repopulate localconfig before cache reload in ext mgr

Reloading caches requires the ext_localconf files. If in an
ext_localconf the extension configuration is accessed this
will fail directly after installation as the configuration is
not reloaded yet.

The patch changes the order to first write the new configuration,
then read the new configuration into the global array and
finally reloading the caches.

Change-Id: I9e2cd70078b2038aa30f2b4706aec46243ab2a9d
Resolves: #83300
Related: #82368
Releases: master
Reviewed-on: https://review.typo3.org/55045
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] recycler ignored recursive flag 27/55027/2
Benjamin Kluge [Mon, 11 Dec 2017 11:16:37 +0000 (12:16 +0100)]
[BUGFIX] recycler ignored recursive flag

The recycler checkbox "Recover content and subpages recursively" has no functionality.

Resolves: #81214
Releases: master
Change-Id: I45129dd0ff91fc339f520e8e5d9a65ece4a701a8
Reviewed-on: https://review.typo3.org/55027
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Do not reprocess image preview when empty configuration is passed 04/54804/3
Tymoteusz Motylewski [Mon, 27 Nov 2017 21:09:52 +0000 (22:09 +0100)]
[BUGFIX] Do not reprocess image preview when empty configuration is passed

Fixes regression introduced in https://review.typo3.org/53399
Where thumbnail was regenerated every time process was called with
empty configuration like:

$fileObject->process(ProcessedFile::CONTEXT_IMAGEPREVIEW, [])

Resolves: #83242
Relates: #81776
Releases: master, 8.7, 7.6
Change-Id: I6a4c331bad4d80225d3914f1a48f6071b0d87380
Reviewed-on: https://review.typo3.org/54804
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
19 months ago[BUGFIX] EXT:form - resolve numeric values in finishers 94/54994/4
Mathias Brodala [Fri, 8 Dec 2017 15:45:23 +0000 (16:45 +0100)]
[BUGFIX] EXT:form - resolve numeric values in finishers

This fixes option parsing for finishers to return any kind of
numeric values within the form runtime or finisher variable provider.

Resolves: #82833
Releases: master, 8.7
Change-Id: I334fbd36e526823f07e57247bd63d412a3c3b0d6
Reviewed-on: https://review.typo3.org/54994
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Eugene Kenah Djomo <kdeugene@yahoo.fr>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[DOCS] Documentation for 9.0 16/55016/8
Susanne Moog [Sun, 10 Dec 2017 19:32:37 +0000 (20:32 +0100)]
[DOCS] Documentation for 9.0

Change-Id: I2ac571a8f7706a5195ffdddcacef437cc30393ba
Resolves: #83292
Releases: master
Reviewed-on: https://review.typo3.org/55016
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[FOLLOWUP][FEATURE] EXT:Scheduler: Add sorting to the list of scheduler tasks 29/55029/4
Stefan Neufeind [Mon, 11 Dec 2017 14:12:47 +0000 (15:12 +0100)]
[FOLLOWUP][FEATURE] EXT:Scheduler: Add sorting to the list of scheduler tasks

Properly set variable SplitButtons again.
Show missing classes in an extra table.

Resolves: #45535
Releases: master
Change-Id: I4ac967ba640f6663ef4d4262e11c2cb428cb0ee5
Reviewed-on: https://review.typo3.org/55029
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[FOLLOWUP][BUGFIX] EXT:form - handle boolean finisher options 26/55026/4
Mathias Brodala [Mon, 11 Dec 2017 11:16:27 +0000 (12:16 +0100)]
[FOLLOWUP][BUGFIX] EXT:form - handle boolean finisher options

Fix preview rendering.

Change-Id: I0c11304175a0734b2c3690c1e460490e3733bba5
Resolves: #82569
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55026
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Deprecation: <link> syntax parsing in RteHtmlParser 57/54457/9
Benni Mack [Fri, 20 Oct 2017 11:59:40 +0000 (13:59 +0200)]
[TASK] Deprecation: <link> syntax parsing in RteHtmlParser

Functionality regarding parsing / resolving <link> tags is marked
as deprecated as it does not need to be called anymore.

Additionally, adding and calling the hooks
$TYPO3_CONF_VARS['SC_OPTIONS']['t3lib/class.t3lib_parsehtml_proc.php']['modifyParams_LinksRte_PostProc']
$TYPO3_CONF_VARS['SC_OPTIONS']['t3lib/class.t3lib_parsehtml_proc.php']['modifyParams_LinksDb_PostProc']
will trigger deprecation errors.

Resolves: #83252
Releases: master
Change-Id: Id7998849f7039a0bd786321787ce87884b254b67
Reviewed-on: https://review.typo3.org/54457
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
19 months ago[BUGFIX] Change data-uid to data-state-id 33/55033/2
Paweł Rogowicz [Mon, 11 Dec 2017 14:59:17 +0000 (15:59 +0100)]
[BUGFIX] Change data-uid to data-state-id

Change data-uid to data-state-id because there isn't uid just state identifier

Releases: master
Resolves: #83280
Change-Id: Ia0a57c061c4cff7ce6969a5a9ccc4398b81ba202
Reviewed-on: https://review.typo3.org/55033
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[TASK] Streamline composer dependencies for system extensions 00/55000/3
Benni Mack [Sat, 9 Dec 2017 17:10:03 +0000 (18:10 +0100)]
[TASK] Streamline composer dependencies for system extensions

All system extensions should have a dependency on
"typo3/cms-core" with a fixed version set to "9.0.0".

Additionally, EXT:core ("typo3/cms-core") needs to have all
dependencies of the root composer.json in order
to work as standalone composer package.

Releases: master
Resolves: #83270
Change-Id: Iaf0e925b46548914dcd0ffff49aedf5fc89107b6
Reviewed-on: https://review.typo3.org/55000
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] EXT:form - Tests for PropertyMappingConfiguration 21/55021/5
Marcel Jürgen Falk [Mon, 11 Dec 2017 08:04:28 +0000 (09:04 +0100)]
[TASK] EXT:form - Tests for PropertyMappingConfiguration

Resolves: #83279
Releases: master, 8.7
Change-Id: I40f6ab483289cbf45f132453b0a1e0af4b72b5b5
Reviewed-on: https://review.typo3.org/55021
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
19 months ago[BUGFIX] Use stateIdentifier instead of Uid for SVG tree nodes 20/55020/7
Paweł Rogowicz [Mon, 11 Dec 2017 11:07:23 +0000 (12:07 +0100)]
[BUGFIX] Use stateIdentifier instead of Uid for SVG tree nodes

Change Uid to stateIdentifier because one Uid can occur in the pagetree
many times, for example in DB mounts.
We need to know what node is visible or what node was clicked or what
node was mouse over / mouse leave, e.t.c.

This change also fixes:
- fix MP title position and visibility
- fix changing node name when the same node is multiple in page tree
(pagetree, mount points)
- modified the acceptance tests

Releases: master
Resolves: #83280
Change-Id: I57716db1f2850f0c4b1432651ed391ece5921fec
Reviewed-on: https://review.typo3.org/55020
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
19 months ago[TASK] EXT:form - improve width of form editor stage 22/54022/8
Andreas Steiger [Fri, 8 Sep 2017 14:45:07 +0000 (16:45 +0200)]
[TASK] EXT:form - improve width of form editor stage

Improve and expand the width of the form editor stage for different
modes.

Resolves: #82324
Releases: master, 8.7
Change-Id: Ib98e21ed498a76a32b285d29dc186f09c097742a
Reviewed-on: https://review.typo3.org/54022
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[!!!][TASK] Remove column sys_file_reference.sorting 58/54858/8
Stephan Großberndt [Wed, 29 Nov 2017 11:38:29 +0000 (12:38 +0100)]
[!!!][TASK] Remove column sys_file_reference.sorting

The column `sorting` has been removed from table `sys_file_reference` as
it was not used in TYPO3 core and lead to severe performance issues on
instances with many records in the table.

Releases: master
Resolves: #83160
Related: #80800
Change-Id: Ibff4e11f2ab3954a71cf0ef86e4a75ec4f39eb8c
Reviewed-on: https://review.typo3.org/54858
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[!!!][TASK] Remove EXT:backend/Resources/Private/Templates/Close.html 23/55023/2
Stephan Großberndt [Mon, 11 Dec 2017 09:47:16 +0000 (10:47 +0100)]
[!!!][TASK] Remove EXT:backend/Resources/Private/Templates/Close.html

Remove unused file EXT:backend/Resources/Private/Templates/Close.html

In #68108 the file Close.html was erroneously moved to
EXT:backend/Resources/Private/Templates/ which is a path that is not
directly accessible for web users, but the file must be. In #83258 this
was fixed by copying the file to EXT:backend/Resources/Public/Html/ to
make this a non-breaking change back-portable down to 7.6.

Releases: master
Resolves: #83284
Related: #83258
Related: #68108
Change-Id: I4ece2b4d6069e0a573ecfa092c73b80d2c07a42f
Reviewed-on: https://review.typo3.org/55023
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Adjust size of new content element wizard 22/55022/2
Benjamin Kott [Mon, 11 Dec 2017 08:43:19 +0000 (09:43 +0100)]
[TASK] Adjust size of new content element wizard

Resolves: #83282
Releases: master
Change-Id: I50f06dc620038f3522e95de668cb4f2e0e829e00
Reviewed-on: https://review.typo3.org/55022
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[FEATURE] EXT:Scheduler: Add sorting to the list of scheduler tasks 72/50972/7
Michael Oehlhof [Thu, 15 Dec 2016 11:47:10 +0000 (12:47 +0100)]
[FEATURE] EXT:Scheduler: Add sorting to the list of scheduler tasks

Extract the HTML markup from "listTaskAction" into Fluid

Resolves: #45535
Releases: master
Change-Id: Ibe8f3407a0260da50980fdabadacef9bd52ed13b
Reviewed-on: https://review.typo3.org/50972
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Show correct page title in new page tree 17/55017/2
Michael Oehlhof [Sun, 10 Dec 2017 21:17:34 +0000 (22:17 +0100)]
[BUGFIX] Show correct page title in new page tree

The page title was shown htmlescaped in the new page tree.

Resolves: #83277
Releases: master
Change-Id: I34a06e06d35d435d13d00d3d0a715a25deec384c
Reviewed-on: https://review.typo3.org/55017
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[!!!][BUGFIX] Fluid Widget Links: Do not use cHash by default 67/54967/3
Benni Mack [Wed, 6 Dec 2017 19:11:39 +0000 (20:11 +0100)]
[!!!][BUGFIX] Fluid Widget Links: Do not use cHash by default

When using the widget.link viewhelper, it is not possible to create links
without cHash.

In order to achieve this, cHash is only appended, if "useCacheHash" is
activated (addQueryString is always added, which makes sense due to the
parameters for the link).

As this is a breaking bugfix, it can only go in master.

Resolves: #83244
Resolves: #61960
Releases: master
Change-Id: I1c2dcf159a107188fd744f32de60809d15831162
Reviewed-on: https://review.typo3.org/54967
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Use correct path variable on Windows 40/54940/2
Nicole Cordes [Wed, 6 Dec 2017 00:19:02 +0000 (01:19 +0100)]
[BUGFIX] Use correct path variable on Windows

There is a difference between Apache and CLI exposing global path
configuration on Windows Systems. The CommandUtility uses the global
path to initialize an internal path storage for possible command
resources. The patch ensures both possible keys on Windows systems are
taken into account to resolve possible application locations.

Resolves: #83234
Releases: master, 8.7, 7.6
Change-Id: Id7166042e39c4f468c10c1c489c7fe5beae7a5fc
Reviewed-on: https://review.typo3.org/54940
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
19 months ago[BUGFIX] Remove obsolete AJAX routes in EXT:backend 15/55015/3
Andreas Fernandez [Sun, 10 Dec 2017 18:36:24 +0000 (19:36 +0100)]
[BUGFIX] Remove obsolete AJAX routes in EXT:backend

This patch removes obsoletes routes that were left from the ExtJS
removal.

Resolves: #83276
Related: #82426
Releases: master
Change-Id: I603022fee7bb8add882a058f1f000b47705a8df2
Reviewed-on: https://review.typo3.org/55015
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
19 months ago[BUGFIX] Fix card title of settings module 10/55010/2
Susanne Moog [Sat, 9 Dec 2017 23:18:59 +0000 (00:18 +0100)]
[BUGFIX] Fix card title of settings module

Change-Id: I80b7e93e699613f6d04bb44d987406e325fe2dda
Resolves: #83275
Releases: master
Reviewed-on: https://review.typo3.org/55010
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
19 months ago[TASK][FOLLOWUP] Remove leftover ExtJS-related pagetree classes 04/55004/5
Benni Mack [Sat, 9 Dec 2017 19:48:28 +0000 (20:48 +0100)]
[TASK][FOLLOWUP] Remove leftover ExtJS-related pagetree classes

Some classes regarding ExtJS data providing the tree
can now safely be removed, as they are not in use anymore.

Resolves: #82426
Releases: master
Change-Id: Ic35743154cb8e35b0ddc5a32cd0ec60e68832e0f
Reviewed-on: https://review.typo3.org/55004
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Move Page Title generation to TSFE 73/54973/9
Benni Mack [Thu, 7 Dec 2017 20:06:25 +0000 (21:06 +0100)]
[TASK] Move Page Title generation to TSFE

The static method "PageGenerator::generatePageTitle()" only
operated on TSFE and is moved within the main controller,
which can be retriggered multiple times as before.

The same goes for TemplateService->printTitle().

Additionally, the method isAllowedLinkVarValue() is moved to TSFE
as well.

Resolves: #83254
Releases: master
Change-Id: If519963e33a57c21ac5cc575e4395444ab50450d
Reviewed-on: https://review.typo3.org/54973
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Move option formatToPageTypeMapping 26/43926/7
Christian Futterlieb [Fri, 9 Oct 2015 08:50:54 +0000 (10:50 +0200)]
[BUGFIX] Move option formatToPageTypeMapping

Move the option formatToPageTypeMapping from
plugin.tx_myextension.settings.view.formatToPageTypeMapping to
plugin.tx_myextension.view.formatToPageTypeMapping

and deprecate the usage of the wrong location.

Resolves: #70526
Releases: master
Change-Id: I660aa41097e6cdba5e8fb90591a67a0b83ee90f2
Reviewed-on: https://review.typo3.org/43926
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Linkhandler - access to data outside editors pagetree 52/54852/2
Anke Altintop [Wed, 29 Nov 2017 11:02:17 +0000 (12:02 +0100)]
[BUGFIX] Linkhandler - access to data outside editors pagetree

Respect options.pageTree.altElementBrowserMountPoints in RecordLinkHandler

Resolves: #82250
Releases: master, 8.7
Change-Id: Ic46544c35076439b38b80656c5702ff7c9d0f87b
Reviewed-on: https://review.typo3.org/54852
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] ResourceViewHelper should always return absolute paths 03/55003/4
Benni Mack [Sat, 9 Dec 2017 19:04:45 +0000 (20:04 +0100)]
[TASK] ResourceViewHelper should always return absolute paths

The ResourceViewHelper had a special handling for returning relative
paths, but should always use getAbsoluteWebPath().

The option "absolute" is there to generate a full URL, so this is no issue at all.

Resolves: #83272
Releases: master
Change-Id: I3705712bf8cc38cc45914e83715b18c268c42bd8
Reviewed-on: https://review.typo3.org/55003
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Allow to create admins as system maintainers in Install Tool 98/54898/7
Jonathan IROULIN [Fri, 1 Dec 2017 15:35:35 +0000 (16:35 +0100)]
[TASK] Allow to create admins as system maintainers in Install Tool

This patch add a checkbox to add the new administrator as system
maintainer.

Resolves: #83178
Releases: master
Change-Id: I814ed693ef8e57f2ae58e417727684a701b1fcfd
Reviewed-on: https://review.typo3.org/54898
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] The CE File Links (fluid_styled_content) create thumbs for non-image files 56/54856/3
Jonathan IROULIN [Wed, 29 Nov 2017 11:21:25 +0000 (12:21 +0100)]
[BUGFIX] The CE File Links (fluid_styled_content) create thumbs for non-image files

This patch resolves problems with usage of {file.type} to determine
if the file type is "unknown" ({file.type =} = 0)
or "text" type ({file.type =} = 1)

Resolves: #79711
Releases: master
Change-Id: I05615b7f10bc5125705e952147696d4e402dd900
Reviewed-on: https://review.typo3.org/54856
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Show information if access is not allowed in element information 11/54811/2
Georg Ringer [Tue, 28 Nov 2017 06:49:52 +0000 (07:49 +0100)]
[BUGFIX] Show information if access is not allowed in element information

If the access to the element information is not allowed, show some
information to the user instead of returning an empty string.

Resolves: #83067
Releases: master, 8.7
Change-Id: Ie4ca3ba41556813a44802fc60befe164a17c4178
Reviewed-on: https://review.typo3.org/54811
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Fix offset and limit in list module 99/54999/3
Susanne Moog [Sat, 9 Dec 2017 15:01:06 +0000 (16:01 +0100)]
[BUGFIX] Fix offset and limit in list module

Offset and limit in a count query do not make sense.

Additionally the hook deprecation was incomplete
as the core also threw deprecation warnings on
list module pagination.

Change-Id: I8435d15c981f47e2940dbbf470e2de84fc3d5055
Resolves: #83269
Releases: master
Reviewed-on: https://review.typo3.org/54999
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Consider property clean if lazy loaded proxy is untouched 65/53665/18
Matthias Vogel [Tue, 8 Aug 2017 17:20:38 +0000 (19:20 +0200)]
[BUGFIX] Consider property clean if lazy loaded proxy is untouched

Objects containing a LazyLoadingProxy will be marked dirty even if the
lazy proxy is untouched.

For more details see IsDirtyTest.

Resolves: #82065
Releases: master, 8.7
Change-Id: I579a275bb7d22af836be2497064ed09ea0203df6
Reviewed-on: https://review.typo3.org/53665
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[FEATURE] Add uri/link to backend route ViewHelper 06/47306/16
Ruud Silvrants [Fri, 2 Sep 2016 19:35:45 +0000 (21:35 +0200)]
[FEATURE] Add uri/link to backend route ViewHelper

Since unified URL routing is in place for TYPO3 v9 now,
a new pair of linking to routes is added.

Change-Id: Ied1a67aee173a9a1dc00eaadc9676ded1276076f
Resolves: #75161
Releases: master
Reviewed-on: https://review.typo3.org/47306
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[FEATURE] Add a hook to hide credentials in the Configuration module 44/54644/14
Christian Wolff [Wed, 15 Nov 2017 09:45:25 +0000 (10:45 +0100)]
[FEATURE] Add a hook to hide credentials in the Configuration module

This allows extensions to hide their own credentials in the
Configuration module.

Resolves: #82999
Releases: master
Change-Id: Idb25ab98c7986fb6f7471948b684834b608a0f0d
Reviewed-on: https://review.typo3.org/54644
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Move public TemplateService properties to protected 01/52901/31
Elmar Hinz [Mon, 22 May 2017 13:55:22 +0000 (15:55 +0200)]
[TASK] Move public TemplateService properties to protected

The properties are meant to be used only inside the class (and the
extended classes) itself.

Resolves: #83273
Releases: master
Change-Id: I550012bc377c6bb577747490fac3100d378a6fd6
Reviewed-on: https://review.typo3.org/52901
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[FEATURE] Display (un)substituted TS constant 90/50190/8
Philipp Kitzberger [Tue, 11 Oct 2016 21:09:29 +0000 (21:09 +0000)]
[FEATURE] Display (un)substituted TS constant

Display value of TS constants on "UN-substituted constants in green"
mode and constant name when on "Substituted constant in green" mode.

Before this patch toggling between both modes was necessary to simply
get an idea of what the value/variable name was while being on the
'other' mode.

As a side effect this patch improves the search feature of the object
browser when searching for a constant value or name, i.e. 'maxWInText'
while being on "Substituted" mode.

Resolves: #40729
Releases: master
Change-Id: Ic8c3f1b96b3b440a3ed4d098604e29d018129451
Reviewed-on: https://review.typo3.org/50190
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[FOLLOWUP][BUGFIX] Make category tree filterable for editors 75/54975/2
Christoph Lehmann [Thu, 7 Dec 2017 21:53:35 +0000 (22:53 +0100)]
[FOLLOWUP][BUGFIX] Make category tree filterable for editors

Check if TCEFORM.pages.categories.config.treeConfig.rootUid
itself is in the users category mounts (no need for a pseudo
parent category)

Resolves: #83257
Releases: master,8.7,7.6
Change-Id: I8a60860ee3a22d68964f4e44018f0962f7f0f278
Reviewed-on: https://review.typo3.org/54975
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Program to cache frontend interface, not implementations 16/53116/13
Claus Due [Sun, 4 Jun 2017 13:25:36 +0000 (15:25 +0200)]
[TASK] Program to cache frontend interface, not implementations

Instead of annotating and type-hinting specific cache
frontend implementations, TYPO3 should program to
the FrontendInterface instead. This patch corrects that.

Change-Id: Ibc8d31cf78459e700ab9fe3448a53cbe83bccc61
Resolves: #81461
References: #81432
Releases: master
Reviewed-on: https://review.typo3.org/53116
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[FOLLOWUP][BUGFIX] Use Fluid standalone abstract classes 02/55002/2
Georg Ringer [Sat, 9 Dec 2017 18:23:05 +0000 (19:23 +0100)]
[FOLLOWUP][BUGFIX] Use Fluid standalone abstract classes

Resolves: #82414
Releases: master
Change-Id: I5152b9929d8755adfb8d2d77c03178178c8a8742
Reviewed-on: https://review.typo3.org/55002
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] UX: Streamline Page Translation selector in Page Module 01/55001/2
Benni Mack [Sat, 9 Dec 2017 17:38:32 +0000 (18:38 +0100)]
[TASK] UX: Streamline Page Translation selector in Page Module

The page translation selector in the page module has the label outside
of the dropdown, where as the List module has the label as the first option.

This patch puts the label inside the first option of the dropdown selector
in the page module.

This way, the selector box is aligned to the left, and thus, does not look
like it's placed "somewhere" in the HTML code.

Resolves: #83271
Releases: master
Change-Id: Idbedf2f6cfb9056e0c89a69029f31b4b47673a02
Reviewed-on: https://review.typo3.org/55001
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Speed up page tree loading 87/54887/31
Tymoteusz Motylewski [Fri, 8 Dec 2017 15:05:17 +0000 (16:05 +0100)]
[TASK] Speed up page tree loading

Instead of doing manual queries for each tree level, and checking
for children on each tree level, the page tree now fetches all pages
the user has access to, and checks if this works out.

Resolves: #83233
Releases: master
Change-Id: I45a6b834ef1fe71e5748dfc8de9bcf6dad8172c9
Reviewed-on: https://review.typo3.org/54887
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[TASK] Introduce ExcelMicro as CGL for TypeScript 58/54958/4
Frank Naegler [Thu, 7 Dec 2017 10:18:51 +0000 (11:18 +0100)]
[TASK] Introduce ExcelMicro as CGL for TypeScript

Resolves: #83248
Releases: master
Change-Id: I1a61178131b358e4cc309bd11fc77278d9220a55
Reviewed-on: https://review.typo3.org/54958
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Support longer database passwords 37/54137/6
Tobias Hüske [Sat, 9 Dec 2017 05:39:06 +0000 (06:39 +0100)]
[TASK] Support longer database passwords

Sometimes the database user has a password that
is larger than 50 characters. At the moment TYPO3
throws an error message when entering this password.

Microsoft SQL Server passwords can contain
up to 128 characters, MySQL & PostgreSQL have no limitations.

For this reason, the maximum password
length has been increased to 128 characters.

Resolves: #82479
Releases: master, 8.7
Change-Id: I4ff5ef85ec74f1ff87bfe5d3f6658196b67f8330
Reviewed-on: https://review.typo3.org/54137
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[TASK] Remove leftover @transient annotations 84/54984/5
Stefan Neufeind [Fri, 8 Dec 2017 11:25:16 +0000 (12:25 +0100)]
[TASK] Remove leftover @transient annotations

@transient was deprecated with #54760.
But those usages don't make sense in TYPO3 Core here
and might be leftovers from Flow.

Related: #83092
Resolves: #83259
Releases: master
Change-Id: I51427ac48176fbfa2e3e2dbf09090fc872bf95a2
Reviewed-on: https://review.typo3.org/54984
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[!!!][TASK] Drop support for &id=23.1 (id.type) syntax 80/54980/3
Benni Mack [Fri, 8 Dec 2017 07:10:02 +0000 (08:10 +0100)]
[!!!][TASK] Drop support for &id=23.1 (id.type) syntax

TYPO3 previously allowed to hand over the typeNum parameter
via index.php?id=pageId.typeNum which is dropped now, as
"index.php?id=pageId&type=typeNum" should be used, no more hidden magic.

Resolves: #83265
Releases: master
Change-Id: I218812b462d3ccb3ee0c35f0c8507957f0002ac8
Reviewed-on: https://review.typo3.org/54980
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Allow Symfony 4 as constraint for composer 93/54893/4
Benni Mack [Thu, 7 Dec 2017 08:05:52 +0000 (09:05 +0100)]
[TASK] Allow Symfony 4 as constraint for composer

Symfony4 was released today, and using Symfony 4 components
should not be restricted.

The current used Symfony components (YAML, Finder, Console)
mainly concentrated on cleanup for the code.

For the bundled zip/tar.gz archives, nothing changes.

Resolves: #83180
Releases: master, 8.7
Change-Id: Ic518f3b7d3a94bd3b89587d4c8a07ed37c71cb38
Reviewed-on: https://review.typo3.org/54893
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] EXT:form - respect class for file upload field 91/54991/2
Mathias Brodala [Fri, 8 Dec 2017 13:28:15 +0000 (14:28 +0100)]
[BUGFIX] EXT:form - respect class for file upload field

Resolves: #83260
Releases: master, 8.7
Change-Id: I04c0bfa08ceb19ed0f797107ac307b06a77b4dcb
Reviewed-on: https://review.typo3.org/54991
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Use JsonResponse for all Backend AJAX calls 95/54995/3
Benni Mack [Fri, 8 Dec 2017 23:10:36 +0000 (00:10 +0100)]
[TASK] Use JsonResponse for all Backend AJAX calls

The new JsonResponse object should be used throughout the
TYPO3 Backend in order to properly call json_encode() with
the right flags automatically, making the code inside
the controllers simpler.

Resolves: #83267
Releases: master
Change-Id: Ie03fb1414a965a61632897f0e25645a67f3225a5
Reviewed-on: https://review.typo3.org/54995
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[!!!][TASK] Remove config.lockFilePath functionality 74/54974/5
Benni Mack [Thu, 7 Dec 2017 20:44:05 +0000 (21:44 +0100)]
[!!!][TASK] Remove config.lockFilePath functionality

When using the stdWrap.filelist functionality, the lockFilePath
only allowed to be used for a certain directory (usually, if not set, it
was set to fileadmin/), however, this is both very unsecure and inflexible.

Thus, stdWrap.filelist is extended to be used with all local FAL storages.

Add the same time, the public property TSFE->lockFilePath and the TypoScript
option "config.lockFilePath" is removed.

Resolves: #83256
Releases: master
Change-Id: Ia86c6686128dae4c0870cd15e019f4d53a4b28b6
Reviewed-on: https://review.typo3.org/54974
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Access Close.html from Resources/Public/Html/ 83/54983/2
Stephan Großberndt [Fri, 8 Dec 2017 11:16:16 +0000 (12:16 +0100)]
[BUGFIX] Access Close.html from Resources/Public/Html/

Clicking the close button in a editing popup accesses Close.html in
Resources/Public/Html/ which is a folder accessible by a web user
instead of Resources/Private/Templates/ which lead to a HTTP 403 error
on closing the popup.

Releases: master, 8.7, 7.6
Resolves: #83258
Related: #68108
Change-Id: Ibe7e328936240df436a3c9585e53122f1577dc6e
Reviewed-on: https://review.typo3.org/54983
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[FOLLOWUP][FEATURE] EXT:form - support translation arguments 89/54989/2
Mathias Brodala [Fri, 8 Dec 2017 12:21:28 +0000 (13:21 +0100)]
[FOLLOWUP][FEATURE] EXT:form - support translation arguments

Add missing YAML for TypoLink example.

Resolves: #81363
Releases: master
Change-Id: I1efc0ab812f96883a938326fb229f1536b7345e0
Reviewed-on: https://review.typo3.org/54989
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Clarify the affected classes and methods in rst file 63/54963/3
Anja Leichsenring [Thu, 7 Dec 2017 12:54:32 +0000 (13:54 +0100)]
[BUGFIX] Clarify the affected classes and methods in rst file

The documentation file states now clearly which parts of public
API have been removed / marked as deprecated.

Resolves: #79972
Releases: master, 8.7
Change-Id: I48420de5a96681d218f98268223b5cb6a198fda9
Reviewed-on: https://review.typo3.org/54963
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Add affected class name to method deprecation 57/54957/2
Anja Leichsenring [Thu, 7 Dec 2017 09:29:19 +0000 (10:29 +0100)]
[BUGFIX] Add affected class name to method deprecation

The documentation file misses the class name of the method
that has been deprecated.

Resolves: #78872
Releases: master, 8.7
Change-Id: I3e6b2fd576f4d4ac85ea096ae3406e6df972a97b
Reviewed-on: https://review.typo3.org/54957
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Mention correct class and function in rst file 47/54947/2
Anja Leichsenring [Wed, 6 Dec 2017 16:41:17 +0000 (17:41 +0100)]
[BUGFIX] Mention correct class and function in rst file

Due to a copy-paste error, the description of the documentation
file does not reflect the other parts.

Resolves: #76259
Releases: master, 8.7
Change-Id: Iea069cae225523d3d35eb6b41b4ab618f2c25e76
Reviewed-on: https://review.typo3.org/54947
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Fix invalid type hints in EXT:form's file upload converter 84/54784/6
Oliver Hader [Mon, 27 Nov 2017 11:11:48 +0000 (12:11 +0100)]
[BUGFIX] Fix invalid type hints in EXT:form's file upload converter

Due to invalid PHP type hints updating a previously uploaded file
reference in a mail form fails in the frontend.

Resolves: #83112
Releases: master, 8.7
Change-Id: Ibf98267a60f076b5654fb0d0d9181a4caeed49b3
Reviewed-on: https://review.typo3.org/54784
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Improve SVG page tree 33/54933/13
Tymoteusz Motylewski [Thu, 7 Dec 2017 15:12:00 +0000 (16:12 +0100)]
[BUGFIX] Improve SVG page tree

- drag and drop doesn't work on firefox
- when request returns error or 500 code loader is still visible
- loader isn't visible on start
- SVG tree page is duplicate on change left actions menu
- loader is duplicate on change left action menu
- nodes on drag & drop are too sensitive

Releases: master
Resolves: #83224
Resolves: #83176
Resolves: #83177

Change-Id: I03acf2244fe860b7fafd6067d8dfb31ef5bca064
Reviewed-on: https://review.typo3.org/54933
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[!!!][FEATURE] Move extension configuration to install tool 34/54034/34
Markus Hoelzle [Fri, 8 Sep 2017 10:01:53 +0000 (12:01 +0200)]
[!!!][FEATURE] Move extension configuration to install tool

With #82254 LocalConfiguration serialized array EXT/extConf has been
changed to a not serialized array in EXTENSIONS. This patch follows
up on this task an finishes various tasks:

* An install tool silent upgrader upmerges given EXT/extConf settings
  to EXTENSIONS array. The resulting EXTENSIONS array does not contain
  dots for sub paths in its array key anymore and is accessible with a
  new ExtensionConfiguration->get() API to fetch values and whole
  extension config.
* A new API is introduced to get() and set() extension specific
  configuration, is documented and used throughout the core to not
  unserialize old EXT/extConf anymore. Setting values updates legacy
  EXT/extConf to new values including compatible 'dot' ending on
  nested array configurations.
* If extensions come with new configuration items in ext_conf_template.txt
  a silent upgrader of the install tool synchronizes these to the
  EXTENSIONS and old extConf array. Extension authors can rely on that
  and always fetch new keys from the new ExtensionConfiguration->get()
  API right away. The synchronization is also triggered when new
  extensions are loaded or extensions are updated via the extension
  manager.
* Core usages are adapted to the new API.
* Next to the main get() / set() API, the extension configuration
  form is extracted from the extension manager and put into the install
  tool as a new card in "Settings". The code below is streamlined
  and encapsulated with just a couple of public methods in class
  'ExtensionConfigurationService' as internal class for use in install
  tool and extension manager.

Resolves: #82368
Related: #82254
Releases: master
Change-Id: I88568fa355f8f6fd5acc9850dcdd718fdd9a1b2e
Reviewed-on: https://review.typo3.org/54034
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[!!!][TASK] Remove stdWrap option TCAselectItem 99/54799/10
Georg Ringer [Mon, 27 Nov 2017 18:58:37 +0000 (19:58 +0100)]
[!!!][TASK] Remove stdWrap option TCAselectItem

The option `TCAselectItem` is rarely used and also does not cover all
possibilities of the core like manipulating entries with TSconfig and the
mentioned support of database relations.

Resolves: #83122
Releases: master
Change-Id: Ic5ca02d72627a87dc1827bfb4f3c414bc810eef8
Reviewed-on: https://review.typo3.org/54799
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Use given redirectUrl in „list“ wizard, if available 41/54841/4
Andreas Fernandez [Tue, 28 Nov 2017 20:41:40 +0000 (21:41 +0100)]
[BUGFIX] Use given redirectUrl in „list“ wizard, if available

The „list“ wizard now checks whether the redirectUrl was given with
the request and uses this, otherwise it falls back to REQUEST_URI.

Resolves: #83146
Releases: master, 8.7
Change-Id: I0572e6f20c89f77bf11a1c7c2257e4a2c10f4f12
Reviewed-on: https://review.typo3.org/54841
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[!!!][TASK] Remove custom userfunc of DataMapper->getPlainValue 37/54837/3
Benni Mack [Tue, 28 Nov 2017 17:08:07 +0000 (18:08 +0100)]
[!!!][TASK] Remove custom userfunc of DataMapper->getPlainValue

DataMapper's hidden functionality of having a callback functionality
to modify a string before storing it in the database. This was used
for database abstraction with $TYPO3_DB ("fullQuoteStr"), which is now
obsolete for Extbase in general.

Thus, the code can be removed.

Resolves: #83241
Releases: master
Change-Id: Ic09c7572a19da570aebee969dd836371cddb5d43
Reviewed-on: https://review.typo3.org/54837
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] EXT:form - Cover empty strings for "skipIfValueIsEmpty" 77/54577/5
Andreas Fernandez [Tue, 7 Nov 2017 10:48:00 +0000 (11:48 +0100)]
[BUGFIX] EXT:form - Cover empty strings for "skipIfValueIsEmpty"

This ensures that e.g. unchecked checkboxes are not tried to be
stored in the database as empty strings causing an error on int
fields.

Resolves: #82938
Releases: master, 8.7
Change-Id: I6f1811b8fdf17de4c0dd1fac4dec8076600924c6
Reviewed-on: https://review.typo3.org/54577
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] EXT:form - handle boolean finisher options 26/54226/9
Ralf Zimmermann [Thu, 28 Sep 2017 07:53:05 +0000 (09:53 +0200)]
[BUGFIX] EXT:form - handle boolean finisher options

Properly store boolean form definition values. Also
boolean finisher options are returned as boolean now.

Resolves: #82569
Releases: master, 8.7
Change-Id: I1eee0c6d8eaf07534d31622025f3c954d608627b
Reviewed-on: https://review.typo3.org/54226
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[FEATURE] EXT:form - support translation arguments 51/52951/12
Mathias Brodala [Mon, 29 May 2017 11:08:48 +0000 (13:08 +0200)]
[FEATURE] EXT:form - support translation arguments

Form element properties and finisher options can now use arguments
in their translations.

This is especially useful to pass values created dynamically via
formDefinitionOverrides in TypoScript.

Resolves: #81363
Releases: master
Change-Id: Ie205ebc62bcf807e6740c54bbda0115435317604
Reviewed-on: https://review.typo3.org/52951
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[FEATURE] EXT:form - add file size validator 35/54135/17
Ralf Zimmermann [Wed, 13 Sep 2017 14:01:50 +0000 (16:01 +0200)]
[FEATURE] EXT:form - add file size validator

A new ExtbaseValidator called "FileSizeValidator" has been added which
is able to validate a file resource regarding its file size. The
validator is also available within the form editor.

Resolves: #82177
Releases: master
Change-Id: I04ae755b8632c473769fc7ae859c97d88c60b390
Reviewed-on: https://review.typo3.org/54135
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Protect internal properties of PageRepository 18/52918/13
Elmar Hinz [Tue, 23 May 2017 14:50:58 +0000 (16:50 +0200)]
[TASK] Protect internal properties of PageRepository

Mark the public properties as protected and deprecate them within
PageRepository:

- workspaceCache
- error_getRootLine
- error_getRootLine_failPid

Change-Id: I4ed101794dcfc7fa054d42d9e58ad8b5718bcc5d
Releases: master
Resolves: #81318
Reviewed-on: https://review.typo3.org/52918
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[FOLLOWUP][FEATURE] Show page translations in list module 53/54953/2
Oliver Hader [Wed, 6 Dec 2017 22:28:06 +0000 (23:28 +0100)]
[FOLLOWUP][FEATURE] Show page translations in list module

In case the list module is used for a particular page and
then removing the very same page in the pagetree will lead
to an SQL error since $this->id is null. Using proper
parameter type solves this issue.

Resolves: #83016
Releases: master
Change-Id: I07265ed5590062ff043cf0f73b9dbe42f70e9764
Reviewed-on: https://review.typo3.org/54953
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>