Packages/TYPO3.CMS.git
20 months ago[TASK] Use JsonResponse for all Backend AJAX calls 95/54995/3
Benni Mack [Fri, 8 Dec 2017 23:10:36 +0000 (00:10 +0100)]
[TASK] Use JsonResponse for all Backend AJAX calls

The new JsonResponse object should be used throughout the
TYPO3 Backend in order to properly call json_encode() with
the right flags automatically, making the code inside
the controllers simpler.

Resolves: #83267
Releases: master
Change-Id: Ie03fb1414a965a61632897f0e25645a67f3225a5
Reviewed-on: https://review.typo3.org/54995
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[!!!][TASK] Remove config.lockFilePath functionality 74/54974/5
Benni Mack [Thu, 7 Dec 2017 20:44:05 +0000 (21:44 +0100)]
[!!!][TASK] Remove config.lockFilePath functionality

When using the stdWrap.filelist functionality, the lockFilePath
only allowed to be used for a certain directory (usually, if not set, it
was set to fileadmin/), however, this is both very unsecure and inflexible.

Thus, stdWrap.filelist is extended to be used with all local FAL storages.

Add the same time, the public property TSFE->lockFilePath and the TypoScript
option "config.lockFilePath" is removed.

Resolves: #83256
Releases: master
Change-Id: Ia86c6686128dae4c0870cd15e019f4d53a4b28b6
Reviewed-on: https://review.typo3.org/54974
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
20 months ago[BUGFIX] Access Close.html from Resources/Public/Html/ 83/54983/2
Stephan Großberndt [Fri, 8 Dec 2017 11:16:16 +0000 (12:16 +0100)]
[BUGFIX] Access Close.html from Resources/Public/Html/

Clicking the close button in a editing popup accesses Close.html in
Resources/Public/Html/ which is a folder accessible by a web user
instead of Resources/Private/Templates/ which lead to a HTTP 403 error
on closing the popup.

Releases: master, 8.7, 7.6
Resolves: #83258
Related: #68108
Change-Id: Ibe7e328936240df436a3c9585e53122f1577dc6e
Reviewed-on: https://review.typo3.org/54983
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
20 months ago[FOLLOWUP][FEATURE] EXT:form - support translation arguments 89/54989/2
Mathias Brodala [Fri, 8 Dec 2017 12:21:28 +0000 (13:21 +0100)]
[FOLLOWUP][FEATURE] EXT:form - support translation arguments

Add missing YAML for TypoLink example.

Resolves: #81363
Releases: master
Change-Id: I1efc0ab812f96883a938326fb229f1536b7345e0
Reviewed-on: https://review.typo3.org/54989
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Clarify the affected classes and methods in rst file 63/54963/3
Anja Leichsenring [Thu, 7 Dec 2017 12:54:32 +0000 (13:54 +0100)]
[BUGFIX] Clarify the affected classes and methods in rst file

The documentation file states now clearly which parts of public
API have been removed / marked as deprecated.

Resolves: #79972
Releases: master, 8.7
Change-Id: I48420de5a96681d218f98268223b5cb6a198fda9
Reviewed-on: https://review.typo3.org/54963
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Add affected class name to method deprecation 57/54957/2
Anja Leichsenring [Thu, 7 Dec 2017 09:29:19 +0000 (10:29 +0100)]
[BUGFIX] Add affected class name to method deprecation

The documentation file misses the class name of the method
that has been deprecated.

Resolves: #78872
Releases: master, 8.7
Change-Id: I3e6b2fd576f4d4ac85ea096ae3406e6df972a97b
Reviewed-on: https://review.typo3.org/54957
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Mention correct class and function in rst file 47/54947/2
Anja Leichsenring [Wed, 6 Dec 2017 16:41:17 +0000 (17:41 +0100)]
[BUGFIX] Mention correct class and function in rst file

Due to a copy-paste error, the description of the documentation
file does not reflect the other parts.

Resolves: #76259
Releases: master, 8.7
Change-Id: Iea069cae225523d3d35eb6b41b4ab618f2c25e76
Reviewed-on: https://review.typo3.org/54947
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Fix invalid type hints in EXT:form's file upload converter 84/54784/6
Oliver Hader [Mon, 27 Nov 2017 11:11:48 +0000 (12:11 +0100)]
[BUGFIX] Fix invalid type hints in EXT:form's file upload converter

Due to invalid PHP type hints updating a previously uploaded file
reference in a mail form fails in the frontend.

Resolves: #83112
Releases: master, 8.7
Change-Id: Ibf98267a60f076b5654fb0d0d9181a4caeed49b3
Reviewed-on: https://review.typo3.org/54784
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Improve SVG page tree 33/54933/13
Tymoteusz Motylewski [Thu, 7 Dec 2017 15:12:00 +0000 (16:12 +0100)]
[BUGFIX] Improve SVG page tree

- drag and drop doesn't work on firefox
- when request returns error or 500 code loader is still visible
- loader isn't visible on start
- SVG tree page is duplicate on change left actions menu
- loader is duplicate on change left action menu
- nodes on drag & drop are too sensitive

Releases: master
Resolves: #83224
Resolves: #83176
Resolves: #83177

Change-Id: I03acf2244fe860b7fafd6067d8dfb31ef5bca064
Reviewed-on: https://review.typo3.org/54933
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[!!!][FEATURE] Move extension configuration to install tool 34/54034/34
Markus Hoelzle [Fri, 8 Sep 2017 10:01:53 +0000 (12:01 +0200)]
[!!!][FEATURE] Move extension configuration to install tool

With #82254 LocalConfiguration serialized array EXT/extConf has been
changed to a not serialized array in EXTENSIONS. This patch follows
up on this task an finishes various tasks:

* An install tool silent upgrader upmerges given EXT/extConf settings
  to EXTENSIONS array. The resulting EXTENSIONS array does not contain
  dots for sub paths in its array key anymore and is accessible with a
  new ExtensionConfiguration->get() API to fetch values and whole
  extension config.
* A new API is introduced to get() and set() extension specific
  configuration, is documented and used throughout the core to not
  unserialize old EXT/extConf anymore. Setting values updates legacy
  EXT/extConf to new values including compatible 'dot' ending on
  nested array configurations.
* If extensions come with new configuration items in ext_conf_template.txt
  a silent upgrader of the install tool synchronizes these to the
  EXTENSIONS and old extConf array. Extension authors can rely on that
  and always fetch new keys from the new ExtensionConfiguration->get()
  API right away. The synchronization is also triggered when new
  extensions are loaded or extensions are updated via the extension
  manager.
* Core usages are adapted to the new API.
* Next to the main get() / set() API, the extension configuration
  form is extracted from the extension manager and put into the install
  tool as a new card in "Settings". The code below is streamlined
  and encapsulated with just a couple of public methods in class
  'ExtensionConfigurationService' as internal class for use in install
  tool and extension manager.

Resolves: #82368
Related: #82254
Releases: master
Change-Id: I88568fa355f8f6fd5acc9850dcdd718fdd9a1b2e
Reviewed-on: https://review.typo3.org/54034
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[!!!][TASK] Remove stdWrap option TCAselectItem 99/54799/10
Georg Ringer [Mon, 27 Nov 2017 18:58:37 +0000 (19:58 +0100)]
[!!!][TASK] Remove stdWrap option TCAselectItem

The option `TCAselectItem` is rarely used and also does not cover all
possibilities of the core like manipulating entries with TSconfig and the
mentioned support of database relations.

Resolves: #83122
Releases: master
Change-Id: Ic5ca02d72627a87dc1827bfb4f3c414bc810eef8
Reviewed-on: https://review.typo3.org/54799
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Use given redirectUrl in „list“ wizard, if available 41/54841/4
Andreas Fernandez [Tue, 28 Nov 2017 20:41:40 +0000 (21:41 +0100)]
[BUGFIX] Use given redirectUrl in „list“ wizard, if available

The „list“ wizard now checks whether the redirectUrl was given with
the request and uses this, otherwise it falls back to REQUEST_URI.

Resolves: #83146
Releases: master, 8.7
Change-Id: I0572e6f20c89f77bf11a1c7c2257e4a2c10f4f12
Reviewed-on: https://review.typo3.org/54841
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[!!!][TASK] Remove custom userfunc of DataMapper->getPlainValue 37/54837/3
Benni Mack [Tue, 28 Nov 2017 17:08:07 +0000 (18:08 +0100)]
[!!!][TASK] Remove custom userfunc of DataMapper->getPlainValue

DataMapper's hidden functionality of having a callback functionality
to modify a string before storing it in the database. This was used
for database abstraction with $TYPO3_DB ("fullQuoteStr"), which is now
obsolete for Extbase in general.

Thus, the code can be removed.

Resolves: #83241
Releases: master
Change-Id: Ic09c7572a19da570aebee969dd836371cddb5d43
Reviewed-on: https://review.typo3.org/54837
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] EXT:form - Cover empty strings for "skipIfValueIsEmpty" 77/54577/5
Andreas Fernandez [Tue, 7 Nov 2017 10:48:00 +0000 (11:48 +0100)]
[BUGFIX] EXT:form - Cover empty strings for "skipIfValueIsEmpty"

This ensures that e.g. unchecked checkboxes are not tried to be
stored in the database as empty strings causing an error on int
fields.

Resolves: #82938
Releases: master, 8.7
Change-Id: I6f1811b8fdf17de4c0dd1fac4dec8076600924c6
Reviewed-on: https://review.typo3.org/54577
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] EXT:form - handle boolean finisher options 26/54226/9
Ralf Zimmermann [Thu, 28 Sep 2017 07:53:05 +0000 (09:53 +0200)]
[BUGFIX] EXT:form - handle boolean finisher options

Properly store boolean form definition values. Also
boolean finisher options are returned as boolean now.

Resolves: #82569
Releases: master, 8.7
Change-Id: I1eee0c6d8eaf07534d31622025f3c954d608627b
Reviewed-on: https://review.typo3.org/54226
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[FEATURE] EXT:form - support translation arguments 51/52951/12
Mathias Brodala [Mon, 29 May 2017 11:08:48 +0000 (13:08 +0200)]
[FEATURE] EXT:form - support translation arguments

Form element properties and finisher options can now use arguments
in their translations.

This is especially useful to pass values created dynamically via
formDefinitionOverrides in TypoScript.

Resolves: #81363
Releases: master
Change-Id: Ie205ebc62bcf807e6740c54bbda0115435317604
Reviewed-on: https://review.typo3.org/52951
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[FEATURE] EXT:form - add file size validator 35/54135/17
Ralf Zimmermann [Wed, 13 Sep 2017 14:01:50 +0000 (16:01 +0200)]
[FEATURE] EXT:form - add file size validator

A new ExtbaseValidator called "FileSizeValidator" has been added which
is able to validate a file resource regarding its file size. The
validator is also available within the form editor.

Resolves: #82177
Releases: master
Change-Id: I04ae755b8632c473769fc7ae859c97d88c60b390
Reviewed-on: https://review.typo3.org/54135
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Protect internal properties of PageRepository 18/52918/13
Elmar Hinz [Tue, 23 May 2017 14:50:58 +0000 (16:50 +0200)]
[TASK] Protect internal properties of PageRepository

Mark the public properties as protected and deprecate them within
PageRepository:

- workspaceCache
- error_getRootLine
- error_getRootLine_failPid

Change-Id: I4ed101794dcfc7fa054d42d9e58ad8b5718bcc5d
Releases: master
Resolves: #81318
Reviewed-on: https://review.typo3.org/52918
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[FOLLOWUP][FEATURE] Show page translations in list module 53/54953/2
Oliver Hader [Wed, 6 Dec 2017 22:28:06 +0000 (23:28 +0100)]
[FOLLOWUP][FEATURE] Show page translations in list module

In case the list module is used for a particular page and
then removing the very same page in the pagetree will lead
to an SQL error since $this->id is null. Using proper
parameter type solves this issue.

Resolves: #83016
Releases: master
Change-Id: I07265ed5590062ff043cf0f73b9dbe42f70e9764
Reviewed-on: https://review.typo3.org/54953
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[FOLLOWUP][BUGFIX] Use Fluid standalone abstract classes 46/54946/4
Benni Mack [Wed, 6 Dec 2017 16:20:50 +0000 (17:20 +0100)]
[FOLLOWUP][BUGFIX] Use Fluid standalone abstract classes

Resolves: #82414
Releases: master
Change-Id: I375bfd92e0b7eb58aa68f5a50e18b854d8fc6bdb
Reviewed-on: https://review.typo3.org/54946
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] EXT:form - merge properties with configuration settings 24/54124/4
Ralf Zimmermann [Tue, 12 Sep 2017 09:58:44 +0000 (11:58 +0200)]
[BUGFIX] EXT:form - merge properties with configuration settings

Merge the properties set through the formDefinition with the
predefined properties from the base configuration.
Add tests for property part of FormElementInterface implementation.

Resolves: #82243
Releases: master, 8.7
Change-Id: Ia6a4428aa52508ec6756eaa6a9d9c471e932baf8
Reviewed-on: https://review.typo3.org/54124
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Add missing backslashes to class name in rst file 60/54960/2
Anja Leichsenring [Thu, 7 Dec 2017 11:23:56 +0000 (12:23 +0100)]
[BUGFIX] Add missing backslashes to class name in rst file

Namespace and classname have not been separated by a backslash,
making that class not easy to identify.

Resolves: #79341
Releases: master, 8.7
Change-Id: Ic86086524cb10c470296facef25759f14c35cc11
Reviewed-on: https://review.typo3.org/54960
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[BUGFIX] Correct method name in documentation file 54/54954/2
Anja Leichsenring [Thu, 7 Dec 2017 07:46:33 +0000 (08:46 +0100)]
[BUGFIX] Correct method name in documentation file

The mentioned method to be changed was mistyped.
The name given in the rst file doesn't exist.

Resolves: #77750
Releases: master, 8.7
Change-Id: Ic64590c8ffa3826dd3c5db5365e0c5273e897824
Reviewed-on: https://review.typo3.org/54954
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] EXT:form - hide readonly elements in summary page and emails 31/54131/3
Ralf Zimmermann [Wed, 13 Sep 2017 10:51:37 +0000 (12:51 +0200)]
[BUGFIX] EXT:form - hide readonly elements in summary page and emails

Hide readonly form elements within the summary page and emails.

Resolves: #82471
Releases: master, 8.7
Change-Id: I9c42754c935c0b2c62ff1a70f43e7a13d3594f82
Reviewed-on: https://review.typo3.org/54131
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] EXT:form - show message if a form could not be saved 26/54126/8
Ralf Zimmermann [Tue, 12 Sep 2017 12:49:40 +0000 (14:49 +0200)]
[BUGFIX] EXT:form - show message if a form could not be saved

Notify the user if the form could not be saved.

Also remove the timeout of the error messages to ensure editors
have enough time to read and understand the message.

Resolves: #82255
Resolves: #82381
Releases: master, 8.7
Change-Id: I1377b7a85347107e7d03079b5a31179873a81e60
Reviewed-on: https://review.typo3.org/54126
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Proper checks for system maintainers 41/54941/4
Georg Ringer [Wed, 6 Dec 2017 08:35:28 +0000 (09:35 +0100)]
[BUGFIX] Proper checks for system maintainers

Always use the original user id and never use a fallback to a user id
switched to.

The BackendUserAuthentication->isSystemMaintainer() method now always
returns false if a user is in "switch user" mode.

Resolves: #83041
Releases: master
Change-Id: I25fc15bb9f2ed19ae5080fbe039154be1c1a521f
Reviewed-on: https://review.typo3.org/54941
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[!!!][TASK] Remove cache_phpcode cache configuration 49/54949/3
Benni Mack [Wed, 6 Dec 2017 18:45:45 +0000 (19:45 +0100)]
[!!!][TASK] Remove cache_phpcode cache configuration

The "cache_phpcode" cache was used for having TYPO3's own-baked
DBAL layer running. As this is not installed nor shipped anymore, the cache
configuration should be removed.

Resolves: #83243
Releases: master
Change-Id: Ic1c48b4090d3744239bdeb51ce1d178baf10aa40
Reviewed-on: https://review.typo3.org/54949
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Adjust loading animation of modal windows 29/54929/4
Benjamin Kott [Mon, 4 Dec 2017 12:28:27 +0000 (13:28 +0100)]
[TASK] Adjust loading animation of modal windows

Use TYPO3 spinner which is properly centered.

Releases: master, 8.7
Resolves: #83218
Change-Id: Ieec359ee0bc05ebb75724b963edaf1dc5bbab0a8
Reviewed-on: https://review.typo3.org/54929
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[BUGFIX] Require mail subject in finisher overrides 43/54943/3
Daniel Lorenz [Wed, 6 Dec 2017 13:04:47 +0000 (14:04 +0100)]
[BUGFIX] Require mail subject in finisher overrides

Resolves: #83021
Releases: master, 8.7
Change-Id: Ic88731ce7f2b698d39aca6944cf0257a8a758420
Reviewed-on: https://review.typo3.org/54943
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Make fixture invalid for symfony yaml parser 42/54942/2
Daniel Lorenz [Wed, 6 Dec 2017 11:10:16 +0000 (12:10 +0100)]
[BUGFIX] Make fixture invalid for symfony yaml parser

Resolves: #83239
Releases: master, 8.7
Change-Id: I3a617b31f197b19231a858f88f992904c681124d
Reviewed-on: https://review.typo3.org/54942
Reviewed-by: Carlos Meyer <cm@davitec.de>
Tested-by: Carlos Meyer <cm@davitec.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] EXT:form - allow field options translation by type 72/54472/2
Mathias Brodala [Wed, 25 Oct 2017 09:41:48 +0000 (11:41 +0200)]
[BUGFIX] EXT:form - allow field options translation by type

Resolves: #82853
Releases: master, 8.7
Change-Id: I7d55cb7a6472d310b2f1d47a9b04014cbd43a832
Reviewed-on: https://review.typo3.org/54472
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Tested-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[!!!][TASK] Deprecate cache FrontendInterface->getByTag 91/53091/11
Claus Due [Sat, 3 Jun 2017 14:28:05 +0000 (16:28 +0200)]
[!!!][TASK] Deprecate cache FrontendInterface->getByTag

See #81460 for a detailed reasoning behind the change.

The patch declares the getByTags method as deprecated
and removes the only usage that existed in TYPO3.

Resolves: #81460
Related: #81432
Releases: master
Change-Id: I9647563246d96228cb906b7d9008b2cec564d3ae
Reviewed-on: https://review.typo3.org/53091
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
20 months ago[BUGFIX] Correct wrong class names in deprecation.rst 44/54944/4
Anja Leichsenring [Wed, 6 Dec 2017 13:43:28 +0000 (14:43 +0100)]
[BUGFIX] Correct wrong class names in deprecation.rst

Correct two class names, one wrongly named, one with a typo, in
a deprecation rst file of 8.0.

Resolves: #73514
Releases: master, 8.7
Change-Id: I48a4af12749d477b151a4774f8e35c09bc9817ce
Reviewed-on: https://review.typo3.org/54944
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[BUGFIX] Output correct max upload size 37/54937/2
Alexander Opitz [Tue, 5 Dec 2017 16:13:24 +0000 (17:13 +0100)]
[BUGFIX] Output correct max upload size

We should show what the max upload file size is and not the max size of
a HTTP post body.

Resolves: #83230
Releases: master, 8.7, 7.6
Change-Id: Ib6fa244b19c434417808bb19126f862cf9418fb0
Reviewed-on: https://review.typo3.org/54937
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
20 months ago[!!!][TASK] Remove CMS base ViewHelper classes 68/54068/11
Claus Due [Sat, 9 Sep 2017 15:13:13 +0000 (17:13 +0200)]
[!!!][TASK] Remove CMS base ViewHelper classes

This patch sacrifices two features:

* Having $this->controllerContext on ViewHelpers
* Support for render method arguments

And by doing so, allows the removal of every CMS
base ViewHelper class and several overrides they
implement. The base classes are still available as
class aliases to limit the breaking change to the two
features mentioned above.

Change-Id: I425b01234618f83d701ec6dd99ce3bf7ce514589
Resolves: #82414
Releases: master
Reviewed-on: https://review.typo3.org/54068
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[BUGFIX] Wording 78169-IntroduceTranslationSourceFieldForTt_content.rst 34/54934/4
Simon [Tue, 5 Dec 2017 09:43:11 +0000 (10:43 +0100)]
[BUGFIX] Wording 78169-IntroduceTranslationSourceFieldForTt_content.rst

Uid is pronounced as a consonent sound (y) or in german "j", therefore it
becomes "a uid".

Releases: master, 8.7
Resolves: #83225
Change-Id: Id8d4ac712d3cab6b47b9cb48a804ae8a7574ed30
Reviewed-on: https://review.typo3.org/54934
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Re-add missing labels 22/54922/5
Nicole Cordes [Sun, 3 Dec 2017 18:09:38 +0000 (19:09 +0100)]
[BUGFIX] Re-add missing labels

Since the page tree change, some default labels are not available
anymore. This patch re-adds missing labels for debugger and module
wizards.

Resolves: #83208
Releases: master
Change-Id: I2be56c573b7099ee1bedab0238b839bf9867f73e
Reviewed-on: https://review.typo3.org/54922
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[TASK] ext_emconf.php: Fix some inconsistencies 18/54918/3
Christian Kuhn [Sun, 3 Dec 2017 16:10:15 +0000 (17:10 +0100)]
[TASK] ext_emconf.php: Fix some inconsistencies

Some 'constraints' related inconsistencies, especially
in test fixture extensions.

Change-Id: I015e34a5519cab166d7941cce35a1661c42b9c5a
Resolves: #83205
Releases: master
Reviewed-on: https://review.typo3.org/54918
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Raise testing-framework to 2.0.0 16/54916/2
Christian Kuhn [Sun, 3 Dec 2017 14:58:22 +0000 (15:58 +0100)]
[TASK] Raise testing-framework to 2.0.0

master branch of testing-framework is now tagged as 2.x.x for
core master / v9, while the 8 branch of testing-framework
is tagged as 1.2.x and used in v8 core.
The split is needed since master branch contains the svg tree
adaptions and 1.2 branch does not.

Change-Id: I27bb4e996e20cf00110cb0e6a160337656a2d7f0
Resolves: #83203
Related: #83204
Related: #82226
Related: #82426
Releases: master
Reviewed-on: https://review.typo3.org/54916
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] ContentObjectRendereTest: Undefined constant NL 07/54907/2
Christian Kuhn [Sat, 2 Dec 2017 23:40:52 +0000 (00:40 +0100)]
[BUGFIX] ContentObjectRendereTest: Undefined constant NL

A data provider uses the not defined constant "NL". PHP 7.2
throws warnings on this. Warnings from data providers do not
lead to failing tests, still this is ugly and pollutes test
runs with warnings in the head part.

Change-Id: I3b09ce51d675cf3097967c074511eaf0a53cf8f9
Resolves: #83194
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54907
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] bamboo: Include php 7.2 in test suite 06/54906/2
Christian Kuhn [Sat, 2 Dec 2017 22:15:34 +0000 (23:15 +0100)]
[TASK] bamboo: Include php 7.2 in test suite

Add php 7.2 to master test suite:
* pre-merge: acceptance, integration, functionals on any PHP agent 7.x
* pre-merge: distinct 7.0, 7.1, 7.2 jobs for php unit tests and php linting
* nightly: distinct 7.0, 7.1, 7.2 jobs for all tests

Change-Id: I8ad609e1cb2dc66162d642b5428bbf5a74d3bf36
Resolves: #83193
Releases: master
Reviewed-on: https://review.typo3.org/54906
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Remove auto-creation of uploads folder 95/54895/2
Benni Mack [Thu, 30 Nov 2017 21:10:33 +0000 (22:10 +0100)]
[TASK] Remove auto-creation of uploads folder

For new plain TYPO3 installations, the uploads/ folder
is not needed anymore, as the TYPO3 core does not
use the uploads/ (internal_type=file) functionality
anymore, but uses the File Abstraction Layer completely.

Resolves: #83182
Releases: master
Change-Id: Idc99d72b91aaeff5a39a1ef353cc8cc6583dced6
Reviewed-on: https://review.typo3.org/54895
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[BUGFIX] Implicit constant to string cast in unit test case 03/54903/2
Christian Kuhn [Sat, 2 Dec 2017 01:24:18 +0000 (02:24 +0100)]
[BUGFIX] Implicit constant to string cast in unit test case

An array key is not used as string but as constant in
two ConfigurationManager test cases. PHP 7.2 is more
picky about this an throws warnings. Fix by creating
proper strings.

Change-Id: I64def6cf9b5d9df7e150d137929c721558c761d7
Resolves: #83190
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54903
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[CLEANUP] Add class-imports in Extbase Persistence classes 96/54896/4
Stefan Neufeind [Fri, 1 Dec 2017 08:00:52 +0000 (09:00 +0100)]
[CLEANUP] Add class-imports in Extbase Persistence classes

This cleanup should ease backporting future patches in that area.

Releases: master, 8.7, 7.6
Resolves: #83189
Change-Id: I42b700d2fd17beadc4a9b8e64e500f3d3b93fd1f
Reviewed-on: https://review.typo3.org/54896
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Remove double quotations in FileList class 99/54899/2
Wouter Wolters [Fri, 1 Dec 2017 20:38:09 +0000 (21:38 +0100)]
[BUGFIX] Remove double quotations in FileList class

On two occasions there are too many double quotes.

Resolves: #83186
Releases: master
Change-Id: I8708bc5ff1d6ac680bccaab14d407f5ab3222698
Reviewed-on: https://review.typo3.org/54899
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[TASK] Save 2 calls to the runtime cache in DataHandler 94/54894/2
Wouter Wolters [Thu, 30 Nov 2017 21:00:34 +0000 (22:00 +0100)]
[TASK] Save 2 calls to the runtime cache in DataHandler

By just getting the value and checking what is returned instead of
calling the runtime cache twice for each call

Resolves: #83181
Releases: master
Change-Id: Ic5802bf57faa5f8e38c35f9405918d5076697332
Reviewed-on: https://review.typo3.org/54894
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Fix ExtJS removal documentation files 97/54897/3
Christian Kuhn [Fri, 1 Dec 2017 10:50:40 +0000 (11:50 +0100)]
[BUGFIX] Fix ExtJS removal documentation files

A couple of syntax errors in the .rst files of the
ExtJS / page tree feature.

Resolves: #83185
Related: #82426
Releases: master
Change-Id: I010dffddbe565de770868e717d75f16828d60b0b
Reviewed-on: https://review.typo3.org/54897
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[BUGFIX] Fix injured workspace encapsulation in record localize summary. 81/50881/14
Gleb Levitin [Sun, 4 Dec 2016 09:20:42 +0000 (10:20 +0100)]
[BUGFIX] Fix injured workspace encapsulation in record localize summary.

This patch resolves problem with the injured workspace encapsulation
for removed records while fetching the record localize summary in page
module within a workspace.

Resolves: #78841
Releases: master, 8.7
Change-Id: I734a32c7b52ed4a2a3ab49c63d45df46472a99a4
Reviewed-on: https://review.typo3.org/50881
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[BUGFIX] Add `config.frontend_editing` to tsref.xml of EXT:t3editor 22/51622/2
Andreas Fernandez [Fri, 10 Feb 2017 05:18:00 +0000 (06:18 +0100)]
[BUGFIX] Add `config.frontend_editing` to tsref.xml of EXT:t3editor

Resolves: #79736
Releases: master
Change-Id: I8662c7adfa38669b3a66b3959485722a285b4448
Reviewed-on: https://review.typo3.org/51622
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Make quoting of SQL fragments in TCA possible 60/53360/17
Stephan Großberndt [Fri, 30 Jun 2017 06:35:50 +0000 (08:35 +0200)]
[BUGFIX] Make quoting of SQL fragments in TCA possible

The table and column name quoting method {#tableName}.{#columnName}
introduced for TypoScript in issue #80506 is now used to quote
identifiers in TCA column definitions known to possibly contain SQL
fragments. Missing quotes for identifiers containing e.g. uppercase
letters lead to exceptions when performing a query in PostgreSQL.

In order to achieve this a new Class TcaPreparation is added as this is
not a typical TcaMigration.

Releases: master, 8.7
Resolves: #81751
Related: #80506
Change-Id: I230be317c7088e5de5343634fac507b4ab994b28
Reviewed-on: https://review.typo3.org/53360
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
20 months ago[FEATURE] Provide a trait to support public access deprecation 28/52928/34
Elmar Hinz [Wed, 24 May 2017 08:00:14 +0000 (10:00 +0200)]
[FEATURE] Provide a trait to support public access deprecation

Provides a trait to leverage a smooth migration of public
property access to protected. For the period of deprecation
the access to the protected property is still possible and is
logged by the deprecation log. A unit test is included.

Resolves: #81330
Releases: master
Change-Id: I6293e460053eb38a633271ec877b3bc9a8527342
Reviewed-on: https://review.typo3.org/52928
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Fix language of placeholder for relations 31/54831/9
Nicole Cordes [Wed, 22 Nov 2017 11:28:37 +0000 (12:28 +0100)]
[BUGFIX] Fix language of placeholder for relations

When a parent record (e.g. tt_content) has inline relations
(e.g. sys_file_reference)and these relations show a placeholder
for records related to them (e.g. sys_file and sys_file_metadata)
then we need to pass the context of the language so that
the placeholders are shown in the correct language.

We now do so by putting the value of the language field
of the parent record into the data set and update it
in case child records are also translatable.

This way when going down the list of children, we always
know the language id of the last applicable parent element,
even if one element in between was not translatable (e.g. sys_file)

If we know the language, we can pick the correct record uid
out of the list of possible related uids, instead of
just picking the first one.

Furthermore the language field for sys_file_metadata is removed from
editor form as the language is set by GET parameter already.

Change-Id: I64c97c8080196599e85b95e09e7eb89701670fa4
Resolves: #75040
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54831
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
20 months ago[!!!][FEATURE] Replace ExtJS page tree 94/51594/113
Tymoteusz Motylewski [Thu, 30 Nov 2017 13:16:24 +0000 (14:16 +0100)]
[!!!][FEATURE] Replace ExtJS page tree

The ExtJS/ExtDirect based page tree has been replaced with
new implementation based on SVG.

Refactoring and performance improvement of the PHP side
(tree data provider) will be done in the followup patch.

Releases: master
Resolves: #82426
Change-Id: I502a085da939ebe2561d2b7a17cc8347e5101623
Reviewed-on: https://review.typo3.org/51594
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Fix exceptions from BE Routing change 86/54886/2
Susanne Moog [Thu, 30 Nov 2017 12:47:58 +0000 (13:47 +0100)]
[BUGFIX] Fix exceptions from BE Routing change

Change-Id: I3f74892da6c82a7213b7f77d5027160ee118eabb
Resolves: #83174
Releases: master
Reviewed-on: https://review.typo3.org/54886
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Suggest PHP "intl" extension 78/54878/4
Markus Klein [Wed, 29 Nov 2017 21:30:02 +0000 (22:30 +0100)]
[TASK] Suggest PHP "intl" extension

This is the basis for further improvements, which require
locale aware operations.

Resolves: #83171
Releases: master
Change-Id: Iae9bf29b88031a0115cdf3dfb2957c97c9cc0c34
Reviewed-on: https://review.typo3.org/54878
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Use BE Routing / PSR-7 instead of BackendUtility::getModuleUrl 55/54755/10
Benni Mack [Fri, 24 Nov 2017 22:30:11 +0000 (23:30 +0100)]
[TASK] Use BE Routing / PSR-7 instead of BackendUtility::getModuleUrl

The new PSR-7-based solution since TYPO3 v7 should be used everywhere
instead of "BackendUtility::getModuleUrl()". This is possible because
modules can be addressed via the "route" GET parameter instead of the
"M" parameter since a few months.

The patch changes all occurrences within TYPO3 Core to use the new API.

Resolves: #83172
Releases: master
Change-Id: Iec40e8ae00f1d900d7479b84a3a62827ddba653b
Reviewed-on: https://review.typo3.org/54755
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[FOLLOWUP][BUGFIX] Preview information should not conflict with frontend layout 81/54881/2
Markus Klein [Thu, 30 Nov 2017 09:29:48 +0000 (10:29 +0100)]
[FOLLOWUP][BUGFIX] Preview information should not conflict with frontend layout

Switch order of arguments to implode().

Resolves: #83158
Releases: master, 8.7
Change-Id: I15ff9827418e9d24fefae5f3fa8852a37f5363d0
Reviewed-on: https://review.typo3.org/54881
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
20 months ago[BUGFIX] Handle docroot relative paths correctly in ResourceCompressor 81/54481/7
Markus Klein [Thu, 26 Oct 2017 22:30:15 +0000 (00:30 +0200)]
[BUGFIX] Handle docroot relative paths correctly in ResourceCompressor

Resolves: #82863
Releases: master, 8.7
Change-Id: Iaf775d83c526017ff882d21c8f6d7c5c1f78a038
Reviewed-on: https://review.typo3.org/54481
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
20 months ago[TASK] Re-add autolinking RTE feature in CKeditor 11/54611/5
Benni Mack [Fri, 10 Nov 2017 09:45:55 +0000 (10:45 +0100)]
[TASK] Re-add autolinking RTE feature in CKeditor

A missing functionality is added, which happened when introducing CKeditor.

Automatically linking a URL when typing www.typo3.org should happen directly.

A specific plugin is used for that. Base concept was taken from
https://github.com/Gnodiah/ckeditor-autolink

Resolves: #80977
Releases: master, 8.7
Change-Id: I575b63eeb696166b5e3b06047106e26cb68eb7b4
Reviewed-on: https://review.typo3.org/54611
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Return null value instead of string 'NULL' 27/43627/13
Gernot Leitgab [Fri, 2 Sep 2016 18:59:26 +0000 (20:59 +0200)]
[BUGFIX] Return null value instead of string 'NULL'

Add local getPlainValue method in persistence backend, so a
null value instead of string 'NULL' is written to database.

Resolves: #68994
Related: #57255
Releases: master, 8.7
Change-Id: Idb61caabf5115da4bb818d2ed8bb4faa16f5df2c
Reviewed-on: https://review.typo3.org/43627
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[TASK] Add HTML5 checks for "create new admin user" in Install Tool 72/54872/5
Jonathan IROULIN [Wed, 29 Nov 2017 17:45:04 +0000 (18:45 +0100)]
[TASK] Add HTML5 checks for "create new admin user" in Install Tool

This patch adds HTML5 attributes to the form fields so the username
field is set to required and the password has to be at least 8
characters long.

Resolves: #82135
Releases: master
Change-Id: I3ab05af63125479de2427a5b236f8c434d598aad
Reviewed-on: https://review.typo3.org/54872
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Make install tool cards more speaking 73/54873/2
Benni Mack [Wed, 29 Nov 2017 17:47:21 +0000 (18:47 +0100)]
[TASK] Make install tool cards more speaking

Resolves: #83169
Releases: master
Change-Id: Ic9ed0f3ceb06aa3befcc3931ba656639615c2f6f
Reviewed-on: https://review.typo3.org/54873
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Avoid reflection for public property injection 50/54850/5
Alexander Schnitzler [Wed, 29 Nov 2017 10:08:35 +0000 (11:08 +0100)]
[BUGFIX] Avoid reflection for public property injection

The property injection in the ObjectContainer always
did reflect the object and made the property accessible,
even if the property was public and therefore accessible
by default.

With this patch, reflection is avoided for public
properties which increases the performance of public
property injection a lot.

Releases: master, 8.7
Resolves: #83155
Change-Id: I32f7c8e257f65da4a2fce1d7ee515d7954564387
Reviewed-on: https://review.typo3.org/54850
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Properly handle flexform related exceptions 61/51061/5
Alexander Schnitzler [Thu, 29 Dec 2016 14:24:15 +0000 (15:24 +0100)]
[BUGFIX] Properly handle flexform related exceptions

The FlexFormTools class tries to resolve the datastructure
of flex fields by the given TCA configuration. The flexform
definition can either be set directly in the TCA or it is
fetched from another record.

Example:
TemplaVoilà fetches the data structure from the table
tx_templavoila_datastructure.

When trying to resolve the data structure from another
table and the identifier is invalid (e.g. empty or does
not point to a valid record), several exceptions are
thrown that need to be caught at several points to keep
the user interface accessible.

Other than these mentioned exceptions there are ones
that indicate that the TCA configuration is simply wrong.
These ones are not caught and will still bubble up.

Releases: master, 8.7
Fixes: #79101
Change-Id: I9be921e1425076897a86ebb0b997a998fda7f373
Reviewed-on: https://review.typo3.org/51061
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] All TCA columns should have a config section 57/54857/3
Christian Kuhn [Wed, 29 Nov 2017 11:31:18 +0000 (12:31 +0100)]
[TASK] All TCA columns should have a config section

Having a TCA columns field without 'config' array doesn't make
sense. ['config']['type'] is marked as mandatory field anyway
and the TCA migration throws an exception if ['config'] exists
but ['type'] is missing for a while.
The patch now adds code to add ['config']['type'] = 'none' if
['config'] does not exist at all.

Change-Id: I18b9a9866f16ca3ba5750ec2970436282aa01719
Resolves: #83152
Releases: master
Reviewed-on: https://review.typo3.org/54857
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[BUGFIX] Fix source collection for GIFBUILDER 37/49537/9
Marco Huber [Mon, 22 Aug 2016 11:49:34 +0000 (13:49 +0200)]
[BUGFIX] Fix source collection for GIFBUILDER

If the file resource is a GIFBUILDER object, the dimension is set in the
properties XY, maxWidth or maxHeight.

Change-Id: Ic931760a966e6647042bca976c48e7bbaabdbb5a
Resolves: #77577
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/49537
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[FEATURE] Possibility to set sessionTimeout for Frontend Users 54/50654/11
Alexander Opitz [Mon, 14 Nov 2016 15:54:50 +0000 (16:54 +0100)]
[FEATURE] Possibility to set sessionTimeout for Frontend Users

Currently it was only possible to set the session timeout for the backend users
You can define the sessionTimeout with the new configuration option
$GLOBALS['TYPO3_CONF_VARS']['FE']['sessionTimeout'].

Resolves: #78695
Releases: master
Change-Id: I628ccc4448230af6dd2bf1533777375ef7e5624d
Reviewed-on: https://review.typo3.org/50654
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Clarify description of FE|sessionDataLifetime 71/54871/3
Markus Klein [Wed, 29 Nov 2017 17:39:18 +0000 (18:39 +0100)]
[BUGFIX] Clarify description of FE|sessionDataLifetime

The FE|sessionDataLifetime option is solely used for anonymous
frontend sessions. It does not influence any other session(-data).
Document this clearly.

Resolves: #83168
Releases: master, 8.7
Change-Id: I8b16bc73c6d79b5bc6015b4448c6ec4604bdd780
Reviewed-on: https://review.typo3.org/54871
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Simplify the Clear temp file section in Install Tool 15/54215/4
Georg Ringer [Tue, 26 Sep 2017 05:41:52 +0000 (07:41 +0200)]
[TASK] Simplify the Clear temp file section in Install Tool

Hide the button for cleaning a directory if the directory is
empty.

Resolves: #82561
Releases: master
Change-Id: I06e76f79b1d814aa5a04a68be544a4c102d7392a
Reviewed-on: https://review.typo3.org/54215
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Install tool: Racy clear tables 69/54869/2
Christian Kuhn [Wed, 29 Nov 2017 17:06:54 +0000 (18:06 +0100)]
[BUGFIX] Install tool: Racy clear tables

JS ajax call to reload stats must be called after
clear table finished and not in parallel.

Change-Id: Ifdaa6f89eafe042b5c57b130e189001b1ca0a3fe
Resolves: #83166
Releases: master
Reviewed-on: https://review.typo3.org/54869
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[!!!][TASK] Migrate backend_layout.icon to FAL 30/54830/8
Benni Mack [Tue, 28 Nov 2017 11:57:38 +0000 (12:57 +0100)]
[!!!][TASK] Migrate backend_layout.icon to FAL

The last place in TYPO3 Core to use internal_type=file (backend_layout.icon)
is now moved to FAL with sys_file_reference.

An upgrade wizard is in place to migrate existing icons from uploads/media
to sys_file.

FormEngine is migrated to also allow to use sys_file_references for the
TCA ctrl property "selicon_field".

With this change, a followup could be integrated to deprecate "old-style"
internal_type=file code, and also to not create the uploads/ folder at all anymore
within TYPO3 installations.

Additionally, the functionality of "selicon_field_path" should be deprecated
in the future.

Resolves: #83153
Releases: master
Change-Id: I578fd68b7e1f7bc6a1991b90e7750b903d3ec28b
Reviewed-on: https://review.typo3.org/54830
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Reviewed-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Tested-by: Pawel Cieslik <p.cieslik@macopedia.pl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths 16/54416/7
Benjamin Franzke [Tue, 17 Oct 2017 14:53:28 +0000 (16:53 +0200)]
[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths

FLUIDTEMPLATE variables may contain content elements (e.g. recursive
FLUIDTEMPLATE's) which may instantiate own TemplateViews
(e.g. StandaloneView).
A recursive StandaloneView will statically(!!) cache used TemplatesPaths
in \TYPO3Fluid\Fluid\View\Templates::resolvedFiles.

If StandaloneView is instantiated before, but the fluid layout path is
calculated after inner content objects are being rendering,
the altered statically cached `resolvedFiles` cache is used
and contains invalid layoutRootPaths.

Short term solution:
Defer the initialization of the StandaloneView (which flushes those
buggy caches) until all variables have been processed.

Change-Id: Idf053b3d0f0835a352790e0ed971344d67844bbc
Releases: master, 8.7
Resolves: #79760
Resolves: #82745
Reviewed-on: https://review.typo3.org/54416
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Use booleans where currently 1/0 are used 71/54671/6
Stefan Neufeind [Fri, 17 Nov 2017 09:26:42 +0000 (10:26 +0100)]
[TASK] Use booleans where currently 1/0 are used

Releases: master
Resolves: #83023
Change-Id: I9fe436f94a1223020b5fd0c308fa5bdb1b81ec39
Reviewed-on: https://review.typo3.org/54671
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[!!!][TASK] Remove TYPO3.LLL usages in TYPO3 core 60/54860/7
Pawel Cieslik [Wed, 29 Nov 2017 12:03:54 +0000 (13:03 +0100)]
[!!!][TASK] Remove TYPO3.LLL usages in TYPO3 core

Remove TYPO3.LLL after moving to new JS API for translations TYPO3.lang

Resolves: #83161
Releases: master
Change-Id: I815b15349c8bfe6ca71f4d1ce59b7b01e670eae2
Reviewed-on: https://review.typo3.org/54860
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Apply correct button styles on EDITPANEL for pages 59/54859/2
Benjamin Kott [Wed, 29 Nov 2017 11:50:48 +0000 (12:50 +0100)]
[BUGFIX] Apply correct button styles on EDITPANEL for pages

Resolves: #83162
Releases: master, 8.7
Change-Id: I76bc60d9ac94eb1fe510bfe324cf49c0ed3bf896
Reviewed-on: https://review.typo3.org/54859
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Use $pathsToProvideInTestInstance in functional import tests 62/54862/3
Oliver Hader [Wed, 29 Nov 2017 12:58:11 +0000 (13:58 +0100)]
[TASK] Use $pathsToProvideInTestInstance in functional import tests

$pathsToProvideInTestInstance offers the possibility to use real
duplicates instead of linked resources in the filesystem - especially
in scenarios when files shall be modified inside a testing instance this
is the better approach and avoid side-effects during test execution.

Resolves: #83163
Releases: master, 8.7
Change-Id: I5e5825d2f999401533afffdf9c6e8d83ac55c94e
Reviewed-on: https://review.typo3.org/54862
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Ignore translations from other workspaces 30/53330/4
Markus Goldbach [Mon, 26 Jun 2017 11:42:17 +0000 (13:42 +0200)]
[BUGFIX] Ignore translations from other workspaces

Ignore translations of content elements (tt_content) which are created in
other workspace, so it is able to create a new/other translation in
another workspace even inside the live workspace

Change-Id: Ifef673b8677ae81f238068ed3a0bfdd1ca8e7932
Resolves: #81691
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53330
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[FEATURE] URL validator for Extbase 92/52092/15
Roland Golla [Sun, 19 Mar 2017 14:42:39 +0000 (15:42 +0100)]
[FEATURE] URL validator for Extbase

Add a new Extbase validator to check if a value is a valid URL.

Change-Id: Ic4ce6ee0f8a38f082e869c094ae6013493d7fb96
Resolves: #80342
Releases: master
Reviewed-on: https://review.typo3.org/52092
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[BUGFIX] Determine Chinese simplified Han "Accept-Language" header 56/51056/13
DavidsWONG [Thu, 29 Dec 2016 09:02:30 +0000 (10:02 +0100)]
[BUGFIX] Determine Chinese simplified Han "Accept-Language" header

Internet Explorer (IE11 & Edge) changed the submitted HTTP header
for "Accept-Language" from "zh-cn" to "zh-hans-cn". In order to
determine the Chinese language correctly, this value is added.

Releases: master, 8.7
Resolves: #81858
Change-Id: I477f88950313aa9bf0aeabbf6603bd15247a52ba
Reviewed-on: https://review.typo3.org/51056
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] System information: set error filter in link to log 05/48005/3
Felix Althaus [Tue, 3 May 2016 21:48:17 +0000 (23:48 +0200)]
[BUGFIX] System information: set error filter in link to log

The link in system information menu "We have found 2 errors.
Please check your system log" will now set the appropriate filter in log
to only show errors. Before this patch user‘s last filter state was
spawned. This could result in errors not even being displayed at all.

Resolves: #76009
Releases: master
Change-Id: Id90ac9950ff71cd1fb5db1724590cf939fc22823
Reviewed-on: https://review.typo3.org/48005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Tested-by: Sebastian Hofer <sebastian.hofer@marit.ag>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
20 months ago[FEATURE] Add support to native SQL time column type 50/52250/23
Eric Chavaillaz [Wed, 29 Mar 2017 14:47:42 +0000 (16:47 +0200)]
[FEATURE] Add support to native SQL time column type

This patch introduce a new key "time" to the TCA property
"dbType" to allow using native SQL time column type.

Resolves: #80557
Releases: master
Change-Id: Id03045ccf219a9a7e9d851b2f4501bed60ab4ea0
Reviewed-on: https://review.typo3.org/52250
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[BUGFIX] Ensure all sys_file_metadata TCA columns have a config section 48/54848/7
Benni Mack [Wed, 29 Nov 2017 09:22:17 +0000 (10:22 +0100)]
[BUGFIX] Ensure all sys_file_metadata TCA columns have a config section

The main issue is that the core ships a TCA column without a config section.

If EXT:filemetadata is available, this is overridden, so no issue here.

Further steps are (not scope of this patch) would be a TCA migration checker
to ensure that all TCA columns have a config section.

Resolves: #73076
Related: #77619
Related: #83152
Releases: master, 8.7
Change-Id: I3454780f1122ee5f4ef2bd65b19a9699daa73f33
Reviewed-on: https://review.typo3.org/54848
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[BUGFIX] Preview information should not conflict with frontend layout 53/54853/2
Benjamin Kott [Wed, 29 Nov 2017 11:05:02 +0000 (12:05 +0100)]
[BUGFIX] Preview information should not conflict with frontend layout

The preview information badge was reworked and now has a fixed
always visible position. Clicks on the preview badge are now prevended
and passed through to the underlaying/covered elements.

Resolves: #83158
Releases: master, 8.7
Change-Id: Ie71420e5185e42b850ac3bb11d8eb4edd26bb4ad
Reviewed-on: https://review.typo3.org/54853
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[TASK] Remove unused method isLocalizationEnabled 51/54851/2
Susanne Moog [Wed, 29 Nov 2017 10:53:52 +0000 (11:53 +0100)]
[TASK] Remove unused method isLocalizationEnabled

Change-Id: Ib7fd53d28dfd08ba8cc81b14e854812981db268f
Resolves: #83156
Releases: master
Reviewed-on: https://review.typo3.org/54851
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Prevent catchable error during workspace publishing 14/49614/4
Benni Mack [Wed, 29 Nov 2017 09:50:58 +0000 (10:50 +0100)]
[BUGFIX] Prevent catchable error during workspace publishing

When publishing a workspace, incorrect TCA might lead to a catchable
fatal error. This happened, when TCA for a field did not contain a
config-entry.

Resolves: #77619
Releases: master, 8.7, 7.6
Change-Id: I81a3b727320ee984908c964d0729551c4c264f8d
Reviewed-on: https://review.typo3.org/49614
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[TASK] Port TYPO3.LLL usages to TYPO3.lang 36/54836/3
Pawel Cieslik [Tue, 28 Nov 2017 16:23:17 +0000 (17:23 +0100)]
[TASK] Port TYPO3.LLL usages to TYPO3.lang

TYPO3 core uses new JS api for fetching language labels - TYPO3.lang.

Resolves: #83142
Releases: master
Change-Id: I690b667b27d1152556b147e7198260fae018c62b
Reviewed-on: https://review.typo3.org/54836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
20 months ago[BUGFIX] Allow to upload online media via file list 47/54847/4
Benni Mack [Wed, 29 Nov 2017 08:48:00 +0000 (09:48 +0100)]
[BUGFIX] Allow to upload online media via file list

It was not possible due to a form name mixup to add online media files
via the FileList in TYPO3 v9 anymore.

Related: #82436
Related: #81763
Resolves: #83151
Releases: master
Change-Id: Ica0ed049f685bf20b98f0a599adf61ec3874017a
Reviewed-on: https://review.typo3.org/54847
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Remove hard-coded l10n_parent fields for pages 64/54664/11
Benni Mack [Thu, 16 Nov 2017 14:08:42 +0000 (15:08 +0100)]
[TASK] Remove hard-coded l10n_parent fields for pages

Due to the change of the pages_language_overlay migration, a lot
of hard-coded "l10n_parent" and "sys_language_uid" fields for
pages have been introduced.

This should be changed into a common function in DataHandler
and the TCA option should be used instead.

Resolves: #83013
Releases: master
Change-Id: I43a33aac1015436109d1ca7b3ea200c78d2a2fb9
Reviewed-on: https://review.typo3.org/54664
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[!!!][TASK] Remove BE/fileExtensions/webspace 34/54634/11
Benni Mack [Tue, 14 Nov 2017 06:47:14 +0000 (07:47 +0100)]
[!!!][TASK] Remove BE/fileExtensions/webspace

The option $TYPO3_CONF_VARS[BE][fileExtensions][webspace][*]
is removed.

It was only used in some specific cases, whereas fileDenyPattern usage
is more consistently done and replaces this setting.

Resolves: #83081
Releases: master
Change-Id: I1327ad000c08d8619366c03838b01261f91fa945
Reviewed-on: https://review.typo3.org/54634
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[!!!][TASK] Remove stdWrap options space, spaceBefore, spaceAfter 02/54802/6
Georg Ringer [Mon, 27 Nov 2017 19:24:41 +0000 (20:24 +0100)]
[!!!][TASK] Remove stdWrap options space, spaceBefore, spaceAfter

The stdWrap options 'space', 'spaceBefore', 'spaceAfter'
are rarely used and should be better done completely by CSS.

Resolves: #83123
Releases: master
Change-Id: Ic3ed819e64e84f57f77fde1ff72404b78fd74009
Reviewed-on: https://review.typo3.org/54802
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Separately extract @validate annotations 38/54838/3
Alexander Schnitzler [Tue, 28 Nov 2017 18:01:10 +0000 (19:01 +0100)]
[TASK] Separately extract @validate annotations

Separately exctracting the @validate annotations
makes resolving these annotations more testable.

Also this allows to deprecate the usage of @validate
in favor of a doctrine annotation.

Releases: master
Resolves: #83143
Change-Id: I4dfd93b58e08cd5c458abebee36e82e9ce03ad47
Reviewed-on: https://review.typo3.org/54838
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Add missing delete button for Documentation 17/54817/12
Łukasz Uznański [Tue, 28 Nov 2017 09:22:28 +0000 (10:22 +0100)]
[TASK] Add missing delete button for Documentation

Add a  missing delete button within the Documentation module. Right now,
a user can't delete previously downloaded documentation.

Resolves: #80575
Releases: master, 8.7
Change-Id: I9077270c66ec225f1eb7a26e505da0d98d5f7f0e
Reviewed-on: https://review.typo3.org/54817
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Hint for 'Check for broken extensions' if install tool crashes 59/54559/5
Christian Kuhn [Tue, 28 Nov 2017 17:55:34 +0000 (18:55 +0100)]
[BUGFIX] Hint for 'Check for broken extensions' if install tool crashes

If the install tool crashes in cards that load ext_* files from extensions,
it currently clears html body and only renders a message "Something went wrong".

This will later become a recovery view which can analyze where and how the
error happened to show the user good option on how to resurrect the instance.

For now, the message is extended a bit linking to the "Upgrade" menu saying
one should use the "Check for broken extensions". This way - until a bigger
solution evolved - we at least have a link to click on, and the user does not
need to fiddle with the url bar of the browser. This is especially useful
in install tool standalone mode where the whole content including the left
main menu is currently substituted by the error message.

Change-Id: I8e1c450949d9f00f8c2e0e1e95a847979973c124
Resolves: #82922
Releases: master
Reviewed-on: https://review.typo3.org/54559
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[BUGFIX] Disable column sys_file_reference.sorting 42/54342/12
Stephan Großberndt [Mon, 9 Oct 2017 16:48:39 +0000 (18:48 +0200)]
[BUGFIX] Disable column sys_file_reference.sorting

Disable the column sys_file_reference.sorting by its according TCA
definition as it is not useful and leads to severe performance issues
adding new references when there are already many references.

Releases: master, 8.7
Resolves: #80800
Change-Id: I7b34a1be7efe3cf4818b43919389d9c815e74ec6
Reviewed-on: https://review.typo3.org/54342
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] UpgradeWizard check for utf8 is wrong 35/54835/2
Susanne Moog [Tue, 28 Nov 2017 16:06:36 +0000 (17:06 +0100)]
[BUGFIX] UpgradeWizard check for utf8 is wrong

The upgrade wizard checking for utf-8 sets a
variable called charsetOk which worked
differently on MySQL compared to other DBMS.

On MySQL it contained true if the charset was
not OK, in all other cases it was true if ok.

This is now consistently handled according to
the variable name.

Change-Id: Iee347b6c2469ad9a33e9bd4109d361dc337a63a0
Resolves: #83141
Releases: master
Reviewed-on: https://review.typo3.org/54835
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[FEATURE] Add support for addQueryString to TypolinkViewHelper 98/54798/10
Sebastian Hofer [Mon, 27 Nov 2017 18:08:22 +0000 (19:08 +0100)]
[FEATURE] Add support for addQueryString to TypolinkViewHelper

This enables {Link,Uri}/TypoLinkViewHelper to support addQueryString,
addQueryString.method and addQueryString.exclude.

Resolves: #81358
Releases: master
Change-Id: I96f0a2035997513eced06ba543a718b164b9da63
Reviewed-on: https://review.typo3.org/54798
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
20 months ago[TASK] Install Tool: Display a warning if PHP fileinfo extension is not loaded 23/54823/9
Jonathan IROULIN [Tue, 28 Nov 2017 10:18:25 +0000 (11:18 +0100)]
[TASK] Install Tool: Display a warning if PHP fileinfo extension is not loaded

Show a warning message during the installation process if
the PHP fileinfo extension is not loaded.
It only displays a warning because the fileinfo extension is just
a suggestions and not required.
The fileinfo extension is useful to extract file metadata.

Resolves: #78702
Releases: master, 8.7
Change-Id: Iea0fa087d96d5615056308b7b2fef082b9154a2d
Reviewed-on: https://review.typo3.org/54823
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[BUGFIX] Streamline page translation localization modes for enableFields 51/54751/4
Benni Mack [Fri, 24 Nov 2017 22:12:54 +0000 (23:12 +0100)]
[BUGFIX] Streamline page translation localization modes for enableFields

During the migration of page translations from pages_language_overlay
some fields have been migrated to a localization mode.

hidden, starttime and endtime can currently not be configured on a
per language-basis, which was possible before.

The fields are now settable on a per-language basis.

Resolves: #83082
Releases: master
Change-Id: Ibd401c38f3f8f8dfaaab9e459e1df284ecb625ea
Reviewed-on: https://review.typo3.org/54751
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months agoRevert "[BUGFIX] Fix language of placeholder for relations" 26/54826/4
Christian Kuhn [Tue, 28 Nov 2017 11:06:00 +0000 (12:06 +0100)]
Revert "[BUGFIX] Fix language of placeholder for relations"

This reverts commit 5be3ec134bf1186260e3172832e8c69dfd13913d.

Further issues popped up in the master patch.

Reverts: #75040
Releases: master
Change-Id: I8ed284060b9b8ef018f4097c772032e81e3e885b
Reviewed-on: https://review.typo3.org/54826
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Also show port when trustedHosts pattern mismatches 21/54821/6
Oliver Thiele [Tue, 28 Nov 2017 09:34:17 +0000 (10:34 +0100)]
[BUGFIX] Also show port when trustedHosts pattern mismatches

Add the port information to the error message when the
trustedHostsPattern mismatches. This is important as
the SERVER_NAME may match, but the SERVER_PORT might be
different from the default ports.

Releases: master, 8.7
Resolves: #83133
Change-Id: I8a25cc0bd2c9578b611986cea4bb7f270dff927b
Reviewed-on: https://review.typo3.org/54821
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>