Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Hide password hash for RsaInputField 95/51495/2
Georg Ringer [Wed, 1 Feb 2017 11:11:49 +0000 (12:11 +0100)]
[BUGFIX] Hide password hash for RsaInputField

If rsauth is used, the eval configuration does not
contain the setting 'password' and the password can always
be hidden.

Resolves: #79576
Releases: master
Change-Id: Idcc8df67400be1d3f54e948681104ff9ad2d009e
Reviewed-on: https://review.typo3.org/51495
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][TASK] EXT:form - Refactor fluid rendering 42/51442/13
Ralf Zimmermann [Thu, 26 Jan 2017 22:52:51 +0000 (23:52 +0100)]
[!!!][TASK] EXT:form - Refactor fluid rendering

This patch is a followup of issue #79439.

EXT:form uses "fluid" as the default rendering strategy.
Therefore, EXT:form has to work close with the concepts of fluid to
avoid current and future problems.
Until now, EXT:form tried to reuse a fluid view instance by
reconfiguring the instance on each nesting level, but fluid is not
intended for such a purpose.
Therefore, the templates have to be moved/ changed and some
configuration has to be changed.
The patch breaks EXT:form only for people who are using custom
configurations/ templates.

Resolves: #79464
Releases: master
Change-Id: I6346b888b47a52bcc995c7d4cd3acdc65a1396c8
Reviewed-on: https://review.typo3.org/51442
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Set TYPO3_DLOG constant in testing framework 04/51504/3
Markus Klein [Thu, 2 Feb 2017 00:18:04 +0000 (01:18 +0100)]
[BUGFIX] Set TYPO3_DLOG constant in testing framework

The constant is undefined currently and hence leads to useless calls
to the devLog facility.
Set this constant to false by default to avoid that.

Resolves: #79588
Releases: master
Change-Id: I22f9c3ddb564ccd86b763672120bd5991c97fb79
Reviewed-on: https://review.typo3.org/51504
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Fix dom path to select items and buttons 09/51509/2
Daniel Lorenz [Thu, 2 Feb 2017 11:43:21 +0000 (12:43 +0100)]
[BUGFIX] Fix dom path to select items and buttons

Resolves: #79600
Releases: master
Change-Id: Ife6221668159ea02e8980ab449d394c1a8fb3df3
Reviewed-on: https://review.typo3.org/51509
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Allow long cookie names 83/51483/2
Marco Huber [Tue, 31 Jan 2017 10:29:36 +0000 (11:29 +0100)]
[BUGFIX] Allow long cookie names

With this patch cookie names longer than 32 chars are possible.

Resolves: #79566
Releases: master, 7.6
Change-Id: I5132defab6e7524ed4aaf48ea29e44da40aee516
Reviewed-on: https://review.typo3.org/51483
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Fix CSH on Info -> Pagetree overview 03/51503/2
Tymoteusz Motylewski [Wed, 1 Feb 2017 19:10:18 +0000 (20:10 +0100)]
[BUGFIX] Fix CSH on Info -> Pagetree overview

Fixes undefined variable.

Releases: master
Resolves: #79586
Change-Id: I9873775cabfd274c03353b1022f325ee2636269f
Reviewed-on: https://review.typo3.org/51503
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Remove empty option tag in fluid select viewhelper 88/51388/8
Marcus Schwemer [Sun, 22 Jan 2017 21:24:39 +0000 (22:24 +0100)]
[BUGFIX] Remove empty option tag in fluid select viewhelper

Currently the select viewhelper produces an empty option tag, if no
argument "option" is provided. This is not needed.

Resolves: #79274
Releases: master
Change-Id: Ie3a78f241cba19875c866bbc44c48d58603a1e91
Reviewed-on: https://review.typo3.org/51388
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[FEATURE] Implement configuration for CKEditor 19/50919/20
Benni Mack [Tue, 17 Jan 2017 20:38:07 +0000 (21:38 +0100)]
[FEATURE] Implement configuration for CKEditor

The main problem with the current RTE configuration relies in the fact
that it is *only* configurable via pageTS.

CKEditor can now be configured via YAML, but the configuration preset
can be overriden via pageTS.

Additionally, the CKEditor Form Element is cleaned up.

A different preset can be used via PageTS config:
- RTE.default.preset = minimal
- RTE.config.tt_content.bodytext.preset = full

Once included, the next features will be
- a configuration backend module for ckeditor
- Make sure to re-add the feature for RTE.anchorClasses
- Check the languages of CKeditor that they are in line with the TYPO3
languages (possibility to add others)
- image handling
- table handling

Resolves: #78917
Releases: master
Change-Id: Ia222b73072b9e3fdb3a120d0be0a24a913552126
Reviewed-on: https://review.typo3.org/50919
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Use strict comparison for strings 62/51462/6
Georg Ringer [Mon, 30 Jan 2017 06:42:37 +0000 (07:42 +0100)]
[TASK] Use strict comparison for strings

Change string comparison for string checks. Checks which could lead
to false positives like comparing with '0' or '' are excluded.
RegEx used to find affected places: (?<=\s)((?:!|=)=)(?=[^=]'[^0-9'\n]+')

Resolves: #79540
Resolves: master
Change-Id: I9a04bdd9e0e78cc97036560709bb505097bf48f9
Reviewed-on: https://review.typo3.org/51462
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Remove additional lines in textareas of formengine 90/51490/2
Georg Ringer [Tue, 31 Jan 2017 19:15:20 +0000 (20:15 +0100)]
[BUGFIX] Remove additional lines in textareas of formengine

Remove additional lines around the actual content of a
textarea.

Resolves: #79573
Releases: master
Change-Id: I636afb0ec63d34d4a209caeaa1369bc65727665d
Reviewed-on: https://review.typo3.org/51490
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[BUGFIX] Temporarily skip repeatedly failing tests 87/51487/2
Mona Muzaffar [Tue, 31 Jan 2017 11:35:15 +0000 (12:35 +0100)]
[BUGFIX] Temporarily skip repeatedly failing tests

Resolves: #79552
Releases: master
Change-Id: I3da3eafd095a00062e01e4ab24d6c9ebf41c3a2e
Reviewed-on: https://review.typo3.org/51487
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Clear search field in Install Tool with ESC 84/51484/6
Georg Ringer [Tue, 31 Jan 2017 10:33:30 +0000 (11:33 +0100)]
[TASK] Clear search field in Install Tool with ESC

As the search in the Install Tool > All configuration can be
triggered by using CTRL + f, it should also listen on the
ESC key to clear the search again.

Resolves: #79567
Releases: master, 7.6
Change-Id: I9a304bb455153429f99354a4ef684326b1baa612
Reviewed-on: https://review.typo3.org/51484
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Marco Huber <mail@marco-huber.de>
Tested-by: Marco Huber <mail@marco-huber.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[TASK] Show description of tests in Install Tool at start 78/51478/3
Georg Ringer [Mon, 30 Jan 2017 20:55:48 +0000 (21:55 +0100)]
[TASK] Show description of tests in Install Tool at start

The description of the following tests should be shown right away
instead after the test:

- Combining images
- Converting images
- Gdlib
- Scaling images
- Write gif & png

Furthermore the tag is used to highlight code.

Resolves: #79561
Releases: master
Change-Id: I90d1d3ff9f14cc193d4f67124e7a804085586106
Reviewed-on: https://review.typo3.org/51478
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Use normalized jpg_quality in GraphicalFunctions 00/51400/3
Sascha Egerer [Mon, 23 Jan 2017 13:47:20 +0000 (14:47 +0100)]
[TASK] Use normalized jpg_quality in GraphicalFunctions

If the setting 'processor_effects' is set the already normalized
value of jpg_quality should be used.

Change-Id: Idcebd8dfeadbc0c85e756281ed3ba05f8f9b965c
Resolves: #79428
Releases: master
Reviewed-on: https://review.typo3.org/51400
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Add Index.rst to master folder 70/51470/2
Philipp Gampe [Mon, 30 Jan 2017 14:02:19 +0000 (15:02 +0100)]
[TASK] Add Index.rst to master folder

Resolves: #79555
Releases: master
Change-Id: I1a7523dbc87907cba754c405cc4bbf9050a51255
Reviewed-on: https://review.typo3.org/51470
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Temporaryly skip tests repeatedly failing 68/51468/5
Mona Muzaffar [Mon, 30 Jan 2017 12:10:16 +0000 (13:10 +0100)]
[BUGFIX] Temporaryly skip tests repeatedly failing

Change-Id: I7d2492782ff1a7203beafc37a1b4457bf65735a2
Resolves: #79552
Releases: master
Reviewed-on: https://review.typo3.org/51468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Link to crawler extension docs 63/51463/3
Christian Weiske [Mon, 30 Jan 2017 09:50:55 +0000 (10:50 +0100)]
[TASK] Link to crawler extension docs

Change-Id: Ie1e780af0b15c9785225bd8a147b08458b6a3b06
Resolves: #79541
Releases: master
Reviewed-on: https://review.typo3.org/51463
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Use “error” icon for validation failures in FormEngine 60/51460/3
Andreas Fernandez [Sun, 29 Jan 2017 20:38:16 +0000 (21:38 +0100)]
[TASK] Use “error” icon for validation failures in FormEngine

Currently, a warning sign is rendered next to field labels whose
validation failed. Failed validations are errors and thus another icon
should be rendered. With this patch, a red circle containing an
exclamation mark is rendered. It’s the same icon as in the tabs holding
affected fields.

Resolves: #79537
Releases: master
Change-Id: I01b783c36dfac551bf6e9f0cb8fc703290c3eb72
Reviewed-on: https://review.typo3.org/51460
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix wrong condition in method checkValueForText 65/51465/3
Dominique Kreemers [Mon, 30 Jan 2017 10:48:41 +0000 (11:48 +0100)]
[BUGFIX] Fix wrong condition in method checkValueForText

This makes "eval" processing working again for text fields.

Resolves: #79545
Related: #79341
Releases: master
Change-Id: Icda2f32a41a95afa33c87be9ed60c5b5ed47f275
Reviewed-on: https://review.typo3.org/51465
Reviewed-by: Marcus Schwemer <ms@schwemer.de>
Tested-by: Marcus Schwemer <ms@schwemer.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[FOLLOWUP][TASK] Code cleanup for RteHtmlParser 55/51455/2
Frans Saris [Sun, 29 Jan 2017 15:56:29 +0000 (16:56 +0100)]
[FOLLOWUP][TASK] Code cleanup for RteHtmlParser

Resolves: #79280
Releases: master
Change-Id: I1d3815cef36d624c910d40eb6d63a3eba4f3f53d
Reviewed-on: https://review.typo3.org/51455
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Improve LogEntries partial performance 64/51464/2
Claus Due [Mon, 30 Jan 2017 10:06:56 +0000 (11:06 +0100)]
[TASK] Improve LogEntries partial performance

This patch avoids `f:switch` in the partial template,
since this ViewHelper is not compilable in the
version provided as override from TYPO3 CMS.

The patch also adds the CompileWithRenderStatic
trait to a ViewHelper used frequently in that partial.

Change-Id: I768e43e7c70a17fef04c28774169d4b3badb310b
Resolves: #79542
Releases: master
Reviewed-on: https://review.typo3.org/51464
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Remove ses_hashlock from acceptance test fixtures 53/51453/3
Andreas Fernandez [Sun, 29 Jan 2017 11:11:38 +0000 (12:11 +0100)]
[BUGFIX] Remove ses_hashlock from acceptance test fixtures

With the merge of #79513 the fields `ses_hashlock` were removed from
be_users and fe_users. The usages within the acceptance test fixtures
were not removed, causing the acceptance test to fail.

This patch removes the field usages in the fixtures.

Resolves: #79526
Related: #79513
Releases: master
Change-Id: Ibf139599ac0b71f510e322e011d461c4df400664
Reviewed-on: https://review.typo3.org/51453
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Do not strip sub-paths from emulated controller name 51/51451/4
Claus Due [Sat, 28 Jan 2017 12:02:52 +0000 (13:02 +0100)]
[BUGFIX] Do not strip sub-paths from emulated controller name

This patch solves a special case in the integration with
Fluid. Fluid itself allows an emulated controller action
to be used, which contains a sub-path (controller name
supports this as well). However, the RenderingContext
forced use of pathinfo() on the passed path, which caused
sub-paths to be removed. The patch switches from
pathinfo() to substr() to preserve any slashes in such
controller action names.

Only direct usage of Fluid's API is affected and no
current compatibility is broken by the patch.

Change-Id: I7e1c27d55a44b957aadbace571e50afd7614d8a0
Resolves: #79519
Releases: master
Reviewed-on: https://review.typo3.org/51451
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[CLEANUP] Simplify updating of timestamp in writeForeignField 76/50976/3
Thomas Hohn [Thu, 15 Dec 2016 10:45:22 +0000 (11:45 +0100)]
[CLEANUP] Simplify updating of timestamp in writeForeignField

There is no need to check the record we are updating -
since we update it anyway, update timestamp too and
save both a call to getRecord and a loop through fields,
casting and checking each field value comparing to DB.

Change-Id: Ic807030c5cea83d36e543ed0f75cf980c3872d1e
Releases: master, 7.6
Resolves: #79004
Reviewed-on: https://review.typo3.org/50976
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] EXT:linkvalidator Keep field content when saving new task 11/51011/2
Michael Oehlhof [Tue, 20 Dec 2016 22:43:29 +0000 (23:43 +0100)]
[BUGFIX] EXT:linkvalidator Keep field content when saving new task

When saving a new linkvalidator task in the scheduler and the validation
failed, now the previous input is kept in the external fields.

Resolves: #79056
Releases: master
Change-Id: Ib629f47890f2972de8c8bfa28644ef933357c374
Reviewed-on: https://review.typo3.org/51011
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Remove alerts of locked records 87/51387/2
Georg Ringer [Sun, 22 Jan 2017 20:36:30 +0000 (21:36 +0100)]
[TASK] Remove alerts of locked records

Use tooltips instead of ancient JavaScript alerts for locked
records.

Resolves: #79422
Releases: master
Change-Id: Ia9911f8eaad1c55c2af14e366af13e0e9b7b21df
Reviewed-on: https://review.typo3.org/51387
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Change EM composer mode message to info level 59/51059/2
Benjamin Franzke [Thu, 29 Dec 2016 12:10:17 +0000 (13:10 +0100)]
[BUGFIX] Change EM composer mode message to info level

As https://review.typo3.org/#/c/44025/ enabled extensionmanager
offline mode for composer installations, the composer mode message
should no longer be a warning but an info.

Releases: master, 7.6
Fixes: #79107
Change-Id: Ic9fcb134c113172de504833ed81f7a46a0ba4e2c
Reviewed-on: https://review.typo3.org/51059
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Avoid version overlay if EXT:version is not loaded 52/50952/5
Claus Due [Tue, 13 Dec 2016 16:31:36 +0000 (17:31 +0100)]
[BUGFIX] Avoid version overlay if EXT:version is not loaded

PlainDataResolver will do semi-expensive operations for
workspaces-enabled tables even if EXT:version (and
therefore EXT:workspaces) is not loaded.

Doing a cheap check can prevent calling two such
operations and saves SQL queries and memory.

Change-Id: I6062538c3c158352b7be5748d407bbe2aad3a641
Resolves: #78982
Releases: master
Reviewed-on: https://review.typo3.org/50952
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Consolidate code duplications in form data groups 43/51443/3
Artus Kolanowski [Wed, 25 Jan 2017 00:33:00 +0000 (01:33 +0100)]
[TASK] Consolidate code duplications in form data groups

Introduce a new class `OrderedProviderList` which calls providers
with dependencies given by setter.

Resolves: #79512
Releases: master
Change-Id: Icf97e2e6fa5ed88d7b76b7628bb4e9790b615a38
Reviewed-on: https://review.typo3.org/51443
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Extbase: Fix counting objects on joined tables 20/51320/3
Morton Jonuschat [Sun, 15 Jan 2017 21:21:44 +0000 (13:21 -0800)]
[BUGFIX] Extbase: Fix counting objects on joined tables

While it's normally fine to replace DISTINCT with GROUP BY when counting
objects this results in a different resultset. The GROUP BY statement will
have n rows with the count per grouped combination while the DISTINCT
based query will have one row with the count of unique combinations.

Use a COUNT(DISTINCT uid) to get the expected result.
DISTINCT is supported on MySQL, PostgreSQL, Oracle and MSSQL Server.

Change-Id: If3193113529f1bb01693dba39abccfe349f169b1
Resolves: #79330
Releases: master
Reviewed-on: https://review.typo3.org/51320
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Move page module function QuickEdit to EXT:compatibility7 40/51340/10
Artus Kolanowski [Tue, 17 Jan 2017 23:46:33 +0000 (00:46 +0100)]
[!!!][TASK] Move page module function QuickEdit to EXT:compatibility7

To follow the concept of backend apps and provide a lean core by
removing a rarely used feature, which benefit is pretty low for
the editor.

Resolves: #79364
Releases: master
Change-Id: Ic1796aa4f23507ac45b52155c66da02cffc88b3b
Reviewed-on: https://review.typo3.org/51340
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] EXT:Scheduler: Run manually executed tasks on next cron-run 07/45807/16
Michael Oehlhof [Sun, 10 Jan 2016 19:24:47 +0000 (20:24 +0100)]
[FEATURE] EXT:Scheduler: Run manually executed tasks on next cron-run

Added a feature to the scheduler to mark tasks to be run by
next cron job.

Resolves: #45537
Releases: master
Change-Id: I72d0e693821630a0be655159b53c168b1973d886
Reviewed-on: https://review.typo3.org/45807
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Deprecate the field select_key of tt_content 34/49934/8
Georg Ringer [Tue, 13 Sep 2016 18:12:06 +0000 (20:12 +0200)]
[!!!][TASK] Deprecate the field select_key of tt_content

The field `select_key` is not used by the core and
is moved to the EXT:compatibility7.

Resolves: #77934
Releases: master
Change-Id: Ied7fa722c1bccb314fd02229da407613fbce7dfe
Reviewed-on: https://review.typo3.org/49934
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Remove lockHashKeyWords functionality 37/51437/4
Benni Mack [Thu, 26 Jan 2017 16:36:46 +0000 (17:36 +0100)]
[!!!][TASK] Remove lockHashKeyWords functionality

The TYPO3 Core used the "useragent" to create a hashbase
by default to harden the session hijacking functionality.

This very very old feature adds a tiny bit of security on top,
however it has the drawback that users get logged out (of BE or FE)
if their browser updates (due to evergreen browsers or security
updates as the user agent string changes). This is very inconvenient
for websites that use a very long session time for logged in users
in the frontend (or backend) when using TYPO3 as a platform or
application.

It was originally concepted so it could be extended but there is no
hook to do so, and extending all classes does not really make a lot
of sense in the hierarchical PHP class structure.

Resolves: #79513
Releases: master
Change-Id: I78e58210da80c7c1544a644e8e10bc1f667b5bf1
Reviewed-on: https://review.typo3.org/51437
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[FEATURE] Add signal to exclude tables from ReferenceIndex 62/51362/11
Thomas Hohn [Thu, 19 Jan 2017 13:38:07 +0000 (14:38 +0100)]
[FEATURE] Add signal to exclude tables from ReferenceIndex

A new signal is introduced to allow the exclusion of tables from the
ReferenceIndex. The checks whether tables or columns should be excluded
are extracted to methods.

Fixes: #79387
Releases: master
Change-Id: I5ef558bc1a1c63553e8a1dc193167d068f235487
Reviewed-on: https://review.typo3.org/51362
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Only perform reindex if data has indeed changed 18/51018/2
Thomas Hohn [Tue, 13 Dec 2016 20:46:38 +0000 (21:46 +0100)]
[BUGFIX] Only perform reindex if data has indeed changed

Change-Id: I889264f34599be556e16b3d37825a3761b681e70
Resolves: #79068
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51018
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Persist traversable domain objects via identifier 87/51287/3
Mathias Brodala [Thu, 12 Jan 2017 13:03:04 +0000 (14:03 +0100)]
[BUGFIX] Persist traversable domain objects via identifier

Objects implementing the DomainObjectInterface must always be
persisted using their identifier, even if they implement the
Traversable interface.

Change-Id: Iccb53d6e7ded9b6b5300e111e8503641b10615f4
Resolves: #79294
Related: #57255
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51287
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Add .php_cs.cache to .gitignore 41/51441/4
Georg Ringer [Thu, 26 Jan 2017 20:24:52 +0000 (21:24 +0100)]
[TASK] Add .php_cs.cache to .gitignore

The php-cs fixer creates a cache file which
should not be commited. Add it to the .gitgnore to avoid
any mistakes.

Resolves: #79510
Releases: master, 7.6
Change-Id: Ia85f825416ad767a07d280de35a18c318e1a5133
Reviewed-on: https://review.typo3.org/51441
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[!!!][FEATURE] FormEngine element level refactoring 51/51151/74
Christian Kuhn [Thu, 5 Jan 2017 17:08:27 +0000 (18:08 +0100)]
[!!!][FEATURE] FormEngine element level refactoring

The patch introduces a new API on FormEngine element level
that substitutes the old "wizards" / renderWizard() API
with a more powerful system.

Single wizards are now split into one of three categories:
* An informational wizard
* A control button / icon
* A true wizard with additonal functionality

Method renderWizards() is still called in elements for compatibility
reasons if people added own scrip/popup/userFunc wizards, but all
core wizards are migrated.

The patch significantly cleans the HTML of single elements, especially
HTML stuff that was added by the SingleFieldContainer is now put down
to single elements, while main HTML wraps formerly done by renderWizards()
is fetched "up" to single elements. This gives single elements full
control about the main HTML it is producing, which is a must have
preparation in order to further advance in this area and to switch
single elements to fluid rendering in one of the next steps.

The patch brings a pretty huge list of TCA changes and
simplifications, all TCA changes are supported by TCA migration,
so existing extensions should benefit out of the box and just
get deprecations logged.

Change-Id: I45083e14e45bbf40c06267b51c9d0b7c15e2f7ab
Resolves: #79440
Resolves: #70032
Releases: master
Reviewed-on: https://review.typo3.org/51151
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Functional test for VariableFrontend cache type 94/51394/3
Manuel Selbach [Sun, 22 Jan 2017 06:13:44 +0000 (22:13 -0800)]
[TASK] Functional test for VariableFrontend cache type

Add a functional test to verify that serialized PHP objects
can be successfully stored in the database without having
encoding/escaping problems.

Resolves: #79452
Releases: master
Change-Id: I97d586cb8a50e571d99ff8b7fc463c0a83e15f36
Reviewed-on: https://review.typo3.org/51394
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] EXT:form - Add CE preview for form plugins 22/51422/5
Ralf Zimmermann [Wed, 25 Jan 2017 10:58:06 +0000 (11:58 +0100)]
[TASK] EXT:form - Add CE preview for form plugins

Render the form label or a placeholder text (if no form is selected)
within the page module.

Resolves: #78834
Releases: master
Change-Id: I5519ce8bec7ae077d22328ff0ad70b29aa1b5af7
Reviewed-on: https://review.typo3.org/51422
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:form - Optimize frontend templates 26/51426/2
Andreas Steiger [Wed, 25 Jan 2017 15:40:03 +0000 (16:40 +0100)]
[TASK] EXT:form - Optimize frontend templates

* add attribute role="alert" to error hints
* streamline bootstrap 3 error classes
* add attribute formnovalidate to previous button of multistep form
* remove fieldset wrap from element type 'PAGE'

Resolves: #69974
Releases: master
Change-Id: I66336879bed0f94752482404c3ed7cfa7028046d
Reviewed-on: https://review.typo3.org/51426
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] EXT:form - Add form settings button to module header 25/51425/3
Ralf Zimmermann [Wed, 25 Jan 2017 15:10:42 +0000 (16:10 +0100)]
[FEATURE] EXT:form - Add form settings button to module header

Adds a new button into the form editor module header.
Clicking on this buttons shows the form settings within the inspector.

Resolves: #79467
Releases: master
Change-Id: I767c71fcf65ca5bd58b2b530a60fce1caf75e3c9
Reviewed-on: https://review.typo3.org/51425
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:form - parse finisher values only if string 81/51381/4
Ralf Zimmermann [Sun, 22 Jan 2017 16:40:24 +0000 (17:40 +0100)]
[BUGFIX] EXT:form - parse finisher values only if string

Parse finisher option values only if the referenced formelement value
is a string.

Resolves: #79412
Releases: master
Change-Id: Ie379a396473c31907d52c8aa096168fed803510b
Reviewed-on: https://review.typo3.org/51381
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Improve constant editor 86/51386/3
Georg Ringer [Sun, 22 Jan 2017 20:15:24 +0000 (21:15 +0100)]
[TASK] Improve constant editor

- Skip length check of header
- Use type "number" for integer types
- Apply min & max attributes if available

Resolves: #79421
Releases: master
Change-Id: I508000547214d3d3ca18a8e311ce68dd03dea09b
Reviewed-on: https://review.typo3.org/51386
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mattias Nilsson <tollepjaer@gmail.com>
Tested-by: Mattias Nilsson <tollepjaer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix SQL error in createEntryData 97/51397/5
Thomas Hohn [Mon, 23 Jan 2017 08:35:45 +0000 (09:35 +0100)]
[BUGFIX] Fix SQL error in createEntryData

The database field definition for ref_string is limited to varchar(200)
and can cause an SQL error when bigger strings are inserted.
In addition it makes sense to add a mb_substr() to avoid an error if
longer strings are inserted.

Fixes: #79425
Releases: master
Change-Id: I1f1e672f610f830ad5e02509cb1f0529c9cbeb41
Reviewed-on: https://review.typo3.org/51397
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Access check for delete pages expects array of integers 42/51342/4
Mona Muzaffar [Wed, 18 Jan 2017 13:42:56 +0000 (14:42 +0100)]
[BUGFIX] Access check for delete pages expects array of integers

An error occurs in the createNamedParameter function
which expects an array but gets a string instead.

Change-Id: I393a6a87c912129ded28f677ca65c081fc4205e7
Resolves: #79309
Releases: master
Reviewed-on: https://review.typo3.org/51342
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup code of LocalizationController::process 49/51349/3
Manuel Selbach [Wed, 18 Jan 2017 20:12:16 +0000 (21:12 +0100)]
[TASK] Cleanup code of LocalizationController::process

Change-Id: I6db726bfff61c092309a971eb71e074c30cad046
Releases: master, 7.6
Resolves: #79378
Reviewed-on: https://review.typo3.org/51349
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Deprecate visibility for internal variables in Datahandler class 11/51411/6
Thomas Hohn [Tue, 24 Jan 2017 21:00:33 +0000 (22:00 +0100)]
[TASK] Deprecate visibility for internal variables in Datahandler class

This patch marks some internal cache variables in the
Datahandler as deprecated since their visibility should be
changed from public to protected or even be replaced
by a runtime cache. Since this can't be done before
TYPO3 v9 they are marked as deprecated in TYPO3 v8
as a preparation.

Fixes: #79441
Releases: master
Change-Id: I7d35792fb81e6f16b3b729a3841c1cfda109952f
Reviewed-on: https://review.typo3.org/51411
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Use subselect to update reference index 70/51370/8
Thomas Hohn [Fri, 20 Jan 2017 10:57:04 +0000 (11:57 +0100)]
[BUGFIX] Use subselect to update reference index

Switch updateIndex method to use a subselect based approach
to avoid errors due to huge parameter lists for manually
built NOT IN queries which could exceed the maximum query
length.

Add a warning if the table doesn't share a connection with
the reference index as it can not be updated automatically.

Resolves: #79397
Releases: master
Change-Id: I563dfe607b24ffe949ef5a0e9d2e62b2312ff8f0
Reviewed-on: https://review.typo3.org/51370
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Debugger output: split lines before escaping them 69/51369/2
Markus Klein [Fri, 20 Jan 2017 09:16:29 +0000 (10:16 +0100)]
[BUGFIX] Debugger output: split lines before escaping them

This fixes the issue that lines are wrapped within a HTML entity.

Resolves: #79398
Releases: master, 7.6
Change-Id: I0bf1722cb9792fea0f45421fe1f72e1932879002
Reviewed-on: https://review.typo3.org/51369
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Dominique Kreemers <dominique.kreemers@icloud.com>
Tested-by: Dominique Kreemers <dominique.kreemers@icloud.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup ActionService::getVersionedId 51/51351/3
Manuel Selbach [Wed, 18 Jan 2017 20:55:29 +0000 (21:55 +0100)]
[TASK] Cleanup ActionService::getVersionedId

Within the refactoring process the optional parameter $useDeleteClause was missed
to remove from the parameter list of the method, as it is not implemented in the body and
not used anywhere in the core.

Releases: master
Resolves: #79382
Change-Id: I4db104941b78f44573b0b1f51ad216ded93887bf
Reviewed-on: https://review.typo3.org/51351
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Add parameter types to database writes in functional tests 95/51395/3
Manuel Selbach [Sun, 22 Jan 2017 06:11:12 +0000 (22:11 -0800)]
[BUGFIX] Add parameter types to database writes in functional tests

When writing to database tables with BLOB type columns declare the field
type for the query parameters in functional tests. This is required for
databases that use a different encoding/transport protocol for BLOB
fields.

Resolves: #79453
Releases: master
Change-Id: I1371bb192abaec841be982a1b228cc6b7e6d1cbf
Reviewed-on: https://review.typo3.org/51395
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix title for expand button in workspace module 59/51359/4
Mona Muzaffar [Thu, 19 Jan 2017 11:17:57 +0000 (12:17 +0100)]
[BUGFIX] Fix title for expand button in workspace module

Change-Id: I6a17811dd5dbc5ed285b6040fcbe97e94b416b8b
Releases: master
Resolves: #79321
Reviewed-on: https://review.typo3.org/51359
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FEATURE] Add new ViewHelper f:variable via Fluid 2.2.0 98/51398/6
Claus Due [Mon, 23 Jan 2017 11:36:32 +0000 (12:36 +0100)]
[FEATURE] Add new ViewHelper f:variable via Fluid 2.2.0

A new Fluid ViewHelper, `f:variable`, has become available
in TYPO3 after raising the minimum required version of the
Fluid engine to 2.2.0.

Change-Id: I4f42030ef586e8d9a3d40c54c64137eb1969384d
Resolves: #79402
Releases: master
Reviewed-on: https://review.typo3.org/51398
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Adjust Cs-Fixer 2.0 hits 28/51428/2
Anja Leichsenring [Wed, 25 Jan 2017 17:37:09 +0000 (18:37 +0100)]
[TASK] Adjust Cs-Fixer 2.0 hits

With the update of cs-fixer to version 2.0, some checks
got minor changes in behaviour. The core follows now in
applying those suggested changes.

Resolves: #79469
Relates: #79361
Releases: master
Change-Id: I5d17b750231dcb386002b3e46b3a89c59eca2989
Reviewed-on: https://review.typo3.org/51428
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Fix broken TypeScript compiler setting 04/51404/4
Frank Naegler [Tue, 24 Jan 2017 08:46:54 +0000 (09:46 +0100)]
[BUGFIX] Fix broken TypeScript compiler setting

This patch adds a missing compilerOption to generate subfolder in the
build directory, which fix the copy to final destination problem.

Resolves: #79431
Releases: master
Change-Id: Ie756d47e12d2ff72aa6db397d87db311eed43b59
Reviewed-on: https://review.typo3.org/51404
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[FEATURE] EXT:form - Add element selector for text editors 24/51424/3
Ralf Zimmermann [Wed, 25 Jan 2017 14:59:36 +0000 (15:59 +0100)]
[FEATURE] EXT:form - Add element selector for text editors

Adds a new button to the text editors.
This splitbutton opens a list with available form elements.
If a form element is choosen, the form element identifier will be
inserted into the property text editor.

Resolves: #79442
Releases: master
Change-Id: If40114958311200348bde220f6cf62fb6365260b
Reviewed-on: https://review.typo3.org/51424
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Update php-cs-fixer to version 2.0 23/51423/5
Anja Leichsenring [Wed, 25 Jan 2017 12:35:02 +0000 (13:35 +0100)]
[TASK] Update php-cs-fixer to version 2.0

Change-Id: Ia32a61238bdf46c01a3856376c0a94d9d09339ee
Resolves: #79361
Releases: master
Reviewed-on: https://review.typo3.org/51423
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update phpunit to version 5.7.5 20/51420/3
Anja Leichsenring [Wed, 25 Jan 2017 09:11:55 +0000 (10:11 +0100)]
[TASK] Update phpunit to version 5.7.5

Change-Id: I118f4d6b9fd94fcaa0da3cef4e0f290b60c57fc8
Resolves: #79460
Releases: master
Reviewed-on: https://review.typo3.org/51420
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update codeception to version 2.2.8 19/51419/3
Anja Leichsenring [Wed, 25 Jan 2017 08:33:20 +0000 (09:33 +0100)]
[TASK] Update codeception to version 2.2.8

We want to use the latest version.

Change-Id: I9f41f2b6e58020e01615569350b80afb34a3a067
Resolves: #79459
Releases: master
Reviewed-on: https://review.typo3.org/51419
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:form - add onSubmit callback for pages 96/50796/3
Ralf Zimmermann [Mon, 28 Nov 2016 16:32:46 +0000 (17:32 +0100)]
[TASK] EXT:form - add onSubmit callback for pages

Add onSubmit callback for toplevel composit elements aka. pages.
The ticket provides an example extension for testing.

Resolves: #78821
Releases: master
Change-Id: Ie521ba75472e426594dae231ee86f68cd241f23d
Reviewed-on: https://review.typo3.org/50796
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Ext:form - Add update option to saveToDatabase finisher 10/50810/4
Ralf Zimmermann [Wed, 30 Nov 2016 02:08:30 +0000 (03:08 +0100)]
[TASK] Ext:form - Add update option to saveToDatabase finisher

This patch adds an option to the saveToDatabase finisher which makes it
possible to update an existing database record.
The forge issue provides an example extension for testing.

Resolves: #78839
Releases: master
Change-Id: I07d874a72b81a5e43c864f8a468a1310cac57995
Reviewed-on: https://review.typo3.org/50810
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] EXT:form - editor error on mixed option key types 21/51421/2
Ralf Zimmermann [Wed, 25 Jan 2017 10:00:40 +0000 (11:00 +0100)]
[BUGFIX] EXT:form - editor error on mixed option key types

Let the JavaScript 'Inspector-PropertyGridEditor' deal with mixed
option value types (string / int)

Resolves: #79457
Releases: master
Change-Id: I7e9a377d9a5d6e9f1336c25bc114c974a70b7284
Reviewed-on: https://review.typo3.org/51421
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] EXT:form - fluid 2.2.0 compatibility 10/51410/8
Claus Due [Tue, 24 Jan 2017 17:29:23 +0000 (18:29 +0100)]
[BUGFIX] EXT:form - fluid 2.2.0 compatibility

With the update of fluid to 2.2.0 (e004145) the backend and frontend
break. This patch fixes these problems.

Change-Id: I74617650c5feff381421e15f50aa84aeaf2f6aad
Resolves: #79439
Releases: master
Reviewed-on: https://review.typo3.org/51410
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Correctly show sub item indicator in svg tree 37/51237/5
Thorben Nissen [Tue, 10 Jan 2017 13:21:56 +0000 (14:21 +0100)]
[BUGFIX] Correctly show sub item indicator in svg tree

Changes the way the svg tree nodes are checked for "indeterminate" state
after the data is loaded, so the initial state. Changes code using "rootNode"
to using list of all nodes. Removes unused code.

Resolves: #79246
Releases: master
Change-Id: I7a076a6d3d2c29f0318598227af5d674caa3642f
Reviewed-on: https://review.typo3.org/51237
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Tested-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Use BLOB type column for uc in be_users table 93/51393/3
Manuel Selbach [Sun, 22 Jan 2017 06:23:30 +0000 (22:23 -0800)]
[BUGFIX] Use BLOB type column for uc in be_users table

The unified handling for frontend and backend users requires
identical SQL column types to properly escape the input data.
Using binary encoding for the uc column in combination with a
TEXT type field in the BE fails on PostgreSQL.

Resolves: #79451
Related: #79324
Releases: master
Change-Id: I08e404ca7050aa169234a4542ffa640cad2cd1ff
Reviewed-on: https://review.typo3.org/51393
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Don't query database with non-numeric uids in RelationHandler 96/51396/3
Manuel Selbach [Sun, 22 Jan 2017 06:08:38 +0000 (22:08 -0800)]
[BUGFIX] Don't query database with non-numeric uids in RelationHandler

Check that a uid is numeric to prevent errors when querying an integer
database field with a string value like NEW123456789.

Resolves: #79455
Releases: master
Change-Id: I03a71f31c537e04bc05fcf13f7153c7f6adb3ae7
Reviewed-on: https://review.typo3.org/51396
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX][DBAL] Fix ExtensionManager repository insertion 08/51108/4
Johannes Goslar [Mon, 2 Jan 2017 16:11:46 +0000 (17:11 +0100)]
[BUGFIX][DBAL] Fix ExtensionManager repository insertion

Resolves: #79143
Releases: master
Change-Id: I3cc6f0cff6980439f8f967f8ea627e074444f28c
Reviewed-on: https://review.typo3.org/51108
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Convert fe_group in sys_collection to VARCHAR 92/51392/5
Manuel Selbach [Sun, 22 Jan 2017 06:28:23 +0000 (22:28 -0800)]
[BUGFIX] Convert fe_group in sys_collection to VARCHAR

The core methods dealing with frontend group restrictions expect this
field to be of a character based datatype. Comparing an integer based
field with string triggers query errors on PostgreSQL which
does not perform implict type conversions.

Resolves: #79447
Releases: master
Change-Id: Idc937e71d578e5f4a81595124c3aef53d32b2ed7
Reviewed-on: https://review.typo3.org/51392
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix early return in addUnionStatement method 90/51290/5
Dominique Kreemers [Tue, 17 Jan 2017 11:19:24 +0000 (12:19 +0100)]
[BUGFIX] Fix early return in addUnionStatement method

Set $propertyPath, $tableName and $className to avoid
unnecessary joins and wrong repository results.

This is a regression fix after the Doctrine migration.

Resolves: #79286
Related: #77379
Releases: master
Change-Id: I64489b46b9ca751535b64482f54ceb7b2da05003
Reviewed-on: https://review.typo3.org/51290
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Render metatags on uncached pages 43/51143/3
Daniel Dorndorf [Thu, 5 Jan 2017 10:11:11 +0000 (11:11 +0100)]
[BUGFIX] Render metatags on uncached pages

Adding metatags on uncached pages using the pagerenderer didn't work
because the metatag array was rendered prior to adding any
entries with the 'render-preProcess' hook.

Resolves: #79162
Releases: master, 7.6
Change-Id: I2142a5c91fcb0840993d9235caa1e883bbb0c2b4
Reviewed-on: https://review.typo3.org/51143
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Improve "Create multiple pages" wizard 85/51385/2
Georg Ringer [Sun, 22 Jan 2017 19:41:25 +0000 (20:41 +0100)]
[TASK] Improve "Create multiple pages" wizard

- Use xs instead of sm to support smaller screens
- Add an id to the select field

Resolves: #79418
Releases: master
Change-Id: Ibc0c242d1c9ab54032c2ee383a127b9665cde736
Reviewed-on: https://review.typo3.org/51385
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix broken links to permission module 30/51330/3
Frank Naegler [Mon, 16 Jan 2017 17:37:05 +0000 (18:37 +0100)]
[BUGFIX] Fix broken links to permission module

This patch fix broken links in ClickMenu and DatabaseRecordList which
exists since the permissions module refactoring:
http://review.typo3.org/33402

Resolves: #79329
Related: #62339
Releases: master, 7.6
Change-Id: Iafe66352a7bac593e249ef09c07f1c9dc9b15359
Reviewed-on: https://review.typo3.org/51330
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Disable escaping pidRecordTitle in clickmenu move element 41/51041/4
Gianluigi Martino [Fri, 23 Dec 2016 16:20:37 +0000 (17:20 +0100)]
[TASK] Disable escaping pidRecordTitle in clickmenu move element

Prevent the escaping of pidRecordTitle in click menu move element. The
escaping is already done in the MoveElementController due to the usage
of the third (prep) parameter in BackendUtility::getRecordTitle.

Resolves: #79088
Releases: master
Change-Id: Ib35e9d5a3da7fc76085db910927ada17dbdd0b06
Reviewed-on: https://review.typo3.org/51041
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Style select field of BackendUtility::getFuncMenu 84/51384/2
Georg Ringer [Sun, 22 Jan 2017 19:21:50 +0000 (20:21 +0100)]
[TASK] Style select field of BackendUtility::getFuncMenu

The select field of BackendUtility::getFuncMenu must be styled by
the class "form-control".

One example can be found in the template module if multiple
template records are saved on one page.

Resolves: #79417
Releases: master
Change-Id: I84967474aadbd88bd844fe3cb7de0245abebd39f
Reviewed-on: https://review.typo3.org/51384
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Remove double escaping in template module 91/51391/2
Georg Ringer [Mon, 23 Jan 2017 06:59:14 +0000 (07:59 +0100)]
[BUGFIX] Remove double escaping in template module

The information of a template (title, site title, description) is
already escaped by using fluid. Therefore the htmlspecialchars() must be
removed in the controller.

This is a fix of the regression of the fluidification of #75031.

Resolves: #79424
Releases: master
Change-Id: Iead09ee8f8f0256eee10c2585408d549dbe5c44c
Reviewed-on: https://review.typo3.org/51391
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Render information msg in TS module with a callout 83/51383/3
Georg Ringer [Sun, 22 Jan 2017 19:17:59 +0000 (20:17 +0100)]
[TASK] Render information msg in TS module with a callout

If a template record does not contain any constants, the information
should be rendered by a nice callout.

Resolves: #79416
Releases: master
Change-Id: I6af7b2676d4a7517bc392595948806df9ae7e042
Reviewed-on: https://review.typo3.org/51383
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Allow new lines for description field 79/51379/2
Georg Ringer [Sat, 21 Jan 2017 21:52:56 +0000 (22:52 +0100)]
[TASK] Allow new lines for description field

As the description is a textarea, the rendering should support
lines as well.

Resolves: #79406
Releases: master, 7.6
Change-Id: I8774adb07c50aed24b3d3e94e0a0b913aedeb5a9
Reviewed-on: https://review.typo3.org/51379
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Fix invalid button group markup in scheduler 65/51365/2
Andreas Fernandez [Thu, 19 Jan 2017 20:56:29 +0000 (21:56 +0100)]
[BUGFIX] Fix invalid button group markup in scheduler

An element with the class `btn-group` must not also have the class `btn`.
Such occurences are fixed in this patch.

Resolves: #79395
Related: #78199
Releases: master
Change-Id: I4793afc984936c2fc7226feac24f03b6ec94794f
Reviewed-on: https://review.typo3.org/51365
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] FormEngine: Do not add <br> to readonly textarea content 72/51372/2
Markus Klein [Fri, 20 Jan 2017 14:57:12 +0000 (15:57 +0100)]
[BUGFIX] FormEngine: Do not add <br> to readonly textarea content

Multiline content is displayed in a textarea "as is" by the browser.
There is no need to add <br> tags.

Resolves: #79399
Releases: master, 7.6
Change-Id: Ia628457231a15318dff4fe36f5d3cd3d990d7dc7
Reviewed-on: https://review.typo3.org/51372
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update Fluid engine dependency to 2.2.0 75/51375/3
Claus Due [Fri, 20 Jan 2017 22:03:41 +0000 (23:03 +0100)]
[TASK] Update Fluid engine dependency to 2.2.0

This raises the required and locked version of Fluid
to 2.2.0. The dependency is also bumped in the
composer manifest to ensure that the new VH
`f:variable` can be trusted to exist.

The Fluid engine patches are as follows:

* [FEATURE] Add variable assigning ViewHelper
* [BUGFIX] Cache did not lfush when compiler disabled
* [BUGFIX] Allow renderSection() to be called directly
* [BUGFIX] Convert bool arguments into BooleanNodes
* [BUGFIX] Disable variable extractors

Change-Id: I4ca2ef35b1f82952ca6ef1932d5b2a7a764ff526
Releases: master
Resolves: #79402
Resolves: #79375
Resolves: #77986
Reviewed-on: https://review.typo3.org/51375
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Use official TYPO3.Icon repository 77/51377/2
Benjamin Kott [Sat, 21 Jan 2017 11:04:52 +0000 (12:04 +0100)]
[TASK] Use official TYPO3.Icon repository

The backend icon set has been moved and is now under maintenance of the
TYPO3 GitHub Department. https://github.com/TYPO3/TYPO3.Icons

Resolves: #79404
Releases: master, 7.6
Change-Id: I9c4a78bbf52f681d61e69f2e7245fb1c2cac561f
Reviewed-on: https://review.typo3.org/51377
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Initialize TSFE->config with correct type in PHP 7.1 02/51302/7
Sascha Egerer [Fri, 13 Jan 2017 09:00:16 +0000 (10:00 +0100)]
[BUGFIX] Initialize TSFE->config with correct type in PHP 7.1

The TypoScriptFrontendController->config variable must be of type
array but is initialized with an empty string. Since PHP 7.1 there is
a different handling of invalid array usage. If a variable is
accessed as an array but is not an array the value of that variable
becomes a string 'A'.

PHP 7
php > $config = '';
php > $config['foo'] = 'bar';
php > print_r($config)
Array
(
    [foo] => bar
)

PHP 7.1
php > $config = '';
php > $config['foo'] = 'bar';
> Warning: Illegal string offset 'foo' in php shell code on line 1
php > print_r($config)
A

Related PHP "Bug" (It's not a bug, it's a feature)
https://bugs.php.net/bug.php?id=73081

Change-Id: I6d5b75ed60f0506ecacdead01a318fdc26757394
Resolves: #79052
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51302
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
2 years ago[BUGFIX] Use proper type in LinkAnalyzer to avoid exceptions 19/51319/3
Georg Ringer [Sun, 15 Jan 2017 19:57:30 +0000 (20:57 +0100)]
[BUGFIX] Use proper type in LinkAnalyzer to avoid exceptions

To avoid exceptions, the proper type must be used.

Resolves: #79166
Releases: master
Change-Id: I00a6d65bee8b8807853461bfad681f354ae02045
Reviewed-on: https://review.typo3.org/51319
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Adjust namespaces of test classes in dynamicReturnTypesMeta.json 64/51364/2
Markus Klein [Thu, 19 Jan 2017 15:31:41 +0000 (16:31 +0100)]
[TASK] Adjust namespaces of test classes in dynamicReturnTypesMeta.json

Resolves: #79393
Releases: master
Change-Id: Ic8c0ec41b7421873c4dcbaaa89e483b09ad5608a
Reviewed-on: https://review.typo3.org/51364
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP][BUGFIX] Extbase: Do not mangle SQL query when constraint value is empty 63/51363/2
Daniel Goerz [Thu, 19 Jan 2017 15:02:07 +0000 (16:02 +0100)]
[FOLLOWUP][BUGFIX] Extbase: Do not mangle SQL query when constraint value is empty

Remove a typo from phpdoc.

Change-Id: If5b45a1124294c80fe3b36f8f1c829f293c9d621
Resolves: #79388
Releases: master
Reviewed-on: https://review.typo3.org/51363
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Extbase: Do not mangle SQL query when constraint value is empty 60/51360/2
Markus Klein [Thu, 19 Jan 2017 12:54:30 +0000 (13:54 +0100)]
[BUGFIX] Extbase: Do not mangle SQL query when constraint value is empty

The query parser now throws an exception if the given value for an
IN or CONTAINS expression is invalid, instead of silently converting
it to a "1<>1" condition.
This helps developers when searching for broken queries and prevents
running queries with invalid/useless constraints.

Resolves: #79388
Releases: master
Change-Id: I9868325810ec11c72c994a0106a9e27141d95f3a
Reviewed-on: https://review.typo3.org/51360
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Use reflection information in getGettablePropertyNames 97/50197/7
Nicole Cordes [Wed, 12 Oct 2016 15:55:27 +0000 (17:55 +0200)]
[BUGFIX] Use reflection information in getGettablePropertyNames

In \TYPO3\CMS\Extbase\Reflection\ObjectAccess there is a method to get
all available property names of an object. Currently all get/is/has
methods are joined as they can be fetch from Extbase as well. But for
those methods it is necessary to respect their arguments as Extbase
calls those functions without any argument. This can trigger PHP warnings.

The patch uses a class reflection to get public properties and inspect
the method arguments. Only those functions without arguments or only
optional arguments are considered as valid property name.

Resolves: #78270
Releases: master, 7.6
Change-Id: Ie286dca2a249b73d3dc58f7388dda593a678db3d
Reviewed-on: https://review.typo3.org/50197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Use BLOB type column for ses_data in be_sessions table 14/51314/2
Morton Jonuschat [Sun, 15 Jan 2017 05:56:36 +0000 (21:56 -0800)]
[BUGFIX] Use BLOB type column for ses_data in be_sessions table

The unified session handling for frontend and backend requires
identical SQL column types to properly escape the input data.
Using binary encoding for session data in combination with a TEXT
type field in the BE fails on PostgreSQL.

Change-Id: I3f3f379b43f873335207232e498f2e9e2c8b35e5
Resolves: #79324
Releases: master
Reviewed-on: https://review.typo3.org/51314
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Avoid stripping tags for generating diffs 20/51220/2
Georg Ringer [Mon, 9 Jan 2017 18:16:10 +0000 (19:16 +0100)]
[BUGFIX] Avoid stripping tags for generating diffs

Tags must not be stripped away for creating diffs as
those are essential for editors. Otherwise it is not
possible to see changed links or changing a header from
h1 to h2.

Resolves: #78767
Resolves: #79205
Releases: master, 7.6
Change-Id: Icb174f3522354fa8ef5d2b8ccca039e33ef472e7
Reviewed-on: https://review.typo3.org/51220
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Fix minor typo in DateTimePicker.js 46/51346/2
Wouter Wolters [Wed, 18 Jan 2017 15:25:19 +0000 (16:25 +0100)]
[BUGFIX] Fix minor typo in DateTimePicker.js

Heven't replaced with haven't

Resolves: #79376
Releases: master,7.6
Change-Id: I85b252514378eb4db1eb63f93d9b746ca332602e
Reviewed-on: https://review.typo3.org/51346
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FEATURE] CLI support for T3D import 77/45977/18
Martin Kutschker [Fri, 15 Jan 2016 21:00:48 +0000 (21:00 +0000)]
[FEATURE] CLI support for T3D import

A new CLI command allows to imoprt t3d/xml files for EXT:impexp.

Resolves: #72749
Releases: master
Change-Id: I8775bcc1d39901c25f0c4613d1d5fc3ff3b8868a
Reviewed-on: https://review.typo3.org/45977
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Reorder & Rename entries in CType list 48/49948/5
Georg Ringer [Thu, 15 Sep 2016 17:50:34 +0000 (19:50 +0200)]
[TASK] Reorder & Rename entries in CType list

To improve usability the naming and sorting of content element
types for the content element wizard and the select box are
unified.

Resolves: #77961
Releases: master
Change-Id: I6a0aa4a824992e062ba14931a7712eaafadeb8ab
Reviewed-on: https://review.typo3.org/49948
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Use runtime cache for BackendUtility::isRecordLocked 32/51332/4
Georg Ringer [Tue, 17 Jan 2017 06:49:22 +0000 (07:49 +0100)]
[TASK] Use runtime cache for BackendUtility::isRecordLocked

Instead of using $GLOBALS a runtime cache is used.

Resolves: #79345
Releases: master
Change-Id: I2273051c2d52efff5fa578a82ff636748fe7fdf6
Reviewed-on: https://review.typo3.org/51332
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Deprecate ArrayUtility::inArray() 09/51309/5
Wouter Wolters [Fri, 13 Jan 2017 16:09:09 +0000 (17:09 +0100)]
[TASK] Deprecate ArrayUtility::inArray()

Resolves: #79316
Releases: master
Change-Id: Ieb54d51a6d6f15325fc4c1c88ad29c845200c68b
Reviewed-on: https://review.typo3.org/51309
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Add linkDetails to the parameters sent in typoLink_PostProc hook 34/51334/2
Phat Hoang [Tue, 17 Jan 2017 10:12:37 +0000 (11:12 +0100)]
[TASK] Add linkDetails to the parameters sent in typoLink_PostProc hook

This can be useful when using the unified referencing syntax.

Resolves: #79349
Releases: master

Change-Id: If822da7a6fd348f71c4f36ecf5f63f0a103bd2f7
Reviewed-on: https://review.typo3.org/51334
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mattias Nilsson <tollepjaer@gmail.com>
Tested-by: Mattias Nilsson <tollepjaer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix typo in CacheManager 34/51234/16
Georg Ringer [Tue, 10 Jan 2017 10:09:03 +0000 (11:09 +0100)]
[BUGFIX] Fix typo in CacheManager

By fixing a typo in the CacheManager empty tag arrays
are detected and intercepted.

Resolves: #79236
Releases: master
Change-Id: I67fccda3755274f3334f0916d26beabbb28b8eb4
Reviewed-on: https://review.typo3.org/51234
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Cleanup RTE HTMLArea TSconfig processing options 99/51299/3
Benni Mack [Thu, 12 Jan 2017 23:57:27 +0000 (00:57 +0100)]
[TASK] Cleanup RTE HTMLArea TSconfig processing options

Some obsolete options are found in the documentation, additionally
the RTE.default.proc.exitHTMLparser_db is not enabled by default
anymore, as the functionality to keep non matched tags is not needed.

In case of a site extending the default exitHTMLparser_db configuration of
HTMLArea, it has to be enabled like this:

RTE.default.proc.exitHTMLparser_db = 1
RTE.default.proc.exitHTMLparser_db {
## KEEP ALL TAGS
## Unwanted tags were removed on entry.
## Without this rule, the parser will remove all tags! Presumably, this rule will be more efficient than repeating the allowTags rule
keepNonMatchedTags = 1
}

Resolves: #79346
Releases: master
Change-Id: Ie7208a3fc751b2b712ec773a148c4404965abd99
Reviewed-on: https://review.typo3.org/51299
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Prepare richtext configuration 11/51311/11
Christian Kuhn [Fri, 13 Jan 2017 16:55:56 +0000 (17:55 +0100)]
[!!!][TASK] Prepare richtext configuration

Configuring a richtext field in TCA with the "defaultExtras"
setting (which was formerly the 5th showitem parameter) has
been ugly ever since: The DataHandler needed a special _TRANSFORM_
field to trigger required RTE transformations, further config
depends on pageTs settings.

The patch gets rid of "defaultExtras" for richtext elements and
adds a new option "enableRichtext=true" within the config section
for type=text TCA fields.
This setting can be set via "columnsOverrides" for specific types, too.

As an intermediate solution, the configuration class "Richtext" is
added to fetch richtext configuration. This will be extended with
another patch to provide ckeditor configuration on TCA level.

Change-Id: I70f4cb26e2a45629b99680e532d376538afd2b90
Resolves: #79341
Releases: master
Reviewed-on: https://review.typo3.org/51311
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>