Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Add parameter types to database writes in functional tests 95/51395/3
Manuel Selbach [Sun, 22 Jan 2017 06:11:12 +0000 (22:11 -0800)]
[BUGFIX] Add parameter types to database writes in functional tests

When writing to database tables with BLOB type columns declare the field
type for the query parameters in functional tests. This is required for
databases that use a different encoding/transport protocol for BLOB
fields.

Resolves: #79453
Releases: master
Change-Id: I1371bb192abaec841be982a1b228cc6b7e6d1cbf
Reviewed-on: https://review.typo3.org/51395
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix title for expand button in workspace module 59/51359/4
Mona Muzaffar [Thu, 19 Jan 2017 11:17:57 +0000 (12:17 +0100)]
[BUGFIX] Fix title for expand button in workspace module

Change-Id: I6a17811dd5dbc5ed285b6040fcbe97e94b416b8b
Releases: master
Resolves: #79321
Reviewed-on: https://review.typo3.org/51359
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FEATURE] Add new ViewHelper f:variable via Fluid 2.2.0 98/51398/6
Claus Due [Mon, 23 Jan 2017 11:36:32 +0000 (12:36 +0100)]
[FEATURE] Add new ViewHelper f:variable via Fluid 2.2.0

A new Fluid ViewHelper, `f:variable`, has become available
in TYPO3 after raising the minimum required version of the
Fluid engine to 2.2.0.

Change-Id: I4f42030ef586e8d9a3d40c54c64137eb1969384d
Resolves: #79402
Releases: master
Reviewed-on: https://review.typo3.org/51398
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Adjust Cs-Fixer 2.0 hits 28/51428/2
Anja Leichsenring [Wed, 25 Jan 2017 17:37:09 +0000 (18:37 +0100)]
[TASK] Adjust Cs-Fixer 2.0 hits

With the update of cs-fixer to version 2.0, some checks
got minor changes in behaviour. The core follows now in
applying those suggested changes.

Resolves: #79469
Relates: #79361
Releases: master
Change-Id: I5d17b750231dcb386002b3e46b3a89c59eca2989
Reviewed-on: https://review.typo3.org/51428
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Fix broken TypeScript compiler setting 04/51404/4
Frank Naegler [Tue, 24 Jan 2017 08:46:54 +0000 (09:46 +0100)]
[BUGFIX] Fix broken TypeScript compiler setting

This patch adds a missing compilerOption to generate subfolder in the
build directory, which fix the copy to final destination problem.

Resolves: #79431
Releases: master
Change-Id: Ie756d47e12d2ff72aa6db397d87db311eed43b59
Reviewed-on: https://review.typo3.org/51404
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[FEATURE] EXT:form - Add element selector for text editors 24/51424/3
Ralf Zimmermann [Wed, 25 Jan 2017 14:59:36 +0000 (15:59 +0100)]
[FEATURE] EXT:form - Add element selector for text editors

Adds a new button to the text editors.
This splitbutton opens a list with available form elements.
If a form element is choosen, the form element identifier will be
inserted into the property text editor.

Resolves: #79442
Releases: master
Change-Id: If40114958311200348bde220f6cf62fb6365260b
Reviewed-on: https://review.typo3.org/51424
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Update php-cs-fixer to version 2.0 23/51423/5
Anja Leichsenring [Wed, 25 Jan 2017 12:35:02 +0000 (13:35 +0100)]
[TASK] Update php-cs-fixer to version 2.0

Change-Id: Ia32a61238bdf46c01a3856376c0a94d9d09339ee
Resolves: #79361
Releases: master
Reviewed-on: https://review.typo3.org/51423
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update phpunit to version 5.7.5 20/51420/3
Anja Leichsenring [Wed, 25 Jan 2017 09:11:55 +0000 (10:11 +0100)]
[TASK] Update phpunit to version 5.7.5

Change-Id: I118f4d6b9fd94fcaa0da3cef4e0f290b60c57fc8
Resolves: #79460
Releases: master
Reviewed-on: https://review.typo3.org/51420
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update codeception to version 2.2.8 19/51419/3
Anja Leichsenring [Wed, 25 Jan 2017 08:33:20 +0000 (09:33 +0100)]
[TASK] Update codeception to version 2.2.8

We want to use the latest version.

Change-Id: I9f41f2b6e58020e01615569350b80afb34a3a067
Resolves: #79459
Releases: master
Reviewed-on: https://review.typo3.org/51419
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:form - add onSubmit callback for pages 96/50796/3
Ralf Zimmermann [Mon, 28 Nov 2016 16:32:46 +0000 (17:32 +0100)]
[TASK] EXT:form - add onSubmit callback for pages

Add onSubmit callback for toplevel composit elements aka. pages.
The ticket provides an example extension for testing.

Resolves: #78821
Releases: master
Change-Id: Ie521ba75472e426594dae231ee86f68cd241f23d
Reviewed-on: https://review.typo3.org/50796
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Ext:form - Add update option to saveToDatabase finisher 10/50810/4
Ralf Zimmermann [Wed, 30 Nov 2016 02:08:30 +0000 (03:08 +0100)]
[TASK] Ext:form - Add update option to saveToDatabase finisher

This patch adds an option to the saveToDatabase finisher which makes it
possible to update an existing database record.
The forge issue provides an example extension for testing.

Resolves: #78839
Releases: master
Change-Id: I07d874a72b81a5e43c864f8a468a1310cac57995
Reviewed-on: https://review.typo3.org/50810
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] EXT:form - editor error on mixed option key types 21/51421/2
Ralf Zimmermann [Wed, 25 Jan 2017 10:00:40 +0000 (11:00 +0100)]
[BUGFIX] EXT:form - editor error on mixed option key types

Let the JavaScript 'Inspector-PropertyGridEditor' deal with mixed
option value types (string / int)

Resolves: #79457
Releases: master
Change-Id: I7e9a377d9a5d6e9f1336c25bc114c974a70b7284
Reviewed-on: https://review.typo3.org/51421
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] EXT:form - fluid 2.2.0 compatibility 10/51410/8
Claus Due [Tue, 24 Jan 2017 17:29:23 +0000 (18:29 +0100)]
[BUGFIX] EXT:form - fluid 2.2.0 compatibility

With the update of fluid to 2.2.0 (e004145) the backend and frontend
break. This patch fixes these problems.

Change-Id: I74617650c5feff381421e15f50aa84aeaf2f6aad
Resolves: #79439
Releases: master
Reviewed-on: https://review.typo3.org/51410
Tested-by: Andreas Steiger <typo3@andreassteiger.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Correctly show sub item indicator in svg tree 37/51237/5
Thorben Nissen [Tue, 10 Jan 2017 13:21:56 +0000 (14:21 +0100)]
[BUGFIX] Correctly show sub item indicator in svg tree

Changes the way the svg tree nodes are checked for "indeterminate" state
after the data is loaded, so the initial state. Changes code using "rootNode"
to using list of all nodes. Removes unused code.

Resolves: #79246
Releases: master
Change-Id: I7a076a6d3d2c29f0318598227af5d674caa3642f
Reviewed-on: https://review.typo3.org/51237
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Tested-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Use BLOB type column for uc in be_users table 93/51393/3
Manuel Selbach [Sun, 22 Jan 2017 06:23:30 +0000 (22:23 -0800)]
[BUGFIX] Use BLOB type column for uc in be_users table

The unified handling for frontend and backend users requires
identical SQL column types to properly escape the input data.
Using binary encoding for the uc column in combination with a
TEXT type field in the BE fails on PostgreSQL.

Resolves: #79451
Related: #79324
Releases: master
Change-Id: I08e404ca7050aa169234a4542ffa640cad2cd1ff
Reviewed-on: https://review.typo3.org/51393
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Don't query database with non-numeric uids in RelationHandler 96/51396/3
Manuel Selbach [Sun, 22 Jan 2017 06:08:38 +0000 (22:08 -0800)]
[BUGFIX] Don't query database with non-numeric uids in RelationHandler

Check that a uid is numeric to prevent errors when querying an integer
database field with a string value like NEW123456789.

Resolves: #79455
Releases: master
Change-Id: I03a71f31c537e04bc05fcf13f7153c7f6adb3ae7
Reviewed-on: https://review.typo3.org/51396
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX][DBAL] Fix ExtensionManager repository insertion 08/51108/4
Johannes Goslar [Mon, 2 Jan 2017 16:11:46 +0000 (17:11 +0100)]
[BUGFIX][DBAL] Fix ExtensionManager repository insertion

Resolves: #79143
Releases: master
Change-Id: I3cc6f0cff6980439f8f967f8ea627e074444f28c
Reviewed-on: https://review.typo3.org/51108
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Convert fe_group in sys_collection to VARCHAR 92/51392/5
Manuel Selbach [Sun, 22 Jan 2017 06:28:23 +0000 (22:28 -0800)]
[BUGFIX] Convert fe_group in sys_collection to VARCHAR

The core methods dealing with frontend group restrictions expect this
field to be of a character based datatype. Comparing an integer based
field with string triggers query errors on PostgreSQL which
does not perform implict type conversions.

Resolves: #79447
Releases: master
Change-Id: Idc937e71d578e5f4a81595124c3aef53d32b2ed7
Reviewed-on: https://review.typo3.org/51392
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix early return in addUnionStatement method 90/51290/5
Dominique Kreemers [Tue, 17 Jan 2017 11:19:24 +0000 (12:19 +0100)]
[BUGFIX] Fix early return in addUnionStatement method

Set $propertyPath, $tableName and $className to avoid
unnecessary joins and wrong repository results.

This is a regression fix after the Doctrine migration.

Resolves: #79286
Related: #77379
Releases: master
Change-Id: I64489b46b9ca751535b64482f54ceb7b2da05003
Reviewed-on: https://review.typo3.org/51290
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Render metatags on uncached pages 43/51143/3
Daniel Dorndorf [Thu, 5 Jan 2017 10:11:11 +0000 (11:11 +0100)]
[BUGFIX] Render metatags on uncached pages

Adding metatags on uncached pages using the pagerenderer didn't work
because the metatag array was rendered prior to adding any
entries with the 'render-preProcess' hook.

Resolves: #79162
Releases: master, 7.6
Change-Id: I2142a5c91fcb0840993d9235caa1e883bbb0c2b4
Reviewed-on: https://review.typo3.org/51143
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Improve "Create multiple pages" wizard 85/51385/2
Georg Ringer [Sun, 22 Jan 2017 19:41:25 +0000 (20:41 +0100)]
[TASK] Improve "Create multiple pages" wizard

- Use xs instead of sm to support smaller screens
- Add an id to the select field

Resolves: #79418
Releases: master
Change-Id: Ibc0c242d1c9ab54032c2ee383a127b9665cde736
Reviewed-on: https://review.typo3.org/51385
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix broken links to permission module 30/51330/3
Frank Naegler [Mon, 16 Jan 2017 17:37:05 +0000 (18:37 +0100)]
[BUGFIX] Fix broken links to permission module

This patch fix broken links in ClickMenu and DatabaseRecordList which
exists since the permissions module refactoring:
http://review.typo3.org/33402

Resolves: #79329
Related: #62339
Releases: master, 7.6
Change-Id: Iafe66352a7bac593e249ef09c07f1c9dc9b15359
Reviewed-on: https://review.typo3.org/51330
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Disable escaping pidRecordTitle in clickmenu move element 41/51041/4
Gianluigi Martino [Fri, 23 Dec 2016 16:20:37 +0000 (17:20 +0100)]
[TASK] Disable escaping pidRecordTitle in clickmenu move element

Prevent the escaping of pidRecordTitle in click menu move element. The
escaping is already done in the MoveElementController due to the usage
of the third (prep) parameter in BackendUtility::getRecordTitle.

Resolves: #79088
Releases: master
Change-Id: Ib35e9d5a3da7fc76085db910927ada17dbdd0b06
Reviewed-on: https://review.typo3.org/51041
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Style select field of BackendUtility::getFuncMenu 84/51384/2
Georg Ringer [Sun, 22 Jan 2017 19:21:50 +0000 (20:21 +0100)]
[TASK] Style select field of BackendUtility::getFuncMenu

The select field of BackendUtility::getFuncMenu must be styled by
the class "form-control".

One example can be found in the template module if multiple
template records are saved on one page.

Resolves: #79417
Releases: master
Change-Id: I84967474aadbd88bd844fe3cb7de0245abebd39f
Reviewed-on: https://review.typo3.org/51384
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Remove double escaping in template module 91/51391/2
Georg Ringer [Mon, 23 Jan 2017 06:59:14 +0000 (07:59 +0100)]
[BUGFIX] Remove double escaping in template module

The information of a template (title, site title, description) is
already escaped by using fluid. Therefore the htmlspecialchars() must be
removed in the controller.

This is a fix of the regression of the fluidification of #75031.

Resolves: #79424
Releases: master
Change-Id: Iead09ee8f8f0256eee10c2585408d549dbe5c44c
Reviewed-on: https://review.typo3.org/51391
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Render information msg in TS module with a callout 83/51383/3
Georg Ringer [Sun, 22 Jan 2017 19:17:59 +0000 (20:17 +0100)]
[TASK] Render information msg in TS module with a callout

If a template record does not contain any constants, the information
should be rendered by a nice callout.

Resolves: #79416
Releases: master
Change-Id: I6af7b2676d4a7517bc392595948806df9ae7e042
Reviewed-on: https://review.typo3.org/51383
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Allow new lines for description field 79/51379/2
Georg Ringer [Sat, 21 Jan 2017 21:52:56 +0000 (22:52 +0100)]
[TASK] Allow new lines for description field

As the description is a textarea, the rendering should support
lines as well.

Resolves: #79406
Releases: master, 7.6
Change-Id: I8774adb07c50aed24b3d3e94e0a0b913aedeb5a9
Reviewed-on: https://review.typo3.org/51379
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Fix invalid button group markup in scheduler 65/51365/2
Andreas Fernandez [Thu, 19 Jan 2017 20:56:29 +0000 (21:56 +0100)]
[BUGFIX] Fix invalid button group markup in scheduler

An element with the class `btn-group` must not also have the class `btn`.
Such occurences are fixed in this patch.

Resolves: #79395
Related: #78199
Releases: master
Change-Id: I4793afc984936c2fc7226feac24f03b6ec94794f
Reviewed-on: https://review.typo3.org/51365
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] FormEngine: Do not add <br> to readonly textarea content 72/51372/2
Markus Klein [Fri, 20 Jan 2017 14:57:12 +0000 (15:57 +0100)]
[BUGFIX] FormEngine: Do not add <br> to readonly textarea content

Multiline content is displayed in a textarea "as is" by the browser.
There is no need to add <br> tags.

Resolves: #79399
Releases: master, 7.6
Change-Id: Ia628457231a15318dff4fe36f5d3cd3d990d7dc7
Reviewed-on: https://review.typo3.org/51372
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update Fluid engine dependency to 2.2.0 75/51375/3
Claus Due [Fri, 20 Jan 2017 22:03:41 +0000 (23:03 +0100)]
[TASK] Update Fluid engine dependency to 2.2.0

This raises the required and locked version of Fluid
to 2.2.0. The dependency is also bumped in the
composer manifest to ensure that the new VH
`f:variable` can be trusted to exist.

The Fluid engine patches are as follows:

* [FEATURE] Add variable assigning ViewHelper
* [BUGFIX] Cache did not lfush when compiler disabled
* [BUGFIX] Allow renderSection() to be called directly
* [BUGFIX] Convert bool arguments into BooleanNodes
* [BUGFIX] Disable variable extractors

Change-Id: I4ca2ef35b1f82952ca6ef1932d5b2a7a764ff526
Releases: master
Resolves: #79402
Resolves: #79375
Resolves: #77986
Reviewed-on: https://review.typo3.org/51375
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Use official TYPO3.Icon repository 77/51377/2
Benjamin Kott [Sat, 21 Jan 2017 11:04:52 +0000 (12:04 +0100)]
[TASK] Use official TYPO3.Icon repository

The backend icon set has been moved and is now under maintenance of the
TYPO3 GitHub Department. https://github.com/TYPO3/TYPO3.Icons

Resolves: #79404
Releases: master, 7.6
Change-Id: I9c4a78bbf52f681d61e69f2e7245fb1c2cac561f
Reviewed-on: https://review.typo3.org/51377
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Initialize TSFE->config with correct type in PHP 7.1 02/51302/7
Sascha Egerer [Fri, 13 Jan 2017 09:00:16 +0000 (10:00 +0100)]
[BUGFIX] Initialize TSFE->config with correct type in PHP 7.1

The TypoScriptFrontendController->config variable must be of type
array but is initialized with an empty string. Since PHP 7.1 there is
a different handling of invalid array usage. If a variable is
accessed as an array but is not an array the value of that variable
becomes a string 'A'.

PHP 7
php > $config = '';
php > $config['foo'] = 'bar';
php > print_r($config)
Array
(
    [foo] => bar
)

PHP 7.1
php > $config = '';
php > $config['foo'] = 'bar';
> Warning: Illegal string offset 'foo' in php shell code on line 1
php > print_r($config)
A

Related PHP "Bug" (It's not a bug, it's a feature)
https://bugs.php.net/bug.php?id=73081

Change-Id: I6d5b75ed60f0506ecacdead01a318fdc26757394
Resolves: #79052
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51302
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
2 years ago[BUGFIX] Use proper type in LinkAnalyzer to avoid exceptions 19/51319/3
Georg Ringer [Sun, 15 Jan 2017 19:57:30 +0000 (20:57 +0100)]
[BUGFIX] Use proper type in LinkAnalyzer to avoid exceptions

To avoid exceptions, the proper type must be used.

Resolves: #79166
Releases: master
Change-Id: I00a6d65bee8b8807853461bfad681f354ae02045
Reviewed-on: https://review.typo3.org/51319
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Adjust namespaces of test classes in dynamicReturnTypesMeta.json 64/51364/2
Markus Klein [Thu, 19 Jan 2017 15:31:41 +0000 (16:31 +0100)]
[TASK] Adjust namespaces of test classes in dynamicReturnTypesMeta.json

Resolves: #79393
Releases: master
Change-Id: Ic8c0ec41b7421873c4dcbaaa89e483b09ad5608a
Reviewed-on: https://review.typo3.org/51364
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP][BUGFIX] Extbase: Do not mangle SQL query when constraint value is empty 63/51363/2
Daniel Goerz [Thu, 19 Jan 2017 15:02:07 +0000 (16:02 +0100)]
[FOLLOWUP][BUGFIX] Extbase: Do not mangle SQL query when constraint value is empty

Remove a typo from phpdoc.

Change-Id: If5b45a1124294c80fe3b36f8f1c829f293c9d621
Resolves: #79388
Releases: master
Reviewed-on: https://review.typo3.org/51363
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Extbase: Do not mangle SQL query when constraint value is empty 60/51360/2
Markus Klein [Thu, 19 Jan 2017 12:54:30 +0000 (13:54 +0100)]
[BUGFIX] Extbase: Do not mangle SQL query when constraint value is empty

The query parser now throws an exception if the given value for an
IN or CONTAINS expression is invalid, instead of silently converting
it to a "1<>1" condition.
This helps developers when searching for broken queries and prevents
running queries with invalid/useless constraints.

Resolves: #79388
Releases: master
Change-Id: I9868325810ec11c72c994a0106a9e27141d95f3a
Reviewed-on: https://review.typo3.org/51360
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Use reflection information in getGettablePropertyNames 97/50197/7
Nicole Cordes [Wed, 12 Oct 2016 15:55:27 +0000 (17:55 +0200)]
[BUGFIX] Use reflection information in getGettablePropertyNames

In \TYPO3\CMS\Extbase\Reflection\ObjectAccess there is a method to get
all available property names of an object. Currently all get/is/has
methods are joined as they can be fetch from Extbase as well. But for
those methods it is necessary to respect their arguments as Extbase
calls those functions without any argument. This can trigger PHP warnings.

The patch uses a class reflection to get public properties and inspect
the method arguments. Only those functions without arguments or only
optional arguments are considered as valid property name.

Resolves: #78270
Releases: master, 7.6
Change-Id: Ie286dca2a249b73d3dc58f7388dda593a678db3d
Reviewed-on: https://review.typo3.org/50197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Use BLOB type column for ses_data in be_sessions table 14/51314/2
Morton Jonuschat [Sun, 15 Jan 2017 05:56:36 +0000 (21:56 -0800)]
[BUGFIX] Use BLOB type column for ses_data in be_sessions table

The unified session handling for frontend and backend requires
identical SQL column types to properly escape the input data.
Using binary encoding for session data in combination with a TEXT
type field in the BE fails on PostgreSQL.

Change-Id: I3f3f379b43f873335207232e498f2e9e2c8b35e5
Resolves: #79324
Releases: master
Reviewed-on: https://review.typo3.org/51314
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Avoid stripping tags for generating diffs 20/51220/2
Georg Ringer [Mon, 9 Jan 2017 18:16:10 +0000 (19:16 +0100)]
[BUGFIX] Avoid stripping tags for generating diffs

Tags must not be stripped away for creating diffs as
those are essential for editors. Otherwise it is not
possible to see changed links or changing a header from
h1 to h2.

Resolves: #78767
Resolves: #79205
Releases: master, 7.6
Change-Id: Icb174f3522354fa8ef5d2b8ccca039e33ef472e7
Reviewed-on: https://review.typo3.org/51220
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Fix minor typo in DateTimePicker.js 46/51346/2
Wouter Wolters [Wed, 18 Jan 2017 15:25:19 +0000 (16:25 +0100)]
[BUGFIX] Fix minor typo in DateTimePicker.js

Heven't replaced with haven't

Resolves: #79376
Releases: master,7.6
Change-Id: I85b252514378eb4db1eb63f93d9b746ca332602e
Reviewed-on: https://review.typo3.org/51346
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[FEATURE] CLI support for T3D import 77/45977/18
Martin Kutschker [Fri, 15 Jan 2016 21:00:48 +0000 (21:00 +0000)]
[FEATURE] CLI support for T3D import

A new CLI command allows to imoprt t3d/xml files for EXT:impexp.

Resolves: #72749
Releases: master
Change-Id: I8775bcc1d39901c25f0c4613d1d5fc3ff3b8868a
Reviewed-on: https://review.typo3.org/45977
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Reorder & Rename entries in CType list 48/49948/5
Georg Ringer [Thu, 15 Sep 2016 17:50:34 +0000 (19:50 +0200)]
[TASK] Reorder & Rename entries in CType list

To improve usability the naming and sorting of content element
types for the content element wizard and the select box are
unified.

Resolves: #77961
Releases: master
Change-Id: I6a0aa4a824992e062ba14931a7712eaafadeb8ab
Reviewed-on: https://review.typo3.org/49948
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Use runtime cache for BackendUtility::isRecordLocked 32/51332/4
Georg Ringer [Tue, 17 Jan 2017 06:49:22 +0000 (07:49 +0100)]
[TASK] Use runtime cache for BackendUtility::isRecordLocked

Instead of using $GLOBALS a runtime cache is used.

Resolves: #79345
Releases: master
Change-Id: I2273051c2d52efff5fa578a82ff636748fe7fdf6
Reviewed-on: https://review.typo3.org/51332
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Deprecate ArrayUtility::inArray() 09/51309/5
Wouter Wolters [Fri, 13 Jan 2017 16:09:09 +0000 (17:09 +0100)]
[TASK] Deprecate ArrayUtility::inArray()

Resolves: #79316
Releases: master
Change-Id: Ieb54d51a6d6f15325fc4c1c88ad29c845200c68b
Reviewed-on: https://review.typo3.org/51309
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Add linkDetails to the parameters sent in typoLink_PostProc hook 34/51334/2
Phat Hoang [Tue, 17 Jan 2017 10:12:37 +0000 (11:12 +0100)]
[TASK] Add linkDetails to the parameters sent in typoLink_PostProc hook

This can be useful when using the unified referencing syntax.

Resolves: #79349
Releases: master

Change-Id: If822da7a6fd348f71c4f36ecf5f63f0a103bd2f7
Reviewed-on: https://review.typo3.org/51334
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mattias Nilsson <tollepjaer@gmail.com>
Tested-by: Mattias Nilsson <tollepjaer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix typo in CacheManager 34/51234/16
Georg Ringer [Tue, 10 Jan 2017 10:09:03 +0000 (11:09 +0100)]
[BUGFIX] Fix typo in CacheManager

By fixing a typo in the CacheManager empty tag arrays
are detected and intercepted.

Resolves: #79236
Releases: master
Change-Id: I67fccda3755274f3334f0916d26beabbb28b8eb4
Reviewed-on: https://review.typo3.org/51234
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Cleanup RTE HTMLArea TSconfig processing options 99/51299/3
Benni Mack [Thu, 12 Jan 2017 23:57:27 +0000 (00:57 +0100)]
[TASK] Cleanup RTE HTMLArea TSconfig processing options

Some obsolete options are found in the documentation, additionally
the RTE.default.proc.exitHTMLparser_db is not enabled by default
anymore, as the functionality to keep non matched tags is not needed.

In case of a site extending the default exitHTMLparser_db configuration of
HTMLArea, it has to be enabled like this:

RTE.default.proc.exitHTMLparser_db = 1
RTE.default.proc.exitHTMLparser_db {
## KEEP ALL TAGS
## Unwanted tags were removed on entry.
## Without this rule, the parser will remove all tags! Presumably, this rule will be more efficient than repeating the allowTags rule
keepNonMatchedTags = 1
}

Resolves: #79346
Releases: master
Change-Id: Ie7208a3fc751b2b712ec773a148c4404965abd99
Reviewed-on: https://review.typo3.org/51299
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Prepare richtext configuration 11/51311/11
Christian Kuhn [Fri, 13 Jan 2017 16:55:56 +0000 (17:55 +0100)]
[!!!][TASK] Prepare richtext configuration

Configuring a richtext field in TCA with the "defaultExtras"
setting (which was formerly the 5th showitem parameter) has
been ugly ever since: The DataHandler needed a special _TRANSFORM_
field to trigger required RTE transformations, further config
depends on pageTs settings.

The patch gets rid of "defaultExtras" for richtext elements and
adds a new option "enableRichtext=true" within the config section
for type=text TCA fields.
This setting can be set via "columnsOverrides" for specific types, too.

As an intermediate solution, the configuration class "Richtext" is
added to fetch richtext configuration. This will be extended with
another patch to provide ckeditor configuration on TCA level.

Change-Id: I70f4cb26e2a45629b99680e532d376538afd2b90
Resolves: #79341
Releases: master
Reviewed-on: https://review.typo3.org/51311
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Remove vC checks and deprecate veriCode() method 17/51317/4
Tymoteusz Motylewski [Sun, 15 Jan 2017 17:46:52 +0000 (18:46 +0100)]
[!!!][TASK] Remove vC checks and deprecate veriCode() method

Since now all Backend urls have module token in place,
the veriCode is not needed any more.
Thus AbstractUserAuthentication::veriCode() is marked as deprecated,
vC parameter is not checked any more
and vC property is removed from some controllers.

Resolves: #79327
Releases: master
Change-Id: I47e459d95e8f561dcc933a832d22c86ed02aa707
Reviewed-on: https://review.typo3.org/51317
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Streamline assignment of current workspace in DataHandler 25/51325/6
Oliver Hader [Mon, 16 Jan 2017 12:42:36 +0000 (13:42 +0100)]
[TASK] Streamline assignment of current workspace in DataHandler

The processing of data structures in DataHandler and RelationHandler
are bound to each other. DataHandler allows to be initialized with a
custom BE_USER instance and thus with a custom workspace, different
to the actual value of the real instance of $GLOBALS['BE_USER'].

This patch streamlines the workspace disposal by explicitly
forwarding the provided workspace to RelationHandler and avoids
fetching the current workspace for processing from global values.

The consideration of workspace related fields in RelationHandler was
bound to the current workspace of the global backend user - however,
this backend user constraint has been removed now.

Resolves: #79339
Releases: master
Change-Id: I3973d55c5b9d99ed2e976b86136338fee79d5f6e
Reviewed-on: https://review.typo3.org/51325
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Include constants in TypoScript cache 04/51304/3
Benni Mack [Fri, 13 Jan 2017 09:48:12 +0000 (10:48 +0100)]
[TASK] Include constants in TypoScript cache

In order to work with available constants in TypoScript in Frontend
the parsed TypoScript constants are included in the cache entries
as well.

This ensures a more consistent behaviour of available information
for the TYPO3 Frontend.

This was previously set via $this->backend_info which was
set to "true" in the TYPO3 Backend.

Resolves: #79307
Releases: master
Change-Id: I5f5e024c8df51c4fd43b7bc607855b9b21ebb1dd
Reviewed-on: https://review.typo3.org/51304
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Extbase: Don't use ORDER BY with COUNT(*) SQL statements 13/51313/2
Morton Jonuschat [Sun, 15 Jan 2017 05:36:02 +0000 (21:36 -0800)]
[BUGFIX] Extbase: Don't use ORDER BY with COUNT(*) SQL statements

Databases that adhere to the SQL92 standard and enforce having all
columns that are using in any part of the query be part of the
SELECT/COUNT field list will throw an error when using COUNT(*) in
combination with ORDER BY.
Since ordering has no influence on the result of COUNT(*) the
ORDER BY query part has been disabled in getObjectCountByQuery().

Change-Id: Idd7c73d172116a83feb653db6a0167fb0bea2023
Resolves: #79322
Releases: master
Reviewed-on: https://review.typo3.org/51313
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Return all packages with PackageManager::getAvailablePackages 26/51026/3
Nicole Cordes [Thu, 22 Dec 2016 15:29:43 +0000 (16:29 +0100)]
[BUGFIX] Return all packages with PackageManager::getAvailablePackages

Currently the PackageManager loads installed package information by
default only. This patch adds a new flag to ensure all packages are
fetched before all available package information should be returned.

Resolves: #79078
Releases: master
Change-Id: I729c02f7b5c8303ee8d277aa88782274dff23591
Reviewed-on: https://review.typo3.org/51026
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Make persistent connections available for Redis cache backend 78/50978/9
Kasper Ligaard [Thu, 15 Dec 2016 13:59:26 +0000 (14:59 +0100)]
[BUGFIX] Make persistent connections available for Redis cache backend

The Redis cache backend allows configuration of all connection
setting, except setting persistent connections. This omission
is fixed by this patch. Being unable to use persistent connections
under high load can hurt performance in cloud setups. Persistent
connections has been part of phpredis since 2010 and thus is
broadly available, but is impossible to use with TYPO3.

Resolves: #79005
Releases: master, 7.6
Change-Id: Ie5476e894072bb9979691f28bc7a1e10e86ef454
Reviewed-on: https://review.typo3.org/50978
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kasper Ligaard <kasperligaard+typo3.org@gmail.com>
Reviewed-by: David Greiner <hallo@davidgreiner.de>
Tested-by: David Greiner <hallo@davidgreiner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Prepend, don't append, configured View paths 83/51283/2
Claus Due [Thu, 12 Jan 2017 12:02:20 +0000 (13:02 +0100)]
[BUGFIX] Prepend, don't append, configured View paths

Avoids an issue where default View paths would
be added LAST instead of FIRST as is intended.

Change-Id: I00413b40e2df529b0c6673226b65924b034c2432
Resolves: #79290
Releases: master
Reviewed-on: https://review.typo3.org/51283
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Remove outdated PHPDoc comment 08/51308/3
Stefan Rotsch [Fri, 13 Jan 2017 15:47:57 +0000 (16:47 +0100)]
[BUGFIX] Remove outdated PHPDoc comment

The described behavior has been removed with TYPO3 7.6;
the variable is treated as a boolean now.

Resolves: #79314
Releases: master
Change-Id: I456ad1884a9a40c22c2015d19aa5abdd623a1654
Reviewed-on: https://review.typo3.org/51308
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] List Module: Hide hidden fields in single table rendering 82/51282/3
Georg Ringer [Thu, 12 Jan 2017 11:50:41 +0000 (12:50 +0100)]
[TASK] List Module: Hide hidden fields in single table rendering

If a field is hidden by using TsConfig, it should also not be
shown in the single table rendering in the record list.

Resolves: #79289
Releases: master
Change-Id: I0366c5ef5da260084367b9881f3a26ef60d5b319
Reviewed-on: https://review.typo3.org/51282
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Ext:form - remove class attribute from flashMessages viewhelper 03/51303/2
Ralf Zimmermann [Fri, 13 Jan 2017 09:09:37 +0000 (10:09 +0100)]
[BUGFIX] Ext:form - remove class attribute from flashMessages viewhelper

https://review.typo3.org/#/c/50285/ breaks the ext:form backend modul.
Remove "class" tag attributes from flashMessages viewHelper tags.

Resolves: #79306
Releases: master
Change-Id: I753cc5bf4deabfa824179c5e025044c65df4e069
Reviewed-on: https://review.typo3.org/51303
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Move pages.url_scheme to compatibility7 77/51077/5
Benni Mack [Thu, 12 Jan 2017 14:26:02 +0000 (15:26 +0100)]
[!!!][TASK] Move pages.url_scheme to compatibility7

Adding SSL support on a per-page basis is something that
does not happen very much in 2017 anymore, rather doing this
on a per-domain basis, and based on server-redirects makes
more sense these days.

The field and the functionality for links is moved to
EXT:compatibility7.

Resolves: #79302
Releases: master
Change-Id: I7ae1c59533bee1d015b39811f39d590e5488aabe
Reviewed-on: https://review.typo3.org/51077
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][TASK] Remove RTE proc.transformBoldAndItalicTags option 89/51289/5
Benni Mack [Thu, 12 Jan 2017 15:41:30 +0000 (16:41 +0100)]
[!!!][TASK] Remove RTE proc.transformBoldAndItalicTags option

The option transformBoldAndItalicTags is there to convert
<i> and <b> tags from the DB to <strong> and <em> for the RTE.

When saving, all tags are converted back to <i> and <b>
before storing the content in the database again.

This is actually a (weird) shortcut due to historical reasons,
and can easily be set up by the HTMLparser directly using
the tags.[tagname].remap = [newtagname].

This syntax can be used directly to enable this functionality
again

RTE.default.proc {
        # make <strong> and <em> tags when sending to the RTE
    HTMLparser_rte {
            tags {
                b.remap = strong
                i.remap = em
            }
    }
        # make <b> and <i> tags when sending to the DB
    HTMLparser_db {
        tags {
            strong.remap = B
            em.remap = I
        }
    }
}

The option is removed and the explicit (and IMHO more understandable)
syntax is used in the RTE configuration of HTMLArea.

If the InlineElements functionality of HTMLarea is enabled,
then the remapping is not done, as any tag (b, i, strong, em)
is kept as is, becoming more flexible.

In any case, any "unification" if necessary, can also be
done the same way via the HTMLparser for the frontend
when outputting the content.

Resolving: #79300
Releases: master
Change-Id: I354b0ccd1948ea7d018c7135c4694e0c0f9b72b8
Reviewed-on: https://review.typo3.org/51289
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Move DatabaseL10nModeUpdate to a row updater 77/51277/6
Christian Kuhn [Thu, 12 Jan 2017 00:17:37 +0000 (01:17 +0100)]
[TASK] Move DatabaseL10nModeUpdate to a row updater

The new DatabaseL10nModeUpdate install tool upgrade wizard that
migrates row content for old "mergeIfNotBlank" fields is now
implemented as the first consumer of the new row updater upgrade
wizard.

Change-Id: If7495ef09e06c5fd611fe95feff640c67d3a672b
Resolves: #79281
Related: #79243
Related: #79279
Releases: master
Reviewed-on: https://review.typo3.org/51277
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] Introduce l10n_source field for tt_content 70/51070/26
Tymoteusz Motylewski [Thu, 12 Jan 2017 13:03:46 +0000 (14:03 +0100)]
[FEATURE] Introduce l10n_source field for tt_content

A new field which is a ctrl-based field for any TCA table
called "translationSource" set to a DB field name
(used for the new field tt_content.l10n_source) is added
and filled as it contains the uid of the record of where a
translation record came from.

This is different to "transOrigPointerField" as it
contains not the record to a record in the default language
or the one where a record was copied from, but rather
the information what the translation source was made.

Releases: master
Resolves: #78169
Change-Id: I3ecfeedb656c64681e5e3021cad6b708482520dc
Reviewed-on: https://review.typo3.org/51070
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Move legacy indexed_search plugin registration 88/51288/2
Benni Mack [Thu, 12 Jan 2017 14:34:13 +0000 (15:34 +0100)]
[BUGFIX] Move legacy indexed_search plugin registration

When moved to EXT:compatibility7 the pi-based Indexed Search
plugin registration was moved to "Configuration/TCA" but
should go into "Configuration/TCA/Overrides".

Resolves: #79299
Releases: master
Change-Id: Ic9abec2a967b08514a786bc2ee62ce65024a1e32
Reviewed-on: https://review.typo3.org/51288
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Always keep <a> instead of <link> tags in RTE transformations 41/49441/5
Benni Mack [Thu, 12 Jan 2017 01:29:23 +0000 (02:29 +0100)]
[TASK] Always keep <a> instead of <link> tags in RTE transformations

The RTE uses <a> tags for handling links, a transformation
that replaces <link> tags to <a> tags is updated to use the
new t3:// linking syntax instead of hard-coding index.php?id=23
or trying to manually resolve the TypoLink functionality
for doing links.

This also means that the RTE now deals with t3:// links,
and HtmlArea is adapted as well.

When saving the links in the database again, the links
are now not transformed into <link> tags again but kept
as proper <a> tags.

Resolves: #79291
Releases: master
Change-Id: Idc002138e1283d6962666dcd44ba3039c464d6ca
Reviewed-on: https://review.typo3.org/49441
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years agoRevert "[BUGFIX] Skip main extension repository check in Composer mode" 80/51280/4
Nicole Cordes [Thu, 12 Jan 2017 09:08:51 +0000 (10:08 +0100)]
Revert "[BUGFIX] Skip main extension repository check in Composer mode"

This reverts commit e538ed3f154f447ddbaf78785a31c9ab2ee72a17.

We do need the information about the main repository status as there is
currently no other possibility to get information about the (security)
status of extension besides the TER itself.

Resolves: #79285
Related: #79277
Releases: master, 7.6
Change-Id: Ia769dc95eaeff405f291d5929b7790a50c332a83
Reviewed-on: https://review.typo3.org/51280
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Skip main extension repository check in Composer mode 67/51267/3
Mathias Brodala [Wed, 11 Jan 2017 14:41:36 +0000 (15:41 +0100)]
[BUGFIX] Skip main extension repository check in Composer mode

Extensions are not installed and updated from the main extension
repository in Composer mode, thus skip this check completely.

Resolves: #79277
Releases: master, 7.6
Change-Id: I6cb209b5ebae04b7e29b55a52ac61ce0f4b261c2
Reviewed-on: https://review.typo3.org/51267
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[!!!][TASK] Remove TCA l10n_mode=mergeIfNotBlank 39/51239/14
Oliver Hader [Tue, 10 Jan 2017 13:41:26 +0000 (14:41 +0100)]
[!!!][TASK] Remove TCA l10n_mode=mergeIfNotBlank

The TCA setting "l10n_mode=mergeIfNotBlank" for a single
column is removed from the list of values.

The functionality was there to use the value of a field
of the original record, if the value of the translated record
is empty (or trim'ed empty), and is then overlaid.

The new behaviour is to duplicate the behaviour during
the localize process, and then completely separate.

As a result the related TypoScript setting
config.sys_language_softMergeIfNotBlank is not required
anymore and is removed as well.

Resolves: #79243
Releases: master
Change-Id: I55f3ebd2fe2ddd8412101d5496a0da3c5ab64c68
Reviewed-on: https://review.typo3.org/51239
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][FEATURE] Refactoring of FlashMessage rendering 85/50285/22
Susanne Moog [Mon, 9 Jan 2017 22:04:19 +0000 (23:04 +0100)]
[!!!][FEATURE] Refactoring of FlashMessage rendering

This patch reverts some changes of #73698 and adds some new things:

- Introduce context based FlashMessageRenderer
- Add special FlashMessageViewHelper for the backend
- Cleanup classes related to FlashMessages
- Deprecate some methods from the FlashMessages::class

Resolves: #78477
Related: #73698
Releases: master
Change-Id: I937d5896b0a3d45e59c9174d233410f202add997
Reviewed-on: https://review.typo3.org/50285
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Filelist: Renaming: Add a better flash message 03/51203/3
Josef Glatz [Sun, 8 Jan 2017 23:01:08 +0000 (00:01 +0100)]
[TASK] Filelist: Renaming: Add a better flash message

Just add another/meaningful message to the flash message
queue if the file/folder was not really renamed. It just gives a
better feedback to the backend user.

Resolves: #79206
Releases: master
Change-Id: Id2378fdd0f24a94c2260cff9fd7e2cb8feb40eaf
Reviewed-on: https://review.typo3.org/51203
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Filelist: Info dialog shows image dimensions 52/51052/6
Michael Oehlhof [Wed, 28 Dec 2016 08:03:36 +0000 (09:03 +0100)]
[TASK] Filelist: Info dialog shows image dimensions

The file info modal now contains the width and height of images

Resolves: #65822
Releases: master, 7.6
Change-Id: Iadb64ae3db4558bf74f15aaeac1fe29848120563
Reviewed-on: https://review.typo3.org/51052
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add update wizard to remove CLI users 66/51266/4
Benni Mack [Wed, 11 Jan 2017 14:36:03 +0000 (15:36 +0100)]
[TASK] Add update wizard to remove CLI users

The new CLI functionality to use one dedicated CLI user
called _cli_ makes all previous users prefixed with _cli_*
obsolete, as they are not in use anymore.

An update wizard in the install tool sets all _cli_* users
to "deleted=1".

Resolves: #79276
Releases: master
Change-Id: Ie9c72595b5c42106f437e59383d2f1ebc9b7f3a0
Reviewed-on: https://review.typo3.org/51266
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] ResourceCompressor does not persist external resources 70/51270/2
Benni Mack [Wed, 11 Jan 2017 17:05:50 +0000 (18:05 +0100)]
[BUGFIX] ResourceCompressor does not persist external resources

The condition in the ResourceCompressor for fetching
external files never worked, as it was a simple typo
to update an external resource.

So the first time the local file did not exist (and thus, the md5
did not match) and the file was fetched but due to the
wrong check, the file never got updated.

Resolves: #79269
Releases: master, 7.6
Change-Id: If6942284ccd46f400e23d199e827d4e7a696961d
Reviewed-on: https://review.typo3.org/51270
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: David Greiner <hallo@davidgreiner.de>
Tested-by: David Greiner <hallo@davidgreiner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Code cleanup for RteHtmlParser 68/51268/5
Benni Mack [Wed, 11 Jan 2017 15:57:36 +0000 (16:57 +0100)]
[TASK] Code cleanup for RteHtmlParser

Several code parts have been cleaned up and sorted into separate methods
to ensure readability.

Certain options defined by procOptions are now initialized at the very
beginning, before all transformations.

Resolving modes are moved into a separate method, as well as configuring
the entry- and exit-HTML parser, making the main method easier to read.

Cleaning up content and adding <p> tags around "simple" content lines
has been split up as well to avoid code duplication.

Resolves: #79280
Releases: master
Change-Id: Ib734a8cedebff3cc0b415155b6328bf3a77841e9
Reviewed-on: https://review.typo3.org/51268
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][FEATURE] Install tool table row updaters 73/51273/3
Christian Kuhn [Wed, 11 Jan 2017 19:56:22 +0000 (20:56 +0100)]
[FOLLOWUP][FEATURE] Install tool table row updaters

Fix a left over hack and improve comment wording at
a couple of places.

Change-Id: Ida005a7d5889e8aa4afd1e39eb66862f85fd3fbc
Resolves: #79279
Releases: master
Reviewed-on: https://review.typo3.org/51273
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Add possibility to create TRIM expression with Doctrine DBAL 55/51255/5
Oliver Hader [Tue, 10 Jan 2017 22:01:00 +0000 (23:01 +0100)]
[FEATURE] Add possibility to create TRIM expression with Doctrine DBAL

This adds the possibility to create TRIM expressions using the
ExpressionBuilder like shown in the following example:

$queryBuilder->expr()->comparison(
    $queryBuilder->expr()->trim($fieldName),
    ExpressionBuilder::EQ,
    $queryBuilder->createNamedParameter('', \PDO::PARAM_STR)
);

Resolves: #79262
Releases: master
Change-Id: I7813e8a1b0a38ec36797dfbb4fdb02ab78ebe8b2
Reviewed-on: https://review.typo3.org/51255
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FEATURE] Install tool table row updaters 53/51253/5
Christian Kuhn [Tue, 10 Jan 2017 21:38:43 +0000 (22:38 +0100)]
[FEATURE] Install tool table row updaters

Introduce an upgrade wizard in install tool that walks through all
TCA table rows and calls registered row updaters to manipulate single
row data.

Change-Id: I25425e79d966d229da0fa6a181f0eabf97208a70
Resolves: #79279
Releases: master
Reviewed-on: https://review.typo3.org/51253
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] Add hook to add custom TypoScript templates 06/51106/5
Benni Mack [Tue, 3 Jan 2017 12:26:19 +0000 (13:26 +0100)]
[FEATURE] Add hook to add custom TypoScript templates

This hook allows to extend the added TypoScript by adding
custom TypoScript templates (e.g. not loaded from the database)

Resolves: #79140
Releases: master
Change-Id: Ie2350c809685fdc3886f5f77761bad5124baa2bb
Reviewed-on: https://review.typo3.org/51106
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] CacheHashCalculator does not exclude ADMCMD arguments 65/51265/3
Oliver Hader [Wed, 11 Jan 2017 14:17:12 +0000 (15:17 +0100)]
[BUGFIX] CacheHashCalculator does not exclude ADMCMD arguments

ADMCMD arguments are not filtered when calculating the cache-hash
which results in a page not found error. The behavior can be
triggered by creating and opening a preview link in the workspace
module which implicitly sets ADMCMD_previewWS during runtime.

Resolves: #79275
Releases: master, 7.6, 6.2
Change-Id: I339c2787e7de1adf47bb1322c91e0a78c476f790
Reviewed-on: https://review.typo3.org/51265
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Remove RteHtmlParser proc options 64/51264/2
Benni Mack [Wed, 11 Jan 2017 13:05:30 +0000 (14:05 +0100)]
[!!!][TASK] Remove RteHtmlParser proc options

The RTE processing options "dontProtectUnknownTags_rte"
and "dontConvAmpInNBSP_rte" come from a legacy point of
view when transforming from DB to the RTE and have never
been set since TYPO3 4.x as a default for installations.

Additionally the option "dontConvBRtoParagraph" which was used
for setups without RTE where people just wrote plain HTML is
removed, so BR tags are kept as they are (which is a regular use case
in any RTE). This option was set with HtmlArea at all time
(same with other RTEs).

The options are very custom and when transferring data to the RTE
the best practice is applied by default since a decade (original code
was from CVS by Kasper - before the RTE was enabled by default).

Resolves: #79273
Releases: master
Change-Id: Ib05955b7294fc8f5600d91de443f519176b58634
Reviewed-on: https://review.typo3.org/51264
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Extract broken links marker syntax for RTE 58/51258/6
Benni Mack [Wed, 11 Jan 2017 09:25:50 +0000 (10:25 +0100)]
[TASK] Extract broken links marker syntax for RTE

The RTE parser has the following functionality:
- When transforming content from DB to RTE, and <link 13> tag references
a page that does not exist anymore, it adds an attribute rteerror="Page 13
does not exist" and style="background-color: yellow; border:2px red solid;
color: black;" to the then rendered <a> tag.

- When coming back from the RTE to the DB, the <a> tags that do not
contain a "rteerror" attribute but a style attribute are wrapped in
a <span> tag before transforming back to a <link> tag, since the
custom <link> tag cannot contain any other property than href,
class, target and title.
- If both "rteerror" and "style" attributes are still set, they get
removed again.

This approach has several downsides:
- Due to the limitation of the <link> tag an additional <span>
tag gets added to the database (!) which adds hard-coded
styling. The only way to remove this is to disallow "style"
attributes in "span" tags, or to manually remove the span
tags from the database.
- The transformation is not 1:1 the same / are not in sync.
So, if the editor changes the page ID of the broken link
from "13" to any other existing page, the span tag with the
yellow background is still added and kept.
- If the target page 13 gets added back via the recycler, the
span tag needs to be removed from the RTE content again
manually (in source code mode of the RTE)

Instead, the functionality to display broken links is now
handled differently:
- A new transformation "detectbrokenlinks" is added to the RTE
parser which checks all <a> tags with the new link service
class (thus, checks for all ! links not just <link> tags)
- The added attributes which are added to the <a> tag
is removed again (regardless if the link was fixed or not) when
saving the data again in the RTE thus leaving no ugly hard-coded
tags when rendering the content in the frontend, making sure that
content is clean in the database.
- The frontend is now only throwing a TS log message for the admin
panel (as before), and this should be the way to handle broken links
in the future.

Resolves: #79267
Releases: master
Change-Id: I8d0979fe9694d278a3e642a33e66f5decfb46bd8
Reviewed-on: https://review.typo3.org/51258
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][TASK] Remove ExtDirect State Provider 24/51224/8
Benni Mack [Mon, 9 Jan 2017 19:13:09 +0000 (20:13 +0100)]
[!!!][TASK] Remove ExtDirect State Provider

The ExtDirect component for fetching the state (for the pagetree)
can be simplified by simply using the Storage.Persistent logic
which does the same.

For this, a simple inline ExtJS onReady code block is added.

All functionality related to ExtDirect State Provider is removed.

Resolves: #79227
Releases: master
Change-Id: I464ffd0608c1fd38cd81c8324f044da6f4140847
Reviewed-on: https://review.typo3.org/51224
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Doctrine: Consider MySQL index subpart information in upgrade wizards 81/50081/9
Morton Jonuschat [Sun, 2 Oct 2016 00:02:31 +0000 (17:02 -0700)]
[BUGFIX] Doctrine: Consider MySQL index subpart information in upgrade wizards

If an index is defined on a table that is stored on a MySQL database
and uses the MySQL specific subpart length feature add the information
to the schema diff so that the upgrade wizards don't show false
positive changes.

Change-Id: I49eb73c18f7b86aad70d11f3e222c44bd1bd827f
Resolves: #78024
Resolves: #79065
Releases: master
Reviewed-on: https://review.typo3.org/50081
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[FEATURE] Add button to delete similar errors from sys_log 38/51238/16
Mathias Schreiber [Tue, 10 Jan 2017 13:40:45 +0000 (14:40 +0100)]
[FEATURE] Add button to delete similar errors from sys_log

The log module of TYPO3 now shows a button to delete multiple errors at once based on
the `details` field of the `sys_log` table.
This comes in handy when you fixed an error that spammed the log before.

Releases: master
Resolves: #79235
Change-Id: I314abcae454e96b9809c6f4a2fb69b3b926f3118
Reviewed-on: https://review.typo3.org/51238
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Remove unnecessary pageTS config of HtmlArea 60/51260/2
Benni Mack [Wed, 11 Jan 2017 09:37:53 +0000 (10:37 +0100)]
[TASK] Remove unnecessary pageTS config of HtmlArea

HTMLarea defines htmlSpecialChars=0 which is set by default.
If it is overriden by an installation, this can still be done and
does not break anything then.

Resolves: #79268
Releases: master
Change-Id: I39022320d3f4834ceea4a52e3a4e80cd34b90506
Reviewed-on: https://review.typo3.org/51260
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[!!!][TASK] Remove RTE proc option "disableUnifyLineBreaks" 61/51261/2
Benni Mack [Wed, 11 Jan 2017 10:04:40 +0000 (11:04 +0100)]
[!!!][TASK] Remove RTE proc option "disableUnifyLineBreaks"

The RTE option "proc.disableUnifyLineBreaks" was never
set by default.

If NOT set (= default), then all line breaks within the
RteHtmlParser are converted as LF, and then migrated
to CRLFs after all transformations are done.

Activating the option did not do that, thus having problems
when content was entered on different OSes (Windows / Unix)
and leaving with mixed line break data in the database, the
option was historically added to stay compatible with old
versions where the unification was not available yet.

Resolves: #79270
Releases: master
Change-Id: If3b3f48ea7d9ba98882ee340d017296f7b650dda
Reviewed-on: https://review.typo3.org/51261
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use POST for storing uc-related Storage in BE 57/51257/3
Benni Mack [Wed, 11 Jan 2017 01:14:08 +0000 (02:14 +0100)]
[BUGFIX] Use POST for storing uc-related Storage in BE

The AJAX call to store uc settings should be handled
as POST request, and not a GET request to ensure that
even long data can be stored on the server and not
run in Firewall/HTTP GET length restrictions.

Additionally a really bad typo did not allow any
POST requests in UserSettingsController as the key
evaluation was wrong.

Resolves: #79266
Releases: master, 7.6
Change-Id: I0fd10090416b1a16f6a9bdc6a07efceccf147336
Reviewed-on: https://review.typo3.org/51257
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix JS errors in context menu 51/51251/4
Tymoteusz Motylewski [Tue, 10 Jan 2017 21:54:47 +0000 (22:54 +0100)]
[BUGFIX] Fix JS errors in context menu

Fixes two issues: syntax error (missing semicolon),
and "Uncaught TypeError: Cannot read property 'refresh' of undefined"
when e.g. deleting a page or a file.

In file module, refresh is not needed as all actions are refreshing
the frames anyway.

Releases: master, 7.6
Resolves: #79091
Change-Id: Icfc9f786c24099c55d8e60cf30f72f035ae28231
Reviewed-on: https://review.typo3.org/51251
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[FEATURE] Ext:form - extend the extension location functionality 54/51254/3
Ralf Zimmermann [Tue, 10 Jan 2017 22:06:25 +0000 (23:06 +0100)]
[FEATURE] Ext:form - extend the extension location functionality

With this patch is it possible to:

* save existing forms within extension locations
  ("allowedExtensionPaths") if "allowSaveToExtensionPaths"
  is set to true (like before)
* save new created forms within extension locations
  ("allowedExtensionPaths") if "allowSaveToExtensionPaths"
  is set to true
* delete forms within extension locations ("allowedExtensionPaths")
  if "allowDeleteFromExtensionPaths" is set to true

Resolves: #79250
Releases: master
Change-Id: I2d06448f7ee9a0ab0a249ddfee750eda8aeee54e
Reviewed-on: https://review.typo3.org/51254
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Deprecate CommandLineController and Cleaner Command 49/51249/3
Benni Mack [Tue, 10 Jan 2017 20:42:33 +0000 (21:42 +0100)]
[TASK] Deprecate CommandLineController and Cleaner Command

The base classes of the very very old CommandLineController
and the Cleaner Command are deprecated. They are not in
use anymore.

Extbase Command Controllers or Symfony Commands should
be used instead.

Resolves: #79265
Releases: master
Change-Id: I85a975038ce54b5a82069ec57679da9815e6e010
Reviewed-on: https://review.typo3.org/51249
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Remove creation of _cli_scheduler in BE 56/51256/2
Benni Mack [Tue, 10 Jan 2017 23:35:45 +0000 (00:35 +0100)]
[TASK] Remove creation of _cli_scheduler in BE

The _cli_scheduler backend user was necessary before the
introduction of the unified "_cli_" user for all CLI processes.

The scheduler module had an info and functionality to
create such a user which is not needed anymore and
can safely be removed.

Resolves: #79264
Releases: master
Change-Id: Ie2472869b9db1fc9dcb4add9fae6be63722156c6
Reviewed-on: https://review.typo3.org/51256
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[!!!][FEATURE] Migrate Scheduler Cli Controller to Symfony Command 46/51246/5
Benni Mack [Tue, 10 Jan 2017 20:36:40 +0000 (21:36 +0100)]
[!!!][FEATURE] Migrate Scheduler Cli Controller to Symfony Command

The scheduler CLI controller that is triggered via
"typo3/cli_dispatch.phpsh scheduler" is migrated to a Symfony Command,
which also allows the scheduler to be called via
"typo3/sysext/core/bin/typo3 scheduler:run" with the same arguments.

The PHP class TYPO3\CMS\Scheduler\Controller\SchedulerCliController
has been replaced by TYPO3\CMS\Scheduler\Command\SchedulerCommand.

Resolves: #79263
Releases: master
Change-Id: I3f117a5a4d46cffe303f0209ac256d0011afe979
Reviewed-on: https://review.typo3.org/51246
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[!!!][TASK] Remove system extension t3skin 52/51252/5
Wouter Wolters [Tue, 10 Jan 2017 21:00:11 +0000 (22:00 +0100)]
[!!!][TASK] Remove system extension t3skin

The system extension "t3skin" has been slowly trimmed down due to
the native CSS/LESS building of the TYPO3 core into EXT:backend and
EXT:core, and through the IconProvider / IconFactory concepts.

The leftover files, which are mainly related to ExtJS (which
will be removed soon anyway) have been moved to EXT:core for the time
being.

All other images are unused and deleted from the TYPO3 core.

Resolves: #79259
Releases: master
Change-Id: Ic0a0c47999ca57d4e6ea5d7499afc399b307b15f
Reviewed-on: https://review.typo3.org/51252
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Deprecate unused LocalizationRepository methods 45/51245/3
Tymoteusz Motylewski [Tue, 10 Jan 2017 22:07:33 +0000 (23:07 +0100)]
[TASK] Deprecate unused LocalizationRepository methods

After the change https://review.typo3.org/#/c/47645/ was merged
methods getRecordLocalization and getPreviousLocalizedRecordUid
are not needed.

Releases: master
Resolves: #79258
Change-Id: I08fe089ddcaed2a7d879630acd046c8b7c303a06
Reviewed-on: https://review.typo3.org/51245
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Cleanup CLI commands in EXT:backend 47/51247/4
Benni Mack [Tue, 10 Jan 2017 20:38:40 +0000 (21:38 +0100)]
[TASK] Cleanup CLI commands in EXT:backend

* Make backend:unlock and backend:lock a separate class.
* Manually require the CLI user for ReferenceIndexUpdateCommand
* Cleanup the commands.php (as the "user" property is not evaluated anymore)

Resolves: #79261
Releases: master
Change-Id: Id3c90780de0dc299c07c5bca14dd4247b634d53c
Reviewed-on: https://review.typo3.org/51247
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup CLI handling of CLI commands 48/51248/4
Benni Mack [Tue, 10 Jan 2017 20:41:05 +0000 (21:41 +0100)]
[TASK] Cleanup CLI handling of CLI commands

The new _CLI_ user authentication is now explictly
set and required in each command (if a user is needed)
during runtime, and not done by the bootstrap anymore,
so this needs to be called separately.

Additionally, some cleanups to the new
CommandLineUserAuthentication is made.

Resolves: #79260
Releases: master
Change-Id: I6a882d083ec6fd878519c1472702f2a724bd7ed3
Reviewed-on: https://review.typo3.org/51248
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[!!!][TASK] Remove l10n_mode noCopy 35/51235/3
Oliver Hader [Tue, 10 Jan 2017 11:47:54 +0000 (12:47 +0100)]
[!!!][TASK] Remove l10n_mode noCopy

The setting noCopy is removed from the list of possible values
of the TCA column property l10n_mode without any replacement.

Resolves: #79242
Releases: master
Change-Id: If6be272bd71f955a4f3a12c953ffedc55f7e07ac
Reviewed-on: https://review.typo3.org/51235
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Müllenhagen <christianmuellenhagen@yahoo.de>
Tested-by: Christian Müllenhagen <christianmuellenhagen@yahoo.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][FEATURE] Introduce single _cli_ user for all CLI calls 89/51089/6
Benni Mack [Sun, 1 Jan 2017 20:32:54 +0000 (21:32 +0100)]
[!!!][FEATURE] Introduce single _cli_ user for all CLI calls

The command line users prefixing with _CLI_scheduler etc. is flawed,
however a single user is needed for doing e.g. DataHandler calls.

This patch adds a new CommandLineUserAuthentication class, which extends
the regular $BE_USER object to only allow a user called "_cli_" and which
is created automatically if it does not exist, so the _cli_ user always
exists.

Additionally, the _cli_ user is now an admin user so access settings
on command line are obsolete and crucial stuff like the DataHandler can
be used without restrictions.

* Adapt Extbase Bootstrap
* Make sure to have an API to "opt-in" for the need for a user
* Adapt documentation (e.g. in scheduler) because a new user is not needed.

Resolves: #79240
Releases: master
Change-Id: I5a6277fa2252ce6c61f57bbfa26e8be9dc47bbab
Reviewed-on: https://review.typo3.org/51089
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] InstallTool: handle column renames in database compare 85/51085/6
Morton Jonuschat [Sat, 31 Dec 2016 21:07:31 +0000 (13:07 -0800)]
[BUGFIX] InstallTool: handle column renames in database compare

When the Doctrine SchemaMigrator detects an added column and a removed
column that only differ by name but not by configuration these separate
changes get optimized into a column rename operation.

Deoptimize these renames into distinct add/drop column operations to
keep handling of columns consistent when multiple columns change at the
same time.

Resolves: #78771
Releases: master
Change-Id: Ic6d06b99dfb3f33975969be39d904faac5b438a0
Reviewed-on: https://review.typo3.org/51085
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use $ instead of TYPO3.jQuery 12/51212/5
Benni Mack [Mon, 9 Jan 2017 09:15:03 +0000 (10:15 +0100)]
[TASK] Use $ instead of TYPO3.jQuery

In TYPO3 6.0 we introduced TYPO3.jQuery as a possibility to have jQuery
run side-by-side with prototype.js in a no-conflict mode.

Since TYPO3 7.5, prototype.js was removed, and $ can be used.

PageRenderer now sets TYPO3.jQuery AND $ as shorthand-functionality
and all places in the TYPO3 Core are replaced with the common $
functionality, so TYPO3.jQuery should be avoided.

Resolves: #79221
Releases: master
Change-Id: I9177d7d3ad618fa7bb3a7e2ea483f39d6d4231bc
Reviewed-on: https://review.typo3.org/51212
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[!!!][TASK] EXT:form - split typoscript includes 00/51200/8
Josef Glatz [Sun, 8 Jan 2017 14:30:36 +0000 (15:30 +0100)]
[!!!][TASK] EXT:form - split typoscript includes

1) Move backend module specific TypoScript directly to
`EXT:form/ext_typoscript_setup.txt`. It should be loaded
automatically, when EXT:form is installed.

2) Do not load frontend specific TypoScript automatically
and make it available through
`ExtensionManagementUtility::addStaticFile()`. As this method
do only TCA-related changes it's ok to put it into `TCA/Overrides`.

Resolves: #79201
Releases: master
Change-Id: I4c3f51b4bbd0cb472358e97350eed09ecd73f4e6
Reviewed-on: https://review.typo3.org/51200
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>