Packages/TYPO3.CMS.git
3 years ago[BUGFIX] Don't redirect when you click on "save and view" 95/47195/2
Marco Huber [Fri, 11 Mar 2016 14:24:53 +0000 (15:24 +0100)]
[BUGFIX] Don't redirect when you click on "save and view"

Some more page types which should be opened directly and not
redirect to the rootpage if you click on "Save and view".

Resolves: #75020
Related: #66370
Releases: master, 7.6
Change-Id: I278a917c69565e8fe1e175901df01c4cccf9ef98
Reviewed-on: https://review.typo3.org/47195
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Prevent XSS in ViewHelpers 93/47193/5
Nicole Cordes [Fri, 11 Mar 2016 10:17:33 +0000 (11:17 +0100)]
[BUGFIX] Prevent XSS in ViewHelpers

This patch removes wrongly introduced missing escaping in ViewHelpers
and adds some documentation about escaping settings.

Resolves: #75016
Releases: master
Change-Id: If0dbd8a5f7506a78238e6245b1a6f568ec7b3e27
Reviewed-on: https://review.typo3.org/47193
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
3 years ago[BUGFIX] Suggest wizard in FlexForms for new records 23/47223/2
Nicole Cordes [Sat, 12 Mar 2016 11:47:04 +0000 (12:47 +0100)]
[BUGFIX] Suggest wizard in FlexForms for new records

Within new records the suggest wizard doesn't work in FlexForm fields.
Due to unexpected incoming data the field configuration can't be fetched.
This patch ensures sanitized data before fetching FlexForms field
configuration.

Resolves: #73864
Releases: master, 7.6
Change-Id: I7e9a72c2aa6d1efed943845aa2198ce153b75fb8
Reviewed-on: https://review.typo3.org/47223
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
3 years ago[BUGFIX] Fix invalid placeholder in exception message 32/47232/2
Markus Klein [Sun, 13 Mar 2016 16:23:36 +0000 (17:23 +0100)]
[BUGFIX] Fix invalid placeholder in exception message

The message of the ContentRenderingException must use %s
as correct placeholder.

Resolves: #75035
Releases: master, 7.6
Change-Id: Ie78997ead81fc308a4002cffca8dfa0a99b50ac2
Reviewed-on: https://review.typo3.org/47232
Reviewed-by: Dennis Römmich <dennis.roemmich@sunzinet.com>
Tested-by: Dennis Römmich <dennis.roemmich@sunzinet.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years agoRevert "[FEATURE] Info ViewHelpers for page and content information array" 09/47209/3
Nicole Cordes [Fri, 11 Mar 2016 19:37:23 +0000 (20:37 +0100)]
Revert "[FEATURE] Info ViewHelpers for page and content information array"

We do not need those ViewHelpers in the core and they don't work
properly as the getData-methods are never called and escaping is not
turned off.

This reverts commit ca0d46cb6b4bf64b53140db6f2aa70cf89310d65.

Reverts: #38942
Releases: master
Change-Id: Ief1ae8638c37feb822f836892e7444077c97bb83
Reviewed-on: https://review.typo3.org/47209
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
3 years ago[BUGFIX] Store rtehtmlarea_spellchecker in correct route configuration 04/47204/2
Andreas Fernandez [Fri, 11 Mar 2016 17:19:03 +0000 (18:19 +0100)]
[BUGFIX] Store rtehtmlarea_spellchecker in correct route configuration

The RTE route "rtehtmlarea_spellchecker" is an AJAX route, therefore it must
be stored in AjaxRoutes.php.

Change-Id: Ief55ef5e17a72187491d63915e29934e45d5a985
Resolves: #75024
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47204
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Make SingleTasks toggleable from scheduler list view 73/46773/7
Andreas Fernandez [Fri, 19 Feb 2016 11:18:33 +0000 (12:18 +0100)]
[BUGFIX] Make SingleTasks toggleable from scheduler list view

The toggle button for tasks does not work for single tasks. This patch
enables the functionality and registers a single task for execution on
next scheduler run when enabled.

Additionally class constants are introduced for the two available types.

Change-Id: I91c7b24bf141ef6735b3fd38e2859d63634d507e
Resolves: #64708
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46773
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Add unit tests for TYPO3SEARCH markers 75/47175/4
Tymoteusz Motylewski [Thu, 10 Mar 2016 13:44:22 +0000 (14:44 +0100)]
[TASK] Add unit tests for TYPO3SEARCH markers

Add two unit tests for Indexer, covering content extraction
from between TYPO3SEARCH_begin and TYPO3SEARCH_end markers.

Add note to documentation that it's possible to have multiple
TYPO3SEARCH marker pairs.

Resolves: #74815
Releases: master, 7.6, 6.2
Change-Id: I37c67dfc055dc30698831eef6d0231d929fef957
Reviewed-on: https://review.typo3.org/47175
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Initialize T3editor properly 80/46680/4
Andreas Fernandez [Mon, 15 Feb 2016 17:35:21 +0000 (18:35 +0100)]
[BUGFIX] Initialize T3editor properly

If a T3editor is instantiated on-the-fly, it is not initialized properly.
Add a callback to the ``Form/Element/T3editorElement`` class and mark
editor instances as initialized to prevent double initialization.

Change-Id: I8c6b692eb2c132180ed0d122b35515276df5acd9
Resolves: #73425
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46680
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[BUGFIX] Add button styling to clipInsert button 72/47172/2
Andreas Fernandez [Thu, 10 Mar 2016 12:29:33 +0000 (13:29 +0100)]
[BUGFIX] Add button styling to clipInsert button

The button for inserting items from clipboard to a multiselect field has
a proper styling now.

Change-Id: I2360507fb0daedc57e0e1b3a5442af790529039e
Resolves: #74813
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47172
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Properly escape all form attributes in SetupModuleController 43/42643/11
Stefan Neufeind [Fri, 20 Nov 2015 14:34:35 +0000 (15:34 +0100)]
[TASK] Properly escape all form attributes in SetupModuleController

Change-Id: Ia208202e440992e7cf6a21639b83f84205fc2606
Resolves: #69062
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/42643
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
3 years ago[BUGFIX] Check access to cshmanual module 58/46358/9
Marco Huber [Fri, 29 Jan 2016 15:29:57 +0000 (16:29 +0100)]
[BUGFIX] Check access to cshmanual module

Don't render the "more" link in the help popup if the user has no
access to the cshmanual module.

Resolves: #73013
Related: #73009
Releases: master, 7.6
Change-Id: I5b236c08fd505c1f405a3fc0e459c1ac21fbeb84
Reviewed-on: https://review.typo3.org/46358
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
3 years ago[BUGFIX] Unset default link if set with values from other link handler 68/47168/7
Tim Jungebluth [Wed, 9 Mar 2016 20:21:03 +0000 (21:21 +0100)]
[BUGFIX] Unset default link if set with values from other link handler

Change-Id: I49a19d9ca4e08cea927f5541accfade09320210d
Resolves: #74586
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47168
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Load XML files of t3editor properly 73/47173/3
Andreas Fernandez [Thu, 10 Mar 2016 13:10:12 +0000 (14:10 +0100)]
[BUGFIX] Load XML files of t3editor properly

Since the XEE security fix (I26701fc2ffb5aed7ccbd96c168aef571d012091e),
the XML files in the t3editor are not loaded anymore. Change the way how
the files are loaded to fix the issue.

Change-Id: I26c622e47ee0f791b998886837f4443f5bddf11b
Resolves: #74508
Releases: master, 7.6, 6.2
Reviewed-on: https://review.typo3.org/47173
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[TASK] Acceptance tests should be more stable on travis 42/47142/4
Timo Schmidt [Sun, 6 Mar 2016 19:38:41 +0000 (20:38 +0100)]
[TASK] Acceptance tests should be more stable on travis

Increase the stability of the acceptance tests on travis-ci by:

* Use waitFor* instead of see* when possible
* Wait after login for the main navigation and the content iframe
* Setting an implicite wait of 1 second to recude general timing issues

In general from time to time phantomjs stucks with:

SessionManagerReqHand - _cleanupWindowlessSessions -
Asynchronous Sessions clean-up phase starting NOW

This needs further investigation:

https://github.com/ariya/phantomjs/issues/11526

Resolves: #74379
Releases: master
Change-Id: I3465e61a1a8c1c5c2bd5a83e928599606ba28c93
Reviewed-on: https://review.typo3.org/47142
Reviewed-by: Roland Golla <rolandgolla@gmail.com>
Tested-by: Roland Golla <rolandgolla@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Remove igbinary from cache framework 57/47157/4
Mathias Schreiber [Tue, 8 Mar 2016 15:07:41 +0000 (16:07 +0100)]
[TASK] Remove igbinary from cache framework

The patch removes igbinary serializer support from the cache framework.
When igbinary support was added back then in PHP 5.3 times, it had the
potential to serialize data quicker than the default serializer.

Unfortunately, other promises aren't held:
* The module found no general acceptance within the PHP community and
  isn't supported very well. PHP 7 is still not officially supported.
* Last release at the time of this writing was in 2014-08
* The module must still be compiled from source and no recent
  distribution ever packaged it by default
* The maintenance load on devOps side is high: The module must be
  recompiled with each minor php release
* In case the module is not updated, it throws errors at a central place
  of the system and can easily brick a whole instance
* The module found no huge acceptance by hosters and is only very rarely
  used in real life instances
* A performance impact is only measurable in very small and highly
  specialized use cases, it typically plays no role in casual frontend
  or backend requests.

We've seen several life systems in the wild lately with sloppy hosters
not maintaining the igbinary module within their infrastructure properly.
The current implementation with VariableFrontend dynamically detecting
and then force using the module leads to hard crashes in those situations.
The main issue is that serializing is done via PHPs serializer and
unserializing using igbinary then fails, effectively rendering the
entire installation bricked.
To come by those situations, it is considered more important to deliver
a stable product than a product that is quicker in more theoretical use
cases.

Thus, the support for this module is kicked from the standard cache
frontend. In case igbinary still gives significant boost for specialized
specific instances, an admin can still configure a VariableFrontend that
uses this serializer.

Resolves: #74501
Releases: master
Change-Id: I8d4407382c941f66e8c2747a82ec4464b95476f8
Reviewed-on: https://review.typo3.org/47157
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
3 years ago[BUGFIX] Make DataHandler aware of relations behind special=languages 35/46535/3
Markus Klein [Mon, 8 Feb 2016 16:43:58 +0000 (17:43 +0100)]
[BUGFIX] Make DataHandler aware of relations behind special=languages

The special TCA option "languages" makes some other TCA options like
foreign_table unnecessary which have been removed from
the sys_language_uid fields.

But DataHandler relies on the 'foreign_table' setting and therefore
needs some more information to resolve the related table
behind the "languages" option.

Resolves: #73182
Releases: master, 7.6
Change-Id: Id8f7f995d424f69fd5dce8e28cb1fc9db33fa0b0
Reviewed-on: https://review.typo3.org/46535
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
3 years ago[TASK] Remove non-existant hard-coded check for user_ws 40/47140/2
Benni Mack [Sun, 6 Mar 2016 13:15:06 +0000 (14:15 +0100)]
[TASK] Remove non-existant hard-coded check for user_ws

The user_ws module does not exist anymore, and the hard-coded check can be removed.

Resolves: #74377
Releases: master
Change-Id: I1197362690a42da9a33d843019e2401bc4ef29d8
Reviewed-on: https://review.typo3.org/47140
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Jonas Götze <jonnsn@gmail.com>
Tested-by: Jonas Götze <jonnsn@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[FOLLOWUP][TASK] Use variable argument-lists instead of func_get_args() 38/47138/2
Benni Mack [Sun, 6 Mar 2016 13:08:55 +0000 (14:08 +0100)]
[FOLLOWUP][TASK] Use variable argument-lists instead of func_get_args()

Fixed fatal error introduced with the previous patch.

Resolves: #72071
Releases: master
Signed-off-by: Benni Mack <benni@typo3.org>
Change-Id: I3047c448d7526fafd65582fdbe7be196fa3795a4
Reviewed-on: https://review.typo3.org/47138

3 years ago[TASK] Use variable argument-lists instead of func_get_args() 43/45143/5
Benni Mack [Sat, 5 Mar 2016 21:43:05 +0000 (22:43 +0100)]
[TASK] Use variable argument-lists instead of func_get_args()

Supported since PHP 5.6. This makes the code easier to read
and allows to properly document using phpdoc.

https://secure.php.net/manual/en/functions.arguments.php#functions.variable-arg-list

Change-Id: Id04f768635eba7c70f1ea5ba6a7c01d00cb9fafc
Resolves: #72071
Releases: master
Reviewed-on: https://review.typo3.org/45143
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Fluidification of Info Module 29/47129/3
Michael Oehlhof [Sun, 6 Mar 2016 00:42:04 +0000 (01:42 +0100)]
[TASK] Fluidification of Info Module

Moved all HTML code from the PHP code to an own Fluid template.

Resolves: #74360
Releases: master
Change-Id: Ib583695d8b95140347c4107d6183fbbde9f309eb
Reviewed-on: https://review.typo3.org/47129
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Add urldecode for the forgotHash in FrontendLoginController 84/47084/4
Zsolt Molnar [Wed, 3 Feb 2016 10:48:26 +0000 (12:48 +0200)]
[BUGFIX] Add urldecode for the forgotHash in FrontendLoginController

The GET parameter forgothash had to be urlencoded in order to provide
proper, clickable links in emails.
Exploding the hash at the pipe sign broke because it got encoded, thus
no pipe to explode by.

This fix applies a rawurldecode at the explode to avoid side effects.

Resolves: #73060
Releases: master, 7.6
Change-Id: Iffb0db26b591b26ed4c2bf78aa50c8bf1addec2b
Reviewed-on: https://review.typo3.org/47084
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Tested-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[BUGFIX] Ignore cURL proxy header block 79/46779/4
Albrecht Köhnlein [Fri, 19 Feb 2016 14:28:46 +0000 (15:28 +0100)]
[BUGFIX] Ignore cURL proxy header block

When cURL is enabled with a proxy, the proxy’s HTTP header (sent as a
response to the client CONNECT request) was not removed correctly for
https requests.

See also RFC 2817.

Resolves: #73567
Releases: master, 7.6, 6.2
Change-Id: I0f11933f523b099dd23a5bef631699904ffcefc8
Reviewed-on: https://review.typo3.org/46779
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[TASK] Codeception simple tests for admin user 12/46912/14
Roland Golla [Sat, 5 Mar 2016 22:42:01 +0000 (23:42 +0100)]
[TASK] Codeception simple tests for admin user

Resolves: #73566
Releases: master
Change-Id: I294ae235c7e9edcbbfeb838dadaec68722b492ba
Reviewed-on: https://review.typo3.org/46912
Reviewed-by: Timo Schmidt <timo-schmidt@gmx.net>
Tested-by: Timo Schmidt <timo-schmidt@gmx.net>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[!!!][TASK] Remove unused downloadname from sys_file_reference 88/47088/3
Wouter Wolters [Fri, 4 Mar 2016 20:56:50 +0000 (21:56 +0100)]
[!!!][TASK] Remove unused downloadname from sys_file_reference

The field sys_file_reference.downloadname was added with FAL
but never touched or used (nor has it a TCA definition) and is now
removed.

Resolves: #74124
Releases: master
Change-Id: I6ce886fe1e05f30d625b65d5c44fa12c2f523fd7
Reviewed-on: https://review.typo3.org/47088
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] The Scheduler should be tested with an acceptance test 20/47120/5
Timo Schmidt [Sat, 5 Mar 2016 20:58:52 +0000 (21:58 +0100)]
[TASK] The Scheduler should be tested with an acceptance test

Introduces a new test for the scheduler that tests the creation
of a reports scheduler task.

In addition the existing login tests are moved into the "Login" package.

Resolves: #74334
Releases: master
Change-Id: Idce3a7a1f2a798963ad071e6bc0c754807b4959f
Reviewed-on: https://review.typo3.org/47120
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[!!!][TASK] Cleanup dual-use of auth_timeout_field in AbstractUserAuthentication 64/42464/10
Stefan Neufeind [Sun, 9 Aug 2015 18:31:05 +0000 (20:31 +0200)]
[!!!][TASK] Cleanup dual-use of auth_timeout_field in AbstractUserAuthentication

So far the variable could either contain the name of a field or a
timeout-value in seconds.
Introduce a clean integer-field for the timeout and keep the current field
only for the case where a class wants to really fetch the timeout from a
field in the userdata.

Change-Id: I2751e06a315936119478d0dd81cc4c5b1e941368
Resolves: #68890
Releases: master
Reviewed-on: https://review.typo3.org/42464
Reviewed-by: Thomas Mayer <thomas.mayer@2bis10.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Allow calling tests with phpdbg-SAPI 57/45157/4
Stefan Neufeind [Sun, 6 Dec 2015 13:45:51 +0000 (14:45 +0100)]
[TASK] Allow calling tests with phpdbg-SAPI

Using phpdbg with phpunit it a fast way to create code-coverage-reports.

Change-Id: If3a1b2f957af6937d0191b4d9a1e656aac5373a7
Resolves: #72076
Releases: master
Reviewed-on: https://review.typo3.org/45157
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Use simple syntax for labels in module registration 34/47134/3
Benni Mack [Sun, 6 Mar 2016 02:38:13 +0000 (03:38 +0100)]
[TASK] Use simple syntax for labels in module registration

Resolves: #74363
Releases: master
Change-Id: Ic9cd97f5b1dc6654020782e91a49330fb4bfcfbe
Reviewed-on: https://review.typo3.org/47134
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[FEATURE] EXT:form - Allow predefined forms 57/45357/23
Ralf Zimmermann [Sun, 6 Mar 2016 00:57:00 +0000 (01:57 +0100)]
[FEATURE] EXT:form - Allow predefined forms

This patchset enables the integration of predefined forms. An integrator
can define forms - for example within the site package - using
plugin.tx_form.predefinedForms. An editor can add a new mailform
content element to a page and choose a form from the list of predefined
elements.

Example integration:

plugin.tx_form.predefinedForms.someUniqueName = FORM
plugin.tx_form.predefinedForms.someUniqueName {
 ...
}

Resolves: #72309
Releases: master
Change-Id: I79def3cc00812bd5e5006b5226216064cc1b7ac7
Reviewed-on: https://review.typo3.org/45357
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[BUGFIX] Workspace page previews collide with generated preview links 53/45253/4
Oliver Hader [Mon, 14 Dec 2015 21:53:55 +0000 (22:53 +0100)]
[BUGFIX] Workspace page previews collide with generated preview links

Workspace page previews collide with that configuration that might have
been set by using a preview link containing a ADMCMD_prev command. The
keyword "IGNORE" is introduced to actually ignore these configurations
when viewing a page from the workspace module.

Resolves: #72225
Releases: master, 7.6, 6.2
Change-Id: I6a73e860a76308028f0a3b1bcd182e41082adcd6
Reviewed-on: https://review.typo3.org/45253
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] EXT:form - add unitTests for class TypoScriptToJsonConverter 22/47122/6
Sebastian Wagner [Sat, 5 Mar 2016 21:29:57 +0000 (22:29 +0100)]
[TASK] EXT:form - add unitTests for class TypoScriptToJsonConverter

This patch introduces a first test case for TypoScriptToJsonConverter
of EXT:form. The test case asserts that a protected method internally
triggers adding elements to a given and mocked parent element in the
nested form hierarchy.

Resolves: #74337
Releases: master, 7.6
Change-Id: I191ba8fe41a5829e23303447f86303ae8c6dd081
Reviewed-on: https://review.typo3.org/47122
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[BUGFIX] Make environment check standalone 61/42861/11
Mathias Brodala [Tue, 25 Aug 2015 07:45:15 +0000 (09:45 +0200)]
[BUGFIX] Make environment check standalone

The system environment check is supposed to be useable standalone
without any TYPO3 internal requirements.

Move all checks which require a fully set up TYPO3 installation
into a separate class and use it where necessary.

Resolves: #69495
Releases: master
Change-Id: I9f78f8c03a28d18a6daa326b321db721800e7599
Reviewed-on: https://review.typo3.org/42861
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[TASK] Use JsConfirmation enumeration in BackendUserAuthentication 30/43330/7
Andreas Wolf [Sat, 5 Mar 2016 11:56:30 +0000 (12:56 +0100)]
[TASK] Use JsConfirmation enumeration in BackendUserAuthentication

This makes use of the JsConfirmation enumeration to ensure valid values
in BackendUserAuthentication::jsConfirmation.

As combinations of values are allowed, we need to check for all possible
combinations by comparing to an OR-ed bitmask with all possible bits.
Additionally, this fixes a bug where setting the TSconfig option to "0"
would yield a value of 255, which would enable all notifications instead
of disabling them.

Resolves: #69827
Releases: master
Change-Id: I59b8b8de3efb5c33273ea4c7dfdad2ac25473463
Reviewed-on: https://review.typo3.org/43330
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Update: imagesLoaded PACKAGED v3.1.8 -> v4.1.0 76/47076/2
Wouter Wolters [Fri, 4 Mar 2016 18:44:32 +0000 (19:44 +0100)]
[TASK] Update: imagesLoaded PACKAGED v3.1.8 -> v4.1.0

Resolves: #73748
Releases: master
Change-Id: Ic24966b0d8bd60f977d02a60fce11fa68e545a71
Reviewed-on: https://review.typo3.org/47076
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[CLEANUP] Rename AbstractContentObject::getContentObject() 72/42272/12
Andreas Wolf [Fri, 4 Mar 2016 11:56:06 +0000 (12:56 +0100)]
[CLEANUP] Rename AbstractContentObject::getContentObject()

The method is renamed to getContentObjectRenderer(), as this better
reflects what it actually does. The old method is marked as deprecated
and scheduled for removal in v9.

Change-Id: Idaaba8856f7cca31bdc1d5c301a221dee2059048
Resolves: #68748
Releases: master
Reviewed-on: https://review.typo3.org/42272
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[FEATURE] Trigger event after modals dismiss 33/46933/3
Andreas Fernandez [Sat, 27 Feb 2016 21:17:47 +0000 (22:17 +0100)]
[FEATURE] Trigger event after modals dismiss

A new event ``modal-destroyed`` is triggered after modals dismissed.

Change-Id: Id05bf17889889bf1bacbd6a6ad3023923899671d
Resolves: #73720
Releases: master
Reviewed-on: https://review.typo3.org/46933
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] LocalImageProcessor cannot reuse remote files 05/46905/4
Andreas Wolf [Fri, 26 Feb 2016 09:46:39 +0000 (10:46 +0100)]
[BUGFIX] LocalImageProcessor cannot reuse remote files

The LocalImageProcessor had a check for the storage type, to only do a
check for existing files on local storages, as it needed to fetch an
existing file from the storage to get metadata from it.

This check is now replaced by a proper usage of the FAL API: Fetch the
generated file for local (read-only) processing, which in case of a
local storage means the file is not moved at all. Then, the image
metadata can be extracted from the local file and the file index record
of the processed file can be updated accordingly.

Change-Id: I9fca326fe1d1743cd53a0a85c674ff81e5a051b9
Releases: master, 7.6
Resolves: #67126
Reviewed-on: https://review.typo3.org/46905
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Apply image cropping to click-enlarged images 14/46114/5
Oliver Hader [Wed, 20 Jan 2016 18:22:36 +0000 (19:22 +0100)]
[BUGFIX] Apply image cropping to click-enlarged images

Image cropping is not applied to click-enlarged images, neither if
using the lightbox-mode nor the regular mode using tx_cms_showpic.
Cropping is applied in these scenarios as well with transporting
the accordant crop value of the current image being processed.

Resolves: #72798
Releases: master, 7.6
Change-Id: I3e07fc447ac8a35cbe4fbb43bac9adb9bb7ed506
Reviewed-on: https://review.typo3.org/46114
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[!!!][TASK] Clean up ObjectManager injection of CommandController 94/44694/14
Mathias Brodala [Fri, 20 Nov 2015 16:52:22 +0000 (17:52 +0100)]
[!!!][TASK] Clean up ObjectManager injection of CommandController

The ObjectManager injection method was misused to initialize
a lot of objects which are now instantiated separately.

Resolves: #71521
Releases: master
Change-Id: I6509ac064ec39140b841a258c46ad5a021039972
Reviewed-on: https://review.typo3.org/44694
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[BUGFIX] Set correct max-height for RTE 21/47121/2
Marius David Wieschollek [Sat, 5 Mar 2016 21:18:12 +0000 (22:18 +0100)]
[BUGFIX] Set correct max-height for RTE

Also fixes the spelling mistake in the label of the related Backend User Settings Option

Resolves: #74336
Releases: master
Change-Id: I21d00fd2de901eb03111581626c7efc4dec23647
Reviewed-on: https://review.typo3.org/47121
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Reviewed-by: Andreas Bouche <andreas.bouche@flagbit.de>
Tested-by: Andreas Bouche <andreas.bouche@flagbit.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Absolute URIs get prefixed with absRefPrefix in typolink 13/46113/7
Oliver Hader [Wed, 20 Jan 2016 18:18:24 +0000 (19:18 +0100)]
[BUGFIX] Absolute URIs get prefixed with absRefPrefix in typolink

An absolute URI (e.g. "/folder/someFile.png") gets prefixed with
absRefPrefix (e.g. "/") which results in "//folder/someFile.png",
which is a schema-less URI notation and thus "folder" is
interpreted as hostname.

Resolves: #72846
Releases: master, 7.6
Change-Id: Ic49c0a24a17f754c6c89186e6041b9857eb967b1
Reviewed-on: https://review.typo3.org/46113
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[FEATURE] Allow calling toArray() on ObjectStorage using name getArray() 61/46961/3
Claus Due [Mon, 29 Feb 2016 14:17:41 +0000 (15:17 +0100)]
[FEATURE] Allow calling toArray() on ObjectStorage using name getArray()

This change adds an alias method which allows ObjectStorage's
values to be accessed using a "get"-prefixed method name which
in turn allows the values to be addressed using numerical
indices or converted to arrays on-the-fly by adding an ".array"
segment to the property path.

Change-Id: Ibe94910d6043a52c7ef330e18e0330021ecbb325
Resolves: #73752
Releases: master
Reviewed-on: https://review.typo3.org/46961
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] EXT:form - prevent initial ajax call 10/47110/3
Sebastian Wagner [Sat, 5 Mar 2016 17:19:02 +0000 (18:19 +0100)]
[TASK] EXT:form - prevent initial ajax call

Initially, provide the whole configuration for the wizard through a
requireJs config. Therefore, an early AJAX call to the WizardController
can be omitted.

With this patchset, no AJAX route for loading has to be registered. The
loadAction is removed as well. Furthermore, a left over intialize script
is dropped. The Wizard.Settings to configure the ExtJs viewport are used
directly.

Resolves: #74316
Releases: master
Change-Id: I5278784cadc603238707b6e7b26426155e3c080c
Reviewed-on: https://review.typo3.org/47110
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Copy is missing in pagetree context menu without edit permissions 93/46893/3
Gianluigi Martino [Thu, 25 Feb 2016 13:47:38 +0000 (14:47 +0100)]
[TASK] Copy is missing in pagetree context menu without edit permissions

Show copy option in pagetree context menu also without edit permission

Change-Id: Icefaa7ef775fa5eb23652e00fe7643ae863c0e19
Resolves: #73470
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46893
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[FEATURE] Activated D&D copy by pressing the CTRL key while dropping 62/47062/10
Jo Hasenau [Fri, 4 Mar 2016 16:31:29 +0000 (17:31 +0100)]
[FEATURE] Activated D&D copy by pressing the CTRL key while dropping

Resolves: #74179
Releases: master
Change-Id: I93864236f179b57cc0b1cbf67ce9941da096986a
Reviewed-on: https://review.typo3.org/47062
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Fix date conversion of neg timestamps 15/47115/2
Daniel Maier [Sat, 5 Mar 2016 18:57:21 +0000 (19:57 +0100)]
[BUGFIX] Fix date conversion of neg timestamps

Date conversion of TCA fields with eval "date" or "datetime" is now also
handled correctly for dates before 1970, thus having a negative
timestamp. Timezone offset is now also applied for those negative
timestamps, in order to prevent erroneous data for dates before 1970.

Resolves: #73871
Releases: master, 7.6
Change-Id: I4de9911dec3de720992da137fe8afcb3ecbfdad7
Reviewed-on: https://review.typo3.org/47115
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[BUGFIX] Fix slide function of cObject 89/47089/4
Jo Hasenau [Fri, 4 Mar 2016 21:06:28 +0000 (22:06 +0100)]
[BUGFIX] Fix slide function of cObject

Move variable value association to correct position.

Resolves: #69941
Releases: master, 7.6
Change-Id: I8bca6203f4e994a86b11f5d3be54b83e7dfdd73c
Reviewed-on: https://review.typo3.org/47089
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Check if selected page is available before loading BE module 23/44923/10
Michael Oehlhof [Mon, 23 Nov 2015 23:14:07 +0000 (00:14 +0100)]
[BUGFIX] Check if selected page is available before loading BE module

If a formerly selected page (in page tree) is not available anymore
(e.g. deleted), any access to a backend module will now check
this condition and will avoid an error.
An empty module will be displayed in such a case.

Resolves: #66449
Releases: master, 7.6
Change-Id: I4caf6abf715af2009705caf126f2614ae5cde9ed
Reviewed-on: https://review.typo3.org/44923
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] EXT:form - prevent duplicate call to getRecordAsJson 12/47112/2
Sebastian Wagner [Sat, 5 Mar 2016 17:54:59 +0000 (18:54 +0100)]
[BUGFIX] EXT:form - prevent duplicate call to getRecordAsJson

We prevent getRecordAsJson to be called twice when rendering element.
Fix annotations of for return values of JSON elements

Resolves: #74331
Change-Id: Ib4826ebeee33f91c18db230d1aba2ffe39070ea1
Reviewed-on: https://review.typo3.org/47112
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Switched D&D back from sortable to draggable and adjusted dropzones 58/47058/5
Jo Hasenau [Fri, 4 Mar 2016 14:48:45 +0000 (15:48 +0100)]
[TASK] Switched D&D back from sortable to draggable and adjusted dropzones

Resolves: #66540
Releases: master
Change-Id: I982bb63a14409fd4510126d3d4b88ee85562967e
Reviewed-on: https://review.typo3.org/47058
Reviewed-by: Marius Wieschollek <marius.typo3@mdns.eu>
Tested-by: Marius Wieschollek <marius.typo3@mdns.eu>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Karthikeyan Palaniswamy <karthikeyan@forethought.de>
Tested-by: Karthikeyan Palaniswamy <karthikeyan@forethought.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Reinsert ommitted vars for ternary operators 08/47108/2
Jo Hasenau [Sat, 5 Mar 2016 16:55:38 +0000 (17:55 +0100)]
[BUGFIX] Reinsert ommitted vars for ternary operators

When the check is done with multiple variables omitting the first part
of a ternary operator just inserts the boolean result of the check
but not the variable

Change-Id: If683770435995cac079fb2fd42344ba1cc15a08f
Resolves: #70242
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/47108
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Karthikeyan Palaniswamy <karthikeyan@forethought.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] DataHandler: Use the updated field to determine record type 62/46162/4
Hannes Lau [Fri, 22 Jan 2016 17:51:20 +0000 (18:51 +0100)]
[BUGFIX] DataHandler: Use the updated field to determine record type

Use the new, updated field values of the current record, to determine
its type value. This allows to pick the correct RTE configuration
for new records with non-default types.

Fixes: #72898
Releases: master, 7.6
Change-Id: If519a9c9357034977ede40d7b709a7d83a3e92c8
Reviewed-on: https://review.typo3.org/46162
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Tested-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Tested-by: Jonas Götze <jonnsn@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[BUGFIX] Show the copy option in the page browser contextual menu 06/47106/2
eugen_lang [Sat, 5 Mar 2016 15:40:05 +0000 (16:40 +0100)]
[BUGFIX] Show the copy option in the page browser contextual menu

Resolves: #33147
Releases: master, 7.6
Change-Id: I98c696eb58c759f6c50dbaf111556b86cffe0e93
Reviewed-on: https://review.typo3.org/47106
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Karthikeyan Palaniswamy <karthikeyan@forethought.de>
Tested-by: Karthikeyan Palaniswamy <karthikeyan@forethought.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[FEATURE] Check database default charset 03/47103/5
Jonas Götze [Sat, 5 Mar 2016 14:23:43 +0000 (15:23 +0100)]
[FEATURE] Check database default charset

Checks the default database charset during installation and provides
Upgrade Wizard to fix default charset.

Resolves: #74319
Releases: master
Change-Id: I645c0dc321a719e2149b8474e4292c80811fd82c
Reviewed-on: https://review.typo3.org/47103
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Tested-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[FEATURE] Add a CSPRNG 07/46507/7
Christian Futterlieb [Sun, 31 Jan 2016 20:09:20 +0000 (21:09 +0100)]
[FEATURE] Add a CSPRNG

* Add a simple API for generation of random bytes, integers and
  hex-strings: Crypto\Random
* Deprecate the methods GeneralUtility::generateRandomBytes() and
  GeneralUtility::getRandomHexString()
* Replace occurrences of the deprecated methods

Change-Id: If4d6daa00138eac791954a4fd9a4fc26a79ddf07
Resolves: #73050
Releases: master
Reviewed-on: https://review.typo3.org/46507
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
3 years ago[TASK] Clean up typolink target and linktxt 95/47095/3
Benni Mack [Sat, 5 Mar 2016 12:59:20 +0000 (13:59 +0100)]
[TASK] Clean up typolink target and linktxt

Rename $linktxt to $linkText.
Only evaluate target if forceTarget is not set.

Add a small helper method to call parseFunc on empty
$linkText that is used in 4 places within typoLink().

Resolves: #74318
Releases: master
Change-Id: I043ba3192be83ec6acf28cb88a287be1b8cd74fa
Reviewed-on: https://review.typo3.org/47095
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Tested-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years agoRevert "[BUGFIX] Fix date conversion of neg timestamps" 07/47107/4
Christian Kuhn [Sat, 5 Mar 2016 16:18:14 +0000 (17:18 +0100)]
Revert "[BUGFIX] Fix date conversion of neg timestamps"

This reverts commit 41b350dc84876c282a7309911287622591b05995.

Default values do not work well.

Change-Id: Idfadf5482d12e2f51fa14aa574061c0c2b65176d
Reviewed-on: https://review.typo3.org/47107
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Denied file extensions still shown in upload forms 72/46072/6
Marco Huber [Tue, 19 Jan 2016 09:54:54 +0000 (10:54 +0100)]
[BUGFIX] Denied file extensions still shown in upload forms

The list of denied file extensions does not contain a dot, but our
fileDenyPattern by default starts with a dot. Therefore, although a
check is performed, the file extensions will still be displayed even
though uploading files with the extension is forbidden by
fileDenyPattern.

This commit adds the dot before the extension when performing the
check, effectively hiding forbidden extensions.

Resolves: #72803
Releases: master, 7.6
Change-Id: I2ec3d02e096b46309932604a53ea4c416ba9812a
Reviewed-on: https://review.typo3.org/46072
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[BUGFIX] Hide view-button in access module 18/41718/6
Andreas Bouche [Sat, 5 Mar 2016 13:37:36 +0000 (14:37 +0100)]
[BUGFIX] Hide view-button in access module

Editing permissions in the access module has no effect on the frontend.
Therefore, the view button is unnecessary here.

Resolves: #68376
Releases: master
Change-Id: Ic5f48320ca54e46e89c8f3b740b457cfcfbbaaae
Reviewed-on: https://review.typo3.org/41718
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Bouche <andreas.bouche@flagbit.de>
Tested-by: Andreas Bouche <andreas.bouche@flagbit.de>
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Tested-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Fix date conversion of neg timestamps 25/47025/6
Daniel Maier [Thu, 3 Mar 2016 20:17:21 +0000 (21:17 +0100)]
[BUGFIX] Fix date conversion of neg timestamps

Date conversion of TCA fields with eval "date" or "datetime" is now also
handled correctly for dates before 1970, thus having a negative
timestamp. Timezone offset is now also applied for those negative
timestamps, in order to prevent erroneous data for dates before 1970.

Furthermore validation handling for dates with zero timestamp
(01.01.1970 midnight UTC) is fixed.

Resolves: #73871
Releases: master, 7.6
Change-Id: Iffa2f12c6941fe17b956202fe9c49f811b1b0539
Reviewed-on: https://review.typo3.org/47025
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Remove leftover FormEngine TSconfig values 22/46822/4
Benni Mack [Tue, 23 Feb 2016 07:01:26 +0000 (08:01 +0100)]
[TASK] Remove leftover FormEngine TSconfig values

Several infos in TSconfig / FormEngine are never used,
the field "storage_pid" does not even exist anymore in v8
(was moved to compatibility6 for v7).

Resolves: #73612
Releases: master
Change-Id: Iec578faa6dc591ad39eddcfbb8c6d06910e13950
Reviewed-on: https://review.typo3.org/46822
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[BUGFIX] Improve DataHandler handling for dbType fields 26/46426/3
Nicole Cordes [Mon, 1 Feb 2016 10:26:35 +0000 (11:26 +0100)]
[BUGFIX] Improve DataHandler handling for dbType fields

Currently we have some issues with handling database fields with type
"date" or "datetime". Those fields can't have an empty default value
in the database but might have defined default values or null. This
patch adds proper handling for both default value cases.

Resolves: #72654
Resolves: #62660
Releases: master, 7.6, 6.2
Change-Id: I429bf4fdfa32531c0034e8346ee11d3d1fb81242
Reviewed-on: https://review.typo3.org/46426
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[BUGFIX] Allow images for HtmlArea in demo mode 92/47092/2
Benni Mack [Sat, 5 Mar 2016 10:27:39 +0000 (11:27 +0100)]
[BUGFIX] Allow images for HtmlArea in demo mode

PageTSconfig was only included in Typical and Advanced
mode resulting in an exception when adding images in
the RTE with Demo mode enabled (via Extension Manager).

Resolves: #74314
Releases: master, 7.6
Change-Id: Ieaffc7faa5cca1f910d1b00fd87e4ae4585889d6
Reviewed-on: https://review.typo3.org/47092
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Tested-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] Move moduleLabels to ModuleLoader 02/46702/10
Benni Mack [Tue, 16 Feb 2016 10:54:01 +0000 (11:54 +0100)]
[TASK] Move moduleLabels to ModuleLoader

Already translated module labels were previously resolved
and stored within $GLOBALS[LANG]. Several checks
and calls were then made to ModuleLoader and $LANG.

All information about the module, as well as all labels
are now stored within ModuleLoader, a addLabelsForModule()
method and a getLabelsForModule() method are placed within
that method, where labels are stored (but not resolved
to the language yet). The language service then is only used
when outputting the labels in various places.

The method $LANG->addModuleLabels() and the public
property $LANG->moduleLabels were deprecated.

Resolves: #72340
Releases: master
Change-Id: I82f01e7641b1395d81895d246ef22f11206d927d
Reviewed-on: https://review.typo3.org/46702
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
3 years ago[FEATURE] Info ViewHelpers for page and content information array 73/46473/13
Claus Due [Wed, 3 Feb 2016 22:25:26 +0000 (23:25 +0100)]
[FEATURE] Info ViewHelpers for page and content information array

Adds ViewHelpers ``f:info.page`` and ``f:info.content`` which return
or assign content or page information arrays respectively depending
on usage of the ``as`` argument as known from other helpers.

Change-Id: Idfa5b68b37e926593072ddf75e6d143a2c5037f8
Releases: master
Resolves: #38942
Reviewed-on: https://review.typo3.org/46473
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
3 years ago[BUGFIX] Ensure t3d compatibility for supported TYPO3 version 32/47032/2
Nicole Cordes [Fri, 4 Mar 2016 09:33:48 +0000 (10:33 +0100)]
[BUGFIX] Ensure t3d compatibility for supported TYPO3 version

This patch fixes an issue with unclean t3d export due to string to array
conversion. This is important to be able to import a t3d files which was
exported with 7.6 and above even in 6.2. This is needed as we do not
have any chance to see which TYPO3 version was used for the export.

Resolves: #74127
Releases: master, 7.6, 6.2
Change-Id: I6ba7b825241c2ca439c485aaf597b019b7ac8997
Reviewed-on: https://review.typo3.org/47032
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[BUGFIX] Make ClickEnlargeViewHelper output data again 85/46985/2
Wouter Wolters [Tue, 1 Mar 2016 19:03:09 +0000 (20:03 +0100)]
[BUGFIX] Make ClickEnlargeViewHelper output data again

Resolves: #73814
Releases: master
Change-Id: I3176797c4817a34f78aa68118098ae97d37fd1a2
Reviewed-on: https://review.typo3.org/46985
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Update: bootstrap-slider.js 5.2.4 -> 6.1.2 74/47074/2
Wouter Wolters [Fri, 4 Mar 2016 18:37:36 +0000 (19:37 +0100)]
[TASK] Update: bootstrap-slider.js 5.2.4 -> 6.1.2

Resolves: #73746
Releases: master
Change-Id: I2a535798cbec2f92a82604d89be89b00e859386f
Reviewed-on: https://review.typo3.org/47074
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[!!!][TASK] Remove unused csConv parameters 04/47004/5
Benni Mack [Thu, 3 Mar 2016 11:05:56 +0000 (12:05 +0100)]
[!!!][TASK] Remove unused csConv parameters

There are several additional parameters that are not used
anymore.

CharsetConverter->entities_to_utf8() - now always
CharsetConverter->utf8_to_numberarray() now always
converts entities, and real UTF-8 characters are returned

Resolves: #74031
Releases: master
Change-Id: I6ee4e74bb9122a2ac8b9843a7026c933d7199381
Reviewed-on: https://review.typo3.org/47004
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
3 years ago[BUGFIX] Only show preview of non-hidden images 35/46735/5
Gianluigi Martino [Tue, 16 Feb 2016 22:19:08 +0000 (23:19 +0100)]
[BUGFIX] Only show preview of non-hidden images

Don't show preview of hidden images in backend e.g.
page module.

Change-Id: I11fbfdbdf9767066dbb3380b543d79c239e6c4a2
Resolves: #73481
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46735
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Incompatible declaration of PreviewController::initializeView 90/46990/2
Andreas Fernandez [Wed, 2 Mar 2016 09:37:12 +0000 (10:37 +0100)]
[BUGFIX] Incompatible declaration of PreviewController::initializeView

The declaration of PreviewController::initializeView is changed to be
functional with PHP 7.

Change-Id: I4b59600aa3d98dec6440551f4228c9aad6fd6714
Resolves: #73866
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46990
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[TASK] EXT:form - Optimize preview in page module 82/47082/2
Björn Jacob [Fri, 4 Mar 2016 20:01:20 +0000 (21:01 +0100)]
[TASK] EXT:form - Optimize preview in page module

This patchset optimizes the preview of a form
elements in the page module. The output of the bodytext
field has been removed. Instead, the ctype is shown.
This avoids the useless display of TypoScript in the
preview.

Resolves: #28403
Releases: master, 7.6
Change-Id: I09a18e6b8a782a50a2ea7570b41fe2abc10df835
Reviewed-on: https://review.typo3.org/47082
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Update moment-timezone to 0.5.1 77/47077/2
Wouter Wolters [Fri, 4 Mar 2016 18:47:35 +0000 (19:47 +0100)]
[TASK] Update moment-timezone to 0.5.1

Resolves: #74186
Releases: master
Change-Id: I8152debaf71c92347f153b444400d46c986156f2
Reviewed-on: https://review.typo3.org/47077
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[TASK] Increased default visibility of column header icons 44/47044/4
Jo Hasenau [Fri, 4 Mar 2016 12:02:36 +0000 (13:02 +0100)]
[TASK] Increased default visibility of column header icons

Resolves: #74148
Releases: master
Change-Id: I00c08d407a9865043278f42ba79a4de01cb71c45
Reviewed-on: https://review.typo3.org/47044
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Tested-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[TASK] Make search levels in live search and list search consistent 71/44171/12
Marcus Schwemer [Mon, 19 Oct 2015 23:25:42 +0000 (01:25 +0200)]
[TASK] Make search levels in live search and list search consistent

Live search searches through the whole system, while list search
is limited to four levels.
Solution:
* Add default pageTS for search levels
* Live search "Show all" now uses "-1" for infinite search

Resolves: #70849
Releases: master
Change-Id: Ibf8b043da26e58bbe0df18fb2013934da5ec64f3
Reviewed-on: https://review.typo3.org/44171
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Missing typo3temp/var/transient breaks thumbnail generation 81/47081/5
Michiel Roos [Fri, 4 Mar 2016 20:02:32 +0000 (21:02 +0100)]
[BUGFIX] Missing typo3temp/var/transient breaks thumbnail generation

The generation of preview images fails because the directory
typo3temp/var/transient does not exist and is not automatically created.

Change-Id: I905ebc5e4e886276eb907221c09fbe582119a148
Resolves: #74200
Releases: master
Reviewed-on: https://review.typo3.org/47081
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Avoid memory leak during file searches 95/46395/2
Alexander Schnitzler [Sat, 30 Jan 2016 13:10:11 +0000 (14:10 +0100)]
[BUGFIX] Avoid memory leak during file searches

During the file search in the file module the search result
is only limited to possibly matching folders. That itself
decreases the search over all files in a storage but it
still does not prevent memory leaks, where the result
of possible folders contain a decent amount of files.

Example:
fileadmin has a total of 10.000 files.
fileadmin has a subfolder called foo
fileadmin/foo holds a subset of 1000 files.
fileadmin/foo holds the file bar

A search for bar asks the database for all folders that contain
files with the matching identifier bar. As a result, only the
folder fileadmin/foo is returned which already excludes 9000
possible files.

Still, the resultset contains 1000 files, whoose name is
compared php-wise with the search string. During that
foreach loop each a file object with a decent memory
footprint will be created. This easily exceeds the
available memory limit.

Resolves: #73032
Releases: master, 7.6
Change-Id: Icf46e05274c671db344797d207afefc029c5fb5b
Reviewed-on: https://review.typo3.org/46395
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[TASK] Remove leftover icon resolving code 31/47031/6
Benni Mack [Fri, 4 Mar 2016 08:34:17 +0000 (09:34 +0100)]
[TASK] Remove leftover icon resolving code

Icons within the TCA (iconfile and icons in options) are handled
by the IconRegistry.

The TcaMigration takes care of that.

The code within FormEngine can thus be removed as it is never
executed.

Resolves: #74157
Releases: master
Change-Id: Ia79349193f4a5da0e7046bd63e2221a9e7759d79
Reviewed-on: https://review.typo3.org/47031
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] EXT:form Validation of email 59/47059/6
Florian Mast [Fri, 4 Mar 2016 14:53:07 +0000 (15:53 +0100)]
[BUGFIX] EXT:form Validation of email

Validation of email should respect empty value

Resolves: #54534
Releases: master,7.6
Change-Id: I40c865b42fe7960dd7ab85f710df1045cd04adf0
Reviewed-on: https://review.typo3.org/47059
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[TASK] Use new confirmation dialog for ClickMenu 54/47054/7
Frank Naegler [Fri, 4 Mar 2016 14:29:30 +0000 (15:29 +0100)]
[TASK] Use new confirmation dialog for ClickMenu

Resolves: #72617
Releases: master, 7.6
Change-Id: I0cf662d55303504d094426dbb82943d437035044
Reviewed-on: https://review.typo3.org/47054
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[BUGFIX] Adjust UserAgent checks in RTE to detect Edge correctly 37/47037/2
Benjamin Kott [Fri, 4 Mar 2016 10:27:02 +0000 (11:27 +0100)]
[BUGFIX] Adjust UserAgent checks in RTE to detect Edge correctly

Resolves: #70373
Releases: master, 7.6, 6.2
Change-Id: I8cb505a051ecfbc0f423d32cbc121545cec35bf4
Reviewed-on: https://review.typo3.org/47037
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[BUGFIX] Keep selected page active after save & close 28/47028/4
Gianluigi Martino [Thu, 3 Mar 2016 21:32:01 +0000 (22:32 +0100)]
[BUGFIX] Keep selected page active after save & close

Keep the currently selected page active when editing the page properties
of another page as non-admin user.

Change-Id: Iad438ad7e20ab8d818286053557ade26542d8216
Resolves: #71094
Releases: master, 7.6, 6.2
Reviewed-on: https://review.typo3.org/47028
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[BUGFIX] Solves PHP warning in FileAllowedTypesValidator 87/46787/7
Florian Mast [Fri, 4 Mar 2016 11:44:02 +0000 (12:44 +0100)]
[BUGFIX] Solves PHP warning in FileAllowedTypesValidator

Resolves: #72890
Resolves: #73618
Releases: master, 7.6
Change-Id: Ida8a9ace681b93d1d66b0e06c893a83e549f8411
Reviewed-on: https://review.typo3.org/46787
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
3 years ago[FEATURE] EXT:form - Directly load form wizard inline 24/43324/33
Sebastian Wagner [Thu, 3 Mar 2016 20:57:37 +0000 (21:57 +0100)]
[FEATURE] EXT:form - Directly load form wizard inline

This patchset optimizes the form wizard.

The wizard is loaded directly as inline wizard. There is no need anymore
to save and reload the newly created content element in order to be able
to open the wizard. This is a huge usability improvement.
Additionally there is no need to provide individual doc headers. Instead,
the centralized doc headers can be used.

The whole integration utilizes the nodeRegistry of formEngine and
registers the wizard as new render type.

Furthermore, all JavaScript is loaded via require.js.

Since integrators and editors had massive problems with overriden form
configuration the wizard cannot be deactivated anymore. Instead, the
user is globally able to configure the usage of the wizard within the
user settings.

Since it is no longer used we also drop the class WizardView.

Resolves: #69394
Releases: master
Change-Id: I571461b8abf50060791b2f32833d99488eaddaf4
Reviewed-on: https://review.typo3.org/43324
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Restore rounded corners on module icons 11/47011/2
Thorsten Griebenow [Thu, 3 Mar 2016 15:32:09 +0000 (16:32 +0100)]
[BUGFIX] Restore rounded corners on module icons

Resolves: #74013
Releases: master
Change-Id: Id2196daa32dbfae8cf096acb620afc1ab7e378b4
Reviewed-on: https://review.typo3.org/47011
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
3 years ago[TASK] Remove fileinfo as dependency in SystemEnvironment/Check 63/47063/3
Timo Schmidt [Fri, 4 Mar 2016 15:08:22 +0000 (16:08 +0100)]
[TASK] Remove fileinfo as dependency in SystemEnvironment/Check

Currenty 'fileinfo' is listed as required php extension in
SystemEnvironment/Check but it is currently not really required
and prevents from installing TYPO3 on Systems where it is not
present (e.g. Mircosoft Azure Cloud)

The class is currently only used once in the core in
"TYPO3\CMS\Core\Type\File\FileInfo" and only when it exists,
so it is not really a hard dependency.

Also grepping on an installation folder does not find any match
where \finfo is really required.

Resolves: #74177
Releases: master, 7.6
Change-Id: I125cd3e8d0eb6f208641375ea71b89917284f8b3
Reviewed-on: https://review.typo3.org/47063
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
3 years ago[FOLLOWUP][FEATURE] Report wrong database character set 64/47064/4
Jonas Götze [Fri, 4 Mar 2016 15:41:14 +0000 (16:41 +0100)]
[FOLLOWUP][FEATURE] Report wrong database character set

This adds the Feature ReST-File and fixes to small whitespace issues

Resolves: #74038
Releases: master
Change-Id: I885db774de249c1e9bd9963c1266934884e5c396
Reviewed-on: https://review.typo3.org/47064
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Replace confirm in FileList->linkClipboardHeaderIcon 56/47056/3
Frank Naegler [Fri, 4 Mar 2016 14:41:51 +0000 (15:41 +0100)]
[TASK] Replace confirm in FileList->linkClipboardHeaderIcon

Resolves: #74178
Releases: master, 7.6
Change-Id: Iaa077ae648375e94abce90923d876128b19a3db7
Reviewed-on: https://review.typo3.org/47056
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] EXT:form - Fix CHECKBOXGROUP and RADIOGROUP in form wizard 10/45410/6
Andreas Häfner [Tue, 22 Dec 2015 16:23:05 +0000 (17:23 +0100)]
[BUGFIX] EXT:form - Fix CHECKBOXGROUP and RADIOGROUP in form wizard

Fixes a JS error, which appeared when adding a CHECKBOXGROUP or
RADIOGROUP within the form wizard.

Furthermore it applies "text" instead of "data" which was already
changed for TEXTAREA and OPTION elements (as discussed in #69369).

Resolves: #72316
Releases: master, 7.6
Change-Id: I758ad36530ea29ca5469e510367fdedde34c5bd6
Reviewed-on: https://review.typo3.org/45410
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Florian Mast <flo.mast@web.de>
Reviewed-by: Florian Mast <flo.mast@web.de>
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Declare ``items`` for each RTE instance 82/46982/2
Florian Busch [Tue, 1 Mar 2016 13:04:59 +0000 (14:04 +0100)]
[BUGFIX] Declare ``items`` for each RTE instance

The variable ``items`` was declared in a prototype instance and thus
shared between all RTE instances. Declare the variable in its own
instance instead.

Change-Id: Ia6f8b5dffb19121ed8995afcc2124b0084be5f7a
Resolves: #68392
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/46982
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Eugen Lang <laeu1011+gerrit@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[!!!][TASK] Convert thumbnails only for non-image files 80/46480/15
Eric Chavaillaz [Thu, 4 Feb 2016 10:43:48 +0000 (11:43 +0100)]
[!!!][TASK] Convert thumbnails only for non-image files

The global option "thumbnails_png" must only be taken
into account if the processed file is not an image.

Resolves: #73106
Releases: master
Change-Id: I9d806631331924f680d4d7834136e6860c6d95d8
Reviewed-on: https://review.typo3.org/46480
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
3 years ago[BUGFIX] Avoid error message on unlimited upload_max_filesize 29/47029/4
Andreas Bouche [Thu, 3 Mar 2016 21:33:36 +0000 (22:33 +0100)]
[BUGFIX] Avoid error message on unlimited upload_max_filesize

Resolves: #73214
Releases: master, 7.6
Change-Id: I9496964ffd9daeb2c330f022c876f6aceacced1c
Reviewed-on: https://review.typo3.org/47029
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[FEATURE] Report wrong database character set 16/47016/4
Andreas Wolf [Thu, 3 Mar 2016 17:27:00 +0000 (18:27 +0100)]
[FEATURE] Report wrong database character set

This adds a new report to the reports module that checks if the MySQL
database uses the right character set.

Change-Id: I5e5d8b4767accb74f3cbfb8eb4c9f4824dfd7eca
Resolves: #74038
Releases: master
Reviewed-on: https://review.typo3.org/47016
Reviewed-by: Jonas Götze <jonnsn@gmail.com>
Tested-by: Jonas Götze <jonnsn@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TAKS] Add json as composer dependency 06/47006/5
Tymoteusz Motylewski [Thu, 3 Mar 2016 12:58:08 +0000 (13:58 +0100)]
[TAKS] Add json as composer dependency

PHP extension json is now listed as dependency
 in composer.json. Extension mysqli is added to
 "suggest" section.

Resolves: #74005
Releases: master, 7.6
Change-Id: Iae0f388a4b10a24e98c392f878381d753971acdb
Reviewed-on: https://review.typo3.org/47006
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Deprecate TemplateService methods 39/47039/5
Benni Mack [Fri, 4 Mar 2016 12:23:24 +0000 (13:23 +0100)]
[TASK] Deprecate TemplateService methods

The static method TemplateService::sortedKeyList is moved
to ArrayUtility::filterAndSortByNumericKeys.

The method TemplateService->removeQueryString() is
marked as deprecated.

Resolves: #74156
Releases: master
Change-Id: Ifcb5a9f0db9a923000c14b6e33c12aafeaf5fef9
Reviewed-on: https://review.typo3.org/47039
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Add backend routes to configuration module 48/47048/3
Frank Naegler [Fri, 4 Mar 2016 12:57:04 +0000 (13:57 +0100)]
[TASK] Add backend routes to configuration module

This patch add the backend routes to the configuration module, to show all
current active backend routes.

Resolves: #74164
Releases: master, 7.6
Change-Id: I5c191d1d8dc8b002ea1a66a33b6628f7eec9994c
Reviewed-on: https://review.typo3.org/47048
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
3 years ago[TASK] Update jQuery to 2.2.1 40/47040/2
Wouter Wolters [Fri, 4 Mar 2016 11:08:26 +0000 (12:08 +0100)]
[TASK] Update jQuery to 2.2.1

Resolves: #73749
Releases: master
Change-Id: I02d619be365bd54ab4015aeb94872f07b1eebd6a
Reviewed-on: https://review.typo3.org/47040
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[FOLLOWUP][FEATURE] Allow Backend Logo to be set via extConf 42/47042/5
Björn Jacob [Fri, 4 Mar 2016 13:30:59 +0000 (14:30 +0100)]
[FOLLOWUP][FEATURE] Allow Backend Logo to be set via extConf

The new PHP 7 syntax introduced also returns an empty
string, if set but empty.

Resolves: #74109
Releases: master
Change-Id: If902ea201cb49578ab2109b40de90c37dcb63b5d
Reviewed-on: https://review.typo3.org/47042
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
3 years ago[BUGFIX] Allow overriding of Backend Routes 05/47005/2
Benni Mack [Thu, 3 Mar 2016 11:47:11 +0000 (12:47 +0100)]
[BUGFIX] Allow overriding of Backend Routes

Adding backend routes from Configuration/Backend/Routes.php is
done via "+=" operator which does not allow to override routes with
the same name. This is however a wanted behaviour - allowing extensions
to override core routes.

The patch changes the "+=" operator to a simple array_merge() call
to allow to change existing routes.

Resolves: #74004
Releases: master, 7.6
Change-Id: I7caf1ab5a91f849b4789ea352c20af6239470f2f
Reviewed-on: https://review.typo3.org/47005
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Schlumberger <thomas@b13.de>
Tested-by: Thomas Schlumberger <thomas@b13.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>