Packages/TYPO3.CMS.git
4 years ago[TASK] Move Content Element Wizard Icons to EXT:frontend 94/40494/2
Benjamin Mack [Sat, 20 Jun 2015 18:00:10 +0000 (20:00 +0200)]
[TASK] Move Content Element Wizard Icons to EXT:frontend

Resolves: #67650
Releases: master
Change-Id: Ifcfe9b30893c34dbc07c38c423c7219ec5141663
Reviewed-on: http://review.typo3.org/40494
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Allow EXT:syntax for icons in new CE wizard 96/40496/3
Benjamin Mack [Sat, 20 Jun 2015 18:02:32 +0000 (20:02 +0200)]
[BUGFIX] Allow EXT:syntax for icons in new CE wizard

Allow EXT:myicon.png instead of just relative paths
for the new Content Element wizard to be more
flexible.

Resolves: #46433
Releases: master
Change-Id: I8a56650e9ebee29f1c846b59fdfef2c40dcbd496
Reviewed-on: http://review.typo3.org/40496
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Cleanup clipboard styling 01/40501/2
Benjamin Mack [Sat, 20 Jun 2015 20:34:26 +0000 (22:34 +0200)]
[TASK] Cleanup clipboard styling

Resolves: #67652
Releases: master
Change-Id: Ica85aecb90c22418334571989fa5a4a2153caecb
Reviewed-on: http://review.typo3.org/40501
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Change grid class of clipboard 74/40474/3
Jan Helke [Fri, 19 Jun 2015 20:39:18 +0000 (22:39 +0200)]
[BUGFIX] Change grid class of clipboard

This patch changes the TWBS grid class of the clipboard from col-sm-6
to col-sm-12. 6 is bogus for two reasons. First of all 6 indicates a
second block with 6. Second this 6 causes the clipboard to collapse
to a width of 50% when the broser window is larger than 1200 px.

Releases: master
Resolves: #67635
Change-Id: Ibb386940e8dc291b0b6b54df2eaa62327ed991e7
Reviewed-on: http://review.typo3.org/40474
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Removes eval() in BackendUtilityTest 97/40497/3
Wouter Wolters [Sat, 20 Jun 2015 18:01:41 +0000 (20:01 +0200)]
[TASK] Removes eval() in BackendUtilityTest

Resolves: #67651
Releases: master
Change-Id: Ib1199162a747c486bba60d0ec489ab07226425c1
Reviewed-on: http://review.typo3.org/40497
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Infinite loop with circular relations 71/40471/4
Felix Oertel [Fri, 19 Jun 2015 13:58:04 +0000 (15:58 +0200)]
[BUGFIX] Infinite loop with circular relations

When resolving circular relations, extbase fails with an
infinite loop because the DataMapper waits for all sub-
objects to be mapped before registering them to the session.
The sub-objects can thus not find the parent object in the
session and the loop begins.

Resolves: #67630
Related: #66429
Releases: master
Change-Id: Ie20e2690323a00d8f54f3af5ce2fce87715f4247
Reviewed-on: http://review.typo3.org/40471
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
4 years ago[BUGFIX] Correctly handle forceTypeValue = 0 78/19778/9
Steffen Roßkamp [Sat, 27 Dec 2014 00:11:18 +0000 (01:11 +0100)]
[BUGFIX] Correctly handle forceTypeValue = 0

Setting config.forceTypeValue or forceTypeValue in GMENU, TMENU,
IMGMENU or JSMENU objects to 0 (zero) is now handled properly
and type is forced to zero.

Resolves: #23270
Releases: master, 6.2
Change-Id: If4a829aacf091ec3fae78329915b7c74619245b3
Reviewed-on: http://review.typo3.org/19778
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Arjen Hoekema <arjenhoekema@gmail.com>
Tested-by: Arjen Hoekema <arjenhoekema@gmail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[!!!][TASK] Cleanup Flash message rendering in FlashMessageQueue 41/40341/3
Helmut Hummel [Tue, 16 Jun 2015 21:02:19 +0000 (23:02 +0200)]
[!!!][TASK] Cleanup Flash message rendering in FlashMessageQueue

Streamline rendering of FlashMessages to the same output
the view helper creates by default currently.

This makes usage of HTML in flash messages not possible any more
when FlashMessageQueue::renderFlashMessages() is used, because
all HTML entities will now be properly HTML encoded.

Also adapt DocumentTemplate to use the new rendering
and remove the deprecated div wrapper with id.

Resolves: #67546
Related: #63453
Releases: master
Change-Id: I999f1b394c23e964cced30e74351fd6bfb2cd645
Reviewed-on: http://review.typo3.org/40341
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Properly escape data in PermissionAjaxController 28/40328/5
Wouter Wolters [Tue, 16 Jun 2015 19:39:46 +0000 (21:39 +0200)]
[BUGFIX] Properly escape data in PermissionAjaxController

Resolves: #48692
Releases: master
Change-Id: Icd8252c81575244bca55515f79b22445a82fcadc
Reviewed-on: http://review.typo3.org/40328
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Port toolbar dropdowns to Fluid 29/40329/13
Andreas Fernandez [Tue, 16 Jun 2015 19:52:05 +0000 (21:52 +0200)]
[TASK] Port toolbar dropdowns to Fluid

The toolbar dropdown menus are ported to Fluid. Also, some small
improvements are made in this patch.

Resolves: #67537
Related: #67568
Releases: master
Change-Id: I41b502e97108494bf6d4acfa0dedb32bb18a5e18
Reviewed-on: http://review.typo3.org/40329
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FOLLOWUP][TASK] Cleanup bootstrap 91/40491/2
Benjamin Mack [Sat, 20 Jun 2015 15:14:54 +0000 (17:14 +0200)]
[FOLLOWUP][TASK] Cleanup bootstrap

Due to the HttpUtility resolving of absolute URLs
the redirect to the install tool did not work anymore.

Resolves: #67645
Releases: master
Change-Id: Ice49e2ad25221cfdf69d4b84b54a95633bd5df21
Reviewed-on: http://review.typo3.org/40491
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Thorsten Griebenow <tgr@starfinanz.de>
Reviewed-by: Thorsten Griebenow <tgr@starfinanz.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[BUGFIX] Sorting ignored in "Template Overview" 66/21366/6
Reinhard Führicht [Tue, 25 Jun 2013 13:41:13 +0000 (15:41 +0200)]
[BUGFIX] Sorting ignored in "Template Overview"

The overview of all TS templates shows a tree like view listing
of all pages having a ts template on them.
But this view doesn't sort the pages by "sorting" like
in the pagetree.

Resolves: #22774
Releases: master, 6.2
Change-Id: If7279f14697aab02735da66de5cd3cb2185f2b3a
Reviewed-on: http://review.typo3.org/21366
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FOLLOWUP][TASK] FAL: Use file drivers correctly in Folder::getSubfolder 88/40488/3
Benjamin Mack [Sat, 20 Jun 2015 13:14:58 +0000 (15:14 +0200)]
[FOLLOWUP][TASK] FAL: Use file drivers correctly in Folder::getSubfolder

Storage should use folder identifier when accessing the driver

Releases: master
Resolves: #67647
Resolves: #65305
Resolves: #59475
Resolves: #59473
Change-Id: I7cbe71291866ef033bba2fc3c6c06ffe73f909d0
Reviewed-on: http://review.typo3.org/40488
Reviewed-by: Marc Bastian Heinrichs <typo3@mbh-software.de>
Tested-by: Marc Bastian Heinrichs <typo3@mbh-software.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] RTE transformation not executed 67/40467/3
Christian Kuhn [Fri, 19 Jun 2015 11:49:40 +0000 (13:49 +0200)]
[BUGFIX] RTE transformation not executed

With moving the 4th TCA showitem field to defaultExtras in
columnsOverrides a bug was introduced, so the DataHandler no
longer executes RTE transformation. defaultExtras field
is parallel to config section, and not nested in there.

Resolves: #67614
Related: #67229
Releases: master
Change-Id: Ie6f21523ae3c63abbf69fd1623df92bec02e41fd
Reviewed-on: http://review.typo3.org/40467
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fluid BytesViewHelper: use translated units 97/38497/12
Michael Oehlhof [Mon, 6 Apr 2015 15:18:25 +0000 (17:18 +0200)]
[BUGFIX] Fluid BytesViewHelper: use translated units

The units are moved from a constant to a localization file,
to make it possible to translate the units.

Resolves: #62454
Releases: master
Change-Id: I57a8fd2a060173fd9acbe30e3e3c716efd3c3fd9
Reviewed-on: http://review.typo3.org/38497
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FOLLOWUP][TASK] FAL: Use file drivers correctly in Folder::getSubfolder 87/40487/2
Benjamin Mack [Sat, 20 Jun 2015 12:10:03 +0000 (14:10 +0200)]
[FOLLOWUP][TASK] FAL: Use file drivers correctly in Folder::getSubfolder

Remove obsolete unit test.

Resolves: #65305
Resolves: #59475
Resolves: #59473
Releases: master
Change-Id: Iba3dbd92bf646f219649150df13a2a87715b0d24
Reviewed-on: http://review.typo3.org/40487
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Include doktype in pageOverlayFields 65/40365/2
Andreas Wolf [Wed, 17 Jun 2015 13:34:29 +0000 (15:34 +0200)]
[BUGFIX] Include doktype in pageOverlayFields

Translation overlays must include the doktype field of the translated
page, to take into account page type changes. Otherwise we get unwanted
behaviour if e.g. the original language is a shortcut, but the
translated page is a standard page. Then still a shortcut will be
rendered, with weird possible mode combinations, rendering the page
unviewable.

This is especially nasty as the translation mode is reset when
translating, making the translated page a "shortcut to selected page"
which is always broken (!) if no page is selected.

Releases: master
Resolves: #67562
Change-Id: I8b562643de6c0fd0e267875e298f7c6de14ebbe3
Reviewed-on: http://review.typo3.org/40365
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[!!!][TASK] Remove PHP library inclusion in FE 84/40484/3
Benjamin Mack [Sat, 20 Jun 2015 10:58:24 +0000 (12:58 +0200)]
[!!!][TASK] Remove PHP library inclusion in FE

The functionality to add PHP include files
during the Frontend request is quite old and
obsolete as there are plenty of hooks available.

The functionality is in this case obsolete as it does
not apply to the design patterns we apply nowadays.

This patch removes the the library inclusion and
the associated TypoScript options and PHP function.

Resolves: #67646
Releases: master
Change-Id: I376d0ed5eed324a1a0202021529ed526a48edab4
Reviewed-on: http://review.typo3.org/40484
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][TASK] FAL: Use file drivers correctly in Folder::getSubfolder 79/38479/11
Michael Oehlhof [Sat, 4 Apr 2015 13:43:09 +0000 (15:43 +0200)]
[!!!][TASK] FAL: Use file drivers correctly in Folder::getSubfolder

This patch extends the API of the DriverInterface.

The Folder::getSubfolder() function now asks for the correct folder.
The getFolderInFolder($folderName, $folder) function is added
to ResourceStorage and the getFolderInFolder and getFileInFolder
functions are added to the DriverInterface.

Resolves: #65305
Resolves: #59475
Resolves: #59473
Releases: master
Change-Id: Ib3e8e76ebf4ce43a442dab610c882d7a075a791f
Reviewed-on: http://review.typo3.org/38479
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Clean up bootstrap process 83/40483/2
Benjamin Mack [Sat, 20 Jun 2015 10:09:14 +0000 (12:09 +0200)]
[TASK] Clean up bootstrap process

This patch streamlines the redirect process
to the install tool, as some constants don't
need to be set just before redirecting.

Additionally, some streamlining was taken care of.

Resolves: #67645
Releases: master
Change-Id: I03cca6356ba778da0a716d8da302aea5cdb0f9a9
Reviewed-on: http://review.typo3.org/40483
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] TypeError: this.I18N was undefined in backend 80/40480/4
Frank Nägler [Sat, 20 Jun 2015 10:03:05 +0000 (12:03 +0200)]
[BUGFIX] TypeError: this.I18N was undefined in backend

Fixed JS Error in backend.
Can be verified in EXT:styleguide mega record.

Resolves: #67644
Releases: master
Change-Id: Ib549594c46c8e81d7e048d617353abe20e29d08d
Reviewed-on: http://review.typo3.org/40480
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years agoRevert "[BUGFIX] Change default label for sys_file_references" 76/40476/2
Markus Klein [Fri, 19 Jun 2015 21:01:44 +0000 (23:01 +0200)]
Revert "[BUGFIX] Change default label for sys_file_references"

This reverts commit 6a7d3a545ff32f24e860ee2d9141852c4a964cb9.

The original patch breaks the functional tests.

Change-Id: Ief8de9603ee1faf68f763c43b1cb48b72fa80ae1
Releases: master
Reverts: #67303
Reviewed-on: http://review.typo3.org/40476
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Change default label for sys_file_references 64/39964/8
Bernd Wilke [Fri, 5 Jun 2015 07:38:43 +0000 (09:38 +0200)]
[BUGFIX] Change default label for sys_file_references

In the List module you can select additional fields to be displayed.
For fields referencing files only, the uid is shown which does give
no hint to the real referenced file.
This change selects the uid_local field, which selects the filename
from sys_file for display.

Change-Id: Ib4d8a99e66bf2507617bf43f65a0bbd511177d4b
Resolves: #67303
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/39964
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FOLLOWUP] Document "DBMS specific conversion between Meta/MySQL field types" 68/40468/2
Morton Jonuschat [Fri, 19 Jun 2015 12:21:57 +0000 (14:21 +0200)]
[FOLLOWUP] Document "DBMS specific conversion between Meta/MySQL field types"

Document the changes in mapping field types and the impact for sites
running PostgreSQL.

Resolves: #67626
Related: #67290
Releases: master
Change-Id: Ie7333e42699c50adc513d490ff25774d70087037
Reviewed-on: http://review.typo3.org/40468
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
4 years ago[TASK] dbal: convert DBMS specific key/default/extra values to MySQL SQL 56/40156/8
Morton Jonuschat [Wed, 10 Jun 2015 19:28:33 +0000 (21:28 +0200)]
[TASK] dbal: convert DBMS specific key/default/extra values to MySQL SQL

Allow DBMS specific transformations of field information to MySQL SQL
dialect. Provide the database compare in the install tool with more
details about the current database schema to avoid changes that can not
be implemented due to syntax differences.

Resolves: #67300
Resolves: #67329
Releases: master
Change-Id: Id415ba6246963fd0da97b5825fbe4fc9ac959641
Reviewed-on: http://review.typo3.org/40156
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[FEATURE] Backend User: display "online" badge 77/40377/7
Felix Kopp [Wed, 17 Jun 2015 17:26:00 +0000 (19:26 +0200)]
[FEATURE] Backend User: display "online" badge

To gain quick overview of people in project being online
at the moment the small label "online" is added to listing.

Resolves: #67574
Releases: master
Change-Id: I098977dc17ab7edacc9ed9b9e122471ed0d5e3c5
Reviewed-on: http://review.typo3.org/40377
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FEATURE] dbal: DBMS specific conversion between Meta/MySQL field types 38/40138/6
Morton Jonuschat [Sat, 6 Jun 2015 16:43:57 +0000 (18:43 +0200)]
[FEATURE] dbal: DBMS specific conversion between Meta/MySQL field types

This patch changes the implementation of the methods that convert
between ADOdb meta field types and MySQL native field types to allow
overriding the conversion per data type.

The PostgresSpecifics provide better matching of BLOB, SERIAL, DOUBLE
and INTEGER types.

Resolves: #67290
Releases: master
Change-Id: Ieda2a2a26d411b031c2db96821d85e21b2ebb037
Reviewed-on: http://review.typo3.org/40138
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Don't force lowercase on SQL SET() values 76/40176/3
Stephan Großberndt [Thu, 11 Jun 2015 09:50:53 +0000 (11:50 +0200)]
[BUGFIX] Don't force lowercase on SQL SET() values

With this patch Database Analyzer no longer complains about SQL SET()
values in upper- or mixed case when checking field types.

Resolves: #67413
Releases: master, 6.2
Change-Id: I5cd1689bce21642b278a94d970ab2d3301c644f0
Reviewed-on: http://review.typo3.org/40176
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[CLEANUP] Replace create_function() with closure 57/40457/3
Markus Klein [Thu, 18 Jun 2015 21:53:24 +0000 (23:53 +0200)]
[CLEANUP] Replace create_function() with closure

The create_function() function is discouraged due to internal usage
of eval(). Replace all calls with a real closure, which is supported
since PHP 5.3.

Resolves: #67616
Releases: master
Change-Id: I7943bf69df94d0948b1b2dd0f4821bc48ec67896
Reviewed-on: http://review.typo3.org/40457
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][TASK] Remove deprecated function calls since 6.2 67/40367/7
Benjamin Mack [Wed, 17 Jun 2015 15:07:25 +0000 (17:07 +0200)]
[!!!][TASK] Remove deprecated function calls since 6.2

Some last leftover deprecated methods and logic are removed.

Resolves: #67565
Releases: master
Change-Id: Ia6a62d8aa436e491e93dce3b51468c7bcaf6bcb7
Reviewed-on: http://review.typo3.org/40367
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Removes eval() in ArrayUtilityTest 90/40290/6
Alexander Krist [Tue, 16 Jun 2015 11:34:08 +0000 (13:34 +0200)]
[TASK] Removes eval() in ArrayUtilityTest

Adds a new ArrayUtilityMockup and removes the ugly
usage of eval() from ArrayUtitilyTest.

Change-Id: Id655f913b3eb638518cd9830e5ababc3c34b982c
Resolves: #67490
Related: #67468
Releases: master
Reviewed-on: http://review.typo3.org/40290
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Removes eval() in array utility unit tests 44/40444/4
Alexander Krist [Thu, 18 Jun 2015 12:23:03 +0000 (14:23 +0200)]
[TASK] Removes eval() in array utility unit tests

Adds a new DummyController fixture and removes the ugly
usage of eval() from FieldProviderTest.

Change-Id: I6efa66ae5c986d048de91c97c9d5488235b97031
Resolves: #67601
Related: #67468
Releases: master
Reviewed-on: http://review.typo3.org/40444
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Removes eval() in uri builder unit tests 24/40324/3
Alexander Krist [Tue, 16 Jun 2015 18:15:17 +0000 (20:15 +0200)]
[TASK] Removes eval() in uri builder unit tests

Adds fixtures for an Entity and an ValueObject and removes the ugly
usage of eval() from UriBuilderTest in unit tests.

Change-Id: Ice36da5d09141b662176539d714f569ab340fdbe
Resolves: #67525
Related: #67468
Releases: master
Reviewed-on: http://review.typo3.org/40324
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Removes eval() in core tree data provider factory unit tests 25/40425/5
Pierrick Caillon [Thu, 18 Jun 2015 09:36:57 +0000 (11:36 +0200)]
[TASK] Removes eval() in core tree data provider factory unit tests

Adds fixture for a DataProvider and removes the ugly usage of eval() from
TreeDataProviderFactoryTest in unit tests.

Resolves: #67591
Related: #67468
Releases: master
Change-Id: I3f02ad549197c8dd4fffb8edbd5d5774a9adbb7e
Reviewed-on: http://review.typo3.org/40425
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Removes eval() in core data handler unit tests 50/40450/3
Pierrick Caillon [Thu, 18 Jun 2015 13:48:45 +0000 (15:48 +0200)]
[TASK] Removes eval() in core data handler unit tests

Adds fixtures for InvalidHook and AllowAccessHook and removes the ugly
usage of eval() from DataHandlerTest in unit tests.

Resolves: #67606
Related: #67468
Releases: master
Change-Id: Ibf14efcc966659ff813ac9d8a3a00c6ccbc47da6
Reviewed-on: http://review.typo3.org/40450
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Removes eval() in core general utility unit tests 46/40446/5
Pierrick Caillon [Thu, 18 Jun 2015 12:56:00 +0000 (14:56 +0200)]
[TASK] Removes eval() in core general utility unit tests

Adds and updates fixtures JavaScript minifying error test, class
replacement test, instantiation with constructor parameters test
and deprecated log permissions test and removes the ugly usage of
eval() from GeneralUtilityTest in unit tests.

Resolves: #67600
Related: #67468
Releases: master
Change-Id: Id5990bb21b2c395787ac5013a1440c5a71462e23
Reviewed-on: http://review.typo3.org/40446
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Removes eval() in core path utility unit tests 35/40435/3
Pierrick Caillon [Thu, 18 Jun 2015 10:39:56 +0000 (12:39 +0200)]
[TASK] Removes eval() in core path utility unit tests

Adds fixture for a Windows environment PathUtility and removes the
ugly usage of eval() from PathUtilityTest in unit tests.

Resolves: #67596
Related: #67468
Releases: master
Change-Id: I0f4135e6f9200c529854a28acefa01953c8bdf89
Reviewed-on: http://review.typo3.org/40435
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Removes eval() in core mailer unit test 48/40448/3
Pierrick Caillon [Thu, 18 Jun 2015 13:26:53 +0000 (15:26 +0200)]
[TASK] Removes eval() in core mailer unit test

Adds fixture for FakeTransport and removes the ugly usage of
eval() from MailerTest in unit tests.

Resolves: #67604
Related: #67468
Releases: master
Change-Id: I37011a5eaadc0abac38e1c53bcd20bbe3e62f4fd
Reviewed-on: http://review.typo3.org/40448
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Properly escape data in SelectImage 27/40327/2
Wouter Wolters [Tue, 16 Jun 2015 18:32:16 +0000 (20:32 +0200)]
[BUGFIX] Properly escape data in SelectImage

Resolves: #67527
Releases: master
Change-Id: Id4e80a03a9553eab742e3dd1b44117e04a5180b7
Reviewed-on: http://review.typo3.org/40327
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[CLEANUP] EXT:backend/Classes/Controller/*.php 49/37849/13
Michael Oehlhof [Sun, 15 Mar 2015 01:55:38 +0000 (02:55 +0100)]
[CLEANUP] EXT:backend/Classes/Controller/*.php

Refactor the code to go green in PHPStorm.

- declare missing class variables
- add getter for LanguageService
- add getter for BackendUser
- add getter for TimeTracker
- add getter for DocumentTemplate
- add getter for DatabaseConnection
- fix code style issues "Unnecessary fully qualified name"

Resolves: #65738
Releases: master
Change-Id: I5a870c2760d73da9a17062165be977ae253ab81d
Reviewed-on: http://review.typo3.org/37849
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Removes eval() in core version number utility unit tests 31/40431/3
Pierrick Caillon [Thu, 18 Jun 2015 10:16:00 +0000 (12:16 +0200)]
[TASK] Removes eval() in core version number utility unit tests

Adds fixture for specifying current version in VersionNumberUtility
and removes the ugly usage of eval() from VersionNumberUtilityTest.

Resolves: #67594
Related: #67468
Releases: master
Change-Id: Ia4b256c1a1e61dc117519c243d0e465fb36e8662
Reviewed-on: http://review.typo3.org/40431
Reviewed-by: Alexander Krist <mail@alex-krist.de>
Tested-by: Alexander Krist <mail@alex-krist.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Properly resolve link format to page type 87/38687/4
Daniel Schmidt [Tue, 14 Apr 2015 10:55:38 +0000 (12:55 +0200)]
[BUGFIX] Properly resolve link format to page type

This fixes the resolving of link format to target page type
when creating frontend links with the UriBuilder.

Resolves: #66352
Releases: master, 6.2
Change-Id: I6bb6ec805212cd7411ecd17e4abc3ac542f7a337
Reviewed-on: http://review.typo3.org/38687
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Save pixels: hide Workspace toolbar item when unused 68/40368/5
Felix Kopp [Wed, 17 Jun 2015 15:21:37 +0000 (17:21 +0200)]
[TASK] Save pixels: hide Workspace toolbar item when unused

In use case where EXT: workspaces is installed and activated but no
additional Workspaces (sys_workspace) records are added TYPO3
should assume that Workspaces are unused. No permanently visible
button should sit in the topbar.

Resolves: #67568
Releases: master
Change-Id: I1a4bd40df79458690ce1c0d9e141dd71247d8cbf
Reviewed-on: http://review.typo3.org/40368
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Add missing break statements 52/40452/2
Markus Klein [Thu, 18 Jun 2015 19:15:03 +0000 (21:15 +0200)]
[BUGFIX] Add missing break statements

UserSettingsController misses break statements in a switch
control structure. Add them.

Resolves: #67615
Releases: master
Change-Id: I9cd42d77324993b10b304ea85436537d448fe56e
Reviewed-on: http://review.typo3.org/40452
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Show expected targetType on "Object not found" errors 41/40141/3
Mathias Brodala [Wed, 10 Jun 2015 07:06:11 +0000 (09:06 +0200)]
[TASK] Show expected targetType on "Object not found" errors

If the ``PersistentObjectConverter`` cannot find an object by
given identity the error message shows the identity but not the
expected object type. Adding it helps a lot in debugging such errors.

Resolves: #67382
Releases: master
Change-Id: Ib13e1e7927b2b56cb6c23555608703dfcda060b9
Reviewed-on: http://review.typo3.org/40141
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Check if file exists before deletion 38/40238/2
Christoph Lehmann [Mon, 15 Jun 2015 08:16:34 +0000 (10:16 +0200)]
[BUGFIX] Check if file exists before deletion

File deletion in "processed" folder no longer throws an exception when
trying to delete a file that does not exist.

Resolves: #67432
Releases: master, 6.2
Change-Id: I59acdcbb04725ce4425ca3f333093e5a870046ca
Reviewed-on: http://review.typo3.org/40238
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[FEATURE] Custom attribute name and multiple values for meta tags 20/40120/17
Alexander Kontos [Thu, 11 Jun 2015 22:32:23 +0000 (00:32 +0200)]
[FEATURE] Custom attribute name and multiple values for meta tags

To support a broader range of possible meta tags we need a specify
the used attribute name. Also now it is possible to ad the same
meta tag with different values.

Resolves: #67360
Releases: master
Change-Id: Ic8f8e03a7b137302af6613edfbe7e89a50e25e12
Reviewed-on: http://review.typo3.org/40120
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Fix check for import / export folder 38/40338/2
Alexander Stehlik [Wed, 17 Jun 2015 09:45:18 +0000 (11:45 +0200)]
[BUGFIX] Fix check for import / export folder

When the import / export folder is not available a NULL value
is returned. The condition that checks if a vaild folder is
found now checks for NULL values instead of FALSE.

Releases: master, 6.2
Resolves: #67543
Change-Id: Ie9d6314506f9c8bbea19ed445e29b5bd1d8a544b
Reviewed-on: http://review.typo3.org/40338
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Marc Bastian Heinrichs <typo3@mbh-software.de>
Tested-by: Marc Bastian Heinrichs <typo3@mbh-software.de>
4 years ago[BUGFIX] Use single quotes for password check 36/40436/3
Andreas Fernandez [Thu, 18 Jun 2015 10:46:14 +0000 (12:46 +0200)]
[BUGFIX] Use single quotes for password check

Use single quotes for the password check in
SaltedPasswordsUtility::getNumberOfBackendUsersWithInsecurePassword
to tell other DBMS to expect a value and not an identifier.

Using double quotes for values violates the SQL standard.

Resolves: #67599
Releases: master, 6.2
Change-Id: I4d17f2eb24e77421da2368cc899a021c435cfff8
Reviewed-on: http://review.typo3.org/40436
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
4 years ago[CLEANUP] Code duplication in DataHandler::copyRecord_processManyToMany() 23/40423/5
Andreas Wolf [Wed, 17 Jun 2015 18:54:07 +0000 (20:54 +0200)]
[CLEANUP] Code duplication in DataHandler::copyRecord_processManyToMany()

There was a foreach loop that only differed in one line, but was
duplicated due to the complex condition around it. This commit splits
the condition, introduces helper variables and moves the condition
inside the foreach loop to get rid of the duplication.

Additionally, duplicated lines for purging the items of the relation
analyzer are also removed.

Resolves: #67579
Releases: master
Change-Id: Ibb9277dfb32960cc77aee17839d7df3bf57fc6da
Reviewed-on: http://review.typo3.org/40423
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Check access to folder in FileListController 08/39108/9
Nicole Cordes [Thu, 30 Apr 2015 16:12:27 +0000 (18:12 +0200)]
[BUGFIX] Check access to folder in FileListController

Currently if a folder isn't accessible for the user, the root folder
is taken as fallback solution. But this folder might be inaccessible as
well. This patch adds an access check for the returned folder and
turns thrown errors into flash messages.

Releases: master, 6.2
Resolves: #66693
Resolves: #56641
Change-Id: I310df8061edc790dde1034a27136365b4253ac7f
Reviewed-on: http://review.typo3.org/39108
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FEATURE] dbal: Ignore MySQL ENGINE in database schema compare 55/40055/3
Morton Jonuschat [Sat, 6 Jun 2015 18:04:26 +0000 (20:04 +0200)]
[FEATURE] dbal: Ignore MySQL ENGINE in database schema compare

Ignore the database engine when comparing the expected and the
current schema information if DBAL is enabled. The MySQL specific
storage engines are not available on other DBMS.

Resolves: #67302
Releases: master
Change-Id: Ic57233de7c4294454609955e802498053f186326
Reviewed-on: http://review.typo3.org/40055
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] dbal: Always initialize the DBMS specifics 35/40135/2
Morton Jonuschat [Tue, 9 Jun 2015 18:37:35 +0000 (20:37 +0200)]
[BUGFIX] dbal: Always initialize the DBMS specifics

Make default DBMS specifics available when no DBAL handler has
been configured to fix errors in the install tool.

Resolves: #67380
Releases: master
Change-Id: I8140fbe570628a5747e21a6e07920b8fbdc820b1
Reviewed-on: http://review.typo3.org/40135
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Add basic unit tests for ContentObjectRenderer::typoLink 91/40391/3
Nicole Cordes [Wed, 17 Jun 2015 19:43:20 +0000 (21:43 +0200)]
[TASK] Add basic unit tests for ContentObjectRenderer::typoLink

Resolves: #67586
Releases: master, 6.2
Change-Id: I0c20b13469d9bb9af844f92ee87181a55bacc906
Reviewed-on: http://review.typo3.org/40391
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][TASK] RTE: Remove tt_content rte_enabled and flag handling 80/40380/2
Christian Kuhn [Wed, 17 Jun 2015 18:01:20 +0000 (20:01 +0200)]
[!!!][TASK] RTE: Remove tt_content rte_enabled and flag handling

The tt_content field rte_enabled is not really useful anymore, RTE
can be disabled on a per-user basis. The field is removed from DB
together with the "flag" handling.

Resolves: #67577
Releases: master
Change-Id: I214baf45228a91d2193b54fbbc9ee71632e39bdf
Reviewed-on: http://review.typo3.org/40380
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Alina Fleser <afleser@arxia.com>
Tested-by: Alina Fleser <afleser@arxia.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Extend FileMount-Model with description-field 86/40386/2
Daniel Maier [Wed, 17 Jun 2015 19:01:14 +0000 (21:01 +0200)]
[TASK] Extend FileMount-Model with description-field

The new description-field that was recently added to table sys_filemounts
is now also added to the FileMount-Model.

Resolves: #67581
Related: #59570
Releases: master
Change-Id: I70d174d2bd9b10fe913fb06b713f5899c35f8bf9
Reviewed-on: http://review.typo3.org/40386
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Early continue in DataHandler::process_* 95/40295/2
Andreas Wolf [Tue, 16 Jun 2015 10:20:28 +0000 (12:20 +0200)]
[CLEANUP] Early continue in DataHandler::process_*

Resolves: #67500
Releases: master
Change-Id: Iaab030099f565deb10d22c254856af7a07ecd3e9
Reviewed-on: http://review.typo3.org/40295
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Split DataHandler::copyRecord_procBasedOnFieldType 11/40311/6
Andreas Wolf [Tue, 16 Jun 2015 11:36:20 +0000 (13:36 +0200)]
[TASK] Split DataHandler::copyRecord_procBasedOnFieldType

This is the first part to get this method down to an understandable
size. The two factored out methods should be further simplified/split
up.

Resolves: #67510
Releases: master
Change-Id: Ice6692cf916591687aaaf9296d8834ef3d352ca5
Reviewed-on: http://review.typo3.org/40311
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Properly escape option value for groups 21/40321/2
Wouter Wolters [Tue, 16 Jun 2015 17:18:55 +0000 (19:18 +0200)]
[BUGFIX] Properly escape option value for groups

Resolves: #56296
Releases: master,6.2
Change-Id: I2960cc23b6fdb44e5159c74c126feaa6070eb7bf
Reviewed-on: http://review.typo3.org/40321
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
4 years ago[FOLLOWUP][TASK] Convert dropdowns in clipboard to TWBS 82/40382/3
Andreas Fernandez [Wed, 17 Jun 2015 18:18:01 +0000 (20:18 +0200)]
[FOLLOWUP][TASK] Convert dropdowns in clipboard to TWBS

Remove double quotes from URL.

Releases: master
Resolves: #67560
Change-Id: I4097f7096b58a6aa3a7fde0bac521e43bf638a81
Reviewed-on: http://review.typo3.org/40382
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Hide "Create ..." buttons, if maxitems is reached 57/40257/7
Jonathan IROULIN [Mon, 15 Jun 2015 15:54:29 +0000 (17:54 +0200)]
[BUGFIX] Hide "Create ..." buttons, if maxitems is reached

This patch hide "Creation relation", "Create new ..." and
"Select & Upload" button when the edit form is generated if there
is a maxitems limit in the TCA. The buttons are not immediately
hidden/shown if the number of relation changes. That would involve
JavaScript magic and could be done in a follow up.

Resolves: #45125
Releases: master
Change-Id: I725aee28568c67dfc3b2feebb62d39ec5432d149
Reviewed-on: http://review.typo3.org/40257
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Convert dropdowns in clipboard to TWBS 62/40362/3
Jan Helke [Wed, 17 Jun 2015 13:55:27 +0000 (15:55 +0200)]
[TASK] Convert dropdowns in clipboard to TWBS

This patch converts the dropdowns in the clipboard from select options to
ul li list to follow the TWBS guidelines.

Releases: master
Resolves: #67560
Change-Id: Ic1f3d769170a59b0217198030c9ef30aa9a5124a
Reviewed-on: http://review.typo3.org/40362
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Alina Fleser <afleser@arxia.com>
Tested-by: Alina Fleser <afleser@arxia.com>
4 years ago[BUGFIX] Fix SQL error on recursive TypoScript template inclusion 47/40147/2
Andreas Fernandez [Wed, 10 Jun 2015 11:09:16 +0000 (13:09 +0200)]
[BUGFIX] Fix SQL error on recursive TypoScript template inclusion

If TypoScript templates are included recusively (a > b > a), the
$basedOnIds array is empty and creates an invalid SQL query.

Resolves: #64654
Releases: master, 6.2
Change-Id: Ia3001e1e620d6bb4d2d1f3ad016816bc5636dff1
Reviewed-on: http://review.typo3.org/40147
Reviewed-by: Pierrick Caillon <pierrick.caillon@plan-net.fr>
Tested-by: Pierrick Caillon <pierrick.caillon@plan-net.fr>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[!!!][TASK] Move language file of EXT:opendocs 54/40354/4
Andreas Fernandez [Wed, 17 Jun 2015 12:22:25 +0000 (14:22 +0200)]
[!!!][TASK] Move language file of EXT:opendocs

Move the language file to Resources/Private/Language/locallang.xlf.

Resolves: #67557
Releases: master
Change-Id: I46eb8a7931d82babda1fee78b925367cd12bf59d
Reviewed-on: http://review.typo3.org/40354
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] RTE: Remove unused css files 70/40370/2
Christian Kuhn [Wed, 17 Jun 2015 16:23:05 +0000 (18:23 +0200)]
[TASK] RTE: Remove unused css files

A number of .css files within RTE are referenced in the plugin files
but never included since addIconsToSkin is not 1. The patch removes
those files and cleans up ext_localconf a bit.

Resolves: #67571
Releases: master
Change-Id: I07daa2c56563a6e627c58a472707372b8199a292
Reviewed-on: http://review.typo3.org/40370
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[!!!][FEATURE] Support IEC/SI units in file size formatting 91/40291/12
Pierrick Caillon [Tue, 16 Jun 2015 11:35:01 +0000 (13:35 +0200)]
[!!!][FEATURE] Support IEC/SI units in file size formatting

The new labels "iec" and "si" are added to GeneralUtility::formatSize,
where "iec" is the new default label.

A new parameter "base" has been added for specifying the base unit
multiplier expecting 1000 and 1024 as value and defaulting to 1024
when using the old labels.

Resolves: #22175
Releases: master
Change-Id: Iaa255f639b0421e508f561557a6c6b2e2b226bc9
Reviewed-on: http://review.typo3.org/40291
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] FormEngine: Size equals to 1 if none set on multi-selects 29/27829/7
Daniel Maier [Wed, 17 Jun 2015 10:36:03 +0000 (12:36 +0200)]
[BUGFIX] FormEngine: Size equals to 1 if none set on multi-selects

Having a FormEngine select element with maxitems=10
and no size set, then a typical single-select element
is rendered, with no chance of using the up- and
down buttons provided, as the single select does not
allow to use more than one entry in rendering.

The browser behavior is not adopted and if size
is not given, a broken state is rendered.

Releases: master
Resolves: #56259
Change-Id: I9963503cb046353b81f13b0c624bddbd7e5b74f8
Reviewed-on: http://review.typo3.org/27829
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] RTE: Remove empty locallang files 58/40358/3
Christian Kuhn [Wed, 17 Jun 2015 13:37:29 +0000 (15:37 +0200)]
[TASK] RTE: Remove empty locallang files

Some locallang.xlf files in RTE are empty. Remove them
together with their references.

Resolves: #67559
Releases: master
Change-Id: I3d08bf1c9f142cdb0719d7b0284293481db15df3
Reviewed-on: http://review.typo3.org/40358
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Alina Fleser <afleser@arxia.com>
Tested-by: Alina Fleser <afleser@arxia.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Add description-field for filemounts 85/40285/3
Daniel Maier [Tue, 16 Jun 2015 10:08:36 +0000 (12:08 +0200)]
[FEATURE] Add description-field for filemounts

With the new field it is possible to give a short description what a
certain filemount should be used for or which documents they contain, etc.

Change-Id: Ia0e9d8385d8a6f0620b20581f4acc497dc9ffca9
Resolves: #59570
Releases: master
Reviewed-on: http://review.typo3.org/40285
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Misleading annotation in createVersionNumberedFilename 44/40344/2
Christian Kuhn [Wed, 17 Jun 2015 11:19:32 +0000 (13:19 +0200)]
[BUGFIX] Misleading annotation in createVersionNumberedFilename

The method returns a string.

Resolves: #67549
Releases: master
Change-Id: I7b9b6a1000ddfbb3394b545f42370ba39dcbecbe
Reviewed-on: http://review.typo3.org/40344
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FOLLOWUP][TASK] Deprecate init.php 42/40342/5
Wouter Wolters [Wed, 17 Jun 2015 11:11:10 +0000 (13:11 +0200)]
[FOLLOWUP][TASK] Deprecate init.php

Add missing TYPO3_MODE in two places.

Resolves: #67471
Releases: master
Change-Id: I02a77209dabe4267a4df57b754048160482e2c50
Reviewed-on: http://review.typo3.org/40342
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Add "tx_felogin" folder in "uploads" folder during install 36/40336/4
Jonathan IROULIN [Wed, 17 Jun 2015 08:15:39 +0000 (10:15 +0200)]
[BUGFIX] Add "tx_felogin" folder in "uploads" folder during install

fe_login is a preinstalled extension but the "/uploads/tx_felogin" folder
was not created during step-2 installation process.
This patch add "tx_felogin" folder in "uploads" folder
during the process installation.

Resolves: #60261
Releases: master, 6.2
Change-Id: If4914b958b7117dc9f33d303d29850124b775b50
Reviewed-on: http://review.typo3.org/40336
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Add table of content page for 7.3 35/40335/3
Wouter Wolters [Wed, 17 Jun 2015 08:10:09 +0000 (10:10 +0200)]
[TASK] Add table of content page for 7.3

Resolves: #67536
Releases: master
Change-Id: I1527b99395ab44263194922579cb482bbe567542
Reviewed-on: http://review.typo3.org/40335
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
4 years ago[TASK] Update Bootstrap to 3.3.5 20/40320/2
Andreas Fernandez [Tue, 16 Jun 2015 17:18:25 +0000 (19:18 +0200)]
[TASK] Update Bootstrap to 3.3.5

Resolves: #67522
Releases: master
Change-Id: Iceae001a8519fbf33f8661425b732349e969fbf6
Reviewed-on: http://review.typo3.org/40320
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove unused icons in typo3/gfx/ 17/40317/2
Benjamin Mack [Tue, 16 Jun 2015 17:02:30 +0000 (19:02 +0200)]
[TASK] Remove unused icons in typo3/gfx/

Resolves: #67520
Releases: master
Change-Id: I4db740c6eead3d2b77cd7a879a8f5912b6b97db9
Reviewed-on: http://review.typo3.org/40317
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Restore the layout of the clipboard 19/40319/2
Jan Helke [Tue, 16 Jun 2015 17:12:55 +0000 (19:12 +0200)]
[BUGFIX] Restore the layout of the clipboard

Reposition the thumbnail back in another column than the icon.

Releases: master
Resolves: #67521
Change-Id: I2506635e555eaae9cc0ee6c2b9f82c0f72c2c5f5
Reviewed-on: http://review.typo3.org/40319
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Removes eval() in abstract backend unit tests 88/40288/5
Alexander Krist [Tue, 16 Jun 2015 10:57:34 +0000 (12:57 +0200)]
[TASK] Removes eval() in abstract backend unit tests

Adds a new AccessibleProxy for AbstractBackend and removes the ugly
usage of eval() from AbstractBackendTest in unit tests.

Change-Id: I3c471219fe37ecf8a51cb02b60c75130fbb4ad25
Resolves: #67489
Related: #67468
Releases: master
Reviewed-on: http://review.typo3.org/40288
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove show/hide thumbnails button from clipboard 07/40307/4
Jan Helke [Tue, 16 Jun 2015 14:37:43 +0000 (16:37 +0200)]
[TASK] Remove show/hide thumbnails button from clipboard

This patch remove the button to show and hide the thumbnails of images
from the clipboard. The thumbnails will be shown by default.

Releases: master
Resolves: #67509
Change-Id: Ic1e714e9f46b02555e310fc9399ba1c6e9ebde7c
Reviewed-on: http://review.typo3.org/40307
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Clean up unused t3skin variables in ext_tables.php 14/40314/2
Benjamin Mack [Tue, 16 Jun 2015 16:10:47 +0000 (18:10 +0200)]
[TASK] Clean up unused t3skin variables in ext_tables.php

There are several options and references within
EXT:t3skin/ext_tables.php which are not in use anymore
and can simple be removed.

Resolves: #67518
Releases: master
Change-Id: I6aafadc558a3ee8108964928464038ccf4b828c5
Reviewed-on: http://review.typo3.org/40314
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove usage of _icon_website.gif 13/40313/3
Benjamin Mack [Tue, 16 Jun 2015 16:00:39 +0000 (18:00 +0200)]
[TASK] Remove usage of _icon_website.gif

The occurence of _icon_website.gif was still used in two places
instead of using the proper sprite icon. The patch changes the
places to use sprite icons.

Resolves: #67517
Releases: master
Change-Id: I14222563aebfc08c2eb030b3550525d82597358a
Reviewed-on: http://review.typo3.org/40313
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
4 years ago[!!!][FEATURE] "Content-Language" HTTP header now added when rendering 65/40265/5
Romain L [Mon, 15 Jun 2015 17:54:10 +0000 (19:54 +0200)]
[!!!][FEATURE] "Content-Language" HTTP header now added when rendering

The "Content-Language" is now sent as a both meta tag and HTTP header.
Previously page language information was only sent as meta tag.

By default new and existing installations will send a header
"Content-language: XX" where "XX" is the iso code of the
sys_language_content if that is properly defined by the sys_language
record representing the sys_language_uid.
A new Typoscript configuration "config.disableLanguageHeader" allows
to disable this behavior.
You must set "config.disableLanguageHeader" to get the previous
behavior (no header).

Resolves: #33071
Releases: master
Change-Id: I2de9ad3deb93b9e2266ff03cb68d3fb60250bf41
Reviewed-on: http://review.typo3.org/40265
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Deprecate IconUtility::getIcon and clean up "gfx/i/" 05/40305/2
Benjamin Mack [Tue, 16 Jun 2015 14:32:40 +0000 (16:32 +0200)]
[TASK] Deprecate IconUtility::getIcon and clean up "gfx/i/"

The method IconUtility::getIcon was used for returning
overlaid icons before TYPO3 CMS 4.4, based on raw icons
inside gfx/i/ and created temporary icons when not present.

The left-over function calls are replaced with sprite icon calls.

Additionally, in order to thin out typo3/gfx/, all icons which have
always been overlaid with t3skin already have been removed. All
other files from typo3/gfx/i/ are moved to EXT:t3skin to
stay compatible.

With TYPO3 CMS 8, the folder EXT:t3skin/icons/gfx/i/ will
be completely removed with the function itself.

Resolves: #67506
Releases: master
Change-Id: Idc20fadd36ffeb26782d8d54e27802a0412f9516
Reviewed-on: http://review.typo3.org/40305
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] ViewHelper Exceptions are logged in Production 12/40212/6
Helmut Hummel [Fri, 12 Jun 2015 15:20:17 +0000 (17:20 +0200)]
[BUGFIX] ViewHelper Exceptions are logged in Production

In Production context all Exceptions from ViewHelpers
will be silently logged.
Additionally, the output is discarded from rendering.
In Development they will be re-thrown, so the
global exception handler will be triggered.

Resolves: #32528
Releases: master
Change-Id: I4af4d03ff6048fcc8999f4a48d5c2897dc43fc4e
Reviewed-on: http://review.typo3.org/40212
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Peter Niederlag <peter.niederlag@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Fix small typo in EditDocumentController 06/40306/2
Wouter Wolters [Tue, 16 Jun 2015 14:34:04 +0000 (16:34 +0200)]
[TASK] Fix small typo in EditDocumentController

Resolves: #67508
Releases: master
Change-Id: I185300d1cf50a9d8407421c03c8996d66fc79262
Reviewed-on: http://review.typo3.org/40306
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] 404 error after closing edit wizard 87/40287/4
Gilles FOUET [Tue, 16 Jun 2015 10:06:45 +0000 (12:06 +0200)]
[BUGFIX] 404 error after closing edit wizard

The returnUrl parameter was double encoded around getModuleUrl.
Now it's encoded only one time.

Resolves: #67473
Releases: master
Change-Id: I59345018f61717abbd6cfea02891c28441158b61
Reviewed-on: http://review.typo3.org/40287
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove icons from clipboard menu 01/40301/3
Jan Helke [Tue, 16 Jun 2015 13:47:38 +0000 (15:47 +0200)]
[TASK] Remove icons from clipboard menu

This patch removes the scissor + paper icon from the dropdown
menu of the Clipboard in the List module and the File list module.
As they do not fit the style logic anymore and do not describe
the actions "Move" and "Copy" properly, they are removed without
substitution.

Releases: master
Resolves: #67504
Change-Id: I562dac0b6475ac1b1c23976c5c0d612d6ca0e3e3
Reviewed-on: http://review.typo3.org/40301
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Unify handling of TYPO3_PROCEED_IF_NO_USER 33/38033/8
Benjamin Mack [Mon, 23 Mar 2015 12:29:24 +0000 (13:29 +0100)]
[TASK] Unify handling of TYPO3_PROCEED_IF_NO_USER

The constant TYPO3_PROCEED_IF_NO_USER
allows for calling the Backend boostrap without
a authenticated user. The constant is now moved
mainly to the Request Handlers so it is encapsulated
in that area for now.

Once the Request Handler logic is streamlined better
the constant can be dropped in the core with a
deprecation layer.

Resolves: #65932
Releases: master
Change-Id: I02dfb384660be749247ea27e05038d3f0b373896
Reviewed-on: http://review.typo3.org/38033
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FOLLOWUP][CLEANUP] Early returns for DataHandler::copyRecord() and friends 99/40299/2
Christian Kuhn [Tue, 16 Jun 2015 13:42:28 +0000 (15:42 +0200)]
[FOLLOWUP][CLEANUP] Early returns for DataHandler::copyRecord() and friends

A missing parenthesis destroys the boolean logic so a
couple of functional tests fail.

Related: #67336
Releases: master
Change-Id: I4544ebf5b339d85f65bcf2aa1fa03daf39c7b656
Reviewed-on: http://review.typo3.org/40299
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Deprecate $disable Option in PageRepository->getExtURL 73/39473/4
Benjamin Mack [Tue, 12 May 2015 04:13:46 +0000 (12:13 +0800)]
[TASK] Deprecate $disable Option in PageRepository->getExtURL

The disable option to check whether redirects are allowed
should be handled outside of the call to simplify code readability
and maintainability.

Resolves: #66904
Releases: master
Change-Id: Ica85c0703641ff4764233b626d0c08a64bb65d28
Reviewed-on: http://review.typo3.org/39473
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[CLEANUP] Early returns for DataHandler::copyRecord() and friends 81/40281/2
Andreas Wolf [Sun, 7 Jun 2015 09:10:23 +0000 (11:10 +0200)]
[CLEANUP] Early returns for DataHandler::copyRecord() and friends

Related: #67336
Releases: master
Change-Id: I40e944e0833ff75c7bdc77829d52fa3c868b7575
Reviewed-on: http://review.typo3.org/40281
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Early returns in various DataHandler methods 80/40280/2
Andreas Wolf [Sun, 7 Jun 2015 08:55:34 +0000 (10:55 +0200)]
[CLEANUP] Early returns in various DataHandler methods

Related: #67336
Releases: master
Change-Id: Ied575832fdb942f5cb0e82116148e9b336e01715
Reviewed-on: http://review.typo3.org/40280
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Introduce early returns in DataHandler::moveRecord() 79/40279/2
Andreas Wolf [Sun, 7 Jun 2015 08:51:57 +0000 (10:51 +0200)]
[TASK] Introduce early returns in DataHandler::moveRecord()

Related: #67336
Releases: master
Change-Id: I790c40184d435c918d3a63a3a1e4d8225fcacde2
Reviewed-on: http://review.typo3.org/40279
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Empty item group in selectElement 04/40204/3
ajahn [Fri, 12 Jun 2015 08:42:37 +0000 (10:42 +0200)]
[BUGFIX] Empty item group in selectElement

Item groups that do not have any items are ignored and not rendered

Change-Id: I458a1491788fa8a78321a9c129949c08e62e375f
Resolves: #67394
Releases: master
Reviewed-on: http://review.typo3.org/40204
Tested-by: Pierrick Caillon <pierrick.caillon@plan-net.fr>
Reviewed-by: Alexander Jahn <jahn.typo3@googlemail.com>
Tested-by: Alexander Jahn <jahn.typo3@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Change order of public static to static public 83/40283/5
Wouter Wolters [Tue, 16 Jun 2015 09:39:09 +0000 (11:39 +0200)]
[TASK] Change order of public static to static public

Do this also for protected static.

Resolves: #67487
Releases: master
Change-Id: I045bfb897bdfbfe58c9895792c3dcd340fc477b5
Reviewed-on: http://review.typo3.org/40283
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Removes eval() in scheduler unit tests 78/40278/5
Alexander Krist [Mon, 15 Jun 2015 18:02:13 +0000 (20:02 +0200)]
[TASK] Removes eval() in scheduler unit tests

Adds a new AccessibleProxy for NormalizeCommand and removes
the ugly usage of eval() from NormalizeCommandTest in unit tests.

Change-Id: I2465be5918167582fae5e3e612c89a69b6b22657
Resolves: #67485
Related: #67468
Releases: master
Reviewed-on: http://review.typo3.org/40278
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[FEATURE] Allow .ts file extension for static typoscript templates 64/40264/6
Pierrick Caillon [Mon, 15 Jun 2015 17:20:01 +0000 (19:20 +0200)]
[FEATURE] Allow .ts file extension for static typoscript templates

Static TypoScript support alternative primary names for constants and
setup file:
* constants.ts
* setup.ts

Old names are still working:
* constants.txt
* setup.txt

Resolves: #34922
Releases: master
Change-Id: I6868c22c95337812e6946f16655f024f2ed80471
Reviewed-on: http://review.typo3.org/40264
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] File metadata can’t be edited inline 86/37586/6
Benjamin Mack [Mon, 15 Jun 2015 10:04:51 +0000 (12:04 +0200)]
[BUGFIX] File metadata can’t be edited inline

Since 2012, there is a special mechanism to allow some tables for
editing even if their records reside on a page that is inaccessible for
the user. This is checked for regular forms in
``EditDocumentController``, but the check for inline elements was
missing until this patch.

Resolves: #65563
Releases: master, 6.2
Change-Id: I6d984c28672e2b3ba225ea91f6c7292aa3e1127d
Reviewed-on: http://review.typo3.org/37586
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
4 years ago[BUGFIX] Include of flowplayer for 6.2 static template is wrong 71/40271/2
Wouter Wolters [Mon, 15 Jun 2015 18:51:43 +0000 (20:51 +0200)]
[BUGFIX] Include of flowplayer for 6.2 static template is wrong

Resolves: #67475
Releases: master
Change-Id: Ib8cfdd76f57c601f8162467168c3ec043809a3b9
Reviewed-on: http://review.typo3.org/40271
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Remove last usage of two icons from gfx folder and remove files 40/38440/8
Jan Helke [Thu, 2 Apr 2015 16:26:34 +0000 (18:26 +0200)]
[TASK] Remove last usage of two icons from gfx folder and remove files

Remove the last two usages of gfx/icon_note.gif and
gfx/icon_warning2.gif after the merge of
https://forge.typo3.org/issues/65992 .
These files are only used in TimeTracker.

TimeTracker is rendered in the AdminPanel, go to TypoScript accordion and
select "Display Messages"

Resolves: #66250
Related: #65992
Releases: master
Change-Id: I8d0485d3d4a66a41bce26a6c0a38c978dee52b88
Reviewed-on: http://review.typo3.org/38440
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Update TYPO3 version in ext_emconf.php and composer.json 73/40273/2
Wouter Wolters [Mon, 15 Jun 2015 21:15:37 +0000 (23:15 +0200)]
[TASK] Update TYPO3 version in ext_emconf.php and composer.json

Resolves: #67478
Releases: master
Change-Id: I49cebb422ff87d245d757f7736a3b8b969e8b243
Reviewed-on: http://review.typo3.org/40273
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>