Packages/TYPO3.CMS.git
5 years ago[BUGFIX] Rename hook in VariableFrontend.php 94/25494/2
Nicole Cordes [Sat, 16 Nov 2013 20:33:10 +0000 (21:33 +0100)]
[BUGFIX] Rename hook in VariableFrontend.php

Due to the namespace changes the hook in
typo3\sysext\core\Classes\Cache\Frontend\VariableFrontend.php was
renamed. This patch changes name back to the one before.

Resolves: #53707
Releases: 6.2, 6.1, 6.0
Change-Id: Ibb86188b38aba9ca7e7e2670f843234fae16fa87
Reviewed-on: https://review.typo3.org/25494
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] additionalAttributes for be.buttons.icon-VH misses hsc 85/25485/2
Markus Klein [Mon, 18 Nov 2013 10:42:02 +0000 (11:42 +0100)]
[BUGFIX] additionalAttributes for be.buttons.icon-VH misses hsc

The values of the additional attributes for the backend icon viewhelper
need to be processed through htmlspecialchars().

Resolves: #53711
Releases: 6.2, 6.1, 6.0
Change-Id: I89794c77ad1bb7bad99517e24ae7345e0803616e
Reviewed-on: https://review.typo3.org/25485
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Check for query failures in admin methods 84/25484/2
Thomas Maroschik [Mon, 21 Oct 2013 17:18:23 +0000 (19:18 +0200)]
[BUGFIX] Check for query failures in admin methods

In the DatabaseConnection class the two methods admin_get_fields
and admin_get_keys throw a fatal error when a query failure occurs.

This fix introduces two checks that prevent the methods from fataling
and return an empty result on failure.

Fixes: #53014
Releases: 6.0, 6.1, 6.2

Change-Id: I40f7e52fe14b7d75766f0484e42834b0e1b1a5dc
Reviewed-on: https://review.typo3.org/24940
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-on: https://review.typo3.org/25484
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years agoRevert "[BUGFIX] EM: Fetch list as html, not as json" 47/25447/2
Helmut Hummel [Fri, 15 Nov 2013 17:40:37 +0000 (18:40 +0100)]
Revert "[BUGFIX] EM: Fetch list as html, not as json"

This reverts commit 8a80c2336eabed5c794b2401981b1d35608787e1

This change did not work at all, left unused
templates behind (List/Ter.json),
and caused further bugs #53661

Change-Id: I62d1c6c06a5acb8aeed0a12226b3e7ed1bd3282b
Reviewed-on: https://review.typo3.org/25447
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] FILES.folder does not work 10/25410/2
Stefan Froemken [Sat, 26 Oct 2013 13:58:27 +0000 (15:58 +0200)]
[BUGFIX] FILES.folder does not work

cObject IMAGE was executed with empty values
because given key contains filenames instead of
numbers

Resolves: #45724
Releases: 6.2, 6.1, 6.0
Change-Id: I5582b63080b7e6124c3780a8430efb410876a662
Reviewed-on: https://review.typo3.org/25410
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Move beuser property mappings to global scope 05/24005/2
Philipp Gampe [Mon, 23 Sep 2013 10:00:55 +0000 (12:00 +0200)]
[BUGFIX] Move beuser property mappings to global scope

Currently the persistence settings for all tx_beuser models are defined
in module.tx_beuser.persistence.classes.
If any other module tries to access the corresponding backend user
repository from tx_beuser, then no mappings will be loaded by extbase,
resulting in a wrong cache entry for the model and the attempt to
access a nonexisting table.

Move the class mapping part of the TS template into
  config.tx_extbase.persistence.classes
to make them available for all extensions and modules.

Resolves: #51234
Releases: 6.2, 6.1, 6.0
Change-Id: I0b39c96c9db89c379e5613231a215f27b2dfbcde
Reviewed-on: https://review.typo3.org/24005
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Fix broken edit icons on cType HTML 05/25405/2
Stefan Neufeind [Thu, 14 Nov 2013 17:26:38 +0000 (18:26 +0100)]
[BUGFIX] Fix broken edit icons on cType HTML

Fix the wrong Typoscript configuration for front-end edit icons
for cType HTML (for the traditional fe-editing).

Resolves: #17493
Releases: 6.2, 6.1, 6.0, 4.5
Change-Id: I743d8d8ee77bd76bd9ed2a12cd34817196d3719a
Reviewed-on: https://review.typo3.org/25405
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Distinguish unassigend columns and colPos 0 86/25386/2
Georg Ringer [Sun, 17 Feb 2013 17:06:51 +0000 (18:06 +0100)]
[BUGFIX] Distinguish unassigend columns and colPos 0

When using backend layout columns without a colPos value they should be
just placeholders with the label "not assigned". Currently they are
showing the content of the column 0 instead if there is such a column in
the backend layout.

The label "not assigned" is used for columns without any
label, otherwise the label is used together with the suffix
"(not assigned)".

Change-Id: I02c418eebdd9345c3066aa8c3eeec353d2cd9e58
Resolves: #25157
Resolves: #45550
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/25386
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] Native date and datetime values do not consider timezone 67/25367/2
Oliver Hader [Wed, 11 Sep 2013 14:12:20 +0000 (16:12 +0200)]
[BUGFIX] Native date and datetime values do not consider timezone

The TCA configuration property "dbType" allows to store "date"
or "datetime" values directly in the database (instead of using
a timestamp value).
However, the timezone is not recognized correctly - besides that,
the serverTimeZone is applied which does not make much sense at
all, since it leaves out DST handling.

Fixes: #51918
Releases: 6.0, 6.1, 6.2
Change-Id: I45da65d8cee2611358303e93305cb5c793223746
Reviewed-on: https://review.typo3.org/25367
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Compressor resolves dots in filenames correctly 10/25010/2
Christian Kuhn [Thu, 17 Oct 2013 16:46:47 +0000 (18:46 +0200)]
[BUGFIX] Compressor resolves dots in filenames correctly

Method getFilenameFromMainDir() tries to resolve a given file path
to a path relative to the document root and takes care of file
existance.

Sometimes it is fed with a path like '../path/to/file' and then
prepends it with the document root to call an is_file() on it. The
constructed path is then '/path/to/doc/root/typo3/../path/to/file'. If
now 'root' is a symlink to some sub structure itself, is_file()
will fail, because it does not solve the '..' part correctly anymore.

Using resolveBackPath() on the path before feeding it to is_file()
transforms the path to '/path/to/doc/root/path/to/file'. So the dots
are resolved and is_file is happy.

Change-Id: I20b4f4bbea695aeb02e3d92469236bc63cd05d97
Resolves: #52926
Releases: 6.2, 6.1, 6.0, 4.7
Reviewed-on: https://review.typo3.org/25010
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] T3editor: Make errors/exceptions show correctly 79/25079/2
Stefan Neufeind [Thu, 24 Oct 2013 23:26:02 +0000 (01:26 +0200)]
[BUGFIX] T3editor: Make errors/exceptions show correctly

* Display T3editor.lang.errorWhileSaving in a flashmessage.
* Pass exception-messages through the AJAX-call and display
  them in the flashmessage as well.

Change-Id: Ia743b5a3fc9a7b272854920bcc0e9d081d4822ef
Resolves: #53115
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/25079
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix menu popup for all IE versions 84/25284/3
Alexander Opitz [Wed, 21 Aug 2013 15:09:23 +0000 (17:09 +0200)]
[BUGFIX] Fix menu popup for all IE versions

The IE has problems with base URLs in JS on window.open()
function calls. This problem was already fixed for content
objects but not for the menu.

This change adds the baseUrlWrap and also the quoteJSvalue
function call like in ContentObjectRenderer::typoLink().

Resolves: #22136
Releases: 6.2, 6.1, 6.0, 4.5
Change-Id: Ia1ad859d2acb358378bc4ffa3f6a9162b3fc6937
Reviewed-on: https://review.typo3.org/25284
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] dataTables: Avoid sending cookie-data too often 42/25342/2 42/25342/3
Stefan Neufeind [Thu, 17 Oct 2013 23:05:25 +0000 (01:05 +0200)]
[BUGFIX] dataTables: Avoid sending cookie-data too often

All core-modules currently using jQuery-dataTables are
called through mod.php. So by adding that to the
cookie-path we can at least prevent sending those cookies
with requests like JS/CSS/images.

Change-Id: Ia9ea30e8967564572c7104600eb8dcc67647382d
Resolves: #52934
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/25342
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Wrong usage-text for cli_dispatch 46/25346/2
Tomita Militaru [Tue, 12 Nov 2013 12:05:14 +0000 (14:05 +0200)]
[BUGFIX] Wrong usage-text for cli_dispatch

Correct usage text for cli_dispatch, use --refindex update
instead of -e

Resolves: #53399
Releases: 6.2, 6.1, 6.0
Change-Id: I6e571e8ba1cc139c7a4004800491637d5b3af6d7
Reviewed-on: https://review.typo3.org/25346
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Evaluator in JS fails with namespaces 17/25317/2
Stefan Aebischer [Mon, 28 Oct 2013 22:07:09 +0000 (23:07 +0100)]
[BUGFIX] Evaluator in JS fails with namespaces

If you add an own evaluator, you have to insert the
class inclusive namespaces. JavaScript in TYPO3
backend fails to use the correct class set in
namespaces.

Resolves: #52904
Releases: 6.2,6.1,6.0
Change-Id: I356a2a7ff169462307506c64234741e6a690f8e2
Reviewed-on: https://review.typo3.org/25317
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Make be.buttons.icon-ViewHelper extensible 11/25311/2
Stefan Neufeind [Mon, 11 Nov 2013 22:43:29 +0000 (23:43 +0100)]
[BUGFIX] Make be.buttons.icon-ViewHelper extensible

Many of the standard-ViewHelpers (tag-based) at least support
additionalAttributes. Introduce this for be.buttons.icon as well
to allow for attributes like onclick or target. Those arguments
will be assigned to the surrounding a-tag if an uri is specified.

Change-Id: I0b8ef12842a818ed5d49437a003287aff9b08f13
Resolves: #53538
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/25311
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Hard-coded labels in file collections 80/25280/3
Tomita Militaru [Mon, 11 Nov 2013 14:29:35 +0000 (16:29 +0200)]
[TASK] Hard-coded labels in file collections

Adds labels for file collection types in TCA

Resolves: #52727
Release: 6.2, 6.1, 6.0
Change-Id: I0aafc385d824a41a4e6045a9708d726dee06ea39
Reviewed-on: https://review.typo3.org/25280
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Correctly append additionalTreelistUpdateFields 77/25277/2
Bart Dubelaar [Tue, 27 Nov 2012 00:45:21 +0000 (01:45 +0100)]
[BUGFIX] Correctly append additionalTreelistUpdateFields

The list of additionalTreelistUpdateFields was not correctly
appended to the updateRequiringFields array.

Resolves: #37948
Releases: 6.2, 6.1, 6.0, 4.5
Change-Id: I7df514649203bf607a6ac3550c875c429e0f7328
Reviewed-on: https://review.typo3.org/25277
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Call to FlashMessageQueue::addMessage() method in extbase 72/25272/2
Markus Klein [Wed, 2 Oct 2013 20:40:23 +0000 (22:40 +0200)]
[BUGFIX] Call to FlashMessageQueue::addMessage() method in extbase

Extbase still uses the addMessage method, which is deprecated.
The official API is now enqueue(), let's use this one.

Resolves: #52488
Releases: 6.1, 6.2
Change-Id: I85097ee53ded9c2d2ccdc6c240667ddaa3768999
Reviewed-on: https://review.typo3.org/25272
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] EM: Fetch list as html, not as json 69/25269/2
Stefan Neufeind [Fri, 8 Nov 2013 13:40:14 +0000 (14:40 +0100)]
[BUGFIX] EM: Fetch list as html, not as json

After performing an update from TER currently the extension-list
is fetched as format=json. This however leads to that situation
that links in the list also have format=json and won't work
anymore (example: pagination-widget).

Change-Id: Id37ab27bb3acd821e9dc0cadb23978aa3e5d9784
Resolves: #53423
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/25269
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Correct storage selection (follow-up) 32/25232/2
Ernesto Baschny [Thu, 26 Sep 2013 14:44:59 +0000 (16:44 +0200)]
[BUGFIX] Correct storage selection (follow-up)

The new matching did not consider Windows paths names as the
previous version did. Using PathUtility is safer.

Releases: 6.2, 6.1, 6.0
Resolves: #52173
Change-Id: Ib0454a468bb93f5baab9677ffafc86efd0f1ae27
Reviewed-on: https://review.typo3.org/25232
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Fix superfluous strlen() on constant strings 43/25243/2
Steffen Ritter [Sat, 9 Nov 2013 21:41:29 +0000 (22:41 +0100)]
[TASK] Fix superfluous strlen() on constant strings

Releases: 6.2, 6.1, 6.0
Resolves: #53477
Change-Id: I27817df25c126beb216c2b933c82ad9c35b74d80
Reviewed-on: https://review.typo3.org/25243
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Enable treeConfig overriding by Page TSconfig 35/25235/2
Stefan Froemken [Mon, 8 Apr 2013 10:58:15 +0000 (12:58 +0200)]
[BUGFIX] Enable treeConfig overriding by Page TSconfig

Add treeConfig to whitelist to allow overriding rootUid
as described in the documentation. Example:

TCEFORM.pages.categories.config.treeConfig.rootUid = 1

Resolves: #47040
Releases: 6.2, 6.1, 6.0, 4.7
Change-Id: Idd55593b063daa0be3c2943400f82617b0bf6218
Reviewed-on: https://review.typo3.org/25235
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] T3editor: Honour fileDenyPattern on saving included TS 57/25057/2
Stefan Neufeind [Tue, 29 Oct 2013 21:17:25 +0000 (22:17 +0100)]
[BUGFIX] T3editor: Honour fileDenyPattern on saving included TS

fileDenyPattern is only checked on loading so far.
Needs to be added for saving as well taken into account, since
otherwise an arbitrary file (including .php) can be overwritten.

Change-Id: Ia7edc83c8954942fb848746abc0980a304a1a6df
Resolves: #53195
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/25057
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Escape title, extension, description of scheduler tasks 14/25214/2
Tomita Militaru [Sat, 2 Nov 2013 22:14:14 +0000 (00:14 +0200)]
[BUGFIX] Escape title, extension, description of scheduler tasks

Properly escapes the title, description and extension of
displayed scheduler tasks

Resolves: #29179
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ie03383f694863e435bfb96341226f8c78be426e5
Reviewed-on: https://review.typo3.org/25214
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Exception using cObject FORM in TypoScript 17/23717/2
Andreas Bouche [Fri, 4 Nov 2011 09:32:09 +0000 (10:32 +0100)]
[BUGFIX] Exception using cObject FORM in TypoScript

Through a bug introduced by #31120, an Exception is thrown when a
TypoScript FORM object should be rendered.

Fixes: #31572
Releases: 6.2, 6.1, 6.0, 4.7
Change-Id: Ie67484fd014620ea229a7bee8bfebd063a3b57ae
Reviewed-on: https://review.typo3.org/23717
Reviewed-by: Stefan Neufeind
Reviewed-by: Sebastian Michaelsen
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Enable BE search for multiple mountpoints 86/24886/3
Georg Ringer [Thu, 19 Sep 2013 05:31:20 +0000 (07:31 +0200)]
[BUGFIX] Enable BE search for multiple mountpoints

Backend search now allows search from all mounts of an editor.
If the root page is selected it will search in all mounts of the
backend user.

Change-Id: Ic462725bb4cba8100c5eeca5f7f47b5711ab2869
Resolves: #35073
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24886
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Exclude central Modernizr from concatenation 80/24880/2
Stefan Neufeind [Thu, 17 Oct 2013 20:30:29 +0000 (22:30 +0200)]
[TASK] Exclude central Modernizr from concatenation

Modernizr is added to every "page" in the backend
as a default in DocumentTemplate. By default all JS
gets merged. Thus Modernizr is added to multiple
files.

Reduce the size of JS-files and allow browsers to
take advantage of reusing that code by having this
library as a separate part.

Change-Id: If18ca423ac3b4b1347c1319189d0feb019f37b7f
Resolves: #52931
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24880
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Tests for Persistence\Generic\Backend::getIdentifierByObject 77/24877/2
Stefan Neufeind [Sun, 6 Oct 2013 23:13:28 +0000 (01:13 +0200)]
[TASK] Tests for Persistence\Generic\Backend::getIdentifierByObject

Change-Id: Idb00a92469672e907286024ec461f0b8ee98c6c9
Resolves: #52570
Releases: 6.1, 6.2
Reviewed-on: https://review.typo3.org/24440
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit ec71772a424f08a5f1e8d671169c72767331b92f)
Reviewed-on: https://review.typo3.org/24877

5 years ago[BUGFIX] Getting the identifier for a lazy object fails 59/24859/2
Marc Bastian Heinrichs [Tue, 30 Jul 2013 08:52:43 +0000 (10:52 +0200)]
[BUGFIX] Getting the identifier for a lazy object fails

Using PersistenceManager::getIdentifierByObject doesn't work for lazy
object since version 6.1, because the function uses the session object
directly. Before the Backend::getIdentifierByObject was used, which
handles lazy objects right.
Solution: use the Backend again.

Resolves: #50548
Releases: 6.2, 6.1
Change-Id: I8381a968f730918b96b6764d3f62bfc5f58509ee
Reviewed-on: https://review.typo3.org/24859
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Suppress empty tag names in output of array2xml 48/24848/2
Markus Hoelzle [Wed, 16 Oct 2013 13:26:58 +0000 (15:26 +0200)]
[BUGFIX] Suppress empty tag names in output of array2xml

If a tag name is empty GeneralUtility::array2xml must not output that
tag at all.

Resolves: #52529
Releases: 6.2, 6.1, 6.0
Change-Id: Ib075feac25e5ba06884436db6d4be69cc428a43d
Reviewed-on: https://review.typo3.org/24848
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Preserve vendor name in refering request 88/24788/3
Thomas Maroschik [Tue, 15 Oct 2013 09:28:41 +0000 (11:28 +0200)]
[BUGFIX] Preserve vendor name in refering request

Fluid FormViewHelper adds some hidden fields that contain information
about the current controller. When the form is submitted and contains
a validation error the errorAction int the ActionController is hit.
This one builds a refering request object from the hidden fields without
a vendor name, as this one is not passed from the FormViewHelper.
The request object tries to guess the controller name but guesses a non
namespaced classes name as the vendor name is not given. To get further
information about the class methods the class name gets autoloaded and
creates a wrong classes cache entry as the autoloader cannot detect if
a extension has namespaced or non namespaced classes from the outside.

This patch introduces a hidden vendor name field in the Fluid FormViewHelper.

Fixes: #52823
Releases: 6.2, 6.1, 6.0
Change-Id: I0a82cf2ee07ce293eda0b9f50d3cac7b2a513f15
Reviewed-on: https://review.typo3.org/24788
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Follow-Up: Fatal error due to missing use statement 28/24828/2
Sascha Egerer [Wed, 16 Oct 2013 07:31:17 +0000 (09:31 +0200)]
[BUGFIX] Follow-Up: Fatal error due to missing use statement

A fatal error occurs in the DataHandler.php due to a missing
use statement that was forgotten in the backport.

Related: #52636
Releases: 6.1
Change-Id: I6f893e56f86f3ade6e685efb7c40b73fa28c1840
Reviewed-on: https://review.typo3.org/24828
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Moving folders fails 00/24800/2
Oliver Hader [Tue, 15 Oct 2013 12:38:43 +0000 (14:38 +0200)]
[BUGFIX] Moving folders fails

On moving existing folders inside another existing folder in the
file-module, the following exception is thrown:

1314085991: uid of Storage has to be numeric.

The reason is obvious, since the submitted storage key contains
the storage object instead of the UID of the storage.

Change-Id: Ia6f6af5252880a7bde8a537bc9e343c392eadbf5
Fixes: #52845
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/24800
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Only load folder contents if folder is initialised 81/24781/2
Frans Saris [Mon, 5 Aug 2013 20:13:55 +0000 (22:13 +0200)]
[BUGFIX] Only load folder contents if folder is initialised

FolderBasedFileCollection::loadContents() has to check if
the folder is initialised prior to loading the contents to
prevent fatal errors.

Fixes: #50802
Releases: 6.2, 6.1, 6.0
Change-Id: If3ce06cff13595da49abbb6aa99c891969aea692
Reviewed-on: https://review.typo3.org/24781
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Superfluous usage of ObjectManagerException 74/24774/2
Oliver Hader [Mon, 14 Oct 2013 22:00:53 +0000 (00:00 +0200)]
[BUGFIX] Superfluous usage of ObjectManagerException

The workspace backend module uses
\TYPO3\CMS\Extbase\Object\ObjectManagerException instead of
\TYPO3\CMS\Extbase\Object\ObjectManager.

Change-Id: Ieb30ed6cd3e8d33de7270800044b0eeebf83be90
Fixes: #52824
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/24774
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[FEATURE] Add getValidators to AbstractCompositeValidator 73/23573/3
Stefan Froemken [Wed, 4 Sep 2013 07:09:14 +0000 (09:09 +0200)]
[FEATURE] Add getValidators to AbstractCompositeValidator

removeValidator is unusable as long as there is no method
to get contained validators

Resolves: #51707
Releases: 6.2, 6.1, 6.0
Change-Id: If8705e8b5c7c2dfa84a732b97813d6097930f209
Reviewed-on: https://review.typo3.org/23573
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Use callback in preg_replace in RemoveXSS 55/24755/2
Jigal van Hemert [Mon, 14 Oct 2013 08:34:52 +0000 (10:34 +0200)]
[BUGFIX] Use callback in preg_replace in RemoveXSS

Since PHP 5.5.0 the use of the /e modifier is deprecated in preg_replace.
Use callback function instead.
Also change comments to CGL format.

Change-Id: I44f12e8bfa1c976e494dae847cc6c53d15ed7c2d
Fixes: #52771
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/24755
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Detect unix-styled absolute paths on Windows systems 24/24724/2
Nicole Cordes [Mon, 14 Oct 2013 08:12:34 +0000 (10:12 +0200)]
[BUGFIX] Detect unix-styled absolute paths on Windows systems

Currently PathUtility::isAbsolutePath and GeneralUtility::isAbsPath
only the for ":\" to detect absolute paths on Windows systems. This
patch provides even ":/" as unix-styled paths are mostly used now.

Resolves: #52773
Releases: 6.2, 6.1, 6.0
Change-Id: I1e132bbe74394861af4bf02a22287c9496953150
Reviewed-on: https://review.typo3.org/24724
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Object passed to date() 10/24710/2
Xavier Perseguers [Sun, 13 Oct 2013 17:56:12 +0000 (19:56 +0200)]
[BUGFIX] Object passed to date()

Function date() expects a timestamp as second parameter, not
an object.

Fixes: #52759
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I6821bafa51372c50d8903c63d62ea44933bc12b3
Reviewed-on: https://review.typo3.org/24710
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[TASK] Use 6.1 branch in travis-integration for travis 60/24660/2
Christian Kuhn [Sat, 12 Oct 2013 20:18:56 +0000 (22:18 +0200)]
[TASK] Use 6.1 branch in travis-integration for travis

Change-Id: I748bae0a4c4995d6e47b42d2d84cead36db3665d
Resolves: #52731
Related: #47018
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/24660
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Use BackendUtility use statement 58/24658/2
Anja Leichsenring [Sat, 12 Oct 2013 18:34:23 +0000 (20:34 +0200)]
[BUGFIX] Use BackendUtility use statement

Due to a faulty backport BackendUtility was used without proper
namespace, leading to a fatal error while editing page properties.
This introduces the use statement for all occurences in the class.

Resolves: #52728
Releases: 6.1, 6.0
Change-Id: I37b9e98513b1dd173e7099bce68a5950b9dd12e1
Reviewed-on: https://review.typo3.org/24658
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Wrong calculation of maximum value for checkbox fields 53/24653/2
Nicole Cordes [Sat, 12 Oct 2013 16:36:30 +0000 (18:36 +0200)]
[BUGFIX] Wrong calculation of maximum value for checkbox fields

This patch corrects the calculation of the maximum value for a group
of checkboxes which is stored as bit flag value in the database. The
formular for the maximum value is 2nd power of the item count minus one.

Resolves: #52104
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I0eb430b72a072838c6ac3bc3f5e339ff2509c455
Reviewed-on: https://review.typo3.org/24653
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
5 years ago[BUGFIX] Prevent empty newline below scheduler-task-name 19/24619/2
Stefan Neufeind [Sat, 12 Oct 2013 01:20:07 +0000 (03:20 +0200)]
[BUGFIX] Prevent empty newline below scheduler-task-name

The newline below a scheduler-task-name is only needed
if a progress-bar and/or additional-information follow.

Change-Id: I8d92fc0d3b8d88fdbdfdc79d8ee501b74d821bcc
Resolves: #52715
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24619
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[BUGFIX] DataMapFactory::resolveTableName must remove leading backslashes 03/24603/2
Alexander Schnitzler [Fri, 11 Oct 2013 16:33:10 +0000 (18:33 +0200)]
[BUGFIX] DataMapFactory::resolveTableName must remove leading backslashes

Currently the method just splits the given class name
by backslashes to detect the proper vendor name. If using
a leading backslash the algorithm of this function causes
a wrong result. Therefore all leading backslashes must be
removed first.

Releases: 6.2, 6.1, 6.0
Fixes: #52708
Change-Id: Icdc46facf66260bf528994964fb713d3dd24b3c6
Reviewed-on: https://review.typo3.org/24603
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] BackendUtility::viewOnClick() called with non-integer 64/23064/4
Oliver Hader [Thu, 8 Aug 2013 10:48:24 +0000 (12:48 +0200)]
[BUGFIX] BackendUtility::viewOnClick() called with non-integer

The origin is in DatabaseRecordList::makeControl() that
tries to create a preview link with the page id "243#33163"
- more strict checks will deny this request because it's not
the expected integer value. Thus, BackendUtility::viewOnClick()
is called with a string instead of an integer.
This happens in the regular list module in the TYPO3 backend.
It's not critical if hooks and further processors use intval() on the
argument, but is bad if methods expect the defined integer value.

Change-Id: Ib66c1ee219b67e51d534f11fbf1eaa330476ca93
Fixes: #50912
Releases: 4.5, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/23064
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Clear_cache() must not consider page ids lower than 0 79/23079/3
Oliver Hader [Fri, 11 Oct 2013 12:30:53 +0000 (14:30 +0200)]
[BUGFIX] Clear_cache() must not consider page ids lower than 0

DataHandler::clear_cache() is called with a table and an uid that
has been modified to trigger the clear cache commands. To find
siblings, children, parents, etc. the pid value is directly used
to find the affected pages. However, in a workspace context, the
pid is always "-1" which leads to a selection of all page
records of all workspaces. This amount is used to flush all
defined caches by a given tag name and might result in execution
time outs.

To avoid these superfluous cache flushes, page ids lower than 0
are ignored now in this section.

Fixes: #51051
Releases: 6.0, 6.1, 6.2
Change-Id: I03987bbd8c5d3526fb4dfda75b0dd0316fe1d836
Reviewed-on: https://review.typo3.org/23079
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Select available page when changing WS 90/24590/2
Thorsten Kahler [Thu, 7 Feb 2013 17:13:34 +0000 (18:13 +0100)]
[BUGFIX] Select available page when changing WS

When changing to another workspaces the currently selected page is not
always available.
This change selects the next available page from the rootline for page
tree and submodules of web module when the current page does not exist
in the workspace.

Change-Id: I0502fea3c21515421586403a41f5c696ffc0d762
Fixes: #37611
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/24590
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Copy records to target page before origin page is deleted 84/24584/2
Timo Webler [Thu, 10 Oct 2013 07:21:48 +0000 (09:21 +0200)]
[BUGFIX] Copy records to target page before origin page is deleted

When a deletion of a page is published, all moved records
have to be copied to their new location before they get deleted.

Resolves: #52636
Releases: 6.2, 6.1, 6.0
Change-Id: Ide471b4f25c0350a1df57af3d92283310a76cac9
Reviewed-on: https://review.typo3.org/24584
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Create workspace placeholder with processed field content 82/24582/2
Sascha Egerer [Wed, 7 Aug 2013 19:27:08 +0000 (21:27 +0200)]
[BUGFIX] Create workspace placeholder with processed field content

The field content that is used for the workspace placeholder records
is not processed through the field configuration.

This produces annoying error messages to the user.

Resolves: #17551
Releases: 6.2, 6.1, 6.0
Change-Id: I79823cc2bd0d26a03b0850045c08999ebdbc1a9b
Reviewed-on: https://review.typo3.org/24582
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Add workspace overlay for fetched records. 77/24577/2
Timo Webler [Wed, 25 Apr 2012 15:07:31 +0000 (17:07 +0200)]
[BUGFIX] Add workspace overlay for fetched records.

Call workspace overlay to resolve the right uid for
move-placeholder.

Change-Id: I6af65fcda1b1fffe72dfbc314976e42f30120d71
Fixes: #36573
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/24577
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] WS preview shows pages changes from all WS 73/24573/2
Thorsten Kahler [Thu, 7 Feb 2013 10:14:25 +0000 (11:14 +0100)]
[BUGFIX] WS preview shows pages changes from all WS

In workspace preview the query condition for pages records has to be
enhanced to restrict to live WS and current WS.

Change-Id: Ib271b9bb435b50f2777621707728a74ba5de4187
Fixes: #37209
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24573
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Delete modified record in WS just deletes WS version 67/24567/2
Sascha Egerer [Fri, 4 Oct 2013 09:57:35 +0000 (11:57 +0200)]
[BUGFIX] Delete modified record in WS just deletes WS version

If you edit a record in a workspace and then you try to
delete the record, the record it not deleted but the
version (workspace-change record) is.

Resolves: #52530
Releases: 6.2, 6.1, 6.0
Change-Id: I6a77f9a398276af98c41d841053641f3e07b2e33
Reviewed-on: https://review.typo3.org/24567
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Don't show duplicates in workspace preview 08/24008/2
Timo Webler [Mon, 3 Dec 2012 08:51:02 +0000 (09:51 +0100)]
[BUGFIX] Don't show duplicates in workspace preview

Fixed workspace filters in case of workspace preview
in TYPO3\CMS\Frontend\Page\PageRepository::enableFields().

Additionally cleared up the corresponding comments.

Change-Id: I088928a88cb673f18f218ef691a6c528019317c0
Fixes: #37065
Releases: 6.2, 6.1, 6.0, 4.5
Reviewed-on: https://review.typo3.org/24008
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Cannot upload an extension as zip 31/24531/2
Xavier Perseguers [Wed, 25 Sep 2013 07:41:58 +0000 (09:41 +0200)]
[BUGFIX] Cannot upload an extension as zip

The file extension ".zip" should be systematically removed when
extracting the extension key from the uploaded file name.

Fixes: #52178
Releases: 6.2, 6.1, 6.0
Change-Id: I5316b995533fa324d3b19407ad9bb6365ab8858b
Reviewed-on: https://review.typo3.org/24037
Reviewed-by: Sebastian Fischer
Tested-by: Sebastian Fischer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit e1db658c3f6d332f4c1971f333b55c168aed43df)
Reviewed-on: https://review.typo3.org/24531

5 years ago[BUGFIX] Fields of type file_reference are not properly indexed 48/24448/2
Martin Borer [Mon, 12 Aug 2013 10:44:46 +0000 (12:44 +0200)]
[BUGFIX] Fields of type file_reference are not properly indexed

sys_refindex entries for TCA-fields of type group->file_reference
are not correct. The fields ref_table and ref_uid are not filled.
This results in a wrong number of references in the Ref column of
the Filelist module and prevents a warning that a resource is still
in use when deleting it.

Resolves: #49538
Releases: 6.2, 6.1, 6.0
Change-Id: I1c44fc98b7ceefd6247ec372e5b28f8682a47bf1
Reviewed-on: https://review.typo3.org/24448
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Missing closing tag in ElementBrowser 37/24437/2
Philipp Gampe [Sun, 6 Oct 2013 22:10:12 +0000 (00:10 +0200)]
[BUGFIX] Missing closing tag in ElementBrowser

There is missing " />" at the end for $clickIcon, which refers to
the thumbnail in the element browser.
Resolves: #52546
Releases: 6.2, 6.1, 6.0
Change-Id: I2da27190db0ca627c2967750f828c6748b039356
Reviewed-on: https://review.typo3.org/24437
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
5 years ago[TASK] Use instanceof comparison instead of string comparison 98/24398/2
Benjamin Serfhos [Wed, 2 Oct 2013 12:28:17 +0000 (14:28 +0200)]
[TASK] Use instanceof comparison instead of string comparison

This allows the ViewHelper to render elements which are extending
the model.

Resolves: #52469
Releases: 6.2, 6.1, 6.0
Change-Id: If4b9b3019b44e38a5a25cb74ff993e572464bb9d
Reviewed-on: https://review.typo3.org/24398
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] TS is fetched from cache incorrectly sometimes 77/24177/2
Dmitry Dulepov [Mon, 3 Dec 2012 09:40:25 +0000 (13:40 +0400)]
[BUGFIX] TS is fetched from cache incorrectly sometimes

If $TYPO3_CONF_VARS['FE']['defaultTypoScript_constants'] or
$TYPO3_CONF_VARS['FE']['defaultTypoScript_setup'] are set through
the PHP code, cached TS will not be found in cache. This would
result in TS parsing every time when there are USER_INT objects
on the page. It may slow down the page with USER_INT objects
by about 300% comparing to the cached version.

This change is re-added after it got reverted due to lack of reviews in
Ia0fd65a35897c71d60c48c0b03098ce67ad16c70.

Change-Id: Ief3a065451644423b236489729716b906f3d4500
Resolves: #43540
Releases: 4.5, 4.7, 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/24177
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
5 years ago[BUGFIX] Fix wrong handling of php and TYPO3 dependencies 26/24126/2
Susanne Moog [Sun, 8 Sep 2013 13:26:22 +0000 (15:26 +0200)]
[BUGFIX] Fix wrong handling of php and TYPO3 dependencies

Due to a superfluos try-catch block dependencies for TYPO3 and
PHP version were not checked correctly.

Additionally the TER version comparison was wrong as it did not
include the given version (only less or greater was checked, not
...OrEqual).

Resolves: #48809
Resolves: #51730
Resolves: #51182
Releases: 6.2, 6.1, 6.0
Change-Id: I773e1af014cd3e8525794c2fcdc615ea8a5f36a1
Reviewed-on: https://review.typo3.org/24126
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Initialize extension name in command requests 24/24124/2
Alexander Stehlik [Wed, 25 Sep 2013 06:40:37 +0000 (08:40 +0200)]
[BUGFIX] Initialize extension name in command requests

This patch initializes the extension name in the configuration manager
as soon as it is available during an Extbase command line request.

Resolves: #51329
Releases: 6.2, 6.1, 6.0
Change-Id: I73b0f0e7a0b20e1773c9eb92f0d2175416ce2bb1
Reviewed-on: https://review.typo3.org/24124
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] EmConfUtility accesses non-arrays 97/24097/2
Markus Klein [Mon, 16 Sep 2013 19:20:12 +0000 (21:20 +0200)]
[BUGFIX] EmConfUtility accesses non-arrays

Properly check for array-type before accessing
or counting the variable.

Resolves: #52045
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Id161fddadbbcadd462de36e8227278107f2e7a3a
Reviewed-on: https://review.typo3.org/24097
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Clear cached menu by tag 95/24095/2
Zbigniew Jacko [Tue, 3 Sep 2013 22:10:48 +0000 (00:10 +0200)]
[BUGFIX] Clear cached menu by tag

This change adds a table cf_cache_hash for clear cache by tag
for example for cached menu.

Resolves: #51588
Releases: 6.2, 6.1, 6.0
Change-Id: I18b8aad3ac82737bbc52d4aae49be9028b6df944
Reviewed-on: https://review.typo3.org/23624
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Piotr Molewski
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit f6a8c13d3f71be582147be19d105046fce1d82ad)
Reviewed-on: https://review.typo3.org/24095

5 years ago[BUGFIX] Fix jumpToUrl()-Usage in Element Browser 93/24093/2
Benjamin Pick [Wed, 18 Sep 2013 14:53:44 +0000 (16:53 +0200)]
[BUGFIX] Fix jumpToUrl()-Usage in Element Browser

The Javascript functions jumpToUrl(URL,anchor) and jumpToUrl(URL,formEl)
cannot be used interchangeably. This leads to a javascript error,
because the formElement is rendered as string
("[object HTMLInputElement]").

Resolves: #50437
Releases: 6.0, 6.1, 6.2
Change-Id: I53e1be3c157a2ef6c646f02af15e8c746b6e6375
Reviewed-on: https://review.typo3.org/24093
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Check for string before using strlen 89/24089/2
Kilian Hann [Tue, 24 Sep 2013 13:34:15 +0000 (15:34 +0200)]
[BUGFIX] Check for string before using strlen

If pi_flexform is converted to an array already, checking via strlen
produces a warning. An additional check via is_string suppresses the
warning.

Resolves: #52091
Resolves: #51684
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I97c41cdedb1afb28e2a9ca39e1d9cfb3921d9f47
Reviewed-on: https://review.typo3.org/24089
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] groupFor-VH does not work with @lazy 87/24087/2
Stefan Froemken [Wed, 25 Sep 2013 13:50:41 +0000 (15:50 +0200)]
[BUGFIX] groupFor-VH does not work with @lazy

If you group an property with annotated @lazy option
f:groupedFor-ViewHelper can't group by this property.

Resolves: #52266
Releases: 6.2, 6.1, 6.0
Change-Id: Ie208b67eec8500fee87ee1c62b1bd348c0ed5598
Reviewed-on: https://review.typo3.org/24087
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fix PHP warning trigged in getAuthInfoArray() 02/24002/2
Christian Finkemeier [Thu, 8 Aug 2013 13:18:55 +0000 (15:18 +0200)]
[BUGFIX] Fix PHP warning trigged in getAuthInfoArray()

AbstractUserAuthentication::getAuthInfoArray() calls
$GLOBALS['TYPO3_DB']->cleanIntList() with a possible NULL argument.
This leads to a PHP warning in GeneralUtility::trimExplode().

Resolves: #50913
Relates: #42921
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I42ddf8fed715c5f8ce060e6ca5826ef3ed8f223e
Reviewed-on: https://review.typo3.org/24002
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Fatal in DefaultConfiguration 85/24085/2
Christian Kuhn [Thu, 26 Sep 2013 20:00:46 +0000 (22:00 +0200)]
[BUGFIX] Fatal in DefaultConfiguration

Change-Id: I6f6c8a2ddc26a6c7584e6a067c887768cf3ae5b1
Resolves: #52316
Related: #52305
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24084
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 951e705be57cf183db1f19ab9aa41396c2ac0035)
Reviewed-on: https://review.typo3.org/24085

5 years ago[BUGFIX] Configure main extbase caches for unlimited entry lifetime 81/24081/2
Christian Kuhn [Thu, 26 Sep 2013 14:12:25 +0000 (16:12 +0200)]
[BUGFIX] Configure main extbase caches for unlimited entry lifetime

The extbase reflection and object caches are "stable" cache entries
and only need to be deleted if extensions change or are updates. The
extension manager takes care of flushing in this case.
Currently, the default lifetime of those cache entries is only one
hour, so they are recalculated pretty often. This is especially a
problem if the site was not accessed for more than an hour, since
tons of cache entries exceeded their lifetime and require
recalculation.
The patch moves the cache configuration of the required extbase
extension to DefaultConfiguration and sets unlimited default
lifetime for object and reflection cache.

Change-Id: I671692645aeb104f7fa73595cc79b25ed5984b85
Resolves: #52305
Related: #51116
Related: #52304
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24069
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 690a3713830fc25e39e9f26937376b0aba10412d)
Reviewed-on: https://review.typo3.org/24081

5 years ago[TASK] Use SimpleFileBackend for t3lib_l10n cache 79/24079/2
Christian Kuhn [Thu, 26 Sep 2013 13:00:08 +0000 (15:00 +0200)]
[TASK] Use SimpleFileBackend for t3lib_l10n cache

The language cache by default uses the FileBackend to store its data.
Language cache entries need to be deleted only if new extensions are
loaded and if new language overlays are fetched. They do not need
tagging and can have an unlimited lifetime.
Switching to SimpleFileBackend removes the tagging and sets unlimited
lifetime by to reduce read and write load on this cache.

Change-Id: I5c4778f4c38ae369b6873574e961fa65208d77a1
Resolves: #52295
Related: #52125
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24064
Reviewed-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 3d0008feb8afa84b1f39ceeb017de2a2d4aca3e4)
Reviewed-on: https://review.typo3.org/24079

5 years ago[BUGFIX] EM does not link to docs.typo3.org 53/24053/2
Xavier Perseguers [Tue, 24 Sep 2013 12:57:27 +0000 (14:57 +0200)]
[BUGFIX] EM does not link to docs.typo3.org

docs.typo3.org is new official documentation platform supporting both
OpenOffice and Sphinx manuals.

Fixes: #52226
Releases: 6.2, 6.1, 6.0
Change-Id: Ie5f27bf15f5174a6e1bb53bedd575ceeb362add8
Reviewed-on: https://review.typo3.org/24017
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/24053

5 years ago[BUGFIX] Increase performance of exports for caches 51/24051/2
Markus Klein [Mon, 23 Sep 2013 10:20:01 +0000 (12:20 +0200)]
[BUGFIX] Increase performance of exports for caches

Exporting arrays for caches is now done with var_export().

Resolves: #51116
Releases: 6.2, 6.1, 6.0
Change-Id: I7519fd9c2ab21cc22a3f4e092b611c6bca58c30f
Reviewed-on: https://review.typo3.org/23969
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit 8167fb19bc4539814a222185a8380be9add2e465)
Reviewed-on: https://review.typo3.org/24051

5 years ago[BUGFIX] Remove duplicate exception code 46/24046/2
Fabien Udriot [Wed, 25 Sep 2013 07:59:08 +0000 (09:59 +0200)]
[BUGFIX] Remove duplicate exception code

Exception code "1314354065" is used twice: once in the abstract
Resource repository and the other one in the File Collection repository.
Since exception code must be unique, the patch simply renames one
occurrence.

Change-Id: I41474db5de7e8f575275d57e9585252857334ee2
Releases: 6.0, 6.1, 6.2
Resolves: #52243
Reviewed-on: https://review.typo3.org/24038
Reviewed-by: Kilian Hann
Tested-by: Kilian Hann
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/24046

5 years ago[BUGFIX] Correct storage selection (common prefixes) 93/23993/2
Ernesto Baschny [Mon, 23 Sep 2013 08:29:56 +0000 (10:29 +0200)]
[BUGFIX] Correct storage selection (common prefixes)

If there is a local storage "uploads/test/" and a requested file
is in "uploads/other/file.txt", the storage matching will not
consider this storage for this file anymore, although they share a
common prefix, but will use a correct matching storage (e.g. 0).

Releases: 6.2, 6.1, 6.0
Resolves: #52173
Change-Id: Id14ffd6620554c086b6e77dca285ade8dee39ab2
Reviewed-on: https://review.typo3.org/23993
Reviewed-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix broken Unit-test for #44825 12/24012/2
Wouter Wolters [Mon, 23 Sep 2013 20:16:32 +0000 (22:16 +0200)]
[BUGFIX] Fix broken Unit-test for #44825

Change-Id: Id1ecce2b4fe789b655f63cd8b5f78ab20eadfbd5
Resolves: #52201
Related: #44825
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/24012
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix page.headerData + USER_INT 81/23981/2
Helmut Hummel [Thu, 12 Sep 2013 13:25:58 +0000 (15:25 +0200)]
[BUGFIX] Fix page.headerData + USER_INT

INT scripts placed in page.headerData.XX were
not replaced any more after introducing USER_INT
capabilities of the pageRenderer in #22273

This change reprocesses _INT placeholders after
the pageRenderer replacements have been done.

Resolves: #44825
Releases: 6.0, 6.1, 6.2
Change-Id: If11b692ed75120dbf122d95ca497b5e382fdf349
Reviewed-on: https://review.typo3.org/23981
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Increase length of identifier field in sys_file 37/23937/2
Nicole Cordes [Tue, 17 Sep 2013 21:36:53 +0000 (23:36 +0200)]
[BUGFIX] Increase length of identifier field in sys_file

Sometimes the identifier is longer than 200 chars. This patch increases
the maximum length to 512 characters.

Resolves: #48912
Releases: 6.2, 6.1, 6.0
Change-Id: I67edc1facf972d2ffef09a3204edc556464afda5
Reviewed-on: https://review.typo3.org/23882
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Aske Ertmann
Tested-by: Aske Ertmann
Reviewed-by: Jon Langeland
Tested-by: Jon Langeland
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit ec0fa11769e123e6e37e248824eaa5853cc4aa07)
Reviewed-on: https://review.typo3.org/23937

5 years ago[BUGFIX] Wrong exception on renaming folder 25/23925/2
Francois Suter [Tue, 17 Sep 2013 07:04:05 +0000 (09:04 +0200)]
[BUGFIX] Wrong exception on renaming folder

When a user tries to rename a folder without the permissions
to do so, the ResourceStorage throws a
"InsufficientFileAccessPermissionsException" instead of a
"InsufficientUserPermissionsException".

Resolves: #52056
Releases: 6.0, 6.1, 6.2
Change-Id: I83e75038bd6763f201ef03ebf37018368e990e1a
Reviewed-on: https://review.typo3.org/23925
Reviewed-by: Francois Suter
Tested-by: Francois Suter
5 years ago[BUGFIX] Fix PHP warning when writing to Backend user log 16/23916/2
Alexander Stehlik [Thu, 15 Aug 2013 16:05:10 +0000 (18:05 +0200)]
[BUGFIX] Fix PHP warning when writing to Backend user log

The writelog method for the BackendUserAuthentication object is now
checking if there is actually an uid available in the user array
before it tries to access it.

This prevents a PHP warning about an illegal string offset when writing
log messages in an authentication service.

Releases: 6.0, 6.1, 6.2
Resolves: #49328
Change-Id: I006c6b0ccd8f03292715a7d7ab8e457914637d93
Reviewed-on: https://review.typo3.org/23116
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit f36574c7a975e93c3a1faf9f3fcace280cda71a8)
Reviewed-on: https://review.typo3.org/23916

5 years ago[BUGFIX] Faulty expand/collapse behavior in Element Browser 77/23877/5
Oliver Hader [Wed, 7 Aug 2013 17:01:53 +0000 (19:01 +0200)]
[BUGFIX] Faulty expand/collapse behavior in Element Browser

On using the element browser in combination with files, the
expand/collapse behavior is wrong. On opening a collapsed folder,
an AJAX call fetches the sub-nodes that will be added to the DOM
tree. However, the calling scope of the original rendering
process and the AJAX call differ a lot.
The only possibility to get this working is to transfer the
scope and rebuild it in the AJAX context.

Change-Id: I1bf7b56ae2d82d15e0246bd651f77793adde705b
Fixes: #45859
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/23877
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Fix cropping of transparent gifs with im6. 72/23872/2
Stefan Neufeind [Thu, 25 Apr 2013 12:06:49 +0000 (14:06 +0200)]
[BUGFIX] Fix cropping of transparent gifs with im6.

The usage of the ! operator to force cropping empty image
canvas is inverted between ImageMagick v4 and v6 while
GraphicsMagick accepts both syntaxes. Because im4 is
deprecated, we can always use im6 syntax.

Fixes: #19045
Releases: 6.2, 6.1, 6.0
Change-Id: Iee1260a94f2686a512ce1b1df65c384319a4c4de
Reviewed-on: https://review.typo3.org/23872
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Form Wizard: Adds mouse pointer to docheader icons 75/23875/2
Ernesto Baschny [Tue, 17 Sep 2013 16:03:03 +0000 (18:03 +0200)]
[BUGFIX] Form Wizard: Adds mouse pointer to docheader icons

Resolves: #50907
Releases: 6.2, 6.1, 6.0
Change-Id: I232498fea18b270e9436aeaf710f728a62365a4b
Reviewed-on: https://review.typo3.org/23875
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Also consider JPEG files for IM/GM 15/23815/2
Markus Klein [Fri, 13 Sep 2013 14:37:32 +0000 (16:37 +0200)]
[BUGFIX] Also consider JPEG files for IM/GM

The Core does not check for the JPEG file extension
when converting images with IM/GM.

Resolves: #51981
Releases: 6.2, 6.1, 6.0
Change-Id: I148ecb0d3c71fdee563476c33865cd18420b2384
Reviewed-on: https://review.typo3.org/23815
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Use a 401 header if login is not successful 00/23800/2
Georg Ringer [Fri, 6 Sep 2013 08:00:04 +0000 (10:00 +0200)]
[TASK] Use a 401 header if login is not successful

If login is not correct, a 401 should be used instead of a 200.

Change-Id: Ia2fa139e89fe19df77bb0530b4fbce502506f524
Resolves: #51803
Releases: 6.2,6.1,6.0,4.5
Reviewed-on: https://review.typo3.org/23800
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Replace SHOW DATABASE by query to schema 95/23795/2
Alexander Opitz [Thu, 5 Sep 2013 12:55:47 +0000 (14:55 +0200)]
[BUGFIX] Replace SHOW DATABASE by query to schema

The SQL query "SHOW DATABASE" may be restricted on the SQL Server.
Since MySQL 5.0 (which is minimum since TYPO3 CMS 4.7) we can also query
the information_schema table to gather the information to which table
we have access.

Resolves: #47744
Releases: 6.2, 6.1
Change-Id: Ie65abadeed54cbc54bee401bdc1aab18ffc8eea6
Reviewed-on: https://review.typo3.org/23795
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Call to undefined method setTemplateFile 92/23792/2
Wouter Wolters [Tue, 10 Sep 2013 17:13:11 +0000 (19:13 +0200)]
[BUGFIX] Call to undefined method setTemplateFile

Call to undefined method when setting
'pageHeaderFooterTemplateFile' in TypoScriptFrontendController.
This needs to be called on the page renderer object.

Change-Id: Ic4407addb5d22f09fc4cd6482cc79ad5af724582
Resolves: #51891
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23734
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
(cherry picked from commit eee040cc3ba06154638f94ed1b59c7e2a78e4064)
Reviewed-on: https://review.typo3.org/23792

5 years ago[TASK] Set TYPO3 version to 6.1.6-dev 74/23774/2
TYPO3 Release Team [Thu, 12 Sep 2013 08:59:01 +0000 (10:59 +0200)]
[TASK] Set TYPO3 version to 6.1.6-dev

Change-Id: I5fa98428e5a7cca5162c8d2b0c7636dae87cde67
Reviewed-on: https://review.typo3.org/23774
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[RELEASE] Release of TYPO3 6.1.5 73/23773/2 TYPO3_6-1-5
TYPO3 Release Team [Thu, 12 Sep 2013 08:58:34 +0000 (10:58 +0200)]
[RELEASE] Release of TYPO3 6.1.5

Change-Id: Icf49a0e16d336e6d942a56a178207c13834dc676
Reviewed-on: https://review.typo3.org/23773
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
5 years ago[BUGFIX] Fix SQL error for sys_file 69/23769/2
Markus Klein [Wed, 11 Sep 2013 22:06:15 +0000 (00:06 +0200)]
[BUGFIX] Fix SQL error for sys_file

Regression for SQL error introduced with #51562.

Resolves: #51929
Releases: 6.2, 6.1
Change-Id: Ib9756234fed6284c5c7547284dff9f3308360c35
Reviewed-on: https://review.typo3.org/23769
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[TASK] Move StorageRepositoryTest tests to AbstractRepositoryTest 65/23765/2
Anja Leichsenring [Wed, 11 Sep 2013 16:59:28 +0000 (18:59 +0200)]
[TASK] Move StorageRepositoryTest tests to AbstractRepositoryTest

All tests in the class belong to AbstractRepository, so the tests move.

Change-Id: I5e78e0d61a2d8f8bcfd06d871a909b749417e616
Resolves: #51923
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23765
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Empty __call() function hides implementation errors 64/23764/2
Anja Leichsenring [Wed, 11 Sep 2013 17:06:53 +0000 (19:06 +0200)]
[BUGFIX] Empty __call() function hides implementation errors

Throw an Exception if this method hits.

Change-Id: Ide94043bb008e1dfaf19b452570ce70d5f2aa432
Resolves: #51924
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/23764
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Move forgotten getEnvironmentMode() 60/23760/2
Anja Leichsenring [Wed, 11 Sep 2013 16:47:30 +0000 (18:47 +0200)]
[BUGFIX] Move forgotten getEnvironmentMode()

getWhereClauseForEnabledFields() moved from StorageRepository
to AbstractRepository, but getEnvironmentMode() stayed
in StorageRepository although getWhereClauseForEnabledFields()
relies on it. Move getEnvironmentMode() as well.

Change-Id: Id252c8bd3b9e09a2c38d5ea1ebe6497dd76c12ae
Resolves: #51562
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23760
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] FAL ResourceStorage must not access sys_file table directly 56/23756/2
Steffen Ritter [Wed, 11 Sep 2013 15:45:47 +0000 (17:45 +0200)]
[TASK] FAL ResourceStorage must not access sys_file table directly

The ResourceStorage accesses the index table sys_file directly via
a call to the $GLOBALS[TYPO3_DB]. The interaction with the sys_file
index table should be managed only by an according repository to
allow changes within that mechanism.

This patch rearranges the factory method to use the according
call within the FileRepository and adapts it, as the FileRepository
will return a file Object instead of an array.

This serves as a preparation for further indexing optimisations,
which need IndexRecords to be handled centrally.

Releases: 6.2, 6.1, 6.0
Resolves: #51519
Change-Id: I5aa2d212b936b218db1808ea3d0384b8292287a9
Reviewed-on: https://review.typo3.org/23756
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Follow-Up: Missing signals on adding file 53/23753/2
Stefan Neufeind [Wed, 11 Sep 2013 15:04:37 +0000 (17:04 +0200)]
[BUGFIX] Follow-Up: Missing signals on adding file

Mocked driver needs to return a proper "file" on calls to addFile().

Change-Id: Iddfc2f9b7e71101ad229a513727f65f64d654d45
Releases: 6.2, 6.1, 6.0
Resolves: #50795
Reviewed-on: https://review.typo3.org/23753
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove sys_file.deleted flag and it's usage 42/23742/3
Ernesto Baschny [Wed, 11 Sep 2013 12:39:43 +0000 (14:39 +0200)]
[TASK] Remove sys_file.deleted flag and it's usage

This also fixes the 'Uncaught TYPO3 Exception #1317178604
No file found for given UID.' that appears when some sys_file
entries have a deleted flag set by mistake.

Resolves: #51562
Releases: 6.2, 6.1, 6.0
Change-Id: Id23636d2732f3562b8a155025656b26041c9a4e2
Reviewed-on: https://review.typo3.org/23742
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Missing signals on adding file 45/23745/2
Andreas Wolf [Mon, 5 Aug 2013 13:28:01 +0000 (15:28 +0200)]
[BUGFIX] Missing signals on adding file

There are signals for most operations performed in the file storage, but
not for adding a file. Especially this operation is interesting for
things like file indexing, automatic generation of variants (renditions)
etc., therefore this patch adds the two missing signals.

Resolves: #50795
Releases: 6.2, 6.1, 6.0
Change-Id: I0def7b44ff8977a42916e01388604fcbf2d6d299
Reviewed-on: https://review.typo3.org/23745
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] Follow-up: Fix fileinfo property mapping in ResourceStorage 23/23723/3
Stefan Neufeind [Mon, 9 Sep 2013 22:11:50 +0000 (00:11 +0200)]
[BUGFIX] Follow-up: Fix fileinfo property mapping in ResourceStorage

Adjust unittest to changed conditions.

Change-Id: Ia885ba544a159cb1666464cece30c3e6ea3558b6
Fixes: #49386
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/23723
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Fix fileinfo property mapping in ResourceStorage::setFileContents 12/23712/2
Thomas Maroschik [Mon, 24 Jun 2013 14:33:02 +0000 (16:33 +0200)]
[BUGFIX] Fix fileinfo property mapping in ResourceStorage::setFileContents

Fixes the handling of the mismatch between the file info property
"mimetype" and the file object property "mime_type" by using the
exposed API methods.

Fixes: #49386
Releases: 6.2, 6.1, 6.0
Change-Id: If948de2a8bead340ae97097b3e4e391a27296362
Reviewed-on: https://review.typo3.org/23712
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] excludeFromUpdates flag ignored 19/23519/3
Francois Suter [Wed, 14 Aug 2013 11:51:22 +0000 (13:51 +0200)]
[BUGFIX] excludeFromUpdates flag ignored

Since the 6.0 Extension Manager, the "excludeFromUpdates" state
is ignored. It should be checked for and the update button in the
list view hidden in such a case.

Resolves: #51018
Releases: 6.0, 6.1, 6.2
Change-Id: I734331d1b85728dc86732f66ad495a9f83cd0aca
Reviewed-on: https://review.typo3.org/23519
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
5 years ago[BUGFIX] mounts of same storage had same subfolder count in Filelist 41/23641/2
Simon Schick [Wed, 22 May 2013 17:42:14 +0000 (19:42 +0200)]
[BUGFIX] mounts of same storage had same subfolder count in Filelist

When you opened the filelist module as user who just was allowed to see
a bunch of filemounts, the filemounts had either all or none the expand-
icon, based on the first file-mount of this storage the user has access
to.

Resolves: #48467
Releases: 6.2, 6.1, 6.0
Change-Id: I1e6a29e351a643f52c0f7a42fde38c9d9b2fc5cb
Reviewed-on: https://review.typo3.org/23641
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind