Packages/TYPO3.CMS.git
6 years ago[BUGFIX] Copy and move folders between storages is broken 94/19194/4
Nicole Cordes [Fri, 22 Mar 2013 17:23:39 +0000 (18:23 +0100)]
[BUGFIX] Copy and move folders between storages is broken

If you try to copy a folder from one storage into another one it leads to
a copy in the same (source) storage. This happens because the action is
executed in the source storage and only works with the source folder
object. This is fixed by calling the move method on the target storage
instead.

Besides the copyFolderBetweenStorages function raises an exception which
might be moved into the driver class as the driver should be responsible
for the copy work. Therefore the AbstractDriver should support
(abstract) methods to copy a folder between storages and the local
driver should raises the exception.

Same applies for moving folders between storages.

Change-Id: Ib282e351f39abca21d57f5d621b4bd999f8419d9
Fixes: #46564
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19194
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX][EM] Fix failing unit tests 08/19208/2
Christian Kuhn [Sat, 23 Mar 2013 11:00:16 +0000 (12:00 +0100)]
[BUGFIX][EM] Fix failing unit tests

Change-Id: I2a100ba46e4b3c3177848ed554ea74f2d2b8dc52
Fixes: #46588
Related: #46573
Releases: 6.1
Reviewed-on: https://review.typo3.org/19208
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX][EM] Fix of last update time after update 02/19202/2
Jost Baron [Fri, 22 Mar 2013 21:23:20 +0000 (22:23 +0100)]
[BUGFIX][EM] Fix of last update time after update

The time of the last update in the extension manager was not displayed
correctly immediately after an update, an additional refresh was needed.

Fixes: #46573
Releases: 6.1
Change-Id: I51b0c966ddb3dda522cc68573d440e24273e96bc
Reviewed-on: https://review.typo3.org/19202
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Title includes html tags 67/19167/2
Nicole Cordes [Fri, 22 Mar 2013 09:13:21 +0000 (10:13 +0100)]
[BUGFIX] Title includes html tags

In the filelist special folders like _temp_ and _recycler_ folder are
highlighted in bold as they get human readable names. The <strong>
tags are shown in the title tag as well. Therefore the title tag has
to be stripped of any html tags.

Change-Id: I4b21a916851e0d02aa58971eabda32f813bd890c
Fixes: #46532
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19167
Reviewed-by: Fabien Udriot
Reviewed-by: Michael Staatz
Reviewed-by: Oliver Klee
Tested-by: Michael Staatz
Reviewed-by: Wouter Wolters
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX] Context menu for offline storages raises exception 81/19181/2
Nicole Cordes [Fri, 22 Mar 2013 13:57:11 +0000 (14:57 +0100)]
[BUGFIX] Context menu for offline storages raises exception

If you try to call the context menu for an offline storage an exception is
raised. Therefore an offline storage shouldn't be linked with a context
menu.

Change-Id: I2845d173bd2a22c96e23bb58bf1a57239109829a
Fixes: #46551
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19181
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[TASK][EM] Truncate table if updating extension list 99/19199/2
Christian Kuhn [Fri, 22 Mar 2013 18:19:15 +0000 (19:19 +0100)]
[TASK][EM] Truncate table if updating extension list

If updating the TER extension list, em deletes all rows of the table
with entries of the specific repository. Since EM handles the main
repository only, truncate can be used here, which is quicker.

Change-Id: Id0dc4fb57d68346f372c44d8cbee247072d09548
Resolves: #46569
Releases: 6.1
Reviewed-on: https://review.typo3.org/19199
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Warning empty $GLOBALS['TCA'] in rootline utility 00/19200/3
Christian Kuhn [Fri, 22 Mar 2013 18:51:56 +0000 (19:51 +0100)]
[BUGFIX] Warning empty $GLOBALS['TCA'] in rootline utility

The TCA refactoring of issue #45767 introduced a warning in the
rootline utility: Rootline resolving is called by determineID in
index_ts. At this point in bootstrap the TCA was not loaded yet.
The patch just moves the TCA includes prior to determineID.

Warning: This leads to an earlier execution of ext_tables.php if
caches are empty. 6.0 did that too, it called includeTca()
in RootlineUtility to circumvent the same issue, the current patch
just solves the issue in a cleaner way. But still, this might lead
to problems if ext_tables.php code relies for example on the setup
done by determineID or the other code in between. The risk this
breaks something is pretty low, though.

Change-Id: I83e6367dbb4654fe0bf957bbe817fa6d5b5ea106
Resolves: #46156
Related: #45767
Releases: 6.1
Reviewed-on: https://review.typo3.org/19200
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK][EM] More readable "time since last update"-strings 16/19116/8
Jost Baron [Wed, 20 Mar 2013 18:00:53 +0000 (19:00 +0100)]
[TASK][EM] More readable "time since last update"-strings

The extensionmanager now shows the time elapsed since the last update,
not the time of the last update. The time of the last update is still
shown in a tooltip. Some english localizations have changed.

Resolves: #46524
Related: #39921
Releases: 6.1
Change-Id: I2d5c6e8099e6973826debfcf2cbb597c35bb499c
Reviewed-on: https://review.typo3.org/19116
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] fallbackRendering is always called 61/17661/3
Simon Schaufelberger [Tue, 22 Jan 2013 22:33:45 +0000 (23:33 +0100)]
[BUGFIX] fallbackRendering is always called

When rendering textpic, the content object rendering is always called for
the Typoscript setting fallbackRendering which is not always defined.

Change-Id: I2ebfffd2ece8022136c4fcc8d0e12d552486dd32
Fixes: #44732
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/17661
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Small clean up in the page tree code 49/19049/3
Dmitry Dulepov [Tue, 19 Mar 2013 14:35:21 +0000 (18:35 +0400)]
[TASK] Small clean up in the page tree code

There are minor issues in the page tree code, which should be
cleaned up. This is a non-functionality change.

Change-Id: Ia4a27797293cb94d58927036ec33dd28a02d0961
Resolves: #46435
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19049
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[TASK] Update file type according to Iana standard 97/18297/4
Fabien Udriot [Fri, 15 Feb 2013 10:59:12 +0000 (11:59 +0100)]
[TASK] Update file type according to Iana standard

This change relates to the File types in FAL.
The Iana standard http://www.iana.org/assignments/media-types
defines a list of Media types which are followed in TYPO3 CMS.
It looks the "Software" type should be deprecated and replaced by
"Application". This matches the mime-type e.g application/pdf and
sounds more comprehensive.

Change-Id: Ic2ec7173d10b6139e6e2a19fcead3086665a3aae
Fixes: #45503
Releases: 6.1
Reviewed-on: https://review.typo3.org/18297
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[TASK] thumbs.php ease require/include path 28/18928/2
Felix Kopp [Thu, 14 Mar 2013 22:49:47 +0000 (23:49 +0100)]
[TASK] thumbs.php ease require/include path

Currently typo3/thumbs.php requires t3lib/thumbs.php and
t3lib/thumbs.php requires EXT:backend/Classes/View/ThumbnailView.php.

Include ThumbnailView directly in typo3/thumbs.php.
But keeps deprecation in place and other files untouched.

Change-Id: I1c464e683cb08f674ac47cb87f296b185fd35db5
Fixes: #46308
Releases: 6.1
Reviewed-on: https://review.typo3.org/18928
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Update sys_refindex to reflect typolink to file in RTE content 42/10942/7
Benjamin Mack [Tue, 9 Oct 2012 21:51:15 +0000 (23:51 +0200)]
[BUGFIX] Update sys_refindex to reflect typolink to file in RTE content

Problem: sys_refindex should be updated when a link to a file is
inserted in or removed from RTE content.
Solution: Add missing softrefs.

Change-Id: Ice1f46a591bd0129aef043b0b18b21be0469157b
Releases: 6.0
Resolves: #36792
Reviewed-on: https://review.typo3.org/10942
Reviewed-by: Steffen Ritter
Reviewed-by: Helmut Hummel
Reviewed-by: Mattias Nilsson
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[TASK] Remove Flash Uploader Functionality 46/19146/2
Benjamin Mack [Thu, 21 Mar 2013 17:52:28 +0000 (18:52 +0100)]
[TASK] Remove Flash Uploader Functionality

As there is a better HTML5 alternative in the
Backend since TYPO3 CMS 6.0, the
flash uploader has only little benefits anymore.

The patch removes all occurrences (except labels)
that are related to swfupload, as well as swfupload
itself.

Releases: 6.1
Resolves: #46510
Change-Id: I76ce06900b74de2e3cdc79caf9984e050bf40990
Reviewed-on: https://review.typo3.org/19146
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Sorting files in filelist is case sentive 73/19173/2
Nicole Cordes [Fri, 22 Mar 2013 11:55:45 +0000 (12:55 +0100)]
[BUGFIX] Sorting files in filelist is case sentive

The sorting for files in the filelist is case sensitive while the sorting
for folders is not. The sorting should be adjusted to be identical for
files and folders.

Change-Id: I2aee28f42beb1f9b4b1eb969ee5503fd9bea0e23
Fixes: #46541
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19173
Reviewed-by: Michael Staatz
Tested-by: Michael Staatz
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[TASK] Remove unneded text in Install-Tool 76/19176/2
Georg Ringer [Fri, 22 Mar 2013 12:54:16 +0000 (13:54 +0100)]
[TASK] Remove unneded text in Install-Tool

Some text in the install tool should be removed

- "Installing TYPO3 as always been a hot topic on the mailinglist"...
  Nowadays it is quite easy to install TYPO3
- The text why the InstallTool should be standalone and no BE module is
  not quite true as it is also a BE module and rest of the text is such
  technical and got no information benefit for anybody

Change-Id: I73c312e6a426ef9fd3754564fa8fce707116a242
Resolves: #46547
Releases: 6.1
Reviewed-on: https://review.typo3.org/19176
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years agoImprove rendering of "System environment check" 75/19175/2
Georg Ringer [Fri, 22 Mar 2013 12:44:18 +0000 (13:44 +0100)]
Improve rendering of "System environment check"

The title should be wrapped in a <strong>-Tag

Change-Id: Idf76d37edbfaa437d1940d1e0db476fa41415bca
Resolves: #46546
Releases: 6.1
Reviewed-on: https://review.typo3.org/19175
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Small cleanup in Boostrap.php 38/19038/2
Michael Stucki [Tue, 19 Mar 2013 12:54:00 +0000 (13:54 +0100)]
[TASK] Small cleanup in Boostrap.php

Code cleanup prior to #41596
Releases: 6.1, 6.0

Change-Id: I87294a52e282175b345ee8b1a735604f6993e0f3
Reviewed-on: https://review.typo3.org/19038
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[TASK] Remove deprecated code 76/17676/5
Benjamin Mack [Sat, 9 Feb 2013 06:00:32 +0000 (07:00 +0100)]
[TASK] Remove deprecated code

Remove deprecated code that is marked to be deleted in 6.1.

Change-Id: I4a8f512c039e537733228840f1fb8a592f8331a3
Resolves: #44763
Releases: 6.1
Reviewed-on: https://review.typo3.org/17676
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove deprecated code 33/12933/6
Markus Klein [Tue, 25 Sep 2012 07:27:39 +0000 (09:27 +0200)]
[TASK] Remove deprecated code

Remove all code that was marked for removal in version 6.0.

Change-Id: I98668661a4b4e3a4c2f3a035bfe4ddbaf2ef61f5
Resolves: #39137
Related: #37081
Releases: 6.1
Reviewed-on: https://review.typo3.org/12933
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 56/19156/2
Christian Kuhn [Thu, 21 Mar 2013 21:17:03 +0000 (22:17 +0100)]
[TASK] Raise submodule pointer

Change-Id: Iee8e10b5394957c5df9ff543ced4365be42e5716
Reviewed-on: https://review.typo3.org/19156
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove deleted file reference from legacy index 53/19153/3
Christian Kuhn [Thu, 21 Mar 2013 21:05:52 +0000 (22:05 +0100)]
[TASK] Remove deleted file reference from legacy index

Change-Id: I0cf581fe1e96cae0627855df64a136cb71d06238
Related: #46516
Reviewed-on: https://review.typo3.org/19153
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 52/19152/2
Christian Kuhn [Thu, 21 Mar 2013 21:03:58 +0000 (22:03 +0100)]
[TASK] Raise submodule pointer

Change-Id: I7600f2b1c37d0cd8160d6f93e036a05bb520b557
Reviewed-on: https://review.typo3.org/19152
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 50/19150/2
Christian Kuhn [Thu, 21 Mar 2013 20:24:02 +0000 (21:24 +0100)]
[TASK] Raise submodule pointer

Change-Id: If7e6d8aefe8673dc7b40058eee691b54974e3e97
Reviewed-on: https://review.typo3.org/19150
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 48/19148/2
Christian Kuhn [Thu, 21 Mar 2013 18:41:19 +0000 (19:41 +0100)]
[TASK] Raise submodule pointer

Change-Id: I6acbc8e89a12a963a4e84b3ad5b97fd96fc63431
Reviewed-on: https://review.typo3.org/19148
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[!!!][-FEATURE] Remove ext:statictemplates 13/19113/3
Christian Kuhn [Wed, 20 Mar 2013 18:47:21 +0000 (19:47 +0100)]
[!!!][-FEATURE] Remove ext:statictemplates

The patch removes the hopelessly outdated extension statictemplates.

Change-Id: Ic19d8b8d6cc99eead98a7a27d91e5a9d42676254
Resolves: #46469
Related: #46470
Related: #46358
Releases: 6.1
Reviewed-on: https://review.typo3.org/19113
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 19/19119/2
Christian Kuhn [Wed, 20 Mar 2013 20:37:30 +0000 (21:37 +0100)]
[TASK] Raise submodule pointer

Change-Id: I03299ac7408140a6a0a3652bef62187b9073c317
Reviewed-on: https://review.typo3.org/19119
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix .zip-export on windows and add unit test 61/18961/5
Jost Baron [Fri, 15 Mar 2013 20:06:21 +0000 (21:06 +0100)]
[BUGFIX] Fix .zip-export on windows and add unit test

On Windows servers (xampp), the .zip-export of extensions did not
work because \ZipArchive::addFile can't add directories on Windows.

Added a unit test for the export function.

Fixes: #45140
Releases: 6.0, 6.1
Change-Id: If248bf031d3d7b621971de609b86eedc0ee05a64
Reviewed-on: https://review.typo3.org/18961
Reviewed-by: Jost Baron
Tested-by: Jost Baron
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] ExtDirectApi uses an undefined variable 60/18760/2
Dmitry Dulepov [Wed, 6 Mar 2013 18:24:44 +0000 (22:24 +0400)]
[BUGFIX] ExtDirectApi uses an undefined variable

Method generateAPI() sets $className inside the condition but later uses
it without checking if it is empty or not. The result is a PHP warning
"Invalid argument supplied for foreach()".

Change-Id: I7fd2bf88374661a8b54023aee9fe2af5619471b0
Resolves: #46075
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18760
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX][EM] Get extension show spinner icon in upper right table 97/19097/4
Christian Kuhn [Wed, 20 Mar 2013 15:45:01 +0000 (16:45 +0100)]
[BUGFIX][EM] Get extension show spinner icon in upper right table

The load mask logic in extension manager stumbles upon the fluid change
of issue #40826 and now always shows a spinner in the "Get extensions"
tab.
This is solved with a small cleanup of the classes and markup added to
this HTML section which anyway are obsolete since #46029.

Change-Id: I0a2e5b26c890ba7ba93bf4abb1f6485084ebf808
Resolves: #46455
Related: #46029
Related: #40826
Releases: 6.1
Reviewed-on: https://review.typo3.org/19097
Reviewed-by: Jost Baron
Tested-by: Jost Baron
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 14/19114/2
Christian Kuhn [Wed, 20 Mar 2013 19:18:07 +0000 (20:18 +0100)]
[TASK] Raise submodule pointer

Change-Id: I9676dd5027e3788ae7e1e224316c94e530857716
Reviewed-on: https://review.typo3.org/19114
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] NEWS.txt entry about removed f:form inline styling 78/19078/3
Christian Kuhn [Wed, 20 Mar 2013 11:17:25 +0000 (12:17 +0100)]
[TASK] NEWS.txt entry about removed f:form inline styling

Change-Id: Ia646ea2b54b8d7803309e0722662085eb8fe40c3
Resolves: #46451
Releases: 6.1
Reviewed-on: https://review.typo3.org/19078
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Separate ext:statictemplates code from core 74/18974/5
Christian Kuhn [Sat, 16 Mar 2013 10:41:01 +0000 (11:41 +0100)]
[TASK] Separate ext:statictemplates code from core

The three menu types GMENU_LAYERS GMENU_FOLDOUT and TMENU_LAYERS use
javascript files of statictemplates and belongs to the extension.
Using the new factory of issue #46292, those three menu objects are
now transferred to statictemplates extension.

For upgrade to TYPO3 CMS 4.5 an ugrade wizard was created to install
statictemplates system extension if the database tables was in use.
Everything before 4.5 is out of support for a long time, so we can
expect the extension to be already loaded if it is used. The old
upgrade wizard is removed now.

Some statictemplates specific code in ext:tstemplate is substituted
with hooks, used by statictemplates.

Change-Id: Id14dca12f09051c3003fedaeb971fef457f7a17e
Resolves: #46358
Related: #46292
Releases: 6.1
Reviewed-on: https://review.typo3.org/18974
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Usage of deprecated returnFilemounts() 13/18513/2
Markus Klein [Wed, 27 Feb 2013 12:06:46 +0000 (13:06 +0100)]
[BUGFIX] Usage of deprecated returnFilemounts()

Some places in Core still use $GLOBALS['BE_USER']->returnFilemounts()

Resolves: #36405
Releases: 6.0, 6.1
Change-Id: I6252ed1191811a9813e590aa570741d31522895c
Reviewed-on: https://review.typo3.org/18513
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Reviewed-by: Sebastian Fischer
Reviewed-by: Christian Weiske
Tested-by: Christian Weiske
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] BELog module error: "vsprintf(): Too few arguments" 62/18762/2
Dmitry Dulepov [Wed, 6 Mar 2013 19:05:01 +0000 (23:05 +0400)]
[BUGFIX] BELog module error: "vsprintf(): Too few arguments"

AbstractExceptionHandler contains a function named writeLog. That
function adds an entry to the system log. System log expects not
just a string but a string format with % characters. Callers of
this methods may supply a URL ("Request URL:" in the log message)
that contains % characters. vsprintf() in the BELog view helper
will complain about missing arguments to such string.

Change-Id: Ie080c0af1d93c28f8521b670a8ae8e63f8c4cfda
Resolves: #46077
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18762
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Hardcoded CLI arguments from $_SERVER vars 29/18929/5
Benjamin Mack [Thu, 14 Mar 2013 23:15:48 +0000 (00:15 +0100)]
[FEATURE] Hardcoded CLI arguments from $_SERVER vars

Currently there is no way to overwrite the used CLI
arguments from the class who extends from the
\TYPO3\CMS\Core\Controller\CommandLineController

This occurs because the
\TYPO3\CMS\Core\Controller\CommandLineController connects
hardcoded to the $_SERVER['argv'] array. This is in
some situations very unhandy - e.g. trigger lowlevel
cleaner during a scheduler task.

Kudos to AOE, Michael Klapper and Tolleiv Nietsch!

Resolves: #21389
Releases: 6.1
Change-Id: I42c14d37e8e7f977b3c7e73b0009e6c8495c3258
Reviewed-on: https://review.typo3.org/18929
Reviewed-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Deprecate class FE_loadDBGroup 49/18549/5
Thorsten Kahler [Fri, 1 Mar 2013 11:17:04 +0000 (12:17 +0100)]
[TASK] Deprecate class FE_loadDBGroup

Class FE_loadDBGroup's only purpose is to set an attribute of its parent
class. This should better be done when instantiating an object.

This patch additionaly renames the mentioned attribute to make its
purpose clearer. A setter method for that attribute is added and a
compatibility layer as well.

Change-Id: I44b3e331dcb86d75f266d9e36cf0829998f1fb5b
Resolves: #45937
Related: #23977
Releases: 6.1
Reviewed-on: https://review.typo3.org/18549
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Update copyright year to 2013 84/18984/4
Wouter Wolters [Sat, 16 Mar 2013 19:43:11 +0000 (20:43 +0100)]
[TASK] Update copyright year to 2013

In this patch are also some fixes for files containing
a interface. Due the namespace change all interfaces
have the curly bracket not on the same line as the
interface name.

Change-Id: I64ba45de73693452d681ce7f018965968b11d2af
Resolves: #46370
Releases: 6.1
Reviewed-on: https://review.typo3.org/18984
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Use minimised version of jquery.dataTables-1.9.4 52/16652/3
Stefan Neufeind [Wed, 21 Nov 2012 00:29:56 +0000 (01:29 +0100)]
[TASK] Use minimised version of jquery.dataTables-1.9.4

Change-Id: Ic8f2f046b6df70c885158f4c1f08cbad1c943cf1
Resolves: #43186
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/16652
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 18/19018/2
Christian Kuhn [Mon, 18 Mar 2013 20:45:07 +0000 (21:45 +0100)]
[TASK] Raise submodule pointer

Change-Id: I8b49be31e8f22a661dbb9c38f2e6a11d370541d3
Reviewed-on: https://review.typo3.org/19018
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Declare non static methods as static 01/18301/4
Georg Ringer [Fri, 15 Feb 2013 13:32:00 +0000 (14:32 +0100)]
[TASK] Declare non static methods as static

Change-Id: Ifa199fd6b500f4f161b49a406aa2678abdaa785b
Resolves: #45509
Releases: 6.1
Reviewed-on: https://review.typo3.org/18301
Reviewed-by: Dmitry Dulepov
Reviewed-by: Oliver Klee
Reviewed-by: Simon Schaufelberger
Tested-by: Simon Schaufelberger
Reviewed-by: Soren Malling
Tested-by: Soren Malling
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Media element not working with FAL 28/18228/3
Andreas Schütte [Wed, 13 Feb 2013 08:45:44 +0000 (09:45 +0100)]
[BUGFIX] Media element not working with FAL

With FAL the path to a file is no longer used,
instead the UID to the specific file is used,
prefixed with "file:"

This patch just adds a check if the filename
starts with "file:" and if so load the specific FileObject
to retrive the url. This check is done before all others,
because FAL should be the default file handler.
Additionally use explode() first to get the filename
if an editor adds (non used)
link parameters: file:740 _blank media-title

This fixes also the problem with audio files mentioned in #39416,
using the same patch.

Resolves: #41280
Related: #39416
Releases: 6.0, 6.1
Change-Id: Ibec6cefda54b6e136c0d5ae43c67ef2eea3b1bb8
Reviewed-on: https://review.typo3.org/18228
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Marco Huber
Tested-by: Marco Huber
Reviewed-by: Stefan Neufeind
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix PHP warning in BackendUtility::lockRecords 78/18978/5
Helmut Hummel [Sat, 16 Mar 2013 15:29:20 +0000 (16:29 +0100)]
[BUGFIX] Fix PHP warning in BackendUtility::lockRecords

This methods triggers a warning "Illegal String offset"
with PHP 5.4, because $GLOBALS['BE_USER']->user['uid'] is accessed
even if a user is not logged in.

Additionally a delete query is executed in this case which
does not make sense at all.

Properly check if a user is logged in before executing any
functionality in this method.

Fixes: #46361
Releases: 4.5, 4.7, 6.0, 6.1
Change-Id: I370e0a8610a55b3d684bef95d7c6905eaaaacbab
Reviewed-on: https://review.typo3.org/18978
Reviewed-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 91/18991/2
Christian Kuhn [Sun, 17 Mar 2013 21:07:51 +0000 (22:07 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ib66dcd1ca3ea25d55e9ff8a8dee281aa99687489
Reviewed-on: https://review.typo3.org/18991
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove old JS in page header 13/18313/4
Georg Ringer [Sat, 16 Feb 2013 12:05:09 +0000 (13:05 +0100)]
[TASK] Remove old JS in page header

Change-Id: I509ffe2cc3dc37cc08de3633c79127c1f50145a7
Resolves: #45528
Releases: 6.1
Reviewed-on: https://review.typo3.org/18313
Reviewed-by: Oliver Klee
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Markus Klein
Reviewed-by: Henrik Ziegenhain
Reviewed-by: Thomas Loeffler
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[FEATURE] Add stdWrap to config.pageTitleSeperator 23/18123/3
Georg Ringer [Fri, 8 Feb 2013 15:55:53 +0000 (16:55 +0100)]
[FEATURE] Add stdWrap to config.pageTitleSeperator

Add stdWrap to config.pageTitleSeperator

Change-Id: I88c2141167414b184f158d09f40df3aa36390b4a
Resolves: #35223
Releases: 6.1
Reviewed-on: https://review.typo3.org/18123
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[TASK] Use central jQuery 50/16650/2
Stefan Neufeind [Wed, 21 Nov 2012 00:17:46 +0000 (01:17 +0100)]
[TASK] Use central jQuery

Change-Id: I80ebeaff81fbcb8d4d479d977f7aa23390692d28
Resolves: #43184
Releases: 6.0
Reviewed-on: https://review.typo3.org/16650
Reviewed-by: Oliver Klee
Reviewed-by: Mattias Nilsson
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Sebastian Michaelsen
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Marcus Schwemer
Tested-by: Marcus Schwemer
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] respect rootLevel=-1 in exec_foreign_table_where_query 17/18417/3
Stefan Froemken [Thu, 21 Feb 2013 12:34:22 +0000 (13:34 +0100)]
[BUGFIX] respect rootLevel=-1 in exec_foreign_table_where_query

exec_foreign_table_where_query does not interpret the
rootLevel directive correctly.

Resolves: #45703
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: I2a4dd0335ac5373562f287427d5592cfd406e2f9
Reviewed-on: https://review.typo3.org/18417
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] HMENU rendering uses old tslib_ class names 13/18913/7
Christian Kuhn [Thu, 14 Mar 2013 16:39:14 +0000 (17:39 +0100)]
[BUGFIX] HMENU rendering uses old tslib_ class names

The menu rendering in frontend still instantiates menu classes with
its old tslib_ prefixed names. This is unflexible and a potential
performance issue.

The patch introduces a simple factory instead with a mapping for
existing TypoScript menu types to the implementing classes.
The current variable $menuclasses is obsolete.
Additionally, the naming of three existing classes is adapted to
the correct class names to be in sync with the others.

A method in the factory to register additional menu types will
be added with a second patch.

Change-Id: I3d65258ffe4d30a918705b23349d3facb563c80e
Resolves: #46292
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18913
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Make sure XML parser is created everytime when needed 66/18966/2
Christian Kuhn [Sat, 16 Mar 2013 00:25:29 +0000 (01:25 +0100)]
[BUGFIX] Make sure XML parser is created everytime when needed

Currently, EM's MirrorXmlPushParser, which is based on ext/xml,
is not properly working. The constructor creates the parser and
within parseXML() method the parser resource is freed.
However, when clicking on retrieve/update button method
parseXML() is invoked multiple times which makes subsequent calls
fail.

Creating the parser is now done within parseXML() method.

Change-Id: I7c6c15f65d08fb0264d7d66cc584cbe7ff423b45
Resolves: #25292
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/18966
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 63/18963/2
Christian Kuhn [Fri, 15 Mar 2013 22:59:46 +0000 (23:59 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ifc59f15abf43026007737c1051bb0f79bfacc55d
Reviewed-on: https://review.typo3.org/18963
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Importing extensions from repository fails 05/18805/8
Christian Kuhn [Fri, 15 Mar 2013 21:54:00 +0000 (22:54 +0100)]
[BUGFIX] Importing extensions from repository fails

If importing the extension list from TER, an incoming XML extension
row has a field 'category' that contains either a string like
'plugin' or a category number.
The list is persisted to the 'extension' repository. In the
database, the category is stored as integer. There is a mapping
function in the extension model to get the integer category
index from given XML input. The method is faulty and returns
strings instead of an index if the given category is a string
itself. This results in database errors during insert.

The patch fixes the method, renames it along the way and adds
unit tests to document desired behavior.

Change-Id: I601b84d0829f3d20a4cdd25a3f7f37e8128dbce1
Fixes: #46115
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18805
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years agoRevert "[BUGFIX] Fix wrong column title in web>list for field colpos" 41/18941/4
Christian Kuhn [Fri, 15 Mar 2013 15:02:03 +0000 (16:02 +0100)]
Revert "[BUGFIX] Fix wrong column title in web>list for field colpos"

This reverts commit 50eba0a8eee20f9ecc2b2c0b5856677d256e3cfd

The patch triggers warnings and errors in multiple extensions. Digging
into the details shows the implementation is neither finished nor
stable. See issue #25113 for a detailed analysis.

Change-Id: I739c72887617b026d80063fe1fab57f95124d508
Related: #25113
Fixes: #45833
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/18941
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGIFX] Extra output block backend thumbnails 20/18220/2
Francois Suter [Tue, 12 Feb 2013 16:09:14 +0000 (17:09 +0100)]
[BUGIFX] Extra output block backend thumbnails

If some inclusion causes output when viewing image thumbnails
in the backend, the output will be broken. Adding a call to
ob_clean() ensures that this does not happen.

Resolves: #31953
Releases: 6.1, 6.0
Change-Id: I1d33bc3c5e8bbd1851f087c76564f8924f8dfe26
Reviewed-on: https://review.typo3.org/18220
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Raise submodule pointer 31/18931/2
Christian Kuhn [Fri, 15 Mar 2013 00:37:25 +0000 (01:37 +0100)]
[TASK] Raise submodule pointer

Change-Id: I5eff310e62fc43d9d2f9b52631da8ce3b085d474
Reviewed-on: https://review.typo3.org/18931
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup form 09/18009/9
Wouter Wolters [Mon, 4 Feb 2013 21:31:07 +0000 (22:31 +0100)]
[TASK] Cleanup form

* Fix old classnames in comments
* Add missing function documentation
* Add \ to DOM* classes

Change-Id: Iec474715af103e0d158e5539b46a31c81ba678ac
Resolves: #45149
Releases: 6.1
Reviewed-on: https://review.typo3.org/18009
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 27/18927/2
Christian Kuhn [Thu, 14 Mar 2013 21:03:14 +0000 (22:03 +0100)]
[TASK] Raise submodule pointer

Change-Id: I1c7c78225043cd5b0edd5a1ee0ce3ea236ed5c0f
Reviewed-on: https://review.typo3.org/18927
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup func and func_wizards 25/18025/5
Wouter Wolters [Tue, 5 Feb 2013 18:34:05 +0000 (19:34 +0100)]
[TASK] Cleanup func and func_wizards

Change-Id: Ia23ed69335b6728c198b84b830104f11994e4663
Resolves: #45180
Releases: 6.1
Reviewed-on: https://review.typo3.org/18025
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Missing labels in backend modules 25/18925/4
Christian Kuhn [Thu, 14 Mar 2013 20:11:14 +0000 (21:11 +0100)]
[BUGFIX] Missing labels in backend modules

There seems to be some magic in SOBE that automatically includes
language files if they are located parallel to the module that is
loaded. The task from #46143 and #46144 registered new wizard classes
at a different location, so the magic doesn't hit anymore. As a
result, no labels are show in above extensions in the backend.
Fix is to include the locallang file in main() of the modules. The
direct access to $LANG is removed along the way by accessing
$GLOBALS['LANG'] directly.

Change-Id: Iecddb181141f5317b87e405ada925c61cfd9261c
Fixes: #46296
Related: #46143
Related: #46144
Releases: 6.1
Reviewed-on: https://review.typo3.org/18925
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] NEWS.txt entry about enabled new extbase property mapper 23/18923/3
Christian Kuhn [Thu, 14 Mar 2013 19:25:17 +0000 (20:25 +0100)]
[TASK] NEWS.txt entry about enabled new extbase property mapper

Change-Id: I13442a04ae0e0dc2c4907b72b9b5381177870b4e
Reviewed-on: https://review.typo3.org/18923
Reviewed-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] LanguageController has "mixed" type annotations 75/17975/4
Wouter Wolters [Sun, 3 Feb 2013 13:11:07 +0000 (14:11 +0100)]
[BUGFIX] LanguageController has "mixed" type annotations

The LanguageController of the lang sysext throws
exceptions if the rewritten property mapper is enabled.
The type annotation 'mixed' is unknown. The patch fixed
the annotation to the correct string value to make the
property mapper happy.

Change-Id: I57ebd268d2fe82c095ccf20b581e721703fb2868
Fixes: #44672
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/17975
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Remove rewrittenPropertyMapper setting in sysext 19/18919/2
Anja Leichsenring [Thu, 14 Mar 2013 18:44:57 +0000 (19:44 +0100)]
[TASK] Remove rewrittenPropertyMapper setting in sysext

After enabling the rewrittenPropertyMapper per default, the
explicit enabling in sysexts is no longer needed.

Resolves: #46294
Releases: 6.1
Change-Id: I7f5760ae85999495606a3d56098cf7b38682b452
Reviewed-on: https://review.typo3.org/18919
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 18/18918/2
Christian Kuhn [Thu, 14 Mar 2013 18:31:39 +0000 (19:31 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ie182842c25a5dcb49989cd8478497c63a1fe1938
Reviewed-on: https://review.typo3.org/18918
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Integrate latest version of jquery (1.9.1) 09/18909/2
Benjamin Mack [Thu, 14 Mar 2013 15:53:11 +0000 (16:53 +0100)]
[TASK] Integrate latest version of jquery (1.9.1)

With the new jQuery API introduced in TYPO3 CMS 6.0,
it is possible to ship and include multiple jQuery versions.

For 6.1 the latest version of jQuery should be used,
so the latest release is added to the local jQuery repository.

Releases: 6.1
Resolves: #46286
Change-Id: I5745df65b463db4973df346afe963a35d68d5bab
Reviewed-on: https://review.typo3.org/18909
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Release typo3/ajax.php from early t3lib_div usage 03/18903/2
Christian Kuhn [Fri, 15 Feb 2013 21:59:25 +0000 (22:59 +0100)]
[TASK] Release typo3/ajax.php from early t3lib_div usage

ajax.php entry script requires t3lib_div very early to use a single
method from it. This is ugly, so the needed code is now implemented
in ajax.php directly, removing the requirement to include t3lib_div
so early.

Change-Id: I974c39c185872ab68bdc7732434c4bc52d77f75f
Resolves: #46269
Release: 6.1
Reviewed-on: https://review.typo3.org/18903
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Skip unreliable APC test on PHP versions below 5.3.4 01/18901/2
Christian Kuhn [Thu, 14 Feb 2013 00:13:43 +0000 (01:13 +0100)]
[BUGFIX] Skip unreliable APC test on PHP versions below 5.3.4

APC has some slam protection that tries to prevent hammering of cache
entries. This can be disabled, but the option does not work at least
in native PHP 5.3.3 on debian squeeze. While it is no problem with
higher PHP version like the current one on travis-ci.org,
some tests are now just skipped on PHP environments knows for issues.

Change-Id: Ibbef201805b58041bb0b3e8aa16f0c1a2e366020
Resolves: #46267
Release: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18901
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Add .htaccess file to ext:extensionmanager/Resources/Private 97/18897/2
Christian Kuhn [Wed, 13 Feb 2013 23:59:20 +0000 (00:59 +0100)]
[BUGFIX] Add .htaccess file to ext:extensionmanager/Resources/Private

Change-Id: I7ada1e5e40067cf1faed8b2b5d338a690e921cad
Fixes: #46264
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18897
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Relocate cache backend sql resource files 95/18895/2
Christian Kuhn [Wed, 13 Feb 2013 23:50:12 +0000 (00:50 +0100)]
[TASK] Relocate cache backend sql resource files

Some cache backends have specific sql resource files located at
t3lib/cache/backend/resources.
After namespace switch, the class files are located at ext:core.
According to the extbase scheme, the resource files are now moved
to ext:core/Resources/Private/Sql/Cache/Backend and renamed.

Change-Id: Ib693e0dfed8636b9898ef9bbff73dab21df5c2b0
Resolves: #46263
Releases: 6.1
Reviewed-on: https://review.typo3.org/18895
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Move CF last_synched_revision file to ext:core/Classes/Cache 94/18894/2
Christian Kuhn [Wed, 13 Feb 2013 23:18:30 +0000 (00:18 +0100)]
[TASK] Move CF last_synched_revision file to ext:core/Classes/Cache

Change-Id: I32887386c6a5b4162a12b419c5f34e1ddc061a35
Resolves: #46262
Releases: 6.1
Reviewed-on: https://review.typo3.org/18894
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Toolbar items with separator: fix white-space 58/18458/2
Felix Kopp [Sun, 24 Feb 2013 16:14:05 +0000 (17:14 +0100)]
[BUGFIX] Toolbar items with separator: fix white-space

The toolbar function could output erroneous html is case
additional toolbar items do not bring additionalAttributes.

Additional attributes are defined based on ToolbarItemHookInterface.
But additionalAttributes can be an empty string:

Fix output <liclass="separator"> to <li class="separator">
by adding an extra white-space.

Change-Id: I09338d17848c8fc74b25e7c532d6ee329956321b
Fixes: #45795
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18458
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup sysext "wizard_crpages" and "wizard_sortpages" 20/18820/2
Wouter Wolters [Mon, 18 Feb 2013 20:47:09 +0000 (21:47 +0100)]
[TASK] Cleanup sysext "wizard_crpages" and "wizard_sortpages"

This is a non-functional change that reformats the code, removes
unnecessary empty lines and fixes reference to old classnames.

Furthermore change "0" to FALSE where a boolean is needed.

Change-Id: Ida0c80ce0c54c6054e248b29c716b740f5e65194
Resolves: #46143
Releases: 6.1
Reviewed-on: https://review.typo3.org/18820
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup sysext "tstemplate" and module functions 21/18821/2
Wouter Wolters [Tue, 19 Feb 2013 18:24:34 +0000 (19:24 +0100)]
[TASK] Cleanup sysext "tstemplate" and module functions

Change-Id: Icd9ad7fadbd6910eba87a77908e15568be800dc2
Resolves: #46144
Releases: 6.1
Reviewed-on: https://review.typo3.org/18821
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 89/18889/2
Christian Kuhn [Wed, 13 Mar 2013 22:50:55 +0000 (23:50 +0100)]
[TASK] Raise submodule pointer

Change-Id: I04d40a3796937182603c7b85e16227f18f51c002
Reviewed-on: https://review.typo3.org/18889
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Central system environment check 70/18870/11
Christian Kuhn [Mon, 25 Feb 2013 20:50:02 +0000 (21:50 +0100)]
[FEATURE] Central system environment check

This patch adds a new structure to the install tool to centralize
all system and especially PHP related system checks cluttered in
various modules and parts of the core at the moment.

The idea is to have a basic, standalone script to test for all
requirements TYPO3 CMS has in order to run smoothly. The script does
not use any TYPO3 core code and has no further dependencies. With
a later patch, the check will be integrated as the very first
step during install, to give a good indicator if the final
installed system will work well or if any system constraints are
not met.

Currently, the script is included as a new section in the install
tool, called "System environment", where all checks are performed
and each gives a status back. This will already help to support
questions on mailing lists and should be the first step every user
is guided to: "Do you have warnings or errors in the system
environment?". The install tool implementation should also help
already if moving an instance to a different server.

Furthermore, there is a simple integration in the reports module
that points to the install tool if issues are found.

The class structure is as simple as possible, it is very easy to
adapt single checks later on, the API is a single getStatus() method
that returns all check object of the specific tests. Due to the
nature of the script and the later usage in the installation
process, things like localization and so on are not done and
should also not be implemented later on.

Most current check code is fetched from existing install tool,
reports module and bootstrap code. This also make the main
Installer.php class of the install tool already a bit better
maintainable since 600 lines of code are removed from it.

Change-Id: I64387ca9aaa4b429ee4a909cdab4386180af0d45
Resolves: #46219
Releases: 6.1
Reviewed-on: https://review.typo3.org/18870
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Translation of a form makes the form wizard unusable 96/12996/9
Mario Rimann [Tue, 15 Jan 2013 09:20:27 +0000 (10:20 +0100)]
[BUGFIX] Translation of a form makes the form wizard unusable

As soon as the form-configuration for the form wizard gets
loaded, the leading "[Translate to XYZ:] " is stripped off to get the
wizard working (with the leading text, the form config could not
be serialized as needed and the wizard didn't show a single field).

The stripping is only done on localized records.

Change-Id: I0cab1d371abf5ae01b524c39acedcd1a3a5db9c4
Fixes: #39127
Releases: 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/12996
Tested-by: Mario Rimann
Reviewed-by: Stefan Galinski
Tested-by: Stefan Galinski
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Improve FAL performance 16/18316/4
Dmitry Dulepov [Sat, 16 Feb 2013 17:57:33 +0000 (19:57 +0200)]
[TASK] Improve FAL performance

FAL performance in BE and FE can be improved by using certain database
indexes. One set of indexes improves performance in BE by adding a
"deleted" column, which is used by List module. Without this column
in the 'pid' index, List module will do a full scan, which is much
slower. Another set of indexes improves performance when getting files
from storage.

Change-Id: I1f8577453ed917db95d680ca74fefc4691ba53b0
Resolves: #45532
Releases: 6.1
Reviewed-on: https://review.typo3.org/18316
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Improve rootline cache handling 14/18314/2
Georg Ringer [Sat, 16 Feb 2013 13:18:43 +0000 (14:18 +0100)]
[TASK] Improve rootline cache handling

The method get() checks if there is an entry by using
has() and does then an additional get(). This can
be simplified which saves a query for every hit

Change-Id: I0ebfd8c7622a5e673d3f34aa685f18a9878116ef
Resolves: #45530
Releases: 6.1
Reviewed-on: https://review.typo3.org/18314
Reviewed-by: Oliver Hader
Reviewed-by: Philipp Gampe
Reviewed-by: Steffen Ritter
Reviewed-by: Oliver Klee
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Exception when deleted file is in clipboard 91/18191/2
Andreas Wolf [Sun, 10 Feb 2013 17:10:54 +0000 (18:10 +0100)]
[BUGFIX] Exception when deleted file is in clipboard

When a file is deleted while it is part of a clipboard, an exception is
thrown when the clipboard is reconstituted. This exception has to be
catched, otherwise the file module will be unusable.

Change-Id: I8849644ffa7b78559c1797d85ce3cc6e01d03a74
Resolves: #43906
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18191
Reviewed-by: Thomas Scheibitz
Tested-by: Thomas Scheibitz
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] inject* methods in FAL inhibit use of Extbase object manager 59/18159/3
Andreas Wolf [Sat, 9 Feb 2013 14:49:32 +0000 (15:49 +0100)]
[BUGFIX] inject* methods in FAL inhibit use of Extbase object manager

The ResourceStorage class of FAL has two inject* methods which are seen
as dependency injectors by the Extbase object manager. Thus an exception
is thrown when a ResourceStorage object is created via Extbase.

This commit changes the two method's names and adjust all usages within
the core. These methods are internal and I don't expect them to be used
anywhere else, so we don't need a backwards compatibility layer.

Change-Id: I4b73445708cf8041b505b5ea8923dc595ddaadb0
Resolves: #45319
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18159
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Add context-menu for template-icon in the "Template"-view 46/18846/2
Stefan Neufeind [Mon, 11 Mar 2013 22:29:06 +0000 (23:29 +0100)]
[FEATURE] Add context-menu for template-icon in the "Template"-view

Allows to easily copy, delete, (de)activate etc. the template.

Resolves: #46058
Releases: 6.1
Change-Id: I2dfc96da13fdec9807a05ef3764d40db76aa1c4e
Reviewed-on: https://review.typo3.org/18846
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Set TYPO3 version to 6.1-dev 66/18866/2
TYPO3 Release Team [Tue, 12 Mar 2013 16:07:31 +0000 (17:07 +0100)]
[TASK] Set TYPO3 version to 6.1-dev

Change-Id: Ic7f565cb3188194e47a13b284a9d5f79e90d8616
Reviewed-on: https://review.typo3.org/18866
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.1.0alpha1 65/18865/2
TYPO3 Release Team [Tue, 12 Mar 2013 16:07:15 +0000 (17:07 +0100)]
[RELEASE] Release of TYPO3 6.1.0alpha1

Change-Id: If1bbb1fab9f79ddfab6c848c6549d9244cfc6f98
Reviewed-on: https://review.typo3.org/18865
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Prevent encoding of HTML entities in backend previews 94/10494/8
Helmut Hummel [Tue, 27 Nov 2012 00:38:41 +0000 (01:38 +0100)]
[BUGFIX] Prevent encoding of HTML entities in backend previews

HTML entities that are used in HTML enabled fields should
be preserved for the preview instead of being encoded (twice).

Change-Id: I4f7b0b7214906f404a1cd1efba009a8cf577a18b
Fixes: #36067
Releases: 6.1
Reviewed-on: https://review.typo3.org/10494
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Cleanup filelist 05/18005/2
Wouter Wolters [Mon, 4 Feb 2013 17:44:54 +0000 (18:44 +0100)]
[TASK] Cleanup filelist

Change-Id: If107bd20db15d1881c12097adecd342b8e1979aa
Resolves: #45143
Releases: 6.1
Reviewed-on: https://review.typo3.org/18005
Reviewed-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Oliver Klee
Reviewed-by: Felix Kopp
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Cleanup sysext "taskcenter" and "tsconfig_help" 22/18822/3
Wouter Wolters [Tue, 19 Feb 2013 19:24:38 +0000 (20:24 +0100)]
[TASK] Cleanup sysext "taskcenter" and "tsconfig_help"

Change-Id: I2658e5d0a7ae979f93b60713294adcbe8e41db09
Resolves: #46145
Releases: 6.1
Reviewed-on: https://review.typo3.org/18822
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Show better error messages on failed TER update 88/18688/4
Jost Baron [Mon, 4 Mar 2013 21:38:01 +0000 (22:38 +0100)]
[TASK] Show better error messages on failed TER update

This patch shows error messages in a flash message if the ajax request
for a TER-update fails, and resets the extension manager into a sane
state, instead of showing an ever spinning wheel.

Resolves: #46030
Releases: 6.1
Change-Id: I1cc67460a11feb206c53c12a38ad0f6db482e04a
Reviewed-on: https://review.typo3.org/18688
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] sys_note: Display/functionality for hover/context menu 11/16911/8
Stefan Neufeind [Sat, 1 Dec 2012 01:02:52 +0000 (02:02 +0100)]
[FEATURE] sys_note: Display/functionality for hover/context menu

In page-module content-elements only show icons when hovered
and they have a contextmenu on the icon.

Add same functionality for sys_note

Change-Id: I170309ac5ffe8b9cfa25ba1c9933d69ddcbcbca8
Resolves: #43496
Releases: 6.1
Reviewed-on: https://review.typo3.org/16911
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Make the update-from-TER link more visible 87/18687/3
Jost Baron [Mon, 4 Mar 2013 20:41:21 +0000 (21:41 +0100)]
[TASK] Make the update-from-TER link more visible

Make the "update from TER"-action in the extension manager more
visible by showing a button for it, instead of a text link.

Also moved the rendering functionality of the update link from
a viewhelper to a partial, as partials tend to be more readable
and bug free.

Resolves: #46029
Releases: 6.1
Change-Id: If447bba28bc0dee3e7de286e1a93e062ef59843c
Reviewed-on: https://review.typo3.org/18687
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Handle symlink on extension update 26/18826/4
Philipp Gampe [Sun, 10 Mar 2013 16:15:27 +0000 (17:15 +0100)]
[BUGFIX] Handle symlink on extension update

If an extension is updated and the extension in the file
system is a symlink to a different directory, all
target directory contents is removed and the update fails.

Introduce a check for symlink and just remove the
symlink in this case.

Resolves: #46158
Releases: 6.1, 6.0
Change-Id: I112ae7192fb0edf77ebd703a61804dc09ca506a4
Reviewed-on: https://review.typo3.org/18826
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] More descriptive error message on file upload failure 27/18827/2
Philipp Gampe [Thu, 27 Dec 2012 12:34:12 +0000 (13:34 +0100)]
[TASK] More descriptive error message on file upload failure

Provide the user with more accurate information about what might have
gone wrong.

Resolves: #46160
Releases: 6.0,6.1
Change-Id: I86123b904f36ff7f6db77f2dd13f97c0a01957c3
Reviewed-on: https://review.typo3.org/18827
Reviewed-by: Alexander Opitz
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Correct check for extTables script 28/18828/2
Francois Suter [Sun, 10 Mar 2013 19:42:19 +0000 (20:42 +0100)]
[BUGFIX] Correct check for extTables script

Existence of the script defined in TYPO3_extTableDef_script is
currently achieved by using file_exists(). This is insufficient
if TYPO3_extTableDef_script is defined, but empty, as
file_exists() will match "typo3conf/" and try to include it.

Resolves: #46161
Releases: 6.0, 6.1
Change-Id: I2e72e86bc583bf4a1ca7e570e679d8297963383d
Reviewed-on: https://review.typo3.org/18828
Reviewed-by: Francois Suter
Tested-by: Francois Suter
6 years ago[BUGFIX] Typo in sys_log TCA 11/18811/2
Christian Kuhn [Fri, 8 Mar 2013 10:32:13 +0000 (11:32 +0100)]
[BUGFIX] Typo in sys_log TCA

Wrong table field name in sys_log TCA "detail_nr" instead of
"details_nr" triggers SQL errors in DB check -> Full search module.

Change-Id: I02298019ef29f38def0b6c204236fd6987b92bce
Releases: 6.1, 6.0
Fixes: #45887
Reviewed-on: https://review.typo3.org/18811
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 10/18810/2
Christian Kuhn [Fri, 8 Mar 2013 10:09:01 +0000 (11:09 +0100)]
[TASK] Raise submodule pointer

Change-Id: I886c3e9cb3212d958b405e0ac9264c2ef9860171
Reviewed-on: https://review.typo3.org/18810
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Don't render table header if no files given 62/18362/2
Georg Ringer [Mon, 18 Feb 2013 16:19:35 +0000 (17:19 +0100)]
[TASK] Don't render table header if no files given

It doesn't make sense to render the table header in
the filelist module if no files are given.

Change-Id: I81870bca94e63643e3f27c90efa370b0a9964337
Resolves: #45579
Releases: 6.1
Reviewed-on: https://review.typo3.org/18362
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Soren Malling
Tested-by: Soren Malling
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Wrong cmd example in INSTALL.txt 06/18806/2
Markus Klein [Fri, 8 Mar 2013 09:45:52 +0000 (10:45 +0100)]
[BUGFIX] Wrong cmd example in INSTALL.txt

The INSTALL.txt file has an example on how to create a link
in Windows using the MKLINK command.

Unfortunately the parameters in the example have the wrong order.

Resolves: #46119
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: Ida960d79e0144c15afdd7c21a9cd35466ec24545
Reviewed-on: https://review.typo3.org/18806
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix SQL syntax 75/18475/3
Michael Stucki [Tue, 26 Feb 2013 00:19:02 +0000 (01:19 +0100)]
[BUGFIX] Fix SQL syntax

Use single quotes to retain compatibility with PostgreSQL.

Change-Id: If3b900d08330bb96ce37fcbefcd110ccfd9b24b5
Resolves: #45826
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18475
Reviewed-by: Felix Kopp
Reviewed-by: Rico Sonntag
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Allow Setting colorspace in the Install Tool. 74/17474/12
Anja Leichsenring [Sat, 12 Jan 2013 10:50:37 +0000 (11:50 +0100)]
[BUGFIX] Allow Setting colorspace in the Install Tool.

Some versions of Imagemagick (6.7.0 and above) use the sRGB colorspace
instead RGB as before. This results in darker images after processing,
because TYPO3 hardcoded the RGB colorspace in graphical functions.

This patch introduces a setting in the GFX part of the Install Tool,
lets the user choose the sufficient colorspace.
This selection is used in graphical functions.

Additionaly a hint on the setting was added to the Image Processing Test
'Read Images' in the Install Tool.

Fixes: #36597
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: I50a26c414705afa3177a2f12fc3bb4532c2d0f7f
Reviewed-on: https://review.typo3.org/17474
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Deactivating "install" extension leads to exceptions 24/16824/3
Wouter Wolters [Tue, 27 Nov 2012 21:48:44 +0000 (22:48 +0100)]
[BUGFIX] Deactivating "install" extension leads to exceptions

Uninstalling the "install" extension leads to exceptions in
required system extensions like extensionmanager or lang.

The solution is to make "install" a required extension too.

Change-Id: Id5a0ebd9400648cd7c453d98b58e8cad1d155bd8
Fixes: #43361
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/16824
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Sebastian Michaelsen
Tested-by: Sebastian Michaelsen
Reviewed-by: Oliver Klee
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Stefan Neufeind
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Fix deprecated things in sysnote 94/18194/3
Markus Günther [Mon, 11 Feb 2013 06:43:36 +0000 (07:43 +0100)]
[TASK] Fix deprecated things in sysnote

The extension sysnote uses deprecated methods in the repository and
the controller. This patch will adjust that.

Fixes: #45349
Releases: 6.1

Change-Id: I7270efb264b80eb852ad972e8a492c0941e83be2
Reviewed-on: https://review.typo3.org/18194
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] RTE: Empty paragraphs are not correctly transformed 21/11621/5
Stanislas Rolland [Tue, 11 Dec 2012 16:00:36 +0000 (11:00 -0500)]
[BUGFIX] RTE: Empty paragraphs are not correctly transformed

Problem: Empty paragraphs entered in the RTE may get lost on way to
database if no block is found in content, as well as on way to the RTE
if followed by a block.
Solution: Fix both transformations and add multiple unit test
cases.

Releases: 4.5, 4.7, 6.0, 6.1
Resolves: #36904
Resolves: #26141

Change-Id: I6c5495fb668f29267bcdeb7b44814a4bb9dc0f96
Reviewed-on: https://review.typo3.org/11621
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Tested-by: Mario Rimann
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn