Packages/TYPO3.CMS.git
6 years ago[TASK] Cleanup wizard initializing 93/21293/8
Wouter Wolters [Sat, 8 Jun 2013 15:51:41 +0000 (17:51 +0200)]
[TASK] Cleanup wizard initializing

The patch cleans up the initialization of the various
wizards we have in TYPO3 CMS. Things that are improved:

* Add constructor to all controllers
* Move language inclusion to constructor
* Move init() and sometimes printContent() to the constructor
* Make init() protected
* Add controller to $GLOBALS['SOBE']

Change-Id: I9783e347a3bf983fae8b6bbbbc972ecf56f31f83
Resolves: #48963
Releases: 6.2
Reviewed-on: https://review.typo3.org/21293
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Failing FAL unit test 41/21541/2
Christian Kuhn [Thu, 20 Jun 2013 16:47:39 +0000 (18:47 +0200)]
[BUGFIX] Failing FAL unit test

Using 0042 as create mask for files in unit test from issue #49029
triggers a warning and lets the test fail when the test file is
removed again. Relaxing the create mask to 0642 solves the issue.

Change-Id: I1bfdb344df5160505d853a725584c2a98f30494b
Resolves: #49296
Related: #49029
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21541
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix JS error with Context Sensitive Help 18/21518/2
Michel Nederlof [Wed, 19 Jun 2013 21:47:02 +0000 (23:47 +0200)]
[BUGFIX] Fix JS error with Context Sensitive Help

Using the edit form for records in a new pop window leads
to a JS error, as "top" is not defined in the new window.

Resolves: #26588
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I2eab83a2c9df2fed13fd5bcc1c829bf4f2b9a055
Reviewed-on: https://review.typo3.org/21518
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Correct permissions of new files 36/21336/7
Michael Knabe [Tue, 11 Jun 2013 12:26:35 +0000 (14:26 +0200)]
[BUGFIX] Correct permissions of new files

Set the correct file permissions of files created with
FAL according to the fileCreateMask.

Change-Id: I4d6562f926cd79a98c3d6b0545a14915c1d7a766
Resolves: #49029
Releases: 6.0, 6.1, 6.2
Reviewed-on: https://review.typo3.org/21336
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Install tool: Warning in upgrade wizard 16/21516/2
Christian Kuhn [Wed, 19 Jun 2013 20:48:23 +0000 (22:48 +0200)]
[BUGFIX] Install tool: Warning in upgrade wizard

The 'silent' cache framework table upgrade throws a warning that
explode() expects a string but an array is given in
SqlSchemaMigration getStatementArray(). The upgrade wizard uses
a wrong API call, since this method is already called within
getExpectedDatabaseSchema() of the helper class.

Change-Id: I6cdde020265e730faa07a25ebda41917672ccea7
Resolves: #49265
Related: #49162
Releases: 6.2
Reviewed-on: https://review.typo3.org/21516
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Use userInput instead of own broken method 11/21511/4
Alexander Opitz [Wed, 19 Jun 2013 17:14:46 +0000 (19:14 +0200)]
[BUGFIX] Use userInput instead of own broken method

The user data from form post submit is broken after install tool
rewrite. Instead of using own method to gather data changed to
the userInput variable that is set by the calling action.

Resolves: #49260
Related: #49162
Related: #49258
Releases: 6.2
Change-Id: I2ce0b5e4bfcb0ef013039297a9186f0f59413b31
Reviewed-on: https://review.typo3.org/21511
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Update Wizard user input not taken into account 10/21510/2
Alexander Opitz [Wed, 19 Jun 2013 17:01:13 +0000 (19:01 +0200)]
[BUGFIX] Update Wizard user input not taken into account

After reworking the install tool, the form element identifier was broken.

Resolves: #49258
Releases: 6.2
Change-Id: Ia9bae8c23345502ddbd4dd398f523af07dbfa5e1
Reviewed-on: https://review.typo3.org/21510
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Install tool: Code optimization in update wizard action 15/21515/2
Christian Kuhn [Wed, 19 Jun 2013 20:11:04 +0000 (22:11 +0200)]
[TASK] Install tool: Code optimization in update wizard action

An if with only a 'throw Exception' call in it breaks code execution
and acts as a guard clause. The code below does not need to be in
an else case.

Change-Id: Ib24ed4bee06763fb46145b815a0b6f3fdf7bafa6
Resolves: #49263
Related: #49162
Releases: 6.2
Reviewed-on: https://review.typo3.org/21515
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Filelist: Only show paste buttons if clipObj is set 31/21131/3
Philipp Gampe [Tue, 28 May 2013 13:14:19 +0000 (15:14 +0200)]
[BUGFIX] Filelist: Only show paste buttons if clipObj is set

During introduction of the paste buttons for empty folders, I assumed
that the clipboard object is always set.
This might not be the case, e.g. in EXT:sphinx 4.0.0.

Wrap the paste button code with a check if the clibObj is set.

We can not set the clibObj here, because it depends on variables of the
calling class.

Resolves: #48603
Releases: 6.2, 6.1, 6.0
Change-Id: I2c7c322c9cb994cfdfa1511c96e8c7da143dc77a
Reviewed-on: https://review.typo3.org/21131
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Remove duplicate vera.ttf from ext:core 12/21512/2
Christian Kuhn [Wed, 19 Jun 2013 19:05:43 +0000 (21:05 +0200)]
[TASK] Remove duplicate vera.ttf from ext:core

vera.ttf is a font only used in the install tool, it was duplicated
to ext:install with the rewrite patch, but forgotten to be removed
from ext:core along the way. The file is removed from ext:core now
to finish the process.

Change-Id: Ibeb8a459655d51b0d5fd5269060c0a36b47b85fc
Resolves: #49261
Related: #49162
Releases: 6.2
Reviewed-on: https://review.typo3.org/21512
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[!!!][TASK] Rewrite install tool 68/21468/16
Christian Kuhn [Sun, 16 Jun 2013 13:06:31 +0000 (15:06 +0200)]
[!!!][TASK] Rewrite install tool

Main features:
* The god class "Installer" is gone and split into two major parts.
A step controller handling major upgrade and install tasks, and a
tool controller handling the known install tool actions.

* The step controller is designed to be always called prior to the
tool controller, if a step needs execution, it comes up, otherwise
the tool controller will be executed.

* The entry point typo3/install/index.php is gone and substituted
by typo3/sysext/install/Start/Install.php. The file contains a
lengthy comment to document the main request flow and used GET/POST
parameters.

* Most parts of the install tool do not bootstrap the whole system
anymore, in general only the base bootstrap, dbal (if loaded),
extbase and fluid ext_localconf.php are loaded. This makes sure
the install tool can not fatal if some extensions ext_localconf
is broken. The whole install tool runs without any caching, so a fatal
in some cache file can not kill the install tool execution.

* Installing TYPO3 CMS on a dbal enabled system is now handled in
the step installer directly to make the according code easier to
understand.

* Rendering is done with a simplified fluid standalone view.

* All install tool forms are CSRF protected.

* A new and fully unit tested class structure is introduced, designed
to take care of the basic file and folder structure of the instance.
It is used during installation to create the needed structure and
can be called in the install tool to compare and fix the current
instance structure with the expected structure. In effect, the
"dummy" package is obsolete. An instance can be created by just
linking index.php, typo3_src/ and typo3/ within the document root,
the installer takes care of creating everything else.

* The installation procedure is released from the package handling.
Packages will be handled by the extension manager after initial
installation with another patch.

Loose ends:
* The whole package handling needs to be implemented in the
extension manager.

* Not all upgrade wizards work, this code area needs some love.

* A 'core' auto updater could be implemented now. A GSoC project
is currently running to realize this.

* The SQL schema migration API is a mess and should be refactored.
For now, another helper class is introduced to encapsulate some
of the nasty details.

* An auto configuration and configuration suggestion system is
planned and needs to be done. It should suggest best configuration
options in the install tool, and should auto configure the system
during installation in the last install step.

* If the backend or frontend fatals due to some extension that
triggers a fatal in ext_localconf or ext_tables (for example
due to a require() of a no longer existing file), a small helper
action in the install tool could find those extensions and suggest
to unload them.

Change-Id: Ice3248caa903449ad6a83ea4f234c7bd125bdb66
Resolves: #49162
Releases: 6.2
Reviewed-on: https://review.typo3.org/21468
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Tested-by: Alexander Opitz
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Add autofocus attribute to BE login 00/21500/2
Markus Klein [Tue, 18 Jun 2013 20:32:33 +0000 (22:32 +0200)]
[FEATURE] Add autofocus attribute to BE login

Adding the HTML5 autofocus attribute to the
backend login box's username field.

Resolves: #49228
Releases: 6.2
Change-Id: I5a00d5ec260ade81fb83553a50358cddf95eaebb
Reviewed-on: https://review.typo3.org/21500
Reviewed-by: Eric Chavaillaz
Tested-by: Eric Chavaillaz
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[BUGFIX] Raw search can't search inside the pages table 02/21502/2
Stefan Galinski [Wed, 19 Jun 2013 10:26:06 +0000 (12:26 +0200)]
[BUGFIX] Raw search can't search inside the pages table

It's impossible to search the pages table, because a field
definition is wrongly named in the pages TCA.

Fixes: #49242
Releases: 6.2, 6.1, 6.0
Change-Id: I0d1b9eeb4ffdfbff456dfc6249cb23853cb9a357
Reviewed-on: https://review.typo3.org/21502
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[BUGFIX] Use correct path in belog modules 80/21480/4
Georg Ringer [Mon, 17 Jun 2013 12:57:47 +0000 (14:57 +0200)]
[BUGFIX] Use correct path in belog modules

Belog module links to history view but path is wrong in
the info module.

Change-Id: I3e45218b2bd8b7d69d75459f41c37512de3dd23f
Releases: 6.2, 6.1, 6.0
Resolves: #49091
Reviewed-on: https://review.typo3.org/21480
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Nested FLUIDTEMPLATE doesn't work anymore 85/20585/6
Stefan Galinski [Tue, 7 May 2013 14:53:07 +0000 (16:53 +0200)]
[BUGFIX] Nested FLUIDTEMPLATE doesn't work anymore

It's impossible since version 6.0 to render a
FLUIDTEMPLATE content object inside a
FLUIDTEMPLATE, because the internal fluid view
instance of the parent FLUIDTEMPLATE will be
overridden by the children FLUIDTEMPLATE.

Fixes: #48021
Releases: 6.2, 6.1, 6.0
Change-Id: I776a3b0a388bb47d2995041679e39ec7442459c2
Reviewed-on: https://review.typo3.org/20585
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Cleanup ChangeLog 23/21423/2
Michael Stucki [Fri, 14 Jun 2013 12:33:28 +0000 (14:33 +0200)]
[TASK] Cleanup ChangeLog

Remove duplicate lines from ChangeLog
Follow-up to commit:db9efd32b4dfad2952f2725b53fb5e4522740b74

Change-Id: I62b32f9b0b37c3977bc61b2874e37cde289846df
Resolves: #49110
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21423
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Remove unused icons from /gfx 04/21404/2
Felix Kopp [Thu, 13 Jun 2013 20:15:15 +0000 (22:15 +0200)]
[TASK] Remove unused icons from /gfx

Folder /gfx holds image that are used over the backend.
EXT: t3skin brings an override declaration and own icons.

Over the time lots of icons were added and overworked but
no icons were removed - although many should be erased.

Removes unused icons from the main /gfx folder.

Resolves: #49112
Releases: 6.2
Change-Id: Id5e00dd3daec3129caae58ed1bccfd51fb9f610b
Reviewed-on: https://review.typo3.org/21404
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Add labels to form fields of admin panel 72/21372/2
Georg Ringer [Wed, 12 Jun 2013 17:51:43 +0000 (19:51 +0200)]
[TASK] Add labels to form fields of admin panel

Labels make it much easier to click check boxes and to
reach fields.

Change-Id: Ib9c42f4859a4fc4e30fc7f03dd525795d0824449
Resolves: #49073
Reviewed-on: https://review.typo3.org/21372
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Fix reverse order handling of MediaProvider 71/21471/4
Alexander Opitz [Mon, 17 Jun 2013 07:37:14 +0000 (09:37 +0200)]
[BUGFIX] Fix reverse order handling of MediaProvider

Fixing the variable used to test for valid providers in reverse order.

Resolves: #49136
Releases: 6.2, 6.1, 6.0
Change-Id: Ia80366150b853138fc41c09e59df993e1540b230
Reviewed-on: https://review.typo3.org/21471
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[FEATURE] Allow custom record list in element browser 47/21347/5
Alexander Stehlik [Tue, 11 Jun 2013 17:58:26 +0000 (19:58 +0200)]
[FEATURE] Allow custom record list in element browser

Introduces a class variable and a setter for a custom record list
instance in the element browser that can be used to override the
default element browser recordlist.

Resolves: #49037
Releases: 6.2
Change-Id: I41fd3a33f70e72aedef9362ee6bf67de9dcde8ac
Reviewed-on: https://review.typo3.org/21347
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Move video-js to contrib 51/21451/3
Felix Kopp [Sat, 15 Jun 2013 13:11:58 +0000 (15:11 +0200)]
[TASK] Move video-js to contrib

To resolve /t3lib few more files should be moved:
Moves video-js styles controls to contrib.

Change-Id: I648d3bdd17ed0414e6ef1041f3630c343c73747d
Resolves: #49152
Releases: 6.2
Reviewed-on: https://review.typo3.org/21451
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Allow non-Admins to delete Records finally 80/10480/6
dkd-egerer Sascha Egerer [Tue, 27 Nov 2012 00:42:59 +0000 (01:42 +0100)]
[BUGFIX] Allow non-Admins to delete Records finally

This patch adds the posibility for non Admins to delete
records finally in the recycler.

Change-Id: I1fda11d621403758f4d78b7fa8f730d7b47d79a7
Fixes: #34156
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/10480
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Illegal string offset 'translations' in DatabaseRecordList 79/19779/3
Philipp Gampe [Wed, 10 Apr 2013 15:41:53 +0000 (17:41 +0200)]
[BUGFIX] Illegal string offset 'translations' in DatabaseRecordList

The return value of TranslationConfigurationProvider->translationInfo
normally is an array, but it is a string in case of an error.
Move the line below the is_array() check, because it is only needed
inside.

Fixes: #47103
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: Ia781eae987d9295bc2b299f83c087669c96dfd00
Reviewed-on: https://review.typo3.org/19779
Reviewed-by: Dmitry Dulepov
Reviewed-by: Alexander Opitz
Reviewed-by: Heiko Kromm
Tested-by: Heiko Kromm
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[TASK] Move express-install to contrib (flowplayer) 50/21450/2
Felix Kopp [Sat, 15 Jun 2013 12:58:44 +0000 (14:58 +0200)]
[TASK] Move express-install to contrib (flowplayer)

To resolve /t3lib few more files should be moved:
Moves flowplayer styles for express-install to contrib.

Change-Id: I8d987774c9ff2c9ab13f86ab6086c1d7fb608afa
Resolves: #49151
Releases: 6.2
Reviewed-on: https://review.typo3.org/21450
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[BUGFIX] Fix template rootline for translated pages 74/21174/4
Alexander Stehlik [Fri, 31 May 2013 15:07:00 +0000 (17:07 +0200)]
[BUGFIX] Fix template rootline for translated pages

The TypoScript template rootline in the Frontend will not be
changed any more if a different sys_language_uid is used.

The data of the current rootLine will be overwritten with the
translated rootLine data.

Resolves: #48300
Releases: 6.2, 6.1
Change-Id: I38bd4a6f3d3c2f15712003b1d1a1334284ebe9b0
Reviewed-on: https://review.typo3.org/21174
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] compressJs returns wrong filenames 45/20845/3
Philipp Gampe [Thu, 16 May 2013 18:23:00 +0000 (20:23 +0200)]
[BUGFIX] compressJs returns wrong filenames

If you enable
    config.concatenateJs = 1
    config.compressJs = 1
then the uncompressed version of the file is linked.

This does not change much, because compression is disabled and the files
will always be uncompressed, however the right link should be generated.

The allows extension to override the compress method and implement
compression without fixing the rest of the code.

The bug is a regression introduced with: #27694 (4.6).

Return the correct filename by overriding the filename with the returned
value of compressJsFile.

Resolves: #48213
Related: #27694
Releases: 6.2, 6.1, 6.0, 4.7
Change-Id: I1f65576db8084b54f9e5a13947ced258eef893d7
Reviewed-on: https://review.typo3.org/20845
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Insert rows only once in exec_INSERTmultipleRows 85/21085/2
Jigal van Hemert [Wed, 15 May 2013 19:07:50 +0000 (21:07 +0200)]
[BUGFIX] Insert rows only once in exec_INSERTmultipleRows

For native handler types multiple rows can be inserted using the mysql
INSERTmultipleRows API call. When another handler was used, the operation
was done twice, due to a missing else after the native handler condition.
This resulted in two database records for every INSERT statement.

The patch adds the missing else branch for the condition, preventing
the second run that was only meant to handle non-native handler types.

Change-Id: Ibab98a0c73b379bac063c8d1c19e30e93f38faf4
Resolves: #48220
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Related: #34327
Reviewed-on: https://review.typo3.org/21085
Tested-by: Alexander Opitz
Reviewed-by: Alexander Opitz
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Cleanup ChangeLog 03/21403/2
Ernesto Baschny [Thu, 13 Jun 2013 21:10:27 +0000 (23:10 +0200)]
[TASK] Cleanup ChangeLog

Remove mistakenly introduced submodule history in 6.2.0alpha1
release.

Resolves: #49110
Releases: 6.2
Change-Id: I00cb44c5ff718a2bf53f61c5ce7cdf778c783325
Reviewed-on: https://review.typo3.org/21403
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
6 years ago[BUGFIX] Repair broken unit tests 89/21389/2
Anja Leichsenring [Thu, 13 Jun 2013 12:35:44 +0000 (14:35 +0200)]
[BUGFIX] Repair broken unit tests

In patch 21171 some tests broke due to forgotten adjustments after
code change.
This patch brings the missing adjustment.

Releases: 6.2, 6.1
Resolves: #49100
Relates: #48571
Change-Id: I9a07e14ea050fad95bcc424ad07afc54f6aea1e1
Reviewed-on: https://review.typo3.org/21389
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Tested-by: Philipp Gampe
Reviewed-by: Philipp Gampe
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] findByUid should respect query settings of repository 71/21171/5
Alexander Schnitzler [Fri, 31 May 2013 08:51:11 +0000 (10:51 +0200)]
[BUGFIX] findByUid should respect query settings of repository

Prior to 6.1 findByUid built its own query which respected
the settings of its repository. Now findByUid just fetches
the object from the persistence manager which builds its own
query without respecting the query setting of the repository.

This leads to the error that the user isn't able to fetch
hidden records by uid any more. Therefore the
old behaviour of the repository must be used.
An according deprecation hint is added.

Releases: 6.2, 6.1
Resolves: #48571
Change-Id: Ic9a48d5d06f20b2ab8032c39eecb89cd52f898af
Reviewed-on: https://review.typo3.org/21171
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Do not add category to empty table names 38/20938/5
Alexander Opitz [Tue, 21 May 2013 07:42:34 +0000 (09:42 +0200)]
[BUGFIX] Do not add category to empty table names

If the $GLOBALS['TYPO3_CONF_VARS']['SYS']['defaultCategorizedTables']
is empty or you have empty strings between commas then we try to add
empty tablenames to the table definitions.

This is fixed by setting removeEmptyValues to true in trimExplode
and adding a RuntimeException to the add function to prevent
others (extensions) breaking the functionality.

Resolves: #48381
Releases: 6.2, 6.1
Change-Id: I4a8d43a0ff75da298ace4f1d33a5dcf2d2ac569f
Reviewed-on: https://review.typo3.org/20938
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Peter Niederlag
Tested-by: Peter Niederlag
6 years ago[BUGFIX] Fix missing single quotes in SchemaMigratorTest 71/21371/2
Wouter Wolters [Wed, 12 Jun 2013 17:37:48 +0000 (19:37 +0200)]
[BUGFIX] Fix missing single quotes in SchemaMigratorTest

Change-Id: I452252096e39d8986dfa414016011d16f33523b8
Resolves: #49072
Related: #41344
Releases: 6.2
Reviewed-on: https://review.typo3.org/21371
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Avoid double wrap in css_styled_content 58/21358/3
Francois Suter [Wed, 12 Jun 2013 09:38:47 +0000 (11:38 +0200)]
[BUGFIX] Avoid double wrap in css_styled_content

Since TYPO3 6.0, USER objects have stdWrap property. The
various render methods of css_styled_content still call
stdWrap themselves, resulting in a double wrap.

Remove the stdWrap calls in css_styled_content render methods.

Resolves: #49051
Releases: 6.0, 6.1, 6.2
Change-Id: I3092990a4d1efb12597dc543c222a727135d63ec
Reviewed-on: https://review.typo3.org/21358
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
Reviewed-by: Francois Suter
Tested-by: Francois Suter
6 years ago[TASK] Move t3lib/csconvtbl && t3lib/unidata 26/21326/3
Georg Ringer [Mon, 10 Jun 2013 16:09:53 +0000 (18:09 +0200)]
[TASK] Move t3lib/csconvtbl && t3lib/unidata

Move the 2 folders t3lib/csconvtbl && t3lib/unidata to
sysext/core/Resources/Private/Charsets/

Change-Id: If721bfe5ab7887f67ca774ae5a409d6f67ef009e
Resolves: #49005
Releases: 6.2
Reviewed-on: https://review.typo3.org/21326
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] False-Positives in SQL comparison 30/19630/9
Mario Rimann [Fri, 5 Apr 2013 21:10:29 +0000 (23:10 +0200)]
[BUGFIX] False-Positives in SQL comparison

When one has e.g. a field "foo INT(11) DEFAULT '0' NOT NULL" in
it's ext_tables.sql definition, the comparison will always complain
about that field, since the underlying DB lists this field as "int(11)"
which is lowercased.

This integrates a regex that lowercases the field types before
comparing the field from the definition against the existing field.

Change-Id: If76abbbca56d0ef0ab796a7f4e6bee1197ac39e6
Resolves: #41344
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/19630
Tested-by: Dmitry Dulepov
Tested-by: Wouter Wolters
Reviewed-by: Dmitry Dulepov
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
6 years ago[BUGFIX] Missing file extension class with "file links" type 18/21318/2
Stefan Galinski [Mon, 10 Jun 2013 14:50:40 +0000 (16:50 +0200)]
[BUGFIX] Missing file extension class with "file links" type

The content element type "file links" can't render
the the css class for the file extension, because
it uses a non-existing reference from pre-FAL
times. You can find the specific css class on the
generated list item.

Fixes: #48996
Releases: 6.2, 6.1, 6.0
Change-Id: I3031770a6741a331647f3bd5699ea1a2c0d444a9
Reviewed-on: https://review.typo3.org/21318
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] List Module - Reference count limited to 20 23/21323/2
Stefan Galinski [Mon, 10 Jun 2013 15:42:22 +0000 (17:42 +0200)]
[BUGFIX] List Module - Reference count limited to 20

The reference count in the list view is limited
to 20. Use the extended view to render the counter.

Fixes: #49004
Releases: 6.2, 6.1, 6.0
Change-Id: I295f3c5ea93c5cad5e5f64ba4bfd15a8f9193e61
Reviewed-on: https://review.typo3.org/21323
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[TASK] Allow sys_category in rootpage 23/20123/4
Stefan Froemken [Wed, 24 Apr 2013 07:27:18 +0000 (09:27 +0200)]
[TASK] Allow sys_category in rootpage

Allow sys_category records to be stored in the rootpage. (pid=0)

Resolves: #47530
Releases: 6.2, 6.1, 6.0
Change-Id: Ie71a13ec9a1be65c57e28fff63f003fc5caa6ac1
Reviewed-on: https://review.typo3.org/20123
Reviewed-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[BUGFIX] Recycler ignores depth setting 21/21321/2
Stefan Galinski [Mon, 10 Jun 2013 15:17:44 +0000 (17:17 +0200)]
[BUGFIX] Recycler ignores depth setting

The recycler currently ignores the depth
setting, because of a wrong type check
since the migration to mysqli.

Fixes: #48997
Releases: 6.2, 6.1
Change-Id: Ib7a4eb1fc68468ce09944bb9342e070a6ab3860f
Reviewed-on: https://review.typo3.org/21321
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
6 years ago[TASK] Remove "require_once" in /typo3/ 83/21283/2
Felix Kopp [Fri, 7 Jun 2013 11:05:36 +0000 (13:05 +0200)]
[TASK] Remove "require_once" in /typo3/

During the namespace switch many classes were renamed
and moved to different locations based on the new names.

This patch removes the "require_once" statements that are
automatically resolved and auto loaded in makeInstance.

Change-Id: I5f788fad6ea63b2aa0b9f33e3d068b93ec04dc31
Resolves: #48934
Releases: 6.2
Reviewed-on: https://review.typo3.org/21283
Reviewed-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Bad English in system extensions: "screen shot" 96/21296/3
Bernhard Kraft [Sat, 8 Jun 2013 19:11:53 +0000 (21:11 +0200)]
[BUGFIX] Bad English in system extensions: "screen shot"

According to wiktionary [1] the word "screenshot" is a compound
word and not two separate words.

[1] http://en.wiktionary.org/wiki/screenshot

Resolves: #48989
Releases: 6.2, 6.1
Change-Id: Id7b9aa7eb98c4a2c6b0d47bddfb7cb9d51580aec
Reviewed-on: https://review.typo3.org/21296
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Move JavaScript files out of t3lib 03/20903/3
Felix Kopp [Sat, 18 May 2013 21:32:00 +0000 (23:32 +0200)]
[TASK] Move JavaScript files out of t3lib

t3lib folder should diminish and finally dissolve itself.
Moves JS files out of t3lib to corresponding extension folders.

Change-Id: Iffdbd1a919dadae923034d38dedafa68a902da26
Resolves: #48379
Releases: 6.2
Reviewed-on: https://review.typo3.org/20903
Tested-by: Wouter Wolters
Reviewed-by: Wouter Wolters
Reviewed-by: Markus Klein
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] FileLogWriter ignores log file configuration 58/21258/7
Steffen Müller [Thu, 6 Jun 2013 13:42:17 +0000 (15:42 +0200)]
[BUGFIX] FileLogWriter ignores log file configuration

If there are several instances of TYPO3\CMS\Core\Log\Writer\FileLogWriter
with different log files configured in $logFile, all log records end up
in one file.

This is caused by improper use of static variable $logFileHandle.
All filehandles except the one of the latest instance are ignored.

Resolves: #48918
Releases: 6.2, 6.1, 6.0
Change-Id: Ie6de5e4789d107b541117daf6c7e9855015e0a46
Reviewed-on: https://review.typo3.org/21258
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[BUGFIX] Bad English in TCEforms: "Edit Pagecontent" and "fontface" 46/21246/3
Dmitry Dulepov [Wed, 5 Jun 2013 14:10:19 +0000 (17:10 +0300)]
[BUGFIX] Bad English in TCEforms: "Edit Pagecontent" and "fontface"

Core language files contain the words "Pagecontent" and "fontface",
which both must be two separate words.

Change-Id: I5538002e38a8a07224299c151bf7bbe525883754
Resolves: #22913
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/21246
Reviewed-by: Bernhard Kraft
Tested-by: Bernhard Kraft
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Increase spacing between icon (module menu) 92/21292/2
Felix Kopp [Tue, 28 May 2013 00:30:28 +0000 (02:30 +0200)]
[TASK] Increase spacing between icon (module menu)

Adds small additional space between icons and label in mod menu.

Resolves: #48957
Releses: 6.2
Change-Id: Ibbc0278729ca0aec1bfc56e4c4bd58516c599978
Reviewed-on: https://review.typo3.org/21292
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] EXT: t3skin - extract table styling 97/21197/3
Felix Kopp [Mon, 3 Jun 2013 09:04:55 +0000 (11:04 +0200)]
[TASK] EXT: t3skin - extract table styling

In order to be able to introduce common table css definition,
CSS must be concentrated in a common file "main_table.css".

Change-Id: I3b051577bd0549be074347ce20a41cbeeb3b4b8f
Resolves: #48786
Releases: 6.2
Reviewed-on: https://review.typo3.org/21197
Reviewed-by: Susanne Moog
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[TASK] EXT: t3skin: Extract form styling into own file 96/21196/2
Felix Kopp [Mon, 3 Jun 2013 08:28:45 +0000 (10:28 +0200)]
[TASK] EXT: t3skin: Extract form styling into own file

File main_content.css currently includes styles definitions
for <form> and corresponding fields.

Extract CSS styling definitions from main_content.css into an
own file "main_form.css" (for /structure + /visual directory).

Change-Id: I77fb16fb32d28a1e946e5f6093ee4389289e0ca1
Resolves: #48783
Releases: 6.2
Reviewed-on: https://review.typo3.org/21196
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
6 years ago[FEATURE] Switch View Helper 55/21155/6
Wouter Wolters [Wed, 29 May 2013 17:06:33 +0000 (19:06 +0200)]
[FEATURE] Switch View Helper

Simple view helper that allows you to render content depending
on a given value or expression.
It bahaves similar to a basic switch statement in PHP.

Usage:

<f:switch expression="{person.gender}">
  <f:case value="male">Mr.</f:case>
  <f:case value="female">Mrs.</f:case>
</f:switch>

Change-Id: I44a7066dfa86785f795069e0f06391cb45fa373c
Resolves: #48653
Releases: 6.2
Reviewed-on: https://review.typo3.org/21155
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
6 years ago[TASK] Remove styles for former ExtensionManager 73/21073/3
Felix Kopp [Sun, 26 May 2013 15:59:11 +0000 (17:59 +0200)]
[TASK] Remove styles for former ExtensionManager

Deleted CSS files that bring styles for former EXT: em.

Change-Id: Ia8bd3c8971ba5aabb7792a08b4cff577d1f95ec6
Resolves: #48550
Releases: 6.2
Reviewed-on: https://review.typo3.org/21073
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Set TYPO3 version to 6.2-dev 34/21234/2
TYPO3 Release Team [Tue, 4 Jun 2013 20:49:33 +0000 (22:49 +0200)]
[TASK] Set TYPO3 version to 6.2-dev

Change-Id: I70f9ae0972a71aa4a62c5c99ddc46d7a2f3e3e6d
Reviewed-on: https://review.typo3.org/21234
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.2.0alpha1 33/21233/2 TYPO3_6-2-0alpha1
TYPO3 Release Team [Tue, 4 Jun 2013 20:49:08 +0000 (22:49 +0200)]
[RELEASE] Release of TYPO3 6.2.0alpha1

Change-Id: I85317f149a345b67ddaa6e6d2ec67c90f02a4256
Reviewed-on: https://review.typo3.org/21233
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[TASK] Make preperations for backporting Flow validation api 90/21190/5
Alexander Schnitzler [Sun, 2 Jun 2013 11:36:59 +0000 (13:36 +0200)]
[TASK] Make preperations for backporting Flow validation api

Synced some parts of Extbase validation with the one of
Flow without changing actual behaviour.

Releases: 6.2
Resolves: #48767
Change-Id: I0801f4faaa2d9e0fea31e51704ff0a30ca2c4ccb
Reviewed-on: https://review.typo3.org/21190
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[TASK] Mark Extbase\Mvc\Controller\FlashMessageContainer deprecated 66/21166/3
Alexander Schnitzler [Thu, 30 May 2013 10:08:41 +0000 (12:08 +0200)]
[TASK] Mark Extbase\Mvc\Controller\FlashMessageContainer deprecated

As Extbase uses the new FlashMessageService provided by the core the
old FlashMessageContainer has to be marked deprecated. Therefore also
TYPO3\CMS\Extbase\Mvc\Controller\AbstractController->injectFlash
MessageContainer has to be marked deprecated but must not throw
create a deprecation log entry.

Releases: 6.2
Resolves: #48669
Change-Id: I2583f6a72aae6ee8abc50ebd053ffc23bc74d30b
Reviewed-on: https://review.typo3.org/21166
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[FEATURE] Add ObjectManager->getScope like in TYPO3.Flow 89/21189/5
Alexander Schnitzler [Sun, 2 Jun 2013 10:59:52 +0000 (12:59 +0200)]
[FEATURE] Add ObjectManager->getScope like in TYPO3.Flow

This method detects if a class is of type prototype or
singleton. We need this method as it is a dependency for
further backporting of the Flow validation api.

Releases: 6.2
Resolves: #48766
Change-Id: I4d6b043a4015c31ede0b099eebed4491a38723cd
Reviewed-on: https://review.typo3.org/21189
Tested-by: Wouter Wolters
Reviewed-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] FormFieldVH->getPropertyValue() must work without form object 81/21181/6
Alexander Schnitzler [Sat, 1 Jun 2013 08:32:19 +0000 (10:32 +0200)]
[BUGFIX] FormFieldVH->getPropertyValue() must work without form object

Since the new property mapper is active by default it is
possible to create forms without object="{object}", e.g.
using a newAction. This leads to some view helpers throwing
an exception as they rely on a present object to receive the
property value. As this object may not be present a missing
check has to be added to method getPropertyValue().

This check also exists in Flow.Fluid and is necessary to
fix malfunctioning view helpers.

Releases: 6.2, 6.1
Resolves: #48750
Relates: #48628
Change-Id: I6c42725d6daf9003358f8b6fbe9af3e62f011213
Reviewed-on: https://review.typo3.org/21181
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Alexander Schnitzler
Tested-by: Alexander Schnitzler
6 years ago[BUGFIX] Enable CheckboxViewHelper binding to ArrayObject and Null 84/21184/2
Alexander Schnitzler [Sat, 1 Jun 2013 09:56:21 +0000 (11:56 +0200)]
[BUGFIX] Enable CheckboxViewHelper binding to ArrayObject and Null

Currently the checkbox view helper relies on a present
form object which is not necessary any longer since 6.1
as the new property mapper is active by default.

Therefore the viewhelper must be adjusted to be able to
be bound to ArrayObject objects or Null which throws an
exception till now.

Releases: 6.2, 6.1
Resolves: #48628
Change-Id: I35b70fb0a09ddd72da1c64ec5c7c5456e9af9471
Reviewed-on: https://review.typo3.org/21184
Tested-by: Adrian Dymorz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Wrong position for beforeCallActionMethod 16/21116/2
Stefan Froemken [Thu, 2 May 2013 11:50:43 +0000 (13:50 +0200)]
[BUGFIX] Wrong position for beforeCallActionMethod

The SignalSlot "beforeCallActionMethod" is at the
wrong position

Resolves: #47826
Releases: 6.2, 6.1
Change-Id: Id80297deb26c544bb703fa1fe7dd05b58b2b9230
Reviewed-on: https://review.typo3.org/21116
Tested-by: Alexander Schnitzler
Reviewed-by: Alexander Schnitzler
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Move typo3lang.js to Resources/Public/JavaScript 60/21160/2
Wouter Wolters [Wed, 29 May 2013 18:28:56 +0000 (20:28 +0200)]
[TASK] Move typo3lang.js to Resources/Public/JavaScript

Move typo3/sysext/lang/res/js/be/typo3lang.js to
typo3/sysext/Resources/Public/JavaScript/Typo3Lang.js

Change-Id: I1541e377a49ac0cd3d43a222c4ca87b71268cce2
Resolves: #48655
Releases: 6.2
Reviewed-on: https://review.typo3.org/21160
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Clean-up EXT: t3skin css files 94/21194/2
Felix Kopp [Sun, 2 Jun 2013 19:18:04 +0000 (21:18 +0200)]
[TASK] Clean-up EXT: t3skin css files

Few styles are unused or defined multiple times. Few files are not
in use any longer. Also comments and newlines could be unified.

Change-Id: If38a33291454e5b53247d79b78d2c7141f768512
Resolves: #48776
Releases: 6.2
Reviewed-on: https://review.typo3.org/21194
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
6 years ago[TASK] Remove tabs_images for module groups 93/21193/3
Felix Kopp [Sun, 2 Jun 2013 18:01:09 +0000 (20:01 +0200)]
[TASK] Remove tabs_images for module groups

Backend Modules are mostly recognized by their icons. Those
modules are accessed via the module menu on the left.
Modules are grouped into module groups.

Since module groups are defined the same way as
sub-modules are - also module *groups* have icons.

Those icons are not displayed widely and not maintained.
Because these module -group- icons do not bring benefits:

This patch removes tabs_images from module groups.

Change-Id: I1a1de5d1fa8899c362dcf1d2c592ec85cf32e59b
Resolves: #48774
Releases: 6.2
Reviewed-on: https://review.typo3.org/21193
Reviewed-by: Soren Malling
Tested-by: Soren Malling
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
6 years ago[BUGFIX] CSS: Default vertical spacing for blocks 50/21050/3
Felix Kopp [Sun, 26 May 2013 01:10:55 +0000 (03:10 +0200)]
[BUGFIX] CSS: Default vertical spacing for blocks

Forms, tables, texts need a clear structure and obvious
visual distinction. Our Backend currently does not
deliver strong defaults for extensions.

Many modules already work around this lack of structure
by adding extra spacing and horizontal rules:

- DocumentTemplate::spacer(x-Pixel)
- DocumentTemplate::divider()

This patch brings vertical spacing based on CSS for:

- p
- ul / ol
- dl
- blockquote

Change-Id: I93a1a43b21d6e56db822558c6d4be0103097ed98
Resolves: #48540
Releases: 6.2
Reviewed-on: https://review.typo3.org/21050
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Automatically determine page type for URIs with format 23/21123/3
Lienhart Woitok [Sat, 18 Jun 2011 17:58:58 +0000 (19:58 +0200)]
[FEATURE] Automatically determine page type for URIs with format

When rendering a special format a custom page type is required.
This adds a mapping configuration to define which page type
should be used for which format.

Example:
plugin.tx_myext {
    view.formatToPageTypeMapping {
        txt = 99
        pdf = 123
    }
}

The formats defined will apply to all Plugins in your extension.

Change-Id: I22beb6334a094711abfb2ee7b53fb3e065ec8580
Releases: 6.2
Resolves: #27498
Reviewed-on: https://review.typo3.org/21123
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] changing FE user password updates tstamp 86/21186/2
Jigal van Hemert [Sat, 1 Jun 2013 20:59:47 +0000 (22:59 +0200)]
[BUGFIX] changing FE user password updates tstamp

When an FE user changes his/her password the tstamp field of the
record is also updated to reflect that the record is changed.

Change-Id: I6907c7af6c46612f5e1d2e6aca6a38e9216d3af3
Fixes: #48685
Releases: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/21186
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Steffen Müller
Tested-by: Steffen Müller
6 years ago[TASK] Clean-up and update INSTALL.txt 64/21064/3
Felix Kopp [Sun, 26 May 2013 14:44:15 +0000 (16:44 +0200)]
[TASK] Clean-up and update INSTALL.txt

- Update copyright year
- Include required module "fileinfo" in recommended section
- Add reference to recommended library FreeType 2
- Correct typo3.org deep links accordingly (T3O)

Change-Id: I067b2d930c1a6ffa15ea61f10723e29eb434f491
Resolves: #48541
Releases: 6.2
Reviewed-on: https://review.typo3.org/21064
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Bring back int_from_ver 47/21047/4
Anja Leichsenring [Sat, 25 May 2013 20:20:27 +0000 (22:20 +0200)]
[TASK] Bring back int_from_ver

Due to many failing extensions relying on this function,
Release Management decided to bring it back as a redirect
to VersionNumberUtility::convertVersionNumberToInteger.

Resolves: #48536
Relates: #44763
Releases: 6.2, 6.1
Change-Id: Id76758c10a542bdbe0cc033466f494b0a6350692
Reviewed-on: https://review.typo3.org/21047
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Daniel Hürtgen
Tested-by: Daniel Hürtgen
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[FEATURE] Backport Object Type Converter from Flow 14/21114/2
Helmut Hummel [Fri, 3 May 2013 19:17:37 +0000 (21:17 +0200)]
[FEATURE] Backport Object Type Converter from Flow

In Flow there is a Type Converter which can map array sources
to not persistent objects. This is very useful if you need
transitional objects built from request arguments.

Backporting this converter needs some minor modifications
in the reflection service, which are included in this commit
as well as registering the new converter.

Resolves: #48548
Releases: 6.2

Change-Id: Ic88b732076ae19ece490cf1376b2d1bbcaf1ebff
Reviewed-on: https://review.typo3.org/21114
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Daniel Hürtgen
Tested-by: Daniel Hürtgen
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Remove dummy files from ext:tstemplate_* extensions 66/20766/3
Wouter Wolters [Mon, 13 May 2013 21:00:20 +0000 (23:00 +0200)]
[TASK] Remove dummy files from ext:tstemplate_* extensions

* Remove dummy files from ext:tstemplate_* extensions
* Remove old class names to the new ones
* Adjust function names for the backend module
* Adjust AJAX save type

Change-Id: I560c1c0e7bceb271eaba1a1d660cec71614df64a
Resolves: #48157
Related: #47756
Releases: 6.2
Reviewed-on: https://review.typo3.org/20766
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Merge submodule version into core
Thomas Maroschik [Mon, 27 May 2013 17:05:55 +0000 (19:05 +0200)]
[TASK] Merge submodule version into core

6 years ago[TASK] Merge submodule workspaces into core
Thomas Maroschik [Mon, 27 May 2013 17:05:54 +0000 (19:05 +0200)]
[TASK] Merge submodule workspaces into core

6 years ago[TASK] Merge submodule linkvalidator into core
Thomas Maroschik [Mon, 27 May 2013 17:05:52 +0000 (19:05 +0200)]
[TASK] Merge submodule linkvalidator into core

6 years ago[TASK] Merge submodule fluid into core
Thomas Maroschik [Mon, 27 May 2013 17:05:51 +0000 (19:05 +0200)]
[TASK] Merge submodule fluid into core

6 years ago[TASK] Merge submodule extbase into core
Thomas Maroschik [Mon, 27 May 2013 17:05:50 +0000 (19:05 +0200)]
[TASK] Merge submodule extbase into core

6 years ago[TASK] Merge submodule dbal into core
Thomas Maroschik [Mon, 27 May 2013 17:05:48 +0000 (19:05 +0200)]
[TASK] Merge submodule dbal into core

6 years ago[BUGFIX] uploading extname_1.0.3 (1).zip creates extension "extname (1)" 75/20875/5
Philipp Gampe [Fri, 17 May 2013 15:11:17 +0000 (17:11 +0200)]
[BUGFIX] uploading extname_1.0.3 (1).zip creates extension "extname (1)"

The function getExtensionFromZipFile fails to sanitize any output after
the version. As the function is only interested in the part before the
version which must be the extension key, remove any trailing characters.

Add a unit test to document this behavior.

Resolves: #48332
Releases: 6.2, 6.1, 6.0
Change-Id: I09b810d4bce214b6fa38e1a62200560f30d88984
Reviewed-on: https://review.typo3.org/20875
Reviewed-by: Alexander Opitz
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Pass $field to BackendUtility::getFlexFormDS 19/20919/4
Wouter Wolters [Sun, 19 May 2013 14:21:37 +0000 (16:21 +0200)]
[BUGFIX] Pass $field to BackendUtility::getFlexFormDS

This bugfix just passes an already existing argument
along to the hook method, making the $field variable
available there.

Change-Id: I5337490920a96a8db0af8f8ecc01e967dba0c9ca
Fixes: #39527
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/20919
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[FEATURE] Multiple params for user function in typoscript conditions. 35/19835/3
Daniel Hürtgen [Fri, 12 Apr 2013 12:35:47 +0000 (14:35 +0200)]
[FEATURE] Multiple params for user function in typoscript conditions.

Currrently you can use user functions for typoscript conditions and
pass one parameter to your created functions. If you have more than
parameter, you must create a workaround and use an delimiter other
than comma an split it up in your user functions to separate them.

This patch is a fix for that and make it possible to use multiple params
for user functions.

Change-Id: Ief2486f6133132303a5925370c1517ee9a98a0b4
Resolves: #47159
Releases: 6.2
Reviewed-on: https://review.typo3.org/19835
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Daniel Hürtgen
Tested-by: Daniel Hürtgen
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
6 years ago[BUGFIX] Some TCAdefaults work only with "Page (inside)" 00/20900/2
Wouter Wolters [Sat, 18 May 2013 15:45:17 +0000 (17:45 +0200)]
[BUGFIX] Some TCAdefaults work only with "Page (inside)"

Some TCAdefaults work only with "Page (inside)" and not in
the wizard.

Affected defaults:
* TCAdefaults.pages.hidden = 1
* TCAdefaults.pages.doktype = 2

Change-Id: I71eb301909c31eb8cd160dbe6beadc4ba5102b66
Resolves: #14955
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/20900
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] EXT: Belog - backend module H1-H4 (html) 49/21049/2
Felix Kopp [Sun, 26 May 2013 00:29:35 +0000 (02:29 +0200)]
[TASK] EXT: Belog -  backend module H1-H4 (html)

Restructures headlines in EXT: belog backend module to
reflect hierarchy of the content: H1 through H4.

Change-Id: I3d462bbbbc7a79d13da154dca9e393a204e9ae29
Resolves: #48539
Releases: 6.2
Reviewed-on: https://review.typo3.org/21049
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Link to not-existing folder results in fatal error 26/20926/2
Philipp Gampe [Fri, 5 Apr 2013 08:05:06 +0000 (10:05 +0200)]
[BUGFIX] Link to not-existing folder results in fatal error

If a folder is removed from the (default) local storage outside of
TYPO3 while still being linked inside a content element, a fatal error
is thrown.

Catch the fatal error and do not render the link.
Rendering the link text, but no link is the default normal behavior of
links in frontent.

Fixes: #48390
Releases: 6.2, 6.1, 6.0
Change-Id: I7ffbf2e055a3cb204dbe61e145ca54ee18b4982b
Reviewed-on: https://review.typo3.org/20926
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[BUGFIX] Catch FolderDoesNotExist Exception on links/images 70/20570/6
Alexander Opitz [Tue, 7 May 2013 08:25:06 +0000 (10:25 +0200)]
[BUGFIX] Catch FolderDoesNotExist Exception on links/images

If you have RTE content which have false links/images to files, we
get a FolderDoesNotExistException (FileDoesNotExistException in 6.0).
This should be catched.

Reproduce
* Create content element text
* In RTE change to text mode
* Add <img src="nofile" /> for image
or
* Add <a href="nowhere">link</a> for link
* save

Resolves: #46785
Releases: 6.2, 6.1, 6.0
Change-Id: I7b959825e8e36dc5b1941c9fa411afa321a594fb
Reviewed-on: https://review.typo3.org/20570
Reviewed-by: Simon Schick
Tested-by: Simon Schick
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[FEATURE] Improve livesearch results 92/20992/4
Philipp Kitzberger [Thu, 23 May 2013 09:32:49 +0000 (11:32 +0200)]
[FEATURE] Improve livesearch results

* uid and pid are displayed as tooltip in livesearch results
* returnUrl set so closing edit mask won't lead to dummy.php

Resolves: #35358
Releases: 6.2
Change-Id: I9c31cb547c9e9eb82f35a614d6977fca87f339d6
Reviewed-on: https://review.typo3.org/20992
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Raise submodule pointer 25/21025/2
TYPO3 Release Team [Fri, 24 May 2013 14:18:50 +0000 (16:18 +0200)]
[TASK] Raise submodule pointer

Change-Id: I27e54b3d481a30ec8526fc79ac2b2f0e3cf6a4eb
Reviewed-on: https://review.typo3.org/21025
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Disable restricted users to handle page records in pagetree 02/19802/4
Frank Frewer [Thu, 11 Apr 2013 17:53:39 +0000 (19:53 +0200)]
[BUGFIX] Disable restricted users to handle page records in pagetree

This patch hides the context menu entries 'disable'/'enable', 'edit',
'new', 'cut', 'copy', 'paste into', 'paste after' and 'delete' in
case an user is restricted to only non default languages.
Additionally it throws an error message if the user is trying to edit
a page title directly in the pagetree via double click.

Resolves: #47126
Releases: 6.2,6.1, 6.0, 4.7, 4.5
Change-Id: I13537529d4b72763c3a2ff5c75b5ae53a9e3fec1
Reviewed-on: https://review.typo3.org/19802
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Philipp Gampe
Reviewed-by: Alexander Opitz
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Paste button missing in empty folders 57/20857/4
Philipp Gampe [Fri, 17 May 2013 03:29:42 +0000 (05:29 +0200)]
[BUGFIX] Paste button missing in empty folders

Inside an empty folder is no obvious way to paste the content of the
clipboard.

Add a paste icon to the docheader to paste into the current folder.

Resolves: #48202
Releases: 6.2, 6.1, 6.0
Change-Id: I2192bd853a1c1fada332319812acee8fe821b78a
Reviewed-on: https://review.typo3.org/20857
Reviewed-by: Markus Klein
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[TASK] Rethink .txt files (GPL & Readme) 31/20931/2
Felix Kopp [Mon, 20 May 2013 13:13:28 +0000 (15:13 +0200)]
[TASK] Rethink .txt files (GPL & Readme)

Removes few outdated Readme files.

Also brings the well-formatted official GPL.txt from
http://www.gnu.org/licenses/gpl-2.0.txt

Change-Id: Ie059d19fd2424f8626bcd7f0e5c040736fa31377
Resolves: #48397
Releases: 6.2
Reviewed-on: https://review.typo3.org/20931
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
6 years ago[BUGFIX] TCA load regression in eid context 54/20554/4
Christian Kuhn [Mon, 6 May 2013 18:25:37 +0000 (20:25 +0200)]
[BUGFIX] TCA load regression in eid context

TCA refactoring in 6.1 misses an edge case:
Frontend index_ts loads TCA *after* eid is handled, so there is
no TCA loaded in eid context. Eid scripts that still need
TCA *should* call EidUtility::initTCA(), but some call instead
TSFE->includeTCA(). But includeTCA() is empty now and deprecated.

The patch adds a call to includeTCA() to load TCA, if
GLOBALS['TCA'] array is empty. This makes sure populating TCA
is done only once.

ext:caretaker_instance is affected by this, eg. test "Check
backend user accounts" needs TCA and fails without the patch.

Change-Id: Iaa70fe62e0eba9981e31379b853c968efe1d4cca
Resolves: #47993
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/20554
Reviewed-by: Markus Klein
Reviewed-by: Alexander Opitz
Reviewed-by: Stefan Neufeind
Tested-by: Alexander Opitz
Reviewed-by: Felix Kopp
Reviewed-by: Dmitry Dulepov
Tested-by: Markus Klein
6 years ago[TASK] Hide func menu with only one entry 72/20772/4
Georg Ringer [Sun, 19 May 2013 17:40:12 +0000 (19:40 +0200)]
[TASK] Hide func menu with only one entry

The func menu in a module is used to switch between different views in
the same module.

However if only one item is available, there is no reason to show the
function menu at all.
Also the onchange handler does not work as nothing is changeable.

Count the number of elements and suppress the selector if there is only
one item.

Change-Id: I6bbce41af19c8755c67c7ce5085f94930f4f87f6
Resolves: #48175
Releases: 6.2
Reviewed-on: https://review.typo3.org/20772
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] file_upload missing back icon 59/20859/2
Philipp Gampe [Fri, 17 May 2013 04:28:54 +0000 (06:28 +0200)]
[BUGFIX] file_upload missing back icon

Add a back button to:
 * file_upload
 * file_rename
 * file_newfolder

The code is taken from recordlist.

Resolves: #48065
Releases: 6.2, 6.1, 6.0
Change-Id: If328dd20f09875ab486fa3419ec5de9df8955956
Reviewed-on: https://review.typo3.org/20859
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
6 years ago[BUGFIX] EXT: setup — Increase Spacing 25/20925/2
Felix Kopp [Sun, 19 May 2013 22:24:56 +0000 (00:24 +0200)]
[BUGFIX] EXT: setup — Increase Spacing

User configure their personal TYPO3 backend in EXT: setup.
Here loads of options feel at home.

To lead users when searching for options space is essential.
This patch brings vertical spacing to the formular rows.

Change-Id: I622ed5050eee14e7a653b0e41203126ebe898bb1
Resolves: #48388
Releases: 6.2
Reviewed-on: https://review.typo3.org/20925
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Thomas Maroschik
Tested-by: Thomas Maroschik
Reviewed-by: Felix Kopp
Tested-by: Felix Kopp
6 years ago[TASK] Update phpdoc of pi_getPageLink/pi_linkToPage 56/20856/4
Stefan Neufeind [Thu, 16 May 2013 23:36:14 +0000 (01:36 +0200)]
[TASK] Update phpdoc of pi_getPageLink/pi_linkToPage

Calls methods in contentObjectRenderer and thus
should match that phpdoc over there (especially
giving a hint about what to urlencode and what not).

Resolves: #48316
Releases: 6.2
Change-Id: Id932763dc06ffaad09f169aff9ac9457d890a777
Reviewed-on: https://review.typo3.org/20856
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
6 years ago[BUGFIX] Fix last line in table wizard 55/20455/3
Alexander Opitz [Fri, 3 May 2013 08:36:03 +0000 (10:36 +0200)]
[BUGFIX] Fix last line in table wizard

In the table wizard (table ce) you have the possibility to move first line
to the last line and vice versa. But on last line the false icon and
input field is set. We also have a FIXME comment there.

With the patch we fix the problem and you can again move the last line on
top of the lines.

Resolves: #16531
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I7fe69397ba595a6b2aec8cdfba05b286f3b8ebe4
Reviewed-on: https://review.typo3.org/20455
Reviewed-by: Simon Schaufelberger
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[BUGFIX][CONF] Remove unused EM related settings 07/20807/2
Jigal van Hemert [Wed, 15 May 2013 19:55:21 +0000 (21:55 +0200)]
[BUGFIX][CONF] Remove unused EM related settings

The settings em_wsdlURL and em_mirrorListURL are not used anymore in
the Extension Manager and should be removed.

Change-Id: I70003ac547cb0cc9bfcf47bc90e174e280b30052
Resolves: #48179
Branches: 6.2, 6.1, 6.0
Reviewed-on: https://review.typo3.org/20807
Reviewed-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
6 years ago[BUGFIX] File list module headline 06/20906/3
Felix Kopp [Sun, 19 May 2013 10:28:29 +0000 (12:28 +0200)]
[BUGFIX] File list module headline

View should guide users and always prompt the current status.
File list has been lacking a main headline - until now.

Change-Id: Id3d2d1963bbedf917d2e8bc8f7756c10a026512e
Resolves: #48380
Releases: 6.2
Reviewed-on: https://review.typo3.org/20906
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] MailUtility::parseAddresses() returns @localhost on empty string 39/20839/4
Philipp Gampe [Thu, 16 May 2013 17:01:17 +0000 (19:01 +0200)]
[BUGFIX] MailUtility::parseAddresses() returns @localhost on empty string

parseAddresses should return an array of email addresses ready to be
feed into swiftmailer.
If an empty string is passed to the function, then it returns
"@localhost", which is not a valid email.
Swiftmailer will throw an exception "Address in mailbox given
[@localhost] does not comply with RFC 2822, 3.6.2."
This happens in ContentObjectRenderer->sendNotifyEmail() which is in
turn used by the frontend login forgotten passwort form.

Skip any addresses without a mailbox given.

Resolves: #48247
Releases: 6.2, 6.1
Change-Id: If8724416b3451417db7729dc81abdbd068dc8b10
Reviewed-on: https://review.typo3.org/20839
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[TASK] Move js files to EXT: backend 44/20644/3
Felix Kopp [Wed, 8 May 2013 16:32:26 +0000 (18:32 +0200)]
[TASK] Move js files to EXT: backend

The global js/ directory should be resolved. Moves several files
to EXT: backend that are only used in EXT: backend classes.

Change-Id: I79c80f60699750a5aff46ac554cb8d92c8a37236
Resolves: #48063
Releases: 6.2
Reviewed-on: https://review.typo3.org/20644
Reviewed-by: Thomas Maroschik
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Introduce Share font to backend for H1 54/20654/7
Felix Kopp [Thu, 16 May 2013 23:11:54 +0000 (01:11 +0200)]
[FEATURE] Introduce Share font to backend for H1

Brings the share web font to backend. Following TYPO3 styleguide
and typo3.org website. Share font is used for module headline only.

Change-Id: Id6f1ff9b7971dff7192928df68677b5a98485cb8
Resolves: #36017
Releases: 6.2
Reviewed-on: https://review.typo3.org/20654
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[FEATURE] Become spacious: increase spaces 94/20894/2
Felix Kopp [Sat, 18 May 2013 11:49:20 +0000 (13:49 +0200)]
[FEATURE] Become spacious: increase spaces

Backend had been dense for a long time. With larger screens come
more opportunities. Increases vertical and horizontal spaces.

On our way to a backend with less clutter and more space this
is the initial spark.

This patch follows the 12px backend grid raster.

Change-Id: I350a772ee2a52b8b5aed18dbdd44f340b9c17950
Resolves: #48376
Releases: 6.2
Reviewed-on: https://review.typo3.org/20894
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Select/deselect all in database analyzer doesn't work 97/20897/3
Wouter Wolters [Sat, 18 May 2013 12:25:08 +0000 (14:25 +0200)]
[BUGFIX] Select/deselect all in database analyzer doesn't work

Due to the introduction of jQuery in the Install Tool the
select/deselect is broken. Remove the inline onclick event and
put the new logic in install.js

Change-Id: I74602929c2097c111dbad0ef02743bd69ad2c189
Resolves: #48168
Releases: 6.2
Reviewed-on: https://review.typo3.org/20897
Reviewed-by: Philipp Gampe
Tested-by: Philipp Gampe
Reviewed-by: Francois Suter
Tested-by: Francois Suter
6 years ago[BUGFIX] be_users.userMods is too small to hold all modules 85/20885/3
Philipp Gampe [Fri, 17 May 2013 20:42:51 +0000 (22:42 +0200)]
[BUGFIX] be_users.userMods is too small to hold all modules

It is impossible to assign all modules to a single user, because the
DB field is too small.  Saving such a record will result in a DB error
and a truncated modules list.

Solution: Change to field from varchar(255) to text to support a larger
number of modules.

This change requires a DB compare to become active. The fix is simply
not present otherwise, but also don't affect existing installations in
any way.

Resolves: #16762
Releases: 6.2, 6.1, 6.0, 4.7, 4.5
Change-Id: I67b2ed6b650f9eaf5bdcc9ef81ce93cbbdc54b7f
Reviewed-on: https://review.typo3.org/20885
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
6 years ago[TASK] Remove mention of template.php
Wouter Wolters [Fri, 17 May 2013 17:54:19 +0000 (19:54 +0200)]
[TASK] Remove mention of template.php

template.php is removed from core. Rename this to
\TYPO3\CMS\Backend\Template\DocumentTemplate

Change-Id: Ie8378f4951abdfc825c1222861253228ae66e350
Resolves: #48372
Releases: 6.2
Reviewed-on: https://review.typo3.org/20883
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters