Packages/TYPO3.CMS.git
7 months ago[!!!][TASK] Drop PATH_thisScript constant 92/59392/10
Christian Kuhn [Wed, 9 Jan 2019 22:17:51 +0000 (23:17 +0100)]
[!!!][TASK] Drop PATH_thisScript constant

The patch removes the definition of constant PATH_thisScript.

* The main change in SystemEnvironmentBuilder splits method
definePaths() into two parts calculateScriptPath() and
calculateRootPath() since definePaths() formerly communicated
the script path using the PATH_thisScript constant to method
initializeEnvironment(), which has to fall now. Note
initializeEnvironment() is now protected, which is ok since
that usage was only internally for the testing framework which
is resolved now, too.

* A raise of the testing framework from 5.0.1 to 5.0.2 is needed.
It also defined that constant and triggered some different code
paths with this in SystemEnvironmentBuilder.
composer require --dev typo3/testing-framework ~5.0.2

* With the changes in SystemEnvironmentBuilder,
Environment::getCurrentScript() now returns '.../bin/phpunit' and
not '.../typo3/index.php' in unit tests, which is more correct. This
however has the side effect that various path related unit tests
need an adaption to properly set up the environment as needed.

Change-Id: I7d16c488a3039b3de689bb8b1b903d989d943c8d
Resolves: #87391
Releases: master
Reviewed-on: https://review.typo3.org/59392
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Remove unit tests that do not test the subject 97/59397/2
Christian Kuhn [Thu, 10 Jan 2019 11:27:55 +0000 (12:27 +0100)]
[TASK] Remove unit tests that do not test the subject

Some tests in FrontendLoginControllerTest test only
GeneralUtility::getIndpEnv(), but not the system under
test FrontendLoginController. Remove those.

Resolves: #87389
Releases: master
Change-Id: I3ea71c15ad8eda16750bfec1367ee4cc439dee2f
Reviewed-on: https://review.typo3.org/59397
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Remove unused variable in DataHandler 93/59393/2
Christian Kuhn [Wed, 9 Jan 2019 22:20:18 +0000 (23:20 +0100)]
[BUGFIX] Remove unused variable in DataHandler

Resolves: #87384
Related: #87294
Releases: master
Change-Id: If9cba4db4efc8f1c8e1be5c501450e1a18d87235
Reviewed-on: https://review.typo3.org/59393
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[TASK] Remove crop checkbox in TypoScript Object Browser 30/59130/9
Georg Ringer [Wed, 12 Dec 2018 23:14:42 +0000 (00:14 +0100)]
[TASK] Remove crop checkbox in TypoScript Object Browser

Simplfy the UI by removing the checkbox and do it with
CSS only

Resolves: #87141
Releases: master
Change-Id: I08488f5712148d87e2ce30c53f53fc35905392d9
Reviewed-on: https://review.typo3.org/59130
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Update copyright year in documentation to 2019 81/59381/3
Stefanos Karasavvidis [Wed, 9 Jan 2019 09:20:56 +0000 (11:20 +0200)]
[TASK] Update copyright year in documentation to 2019

Includes year change in Settings.cfg,  Index.rst files and also
README.md, INSTALL.md and SystemEnvironmentBuilder.php

Resolves: #87313
Releases: master, 9.5, 8.7
Change-Id: Ie056e9b7804af4003c2b67ee5e6d87ffd4eb96ba
Reviewed-on: https://review.typo3.org/59381
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated code from TYPO3\CMS\Info\Controller\TranslationStatusCo... 80/59380/2
Georg Ringer [Tue, 8 Jan 2019 20:21:31 +0000 (21:21 +0100)]
[!!!][TASK] Remove deprecated code from TYPO3\CMS\Info\Controller\TranslationStatusController

Resolves: #87374
Releases: master
Change-Id: I16e1f37d9bb402068d921cd7bbafd3716b264bfc
Reviewed-on: https://review.typo3.org/59380
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove t3ver_label database field 97/59297/6
Benni Mack [Tue, 25 Dec 2018 19:20:57 +0000 (20:20 +0100)]
[!!!][TASK] Remove t3ver_label database field

The versioning-related DB field "t3ver_label" has no special
use anymore in TYPO3 Core and Workspaces, as it was related
to static versioning and not workspace-workflows.

Resolves: #87294
Releases: master
Change-Id: I0573bc132c0151b437e557cf2c0f23c4a0d34352
Reviewed-on: https://review.typo3.org/59297
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Avoid fatal when flushed directory is a symlink 74/59374/3
Helmut Hummel [Tue, 8 Jan 2019 14:33:08 +0000 (15:33 +0100)]
[BUGFIX] Avoid fatal when flushed directory is a symlink

\TYPO3\CMS\Core\Utility\GeneralUtility::flushDirectory tries to
rename the given directory to be able to atomically flush the
contents of the directory. This however fails, when the given
folder is a symlink.

We now catch this case by checking whether the given directory
is a symlink and resolve it with realpath.

While this does not cover all possible cases, it improves the
case where the folder containing the symlink is also writable.

Resolves: #87367
Releases: master, 9.5, 8.7
Change-Id: Ic812a5eaa86cca4d81aee31b4a3fbdce052994a0
Reviewed-on: https://review.typo3.org/59374
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
7 months ago[TASK] Raise styleguide from 10.0.1 to 10.0.2 87/59387/2
Christian Kuhn [Wed, 9 Jan 2019 15:09:06 +0000 (16:09 +0100)]
[TASK] Raise styleguide from 10.0.1 to 10.0.2

Brings a patch that blocks a core patch due to a
deprecated field usage in styleguide.

composer require --dev typo3/cms-styleguide ~10.0.2

Resolves: #87381
Releases: master
Change-Id: Ic7e67b0ff5f0865bfdcff97d62a18b891bf959dc
Reviewed-on: https://review.typo3.org/59387
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[!!!][TASK] Remove TYPO3\CMS\Core\TypoScript\ConfigurationForm 78/59378/3
Georg Ringer [Tue, 8 Jan 2019 19:04:25 +0000 (20:04 +0100)]
[!!!][TASK] Remove TYPO3\CMS\Core\TypoScript\ConfigurationForm

Resolves: #87372
Releases: master
Change-Id: I53efcec5649e062062014d7c271a84ada7c14ecc
Reviewed-on: https://review.typo3.org/59378
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Move entry path existance check in SystemEnvironmentBuilder 86/59386/3
Christian Kuhn [Wed, 9 Jan 2019 13:41:30 +0000 (14:41 +0100)]
[TASK] Move entry path existance check in SystemEnvironmentBuilder

As a preparation to further path related clean ups, the
file existance check of the determined scriptPath must
only be checked if PATH_thisScript is not defined. This
is an edge case that was triggered with my patch for
issue #87247 and fixes unit tests for extensions with
current testing-framework.
Note this is not the final state and more patches to
handle the path mess will follow later.

Resolves: #87378
Related: #87247
Releases: master
Change-Id: I8e3d8524a5d40fe66bdfdbda92a2f18540d9a0d8
Reviewed-on: https://review.typo3.org/59386
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Install tool: Allow row updater as valid identifier 90/59290/2
Thorben Nissen [Sun, 23 Dec 2018 21:16:12 +0000 (22:16 +0100)]
[BUGFIX] Install tool: Allow row updater as valid identifier

In `UpgradeWizardService::assertIdentifierIsValid` check if the
identifier is a subclass of `RowUpdaterInterface` to avoid an exception
being thrown, when marking a row updater as undone.

Resolves: #87283
Releases: master, 9.5
Change-Id: I1b6a18437aa9d5a423c0a47595feac8b51c28bdb
Reviewed-on: https://review.typo3.org/59290
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[BUGFIX] Use `addOrderBy()` to support multiple orderings 56/59356/3
Andreas Fernandez [Mon, 7 Jan 2019 14:26:02 +0000 (15:26 +0100)]
[BUGFIX] Use `addOrderBy()` to support multiple orderings

`DatabaseRecordList::prepareQueryBuilder()` is able to handle multiple
order clauses defined in either `sortby` or `default_sortby`. However,
the wrong method for appending the order clause is used, which results in
overriding the previous set clause.

This patch changes the method to use `addOrderBy()` instead which appends
multiple order clauses properly.

Resolves: #87352
Releases: master, 9.5
Change-Id: I08f4248d4dc890079715efb9a48b1d270a6b1077
Reviewed-on: https://review.typo3.org/59356
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: featdd <dorndorf@featdd.de>
Tested-by: featdd <dorndorf@featdd.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated code from EXT:recordlist 57/59357/6
Andreas Fernandez [Mon, 7 Jan 2019 15:06:07 +0000 (16:06 +0100)]
[!!!][TASK] Remove deprecated code from EXT:recordlist

Resolves: #87354
Related: #87193
Releases: master
Change-Id: Ib1ccf6fdb7c69257716665c58e75b2295dc5f0b1
Reviewed-on: https://review.typo3.org/59357
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[BUGFIX] Add also the "/" slash to ROUTE_PATH_DELIMITERS array 23/59123/5
Ralf Merz [Wed, 12 Dec 2018 16:43:14 +0000 (17:43 +0100)]
[BUGFIX] Add also the "/" slash to ROUTE_PATH_DELIMITERS array

This is needed so that the PageType routeEnhancer is able to build URL
with a single trailing slash.
In other words, this fixes that a double trailing slash was created.

The functional test pageTypeDecoratorIsApplied gets extended with 2
instruction scenarios to set routeEnhancer PageTypeDecorator to
have a trailing slash instead of .html suffix tested, too.

Resolves: #86557
Releases: master, 9.5
Change-Id: If03bad8f054dc659f8870a98e064d9869597e8ba
Reviewed-on: https://review.typo3.org/59123
Reviewed-by: Michael Giek <michael.giek@web.de>
Tested-by: Michael Giek <michael.giek@web.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[BUGFIX] Replace removed alias for ViewHelperNode 71/59371/3
Stefanos Karasavvidis [Tue, 8 Jan 2019 09:07:39 +0000 (11:07 +0200)]
[BUGFIX] Replace removed alias for ViewHelperNode

Replaces the removed class alias
TYPO3\CMS\Fluid\Core\Parser\SyntaxTree\ViewHelperNode.

Resolves: #87362
Releases: master, 9.5
Change-Id: I21a3c35a0ce1b8cd7bf9de839dcc3e4bdba05bbb
Reviewed-on: https://review.typo3.org/59371
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Tested-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Set pageId in WorkspacePreview in InlineSettings 98/58998/4
Devid Messner [Fri, 30 Nov 2018 11:16:44 +0000 (12:16 +0100)]
[BUGFIX] Set pageId in WorkspacePreview in InlineSettings

The page ID is necessary for publishing and changing the stage.
Otherwise, the entire workspace is always published.

Resolves: #87047
Releases: master, 9.5
Change-Id: I4154810e79d776d41315d2d7029352fa86eff5d0
Reviewed-on: https://review.typo3.org/58998
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Tested-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove deprecated code from TableController 68/59368/3
Georg Ringer [Mon, 7 Jan 2019 20:47:57 +0000 (21:47 +0100)]
[!!!][TASK] Remove deprecated code from TableController

Resolves: #87360
Releases: master
Change-Id: Iaac2d1242fdc9d9fe71500f816096753266c40a5
Reviewed-on: https://review.typo3.org/59368
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[!!!][TASK] Remove deprecated code from DocumentTemplate 69/59369/2
Georg Ringer [Mon, 7 Jan 2019 21:00:28 +0000 (22:00 +0100)]
[!!!][TASK] Remove deprecated code from DocumentTemplate

Resolves: #87361
Releases: master
Change-Id: I21ff5db9c8f2faf303e93a0c897aa44f20f663b4
Reviewed-on: https://review.typo3.org/59369
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[!!!][TASK] Remove leftover deprecated hooks 64/59364/5
Benni Mack [Mon, 7 Jan 2019 20:14:34 +0000 (21:14 +0100)]
[!!!][TASK] Remove leftover deprecated hooks

Due to testing framework refactoring, the 2 leftover hooks
in Frontend middlewares can now be removed:

$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['initFEuser']
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['postBeUser']

Thus, Frontend Middleware stack is now free of hooks.

Resolves: #87357
Releases: master
Change-Id: I076d9f4aa556f4ba111196449eee6449ba8036db
Reviewed-on: https://review.typo3.org/59364
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Activate link on numbers in filelist pagination 25/59325/3
Guido Schmechel [Thu, 3 Jan 2019 22:04:03 +0000 (23:04 +0100)]
[TASK] Activate link on numbers in filelist pagination

Because it is hard to hit only the arrow, now the numbers
in the filelist pagination are linked as well.

Resolves: #87317
Releases: master, 9.5
Change-Id: If8a00d603b0b0f474b7e23814ed0d075fa217a52
Reviewed-on: https://review.typo3.org/59325
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Tested-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[TASK] Raise typo3/testing-framework to ~5.0.1 63/59363/3
Christian Kuhn [Mon, 7 Jan 2019 19:51:32 +0000 (20:51 +0100)]
[TASK] Raise typo3/testing-framework to ~5.0.1

The new version no longer uses two deprecated frontend
hooks and switches to proper psr-15 middleware instead.
This unlocks the according hook removal for core in
a separate patch.

composer require --dev typo3/testing-framework ~5.0.1

Change-Id: Ia30704174d975df6a253b0bac66e037b5dc4987d
Resolves: #87358
Reviewed-on: https://review.typo3.org/59363
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[!!!][TASK] Remove database field pages.alias 32/59232/7
Benni Mack [Thu, 20 Dec 2018 08:46:12 +0000 (09:46 +0100)]
[!!!][TASK] Remove database field pages.alias

This is a precursor for removing PseudoSiteHandling in general.

The database field "pages.alias" field is dropped, along with
the functionality to evalute if a frontend request "?id=acme"
is non-integer, as it now always has to be integer.

Existing links pointing to page aliases will stop working.

Resolves: #87356
Releases: master
Change-Id: I19134cc788e633e140b43497f716082ac96744e5
Reviewed-on: https://review.typo3.org/59232
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[FEATURE] Add scheduler information to system information toolbar 09/57609/19
Josef Glatz [Mon, 16 Jul 2018 09:21:43 +0000 (11:21 +0200)]
[FEATURE] Add scheduler information to system information toolbar

The system information toolbar now shows useful information
about the (automatic) execution/configuration of the TYPO3
scheduler if the system extension is activated and if there
are any tasks configured at all.

- Show a warning when the scheduler execution seems not
  to be configured correctly
- Show start date, start time, duration and execution type
  of the last sucessfully executed scheduler run
  - Highlight information if it was started manually

Releases: master
Resolves: #85569
Change-Id: Ic1b8a1c52678b60d40edcb77296f51f58ec01a4b
Reviewed-on: https://review.typo3.org/57609
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Tested-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated code in DataHandler 30/59330/3
Benni Mack [Fri, 4 Jan 2019 19:21:12 +0000 (20:21 +0100)]
[!!!][TASK] Remove deprecated code in DataHandler

The following methods / properties / TSconfig options are removed:

- DataHandler->updateModeL10NdiffData
- DataHandler->updateModeL10NdiffDataClear

- DataHandler->resorting()
- DataHandler->getTCEMAIN_TSconfig()
- DataHandler->newlog2()

- options.clearCache.system

Resolves: #87346
Releases: master
Change-Id: I0c21020528aef515f40067e2ee97fee8f78ca27c
Reviewed-on: https://review.typo3.org/59330
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[BUGFIX] Use correct language fallback settings in functional tests 52/59352/3
Oliver Hader [Mon, 7 Jan 2019 07:56:27 +0000 (08:56 +0100)]
[BUGFIX] Use correct language fallback settings in functional tests

Site configuration generators in functional tests produced wrong data
concerning language fallbacks. Since there have not been any test cases
making use of this particular feature, no tests had to be adjusted.

Resolves: #87344
Releases: master, 9.5
Change-Id: I66707bffc4ba1edce9de304fed897724b99ab81b
Reviewed-on: https://review.typo3.org/59352
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Remove fuzzy extension scanner checks 53/59353/2
Benni Mack [Mon, 7 Jan 2019 08:29:21 +0000 (09:29 +0100)]
[TASK] Remove fuzzy extension scanner checks

The recently introduced addition to the
ExtensionScanner files for
GraphicalFunctions->init() is removed
as there are too many false positives
due to a badly named method name (init).

The check is removed again.

Related: #87342
Resolves: #87345
Releases: master
Change-Id: Iab775eed9a760cf3d5129476d69ccf9d561b47bf
Reviewed-on: https://review.typo3.org/59353
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Tested-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[FEATURE] Support feature toggle in expression language 79/58879/6
Frank Naegler [Wed, 7 Nov 2018 22:00:23 +0000 (23:00 +0100)]
[FEATURE] Support feature toggle in expression language

Change-Id: I018b19b2fc0962b45d052a7ae4a56396f002361c
Resolves: #86881
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/58879
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove deprecated function `launchView()` 51/59351/2
Andreas Fernandez [Mon, 7 Jan 2019 07:40:43 +0000 (08:40 +0100)]
[!!!][TASK] Remove deprecated function `launchView()`

Resolves: #87343
Related: #87193
Releases: master
Change-Id: Ia93afa94cd510debc0a37930f1dbf761d7d23267
Reviewed-on: https://review.typo3.org/59351
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[!!!][TASK] Remove deprecated code in EXT:core 35/59335/3
Benni Mack [Fri, 4 Jan 2019 20:17:58 +0000 (21:17 +0100)]
[!!!][TASK] Remove deprecated code in EXT:core

The fallback in site configuration (during 9.3 and 9.4)
with all configuration within the subproperty
"site" is now removed.

- GraphicalFunctions->init()
- AbstractHierarchicalFilesystemDriver()->getCharsetConversion()
- FAL: FileExtensionFilter + Indexer - file extension + mimetype guessing
- ResourceStorage->dumpFileContents()
- AbstractService->devLog()

Resolves: #87342
Releases: master
Change-Id: I107544a129272ebace234e4e7e3ead0ff05a2e5c
Reviewed-on: https://review.typo3.org/59335
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated `TYPO3.Popover` object 47/59347/7
Andreas Fernandez [Sun, 6 Jan 2019 14:05:33 +0000 (15:05 +0100)]
[!!!][TASK] Remove deprecated `TYPO3.Popover` object

The global JavaScript object `TYPO3.Popover` has been removed.

Resolves: #87338
Related: #87193
Releases: master
Change-Id: I810711a01edd4d43820d714200a871271d4136b0
Reviewed-on: https://review.typo3.org/59347
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated `TYPO3.Utility` object 48/59348/4
Andreas Fernandez [Sun, 6 Jan 2019 14:15:43 +0000 (15:15 +0100)]
[!!!][TASK] Remove deprecated `TYPO3.Utility` object

The global JavaScript object `TYPO3.Utility` has been removed.

Resolves: #87339
Releases: master
Change-Id: I50a6cd465aa914780c825152b7172df9b92173f3
Reviewed-on: https://review.typo3.org/59348
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated code from EXT:install 95/59295/4
Wouter Wolters [Tue, 25 Dec 2018 12:08:21 +0000 (13:08 +0100)]
[!!!][TASK] Remove deprecated code from EXT:install

Resolves: #87292
Releases: master
Change-Id: I4ea3a115273e9b83fc7eabf0cd87440df05b0f86
Reviewed-on: https://review.typo3.org/59295
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated `TYPO3/CMS/Backend/Storage` 49/59349/2
Andreas Fernandez [Sun, 6 Jan 2019 14:26:08 +0000 (15:26 +0100)]
[!!!][TASK] Remove deprecated `TYPO3/CMS/Backend/Storage`

Resolves: #87340
Related: #87193
Releases: master
Change-Id: I2f41008e0e3827c52f5d5351a53898bd22f3748d
Reviewed-on: https://review.typo3.org/59349
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated code from RteHtmlParser 42/59342/3
Christian Kuhn [Sat, 5 Jan 2019 16:15:16 +0000 (17:15 +0100)]
[!!!][TASK] Remove deprecated code from RteHtmlParser

Resolves: #87336
Releases: master
Change-Id: I7835c2e328aac7bc154b9460abaec56a29fe8216
Reviewed-on: https://review.typo3.org/59342
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Show tooltips in the recordlist 36/59336/2
Guido Schmechel [Sat, 5 Jan 2019 07:52:29 +0000 (08:52 +0100)]
[BUGFIX] Show tooltips in the recordlist

If a recordlist title do not need to be converted for
output, then the original title will be taken for the
tooltip and added to a span tag.

Resolves: #87326
Releases: master, 9.5
Change-Id: I58fbf9ceadf191eaafc5430ce4d09adeb27c789f
Reviewed-on: https://review.typo3.org/59336
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[!!!][TASK] Drop core 6->7 auto TCA migrations 41/59341/3
Christian Kuhn [Sat, 5 Jan 2019 15:07:29 +0000 (16:07 +0100)]
[!!!][TASK] Drop core 6->7 auto TCA migrations

The TcaMigration class to auto migrate existing TCA
to new specs before it is cached has been added with
core v7.
The patch now finally removes all migrations that
changed core v6 compatible TCA to core v7 compatible
TCA.

Resolves: #87335
Releases: master
Change-Id: Ie5734d4c0bcee83ce74591d6de39a50c12d4386a
Reviewed-on: https://review.typo3.org/59341
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[!!!][TASK] Remove deprecated functionality in RootlineUtility 32/59332/2
Benni Mack [Fri, 4 Jan 2019 19:36:20 +0000 (20:36 +0100)]
[!!!][TASK] Remove deprecated functionality in RootlineUtility

The constructor does not allow PageRepository anymore, but the new
Context object only (or null, as it is an optional argument).

Resolves: #87331
Releases: master
Change-Id: I4d103aee03b1b30ceab6f033ccc58b1af0626157
Reviewed-on: https://review.typo3.org/59332
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[TASK] Stop dangling containers in bamboo 38/59338/2
Christian Kuhn [Sat, 5 Jan 2019 13:51:43 +0000 (14:51 +0100)]
[TASK] Stop dangling containers in bamboo

In rare conditions a bamboo agent does not stop all
created sibling containers at the end of a job. These
dangling containers then make consecutive runs on this
agents fail due to container namespace collisions.
As a self-heal mechanism, all jobs that fiddle with
containers now simply stop any possibly dangling containers
as an early task before starting own ones.

Resolves: #87334
Releases: master, 9.5, 8.7
Change-Id: I80332da8f9b1013dc8d961e7e532faf59b3bd3b8
Reviewed-on: https://review.typo3.org/59338
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months agoRevert "[TASK] Remove COMPOSER_ROOT_VERSION from bamboo testing" 37/59337/2
Christian Kuhn [Sat, 5 Jan 2019 13:13:10 +0000 (14:13 +0100)]
Revert "[TASK] Remove COMPOSER_ROOT_VERSION from bamboo testing"

This reverts commit 4036d2ecf3c5cfc24fa4f0408633eac6fec72515.

The solution does not work out for not yet released
major versions like 10.*.

Reverts: #87170
Resolves: #87170
Releases: master
Change-Id: Ibb827acc97e48e5e44e4b8aec77501517afc762e
Reviewed-on: https://review.typo3.org/59337
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated functionality within PageRenderer 10/59310/5
Benni Mack [Sun, 30 Dec 2018 19:25:41 +0000 (20:25 +0100)]
[!!!][TASK] Remove deprecated functionality within PageRenderer

Various jQuery and MetaTag API related methods within
PageRenderer have been removed.

Resolves: #87310
Releases: master
Change-Id: I309718b6576aca8ba6a5323d16f9395a752a0b0d
Reviewed-on: https://review.typo3.org/59310
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Invalidate cached PageTitleProvider 65/59265/3
Guido Schmechel [Sat, 22 Dec 2018 11:26:14 +0000 (12:26 +0100)]
[BUGFIX] Invalidate cached PageTitleProvider

After handling/saving a page the cache entry for pageTitle
is removed, too.

Resolves: #87257
Releases: master, 9.5
Change-Id: I5aac5563d49100ef1f82e6bbe22dad05969b6fdf
Reviewed-on: https://review.typo3.org/59265
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: JarvisH <jekorma+mytypo3@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated code in ExtensionManagementUtility 11/59311/3
Benni Mack [Sun, 30 Dec 2018 19:38:27 +0000 (20:38 +0100)]
[!!!][TASK] Remove deprecated code in ExtensionManagementUtility

Various methods within ExtensionManagementUtility that was
previously deprecated have been removed.

Resolves: #87311
Releases: master
Change-Id: I38e557f46492cc2b3c14f97882266efa673d7349
Reviewed-on: https://review.typo3.org/59311
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove legacy pages_language_overlay functionality 96/59296/8
Benni Mack [Tue, 25 Dec 2018 19:09:24 +0000 (20:09 +0100)]
[!!!][TASK] Remove legacy pages_language_overlay functionality

This patch removes any occurrences of "pages_language_overlay" in use
and enables the feature "unifiedPageTranslationHandling", which
removes any SQL CREATE/ALTER statements related to "pages_language_overlay".

TCA for table "pages_language_overlay" is kept for the time being to have
"MigratePagesLanguageOverlayUpdate" still working.

Resolves: #87293
Releases: master
Change-Id: I94514f30696dcbc2ad3ae8900a6a25b41d2a7bd9
Reviewed-on: https://review.typo3.org/59296
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated code from EXT:filelist 09/59309/2
Wouter Wolters [Sun, 30 Dec 2018 14:54:47 +0000 (15:54 +0100)]
[!!!][TASK] Remove deprecated code from EXT:filelist

Resolves: #87309
Releases: master
Change-Id: I0397d3cab0f5957482553640180bfebc0a36ea15
Reviewed-on: https://review.typo3.org/59309
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[BUGFIX] Show correct extension name in redirects update 94/59294/3
Benjamin Kott [Tue, 25 Dec 2018 12:07:55 +0000 (13:07 +0100)]
[BUGFIX] Show correct extension name in redirects update

Releases: master, 9.5
Resolves: #87291
Change-Id: I3125b7040c4d4fdba34969f573d26444a056ff9e
Reviewed-on: https://review.typo3.org/59294
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[BUGFIX] Allow to add type=0 to typolink syntax 99/59299/2
Benni Mack [Wed, 26 Dec 2018 23:21:34 +0000 (00:21 +0100)]
[BUGFIX] Allow to add type=0 to typolink syntax

In previous versions, it was possible to link
to type=0 via "4,0,&param=2" where this was
stripped away, as the old syntax with the third
parameter was not supported anymore.

The patch changes the "empty()" to "isset()"
and explicitly sets the type parameter again.

Resolves: #81226
Releases: master, 9.5, 8.7
Change-Id: I5d19c38c90571f6686e7121dac638342783237ec
Reviewed-on: https://review.typo3.org/59299
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated code from EXT:linkvalidator 93/59293/4
Wouter Wolters [Tue, 25 Dec 2018 11:31:07 +0000 (12:31 +0100)]
[!!!][TASK] Remove deprecated code from EXT:linkvalidator

Resolves: #87290
Releases: master
Change-Id: Ie3496ac4ac47eb220d4ea924a2792fa3b31e7564
Reviewed-on: https://review.typo3.org/59293
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated code from EXT:indexed_search 07/59307/3
Wouter Wolters [Sun, 30 Dec 2018 14:11:42 +0000 (15:11 +0100)]
[!!!][TASK] Remove deprecated code from EXT:indexed_search

Resolves: #87308
Releases: master
Change-Id: I02a1d3ef914a9618a91f70a6c3a53d5e3bfe9f79
Reviewed-on: https://review.typo3.org/59307
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Remove unused CMD property from SchedulerModuleController 06/59306/2
Wouter Wolters [Sun, 30 Dec 2018 13:42:18 +0000 (14:42 +0100)]
[TASK] Remove unused CMD property from SchedulerModuleController

Property was forgotten during the deprecation cleanup in EXT:scheduler

Resolves: #87307
Releases: master
Change-Id: I72d98a75fccb154b81b72ba447f8be979d493fc4
Reviewed-on: https://review.typo3.org/59306
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[FEATURE] Make SiteLanguage available in TypoScript 30/58930/11
Georg Ringer [Thu, 22 Nov 2018 07:46:21 +0000 (08:46 +0100)]
[FEATURE] Make SiteLanguage available in TypoScript

The current language configuration should be available in TS as well.

Resolves: #86973
Releases: master, 9.5
Change-Id: Iae71b550b3d000b12b4e127fee751740c3a36bf7
Reviewed-on: https://review.typo3.org/58930
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
7 months ago[TASK] Fix sentence in indexed_search documentation 98/59298/4
Franz Holzinger [Wed, 26 Dec 2018 15:10:21 +0000 (16:10 +0100)]
[TASK] Fix sentence in indexed_search documentation

Releases: master, 9.5
Resolves: #87297
Change-Id: I89d13028f36c867e79c6e2a35576135ea9ca919c
Reviewed-on: https://review.typo3.org/59298
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated TMENU options 91/59291/2
Benni Mack [Mon, 24 Dec 2018 18:52:33 +0000 (19:52 +0100)]
[!!!][TASK] Remove deprecated TMENU options

The TMENU options beforeImg and afterImg have been removed as
well, as part of removal of image generation being part of the
menu generation.

Resolves: #87287
Releases: master
Change-Id: I81134ccf3c8af9368ff0521e7b136d457333903e
Reviewed-on: https://review.typo3.org/59291
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated code from EXT:rsaauth 92/59292/3
Wouter Wolters [Tue, 25 Dec 2018 10:54:08 +0000 (11:54 +0100)]
[!!!][TASK] Remove deprecated code from EXT:rsaauth

Resolves: #87289
Releases: master
Change-Id: I398622277b024b447ea4087e3a1af1b23b9026bc
Reviewed-on: https://review.typo3.org/59292
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated code from EXT:scheduler 86/59286/2
Wouter Wolters [Sun, 23 Dec 2018 14:16:05 +0000 (15:16 +0100)]
[!!!][TASK] Remove deprecated code from EXT:scheduler

Resolves: #87282
Releases: master
Change-Id: I579463d5b1e5780e0f4bcf5665a3e57500f6bbeb
Reviewed-on: https://review.typo3.org/59286
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Streamline tree markup 85/59285/3
Andreas Fernandez [Sun, 23 Dec 2018 08:29:30 +0000 (09:29 +0100)]
[BUGFIX] Streamline tree markup

The trees used in TSOB and in the configuration module have a different
markup than the tree of the Link Browser (and the rest), causing the
regression introduced with #86790. The markup of the trees is now changed
to have a consistent structure.

Resolves: #87280
Related: #86790
Releases: master, 9.5, 8.7
Change-Id: I00c6b93c760a725e1ee771651f26c53573e0a6e2
Reviewed-on: https://review.typo3.org/59285
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
7 months ago[!!!][TASK] Remove deprecated code in EditFileController 82/59282/3
Anja Leichsenring [Sat, 22 Dec 2018 17:18:01 +0000 (18:18 +0100)]
[!!!][TASK] Remove deprecated code in EditFileController

Change-Id: I82b07824a592206110ff0f07dc97488dc5ce5c80
Resolves: #87278
Releases: master
Reviewed-on: https://review.typo3.org/59282
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[!!!][TASK] Remove deprecated IMGMENU and GMENU 80/59280/4
Christian Kuhn [Sat, 22 Dec 2018 16:29:38 +0000 (17:29 +0100)]
[!!!][TASK] Remove deprecated IMGMENU and GMENU

Change-Id: Ie2ee4ea69ff3cdc67155d292bfd3fccbe1d7ad09
Resolves: #87279
Releases: master
Reviewed-on: https://review.typo3.org/59280
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[TASK] Add missing class aliases to extension scanner 78/59278/6
Anja Leichsenring [Sat, 22 Dec 2018 15:49:53 +0000 (16:49 +0100)]
[TASK] Add missing class aliases to extension scanner

Class aliases have been removed, leading to fatal php errors
for class not found. These class names can be scanned, so
adding them to the class name matcher configuration will ease
the update for users.

Change-Id: I589b2d222724cd77d3e3163104240b5dccb3da66
Resolves: #87277
Relates: #87230
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/59278
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove sys_domain and LegacyDomains 33/59233/6
Benni Mack [Thu, 20 Dec 2018 09:26:41 +0000 (10:26 +0100)]
[!!!][TASK] Remove sys_domain and LegacyDomains

Removes the legary sys_domain table and handling.

Resolves: #87276
Releases: master
Change-Id: If2a5eeb1ebcc113c8b00162f4c02ea3a58edcefe
Reviewed-on: https://review.typo3.org/59233
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove Extbase mode for non-consistentTranslationOverlayHandling 55/59255/7
Benni Mack [Fri, 21 Dec 2018 11:54:10 +0000 (12:54 +0100)]
[!!!][TASK] Remove Extbase mode for non-consistentTranslationOverlayHandling

The feature flag and all its logic for not using the
consistentTranslationOverlayHandling in Extbase has been removed.

Along with that, QuerySettings interface has two methods less to implement:
- setLanguageMode()
- getLanguageMode()

The methods are kept within the implementation in Typo3QuerySettings without
any actions for now.

Resolves: #87264
Releases: master
Change-Id: Id4f46c8ff61ec86697d8b9dcbe6cd489b2782c0d
Reviewed-on: https://review.typo3.org/59255
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Remove deprecated code in ElementInformationController 77/59277/4
Anja Leichsenring [Sat, 22 Dec 2018 14:51:46 +0000 (15:51 +0100)]
[TASK] Remove deprecated code in ElementInformationController

Change-Id: I5511af7dac4de54ff01f3a1f1ba9c0fb83697ac0
Resolves: #87272
Releases: master
Reviewed-on: https://review.typo3.org/59277
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Avoid case mismatches in method calls 76/59276/3
Alexander Schnitzler [Sat, 22 Dec 2018 14:31:58 +0000 (15:31 +0100)]
[TASK] Avoid case mismatches in method calls

Releases: master
Resolves: #87273
Change-Id: I903d15be35772d9e18be93f65a8ec371837c3aec
Reviewed-on: https://review.typo3.org/59276
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated code from PageLayoutController 74/59274/3
Christian Kuhn [Sat, 22 Dec 2018 13:28:54 +0000 (14:28 +0100)]
[!!!][TASK] Remove deprecated code from PageLayoutController

Resolves: #87270
Releases: master
Change-Id: Ib6016927dbc79f83d4e0f0b57f8e01bc88ddb963
Reviewed-on: https://review.typo3.org/59274
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Minor code cleanups 69/59269/2
Christian Kuhn [Sat, 22 Dec 2018 12:20:04 +0000 (13:20 +0100)]
[BUGFIX] Minor code cleanups

A small series of minor cleanups:
* Setting a no longer existing property
* Slight variable type improvements
* Unused variable assignment

Resolves: #87267
Releases: master
Change-Id: I07c43b31b8fb2d8bacd80dc023595860fa77abf4
Reviewed-on: https://review.typo3.org/59269
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated Extbase-related code (Part 3) 73/59273/3
Alexander Schnitzler [Sat, 22 Dec 2018 13:10:18 +0000 (14:10 +0100)]
[!!!][TASK] Remove deprecated Extbase-related code (Part 3)

* public static method in ActionController
* public method in Argument
* public method in Arguments
* class AbstractValidatorTestcase
* legacy location of settings.view.formatToPageTypeMapping

Releases: master
Resolves: #87268
Change-Id: Ieacc247e2ee85b088c01ae9d6d79691df319b333
Reviewed-on: https://review.typo3.org/59273
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Remove registered legacy extbase annoations 47/59247/5
Alexander Schnitzler [Thu, 20 Dec 2018 20:20:46 +0000 (21:20 +0100)]
[TASK] Remove registered legacy extbase annoations

The following registered annotations are no longer supported.
Therefore they should no longer be registered.

* inject
* transient
* lazy
* validate
* cascade
* cli
* flushesCaches
* uuid
* identity

Releases: master
Resolves: #87272
Change-Id: I3d018ce39cc33e4ab55f966083ef2d6112570ebc
Reviewed-on: https://review.typo3.org/59247
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Remove invalid NoSuchCommandException 68/59268/2
Christian Kuhn [Sat, 22 Dec 2018 12:15:21 +0000 (13:15 +0100)]
[BUGFIX] Remove invalid NoSuchCommandException

The NoSuchCommandExceptions has been forgotton
to be removed along with the CommandException
it extends from. It is unused and can be dropped.

Resolves: #87266
Related: #85977
Related: #87246
Releases: master
Change-Id: Ie83695be3f688ad0e52a4fd54918df2b167f6560
Reviewed-on: https://review.typo3.org/59268
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Replace @ignorevalidation with @Extbase\IgnoreValidation 67/59267/3
Alexander Schnitzler [Sat, 22 Dec 2018 12:06:36 +0000 (13:06 +0100)]
[BUGFIX] Replace @ignorevalidation with @Extbase\IgnoreValidation

While dropping support for @ignorevalidation in #86901
(https://review.typo3.org/58886/) some usages of @ignorevalidation
had not been replaced.

Releases: master
Resolves: #87255
Change-Id: I9067dcb8b376da184b8f1f5a6694062edc3e0e71
Reviewed-on: https://review.typo3.org/59267
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Add PATH_site to extension scanner 66/59266/3
Christian Kuhn [Sat, 22 Dec 2018 11:52:00 +0000 (12:52 +0100)]
[BUGFIX] Add PATH_site to extension scanner

When deprecating PATH_site constants we missed
an entry in the extension scanner. Let's add that
matcher since the constant is rather frequently
used in extensions and deserves a match.

Resolves: #87265
Related: #85285
Releases: master, 9.5
Change-Id: I4b2c6cba062ba54a16256fbe8f8ffc2550cfd312
Reviewed-on: https://review.typo3.org/59266
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[BUGFIX] Avoid frameborder attribute if no doctype is set 17/59117/2
Georg Ringer [Tue, 11 Dec 2018 12:56:05 +0000 (13:56 +0100)]
[BUGFIX] Avoid frameborder attribute if no doctype is set

The YouTube and Vimeo renderer must also check if the doctype is not set as html5 is
the default value.

Resolve: #87114
Releases: master, 9.5
Change-Id: I0eab8e6da67ca1c073847a1a4c6203f97778c4df
Reviewed-on: https://review.typo3.org/59117
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove deprecated code from EXT:taskcenter 46/59246/4
Wouter Wolters [Thu, 20 Dec 2018 20:04:03 +0000 (21:04 +0100)]
[!!!][TASK] Remove deprecated code from EXT:taskcenter

Resolves: #87249
Releases: master
Change-Id: Ibffaf40318977a069c1835439adc93e1bd3616ae
Reviewed-on: https://review.typo3.org/59246
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Show domains from Site configs in redirect picker 56/59256/5
Benni Mack [Fri, 21 Dec 2018 13:00:28 +0000 (14:00 +0100)]
[BUGFIX] Show domains from Site configs in redirect picker

The FormEngine sys_redirect value picker for "host" was built on
top of sys_domain, however the value picker should
include domains (hosts) from site configurations
as well.

Resolves: #87258
Releases: master, 9.5
Change-Id: I74bf5a8ce3bf91065b68269d6481eb89286585fa
Reviewed-on: https://review.typo3.org/59256
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[BUGFIX] Fix double namespace in test class 60/59260/3
Benni Mack [Fri, 21 Dec 2018 21:45:20 +0000 (22:45 +0100)]
[BUGFIX] Fix double namespace in test class

A wrong PHP namespace is used in a UnitDeprecated PHP test class.

The patch changes the path to the correct one.

Resolves: #87263
Releases: master, 9.5
Change-Id: Iadfc83cb00195b528264ac5f8e10a106be94847d
Reviewed-on: https://review.typo3.org/59260
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove deprecated code from various controllers 52/59252/4
Christian Kuhn [Thu, 20 Dec 2018 22:07:25 +0000 (23:07 +0100)]
[!!!][TASK] Remove deprecated code from various controllers

Drop deprecated properties and methods from various
backend controllers.

Resolves: #87253
Releases: master
Change-Id: I7a4bf179bffbdce4843cabf0efaa08a7a813808b
Reviewed-on: https://review.typo3.org/59252
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated core authentication related code 45/59245/3
Christian Kuhn [Thu, 20 Dec 2018 19:30:55 +0000 (20:30 +0100)]
[!!!][TASK] Remove deprecated core authentication related code

Mostly removes code related to core authentication
classes.

Resolves: #87248
Releases: master
Change-Id: I711e1fae63fecabd1b1a51854698319112db2824
Reviewed-on: https://review.typo3.org/59245
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove deprecated Extbase-related code (Part 2) 49/59249/6
Alexander Schnitzler [Thu, 20 Dec 2018 21:18:11 +0000 (22:18 +0100)]
[!!!][TASK] Remove deprecated Extbase-related code (Part 2)

* public methods in ClassSchema
* public methods in ReflectionService
* public methods in ValidatorResolver
* public constants in ValidatorResolver
* class RawValidator

Releases: master
Resolves: #87254
Change-Id: I3523e56cfab25fb147e8ce07c143aad9a6e8a549
Reviewed-on: https://review.typo3.org/59249
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Exclude logger from serialize on save for scheduler task 37/59237/4
Joerg Boesche [Thu, 20 Dec 2018 10:57:32 +0000 (11:57 +0100)]
[BUGFIX] Exclude logger from serialize on save for scheduler task

Exclusion of the logger instance from the record during save to database.
Prevent hard-coded logfile paths in database record.
Set the logger at runtime if the task is executed.

Resolves: #86785
Releases: master, 9.5
Change-Id: I30cf258042a2ca6ec3e79a52dcf3a3849cfbe77d
Reviewed-on: https://review.typo3.org/59237
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Chris Müller <typo3@krue.ml>
Tested-by: Chris Müller <typo3@krue.ml>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove deprecated code from EXT:setup 48/59248/2
Wouter Wolters [Thu, 20 Dec 2018 20:36:50 +0000 (21:36 +0100)]
[!!!][TASK] Remove deprecated code from EXT:setup

Resolves: #87250
Releases: master
Change-Id: I72b85074e4e9b31f3bb72391f035d4aae8932d41
Reviewed-on: https://review.typo3.org/59248
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Drop evaluation of @validate annotations 80/58880/5
Alexander Schnitzler [Sat, 10 Nov 2018 10:53:51 +0000 (11:53 +0100)]
[!!!][TASK] Drop evaluation of @validate annotations

@validate annotations in (Extbase) models and
controllers are no longer evaluated and should be
replaced with its doctrine annotation replacement.

Releases: master
Resolves: #86898
Change-Id: I6799f0e8e7a6d9661c59f27c2aad589d6a807658
Reviewed-on: https://review.typo3.org/58880
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated global constants 44/59244/6
Christian Kuhn [Thu, 20 Dec 2018 18:09:34 +0000 (19:09 +0100)]
[!!!][TASK] Remove deprecated global constants

Drops most global constants marked for removal,
only PATH_site and PATH_thisScript are left, those
need special care.

Resolves: #87247
Releases: master
Change-Id: Id93f31df8abb44d9f4f1df836b49ff225741fb83
Reviewed-on: https://review.typo3.org/59244
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Drop evaluation of @transient annotations 84/58884/9
Alexander Schnitzler [Sat, 10 Nov 2018 15:05:49 +0000 (16:05 +0100)]
[!!!][TASK] Drop evaluation of @transient annotations

@transient will no longer exclude domain model properties from
the processing of the persistence layer

Releases: master
Resolves: #86905
Change-Id: I45684e335089f6706c12669ccf49669c1b9d3297
Reviewed-on: https://review.typo3.org/58884
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated Extbase-related code 41/59241/6
Benni Mack [Thu, 20 Dec 2018 13:17:42 +0000 (14:17 +0100)]
[!!!][TASK] Remove deprecated Extbase-related code

* Cli functionality
* annotations @cli @internal @flushesCaches
* config.tx_extbase.objects
* plugin.tx_%plugin%.objects

Resolves: #87246
Releases: master
Change-Id: Ic53699f5aa0219d418fe4e385157c90c2083dce8
Reviewed-on: https://review.typo3.org/59241
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated code from impexp extension 43/59243/3
Christian Kuhn [Thu, 20 Dec 2018 15:48:24 +0000 (16:48 +0100)]
[!!!][TASK] Remove deprecated code from impexp extension

Resolves: #87244
Releases: master
Change-Id: I85282bdddc61df62fad1234406b05b73923407be
Reviewed-on: https://review.typo3.org/59243
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Drop evaluation of @lazy annotations 83/58883/7
Alexander Schnitzler [Sat, 10 Nov 2018 15:00:58 +0000 (16:00 +0100)]
[!!!][TASK] Drop evaluation of @lazy annotations

Using the @lazy annotation will no longer trigger the lazy loading
of domain model properties.

Releases: master
Resolves: #86900
Change-Id: I630f702713f1e0a654ff61b9c3bc5792ba101e4e
Reviewed-on: https://review.typo3.org/58883
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Drop evaluation of @ignorevalidation annotations 86/58886/6
Alexander Schnitzler [Sat, 10 Nov 2018 15:25:15 +0000 (16:25 +0100)]
[!!!][TASK] Drop evaluation of @ignorevalidation annotations

@ignorevalidation will no longer ignore the triggering of validations

Releases: master
Resolves: #86901
Change-Id: Ifd98389fe948c7420852e7442fe4f5a8a703f1c7
Reviewed-on: https://review.typo3.org/58886
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Drop deprecated code from EditDocumentController 42/59242/4
Christian Kuhn [Thu, 20 Dec 2018 14:19:34 +0000 (15:19 +0100)]
[!!!][TASK] Drop deprecated code from EditDocumentController

Resolves: #87242
Releases: master
Change-Id: I29a7b417b3705aec3743692b70adbae97f6fbfe3
Reviewed-on: https://review.typo3.org/59242
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Drop evaluation of @cascade annotations 85/58885/6
Alexander Schnitzler [Sat, 10 Nov 2018 15:14:40 +0000 (16:14 +0100)]
[!!!][TASK] Drop evaluation of @cascade annotations

@cascade will no longer trigger cascading of actions in the
persistence layer

Releases: master
Resolves: #86906
Change-Id: I714ae2ad2050e2ebf87a5918a4bd35661bc43d48
Reviewed-on: https://review.typo3.org/58885
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove non-route variants for BE calls 38/59238/3
Benni Mack [Thu, 20 Dec 2018 12:10:09 +0000 (13:10 +0100)]
[!!!][TASK] Remove non-route variants for BE calls

Remove AjaxRequestHandler and the special
handling of '&M=...' query parameter in TYPO3
Backend.

Resolves: #87241
Releases: master
Change-Id: I1f02dc6eef6b1821e30df7d8dc85d16c1fc4d37f
Reviewed-on: https://review.typo3.org/59238
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[BUGFIX] Reimplement custom BE languages 68/59068/7
Guido Schmechel [Sun, 9 Dec 2018 11:12:25 +0000 (12:12 +0100)]
[BUGFIX] Reimplement custom BE languages

Because of a regression the backend does not load custom BE languages.
The loading order is changed so that custom languages are available
again.

Resolves: #87101
Releases: master, 9.5
Change-Id: I0530957abc49f775497d9644047cbb49ceffcda9
Reviewed-on: https://review.typo3.org/59068
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Drop evaluation of @inject annotations 82/58882/6
Alexander Schnitzler [Sat, 10 Nov 2018 14:47:35 +0000 (15:47 +0100)]
[!!!][TASK] Drop evaluation of @inject annotations

@inject will no longer trigger dependency injection

Releases: master
Resolves: #86899
Change-Id: Id440e94b71f62e7b2c396ec1c865ebd109026a04
Reviewed-on: https://review.typo3.org/58882
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[!!!][TASK] Remove last batch of old class aliases 39/59239/3
Christian Kuhn [Thu, 20 Dec 2018 12:08:38 +0000 (13:08 +0100)]
[!!!][TASK] Remove last batch of old class aliases

Extbase extension is the last core extension that
delivered class aliases. Drop them.

Resolves: #87240
Releases: master
Change-Id: I89074e9d32a4f9f639199edf12c2ebd71be2f8e4
Reviewed-on: https://review.typo3.org/59239
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
7 months ago[BUGFIX] Remove unused deprecation trait 36/59236/2
Christian Kuhn [Thu, 20 Dec 2018 10:52:48 +0000 (11:52 +0100)]
[BUGFIX] Remove unused deprecation trait

Resolves: #87239
Related: #87235
Releases: master
Change-Id: Idffa45715e19d71b0f08ff5885d665e0c6b44af8
Reviewed-on: https://review.typo3.org/59236
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Do not show error when copying a record was succesful 02/59202/3
Christoph Lehmann [Tue, 18 Dec 2018 22:23:52 +0000 (23:23 +0100)]
[TASK] Do not show error when copying a record was succesful

https://review.typo3.org/#/c/32356/ introduced the log message

The change was about skipping the direct copyRecord() call for
records that will be processed inside another copyRecord() call
for the record of the default language

Due to https://review.typo3.org/#/c/51070/ $overrideValues contains

['l10n_source' => 0]

When an element is copied inside an earlier copyRecord() call
the error log message is generated which leads to an error
flash message editors see when copying a page, but everything
(copying the records once) went fine.

A earlier call of copyRecord() can occur when using extension like
gridelements when copying a content element laying inside a
grid container element.

Resolves: #82032
Releases: master, 9.5, 8.7
Change-Id: I0d5be8e8920852a0e0c5a5ee93a67f9a6426e941
Reviewed-on: https://review.typo3.org/59202
Reviewed-by: Marcel Tams <marcel.tams@networkteam.com>
Tested-by: Marcel Tams <marcel.tams@networkteam.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Lange <lange@networkteam.com>
Tested-by: Christian Lange <lange@networkteam.com>
Reviewed-by: DANIEL Rémy <dogawaf@free.fr>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
7 months ago[!!!][TASK] Remove deprecated code from EXT:tstemplate 01/59201/8
Wouter Wolters [Tue, 18 Dec 2018 22:35:03 +0000 (23:35 +0100)]
[!!!][TASK] Remove deprecated code from EXT:tstemplate

Resolves: #87233
Releases: master
Change-Id: Ib5604ec4b46b2906565154274ba025a959ea102a
Reviewed-on: https://review.typo3.org/59201
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
7 months ago[!!!][TASK] Remove deprecated code related to TSFE 26/59226/7
Benni Mack [Wed, 19 Dec 2018 19:46:45 +0000 (20:46 +0100)]
[!!!][TASK] Remove deprecated code related to TSFE

The following code related to TSFE has been removed:

PHP classes:
* TYPO3\CMS\Core\PageTitle\AltPageTitleProvider
* TYPO3\CMS\Frontend\Page\ExternalPageUrlHandler
* TYPO3\CMS\Frontend\Page\PageGenerator
* TYPO3\CMS\Frontend\Page\EidUtility

PHP interfaces:
* TYPO3\CMS\Frontend\Http\UrlHandlerInterface

Methods that have been marked as protected
* tempPageCacheContent()
* realPageCacheContent()
* setPageCacheContent()
* clearPageCacheContent_pidList()
* setSysLastChanged()
* contentStrReplace()

Dropped TSFE methods
* mergingWithGetVars()
* connectToDB()
* initFEuser()
* checkAlternativeIdMethods()
* initializeBackendUser()
* getPageShortcut()
* pageUnavailableAndExit()
* pageNotFoundAndExit()
* checkPageUnavailableHandler()
* pageUnavailableHandler()
* pageNotFoundHandler()
* pageErrorHandler()
* makeCacheHash()
* initTemplate()
* handleDataSubmission()
* initializeRedirectUrlHandlers()
* redirectToExternalUrl()
* checkPageForMountpointRedirect()
* checkPageForShortcutRedirect()
* redirectToCurrentPage()
* processOutput()
* sendCacheHeaders()
* sendHttpHeadersDirectly()
* storeSessionData()
* previewInfo()
* hook_eofe()
* addTempContentHttpHeaders()
* setCSS()
* getUniqueId()
* readLLfile()
* getLLL()
* initLLvars()
* convPOSTCharset()
* convertCharsetRecursivelyToUtf8()
* domainNameMatchesCurrentRequest()
* getDomainDataForPid()
* getDomainNameForPid()

Dropped TSFE properties
* activeUrlHandlers
* page_cache_reg1
* siteScript
* loginUser
* gr_list
* beUserLogin
* workspacePreview
* ADMCMD_preview_BEUSER_uid
* showHiddenPage
* showHiddenRecords
* debug
* MP_defaults
* sys_language_uid
* sys_language_mode
* sys_language_content
* sys_language_contentOL
* altPageTitle
* lang

TSFE Properties now marked as protected
* loginAllowedInBranch
* loginAllowedInBranch_mode
* cacheTimeOutDefault
* cacheContentFlag
* cacheExpires
* isClientCachable
* no_cacheBeforePageGen
* tempContent
* pagesTSconfig
* pageCacheTags
* uniqueCounter
* uniqueString
* pageAccessFailureHistory

TSFE Method Signature changes
* calculateLinkVars now 1st parameter is required
* preparePageContentGeneration now 1st parameter is required
4th Parameter of TSFE->__construct() now unused

Removed TypoScript
* config.typolinkCheckRootline
* config.titleTagFunction
* config.USERUID_substToken
* config.USERNAME_substToken

Hooks
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-PostProc']

Database fields:
* index_phash.data_page_reg1

Resolves: #87235
Releases: master
Change-Id: Id95bb0ccb30852fd115fb9da7754fa2e64374a41
Reviewed-on: https://review.typo3.org/59226
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove deprecated GeneralUtility functionality 30/59230/6
Christian Kuhn [Wed, 19 Dec 2018 21:23:42 +0000 (22:23 +0100)]
[!!!][TASK] Remove deprecated GeneralUtility functionality

Resolves: #87234
Releases: master
Change-Id: I07eb0387b8ad1921f715637a5a48581f3eaf9c42
Reviewed-on: https://review.typo3.org/59230
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
7 months ago[!!!][TASK] Remove deprecated adminpanel/feedit code 05/59205/4
Benni Mack [Wed, 19 Dec 2018 08:59:28 +0000 (09:59 +0100)]
[!!!][TASK] Remove deprecated adminpanel/feedit code

The following previously deprecated classes/interfaces have been removed:

* TYPO3\CMS\Adminpanel\View\AdminPanelView
* TYPO3\CMS\Adminpanel\View\AdminPanelViewHookInterface
* TYPO3\CMS\Core\FrontendEditing\FrontendEditingController

The following methods have been removed:
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeAdminPanel()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeFrontendEdit()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->isFrontendEditingActive()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->displayAdminPanel()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->isAdminPanelVisible()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->checkBackendAccessSettingsFromInitPhp()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extPageReadAccess()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extGetTreeList()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extGetLL()

The following public properties have been removed
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extAdmEnabled
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->adminPanel
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->frontendEdit
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extAdminConfig

The following PageTSconfig option has no effect anymore:
* TSFE.frontendEditingController

Resolves: #87231
Releases: master
Change-Id: I88cc3ac18077f054cc8895f5ccfb65291e94defa
Reviewed-on: https://review.typo3.org/59205
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[!!!][TASK] Remove old fluid related class aliases 27/59227/4
Christian Kuhn [Wed, 19 Dec 2018 19:50:11 +0000 (20:50 +0100)]
[!!!][TASK] Remove old fluid related class aliases

Drops old fluid class aliases. Note most of them have
been deprecated with core v8 already.

Resolves: #87230
Releases: master
Change-Id: I509019be4e1df77bfeb94a7498a1ba795c128e86
Reviewed-on: https://review.typo3.org/59227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
7 months ago[TASK] Require styleguide 10.0.1 28/59228/3
Christian Kuhn [Wed, 19 Dec 2018 20:17:18 +0000 (21:17 +0100)]
[TASK] Require styleguide 10.0.1

Styleguide used old fluid related class aliases
which is fixed with this raise.

composer require --dev typo3/cms-styleguide:~10.0.1

Change-Id: I77648c6c919f60866acec9bdaf4cefce437a074c
Resolves: #87232
Related: #87230
Releases: master
Reviewed-on: https://review.typo3.org/59228
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>