Packages/TYPO3.CMS.git
2 years ago[FOLLOWUP][BUGFIX] Hide language switcher if record has no default translation 92/51092/5
Sascha Nowak [Mon, 2 Jan 2017 10:59:58 +0000 (11:59 +0100)]
[FOLLOWUP][BUGFIX] Hide language switcher if record has no default translation

In the current implementation it is not possible to create a new translations outside
of the default translation. So we can readd the new translation option when the record
has a default translation.

Change-Id: I89c4200ff847dadfdeec03b5f43a6577f40702e3
Resolves: #72797
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51092
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
2 years ago[FEATURE] Allow overriding of image manipulation cropVariants 76/51676/3
Stefan Froemken [Tue, 14 Feb 2017 15:56:56 +0000 (16:56 +0100)]
[FEATURE] Allow overriding of image manipulation cropVariants

It is not possible to change or override cropVariants via TSconfig
for sys_file_reference (e.g. for a specific user or page tree branch),
thus making the cropping functionality a pain for bigger sites.
Setting a FormEngine option as expected like
TCEFORM.sys_file_reference.crop.config.cropVariants.* does now work.

Resolves: #79812
Releases: master
Change-Id: I9d36f6661c2a5ca051b803f06485fdb4c8c8a437
Reviewed-on: https://review.typo3.org/51676
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[CLEANUP] Ensure variables initalized and fix code smell 42/51742/3
Sascha Egerer [Sat, 18 Feb 2017 15:58:33 +0000 (16:58 +0100)]
[CLEANUP] Ensure variables initalized and fix code smell

* Ensure that variables are correctly initalized.
* Fix some php docs.
* Initalizes for loop iterator variables before the loop if they are
  also used after the for loop is finished.
* Remove superfluous function arguments.

Resolves: #79892
Releases: master
Change-Id: I75109b2914f2b05806a303837b7aad79be8e3707
Reviewed-on: https://review.typo3.org/51742
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update styleguide to 8.0.6 00/51800/6
Christian Kuhn [Thu, 23 Feb 2017 10:21:39 +0000 (11:21 +0100)]
[TASK] Update styleguide to 8.0.6

Change-Id: I89f5e73ab896d6cd4dac46ebc9e64e14643adbeb
Resolves: #79725
Releases: master
Reviewed-on: https://review.typo3.org/51800
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Fix append and prepend function of valuePicker 79/51779/4
Mona Muzaffar [Tue, 21 Feb 2017 11:37:43 +0000 (12:37 +0100)]
[BUGFIX] Fix append and prepend function of valuePicker

valuePicker appends and prepends now in the correct order.

Change-Id: Ic97b8a66469d43d9269f67f1de3f0cb40d1e8321
Resolves: #79937
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51779
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FEATURE] Add cropVariant support to typoscript rendering of images 53/51753/6
Frans Saris [Sun, 19 Feb 2017 10:46:03 +0000 (11:46 +0100)]
[FEATURE] Add cropVariant support to typoscript rendering of images

The introduction of the new crop variants #75880 broke the handling of
cropped images when using typoscript to render file(reference)'s

This patch fixes the rendering of cropped images and introduces the new
cropVariant option to the typoscript object IMG_RESOURCE

Releated: #75880
Resolves: #79883
Releases: master
Change-Id: Icba77d76c6914d48dcc57d7e8c48471ed27c44b3
Reviewed-on: https://review.typo3.org/51753
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Johannes Goslar <jogo@kronberger-spiele.de>
Reviewed-by: Christer V <cvi@systime.dk>
Tested-by: Christer V <cvi@systime.dk>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Temporarily skip flaky language tests 98/51798/2
Mona Muzaffar [Thu, 23 Feb 2017 08:15:12 +0000 (09:15 +0100)]
[TASK] Temporarily skip flaky language tests

Skip tests downloadALanguage() and activateAndDeactivateALanguage()
Tests need to be fixed.

Change-Id: I999359a83e0d8e092fda483a7799c70110eb10e4
Resolves: #79962
Releases: master
Reviewed-on: https://review.typo3.org/51798
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Upgrade migrated allowLanguageSynchronization field names 92/51692/8
Oliver Hader [Wed, 15 Feb 2017 08:33:45 +0000 (09:33 +0100)]
[TASK] Upgrade migrated allowLanguageSynchronization field names

In case TCA field values have not been migrated yet, but their TCA at the
same time already being updated to allowLanguageSynchronization, then the
field values are not considered in the upgrade wizard.

This change now includes manually updated TCA settings as well.

Resolves: #79950
Related: #79658
Releases: master
Change-Id: Id239c569e3731691a54015642e56a6450c09badc
Reviewed-on: https://review.typo3.org/51692
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Cleanup ContextMenu calls 93/51793/3
Benni Mack [Wed, 22 Feb 2017 09:14:33 +0000 (10:14 +0100)]
[TASK] Cleanup ContextMenu calls

There are still some properties and additional method call arguments
that are not evaluated properly anymore and can be omitted.

Resolves: #79959
Releases: master
Change-Id: Ifc4ed71891394af4c80eaa9c4bb987f79c980a73
Reviewed-on: https://review.typo3.org/51793
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Update Fluid dependency to version 2.3.1 11/51711/7
Claus Due [Wed, 15 Feb 2017 21:21:46 +0000 (22:21 +0100)]
[TASK] Update Fluid dependency to version 2.3.1

Solves three issues:

* Namespace declaration output in templates without sections
* Potential error from unexpected input argument in sanitizePath
* Rendering of new HeaderAssets / FooterAssets sections in
   uncompiled templates.

Adds two Fluid features:

* Namespace detection is now in sync with TYPO3 CMS.
* Escaping modifier `{escaping off}` now supported.

And allows the removal of two custom Fluid integrations
contained in TYPO3 which are now included in Fluid.

Change-Id: Ic9cd73d1d05688139241c81e6a3fb78998fe9407
Resolves: #79847
Resolves: #79811
Releases: master
Reviewed-on: https://review.typo3.org/51711
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[CLEANUP] Streamline EXT:about 90/51790/3
Benni Mack [Wed, 22 Feb 2017 07:38:47 +0000 (08:38 +0100)]
[CLEANUP] Streamline EXT:about

Streamlined EXT:about extension as a first step to clean up the whole
TYPO3 Core base:

- Moved locallang file to EXT:about, as it is only used in this extension
- Removed usage of TYPO3_LOADED_EXT/ext_emconf.php in favor of PackageManager
(needed to add the authors into each Package)
- Fully added all external libraries in use (not including -dev requirements)
- Moved EqualHeight.js to EXT:about as it is only used in this extension
- Proper usage of Fluid layouts
- Streamlined code, variables, imports and comments
- Reviewed comments in PHP

Resolves: #79948
Releases: master
Change-Id: Ia6c2d6b519bc34847131f06908c2c441b9248a8b
Reviewed-on: https://review.typo3.org/51790
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Simplify ImageCropUpdater 92/51792/2
Christian Kuhn [Wed, 22 Feb 2017 08:51:35 +0000 (09:51 +0100)]
[TASK] Simplify ImageCropUpdater

The ImageCropUpdater of the install tool does not need the
not-yet-migrated TCA it does not rely on any TCA that may
have changed. Remove that section from the code.

Change-Id: I8ed4190fd53d87f368c978b183b99b562dba9444
Resolves: #79951
Releases: master
Reviewed-on: https://review.typo3.org/51792
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Improve preview of InputLinkelement 92/51592/9
Georg Ringer [Wed, 8 Feb 2017 18:49:23 +0000 (19:49 +0100)]
[BUGFIX] Improve preview of InputLinkelement

- Use a div instead of an input field to avoid issues like
  tooltip not shown because of the disabled attribute.
- Trigger onchange from LinkBrowser popup
- If no value found, show the input field, which makes it easier
  to e.g. enter an external url.
- Show helpful title for toggle button on hover

Resolves: #79667
Related: #79670
Releases: master
Change-Id: If00d892d0ae7aebe0dfc5f17f5d43af16d0ee730
Reviewed-on: https://review.typo3.org/51592
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Select icon added via pageTsConfig not shown 66/51766/3
Christian Kuhn [Mon, 20 Feb 2017 09:30:29 +0000 (10:30 +0100)]
[BUGFIX] Select icon added via pageTsConfig not shown

Fix for issue #78628 fixed "addItems" for TCA trees, but broke them
for select drop downs. Juggle icon providing around a bit to fix.

Change-Id: I3a1077992a7db0d72bc2d7d0247292763cc25958
Resolves: #78747
Related: #78628
Releases: master
Reviewed-on: https://review.typo3.org/51766
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Extbase: correct handling of mm relations 82/51782/3
Johannes Kasberger [Tue, 21 Feb 2017 13:27:56 +0000 (14:27 +0100)]
[BUGFIX] Extbase: correct handling of mm relations

This change fixes a regression after the doctrine migration and additionally
fixes a wrong join condition which is also present in version 7

Resolves: #79931
Resolves: #79932
Releases: master
Change-Id: I04a4ce174fb1da3baca9af8ba771a7db70d9a884
Reviewed-on: https://review.typo3.org/51782
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Deprecate TSFE-related properties and methods 17/51717/7
Benni Mack [Thu, 16 Feb 2017 12:18:20 +0000 (13:18 +0100)]
[TASK] Deprecate TSFE-related properties and methods

There are some methods and properties which are conceptually in the
wrong place or are outdated.

$TSFE->compensateFieldWith (and config.compensateFieldWidth)
are not in use anymore (since TYPO3 7), as this belonged to
the very very old FORM cObject.

$TSFE->excludeCHashVars
was superseeded with cHash calculation in v6, but never removed.

$TSFE->scriptParseTime (and $TSFE->setParseTime())
is a public property and solely there for one use, storing the calculated
time between the request start and end. This does not need to be
located inside TSFE, as the functionality can be the same,
but built in the request handler, removing a cross-dependency.

$TSFE->generatePage_whichScript()
This alternative method to be used for including raw
PHP include files via requireOnce and config.pageGenScript
dates back to the plain PHP files index_ts.php and pagegen.php
which can safely be marked as outdated now via better PHP class
abstraction and hooks.

The overall goal is to achieve better separation of concerns,
and thus TSFE should only contain what it needs (dealing with rendering a
page based on TypoScript settings).

PageGenerator:: pagegenInit()
Unlike the other methods in PageGenerator this method has
one simple job: Setting $TSFE public properties based on TypoScript
settings. This surely needs to be merged into TSFE, as this is one of the
core jobs of TSFE. It also helps to avoid very unsuccessful attempts
to override certain parts of the Frontend Request as the static calls
to PageGenerator cannot be overriden at all.

TSFE->encryptCharcode and TSFE->encryptEmail()
Both are only needed in ContentObejctRenderer and are there
moved as protected methods and used solely there.

Resolves: #79858
Releases: master
Change-Id: Iabd351a0b5fd7c8cc242f66ba1e9799377fb9390
Reviewed-on: https://review.typo3.org/51717
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Adds notice for lockDomain option in tooltip 51/49751/6
Tomita Militaru [Fri, 2 Sep 2016 11:17:17 +0000 (13:17 +0200)]
[TASK] Adds notice for lockDomain option in tooltip

Notice message for lockDomain option that it can
be circumvented by faking HTTP_HOST

Resolves: #75104
Releases: master
Change-Id: I9b83ab7380123a78a2b99b8ab8127a4fcc69beb4
Reviewed-on: https://review.typo3.org/49751
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Refactor CKEditor to be inline with the AbstractLinkBrowser 60/51760/3
Frans Saris [Sun, 19 Feb 2017 20:28:30 +0000 (21:28 +0100)]
[BUGFIX] Refactor CKEditor to be inline with the AbstractLinkBrowser

The internals of the LinkBrowser and LinkHandler depend on all the
field specific info to be in the P parameter.

Further the DatabaseBrowser used by the RecordBrowser fetches the table
parameter form global url query scope what collides with the params set
by the CKEditor RichTextElement.

To prevent the parameter collision the params set by the RichTextElement
are moved to the P prefix what is also more inline with the other
LinkBrowser implementations.

This patch also resolves the lasts issues related to the new
recordHandler + CKEditor.

Resolves: #79645
Releases: master
Change-Id: Id7cab0f0a012c5de11a2038e1d579d87599d47cd
Reviewed-on: https://review.typo3.org/51760
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Add button to reload static database data of an extension 10/51310/6
Nicole Cordes [Fri, 13 Jan 2017 19:16:20 +0000 (20:16 +0100)]
[TASK] Add button to reload static database data of an extension

This patch re-adds the possibility to manually trigger a reload of
static database data an extension might ships. In the EM list view, an
inconspicuous button is added for each extension which has an own
ext_tables_static+adt.sql file. Furthermore the import is changed, so
that a md5 hash of the file content is stored in the database. If the
extension is updated and the content if the file changes, a more visible
button is shown to indicate an update should be considered.

Resolves: #60748
Releases: master, 7.6
Change-Id: I8ccb01d7e1f98a4adfc70a4d1aa80db4e76bbc9d
Reviewed-on: https://review.typo3.org/51310
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Matthes
Tested-by: Christian Matthes
Tested-by: Joerg Kummer <service@enobe.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Fix runtime-error in traverseFlexFormXMLData 99/51399/4
Thomas Hohn [Mon, 23 Jan 2017 12:08:34 +0000 (13:08 +0100)]
[BUGFIX] Fix runtime-error in traverseFlexFormXMLData

Fix that run-time error will be thrown if
$dataStructureArray['sheets'] is not an array.

Fixes: #79426
Releases: master
Change-Id: I9b7549a5b79d0d5b8b2e27df407879812c1aa491
Reviewed-on: https://review.typo3.org/51399
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Add missing break statement in switch case 59/51759/5
Sascha Egerer [Sun, 19 Feb 2017 19:42:30 +0000 (20:42 +0100)]
[BUGFIX] Add missing break statement in switch case

There is a break statement missing in a switch case statement.
Currently this does not have any side effects but to prevent wrong
behavior in the future this should be fixed.

Resolves: #79906
Releases: master
Change-Id: I2adf40adb1f8df5dcfcdb31f8e9ccddd2b885961
Reviewed-on: https://review.typo3.org/51759
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Remove invalid :has CSS definition 39/51739/3
Sascha Egerer [Sat, 18 Feb 2017 14:31:59 +0000 (15:31 +0100)]
[CLEANUP] Remove invalid :has CSS definition

There is a css rule containing a `:has()` rule.
This rule is not supported in any browser yet and
there must be also no whitespace between the `:has` and
the opening brace.

Resolves: #79890
Releases: master
Change-Id: Ief60c287f1bd0f95c6b61fde0e6f50704978357f
Reviewed-on: https://review.typo3.org/51739
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Install Tool configuration parser must handle nested config 72/51772/5
Markus Klein [Mon, 20 Feb 2017 13:26:59 +0000 (14:26 +0100)]
[BUGFIX] Install Tool configuration parser must handle nested config

Since TYPO3_CONF_VARS may contain nested arrays and the array keys
for those subarrays may collide with first-level citizens (e.g. BE)
the current description parsing (parsing of PHP source code file)
fail hard for those cases.
The problem is not solvable without writing a dedicated full PHP parser
in order to have proper notion of nesting levels.
For this reason the regex-based parsing is completely removed and a
new and dedicated file for the option descriptions is introduced,
which stores the description into a PHP array.

This frees us from the buggy PHP code parsing with regex and enables us
in the future to enhance this array with more information.
(e.g. extract data type into a dedicated subarray element)

Resolves: #79920
Releases: master
Change-Id: Idb5d3fdd2dee5f3150b52c66e65d06c028750893
Reviewed-on: https://review.typo3.org/51772
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] CSH manual: differentiate copyright notice from help content 46/51746/2
Josef Glatz [Sat, 18 Feb 2017 20:42:39 +0000 (21:42 +0100)]
[TASK] CSH manual: differentiate copyright notice from help content

Improve visual differentiation of content and copyright notice.
A visual hruler is added. Font-size and color is slightly adopted.

Resolves: #79895
Releases: master
Change-Id: Idd7190d860c6083d3333b82dba9a796a0bce0e2c
Reviewed-on: https://review.typo3.org/51746
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Only apply image cropping when cropping is set 49/51749/3
Frans Saris [Sun, 19 Feb 2017 08:51:46 +0000 (09:51 +0100)]
[BUGFIX] Only apply image cropping when cropping is set

Resolves: #79836
Releases: master
Change-Id: I29fb6f0f31a54b6f20c937881a8b523b844dde69
Reviewed-on: https://review.typo3.org/51749
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Setting $checkStoredRecords leads to missing sys_log data 68/51568/5
Thomas Hohn [Tue, 7 Feb 2017 20:59:11 +0000 (21:59 +0100)]
[BUGFIX] Setting $checkStoredRecords leads to missing sys_log data

Setting the property $checkStoredRecords in DataHandler to false leads
to missing information in sys_log for new records since the
$newRecord array is empty.

This patch fills the $newRecord array with the newly inserted or
updated data - however the only thing that can't be retrieved is
the title since this is fetched through the call to
checkStoredRecord that is not executed.

Resolves: #79669
Releases: master
Change-Id: I2a53bc2880402fbb42fad859c9fef2dd7c5ae167
Reviewed-on: https://review.typo3.org/51568
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Fix functional tests for EXT:extbase on PostgreSQL 33/51733/4
Morton Jonuschat [Fri, 17 Feb 2017 09:03:43 +0000 (01:03 -0800)]
[BUGFIX] Fix functional tests for EXT:extbase on PostgreSQL

Fix ExpressionBuilder::inSet() to allow working with columns
on a seondary table on Non-MySQL databases. Fix the usage of
inSet() within Typo3DbQueryParser to properly quote the table
identifier and ensure that all places that use inSet() use it
to compare a string value or a field on a table.

Fix assertions to take string/int differences into account and
ensure consistent order when asserting lists of records.

Change-Id: I9fecd228cde1a7d5a6202702616d806b4354eb4f
Resolves: #79796
Releases: master
Reviewed-on: https://review.typo3.org/51733
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix functional tests for EXT:indexed_search on PostgreSQL 65/51765/2
Morton Jonuschat [Mon, 20 Feb 2017 05:21:30 +0000 (21:21 -0800)]
[BUGFIX] Fix functional tests for EXT:indexed_search on PostgreSQL

MySQL has support for backslash escape sequences. Change the tests
to have the expected results without the additional escaping and
add the additional slashes to the expected result if the database
platform running the tests is MySQL.

Change-Id: Ib2e30e95db507501aaea095eb3764a0d37135ec9
Resolves: #79799
Releases: master
Reviewed-on: https://review.typo3.org/51765
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
2 years ago[BUGFIX] Fix deleting file from context menu 68/51768/2
Tymoteusz Motylewski [Mon, 20 Feb 2017 11:15:13 +0000 (12:15 +0100)]
[BUGFIX] Fix deleting file from context menu

Since context menu refactoring the file deletion
did not work.
This patch fixes the issue, by adding missing line in JS.

Resolves: #79916
Releases: master
Change-Id: I939f153aa1d5eae22f821ede98329774e63a3757
Reviewed-on: https://review.typo3.org/51768
Reviewed-by: Malte Koitka <malte@cytrus.de>
Tested-by: Malte Koitka <malte@cytrus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix functional tests for EXT:frontend on PostgreSQL 64/51764/2
Morton Jonuschat [Mon, 20 Feb 2017 05:09:01 +0000 (21:09 -0800)]
[BUGFIX] Fix functional tests for EXT:frontend on PostgreSQL

Replace the MySQL specific backtick quoting with the actual quote
character in test checking for SQL fragments/quoting of fields.

Change assertions that assume integer return values from the
database driver to also accept string types using assertEquals().

Resolves: #79797
Releases: master
Change-Id: I1f78b0b65cdcceeaefa23902d14fa0988198d849
Reviewed-on: https://review.typo3.org/51764
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Skip another unstable acceptance test 67/51767/3
Christian Kuhn [Mon, 20 Feb 2017 10:18:38 +0000 (11:18 +0100)]
[TASK] Skip another unstable acceptance test

The "addAndDeletePage" acceptance test is still unstable, even with
multiple people trying to stabilize that thing already. To raise acceptance
of acceptance tests during core development, this one is skipped for now.

Resolves: #79913
Releases: master
Change-Id: I55ac9ede4b241a737046d1c0ee16618c314f9d79
Reviewed-on: https://review.typo3.org/51767
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Use new cropping API for CE preview in the BE page module 52/51752/2
Frans Saris [Sun, 19 Feb 2017 10:27:47 +0000 (11:27 +0100)]
[BUGFIX] Use new cropping API for CE preview in the BE page module

Resolves: #79854
Releases: master
Change-Id: Ib7cc81efda1c59d54ab30af00622456955cf7397
Reviewed-on: https://review.typo3.org/51752
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] L10nModeUpdater: Cast parentId to integer 57/51757/3
Andreas Fernandez [Sun, 19 Feb 2017 18:09:28 +0000 (19:09 +0100)]
[BUGFIX] L10nModeUpdater: Cast parentId to integer

To prevent PHP errors in L10nModeUpdater caused by faulty extensions
whose `transOrigPointerField` field is not an integer, the parentId is
now always cast to an int.

Resolves: #79824
Releases: master
Change-Id: I238b89b6fec476731f16807125eb89e9198f50c4
Reviewed-on: https://review.typo3.org/51757
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Enhance DataHandler translation and synchronization handling 14/51714/10
Oliver Hader [Wed, 15 Feb 2017 21:47:15 +0000 (22:47 +0100)]
[TASK] Enhance DataHandler translation and synchronization handling

* add more tests for allowLanguageSynchronization & l10n_mode=exclude
* enhance inline children synchronization for non-translatable tables
  using $GLOBALS['TCA'][$tableName]['ctrl']['origUid'] if defined
* bugfix for copying records instead of localizing them - the target
  page-id was missing
* integrate handling of l10n_mode=prefixLangTitle for cloning data
  in memory - DataHandler hooks are not process in that regard

Resolves: #79856
Releases: master
Change-Id: I7f5ef7edba9e80deba6025fe1394d10ee8e2d78c
Reviewed-on: https://review.typo3.org/51714
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Prevent division by 0 when using image file without dimensions 50/51750/5
Frans Saris [Sun, 19 Feb 2017 09:50:48 +0000 (10:50 +0100)]
[BUGFIX] Prevent division by 0 when using image file without dimensions

Resolves: #79902
Releases: master
Change-Id: I42a126369108434e33d3b00d4fe6b556592dc2c9
Reviewed-on: https://review.typo3.org/51750
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
2 years ago[BUGFIX] Fix functional tests for EXT:workspaces on PostgreSQL 31/51731/4
Morton Jonuschat [Fri, 17 Feb 2017 07:07:24 +0000 (23:07 -0800)]
[BUGFIX] Fix functional tests for EXT:workspaces on PostgreSQL

Detect errors during execution of SQL statements using the
exceptions thrown by Doctrine DBAL instead of trying to use
Connection::errorCode().

The previous code doesn't work on MySQL if an actual error
occurs since an exception would be thrown earlier in the
process and the relevant code path would not be reached.

The happy path worked before because MySQL returns 0 as the
code when a statement executed successfully while PostgreSQL
returns '00000' which PHP does not consider to be empty.

Resolves: #79801
Releases: master
Change-Id: I508966b6731d256d1edff2267669d158a8d647bf
Reviewed-on: https://review.typo3.org/51731
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Make progress of tasks in scheduler more readable 10/51710/7
Thomas Hohn [Wed, 15 Feb 2017 20:41:56 +0000 (21:41 +0100)]
[TASK] Make progress of tasks in scheduler more readable

Currently it's hard to read the progress of tasks in the
scheduler due to the combination of blue, white and light
grey. Change of background color for progress from f5f5f5
to dedede makes it more readable.

Resolves: #79844
Releases: master

Change-Id: I896e66452e3093d729522c9ca7da6b597e0451c7
Reviewed-on: https://review.typo3.org/51710
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
2 years ago[BUGFIX] Use correct check to find site root pages 56/51756/3
Georg Ringer [Sun, 19 Feb 2017 17:47:45 +0000 (18:47 +0100)]
[BUGFIX] Use correct check to find site root pages

The change #79857 introduced a wrong check to find the
site root pages. Instead of checking pid == 0, the field
is_siteroot must be used.

Resolves: #79897
Releases: master
Change-Id: Ibfff703fc9506505f860c051f65dc3d31083eb1e
Reviewed-on: https://review.typo3.org/51756
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
2 years ago[BUGFIX] RTE: Determine window object correctly 54/51754/3
Philipp Kerling [Sun, 19 Feb 2017 11:10:16 +0000 (12:10 +0100)]
[BUGFIX] RTE: Determine window object correctly

Resolves: #79904
Related: #77385
Related: #77137
Releases: master
Change-Id: I2036ecfcf380d864438d3e5480ce3aecc96b2634
Reviewed-on: https://review.typo3.org/51754
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] fsc/csc: Fix typolink parameters in parseFunc 55/51755/3
Philipp Kerling [Sun, 19 Feb 2017 11:14:11 +0000 (12:14 +0100)]
[BUGFIX] fsc/csc: Fix typolink parameters in parseFunc

This is a simple typo in the lib.parseFunc of both fluid_styled_content
and css_styled_content. The ATagParams attribute for the typolink
function needs to be written with a capital A in order to work,
otherwise all additional parameters on <a> tags will be dropped in the
rendered output.

Resolves: #79896
Releases: master
Change-Id: I54d5c18fe6934c03b97ae197aba56055394916e5
Reviewed-on: https://review.typo3.org/51755
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
2 years ago[TASK] AC tests: Change default log dir 47/51747/6
Christian Kuhn [Sat, 18 Feb 2017 21:13:38 +0000 (22:13 +0100)]
[TASK] AC tests: Change default log dir

Change acceptance tests log directories for better artifact
building in bamboo with screenshots and adapt two tests to
be less flacky.

Change-Id: Ib86531db23617f8205e5099532249653959662cf
Resolves: #79898
Releases: master
Reviewed-on: https://review.typo3.org/51747
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix assertion in Local Driver Test 41/51741/2
Sascha Egerer [Sat, 18 Feb 2017 14:44:25 +0000 (15:44 +0100)]
[BUGFIX] Fix assertion in Local Driver Test

There are 2 places in the local driver test where a
true assertion is expected. But instead of the correct usage
of `assertTrue()` the method `isTrue()` is being used which
does no assertion.

Resolves: #79891
Releases: master
Change-Id: I68f5e43cb1011dd7aadd2c67479d64810ef88bf3
Reviewed-on: https://review.typo3.org/51741
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] AC tests: Restructure styleguide field tests 43/51743/4
Christian Kuhn [Sat, 18 Feb 2017 17:28:49 +0000 (18:28 +0100)]
[TASK] AC tests: Restructure styleguide field tests

Simplify styleguide "elements basic" acceptance tests to
be easier understandable, split them into two Cest files.

Change-Id: I37ba7a043134e7b2d2291d517c6d0e6aa4c239ae
Resolves: #79893
Releases: master
Reviewed-on: https://review.typo3.org/51743
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Hide help button in create multiple pages function 36/51736/2
Gianluigi Martino [Fri, 17 Feb 2017 22:05:22 +0000 (23:05 +0100)]
[TASK] Hide help button in create multiple pages function

Hide the empty button in the create multiple pages function
if TYPO3 Manual extension is not loaded.

Resolves: #79884
Releases: master
Change-Id: Ib72ddae96512c982e634280ddf888f490289af01
Reviewed-on: https://review.typo3.org/51736
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Fix common misspellings 34/51734/4
Wouter Wolters [Fri, 17 Feb 2017 11:38:00 +0000 (12:38 +0100)]
[TASK] Fix common misspellings

Resolves: #79880
Releases: master
Change-Id: Ia4b240614ee2c1c1a220fcea7d0f7d13ad518acb
Reviewed-on: https://review.typo3.org/51734
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[CLEANUP] Initialize variables and fix invalid function calls 25/51725/2
Sascha Egerer [Thu, 16 Feb 2017 21:55:08 +0000 (22:55 +0100)]
[CLEANUP] Initialize variables and fix invalid function calls

* Initialize some uninitialized variables
* Fix invalid argument count on function calls
* Fix case typo in function call
* Fix some phpdoc issues

Resolves: #79865
Releases: master
Change-Id: I4e41940d849daa818735f75169e7cc686ee908c9
Reviewed-on: https://review.typo3.org/51725
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Fix functional tests for EXT:recycler on PostgreSQL 32/51732/2
Morton Jonuschat [Fri, 17 Feb 2017 07:30:29 +0000 (23:30 -0800)]
[BUGFIX] Fix functional tests for EXT:recycler on PostgreSQL

Enforce consistent ordering of deleted records.

Change-Id: Ibcb5e61c8cf848b2e25702aef3a2d4ca6bd1cfe6
Resolves: #79800
Releases: master
Reviewed-on: https://review.typo3.org/51732
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[FOLLOWUP][TASK] Move typo3/sysext/core/Build/Scripts to Build/Scripts 30/51730/3
Christian Kuhn [Fri, 17 Feb 2017 01:51:01 +0000 (02:51 +0100)]
[FOLLOWUP][TASK] Move typo3/sysext/core/Build/Scripts to Build/Scripts

Fix travis

Change-Id: I3be72d1f892167c884a4ca533dd37633139ef879
Resolves: #79869
Releases: master
Reviewed-on: https://review.typo3.org/51730
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Move typo3/sysext/core/Build/Scripts to Build/Scripts 29/51729/3
Christian Kuhn [Fri, 17 Feb 2017 01:13:04 +0000 (02:13 +0100)]
[!!!][TASK] Move typo3/sysext/core/Build/Scripts to Build/Scripts

This moves all maintenance / check / test scripts from
typo3/sysext/core/Build/Scripts to Build/Scripts.
This is possible now after the test framework extraction.
The artifical Build folder of typo3/sysext/core vanishes and
all core related integrity and code sanitation scripts are
now located next to all other main core build relevant stuff.

This patch is only breaking for core devs who executed one
of the scripts, most notably the "cglFixMyCommit.sh" script.
Path is now:

./Build/Scripts/cglFixMyCommit.sh

Change-Id: I8272d3d18c5e4164d67df8831168476f315db285
Resolves: #79869
Releases: master
Reviewed-on: https://review.typo3.org/51729
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Run acceptance tests in parallel 13/51713/7
Tymoteusz Motylewski [Wed, 15 Feb 2017 22:40:42 +0000 (23:40 +0100)]
[TASK] Run acceptance tests in parallel

Provide script for generating files with acceptance tests groups
to allow running them in parallel on different hosts. Very useful
for bamboo.

Usage:

Generating 5 dynamic group files:
./components/testing_framework/Resources/Core/Build/Scripts/splitAcceptanceTests.sh 5

Run tests of group 1:
./bin/codecept run Acceptance -g AcceptanceTests-Job-1 -c ...

Note group numbers start from 1, not 0.

Resolves: #79845
Releases: master
Change-Id: Ib74ec0b457ee927a906a77e648041ae15dc727d2
Reviewed-on: https://review.typo3.org/51713
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Initialize variable in EXT:filelist 26/51726/2
Sascha Egerer [Thu, 16 Feb 2017 22:09:31 +0000 (23:09 +0100)]
[CLEANUP] Initialize variable in EXT:filelist

Resolves: #79866
Releases: master
Change-Id: Iffb59947ae8a2790736352c473637ac184796b36
Reviewed-on: https://review.typo3.org/51726
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Fix usage of GeneralUtility::quoteJSvalue 27/51727/2
Sascha Egerer [Thu, 16 Feb 2017 22:22:54 +0000 (23:22 +0100)]
[CLEANUP] Fix usage of GeneralUtility::quoteJSvalue

The function GeneralUtility::quoteJSvalue is sometimes called
with a second parameter but it does only have on parameter.

Resolves: #79867
Releases: master
Change-Id: I994501574b798026f43a0e463a633e05ffc1cff3
Reviewed-on: https://review.typo3.org/51727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Remove superfluous initialization of UriBuilder 23/51723/4
Sascha Egerer [Thu, 16 Feb 2017 21:20:35 +0000 (22:20 +0100)]
[CLEANUP] Remove superfluous initialization of UriBuilder

The UriBuilder initialization has been added in
f5dd76ca41f70ea7ab22a2aeb1291aabefc95232 but it is not used
anywhere

Resolves: #79863
Releases: master
Change-Id: I46deb21e5466f3d068f95063034feb4da3b7f60c
Reviewed-on: https://review.typo3.org/51723
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix localization guard for "pages_language_overlay" 20/51720/2
Mathias Brodala [Thu, 16 Feb 2017 15:42:39 +0000 (16:42 +0100)]
[BUGFIX] Fix localization guard for "pages_language_overlay"

Resolves: #79859
Related: #78191
Releases: master, 7.6
Change-Id: Ia2a3ed9b1a793c1be554f73fa99362e3015313df
Reviewed-on: https://review.typo3.org/51720
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove deprecated argument htmlEscape of f:translate VH 09/51709/3
Frank Naegler [Wed, 15 Feb 2017 18:22:26 +0000 (19:22 +0100)]
[TASK] Remove deprecated argument htmlEscape of f:translate VH

Remove usage of htmlEscape from core templates, because it is deprecated since #75575

Resolves: #79842
Related: #75575
Releases: master
Change-Id: I62c53cb9cdba585f5ead920154dcef729c8c02eb
Reviewed-on: https://review.typo3.org/51709
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[BUGFIX] Fix SQL error for single table view in list module 21/51721/3
Frank Naegler [Thu, 16 Feb 2017 17:01:33 +0000 (18:01 +0100)]
[BUGFIX] Fix SQL error for single table view in list module

This patch fixes wrong field escaping due to simple implode of fields
in case label_alt is set for select or groups fields.

Resolves: #79860
Releases: master
Change-Id: Ie0753957e387c1624824d152ac291524cfd34ccd
Reviewed-on: https://review.typo3.org/51721
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[TASK] Improve page tree in access module 19/51719/2
Georg Ringer [Thu, 16 Feb 2017 15:06:51 +0000 (16:06 +0100)]
[TASK] Improve page tree in access module

If the root page is selected, the following is improved:

- show the sitename instead of '[root-level]'
- show the world icon for the first pages (all with pid = 0)

Resolves: #79857
Releases: master
Change-Id: I449a34e356ec43f8679bb9cdcd4c790fd4701004
Reviewed-on: https://review.typo3.org/51719
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix access to non existing object 24/51724/2
Sascha Egerer [Thu, 16 Feb 2017 21:34:50 +0000 (22:34 +0100)]
[BUGFIX] Fix access to non existing object

Fix a fatal error introduced in a previous refactoring of
the code.

Resolves: #79864
Releases: master
Change-Id: Ib50052f2d7b3485da97fbe7a4ad88041bb676dad
Reviewed-on: https://review.typo3.org/51724
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Initialize variables in EXT:version 22/51722/2
Sascha Egerer [Thu, 16 Feb 2017 21:06:43 +0000 (22:06 +0100)]
[CLEANUP] Initialize variables in EXT:version

Add some missing variable initialization in EXT:version

Resolves: #79862
Releases: master
Change-Id: I97d8326675d9d90404b99e501e8756ec045c0d90
Reviewed-on: https://review.typo3.org/51722
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Improve TCA migration messages 56/51556/6
Mona Muzaffar [Mon, 6 Feb 2017 14:11:34 +0000 (15:11 +0100)]
[TASK] Improve TCA migration messages

Resolves: #79437
Releases: master
Change-Id: I5d1c64202d9e59c0a2a8e799df0576af9f6cb82d
Reviewed-on: https://review.typo3.org/51556
Tested-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix functional tests for EXT:core on PostgreSQL 64/51664/5
Morton Jonuschat [Wed, 8 Feb 2017 04:58:53 +0000 (20:58 -0800)]
[BUGFIX] Fix functional tests for EXT:core on PostgreSQL

Fix reliance on MySQLs implicit secondary ordering by uid within
DataHandler.

Reset sequenced on non-MySQL database platforms.

Sort expected results retrieved from the database and switch to using
assertEquals() to avoid string/int type differences in result rows
due to different drivers.

Change-Id: I95a8cdb81dbbdb6c4bcf2c6c9ad9f0e5f9ae44fe
Resolves: #79672
Releases: master
Reviewed-on: https://review.typo3.org/51664
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix functional tests for EXT:backend on PostgreSQL 65/51665/3
Morton Jonuschat [Wed, 8 Feb 2017 04:22:37 +0000 (20:22 -0800)]
[BUGFIX] Fix functional tests for EXT:backend on PostgreSQL

Sort expected results retrieved from the database and switch to using
assertEquals() to avoid string/int type differences in result rows
due to different drivers.

Change-Id: I65975967171c28a13c8711d352895d2969d408ea
Resolves: #79671
Releases: master
Reviewed-on: https://review.typo3.org/51665
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] UriBuilder: Do not skip empty parameters 04/51704/4
Markus Klein [Wed, 15 Feb 2017 15:55:41 +0000 (16:55 +0100)]
[BUGFIX] UriBuilder: Do not skip empty parameters

This is not the job of the uri builder to decide this.
It must simply build an URL from all given parameters.

In general, empty parameters can be intended by a dev.

Resolves: #79835
Releases: master, 7.6
Change-Id: I0ec3e7c41a78b40ecd81e52381f1d744a1e65608
Reviewed-on: https://review.typo3.org/51704
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Change namespace of testing framework 15/51715/6
Susanne Moog [Thu, 16 Feb 2017 08:13:45 +0000 (09:13 +0100)]
[TASK] Change namespace of testing framework

Change-Id: Ib8b787980d90c686457155cbb6c15cd3cd7c0d61
Releases: master
Resolves: #79851
Reviewed-on: https://review.typo3.org/51715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Ensure proper quoting of fields for PostgreSQL in JsonRenderer.ts 69/51569/3
Morton Jonuschat [Wed, 8 Feb 2017 03:49:20 +0000 (19:49 -0800)]
[BUGFIX] Ensure proper quoting of fields for PostgreSQL in JsonRenderer.ts

PostgreSQL requires mixed case column names in the database to be quoted at
all times, otherwise the name of the column will be forcefully converted to
all lowercase.

Set a constant in the testrenderer that contains the current database type
and switch the WHERE condition in JsonRenderer.ts to a properly quoted
version for PostgreSQL

Change-Id: I0b7caf4b51006bdf3bc131d995b0993504f49889
Releases: master
Resolves: #79651
Reviewed-on: https://review.typo3.org/51569
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Clean up testing framework from core deps - part 1 06/51706/6
Benni Mack [Wed, 15 Feb 2017 17:24:57 +0000 (18:24 +0100)]
[TASK] Clean up testing framework from core deps - part 1

There are some unnecessary calls to the core,
which are obviously unneeded.

Resolves: #79843
Releases: master
Change-Id: Ia86f57e56516cc30132a2360d8dc17a44e95531e
Reviewed-on: https://review.typo3.org/51706
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FOLLOWUP][TASK] Add functional test for IRRE on pages 12/51712/2
Oliver Hader [Wed, 15 Feb 2017 21:30:11 +0000 (22:30 +0100)]
[FOLLOWUP][TASK] Add functional test for IRRE on pages

* add values of pages.tx_irretutorial_hotels to assertions
* extend JSON renderer to reflect pages.tx_irretutorial_hotels

Resolves: #79829
Releases: master
Change-Id: I27ac88af79aa6cef85e8d34d22f464c62142cbed
Reviewed-on: https://review.typo3.org/51712
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] CKEditor: Avoid JS error when opening an existing link 91/51691/2
Benni Mack [Wed, 15 Feb 2017 05:47:09 +0000 (06:47 +0100)]
[BUGFIX] CKEditor: Avoid JS error when opening an existing link

When opening an existing link by double-clicking on the
a tag element in CKEditor the popup should open, however
if no additional attributes are registered, JS throws an
error.

Resolves: #79818
Releases: master
Change-Id: I9f9b838862ab76d21161d4962f75f88d70c44cdd
Reviewed-on: https://review.typo3.org/51691
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Streamline DataHandler functional tests 01/51701/4
Oliver Hader [Wed, 15 Feb 2017 15:08:48 +0000 (16:08 +0100)]
[TASK] Streamline DataHandler functional tests

Live and Workspaces share quite a lot of common test cases which however
are duplicated for each scenario. To ease the integration of new tests
for both scenarios, these superfluous redundancies are removed.

Resolves: #79833
Releases: master
Change-Id: I2ef2ee63d9c052ea5e9a5a8ddae7c63f15abf58d
Reviewed-on: https://review.typo3.org/51701
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Adjust paths for fsc static template during migration 97/51697/3
Jan Kiesewetter [Wed, 15 Feb 2017 13:40:58 +0000 (14:40 +0100)]
[BUGFIX] Adjust paths for fsc static template during migration

Resolves: #79828
Releases: master
Change-Id: Ibf3da0d9a181004340038762ef548b10883406b8
Reviewed-on: https://review.typo3.org/51697
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Split long running acceptance test into smaller pieces 60/51660/2
Tymoteusz Motylewski [Mon, 13 Feb 2017 19:02:13 +0000 (20:02 +0100)]
[TASK] Split long running acceptance test into smaller pieces

The formengine validation test is splitted into few smaller tests.

Releases: master
Resolves: #79788
Change-Id: I8a44c02e77bad9b26d33aa17a1d18f2c9edd26ff
Reviewed-on: https://review.typo3.org/51660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FOLLOWUP][TASK] Add functional test for IRRE on pages 05/51705/2
Oliver Hader [Wed, 15 Feb 2017 15:58:56 +0000 (16:58 +0100)]
[FOLLOWUP][TASK] Add functional test for IRRE on pages

* remove wrong column shift in data-set
* update reference index entries for workspaces

Resolves: #79829
Releases: master
Change-Id: I64496bf907cda7a81313c49c80419be3a798ad2e
Reviewed-on: https://review.typo3.org/51705
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Add functional test for IRRE on pages 98/51698/3
Oliver Hader [Wed, 15 Feb 2017 14:09:14 +0000 (15:09 +0100)]
[TASK] Add functional test for IRRE on pages

* add field pages.tx_irretutorial_hotels
* add one relation to tx_irretutorial_1nff_hotel
* update assertions for all scenarios

Resolves: #79829
Releases: master
Change-Id: Ic2f830ac855e1c79692b7182762795be1a893a80
Reviewed-on: https://review.typo3.org/51698
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Extend Testbase to run functionals tests with multiple DB drivers 52/51152/13
Manuel Selbach [Sun, 22 Jan 2017 06:06:55 +0000 (22:06 -0800)]
[TASK] Extend Testbase to run functionals tests with multiple DB drivers

Implement Testbase::importXmlDatabaseFixtureFinisher to handle database
platform specific cleanup tasks for functional tests. For PostgreSQL
this will update the primary key sequences to the maximum value used
in the table to avoid key errors on subsquent inserts.

This patch doesn't fix all functional test to work on PostgreSQL, this
will follow in smaller, subsequent patches as many tests currently fail
due to database rows being returned in a different order as well as
due to different return types of the databases (i.e. int vs. string)
leading to failures when using assertSame().

Releases: master
Resolves: #79650
Change-Id: I8a08fc033b638eb66ca7655fdde4f311dd5982b2
Reviewed-on: https://review.typo3.org/51152
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Code cleanup based on Psalm static analyser 79/51679/5
Wouter Wolters [Tue, 14 Feb 2017 16:59:19 +0000 (17:59 +0100)]
[TASK] Code cleanup based on Psalm static analyser

Code cleanup based on the static analyser Psalm.
https://github.com/vimeo/psalm

Resolves: #79815
Releases: master
Change-Id: I67dd33a79564b81931515f210644e980f83d3b7b
Reviewed-on: https://review.typo3.org/51679
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] FlexFormNoTabsContainer: Fix usage of array_pop() 90/51590/2
Andreas Fernandez [Wed, 8 Feb 2017 16:52:25 +0000 (17:52 +0100)]
[BUGFIX] FlexFormNoTabsContainer: Fix usage of array_pop()

PHP’s `array_pop()` requires its argument being passed as reference,
but the result of `array_keys()` is directly used.
The result of `array_keys()` is now stored into a variable which gets
passed to `array_pop()`.

Resolves: #79686
Releases: master, 7.6
Change-Id: Icda3040abefbffad64e93acf0d7ae632ccee00bf
Reviewed-on: https://review.typo3.org/51590
Reviewed-by: Armin Vieweg <armin@v.ieweg.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fluid: Register "core" namespace globally 88/51688/3
Benni Mack [Tue, 14 Feb 2017 20:23:31 +0000 (21:23 +0100)]
[TASK] Fluid: Register "core" namespace globally

The Fluid namespace "core" is now available globally, making
it obsolete to register the namespace manually in each file
any core viewhelper is necessary.

This is also a precursor for integrating Frontend Editing content
editable ViewHelpers in all places of TYPO3 Frontend when
fluid templates are in use.

Resolves: #79817
Releases: master
Change-Id: I7691107fa7c02e71b848cd8d0bb0eecdae5a8171
Reviewed-on: https://review.typo3.org/51688
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mattias Nilsson <tollepjaer@gmail.com>
Tested-by: Mattias Nilsson <tollepjaer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update file list module access in backend groups and users 82/50982/5
Nicole Cordes [Thu, 15 Dec 2016 23:51:13 +0000 (00:51 +0100)]
[TASK] Update file list module access in backend groups and users

As the file list module was renamed, backend groups and users access
lists need adjustments. This patch updates the module name and
removes the non-existing "file" module from those lists.

Resolves: #78979
Releases: master, 7.6
Change-Id: I06bd10523399f38e2a0ec6fdf5740cbfea6dd509
Reviewed-on: https://review.typo3.org/50982
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Update TYPO3 version to TYPO3 8.7-dev 74/51674/3
Wouter Wolters [Tue, 14 Feb 2017 14:37:32 +0000 (15:37 +0100)]
[TASK] Update TYPO3 version to TYPO3 8.7-dev

Resolves: #79810
Releases: master
Change-Id: I8325ad82a66d7a2c4c5028ecf63fea690c5b7ac0
Reviewed-on: https://review.typo3.org/51674
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove outdated comment 87/51687/2
Georg Ringer [Tue, 14 Feb 2017 20:16:16 +0000 (21:16 +0100)]
[TASK] Remove outdated comment

A comment in InitializeProcessedTca can be removed as
since #79059 a type is required and checked.

Resolves: #79816
Releases: master
Change-Id: Id9ecf7e15b584c20e30f4a5148f35c093d0c6923
Reviewed-on: https://review.typo3.org/51687
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Throw exception when CLI command is added twice 16/51316/4
Benni Mack [Sun, 15 Jan 2017 13:22:44 +0000 (14:22 +0100)]
[TASK] Throw exception when CLI command is added twice

If two extensions register the same command, the "last one"
wins currently.

The patch throws an exception if there is already a name
or alias with this command name.

Resolves: #79590
Releases: master
Change-Id: Iaafb97d88455077ab60689c32dda0580c47e0b47
Reviewed-on: https://review.typo3.org/51316
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Truncate long GIFBUILDER file names 05/51305/6
Thoams Oliver Moll [Fri, 13 Jan 2017 14:05:50 +0000 (15:05 +0100)]
[BUGFIX] Truncate long GIFBUILDER file names

GIFBUILDER generates file names from serialized data from
the GIFBUILDER setup (typoscript).
This can result in too long file names when the GIFBUILDER
is called with many parameters and on filesystems with
a max filename/path length.

The comment of the function fileName() states that the filename
should be shortened to 100 chars, but this doesn't happen.

This patch introduces a simple substring to enforce this limit.

Change-Id: Iaa17760bbf34fc6c01a9bc5ea8d1f8b6b242fecb
Resolves: #79301
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51305
Reviewed-by: Marco Huber <mail@marco-huber.de>
Tested-by: Marco Huber <mail@marco-huber.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Set TYPO3 version to 8.6.1-dev 73/51673/2
TYPO3 Release Team [Tue, 14 Feb 2017 14:33:13 +0000 (15:33 +0100)]
[TASK] Set TYPO3 version to 8.6.1-dev

Change-Id: I112860b52029a9df98143602ef4addaf48a488fe
Reviewed-on: https://review.typo3.org/51673
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 8.6.0 72/51672/2 8.6.0 TYPO3_8-6-0
TYPO3 Release Team [Tue, 14 Feb 2017 14:31:56 +0000 (15:31 +0100)]
[RELEASE] Release of TYPO3 8.6.0

Change-Id: I92505b77df3a6d1a8dceaf137a174aa887e08e0e
Reviewed-on: https://review.typo3.org/51672
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[BUGFIX] allowLanguageSynchronization flaws with pages_language_overlay 71/51671/2
Oliver Hader [Tue, 14 Feb 2017 14:03:14 +0000 (15:03 +0100)]
[BUGFIX] allowLanguageSynchronization flaws with pages_language_overlay

The allowLanguageSynchronization does not work correctly with the tables
pages and pages_language_overlay. This change at least provides the basic
functionality for regular non-relational values (which might work, but are
not verified with tests properly).

Resolves: #79809
Releases: master
Change-Id: Ia8402799828490e695fd7bfed1d1df51c6c43f3e
Reviewed-on: https://review.typo3.org/51671
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Finalize L10nModeUpdater for enhanced l10n_modes 46/51646/9
Oliver Hader [Sun, 12 Feb 2017 20:03:13 +0000 (21:03 +0100)]
[TASK] Finalize L10nModeUpdater for enhanced l10n_modes

L10nModeUpdater has to be adjusted to reflect all possibilities that
became available with introducing allowLanguageSynchronization and
the implicit synchronization for the exclude mode.

Instead of cloning the logic again inside the upgrade wizard, the
DataHandler and DataMapResolver is used to determine required changes
as well as performing especially relation resolving and handling.

Resolves: #79768
Releases: master
Change-Id: Id61c419fe9f6aa6fdbbe6f3d6335b0e9c1bf0693
Reviewed-on: https://review.typo3.org/51646
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Documentation for FluidStyledContent and CSSStyledContent changes 40/51640/11
Benjamin Kott [Sun, 12 Feb 2017 13:54:41 +0000 (14:54 +0100)]
[TASK] Documentation for FluidStyledContent and CSSStyledContent changes

Resolves: #79719
Related: #79622
Releases: master
Change-Id: Id4c7cd1c659df35fb1484d40d079f3d6b1074e20
Reviewed-on: https://review.typo3.org/51640
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Harden TcaMigration 68/51668/2
Christian Kuhn [Tue, 14 Feb 2017 11:29:24 +0000 (12:29 +0100)]
[BUGFIX] Harden TcaMigration

Broken TCA - if 'config' is not an array - can lead to warnings
in TcaMigration. Move a couple of lines around to suppress this.

Change-Id: I8411cd8335de6af49cbd85f821239723dc6d6c55
Resolves: #79806
Releases: master
Reviewed-on: https://review.typo3.org/51668
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Enable "show source" btn in default RTE config 70/51670/2
Benni Mack [Tue, 14 Feb 2017 11:59:13 +0000 (12:59 +0100)]
[BUGFIX] Enable "show source" btn in default RTE config

The button was accidentally removed when introducing
the configuration of the RTE via YAML.

Resolves: #79807
Releases: master
Change-Id: I083432af50279f7bc3a1e0d0d748d8ee06b31354
Reviewed-on: https://review.typo3.org/51670
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Add missing fields in functional tests fixtures 61/51661/2
Tymoteusz Motylewski [Mon, 13 Feb 2017 20:26:40 +0000 (21:26 +0100)]
[BUGFIX] Add missing fields in functional tests fixtures

Add value to the language_isocode column for sys_language fixture
and CType for tt_content fixture.

Resolves: #79790
Releases: master
Change-Id: I2d83d436c495bc2a8174527f34610880f8a0f9ea
Reviewed-on: https://review.typo3.org/51661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Thomas Löffler <thomas.loeffler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix broken svg flag 62/51662/3
Josef Glatz [Mon, 13 Feb 2017 22:13:15 +0000 (23:13 +0100)]
[BUGFIX] Fix broken svg flag

The vietnam svg flag is somewhat garbled. The external lib "region-flags"
isn't broken. It seems as if it was mutilated while adding it to the core
last time.

The broken svg icon is fixed by a re-run of `grunt svgmin` task.

Resolves: #79793
Releases: master, 7.6
Change-Id: Ic1337a1a7037fa95d739937571a1a4ed381e1dae
Reviewed-on: https://review.typo3.org/51662
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Commit compiled install.css 63/51663/2
Josef Glatz [Mon, 13 Feb 2017 22:47:08 +0000 (23:47 +0100)]
[TASK] Commit compiled install.css

Make compiling css with grunt clean again when executing.

Resolves: #79794
Releases: master
Change-Id: Iafee078446347e1de834f555439c921fc401aa98
Reviewed-on: https://review.typo3.org/51663
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Update require.js version number in bower.json 23/51623/5
Anders Kostending [Fri, 10 Feb 2017 09:21:19 +0000 (10:21 +0100)]
[TASK] Update require.js version number in bower.json

The version number of require.js should reflect the one of the
already installed version v2.3.2.

Require.js release notes:
2.3.0:
The way dependencies are found for the sugared syntax changed
slightly in #1582. It is now faster and should catch more
legitimate dependency cases. You should not notice any negative
consequences to the change, but given how important that
mechanism is, it was best to rev the minor version to 2.3.
The r.js optimizer also handles larger directory changes better.
If you are using 2.2, you are encouraged to update to 2.3.
alameda was also updated to 1.1.0 to include the same
dependency searching change as requirejs 2.3.

2.3.1:
Only one change from 2.3.0, and it is in the optimizer.
It fixes how the bundled uglifyjs declares the addFile function.
Without the fix, it causes an error in Node 0.10/0.12.
Newer versions of Node are not affected.

2.3.2:
Fixes an issue that prevented the 2.3.x optimizer from running
in Java's 8+'s jjs. There was a change in require.js and a
change in the r.js optimizer.

Resolves: #79738
Releases: master
Change-Id: I117e0809236462fb6888108f1db60d6d1b4254e9
Reviewed-on: https://review.typo3.org/51623
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[DOCS] 8.6 Documentation 41/51641/6
Mathias Schreiber [Sun, 12 Feb 2017 15:22:10 +0000 (16:22 +0100)]
[DOCS] 8.6 Documentation

Update and proofread 8.6 docs

Resolves:
Change-Id: Ie6cf569ad331f97637cc01901e689db22abeae05
Reviewed-on: https://review.typo3.org/51641
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Added testing_framework to gitattributes export-ignore 59/51659/2
Susanne Moog [Mon, 13 Feb 2017 15:39:40 +0000 (16:39 +0100)]
[TASK] Added testing_framework to gitattributes export-ignore

As the testing framework shall be a standalone component
which will be required via composer it has been excluded
from the exported files via .gitattributes.

Change-Id: I74708a31b3848105a949268e9caa1160c59cbc30
Resolves: #79783
Releases: master
Reviewed-on: https://review.typo3.org/51659
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] DataMapProcessor does not exclude workspace versions 47/51647/2
Oliver Hader [Sun, 12 Feb 2017 20:26:58 +0000 (21:26 +0100)]
[BUGFIX] DataMapProcessor does not exclude workspace versions

DataMapProcessor, used to resolve and handle the language synchronization
feature, does not exclude workspace versions correctly. That's why it
might happen, that inline records are not correctly synchronized in the
live workspace if translations exist in any workspace.

Resolves: #79769
Releases: master
Change-Id: Id1d724ae38aeddefbe82a316624a75315d1a93f1
Reviewed-on: https://review.typo3.org/51647
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] allowLanguageSynchronization fails for 2nd level translations 44/51644/5
Oliver Hader [Sun, 12 Feb 2017 17:04:07 +0000 (18:04 +0100)]
[BUGFIX] allowLanguageSynchronization fails for 2nd level translations

2nd level translations are not considered yet with the feature to
synchronize languages either from parent or source language records.
This change modifies the creation of the language state as well as
switches "custom" states to "source" states of a new second level
translation is being created.

Resolves: #79755
Releases: master
Change-Id: I860d87a1b305966a9caa5cbd17bc5bf7229f5704
Reviewed-on: https://review.typo3.org/51644
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Fix wrong path handling in DocumentationFile 37/51637/2
Nicole Cordes [Sat, 11 Feb 2017 16:11:39 +0000 (17:11 +0100)]
[BUGFIX] Fix wrong path handling in DocumentationFile

Currently several unit tests are failing on Windows system due to the
usage of DIRECTORY_SEPARATOR. This patch ensures unix-like paths are
used everywhere and tests are running again.

Resolves: #79759
Releases: master
Change-Id: I60d8e2c31b56fae627c59b8aa4e8fed0eb85b0a9
Reviewed-on: https://review.typo3.org/51637
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Matthes
Tested-by: Christian Matthes
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[CLEANUP] Remove unused splat operator in AreaTest 52/51652/4
Ingo Pfennigstorf [Mon, 13 Feb 2017 09:10:45 +0000 (10:10 +0100)]
[CLEANUP] Remove unused splat operator in AreaTest

This removes an unnecessary splat operator in the AreaTest.

Resolves: #79775
Releases: master
Change-Id: Ife0ba8c75780552737761f8b0ca97ffc0fe83c51
Reviewed-on: https://review.typo3.org/51652
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[FOLLOWUP][TASK] DatabaseSessionBackend: Pass on DB exception information 58/51658/2
Markus Klein [Mon, 13 Feb 2017 15:20:19 +0000 (16:20 +0100)]
[FOLLOWUP][TASK] DatabaseSessionBackend: Pass on DB exception information

Shorten exception messages.

Resolves: #79781
Releases: master
Change-Id: I4b16c02c4f74dc667e0ce7f5baf525e50c49234a
Reviewed-on: https://review.typo3.org/51658
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>