Packages/TYPO3.CMS.git
6 years ago[TASK] Integrate basic TypoScript parsing test 92/19492/2
Oliver Hader [Mon, 1 Apr 2013 14:04:23 +0000 (16:04 +0200)]
[TASK] Integrate basic TypoScript parsing test

Resolves: #46839
Releases: 6.0, 6.1
Change-Id: I3dd007908bbd127386b86dd0f31e927c1034bb97
Reviewed-on: https://review.typo3.org/19492
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Adapt ArrayConstraints in IndexerTest 89/19489/2
Steffen Ritter [Mon, 1 Apr 2013 13:04:19 +0000 (15:04 +0200)]
[TASK] Adapt ArrayConstraints in IndexerTest

The tests for a parameter array check for equality of
the parameter array and the according value.
Instead we only wanna know if two keys are present and
set correctly and we do not care about other array values.

This refactors the Test to be more polite and is a follow-up
for #46596.

Change-Id: Ia7b4a0521b1d11b9494de2ff766f11b3c8bd1f60
Releases: 6.0, 6.1
Related: #46596
Reviewed-on: https://review.typo3.org/19487
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-on: https://review.typo3.org/19489

6 years ago[BUGFIX] PHP filesystem functions are locale dependent 77/18577/3
Steffen Ritter [Sun, 3 Mar 2013 18:46:38 +0000 (19:46 +0100)]
[BUGFIX] PHP filesystem functions are locale dependent

PHP filesystem functions like pathinfo, dirname and
basename are dependent on the locale set in PHP.
If one enables UTF8filesystem in the install tool, he may
use non-ascii characters in filenames and directory names.
For this to work properly you need to configure
SystemLocale, too.

The file abstraction layer classes need to take care of
the SystemLocale; to avoid code duplication new static
wrapper functions have been introduced.

Change-Id: I635e18d7ed08d928c6c4e427c0348dd46d9c5900
Releases: 6.0, 6.1
Resolves: #45982
Reviewed-on: https://review.typo3.org/18577
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Accept alternative notations for setDBinit 35/19035/4
Michael Stucki [Tue, 19 Mar 2013 10:37:06 +0000 (11:37 +0100)]
[BUGFIX] Accept alternative notations for setDBinit

Allow quotes and upper-case notation when checking if
$TYPO3_CONF_VARS['SYS']['setDBinit'] is configured properly.

Resolves: #24582
Releases: 6.1, 6.0
Change-Id: I51a5f6cf363077c738656c207648f21d726de72b
Reviewed-on: https://review.typo3.org/19035
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Reviewed-by: Oliver Hader
6 years ago[BUGFIX] Javascript for TMENU_LAYERS and GMENU_LAYERS missing 62/19262/4
Michael Stucki [Mon, 25 Mar 2013 12:53:17 +0000 (13:53 +0100)]
[BUGFIX] Javascript for TMENU_LAYERS and GMENU_LAYERS missing

If using GMENU_LAYERS/TMENU_LAYERS and (for example) indexed_search on
the same page, the JavaScript header tags are missing if the page is
loaded from the cache.

Resolves: #36719
Releases: 4.5, 4.6, 4.7, 6.0, 6.1
Change-Id: Icd52f68d2b9462360f0b9efd912d93d4b0c1048c
Reviewed-on: https://review.typo3.org/19262
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Detect APC and APCu correctly 69/19469/2
Stefan Neufeind [Sun, 31 Mar 2013 17:54:41 +0000 (19:54 +0200)]
[TASK] Detect APC and APCu correctly

APCu is just the user-data part of APC,
providing the same API.

If installed it currently identifies itself
as both "apcu" and "apc" (for compatibility).
Thus if "apcu" shows up, we actually have an APC
without opcache-support.

Resolves: #46821
Releases: 4.5, 4.7, 6.0, 6.1
Change-Id: Id61bcf9277295915a6e204eabab7c65159e98764
Reviewed-on: https://review.typo3.org/19469
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Sending fails on multiple email-addresses 63/19463/2
Stefan Neufeind [Sun, 13 Jan 2013 13:57:44 +0000 (14:57 +0100)]
[BUGFIX] Sending fails on multiple email-addresses

Specifying multiple recipients (To or CC) for emails
leads to an error upon form-submit without further explanation.
This patch implements validation for multiple email addresses of
which only the valid ones are then returned.
The sending-API can already handle multiple recipients.

Change-Id: Ia0a947e1ee7b4d9b352a297840b68ff489f71375
Fixes: #44485
Releases: 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/19463
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Fix of Close-button in flash messages 64/19464/2
Jost Baron [Sun, 24 Mar 2013 22:12:13 +0000 (23:12 +0100)]
[BUGFIX] Fix of Close-button in flash messages

The close button did not work because hide() was called on
a HTMLElement instead of an Ext.Element.

Fixes: #46373
Related: #31368
Releases: 6.1, 6.0, 4.7
Change-Id: I70c65a82683ece39de4ed043a916b0521aabafa1
Reviewed-on: https://review.typo3.org/19464
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] WincacheBackend: Add a "Testing"-context to the tests 59/19459/3
Stefan Neufeind [Sun, 31 Mar 2013 13:20:47 +0000 (15:20 +0200)]
[TASK] WincacheBackend: Add a "Testing"-context to the tests

Resolves: #46817
Related: #46768
Releases: 6.0
Change-Id: I5ebc5f026d92ae8070c2dbfd4679e2889bad6c07
Reviewed-on: https://review.typo3.org/19459
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX][Cache] Wincache backend class constructor 39/19439/2
Christian Kuhn [Fri, 29 Mar 2013 14:42:31 +0000 (15:42 +0100)]
[BUGFIX][Cache] Wincache backend class constructor

The class constructor of wincache cache backend misses the first
parameter $context, so $options is treated as $context. Given
backend options are not used this way, for example defaultLifetime
has no effect.
The patch adds the missing constructor parameter to be in line
with the other cache backends.

Change-Id: I488b9996d5ab65420f79b2cab4c75805ae89a77a
Resolves: #46768
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19439
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[!!!][BUGFIX] Crop-Scaled images have wrong file content type 97/19397/2
Oliver Hader [Fri, 22 Mar 2013 09:35:53 +0000 (10:35 +0100)]
[!!!][BUGFIX] Crop-Scaled images have wrong file content type

The following scenario is given:
* resize a 300dpi TIFF image to PNG using stdWrap/cObj
* the 'fileExtension' configuration is not set
* the processed file csm_... has the file extension PNG
* but the file content type is still TIFF, so the file
  was just renamed, but not converted to PNG

Since the processing task determines the accordant filename
and file extension of the processed file, the image processor
(e.g. ImageMagick) needs to know about that fact as well.

This change modifies the TaskInterface which is rarely to not
at all used in custom extensions implementing individual tasks
to process files.

Change-Id: I089edc01a39663ac91b1b9df168f659c32954fcb
Fixes: #46530
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19169
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-on: https://review.typo3.org/19397

6 years ago[BUGFIX] Image rendering of non-existing files throws exception 93/19393/2
Oliver Hader [Fri, 22 Mar 2013 09:31:29 +0000 (10:31 +0100)]
[BUGFIX] Image rendering of non-existing files throws exception

Rendering an image that has no accordant file in a storage in
the frontend (e.g. in TypoScript) fails with an exception like
"Object with identifier xyz does not exist in storage".

A new ResourceDoesNotExistException is introduced to cover
files and folders and is thrown instead of RuntimeException.
This way, the exception is caught in the ContentObjectRenderer
and the frontend rendering just does not output the error,
which is logged instead.

Change-Id: I0affa15a8f0a50bf30a7176972994f209d18daf4
Fixes: #46535
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19393
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Wrong variable name used 88/19388/2
Georg Ringer [Wed, 27 Mar 2013 12:45:19 +0000 (13:45 +0100)]
[BUGFIX] Wrong variable name used

The parameter is called $lgd but is used as $length.

Change-Id: Id5303562d4e3f9bd9222db585da6a5365588a031
Fixes: #46718
Releases: 6.1,6.0
Reviewed-on: https://review.typo3.org/19388
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Increase Web>List title column width 35/19335/2
Felix Kopp [Sun, 24 Feb 2013 22:04:37 +0000 (23:04 +0100)]
[TASK] Increase Web>List title column width

The column width for the title column in list view is hard-coded.

Increase the width for current screen sized.
Without this patch many titles are wrapped in new lines.

Change-Id: I09cf35cd954edc7909ec05f7bb6ad6ccd4fdee95
Fixes: #45805
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19335
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Subfolders must use the identifier as identifier 34/19334/2
Georg Ringer [Fri, 22 Mar 2013 18:14:45 +0000 (19:14 +0100)]
[BUGFIX] Subfolders must use the identifier as identifier

Currently subfolders don't use the identifier correctly as the name is
used instead. This doesn't really matter if you got a folder structure
anyway but dealing with different identifiers leads to troubles.

createFolderObject() will create a new Folder object which then has the
identifier set wrong.

Change-Id: I04629ffc97766557abc0920f1dbe56f1453d76ac
Fixes: #46568
Releases: 6.1,6.0
Reviewed-on: https://review.typo3.org/19334
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Settings for local drivers are not shown by default 12/19212/2
Nicole Cordes [Fri, 22 Mar 2013 15:11:35 +0000 (16:11 +0100)]
[BUGFIX] Settings for local drivers are not shown by default

If you create a new storage the LocalDriver is selected by default
(because it is the first registered driver) but the flexform field is not
shown. Because of the hidden configuration field you cannot set up the
base path until you have saved the storage record. Local driver should be
selected by default and configuration field should be displayed every
time.

Change-Id: Ic9c6c1eb7ca3d9f45723dce728558002440ae9da
Fixes: #46555
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19212
Reviewed-by: Alexander Opitz
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[BUGFIX] Title includes html tags 03/19203/2
Nicole Cordes [Fri, 22 Mar 2013 09:13:21 +0000 (10:13 +0100)]
[BUGFIX] Title includes html tags

In the filelist special folders like _temp_ and _recycler_ folder are
highlighted in bold as they get human readable names. The <strong>
tags are shown in the title tag as well. Therefore the title tag has
to be stripped of any html tags.

Change-Id: I4b21a916851e0d02aa58971eabda32f813bd890c
Fixes: #46532
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19203
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
6 years ago[TASK] Raise submodule pointer 20/19320/2
Christian Kuhn [Tue, 26 Mar 2013 20:43:02 +0000 (21:43 +0100)]
[TASK] Raise submodule pointer

Change-Id: I34270786b7208b73327e6c3330cc80a3e9be93a3
Reviewed-on: https://review.typo3.org/19320
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Remove needless "x " on TER-search 18/19318/2
Stefan Neufeind [Wed, 28 Nov 2012 19:38:15 +0000 (20:38 +0100)]
[BUGFIX] Remove needless "x " on TER-search

Keep input field after search for easy re-search.

Change-Id: I658657c89a91e5196ca5a2997d76bc0bba52c820
Fixes: #43410
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19318
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Segfaults on object comparisons 16/19316/3
Andreas Wolf [Sat, 23 Mar 2013 10:12:38 +0000 (11:12 +0100)]
[BUGFIX] Segfaults on object comparisons

In the ResourceStorage class, the identity of source and target storage
has to be verified for several operations (copy, move). When the
comparison is done with a simple equality operator (==), the properties
of both objects are compared when the objects are not identical. This
comparison led to a segfault in several environments, presumably because
of a meanwhile fixed PHP bug (https://bugs.php.net/bug.php?id=61557).

To prevent these segfaults on affected PHP versions, the comparison is
extended to check for object identity (===). This will not affect the
behaviour of the code, as there should always be only one object per
storage.

Change-Id: I378c447f75c00859447cf1443f64b81e54161c54
Resolves: #46584
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19316
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 15/19315/2
Christian Kuhn [Tue, 26 Mar 2013 20:15:57 +0000 (21:15 +0100)]
[TASK] Raise submodule pointer

Change-Id: I14c35e0a265b917b3ceb8663debd7d81f205c1b5
Reviewed-on: https://review.typo3.org/19315
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Exception with EXT:sys_note is installed 86/19286/2
Oliver Hader [Thu, 21 Mar 2013 15:03:26 +0000 (16:03 +0100)]
[BUGFIX] Exception with EXT:sys_note is installed

If extension sys_note is installed, and the first page does not
have a TypoScript Template with an accordant root flag, a
system exception is thrown, pointing out that the table
"tx_extbase_domain_model_backenduser" could not be found.

The reason for that is:
* the sys_note backend behaviour is based on Extbase
* Extbase is being configured using (front-end) TypoScript
* ext_typoscript_setup.txt files are not processed if there's
  no accordant root template for the current rootline
* the persistence mapping from "be_users" to the mentioned
  "tx_extbase_domain_model_backenduser" would have been defined
  in the external TypoScript file

The solution is to check, whether these external files got
processed during TypoScript parsing and will be processed
explicitely if they have not been integrated yet.

Change-Id: I06a7edecd5cdac9dd7ab3918b281712602ad6b36
Fixes: #46250
Related: #46511
Release: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19286
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Extbase Plugin for Indexed Search not working 54/19254/2
Matthias Nitsch [Tue, 5 Feb 2013 09:09:36 +0000 (10:09 +0100)]
[BUGFIX] Extbase Plugin for Indexed Search not working

The plugin uses wrong classes in several places, which leads to fatal
errors because of missing functions.

Replace all occurences with the right classes.

Resolves: #45162
Releases: 6.1, 6.0
Change-Id: Ie7a0ba25adadf5482b22eaf38c0cf88aaf44cd1a
Reviewed-on: https://review.typo3.org/19254
Reviewed-by: Matthias Nitsch
Tested-by: Matthias Nitsch
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[TASK] Fix failing unit tests for LocalDriver 44/19244/2
Andreas Wolf [Sun, 24 Mar 2013 10:40:48 +0000 (11:40 +0100)]
[TASK] Fix failing unit tests for LocalDriver

The original patch for #46604 unfortunately broke two (non-critical)
unit tests, which are fixed again by this commit.

Change-Id: I36d2cc62cc6cc744cd482aad573db57a57f832a8
Related: #46604
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19244
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX] FAL Upgrade Wizards do not set pid 16/19216/2
Benjamin Mack [Sat, 23 Mar 2013 14:04:41 +0000 (15:04 +0100)]
[BUGFIX] FAL Upgrade Wizards do not set pid

The sys_file_reference records are originally set to
be placed on rootLevel, the upgrade wizard does
exactly that.

However, the concept in this case is flawed
- When creating new sys_file_reference records via IRRE,
   the sys_file_reference is stored on the page
- When copying moving e.g. a tt_content record, all its
   child elements are placed on that new page as
   well (so this works)
- rootLevel restriction is not needed in this case

The patch does the following:
- Modify the existing upgrade wizard to place the
   sys_file_references on the pages of the foreign
   tables (tt_content pid)
- the rootLevel flag for sys_file_reference is removed
- Add a new upgrade wizard is added to ensure the
integrity of the sys-file-reference pids

Releases: 6.1, 6.0
Resolves: #46497
Change-Id: Ic592024669f68ed1606ed36eb050d1dfa5ad66bb
Reviewed-on: https://review.typo3.org/19216
Reviewed-by: Henrik Ziegenhain
Tested-by: Henrik Ziegenhain
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Default upload folder should be user_upload/ 41/19241/2
Benjamin Mack [Sat, 23 Mar 2013 15:27:52 +0000 (16:27 +0100)]
[BUGFIX] Default upload folder should be user_upload/

The default folder in FAL is set to temp. However, temp should
be used for temporary files like import/export t3d files,
not uploads by the user.
In 99% of the use case, the uploaded files should be accessible
by the frontend (which temp isn't because of a .htaccess file).
That's why the fileadmin/user_upload/ should always be
created in the install tool, AND the user_upload file
should be the default folder for the local driver.

Resolves: #46604
Releases: 6.1, 6.0
Change-Id: I79319bab4bad76c1af9e001a0a5146fae85ce59f
Reviewed-on: https://review.typo3.org/19241
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Folder Tree does not respect _temp_ and _recycler_ 38/19238/2
Benjamin Mack [Sat, 23 Mar 2013 15:06:11 +0000 (16:06 +0100)]
[BUGFIX] Folder Tree does not respect _temp_ and _recycler_

The Folder Tree View does not respect temp and
recycler settings, which are identified by the folder
names.

The file list itself does that, because there is a wrong
use of "getIdentifier".

You can see that the foldertree does not show
"Temporary" but "_temp_"  because the comparison
fails every time. The file list works however.

Resolves: #46603
Releases: 6.1, 6.0
Change-Id: I08de29b737ef3464addceda9f610e9dd0a7b1034
Reviewed-on: https://review.typo3.org/19238
Reviewed-by: Andreas Wolf
Tested-by: Andreas Wolf
6 years ago[BUGFIX] Resource storage does not emit signals 39/19239/2
Andreas Wolf [Sat, 23 Mar 2013 14:30:38 +0000 (15:30 +0100)]
[BUGFIX] Resource storage does not emit signals

The ResourceStorage class should emit signals before and after most
actions it performs. The emit*() methods are already there, but not
called from the "action" methods. This commit adds the calls where
missing.

Change-Id: Icf1653975aa72762ab61c6d649207c5900e66b1d
Resolves: #46587
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19221
Reviewed-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Reviewed-by: Tom Ruether
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-on: https://review.typo3.org/19239

6 years ago[BUGFIX] Copy and move folders between storages is broken 13/19213/2
Nicole Cordes [Fri, 22 Mar 2013 17:23:39 +0000 (18:23 +0100)]
[BUGFIX] Copy and move folders between storages is broken

If you try to copy a folder from one storage into another one it leads to
a copy in the same (source) storage. This happens because the action is
executed in the source storage and only works with the source folder
object. This is fixed by calling the move method on the target storage
instead.

Besides the copyFolderBetweenStorages function raises an exception which
might be moved into the driver class as the driver should be responsible
for the copy work. Therefore the AbstractDriver should support
(abstract) methods to copy a folder between storages and the local
driver should raises the exception.

Same applies for moving folders between storages.

Change-Id: Ib282e351f39abca21d57f5d621b4bd999f8419d9
Fixes: #46564
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19213
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Update sys_refindex to reflect typolink to file in RTE content 91/19191/2
Benjamin Mack [Tue, 9 Oct 2012 21:51:15 +0000 (23:51 +0200)]
[BUGFIX] Update sys_refindex to reflect typolink to file in RTE content

Problem: sys_refindex should be updated when a link to a file is
inserted in or removed from RTE content.
Solution: Add missing softrefs.

Change-Id: Ice1f46a591bd0129aef043b0b18b21be0469157b
Releases: 6.0
Resolves: #36792
Reviewed-on: https://review.typo3.org/10942
Reviewed-by: Steffen Ritter
Reviewed-by: Helmut Hummel
Reviewed-by: Mattias Nilsson
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
Reviewed-on: https://review.typo3.org/19191
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] fallbackRendering is always called 95/19195/2
Simon Schaufelberger [Tue, 22 Jan 2013 22:33:45 +0000 (23:33 +0100)]
[BUGFIX] fallbackRendering is always called

When rendering textpic, the content object rendering is always called for
the Typoscript setting fallbackRendering which is not always defined.

Change-Id: I2ebfffd2ece8022136c4fcc8d0e12d552486dd32
Fixes: #44732
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/19195
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Small cleanup in Boostrap.php 39/19039/3
Michael Stucki [Tue, 19 Mar 2013 12:54:00 +0000 (13:54 +0100)]
[TASK] Small cleanup in Boostrap.php

Code cleanup prior to #41596

Releases: 6.1, 6.0
Change-Id: I87294a52e282175b345ee8b1a735604f6993e0f3
Reviewed-on: https://review.typo3.org/19039
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Sorting files in filelist is case sentive 89/19189/2
Nicole Cordes [Fri, 22 Mar 2013 11:55:45 +0000 (12:55 +0100)]
[BUGFIX] Sorting files in filelist is case sentive

The sorting for files in the filelist is case sensitive while the sorting
for folders is not. The sorting should be adjusted to be identical for
files and folders.

Change-Id: I2aee28f42beb1f9b4b1eb969ee5503fd9bea0e23
Fixes: #46541
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19189
Reviewed-by: Benjamin Mack
Tested-by: Benjamin Mack
6 years ago[BUGFIX] Fix .zip-export on windows and add unit test 18/19118/3
Jost Baron [Fri, 15 Mar 2013 20:06:21 +0000 (21:06 +0100)]
[BUGFIX] Fix .zip-export on windows and add unit test

On Windows servers (xampp), the .zip-export of extensions did not
work because \ZipArchive::addFile can't add directories on Windows.

Added a unit test for the export function.

Fixes: #45140
Releases: 6.0, 6.1
Change-Id: If248bf031d3d7b621971de609b86eedc0ee05a64
Reviewed-on: https://review.typo3.org/19118
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] ExtDirectApi uses an undefined variable 15/19115/2
Dmitry Dulepov [Wed, 6 Mar 2013 18:24:44 +0000 (22:24 +0400)]
[BUGFIX] ExtDirectApi uses an undefined variable

Method generateAPI() sets $className inside the condition but later uses
it without checking if it is empty or not. The result is a PHP warning
"Invalid argument supplied for foreach()".

Change-Id: I7fd2bf88374661a8b54023aee9fe2af5619471b0
Resolves: #46075
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19115
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Usage of deprecated returnFilemounts() 69/19069/2
Markus Klein [Wed, 27 Feb 2013 12:06:46 +0000 (13:06 +0100)]
[BUGFIX] Usage of deprecated returnFilemounts()

Some places in Core still use $GLOBALS['BE_USER']->returnFilemounts()

Resolves: #36405
Releases: 6.0, 6.1
Change-Id: I6252ed1191811a9813e590aa570741d31522895c
Reviewed-on: https://review.typo3.org/19069
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] BELog module error: "vsprintf(): Too few arguments" 67/19067/2
Dmitry Dulepov [Wed, 6 Mar 2013 19:05:01 +0000 (23:05 +0400)]
[BUGFIX] BELog module error: "vsprintf(): Too few arguments"

AbstractExceptionHandler contains a function named writeLog. That
function adds an entry to the system log. System log expects not
just a string but a string format with % characters. Callers of
this methods may supply a URL ("Request URL:" in the log message)
that contains % characters. vsprintf() in the BELog view helper
will complain about missing arguments to such string.

Change-Id: Ie080c0af1d93c28f8521b670a8ae8e63f8c4cfda
Resolves: #46077
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/19067
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Use minimised version of jquery.dataTables-1.9.4 33/19033/2
Stefan Neufeind [Wed, 21 Nov 2012 00:29:56 +0000 (01:29 +0100)]
[TASK] Use minimised version of jquery.dataTables-1.9.4

Change-Id: Ic8f2f046b6df70c885158f4c1f08cbad1c943cf1
Resolves: #43186
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/19033
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 23/19023/2
Christian Kuhn [Mon, 18 Mar 2013 21:03:35 +0000 (22:03 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ia8d085a85e3508a44403e6415de87785cda7ed9a
Reviewed-on: https://review.typo3.org/19023
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Media element not working with FAL 02/19002/2
Andreas Schütte [Wed, 13 Feb 2013 08:45:44 +0000 (09:45 +0100)]
[BUGFIX] Media element not working with FAL

With FAL the path to a file is no longer used,
instead the UID to the specific file is used,
prefixed with "file:"

This patch just adds a check if the filename
starts with "file:" and if so load the specific FileObject
to retrive the url. This check is done before all others,
because FAL should be the default file handler.
Additionally use explode() first to get the filename
if an editor adds (non used)
link parameters: file:740 _blank media-title

This fixes also the problem with audio files mentioned in #39416,
using the same patch.

Resolves: #41280
Related: #39416
Releases: 6.0, 6.1
Change-Id: Ibec6cefda54b6e136c0d5ae43c67ef2eea3b1bb8
Reviewed-on: https://review.typo3.org/19002
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix PHP warning in BackendUtility::lockRecords 92/18992/2
Helmut Hummel [Sat, 16 Mar 2013 15:29:20 +0000 (16:29 +0100)]
[BUGFIX] Fix PHP warning in BackendUtility::lockRecords

This methods triggers a warning "Illegal String offset"
with PHP 5.4, because $GLOBALS['BE_USER']->user['uid'] is accessed
even if a user is not logged in.

Additionally a delete query is executed in this case which
does not make sense at all.

Properly check if a user is logged in before executing any
functionality in this method.

Fixes: #46361
Releases: 4.5, 4.7, 6.0, 6.1
Change-Id: I370e0a8610a55b3d684bef95d7c6905eaaaacbab
Reviewed-on: https://review.typo3.org/18992
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] HMENU rendering uses old tslib_ class names 73/18973/2
Christian Kuhn [Thu, 14 Mar 2013 16:39:14 +0000 (17:39 +0100)]
[BUGFIX] HMENU rendering uses old tslib_ class names

The menu rendering in frontend still instantiates menu classes with
its old tslib_ prefixed names. This is unflexible and a potential
performance issue.

The patch introduces a simple factory instead with a mapping for
existing TypoScript menu types to the implementing classes.
The current variable $menuclasses is obsolete.
Additionally, the naming of three existing classes is adapted to
the correct class names to be in sync with the others.

A method in the factory to register additional menu types will
be added with a second patch.

Change-Id: I3d65258ffe4d30a918705b23349d3facb563c80e
Resolves: #46292
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18973
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Make sure XML parser is created everytime when needed 67/18967/2
Christian Kuhn [Sat, 16 Mar 2013 00:25:29 +0000 (01:25 +0100)]
[BUGFIX] Make sure XML parser is created everytime when needed

Currently, EM's MirrorXmlPushParser, which is based on ext/xml,
is not properly working. The constructor creates the parser and
within parseXML() method the parser resource is freed.
However, when clicking on retrieve/update button method
parseXML() is invoked multiple times which makes subsequent calls
fail.

Creating the parser is now done within parseXML() method.

Change-Id: I7c6c15f65d08fb0264d7d66cc584cbe7ff423b45
Resolves: #25292
Releases: 6.1, 6.0, 4.7, 4.5
Reviewed-on: https://review.typo3.org/18967
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 64/18964/2
Christian Kuhn [Fri, 15 Mar 2013 23:00:46 +0000 (00:00 +0100)]
[TASK] Raise submodule pointer

Change-Id: Id68b495581b7ee0bff119031fd24dd01c4a1a5b8
Reviewed-on: https://review.typo3.org/18964
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Importing extensions from repository fails 62/18962/2
Christian Kuhn [Fri, 15 Mar 2013 21:54:00 +0000 (22:54 +0100)]
[BUGFIX] Importing extensions from repository fails

If importing the extension list from TER, an incoming XML extension
row has a field 'category' that contains either a string like
'plugin' or a category number.
The list is persisted to the 'extension' repository. In the
database, the category is stored as integer. There is a mapping
function in the extension model to get the integer category
index from given XML input. The method is faulty and returns
strings instead of an index if the given category is a string
itself. This results in database errors during insert.

The patch fixes the method, renames it along the way and adds
unit tests to document desired behavior.

Change-Id: I601b84d0829f3d20a4cdd25a3f7f37e8128dbce1
Fixes: #46115
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18962
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGIFX] Extra output block backend thumbnails 59/18959/2
Francois Suter [Tue, 12 Feb 2013 16:09:14 +0000 (17:09 +0100)]
[BUGIFX] Extra output block backend thumbnails

If some inclusion causes output when viewing image thumbnails
in the backend, the output will be broken. Adding a call to
ob_clean() ensures that this does not happen.

Resolves: #31953
Releases: 6.1, 6.0
Change-Id: I1d33bc3c5e8bbd1851f087c76564f8924f8dfe26
Reviewed-on: https://review.typo3.org/18959
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years agoRevert "[BUGFIX] Fix wrong column title in web>list for field colpos" 42/18942/4
Christian Kuhn [Fri, 15 Mar 2013 15:02:19 +0000 (16:02 +0100)]
Revert "[BUGFIX] Fix wrong column title in web>list for field colpos"

This reverts commit 765ebd0cd992b86f8002f932bb51b2a39c0ace99

The patch triggers warnings and errors in multiple extensions. Digging
into the details shows the implementation is neither finished nor
stable. See issue #25113 for a detailed analysis.

Change-Id: I1ff1ea11feb34c71d3ee42789c3deda130aa9a0e
Related: #25113
Fixes: #45833
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/18942
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 32/18932/2
Christian Kuhn [Fri, 15 Mar 2013 00:38:45 +0000 (01:38 +0100)]
[TASK] Raise submodule pointer

Change-Id: I64d97afc42424a0f6233fe645453f48c863c671c
Reviewed-on: https://review.typo3.org/18932
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] LanguageController has "mixed" type annotations 20/18920/2
Wouter Wolters [Sun, 3 Feb 2013 13:11:07 +0000 (14:11 +0100)]
[BUGFIX] LanguageController has "mixed" type annotations

The LanguageController of the lang sysext throws
exceptions if the rewritten property mapper is enabled.
The type annotation 'mixed' is unknown. The patch fixed
the annotation to the correct string value to make the
property mapper happy.

Change-Id: I57ebd268d2fe82c095ccf20b581e721703fb2868
Fixes: #44672
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18920
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Skip unreliable APC test on PHP versions below 5.3.4 02/18902/2
Christian Kuhn [Thu, 14 Feb 2013 00:13:43 +0000 (01:13 +0100)]
[BUGFIX] Skip unreliable APC test on PHP versions below 5.3.4

APC has some slam protection that tries to prevent hammering of cache
entries. This can be disabled, but the option does not work at least
in native PHP 5.3.3 on debian squeeze. While it is no problem with
higher PHP version like the current one on travis-ci.org,
some tests are now just skipped on PHP environments knows for issues.

Change-Id: Ibbef201805b58041bb0b3e8aa16f0c1a2e366020
Resolves: #46267
Release: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18902
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Add .htaccess file to ext:extensionmanager/Resources/Private 98/18898/2
Christian Kuhn [Wed, 13 Feb 2013 23:59:20 +0000 (00:59 +0100)]
[BUGFIX] Add .htaccess file to ext:extensionmanager/Resources/Private

Change-Id: I7ada1e5e40067cf1faed8b2b5d338a690e921cad
Fixes: #46264
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18898
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Toolbar items with separator: fix white-space 92/18892/2
Felix Kopp [Sun, 24 Feb 2013 16:14:05 +0000 (17:14 +0100)]
[BUGFIX] Toolbar items with separator: fix white-space

The toolbar function could output erroneous html is case
additional toolbar items do not bring additionalAttributes.

Additional attributes are defined based on ToolbarItemHookInterface.
But additionalAttributes can be an empty string:

Fix output <liclass="separator"> to <li class="separator">
by adding an extra white-space.

Change-Id: I09338d17848c8fc74b25e7c532d6ee329956321b
Fixes: #45795
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18892
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Numeric translation keys aren't translated right in XML files 11/18211/2
Reinhard Führicht [Mon, 21 Jan 2013 08:52:35 +0000 (09:52 +0100)]
[BUGFIX] Numeric translation keys aren't translated right in XML files

When working with the "old" XML based translation files,
numeric keys aren't translated properly.
The reason is, that LocallangXmlParser uses array_merge to combine the
translation arrays of the default language and the current language.
array_merge renumbers numeric keys. Therefore, numeric key in
translation files result in wrong translations in Frontend.

Fixes: #44626
Releases: 6.0, 6.1
Change-Id: I8fdff385f681428b4cb5a3e994828a4a29305c98
Reviewed-on: https://review.typo3.org/18211
Reviewed-by: Reinhard Führicht
Tested-by: Reinhard Führicht
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Translation of a form makes the form wizard unusable 87/18887/3
Mario Rimann [Tue, 15 Jan 2013 09:20:27 +0000 (10:20 +0100)]
[BUGFIX] Translation of a form makes the form wizard unusable

As soon as the form-configuration for the form wizard gets
loaded, the leading "[Translate to XYZ:] " is stripped off to get the
wizard working (with the leading text, the form config could not
be serialized as needed and the wizard didn't show a single field).

The stripping is only done on localized records.

Change-Id: I0cab1d371abf5ae01b524c39acedcd1a3a5db9c4
Fixes: #39127
Releases: 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/18887
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Exception when deleted file is in clipboard 84/18884/2
Andreas Wolf [Sun, 10 Feb 2013 17:10:54 +0000 (18:10 +0100)]
[BUGFIX] Exception when deleted file is in clipboard

When a file is deleted while it is part of a clipboard, an exception is
thrown when the clipboard is reconstituted. This exception has to be
catched, otherwise the file module will be unusable.

Change-Id: I8849644ffa7b78559c1797d85ce3cc6e01d03a74
Resolves: #43906
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18884
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] inject* methods in FAL inhibit use of Extbase object manager 82/18882/2
Andreas Wolf [Sat, 9 Feb 2013 14:49:32 +0000 (15:49 +0100)]
[BUGFIX] inject* methods in FAL inhibit use of Extbase object manager

The ResourceStorage class of FAL has two inject* methods which are seen
as dependency injectors by the Extbase object manager. Thus an exception
is thrown when a ResourceStorage object is created via Extbase.

This commit changes the two method's names and adjust all usages within
the core. These methods are internal and I don't expect them to be used
anywhere else, so we don't need a backwards compatibility layer.

Change-Id: I4b73445708cf8041b505b5ea8923dc595ddaadb0
Resolves: #45319
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18882
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Raise submodule pointer 64/18864/2
TYPO3 Release Team [Tue, 12 Mar 2013 16:02:47 +0000 (17:02 +0100)]
[TASK] Raise submodule pointer

Change-Id: I3c75e82765a4903ca34a19e8fac1ac5e2fdd1635
Reviewed-on: https://review.typo3.org/18864
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Old files of filelist extension are wrong 45/18845/2
Wouter Wolters [Mon, 11 Mar 2013 21:12:20 +0000 (22:12 +0100)]
[BUGFIX] Old files of filelist extension are wrong

During the namespace change the old filelist extenion files
are not correctly set. Instead of "filelist" this was replaced
with "file_list".

Fixes: #46155
Related: #45143
Releases: 6.0

Change-Id: I33ebb12163dd30d35981f45dcd465f7340bf1f5a
Reviewed-on: https://review.typo3.org/18845
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Show better error messages on failed TER update 44/18844/2
Jost Baron [Mon, 4 Mar 2013 21:38:01 +0000 (22:38 +0100)]
[TASK] Show better error messages on failed TER update

This patch shows error messages in a flash message if the ajax request
for a TER-update fails, and resets the extension manager into a sane
state, instead of showing an ever spinning wheel.

Resolves: #46030
Releases: 6.1, 6.0
Change-Id: I1cc67460a11feb206c53c12a38ad0f6db482e04a
Reviewed-on: https://review.typo3.org/18844
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Make the update-from-TER link more visible 43/18843/2
Jost Baron [Mon, 4 Mar 2013 20:41:21 +0000 (21:41 +0100)]
[TASK] Make the update-from-TER link more visible

Make the "update from TER"-action in the extension manager more
visible by showing a button for it, instead of a text link.

Also moved the rendering functionality of the update link from
a viewhelper to a partial, as partials tend to be more readable
and bug free.

Resolves: #46029
Releases: 6.1, 6.0
Change-Id: If447bba28bc0dee3e7de286e1a93e062ef59843c
Reviewed-on: https://review.typo3.org/18843
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Handle symlink on extension update 42/18842/2
Philipp Gampe [Sun, 10 Mar 2013 16:15:27 +0000 (17:15 +0100)]
[BUGFIX] Handle symlink on extension update

If an extension is updated and the extension in the file
system is a symlink to a different directory, all
target directory contents is removed and the update fails.

Introduce a check for symlink and just remove the
symlink in this case.

Resolves: #46158
Releases: 6.1, 6.0
Change-Id: I112ae7192fb0edf77ebd703a61804dc09ca506a4
Reviewed-on: https://review.typo3.org/18842
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] More descriptive error message on file upload failure 40/18840/2
Philipp Gampe [Thu, 27 Dec 2012 12:34:12 +0000 (13:34 +0100)]
[TASK] More descriptive error message on file upload failure

Provide the user with more accurate information about what might have
gone wrong.

Resolves: #46160
Releases: 6.0,6.1
Change-Id: I86123b904f36ff7f6db77f2dd13f97c0a01957c3
Reviewed-on: https://review.typo3.org/18840
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Correct check for extTables script 29/18829/3
Francois Suter [Sun, 10 Mar 2013 19:42:19 +0000 (20:42 +0100)]
[BUGFIX] Correct check for extTables script

Existence of the script defined in TYPO3_extTableDef_script is
currently achieved by using file_exists(). This is insufficient
if TYPO3_extTableDef_script is defined, but empty, as
file_exists() will match "typo3conf/" and try to include it.

Resolves: #46161
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18828
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Change-Id: I9d6694228ca27cb2c446629a90e5c8636705e3e3
Reviewed-on: https://review.typo3.org/18829

6 years ago[BUGFIX] Typo in sys_log TCA 12/18812/2
Christian Kuhn [Fri, 8 Mar 2013 10:32:13 +0000 (11:32 +0100)]
[BUGFIX] Typo in sys_log TCA

Wrong table field name in sys_log TCA "detail_nr" instead of
"details_nr" triggers SQL errors in DB check -> Full search module.

Change-Id: I02298019ef29f38def0b6c204236fd6987b92bce
Releases: 6.1, 6.0
Fixes: #45887
Reviewed-on: https://review.typo3.org/18812
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Wrong cmd example in INSTALL.txt 07/18807/2
Markus Klein [Fri, 8 Mar 2013 09:45:52 +0000 (10:45 +0100)]
[BUGFIX] Wrong cmd example in INSTALL.txt

The INSTALL.txt file has an example on how to create a link
in Windows using the MKLINK command.

Unfortunately the parameters in the example have the wrong order.

Resolves: #46119
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: Ida960d79e0144c15afdd7c21a9cd35466ec24545
Reviewed-on: https://review.typo3.org/18807
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Install Tool: Error message gives wrong info 25/18325/3
Thomas Löffler [Sun, 17 Feb 2013 11:04:20 +0000 (12:04 +0100)]
[BUGFIX] Install Tool: Error message gives wrong info

Based on issue #45135 the change not only includes the
check for the variable length for typo_db_password, but
for typo_db, typo_db_host and typo_db_username as well.

Resolves: #45135
Releases: 4.5,4.7,6.0,6.1
Change-Id: Idcf45892a7b8836be31d2648b04252d1415e372b
Reviewed-on: https://review.typo3.org/18325
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Fix SQL syntax 76/18476/3
Michael Stucki [Tue, 26 Feb 2013 00:19:02 +0000 (01:19 +0100)]
[BUGFIX] Fix SQL syntax

Use single quotes to retain compatibility with PostgreSQL.

Change-Id: I07de0fea0320caed710911750240e35c66f3b679
Resolves: #45826
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18476
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Allow Setting colorspace in the Install Tool. 04/18804/4
Anja Leichsenring [Sat, 12 Jan 2013 10:50:37 +0000 (11:50 +0100)]
[BUGFIX] Allow Setting colorspace in the Install Tool.

Some versions of Imagemagick (6.7.0 and above) use the sRGB colorspace
instead RGB as before. This results in darker images after processing,
because TYPO3 hardcoded the RGB colorspace in graphical functions.

This patch introduces a setting in the GFX part of the Install Tool,
lets the user choose the sufficient colorspace.
This selection is used in graphical functions.

Additionaly a hint on the setting was added to the Image Processing Test
'Read Images' in the Install Tool.

Fixes: #36597
Releases: 6.1, 6.0, 4.7, 4.5
Change-Id: I50a26c414705afa3177a2f12fc3bb4532c2d0f7f
Reviewed-on: https://review.typo3.org/18804
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Deactivating "install" extension leads to exceptions 02/18802/3
Wouter Wolters [Tue, 27 Nov 2012 21:48:44 +0000 (22:48 +0100)]
[BUGFIX] Deactivating "install" extension leads to exceptions

Uninstalling the "install" extension leads to exceptions in
required system extensions like extensionmanager or lang.

The solution is to make "install" a required extension too.

Change-Id: Id5a0ebd9400648cd7c453d98b58e8cad1d155bd8
Fixes: #43361
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18802
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] RTE: Empty paragraphs are not correctly transformed 99/18799/2
Stanislas Rolland [Tue, 11 Dec 2012 16:00:36 +0000 (11:00 -0500)]
[BUGFIX] RTE: Empty paragraphs are not correctly transformed

Problem: Empty paragraphs entered in the RTE may get lost on way to
database if no block is found in content, as well as on way to the RTE
if followed by a block.
Solution: Fix both transformations and add multiple unit test
cases.

Releases: 4.5, 4.7, 6.0, 6.1
Resolves: #36904
Resolves: #26141

Change-Id: I6c5495fb668f29267bcdeb7b44814a4bb9dc0f96
Reviewed-on: https://review.typo3.org/18799
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] Clearing cache from toolbar fails in IE8 95/18795/2
Andreas Kießling [Sat, 23 Feb 2013 12:49:47 +0000 (13:49 +0100)]
[BUGFIX] Clearing cache from toolbar fails in IE8

Fix for regression in #45595 that was introduced with #36364
IE8 does not pass the click event to the handler function and thus
raises a JavaScript error. The event can be fetched from the window
object in this case.

Fixes: #45595
Releases: 6.1, 6.0, 4.7, 4.6, 4.5

Change-Id: I9ccd5c8ae660a34e404122d9dd1c816909688b3e
Reviewed-on: https://review.typo3.org/18795
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] pageNotFound_handling never happens 92/18792/3
Thorben Kapp [Sat, 2 Mar 2013 11:57:08 +0000 (12:57 +0100)]
[BUGFIX] pageNotFound_handling never happens

The function \TYPO3\CMS\Core\Utility\RootlineUtility::getRecordArray
throws a \RuntimeException that should be caught in
\TYPO3\CMS\Frontend\Page\PageRepository::getRootline. If the exception
is not caught, the page-not-found-handling is never triggered.

Fixes: #44454
Releases: 6.0, 6.1
Change-Id: I3988b46ebaa8e479ed3c70017a5dda6bc5eaceac
Reviewed-on: https://review.typo3.org/18792
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[BUGFIX] ExtensionManagementUtility tries to include non-existing files 91/18791/2
Dmitry Dulepov [Wed, 6 Mar 2013 17:51:13 +0000 (21:51 +0400)]
[BUGFIX] ExtensionManagementUtility tries to include non-existing files

Methods createExtLocalconfCacheEntry() and createExtTablesCacheEntry()
attempt to include files without checking if they exist. This causes
PHP warnings about non-existing files and looses time in a call to
GeneralUtility::getUrl().

Change-Id: Icbee0c8e6e9e0ada1dc48ac471006b6dc59adc6d
Resolves: #46074
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18791
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Update copyright year to 2013 86/18786/2
Ernesto Baschny [Thu, 7 Mar 2013 08:32:30 +0000 (09:32 +0100)]
[TASK] Update copyright year to 2013

Resolves: #46085
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: Ifc1b4199f17d385cf6ef3d7bc460b1f91e367fc0
Reviewed-on: https://review.typo3.org/18786
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
6 years ago[TASK] Update copyright year to 2013 82/18782/2
Ernesto Baschny [Thu, 7 Mar 2013 08:32:30 +0000 (09:32 +0100)]
[TASK] Update copyright year to 2013

Resolves: #46085
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: I970078281d129be8ffef0bef128b23354ce59ddd
Reviewed-on: https://review.typo3.org/18782
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
6 years ago[TASK] Set TYPO3 version to 6.0.5-dev 78/18778/2
TYPO3 Release Team [Thu, 7 Mar 2013 09:26:11 +0000 (10:26 +0100)]
[TASK] Set TYPO3 version to 6.0.5-dev

Change-Id: Id80061ffec1abd6bec4592c652d7993e9b89a40b
Reviewed-on: https://review.typo3.org/18778
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.0.4 77/18777/2
TYPO3 Release Team [Thu, 7 Mar 2013 09:26:03 +0000 (10:26 +0100)]
[RELEASE] Release of TYPO3 6.0.4

Change-Id: I83f8cb459f776820f939ceff98d318fd3ad8a542
Reviewed-on: https://review.typo3.org/18777
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUFIX] External URL regression by jumpurl security fix 65/18765/2
Helmut Hummel [Wed, 6 Mar 2013 14:47:57 +0000 (15:47 +0100)]
[BUFIX] External URL regression by jumpurl security fix

With the jumpurl security fix, pages of type
'Link to external URL' throw a jumpurl
hash exception if called in the frontend. This typically
happens if a HMENU renders such page links.

The patch adapts the TSFE logic to write the required
hash dynamically to _GET to make the jumpurl check happy
that is called later on within the same process if
calling such a 'external url' link.

Change-Id: Ie73cd9710929c72aad4e75543f90c8618797997b
Fixes: #46071
Related: #28587
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/18765
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Set TYPO3 version to 6.0.4-dev 48/18748/2
TYPO3 Release Team [Wed, 6 Mar 2013 11:35:42 +0000 (12:35 +0100)]
[TASK] Set TYPO3 version to 6.0.4-dev

Change-Id: Ied84dbe8f0b087b325705329414b7db0dc73b773
Reviewed-on: https://review.typo3.org/18748
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.0.3 47/18747/2
TYPO3 Release Team [Wed, 6 Mar 2013 11:35:33 +0000 (12:35 +0100)]
[RELEASE] Release of TYPO3 6.0.3

Change-Id: I962e723070598c7cf235bd7ff91432a38bb179ce
Reviewed-on: https://review.typo3.org/18747
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[TASK] Raise submodule pointer 39/18739/2
TYPO3 Release Team [Wed, 6 Mar 2013 11:02:55 +0000 (12:02 +0100)]
[TASK] Raise submodule pointer

Change-Id: I4c87c157f5b71a13cdb7b60ec695f15bee260b48
Reviewed-on: https://review.typo3.org/18739
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[SECURITY] Open redirection with jumpurl 32/18732/2
Franz G. Jahn [Wed, 6 Mar 2013 10:49:12 +0000 (11:49 +0100)]
[SECURITY] Open redirection with jumpurl

jumpurl allows redirect to any given URL. A hash on the url
is now required to know if the jumpurl has been created
by the system or by the outside.

The hook "jumpurlRedirectHandler" can be used to allow
redirects without hash or to custom redirects.

Fixes: #28587
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Change-Id: I63da18b1963ec50cd95dd49d1669c9873b7bab54
Security-Commit: db8748be003fdbd7fd179c239dd3dc92543e90bf
Security-Bulletin: TYPO3-CORE-SA-2013-001
Reviewed-on: https://review.typo3.org/18732
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] Fix warning in adapter service 00/18700/2
Helmut Hummel [Tue, 5 Mar 2013 16:39:26 +0000 (17:39 +0100)]
[BUGFIX] Fix warning in adapter service

The merge of #45415 introduced a warning
because the new meta column name was
used as array key.

Skip this step when the meta column
is found to fix this issue.

Fixes: #45415
Releases: 6.1, 6.0

Change-Id: I5446104359816d0ccacf6c239b86b9b073783174
Reviewed-on: https://review.typo3.org/18700
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[BUGFIX] Do not overwrite imagecaption in content adapter 99/18699/2
Helmut Hummel [Tue, 12 Feb 2013 16:57:19 +0000 (17:57 +0100)]
[BUGFIX] Do not overwrite imagecaption in content adapter

Problem:
Create a new content element of type file links,
add a file relation and a description to this file.
Switch this element to be an image element,
add an image and a description of the image

Expected result:
An image with the image description is shown

Actual result:
An image with the description of the file is shown.

Solution:
Check if the field actually is shown in the selected
content element type.

Fixes: #45415
Releases: 6.0, 6.1

Change-Id: I3aa0e47b336cfa881c637b7f5a9e68476ded88ae
Reviewed-on: https://review.typo3.org/18222
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18699

6 years ago[BUGFIX] Fix inconsitency of file reference property getters 98/18698/2
Helmut Hummel [Tue, 12 Feb 2013 17:32:23 +0000 (18:32 +0100)]
[BUGFIX] Fix inconsitency of file reference property getters

The FileReference object has the following getters
for getting properties:

getProperties()
getReferenceProperties()
getProperty($key)
getReferenceProperty($key)

The result from these getters is inconsistent:

getReferenceProperty($key)
Returns the value of a property which is only
in the reference properties

getReferenceProperties()
Returns merged properties form the original
file and the reference properties without
respecting overriding of reference properties
if they are not set to NULL

getProperty($key)
Returns the merged value from original file
and reference, respecting the NULL override
handling. But if a property is only available
in the original file an Exception is thrown.

getProperties()
Returns merged properties form the original
file and the reference properties
respecting overriding of reference properties
if they are not set to NULL
Properties only available in the original file
will be available in the resulting array.

Streamline the behaviour so that all getters
starting with "getReference" will only return
the properties of the reference record and all
other will return the merged properties but
respecting the NULL override handling.

Resolves: #45416
Releases: 6.0, 6.1

Change-Id: I35a84da83be765991b357c5cee89ce018a1f1e24
Reviewed-on: https://review.typo3.org/18223
Reviewed-by: Steffen Ritter
Tested-by: Wouter Wolters
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18698

6 years ago[BUGFIX] Wrong usage of array_unique() 94/18694/2
Andreas Lingott [Tue, 5 Mar 2013 07:31:16 +0000 (08:31 +0100)]
[BUGFIX] Wrong usage of array_unique()

RootlineUtility.php does not use return value of array_unique() call,
which makes the call ineffective.

This causes some huge SQL queries and increases page load time heavily.

Resolves: #46000
Releases: 6.1, 6.0
Change-Id: Ic614a22a97927cc433eab9e5bf1b6125d53b5882
Reviewed-on: https://review.typo3.org/18694
Tested-by: Andreas Lingott
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Michael Stucki
Tested-by: Michael Stucki
6 years ago[BUGFIX] Invalid replacement hints in t3lib/ 84/18584/2
Xavier Perseguers [Mon, 4 Mar 2013 07:38:56 +0000 (08:38 +0100)]
[BUGFIX] Invalid replacement hints in t3lib/

The comment and require_once call in deprecated classes are wrong.

Change-Id: I1d3e49bc977eef1c69551809596a5917a7ccf1f0
Fixes: #45998
Releases: 6.1, 6.0
Reviewed-on: https://review.typo3.org/18584
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
6 years ago[BUGFIX] Invalid SQL result after four login failures 83/18583/2
Philipp Gampe [Sun, 3 Mar 2013 20:07:32 +0000 (21:07 +0100)]
[BUGFIX] Invalid SQL result after four login failures

sql_free_result is called too early.
Move the call after the error handling at the end of the method.

Fixes: #45996
Releases: 6.0, 6.1
Change-Id: I54f1edb48e4c3b70629b46cbba365416c01c0917
Reviewed-on: https://review.typo3.org/18579
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/18583

6 years ago[TASK] Raise submodule pointer 66/18566/2
TYPO3 Release Team [Sun, 3 Mar 2013 08:41:45 +0000 (09:41 +0100)]
[TASK] Raise submodule pointer

Change-Id: Ie62df0cce2b394c2cbb4120d7638c2287befb7cb
Reviewed-on: https://review.typo3.org/18566
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] Make backend user global available early 87/18487/2
Helmut Hummel [Thu, 21 Feb 2013 14:01:02 +0000 (15:01 +0100)]
[BUGFIX] Make backend user global available early

The global must be available very early, because methods below
might trigger code which relies on it. In particular the workspace
overlay of the rootline which is done in certain cases.

Fixes: #45625
Releases: 6.0, 6.1
Change-Id: I035f27e11cd56fc284442b66ad8357060f76e52c
Reviewed-on: https://review.typo3.org/18420
Reviewed-by: Mattias Nilsson
Reviewed-by: Oliver Klee
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18487

6 years ago[BUGFIX] Fix of .zip exports of extension 44/18344/2
Jost Baron [Sat, 16 Feb 2013 13:43:22 +0000 (14:43 +0100)]
[BUGFIX] Fix of .zip exports of extension

Before this, all files of an extension where included into its
.zip export. Now $TYPO3_CONF_VARS['EXT']['excludeForPackaging']
is respected.

Also the function responsible for the export is cleaned up and uses
more core API than before.

Change-Id: I1c06084e4da3ee18014563572fd270ea1e4d3ec5
Fixes: #45404
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18344
Reviewed-by: Jigal van Hemert
Tested-by: Jigal van Hemert
6 years ago[BUGFIX] Invalid RSA key when submitting form twice 40/18340/2
Benjamin Mack [Tue, 15 Jan 2013 12:05:27 +0000 (13:05 +0100)]
[BUGFIX] Invalid RSA key when submitting form twice

When submitting a RSA-supported form twice, the JS error
"Invalid RSA public key" is thrown. In order to suppress
this double RSA decryption, an additional JS check is needed.
The change also modifies the minified version of the JS
done with http://refresh-sf.com/yui/

Change-Id: I7133e320c76e14a6f6855f477ba5a34e50eecf58
Resolves: #40085
Releases: 6.1, 6.0, 4.7, 4.6, 4.5
Reviewed-on: https://review.typo3.org/17541
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-on: https://review.typo3.org/18340

6 years ago[BUGFIX] Fix the display of references in filelist 35/18335/2
Helmut Hummel [Sat, 16 Feb 2013 20:53:31 +0000 (21:53 +0100)]
[BUGFIX] Fix the display of references in filelist

Currently references are not displayed
in the filelist module when trying to delete a file
which has been referenced.

Fixes: #45538
Releases: 6.0, 6.1
Change-Id: Id88bc954ab0002585ec6bb75dabba901784ddab5
Reviewed-on: https://review.typo3.org/18335
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Cleanup "beuser" sysext 22/18322/2
Wouter Wolters [Sun, 10 Feb 2013 14:53:14 +0000 (15:53 +0100)]
[TASK] Cleanup "beuser" sysext

This is a non-functional change that reformats the code, removes
unnecessary empty lines and fixes namespaces in phpDoc. In addition
the following to changes are made:
- add $GLOBALS['TYPO3_DB']->sql_free_result() calls to free some memory
- change bu:SpriteIconForRecord to bu:spriteIconForRecord in templates

Change-Id: I6e832921c46f828c9db0c796d662bd8390b5ac5f
Resolves: #45343
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18322
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[TASK] Cleanup "belog" sysext 21/18321/3
Wouter Wolters [Mon, 11 Feb 2013 21:08:49 +0000 (22:08 +0100)]
[TASK] Cleanup "belog" sysext

Reformats the code, fixes indents and removes extra empty lines. This is
not a functional change but a visual clean up.

Change-Id: I0d11dd7c43eee5d181c4bc0565c85d651c5c29e1
Resolves: #45392
Releases: 6.0, 6.1
Reviewed-on: https://review.typo3.org/18321
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
6 years ago[BUGFIX] LocalDriver needs to respect "is_writeable" 17/18317/2
Georg Ringer [Thu, 10 Jan 2013 09:37:21 +0000 (10:37 +0100)]
[BUGFIX] LocalDriver needs to respect "is_writeable"

The LocalDriver needs also to respect the flag "is_writeable".
This means: if the flag is not set, no folder/file can be edited/moved...

Fixes: #44370
Releases: 6.0, 6.1

Change-Id: I404ed51c62ab96d9b5eaaf6c0b7b255bdea3538b
Reviewed-on: https://review.typo3.org/18317
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
6 years ago[TASK] Set TYPO3 version to 6.0.3-dev 84/18284/2
TYPO3 Release Team [Thu, 14 Feb 2013 15:50:27 +0000 (16:50 +0100)]
[TASK] Set TYPO3 version to 6.0.3-dev

Change-Id: I99ae446f9ecfef13b7f6e0b553f826446fd0504a
Reviewed-on: https://review.typo3.org/18284
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[RELEASE] Release of TYPO3 6.0.2 83/18283/2
TYPO3 Release Team [Thu, 14 Feb 2013 15:50:17 +0000 (16:50 +0100)]
[RELEASE] Release of TYPO3 6.0.2

Change-Id: I9c9635363f5022c8c21fe34b7b6d67bb676cfbd4
Reviewed-on: https://review.typo3.org/18283
Reviewed-by: TYPO3 Release Team
Tested-by: TYPO3 Release Team
6 years ago[BUGFIX] L10n fallback does not work for TS labels 70/18270/2
Xavier Perseguers [Thu, 20 Dec 2012 06:59:15 +0000 (07:59 +0100)]
[BUGFIX] L10n fallback does not work for TS labels

When retrieving a label in TypoScript in a locale that is not
available locally, the English label is returned instead of
using the locale fallback mechanism introduced in TYPO3 4.6.

Change-Id: I29f4b25e3fc23497d6afe74659810ca8995a39df
Fixes: #44099
Relates: #41996
Releases: 4.6, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/17247
Reviewed-by: Mattias Nilsson
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/18270

6 years ago[BUGFIX] L10n fallback does not work for ExtJS in BE 66/18266/2
Xavier Perseguers [Wed, 2 Jan 2013 17:56:09 +0000 (18:56 +0100)]
[BUGFIX] L10n fallback does not work for ExtJS in BE

PageRenderer does not take language dependency into account when reading
localization files to be included as JavaScript labels.

Change-Id: I23d12dd06a99e72968a26d5930decb87901e8af6
Fixes: #44273
Releases: 4.6, 4.7, 6.0, 6.1
Reviewed-on: https://review.typo3.org/17313
Reviewed-by: Mattias Nilsson
Reviewed-by: Begoña Garea Garcia
Tested-by: Begoña Garea Garcia
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-on: https://review.typo3.org/18266