Packages/TYPO3.CMS.git
20 months ago[BUGFIX] Fix imagemagick commands when setting stripProfile to "0" 90/51990/5
Paul Golmann [Thu, 9 Mar 2017 11:12:50 +0000 (12:12 +0100)]
[BUGFIX] Fix imagemagick commands when setting stripProfile to "0"

Remove the ###SkipStripProfile### flag from command parameters added
by e.g. stripProfile in TypoScript if
GFX[processor_stripColorProfileByDefault] is disabled in global
configuration to prevent erroneous imagemagick commands.

Resolves: #80208
Releases: master, 8.7
Change-Id: I0860744ad4b27e44f1d9f7bb6da5dd646f4a1fc4
Reviewed-on: https://review.typo3.org/51990
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Properly append/prepend with "addRecord" wizard 26/55826/5
Mathias Brodala [Tue, 20 Feb 2018 14:47:59 +0000 (15:47 +0100)]
[BUGFIX] Properly append/prepend with "addRecord" wizard

For relations the internal field value contains a list of UIDs instead
of full related records.

Resolves: #82461
Releases: master, 8.7
Change-Id: Iec2a74fbc8d17636dd8751911984c337d4e99b63
Reviewed-on: https://review.typo3.org/55826
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Tested-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Stop monkey patching CacheManager configuration in InstallTool 71/55971/2
Benjamin Franzke [Thu, 1 Mar 2018 15:51:27 +0000 (16:51 +0100)]
[TASK] Stop monkey patching CacheManager configuration in InstallTool

Instead of creating the cacheManager and then disabling all cache
confiurations afterwards, the desired state is enforced inside the
CacheManager now (controlled through a constructor parameter).

Releases: master
Resolves: #84107
Change-Id: Ia3623a96246d97b74ee48eb2022ba35d5bcfcc04
Reviewed-on: https://review.typo3.org/55971
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Put commit hooks into Build/git-hooks directory 12/55712/26
Sybille Peters [Wed, 14 Feb 2018 09:41:20 +0000 (10:41 +0100)]
[TASK] Put commit hooks into Build/git-hooks directory

* commit-msg hook: change wiki link to link to official contribution guide
* commit-msg hook: rebase with original source
* commit-msg hook: add Change-Id on last line after footer
* pre-commit hook: check if staged php files conform to coding guidelines
* Build/Scripts/cglFixMyCommit.sh: extended
  parameters to be used by new pre-commit hook

Resolves: #83891
Releases: master, 8.7, 7.6
Change-Id: I6d00aa32ef3f9517d88e90c40059c7f73d7f6cfe
Reviewed-on: https://review.typo3.org/55712
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Update typo3fluid/fluid to 2.5.1 56/55956/2
Markus Klein [Wed, 28 Feb 2018 22:04:45 +0000 (23:04 +0100)]
[TASK] Update typo3fluid/fluid to 2.5.1

- Allows any protocol or wrapper for template sources
- Ignores empty path specifications

composer command used:
composer update typo3fluid/fluid

Resolves: #84095
Releases: master, 8.7
Change-Id: I52380fe465b112df73ab86c570f6a12d2eedf4d3
Reviewed-on: https://review.typo3.org/55956
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Rename an 'important...rst' to 'Important...rst' 70/55970/2
Christian Kuhn [Thu, 1 Mar 2018 15:43:36 +0000 (16:43 +0100)]
[BUGFIX] Rename an 'important...rst' to 'Important...rst'

Change-Id: Iddf30ed9c58bf94fe24021fd5b08ef2aed366eec
Resolves: #84106
Related: #84086
Releases: master
Reviewed-on: https://review.typo3.org/55970
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Remove undocumented values from Soft Reference Index data 39/55939/2
Markus Klein [Wed, 28 Feb 2018 14:28:06 +0000 (15:28 +0100)]
[BUGFIX] Remove undocumented values from Soft Reference Index data

The fix for #80991 introduced new data in the data structure returned
by the SoftReferenceIndex class' methods.
This new data stems from LinkHandlers, which may provide arbitrary
data. This causes side effects for consumers of the SoftReferenceIndex
like the reference index and the export functionality.

By removing this extra data - which is not used anywhere at all - the
returned data is again conforming to what is documented and keeps
the interface to the SoftReferenceIndex clean.

Resolves: #84080
Releases: master, 8.7
Change-Id: Ic39a8b593cb239aca698e857d1ee602bdeaf229f
Reviewed-on: https://review.typo3.org/55939
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Move Page ID resolving to PSR-15 middleware 61/55961/6
Benni Mack [Thu, 1 Mar 2018 07:29:09 +0000 (08:29 +0100)]
[TASK] Move Page ID resolving to PSR-15 middleware

The next PSR-15 middleware is introduced that was previously part of the
Frontend Request Handler. It defines the actual (current) implementation
to determine the Page ID and GET/POST parameters handled in TSFE.

A possible alternative could be a Router doing the same process at this
very position currently.

Resolves: #84096
Releases: master
Change-Id: I6aa9b5f35183034a8ebb93258d085acafb93862a
Reviewed-on: https://review.typo3.org/55961
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[BUGFIX] Fix linktype selection in Linkvalidator report 72/55872/5
Sybille Peters [Thu, 22 Feb 2018 13:46:42 +0000 (14:46 +0100)]
[BUGFIX] Fix linktype selection in Linkvalidator report

* handle uninitialized values
* do not show all results in report if no linktypes checked

Resolves: #84010
Releases: master, 8.7
Change-Id: Id04d2eed1b1390f2cbf67fd971d7cc4d61539f15
Reviewed-on: https://review.typo3.org/55872
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
20 months ago[TASK] Decouple SystemEnvironmentBuilder from Bootstrap 63/55963/6
Benjamin Franzke [Thu, 1 Mar 2018 10:04:43 +0000 (11:04 +0100)]
[TASK] Decouple SystemEnvironmentBuilder from Bootstrap

Do not rely on defined constants or methods from Bootstrap
to be usable on it own (later).
This is a preparatory refactoring to make the Application/Bootstrap
unaware of the entryPointLevel handling.

Releases: master
Resolves: #84099
Change-Id: Ia2b3b47062db87139e446c928faee75890ffec08
Reviewed-on: https://review.typo3.org/55963
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Make stateless Bootstrap methods static 75/55775/11
Benjamin Franzke [Sat, 17 Feb 2018 15:00:58 +0000 (16:00 +0100)]
[TASK] Make stateless Bootstrap methods static

Methods that do not use $this but mainly act as utility
may be used statically.
The previous non-static chainable behaviour is preserved
by returning static::$instance. (Invoking a static method
non statically does not trigger E_NOTICE or alike.)

The motivation for this change is to deprecate the
Bootstrap instanciated usage at some (later) point
in order to reduce global state.

The following methods are affected:
 * initializeLanguageObject
 * initializeBackendAuthentication
 * initializeBackendUser
 * initializeBackendRouter
 * loadExtTables
 * loadBaseTca
 * loadTypo3LoadedExtAndExtLocalconf
 * unsetReservedGlobalVariables
 * startOutputBuffering
 * disableCoreCache

Releases: master
Resolves: #83952
Change-Id: I59d3027c5d10326d7bab2ae02e6ff0eb836f23e4
Reviewed-on: https://review.typo3.org/55775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[TASK] Use null comparison instead of is_null 50/55950/3
Wouter Wolters [Wed, 28 Feb 2018 20:25:50 +0000 (21:25 +0100)]
[TASK] Use null comparison instead of is_null

Resolves: #84091
Releases: master
Change-Id: I61c24937b919ec54c6547c07d1c4460186725c96
Reviewed-on: https://review.typo3.org/55950
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Remove implement statement if parent already implements the interface 55/55955/6
Wouter Wolters [Wed, 28 Feb 2018 20:46:37 +0000 (21:46 +0100)]
[TASK] Remove implement statement if parent already implements the interface

Resolves: #84094
Releases: master
Change-Id: I0fff99f75287fd5a43093b5df540cea040420d21
Reviewed-on: https://review.typo3.org/55955
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Remove unused use statements 49/55949/4
Wouter Wolters [Wed, 28 Feb 2018 20:05:50 +0000 (21:05 +0100)]
[TASK] Remove unused use statements

Resolves: #84090
Releases: master
Change-Id: Ia2a34856b3b8066906125d7efed593e9291f476c
Reviewed-on: https://review.typo3.org/55949
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[TASK] Migrate OnlineMedia to TypeScript 54/55954/3
Andreas Fernandez [Wed, 28 Feb 2018 20:40:03 +0000 (21:40 +0100)]
[TASK] Migrate OnlineMedia to TypeScript

Resolves: #82600
Releases: master
Change-Id: Ie7b86399f0a75706b1072a3c41e162ab2992a8b0
Reviewed-on: https://review.typo3.org/55954
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Migrate ContextMenuActions to TypeScript 74/55874/4
Andreas Fernandez [Fri, 23 Feb 2018 13:46:29 +0000 (14:46 +0100)]
[TASK] Migrate ContextMenuActions to TypeScript

Change-Id: If8a9b89295256491eb8bcc0e9afb1f37849050fc
Resolves: #82581
Releases: master
Reviewed-on: https://review.typo3.org/55874
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Migrate AjaxDataHandler to TypeScript 08/55908/3
Andreas Fernandez [Mon, 26 Feb 2018 19:11:24 +0000 (20:11 +0100)]
[TASK] Migrate AjaxDataHandler to TypeScript

Change-Id: I151598e90487811217dfa685dcb83081848f2bb6
Resolves: #82578
Releases: master
Reviewed-on: https://review.typo3.org/55908
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Clean up workspace preview top bar 31/55931/7
Benni Mack [Tue, 27 Feb 2018 20:11:20 +0000 (21:11 +0100)]
[TASK] Clean up workspace preview top bar

The preview controller is now not attached to the backend module anymore,
as the Preview functionality ("Split Bar on top") is technically a completely
separate backend preview and completely unrelated to the workspaces
Backend Module.

This change also removes several hacks to generate Backend URLs.

Resolves: #84074
Releases: master
Change-Id: Id0ce7093f6d3ac94c8e4a9cfecd78027d26d45df
Reviewed-on: https://review.typo3.org/55931
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Finalize rowDescription for sys_file_collection 53/55953/2
Josef Glatz [Wed, 28 Feb 2018 20:33:22 +0000 (21:33 +0100)]
[BUGFIX] Finalize rowDescription for sys_file_collection

Add missing TCA configuration for descriptionColumn in
sys_file_collection records. The database column already
exists in ext_tables.sql.

Change-Id: I696e982145604114181240bef321683569187bcd
Resolves: #84093
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55953
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[BUGFIX] Return correct query part in ContentObjectRenderer::searchWhere 14/55914/2
Georg Ringer [Tue, 27 Feb 2018 06:44:11 +0000 (07:44 +0100)]
[BUGFIX] Return correct query part in ContentObjectRenderer::searchWhere

Avoid using a prepared statement to return the final query part.

Resolves: #84022
Releases: master, 8.7
Change-Id: I31c44172221962c1dbb3d97d02f6cfa61449d20a
Reviewed-on: https://review.typo3.org/55914
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Sven Juergens <typo3@blue-side.de>
Tested-by: Sven Juergens <typo3@blue-side.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Add space in lockedRecords messages for translated languages 48/55948/3
Josef Glatz [Wed, 28 Feb 2018 19:03:55 +0000 (20:03 +0100)]
[BUGFIX] Add space in lockedRecords messages for translated languages

The space between the time amount and time unit must be
added directly in the code, as it's not possible to add a leading
space character in a localized string on our translation server.

- use GeneralUtility::trimExplode() for localized label parameter
- add space directly in the code instead of the LLL string

Already translated strings must not be adopted.

Change-Id: Iefeb1a4ed202a4110535fe62d13ce8691a10a80d
Resolves: #84088
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55948
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[TASK] Notification change for chrome is Important, not Breaking 45/55945/2
Christian Kuhn [Wed, 28 Feb 2018 16:30:34 +0000 (17:30 +0100)]
[TASK] Notification change for chrome is Important, not Breaking

Patch for issue #83971 is only an Important change, not
a breaking change and belongs to the 8.7.x documentation
folder to stay in sync with v8

Change-Id: I1314eda5dbf90af5e61b940ad1431b82bd28b0de
Resolves: #84086
Related: #83971
Releases: master
Reviewed-on: https://review.typo3.org/55945
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Consistently retrieve ApplicationContext from GeneralUtility 40/55940/4
Benjamin Franzke [Sun, 25 Feb 2018 12:34:58 +0000 (13:34 +0100)]
[TASK] Consistently retrieve ApplicationContext from GeneralUtility

As documented in Bootstrap code, GeneralUtility should be
used instead of Bootstrap to retrieve the ApplicationContext.

Therefore ClassLoadingInformation is adapted to read the
ApplicationContext from GeneralUtility. Bootstrap now pushes the
ApplicationContext early to GeneralUtility to be available for
ClassLoadingInformation during bootstrap.

Change-Id: I119ac944dd49c7d063b0f1e05f23e48f664ce2bc
Releases: master
Resolves: #84083
Reviewed-on: https://review.typo3.org/55940
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[!!!][BUGFIX] Allow browser notifications only on encrypted connection 16/55916/7
Frank Naegler [Tue, 27 Feb 2018 09:36:36 +0000 (10:36 +0100)]
[!!!][BUGFIX] Allow browser notifications only on encrypted connection

Google Chrome deprecated the browser notification API for unencrypted
origins. For this reason we now use an additional check to prevent
deprecation warnings in the console and disable this feature for
instances without SSL/TLS.

Resolves: #83971
Releases: master, 8.7
Change-Id: I9721842159e7ad3da9e5f4ee93a9bce3eaf5d0eb
Reviewed-on: https://review.typo3.org/55916
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Inject requestId into LogRecords 38/55938/3
Benjamin Franzke [Sun, 18 Feb 2018 20:11:21 +0000 (21:11 +0100)]
[TASK] Inject requestId into LogRecords

Do not use global state from Bootstrap::getInstance(), rather pass
the requestId from LogManager through the Logger to the LogRecord.

We do not have a core object container yet, therefore Bootstrap now
creates a LogManager, injects the requestId and stores that instance
as singleton in the GeneralUtility singleton storage.

Change-Id: Ia9af3c3a0e029a3748045fcf73e92f874f4a37ba
Releases: master
Resolves: #84082
Reviewed-on: https://review.typo3.org/55938
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[!!!][TASK] Remove request type specific code in Bootstrap 92/55692/8
Benjamin Franzke [Mon, 12 Feb 2018 18:00:56 +0000 (19:00 +0100)]
[!!!][TASK] Remove request type specific code in Bootstrap

As all request type specific initialization has been
refactored to the Application classes, request type
specific code in Bootstrap is unused [1] and can
be removed.

[1] redirectToInstallTool() is actually still in use, but moved
into the frontend and backend Application classes with this change.
(Also make their parent class abstract as drive-by change.)

Change-Id: Ieded3603c2936d83d3d4701abef6c3884b558e31
Releases: master
Resolves: #83869
Reviewed-on: https://review.typo3.org/55692
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Avoid renumbering array keys on writing configuration 36/55936/2
Helmut Hummel [Wed, 28 Feb 2018 12:41:49 +0000 (13:41 +0100)]
[BUGFIX] Avoid renumbering array keys on writing configuration

Renumbering array keys, even if all keys are integer
is a destructive operation.
Doing so at least breaks our logging configuration,
which uses LogLevel constants as array keys and these constants
are defined as integer.

Therefore this pure visual optimization is removed
when writing LocalConfiguration.php

At a later point we might consider deprecating this
method, which at least has a wrong method name
(mentions "numeric", while it meanwhile uses "int" checks).
As this method performs a destructive operation,
its usefulness is limited.

Resolves: #82304
Releases: master, 8.7, 7.6
Change-Id: I8d252428f3e27379e4377d30af0fdfd5e5d8719d
Reviewed-on: https://review.typo3.org/55936
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
20 months ago[TASK] Improve strictness of resource access blocking in _.htaccess 37/55937/3
Markus Klein [Wed, 28 Feb 2018 12:50:53 +0000 (13:50 +0100)]
[TASK] Improve strictness of resource access blocking in _.htaccess

For Apache HTTP versions 2.3+ there is a better way to avoid conflicts
in priority of sections. Since the `if` condition has been introduced
it is ranked the highest priority, hence it is most suitable for
rules to protect sensitive data.

Resolves: #81849
Releases: master, 8.7
Change-Id: I3f6edf1e3af55dc3ce901080045c8d353eb89ef9
Reviewed-on: https://review.typo3.org/55937
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[!!!][TASK] Migrate sys_notes away from extbase 04/55804/6
Georg Ringer [Mon, 19 Feb 2018 18:32:24 +0000 (19:32 +0100)]
[!!!][TASK] Migrate sys_notes away from extbase

Simplify the sys_note handling by removing extbase from it

Resolves: #84055
Releases: master
Change-Id: Ib41d5e88c7ec9d79ee23dc913c3dc1ee0184c372
Reviewed-on: https://review.typo3.org/55804
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
20 months ago[TASK] Log warning if a custom BE login image couldn't be resolved 11/55911/15
Tobias Kretschmann [Wed, 28 Feb 2018 11:11:36 +0000 (12:11 +0100)]
[TASK] Log warning if a custom BE login image couldn't be resolved

Log a warning message if the configured TYPO3 backend login
- logo or
- background image
can't get resolved.

Change-Id: I782a9b08650d9b2f9cfb3cefb9c4ba18577d5a7d
Resolves: #84050
Releases: master
Reviewed-on: https://review.typo3.org/55911
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[FEATURE] Provide VH to render icons for resources 59/55759/13
Georg Ringer [Fri, 16 Feb 2018 18:19:06 +0000 (19:19 +0100)]
[FEATURE] Provide VH to render icons for resources

Provide a ViewHelper to render the markup to show
an icon for files and folders.

Resolves: #83942
Releases: master
Change-Id: I44a99f3e06dc35b98b3e29f509432a8575c29807
Reviewed-on: https://review.typo3.org/55759
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
20 months ago[BUGFIX] Initiate correct storage of processed file during reconstitution 27/55927/3
Frans Saris [Tue, 27 Feb 2018 16:07:25 +0000 (17:07 +0100)]
[BUGFIX] Initiate correct storage of processed file during reconstitution

Releases: master, 8.7
Resolves: #84069
Change-Id: Idd642770341ddd5513c650e5ae230bcb5e7e6824
Reviewed-on: https://review.typo3.org/55927
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[BUGFIX] Make sure that mass actions actually process all changes 33/55933/6
Benedikt Huß [Wed, 28 Feb 2018 08:37:12 +0000 (09:37 +0100)]
[BUGFIX] Make sure that mass actions actually process all changes

Evaluate number of total items and trigger subsequent requests to
process the remaining items, so that all changes are actually
processed.

Resolves: #84037
Releases: master, 8.7
Change-Id: I92f388b50328320973abcc290de52083f05655dd
Reviewed-on: https://review.typo3.org/55933
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Remove unused workspace_preview DB field 71/55871/7
Benni Mack [Fri, 23 Feb 2018 10:24:25 +0000 (11:24 +0100)]
[TASK] Remove unused workspace_preview DB field

The unused BE_USER method setWorkspacePreview()
updates a DB field called "workspace_preview_id" which just
does not exist at all. It would lead to an SQL error if called.

However, since this method is never called, nor evaluated since TYPO3 6.2,
all functionality should be removed. Previewing a workspace is handled
via `be_users.workspace_id` anyway.

Resolves: #84021
Releases: master
Change-Id: I706e893aef1faaccf6e43f0e66ac28bff79190d8
Reviewed-on: https://review.typo3.org/55871
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Migrate Viewport to TypeScript 94/55894/7
Andreas Fernandez [Sun, 25 Feb 2018 16:42:19 +0000 (17:42 +0100)]
[TASK] Migrate Viewport to TypeScript

Change-Id: Iafb5d62329d70704aac0dc73f8a6254e2745ffea
Resolves: #82611
Releases: master
Reviewed-on: https://review.typo3.org/55894
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Update jQuery 3.2.1 ❯ 3.3.1 21/55921/8
Frank Naegler [Tue, 27 Feb 2018 12:06:35 +0000 (13:06 +0100)]
[TASK] Update jQuery 3.2.1 ❯ 3.3.1

Needs a typo3/testing-framework raise, too.

Commands:
yarn upgrade jquery
composer update typo3/testing-framework

Updates:
- jquery@3.3.1

Resolves: #84063
Releases: master
Change-Id: Iec4e821ebeb42c46da7d379ea081f3c0f25cc112
Reviewed-on: https://review.typo3.org/55921
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Trigger 404 for subpage shortcuts w/o subpages 05/50805/6
Claus Due [Tue, 29 Nov 2016 13:41:30 +0000 (14:41 +0100)]
[BUGFIX] Trigger 404 for subpage shortcuts w/o subpages

This patch adds a try/catch around the call in TSFE to get
page and rootline with domain and makes getPageShortcut
function set $this->pageNotFound code, then throw error.

Change-Id: Id6aae04d7b4c2a8b267b0d949c056471c3a6b01b
Releases: master
Resolves: #78831
Reviewed-on: https://review.typo3.org/50805
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Upgrade grunt-contrib-uglify 2.0.0 ❯ 3.3.0 32/55932/4
Andreas Fernandez [Wed, 28 Feb 2018 06:48:52 +0000 (07:48 +0100)]
[TASK] Upgrade grunt-contrib-uglify 2.0.0 ❯ 3.3.0

Commands:
yarn upgrade grunt-contrib-uglify --latest

Upgrades:
uglify-js 2.7.5 > 3.3.12

Change-Id: I082a92d87ef1616488c0d8ddcf3801617a37eb50
Resolves: #84075
Releases: master
Reviewed-on: https://review.typo3.org/55932
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[BUGFIX] Avoid PHP warnings within DatePickerViewHelper 22/55922/7
Ralf Zimmermann [Tue, 27 Feb 2018 13:47:58 +0000 (14:47 +0100)]
[BUGFIX] Avoid PHP warnings within DatePickerViewHelper

Avoid PHP warnings within ext:form DatePickerViewHelper if the property
properties.additionalAttributes.placeholder is not defined within
the form definition.

Releases: master, 8.7
Resolves: #84065
Change-Id: I49e0bb3a9548f0be402e1a4794c60c1b42744fac
Reviewed-on: https://review.typo3.org/55922
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Update chosen-js 1.8.2 ❯ 1.8.3 20/55920/2
Frank Naegler [Tue, 27 Feb 2018 11:47:56 +0000 (12:47 +0100)]
[TASK] Update chosen-js 1.8.2 ❯ 1.8.3

Commands:
yarn upgrade chosen-js

Updates:
- chosen-js@1.8.3

Resolves: #84061
Releases: master
Change-Id: Ic22da5e322ac5ad969f72cedfe7593e3976dff4d
Reviewed-on: https://review.typo3.org/55920
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Move preview setting evaluation in separate method 13/55913/2
Benni Mack [Tue, 27 Feb 2018 06:15:39 +0000 (07:15 +0100)]
[TASK] Move preview setting evaluation in separate method

The TSFE method "determineId" is hard to read, mostly due to
the fact that it first evaluates preview settings from admin panel
or logged-in backend users, and then calls "fetch_the_id()" possibly
multiple times.

In order to increase readability, the preview settings evaluation
is moved into a custom protected method within TSFE.

Resolves: #84056
Releases: master
Change-Id: I9611801b77ab10f0e9407f2c558cbec1867cc560
Reviewed-on: https://review.typo3.org/55913
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Update build tool dependencies 18/55918/3
Frank Naegler [Tue, 27 Feb 2018 11:39:06 +0000 (12:39 +0100)]
[TASK] Update build tool dependencies

Commands:
yarn upgrade grunt
yarn upgrade grunt-sass
yarn upgrade jasmine-core

Updates:
- grunt@1.0.2
- grunt-sass@2.1.0
- jasmine-core@2.99.1

Resolves: #84059
Releases: master
Change-Id: I833e2883c49a20cb5d748cb9d96b9e0cfb3f0d79
Reviewed-on: https://review.typo3.org/55918
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[TASK] Update @types definitions 17/55917/2
Frank Naegler [Tue, 27 Feb 2018 11:31:47 +0000 (12:31 +0100)]
[TASK] Update @types definitions

Commands:
yarn upgrade @types/bootstrap
yarn upgrade @types/jasmine
yarn upgrade @types/jqueryui

Updates:
- @types/bootstrap@3.3.38
- @types/jasmine@2.8.6
- @types/jqueryui@1.12.2

Resolves: #84058
Releases: master
Change-Id: I0cca00b6acc1cf8b4d9ed5ce1c09b73dc5bcfc07
Reviewed-on: https://review.typo3.org/55917
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[TASK] Update codemirror 5.33.0 ❯ 5.35.0 19/55919/2
Frank Naegler [Tue, 27 Feb 2018 11:45:08 +0000 (12:45 +0100)]
[TASK] Update codemirror 5.33.0 ❯ 5.35.0

Command:
yarn upgrade codemirror

Updates:
- codemirror@5.35.0

Resolves: #84060
Releases: master
Change-Id: I5e62d8ba0a7e2e51143a4d0438b7220ef72f80d1
Reviewed-on: https://review.typo3.org/55919
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[FEATURE] New API for the admin panel 90/55890/6
Susanne Moog [Sun, 25 Feb 2018 11:21:31 +0000 (12:21 +0100)]
[FEATURE] New API for the admin panel

The admin panel consisted of one big god class
that contained the complete rendering.

The hook to extend the admin panel only allowed to
add content but not to add new modules (with expandable
headers).

The code has been refactored as a first step for a more
flexible admin panel:

- All modules are now rendered by a class per module
- Modules have an interface
- Modules can be registered in ext_localconf (and overwritten) using
the dependency ordering service for priority
- All new classes are strictly typed

Related: #84044
Resolves: #84045
Releases: master
Change-Id: I124bb503907dcfcbd4425d6f7178b87562d2fda4
Reviewed-on: https://review.typo3.org/55890
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Correctly handle identical arrays in arrayDiffAssocRecursive 23/55923/4
Markus Klein [Tue, 27 Feb 2018 14:57:58 +0000 (15:57 +0100)]
[BUGFIX] Correctly handle identical arrays in arrayDiffAssocRecursive

Add a new test to make sure that identical input arrays also deliver
an empty result as difference.

Resolves: #84067
Releases: master, 8.7, 7.6
Change-Id: Ia16ca9560094c4ae42eb69cac9e09cd4bef7dc4e
Reviewed-on: https://review.typo3.org/55923
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[TASK] Migrate NewMultiplePages to TypeScript 10/55910/2
Andreas Fernandez [Mon, 26 Feb 2018 20:12:59 +0000 (21:12 +0100)]
[TASK] Migrate NewMultiplePages to TypeScript

Change-Id: I3fb32010cbbf319ddc35a9c0e13a771625e9c5be
Resolves: #82598
Releases: master
Reviewed-on: https://review.typo3.org/55910
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[TASK] Streamline PHP assignments and comments 15/55915/2
Benni Mack [Tue, 27 Feb 2018 06:53:59 +0000 (07:53 +0100)]
[TASK] Streamline PHP assignments and comments

Use shortening parameters on places that haven't been touched in a while
since PHP 7.0 was a requirement.

Fix PHPdoc comments on various places.

Use booleans instead of integers on variables clearly defined and evaluated
as booleans.

Resolves: #84057
Releases: master
Change-Id: If0ef1a58622a98f4ae5769f953c4c62121abdc89
Reviewed-on: https://review.typo3.org/55915
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[TASK] Migrate PageActions to TypeScript 02/55902/3
Andreas Fernandez [Mon, 26 Feb 2018 08:41:10 +0000 (09:41 +0100)]
[TASK] Migrate PageActions to TypeScript

Change-Id: I070facc7961d59b2151178810f3b77e6928607e0
Resolves: #82601
Releases: master
Reviewed-on: https://review.typo3.org/55902
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Migrate SplitButtons to TypeScript 06/55906/3
Andreas Fernandez [Mon, 26 Feb 2018 15:27:01 +0000 (16:27 +0100)]
[TASK] Migrate SplitButtons to TypeScript

The SplitButtons module is migrated to TypeScript. Additionally, some
parameters of the Icons module are declared as optional.

Change-Id: I61f883e8e496e018a45f63c303de66274d071d94
Resolves: #82602
Releases: master
Reviewed-on: https://review.typo3.org/55906
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Declare arguments 3 - 5 in Icons.getIcon() as optional 09/55909/2
Andreas Fernandez [Mon, 26 Feb 2018 19:15:08 +0000 (20:15 +0100)]
[BUGFIX] Declare arguments 3 - 5 in Icons.getIcon() as optional

The arguments `overlayIdentifier`, `state` and `markupIdentifier` are
not required most times. This patch declares these arguments as optional.

Change-Id: Id6d372be1d814763f2bf432254ac34b6b0d39f54
Resolves: #84048
Releases: master
Reviewed-on: https://review.typo3.org/55909
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[TASK] Migrate DateTimePicker to TypeScript 07/55907/2
Andreas Fernandez [Mon, 26 Feb 2018 18:22:51 +0000 (19:22 +0100)]
[TASK] Migrate DateTimePicker to TypeScript

Change-Id: I7783157819cebea7c4ee55a0b0612483daf9cbf3
Resolves: #82582
Releases: master
Reviewed-on: https://review.typo3.org/55907
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Migrate Modal to TypeScript 47/55847/10
Andreas Fernandez [Tue, 20 Feb 2018 21:56:24 +0000 (22:56 +0100)]
[TASK] Migrate Modal to TypeScript

Change-Id: Ic71a3dde434402ad828e2098eefae80f4039475b
Resolves: #82596
Releases: master
Reviewed-on: https://review.typo3.org/55847
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Prevent duplicating icons definition in the page tree 04/55904/4
Paweł Rogowicz [Mon, 26 Feb 2018 12:56:50 +0000 (13:56 +0100)]
[BUGFIX] Prevent duplicating icons definition in the page tree

Additionally add a console warning when doktype doesn't have an icon

Releases: master, 8.7
Resolves: #84018
Change-Id: If220a53e1dacf4d5b4fabdfcfc25331e83fe6811
Reviewed-on: https://review.typo3.org/55904
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
20 months ago[TASK] Consolidate singleton retrieval 02/55802/7
Benjamin Franzke [Sat, 17 Feb 2018 21:43:01 +0000 (22:43 +0100)]
[TASK] Consolidate singleton retrieval

There is Bootstrap::getInstance()->getEarlyInstance() and
GeneralUtility::makeInstance() to retrieve (global) early instances.
Sometimes the former, sometimes the latter is used (e.g. to
retrieve the PackageManager).

Classes should not know whether something is an early
instance or not. Implementation details like that should be
abstracted into a singleton container. That (currently) is
GeneralUtility::makeInstance().

As there is no obvious reason why different methods are used,
we now use GenerallyUtility::makeInstance() to retrieve singletons.

Add all early singleton instances to the GeneralUtility singleton array
and stop using Bootstrap::getEarlyInstance in classes outside Bootstrap.

One exception to this is the composer ClassLoader. That (obviously)
does not implement the TYPO3 SingletonInterface.
We now push that instance to ClassLoadingInformation during the
bootstrap. (similar to how the PackageManager is pushed to the
ExtensionManagementUtility).

Releases: master
Resolves: #83966
Change-Id: Icf3bef5f51a6142d9d1dcdc9b3700a86d7bb7f78
Reviewed-on: https://review.typo3.org/55802
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Migrate Toolbar to TypeScript 91/55891/2
Andreas Fernandez [Sun, 25 Feb 2018 12:16:23 +0000 (13:16 +0100)]
[TASK] Migrate Toolbar to TypeScript

Change-Id: Iab7de8a076a8d0d9249504dd487278e57a6b9ba4
Resolves: #82606
Releases: master
Reviewed-on: https://review.typo3.org/55891
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Move workspaces preview hook to PSR-15 middleware 99/55899/5
Benni Mack [Mon, 26 Feb 2018 06:02:27 +0000 (07:02 +0100)]
[TASK] Move workspaces preview hook to PSR-15 middleware

Frontend-related hooks are migrated into a PSR-15
compatible middleware to initialize workspace behaviour
and previewing functionality.

Resolves: #84040
Releases: master
Change-Id: I8a86665aad95a84d4d65700949d861b96d006c13
Reviewed-on: https://review.typo3.org/55899
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Call getDomainStartPage without third parameter 01/55901/2
Benni Mack [Mon, 26 Feb 2018 08:39:55 +0000 (09:39 +0100)]
[TASK] Call getDomainStartPage without third parameter

The third parameter in PageRepository->getDomainStartPage
is not used anymore. Saving an extra call to GeneralUtility
to not hand this parameter over to the method in TSFE should be helpful.

However, in the future, this method will probably be changed,
the third parameter is not deprecated for now.

Resolves: #84043
Releases: master
Change-Id: I397dd86d703f4fa5778794209e90ffaa82baf872
Reviewed-on: https://review.typo3.org/55901
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[TASK] Clean up user permission checking in FE request handling 00/55900/2
Benni Mack [Mon, 26 Feb 2018 06:56:02 +0000 (07:56 +0100)]
[TASK] Clean up user permission checking in FE request handling

The PHP code for checking if a backend user is allowed to preview
a page should use the Permission bitmask.

Additionally, the check extPageReadAccess() is a sub-method
of FrontendBackendUserAuthentication object, which checks the webmount
and the page permissions, however, "doesUserHaveAccess" also
checks for the webmount availability.

Resolves: #84042
Releases: master
Change-Id: Ibf8795d41bf9e624c64e07ee6ead34d741fb0bc2
Reviewed-on: https://review.typo3.org/55900
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Move workspace preview user to custom class 88/55888/6
Benni Mack [Sat, 24 Feb 2018 20:03:21 +0000 (21:03 +0100)]
[TASK] Move workspace preview user to custom class

Instead of faking an existing backend user, the workspace preview
functionality (= from a link) should use an anonymous read-only
use which has only access to the workspace and the page, in order
to remove the hacks to allow read-access for existing backend users.

This way, the hook code is getting cleaner and easier to read, and also
easier to debug.

Resolves: #84039
Releases: master
Change-Id: Ia69d66ce25af48b86104ff724f2a3e877aa3a813
Reviewed-on: https://review.typo3.org/55888
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Update readme copyright date to 2018 81/55881/6
Guido Schmechel [Sat, 24 Feb 2018 08:35:34 +0000 (09:35 +0100)]
[TASK] Update readme copyright date to 2018

Releases: master, 8.7, 7.6
Resolves: #84028

Change-Id: Ia6094c57c976ecf6e89b1d99aca0a1b12684e0b2
Reviewed-on: https://review.typo3.org/55881
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[TASK] Use TSFE API methods for checking workspace preview 95/55895/2
Benni Mack [Sun, 25 Feb 2018 21:07:51 +0000 (22:07 +0100)]
[TASK] Use TSFE API methods for checking workspace preview

Instead of using the public "workspacePreview" parameter in TSFE,
which is only set when a sys_preview keyword is used, the parameter
from the BE User can be used instead directly (which is used anyways
when using the API methods TSFE->whichWorkspace()).

The TSFE method doWorkspacePreview() is adapted accordingly to be in line
with the rest of the code.

Resolves: #84038
Releases: master
Change-Id: Ic819e099abf36bda867bb2235d6aa23fbbfe19a4
Reviewed-on: https://review.typo3.org/55895
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
20 months ago[TASK] Use PSR-7 request params in viewpage module 67/55867/3
Benjamin Franzke [Thu, 22 Feb 2018 19:26:59 +0000 (20:26 +0100)]
[TASK] Use PSR-7 request params in viewpage module

Since changeset I3020aa7a9cffd92d4b96afd4d4044979a771db5b
the viewpage module is a native PSR-7 controller, therefore
GeneralUtility _GP() and getIndpEnv() should no longer be used.

Restructure the code to use strict typing (to prevent type casting all
over the code), unify naming ($pageId and $languageId), and to prevent
calculating $targetUrl twice.

Releases: master
Resolves: #84015
Related: #83987
Change-Id: I4f2821824a6f811f4eebda7ebdaf09febab5eecc
Reviewed-on: https://review.typo3.org/55867
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[TASK] Get rid of special fePreview=2 for workspaces 87/55887/3
Benni Mack [Sat, 24 Feb 2018 17:30:44 +0000 (18:30 +0100)]
[TASK] Get rid of special fePreview=2 for workspaces

If a workspace is being previewed, the check does not have a kasper'sche boolean
value (0,1,2) anymore, as the detection of a workspace is handled via a
separate method $this->doWorkspacePreview() anyways.

Resolves: #84035
Releases: master
Change-Id: Ia169df138ef827ead6bee6d88a78d1543a977941
Reviewed-on: https://review.typo3.org/55887
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Show workspace preview text again 83/55883/2
Benni Mack [Sat, 24 Feb 2018 10:24:57 +0000 (11:24 +0100)]
[BUGFIX] Show workspace preview text again

Due to refactorings in various places, a simple copy/paste
mistake was done when showing the preview text of a
workspace. Due to the bug, previewing a workspace
only showed "PREVIEW", instead of "Preview of Workspace
XYZ" and the logout button.

Resolves: #84030
Related: #38735
Related: #83158
Releases: master, 8.7
Change-Id: Id4dacd7e5608d75ad52216729011a5234f57fb7a
Reviewed-on: https://review.typo3.org/55883
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
20 months ago[TASK] Move evaluation of ADMCMD_noBeUser to workspace hook 86/55886/2
Benni Mack [Sat, 24 Feb 2018 11:46:35 +0000 (12:46 +0100)]
[TASK] Move evaluation of ADMCMD_noBeUser to workspace hook

The GET parameter "ADMCMD_noBeUser" is handed over to the frontend
when a workspace preview is shown, in comparison to a live version.

In order to render the "live version", the GET parameter "ADMCMD_noBeUser"
is set, and resets BE User permisisons and preview infos.

This can be simplified in the PreviewHook to ensure that the live
version without a Backend User is used.

Resolves: #84032
Releases: master
Change-Id: Iee85717dc8f125ae91e1f046b273b7adf895c576
Reviewed-on: https://review.typo3.org/55886
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Enable special workspace preview again 85/55885/2
Benni Mack [Sat, 24 Feb 2018 11:20:48 +0000 (12:20 +0100)]
[BUGFIX] Enable special workspace preview again

The special workspace preview is now shown again,
before it was only shown when a workspace preview was active.

Resolves: #84031
Related: #84026
Releases: master
Change-Id: I643632ab9c9e2cb1b7c26b2c3203cfec49e5d040
Reviewed-on: https://review.typo3.org/55885
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
20 months ago[TASK] Remove last occurrences of default draft workspace 80/55880/2
Benni Mack [Fri, 23 Feb 2018 16:56:32 +0000 (17:56 +0100)]
[TASK] Remove last occurrences of default draft workspace

The default draft workspace was deprecated with TYPO3 4.4,
and removed with TYPO3 4.6, but some parts were still left in TYPO3 Core,
and can simply removed now.

Default draft workspace was always marked as "-1", where as "0" was the
live workspace, and everything greater zero is a regular workspace we use
throughout the TYPO3 Core.

See https://typo3.org/news/article/bringing-workspaces-up-to-speed/
for more information about the deprecation.

Resolves: #84026
Releases: master
Change-Id: Ic85425425c4a091bc058091cd483351d84b4d912
Reviewed-on: https://review.typo3.org/55880
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
20 months ago[BUGFIX] Fix page tree wrong height 78/55878/2
Paweł Rogowicz [Fri, 23 Feb 2018 15:16:50 +0000 (16:16 +0100)]
[BUGFIX] Fix page tree wrong height

- added trigger for page tree when is visible
- changed order of checking page tree height, added this before load nodes
- added condition for update height when page is resizing - now it works
when page tree is visible

Releases: master
Resolves: #83320
Change-Id: I1e789b9631282f4463263712e2118c8dea52ccdc
Reviewed-on: https://review.typo3.org/55878
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
20 months ago[BUGFIX] Use Icon API for date picker icons 75/55875/3
Frank Naegler [Fri, 23 Feb 2018 13:45:48 +0000 (14:45 +0100)]
[BUGFIX] Use Icon API for date picker icons

In the scheduler edit task view, a FontAwesome icon for the
date picker was used. This patch uses the IconViewHelper to
use the same icon as everywhere in the backend.

Resolves: #84024
Releases: master, 8.7
Change-Id: Ie1e8846ba8e3fc2eee4134cd2d97b43345b3c0e6
Reviewed-on: https://review.typo3.org/55875
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[FEATURE] EXT:Scheduler: Create task group from add/edit task form 34/55234/6
Michael Oehlhof [Sat, 30 Dec 2017 12:39:49 +0000 (13:39 +0100)]
[FEATURE] EXT:Scheduler: Create task group from add/edit task form

Resolves: #69187
Releases: master
Change-Id: I880f476c1df8cc4c92eec099eaa6f5439b5cc359
Reviewed-on: https://review.typo3.org/55234
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
20 months ago[BUGFIX] Fix timestamp handling in QueryGenerator 33/55533/9
Reiner Teubner [Fri, 2 Feb 2018 13:55:36 +0000 (14:55 +0100)]
[BUGFIX] Fix timestamp handling in QueryGenerator

Since https://review.typo3.org/c/51242/ all hidden
FormEngine fields work with ISO dates but the
QueryGenerator can only handle unix timestamp.
This patch fix the query building process for
timestamp record fields.

Resolves: #83675
Releases: master, 8.7
Change-Id: I79227762c4159984612d86dea640bdfd8b3a2784
Reviewed-on: https://review.typo3.org/55533
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
20 months ago[TASK] Add data attributes in backend toolbar and menu components 97/52197/8
Thomas Deuling [Mon, 27 Mar 2017 20:18:44 +0000 (22:18 +0200)]
[TASK] Add data attributes in backend toolbar and menu components

Add data attributes in backend toolbar and backend menu components,
to have general identifier for binding guided tours popover and
more features that can be based on this.

Resolves: #80500
Releases: master, 8.7
Change-Id: I2add8b8c28ecd37967b7b23f71392aa71f209da5
Reviewed-on: https://review.typo3.org/52197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[FEATURE] Provide setting to hide restricted columns in page module 59/55259/13
steffenk [Thu, 4 Jan 2018 09:11:43 +0000 (10:11 +0100)]
[FEATURE] Provide setting to hide restricted columns in page module

The following TSConfig setting hides columns restricted via
mod.SHARED.colPos_list:

mod.web_layout.hideRestrictedCols = 1

Resolves: #83460
Releases: master
Change-Id: I0ccaa027d9a37530e6362675bf29679edc1d2a3d
Reviewed-on: https://review.typo3.org/55259
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[TASK] Do not repopulate $GLOBALS['TYPO3_CONF_VARS'] in installer 78/55778/6
Benjamin Franzke [Sat, 17 Feb 2018 14:12:03 +0000 (15:12 +0100)]
[TASK] Do not repopulate $GLOBALS['TYPO3_CONF_VARS'] in installer

This is a followup for Icc8a3482edaef1ea329e68638d5ef467548062fc
which missed to remove the TYPO3_CONF_VARS repopulation
from the installer controller.

Now that ExtensionConfiguration::set() updates changed properties,
the manual repopulation after calling
synchronizeExtConfTemplateWithLocalConfigurationOfAllExtensions()
is not needed anymore and should be removed for the same
reasons as described in the mentioned change.

Change-Id: I3ff24411d2f0807a09c49d19bc021e9a239e6cb0
Releases: master
Resolves: #83954
Related: #83958
Reviewed-on: https://review.typo3.org/55778
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[TASK] Consolidate hooks in workspace preview 66/55866/2
Benni Mack [Thu, 22 Feb 2018 20:00:27 +0000 (21:00 +0100)]
[TASK] Consolidate hooks in workspace preview

The Workspace preview hooks first hook into TSFE->connectToDB
to see if ADMCMD_prev is set via GP/cookie. If so, the TSFE object gets
re-instantiated, which is utterly unnecessary.

Additionally, it unsets the BE user cookie, solely to use a SECOND hook
(initializePreviewUser()) to check if the BE_USER is null.

Instead, the hooks are consolidated and the one hook after a regular BE user
exists, gets used, and overridden by a custom BE user object as defined
in the preview configuration with the workspace preview.

Resolves: #84014
Releases: master
Change-Id: Id3caf9cd99ff13c906062ff95523f6066d90d322
Reviewed-on: https://review.typo3.org/55866
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[BUGFIX] Encode node name when editing in the page tree 70/55870/6
Paweł Rogowicz [Fri, 23 Feb 2018 08:14:43 +0000 (09:14 +0100)]
[BUGFIX] Encode node name when editing in the page tree

Pass page title through encodeURIComponent before using it as request
parameter value

Releases: master
Resolves: #84019
Change-Id: Ic7b18c752e67d143928e50ff14fcada6ff03c3f9
Reviewed-on: https://review.typo3.org/55870
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
20 months ago[TASK] Streamline size of email fields 68/55868/2
Guido Schmechel [Thu, 22 Feb 2018 20:54:17 +0000 (21:54 +0100)]
[TASK] Streamline size of email fields

Change email field definition to 255 characters for the rfc compatibility.
Extend the TCA max option, too.

Resolves: #83986
Releases: master
Change-Id: Ifdfc302b67b773dff8ac7d9db2d89f00253c315a
Reviewed-on: https://review.typo3.org/55868
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[TASK] Remove additional GET variables for sys_preview links 57/55857/3
Benni Mack [Wed, 21 Feb 2018 19:56:11 +0000 (20:56 +0100)]
[TASK] Remove additional GET variables for sys_preview links

The possibility of EXT:workspaces to add additional GET variables to
preview links was dropped with TYPO3 6.0, instead linking to the full
workspace was enabled, also of using workspaces instead of versioning.

This info (a string of additional GET vars) is now removed from adding
through the workspaces Hook class, instead the link to the whole
workspace is generated, and identified via a ADMCMD md5-hash.

Resolves: #84006
Releases: master
Change-Id: Ic62b106bb0d350214daf2deda9eae739a3ab9633
Reviewed-on: https://review.typo3.org/55857
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
20 months ago[TASK] Remove usage of extbase from viewpage module 50/55850/7
Georg Ringer [Wed, 21 Feb 2018 04:54:51 +0000 (05:54 +0100)]
[TASK] Remove usage of extbase from viewpage module

Remove the overhead of extbase from the backend extension "viewpage".

Resolves: #83987
Releases: master
Change-Id: I3020aa7a9cffd92d4b96afd4d4044979a771db5b
Reviewed-on: https://review.typo3.org/55850
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
20 months ago[BUGFIX] Don't download language packs of not loaded extensions 60/55860/4
Christian Kuhn [Wed, 21 Feb 2018 23:05:49 +0000 (00:05 +0100)]
[BUGFIX] Don't download language packs of not loaded extensions

The backend language module struggles with downloading
language packs of existing, but not loaded extensions
and fetchess old (non core version specific) packs
for core extensions.
This is hard to solve on a bugfix level for v7 and v8,
and in general it does not make much sense to have
language packs of not loaded extensions lying around
in typo3conf/l10n.
The patch ignores fetching of language packs for
not loaded extensions, it easily applies to all
maintained core versions.

Change-Id: I9ad885012a572368f7946f1027d870ee09550034
Resolves: #83406
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55860
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Prevent repopulating TYPO3_CONF_VARS 03/55703/15
Nicole Cordes [Tue, 13 Feb 2018 17:25:59 +0000 (18:25 +0100)]
[BUGFIX] Prevent repopulating TYPO3_CONF_VARS

Instead of using the native API when changing a TYPO3 Extension
configuration through the new ExtensionConfiguration API, the
method is now solely overwriting the global $TYPO3_CONF_VARS[EXTENSIONS]
and $TYPO3_CONF_VARS[EXT][extConf] options during runtime
to avoid deadlocks and to avoid the removal of existing configuration
of extensions.

The second parameter of ExtensionConfiguration->set() can be removed
separately once EXT:bootstrap_package is adapted to the new functionaliy.

Resolves: #83958
Resolves: #83954
Releases: master
Change-Id: Icc8a3482edaef1ea329e68638d5ef467548062fc
Reviewed-on: https://review.typo3.org/55703
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
20 months ago[BUGFIX] Set Severity object properly 59/55859/2
Andreas Fernandez [Wed, 21 Feb 2018 20:30:32 +0000 (21:30 +0100)]
[BUGFIX] Set Severity object properly

This patch fixes two issues with setting the `Severity` object:
* Check if TYPO3 is an available namespace
* Store the object in `TYPO3.Severity`

Change-Id: Ice2b410f1a588c09f7a689f54ed127d8ee90f9fa
Resolves: #84007
Related: #83955
Releases: master
Reviewed-on: https://review.typo3.org/55859
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[TASK] Unit tests: Do not rely on CacheManager instance 55/55855/4
Christian Kuhn [Wed, 21 Feb 2018 17:39:46 +0000 (18:39 +0100)]
[TASK] Unit tests: Do not rely on CacheManager instance

The typo3/testing-framework bootstrap up until now
initialized the CacheManager singleton and put it
into GeneralUtility instance stack.
To better isolate the tests and as a next step in
side effect free uni testing, the test bootstrap
now cleans this instance after use:

composer update typo/testing-framework

About 300 tests fail with this and are fixed with
the patch by improving their mocking.

Change-Id: Ia3e9dd1f94af10b20e0463a0062ccde74be23660
Resolves: #84004
Releases: master
Reviewed-on: https://review.typo3.org/55855
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
20 months ago[TASK] Migrate Notification to TypeScript 92/55792/6
Andreas Fernandez [Sun, 18 Feb 2018 20:51:04 +0000 (21:51 +0100)]
[TASK] Migrate Notification to TypeScript

Change-Id: I71cbf24dc540b5a5659be8848d08be7dc2e84b22
Resolves: #82599
Releases: master
Reviewed-on: https://review.typo3.org/55792
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Remove unused ADMCMD_previewWS GET parameter 53/55853/2
Benni Mack [Wed, 21 Feb 2018 15:36:39 +0000 (16:36 +0100)]
[TASK] Remove unused ADMCMD_previewWS GET parameter

The workspace GET parameter "ADMCMD_previewWS" is not used anymore
since TYPO3 4.7 and can be removed, as it was used before
the current workspace wasn't transferred via "ADMCMD_prev" keywords before.

Resolves: #84001
Releases: master
Change-Id: If0ec7284a0e6b87185c7773637459e61f6ab2232
Reviewed-on: https://review.typo3.org/55853
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
20 months ago[BUGFIX] Have ImageManipulationWizard return HTMLResponse 56/55856/2
Mathias Schreiber [Wed, 21 Feb 2018 17:46:42 +0000 (18:46 +0100)]
[BUGFIX] Have ImageManipulationWizard return HTMLResponse

ImageManipulationWizard now returns a proper HTMLResponse instead of a JsonResponse.
Furthermore an missing import has been added in LocalizationController.

Resolves: #84005
Releases: master
Change-Id: Ie02cdaca84afa0c7fcde109e0fbbe5237ee69600
Reviewed-on: https://review.typo3.org/55856
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
20 months ago[BUGFIX] Fix wrong type in "rootLevel" option 52/55852/2
Armin Vieweg [Wed, 21 Feb 2018 09:52:09 +0000 (10:52 +0100)]
[BUGFIX] Fix wrong type in "rootLevel" option

Several system tables used a wrong type for ctrl option "rootLevel"
in TCA. By definition in TCAref "rootLevel" is from type integer.

Resolves: #83990
Branches: master
Change-Id: Ic49464ce428a1d9a928f90231c77e0d445789ee7
Reviewed-on: https://review.typo3.org/55852
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
20 months ago[TASK] Streamline deprecation handling in icon API 29/55829/3
Oliver Hader [Tue, 20 Feb 2018 15:44:25 +0000 (16:44 +0100)]
[TASK] Streamline deprecation handling in icon API

Icon API supports some basic handling of deprecated icons
as well as keeping track of replacements. However, it is
not possible to automatically benefit from these
replacements in case they are defined.

This change tackles the following:

* bug when logging deprecated icon identifiers due to
  mismatching sprintf arguments
* automatically making use of available replacements
  instead of throwing exception
* possibility to retrieve deprecated icons and
  replacements (in order to render them in ext:styleguide)

Resolves: #83978
Releases: master
Change-Id: I7faceebc30cca0cd1f392b4845d85ac2e5bf7307
Reviewed-on: https://review.typo3.org/55829
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
20 months ago[BUGFIX] Avoid registering extension icons in IconRegistry 28/55828/4
Oliver Hader [Tue, 20 Feb 2018 15:42:31 +0000 (16:42 +0100)]
[BUGFIX] Avoid registering extension icons in IconRegistry

Extensions usually have an individual icon that can be loaded
from Resources/Public/Icons/Extension.*. For some system extensions
IconRegistry automatically registers icons available in the file
system. This leads to the fact that the "Extension.*"
icon of some extensions is registered multiple times.

Resolves: #83979
Releases: master
Change-Id: I1d2d02a5bbadd33d8d6abeefff0c2071193dbdf0
Reviewed-on: https://review.typo3.org/55828
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Use sys_file as soft reference for formDefinitions 30/55830/4
Ralf Zimmermann [Tue, 20 Feb 2018 15:55:03 +0000 (16:55 +0100)]
[BUGFIX] Use sys_file as soft reference for formDefinitions

Register an embedded form definition as sys_file soft reference to show
the usage of the form definition within the file list module.

Resolves: #83502
Releases: master, 8.7
Change-Id: Ifdba760b8ebd45a9b83e97c5a20cf23ede6a74d7
Reviewed-on: https://review.typo3.org/55830
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[TASK] Streamline usage of form framework icons 03/55803/10
Ralf Zimmermann [Mon, 19 Feb 2018 18:21:26 +0000 (19:21 +0100)]
[TASK] Streamline usage of form framework icons

Use form icons provided by the core. Remove - the now unused - icons
from the form folder.

Resolves: #83964
Releases: master
Change-Id: I0030f648f48c28c9c08d730a429cd3a2d1997ff0
Reviewed-on: https://review.typo3.org/55803
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
20 months ago[BUGFIX] Notice free FormEngine testing 34/55834/4
Christian Kuhn [Tue, 20 Feb 2018 16:00:20 +0000 (17:00 +0100)]
[BUGFIX] Notice free FormEngine testing

Similar solutions as in issue #83975

Change-Id: I04c06f0e73f5e7d44f225ad9b60c9cbed1016308
Resolves: #83981
Related: #83975
Releases: master
Reviewed-on: https://review.typo3.org/55834
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Refactor record querying in deep nested structures in recycler 72/55472/11
Andreas Fernandez [Sat, 27 Jan 2018 23:14:11 +0000 (00:14 +0100)]
[BUGFIX] Refactor record querying in deep nested structures in recycler

This patch refactors how the recycler queries records in deep page
structures.
Instead of resolving each level of the page tree on demand and executing
the complex logic of creating query builders and paging all over again,
a list of page ids is generated once and stored in the Caching Framework
for the current request. This list is then used in an multiple `IN()`
statements (depending on the DBMS engine used).

Also, some wrong type hints and a wrong language file reference are
fixed.

Resolves: #83702
Releases: master, 8.7
Change-Id: Ie3314b5a9209fb5585f95a70c16b35639951c197
Reviewed-on: https://review.typo3.org/55472
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Add placeholder to date picker form elements 35/55835/3
Ralf Zimmermann [Tue, 20 Feb 2018 17:20:01 +0000 (18:20 +0100)]
[BUGFIX] Add placeholder to date picker form elements

Add the possibility to define a placeholder html attribute for
date picker form elements.

Resolves: #82514
Releases: master, 8.7
Change-Id: I7bf272d4e1e9b0af1c15e6ceeb6e1b91afba327e
Reviewed-on: https://review.typo3.org/55835
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
20 months ago[BUGFIX] Fix miscellaneous palette in pages table 22/55822/4
Armin Vieweg [Tue, 20 Feb 2018 11:30:15 +0000 (12:30 +0100)]
[BUGFIX] Fix miscellaneous palette in pages table

Removed unnecessary locallang reference for field "editlock"
in showitem string. This field has been moved to access tab.

Resolves: #83974
Branches: master, 8.7
Change-Id: I85201f552a67badca420386bb615bcc571a712db
Reviewed-on: https://review.typo3.org/55822
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] EXT:form - fix design glitches of new element modal 32/55832/5
Andreas Steiger [Tue, 20 Feb 2018 16:19:30 +0000 (17:19 +0100)]
[BUGFIX] EXT:form - fix design glitches of new element modal

Streamline the markup of the new element modal of the form editor and
fix some style glitches due to side effects with other extensions.

Resolves: #82444
Releases: master, 8.7
Change-Id: Ifceac76a70dd4744f52da3b08ca8baea5f4adb7d
Reviewed-on: https://review.typo3.org/55832
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
20 months ago[BUGFIX] Adjust side-effects for TcaSelectItems test cases 31/55831/6
Oliver Hader [Tue, 20 Feb 2018 16:13:19 +0000 (17:13 +0100)]
[BUGFIX] Adjust side-effects for TcaSelectItems test cases

Resolves: #83980
Related: #83975
Releases: master
Change-Id: I2e8a9f3a5682644ef1dd1f3746be961a93ccafca
Reviewed-on: https://review.typo3.org/55831
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
20 months ago[BUGFIX] Ensures call of synchronizeFieldValues with valid arguments 58/55758/3
Joerg Kummer [Fri, 16 Feb 2018 18:05:16 +0000 (19:05 +0100)]
[BUGFIX] Ensures call of synchronizeFieldValues with valid arguments

Let 8.7 installtool upgrade wizard L10nModeUpdater ignore synchronization if parent entry of given translations is set to deleted

Resolves: #83940
Releases: master, 8.7
Change-Id: Ie240f71ecf42564c0547abd2dfa5c5efb23c6385
Reviewed-on: https://review.typo3.org/55758
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Michael Semle <michael.semle@b13.de>
Tested-by: Michael Semle <michael.semle@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
20 months ago[BUGFIX] Notice free TcaSelectItems testing 23/55823/3
Christian Kuhn [Tue, 20 Feb 2018 11:41:48 +0000 (12:41 +0100)]
[BUGFIX] Notice free TcaSelectItems testing

Making FormEngine data providers notice free is a mixture of
fixing notices in the test subject, and improving test setup:
* It is assumed that stuff like BE_USER and LANG object exists,
  $subject access to these globals which throw notices is not
  fixed, instead the test setup is changed to mock these where
  needed.
* Data provider which have dependencies to other data prodivers
  assume their data is properly set, too. In those cases the
  test setup porperly sets this dependent data.
* Various other "real" notice fixes in test subject and code
  called by the test subject is actually fixed.

Change-Id: I7ae6444dc646ec114c15b2738ef4e30f67f88595
Resolves: #83975
Releases: master
Reviewed-on: https://review.typo3.org/55823
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>