Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Unresolved dependencies uses old flashmessage styling 90/33690/3
Wouter Wolters [Sat, 1 Nov 2014 12:59:35 +0000 (13:59 +0100)]
[BUGFIX] Unresolved dependencies uses old flashmessage styling

The message when there are unresolved dependencies uses the old
flashmessage styling classes. Use the new classes.

Resolves: #62599
Releases: master
Change-Id: I3b48c6ae6ba19f771e81ce3de4bddefb2d509900
Reviewed-on: http://review.typo3.org/33690
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Security status for saltedpasswords broken 89/33689/2
Wouter Wolters [Sat, 1 Nov 2014 12:54:11 +0000 (13:54 +0100)]
[BUGFIX] Security status for saltedpasswords broken

Due to the new flashmessage styling the checks done for
saltedpasswords don't work anymore. Change the checks to the
new class names.

Resolves: #62598
Releases: master
Change-Id: Iea269f1d138e58cd551fa5575f3b03455a48d930
Reviewed-on: http://review.typo3.org/33689
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Make code PHP 5.3 compatible again for now 82/33682/2
Helmut Hummel [Sat, 1 Nov 2014 10:25:50 +0000 (11:25 +0100)]
[TASK] Make code PHP 5.3 compatible again for now

The content exception handler change introduced PHP 5.5 only
code parts. Revert these parts until we have a final
decision when to introduce PHP 5.5 only code in master

Releases: master
Change-Id: I16c818a686e1a99a5084ce8f8dcddef0cc930929
Reviewed-on: http://review.typo3.org/33682
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[FEATURE] Rebrush FlashMessage / state colors 66/33666/2
Felix Kopp [Fri, 31 Oct 2014 11:26:55 +0000 (12:26 +0100)]
[FEATURE] Rebrush FlashMessage / state colors

Rebrushes the FlashMessage layout and output. Better
contrast of box and text. Prominent links. Lighter boxes.

Resolves: #62580
Releases: master
Change-Id: I7db1dbf8aa8ce8d626757c001c1f1a1621d1a303
Reviewed-on: http://review.typo3.org/33666
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[FEATURE] Allow row highlight in table.t3-table 77/33677/3
Felix Kopp [Sat, 1 Nov 2014 00:38:23 +0000 (01:38 +0100)]
[FEATURE] Allow row highlight in table.t3-table

<table class="t3-table"> is the TYPO3 standard class. Allows
success / danger / warning / info and active on table rows
and table cells.

Also makes use of new table row markup in Report>Services.
This preceedes #62580 since FlashMessages can't be changed.

Test run this patch with EXT: styleguide Table demo markup.

Resolves: #62592
Releases: master
Change-Id: I36b4977ab1c412b4f29e4c6a1b958f498304048f
Reviewed-on: http://review.typo3.org/33677
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Fix PHP warning with date function in FormEngine 29/33129/13
Wouter Wolters [Fri, 24 Oct 2014 09:49:50 +0000 (11:49 +0200)]
[BUGFIX] Fix PHP warning with date function in FormEngine

The timestamp handed to the date function must be of type int
otherwise a warning is issued. Cast the value to int before
passing it to the date function. The important scenarios are
when the timestamp is "0" or "" (blank string).

Add unit test for formatValue function and the possible format
configurations.

Resolves: #62032
Releases: master, 6.2, 6.1, 4.5
Change-Id: I5207ef5b562dd70b9b5e574eef1b9ee59fa836f0
Reviewed-on: http://review.typo3.org/33129
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Fix column layout for New Content Element wizard 37/16837/6
Martin Kästner [Wed, 28 Nov 2012 13:13:25 +0000 (14:13 +0100)]
[BUGFIX] Fix column layout for New Content Element wizard

If adding new content elements in Web>List with the CE wizard,
you get the old column layout & titles even if you have a complete
backend_layout working.

But for Moving Elements the Backend Layout is already correct.
Column titles are already in $tcaItems a few lines before
the lines in the patch for File PagePositionMap.php. Using this
values the backend_layout is correct in Web>List CE Wizard.

Resolves: #42457
Releases: master, 6.2
Change-Id: I5f57aeac493ec5db02aaa92bd9eab97390cdb967
Reviewed-on: http://review.typo3.org/16837
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Add unit test for short data type support in ReflectionService 16/33616/3
Markus Klein [Thu, 30 Oct 2014 11:01:48 +0000 (12:01 +0100)]
[TASK] Add unit test for short data type support in ReflectionService

Resolves: #62547
Releases: master
Change-Id: Idada794755d8e40f702d0d9ada5a8b8b5719bf4c
Reviewed-on: http://review.typo3.org/33616
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Use Bootstrap 3.3.x in t3skin 40/33640/2
Felix Kopp [Thu, 30 Oct 2014 19:58:39 +0000 (20:58 +0100)]
[TASK] Use Bootstrap 3.3.x in t3skin

Use twbs Bootstrap 3.3 release for t3skin.
Notes: https://github.com/twbs/bootstrap/releases/tag/v3.3.0

Resolves: #62573
Releases: master
Change-Id: I4138bbf154d091e30155998c4e52c79c41967dc1
Reviewed-on: http://review.typo3.org/33640
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] IMAGE content object accepts directories 86/25286/7
Tomita Militaru [Mon, 11 Nov 2013 20:25:29 +0000 (22:25 +0200)]
[BUGFIX] IMAGE content object accepts directories

Adds checks for file existence to avoid returning directory
paths instead of path to file.

Resolves: #51781
Releases: master, 6.2
Change-Id: I8f879f38b95e6d9562a8883d35664550d8fa8774
Reviewed-on: http://review.typo3.org/25286
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Add check if $fileObject is a correct instance 13/32713/6
Frank Nägler [Wed, 10 Sep 2014 19:55:21 +0000 (21:55 +0200)]
[BUGFIX] Add check if $fileObject is a correct instance

In some cases the $fileObject is null and getName() is called on
a null object which results in a fatal error.

This patch add a check if $fileObject is an instance of
FileInterface before call getName().
Also correct the wrong doc comment.

Resolves: #60773
Releases: 6.2, master
Change-Id: I6f3f817a089c665d8cc9e0b3369d6d690ffaf620
Reviewed-on: http://review.typo3.org/32713
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] ReflectionService must recognize short data types 11/33611/6
Markus Klein [Wed, 29 Oct 2014 23:03:07 +0000 (00:03 +0100)]
[BUGFIX] ReflectionService must recognize short data types

Since the Core uses and embraces the usage of short data type names
like "bool" or "int", internal type checks must ensure these are
recognized as well.

This patch takes the load off the checks and implements type conversion
for these short names right into the ReflectionService, so the checks
are still done against the full names like "boolean" or "integer".

Resolves: #62547
Releases: master
Change-Id: I0d391f04f91c40035d0ff9ae314f8f5bc4d0454c
Reviewed-on: http://review.typo3.org/33611
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[FEATURE] Add possibility to catch exception during rendering 23/31123/18
Helmut Hummel [Wed, 25 Jun 2014 00:17:56 +0000 (02:17 +0200)]
[FEATURE] Add possibility to catch exception during rendering

Currently exceptions throw when rendering single
content objects bubble up to the default exception
handler and break the complete frontend.

This change adds the possibility to register an exception handler
for a content object which can render an appropriate
message instead if wanted (e.g. in production context).

Releases: master
Resolves: #47919
Change-Id: I9e3697401432b043e164fa84340739a525f80264
Reviewed-on: http://review.typo3.org/31123
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Fix active page calculation in indexed_search 05/33605/3
Georg Ringer [Wed, 29 Oct 2014 12:21:56 +0000 (13:21 +0100)]
[BUGFIX] Fix active page calculation in indexed_search

Because of introducing a strict comparion in #60346, the active page is
not highlighted anymore as a float and an int value are compared.

Change-Id: Id66c77e64fb4824f5b254240b1774f77adfa6ab9
Resolves: #62532
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/33605
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[BUGFIX] Remove wrong escaping of email sender 99/33499/2
Markus Klein [Thu, 23 Oct 2014 23:48:01 +0000 (01:48 +0200)]
[BUGFIX] Remove wrong escaping of email sender

Remove a wrong escaping method from sysext form which causes email
problems.

Resolves: #60437
Releases: master, 6.2
Change-Id: I3a5447b55f4f0723637c04929de0412a4a3b67a7
Reviewed-on: http://review.typo3.org/33499
Reviewed-by: Ayke Halder <mail@ayke-halder.de>
Tested-by: Ayke Halder <mail@ayke-halder.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[CLEANUP] BackendUtility 80/33480/6
Markus Klein [Wed, 22 Oct 2014 23:43:06 +0000 (01:43 +0200)]
[CLEANUP] BackendUtility

Fix various code issues like missing return values, wrong phpdoc, unused
variables, etc.

Resolves: #62414
Releases: master
Change-Id: I1769e9c365b96d70cde426a3d079acf8abbfc724
Reviewed-on: http://review.typo3.org/33480
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Cleanup phpDoc to match CGL 77/33577/8
Wouter Wolters [Mon, 27 Oct 2014 17:59:07 +0000 (18:59 +0100)]
[TASK] Cleanup phpDoc to match CGL

* Use bool in @return
* Use int in @return
* Use bool in @param
* Use int in @param
* Remove extra tabs and spaces in @param

Resolves: #62506
Releases: master
Change-Id: I673888aa08855a1364150d0060d0f205fc1f83a2
Reviewed-on: http://review.typo3.org/33577
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[CLEANUP] Remove unnecessary fully qualified names 88/33588/3
Frank Nägler [Mon, 27 Oct 2014 21:15:21 +0000 (22:15 +0100)]
[CLEANUP] Remove unnecessary fully qualified names

Remove unnecessary fully qualified names from Utility classes.

Resolves: #62505
Releases: master
Change-Id: I3d4af98670911b3b49bd8043136c92422925cd2a
Reviewed-on: http://review.typo3.org/33588
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Broken icon on lowlevel > DB Check 89/33589/3
Felix Kopp [Mon, 27 Oct 2014 23:05:17 +0000 (00:05 +0100)]
[BUGFIX] Broken icon on lowlevel > DB Check

Resolves: #61443
Releases: master
Change-Id: I2a524b3b066712a614534acb14eaef28c4fce86e
Reviewed-on: http://review.typo3.org/33589
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Let save and preview button behave as user initiated 76/33576/2
Helmut Hummel [Mon, 27 Oct 2014 17:53:17 +0000 (18:53 +0100)]
[BUGFIX] Let save and preview button behave as user initiated

Browsers started to distinguish how opening a new window
from JavaScript happens. They track "user initiated"
opening and not user initiated opening and behave differently.

A request to open a window by JavaScript which is not
user initiated is caught by a pop up blocker most of the time nowadays.
This means a user must explicitly allow the current page to
open new windows by JavaScript.

Additionally some browsers (e.g. Chrome) always open a new window
instead of a new tab if the request is not user initiated, regardless
of browser settings, which nowadays default to open a new tab.

The "save and preview" button currently initiates a page reload
which saves the document and add some JavaScript to to open a preview
window in the HTML response of this action.
This JavaScript action is then not considered to be user initiated any more
as opening the new window does not follow a direct user click action.

The result is, that if a preview window/tab was opened previously, then
the preview/window tab is just reloaded with the new preview URL.
If it is the first time the window/tab should be opened this request
is caught by the popup blocker.

Other preview buttons in the backend (from Click Menu or action toolbar)
behave differently (correctly) as they are always identified as user initiated.

For that reasons, change the "save and preview" button to directly
open a new window on click (without URL) and let the HTML/ JavaScript response
set the correct preview URL after that.

By doing so we gain a consistent behavior no matter what preview button a user
clicks first.
The only downside is, that in case the preview window is opened
the first time, it remains empty until the page is saved and then reloaded
through the JavaScript code that is already present.

Resolves: #62503
Releases: 6.2, master
Change-Id: I7a96c347453b1ccdeaf0d8d1bd5b080f905563ca
Reviewed-on: http://review.typo3.org/33576
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Use HTML5 input type "email" in user settings 87/33587/2
Georg Ringer [Mon, 27 Oct 2014 21:08:48 +0000 (22:08 +0100)]
[TASK] Use HTML5 input type "email" in user settings

The field "email" should use the input type "email".

Resolves: #62504
Releases: master
Change-Id: I1f443eac86508dd914a75c4a1ab7d0454c043f66
Reviewed-on: http://review.typo3.org/33587
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Add icon for collapsed table in list module 85/33585/2
Georg Ringer [Mon, 27 Oct 2014 19:59:07 +0000 (20:59 +0100)]
[TASK] Add icon for collapsed table in list module

The icon for collapsed table must be also styled with a
font awesome icon as the expand icon.

Resolves: #62439
Releases: master
Change-Id: I908bffadcfa05def7633002bfccdce5afe5ed4ae
Reviewed-on: http://review.typo3.org/33585
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Declare statically called method static 82/33582/2
Helmut Hummel [Mon, 27 Oct 2014 19:16:32 +0000 (20:16 +0100)]
[BUGFIX] Declare statically called method static

InlineElement::updateInlineView() is only used once throughout the core
and called statically, although the method is not declared to be static.

Fix this by declaring it static.

Resolves: #62501
Releases: 6.2, master
Change-Id: Ifeb8551899ccf285d87a66767bf7de4e8e98b32f
Reviewed-on: http://review.typo3.org/33582
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Only reload pagetree if pages are changed 73/33573/4
Helmut Hummel [Mon, 27 Oct 2014 16:04:46 +0000 (17:04 +0100)]
[BUGFIX] Only reload pagetree if pages are changed

When using the click menu to hide, unhide or delete
a record, previously the page tree was refreshed,
although those changes are only reflected in the
pagetree if page properties are changed.

Adapt the click menu to only refresh the tree
if a page record is changed or deleted.

Resolves: #40687
Releases: 6.2, master
Change-Id: I32844b359abd790f1dbd6839eec6feeb6e62bd02
Reviewed-on: http://review.typo3.org/33573
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] RTE: Documentation of enableWordClean is wrong 65/33565/2
Stanislas Rolland [Sun, 26 Oct 2014 23:15:02 +0000 (19:15 -0400)]
[BUGFIX] RTE: Documentation of enableWordClean is wrong

The HTMLparser properties must be defined under subproperty HTMLparser
of enableWordClean and not directly under property enableWordClean.

Releases: master, 6.2
Resolves: #58105
Change-Id: I0b21e5789aa4db867e0057e484d17f40a26b5c56
Reviewed-on: http://review.typo3.org/33565
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] FormEngine paddings, margins, colors, borders 20/33520/2
Felix Kopp [Sat, 25 Oct 2014 11:32:03 +0000 (13:32 +0200)]
[BUGFIX] FormEngine paddings, margins, colors, borders

Fixes several layout issues with the FormEngine form:

Adds space between checkbox+label.
Forms element browser link as default button.
Form field header will be a headline h4.
Repairs outer padding and inner padding and borders.

Resolves: #62466
Releases: master
Change-Id: I0dcf1cd2206c0cee63a8353516a3b41b94fd670b
Reviewed-on: http://review.typo3.org/33520
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] Video player in backend (i) window 16/32816/8
Felix Kopp [Tue, 16 Sep 2014 23:23:35 +0000 (01:23 +0200)]
[FEATURE] Video player in backend (i) window

Allow video and audio playback in the backend (i) element
information window.

Uses the new introduced RenderingRegistry to find a matching
rendering class (#61800).

Brings default letter box background color for <Video> tags.

Resolves: #61668
Releases: master
Change-Id: I7c01fbaf2258b4e7c6f10da0e6438bdc55d12197
Reviewed-on: http://review.typo3.org/32816
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[FEATURE] Refactor toolbar / topbar HTML5 & layout 64/33564/4
Felix Kopp [Sun, 26 Oct 2014 23:09:11 +0000 (00:09 +0100)]
[FEATURE] Refactor toolbar / topbar HTML5 & layout

First step for Toolbar/Topbar refactoring. This is a first step
to refactor HTML5 output - the path to gain HTML5 viewport
without ExtJS and based on jQuery and Bootstrap.

Migrates HTML from topbar to .navbar - keeps ids.
Makes use of .dropdown and .dropdown-menu.
Therefore removes duplicated CSS.
Also increase size to fit our fingers & touch.

This issue is not breaking since common css classes
and interfaces are kept.

Next step #62166: introduce "ToolbarItemInterface" and
remove toolbar-item css and layouts.

Resolves: #62481
Related: #62166
Releases: master
Change-Id: I8c215b19da4a99ad81e53b000b281849991d8deb
Reviewed-on: http://review.typo3.org/33564
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Use "int" in @param notation 33/33533/3
Frank Nägler [Sat, 25 Oct 2014 21:10:03 +0000 (23:10 +0200)]
[TASK] Use "int" in @param notation

This is a follow-up patch for
https://review.typo3.org/33522/

Resolves: #62467
Releases: master
Change-Id: I19333d6e6c987f7e2f84faeabc01a9c724831bc4
Reviewed-on: http://review.typo3.org/33533
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[CLEANUP] Introduce getters for globals in BackendUtility 79/33479/4
Markus Klein [Wed, 22 Oct 2014 22:49:31 +0000 (00:49 +0200)]
[CLEANUP] Introduce getters for globals in BackendUtility

Resolves: #62414
Releases: master
Change-Id: I5f77e85e59a014eeb86fd9ee4db839679c0eac98
Reviewed-on: http://review.typo3.org/33479
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Use "bool" in @param notation 27/33527/2
Frank Nägler [Sat, 25 Oct 2014 20:22:46 +0000 (22:22 +0200)]
[TASK] Use "bool" in @param notation

This patch is a follow-up patch for
https://review.typo3.org/33523/

Resolves: #62468
Releases: master
Change-Id: Ib16ab5378047b91759f3e5c38952fb57d3afb7ce
Reviewed-on: http://review.typo3.org/33527
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Tested-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FEATURE] Put up (badge) in top bar toolbar-items 61/33561/2
Felix Kopp [Sun, 26 Oct 2014 18:17:32 +0000 (19:17 +0100)]
[FEATURE] Put up (badge) in top bar toolbar-items

Makes the (badge) elemente a tiny bubble in the top right
corner of the toolbar-item links.

Revoles: #62479
Releases: master
Change-Id: I3cebab2382d8971b776a9bea45b290a585ca8b25
Reviewed-on: http://review.typo3.org/33561
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Remove table usage in "User settings" + base on Twbs 93/33393/7
Georg Ringer [Sun, 19 Oct 2014 18:45:30 +0000 (20:45 +0200)]
[TASK] Remove table usage in "User settings" + base on Twbs

The module "User settings" currently uses tables to style the form.
This must be changed to use a proper markup.

Additionally fixed:
 * Typos
 * Strict comparison where nothing breaks for sure.

Resolves: #62328
Releases: master
Change-Id: I6af386b63cca6d2ca35eb169332f5e36f7d03542
Reviewed-on: http://review.typo3.org/33393
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Fix suggest wizard for new CE in flexforms 05/33505/3
Markus Klein [Fri, 24 Oct 2014 14:34:59 +0000 (16:34 +0200)]
[BUGFIX] Fix suggest wizard for new CE in flexforms

When having a suggest wizard inside a flexform on a
new content element edit form, we have the problem that
we can't load the wizard's config in the AJAX request due
to missing record information. We don't know what flexform
definition to load, as we don't know what ctype is requested.

Two possible solutions exist:
 - Generate the blank record again in the AJAX request, which
   means we have to copy lots of code from the DataPreProcessor.
   Moreover we would still need to pass the defVal GET parameter
   of the EditDocumentController to the AJAX request handler
   somehow, since we need that information in the DataPreProcessor
   to generate the correct dummy record.
 - Push the record to the AJAX request as serialized array

I chose the second implementation.

Resolves: #50549
Releases: master, 6.2, 6.1
Change-Id: Ic27125d0a901aee10461f88ea49c0f354cb43a54
Reviewed-on: http://review.typo3.org/33505
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[TASK] Sys_note: Bring headline & delete action icon 80/32980/5
Felix Kopp [Thu, 25 Sep 2014 22:15:31 +0000 (00:15 +0200)]
[TASK] Sys_note: Bring headline & delete action icon

To finalze the rebrush of sys notes a section headline is added:
The delete action can be accessed right from the note.

Resolves: #26796
Releases: master
Change-Id: I80923ee523d21880d877a0e1cc9cc2f355f59b3a
Reviewed-on: http://review.typo3.org/32980
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] Add methods to get class tag values via reflection 14/32714/10
Frank Nägler [Wed, 10 Sep 2014 20:30:54 +0000 (22:30 +0200)]
[FEATURE] Add methods to get class tag values via reflection

This patch adds ReflectionService::getClassTagsValues($className) and
ReflectionService::getClassTagValues($className, $tag) to get class
tag values via reflection.

Also the unit test changed to test the new methods.

Resolves: #60822
Releases: master
Change-Id: I45962c30f2559ad1b10fe33a64c541425c80db90
Reviewed-on: http://review.typo3.org/32714
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Replace old fe_users icon with new one 28/30728/7
Felix Kopp [Sun, 26 Oct 2014 10:20:00 +0000 (11:20 +0100)]
[TASK] Replace old fe_users icon with new one

Change path of fe_users icon in TCA to same as in page tree.
See Edit page > Behaviour > Contains plugin

Resolves: #27955
Releases: master, 6.2
Change-Id: Ib2c91ad279249c9ab6a71d23f7c9afca140cc2ec
Reviewed-on: http://review.typo3.org/30728
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Link to ext:perm in clickmenu not working 10/33510/3
Wouter Wolters [Fri, 24 Oct 2014 17:59:24 +0000 (19:59 +0200)]
[BUGFIX] Link to ext:perm in clickmenu not working

The link refers directly to index.php instead of mod.php.
Use BackendUtility::getModuleUrl() for the link to fix the problem.

Resolves: #62459
Related: #38099
Releases: master, 6.2, 6.1
Change-Id: I3b86d97a4f35a96ca39af28e724067b5ec8a832f
Reviewed-on: http://review.typo3.org/33510
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[!!!][TASK] Move flash message output to alerts 48/33048/5 just2b/monolog
Georg Ringer [Mon, 29 Sep 2014 20:14:18 +0000 (22:14 +0200)]
[!!!][TASK] Move flash message output to alerts

Since bootstrap is available it would make sense to
use the alert classes instead of the custom implementation.

Resolves: #61959
Releases: master
Change-Id: I0a6723a1bdb7333bc48f71876b8392e78299e4f3
Reviewed-on: http://review.typo3.org/33048
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[TASK] Add phpDoc in ClickMenu 08/33508/4
Wouter Wolters [Fri, 24 Oct 2014 17:50:45 +0000 (19:50 +0200)]
[TASK] Add phpDoc in ClickMenu

* Make real booleans
* Adds strict comparison where possible

Resolves: #62460
Releases: master
Change-Id: I5dd88eb2300e86e344cc39972c337685e7b02498
Reviewed-on: http://review.typo3.org/33508
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[TASK] Use "int" in @param notation 22/33522/4
Wouter Wolters [Sat, 25 Oct 2014 19:38:56 +0000 (21:38 +0200)]
[TASK] Use "int" in @param notation

Resolves: #62467
Releases: master
Change-Id: I927a16b0fa89c5b859b56a7549548102ac04037f
Reviewed-on: http://review.typo3.org/33522
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Use "bool" in @param notation 23/33523/2
Wouter Wolters [Sat, 25 Oct 2014 14:17:30 +0000 (16:17 +0200)]
[TASK] Use "bool" in @param notation

Resolves: #62468
Releases: master
Change-Id: I2790ca5817e16cfe0dc1c43151d2587ca796294a
Reviewed-on: http://review.typo3.org/33523
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Fix JS error in SuggestWizard 03/33503/3
Markus Klein [Fri, 24 Oct 2014 02:13:42 +0000 (04:13 +0200)]
[BUGFIX] Fix JS error in SuggestWizard

This is regression fix for #59701.

The ID of new Content Elements now contain a dot character.
Fix the generated JS code of the SuggestWizard to filter this dot.

Resolves: #62438
Releases: master, 6.2
Change-Id: Ifd6937a7645c1bfd509fa1b5912d02f2d01c5e0d
Reviewed-on: http://review.typo3.org/33503
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Bernhard Kraft <kraftb@think-open.at>
Tested-by: Bernhard Kraft <kraftb@think-open.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FEATURE] Add multiple parameter in f:form.checkbox 57/33257/5
Stefan Froemken [Fri, 10 Oct 2014 23:12:19 +0000 (01:12 +0200)]
[FEATURE] Add multiple parameter in f:form.checkbox

This patch introduce the multiple parameter
for f:form.checkbox ViewHelper of fluid.

Resolves: #61529
Releases: master,6.2
Change-Id: Ic02b9aaeb19f09be438c18212c5b2f5842bf7468
Reviewed-on: http://review.typo3.org/33257
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Ernesto Baschny <ernst@cron-it.de>
4 years ago[BUGFIX] Extra click menu options on second level not rendered 09/33509/3
Wouter Wolters [Fri, 24 Oct 2014 17:53:24 +0000 (19:53 +0200)]
[BUGFIX] Extra click menu options on second level not rendered

The merge extra_page_cm_options was not correct. The second level
is never rendered again. Fix this by moving it into the correct
method.

Resolves: #62458
Related: #55136
Releases: master
Change-Id: I5ce3c71997f89c28f506b1419986b023d2073218
Reviewed-on: http://review.typo3.org/33509
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[FEATURE] Configure CSS class as non-selectable in RTE 33/29633/7
Stanislas Rolland [Fri, 24 Oct 2014 18:48:45 +0000 (14:48 -0400)]
[FEATURE] Configure CSS class as non-selectable in RTE

To filter some useless classes for authors, we can configure classes as
non-selectable in block or text style selectors.

Releases: master
Resolves: #58122
Change-Id: I6b151cf0524fccac6681a813b73f847783a69b95
Reviewed-on: http://review.typo3.org/29633
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Multilingual classesAnchor titleText not possible 88/33488/5
Stanislas Rolland [Thu, 23 Oct 2014 16:20:58 +0000 (12:20 -0400)]
[BUGFIX] RTE: Multilingual classesAnchor titleText not possible

Content language is not correctly set by RTE controller.

Releases: master, 6.2
Resolves: #62399
Change-Id: I85eb570dc266bdc71e4768a13d27c6f2937f7251
Reviewed-on: http://review.typo3.org/33488
Reviewed-by: Jan Kiesewetter <jan@t3easy.de>
Tested-by: Jan Kiesewetter <jan@t3easy.de>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] Remove table for icons in TCA type "select" 47/33447/2
Georg Ringer [Wed, 22 Oct 2014 07:42:26 +0000 (09:42 +0200)]
[TASK] Remove table for icons in TCA type "select"

The TCA type "select" uses a table to render the belonging icons.
Use divs instead for the markup.

Change-Id: I9bd8fb58d314913ec7b0859361c0c25fcc90d73e
Resolves: #62386
Releases: master
Reviewed-on: http://review.typo3.org/33447
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Missing and invalid warnings on referenced files 04/30204/4
Oliver Hader [Mon, 19 May 2014 10:02:36 +0000 (12:02 +0200)]
[BUGFIX] Missing and invalid warnings on referenced files

The file list module in the backend offers the possibility to
delete files. An interesting use case is the deletion of files
that still have references to other entities. However, currently
proper warnings are only available for sys_file reference.

a) before deleting a file, a popup should be shown
   this does not work since the API is called with
   the identifier instead of a proper UID value

b) after calling the API for deleting a file, references
   should be pointed out
   references are checked, however the description on the
   file usage is missing due to hardcoded "sys_file_reference"
   triggers - thus, no other references are printed out

Resolves: #58913
Releases: master, 6.2, 6.1
Change-Id: Id80361427abc17bda3461c2d00750c4790798c88
Reviewed-on: http://review.typo3.org/30204
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] TSFE: Deprecate JSfuncCalls for body tag 03/33403/3
Benjamin Mack [Tue, 21 Oct 2014 06:28:03 +0000 (08:28 +0200)]
[CLEANUP] TSFE: Deprecate JSfuncCalls for body tag

For old systems without proper JS libraries or usages like GMENU_LAYERS
TSFE provides an array to register handlers directly that are added
to the body tag directly.

This function is removed (only used for GMENU_LAYERS) from the core,
as all according functions should do this via hook or JS-only.

Resolves: #62363
Releases: master
Change-Id: I746e27c88c372dce61dadb6025d9348d34566fdf
Reviewed-on: http://review.typo3.org/33403
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Respect different object mapping for scheduler tasks 18/31618/5
Mathias Brodala [Mon, 14 Jul 2014 07:26:18 +0000 (09:26 +0200)]
[BUGFIX] Respect different object mapping for scheduler tasks

Resolves: #60296
Releases: master, 6.2, 6.1
Change-Id: I7bff792b33ffecbe53ac4aee848e6ad16318a538
Reviewed-on: http://review.typo3.org/31618
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Rename "Extensions" backend module 81/33381/3
Felix Kopp [Sat, 18 Oct 2014 14:22:13 +0000 (16:22 +0200)]
[TASK] Rename "Extensions" backend module

Renames backend module Extension manager to "Extensions".
Also lowers language barriere in "Manage Extensions".

Resolves: #55236
Releases: master
Change-Id: Id8ca9545128807adcc925f3e00f705febae93d2b
Reviewed-on: http://review.typo3.org/33381
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Tested-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] ErrorHandler: Stop execution if E_RECOVERABLE_ERROR occurs 65/32465/4
Markus Klein [Wed, 27 Aug 2014 22:30:10 +0000 (00:30 +0200)]
[BUGFIX] ErrorHandler: Stop execution if E_RECOVERABLE_ERROR occurs

Ensure the ErrorHandler stops script execution if an error occurs.

Resolves: #61213
Releases: master, 6.2, 6.1
Change-Id: I0324a571b494576db1d314d8af0a86273e3205d3
Reviewed-on: http://review.typo3.org/32465
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] ClassLoader also needs to check for interfaces 09/33309/2
Markus Klein [Tue, 14 Oct 2014 14:13:20 +0000 (16:13 +0200)]
[BUGFIX] ClassLoader also needs to check for interfaces

An interface might already be defined, check for existence before trying
to require it, which will cause PHP errors if the interface comes from a
different file path.

Resolves: #62212
Releases: master, 6.2
Change-Id: I9cf43402bbcbbb5e27dbebb4ea48a2e1b483f360
Reviewed-on: http://review.typo3.org/33309
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Remove TCA definitions for pre FAL fields 41/31841/4
Thomas Maroschik [Sat, 26 Jul 2014 10:21:19 +0000 (12:21 +0200)]
[TASK] Remove TCA definitions for pre FAL fields

There are some overrides in the CMS extension that provide the old
TCA for the image and media fields of tt_content and
pages_language_overlay tables. These apply if the compat version
is set to 6.0 and and FAL upgrade wizard is not yet run.

Those are removed now as we only support migrations from one LTS
to the next LTS.

Resolves: #60594
Releases: master
Change-Id: I40b1b4cbc9404d5f4cac7df27029986a2568f2c8
Reviewed-on: http://review.typo3.org/31841
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FEATURE] Base Buttons on Bootstrap - with compat layer 69/33469/3
Felix Kopp [Wed, 22 Oct 2014 09:58:43 +0000 (11:58 +0200)]
[FEATURE] Base Buttons on Bootstrap - with compat layer

Bring default button style and base CSS definitions on Bootstrap
buttons. Brings backward compatibility for all buttons.

Resovles: #62392
Releases: master
Change-Id: I2cd59c00a649e65c03a7843e8de359e84baaa169
Reviewed-on: http://review.typo3.org/33469
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Tested-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Follow-up: Action icon mapping - more icons 71/33471/2
Felix Kopp [Wed, 22 Oct 2014 10:25:20 +0000 (12:25 +0200)]
[TASK] Follow-up: Action icon mapping - more icons

Map further icons from t3skin / sprite icons to FontAwesome.
Unify actions.

Resolves: #62393
Releases: master
Change-Id: I4ae70151d065a671851ad3a3ee406c985e82f3d6
Reviewed-on: http://review.typo3.org/33471
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Tested-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Base Web>List on new .table style 44/33444/4
Felix Kopp [Tue, 21 Oct 2014 23:14:09 +0000 (01:14 +0200)]
[TASK] Base Web>List on new .table style

Base Web>List on common fresh table style in CSS
class "t3-table". Can be styled centrally now.

Resolves: #62384
Releases: master
Change-Id: I0cf274d3d436c0ca7e3ebc9a7345be0f5ee30854
Reviewed-on: http://review.typo3.org/33444
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Remove horizontal scrollers / secondary info 87/33387/3
Felix Kopp [Sun, 19 Oct 2014 14:44:30 +0000 (16:44 +0200)]
[TASK] Remove horizontal scrollers / secondary info

Solves problems with horizontal scrolling on small (SM)
and extra small (XS) screen within the backend.

Secondary information that is not visible in table listing
directly anymore can be accessed in edit/detail views.

Also unifies beusers tables listing.

Resolves: #62325
Releases: master
Change-Id: I4589c787103694fad4587682247619857dfd26f0
Reviewed-on: http://review.typo3.org/33387
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Tested-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FEATURE] Allow adding multiple CSS files in RTE 23/24523/10
Stanislas Rolland [Thu, 23 Oct 2014 01:54:46 +0000 (21:54 -0400)]
[FEATURE] Allow adding multiple CSS files in RTE

Allow to add more than one CSS file in the RTE header.

The new syntax is like this:
    RTE.default.contentCSS {
        file1 = fileadmin/myStylesheet1.css
        file2 = fileadmin/myStylesheet2.css
    }

If no CSS files are set, the RTE default CSS file is still added.

Releases: master
Resolves: #50039
Change-Id: I4b8545982a59382ca4e01abc4440f0b94693ccdc
Reviewed-on: http://review.typo3.org/24523
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Make ContentSlide work correctly if last element is empty 28/32928/3
Robert Vock [Tue, 23 Sep 2014 07:28:18 +0000 (09:28 +0200)]
[BUGFIX] Make ContentSlide work correctly if last element is empty

When using ContentSlide and the last content element in a column returns
an empty string, the slide continues up in the page list, even when
there are other content elements in the column.
Fix this by checking the correct value.

Change-Id: I6543cf2335197ae8510aa8d805d4d60a8d8a2320
Resolves: #51936
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/32928
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] RTE: Deprecated JavaScript methods removed 77/33377/3
Stanislas Rolland [Sat, 18 Oct 2014 02:48:47 +0000 (22:48 -0400)]
[FEATURE] RTE: Deprecated JavaScript methods removed

This change adds documentation of breaking change #62291 which
removed some deprecated JavaScript methods of the RTE.

Releases: master
Resolves: #62291
Change-Id: I52eab4f949d8699837cb42d9bcbb64760cea1778
Reviewed-on: http://review.typo3.org/33377
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: In Chrome RTE inserts weird span tags 91/33391/4
Stanislas Rolland [Wed, 22 Oct 2014 22:32:04 +0000 (18:32 -0400)]
[BUGFIX] RTE: In Chrome RTE inserts weird span tags

Remove the span tags inserted by Chrome or Opera on execution of
native execCommand. The attributes of these span tags have evolved...

Releases: master, 6.2
Resolves: #52470
Change-Id: Ibb046b86e869bd7d4afc61ab5005595467b288cd
Reviewed-on: http://review.typo3.org/33391
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[FEATURE] Make RTE overlay popups maximizable 42/29442/4
Stanislas Rolland [Wed, 22 Oct 2014 20:16:15 +0000 (16:16 -0400)]
[FEATURE] Make RTE overlay popups maximizable

This will make the link and image popus maximizable, and the spell
checker popup as well.

Resolves: #57875
Releases: master

Change-Id: I0258375b7ac31ef67f0625bbb171e1c1b9760876
Reviewed-on: http://review.typo3.org/29442
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] RTE: Split main JS script into components 77/33477/2
Stanislas Rolland [Wed, 22 Oct 2014 17:44:30 +0000 (13:44 -0400)]
[TASK] RTE: Split main JS script into components

Split the main script one class per file.

Releases: master
Resolves: #62404
Change-Id: Ide50dcae24339f7af4fbe4128b7947430af5db8f
Reviewed-on: http://review.typo3.org/33477
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[SECURITY] Fix DoS in openid 60/33460/2
Markus Klein [Wed, 22 Oct 2014 08:14:31 +0000 (10:14 +0200)]
[SECURITY] Fix DoS in openid

Upgrade openid to latest upstream version.
This includes the sec fix already.

Change-Id: I71efa194dc75846e6b2e118781a51c3aa204d749
Resolves: #62357
Releases: master, 6.2, 6.1, 6.0, 4.7, 4.6, 4.5
Security-Commit: 59fbe1eb6b013f0405a9ed65329b36d4ea4a8c92
Security-Bulletin: TYPO3-CORE-SA-2014-002
Reviewed-on: http://review.typo3.org/33460
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] EM: Upload icon -> inline form 43/33443/2
Felix Kopp [Tue, 21 Oct 2014 21:09:07 +0000 (23:09 +0200)]
[BUGFIX] EM: Upload icon -> inline form

Fixes inline loading upload form for extensions in EM.

Resolves: #62342
Releases: master
Change-Id: I6fd61b15b3aadcef117c2e554cf8e54460aba296
Reviewed-on: http://review.typo3.org/33443
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FEATURE] Registry for adding file rendering classes 25/32925/10
Frans Saris [Mon, 22 Sep 2014 19:15:20 +0000 (21:15 +0200)]
[FEATURE] Registry for adding file rendering classes

To be able to render all kinds of media files a file renderingRegistry
is needed where you can register a "renderer" class that can generate
the needed HTML output.

This patch adds a registry for adding renderer classes and
a AudioTagRenderer + VideoTagRenderer class.

Resolves: #61800
Releases: master
Change-Id: Ied5e16f00e10ac0c78a6508ef42fe585558a2d2c
Reviewed-on: http://review.typo3.org/32925
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] Refactor & recolor Modul-Menu (Bootstrap) 99/33399/4
Felix Kopp [Sun, 19 Oct 2014 23:46:55 +0000 (01:46 +0200)]
[FEATURE] Refactor & recolor Modul-Menu (Bootstrap)

Base module menu on Bootstrap less variables navbar-inverse.
First step on roadmap to a backend scaffold without ExtJS ('Flat').

Since the module menu link section must be taller for fingers
and touch (long time goal: 44px height):

+ Moves module menu "User tools" section into the Topbar.
User tools will be in dropdown-menu at User (#62166).

+ "Help Center" section will be moved from module menu
to Topbar (#62338).

Colors module menu, topbar and doc-header will be adapter.

Resolves: #62353
Related: #62166
Related: #62338
Releases: master
Change-Id: I5912508efa1fa8d378afeb0722e7a00be0b86f71
Reviewed-on: http://review.typo3.org/33399
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Tested-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] jsfunc.inline is not fully jQuery compatible 02/33302/7
Stefan Froemken [Mon, 13 Oct 2014 21:38:05 +0000 (23:38 +0200)]
[BUGFIX] jsfunc.inline is not fully jQuery compatible

When working with TYPO3.jQuery you don't get the object itself,
it returns a jQuery object which contains the mentioned object
at array ID 0.

 * To differ jQuery and JS objects I will add $ to jQuery vars.
 * When using jQuery vars, we should also use jQuery methods

Resolves: #62205
Releases: master
Change-Id: If337477af2dc9a2d91139480a171bd4a3421a2fa
Reviewed-on: http://review.typo3.org/33302
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] DocumentTemplate TabMenu output fixed 78/33378/2
Felix Kopp [Sat, 18 Oct 2014 09:51:38 +0000 (11:51 +0200)]
[BUGFIX] DocumentTemplate TabMenu output fixed

Output Bootstrap compatible HTML5 output for
DocumentTemplate TabMenuRaw.

Resolves: #62317
Releases: master
Change-Id: I321f94575d3b4974b5d24ecacc03f0d28ce8b452
Reviewed-on: http://review.typo3.org/33378
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Update version number for master to 7 95/33395/4
Markus Klein [Mon, 20 Oct 2014 00:24:11 +0000 (02:24 +0200)]
[TASK] Update version number for master to 7

Update version number of all sysext and dependency definitions.

Resolves: #62341
Releases: master
Change-Id: Ic8b1b8ead08432917a28b226bbb43347dac42087
Reviewed-on: http://review.typo3.org/33395
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FEATURE] RTE: Avoid overhead of Ext.each and Ext.iterate 83/33383/4
Stanislas Rolland [Sat, 18 Oct 2014 17:27:26 +0000 (13:27 -0400)]
[FEATURE] RTE: Avoid overhead of Ext.each and Ext.iterate

Improve performance by replacing Ext.each and Ext.iterate with
standard JS for statements.

Releases: master
Resolves: #62321
Change-Id: Id17994d4deadb6786b8c8a5071928bcb38bb2407
Reviewed-on: http://review.typo3.org/33383
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Use correct font awesome icon for text file type 84/33384/2
Georg Ringer [Sat, 18 Oct 2014 21:29:59 +0000 (23:29 +0200)]
[BUGFIX] Use correct font awesome icon for text file type

Use the correct class "fa-file-text".

Resolves: #62322
Releases: master
Change-Id: I2ebc743aad88b3fcb91152f27f20d48c0258c044
Reviewed-on: http://review.typo3.org/33384
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[BUGFIX] RTE: Insert Tag dialogue may raise security error in Firefox 75/33375/3
Stanislas Rolland [Fri, 17 Oct 2014 23:05:32 +0000 (19:05 -0400)]
[BUGFIX] RTE: Insert Tag dialogue may raise security error in Firefox

Problem: If a style sheet from another domain is imported by the style
sheet configured for the RTE, a security error is raised by Firefox
when opening the Insert tag dialogue window.
Solution: Catch the error and report it on the console.

Releases: master, 6.2
Resolves: #62316
Change-Id: I093416abbc784f7548cda3b6c9be1d4b7d484040
Reviewed-on: http://review.typo3.org/33375
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] Use a new icon for sys_action toolbar 72/33372/2
Georg Ringer [Fri, 17 Oct 2014 18:44:34 +0000 (20:44 +0200)]
[TASK] Use a new icon for sys_action toolbar

The sysaction icon in the toolbar must also be changed to an icon
of font awesome.

Resolves: #62315
Releases: master
Change-Id: I8fe101948affaaa1e98778784572775d5380b6cc
Reviewed-on: http://review.typo3.org/33372
Reviewed-by: Kay Strobach <typo3@kay-strobach.de>
Tested-by: Kay Strobach <typo3@kay-strobach.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[FEATURE] RTE: remove deprecated JavaScript methods 44/33344/3
Stanislas Rolland [Thu, 16 Oct 2014 22:55:24 +0000 (18:55 -0400)]
[FEATURE] RTE: remove deprecated JavaScript methods

Some JavaScript methods are deprecated since TYPO3 4.7.

Releases: master
Resolves: #62291
Change-Id: Ie427dc8e898233723650ebdd587e9625b8ea4419
Reviewed-on: http://review.typo3.org/33344
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Edit element dialogue may raise JavaScript error 73/33373/2
Stanislas Rolland [Fri, 17 Oct 2014 18:44:33 +0000 (14:44 -0400)]
[BUGFIX] RTE: Edit element dialogue may raise JavaScript error

When clicking ok, some tabs may have not been rendered. Check for
presence of elements and values.

Releases: master, 6.2
Resolves: #62314
Change-Id: I928ac7ce8bebe2539f49e2153b4f7f8f2f7c889b
Reviewed-on: http://review.typo3.org/33373
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Visual regressions and unifications in Backend 41/33341/2
Felix Kopp [Thu, 16 Oct 2014 21:39:31 +0000 (23:39 +0200)]
[BUGFIX] Visual regressions and unifications in Backend

Unifies tables in documentation, web>info page info + language,
scheduler edit and typoscript object browser.

Also due to the introduction of Bootstrap and refactoring of
t3skin/CSS several views broke. Fixes these.

Removes the FontAwesome save button for now.

Resolves: #62275
Releases: master
Change-Id: I545a24a4664b0f56b2b1d8a4a24aa312b0cc4ded
Reviewed-on: http://review.typo3.org/33341
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] RTE: Remove cut, copy and paste buttons in Firefox 67/33367/2
Stanislas Rolland [Fri, 17 Oct 2014 15:55:25 +0000 (11:55 -0400)]
[BUGFIX] RTE: Remove cut, copy and paste buttons in Firefox

Support for allowClipboard policy has been dropped by Firefox 29.
Therefore, remove cut, copy and paste buttons from the RTE toolbar
in Firefox. Remove also dialogue for installing AllowClipboard Helper
Firefox Addon.

Releases: master, 6.2
Resolves: #62296
Change-Id: I772b07cdca148c60ef8f61097f96fe5872fc0309
Reviewed-on: http://review.typo3.org/33367
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] Base backend login on Twitter Bootstrap 78/33278/7
Ingo Pfennigstorf [Fri, 17 Oct 2014 12:35:32 +0000 (14:35 +0200)]
[TASK] Base backend login on Twitter Bootstrap

* Change HTML & CSS by using twb
* Cleanup the Controller, e.g remove backend_old setting

Gorgeous brand new login screen for TYPO3 backend.

Resolves: #62180
Releases: master
Change-Id: Idc56f14a22e98d95f49cb73223732f2b17b98fab
Reviewed-on: http://review.typo3.org/33278
Reviewed-by: Felix Kopp <felix-source@phorax.com>
Tested-by: Felix Kopp <felix-source@phorax.com>
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Tested-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Handle utf8 strings in TitleCaseFilter 35/33335/4
Graeme Worthy [Thu, 16 Oct 2014 10:50:44 +0000 (12:50 +0200)]
[BUGFIX] Handle utf8 strings in TitleCaseFilter

Use proper charset aware string conversion API to handle
the value given to the TitleCaseFilter.

Resolves: #62279
Releases: master, 6.2
Change-Id: I500af9f1fb6769ea35197e19b2a0a7876d7eb736
Reviewed-on: http://review.typo3.org/33335
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[TASK] Adjust Travis to new requirements for version 7 68/33068/2
Markus Klein [Tue, 30 Sep 2014 10:14:02 +0000 (12:14 +0200)]
[TASK] Adjust Travis to new requirements for version 7

Drop the testing for PHP versions below 5.5

Resolves: #61969
Releases: master
Change-Id: I393a463e0ed1648b58c05c1691a65551e4d4bbab
Reviewed-on: http://review.typo3.org/33068
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Refactor t3skin / re-work HTML / move to extension 56/33256/4
Felix Kopp [Fri, 10 Oct 2014 23:06:58 +0000 (01:06 +0200)]
[TASK] Refactor t3skin / re-work HTML / move to extension

Specific CSS styles that are only needed is a single place should
be held in that specific place also. Moves CSS styles that are only
used in one place to that specific location. These styles are also
only loaded when needed.

Also refactors HTML output of backend modules to be more
HTML5 standard conform. This allows us to remove a lot of CSS.

CSS/less was touched for:
About, About modules, Wizards, Permissions, Setup, TS Template.

Resolves: #62157
Related: #62041
Releases: master
Change-Id: I12a2c8fd0ad5be294d7440f08d8fe96f28841bfc
Reviewed-on: http://review.typo3.org/33256
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Move classAliasMaps into compatibility6 extension part 1 50/33150/7
Anja Leichsenring [Fri, 3 Oct 2014 18:27:25 +0000 (20:27 +0200)]
[TASK] Move classAliasMaps into compatibility6 extension part 1

Change-Id: I5845baff737e739599cf29847981f56f5cf866e3
Resolves: #62026
Relates: #62013
Releases: master
Reviewed-on: http://review.typo3.org/33150
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix unit tests for TypeConverter classes 30/33330/2
Markus Klein [Thu, 16 Oct 2014 08:21:45 +0000 (10:21 +0200)]
[BUGFIX] Fix unit tests for TypeConverter classes

The patch Ia4ec3a6c6f5bc6c07717a4956ab12e3e779c3c5a didn't adjust the
unit tests. This fix adds the missing mocks.

Resolves: #49803
Releases: master, 6.2
Change-Id: I829e62eaf3b172edeb295da57093b424edb13d40
Reviewed-on: http://review.typo3.org/33330
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] Monochrome action icons (FontAwesome) 85/33285/4
Felix Kopp [Sun, 12 Oct 2014 23:07:23 +0000 (01:07 +0200)]
[FEATURE] Monochrome action icons (FontAwesome)

Slot for IconUtility to hook into sprite icon generation.
Delivers monochrome action icons.

"Action icons start actions right with the first click."
Documentation for Iconography in #62158.

Related: #62158
Resolves: #49955
Release: master
Change-Id: I24b1a160b983d690567ad5ba015c6bf13af4f403
Reviewed-on: http://review.typo3.org/33285
Reviewed-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Tested-by: Ingo Pfennigstorf <i.pfennigstorf@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Property of alternative model implementation not found 20/31920/6
Oliver Hader [Thu, 31 Jul 2014 13:17:38 +0000 (15:17 +0200)]
[BUGFIX] Property of alternative model implementation not found

The PersistentObjectConverter is mapping submitted data to a
given target domain model. If a class gets overloaded with
config.tx_extbase.objects, this information is not forwarded
to the ReflectionService. That's why properties in alternative
implementations cannot be determined.

Resolves: #49803
Releases: master, 6.2, 6.1
Change-Id: Ia4ec3a6c6f5bc6c07717a4956ab12e3e779c3c5a
Reviewed-on: http://review.typo3.org/31920
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Add more entropy to uniqid 48/30948/12
Tymoteusz Motylewski [Fri, 20 Jun 2014 15:13:30 +0000 (17:13 +0200)]
[BUGFIX] Add more entropy to uniqid

uniqid() generates values based on current time,
subsequent calls may return the same value on a fast machine.

On Windows it's even worse, as uniqid()
has single-second-resolution out of the box.

Right now it is used in many places in the core,
also for creating temporary identifiers
for newly created records (in the datahandler).

The solution is to add a second parameter to
all calls (which adds more entropy).
see http://php.net/manual/en/function.uniqid.php

To make code consistent, this change adds the
 second parameter to all occurences of uniqid.

Resolves: #59701
Resolves: #58602
Resolves: #59055
Releases: master, 6.2
Change-Id: Id791556d45b4289d75411ff19ae050144fbfe51b
Reviewed-on: http://review.typo3.org/30948
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix Web>Page language view CE header 26/33326/2
Felix Kopp [Wed, 15 Oct 2014 19:35:53 +0000 (21:35 +0200)]
[BUGFIX] Fix Web>Page language view CE header

Fixed Content Element height for Content Element records
in Language view.

Resolves: #62260
Releases: master
Change-Id: I96e86155936e6e4d6c57f72e83ee42bf0aec1619
Reviewed-on: http://review.typo3.org/33326
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Rework Module-Menu CSS/Less 61/33261/3
Felix Kopp [Sat, 11 Oct 2014 10:44:22 +0000 (12:44 +0200)]
[TASK] Rework Module-Menu CSS/Less

Overwork Module-Menu CSS without visual changes.

Resolves: #62161
Releases: master
Change-Id: I8670548c7192d337550589d4aa325a63d186b1c3
Reviewed-on: http://review.typo3.org/33261
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Show correct number of inline records defined in flexform 86/32986/4
Daniel Alder [Fri, 26 Sep 2014 07:42:36 +0000 (09:42 +0200)]
[BUGFIX] Show correct number of inline records defined in flexform

getRelatedRecordsArray() is expecting comma separated list of record ids
Before this patch the full flexform xml was passed.
Now we detect whether a field is a flexform and try to extract the
correct field values from it.

Resolves: #56882
Releases: master, 6.2
Change-Id: I50db5dfd5f07bbc20e369c0a07f2f294afb85321
Reviewed-on: http://review.typo3.org/32986
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Daniel Alder <dalder@snowflake.ch>
Tested-by: Daniel Alder <dalder@snowflake.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Allow lower case for drive letters on Windows in CLI scripts 14/32914/4
Alexander Bohndorf [Mon, 22 Sep 2014 07:46:35 +0000 (09:46 +0200)]
[BUGFIX] Allow lower case for drive letters on Windows in CLI scripts

Resolves: #61749
Releases: master, 6.2, 6.1
Change-Id: I88a3489311e8f94669876ddbe59589f68cd5708e
Reviewed-on: http://review.typo3.org/32914
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Stephan Auer <auer.stephan@gmx.at>
Tested-by: Stephan Auer <auer.stephan@gmx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[FEATURE] A new eval option in TCA: email 51/33251/17
Olle Haerstedt [Fri, 10 Oct 2014 12:36:54 +0000 (14:36 +0200)]
[FEATURE] A new eval option in TCA: email

Add a new eval option called 'email' to validate e-mail addresses.
If validation fails, a flash error message will be shown.

Resolves: #62147
Releases: master
Change-Id: Ie3885aa55a3fde95832fec163bc9347f06b4f54b
Reviewed-on: http://review.typo3.org/33251
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Improve readability of TextElement code 69/33169/3
Wouter Wolters [Sun, 5 Oct 2014 15:38:42 +0000 (17:38 +0200)]
[TASK] Improve readability of TextElement code

FormEngine type="text" in class TextElements gets some
code beautification to improve readability.

Resolves: #62040
Releases: master
Change-Id: I219dc1fcabc656aff6eec81066fa7d51ca950d59
Reviewed-on: http://review.typo3.org/33169
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Add trim to modificators in TS-Parser 88/33288/6
Stefan Froemken [Mon, 13 Oct 2014 09:17:22 +0000 (11:17 +0200)]
[BUGFIX] Add trim to modificators in TS-Parser

It is documented that modificators are trimmed in
TypoScriptParser. But since #54856 they aren't trimmed anymore.
That's why f.e. "addToList (value)" will not be executed.

Resolves: #62188
Related: #54856
Releases: master,6.2
Change-Id: I3828b22a836656ec808ac5d770d58803b9195102
Reviewed-on: http://review.typo3.org/33288
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Move MysqlFulltextIndexHook to EXT:indexed_search_mysql 96/33296/2
Georg Ringer [Mon, 13 Oct 2014 19:44:32 +0000 (21:44 +0200)]
[TASK] Move MysqlFulltextIndexHook to EXT:indexed_search_mysql

The hook MysqlFulltextIndexHook should be moved from indexed_search to
indexed_search_mysql because it is only used if indexed_search_mysql is activated.

Resolves: #62201
Releases: master
Change-Id: I11d61f771abb2d2431c26156fb1d6e0104cba5c9
Reviewed-on: http://review.typo3.org/33296
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Sort BE usergroup records in module "Backend Users" 97/33297/3
Georg Ringer [Mon, 13 Oct 2014 19:52:14 +0000 (21:52 +0200)]
[TASK] Sort BE usergroup records in module "Backend Users"

Add a default ordering for the backend usergroup records
which makes it easier to find a specific group.

Resolves: #61686
Releases: master, 6.2
Change-Id: Ie6eaaaadc7eeca47c33686dc42cca7fc41cfe5b9
Reviewed-on: http://review.typo3.org/33297
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[TASK] Remove the "@todo define visibility" in ext:core 75/33275/2
Wouter Wolters [Sun, 12 Oct 2014 15:08:46 +0000 (17:08 +0200)]
[TASK] Remove the "@todo define visibility" in ext:core

The "@todo Define visibility" is not very helpful because:

 * Nobody knows what breaks if changing the visibility
 * The code is flooded with todos which makes it hard
   to work with in an IDE

During ACME it was decided to remove the @todo again.

Resolves: #62178
Related: #61957
Releases: master
Change-Id: I814739b00128a8ce7403abb42338b10dd598c8c4
Reviewed-on: http://review.typo3.org/33275
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Remove the "@todo define visibility" in ext:rtehtmlarea 70/33270/3
Wouter Wolters [Sat, 11 Oct 2014 18:30:03 +0000 (20:30 +0200)]
[TASK] Remove the "@todo define visibility" in ext:rtehtmlarea

The "@todo Define visibility" is not very helpful because:

 * Nobody knows what breaks if changing the visibility
 * The code is flooded with todos which makes it hard
   to work with in an IDE

During ACME it was decided to remove the @todo again.

Resolves: #62169
Related: #61957
Releases: master
Change-Id: I891efb95449b154636604d3e70f4439bb3da832d
Reviewed-on: http://review.typo3.org/33270
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>