Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Properly nest added FlexFormSectionContainer 89/42889/3
Andreas Fernandez [Thu, 27 Aug 2015 13:10:28 +0000 (15:10 +0200)]
[BUGFIX] Properly nest added FlexFormSectionContainer

Attach new created FlexFormSectionContainer to the right element.
Additionally, event stacking has been resolved.

Resolves: #69361
Releases: master
Change-Id: Iac09051b4dca2cf4393b18892359e14c43dfe8a3
Reviewed-on: http://review.typo3.org/42889
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Form NumberFields ignore typed values in wizard 95/42895/4
Sebastian Wagner [Thu, 27 Aug 2015 19:37:29 +0000 (21:37 +0200)]
[BUGFIX] Form NumberFields ignore typed values in wizard

"Spinner fields" in EXT:form are an old remake of the HTML5
number in ExtJS. Directly typing a value into that spinner
field is not stored - only by clicking the accordant buttons
to "spinup" or "spindown" the value.

A listener for the blur event handles this task and now allows
to store typed numbers as well. The event handler utilizes the
blur event to update the value - thus, the disabled onBlur
handling has to be disabled as well.
Using the change event did not work out due to ExtJS constraints.

Resolves: #69024
Releases: master, 6.2
Change-Id: I13264019c3edbfb8aa7051a4ae2e3ce91dd5c7f6
Reviewed-on: http://review.typo3.org/42895
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[TASK] Deprecate form element IMAGEBUTTON 96/42896/6
Ralf Zimmermann [Thu, 27 Aug 2015 19:46:01 +0000 (21:46 +0200)]
[TASK] Deprecate form element IMAGEBUTTON

Resolves: #69371
Releases: master
Change-Id: I39c2b0a3660ca861e70603181f19782033dd770d
Reviewed-on: http://review.typo3.org/42896
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[BUGFIX] IMAGEBUTTON src attribute not working 92/42892/3
Ralf Zimmermann [Thu, 27 Aug 2015 16:58:27 +0000 (18:58 +0200)]
[BUGFIX] IMAGEBUTTON src attribute not working

Render the IMAGEBUTTON "src" attribute as IMG_RESOURCE
but only the IMG_RESOURCE.file property for security reason.

Resolves: #69372
Releases: master, 6.2
Change-Id: Ic7f3eea9a5c43dc5c7254ce0fd7d6f21db445d4f
Reviewed-on: http://review.typo3.org/42892
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[BUGFIX] Tests: Fix Tag model config in extbase blog_example test extension 52/42652/4
Morton Jonuschat [Sat, 15 Aug 2015 20:27:07 +0000 (22:27 +0200)]
[BUGFIX] Tests: Fix Tag model config in extbase blog_example test extension

The Tag model in the extbase definition included a partial configuration
for translatable records. This includes NOT NULL fields in the SQL
schema definition that aren't declared in the TCA as well as fields that
are not being used by TYPO3 at all. This patch removes the partial
configuration as it caused errors when used with MySQL strict mode.

Resolves: #69089
Releases: master
Change-Id: Ib2c01ddfbbf4c7e4f9c0e53c324a3140ce3fa70f
Reviewed-on: http://review.typo3.org/42652
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[BUGFIX] Image Content elements result in exception 97/42897/4
Daniel Maier [Thu, 27 Aug 2015 22:16:05 +0000 (00:16 +0200)]
[BUGFIX] Image Content elements result in exception

With the change introduced in #66204, the fileObject-uid only was
determined if fileObject is instace of AbstractFile. As the uid
needs also be determined correctly for FileReferences, a more
general approach is needed to check if the getUid method exists
for the given fileObject type.

Resolves: #69377
Related: #66204
Releases: master
Change-Id: Ia837b4706ae4c7f38446751eb8c800d4fad8c8e4
Reviewed-on: http://review.typo3.org/42897
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Tested-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Extbase: Make transOrigDiffSourceField available in DataMap 54/42654/4
Anja Leichsenring [Wed, 26 Aug 2015 15:20:23 +0000 (17:20 +0200)]
[BUGFIX] Extbase: Make transOrigDiffSourceField available in DataMap

The transOrigDiffSourceField needs to be available in the DataMap so
that the persistence layer can properly initialize that field when
inserting new objects into the database. This field is often set to
NOT NULL in the schema which leads to SQL errors when it's not included
in the records, for example with MySQL in strict mode.

Resolves: #69085
Releases: master
Change-Id: I021ac695ab495d3d7257dfae27bd596d49551ccf
Reviewed-on: http://review.typo3.org/42654
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Overwriting form language keys via _LOCAL_LANG 05/42805/6
Ralf Zimmermann [Sun, 23 Aug 2015 15:26:21 +0000 (17:26 +0200)]
[BUGFIX] Overwriting form language keys via _LOCAL_LANG

With this patch it is possible to overwrite language keys from a XLIFF
file by TypoScript with the regular _LOCAL_LANG property.

Example:
plugin.tx_form._LOCAL_LANG.en.tx_form_view_mail\.success = Yay, that worked!

Resolves: #39280
Releases: master
Change-Id: Ic1ce1d3c065751f66d713878324e4bcb52e25330
Reviewed-on: http://review.typo3.org/42805
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Replace static MarkerUtility with object 82/42882/7
Anja Leichsenring [Wed, 26 Aug 2015 11:16:49 +0000 (13:16 +0200)]
[TASK] Replace static MarkerUtility with object

The static MarkerUtility introduced by #69262 can easily replaced with
an object. This makes mocking for tests easier. Deprecation will be
easier as soon the marker support is dropped, too.

Change-Id: I14c2a8402888dfaaa48b0fb9e6c9b40475fd800d
Resolves: #69329
Relates: #69262
Releases: master
Reviewed-on: http://review.typo3.org/42882
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Form Wizard does not respect backend debug mode 86/42886/2
Oliver Hader [Thu, 27 Aug 2015 11:23:12 +0000 (13:23 +0200)]
[BUGFIX] Form Wizard does not respect backend debug mode

Form Wizard does not respect backend debug mode in
$GLOBALS['TYPO3_CONF_VARS']['BE']['debug']. The hardcoded
compression and concatenation is removed by this change.

Resolves: #69353
Releases: master, 6.2
Change-Id: I78aa7f67a8c813fd0208e77b432829fceeb7aa6b
Reviewed-on: http://review.typo3.org/42886
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Sebastian Wagner <sebastian.wagner@tritum.de>
Tested-by: Sebastian Wagner <sebastian.wagner@tritum.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[TASK] Cleanup EXT:frontend 56/38456/21
Michael Oehlhof [Fri, 3 Apr 2015 11:01:31 +0000 (13:01 +0200)]
[TASK] Cleanup EXT:frontend

To get it "green" in PhpStorm, several changes are made:

- add getter for DatabaseConnection
- add getter for TypoScriptFrontendController
- add getter for TimeTracker
- add getter for BackendUser
- add use statements
- add missing return statements
- add missing variable declaration
- set correct PhpDoc comments
- initialize used variables
- remove unused variables

Resolves: #66204
Releases: master
Change-Id: Ifd77e96d46fd3df2c2f0a646deb24ef44814037e
Reviewed-on: http://review.typo3.org/38456
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[!!!][TASK] Remove flash and chart from ExtJS 78/42878/5
Alexander Opitz [Wed, 26 Aug 2015 07:48:19 +0000 (09:48 +0200)]
[!!!][TASK] Remove flash and chart from ExtJS

As we don't use the flash and chart module from ExtJS we remove it to
reduce loading time of backend which is needed to initialize flash on
every module page.

Resolves: #66190
Releases: master
Change-Id: I822887d5d56225abf0498965dd7cbf64220077a2
Reviewed-on: http://review.typo3.org/42878
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Josef Glatz <jousch@gmail.com>
Tested-by: Josef Glatz <jousch@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Add missing back reference for file trees 83/42883/4
Markus Klein [Wed, 26 Aug 2015 19:07:33 +0000 (21:07 +0200)]
[BUGFIX] Add missing back reference for file trees

The ElementBrowserFolderTreeView class needs a back reference
to the ElementBrowser as well.
This was forgotten in #69276.

Resolves: #69322
Releases: master
Change-Id: I9722b2cc39e927aa32e318551f47ad4abc5a18a6
Reviewed-on: http://review.typo3.org/42883
Reviewed-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Tested-by: Sebastian Michaelsen <michaelsen@t3seo.de>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Correctly treat relative date specification in date-VH 85/42885/3
Markus Klein [Wed, 26 Aug 2015 21:47:18 +0000 (23:47 +0200)]
[BUGFIX] Correctly treat relative date specification in date-VH

If now base time is given, a relative date must be based on the current time.
A wrong check is fixed to make this working again.

Resolves: #69335
Related: #68022
Releases: master
Change-Id: I9a4133cc570939533576ec8b2fbe8fffe1103825
Reviewed-on: http://review.typo3.org/42885
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Josef Glatz <jousch@gmail.com>
Tested-by: Josef Glatz <jousch@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Update to phpunit 4.8 80/42880/2
Anja Leichsenring [Wed, 26 Aug 2015 09:35:10 +0000 (11:35 +0200)]
[TASK] Update to phpunit 4.8

Change-Id: I73b083192ec92bc709796cdafd84884747298c70
Releases: master
Resolves: #69325
Reviewed-on: http://review.typo3.org/42880
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[CLEANUP] Fix namespace in SplitProcessor example 81/42881/2
Sascha Egerer [Wed, 26 Aug 2015 09:44:15 +0000 (11:44 +0200)]
[CLEANUP] Fix namespace in SplitProcessor example

Change-Id: I97d6f501b775834a6cdd77f3c4f25b47d63b2065
Resolves: #69324
Releases: master
Reviewed-on: http://review.typo3.org/42881
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
4 years ago[CLEANUP] Remove invalid leading slash in SplitProcessor example 79/42879/3
Sascha Egerer [Wed, 26 Aug 2015 09:17:56 +0000 (11:17 +0200)]
[CLEANUP] Remove invalid leading slash in SplitProcessor example

Change-Id: Ia2e3a1b26455a42e814f4a579d61d83c7f5a8f63
Resolves: #69324
Releases: master
Reviewed-on: http://review.typo3.org/42879
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[TASK] Moved marker substitution functionality to own class 81/41381/7
Benjamin Mack [Wed, 15 Jul 2015 22:37:05 +0000 (00:37 +0200)]
[TASK] Moved marker substitution functionality to own class

The marker substitution functionality has been moved from
core/Classes/Html/HtmlParser.php to own class
core/Classes/Utility/MarkerUtility.php

The following methods within HtmlParser have been marked as deprecated.

* HtmlParser::getSubpart()
* HtmlParser::substituteSubpart()
* HtmlParser::substituteSubpartArray()
* HtmlParser::substituteMarker()
* HtmlParser::substituteMarkerArray()
* HtmlParser::substituteMarkerAndSubpartArrayRecursive()

Resolves: #69262
Releases: master
Change-Id: Ia0ffb3715b3ecef9739db4f6aad53bae9c224b90
Reviewed-on: http://review.typo3.org/41381
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[BUGFIX] Indexed Search: Escape search strings for LIKE queries 06/42806/4
Morton Jonuschat [Fri, 21 Aug 2015 09:49:22 +0000 (11:49 +0200)]
[BUGFIX] Indexed Search: Escape search strings for LIKE queries

LIKE queries support special placeholders (_ and %). These characters
need proper escaping before being used in database queries. Use the
escapeStrForLike() method to provide properly escaped strings to the
query.

Resolves: #69227
Releases: master
Change-Id: I29c41bfecdbc13e8156ab9257b906696bc7a5e4f
Reviewed-on: http://review.typo3.org/42806
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[TASK] Add unit tests for HtmlParser->splitIntoBlock() 40/42840/5
Michael Oehlhof [Sat, 22 Aug 2015 18:03:04 +0000 (20:03 +0200)]
[TASK] Add unit tests for HtmlParser->splitIntoBlock()

Resolves: #69264
Releases: master
Change-Id: I73e1bd8894180658fd6911dbca0104518ceaf585
Reviewed-on: http://review.typo3.org/42840
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[!!!][TASK] Streamline ElementBrowser mode handling 75/42875/4
Markus Klein [Tue, 25 Aug 2015 16:37:23 +0000 (18:37 +0200)]
[!!!][TASK] Streamline ElementBrowser mode handling

The ElementBrowser now has a main entry point which takes
care of dispatching to the the various modes.
The main_*() methods of ElementBrowser are therefore made protected.

The $mode member of ElementBrowserController is not needed
by outside code and is therefore protected as well.

Additionally, the $content member of ElementBrowserController and
the printContent() method are removed.

Resolves: #69315
Releases: master
Change-Id: Ib9790915e72d3a5a460211a93ceeda24ee165c3e
Reviewed-on: http://review.typo3.org/42875
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[TASK] Add unit tests for HtmlParser->removeFirstAndLastTag() 44/42844/4
Michael Oehlhof [Sun, 23 Aug 2015 08:15:42 +0000 (10:15 +0200)]
[TASK] Add unit tests for HtmlParser->removeFirstAndLastTag()

Resolves: #69266
Releases: master
Change-Id: I8c35c1c175e632d2cba9fb6a495daf09486dc290
Reviewed-on: http://review.typo3.org/42844
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Add missing breaking changes documentation 14/42814/9
Alexander Schnitzler [Fri, 21 Aug 2015 14:04:19 +0000 (16:04 +0200)]
[TASK] Add missing breaking changes documentation

This patch adds missing documentation for the breaking changes
introduced in https://review.typo3.org/42644.

It also adds an early return for the FileListIsStartModuleUpdate
to prevent unnecessary database operations.

Releases: master
Resolves: #69237
Change-Id: Iaa113741919013b8a0a9513c1dcca2e5db094b04
Reviewed-on: http://review.typo3.org/42814
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FOLLOWUP][!!!][TASK] Trees do not use global SOBE anymore 69/42869/2
Markus Klein [Tue, 25 Aug 2015 12:07:10 +0000 (14:07 +0200)]
[FOLLOWUP][!!!][TASK] Trees do not use global SOBE anymore

Fix wrong instanceof check.

Resolves: #69276
Releases: master
Change-Id: I9beb681c595cfa3e63cfe4ffdbf33557041511b4
Reviewed-on: http://review.typo3.org/42869
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[!!!][TASK] Trees do not use global SOBE anymore 53/42853/4
Markus Klein [Mon, 24 Aug 2015 07:19:42 +0000 (09:19 +0200)]
[!!!][TASK] Trees do not use global SOBE anymore

The back-reference to the underlying instance of ElementBrowser is now
stored as member of the tree.

Resolves: #69276
Releases: master
Change-Id: Ie48a77cd01269ea7e13905d651663424dbb616a1
Reviewed-on: http://review.typo3.org/42853
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[BUGFIX] Correctly assign workspace for rootline retrieval 65/42865/3
Markus Klein [Tue, 25 Aug 2015 10:55:26 +0000 (12:55 +0200)]
[BUGFIX] Correctly assign workspace for rootline retrieval

Resolves: #69306
Releases: master, 6.2
Change-Id: If59ec36222c1124c2918b39fc014e4c8a2d7bf2f
Reviewed-on: http://review.typo3.org/42865
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Use routing for folder navigation tree 47/42847/7
Helmut Hummel [Sun, 23 Aug 2015 06:59:22 +0000 (08:59 +0200)]
[TASK] Use routing for folder navigation tree

Resolves: #69293
Releases: master
Change-Id: I069f3758fc96148043890c6448fda8bc964fd91b
Reviewed-on: http://review.typo3.org/42847
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Password in form is transferred as asterisks 58/42858/2
Xavier Perseguers [Mon, 24 Aug 2015 14:27:22 +0000 (16:27 +0200)]
[BUGFIX] Password in form is transferred as asterisks

Due to a wrong usage of $.inArray() which possibly returns
"0" if element is found at the first position within an array,
TCA fields with a single eval statement "password" are not
properly transferred to TYPO3.

Change-Id: Ic2647fbefc0ea7c9fef88288946af91343fcc55c
Resolves: #69153
Releases: master
Reviewed-on: http://review.typo3.org/42858
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[TASK] Prettify Extbase Debugger Utility 90/42790/4
Benjamin Kott [Thu, 20 Aug 2015 21:58:22 +0000 (23:58 +0200)]
[TASK] Prettify Extbase Debugger Utility

Releases: master
Resolves: #69299
Change-Id: Ibee145703e1689ca804384b20b9af1b0b586b8d8
Reviewed-on: http://review.typo3.org/42790
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[!!!][TASK] Fix configuration for backend module icons 54/42854/6
Helmut Hummel [Mon, 24 Aug 2015 13:45:23 +0000 (15:45 +0200)]
[!!!][TASK] Fix configuration for backend module icons

http://review.typo3.org/38004 removed the typo3/mod directory
with the main modules and their configuration and added the configuration
to `$GLOBALS['TBE_MODULES']`directly.
However for that a sub array key `configuration` was used, which is
inconsistent with all our current API and its usages across other
modules, leading to the situation that this configuration was basically
ignored.

On top of that, http://review.typo3.org/39316 introduced the possibility
to use sprite icons as module icons, which used the configuration key
`icon` in the above mentioned sub array key `configuration`,
making this key the only option evaluated in the sub array.

This change removes this sub array and moves the sprite icon
configuration on top for consistency. For that the key must be changed
to 'iconIdentifier' as 'icon' was already taken for Extbase module
icon configuration.

Resolves: #69291
Releases: master
Change-Id: I282841fdb09c9c2773ca6e5518fdda863f9f8ef5
Reviewed-on: http://review.typo3.org/42854
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Introduce runtime cache for getIndpEnv() 32/42732/5
Markus Klein [Tue, 18 Aug 2015 20:54:48 +0000 (22:54 +0200)]
[TASK] Introduce runtime cache for getIndpEnv()

This method is independent of runtime state, but just reflects
environment state, which does not change during a request.

Caching the result of the method gives a performance boost for common
BE request as documented in the ticket. (85% fewer calls to the method.)

Resolves: #69173
Releases: master
Change-Id: Icb3fd5fb56434c6db2323a9038b7d486426cab7e
Reviewed-on: http://review.typo3.org/42732
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Cleanup navigation frame module registration 56/42856/5
Helmut Hummel [Mon, 24 Aug 2015 14:06:47 +0000 (16:06 +0200)]
[TASK] Cleanup navigation frame module registration

http://review.typo3.org/37611 made the navigation frame dispatched.
For this it leveraged the addNavigationComponent API,
which was introduced only for ExtJS tree components.

Since we want to get rid of ExtJS (and this API specifically),
we need to introduce a different way to make modules or routes
navigation components.

This change reverts the above changes to the API and instead uses
the `navigationFrameModule` option which was introduced in
https://review.typo3.org/#/c/30593

To make this option work with top level modules and inheritance of
the navigation frame,
the evaluation of the option is moved to the module loader, which
has the benefit to have the code only in one place while it needed
to be in two places before.

Resolves: #69270
Releases: master
Change-Id: I7cb2ca2ee6d04001af424c88a1db828d1712caa1
Reviewed-on: http://review.typo3.org/42856
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Deprecate BackendUtility::getPathType_web_nonweb 46/42846/2
Wouter Wolters [Sun, 23 Aug 2015 12:58:20 +0000 (14:58 +0200)]
[TASK] Deprecate BackendUtility::getPathType_web_nonweb

Resolves: #69269
Releases: master
Change-Id: I99f2a486a6bdd5cfb813c5068d226167e4b3ad7f
Reviewed-on: http://review.typo3.org/42846
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[BUGFIX] Copy transOrigDiffSourceField into workspace placeholder 31/42631/4
Morton Jonuschat [Fri, 14 Aug 2015 18:34:18 +0000 (20:34 +0200)]
[BUGFIX] Copy transOrigDiffSourceField into workspace placeholder

The transOrigDiffSourceField field needs to be copied into
workspace move placeholders when it exists as it can be defined
as NOT NULL in the database schema. Not copying it into the
placeholder leads to errors when MySQL is running in strict mode.

Resolves: #69073
Releases: master
Change-Id: Ifcf524675b1d6709d0d77012fdaff35017c00c90
Reviewed-on: http://review.typo3.org/42631
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[TASK] Remove unused CSH file locallang_csh_sysws.xlf 83/42783/2
Wouter Wolters [Thu, 20 Aug 2015 20:59:26 +0000 (22:59 +0200)]
[TASK] Remove unused CSH file locallang_csh_sysws.xlf

Resolves: #69217
Releases: master
Change-Id: I0b76541fff254a1b242a105e4104ea00a523f2a7
Reviewed-on: http://review.typo3.org/42783
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
4 years ago[BUGFIX] Assure a backend domain is set in workspace preview 94/42394/5
Daniel Goerz [Fri, 7 Aug 2015 19:27:44 +0000 (21:27 +0200)]
[BUGFIX] Assure a backend domain is set in workspace preview

Change-Id: Idc17243f8741057ee6ea1746ec6c344aec28d57a
Resolves: #45519
Resolves: #31718
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/42394
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Don't cut off icons in New Record wizard 12/42812/3
Andreas Fernandez [Fri, 21 Aug 2015 13:05:00 +0000 (15:05 +0200)]
[BUGFIX] Don't cut off icons in New Record wizard

If an icon larger than 16x16 pixels is used for the record icon in TCA,
it gets cutted and only the top left part is displayed. Apply proper
CSS rules to fix this behaviour.

Resolves: #69236
Releases: master, 6.2
Change-Id: I9f7643817f05fd6fba73b7884e70dbed2db84999
Reviewed-on: http://review.typo3.org/42812
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Replace ###ID### in openCustomUrlInContentFrame correctly 33/42733/3
Christian Seifert [Tue, 18 Aug 2015 20:31:19 +0000 (20:31 +0000)]
[BUGFIX] Replace ###ID### in openCustomUrlInContentFrame correctly

Adding an URL by getModuleUrl including an array having an ID
parameter id=###ID### results in an escaped string.
Instead of "###ID###" the value "%23%23%23ID%23%23%23" is
submitted to the JavaScript function.

This patch fixes the old replacement function.
Now, you can again add click menu items linking to modules and
passing the selected page uid.

Resolves: #69170
Releases: master, 6.2
Change-Id: Ib4c0a1556dd1ed583e8faefe431e2d4eaaf864ad
Reviewed-on: http://review.typo3.org/42733
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Seifert <christian-f-seifert@gmx.de>
Tested-by: Christian Seifert <christian-f-seifert@gmx.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FEATURE] Add MediaViewHelper 24/38624/11
Frans Saris [Fri, 10 Apr 2015 19:19:23 +0000 (21:19 +0200)]
[FEATURE] Add MediaViewHelper

In order to comfortably render video, audio and all other file types
with a registered Renderer class (RenderingRegistry introduced with
#61800) in FE, we add a new ViewHelper.

The new MediaViewHelper first checks if there is a Renderer present for
the given file. If not, it will as fallback render a image tag.
This way it is a replacement for the ImageViewHelper in most cases.

Releases: master
Resolves: #66366
Change-Id: I4f92b5f1030238aacb544e45a35189f4e3d0732e
Reviewed-on: http://review.typo3.org/38624
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Markus Sommer <markussom@posteo.de>
Tested-by: Markus Sommer <markussom@posteo.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
4 years ago[TASK] Remove unused TCA description file for EM 81/42781/3
Wouter Wolters [Thu, 20 Aug 2015 20:57:33 +0000 (22:57 +0200)]
[TASK] Remove unused TCA description file for EM

Resolves: #69216
Releases: master
Change-Id: I5ed4b8f05da06328699fff86eacddc816d7ad145
Reviewed-on: http://review.typo3.org/42781
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[CLEANUP] Removed unused CSC constant 10/42810/2
Markus Klein [Fri, 21 Aug 2015 12:23:49 +0000 (14:23 +0200)]
[CLEANUP] Removed unused CSC constant

The constant "addIntextClearer" is not evaluated, remove it.

Resolves: #69235
Releases: master
Change-Id: I22d273ff12edc377f7f5661fa813de7cb4438573
Reviewed-on: http://review.typo3.org/42810
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[FOLLOWUP][TASK] Combine several calls to allowTableOnStandardPages 02/42802/2
Georg Ringer [Fri, 21 Aug 2015 08:12:54 +0000 (10:12 +0200)]
[FOLLOWUP][TASK] Combine several calls to allowTableOnStandardPages

The function accepts a comma separated string to add multiple tables.

Change-Id: I51fb442969bb569cf6936c3272551daa861fdbd8
Resolves: #69218
Releases: master
Reviewed-on: http://review.typo3.org/42802
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[FOLLOWUP][BUGFIX] Show first tab in Element Wizard as fallback 00/42800/2
Markus Klein [Fri, 21 Aug 2015 07:44:10 +0000 (09:44 +0200)]
[FOLLOWUP][BUGFIX] Show first tab in Element Wizard as fallback

A wrong variable initialization is fixed.

Resolves: #59810
Releases: master, 6.2
Change-Id: Ied65743326e52e7e56e24a19db57ba40f6b4be47
Reviewed-on: http://review.typo3.org/42800
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Combine several calls to allowTableOnStandardPages 85/42785/2
Wouter Wolters [Thu, 20 Aug 2015 21:43:41 +0000 (23:43 +0200)]
[TASK] Combine several calls to allowTableOnStandardPages

The function accepts a comma separated string to add multiple tables.

Resolves: #69218
Releases: master
Change-Id: Icff55095786e338816cf925c5e89837a436cd201
Reviewed-on: http://review.typo3.org/42785
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Show first tab in Element Wizard as fallback 67/42767/5
Christian Seifert [Thu, 20 Aug 2015 22:59:29 +0000 (22:59 +0000)]
[BUGFIX] Show first tab in Element Wizard as fallback

Using the extension gridelements it is possible to restrict the
selectable content elements instead of the full menu configured
by TSconfig. At first, you might have 5 menus available and you
click on the last menu tab (maybe the fifth), so the backend
stores 5 as current tab.
Adding content elements within a gridelement, which restricts the
range of selectable CEs, you can only select the first tab (p.e.).
The original code assumes that the fifth tab is still there and
tries to select it.

This patch checks first against the existence of the selected tab.
If there is no "fifth" tab p.e. the index is set to 1.

Resolves: #59810
Releases: master, 6.2
Change-Id: I829489737de4631dfe3362e4fb11909be9315864
Reviewed-on: http://review.typo3.org/42767
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Add missing TYPO3_MODE checks in ext_localconf.php 96/42796/2
Wouter Wolters [Thu, 20 Aug 2015 22:34:46 +0000 (00:34 +0200)]
[TASK] Add missing TYPO3_MODE checks in ext_localconf.php

Resolves: #69222
Releases: master
Change-Id: I4e0d737a8035df1c178a584eed203dd48176babe
Reviewed-on: http://review.typo3.org/42796
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[TASK] Remove unused options in global TBE_STYLES 80/42780/2
Wouter Wolters [Thu, 20 Aug 2015 20:38:21 +0000 (22:38 +0200)]
[TASK] Remove unused options in global TBE_STYLES

Since version 7.0 the following options are unused.

* colorschemes
* borderschemes

Resolves: #69215
Releases: master
Change-Id: I6b676aec33e5ce585dd2b6ad5f23f9f449032297
Reviewed-on: http://review.typo3.org/42780
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Use ::class for cleaner command registration in ext:lowlevel 95/42795/2
Wouter Wolters [Thu, 20 Aug 2015 22:17:06 +0000 (00:17 +0200)]
[TASK] Use ::class for cleaner command registration in ext:lowlevel

Resolves: #69221
Releases: master
Change-Id: I3f3970ed213822da6d8e36954ebc1ae8e4392cbe
Reviewed-on: http://review.typo3.org/42795
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Use ::class for hook registration in ext:core 87/42787/2
Wouter Wolters [Thu, 20 Aug 2015 21:52:25 +0000 (23:52 +0200)]
[TASK] Use ::class for hook registration in ext:core

Resolves: #69220
Releases: master
Change-Id: I6a23589bbe29996080fa406fe8084c6817e39a7e
Reviewed-on: http://review.typo3.org/42787
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[BUGFIX] Tests: Create NEWid values the same way as DataHandler 25/42625/3
Morton Jonuschat [Fri, 14 Aug 2015 08:24:34 +0000 (10:24 +0200)]
[BUGFIX] Tests: Create NEWid values the same way as DataHandler

The NEWid values generated in the functions tests of the core use a
different kind of NEWid value that is longer than the values created
within DataHandler. The length of the values generated in the tests
exceeds the length of the database column in the sys_log table, leading
to errors when running MySQL in strict mode.

This change uses the same code as DataHandler to generate NEWid values.

Resolves: #69039
Releases: master
Change-Id: I4380fb333a15d37b9a48b98b211a9143286ec73b
Reviewed-on: http://review.typo3.org/42625
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Add values to submit buttons 64/42764/3
Wouter Wolters [Wed, 19 Aug 2015 17:25:57 +0000 (19:25 +0200)]
[BUGFIX] Add values to submit buttons

Submit buttons need to have a value set,
otherwise submit checks in the PHP code won't work.

Some useless POST checks are removed after the removal of the
type=image input fields for saving data.

Resolves: #69194
Releases: master
Change-Id: If42da73242d82d96d0042e0bedce69ad2a302427
Reviewed-on: http://review.typo3.org/42764
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
4 years ago[FOLLOWUP][BUGFIX] Use correct max size for fields in TCA 73/42773/2
Georg Ringer [Thu, 20 Aug 2015 12:25:02 +0000 (14:25 +0200)]
[FOLLOWUP][BUGFIX] Use correct max size for fields in TCA

Some fields are using a varchar(255) in the DB but the max size
is defined with 256 in the TCA. Change the TCA to 255 to avoid errors.

Change-Id: I9a8dcfaf4563442932ae7f259858ad070415ea24
Resolves: #69209
Releases: master
Reviewed-on: http://review.typo3.org/42773
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Use correct max size for fields in TCA 72/42772/2
Georg Ringer [Thu, 20 Aug 2015 12:12:28 +0000 (14:12 +0200)]
[BUGFIX] Use correct max size for fields in TCA

Some fields are using a varchar(255) in the DB but the max size
is defined with 256 in the TCA. Change the TCA to 255 to avoid errors.

Change-Id: Iad09512e98bb9e2fb9b52e32e0f5f4f8d9b49035
Resolves: #69209
Releases: master
Reviewed-on: http://review.typo3.org/42772
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[FEATURE] Get list of pages based on pageuids from page repository 01/41601/14
Patrick Broens [Wed, 15 Jul 2015 18:36:51 +0000 (20:36 +0200)]
[FEATURE] Get list of pages based on pageuids from page repository

The frontend page repository is now capable of retrieving a list
of pages based on a single page uid or an array of page uids
like HMENU.
This functionality is needed to retrieve pages for the rendering of
several frontend menus by the content element "Special Menus"

Resolves: #68300
Releases: master
Change-Id: I906c07478f3f07ece71aa428cc03cc3a237dfd27
Reviewed-on: http://review.typo3.org/41601
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Add unit tests for HtmlParser::substituteSubpartArray() 37/42737/4
Michael Oehlhof [Tue, 18 Aug 2015 22:56:20 +0000 (00:56 +0200)]
[TASK] Add unit tests for HtmlParser::substituteSubpartArray()

Resolves: #69175
Releases: master
Change-Id: Id85a7ab6bc7f3b3281f394fd9a41ecd64ab51ec7
Reviewed-on: http://review.typo3.org/42737
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[TASK] Add unit tests for HtmlParser::substituteMarker() 65/42765/4
Michael Oehlhof [Wed, 19 Aug 2015 19:59:51 +0000 (21:59 +0200)]
[TASK] Add unit tests for HtmlParser::substituteMarker()

Resolves: #69196
Releases: master
Change-Id: I46a1f5f1ed0b7d2e0a2ceeb22768140771d99ffb
Reviewed-on: http://review.typo3.org/42765
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Respect editlock of pages in inline editing 34/41734/13
Andreas Fernandez [Mon, 20 Jul 2015 12:30:03 +0000 (14:30 +0200)]
[TASK] Respect editlock of pages in inline editing

Disable drag and drop of content elements in Page module
and inline page title editing if page's editlock is set.

Resolves: #68388
Related: #68279
Releases: master
Change-Id: Ibcb285babb84f0777eb621f244f2a9e40498596b
Reviewed-on: http://review.typo3.org/41734
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[TASK] Add unit tests for HtmlParser::substituteMarkerArray() 66/42766/2
Michael Oehlhof [Wed, 19 Aug 2015 20:37:30 +0000 (22:37 +0200)]
[TASK] Add unit tests for HtmlParser::substituteMarkerArray()

Resolves: #69197
Releases: master
Change-Id: I551ce23be294b152117943f5b6e89ed360a8db50
Reviewed-on: http://review.typo3.org/42766
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Restore save+view|close|new functionality 47/42647/4
Markus Klein [Wed, 19 Aug 2015 15:47:01 +0000 (17:47 +0200)]
[BUGFIX] Restore save+view|close|new functionality

Resolves: #68981
Releases: master
Change-Id: I203ed2a58c30cf0da89bedb266453eeff32b34cc
Reviewed-on: http://review.typo3.org/42647
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] DataHandler: Assign reference default values 50/42550/8
Morton Jonuschat [Wed, 12 Aug 2015 20:55:59 +0000 (22:55 +0200)]
[BUGFIX] DataHandler: Assign reference default values

In MySQL stric mode scenarios, relation types not using MM tables
or the foreign_field definition (IRRE) might end up in no
references at all, which is only the trigger for the actual
problem. These references result in a blank string ("") that
is casted in non-strict modes to the accordant field type
defined by the DMBS schema.

In strict mode this has to be handled more specific. Since the
system cannot determine the real meaning automatically, values
for reference that are produced in the mentioned scenario are
now casted to zero (0) or to the default value defined in the
accordant TCA configuration of the field.

Resolves: #69004
Releases: master
Change-Id: I6608f1fe0f63a99caa1208b1d3d76354b6f659cf
Reviewed-on: http://review.typo3.org/42550
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[TASK] Add missing unit tests for SilentConfigurationUpgradeService 87/42487/5
Michael Oehlhof [Mon, 10 Aug 2015 18:06:24 +0000 (20:06 +0200)]
[TASK] Add missing unit tests for SilentConfigurationUpgradeService

Missing unit tests for GFX settings are added:
disableImageMagickAndGdlibIfImageProcessingIsDisabled()
disableImageMagickDetailSettingsIfImageMagickIsDisabled()
setImageMagickDetailSettings()

Resolves: #68913
Releases: master
Change-Id: I45a4e7ed4d614bd6e657c714a09d8251f25eff25
Reviewed-on: http://review.typo3.org/42487
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Log exception as array instead of serialized 17/42717/3
Stephan Großberndt [Tue, 18 Aug 2015 14:54:05 +0000 (16:54 +0200)]
[BUGFIX] Log exception as array instead of serialized

Log exceptions thrown by scheduler tasks as array instead of
serializing the whole exception in order to keep the size down.

Resolves: #69157
Releases: master, 6.2
Change-Id: Ifc6457f3de114779a522baa77443e5019f0dc4c1
Reviewed-on: http://review.typo3.org/42717
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Add unit tests for HtmlParser::substituteSubpart() 18/42718/5
Michael Oehlhof [Tue, 18 Aug 2015 16:02:24 +0000 (18:02 +0200)]
[TASK] Add unit tests for HtmlParser::substituteSubpart()

Resolves: #69160
Releases: master
Change-Id: I240dd575b6b105846493a608b8039b0883e2a866
Reviewed-on: http://review.typo3.org/42718
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Add unit tests for HtmlParser::getSubpart() 67/42667/5
Michael Oehlhof [Sun, 16 Aug 2015 23:15:59 +0000 (01:15 +0200)]
[TASK] Add unit tests for HtmlParser::getSubpart()

Resolves: #69116
Releases: master
Change-Id: I07d4d04d2108976287617b458c0f9857099c2ada
Reviewed-on: http://review.typo3.org/42667
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Remove addModulePath call for ext:taskcenter 34/42734/2
Wouter Wolters [Tue, 18 Aug 2015 21:18:25 +0000 (23:18 +0200)]
[TASK] Remove addModulePath call for ext:taskcenter

Wrong module name is used.
Is not in tools but in user.

Resolves: #69174
Releases: master
Change-Id: Ic2d4a287529b0898c529fb1e04ee7f0b37e4586e
Reviewed-on: http://review.typo3.org/42734
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Streamline tt_content TCA types configuration 29/42729/3
Oliver Hader [Tue, 18 Aug 2015 19:31:06 +0000 (21:31 +0200)]
[TASK] Streamline tt_content TCA types configuration

The 3rd parameter of the TCA types configuration is deprecated.
Therefore the structure needs to be changed - accordingly to
the messages being shown in the deprecation log.

This behavior can only be reproduced if EXT:css_styled_content
is deactivated - since it overrides the mentioned types section.

Resolves: #69171
Releases: master
Change-Id: I9669b1c994b0a711862715f1fb4da672df8630a2
Reviewed-on: http://review.typo3.org/42729
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Remove not used include for CSS files in ext:core 16/42716/2
Wouter Wolters [Tue, 18 Aug 2015 13:55:47 +0000 (15:55 +0200)]
[TASK] Remove not used include for CSS files in ext:core

The mentioned directory doesn't exists.

Resolves: #69156
Releases: master
Change-Id: I0a2847932178c4d6b0fe1297b82116eb4ded7535
Reviewed-on: http://review.typo3.org/42716
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[!!!][TASK] Remove non-tabbed view of Content Element Wizard 22/42722/5
Benjamin Mack [Tue, 18 Aug 2015 17:11:29 +0000 (19:11 +0200)]
[!!!][TASK] Remove non-tabbed view of Content Element Wizard

Resolves: #69168
Releases: master
Change-Id: I88a73fde52af453181fb0b1bc33ea325e5424765
Reviewed-on: http://review.typo3.org/42722
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][BUGFIX] Correct "required"-parameter in TextfieldViewHelper 45/40645/6
Frederic Gaus [Thu, 25 Jun 2015 13:42:08 +0000 (15:42 +0200)]
[!!!][BUGFIX] Correct "required"-parameter in TextfieldViewHelper

Releases: master
Resolves: #67098
Change-Id: Ifc322aba2cf95849e1541cac4df65d30aeb56bc3
Reviewed-on: http://review.typo3.org/40645
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[TASK] Move EXT:impexp entrypoint to Routing 27/42727/3
Benjamin Mack [Tue, 18 Aug 2015 18:46:56 +0000 (20:46 +0200)]
[TASK] Move EXT:impexp entrypoint to Routing

Resolves: #69167
Releases: master
Change-Id: I7e20ed767803621cb555dcf3bc47c269505390ea
Reviewed-on: http://review.typo3.org/42727
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Exclude computed field names on fetching record overlays 60/42160/4
Albrecht Köhnlein [Fri, 31 Jul 2015 08:12:23 +0000 (10:12 +0200)]
[BUGFIX] Exclude computed field names on fetching record overlays

During versioning, the dynamic fields _ORIG_pid and _ORIG_uid are added
to $row, but they do not exist in database and cause an SQL error.

Resolves: #68643
Releases: master, 6.2
Change-Id: I33a56b2071a04b5224821805e60722ce8dd3dd14
Reviewed-on: http://review.typo3.org/42160
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 years ago[TASK] Move EXT:version entrypoint to Routing 26/42726/4
Benjamin Mack [Tue, 18 Aug 2015 18:04:31 +0000 (20:04 +0200)]
[TASK] Move EXT:version entrypoint to Routing

Resolves: #69166
Releases: master
Change-Id: I7fe803ff352464b984ff7008e6ed1aad2c1bdada
Reviewed-on: http://review.typo3.org/42726
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Streamline Version Module 04/42004/8
Benjamin Kott [Mon, 27 Jul 2015 22:14:36 +0000 (00:14 +0200)]
[TASK] Streamline Version Module

- Streamline appearance
- Remove unused JavaScript
- Remove unused CSS
- Use IconFactory

Resolves: #48125
Releases: master
Change-Id: I9efe60a30c895c68c2e4da8105f243f181418525
Reviewed-on: http://review.typo3.org/42004
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Streamline addModulePath call 25/42725/2
Benjamin Mack [Tue, 18 Aug 2015 18:03:19 +0000 (20:03 +0200)]
[TASK] Streamline addModulePath call

The addModulePath functionality is also copied inside
addModule in ExtensionManagementUtility and can be reused.

During that, the EXT:recordlist/ext_tables.php call, is duplicated
and addModulePath can be removed there.

Releases: master
Resolves: #69165
Change-Id: I92dd5b566283d4114216242bf297ef42d6b709a0
Reviewed-on: http://review.typo3.org/42725
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Add missing unit tests for SilentConfigurationUpgradeService (5) 32/42632/4
Michael Oehlhof [Fri, 14 Aug 2015 19:55:29 +0000 (21:55 +0200)]
[TASK] Add missing unit tests for SilentConfigurationUpgradeService (5)

Missing unit tests for configureBackendLoginSecurity() are added.

Resolves: #69075
Releases: master
Change-Id: I94898193d5e8bcee5ed5b99b5ac7e69a8a5787ea
Reviewed-on: http://review.typo3.org/42632
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Move CSH Javascript to EXT:cshmanual 19/42719/6
Benjamin Mack [Tue, 18 Aug 2015 16:52:34 +0000 (18:52 +0200)]
[TASK] Move CSH Javascript to EXT:cshmanual

Releases: master
Resolves: #69161
Change-Id: If0df623ea07c06781aad7f89496919ed2a5f8729
Reviewed-on: http://review.typo3.org/42719
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FOLLOWUP][TASK] Migrate tce_db, tce_file and FormEngine entry points to routing 24/42724/2
Wouter Wolters [Tue, 18 Aug 2015 17:58:43 +0000 (19:58 +0200)]
[FOLLOWUP][TASK] Migrate tce_db, tce_file and FormEngine entry points to routing

Fix broken unit-tests.

Resolves: #69162
Releases: master
Change-Id: I4331db64694bb3921cdce1795f155afeddba5d5b
Reviewed-on: http://review.typo3.org/42724
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[TASK] Migrate tce_db, tce_file and FormEngine entry points to routing 21/42721/5
Benjamin Mack [Tue, 18 Aug 2015 16:56:54 +0000 (18:56 +0200)]
[TASK] Migrate tce_db, tce_file and FormEngine entry points to routing

Resolves: #69162
Releases: master
Change-Id: I1cd25425cf344212c192c78bdf4e2f002fb66173
Reviewed-on: http://review.typo3.org/42721
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][TASK] Remove Extbase ModuleRunner 02/42702/5
Benjamin Mack [Mon, 17 Aug 2015 13:00:46 +0000 (15:00 +0200)]
[!!!][TASK] Remove Extbase ModuleRunner

The ModuleRunner and its interface were initially designed
to allow backend modules other than the "classic" modules that
need a conf.php and index.php to be a flexible entry point

Resolves: #69148
Releases: master
Change-Id: I695e41544f2154115b95c1b120da7c227abd4bcf
Reviewed-on: http://review.typo3.org/42702
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Do not store files directly into typo3temp 34/42634/7
Markus Klein [Fri, 14 Aug 2015 21:13:23 +0000 (23:13 +0200)]
[TASK] Do not store files directly into typo3temp

Use a subfolder within typo3temp if files are meant to be persisted
there. Only allow Install Tool, UnitTests and temporary files for a
request to reside in the root typo3temp folder.

Resolves: #69078
Releases: master
Change-Id: I6202e84fefc7daff9dfcecb1c074d8e64de24718
Reviewed-on: http://review.typo3.org/42634
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[TASK] Tests: Include all NOT NULL fields in EXT:extbase fixtures 30/42630/2
Morton Jonuschat [Fri, 14 Aug 2015 09:00:09 +0000 (11:00 +0200)]
[TASK] Tests: Include all NOT NULL fields in EXT:extbase fixtures

The fixtures used by the functional tests are incomplete and don't
contain all fields that are defined as NOT NULL in the database schema.
Add the missing information to the fixtures to successfully create the
test fixtures in MySQL strict mode.

Resolves: #69072
Releases: master
Change-Id: I793ca8d0cb07ae2c36c1bc74cb473b01ac45594f
Reviewed-on: http://review.typo3.org/42630
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Tests: Include all NOT NULL fields in EXT:workspaces fixtures 28/42628/3
Morton Jonuschat [Fri, 14 Aug 2015 13:40:21 +0000 (15:40 +0200)]
[TASK] Tests: Include all NOT NULL fields in EXT:workspaces fixtures

The fixtures used by the functional tests are incomplete and don't
contain all fields that are defined as NOT NULL in the database schema.
Add the missing information to the fixtures to make tests pass when
running in MySQL strict mode.

Resolves: #69059
Releases: master
Change-Id: I466cf8fd965918096cc72710a8637e82d26d48c9
Reviewed-on: http://review.typo3.org/42628
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Tests: Include all NOT NULL fields in CategoryCollection fixtures 48/42648/2
Morton Jonuschat [Thu, 13 Aug 2015 17:34:23 +0000 (19:34 +0200)]
[TASK] Tests: Include all NOT NULL fields in CategoryCollection fixtures

The fixtures used by the functional tests are incomplete and don't
contain all fields that are defined as NOT NULL in the database schema.
Add the missing information so the fixtures can be successfully inserted
when running in MySQL strict mode.

Resolves: #69031
Releases: master
Change-Id: I0347cae10646e29a62f1d8729a89a4ffed491895
Reviewed-on: http://review.typo3.org/42648
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Tests: Include all NOT NULL fields in EXT:impexp fixtures 27/42627/2
Morton Jonuschat [Fri, 14 Aug 2015 13:39:44 +0000 (15:39 +0200)]
[TASK] Tests: Include all NOT NULL fields in EXT:impexp fixtures

The fixtures used by the functional tests are incomplete and don't
contain all fields that are defined as NOT NULL in the database schema.
Add the missing information to the fixtures to make tests pass when
running in MySQL strict mode.

Resolves: #69058
Releases: master
Change-Id: Ic55f83c0a41b29f88e8ccbc3220d2641b0b83150
Reviewed-on: http://review.typo3.org/42627
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Tests: Include all NOT NULL fields in DataHandling fixtures 24/42624/2
Morton Jonuschat [Fri, 14 Aug 2015 08:23:53 +0000 (10:23 +0200)]
[TASK] Tests: Include all NOT NULL fields in DataHandling fixtures

The fixtures used by the functional tests are incomplete and don't
contain all fields that are defined as NOT NULL in the database schema.
Add the missing information to the fixtures to make tests pass when
running in MySQL strict mode.

Resolves: #69043
Resolves: #69051
Releases: master
Change-Id: I264cd809414b9b45b0bf1b14f33562ed298c4a3f
Reviewed-on: http://review.typo3.org/42624
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Use 'wizard_element_browser' instead of 'browser' in FormEngine 92/42692/2
Markus Klein [Mon, 17 Aug 2015 20:12:06 +0000 (22:12 +0200)]
[TASK] Use 'wizard_element_browser' instead of 'browser' in FormEngine

FormEngine is the last place using the module 'browser'.
This module is the ElementBrowserFramesetController,
which uses a frameset. The frameset has no further functionality
and the additional JS provided by the class, is not used anymore.

We can therefore use the 'wizard_element_browser' module directly,
which does not render a frameset.

Resolves: #69140
Releases: master
Change-Id: Ibfc8147a6e822655ebd2e8f347f6f55c0e8382e5
Reviewed-on: http://review.typo3.org/42692
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[TASK] Remove package class source from package manager cache 93/42693/3
Helmut Hummel [Mon, 17 Aug 2015 22:18:57 +0000 (00:18 +0200)]
[TASK] Remove package class source from package manager cache

Writing the package class source to the package manager cache
has become pointless after package management cleanup.
It is only the source of one class and this source stays always
the same. We do not win anything from writing it to the cache.

Resolves: #69142
Releases: master
Change-Id: I8b910c3e133b1ffd9f0efbdbceb6dd067d9d6f78
Reviewed-on: http://review.typo3.org/42693
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Viewpage language selector 62/27862/7
Erik Frister [Wed, 26 Feb 2014 10:02:06 +0000 (11:02 +0100)]
[FEATURE] Viewpage language selector

Adds a language selector to the viewpage module.

Resolves: #56282
Releases: master
Change-Id: Iae19f533f447c20aab7d672eff9aa1d202365363
Reviewed-on: http://review.typo3.org/27862
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[TASK] Add typehints for ElementBrowser usage via SOBE 91/42691/5
Markus Klein [Mon, 17 Aug 2015 22:03:33 +0000 (00:03 +0200)]
[TASK] Add typehints for ElementBrowser usage via SOBE

The TreeViews access the controllers via the global SOBE.
This patch adds typehints to easily identify those usages.

Resolves: #69139
Releases: master
Change-Id: Ib280d4f9a2eeeb347893d1a9ab761760d993cac5
Reviewed-on: http://review.typo3.org/42691
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[TASK] Remove width/height fields for links in ElementBrowser 90/42690/4
Markus Klein [Mon, 17 Aug 2015 18:19:15 +0000 (20:19 +0200)]
[TASK] Remove width/height fields for links in ElementBrowser

Resolves: #69137
Releases: master
Change-Id: I6da10b4531bce9e13a9b062e43fa6b4b1e33c6fb
Reviewed-on: http://review.typo3.org/42690
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[TASK] Update FontAwesome to version 4.4.0 83/42683/3
Andreas Fernandez [Mon, 17 Aug 2015 13:42:57 +0000 (15:42 +0200)]
[TASK] Update FontAwesome to version 4.4.0

Resolves: #69131
Releases: master
Change-Id: I4df75e2f9b89e4ff3d50c31eef565a9b8965b4a8
Reviewed-on: http://review.typo3.org/42683
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Assure language override without original file 24/37524/5
Stefan Galinski [Wed, 4 Mar 2015 14:50:20 +0000 (15:50 +0100)]
[BUGFIX] Assure language override without original file

The language override of language files is currently broken,
because it only works if a localized language file already
exists inside the extension or l10n directory. This patch assures
that the language override takes place even if no file could
be found in the first place.

Resolves: #65513
Releases: master, 6.2
Change-Id: I9269e60c5788c435b06b820c459fd4f077d066ea
Reviewed-on: http://review.typo3.org/37524
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Stefan Galinski <stefan.galinski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[CLEANUP] ElementBrowser classes 89/42689/4
Markus Klein [Mon, 17 Aug 2015 17:29:33 +0000 (19:29 +0200)]
[CLEANUP] ElementBrowser classes

Next step in cleanup and separation of concerns.
Removal of unused or redundant code.

Resolves: #69136
Releases: master
Change-Id: I4a81c6856bf44cf15ceea1cad9e41f00ba43f70a
Reviewed-on: http://review.typo3.org/42689
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Extbase: Use fully populated records in Backend::insertObject() 56/42656/3
Morton Jonuschat [Sat, 15 Aug 2015 20:05:47 +0000 (22:05 +0200)]
[BUGFIX] Extbase: Use fully populated records in Backend::insertObject()

To successfully insert new records into a database that does not
silently convert NULL values being inserted into NOT NULL columns (MySQL
in strict mode, PostgreSQL) it is necessary to use a fully
populated record, even if it contains only placeholders for some fields
like relations or reference counters.

Resolves: #69084
Releases: master
Change-Id: I89e79d59ad53666432e73c3b1651323d0d506ac3
Reviewed-on: http://review.typo3.org/42656
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 years ago[TASK] Make sysext filelist an extbase module 44/42644/9
Alexander Schnitzler [Sat, 15 Aug 2015 12:56:48 +0000 (14:56 +0200)]
[TASK] Make sysext filelist an extbase module

Currently the filelist module is not yet an extbase
module. To be able to adjust the module in the future
more easily the module will be based on extbase.

Releases: master
Resolves: #69083
Change-Id: I74884cd554272b68ab80509b7548647ff01632d6
Reviewed-on: http://review.typo3.org/42644
Reviewed-by: Carsten Bleicker <carsten@bleicker.de>
Tested-by: Carsten Bleicker <carsten@bleicker.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 years ago[BUGFIX] Icon state toggling in record list 81/42681/3
Andreas Fernandez [Mon, 17 Aug 2015 12:44:59 +0000 (14:44 +0200)]
[BUGFIX] Icon state toggling in record list

When the toggle icon is clicked, the state icon class gets removed,
but the called toggleClass() methods add both icon state classes
again. Change the JavaScript to only add the required icon state
class to the button.

Resolves: #69128
Releases: master
Change-Id: I192163ba35ca0a11fb6c8621af8be04796c82b61
Reviewed-on: http://review.typo3.org/42681
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[BUGFIX] Recycler: Reset internal toggle state after bulk action 82/42682/2
Andreas Fernandez [Mon, 17 Aug 2015 12:58:57 +0000 (14:58 +0200)]
[BUGFIX] Recycler: Reset internal toggle state after bulk action

Reset the internal toggle state in the recycler after a bulk action to get the
button responding after a single click again.

Resolves: #69129
Releases: master
Change-Id: I85d4df932f27cfbd48ac19e4d698e56dc71caec5
Reviewed-on: http://review.typo3.org/42682
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[TASK] Move record-related entrypoints to backend routing 09/42609/3
Manuel Selbach [Fri, 14 Aug 2015 08:00:21 +0000 (10:00 +0200)]
[TASK] Move record-related entrypoints to backend routing

Resolves: #69038
Releases: master
Change-Id: I6ad5e541b1741f0b29a1f68d631404cb5a6d38d2
Reviewed-on: http://review.typo3.org/42609
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 years ago[TASK] Update jQuery to 2.x 94/42494/4
Stefan Neufeind [Wed, 12 Aug 2015 18:40:24 +0000 (20:40 +0200)]
[TASK] Update jQuery to 2.x

Change-Id: Ib39b7e52b794ec375027a3ac1315c6e84e345f93
Resolves: #68917
Releases: master
Reviewed-on: http://review.typo3.org/42494
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
4 years ago[BUGFIX] Apply default values in DataHandler functional tests 98/42598/5
Oliver Hader [Thu, 13 Aug 2015 17:30:42 +0000 (19:30 +0200)]
[BUGFIX] Apply default values in DataHandler functional tests

If MySQL is used in strict mode, setting up the functional
testing scenario requires proper field values for those
fields not having a default value defined in the schema.
For some field types, like BLOB or TEXT this is not possible
and thus has to be determined from the accordant TCA field
configurations.

Resolves: #69030
Releases: master
Change-Id: Ie915fdaca6c90440259e01896677a2d2395417f4
Reviewed-on: http://review.typo3.org/42598
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>