Packages/TYPO3.CMS.git
17 months ago[TASK] Use proper PHPdoc type annotations in Extbase error layer 87/54787/2
Oliver Hader [Mon, 27 Nov 2017 10:58:17 +0000 (11:58 +0100)]
[TASK] Use proper PHPdoc type annotations in Extbase error layer

Resolves: #83111
Releases: master, 8.7
Change-Id: Ifde44802b9cf120f1a6ba3490022ccda1458e00d
Reviewed-on: https://review.typo3.org/54787
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[TASK] Ensure introduction package is properly installed 83/54783/2
Andreas Fernandez [Fri, 8 Sep 2017 18:59:28 +0000 (20:59 +0200)]
[TASK] Ensure introduction package is properly installed

Resolves: #83108
Releases: master, 8.7
Change-Id: I72d30fdab6ea3cc72078d5cf50b38915ff388fa2
Reviewed-on: https://review.typo3.org/54783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
17 months ago[CLEANUP] Alwas put null at the last position 81/54781/5
Alexander Schnitzler [Mon, 27 Nov 2017 10:25:34 +0000 (11:25 +0100)]
[CLEANUP] Alwas put null at the last position

This patch applies the phpdoc_types_order rule of the
php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types_order

Releases: master, 8.7
Resolves: #83109
Change-Id: I57291fb0b113ad01e2a171c1cfd6a9943d6302ad
Reviewed-on: https://review.typo3.org/54781
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
17 months ago[BUGFIX] bamboo: Label parsing 76/54776/2
Christian Kuhn [Mon, 27 Nov 2017 09:23:05 +0000 (10:23 +0100)]
[BUGFIX] bamboo: Label parsing

The bamboo test setup relies on a funny solution to determine the
gerrit patch id and patch set, used for reporting results back
to gerrit.

The regex based solution started behaving weird with latest
bamboo versions and is now quoted slightly differently to fix that.

Special thanks to atlassian support for being friendly, helpful,
quick and providing a working solution to our issue.

Change-Id: I51ec85be2133033777fac8ff1f12071a81c71efc
Resolves: #83107
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54776
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
17 months ago[CLEANUP] The correct case must be used for standard PHP types in phpdoc 75/54775/5
Alexander Schnitzler [Mon, 27 Nov 2017 08:10:31 +0000 (09:10 +0100)]
[CLEANUP] The correct case must be used for standard PHP types in phpdoc

This patch applies the phpdoc_types rule of the
php-cs-fixer. See http://cs.sensiolabs.org/ -> phpdoc_types

Releases: master, 8.7
Resolves: #83106
Change-Id: I958b75d85a08169a987afe9eed0baa4d86139770
Reviewed-on: https://review.typo3.org/54775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
17 months ago[FEATURE] Introduce Yarn and fix dependency handling and downgrade some libs 49/54749/3
Benjamin Kott [Fri, 24 Nov 2017 18:44:17 +0000 (19:44 +0100)]
[FEATURE] Introduce Yarn and fix dependency handling and downgrade some libs

Because of the broken dependency manager logic in NPM this patch introduce
yarn as dependency manager for node modules.
Also this patch downgrade some libs, which was updated accidentally in past.

To install node modules you have to install yarn first and call
`yarn install`, do not use `yarn update` until you really want
update a dependency.

Resolves: #83038
Releases: master, 8.7
Change-Id: I842636241d76b88f2b9e3836230fdb6629d22fc3
Reviewed-on: https://review.typo3.org/54749
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
17 months ago[FOLLOWUP][BUGFIX] Fix some PHP Notices thrown rendering page module 45/54745/3
Jan Helke [Fri, 24 Nov 2017 09:50:40 +0000 (10:50 +0100)]
[FOLLOWUP][BUGFIX] Fix some PHP Notices thrown rendering page module

Refer to the correct LanguageService.
The referenced class is not present in TYPO3 version 8.

Related: #82921
Releases: 8.7
Change-Id: Id68086149170d73e3251beba3653344660f4c55c
Reviewed-on: https://review.typo3.org/54745
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
17 months ago[TASK] Show allowed media sources in "Add media by URL" modal 22/54522/2
Gianluigi Martino [Wed, 18 Oct 2017 15:16:52 +0000 (17:16 +0200)]
[TASK] Show allowed media sources in "Add media by URL" modal

In the modal view of "Add media by URL" the possible sources from where
media can be embedded are now shown.

Resolves: #82545
Releases: master, 8.7
Change-Id: I07ffedcf074b6af1e03113375f3d110916e3b034
Reviewed-on: https://review.typo3.org/54522
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
17 months ago[BUGFIX] Fix some PHP Notices thrown when rendering page module 58/54658/3
Tymoteusz Motylewski [Mon, 6 Nov 2017 08:12:26 +0000 (09:12 +0100)]
[BUGFIX] Fix some PHP Notices thrown when rendering page module

Resolves: #82921
Releases: master, 8.7
Change-Id: Id26239e65321aa3653de849932a0be7e626bd653
Reviewed-on: https://review.typo3.org/54658
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
17 months ago[BUGFIX] Fix broken back button in EXT:form 27/54727/2
Frank Naegler [Tue, 21 Nov 2017 13:04:27 +0000 (14:04 +0100)]
[BUGFIX] Fix broken back button in EXT:form

This patch fix a regression, introduced with #82668

Resolves: #83057
Related: #82668
Releases: master, 8.7
Change-Id: I421be116be6696c52733a77a94a61f81c84864f4
Reviewed-on: https://review.typo3.org/54727
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
17 months ago[BUGFIX] Use correct runtime cache identifier for locked records 29/54729/2
Benni Mack [Wed, 22 Nov 2017 22:44:52 +0000 (23:44 +0100)]
[BUGFIX] Use correct runtime cache identifier for locked records

The runtime cache was re-built wrong by using
a custom identifer, thus being called EVERY time a
record is checked. This puts the pagetree DB queries in half.

A simple check (like done previously with $GLOBALS['LOCKED_RECORDS'])
to a simple identifier solves this issue.

Related: #79345
Resolves: #83068
Releases: master, 8.7
Change-Id: Id422fbc81b145db3559c194774334692863b4699
Reviewed-on: https://review.typo3.org/54729
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
17 months ago[BUGFIX] Page tree nodes can be (un)mounted again 23/54723/4
Andreas Fernandez [Mon, 20 Nov 2017 18:55:06 +0000 (19:55 +0100)]
[BUGFIX] Page tree nodes can be (un)mounted again

(Un)mounting nodes in the page tree is now possible again by fixing calls
to the page tree objects.

Resolves: #83051
Releases: master, 8.7
Change-Id: I978308e301b712fa75d677337d790e4895dc997a
Reviewed-on: https://review.typo3.org/54723
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
17 months ago[BUGFIX] backend formfields: Make boolean fields UI working in Edge/IE 20/54720/2
Stefan Neufeind [Tue, 21 Nov 2017 12:05:42 +0000 (13:05 +0100)]
[BUGFIX] backend formfields: Make boolean fields UI working in Edge/IE

Add for/id so clicking the label toggles the checkbox.

Resolves: #83040
Releases: master, 8.7, 7.6
Change-Id: I3dc08706556e1a95ddc8d96cae705ee968c48326
Reviewed-on: https://review.typo3.org/54720
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
18 months ago[BUGFIX] Fix thrown \InvalidArgumentException in access module 18/54718/2
Andreas Fernandez [Tue, 21 Nov 2017 07:10:55 +0000 (08:10 +0100)]
[BUGFIX] Fix thrown \InvalidArgumentException in access module

The returnUrl is not available if the access module is accessed via
context menu of the page tree. The module now checks whether the
returnUrl is available and renders the close button only in such case.

Resolves: #83053
Releases: master, 8.7
Change-Id: I37c5c65c1505b42acf7ac734fbc7a9f53629a6a1
Reviewed-on: https://review.typo3.org/54718
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[BUGFIX] Fix sorting extensions in "Get Extensions" module 07/54707/2
Nicole Cordes [Mon, 20 Nov 2017 14:33:53 +0000 (15:33 +0100)]
[BUGFIX] Fix sorting extensions in "Get Extensions" module

During some Doctrine cleanup the constraint for fetching extension by
extension key got messed up. This patch removes double named parameter
in search constraint.

Resolves: #80555
Releases: master, 8.7
Change-Id: I84636b4a86d8b3946c552031e3cb23ae69cd3f2a
Reviewed-on: https://review.typo3.org/54707
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
18 months ago[BUGFIX] GIFBUILDER files cannot be delivered via web server 12/54712/2
Oliver Hader [Fri, 17 Nov 2017 13:53:10 +0000 (14:53 +0100)]
[BUGFIX] GIFBUILDER files cannot be delivered via web server

GIFBUILDER uses provided file names and text snippets in order to
generate the final name for files to be written to. In case text
snippets start with a dot, this is also reflected into the file
name - preventing some web servers to deliver the file since it's
considered to be internal.

Resolves: #83029
Releases: master, 8.7
Change-Id: Iebed832c1c2429c7400373a6af4d5ae14a9ea18e
Reviewed-on: https://review.typo3.org/54712
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
18 months ago[BUGFIX] Reload page tree if `extendToSubpages` flag changes 11/54711/2
Andreas Fernandez [Mon, 20 Nov 2017 19:28:05 +0000 (20:28 +0100)]
[BUGFIX] Reload page tree if `extendToSubpages` flag changes

Resolves: #83052
Releases: master, 8.7
Change-Id: I9d86c38f8d1749583e154bd52c77b168d20af7dc
Reviewed-on: https://review.typo3.org/54711
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Prevent javascript error in backend 10/54710/2
Markus Günther [Mon, 20 Nov 2017 08:18:27 +0000 (09:18 +0100)]
[BUGFIX] Prevent javascript error in backend

Adding a condition to check if a backend user has permissions on the
search to prevent a JS error while initializing the autocomplete module.

Fixes: #82969
Releases: master, 8.7, 7.6
Change-Id: If2827902443ff7411d9b2c1050213be3e0d78fb6
Reviewed-on: https://review.typo3.org/54710
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[TASK] Example for a RTE Flexform config after migration 00/54700/2
Velletti [Sat, 18 Nov 2017 11:03:23 +0000 (12:03 +0100)]
[TASK] Example for a RTE Flexform config after migration

Releases: master, 8.7
Resolves: #83031
Change-Id: I918ef9ca5ae28f9c605e3c7940cea53b6ed3325a
Reviewed-on: https://review.typo3.org/54700
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[BUGFIX] Fix class name of success button in the install tool 97/54697/2
Markus Günther [Mon, 20 Nov 2017 10:46:09 +0000 (11:46 +0100)]
[BUGFIX] Fix class name of success button in the install tool

Releases: master, 8.7, 7.6
Fixes: #83044
Change-Id: I2c16f160a18f4c0e58b87261b59fbde90aca2f82
Reviewed-on: https://review.typo3.org/54697
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
18 months ago[BUGFIX] ConstantEditor: Make boolean fields UI working in Edge/IE 81/54681/3
Markus Klein [Sun, 19 Nov 2017 01:34:46 +0000 (02:34 +0100)]
[BUGFIX] ConstantEditor: Make boolean fields UI working in Edge/IE

Move the hidden form field out of the label tag to ensure clicking
the label's content (eg. fa icon) really toggles the checkbox.

Resolves: #82998
Releases: master, 8.7, 7.6
Change-Id: Id4293b4109c82a9e6410e113a5b5560ffd1b75d4
Reviewed-on: https://review.typo3.org/54681
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
18 months ago[BUGIFX] Fix JS error in filtering page tree 89/54689/2
Helmut Hummel [Sun, 19 Nov 2017 20:12:18 +0000 (21:12 +0100)]
[BUGIFX] Fix JS error in filtering page tree

While fixing #82877 a mistake was introduced which leads
to a JavaScript error when filtering the page tree.

Problem is that PageTree.select() is called with
the filter tree currently active, but this method
is only functional for the full page tree since quite
a while now.

We now avoid calling this method and document the behavior
properly in method annotations.

Additionally a typo in the variable name is fixed,
which lead to a jquery warning when selecting a page.

Resolves: #83039
Releases: master, 8.7
Change-Id: I6440fb7f6cfd6ead8b5b29dea7c5081dd688a5c3
Reviewed-on: https://review.typo3.org/54689
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
18 months ago[BUGFIX] use included TSconfig files in frontend 80/54680/2
Jigal van Hemert [Tue, 3 Oct 2017 21:47:10 +0000 (23:47 +0200)]
[BUGFIX] use included TSconfig files in frontend

The files included in the field tsconfig_includes are now included
when collecting the page TSconfig in the TypoScriptFrontendController.

Resolves: #82662
Releases: master, 8.7
Change-Id: I226f942045647a3b7c4130b9e5d39b6d982efd1b
Reviewed-on: https://review.typo3.org/54680
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Add correct conversion of RTE pageTS config 65/54665/4
Frans Saris [Tue, 31 Oct 2017 15:32:51 +0000 (16:32 +0100)]
[BUGFIX] Add correct conversion of RTE pageTS config

Add all pageTS.RTE options to config without dots appended to the key
to be able to override the RTE config with pageTS like before.

Resolves: #82865
Releases: master, 8.7
Change-Id: Idb7d7d3b39d44ec37be8f93cc9de8b42b9c8a55c
Reviewed-on: https://review.typo3.org/54665
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
18 months ago[BUGFIX] Fix notices in UserAuthentication 66/54666/4
Tymoteusz Motylewski [Thu, 16 Nov 2017 14:38:23 +0000 (15:38 +0100)]
[BUGFIX] Fix notices in UserAuthentication

Resolves: #83003
Releases: master, 8.7
Change-Id: Iceaa7ab9bd436322229e591677c0aee16cd69f5c
Reviewed-on: https://review.typo3.org/54666
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
18 months ago[BUGFIX] Set l10n_state before synchronizing fields 56/54656/9
Helmut Hummel [Wed, 15 Nov 2017 17:17:49 +0000 (18:17 +0100)]
[BUGFIX] Set l10n_state before synchronizing fields

L10nModeUpdater checks whether fields in translated records are
modified, thus not synchronized with the parent record and the
new l10n_state for this field is set to "custom" in this case
or "parent" if the field is empty.

However this is done after the data is synchronized, which
leads to wrong data being written by the DataMapProcessor.

To fix this, we move setting l10n_state upwards in the code,
so that relations and fields from translated records can be
updated correctly.

Resolves: #83006
Releases: master, 8.7
Change-Id: Ibb06eecb6cf743bd6bba1990ca6f9391c983821f
Reviewed-on: https://review.typo3.org/54656
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
18 months ago[BUGFIX] Fix keepItems and removeItems handling with 0 values 26/54626/2
Helmut Hummel [Sun, 12 Nov 2017 18:27:49 +0000 (19:27 +0100)]
[BUGFIX] Fix keepItems and removeItems handling with 0 values

TSConfig properties keepItems and removeItems are checked
with a weak in_array() test (third argument not set to true),
which leads to the situation, that arbitrary string values
are treated equal to integer 0

This is now fixed by flipping the array and check for the
array index. This works nicely because PHP silently
converts strings which look like integer to integer for the keys.

Tests are added which cover these cases and demonstrate
the failure before the change.

Resolves: #82980
Releases: 8.7, master
Change-Id: I544a221674fa89d302cb6c1bcca506847c6f7f0f
Reviewed-on: https://review.typo3.org/54626
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
18 months ago[FOLLOWUP][TASK] FAL-based database fields moved to integer 69/54669/2
Oliver Hader [Thu, 16 Nov 2017 17:19:56 +0000 (18:19 +0100)]
[FOLLOWUP][TASK] FAL-based database fields moved to integer

Remove duplicated "image" field definition in test scenario.

Related: #69909
Releases: master, 8.7
Change-Id: Ie87e2e62e036fa70fb837f9bd05f2c3ba13019fa
Reviewed-on: https://review.typo3.org/54669
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
18 months ago[BUGFIX] Avoid invalid references in DataMapProcessor 67/54667/2
Oliver Hader [Wed, 15 Nov 2017 15:07:57 +0000 (16:07 +0100)]
[BUGFIX] Avoid invalid references in DataMapProcessor

If DataMapProcessor is called with a non-reference id, e.g.
zero (0), this submission is considered as a reference. Since
there is no database record having UID 0, the synchronization
process fails with the following exeception:

#1486233164: Child record was not processed

To solve this behavior, invalid references (empty/zero) are
not considered anymore to compare references. Besides that,
values for localized records that are configured to be
synchronized are sanitized correctly now.

Resolves: #83009
Releases: master, 8.7
Change-Id: Ie370007521c45dac8bca03978a387b4662952b1d
Reviewed-on: https://review.typo3.org/54667
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
18 months ago[BUGFIX] Use correct parameters for trimExplode 62/54662/2
Wouter Wolters [Tue, 14 Nov 2017 18:05:15 +0000 (19:05 +0100)]
[BUGFIX] Use correct parameters for trimExplode

In QueryBuilder::quoteIdentifiersForSelect the 3rd parameter of
trimExplode is inserted. To prevent notices array_pad is added.

Resolves: #82995
Releases: master,8.7
Change-Id: If35efcf5c8c3fd5b0360ae8795f9b92ae87250ab
Reviewed-on: https://review.typo3.org/54662
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
18 months ago[BUGFIX] Remove "[newlog()] " from DataHandler log info 61/54661/2
Benni Mack [Thu, 16 Nov 2017 11:10:55 +0000 (12:10 +0100)]
[BUGFIX] Remove "[newlog()] " from DataHandler log info

DataHandlers' newlog() function is a shorthand method that
should act as a simple API, which it does, but it also adds
a "[newlog()] " info in front of the error message, which is
completely useless and only clutters DB and the log module.

Resolves: #83012
Releases: master, 8.7
Change-Id: I9e1ea083461de9cdf66fad1a30019e51130a0186
Reviewed-on: https://review.typo3.org/54661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Fix allowLanguageSynchronization on pages_language_overlay 50/54650/3
Oliver Hader [Wed, 15 Nov 2017 12:43:06 +0000 (13:43 +0100)]
[BUGFIX] Fix allowLanguageSynchronization on pages_language_overlay

In case a TCA field uses allowLanguageSynchronization (or
l10n_mode=exclude) for table pages_language_overlay, dependencies
(localizations of the initial record) are processed that point to
the according pages_language_overlay. However pages_language_overlay
records cannot be localized further, they always depend on a single
pages record which is the record of the default language.

In case the backend is used as non-admin user that has a language
restriction ("Limit to languages" in backend groups/users settings),
an error message is shown:

    [newlog()] recordEditAccessInternals() check failed.
    [ERROR: Language was not allowed.]

In TYPO3 v8, all pages_language_overlay records are selected which match
the condition pages_language_overlay.pid = pages_language_overlay.uid
(pid is used as transOrigPointerField). In TYPO3 v9 this changed since
pages_language_overlay has been migrated into pages having a distinct
transOrigPointerField in l10n_parent.

Resolves: #83001
Releases: 8.7
Change-Id: Ie4dfdb44c3d6a9b89819f473816f3e062a685027
Reviewed-on: https://review.typo3.org/54650
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[BUGFIX] FileStorageExtractionTask breaks if file not found 47/54647/2
Thomas Hohn [Tue, 7 Mar 2017 07:19:46 +0000 (08:19 +0100)]
[BUGFIX] FileStorageExtractionTask breaks if file not found

Before the file is processed a extra check is done to be sure the file
exists. If the file doesn't exist it's marked as missing.

Resolves: #80061
Releases: master, 8.7
Change-Id: Ifda396b75d2ace0ce126057a4e118856b15c05e0
Reviewed-on: https://review.typo3.org/54647
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[TASK] Allow all fields in felogin hook "forgotPasswordMail" 43/54643/2
Tom Novotny [Mon, 13 Nov 2017 14:56:51 +0000 (15:56 +0100)]
[TASK] Allow all fields in felogin hook "forgotPasswordMail"

Return all fields to ease the work with hooks.
Intention is not having to query again in hook
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['felogin']['forgotPasswordMail']
to change "Hello [username],..." to "Hello [fist_name] [last_name],..."
in password forgot mail to user.

Resolves: #82996
Releases: master, 8.7
Change-Id: I18e18845e61d36aadd043758f902dc6627ad5f37
Reviewed-on: https://review.typo3.org/54643
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
18 months ago[BUGFIX] Stabilize Language Acceptance tests 39/54639/2
Mathias Schreiber [Mon, 13 Nov 2017 17:57:01 +0000 (18:57 +0100)]
[BUGFIX] Stabilize Language Acceptance tests

Stabilize the acceptance tests to activate and deactivate a language by
checking only for the alerts instead of the enabled/disabled rows.

Additionally make the download a language test fail immediately if the
language is enabled.

Resolves: #82972
Releases: master, 8.7
Change-Id: Ib380b464a24188dbbee37296ddda0f0bb5c44f5e
Reviewed-on: https://review.typo3.org/54639
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Handle variadic arguments in Extbase DebuggerUtility 37/54637/2
Mathias Brodala [Thu, 9 Nov 2017 08:42:04 +0000 (09:42 +0100)]
[BUGFIX] Handle variadic arguments in Extbase DebuggerUtility

Variadic arguments are optional but do not have a default value, thus
properly check this.

Also render the variadic operator ("...") in the output.

Resolves: #82956
Releases: master, 8.7
Change-Id: I10e3528d9cffcdd03ae4711b139898f569ac3775
Reviewed-on: https://review.typo3.org/54637
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
18 months ago[BUGFIX] Add label to page ID field in PageLinkHandler 35/54635/2
Georg Ringer [Tue, 7 Nov 2017 07:08:42 +0000 (08:08 +0100)]
[BUGFIX] Add label to page ID field in PageLinkHandler

Add the missing label and adopt styling of the additional
field which allows to link to a page by providing the page ID.

Resolves: #82888
Releases: master, 8.7
Change-Id: I33ab92f235391add5d3da00a0251ee11eb936933
Reviewed-on: https://review.typo3.org/54635
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
18 months ago[BUGFIX] Add FLUIDTEMPLATE to t3editor code completion 36/54636/2
Andreas Fernandez [Sun, 5 Nov 2017 12:09:17 +0000 (13:09 +0100)]
[BUGFIX] Add FLUIDTEMPLATE to t3editor code completion

With this patch t3editor is now aware of `FLUIDTEMPLATE`, thus supported
by code completion.

Resolves: #82967
Releases: master, 8.7
Change-Id: I82cc9bd22a5a0829ea634eb5cfda4bc8e589c1cc
Reviewed-on: https://review.typo3.org/54614
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-on: https://review.typo3.org/54636

18 months ago[TASK] Upgrade chromedriver to 2.33 30/54630/2
Christian Kuhn [Mon, 13 Nov 2017 16:53:48 +0000 (17:53 +0100)]
[TASK] Upgrade chromedriver to 2.33

Use latest chromedriver to deal with youngest chrome
in acceptance tests.

Change-Id: I7d637022fa9e327e771198625943b11b986b5a04
Resolves: #82987
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54630
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Fix multi-checkbox/radiobox labels for values containing dots 21/54621/3
Oliver Hader [Fri, 8 Sep 2017 10:43:03 +0000 (12:43 +0200)]
[BUGFIX] Fix multi-checkbox/radiobox labels for values containing dots

If checkbox/radiobox values contain dots, these are falsely evaluated as
array lookup paths. Fix this by passing in separate path segments instead
which may contain dots.

Resolves: #82210
Releases: master, 8.7
Change-Id: Ib3d0d1abbeb4fdf84da427f6bea0d597ba9aade6
Reviewed-on: https://review.typo3.org/54621
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Improve performance iterating local files 27/54627/2
Stephan Großberndt [Tue, 7 Nov 2017 08:44:24 +0000 (09:44 +0100)]
[BUGFIX] Improve performance iterating local files

Improve performance iterating local files by avoiding multiple calls to
SplFileInfo.

Releases: master, 8.7
Resolves: #82936
Change-Id: I54b347ad4734d9083b67c7840ff3ab228c07f4bc
Reviewed-on: https://review.typo3.org/54627
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
18 months ago[BUGFIX] Fix path-resolution for template-resource in EXT:felogin 25/54625/2
Daniel Siepmann [Sun, 12 Nov 2017 13:50:40 +0000 (14:50 +0100)]
[BUGFIX] Fix path-resolution for template-resource in EXT:felogin

Do not use frontend inclusion API for private template resource.
Instead resolve to full absolute path for inclusion.

Releases: master, 8.7
Resolves: #82978
Resolves: #82979
Change-Id: Iadd3a8386b967aeb8b5ffdb28baeb73c2a0f2734
Reviewed-on: https://review.typo3.org/54625
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
18 months ago[BUGFIX] Add missing code-block:: php line in feature rst file 13/54613/2
Frans Saris [Fri, 10 Nov 2017 10:54:40 +0000 (11:54 +0100)]
[BUGFIX] Add missing code-block:: php line in feature rst file

Resolves: #82964
Releases: master, 8.7
Change-Id: Iccaae0c2aeefa7c82b3df50956424509acea4233
Reviewed-on: https://review.typo3.org/54613
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
18 months ago[TASK] EXT:form - cache merged YAML settings 99/54599/2
Ralf Zimmermann [Sun, 10 Sep 2017 16:51:35 +0000 (18:51 +0200)]
[TASK] EXT:form - cache merged YAML settings

Cache the merged YAML settings into the assets cache to improve the
performance.

Resolves: #82373
Releases: master, 8.7
Change-Id: I601364d5957f26f1b369b513534936820f72b78e
Reviewed-on: https://review.typo3.org/54599
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[BUGFIX] Show deleted page actions in record history 79/54579/5
Helmut Hummel [Tue, 7 Nov 2017 14:09:08 +0000 (15:09 +0100)]
[BUGFIX] Show deleted page actions in record history

Because users have no access to deleted pages,
the access check always fails, leading to delete page
actions not being shown in the history despite being
properly tracked.

We now check this case and do a more lightweight check
so that we still have the permissions checked,
but can show deleted pages without disclosing unwanted
information.

Resolves: #45056
Releases: 7.6, 8.7, master
Change-Id: Id919a24651c18a351f9723e86610b525a4f4726c
Reviewed-on: https://review.typo3.org/54579
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[TASK] Add Fluid expressions and pre-processors global config 81/54581/3
Claus Due [Sat, 14 Oct 2017 12:19:49 +0000 (14:19 +0200)]
[TASK] Add Fluid expressions and pre-processors global config

This patch moves a previously hardcoded list of Fluid
implementations from the RenderingContext constructor,
to TYPO3_CONF_VARS. Extensions and site administrators
can then add their own implementations to this array and
have them be used in every RenderingContext.

See included RST file for further information on usage.

Change-Id: I6190ceb410e1121ea935a31237cb8bcd0b2f0417
Resolves: #82763
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54581
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
18 months ago[TASK] Update typo3/cms-composer-installers 01/54601/2
Alexander Opitz [Mon, 6 Nov 2017 12:05:21 +0000 (13:05 +0100)]
[TASK] Update typo3/cms-composer-installers

Update the lock file to pull in the latest (1.4.5) release.
This version is marked as PHP 7.2 compatible.
composer command: composer update typo3/cms-composer-installers

Releases: 8.7, master
Resolves: #82898
Change-Id: I6c491ae7e93f656c01a9ef12d88969057b182ba7
Reviewed-on: https://review.typo3.org/54570
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-on: https://review.typo3.org/54601

18 months ago[TASK] Update ext:styleguide to 8.0.13 89/54589/4
Christian Kuhn [Wed, 8 Nov 2017 13:03:51 +0000 (14:03 +0100)]
[TASK] Update ext:styleguide to 8.0.13

This is probably the last version with v8 and v9
in sync before branching off styleguide v8.

Styleguide introduced a new table with 8.0.13, one
of the acceptance tests that uses a rather hard coded
xpath now needs a slightly different selector to cope
with that.

Change-Id: I7ef4f840807963e6a93a90bda394657b8c36c6a0
Resolves: #82951
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54589
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] TcaMigration should not skip on existing overrideChildTca 82/54582/2
Malte Koitka [Wed, 3 May 2017 07:42:16 +0000 (09:42 +0200)]
[BUGFIX] TcaMigration should not skip on existing overrideChildTca

If an overideChildTca key is already added by a TYPO3 core
function like ExtensionManagementUtility::getFileFieldTCAConfig()
the TCA migration should not be skipped. Otherwise the config will
be incomplete and result in missing fields.

The migration is changed that old "foreign_types",
"foreign_selector_fieldTcaOverride" and "foreign_record_defaults"
are merged into new "overrideChildTca", but the new settings
are keps (take precedence) if given.

Resolves: #80719
Resolves: #81045
Releases: master, 8.7
Change-Id: Ic8a0338e0a9882b3b1e7abcd3123fbd7aa2b3505
Reviewed-on: https://review.typo3.org/54582
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Add workspace overlay for translated page title 84/54584/3
Georg Ringer [Tue, 7 Nov 2017 19:40:29 +0000 (20:40 +0100)]
[BUGFIX] Add workspace overlay for translated page title

The title of a translated page must be overlayed with the
workspace version.

Resolves: #65607
Releases: master, 8.7, 7.6
Change-Id: If10260f196776a16a53968b78542827ecbc145fe
Reviewed-on: https://review.typo3.org/54584
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
18 months ago[TASK] Filter duplicate cache commands from CacheQueue 78/54578/2
Benjamin Rannow [Mon, 6 Nov 2017 11:58:49 +0000 (12:58 +0100)]
[TASK] Filter duplicate cache commands from CacheQueue

under the right condition multiple duplicate cache commands are executed

for Example: save a record in Backend can course multiple 'pages'
commands will be executed, if the record has inline records.

flushing '20' times the 'pages' cache is unnecessary.

Resolves: #82930
Releases: master, 8.7
Change-Id: I69e581cb7f12acbd8172b2ca88e89f93ebfbe4b4
Reviewed-on: https://review.typo3.org/54578
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
18 months ago[BUGFIX] Element file browser respects allowedExtensions 73/54573/2
Christian Kuhn [Wed, 1 Nov 2017 13:05:33 +0000 (14:05 +0100)]
[BUGFIX] Element file browser respects allowedExtensions

The type=input, renderType=inputLink field control has an option
"allowedExtensions" to restrict the file element browser to specific
file endings. This option is now correctly considered in file browser.

Change-Id: Ic42bd0de06002f308d7db4098c704ca2574e4018
Resolves: #82861
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54573
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Fix PHP Notices in cached ext_localconf.php 65/54565/3
Tymoteusz Motylewski [Mon, 6 Nov 2017 10:02:08 +0000 (11:02 +0100)]
[BUGFIX] Fix PHP Notices in cached ext_localconf.php

Resolves: #82920
Releases: master, 8.7
Change-Id: I7a533f56ec68a119c19aad6c87de9dfc2e59dc6a
Reviewed-on: https://review.typo3.org/54565
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
18 months ago[TASK] Update typo3/cms-composer-installers 67/54567/3
Helmut Hummel [Mon, 6 Nov 2017 11:03:16 +0000 (12:03 +0100)]
[TASK] Update typo3/cms-composer-installers

Update the lock file to pull in the latest release.
composer command: composer update typo3/cms-composer-installers

Releases: 8.7, master
Resolves: #82898
Change-Id: Idde56a61ce718da2d06cc70fc0e53b834ac44981
Reviewed-on: https://review.typo3.org/54567
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
18 months ago[BUGFIX] Replace forgotten back button to new button API 64/54564/2
Wouter Wolters [Thu, 17 Aug 2017 12:36:55 +0000 (14:36 +0200)]
[BUGFIX] Replace forgotten back button to new button API

With #69884 the new button API was introduced but the back button
in DatabaseRecordList was forgotten. The button is now done with
the new API.

Resolves: #82056
Releases: master,8.7
Change-Id: Icc6480af3a1b4a04e7222dc92cdb58bf9549007d
Reviewed-on: https://review.typo3.org/54564
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
18 months ago[TASK] Refactor implementation of PaginateWidget 66/54566/2
Claus Due [Sun, 2 Jul 2017 00:04:07 +0000 (02:04 +0200)]
[TASK] Refactor implementation of PaginateWidget

Refactors templates to minimise the impact of using the
uncompilable PaginateWidget. By moving the Widget to
a separate partial and the body rendered by the Widget
to another partial the impact is reduced to a minimum,
because the uncompilable template has just two nodes.

Change-Id: I6f1d528ed0c45d776c4952596ac5a8828d04f477
Resolves: #81766
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54566
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
18 months ago[TASK] Add parameter gclid to excludedParameters for cHash generation 63/54563/2
Georg Ringer [Mon, 6 Nov 2017 08:27:02 +0000 (09:27 +0100)]
[TASK] Add parameter gclid to excludedParameters for cHash generation

The parameter 'gclid' is used as click identifier for Google AdWords
and must not be used during the cHash generation.

Resolves: #82927
Releases: master, 8.7
Change-Id: Id279238738550cfbd0b86e6decf94a86230535ee
Reviewed-on: https://review.typo3.org/54562
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-on: https://review.typo3.org/54563

18 months agoRevert "[BUGFIX] Set _localizedUid in OriginColumnName" 52/54552/3
Helmut Hummel [Sat, 4 Nov 2017 00:59:53 +0000 (02:59 +0200)]
Revert "[BUGFIX] Set _localizedUid in OriginColumnName"

This reverts commit 3d03fc2891331593ee348944bfbe3ccc34bb9f5f.

The patch needs to be reverted due to wrong implementation.
The desired goal is not achievable at all with the current code base.

Reverts: #66535
Releases: master, 8.7
Change-Id: Ia26ff7abf96f77ab4b9de7e7de0e442fc2c83bf8
Reviewed-on: https://review.typo3.org/54552
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] FormEngine: returnUrl handling in inline 44/54544/2
Christian Kuhn [Fri, 3 Nov 2017 11:42:09 +0000 (12:42 +0100)]
[BUGFIX] FormEngine: returnUrl handling in inline

If an inline child, opened via ajax request, generates links leaving
the current records and opening a different one, on closing that
record the returnUrl is wrong and points to the url of the inline
ajax request.
The original return url of the main record is lost in the compile chain.
The returnUrl data provider sets $data['returnUrl'] to current url if not
otherwise given.
The patch hands over the original return url to the inline ajax controller
and lets it 'sink down' in the data compile chain to inline children so
the original return url is available when container or elements generate urls.
Additionally some broken 'returnURL' handling in InlineRecordContainer
and jsfunc.inline.js is cleaned up and removed.

Change-Id: Ia47dc8cee068fc9c4d1c5e16c1960b1a58fcb2f5
Resolves: #82525
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54544
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[BUGFIX] Handle returnUrl for access module 26/54526/2
Markus Klein [Mon, 30 Oct 2017 19:56:30 +0000 (20:56 +0100)]
[BUGFIX] Handle returnUrl for access module

With this fix the access module again returns to the correct
page the user expects it to return to.

Resolves: #82883
Releases: master, 8.7, 7.6
Change-Id: I76953aa1547365db6fbbea772d786e1ad9bfc184
Reviewed-on: https://review.typo3.org/54526
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Access module preselects owner/group when changed via AJAX 25/54525/2
Markus Klein [Mon, 30 Oct 2017 20:42:05 +0000 (21:42 +0100)]
[BUGFIX] Access module preselects owner/group when changed via AJAX

Resolves: #79915
Releases: master, 8.7, 7.6
Change-Id: Ie3b573857ff011295be198633a0f6868b1ff55b6
Reviewed-on: https://review.typo3.org/54525
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Set _localizedUid in OriginColumnName 18/54518/2
Alexander Opitz [Tue, 7 Jul 2015 12:28:10 +0000 (14:28 +0200)]
[BUGFIX] Set _localizedUid in OriginColumnName

While saving an object the _localizedUid will be saved into the DB
column which is defined in TranslationOriginalColumnName.

Resolves: #66535
Releases: master,8.7
Change-Id: Ib23b97f90e805bd1107a3aac5b199f010ab231b3
Reviewed-on: https://review.typo3.org/54518
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Catch UnknownLinkHandlerException in InputLinkElement 06/54506/2
Georg Ringer [Tue, 24 Oct 2017 14:37:27 +0000 (16:37 +0200)]
[BUGFIX] Catch UnknownLinkHandlerException in InputLinkElement

Catch another exception to avoid a breaking backend.

Resolves: #82850
Releases: master, 8.7
Change-Id: I349aae21932beb5d45c1cec1b1211d3400d1d969
Reviewed-on: https://review.typo3.org/54506
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[BUGFIX] Fix foreign_table_where GROUP BY handling 05/54505/2
Wolfgang Klinger [Wed, 25 Oct 2017 10:39:31 +0000 (12:39 +0200)]
[BUGFIX] Fix foreign_table_where GROUP BY handling

Unpack the array elements before passing them on

Resolves: #82159
Releases: master, 8.7
Change-Id: I6a094927f595d42fc15bb96a9dbc1d313a7808b0
Reviewed-on: https://review.typo3.org/54505
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[BUGFIX] Flexform Form ID should not contain brackets 98/54498/2
Benjamin Serfhos [Thu, 11 May 2017 12:30:15 +0000 (14:30 +0200)]
[BUGFIX] Flexform Form ID should not contain brackets

Using brackets in flexform elements caused the javascript to be disabled
for the element.
While using a custom form id that can be used as HTML id="" this is
bypassed and fixes all javascript interaction.

Releases: master, 8.7
Resolves: #80908
Change-Id: I91f39b2fed61076b7139603fedc7b268546d64cd
Reviewed-on: https://review.typo3.org/54498
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[BUGFIX] Fix usages of config.additionalHeaders 84/54484/5
Markus Klein [Fri, 27 Oct 2017 13:49:00 +0000 (15:49 +0200)]
[BUGFIX] Fix usages of config.additionalHeaders

Update some internal usages of config.additionalHeaders in tests
and other places to use the correct new syntax.

Resolves: #82871
Releases: master, 8.7
Change-Id: I44868a736751647c3aa62bd5dc29f0bce5588c10
Reviewed-on: https://review.typo3.org/54484
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[BUGFIX] Ensure correct page is selected in page tree 92/54492/2
Helmut Hummel [Sat, 28 Oct 2017 10:35:24 +0000 (12:35 +0200)]
[BUGFIX] Ensure correct page is selected in page tree

There are several actions in the backend that should
trigger a certain page to be selected in the tree.

Among others these are: open documents toolbar, live search,
favorites.

Fix every scenario in which these actions are triggered
(e.g. page tree was already initialized or not), make
sure the desired page will always be selected and
properly store the selection in the various states
so that the selection persists tree refreshes.

In addition we ensure that the content frame will
be called with the correct id, if the module uses
the page tree as navigation component.

Releases: master, 8.7
Resolves: #82877
Change-Id: I1904c02b2246f01202c6607a9b718aebe0e33341
Reviewed-on: https://review.typo3.org/54492
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[TASK] Add .tsconfig files to .editorconfig 99/54499/2
Peter Kraume [Sun, 29 Oct 2017 12:06:28 +0000 (13:06 +0100)]
[TASK] Add .tsconfig files to .editorconfig

Add definition for new TSConfig filetype .tsconfig to .editorconfig
file.

Change-Id: I3fd87abc8a8fe554692f61e548e37d4d02f74fa4
Resolves: #82879
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54499
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
18 months ago[BUGFIX] Only fetch fileReferences from localized table if column exist 87/54487/2
Benjamin Kott [Thu, 26 Oct 2017 15:54:56 +0000 (17:54 +0200)]
[BUGFIX] Only fetch fileReferences from localized table if column exist

Only if a localized table also contains the requested column for file
references it will overlay the previous generated resultset.

Resolves: #82860, #67741
Releases: master, 8.7
Change-Id: I21fd60454123488ea312d6c6241f2622eab3f14c
Reviewed-on: https://review.typo3.org/54487
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
18 months ago[BUGFIX] Avoid race condition in JS Icon API 86/54486/2
Tymoteusz Motylewski [Tue, 24 Oct 2017 19:46:44 +0000 (21:46 +0200)]
[BUGFIX] Avoid race condition in JS Icon API

Now promise is cached instead of promise result, to avoid race condition
when requesting the same icon multiple times.
Now API will do just one ajax call per icon, even if the other API call
is made before the first one finishes.

Resolves: #82851
Releases: master, 8.7
Change-Id: I4110f84d32c7f1856c1664a02d3c9a2ba59168a6
Reviewed-on: https://review.typo3.org/54486
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[BUGFIX] Allow multiline strings in foreign_table_where 78/54478/3
Wolfgang Klinger [Wed, 25 Oct 2017 11:48:15 +0000 (13:48 +0200)]
[BUGFIX] Allow multiline strings in foreign_table_where

Add the ’s’ (PCRE_DOTALL) modifier to regular expressions.

Resolves: #82854
Releases: master, 8.7
Change-Id: Ib5feaba0272e45dce1bc0b4cfedb11f5eb0b10c2
Reviewed-on: https://review.typo3.org/54478
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
18 months ago[BUGFIX] Do not force content_fallback to default page language 64/54464/2
Benni Mack [Tue, 17 Oct 2017 22:06:21 +0000 (00:06 +0200)]
[BUGFIX] Do not force content_fallback to default page language

If a page translation is not available, the TypoScript option
`config.sys_language_mode` has the option
`content_fallback;listofuids` to define to which other language
translations should be fallen back.

However, if NONE of the defined page translations are available,
a fallback to the DEFAULT language is made (because the
foreach just does not apply) which can not be stopped at all.

To define an explicit 404 when a translated page NOR its
fallbacks are available the special keyword "pageNotFound" is added,
which can be added to
`config.sys_language_mode = content_fallback;3,2,pageNotFound`
and if none of 3,2 are available, a page not found message
is thrown.

Resolves: #82794
Releases: master, 8.7
Change-Id: I90af4e9f9685ffc7db8c562207e3df08786c0ca9
Reviewed-on: https://review.typo3.org/54464
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[FOLLOWUP][BUGFIX] Allow longer file-endings in typoscript directory includes 65/54465/2
Benni Mack [Fri, 20 Oct 2017 14:10:52 +0000 (16:10 +0200)]
[FOLLOWUP][BUGFIX] Allow longer file-endings in typoscript directory includes

Adds missing unit tests for this change.

Resolves: #82543
Releases: master, 8.7
Change-Id: Ica7f5c2f99dd991042e3c1166f7806534bf24421
Reviewed-on: https://review.typo3.org/54465
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
18 months ago[BUGFIX] Allow setting translateToMessage to empty 63/54463/2
Susanne Moog [Tue, 17 Oct 2017 23:06:30 +0000 (01:06 +0200)]
[BUGFIX] Allow setting translateToMessage to empty

Unsetting TCEMAIN.translateToMessage was not possible
due to a default fallback to a hardcoded string in
data handler.

This patch sets the default via PageTSConfig and
simplifies the condition / fallback logic.

Change-Id: Ie06410126a83de0e158c43cbfd6ee3d45176c363
Resolves: #82523
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54463
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
18 months ago[TASK] Remove documentation of borderCol 62/54462/2
Susanne Moog [Sun, 22 Oct 2017 18:13:21 +0000 (20:13 +0200)]
[TASK] Remove documentation of borderCol

CSS Styled Content uses only the constant for setting
the border color, not the older configuration property
borderCol, thus the documentation should reflect that.

Change-Id: I712b4a90c3bb7ed6c967e5d5517fb9edb86a3e8d
Resolves: #44972
Releases: 8.7
Reviewed-on: https://review.typo3.org/54462
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] MenuProcessor doesn't accept necessary sub keys 61/54461/2
Thorben Nissen [Thu, 19 Oct 2017 08:28:43 +0000 (10:28 +0200)]
[BUGFIX] MenuProcessor doesn't accept necessary sub keys

Adds subproperty keys for levels, expandAll, includeSpacer and
titleField to $allowedConfigurationKeys.
Adds the subproperty keys also $removeConfigurationKeysForHmenu.

Resolves: #82810
Releases: master, 8.7
Change-Id: Idd2e50b0b7a203ce0a0ecc490199bdf5305bef47
Reviewed-on: https://review.typo3.org/54461
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[TASK] Update Symfony packages to latest releases 59/54459/4
Helmut Hummel [Fri, 20 Oct 2017 12:54:13 +0000 (14:54 +0200)]
[TASK] Update Symfony packages to latest releases

Update all Symfony packages for the distribution
release to latest versions.

Composer users get these versions anyway, so
no issues are expected here.

Composer command: composer update symfony/*

Releases: 8.7
Resolves: #82834
Change-Id: Ib3a528333abcc72124d2540b9edcbb2431893651
Reviewed-on: https://review.typo3.org/54459
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Allow longer file-endings in typoscript directory includes 58/54458/2
Mathias Schreiber [Wed, 18 Oct 2017 23:13:52 +0000 (01:13 +0200)]
[BUGFIX] Allow longer file-endings in typoscript directory includes

Directory includes now allow more liberal substrings to include files
not only based on their extension (*.typoscript) but based on the last
part of their filename (*.setup.typoscript).

Resolves: #82543
Releases: master, 8.7
Change-Id: Ic2111b98a6e3935b542addfd712f4256aa40f888
Reviewed-on: https://review.typo3.org/54443
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
(cherry picked from commit 9ddb3cb19a7ea4b5c3ab2b411c0f936fcf777842)
Reviewed-on: https://review.typo3.org/54458

19 months ago[TASK] Extend WorkspaceServiceTests for fetchPagesWithVersionsInTable 48/54448/2
Susanne Moog [Thu, 19 Oct 2017 12:49:50 +0000 (14:49 +0200)]
[TASK] Extend WorkspaceServiceTests for fetchPagesWithVersionsInTable

Add new tests for fetchPagesWithVersionsInTable and correct comments.

Change-Id: I2fe08656ecddf3f7391e6012bb969dd85c2cfb24
Resolves: #82811
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54448
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[TASK] Show upload files button in filelist options if folder 56/54456/2
Gianluigi Martino [Tue, 10 Oct 2017 06:24:27 +0000 (08:24 +0200)]
[TASK] Show upload files button in filelist options if folder

At the moment there is only a clickmenu entry to upload files
without entering the folder. With this patch the uploads files button is
also listed as button in option list.

Resolves: #82711
Releases: master, 8.7
Change-Id: Ice84d96a8ee5fad8dbcb9dbc728312ebb63df720
Reviewed-on: https://review.typo3.org/54456
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Add renderType to select 54/54454/2
Susanne Moog [Thu, 19 Oct 2017 21:24:20 +0000 (23:24 +0200)]
[BUGFIX] Add renderType to select

Add missing renderType for select box in form
flexform.

Change-Id: I58ade2720cf763cf26fc1d1e74457044ddfa054f
Resolves: #82825
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54454
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Update friendsofphp/php-cs-fixer to latest version 53/54453/2
Wouter Wolters [Wed, 18 Oct 2017 21:13:46 +0000 (23:13 +0200)]
[TASK] Update friendsofphp/php-cs-fixer to latest version

Resolves: #82806
Releases: master,8.7
Change-Id: I071c114db90b292936f5c3fd76c7ac74fd52bd60
Reviewed-on: https://review.typo3.org/54442
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-on: https://review.typo3.org/54453

19 months ago[BUGFIX] EXT:indexed_search: Dont add stat record for empty search 31/54431/2
Daniel Goerz [Tue, 4 Jul 2017 12:07:24 +0000 (14:07 +0200)]
[BUGFIX] EXT:indexed_search: Dont add stat record for empty search

Resolves: #81786
Releases: master, 8.7
Change-Id: I1bc5e93fdfb3a1068a09ae37c47e51b1811d58b5
Reviewed-on: https://review.typo3.org/54431
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Remove style attribute in LiveSearch 40/54440/2
Andreas Fernandez [Wed, 18 Oct 2017 19:49:36 +0000 (21:49 +0200)]
[BUGFIX] Remove style attribute in LiveSearch

Currently, `beforeRender` removes some inline CSS so adjust the layout
of the suggest list. If the first search has no result, the layout is
broken because `beforeRender` is not called in case there are no results.

This patch removes the style attribute as early as possible.

Resolves: #82757
Releases: master, 8.7
Change-Id: I844b81aca43bd469dfdbb46516366f4786d0935f
Reviewed-on: https://review.typo3.org/54440
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[BUGFIX] Make ReferenceIndex caching optional 24/54424/3
Benni Mack [Mon, 3 Jul 2017 13:21:03 +0000 (15:21 +0200)]
[BUGFIX] Make ReferenceIndex caching optional

The runtime caches used in the ReferenceIndex class
added in TYPO3 8.7.2 should not be added by default
but included on a per-runtime basis when extensions
would use the ReferenceIndex. Otherwise this issue
might lead to side-effects.

For master/9.0 the caches are enabled by default.

Relates: #78634
Resolves: #81771
Releases: master, 8.7
Change-Id: If7ca173d93c05658bce5f57c38842555a439d2ea
Reviewed-on: https://review.typo3.org/54424
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] CKEditor: Make link editable 34/54434/2
Christoph Lehmann [Tue, 17 Oct 2017 14:37:06 +0000 (16:37 +0200)]
[BUGFIX] CKEditor: Make link editable

Fixes the TypeError

htmlspecialchars() expects parameter 1 to be string, null given

Resolves: #82787
Releases: master,8.7
Change-Id: I38a689022ed45c34a8ae78c046abe51803eb0f4c
Reviewed-on: https://review.typo3.org/54434
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christoph Lehmann <christoph.lehmann@networkteam.com>
Tested-by: Christoph Lehmann <christoph.lehmann@networkteam.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
19 months ago[BUGFIX] Update tstamp on inline relation addition 28/54428/2
Susanne Moog [Tue, 17 Oct 2017 21:05:45 +0000 (23:05 +0200)]
[BUGFIX] Update tstamp on inline relation addition

If in a record with an inline relation a new relation
is added and nothing else is changed the timestamp
was not updated.

The logic to update the timestamp has now been added
to the remapStack processing.

Change-Id: I2eae7d1fb54b21dddc6e3609b1585ba484980b06
Resolves: #82576
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54428
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Localization State does not properly sanitize and enrich 27/54427/2
Oliver Hader [Tue, 17 Oct 2017 20:59:31 +0000 (22:59 +0200)]
[BUGFIX] Localization State does not properly sanitize and enrich

The Localization State object has an incomplete assignment in the
constructor - sanitize processing is overridden by enrich processing,
however both should be combined instead.

The current side-effects were, that
* localization state could contain fields that were not defined in TCA
  having support for the `allowLanguageSynchronization` setting
* state values different than `custom`, `source` or `parent` have not
  been overridden by the default `parent` value

Resolves: #82793
Releases: 8.7, master
Change-Id: I25e794736df216b17a5b8de3bc5203bd18ee9694
Reviewed-on: https://review.typo3.org/54427
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] EXT:form - "label" is not set for the FormDefinition class 25/54425/2
Ralf Zimmermann [Thu, 28 Sep 2017 08:09:57 +0000 (10:09 +0200)]
[BUGFIX] EXT:form - "label" is not set for the FormDefinition class

Set the "label" property for the root form element
TYPO3\CMS\Form\Domain\Model\FormDefinition

Resolves: #82573
Releases: master,8.7
Change-Id: I57c45765e4af91da6094f8f7a469a1df2f6da1f5
Reviewed-on: https://review.typo3.org/54425
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Add parseFunc handling to pre tags 21/54421/2
Susanne Moog [Tue, 17 Oct 2017 18:22:54 +0000 (20:22 +0200)]
[BUGFIX] Add parseFunc handling to pre tags

Pre tags are currently not passed through parseFunc
resulting in non-parsed t3:// links in the frontend.

As <pre> tags allow links (and other tags) inside, we
should parse them, too.

Change-Id: I5647f02b0d93b05ecaed8297c794b91255ea6d54
Resolves: #82789
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54421
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Refresh iconElement after its content has been replaced 20/54420/2
Nikita Hovratov [Sun, 18 Jun 2017 22:46:57 +0000 (23:46 +0100)]
[BUGFIX] Refresh iconElement after its content has been replaced

The variable iconElement refers now correctly to the original jQuery
object and is really reverted to the old class as the comment implies.

Resolves: #82624
Releases: master, 8.7
Change-Id: I13615bbee6d5148fe940bac49b72c2766c0a1de7
Reviewed-on: https://review.typo3.org/54420
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] CSC Header CE does not respect lib.parseTarget configuration 71/52571/5
Harry Glatz [Sat, 3 Sep 2016 09:59:38 +0000 (11:59 +0200)]
[BUGFIX] CSC Header CE does not respect lib.parseTarget configuration

The TypoScript of the CSC header element does not respect
the global lib.parseTarget configuration

Resolves: #36216
Releases: 8.7, 7.6
Change-Id: I08ea6c59829a4a63b4aca6bf90b89223921b3fdf
Reviewed-on: https://review.typo3.org/52571
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Harry Glatz <harry.glatz@typo3.org>
Tested-by: Harry Glatz <harry.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Show the "Today" button in DateTimePicker 05/54405/2
Gianluigi Martino [Sun, 15 Oct 2017 12:40:44 +0000 (14:40 +0200)]
[TASK] Show the "Today" button in DateTimePicker

This patch enable the "Today" button on the bottom of the DateTimePicker.
Clicking the "Today" button will set the date and time to now.

Resolves: #82723
Releases: master, 8.7
Change-Id: I262e0206754b2a9e785a6f1184712ba8cc26ad12
Reviewed-on: https://review.typo3.org/54405
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[FOLLOWUP][BUGFIX] IRRE: Check if TCA['ctrl']['languageField'] is set 75/54175/4
Nicole Cordes [Tue, 19 Sep 2017 13:15:47 +0000 (15:15 +0200)]
[FOLLOWUP][BUGFIX] IRRE: Check if TCA['ctrl']['languageField'] is set

This patch adds missing functional tests for
\TYPO3\CMS\Backend\Controller\FormInlineAjaxController::createAction

Related: #82330
Releases: master, 8.7, 7.6
Change-Id: I61c8c07dd0d2c6a92bb445d7f2b6baee23251f5d
Reviewed-on: https://review.typo3.org/54175
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Context menu is not completely visible in filelist with scrollbar 92/54392/2
Gianluigi Martino [Fri, 13 Oct 2017 06:31:56 +0000 (08:31 +0200)]
[BUGFIX] Context menu is not completely visible in filelist with scrollbar

If the foldertree in filelist is to long, the rightclick context menu on
the bottom of the window is not completly visible. With this patch the
position of the menu is calculated based on the windows width and height
and so completly visible.

Resolves: #82732
Releases: master, 8.7
Change-Id: Ied9204371491059efda61143e9ca9c2f3c8a9b9d
Reviewed-on: https://review.typo3.org/54392
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Resolve label in title attribute of ClearCacheToolbarItemSingle 91/54391/2
Loek Hilgersom [Thu, 12 Oct 2017 16:38:35 +0000 (18:38 +0200)]
[BUGFIX] Resolve label in title attribute of ClearCacheToolbarItemSingle

Resolves: #82749
Releases: master, 8.7
Change-Id: I1de1157ca8e28da3a9fd3ffb3783bb73b1f8e845
Reviewed-on: https://review.typo3.org/54391
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Configuration->"Use regular expression" 78/54378/2
Christian Kuhn [Thu, 12 Oct 2017 12:43:20 +0000 (14:43 +0200)]
[BUGFIX] Configuration->"Use regular expression"

Setting / unsetting the checkbox "Use regular expression"
fails with JavaScript error "jumpToUrl is not defined".
Add that to the document body.

Change-Id: I0a5928e008972493d070a35d1219a0acca579ce8
Resolves: #82746
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54378
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Properly detect record link dialog tab 74/54374/2
Stanislas Rolland [Wed, 11 Oct 2017 19:00:03 +0000 (15:00 -0400)]
[BUGFIX] Properly detect record link dialog tab

RecordLinkHandler->canHandleLink should check record identifier,
otherwise the element browser may open the wrong tab when multiple
record identifiers are configured.

Resolves: #82737
Releases: master, 8.7
Change-Id: Ie12c6d7484bdb51577dfe02a653e80fe1d7b63ea
Reviewed-on: https://review.typo3.org/54374
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[BUGFIX] Use correct path for test images in install tool 73/54373/3
Markus Klein [Thu, 12 Oct 2017 08:32:34 +0000 (10:32 +0200)]
[BUGFIX] Use correct path for test images in install tool

This resolves a regression to #81951, where the path adjustment
has been forgotten.

Resolves: #82743
Releases: 8.7
Change-Id: Ibd0260b0450e2b8d0078a004acf4ee835d6a34cc
Reviewed-on: https://review.typo3.org/54373
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
19 months ago[BUGFIX] Correct fixture for metadata in impexp functional tests 61/54361/3
Tymoteusz Motylewski [Tue, 10 Oct 2017 14:23:28 +0000 (16:23 +0200)]
[BUGFIX] Correct fixture for metadata in impexp functional tests

Resolves: #82726
Releases: master, 8.7
Change-Id: I779dbf4cdecf931cae4f2734f561aa1c9eab4efb
Reviewed-on: https://review.typo3.org/54361
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>