Packages/TYPO3.CMS.git
4 years ago[BUGFIX] Speed up BackendUtility->explodeSoftRefParserList 87/35187/3
Stephan Großberndt [Tue, 9 Dec 2014 12:00:31 +0000 (13:00 +0100)]
[BUGFIX] Speed up BackendUtility->explodeSoftRefParserList

Due to improper checking for an empty array in
BackendUtility->explodeSoftRefParserList multiple trimExplode-calls per
record are executed. Fixing this check leads to an early return and
speeds up bulk inserting.

Resolves: #63674
Releases: master, 6.2
Change-Id: Id8969c33d8ebb109018159ada6a277ab5bfdd13c
Reviewed-on: http://review.typo3.org/35187
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[!!!][TASK] Remove global variable WEBMOUNTS 97/35697/3
Benjamin Mack [Thu, 1 Jan 2015 11:11:42 +0000 (12:11 +0100)]
[!!!][TASK] Remove global variable WEBMOUNTS

The WEBMOUNTS variable is holding
the BackendUsers' DB mounts which are
always accessible via $BE_USER->returnWebmounts()

The bootstrap for the Backend is now
a tiny bit faster. The few left-over places
are changed.

The global variable FILEMOUNTS was
already removed with the introduction
of FAL.

Resolves: #64070
Releases: master
Change-Id: I1a681afacd7e0c0092a87ebff07008eb069872f2
Reviewed-on: http://review.typo3.org/35697
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Extension Manager: Port to RequireJS 85/35485/4
Andreas Fernandez [Mon, 15 Dec 2014 16:40:56 +0000 (17:40 +0100)]
[TASK] Extension Manager: Port to RequireJS

Port the JavaScript of the Extension Manager to RequireJS. This
patch is just the base for further improvements.

Releases: master
Resolves: #63910
Change-Id: Ia9322c9b7b518535c95916467643078f17d9a14f
Reviewed-on: http://review.typo3.org/35485
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Clean up BackendController 20/34020/8
Benjamin Mack [Sat, 3 Jan 2015 15:32:30 +0000 (16:32 +0100)]
[TASK] Clean up BackendController

All HTML of BackendController was moved to
Fluid Standalone, and is now more flexible
with the TemplatePath variable.

Some variables are cleaned up now.

Resolves: #62881
Releases: master
Change-Id: Id98677e265aab6a664b764cb2c48607c734ba019
Reviewed-on: http://review.typo3.org/34020
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FEATURE] Allow multiple HTTP headers of the same type in TS 14/27814/6
Marco Huber [Mon, 24 Feb 2014 13:01:58 +0000 (14:01 +0100)]
[FEATURE] Allow multiple HTTP headers of the same type in TS

Allows multiple HTTP headers of the same type in
config.additionalHeaders by extending the configuration
possibilities:

mypage.config.additionalHeaders {
10 {
#the header string
header = WWW-Authenticate: Negotiate

#replace previous headers with the same name
                #optional, default is 1 (yes)
                replace = 0

                #force the HTTP response code
#optional
                httpResponseCode = 401
}
}

See also: http://php.net/header

Resolves: #56236
Releases: master
Change-Id: I25b4c755459b3ad718624426a32f217055c189e5
Reviewed-on: http://review.typo3.org/27814
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Non modules can't check module access 58/35758/2
Wouter Wolters [Sat, 3 Jan 2015 16:35:51 +0000 (17:35 +0100)]
[BUGFIX] Non modules can't check module access

Resolves: #64098
Releases: master, 6.2
Change-Id: Ic71b026e18160fb92c8e215ecf2cfb6c86703661
Reviewed-on: http://review.typo3.org/35758
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Fix folder selection in ElementBrowser 47/35147/3
Markus Klein [Mon, 8 Dec 2014 01:25:13 +0000 (02:25 +0100)]
[BUGFIX] Fix folder selection in ElementBrowser

Resolves: #63651
Releases: master, 6.2
Change-Id: Ica4b9dab922be15bffd67f1dbd90ea8e4522838d
Reviewed-on: http://review.typo3.org/35147
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FEATURE] Introduce unified Storage API for JS 27/35627/5
Benjamin Mack [Wed, 24 Dec 2014 01:25:04 +0000 (02:25 +0100)]
[FEATURE] Introduce unified Storage API for JS

The core lacks a unified API to load and update
the Backend users UC, and to address the browsers'
localStorage.

The new TYPO3.Storage object allows to fetch
and manipulate data in a unified way.

Followup patches will replace previous hacks
and ExtJS calls with the new API.

Releases: master
Resolves: #64031
Change-Id: I53907f0beb93f300f8d8ca7a17721cab1376b9c7
Reviewed-on: http://review.typo3.org/35627
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Scheduler: Fix task group issues 58/35558/5
Mathias Schreiber [Sat, 3 Jan 2015 13:49:34 +0000 (14:49 +0100)]
[BUGFIX] Scheduler: Fix task group issues

Do not list deleted task groups as option when creating new tasks.
Display tasks assigned to a deleted group in the un-grouped block.

Resolves: #63973
Releases: master, 6.2
Change-Id: I0f9b4a01f03f49881883d9dafad2354bb7526fb2
Reviewed-on: http://review.typo3.org/35558
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Refactor copy-pasted getJavaScriptLabelsFromLocallang 94/28694/3
Pascal Dürsteler [Mon, 24 Mar 2014 11:06:03 +0000 (12:06 +0100)]
[TASK] Refactor copy-pasted getJavaScriptLabelsFromLocallang

This refactors the copy-pasted method from ext:recycler into
LanguageService.php.

Resolves: #57225
Releases: master
Change-Id: I0312068b70583feeff9d4cbf5f96fbac75baa793
Reviewed-on: http://review.typo3.org/28694
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[BUGFIX] Autolink urls starting https:// as well 17/35117/3
Georg Ringer [Sat, 6 Dec 2014 20:34:50 +0000 (21:34 +0100)]
[BUGFIX] Autolink urls starting https:// as well

Currently only non ssl urls are automatically identified
and transformed to a link. Now also links starting with
https:// are identified.

Resolves: #63616
Releases: master, 6.2
Change-Id: I3a35c73263e2248c571ba835212ac59b3d7ec68b
Reviewed-on: http://review.typo3.org/35117
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Revamp ext:linkvalidator 62/33262/17
Wouter Wolters [Sat, 11 Oct 2014 11:19:54 +0000 (13:19 +0200)]
[TASK] Revamp ext:linkvalidator

* Migrate JavaScript to jQuery AMD module
* Cleanup the code
* Migrate CSS to less
* Use correct table styles
* Use dyntabmenu instead of ExtJs
* Replace $GLOBALS with corresponding getter

Resolves: #62164
Releases: master
Change-Id: I5021366f4f78ec129f1e769825a6beeed3525454
Reviewed-on: http://review.typo3.org/33262
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] HMENU: Extract menu item generation into separate methods 00/28900/10
Stefan Neufeind [Thu, 1 Jan 2015 20:42:08 +0000 (21:42 +0100)]
[TASK] HMENU: Extract menu item generation into separate methods

In order to ensure valid options and consistency, the 500+ lines
of code for generating special=XY menus in HMENU
can be safely moved into separate methods within the same
class. Additionally, when subclassing HMENU, the functions
can be overridden easier.

The makeMenu() function gets smaller and the new methods are
a good target for creating unit tests.

Releases: master
Resolves: #57366
Change-Id: I1c5be14e4249fe60f7c14f808b762b2af3155680
Reviewed-on: http://review.typo3.org/28900
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FEATURE] displayCond should allow userFunc as condition 28/34728/6
Sebastian Fischer [Fri, 28 Nov 2014 08:56:19 +0000 (09:56 +0100)]
[FEATURE] displayCond should allow userFunc as condition

This patch enables the usage of a displayCond defined as
'USER:\Example\Namespace\UserClass->functionName:any:other:parameter'

Releases: master
Resolves: #62944
Change-Id: I9e915e9098494715a3fb5961836af6b16eb12b27
Reviewed-on: http://review.typo3.org/34728
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Page View Button misses tooltip in page language module 53/35753/3
Anja Leichsenring [Sat, 3 Jan 2015 12:26:26 +0000 (13:26 +0100)]
[BUGFIX] Page View Button misses tooltip in page language module

Add a title attribute to the view page button in page module,
when language mode is active.

Change-Id: I3c991173b2a46e33dcdff5ad6827b4ef6d4dc5fe
Resolves: #64095
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35753
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][TASK] Migrate non-ExtJS trees to jQuery 39/34239/7
Benjamin Mack [Sun, 16 Nov 2014 09:04:02 +0000 (10:04 +0100)]
[!!!][TASK] Migrate non-ExtJS trees to jQuery

Existing tree components that are
not using ExtJS are mainly within
the ElementBrowser and the FolderTree,
which is the navigation component inside filelist.

However, the "old" version of the original pagetree
still exists, and has support for IE5.5 as well, and
an option to filter for items within the pagetree (please
note: this feature was never added to the foldertree).

The old pagetree navigation component itself is now
deprecated (it can still be used in own modules). The
filter functionality is completely removed in the
old pagetree.

The necessary JavaScript code for drag+drop and
expand/collapse of the tree was migrated to RequireJS,
which avoids some more loading of scriptaculous
and prototype.

Releases: master
Resolves: #64059
Change-Id: If8de627d0284d77accdfe55cffe12c591f32df7a
Reviewed-on: http://review.typo3.org/34239
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Remove language "default" from Alternative Page Language and 95/35695/7
Benjamin Mack [Sat, 3 Jan 2015 11:34:53 +0000 (12:34 +0100)]
[TASK] Remove language "default" from Alternative Page Language and
hide record type when not necessary

The pages_language_overlay table has a sys_language_uid
field, but (like all other records) it is filled with "default".
However, due to the concept of two tables for translations
with pages and pages_language_overlay, the default
value does not make any sense and rather causes trouble
within the core when set to "0" / "default".

The patch removes the static entry from the language
dropdown of a pages_language_overlay record.

See also further discussion on forge.

Releases: master
Resolves: #34823
Change-Id: I258a8e2e31411779cc46005d56bc54e2a7a78b7d
Reviewed-on: http://review.typo3.org/35695
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Remove ExtJs loading from ext:scheduler 54/35754/2
Wouter Wolters [Sat, 3 Jan 2015 12:39:02 +0000 (13:39 +0100)]
[TASK] Remove ExtJs loading from ext:scheduler

Resolves: #64096
Releases: master
Change-Id: I0b567eebcdab759a380f99e4aba8d52de810bfc9
Reviewed-on: http://review.typo3.org/35754
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Cleanup EXT:scheduler SchedulerModuleController 52/35752/2
Mathias Schreiber [Sat, 3 Jan 2015 12:16:36 +0000 (13:16 +0100)]
[TASK] Cleanup EXT:scheduler SchedulerModuleController

Greenify SchedulerModuleController

Releases: master
Resolves: #64094
Change-Id: Ie9293d4ecebf0e4d4df4aaaef2fb0af500aa09ab
Reviewed-on: http://review.typo3.org/35752
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[CLEANUP] Use $this-> instead of parent:: in TS Conditions 48/35748/2
Benjamin Mack [Fri, 2 Jan 2015 21:26:12 +0000 (22:26 +0100)]
[CLEANUP] Use $this-> instead of parent:: in TS Conditions

The code for Backend and Frontend TS conditions
uses static calls to parent:: instead of using
$this->, which is common throughout the rest
of the TYPO3 Core.

Resolves: #64090
Releases: master
Change-Id: I672e4828490732a16571de7dbbb6b3da64855222
Reviewed-on: http://review.typo3.org/35748
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Decouple security report from install tool 11/35611/5
Frederic Gaus [Sat, 20 Dec 2014 19:42:57 +0000 (20:42 +0100)]
[TASK] Decouple security report from install tool

Decouple \TYPO3\CMS\Reports\Report\SecurityStatus from install tools. In
this status report several checks are made which are closely coupled to
the install tool. This patch decouples them by introducing a security
status check in the install tool extension

Change-Id: I50e26107a8fc249a3fbe7592a67751c5513388e6
Resolves: #64002
Releases: master
Reviewed-on: http://review.typo3.org/35611
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Fix padding of FormEngine without tabs 74/35674/2
Benjamin Mack [Tue, 30 Dec 2014 14:38:45 +0000 (15:38 +0100)]
[BUGFIX] Fix padding of FormEngine without tabs

There are two inconsistencies within FormEngine:

1) Styling of records without tabs (e.g. filemounts)
2) Invalid HTML structure within pre-loaded IRRE elements

The patch fixes both parts as they are connected to each
other.

Resolves: #64061
Releases: master
Change-Id: I5f7d93af9ec1269ef4b6d6b9098f41a0a68c6b47
Reviewed-on: http://review.typo3.org/35674
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Editing a record in Element Browser throws JS error 77/35677/2
Benjamin Mack [Tue, 30 Dec 2014 18:22:03 +0000 (19:22 +0100)]
[BUGFIX] Editing a record in Element Browser throws JS error

When opening the element browser (e.g. via the field "reference
records" as CType in tt_content), it is actually possible to edit
all title fields / headlines of a record. This is done after
sorting a field. However, some JS variables are not set in the
element browser.

Resolves: #19830
Releases: master
Change-Id: Ic2058a825dea1b2ef18c049bfff92eb94de630df
Reviewed-on: http://review.typo3.org/35677
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] DatabaseRecordList::createReferenceHtml uses too much memory 44/35744/3
Mathias Schreiber [Fri, 2 Jan 2015 18:32:50 +0000 (19:32 +0100)]
[TASK] DatabaseRecordList::createReferenceHtml uses too much memory

In order to reduce the amount of processing time spent while getting
the reference count the amount of records is being calculated by the
database now.

Resolves: #63394
Releases: master
Change-Id: Ib0a04678809d4ce16f0366c900c860da4450af64
Reviewed-on: http://review.typo3.org/35744
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
4 years ago[FEATURE] Custom TypoScript-conditions also in backend 68/35068/7
Stefan Neufeind [Mon, 8 Dec 2014 23:44:17 +0000 (00:44 +0100)]
[FEATURE] Custom TypoScript-conditions also in backend

Make the feature for custom TypoScript-conditions available
in both frontend (was already there) and backend (new) by
moving it to the AbstractConditionMatcher.

Resolves: #63600
Related: #61489
Releases: master
Change-Id: I653f8cca53b23f6c16d81ed5ea3f2bc853e98a2e
Reviewed-on: http://review.typo3.org/35068
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[CLEANUP] Simplify stdWrap handling in Menu cObj 40/35740/3
Philipp Gampe [Fri, 2 Jan 2015 16:19:00 +0000 (17:19 +0100)]
[CLEANUP] Simplify stdWrap handling in Menu cObj

Follow-up to #46624
Restructure the code to make it more readable.

Resolves: #64088
Releases: master
Change-Id: Ib5bb2bd853fe8bfd0483fbc3df00fa5b9225325a
Reviewed-on: http://review.typo3.org/35740
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[!!!][BUGFIX] Respect selected target for shortcut mode 'Parent page' 42/28542/6
Caspar Stuebs [Wed, 19 Mar 2014 18:44:25 +0000 (19:44 +0100)]
[!!!][BUGFIX] Respect selected target for shortcut mode 'Parent page'

The selected page is now respected when selecting the parent page
to use. An upgrade wizard ensures that existing shortcuts will not
break by removing the currently selected page.

The 6.2 version of this patch will only adjust the label to not
mention the "selected page" part, so the label matches
the current behaviour.

Change-Id: I51bc9239871d93728e84a4fe2e3b8bc9bb4a7404
Resolves: #57089
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/28542
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Ignore --linebreak-- fields in removeDuplicatesForInsertion 19/34019/6
Christian Ludwig [Wed, 12 Nov 2014 15:12:17 +0000 (16:12 +0100)]
[BUGFIX] Ignore --linebreak-- fields in removeDuplicatesForInsertion

ExtensionManagementUtility::removeDuplicatesForInsertion() ignores
--linebreak-- fields when looking for duplicates.
In addition the method uses less regular expressions to
make it more performant and easier to understand.

Resolves: #57824
Releases: master, 6.2
Change-Id: Ia064abe81501ec4649dc8fb1fe613d5e5497ff9c
Reviewed-on: http://review.typo3.org/34019
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix error in filelist after deleting file with broken refs 62/33562/9
Cornel Boppart [Sun, 26 Oct 2014 19:07:53 +0000 (20:07 +0100)]
[BUGFIX] Fix error in filelist after deleting file with broken refs

Always delete a file with corrupt relations.
Additionally issue a flash message informing about the broken references.

Resolves: #62480
Releases: master, 6.2
Change-Id: I3bfbcc1ec0dae4ebfe8356905ac2f0548bfaa12b
Reviewed-on: http://review.typo3.org/33562
Reviewed-by: Cornel Boppart <cboppart@snowflake.ch>
Tested-by: Cornel Boppart <cboppart@snowflake.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix typo in Breaking-53658-RemoveAlternateBgColorsOption 42/35742/2
Benjamin Mack [Fri, 2 Jan 2015 17:41:26 +0000 (18:41 +0100)]
[BUGFIX] Fix typo in Breaking-53658-RemoveAlternateBgColorsOption

The headline in that file says it would document
issue #53568 [sic], which is a typo. In fact it is #53658.

Resolves: #63528
Releases: master
Change-Id: Id11c8b48d11281f63cb9515634cf246103173c71
Reviewed-on: http://review.typo3.org/35742
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Missing clickmenu links 55/27855/6
Johannes Feustel [Tue, 25 Feb 2014 16:00:34 +0000 (17:00 +0100)]
[TASK] Missing clickmenu links

For consistency and to improve usability all record icons are linked with
context menu (clickmenu) actions.

Change-Id: I154d1ada104ffed5a8a05c40ec168d1e45ac3bc0
Resolves: #56281
Releases: master
Reviewed-on: http://review.typo3.org/27855
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 years ago[TASK] Extbase: Clean up invalid comments 38/35738/2
Benjamin Mack [Fri, 2 Jan 2015 15:31:27 +0000 (16:31 +0100)]
[TASK] Extbase: Clean up invalid comments

Some words are missing in QuerySettingsInterface
method header comments.

Also, all places within Extbase referring to FLOW3
are changed to TYPO3.Flow.

Resolves: #61570
Releases: master
Change-Id: Iafbc8215ae647fca532de2fe8526f4215a157a03
Reviewed-on: http://review.typo3.org/35738
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Web->Function: empty frame if all related ext removed 30/35730/8
Mathias Schreiber [Fri, 2 Jan 2015 13:59:29 +0000 (14:59 +0100)]
[BUGFIX] Web->Function: empty frame if all related ext removed

Shows a meaningful error message if a module relies on submodules that
have not been registered yet.

Resolves: #21975
Releases: master, 6.2
Change-Id: Ibaf0ccae2a4d8f2aae066323d58dbacf321d107a
Reviewed-on: http://review.typo3.org/35730
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] csc-uploads delivers broken CSS 24/35724/2
Benjamin Mack [Fri, 2 Jan 2015 11:04:54 +0000 (12:04 +0100)]
[BUGFIX] csc-uploads delivers broken CSS

In CSS Styled Content the CSS rule

ul.csc-uploads img { float: left; padding-right: 1em; vertical-align: top; }

causes images to be squeezed when they have the
width-attr (default=150, through
tt_content.uploads.20.renderObj.10.file.width) set
because the 1em is calculated inside the given
dimensions. The padding should be changed to
margin, otherwise all images are squeezed
horizontally regardless of the actual
dimension settings.

Releases: master, 6.2
Resolves: #59124
Change-Id: I171e4f3b048f0a0dc05476890d7af6f88c864874
Reviewed-on: http://review.typo3.org/35724
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] sys_file uid should be visible in filelist 31/35731/2
Benjamin Mack [Fri, 2 Jan 2015 11:38:28 +0000 (12:38 +0100)]
[BUGFIX] sys_file uid should be visible in filelist

There are several cases where editors manually
link to files (<LINK file:123>Download PDF</LINK>),
f.e. in bulletlists, so they need a easy way to
find the uid of a specific file. A good place would
be the mouseover-text of files in the filelist –
like as the pages or tt_content elements have their
uid shown in the element's icon mouseover text.

Resolves: #59866
Releases: master, 6.2
Change-Id: Iec3e5043d01bfb3fac60d738ef7749fc0126c6b2
Reviewed-on: http://review.typo3.org/35731
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Make be_sessions.ses_data text field for HHVM 32/35732/2
Benjamin Mack [Fri, 2 Jan 2015 11:43:44 +0000 (12:43 +0100)]
[TASK] Make be_sessions.ses_data text field for HHVM

The ses_date field of the DB table be_sessions can
hold up to 4GB of data, which is never used.

It also does not work on HHVM (see forge ticket).

Changing it to type text is sufficient.

Resolves: #59771
Releases: master
Change-Id: I4693ba26e0497cd8ca02fc720a5714684e133406
Reviewed-on: http://review.typo3.org/35732
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Change fe_users DB field size to 255 chars 18/35718/3
Benjamin Mack [Fri, 2 Jan 2015 10:19:21 +0000 (11:19 +0100)]
[BUGFIX] Change fe_users DB field size to 255 chars

When having email addresses as usernames the field
fe_users.username gets too small. Resizing to 255
characters solves a lot of problems. Same goes
for the email field.

Releases: master, 6.2
Resolves: #55484
Change-Id: I03e4fe1228a6b22d24ad222a9fab578059917847
Reviewed-on: http://review.typo3.org/35718
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] wizard_crpages cleanup 09/35209/9
Wouter Wolters [Tue, 9 Dec 2014 23:15:27 +0000 (00:15 +0100)]
[TASK] wizard_crpages cleanup

Make the code simpler and more readable.

Resolves: #64062
Releases: master
Change-Id: Ie46f49e8cc5b6982391004bfcdfd712bfbab1a03
Reviewed-on: http://review.typo3.org/35209
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[!!!][TASK] Drop include_once array functionality for modules 29/34829/4
Wouter Wolters [Sun, 30 Nov 2014 19:52:21 +0000 (20:52 +0100)]
[!!!][TASK] Drop include_once array functionality for modules

The include_once array inside module functions is obsolete
and removed. The autoloader should be used instead.

Resolves: #63464
Releases: master
Change-Id: I5027d42537124bde170ad55f7bb49850c03f1606
Reviewed-on: http://review.typo3.org/34829
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[TASK] Deprecate TS option for XHTML 2.0 82/35682/2
Benjamin Mack [Tue, 30 Dec 2014 22:56:59 +0000 (23:56 +0100)]
[TASK] Deprecate TS option for XHTML 2.0

The TypoScript option for setting XHTML 2.0
for the frontend output

  config.xhtmlDoctype = xhtml_2

is deprecated and marked for removal with CMS8.

XHTML2.0 was dropped by the W3C in favor
of HTML5 in 2010.

Releases: master
Resolves: #24387
Change-Id: I3bdf46ac8b42a162f46f29de5d8fc088acf578ba
Reviewed-on: http://review.typo3.org/35682
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[FEATURE] Override check/radio labels with TSConfig 59/29559/16
Mathias Schreiber [Mon, 29 Dec 2014 08:47:39 +0000 (09:47 +0100)]
[FEATURE] Override check/radio labels with TSConfig

Enable locallang override from TSConfig with reference (LLL:) or value.

Use the following instructions :
TCEFORM.[table name].[field].altLabels.[key]

For check fields, [key] is the index of the checkbox.
For radio fields, [key] is the value of the radio button.

Change-Id: I3e5ec9074c2b2429d983168994950e482b025d49
Resolves: #58033
Releases: master
Reviewed-on: http://review.typo3.org/29559
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Fix image rendering for renderMethod = table 07/35407/4
Torben Hansen [Sun, 14 Dec 2014 11:57:32 +0000 (12:57 +0100)]
[BUGFIX] Fix image rendering for renderMethod = table

Since the introduction of FAL to TYPO3, the rendering of images
using CSS styled content with renderMethod = table is broken.

Using a single image results in the image being rendered twice
and if you have multiple images in one content object, only the
last image is rendered multiple times (depending on the amount
of images in the content object).

This patch resolves both issues and loads the current image file
reference to the contentObjectRenderer while looping through the
images of the content object.

Resolves: #46864
Related: #47004
Releases: master, 6.2
Change-Id: If120267111e30de6438cecc5e14cea34bc6fa235
Reviewed-on: http://review.typo3.org/35407
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Migrate left-over prototype code from IRRE JS 45/35645/2
Benjamin Mack [Fri, 26 Dec 2014 01:07:25 +0000 (02:07 +0100)]
[TASK] Migrate left-over prototype code from IRRE JS

There are a few quirks left from prototype which
should be removed before completely
moving to a requireJS module in a separate task.

The following changes allow prototype to be
disabled in FormEngine with IRRE elements.

Tested via Text w/ Image and EXT:styleguide.

Releases: master
Resolves: #64042
Change-Id: I78f6ee5ff23bce5014afdc1a23e0e619efe64868
Reviewed-on: http://review.typo3.org/35645
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Type check fix in linkhandler link type 98/26498/7
Alexander Stehlik [Sun, 21 Dec 2014 16:08:52 +0000 (17:08 +0100)]
[BUGFIX] Type check fix in linkhandler link type

To determine if a link should be handled by the linkhandler link type
in the linkvalidator, the "type" entry in the $value array will be
checked instead of the $type variable which is always empty.

Resolves: #38639
Releases: master, 6.2
Change-Id: I8183bfca0e4662518063f0d3ec9ba6bab0ff58bf
Reviewed-on: http://review.typo3.org/26498
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] linkvalidator: Add headline fallback to prevent NULL on insert 39/35539/3
Benjamin Serfhos [Wed, 17 Dec 2014 11:45:56 +0000 (12:45 +0100)]
[BUGFIX] linkvalidator: Add headline fallback to prevent NULL on insert

While link checker adds the broken links in the database the content
element can have an empty header. Make sure the inserted record does
not fail of empty headline.

Change-Id: I9cd750a278fd514f6154659c9c8466c2713adfe7
Resolves: #63952
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35539
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] deleteRecord_flexFormCallBack deletes file_references 39/16239/11
Lorenz Ulrich [Tue, 6 Nov 2012 15:22:46 +0000 (16:22 +0100)]
[BUGFIX] deleteRecord_flexFormCallBack deletes file_references

Files that are referenced in a flexform
<type>group</type><internal_type>file_reference</internal_type>
will be deleted by deleteRecord_flexFormCallBack() in
t3lib_TCEmain, independent of the path or usage by other records.

For normal record fields (e.g. tt_content.images), only file
with the internal_type "file" are deleted. Files of
internal_type "file_reference" are respected and will not be
deleted. There is an appropriate condition in
t3lib_TCEmain::extFileFunctions().

But for flexform fields, this differentiation in handling
between both internal_types is missing.

Therefore using lowlevel_cleaner or the delete option in the
recycler will delete files that may be still in use. The
flexFormCallBack must be changed to delete only files of
internal_type "file".

Change-Id: I8519705f2155bf0d49ae10316c6622f670189e28
Fixes: #40052
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/16239
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years agoRevert "[TASK] Additional check for valid domain in validEmail()" 83/35683/2
Steffen Müller [Tue, 30 Dec 2014 23:00:57 +0000 (00:00 +0100)]
Revert "[TASK] Additional check for valid domain in validEmail()"

Reverts #56771 which introduced brittle feature + tests to validEmail() which were beyond the scope of the function.

This reverts commit 5033a33d7b7ed13f6672db6846ad097b8120315b.

Change-Id: Ib2b25af1e65ac93c4174117dc15f2e27e5466288
Reverts: #56771
Resolves: #64064
Release: master
Reviewed-on: http://review.typo3.org/35683
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[TASK] Add absRefPrefix to responsive images 38/25138/5
Georg Ringer [Sun, 3 Nov 2013 13:34:35 +0000 (14:34 +0100)]
[TASK] Add absRefPrefix to responsive images

Responsive images must also use the absRefPrefix
as prefix.

Resolves: #53292
Releases: master, 6.2
Change-Id: I12f4ece9b2dda6fb1f56684aefd4013b4ee907a9
Reviewed-on: http://review.typo3.org/25138
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Frederic Gaus <gaus@flagbit.de>
Tested-by: Frederic Gaus <gaus@flagbit.de>
Reviewed-by: Steffen Müller <typo3@t3node.com>
Tested-by: Steffen Müller <typo3@t3node.com>
4 years ago[FEATURE] Add to "additionalWhere" to TypoScript menus 42/19242/5
Mathias Schreiber [Sun, 28 Dec 2014 17:19:26 +0000 (18:19 +0100)]
[FEATURE] Add to "additionalWhere" to TypoScript menus

Allow for TMENU/GMENU to have a new option called
"additionalWhere" to narrow down the SQL query put
in the makeMenu function in the PageRepository.

The patch adds a new TypoScript option which is just
sending an extra parameter to the getMenu() function.

This is possible for all HMENU options supported by
the TYPO3 CMS core.

Releases: master
Resolves: #46624
Change-Id: Ia96b6aa95049ea6de9ecfd4a5adb69e71ccde2b7
Reviewed-on: http://review.typo3.org/19242
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Daniel Maier <dani-maier@gmx.de>
Tested-by: Daniel Maier <dani-maier@gmx.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[TASK] Additional check for valid domain in validEmail() 64/28264/5
Benjamin Mack [Tue, 11 Mar 2014 16:13:21 +0000 (17:13 +0100)]
[TASK] Additional check for valid domain in validEmail()

If using a correct email address (= correct syntax),
but the domain name has no valid MX entry,
then a given email is validated as valid,
but the destination is still wrong. In some cases
the email should be completely validated.
By adding an additional PHP call to check if
the MX entry of the domain part is valid, the
validEmail() can be put in a stricter mode.

Releases: master
Resolves: #56771
Change-Id: I1396320835a9e2b51533d8b43115a7c4ef3ec338
Reviewed-on: http://review.typo3.org/28264
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] Invalid phpDoc in ToolbarItemInterface 70/35670/2
Xavier Perseguers [Tue, 30 Dec 2014 11:05:48 +0000 (12:05 +0100)]
[BUGFIX] Invalid phpDoc in ToolbarItemInterface

Method getAdditionalAttributes() returns an array of HTML attributes.

Resolves: #64058
Releases: master
Change-Id: I38022eceffd8eb8d0121046e5323b9f81d56092b
Reviewed-on: http://review.typo3.org/35670
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FOLLOWUP] Fix missing semicolon 67/35667/2
Wouter Wolters [Mon, 29 Dec 2014 22:49:45 +0000 (23:49 +0100)]
[FOLLOWUP] Fix missing semicolon

Resolves: #64036
Releases: master
Change-Id: I7899481c2229ee3f9c5dfcca695cf025cec0cb33
Reviewed-on: http://review.typo3.org/35667
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FEATURE] Allow RequireJS module loading to execute custom code 35/35635/2
Benjamin Mack [Wed, 24 Dec 2014 13:02:49 +0000 (14:02 +0100)]
[FEATURE] Allow RequireJS module loading to execute custom code

When loading RequireJS modules, it is sometimes helpful to
execute custom code or set inline settings coming from the
server side.

A second parameter in the PageRenderer->loadRequireJsModule

allows to work exactly like using the JS code directly for
require([module], function() { customCode(); });

This is used as a basis to allow proper coding of JS changes
like the legacy tree functionality.

See the current Storage API change for an example on how to use
this.

Releases: master
Resolves: #64036
Change-Id: I7a84f930f7aeab8e46fcf93639055576f751a304
Reviewed-on: http://review.typo3.org/35635
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Performance: Avoid using array_keys in foreach 73/35373/8
Mathias Schreiber [Mon, 29 Dec 2014 08:39:57 +0000 (09:39 +0100)]
[TASK] Performance: Avoid using array_keys in foreach

This lowers the memory usage.

Iterate on the original array instead of an array_keys()-copy
which lowers memory usage and enhances performance.

Change-Id: If65fae1665e242667d621f086a55a22a8d5309ed
Resolves: #64004
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35373
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[CLEANUP] Remove superfluous ContainerViewHelper 62/35662/2
Andreas Fernandez [Mon, 29 Dec 2014 10:14:15 +0000 (11:14 +0100)]
[CLEANUP] Remove superfluous ContainerViewHelper

The ContainerViewHelper in EXT:beuser is removed due to identical
functionality introduced in Ie8464963eb421eca65c0a3c750920037bcee78bc.

Resolves: #64053
Related: #63913
Releases: master
Change-Id: Ic918a090c605a01a63de6b46d45e91fb4a2378e9
Reviewed-on: http://review.typo3.org/35662
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Fix common misspellings and typos 61/35661/4
Wouter Wolters [Sun, 28 Dec 2014 14:51:51 +0000 (15:51 +0100)]
[TASK] Fix common misspellings and typos

Resolves: #64051
Releases: master
Change-Id: I7a36da752fb72d30b5504003cc494feb835a8592
Reviewed-on: http://review.typo3.org/35661
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[BUGFIX] Forms in sys_action need localization and rearrangement 13/35613/5
Mathias Schreiber [Tue, 23 Dec 2014 16:53:35 +0000 (17:53 +0100)]
[BUGFIX] Forms in sys_action need localization and rearrangement

Resolves: #62837
Releases: master
Change-Id: I34ed297bc2b1d2616219ec27b3e3b796ea55c7cd
Reviewed-on: http://review.typo3.org/35613
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[FEATURE] Allow ContainerViewHelper to load RequireJS modules 88/35488/6
Andreas Fernandez [Mon, 15 Dec 2014 17:51:01 +0000 (18:51 +0100)]
[FEATURE] Allow ContainerViewHelper to load RequireJS modules

Add $includeRequireJsModules to ContainerViewHelper that loads RequireJS
modules, if given.

Resolves: #63913
Releases: master
Change-Id: Ie8464963eb421eca65c0a3c750920037bcee78bc
Reviewed-on: http://review.typo3.org/35488
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years agoRevert "[BUGFIX] Typo3DbQueryParser: Use IN with array-operand2" 48/35648/3
Helmut Hummel [Fri, 26 Dec 2014 12:33:02 +0000 (13:33 +0100)]
Revert "[BUGFIX] Typo3DbQueryParser: Use IN with array-operand2"

Reverts: #63275
Resolves: #64044
Related: #7848

This reverts commit e235c9ad8b32267ece98d843a43daeab430db235.

Change-Id: I71a134469b9b44f892ad13be52d828ca653c03f1
Reviewed-on: http://review.typo3.org/35648
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[FOLLOW-UP] Rename rst file 47/35647/2
Frank Nägler [Fri, 26 Dec 2014 11:53:12 +0000 (12:53 +0100)]
[FOLLOW-UP] Rename rst file

Add missing file extension to rst file.

Resolves: #58929
Releases: master
Change-Id: I39e9286914eb92db70dfd68bcd837b9fe0183f2f
Reviewed-on: http://review.typo3.org/35647
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Typo3DbQueryParser: Use IN with array-operand2 14/34514/6
Stefan Neufeind [Sun, 23 Nov 2014 21:19:08 +0000 (22:19 +0100)]
[BUGFIX] Typo3DbQueryParser: Use IN with array-operand2

When passing an array for a "contains"-comparison
Typo3DbQueryParser generates SQL like
[...] WHERE uid_local='1','3' [...]
which simply needs an "IN" statement for the operand2.

Change-Id: Id3a6e73dcbd55d46a5279037b156f604dafa9888
Resolves: #63275
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/34514
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[!!!][TASK] Use progress bar instead of mask for loading 42/34242/6
Benjamin Mack [Sun, 16 Nov 2014 11:16:39 +0000 (12:16 +0100)]
[!!!][TASK] Use progress bar instead of mask for loading

The core currently has two places where a loading
indicator is shown:

* Loading iframes, using a mask created by ExtJS
* Loading IRRE elements via AJAX, hand-made for IRRE

This behaviour should be unified with a new and clean API
using the JS library nprogress (MIT license).

Some old CSS code can safely removed, as it is not
used anymore.

Releases: master
Resolves: #64035
Change-Id: Iaf45af96aa022571195d1a27cfaa9dfd0f4ad63a
Reviewed-on: http://review.typo3.org/34242
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
4 years ago[FEATURE] API for Bootstrap Modals 13/35313/20
Andreas Fernandez [Thu, 11 Dec 2014 16:56:52 +0000 (17:56 +0100)]
[FEATURE] API for Bootstrap Modals

This patch introduces a new BE API for modals.
We introduce only a confirm method, because
the modal should be used as few as possible and
only for small information or confirm dialogs.

Resolves: #63729
Releases: master
Change-Id: Ie2ed6742fbebbc982afabb4eff01045fb2318492
Reviewed-on: http://review.typo3.org/35313
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[FEATURE] Add hook for content element footer in Page module 09/31309/4
Leon de Rijke [Thu, 3 Jul 2014 09:54:52 +0000 (11:54 +0200)]
[FEATURE] Add hook for content element footer in Page module

Currently, there is only a hook for the `tt_content_drawItem` function
in the PageLayoutView. Since 6.0 the info fields for a tt_content element
(hidden,starttime,endtime,fe_group,spaceBefore,spaceAfter) are rendered
in a footer, so there is no way to alter the rendering of the info
fields or add information to the footer.

This change adds a hook to the `tt_content_drawFooter` function
responsible for rendering the footer.

Resolves: #58929
Releases: master
Change-Id: I23c54eefd3a511fddd480b4bf08d6a3977757973
Reviewed-on: http://review.typo3.org/31309
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Backend typolink fields not saved 66/19766/4
Wouter Wolters [Tue, 9 Apr 2013 18:35:46 +0000 (20:35 +0200)]
[BUGFIX] Backend typolink fields not saved

Adds a trailing slash on input and a call to onchange for that field.

Change-Id: Ib17216aba9c0190018a44a04e2081cac19c0b84a
Resolves: #25946
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/19766
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Show info in empty list module 05/35505/3
Georg Ringer [Tue, 16 Dec 2014 06:03:04 +0000 (07:03 +0100)]
[TASK] Show info in empty list module

If the selected page doesn't contain any records to edit, the module
is completly empty. This looks like an error ("white page").

Show a flash message instead.

Resolves: #58743
Releases: master
Change-Id: I4b3fa45d36e42a06ba9855d9d72f0995eac3b0dd
Reviewed-on: http://review.typo3.org/35505
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[TASK] Use stricter checks in DataHandler 29/35329/4
Wouter Wolters [Thu, 11 Dec 2014 22:40:22 +0000 (23:40 +0100)]
[TASK] Use stricter checks in DataHandler

Resolves: #63993
Releases: master
Change-Id: I157be570d1d226685511f83e37fe287e244b9fb2
Reviewed-on: http://review.typo3.org/35329
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[CLEANUP] Namespace cleanup in TypoScriptFrontendController 18/35618/6
Alexander Opitz [Mon, 22 Dec 2014 11:36:12 +0000 (12:36 +0100)]
[CLEANUP] Namespace cleanup in TypoScriptFrontendController

Fix small leftovers after ::class change.

Resolves: #64022
Releases: master
Change-Id: I6873492921cd2205fa621da8842fa186d485e4df
Reviewed-on: http://review.typo3.org/35618
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Wrong RequireJs paths for jQuery in frontend 81/35281/3
Stanislas Rolland [Thu, 11 Dec 2014 03:24:19 +0000 (22:24 -0500)]
[BUGFIX] Wrong RequireJs paths for jQuery in frontend

The RequireJS paths set by page renderer for jQuery components is wrong
in frontend.
Add missing backpath.

Releases: master
Resolves: #63759
Change-Id: If82ddbf820e03acaf6d8266d3b76f14a95348e38
Reviewed-on: http://review.typo3.org/35281
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[FEATURE] Configurable width of the Element Browser Popups 18/29618/6
Georg Ringer [Fri, 18 Apr 2014 03:24:41 +0000 (05:24 +0200)]
[FEATURE] Configurable width of the Element Browser Popups

The width of the element browser is sadly hardcoded to 600 and 650.

In many situations the element browser would need more place and
with this tiny change it would be easily possible to change
that behaviour without overloading the whole file.

The patch allows to set dimensions on a per-user basis via
userTSconfig.

Resolves: #58031
Resolves: #20929
Resolves: #22976
Releases: master
Change-Id: Ida3d01c7fd0457b4a88a33a10b0c19792ba9751a
Reviewed-on: http://review.typo3.org/29618
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[FEATURE] Integrate Uri.TypolinkViewHelper 06/34106/10
Jan Helke [Thu, 13 Nov 2014 19:00:51 +0000 (20:00 +0100)]
[FEATURE] Integrate Uri.TypolinkViewHelper

Based on the existing typolink view helper.
This is a variant to just return the URI.

Resolves: #62931
Releases: master
Change-Id: Iedf7972917a0b5ee1b7b25112cbe9238026236f7
Reviewed-on: http://review.typo3.org/34106
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 years ago[BUGFIX] Fix notice of ttl of ENABLE_INSTALL_TOOL 12/35612/7
Frederic Gaus [Sat, 20 Dec 2014 20:12:33 +0000 (21:12 +0100)]
[BUGFIX] Fix notice of ttl of ENABLE_INSTALL_TOOL

This patch fixes the notice of the install tool protection status
in the reports module, which has been accidentally been removed
with #57072

Change-Id: Idfad1340a1bd395b67c9ff2a60fec69e6a0add97
Resolves: #64003
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/35612
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Remove unused ViewHelpers from ext:belog 03/35603/2
Wouter Wolters [Sat, 20 Dec 2014 16:48:05 +0000 (17:48 +0100)]
[TASK] Remove unused ViewHelpers from ext:belog

With the replacing of the DateTimePicker two ViewHelpers
became obsolete. Both are removed without substitution.

Resolves: #40189
Releases: master
Change-Id: Ic5b16875ed8213d693f54604d09faec53f98aca8
Reviewed-on: http://review.typo3.org/35603
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[FEATURE] Add pattern attribute to TextfieldViewHelper 01/35601/3
Roman Schuermann [Sat, 20 Dec 2014 15:22:27 +0000 (16:22 +0100)]
[FEATURE] Add pattern attribute to TextfieldViewHelper

In order to allow HTML5 validation, the Textfield ViewHelper needs
"pattern" as an attribute.

Resolves: #62428
Releases: master
Change-Id: Idbb35fafec2220c255e2ae3f82ad30f8fe84133d
Reviewed-on: http://review.typo3.org/35601
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
4 years ago[BUGFIX] Properly HTML encode URI in renderer 00/35600/2
Helmut Hummel [Sat, 20 Dec 2014 14:00:49 +0000 (15:00 +0100)]
[BUGFIX] Properly HTML encode URI in renderer

The audio and video tag renderer fails to properly
encode the URI of the files for HTML.

Fix this and adapt the tests.

Resolves: #64000
Releases: master
Change-Id: Iac6d06ce9cabac31545e8cb5f542f3d096990ebe
Reviewed-on: http://review.typo3.org/35600
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Roman Schürmann <roman.schuermann@wmdb.de>
Tested-by: Roman Schürmann <roman.schuermann@wmdb.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] Use autoload map instead of aliases in sysext form 99/35599/2
Helmut Hummel [Fri, 5 Dec 2014 10:41:39 +0000 (11:41 +0100)]
[TASK] Use autoload map instead of aliases in sysext form

Using the alias map is misleading as it is only used
to force the class loader to cache class names with
lowercased identifier to be able to load the class
with "wrong" casing.

Use the autoload map for that instead and clarify
in that file that it must not be removed for now.

Resolves: #63999
Related: #63576 #63577
Releases: master
Change-Id: I8f683ff1d68480a3530a8d2fea62208e66ca947d
Reviewed-on: http://review.typo3.org/35599
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[FEATURE] Make linking of section titles configurable 93/20193/7
Ralf Hettinger [Fri, 26 Apr 2013 16:25:36 +0000 (18:25 +0200)]
[FEATURE] Make linking of section titles configurable

Adding the TS property
plugin.tx_indexedsearch.linkSectionTitles = boolean
which allows turing on/off linking of the sections' titles.
Default is 1 to keep current behaviour.

Resolves: #16794
Releases: master
Change-Id: I0aa32ed49a16dcdd737907324a69d15057598920
Reviewed-on: http://review.typo3.org/20193
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
4 years ago[BUGFIX] Prevent double content link checks 12/26512/6
Mathias Schreiber [Thu, 18 Dec 2014 09:45:12 +0000 (10:45 +0100)]
[BUGFIX] Prevent double content link checks

When a link points to a content element by using it's anchor behind
the page UID the reference index contains two entries for this link,
one for the linked page and one for the linked content element.

Since the content element is already checked when the page link is
validated by extracting the anchor element from the URL it is not
required to handle any other references than those starting with
"pages:". This prevents content elements from being treated as pages.

Resolves: #50772
Releases: master, 6.2
Change-Id: I5337ea01614eee2228fe09936f49a88b5ea96e5d
Reviewed-on: http://review.typo3.org/26512
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Decouple responsibilities in default errorAction() 44/26944/6
Helmut Hummel [Thu, 18 Dec 2014 09:48:38 +0000 (10:48 +0100)]
[TASK] Decouple responsibilities in default errorAction()

The default Extbase ActionController::errorAction does a lot
of different things, which makes it hard to customize a controller
to a desired behavior without copying all or some of its code.

Extracting the different responsibilities to separate methods
simplifies such customizations.

Resolves: #55178
Releases: master
Change-Id: I324a504c745649eec11eec65d4e6a718a5e434bd
Reviewed-on: http://review.typo3.org/26944
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 years ago[TASK] Re-add tests for renumberKeys 82/35582/2
Susanne Moog [Fri, 19 Dec 2014 09:37:29 +0000 (10:37 +0100)]
[TASK] Re-add tests for renumberKeys

The test for renumberKeysToAvoidLeaps were accidentally
removed. Add them again.

Change-Id: Ib51cc8f96d7745ae199ecd2c1e77d728611fde78
Resolves: #63986
Releases: master
Reviewed-on: http://review.typo3.org/35582
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[!!!][TASK] Replace ExtJS DateTimePicker with bootstrap alternative 80/35580/5
Frank Nägler [Fri, 19 Dec 2014 08:33:16 +0000 (09:33 +0100)]
[!!!][TASK] Replace ExtJS DateTimePicker with bootstrap alternative

Follow-up: only deprecate unused method, not remove.

Resolves: #62925
Releases: master
Change-Id: Icce2e9756d74c1c3297fd57e125f67c27056b087
Reviewed-on: http://review.typo3.org/35580
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[!!!][TASK] Replace ExtJS DateTimePicker with bootstrap alternative 94/34094/20
Frank Nägler [Thu, 13 Nov 2014 13:55:17 +0000 (14:55 +0100)]
[!!!][TASK] Replace ExtJS DateTimePicker with bootstrap alternative

This patch replaces the ExtJS DateTimePicker with a bootstrap
based alternative.

The DatePicker is used in the EXT:belog module,
FormEngine and in the EXT:scheduler module

Resolves: #62925
Releases: master
Change-Id: I012e907dda7b8ab0f8583bab2c55cff82c93179e
Reviewed-on: http://review.typo3.org/34094
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 years ago[!!!][TASK] Deprecate FormEngine::$renderReadonly 00/35500/9
Frank Nägler [Mon, 15 Dec 2014 21:56:25 +0000 (22:56 +0100)]
[!!!][TASK] Deprecate FormEngine::$renderReadonly

This patch deprecates FormEngine::$renderReadonly
and removes the dependency from all form element classes.

Resolves: #63847
Releases: master
Change-Id: I4c998c53a3d206586ce6c464696c6e6a4b2f99af
Reviewed-on: http://review.typo3.org/35500
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
4 years ago[FEATURE] Let the reports in the install module check for new versions 45/33745/16
Wouter Wolters [Wed, 12 Nov 2014 20:20:57 +0000 (21:20 +0100)]
[FEATURE] Let the reports in the install module check for new versions

This patch modifies the reports of the install module. Now it behaves
similar to the install tool and issues an error or a warning status
when there is a new version available.

Currently this function only works for the current minor version
(e.g. 6.2.X). It will not notify about updates to e.g. 7.X.X. Besides
it does not take care about development versions at all.

Version information is downloaded from get.typo3.org. If this is not
possible, the old functionality is still working (which is printing out
the version information only with Status::NOTIFY.

With the version information it is checked if the current version is
up-to-date. If it is, the version is printed out with Status::OK. If not,
it checks if there is a security issue in the current version. If yes, the
status get severity Status::ERROR, otherwise Status::WARNING is used.

Resolves: #62444
Related: #62649
Releases: master
Change-Id: Ifdb62e3a4c34f700a73087271d7bff7daf6b8838
Reviewed-on: http://review.typo3.org/33745
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] Fix fatal in RsaAuth-PhpBackendTest with broken openssl config 31/35531/4
Stephan Großberndt [Wed, 17 Dec 2014 01:19:31 +0000 (02:19 +0100)]
[BUGFIX] Fix fatal in RsaAuth-PhpBackendTest with broken openssl config

If the openssl environment is not set up correctly (in Install Tool:
"PHP OpenSSL extension not working") the unit test
TYPO3\CMS\Rsaauth\Tests\Unit\Backend\PhpBackendTest causes a fatal PHP
error "Call to a member function isReady() on a non-object". This
happens because $this->subject->createNewKeyPair() returns NULL if
something goes wrong while setting up a openssl keypair.

Assert the keypair is not null before calling $keypair->isReady().

Resolves: #63948
Releases: master, 6.2
Change-Id: Iffde2b7eafe160d387568d08f627a2bb9852f32f
Reviewed-on: http://review.typo3.org/35531
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Error message in RTE, if I want to insert a Custom Item 68/35568/2
Stanislas Rolland [Thu, 18 Dec 2014 19:42:10 +0000 (14:42 -0500)]
[BUGFIX] Error message in RTE, if I want to insert a Custom Item

Wrong wizard name is used.

Releases: master, 7.0
Resolves: #63938
Change-Id: If8ce8a6efb7ef6b96cc2ce904ab0eb8953492f07
Reviewed-on: http://review.typo3.org/35568
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Button not disabled when in text mode 75/35575/2
Stanislas Rolland [Thu, 18 Dec 2014 20:55:37 +0000 (15:55 -0500)]
[BUGFIX] RTE: Button not disabled when in text mode

Releases: master
Resolves: #63983
Change-Id: Idffdd3facd8e7cf9c0f4de9f7f2df7d344ba2b94
Reviewed-on: http://review.typo3.org/35575
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] Fix dummy parameter and return texts in phpDoc 50/35550/3
Wouter Wolters [Wed, 17 Dec 2014 20:58:50 +0000 (21:58 +0100)]
[TASK] Fix dummy parameter and return texts in phpDoc

Resolves: #63969
Releases: master
Change-Id: If6559f99998ad9f188b40466830556db507d9eda
Reviewed-on: http://review.typo3.org/35550
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] RTE: JS errors on unload 57/35557/2
Stanislas Rolland [Thu, 18 Dec 2014 03:38:13 +0000 (22:38 -0500)]
[BUGFIX] RTE: JS errors on unload

Cleanup the cleanup operations.

Releases: master
Resolves: #63971
Change-Id: I81706a18cdbd39f13d78fdf9738720682ab56d71
Reviewed-on: http://review.typo3.org/35557
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] RTE: Status bar update is happening too late 56/35556/4
Stanislas Rolland [Thu, 18 Dec 2014 02:23:55 +0000 (21:23 -0500)]
[BUGFIX] RTE: Status bar update is happening too late

Force status bar update on initialization and before each toolbar update.

Releases: master
Resolves: #63970
Change-Id: I39833e1256b9b5df2ad0400238278d59921f00c0
Reviewed-on: http://review.typo3.org/35556
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[BUGFIX] Respect sys_language enable fields 73/31173/4
Alexander Stehlik [Sat, 13 Dec 2014 12:08:44 +0000 (13:08 +0100)]
[BUGFIX] Respect sys_language enable fields

This patch adds a call to BackendUtility::BEenableFields()
in the getSystemLanguages() of the TranslationConfigurationProvider
so that hidden records will not be returned any more.

Releases: master, 6.2
Resolves: #59947
Change-Id: I1c73de4621c7490273ce2966130e53add70b81cd
Reviewed-on: http://review.typo3.org/31173
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Susanne Moog <typo3@susannemoog.de>
Tested-by: Susanne Moog <typo3@susannemoog.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
4 years ago[BUGFIX] RTE: Incorrect height of the RTE framework 54/35554/2
Stanislas Rolland [Wed, 17 Dec 2014 22:51:00 +0000 (17:51 -0500)]
[BUGFIX] RTE: Incorrect height of the RTE framework

The calculated height of the toolbar is incorrect due to floating
elements.

Releases: master
Resolves: #63964
Change-Id: I771a0f3f31112777d6d2b8507c23d93f359c24b3
Reviewed-on: http://review.typo3.org/35554
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] Fix dummy texts in phpDoc 48/35548/2
Wouter Wolters [Wed, 17 Dec 2014 19:38:29 +0000 (20:38 +0100)]
[TASK] Fix dummy texts in phpDoc

Resolves: #37346
Releases: master
Change-Id: I7cafc1ba69b1906ead97f6b82717e2747d87cf94
Reviewed-on: http://review.typo3.org/35548
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[BUGFIX] RTE: Missing hide method in StatusBar 46/35546/2
Stanislas Rolland [Wed, 17 Dec 2014 16:13:45 +0000 (11:13 -0500)]
[BUGFIX] RTE: Missing hide method in StatusBar

Releases: master
Resolves: #63963
Change-Id: Ia7d4a77837e6c840f6118da24e444c55b395319a
Reviewed-on: http://review.typo3.org/35546
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[TASK] RTE: Remove ExtJS QuickTips from status bar 43/35543/2
Stanislas Rolland [Wed, 17 Dec 2014 14:51:41 +0000 (09:51 -0500)]
[TASK] RTE: Remove ExtJS QuickTips from status bar

This completes the migration of the RTE status bar to plain JavaScript.

Releases: master
Resolves: #63957
Change-Id: I7b0a2e08d57c21e6a8c4325ec5fb456d15bc4371
Reviewed-on: http://review.typo3.org/35543
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[FEATURE] Emit Signal at the very end of DataPreprocessor::fetchRecord() 62/32862/20
Roland Waldner [Thu, 18 Sep 2014 11:01:46 +0000 (13:01 +0200)]
[FEATURE] Emit Signal at the very end of DataPreprocessor::fetchRecord()

Introduces a new signal which can be used to e.g. manipulate the
regTableItems_data array to display that manipulated data in TCEForms.

Resolves: #61711
Releases: master
Change-Id: I9dbc5e039e48b5eeaaf639c79d25e5885d007a78
Reviewed-on: http://review.typo3.org/32862
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <klein.t3@reelworx.at>
Tested-by: Markus Klein <klein.t3@reelworx.at>
4 years ago[TASK] Lower memory use in ArrayUtil->mergeRecursiveWithOverrule 51/35351/5
Stephan Großberndt [Fri, 12 Dec 2014 13:58:17 +0000 (14:58 +0100)]
[TASK] Lower memory use in ArrayUtil->mergeRecursiveWithOverrule

Iterate on the original array instead of an array_keys()-copy in
ArrayUtil->mergeRecursiveWithOverrule which lowers memory usage and
enhances performance.

Resolves: #63812
Releases: master, 6.2
Change-Id: I71acc9e1e730f1e782d0e74acd45637ce1b9f08e
Reviewed-on: http://review.typo3.org/35351
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 years ago[TASK] RTE: Migrate toolbar button to plain JavaScript 32/35532/4
Stanislas Rolland [Wed, 17 Dec 2014 01:25:31 +0000 (20:25 -0500)]
[TASK] RTE: Migrate toolbar button to plain JavaScript

Releases: master
Resolves: #63946
Change-Id: Ib9230c9b9317ced27f6b293514eacd98db1ba842
Reviewed-on: http://review.typo3.org/35532
Reviewed-by: Stanislas Rolland <typo3@sjbr.ca>
Tested-by: Stanislas Rolland <typo3@sjbr.ca>
4 years ago[CLEANUP] Add missing empty lines before classes' closing curly braces 27/35527/2
Roland Waldner [Tue, 16 Dec 2014 22:09:32 +0000 (23:09 +0100)]
[CLEANUP] Add missing empty lines before classes' closing curly braces

Most of TYPO3's PHP files have an empty line before a class' closing curly
brace. This commit adds this empty line (if it is missing) before a class'
closing curly brace.

This is not part of the TYPO3 CMS CGL but increases consistency in this
area.

This regular expression was used to add the empty lines:

Search:
(}\n)(})

Replace:
$1\n$2

Resolves: #63942
Release: master
Change-Id: Icd6547322ac8b7310956d347fd73c90bde2bbfa7
Reviewed-on: http://review.typo3.org/35527
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 years ago[BUGFIX] Fix failing PHPUnit-Tests on Windows due to uniqid()-calls 28/35528/2
Stephan Großberndt [Tue, 16 Dec 2014 22:42:07 +0000 (23:42 +0100)]
[BUGFIX] Fix failing PHPUnit-Tests on Windows due to uniqid()-calls

If in one test multiple objects are created and their names are created
with uniqid()-calls without params, they fail because they return the
same value.

Using md5(uniqid(microtime(), true)) instead makes object names unique.

Resolves: #63943
Releases: master, 6.2
Change-Id: Ib223d45f04946223c4a8ae9ce68a5c5b24459355
Reviewed-on: http://review.typo3.org/35528
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>