Packages/TYPO3.CMS.git
8 months ago[BUGFIX] Streamline tree markup 85/59285/3
Andreas Fernandez [Sun, 23 Dec 2018 08:29:30 +0000 (09:29 +0100)]
[BUGFIX] Streamline tree markup

The trees used in TSOB and in the configuration module have a different
markup than the tree of the Link Browser (and the rest), causing the
regression introduced with #86790. The markup of the trees is now changed
to have a consistent structure.

Resolves: #87280
Related: #86790
Releases: master, 9.5, 8.7
Change-Id: I00c6b93c760a725e1ee771651f26c53573e0a6e2
Reviewed-on: https://review.typo3.org/59285
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[!!!][TASK] Remove deprecated code in EditFileController 82/59282/3
Anja Leichsenring [Sat, 22 Dec 2018 17:18:01 +0000 (18:18 +0100)]
[!!!][TASK] Remove deprecated code in EditFileController

Change-Id: I82b07824a592206110ff0f07dc97488dc5ce5c80
Resolves: #87278
Releases: master
Reviewed-on: https://review.typo3.org/59282
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[!!!][TASK] Remove deprecated IMGMENU and GMENU 80/59280/4
Christian Kuhn [Sat, 22 Dec 2018 16:29:38 +0000 (17:29 +0100)]
[!!!][TASK] Remove deprecated IMGMENU and GMENU

Change-Id: Ie2ee4ea69ff3cdc67155d292bfd3fccbe1d7ad09
Resolves: #87279
Releases: master
Reviewed-on: https://review.typo3.org/59280
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Add missing class aliases to extension scanner 78/59278/6
Anja Leichsenring [Sat, 22 Dec 2018 15:49:53 +0000 (16:49 +0100)]
[TASK] Add missing class aliases to extension scanner

Class aliases have been removed, leading to fatal php errors
for class not found. These class names can be scanned, so
adding them to the class name matcher configuration will ease
the update for users.

Change-Id: I589b2d222724cd77d3e3163104240b5dccb3da66
Resolves: #87277
Relates: #87230
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/59278
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove sys_domain and LegacyDomains 33/59233/6
Benni Mack [Thu, 20 Dec 2018 09:26:41 +0000 (10:26 +0100)]
[!!!][TASK] Remove sys_domain and LegacyDomains

Removes the legary sys_domain table and handling.

Resolves: #87276
Releases: master
Change-Id: If2a5eeb1ebcc113c8b00162f4c02ea3a58edcefe
Reviewed-on: https://review.typo3.org/59233
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove Extbase mode for non-consistentTranslationOverlayHandling 55/59255/7
Benni Mack [Fri, 21 Dec 2018 11:54:10 +0000 (12:54 +0100)]
[!!!][TASK] Remove Extbase mode for non-consistentTranslationOverlayHandling

The feature flag and all its logic for not using the
consistentTranslationOverlayHandling in Extbase has been removed.

Along with that, QuerySettings interface has two methods less to implement:
- setLanguageMode()
- getLanguageMode()

The methods are kept within the implementation in Typo3QuerySettings without
any actions for now.

Resolves: #87264
Releases: master
Change-Id: Id4f46c8ff61ec86697d8b9dcbe6cd489b2782c0d
Reviewed-on: https://review.typo3.org/59255
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Remove deprecated code in ElementInformationController 77/59277/4
Anja Leichsenring [Sat, 22 Dec 2018 14:51:46 +0000 (15:51 +0100)]
[TASK] Remove deprecated code in ElementInformationController

Change-Id: I5511af7dac4de54ff01f3a1f1ba9c0fb83697ac0
Resolves: #87272
Releases: master
Reviewed-on: https://review.typo3.org/59277
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Avoid case mismatches in method calls 76/59276/3
Alexander Schnitzler [Sat, 22 Dec 2018 14:31:58 +0000 (15:31 +0100)]
[TASK] Avoid case mismatches in method calls

Releases: master
Resolves: #87273
Change-Id: I903d15be35772d9e18be93f65a8ec371837c3aec
Reviewed-on: https://review.typo3.org/59276
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated code from PageLayoutController 74/59274/3
Christian Kuhn [Sat, 22 Dec 2018 13:28:54 +0000 (14:28 +0100)]
[!!!][TASK] Remove deprecated code from PageLayoutController

Resolves: #87270
Releases: master
Change-Id: Ib6016927dbc79f83d4e0f0b57f8e01bc88ddb963
Reviewed-on: https://review.typo3.org/59274
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Minor code cleanups 69/59269/2
Christian Kuhn [Sat, 22 Dec 2018 12:20:04 +0000 (13:20 +0100)]
[BUGFIX] Minor code cleanups

A small series of minor cleanups:
* Setting a no longer existing property
* Slight variable type improvements
* Unused variable assignment

Resolves: #87267
Releases: master
Change-Id: I07c43b31b8fb2d8bacd80dc023595860fa77abf4
Reviewed-on: https://review.typo3.org/59269
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated Extbase-related code (Part 3) 73/59273/3
Alexander Schnitzler [Sat, 22 Dec 2018 13:10:18 +0000 (14:10 +0100)]
[!!!][TASK] Remove deprecated Extbase-related code (Part 3)

* public static method in ActionController
* public method in Argument
* public method in Arguments
* class AbstractValidatorTestcase
* legacy location of settings.view.formatToPageTypeMapping

Releases: master
Resolves: #87268
Change-Id: Ieacc247e2ee85b088c01ae9d6d79691df319b333
Reviewed-on: https://review.typo3.org/59273
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Remove registered legacy extbase annoations 47/59247/5
Alexander Schnitzler [Thu, 20 Dec 2018 20:20:46 +0000 (21:20 +0100)]
[TASK] Remove registered legacy extbase annoations

The following registered annotations are no longer supported.
Therefore they should no longer be registered.

* inject
* transient
* lazy
* validate
* cascade
* cli
* flushesCaches
* uuid
* identity

Releases: master
Resolves: #87272
Change-Id: I3d018ce39cc33e4ab55f966083ef2d6112570ebc
Reviewed-on: https://review.typo3.org/59247
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Remove invalid NoSuchCommandException 68/59268/2
Christian Kuhn [Sat, 22 Dec 2018 12:15:21 +0000 (13:15 +0100)]
[BUGFIX] Remove invalid NoSuchCommandException

The NoSuchCommandExceptions has been forgotton
to be removed along with the CommandException
it extends from. It is unused and can be dropped.

Resolves: #87266
Related: #85977
Related: #87246
Releases: master
Change-Id: Ie83695be3f688ad0e52a4fd54918df2b167f6560
Reviewed-on: https://review.typo3.org/59268
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Replace @ignorevalidation with @Extbase\IgnoreValidation 67/59267/3
Alexander Schnitzler [Sat, 22 Dec 2018 12:06:36 +0000 (13:06 +0100)]
[BUGFIX] Replace @ignorevalidation with @Extbase\IgnoreValidation

While dropping support for @ignorevalidation in #86901
(https://review.typo3.org/58886/) some usages of @ignorevalidation
had not been replaced.

Releases: master
Resolves: #87255
Change-Id: I9067dcb8b376da184b8f1f5a6694062edc3e0e71
Reviewed-on: https://review.typo3.org/59267
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Add PATH_site to extension scanner 66/59266/3
Christian Kuhn [Sat, 22 Dec 2018 11:52:00 +0000 (12:52 +0100)]
[BUGFIX] Add PATH_site to extension scanner

When deprecating PATH_site constants we missed
an entry in the extension scanner. Let's add that
matcher since the constant is rather frequently
used in extensions and deserves a match.

Resolves: #87265
Related: #85285
Releases: master, 9.5
Change-Id: I4b2c6cba062ba54a16256fbe8f8ffc2550cfd312
Reviewed-on: https://review.typo3.org/59266
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Avoid frameborder attribute if no doctype is set 17/59117/2
Georg Ringer [Tue, 11 Dec 2018 12:56:05 +0000 (13:56 +0100)]
[BUGFIX] Avoid frameborder attribute if no doctype is set

The YouTube and Vimeo renderer must also check if the doctype is not set as html5 is
the default value.

Resolve: #87114
Releases: master, 9.5
Change-Id: I0eab8e6da67ca1c073847a1a4c6203f97778c4df
Reviewed-on: https://review.typo3.org/59117
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove deprecated code from EXT:taskcenter 46/59246/4
Wouter Wolters [Thu, 20 Dec 2018 20:04:03 +0000 (21:04 +0100)]
[!!!][TASK] Remove deprecated code from EXT:taskcenter

Resolves: #87249
Releases: master
Change-Id: Ibffaf40318977a069c1835439adc93e1bd3616ae
Reviewed-on: https://review.typo3.org/59246
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Show domains from Site configs in redirect picker 56/59256/5
Benni Mack [Fri, 21 Dec 2018 13:00:28 +0000 (14:00 +0100)]
[BUGFIX] Show domains from Site configs in redirect picker

The FormEngine sys_redirect value picker for "host" was built on
top of sys_domain, however the value picker should
include domains (hosts) from site configurations
as well.

Resolves: #87258
Releases: master, 9.5
Change-Id: I74bf5a8ce3bf91065b68269d6481eb89286585fa
Reviewed-on: https://review.typo3.org/59256
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix double namespace in test class 60/59260/3
Benni Mack [Fri, 21 Dec 2018 21:45:20 +0000 (22:45 +0100)]
[BUGFIX] Fix double namespace in test class

A wrong PHP namespace is used in a UnitDeprecated PHP test class.

The patch changes the path to the correct one.

Resolves: #87263
Releases: master, 9.5
Change-Id: Iadfc83cb00195b528264ac5f8e10a106be94847d
Reviewed-on: https://review.typo3.org/59260
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove deprecated code from various controllers 52/59252/4
Christian Kuhn [Thu, 20 Dec 2018 22:07:25 +0000 (23:07 +0100)]
[!!!][TASK] Remove deprecated code from various controllers

Drop deprecated properties and methods from various
backend controllers.

Resolves: #87253
Releases: master
Change-Id: I7a4bf179bffbdce4843cabf0efaa08a7a813808b
Reviewed-on: https://review.typo3.org/59252
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[!!!][TASK] Remove deprecated core authentication related code 45/59245/3
Christian Kuhn [Thu, 20 Dec 2018 19:30:55 +0000 (20:30 +0100)]
[!!!][TASK] Remove deprecated core authentication related code

Mostly removes code related to core authentication
classes.

Resolves: #87248
Releases: master
Change-Id: I711e1fae63fecabd1b1a51854698319112db2824
Reviewed-on: https://review.typo3.org/59245
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove deprecated Extbase-related code (Part 2) 49/59249/6
Alexander Schnitzler [Thu, 20 Dec 2018 21:18:11 +0000 (22:18 +0100)]
[!!!][TASK] Remove deprecated Extbase-related code (Part 2)

* public methods in ClassSchema
* public methods in ReflectionService
* public methods in ValidatorResolver
* public constants in ValidatorResolver
* class RawValidator

Releases: master
Resolves: #87254
Change-Id: I3523e56cfab25fb147e8ce07c143aad9a6e8a549
Reviewed-on: https://review.typo3.org/59249
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Exclude logger from serialize on save for scheduler task 37/59237/4
Joerg Boesche [Thu, 20 Dec 2018 10:57:32 +0000 (11:57 +0100)]
[BUGFIX] Exclude logger from serialize on save for scheduler task

Exclusion of the logger instance from the record during save to database.
Prevent hard-coded logfile paths in database record.
Set the logger at runtime if the task is executed.

Resolves: #86785
Releases: master, 9.5
Change-Id: I30cf258042a2ca6ec3e79a52dcf3a3849cfbe77d
Reviewed-on: https://review.typo3.org/59237
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Chris Müller <typo3@krue.ml>
Tested-by: Chris Müller <typo3@krue.ml>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove deprecated code from EXT:setup 48/59248/2
Wouter Wolters [Thu, 20 Dec 2018 20:36:50 +0000 (21:36 +0100)]
[!!!][TASK] Remove deprecated code from EXT:setup

Resolves: #87250
Releases: master
Change-Id: I72b85074e4e9b31f3bb72391f035d4aae8932d41
Reviewed-on: https://review.typo3.org/59248
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[!!!][TASK] Drop evaluation of @validate annotations 80/58880/5
Alexander Schnitzler [Sat, 10 Nov 2018 10:53:51 +0000 (11:53 +0100)]
[!!!][TASK] Drop evaluation of @validate annotations

@validate annotations in (Extbase) models and
controllers are no longer evaluated and should be
replaced with its doctrine annotation replacement.

Releases: master
Resolves: #86898
Change-Id: I6799f0e8e7a6d9661c59f27c2aad589d6a807658
Reviewed-on: https://review.typo3.org/58880
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[!!!][TASK] Remove deprecated global constants 44/59244/6
Christian Kuhn [Thu, 20 Dec 2018 18:09:34 +0000 (19:09 +0100)]
[!!!][TASK] Remove deprecated global constants

Drops most global constants marked for removal,
only PATH_site and PATH_thisScript are left, those
need special care.

Resolves: #87247
Releases: master
Change-Id: Id93f31df8abb44d9f4f1df836b49ff225741fb83
Reviewed-on: https://review.typo3.org/59244
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Drop evaluation of @transient annotations 84/58884/9
Alexander Schnitzler [Sat, 10 Nov 2018 15:05:49 +0000 (16:05 +0100)]
[!!!][TASK] Drop evaluation of @transient annotations

@transient will no longer exclude domain model properties from
the processing of the persistence layer

Releases: master
Resolves: #86905
Change-Id: I45684e335089f6706c12669ccf49669c1b9d3297
Reviewed-on: https://review.typo3.org/58884
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated Extbase-related code 41/59241/6
Benni Mack [Thu, 20 Dec 2018 13:17:42 +0000 (14:17 +0100)]
[!!!][TASK] Remove deprecated Extbase-related code

* Cli functionality
* annotations @cli @internal @flushesCaches
* config.tx_extbase.objects
* plugin.tx_%plugin%.objects

Resolves: #87246
Releases: master
Change-Id: Ic53699f5aa0219d418fe4e385157c90c2083dce8
Reviewed-on: https://review.typo3.org/59241
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated code from impexp extension 43/59243/3
Christian Kuhn [Thu, 20 Dec 2018 15:48:24 +0000 (16:48 +0100)]
[!!!][TASK] Remove deprecated code from impexp extension

Resolves: #87244
Releases: master
Change-Id: I85282bdddc61df62fad1234406b05b73923407be
Reviewed-on: https://review.typo3.org/59243
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Drop evaluation of @lazy annotations 83/58883/7
Alexander Schnitzler [Sat, 10 Nov 2018 15:00:58 +0000 (16:00 +0100)]
[!!!][TASK] Drop evaluation of @lazy annotations

Using the @lazy annotation will no longer trigger the lazy loading
of domain model properties.

Releases: master
Resolves: #86900
Change-Id: I630f702713f1e0a654ff61b9c3bc5792ba101e4e
Reviewed-on: https://review.typo3.org/58883
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Drop evaluation of @ignorevalidation annotations 86/58886/6
Alexander Schnitzler [Sat, 10 Nov 2018 15:25:15 +0000 (16:25 +0100)]
[!!!][TASK] Drop evaluation of @ignorevalidation annotations

@ignorevalidation will no longer ignore the triggering of validations

Releases: master
Resolves: #86901
Change-Id: Ifd98389fe948c7420852e7442fe4f5a8a703f1c7
Reviewed-on: https://review.typo3.org/58886
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Drop deprecated code from EditDocumentController 42/59242/4
Christian Kuhn [Thu, 20 Dec 2018 14:19:34 +0000 (15:19 +0100)]
[!!!][TASK] Drop deprecated code from EditDocumentController

Resolves: #87242
Releases: master
Change-Id: I29a7b417b3705aec3743692b70adbae97f6fbfe3
Reviewed-on: https://review.typo3.org/59242
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Drop evaluation of @cascade annotations 85/58885/6
Alexander Schnitzler [Sat, 10 Nov 2018 15:14:40 +0000 (16:14 +0100)]
[!!!][TASK] Drop evaluation of @cascade annotations

@cascade will no longer trigger cascading of actions in the
persistence layer

Releases: master
Resolves: #86906
Change-Id: I714ae2ad2050e2ebf87a5918a4bd35661bc43d48
Reviewed-on: https://review.typo3.org/58885
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove non-route variants for BE calls 38/59238/3
Benni Mack [Thu, 20 Dec 2018 12:10:09 +0000 (13:10 +0100)]
[!!!][TASK] Remove non-route variants for BE calls

Remove AjaxRequestHandler and the special
handling of '&M=...' query parameter in TYPO3
Backend.

Resolves: #87241
Releases: master
Change-Id: I1f02dc6eef6b1821e30df7d8dc85d16c1fc4d37f
Reviewed-on: https://review.typo3.org/59238
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Reimplement custom BE languages 68/59068/7
Guido Schmechel [Sun, 9 Dec 2018 11:12:25 +0000 (12:12 +0100)]
[BUGFIX] Reimplement custom BE languages

Because of a regression the backend does not load custom BE languages.
The loading order is changed so that custom languages are available
again.

Resolves: #87101
Releases: master, 9.5
Change-Id: I0530957abc49f775497d9644047cbb49ceffcda9
Reviewed-on: https://review.typo3.org/59068
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Drop evaluation of @inject annotations 82/58882/6
Alexander Schnitzler [Sat, 10 Nov 2018 14:47:35 +0000 (15:47 +0100)]
[!!!][TASK] Drop evaluation of @inject annotations

@inject will no longer trigger dependency injection

Releases: master
Resolves: #86899
Change-Id: Id440e94b71f62e7b2c396ec1c865ebd109026a04
Reviewed-on: https://review.typo3.org/58882
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[!!!][TASK] Remove last batch of old class aliases 39/59239/3
Christian Kuhn [Thu, 20 Dec 2018 12:08:38 +0000 (13:08 +0100)]
[!!!][TASK] Remove last batch of old class aliases

Extbase extension is the last core extension that
delivered class aliases. Drop them.

Resolves: #87240
Releases: master
Change-Id: I89074e9d32a4f9f639199edf12c2ebd71be2f8e4
Reviewed-on: https://review.typo3.org/59239
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Remove unused deprecation trait 36/59236/2
Christian Kuhn [Thu, 20 Dec 2018 10:52:48 +0000 (11:52 +0100)]
[BUGFIX] Remove unused deprecation trait

Resolves: #87239
Related: #87235
Releases: master
Change-Id: Idffa45715e19d71b0f08ff5885d665e0c6b44af8
Reviewed-on: https://review.typo3.org/59236
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Do not show error when copying a record was succesful 02/59202/3
Christoph Lehmann [Tue, 18 Dec 2018 22:23:52 +0000 (23:23 +0100)]
[TASK] Do not show error when copying a record was succesful

https://review.typo3.org/#/c/32356/ introduced the log message

The change was about skipping the direct copyRecord() call for
records that will be processed inside another copyRecord() call
for the record of the default language

Due to https://review.typo3.org/#/c/51070/ $overrideValues contains

['l10n_source' => 0]

When an element is copied inside an earlier copyRecord() call
the error log message is generated which leads to an error
flash message editors see when copying a page, but everything
(copying the records once) went fine.

A earlier call of copyRecord() can occur when using extension like
gridelements when copying a content element laying inside a
grid container element.

Resolves: #82032
Releases: master, 9.5, 8.7
Change-Id: I0d5be8e8920852a0e0c5a5ee93a67f9a6426e941
Reviewed-on: https://review.typo3.org/59202
Reviewed-by: Marcel Tams <marcel.tams@networkteam.com>
Tested-by: Marcel Tams <marcel.tams@networkteam.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Lange <lange@networkteam.com>
Tested-by: Christian Lange <lange@networkteam.com>
Reviewed-by: DANIEL Rémy <dogawaf@free.fr>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
9 months ago[!!!][TASK] Remove deprecated code from EXT:tstemplate 01/59201/8
Wouter Wolters [Tue, 18 Dec 2018 22:35:03 +0000 (23:35 +0100)]
[!!!][TASK] Remove deprecated code from EXT:tstemplate

Resolves: #87233
Releases: master
Change-Id: Ib5604ec4b46b2906565154274ba025a959ea102a
Reviewed-on: https://review.typo3.org/59201
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[!!!][TASK] Remove deprecated code related to TSFE 26/59226/7
Benni Mack [Wed, 19 Dec 2018 19:46:45 +0000 (20:46 +0100)]
[!!!][TASK] Remove deprecated code related to TSFE

The following code related to TSFE has been removed:

PHP classes:
* TYPO3\CMS\Core\PageTitle\AltPageTitleProvider
* TYPO3\CMS\Frontend\Page\ExternalPageUrlHandler
* TYPO3\CMS\Frontend\Page\PageGenerator
* TYPO3\CMS\Frontend\Page\EidUtility

PHP interfaces:
* TYPO3\CMS\Frontend\Http\UrlHandlerInterface

Methods that have been marked as protected
* tempPageCacheContent()
* realPageCacheContent()
* setPageCacheContent()
* clearPageCacheContent_pidList()
* setSysLastChanged()
* contentStrReplace()

Dropped TSFE methods
* mergingWithGetVars()
* connectToDB()
* initFEuser()
* checkAlternativeIdMethods()
* initializeBackendUser()
* getPageShortcut()
* pageUnavailableAndExit()
* pageNotFoundAndExit()
* checkPageUnavailableHandler()
* pageUnavailableHandler()
* pageNotFoundHandler()
* pageErrorHandler()
* makeCacheHash()
* initTemplate()
* handleDataSubmission()
* initializeRedirectUrlHandlers()
* redirectToExternalUrl()
* checkPageForMountpointRedirect()
* checkPageForShortcutRedirect()
* redirectToCurrentPage()
* processOutput()
* sendCacheHeaders()
* sendHttpHeadersDirectly()
* storeSessionData()
* previewInfo()
* hook_eofe()
* addTempContentHttpHeaders()
* setCSS()
* getUniqueId()
* readLLfile()
* getLLL()
* initLLvars()
* convPOSTCharset()
* convertCharsetRecursivelyToUtf8()
* domainNameMatchesCurrentRequest()
* getDomainDataForPid()
* getDomainNameForPid()

Dropped TSFE properties
* activeUrlHandlers
* page_cache_reg1
* siteScript
* loginUser
* gr_list
* beUserLogin
* workspacePreview
* ADMCMD_preview_BEUSER_uid
* showHiddenPage
* showHiddenRecords
* debug
* MP_defaults
* sys_language_uid
* sys_language_mode
* sys_language_content
* sys_language_contentOL
* altPageTitle
* lang

TSFE Properties now marked as protected
* loginAllowedInBranch
* loginAllowedInBranch_mode
* cacheTimeOutDefault
* cacheContentFlag
* cacheExpires
* isClientCachable
* no_cacheBeforePageGen
* tempContent
* pagesTSconfig
* pageCacheTags
* uniqueCounter
* uniqueString
* pageAccessFailureHistory

TSFE Method Signature changes
* calculateLinkVars now 1st parameter is required
* preparePageContentGeneration now 1st parameter is required
4th Parameter of TSFE->__construct() now unused

Removed TypoScript
* config.typolinkCheckRootline
* config.titleTagFunction
* config.USERUID_substToken
* config.USERNAME_substToken

Hooks
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['tslib_fe-PostProc']

Database fields:
* index_phash.data_page_reg1

Resolves: #87235
Releases: master
Change-Id: Id95bb0ccb30852fd115fb9da7754fa2e64374a41
Reviewed-on: https://review.typo3.org/59226
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated GeneralUtility functionality 30/59230/6
Christian Kuhn [Wed, 19 Dec 2018 21:23:42 +0000 (22:23 +0100)]
[!!!][TASK] Remove deprecated GeneralUtility functionality

Resolves: #87234
Releases: master
Change-Id: I07eb0387b8ad1921f715637a5a48581f3eaf9c42
Reviewed-on: https://review.typo3.org/59230
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove deprecated adminpanel/feedit code 05/59205/4
Benni Mack [Wed, 19 Dec 2018 08:59:28 +0000 (09:59 +0100)]
[!!!][TASK] Remove deprecated adminpanel/feedit code

The following previously deprecated classes/interfaces have been removed:

* TYPO3\CMS\Adminpanel\View\AdminPanelView
* TYPO3\CMS\Adminpanel\View\AdminPanelViewHookInterface
* TYPO3\CMS\Core\FrontendEditing\FrontendEditingController

The following methods have been removed:
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeAdminPanel()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->initializeFrontendEdit()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->isFrontendEditingActive()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->displayAdminPanel()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->isAdminPanelVisible()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->checkBackendAccessSettingsFromInitPhp()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extPageReadAccess()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extGetTreeList()
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extGetLL()

The following public properties have been removed
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extAdmEnabled
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->adminPanel
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->frontendEdit
* TYPO3\CMS\Backend\FrontendBackendUserAuthentication->extAdminConfig

The following PageTSconfig option has no effect anymore:
* TSFE.frontendEditingController

Resolves: #87231
Releases: master
Change-Id: I88cc3ac18077f054cc8895f5ccfb65291e94defa
Reviewed-on: https://review.typo3.org/59205
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove old fluid related class aliases 27/59227/4
Christian Kuhn [Wed, 19 Dec 2018 19:50:11 +0000 (20:50 +0100)]
[!!!][TASK] Remove old fluid related class aliases

Drops old fluid class aliases. Note most of them have
been deprecated with core v8 already.

Resolves: #87230
Releases: master
Change-Id: I509019be4e1df77bfeb94a7498a1ba795c128e86
Reviewed-on: https://review.typo3.org/59227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Require styleguide 10.0.1 28/59228/3
Christian Kuhn [Wed, 19 Dec 2018 20:17:18 +0000 (21:17 +0100)]
[TASK] Require styleguide 10.0.1

Styleguide used old fluid related class aliases
which is fixed with this raise.

composer require --dev typo3/cms-styleguide:~10.0.1

Change-Id: I77648c6c919f60866acec9bdaf4cefce437a074c
Resolves: #87232
Related: #87230
Releases: master
Reviewed-on: https://review.typo3.org/59228
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[!!!][TASK] Remove deprecated frontend-related hooks and include scripts 17/59217/7
Benni Mack [Wed, 19 Dec 2018 15:56:44 +0000 (16:56 +0100)]
[!!!][TASK] Remove deprecated frontend-related hooks and include scripts

The following hooks have been removed:
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['preBeUser']
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['checkAlternativeIdMethods-PostProc']
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['checkDataSubmission']
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['preprocessRequest']
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['connectToDB']
- $GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['hook_previewInfo']

The class EidRequestHandler has been removed.

eID targets cannot include a scriptpath anymore:
- $GLOBALS['TYPO3_CONF_VARS']['FE']['eID_include']['my_eID'] = 'EXT:benni/Scripts/download.php';

Instead, they must contain a target (callable, class/method, function).

The various hooks are still in place in deprecated methods within TSFE which will be removed
in the next patch. Also, now hardly usable PSR-15 middlewares will be cleaned up separately
as well.

Resolves: #87220
Releases: master
Change-Id: Ic54af83c97f2e6d2fba4346e382240d0fac6a2dc
Reviewed-on: https://review.typo3.org/59217
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[BUGFIX] Add checkDataSubmission hook to extension scanner 24/59224/2
Benjamin Franzke [Wed, 19 Dec 2018 18:59:19 +0000 (19:59 +0100)]
[BUGFIX] Add checkDataSubmission hook to extension scanner

This one slipped through in https://review.typo3.org/c/59217/
Also add it to the deprecation .rst file.

Releases: master, 9.5
Resolves: #87229
Related: #86279
Change-Id: Idc5a3d0cc05906938e134fd2b6cea367324a773a
Reviewed-on: https://review.typo3.org/59224
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove old class aliases from core extension 22/59222/3
Christian Kuhn [Wed, 19 Dec 2018 18:10:18 +0000 (19:10 +0100)]
[!!!][TASK] Remove old class aliases from core extension

Resolves: #87228
Releases: master
Change-Id: I400fa0bc7882b0ee366c6f923c8e21c30b30a5f6
Reviewed-on: https://review.typo3.org/59222
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[!!!][TASK] Remove deprecated migration for PackageStates.php v4 version 21/59221/2
Benjamin Franzke [Wed, 19 Dec 2018 15:33:27 +0000 (16:33 +0100)]
[!!!][TASK] Remove deprecated migration for PackageStates.php v4 version

This migration was deprecated during v8 phase in
https://review.typo3.org/46389 and then expanded to be removed in v10
during v9 deprecation removal. Remove this one now.

Releases: master
Resolves: #87226
Related: #73041
Change-Id: I1ffcf0c8f50e311d90e7be935ece30c50eb2e4b6
Reviewed-on: https://review.typo3.org/59221
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated cObj/stdWrap functionality 18/59218/3
Benni Mack [Wed, 19 Dec 2018 16:07:40 +0000 (17:07 +0100)]
[!!!][TASK] Remove deprecated cObj/stdWrap functionality

The following methods within cObj have been removed:
- enableFields()
- currentPageUrl()
- typolinkWrap()
- calcIntExplode()
- filelink()
- addParams()
- filelist()
- stdWrap_filelink()
- stdWrap_addParams()
- stdWrap_filelist()

The following TypoScript stdWrap properties are now removed:
- filelist
- filelink
- addParams

Resolves: #87221
Releases: master
Change-Id: I08ca55b0ac51412356fd40f34193f6b3869c3071
Reviewed-on: https://review.typo3.org/59218
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove several deprecated PHP classes 16/59216/4
Christian Kuhn [Wed, 19 Dec 2018 15:49:07 +0000 (16:49 +0100)]
[!!!][TASK] Remove several deprecated PHP classes

Various classes that have no huge dependencies to
other deprecated code are removed.

Resolves: #87219
Releases: master
Change-Id: I2eb6c56b379b50028fe166c20995ad61f16469fd
Reviewed-on: https://review.typo3.org/59216
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated class Package\DependencyResolver 12/59212/5
Benjamin Franzke [Wed, 19 Dec 2018 10:55:45 +0000 (11:55 +0100)]
[!!!][TASK] Remove deprecated class Package\DependencyResolver

Also remove deprecations that were introduced with the deprecation
of the DependencyResolver in https://review.typo3.org/55977

Removed classes:
  - TYPO3\CMS\Core\Package\DependencyResolver

Removed methods:
  - TYPO3\CMS\Core\Package\PackageManager->injectDependencyResolver()

Method signature changes:
  - TYPO3\CMS\Core\Package\PackageManager->__construct():
    First argument mandatory

Releases: master
Resolves: #87213
Change-Id: Icb1fb060387ec00e5c7aa4429620b0ee251463b8
Reviewed-on: https://review.typo3.org/59212
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove a series of old class aliases 13/59213/3
Christian Kuhn [Wed, 19 Dec 2018 14:27:43 +0000 (15:27 +0100)]
[!!!][TASK] Remove a series of old class aliases

Drop all "easy" cases of old class aliases, only
some bigger extensions are left for dedicated patches.

Resolves: #87217
Releases: master
Change-Id: I61eda47a02ab32430564edb063a5cbf59d560337
Reviewed-on: https://review.typo3.org/59213
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[!!!][TASK] Remove old recordList classes 15/59215/2
Christian Kuhn [Wed, 19 Dec 2018 14:57:46 +0000 (15:57 +0100)]
[!!!][TASK] Remove old recordList classes

Remove unused AbstractRecordList
and AbstractDatabaseRecordList.

Resolves: #87218
Releases: master
Change-Id: I20b7e1c469eb6bed4a2774d5c050fa7ef9407cbd
Reviewed-on: https://review.typo3.org/59215
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Update redefinition guard comments in SystemEnvironmentBuilder 14/59214/3
Benjamin Franzke [Wed, 19 Dec 2018 13:45:02 +0000 (14:45 +0100)]
[BUGFIX] Update redefinition guard comments in SystemEnvironmentBuilder

These constant redefintion guards were forgotten to be updated when
Bootstrap::getInstance() and the call to SystemEnvironmentBuilder::run()
in Bootstrap::baseSetup() were removed.

These guards are no longer necessary for regular execution as baseSetup()
does no longer (conditionally) invoke SystemEnvironmentBuilder::run()
(which was provided for deprecated and now removed bootstrapping code).

We do still leave the guards in, as they are needed in unit tests,
but update the comments.

Releases: master
Resolves: #87216
Related: #87202
Change-Id: I3b1c60ea32163d68b7f314b6539c54d8c048c323
Reviewed-on: https://review.typo3.org/59214
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated code from TemplateService 04/59204/5
Benni Mack [Wed, 19 Dec 2018 07:27:57 +0000 (08:27 +0100)]
[!!!][TASK] Remove deprecated code from TemplateService

The TemplateService class can now be reduced into smaller parts due
to deprecation removals.

Properties now marked as internal:
- absoluteRootLine
- matchAll
- nextLevel
- outermostRootlineIndexWithTemplate
- rootId
- rowSum
- sectionsMatch
- simulationHiddenOrTime
- sitetitle

Removed properties:
- allowedPaths
- debug
- fileCache
- frames
- MPmap
- whereClause

Methods now marked as protected:
- flattenSetup()
- mergeConstantsFromPageTSconfig()
- prependStaticExtra()
- processIncludes()
- substituteConstants()
- versionOL()

Removed public methods:
- getFileName()
- getFromMPmap()
- init()
- initMPmap_create()
- linkData()
- printTitle()

Resolves: #87207
Releases: master
Change-Id: I264a44ee00450cb9cef23aad365a2266bb7bfa70
Reviewed-on: https://review.typo3.org/59204
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Remove unused argument $entryPointLevel from Bootstrap 11/59211/2
Christian Kuhn [Wed, 19 Dec 2018 12:26:08 +0000 (13:26 +0100)]
[BUGFIX] Remove unused argument $entryPointLevel from Bootstrap

The argument is optional and can be removed without
further notice.

Resolves: #87212
Related: #87202
Releases: master
Change-Id: I667a091b84986111562a581c0bb22d29f624fd19
Reviewed-on: https://review.typo3.org/59211
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[!!!][TASK] Remove $response preparation in route dispatching 09/59209/4
Christian Kuhn [Wed, 19 Dec 2018 11:50:51 +0000 (12:50 +0100)]
[!!!][TASK] Remove $response preparation in route dispatching

Calling controllers with a prepared $response object is
dropped, together with the b/w compat feature
'simplifiedControllerActionDispatching'.

Resolves: #87211
Releases: master
Change-Id: Ia1cba4cc78e1cf8527f9c2a8b8f20655bc6af611
Reviewed-on: https://review.typo3.org/59209
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated module classes from backend 08/59208/3
Christian Kuhn [Wed, 19 Dec 2018 10:06:46 +0000 (11:06 +0100)]
[!!!][TASK] Remove deprecated module classes from backend

Removed classes:
TYPO3\CMS\Backend\Module\AbstractFunctionModule
TYPO3\CMS\Backend\Module\AbstractModule
TYPO3\CMS\Backend\Module\BaseScriptClass

Resolves: #87210
Releases: master
Change-Id: I56c92246e7b18fd87707e767f743fd4c84f043a1
Reviewed-on: https://review.typo3.org/59208
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Add acceptance test for Template and Sites creation 84/59184/8
Steffen Dietrich [Mon, 17 Dec 2018 16:23:38 +0000 (17:23 +0100)]
[TASK] Add acceptance test for Template and Sites creation

Extends the existing site configuration acceptance test
by adding a default FE ts snipped and verifying FE is
rendered.

Resolves: #87191
Releases: master, 9.5
Change-Id: I369980f2de240db9647550dad73a2923a1aa6371
Reviewed-on: https://review.typo3.org/59184
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated code from Bootstrap 96/59196/5
Benjamin Franzke [Tue, 18 Dec 2018 10:34:24 +0000 (11:34 +0100)]
[!!!][TASK] Remove deprecated code from Bootstrap

Remove code that is not needed due to the static bootstrap
and PSR-15 refactoring during v9 phase.

All deprecated methods and state is removed from the Bootstrap class,
which includes the Bootstrap instance itself. Bootstrap is provided as
statically invoked utility now.
The Bootstrap instance was deprecated implictly due to the deprecation
of getInstance() (combined with the protected constructor).
We therefore remove the constructor and all (now unused) class properties
and the method-chaining (which was only useful to reduce calls to the
getInstance() method).

Releases: master
Resolves: #87202
Change-Id: Ie97e824294a03d8de88430772fdab4adaf7e3f1f
Reviewed-on: https://review.typo3.org/59196
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[!!!][TASK] Remove deprecated $GLOBALS['TYPO3_GLOBALS_EXT'] 07/59207/2
Benjamin Franzke [Wed, 19 Dec 2018 09:48:48 +0000 (10:48 +0100)]
[!!!][TASK] Remove deprecated $GLOBALS['TYPO3_GLOBALS_EXT']

$GLOBALS['TYPO3_GLOBALS_EXT'] was deprecated in
https://review.typo3.org/58408 and is now removed together
with the internal helper classes LoadedExtensionsArray
and LoadedExtensionArrayElement which powered this array.

Releases: master
Resolves: #87209
Change-Id: Ic323f881b5d07aa70046becf837a2d1dda0d9400
Reviewed-on: https://review.typo3.org/59207
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Remove unused if in PasswordHashing 06/59206/2
Christian Kuhn [Wed, 19 Dec 2018 09:44:23 +0000 (10:44 +0100)]
[BUGFIX] Remove unused if in PasswordHashing

A useless if can be dropped since the deprecation
removals.

Resolves: #87208
Releases: master
Change-Id: Ib664a3d50fb4aeb7956606b054e46a0be84d1e92
Reviewed-on: https://review.typo3.org/59206
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated code from PageRepository 93/59193/7
Benni Mack [Tue, 18 Dec 2018 07:25:31 +0000 (08:25 +0100)]
[!!!][TASK] Remove deprecated code from PageRepository

The PageRepository class can now be reduced into smaller parts due
to deprecation removals.

Properties now marked as internal:
- sys_language_uid
- versioningWorkspaceId

Removed properties:
- versioningPreview
- workspaceCache
- error_getRootLine
- error_getRootLine_failPid

Removed public methods:
- getFirstWebPage()
- getDomainStartPage()
- getRootLine()
- getRecordsByField()
- deleteClause()
- checkWorkspaceAccess()
- getFileReferences()

Removed arguments from public methods:
- 4th argument of getRawRecord()

Special argument handling for public methods:
- getPageOverlay() second argument "-1" has to be "null" now
- getPagesOverlay() second argument "-1" has to be "null" now

Resolves: #87195
Releases: master
Change-Id: Iaf7d5e68054db0f9e78d8ea2fc0d8bb712bf3b74
Reviewed-on: https://review.typo3.org/59193
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated code from core Crypto/PasswordHashing 97/59197/6
Christian Kuhn [Tue, 18 Dec 2018 18:05:53 +0000 (19:05 +0100)]
[!!!][TASK] Remove deprecated code from core Crypto/PasswordHashing

Removed classes:
TYPO3\CMS\Core\Crypto\PasswordHashing\AbstractComposedSalt

Removed interfaces:
TYPO3\CMS\Core\Crypto\PasswordHashing\ComposedPasswordHashInterface
TYPO3\CMS\Core\Crypto\PasswordHashing\ExtensionManagerConfigurationUtility
TYPO3\CMS\Core\Crypto\PasswordHashing\SaltedPasswordService
TYPO3\CMS\Core\Crypto\PasswordHashing\SaltedPasswordsUtility

Removed class aliases:
TYPO3\CMS\Saltedpasswords\Salt\AbstractSalt
TYPO3\CMS\Saltedpasswords\Salt\AbstractComposedSalt
TYPO3\CMS\Saltedpasswords\Salt\Argon2iSalt
TYPO3\CMS\Saltedpasswords\Salt\BcryptSalt
TYPO3\CMS\Saltedpasswords\Salt\BlowfishSalt
TYPO3\CMS\Saltedpasswords\Salt\ComposedSaltInterface
TYPO3\CMS\Saltedpasswords\Salt\Md5Salt
TYPO3\CMS\Saltedpasswords\Salt\SaltFactory
TYPO3\CMS\Saltedpasswords\Salt\SaltInterface
TYPO3\CMS\Saltedpasswords\Salt\Pbkdf2Salt
TYPO3\CMS\Saltedpasswords\Salt\PhpassSalt
TYPO3\CMS\Saltedpasswords\SaltedPasswordsService
TYPO3\CMS\Saltedpasswords\Utility\ExensionManagerConfigurationUtility
TYPO3\CMS\Saltedpasswords\Utility\SaltedPasswordsUtility

Removed methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\Argon2iPasswordHash->getOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\Argon2iPasswordHash->setOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BcryptPasswordHash->getOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BcryptPasswordHash->setOptions()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishSalt->setMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->setMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getMinHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getSaltLength()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getSetting()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setMaxHashCount()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->setMinHashCount()

Protected methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->base64Encode()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->base64Decode()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->isValidSalt()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->base64Encode()

Removed static methods:
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::determineSaltingHashingMethod()
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::getSaltingInstance()
TYPO3\CMS\Core\Crypto\PasswordHashing\PasswordHashFactory::setPreferredHashingMethod()

Second method argument dropped:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash->getHashedPassword()
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash->getHashedPassword()

Ignored options:
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['ext/saltedpasswords']['saltMethods']

Dropped constants:
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\BlowfishPasswordHash::MIN_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Md5PasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\Pbkdf2PasswordHash::MIN_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::ITOA64
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::MAX_HASH_COUNT
TYPO3\CMS\Core\Crypto\PasswordHashing\PhpassPasswordHash::MIN_HASH_COUNT

Removed language file aliases:
EXT:saltedpasswords/Resources/Private/Language/locallang.xlf
EXT:saltedpasswords/Resources/Private/Language/locallang_em.xlf

Change-Id: Ia6a18209f104ca1abc6981508fb8b640ef2eb1a3
Resolves: #87203
Releases: master
Reviewed-on: https://review.typo3.org/59197
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[!!!][TASK] Remove deprecated methods from BackendUtility 03/59203/4
Christian Kuhn [Wed, 19 Dec 2018 00:24:48 +0000 (01:24 +0100)]
[!!!][TASK] Remove deprecated methods from BackendUtility

Removes most deprecated code from BackendUtility, except a method
that has bigger cross dependencies to other deprecated code.

Removed methods:
TYPO3\CMS\Backend\Utility\BackendUtility::deleteClause()
TYPO3\CMS\Backend\Utility\BackendUtility::getOriginalTranslationTable()
TYPO3\CMS\Backend\Utility\BackendUtility::getTCAtypes()
TYPO3\CMS\Backend\Utility\BackendUtility::storeHash()
TYPO3\CMS\Backend\Utility\BackendUtility::getHash()
TYPO3\CMS\Backend\Utility\BackendUtility::getListGroupNames()
TYPO3\CMS\Backend\Utility\BackendUtility::getModTSconfig()
TYPO3\CMS\Backend\Utility\BackendUtility::unsetMenuItems()
TYPO3\CMS\Backend\Utility\BackendUtility::getModuleUrl()
TYPO3\CMS\Backend\Utility\BackendUtility::getPidForModTSconfig()
TYPO3\CMS\Backend\Utility\BackendUtility::getDomainStartPage()
TYPO3\CMS\Backend\Utility\BackendUtility::shortcutExists()

Method signatures:
TYPO3\CMS\Backend\Utility\BackendUtility::getPagesTSconfig() - Second and third argument dropped

Other notes:
Overriding page TSconfig on user TSconfig level with the 'mod.' prefix
is dropped, used 'page.mod' instead.

Resolves: #87206
Releases: master
Change-Id: Ib4102bfc24a99a22891deb46d4b1bb227ffd3936
Reviewed-on: https://review.typo3.org/59203
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[!!!][TASK] Remove deprecated PHP classes from EXT:workspaces 98/59198/5
Wouter Wolters [Tue, 18 Dec 2018 21:38:58 +0000 (22:38 +0100)]
[!!!][TASK] Remove deprecated PHP classes from EXT:workspaces

Resolves: #87204
Releases: master
Change-Id: If697a2761c6c0eb42848c45dd17373d0e1dea5da
Reviewed-on: https://review.typo3.org/59198
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Typo 'boostrap' should be 'bootstrap' 99/59199/2
Christian Kuhn [Tue, 18 Dec 2018 21:45:17 +0000 (22:45 +0100)]
[TASK] Typo 'boostrap' should be 'bootstrap'

Resolves: #87205
Releases: master, 9.5
Change-Id: Idb22d2178bbd20982d4876b5dff45b06dea4100d
Reviewed-on: https://review.typo3.org/59199
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[!!!][TASK] Remove deprecated PHP classes from EXT:core 95/59195/5
Benni Mack [Tue, 18 Dec 2018 17:27:21 +0000 (18:27 +0100)]
[!!!][TASK] Remove deprecated PHP classes from EXT:core

The following previously deprecated PHP classes are now removed:
- TYPO3\CMS\Core\Encoder\JavaScriptEncoder
- TYPO3\CMS\Core\Resources\Utility\BackendUtility
- TYPO3\CMS\Core\Utility\ClientUtility
- TYPO3\CMS\Core\Utility\PhpOptionsUtility

Resolves: #87201
Releases: master
Change-Id: I0b1896692ebf1f15948a9a3661fdc10ab6f019ff
Reviewed-on: https://review.typo3.org/59195
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[!!!][TASK] Remove deprecated code from charset converter 90/59190/6
Benni Mack [Tue, 18 Dec 2018 06:30:00 +0000 (07:30 +0100)]
[!!!][TASK] Remove deprecated code from charset converter

The CharsetConverter class can now be reduced into smaller parts due
to deprecation removals.

Properties now marked as internal:
- parsedCharsets
- noCharByteVal
- toASCII
- twoByteSets
- eucBasedSets

Removed properties:
- synonyms

Removed public methods:
- parse_charset
- convArray
- utf8_to_entities
- entities_to_utf8
- crop
- convCaseFirst
- utf8_char2byte_pos

Removed arguments from public methods:
- 4th argument $useEntityForNoChar of conv

Resolves: #87194
Releases: master
Change-Id: I7ec967a076e9c43f62d95f1912574d3784b924d1
Reviewed-on: https://review.typo3.org/59190
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Do not try to delete already remove file 86/59186/2
Helmut Hummel [Mon, 17 Dec 2018 21:33:23 +0000 (22:33 +0100)]
[BUGFIX] Do not try to delete already remove file

When using the FAL API to add a file to a folder,
the local file is deleted by default already.

Thus the attempt to remove the file again results in a warning.

Therefore remove the obsolete unlink to avoid the warning.

Resolves: #87192
Releases: 8.7, 9.5, master
Change-Id: I23f3192e2760cd705429337464c8a5506cf41205
Reviewed-on: https://review.typo3.org/59186
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Streamline UX for File Upload module 75/59175/2
Benni Mack [Mon, 17 Dec 2018 08:08:40 +0000 (09:08 +0100)]
[BUGFIX] Streamline UX for File Upload module

When using the file upload module (called via File list), the dialog uses
non-bootstrap classes from historical times back in the day.

Using proper HTML makes the view look more like the rest of
TYPO3 Backend.

Resolves: #87178
Releases: master, 9.5
Change-Id: I4d6a4c8f96414d5fb776270db6ef8aa677e788b7
Reviewed-on: https://review.typo3.org/59175
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Add missing use statement in CObjectViewHelper 85/59185/3
Georg Ringer [Mon, 17 Dec 2018 18:53:49 +0000 (19:53 +0100)]
[BUGFIX] Add missing use statement in CObjectViewHelper

The use statement for TypoScriptFrontendController is added.

Resolves: #87186
Releases: master, 9.5
Change-Id: I2b758b3ac9bcd4002844160614ee1a9c7bc72585
Reviewed-on: https://review.typo3.org/59185
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Do not depend on global TSFE for link generation 36/59036/6
Benni Mack [Wed, 5 Dec 2018 10:41:42 +0000 (11:41 +0100)]
[BUGFIX] Do not depend on global TSFE for link generation

Handing in the dependency of TSFE into
AbstractLinkBuilder allows to use a custom TSFE
object, when working within middlewares (e.g. Redirects)
thus, not depending on global state directly.

As a drive-by-fix, using AbstractTypolinkBuilder now does not
generate a global TSFE anymore, which can have ugly side-effects.

Tests are now simplified because the original constructor can be
called directly instead of relying on $GLOBALS[TSFE].

Resolves: #87143
Releases: master, 9.5
Change-Id: I77f2da501d1a78f0579626ebb50ef47a0026f1f7
Reviewed-on: https://review.typo3.org/59036
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[TASK] Streamline dependencies in package.json 74/59174/3
Benni Mack [Mon, 17 Dec 2018 07:49:12 +0000 (08:49 +0100)]
[TASK] Streamline dependencies in package.json

Several changes to Build/package.json are
adapted:
- define compatible node/yarn versions
- adapt version and URL to typo3.org

Resolves: #87177
Releases: master, 9.5, 8.7
Change-Id: Ie812cd69913e2969dc88db8e8c52edbb6d482243
Reviewed-on: https://review.typo3.org/59174
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Matthias Stegmann <matthias.stegmann@b13.de>
Tested-by: Matthias Stegmann <matthias.stegmann@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Mark form as changed after using the image cropper 66/59166/3
Andreas Fernandez [Sun, 16 Dec 2018 11:24:45 +0000 (12:24 +0100)]
[BUGFIX] Mark form as changed after using the image cropper

The image cropper now marks the form as "changed" after saving new
cropping information.

Resolves: #86998
Releases: master, 9.5, 8.7
Change-Id: Ia6a6abeb88b1d9a590e76b50890ebcbac16f7472
Reviewed-on: https://review.typo3.org/59166
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] bamboo sends nightly build messages to intercept 68/59168/2
Christian Kuhn [Sun, 16 Dec 2018 14:46:54 +0000 (15:46 +0100)]
[TASK] bamboo sends nightly build messages to intercept

Resolves: #87171
Releases: master, 9.5, 8.7
Change-Id: Ia71eb5ce2824ff3c39dbc526ec3a3d93b4990eca
Reviewed-on: https://review.typo3.org/59168
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Remove COMPOSER_ROOT_VERSION from bamboo testing 65/59165/2
Christian Kuhn [Sat, 15 Dec 2018 12:14:10 +0000 (13:14 +0100)]
[TASK] Remove COMPOSER_ROOT_VERSION from bamboo testing

With latest changes in master and helper repositories, we do
not need the COMPOSER_ROOT_VERSION setting in tests anymore.
Remove that to have one detail less to maintain.

Resolves: #87170
Releases: master
Change-Id: Iea54bb6f17d0b08b4b248c40ad60691aa5cb0cb3
Reviewed-on: https://review.typo3.org/59165
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] composer update without progress in bamboo 63/59163/3
Christian Kuhn [Fri, 14 Dec 2018 20:05:18 +0000 (21:05 +0100)]
[TASK] composer update without progress in bamboo

To prevent garbled output in test logs, composer update
commands add --no-progress option.

Resolves: #87169
Releases: master, 9.5
Change-Id: I89f27fbf3fea44216f5a01fc3be20f6614dbe8d0
Reviewed-on: https://review.typo3.org/59163
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Disable ext:introduction installer ac test 62/59162/3
Christian Kuhn [Fri, 14 Dec 2018 19:42:10 +0000 (20:42 +0100)]
[TASK] Disable ext:introduction installer ac test

Core v10 compatible releases of ext:introduction and
ext:bootstrap_package will take time until the other day.
To not disable all install related tests, the
ext:introduction related ac tests are skipped for master
for the time being.

Resolves: #87168
Releases: master
Change-Id: I498a9962beca9b9d5e87f7c19fd02ea72db961ac
Reviewed-on: https://review.typo3.org/59162
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Update typo3/cms-styleguide from 9.2.2 to 10.0.0 61/59161/3
Christian Kuhn [Fri, 14 Dec 2018 18:35:56 +0000 (19:35 +0100)]
[TASK] Update typo3/cms-styleguide from 9.2.2 to 10.0.0

A first v10 core compatible styleguide

composer require --dev typo3/cms-styleguide:~10.0.0

Change-Id: I1c9ceb172c72cd52382e090f65c0e7a6a9914b03
Resolves: #87167
Releases: master
Reviewed-on: https://review.typo3.org/59161
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Update typo3/testing-framework from 4.11.1 to 5.0.0 58/59158/3
Christian Kuhn [Fri, 14 Dec 2018 17:03:09 +0000 (18:03 +0100)]
[TASK] Update typo3/testing-framework from 4.11.1 to 5.0.0

Version 5.0.0 of typo3/testing-framework brings core v10
compatibility. This fixes a 'requirements could not be resolved'
message from composer for core master branch.

composer require --dev typo3/testing-framework:~5.0.0

Resolves: #87164
Releases: master
Change-Id: I3dab9b83d872545eff71705a3f4da2a73c40e0da
Reviewed-on: https://review.typo3.org/59158
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Update TYPO3 version to 10.0.0-dev 50/59150/4
Benni Mack [Fri, 14 Dec 2018 08:58:05 +0000 (09:58 +0100)]
[TASK] Update TYPO3 version to 10.0.0-dev

In order to distinguish between v10-dev / dev-master,
and 9.5, all dependencies are updated to v10.0.0-dev.

For ext_emconf.php the fixed version 10.0.0 is used
as in all other branches.

Resolves: #87159
Releases: master
Change-Id: Ie1f135663527f8c7d1654e085b874d699b677529
Reviewed-on: https://review.typo3.org/59150
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Update URL to use HTTPS 28/59128/2
Ben Abbott [Wed, 12 Dec 2018 22:29:21 +0000 (23:29 +0100)]
[TASK] Update URL to use HTTPS

Releases: master
Resolves: #87140
Change-Id: I567b92746e26043b50f9cb735d89aa02f4ccda00
Reviewed-on: https://review.typo3.org/59128
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Set TYPO3 version to 9.5.4-dev 45/59145/3
Oliver Hader [Fri, 14 Dec 2018 07:29:45 +0000 (08:29 +0100)]
[TASK] Set TYPO3 version to 9.5.4-dev

Change-Id: I99d51f3836de8d062bc5503bcc58e05cdfacb83c
Reviewed-on: https://review.typo3.org/59145
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[RELEASE] Release of TYPO3 9.5.3 44/59144/2 v9.5.3
Oliver Hader [Fri, 14 Dec 2018 07:28:19 +0000 (08:28 +0100)]
[RELEASE] Release of TYPO3 9.5.3

Change-Id: Iee75e14be97ac5018cedf4f7f94664d8d4fe43f0
Reviewed-on: https://review.typo3.org/59144
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[DOC] Add ChangeLog index of 9.5.x 24/59124/3
Sybille Peters [Wed, 12 Dec 2018 18:17:18 +0000 (19:17 +0100)]
[DOC] Add ChangeLog index of 9.5.x

In order to get a rendered list of changes since the release of 9.5.0 an
additional index file is needed for the 9.5.x changes.

Resolves: #87135
Releases: master
Change-Id: I14713eace6493220852aea55ae431b1c4182ee80
Reviewed-on: https://review.typo3.org/59124
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix positioning of arrows in Element Browser 36/59136/2
Andreas Fernandez [Thu, 13 Dec 2018 16:18:09 +0000 (17:18 +0100)]
[BUGFIX] Fix positioning of arrows in Element Browser

The positioning of the collapse/expand arrows is changed to fix the break
in trees with very deep nesting.

Resolves: #86790
Releases: master, 8.7
Change-Id: Ie1a916da8220468c6fbb4034c1668675f379f588
Reviewed-on: https://review.typo3.org/59136
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Properly separate markup for modal windows in extension manager 35/59135/4
Oliver Hader [Thu, 13 Dec 2018 15:41:12 +0000 (16:41 +0100)]
[BUGFIX] Properly separate markup for modal windows in extension manager

Due to recent security releases and fixes against cross-site scripting
in central modal window component, templates are separated in order to
distinguish between (secure) HTML and attribute or text nodes.

Resolves: #87146
Releases: master, 8.7
Change-Id: I1264cbe9005e54d1fe30eaba23efbbad07937cb1
Reviewed-on: https://review.typo3.org/59135
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix HTML in modal of OnlineMedia.ts 20/59120/10
Georg Ringer [Tue, 11 Dec 2018 19:33:18 +0000 (20:33 +0100)]
[BUGFIX] Fix HTML in modal of OnlineMedia.ts

Allows to call the OnlineMedia modal box again.

This change also adapts the buttons within
a Modal to be text-only.
Resolves: #87144
Releases: master, 8.7
Change-Id: Id08356aad3eb319c59af1411a14131715c8159d0
Reviewed-on: https://review.typo3.org/59120
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix HTML in drag-title of PageTreeDragDrop.js 21/59121/4
Stefan Neufeind [Tue, 11 Dec 2018 20:56:41 +0000 (21:56 +0100)]
[BUGFIX] Fix HTML in drag-title of PageTreeDragDrop.js

Resolves: #87145
Releases: master
Change-Id: Ie3abd71840ca8fbd48150ae2b4f34efc5273ce63
Reviewed-on: https://review.typo3.org/59121
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] getTreeList inserts duplicate keys in cache_treelist 27/59127/6
Alexander Schnitzler [Wed, 12 Dec 2018 21:53:07 +0000 (22:53 +0100)]
[BUGFIX] getTreeList inserts duplicate keys in cache_treelist

Unfortunately https://review.typo3.org/58951/ did not actually
solve issues #86028 and #86491 for good.

There are two issues concerning the former approach:

1) The expiration time of all created caches was 0, which resulted
   in a permanent creation and deletion of cache entries. This
   behaviour cannot be called caching.

2) Number 1) increases the chance for race conditions where several
   parallel requests tried to create the same cache entry.

To fix this, the check for an existing cache entry will be reverted
to behave like before the regression, i.e. cache entries with an
expiration timestamp of 0 are considered valid again.

Also, new caches are created within a transaction, which prevents
duplicate key errors.

Releases: master, 8.7
Resolves: #87139
Change-Id: If9470f6e0f875c0ec4fe3c092c9bd0dfc059de2d
Reviewed-on: https://review.typo3.org/59127
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Revert bugfix Remove surrounding &nsbp; in the tables with ol or ul in CKEditor 37/59137/2
Benni Mack [Thu, 13 Dec 2018 16:35:50 +0000 (17:35 +0100)]
[BUGFIX] Revert bugfix Remove surrounding &nsbp; in the tables with ol or ul in CKEditor

This reverts commit c23b1e1970d44cb3fc836db697650be568788218
as now frontend rendering is different from 8.7.19 and 8.7.20.

Change-Id: Ia640ed3eda1619b0a34b5cd6afd07a665e372792
Resolves: #86819
Reverts: #83795
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/59137
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Do not rewind Generator in DebuggerUtility::var_dump() 32/59132/4
Mathias Brodala [Thu, 13 Dec 2018 14:21:15 +0000 (15:21 +0100)]
[BUGFIX] Do not rewind Generator in DebuggerUtility::var_dump()

Resolves: #87149
Releases: master, 8.7
Change-Id: I8cf2cfab94634276a67fd3d0dd36215c12ae5490
Reviewed-on: https://review.typo3.org/59132
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Ralf Merz <mail@merzilla.de>
Tested-by: Ralf Merz <mail@merzilla.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
9 months ago[TASK] Silence composer install progress in bamboo 25/59125/2
Christian Kuhn [Wed, 12 Dec 2018 19:43:07 +0000 (20:43 +0100)]
[TASK] Silence composer install progress in bamboo

Resolves: #87136
Releases: master, 8.7
Change-Id: Idbac64bf44b8f79ccd8a169f4abade462873e17d
Reviewed-on: https://review.typo3.org/59125
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Allow custom namespace in ExtbasePluginEnhancer 52/58952/3
Benni Mack [Mon, 26 Nov 2018 14:46:27 +0000 (15:46 +0100)]
[BUGFIX] Allow custom namespace in ExtbasePluginEnhancer

In Extbase, it is possible to configure a custom namespace for
plugin arguments:

plugin.tx_bennimack.view.pluginNamespace = bmack

This is now also respected in the Extbase Plugin Enhancer by omitting
"extension" and "plugin" properties and just using the "namespace"
property.

Resolves: #87005
Releases: master
Change-Id: I19c6338ec0d103837a5c5217ad7ba6643b6b6c54
Reviewed-on: https://review.typo3.org/58952
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Aimeos <aimeos@aimeos.org>
Tested-by: Aimeos <aimeos@aimeos.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Remove @ in doc comment of TypoScriptParser 74/59074/3
Georg Ringer [Mon, 10 Dec 2018 11:17:57 +0000 (12:17 +0100)]
[BUGFIX] Remove @ in doc comment of TypoScriptParser

To avoid exceptions by the Doctrine annotations parser, the @ character
is removed from the doc comment.

Resolves: #87115
Releases: master
Change-Id: I779374e2b9894272087153860de525fa0ce02712
Reviewed-on: https://review.typo3.org/59074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Add filter for be_users and be_groups 70/59070/4
Guido Schmechel [Sun, 9 Dec 2018 20:26:34 +0000 (21:26 +0100)]
[TASK] Add filter for be_users and be_groups

Add textfield filter for select fields from type
"selectMultipleSideBySide" for system tables.

Affected system tables: be_groups, be_users

Resolves: #87112
Releases: master, 8.7
Change-Id: Iba8b837a9fc5f2ec64be7e5ad313b454c4373feb
Reviewed-on: https://review.typo3.org/59070
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Set TYPO3 version to 9.5.3-dev 16/59116/2
Oliver Hader [Tue, 11 Dec 2018 12:43:54 +0000 (13:43 +0100)]
[TASK] Set TYPO3 version to 9.5.3-dev

Change-Id: If92f54c5a28edba2dc330ca8e32e5dcfda817f6f
Reviewed-on: https://review.typo3.org/59116
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[RELEASE] Release of TYPO3 9.5.2 15/59115/2 v9.5.2
Oliver Hader [Tue, 11 Dec 2018 12:42:51 +0000 (13:42 +0100)]
[RELEASE] Release of TYPO3 9.5.2

Change-Id: Ib5214342439fd510cfd599d9880b1612ff9b4cc1
Reviewed-on: https://review.typo3.org/59115
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>