Packages/TYPO3.CMS.git
11 months ago[BUGFIX] Prevent endless loop in recycler folder detection 85/56985/3
Alexander Stehlik [Wed, 16 May 2018 21:16:22 +0000 (23:16 +0200)]
[BUGFIX] Prevent endless loop in recycler folder detection

Compare folder identifiers instead of folder objects because
objects pointing to the same folder might still be different
object instances.

Change-Id: I78e21b9e68fbaae245d12ac4efb96312b246a847
Releases: master, 8.7
Resolves: #85019
Reviewed-on: https://review.typo3.org/56985
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Skip adding child elements if a nested form element is unknown 73/56773/8
Ralf Zimmermann [Sat, 21 Apr 2018 08:06:37 +0000 (10:06 +0200)]
[BUGFIX] Skip adding child elements if a nested form element is unknown

Skip adding child elements within the form factory if a nested form
element is unknown.

Resolves: #84833
Releases: master, 8.7
Change-Id: I1cbb87b4c460bd45b58aa6bcca27a88c61a7e92f
Reviewed-on: https://review.typo3.org/56773
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
11 months ago[TASK] Improve form documentation 97/56997/4
Björn Jacob [Thu, 17 May 2018 15:27:55 +0000 (17:27 +0200)]
[TASK] Improve form documentation

* introduce new role for inline YAML code styles
* fix some internal and external links

Resolves: #85037
Releases: master, 8.7
Change-Id: Ie5581bcc911914c49511ff86c5679f04c45c9f00
Reviewed-on: https://review.typo3.org/56997
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
11 months ago[TASK] Improved form editor hints and validations 81/56981/7
Daniela Pohl [Thu, 17 May 2018 14:31:38 +0000 (16:31 +0200)]
[TASK] Improved form editor hints and validations

- improved margin between field and hint for "special form" element
- styled custom error message hint -> this also applies for
  "single select" element : "inactive option"
- fixed validator and finisher margins
- styled hints for required textareas

Resolves: #82339
Releases: master
Change-Id: I3cd215eb967ccd6f0901a72675513a2619521d11
Reviewed-on: https://review.typo3.org/56981
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
11 months ago[TASK] Make honeypot field accessible 92/56992/5
Björn Jacob [Thu, 17 May 2018 11:35:51 +0000 (13:35 +0200)]
[TASK] Make honeypot field accessible

The honeypot field now passes the accessibility tests WCAG 2.0 (tested
with Google Lighthouse).

Instead of inserting a label tag or a title attribute - which would be
counterproductive by revealing the purpose of the honeypot - the patch
adds an aria-hidden attribute.

Resolves: #75591
Releases: master, 8.7
Change-Id: Ie4b0b7a245f5c0edf3e01ece60dcb638b2f9bdc1
Reviewed-on: https://review.typo3.org/56992
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
11 months ago[TASK] Document 'defaultValue' handling of form 91/56991/4
Björn Jacob [Thu, 17 May 2018 10:58:52 +0000 (12:58 +0200)]
[TASK] Document 'defaultValue' handling of form

The form framework supports setting a 'defaultValue' for most
of the form elements. This patch adds some information about
this setting and outlines the difference to the 'prependOptionValue'
setting.

Resolves: #82422
Releases: master, 8.7
Change-Id: Ic3bbe76ebe69ac0655e11ba501d62ee19b2d143f
Reviewed-on: https://review.typo3.org/56991
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Add missing docs for youtube no-cookie domain change 86/56986/4
Mathias Brodala [Thu, 17 May 2018 07:13:20 +0000 (09:13 +0200)]
[BUGFIX] Add missing docs for youtube no-cookie domain change

The doc file was only added for v7, it must also be added to master
and v8.

Resolves: #85029
Related: #84843
Releases: master, 8.7
Change-Id: I2e372eae6bc90a0da0e441237b087b98319a183e
Reviewed-on: https://review.typo3.org/56986
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
11 months ago[TASK] Remove saltedpasswords FE.enabled 79/56979/6
Christian Kuhn [Wed, 16 May 2018 14:29:38 +0000 (16:29 +0200)]
[TASK] Remove saltedpasswords FE.enabled

Manually configuring clear-text password storage in TYPO3 for
frontend users by explicitly setting the ext:saltedpasswords
extension configuration "FE.enabled = 0" has been a bad idea
for a very long time already. The feature has been dropped
for backend users in core v6.2 and is now finally dropped
for frontend users with this patch, too.
No third party service must rely on clear-text password storing
in 2018 anymore, the TYPO3 authentication services provide
an API to process credentials upon user login for authentication
and authorisation purposes.

Resolves: #85027
Related: #85026
Releases: master
Change-Id: I600f598e969ac99a83f3b57362b251b48116fd58
Reviewed-on: https://review.typo3.org/56979
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Keep RecordListController->modTSconfig public 87/56987/2
Christian Kuhn [Thu, 17 May 2018 07:29:20 +0000 (09:29 +0200)]
[BUGFIX] Keep RecordListController->modTSconfig public

For now, we have to keep property modTSconfig public in
RecordListController since it is used from DatabaseRecordList
via infamous $GLOBALS['SOBE'] and otherwise shows deprecation
notices in list module :(

Resolves: #85030
Related: #85016
Releases: master
Change-Id: I40bdd54a89e2282d8403b633fb08c505b214c338
Reviewed-on: https://review.typo3.org/56987
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[BUGFIX] ActionController must not register superfluous validators 01/56901/6
Alexander Schnitzler [Wed, 9 May 2018 13:43:36 +0000 (15:43 +0200)]
[BUGFIX] ActionController must not register superfluous validators

\TYPO3\CMS\Extbase\Mvc\Controller\ActionController::initializeActionMethodValidators
registers a superfluous property validator for simple types. As these
kinds of validators are added through method getBaseValidatorConjunction,
the superfluous registration is removed.

Releases: master
Resolves: #84953
Change-Id: I02fe7863b9014aa6072653d536dfeed67a01deda
Reviewed-on: https://review.typo3.org/56901
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Set opt-in for override checkbox in TCA input elements 86/56486/5
Tim Schreiner [Thu, 29 Mar 2018 21:21:40 +0000 (23:21 +0200)]
[BUGFIX] Set opt-in for override checkbox in TCA input elements

When useOrOverridePlaceholder mode is used for TCA input type,
use opt-in for the checkbox when placeholder is empty.

In some cases, the placeholder can be empty. Especially when the
placeholder uses data from another field. When information is added
to the corresponding field, the input field does not take this in account
because the override checkbox is set by default.

This can lead to problems for title and alternative fields in the
sys_file_metadata table. When adding a file reference and setting the
title or alternative field afterwards in the original file, the reference
is still using the empty override from file reference.

Resolves: #84563
Releases: master, 8.7
Change-Id: I84a37d55a48464b6249fc8bcee405a7cd909016a
Reviewed-on: https://review.typo3.org/56486
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Tested-by: Alexander Stehlik <alexander.stehlik@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[TASK] Add clarification regarding honeypot and caching 83/56983/4
Björn Jacob [Wed, 16 May 2018 17:30:01 +0000 (19:30 +0200)]
[TASK] Add clarification regarding honeypot and caching

This patch adds some documentation regarding the automatic
inclusion of the honeypot and (static) site caching.

Resolves: #83212
Releases: master, 8.7
Change-Id: I9e7b56a8e515172f6a91274512db13488b41eacb
Reviewed-on: https://review.typo3.org/56983
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
11 months ago[FEATURE] Backend ViewHelpers for edit creation and editing 34/56934/23
Anja [Fri, 11 May 2018 14:37:30 +0000 (16:37 +0200)]
[FEATURE] Backend ViewHelpers for edit creation and editing

Provides Edit- and NewRecord[Link|Uri]ViewHelpers to be used
in all places of the backend, also for extensions.

Remove four dedicated classes from system extensions, that got
replaced with the new implementations.

Also: composer update typo3/testing-framework

Resolves: #84983
Releases: master
Change-Id: I7fc03db101d2f73b63b24e4175d2e02aafa06e95
Reviewed-on: https://review.typo3.org/56934
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[!!!][TASK] Make localization wizard independent of colPos 13/56813/24
Andreas Fernandez [Wed, 25 Apr 2018 17:40:15 +0000 (19:40 +0200)]
[!!!][TASK] Make localization wizard independent of colPos

The localization wizard in the page module offers now a global translate
action per page only. With this change, a user isn't anymore able to
translate content on column basis.

This streamlines the localization process as it lowers the risk of
creating broken localization setups (a.k.a "mixed mode") and it will
simplify the upcoming "Change mode" wizard that enables to switch
between "Free" and "Connected" modes.

Resolves: #84877
Releases: master
Change-Id: Ibfd4641c5a8d3622c86b5a8657af00b2b3122503
Reviewed-on: https://review.typo3.org/56813
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
11 months ago[BUGFIX] getTreeList must return comma-separated list 39/56139/12
Guido Schmechel [Tue, 13 Mar 2018 20:22:03 +0000 (21:22 +0100)]
[BUGFIX] getTreeList must return comma-separated list

While retrieving the list with begin as argument for a
recursive call, getTreeList builds the comma-separated list
correctly.

Resolves: #83328
Releases: master, 8.7, 7.6
Change-Id: I643477dd5c0cbfb67532dd96eb0b479e0cb532b8
Reviewed-on: https://review.typo3.org/56139
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
11 months ago[TASK] Add documentation for DatePicker formats 78/56978/6
Björn Jacob [Wed, 16 May 2018 15:06:16 +0000 (17:06 +0200)]
[TASK] Add documentation for DatePicker formats

This patch adds some documentation for the DatePicker
form element and the available date formats.

Resolves: #82508
Releases: master, 8.7
Change-Id: I1277c024112633ec7e38f4c8cbe30efb97375ce3
Reviewed-on: https://review.typo3.org/56978
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
11 months ago[TASK] Add functional tests for QueryGeneratorTest 74/56974/7
Alexander Schnitzler [Wed, 16 May 2018 10:21:30 +0000 (12:21 +0200)]
[TASK] Add functional tests for QueryGeneratorTest

Releases: master
Resolves: #85024
Change-Id: I623bff02e95056422c1faf859a7d34740ba6b60f
Reviewed-on: https://review.typo3.org/56974
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
11 months ago[TASK] Remove saltedpasswords bulk update task 77/56977/5
Christian Kuhn [Wed, 16 May 2018 09:45:09 +0000 (11:45 +0200)]
[TASK] Remove saltedpasswords bulk update task

This patch is one step into merging the salted passwords
extension code into the core extension, starting with removing
obsolete stuff: The bulk update task is a use-once-throw-away
task aimed to help upgrading systems older than 10 years.
It is removed now. The patch includes an extensive
important ReST file explaining details and alternatives.

Change-Id: I2e9064438e0ac257e95bb0768860f587d8e29375
Resolves: #85022
Releases: master
Reviewed-on: https://review.typo3.org/56977
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[TASK] Streamline TSconfig API 68/56968/7
Christian Kuhn [Tue, 15 May 2018 12:25:27 +0000 (14:25 +0200)]
[TASK] Streamline TSconfig API

Final patch to de-mess the user / page TSconfig related API.

Page TSconfig can be overriden in user TSconfig by prefixing the
path with 'page.' in user TSconfig. However, method
BackendUtility::getModTSconfig() violated this principle and
had a special merge strategy that allowed ommitting the 'page.'
prefix. This has been marked as deprecated in the TSconfig docs for
various years and has been lately removed in the docs altogether,
but the code still existed.
The patch moves this merge into BackendUtility::getPagesTSconfig()
and properly deprecates this case. Usages of getModTSconfig() are
changed to use getPagesTSconfig() directly, dropping the artificial
'properties' and 'value' sub arrays and omitting some rather expensive
string operations at the same time.
This obsoletes getModTSconfig() and a couple of related methods.

Additionally, BackendUserAuthentication->getTSConfig() has been
abused frequently to operate on different arrays than it's own userTS.
Those usages are dropped with the patch. Handing over arguments to
getTSConfig() is now deprecated, effectively reducing the method a getter.

This reduces the API down to BackendUtility::getPagesTSconfig($pid)
and BackendUserAuhtentiction->getTSConfig() both just returning the
entire array. This simplified API can now be documented in the docs.

Change-Id: I4bbb066c1d4e2edbc0182f7967897a1558cc3c0d
Resolves: #85016
Related: #84982
Releases: master
Reviewed-on: https://review.typo3.org/56968
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Fix deletion of invalid tasks 59/56959/3
Mathias Brodala [Mon, 14 May 2018 09:37:57 +0000 (11:37 +0200)]
[BUGFIX] Fix deletion of invalid tasks

If the class of a registered task is missing, e.g. because the related
extension has been removed, the task itself will be unserialized into
an __PHP_Incomplete_Class object. Checking the task execution is an
invalid access in this case and must be avoided for such tasks to be
deleted.

Resolves: #84973
Releases: master, 8.7
Change-Id: Iaec8a5e346a0d6257a942cbead50b214036ed700
Reviewed-on: https://review.typo3.org/56959
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[FEATURE] Show user TSconfig in Configuration module 71/56971/3
Christian Kuhn [Tue, 15 May 2018 15:57:53 +0000 (17:57 +0200)]
[FEATURE] Show user TSconfig in Configuration module

The configuration module gets a new entry showing the
user TSconfig of the currently logged in user.
Note it is not possible to show user TSconfig of a different
user this way, this array is thus basically restricted
to admin users.

Resolves: #85017
Releases: master
Change-Id: Ic078160b2da1f2f5e24f13f9ee9ee708bf9a267e
Reviewed-on: https://review.typo3.org/56971
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: Sascha Maier <sam@amedick-sommer.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Remove setting style for broken links in RteHtmlParser 66/56966/2
Sybille Peters [Tue, 15 May 2018 09:35:51 +0000 (11:35 +0200)]
[TASK] Remove setting style for broken links in RteHtmlParser

This is a followup for issue #84987. The style that is now set by
CSS file in rte_ckeditor should no longer be set by a PHP method.

Resolves: #85007
Related: #84987
Releases: master
Change-Id: Ie05ed7153802e6a655b3e6e473129a92db613714
Reviewed-on: https://review.typo3.org/56966
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
11 months ago[BUGFIX] Add css for marking broken links in rte_ckeditor 43/56943/8
Sybille Peters [Sat, 12 May 2018 18:39:29 +0000 (20:39 +0200)]
[BUGFIX] Add css for marking broken links in rte_ckeditor

The styling for broken page links that was added in
RteHtmlParser::markBrokenLinks is by default removed by ckeditor
so this functionality is no longer available by default.

Page links which link to a non-existing page currently already
get the additional attribute a[data-rte-error]. This patch adds
CSS to visually style broken links with a red border and yellow
background. This is the same styling that was previously used.

This is done by adding the plugin showbrokenlinks.

The style is still added in markBrokenLinks. These attributes
will be removed by ckeditor by default. However, the functionality
is kept to function as fallback.

Resolves: #84987
Releases: master, 8.7
Change-Id: I63e1e1db248fb2c343cdd19b41424621b684e87e
Reviewed-on: https://review.typo3.org/56943
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
11 months ago[TASK] Add additional test to ArrayUtility::getValueByPath() 63/56963/2
Christian Kuhn [Tue, 15 May 2018 08:29:56 +0000 (10:29 +0200)]
[TASK] Add additional test to ArrayUtility::getValueByPath()

Verify getValueByPath() can return a sub part of a given array.

Resolves: #85009
Releases: master
Change-Id: Idc77809b960534d2b2694002c792f42d710ffa81
Reviewed-on: https://review.typo3.org/56963
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[FEATURE] Replace @validate with @Extbase\Validate 70/54870/14
Alexander Schnitzler [Tue, 8 May 2018 10:24:49 +0000 (12:24 +0200)]
[FEATURE] Replace @validate with @Extbase\Validate

This patch introduces the "TYPO3\CMS\Extbase\Annotation\Validate"
annotation that replaces the @validate annotation which is
deprecated from now on.

Releases: master
Resolves: #83167
Change-Id: I9a0a3804cfb7429eaf81ec2b3ffa21c3a3d84c63
Reviewed-on: https://review.typo3.org/54870
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Fix display of indexed search advanced search fields 58/56958/5
Gianluca Piccolo [Mon, 14 May 2018 07:42:45 +0000 (09:42 +0200)]
[BUGFIX] Fix display of indexed search advanced search fields

There were some advanced search fields in indexed search that
disappeared after the last update.

In SearchController, method processExtendedSearchParameters, there were
some non-existing variables that were used in some conditions.
With this patch, those variables are initialized before the conditions
and all the advanced search fields in indexed search are shown again.

Releases: master, 8.7
Resolves: #84995
Change-Id: I69aef4c7a3d869d519e84866929f4724c61eabd7
Reviewed-on: https://review.typo3.org/56958
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Keep state of extendedSearch 47/55547/5
Peter Niederlag [Wed, 15 Nov 2017 09:53:54 +0000 (10:53 +0100)]
[BUGFIX] Keep state of extendedSearch

formAction has set a bunch of variables that are required by
the frontend for the extendedSearch

Inside searchAction this parameters were not set resulting in
the extendedSearch section being empty in frontend after searching.

With this change the processing of the variables is extracted
into a method and called from formAction and searchAction.

Releases: master, 8.7
Resolves: #82064
Change-Id: Ia21c445ef0aa72e8e084e9bd021bc5caa7a1e74b
Reviewed-on: https://review.typo3.org/55547
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[FEATURE] Allow adding additional query restrictions 41/56341/20
Helmut Hummel [Fri, 11 May 2018 22:33:04 +0000 (00:33 +0200)]
[FEATURE] Allow adding additional query restrictions

Make it possible to add additional query restrictions,
that will be applied to every query.

Resolves: #84244
Releases: master, 8.7
Change-Id: I0d0a5546629587306e537da51d8a2557d7e95fce
Reviewed-on: https://review.typo3.org/56341
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
11 months ago[TASK] Deprecate getTSConfigVal() and getTSConfigProp() 53/56953/11
Christian Kuhn [Sun, 13 May 2018 12:15:40 +0000 (14:15 +0200)]
[TASK] Deprecate getTSConfigVal() and getTSConfigProp()

The patch deprecates BackendUserAuthentication->getTSConfigVal()
and ->getTSConfigProp() and adapts usages to rely on getTSConfig()
without arguments. The array nesting is done directly within
consuming code and is combined with ?? to a fallback value.
Advantages:
* Expensive and recursive string operations within
  getTSConfig() are not used anymore.
* The weird 'value' / 'property' based sub array
  juggling is gone.
* Full TSconfig path including fallback can be easily
  seen within consuming code
* Notice free array access using null coalescence operator

Change-Id: I6d5777ebd533dcfdc6018e0226bfb3e513cfa652
Resolves: #84993
Related: #84982
Releases: master
Reviewed-on: https://review.typo3.org/56953
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[TASK] Deprecate BackendUtility::getPidForModTSconfig() 55/56955/2
Christian Kuhn [Sun, 13 May 2018 19:09:55 +0000 (21:09 +0200)]
[TASK] Deprecate BackendUtility::getPidForModTSconfig()

Removing cruft from BackendUtility is always fun. This time an
internal marked one-liner that is used only once bites the dust.

Resolves: #84994
Releases: master
Change-Id: Iaadbcf3dc74f329f91f1a48ba4096e8ea96f60a4
Reviewed-on: https://review.typo3.org/56955
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Fix basename-fetch in basenameDuringBootstrap 44/56944/4
Stefan Neufeind [Sat, 12 May 2018 18:48:08 +0000 (20:48 +0200)]
[BUGFIX] Fix basename-fetch in basenameDuringBootstrap

Also add tests for dirnameDuringBootstrap and basenameDuringBootstrap.

Resolves: #84988
Related: #74806
Releases: master
Change-Id: I6544435f6c79425e7c008670cc5dd4df355b28c8
Reviewed-on: https://review.typo3.org/56944
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] PSR-7 responses return header using getHeader() 93/56093/6
Christian Kuhn [Sun, 11 Mar 2018 06:02:30 +0000 (07:02 +0100)]
[BUGFIX] PSR-7 responses return header using getHeader()

The base PSR-7 implementation of the Response object does not
sanitize the headers properly when handing them in as an array,
thus, it is stored wrong in the Response object.

Resolves: #84853
Releases: master, 8.7
Change-Id: I7571f1438bc602bcae9367b82f99946ed22d8308
Reviewed-on: https://review.typo3.org/56093
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[TASK] Protect user TSconfig properties in BackendUserAuthentication 40/56940/5
Christian Kuhn [Sat, 12 May 2018 15:27:55 +0000 (17:27 +0200)]
[TASK] Protect user TSconfig properties in BackendUserAuthentication

The patch sets all user TSconfig related properties of class
BackendUserAuthentication to protected. Existing usages of
property "userTS" are adapted to call getTSConfig() instead.

Resolves: #84984
Related: #84982
Releases: master
Change-Id: I6fd10164c29959e4e705699776d694d63d7f5596
Reviewed-on: https://review.typo3.org/56940
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
11 months ago[TASK] Improve code for IpAnonymization task and fix a typo 42/56942/3
Markus Klein [Sat, 12 May 2018 18:02:16 +0000 (20:02 +0200)]
[TASK] Improve code for IpAnonymization task and fix a typo

Resolves: #84986
Releases: master
Change-Id: Icd4a55386b6f17b0ba96872e213278998c6015f1
Reviewed-on: https://review.typo3.org/56942
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Allow direct access to BE again while being logged in 49/56949/6
Markus Klein [Sat, 12 May 2018 21:16:19 +0000 (23:16 +0200)]
[BUGFIX] Allow direct access to BE again while being logged in

Having a valid backend authentication and accessing /typo3
now redirects to the backend view again.

Resolves: #84991
Releases: master
Change-Id: I483f6408192a7a239144868048476057ca5b282c
Reviewed-on: https://review.typo3.org/56949
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Allow setting SYS/session in ConfigurationManager 48/56948/4
Helmut Hummel [Sat, 12 May 2018 21:16:18 +0000 (23:16 +0200)]
[BUGFIX] Allow setting SYS/session in ConfigurationManager

The config path SYS/session is similar to SYS/caching/cacheConfigurations.
Within the session configuration path session backends can be set
since TYPO3 8.7.

Allow this path for setting values with the ConfigurationManager.

Resolves: #84536
Releases: master, 8.7
Change-Id: I52649673a16937119136d2fbdd0aa93c924d8f31
Reviewed-on: https://review.typo3.org/56948
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
11 months ago[BUGFIX] Prevent loading jsfunc.inline.js twice 46/56946/2
Frank Naegler [Sat, 12 May 2018 19:46:59 +0000 (21:46 +0200)]
[BUGFIX] Prevent loading jsfunc.inline.js twice

This patch fix a JS error on creating file references because of
loading jsfunc.inline.js twice.

Resolves: #84989
Related: #84969
Releases: master
Change-Id: I35c212025d399d53033abe8ca1c25d3db10bb4b1
Reviewed-on: https://review.typo3.org/56946
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Clarify permission legend in access module 75/56775/5
Guido Schmechel [Sat, 21 Apr 2018 10:17:32 +0000 (12:17 +0200)]
[BUGFIX] Clarify permission legend in access module

The legend of the access module now reflects the intended
behavior of the `edit page` and `delete page` bits.

Resolves: #84513
Releases: master, 8.7
Change-Id: I409a1a7575bd8d44ee001cbbc95f154b5625141b
Reviewed-on: https://review.typo3.org/56775
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Return full userTS in getTSConfig() 37/56937/2
Christian Kuhn [Sat, 12 May 2018 14:14:57 +0000 (16:14 +0200)]
[TASK] Return full userTS in getTSConfig()

By making the first argument $objectString optional in
BackendUserAuthentication->userTSConfig(), we allow the method to
act as a true getter that returns the full user TSconfig array.

This avoids calls to the public property ->userTS, which will be set
to protected in master with another patch.

This patch request is for both master and v8 to simplify life of
extension developers who want to keep an extension compatible
with v8 and v9, without throwing deprecations in v9.

Resolves: #84982
Releases: master, 8.7
Change-Id: I971fcaf4a402b762add4c469650c62b059264d8f
Reviewed-on: https://review.typo3.org/56937
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Add missing information on Feature-84581-SiteHandling.rst 36/56936/3
Riccardo De Contardi [Sat, 12 May 2018 14:05:14 +0000 (16:05 +0200)]
[BUGFIX] Add missing information on Feature-84581-SiteHandling.rst

* Adds a description for the option "iso-639-1"
* Describes the location of "config.yaml" when TYPO3 runs in composer mode

Resolves: #84651
Releases: master
Change-Id: I0a0b5cf1a39e2c732653fe69bb0e0401eb493e7f
Reviewed-on: https://review.typo3.org/56936
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Deprecate BackendUserAuthentication->simplelog() 35/56935/3
Christian Kuhn [Sat, 12 May 2018 12:39:00 +0000 (14:39 +0200)]
[TASK] Deprecate BackendUserAuthentication->simplelog()

The method is a shortcut to writelog() and used only once in
the core. To simplify the old fashioned non logging framework
based API a bit, the method is deprecated with the patch.

Resolves: #84981
Releases: master
Change-Id: Idc7a8d0d4e15e5fef8edc64248a7f307df897ec4
Reviewed-on: https://review.typo3.org/56935
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
11 months ago[TASK] Deprecate BackendUserAuthentication->addTScomment() 33/56933/5
Christian Kuhn [Sat, 12 May 2018 12:13:38 +0000 (14:13 +0200)]
[TASK] Deprecate BackendUserAuthentication->addTScomment()

addTScomment() adds comment strings to user TSconfig before
parse time. This is rather useless since the unparsed final
TSconfig is never shown in the backend. The patch removes
usages and deprecates the method to reduce complexity of
this huge class a tiny little bit.

Resolves: #84980
Releases: master
Change-Id: Ib37561895205fb6f983fa5bba2541fe9e4c61941
Reviewed-on: https://review.typo3.org/56933
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
11 months ago[BUGFIX] Have proper dom in TCA select tree 31/56931/5
Christian Kuhn [Sat, 12 May 2018 09:47:27 +0000 (11:47 +0200)]
[BUGFIX] Have proper dom in TCA select tree

Patch for issue #84564 violates the DOM all other elements
stick to  and just adds the field wizard outside the element div.
Additionally, merging other field wizards result like
requireJS and the readOnly handling is fixed.

Resolves: #84976
Releases: master
Change-Id: I0d329e85649424686ab8653a72388d75e0fc91cc
Reviewed-on: https://review.typo3.org/56931
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Show all content elements with mod.web_layout.defLangBinding 54/54654/11
Nicole Cordes [Sat, 12 May 2018 10:39:52 +0000 (12:39 +0200)]
[BUGFIX] Show all content elements with mod.web_layout.defLangBinding

The option is meant to show translated content elements
alligned with their translation parent element (connected mode).

However this also made content elements diasppear, which were
added individually in a language (free mode).

With this change, elements for a language in free mode
are also shown, when the option is set.

Resolves: #62550
Releases: master, 8.7
Change-Id: I96f754ecf4ddb98f22d0d8c7d7da6001fa774d6b
Reviewed-on: https://review.typo3.org/54654
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Fix relogin with popup 78/54278/14
Benni Mack [Thu, 10 May 2018 13:46:20 +0000 (15:46 +0200)]
[BUGFIX] Fix relogin with popup

The re-login popup in BE has some issues:
- An empty frameset is loaded within the popup which is not needed
and makes the code harder to understand (parent.window.opener)
- The popup always shows the logout form, although the relogin should
show the login credentials form (because the view did not get the memo)
- Login.html should not use "../../../../" for referencing
the form

The LoginFrameset controller thus is not used (will be deprecated
in a separate patch).

This patch moves the logic into the LoginController.

Resolves: #83430
Releases: master
Change-Id: If872baf26297c8b75b786c2d8881802b05b1e41a
Reviewed-on: https://review.typo3.org/54278
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[FEATURE] Add more arguments to the ModuleLinkViewHelper 38/55838/6
Georg Ringer [Tue, 20 Feb 2018 18:26:42 +0000 (19:26 +0100)]
[FEATURE] Add more arguments to the ModuleLinkViewHelper

Improve the ModuleLinkViewHelper by providing arguments as string
and the possibility to add a returnUrl.

Resolves: #83983
Releases: master
Change-Id: I23ff113fd499215832d8d97acff97a0ac05be2b3
Reviewed-on: https://review.typo3.org/55838
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Disable fluid debug in adminPanel edit module 28/56928/2
Susanne Moog [Fri, 11 May 2018 15:48:43 +0000 (17:48 +0200)]
[BUGFIX] Disable fluid debug in adminPanel edit module

Fluid debug information will not be shown in the admin
panel edit module anymore.

Resolves: #84974
Releases: master
Change-Id: If107efc2ff3af8e1c43890e2c2094b1fd08cd88a
Reviewed-on: https://review.typo3.org/56928
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Roberto Torresani <erreti@gmail.com>
Tested-by: Roberto Torresani <erreti@gmail.com>
Reviewed-by: Cristian Buja <cristian.buja@intera.it>
Tested-by: Cristian Buja <cristian.buja@intera.it>
Reviewed-by: Massimiliano Fani <massimiliano.fani@gmail.com>
Tested-by: Massimiliano Fani <massimiliano.fani@gmail.com>
Reviewed-by: Michele Martinello <mikymartin@gmail.com>
Tested-by: Michele Martinello <mikymartin@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
11 months ago[FEATURE] Add bcrypt and argon2i password hashes 68/55668/12
Christian Futterlieb [Sun, 11 Feb 2018 20:21:24 +0000 (21:21 +0100)]
[FEATURE] Add bcrypt and argon2i password hashes

Two new ext:saltedpasswords classes implement bcrypt
and argon2i password hashes.

Change-Id: I3acda7f797ee107403662bb3488caaf2f678597d
Relates: #79795
Resolves: #79889
Releases: master
Reviewed-on: https://review.typo3.org/55668
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] JS error on folder change in file list 26/56926/2
Andreas Wolf [Fri, 11 May 2018 14:33:04 +0000 (16:33 +0200)]
[BUGFIX] JS error on folder change in file list

Change-Id: I9e2b05aee5a283d391703330b99d0378bfeca788
Resolves: #84972
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56926
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Rewrite toggle and save to ajax in AdminPanel 26/56826/5
Susanne Moog [Sun, 29 Apr 2018 14:18:57 +0000 (16:18 +0200)]
[TASK] Rewrite toggle and save to ajax in AdminPanel

As the next step on the road to a better adminPanel,
the save and toggle actions were rewritten to use ajax
getting mostly rid of the $_GET params.

Related: #84044
Resolves: #84892
Releases: master
Change-Id: Ic9169db7cf07b0246d91240c01140bfc05ecef71
Reviewed-on: https://review.typo3.org/56826
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Compatibility for finishers which set content into the response 31/56831/2
Ralf Zimmermann [Mon, 30 Apr 2018 16:58:48 +0000 (18:58 +0200)]
[BUGFIX] Compatibility for finishers which set content into the response

Since #83822 EXT:form makes usage of the controller context
response object which has impacts to the finisher logic which was not
treated by #83822.
Since #84495, finishers with output can return this as string instead
of setting this directly into the response
(which results in a double output).
This patch ensures that existing custom finishers which set the content
into the response, get respected.

Resolves: #84901
Releases: master, 8.7
Change-Id: If98de92e6121283572b9146072ab8f9b7bcace8a
Reviewed-on: https://review.typo3.org/56831
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Alessandro <alessandro.filira@pallino.it>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Use PathUtility wrappers for basename/dirname 69/47169/18
Jigal van Hemert [Thu, 10 May 2018 19:09:14 +0000 (21:09 +0200)]
[TASK] Use PathUtility wrappers for basename/dirname

Basename and dirname are locale aware and can damage path and file names
if they are used with UTF-8 file/path names while a UTF-8 locale is not
loaded.
The PathUtility wrappers solve this.

Releases: master
Resolves: #74806
Change-Id: Ibe113a1632b4e61ea87ed9a7dc8600bf3535acab
Reviewed-on: https://review.typo3.org/47169
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Use pageTree.backgroundColor recursively 89/56489/10
Guido Schmechel [Fri, 30 Mar 2018 15:43:29 +0000 (17:43 +0200)]
[BUGFIX] Use pageTree.backgroundColor recursively

When a page is listed in the pageTree, the option
pageTree.backgroundColor is recursively checked and all
subpages get the backgroundColor.

Now with subpages as a mount, the backgroundColor of the
parent page is adopted.

Resolves: #81987
Releases: master, 8.7
Change-Id: I29d444da96d9d2038a4940896fd848bf42e43f47
Reviewed-on: https://review.typo3.org/56489
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Use symfony/finder to collect TCA 11/56611/7
Andreas Fernandez [Mon, 9 Apr 2018 07:09:20 +0000 (09:09 +0200)]
[TASK] Use symfony/finder to collect TCA

Resolves: #84672
Releases: master
Change-Id: Id6843a1e8fb94c5c7aea3a5c463d8e5229bfc448
Reviewed-on: https://review.typo3.org/56611
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Make linkvalidator table usable without scrolling 20/56820/2
Ingo Pfennigstorf [Fri, 27 Apr 2018 10:40:47 +0000 (12:40 +0200)]
[TASK] Make linkvalidator table usable without scrolling

Currently using the linkvalidator and the table of broken links may
result in excessive horizontal scrolling, as the lines in the table
become very long.

This adds word breaks to the table cell contents and adds a fixed table
layout.

Releases: master, 8.7
Resolves: #84886
Change-Id: Iee4b4af36b2854512eb841f5b814ca8dc1715a53
Reviewed-on: https://review.typo3.org/56820
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Add l10n_mode prefixLangTitle to metadata alternative 78/56778/5
Guido Schmechel [Sat, 21 Apr 2018 18:46:11 +0000 (20:46 +0200)]
[BUGFIX] Add l10n_mode prefixLangTitle to metadata alternative

"Translate to X" will be prepended to the alternative text,
if an element is translated.

Resolves: #83763
Releases: master
Change-Id: I4351e924238b973802b77ec312395b1df4bd0f9f
Reviewed-on: https://review.typo3.org/56778
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Gianluca Piccolo <gianluca.piccolo@pallino.it>
Tested-by: Gianluca Piccolo <gianluca.piccolo@pallino.it>
Reviewed-by: Cristian Buja <cristian.buja@intera.it>
Tested-by: Cristian Buja <cristian.buja@intera.it>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] fix btn-group implementation 30/56630/2
Marco Pfeiffer [Wed, 11 Apr 2018 14:27:07 +0000 (16:27 +0200)]
[TASK] fix btn-group implementation

The current btn-group implementation using spans results in :first-child
and :last-child not working correctly.
There is actually a workaround implemented in bootstrap itself which is
also necessary for using btn-group-justified.
Just add btn-group inside the btn-group.

Releases: master
Resolves: #84693
Change-Id: I5cee00201c00e26bf0a7419ee3584dddf176a205
Reviewed-on: https://review.typo3.org/56630
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Massimiliano Fani <massimiliano.fani@gmail.com>
Reviewed-by: Cristian Buja <cristian.buja@intera.it>
Tested-by: Cristian Buja <cristian.buja@intera.it>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Cleanup TypeScript type defintions and editorconfig 21/56921/2
Frank Naegler [Fri, 11 May 2018 09:28:35 +0000 (11:28 +0200)]
[TASK] Cleanup TypeScript type defintions and editorconfig

Resolves: #84969
Releases: master
Change-Id: I871656c436a9ded5c82fbade4a28d5bd5e84de26
Reviewed-on: https://review.typo3.org/56921
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[TASK] Deprecate various TSFE methods 16/56916/6
Benni Mack [Thu, 10 May 2018 20:41:08 +0000 (22:41 +0200)]
[TASK] Deprecate various TSFE methods

A lot of functionality has been migrated from
TypoScriptFrontendController into middlewares
- functionality that has now no direct influence
in the so-called controller of the frontend (TSFE)
anymore. The respective methods are never called
anymore from TYPO3 Core, and extensions that
bootstrap their own frontend should ensure that
the respective Middlewares are boot up and called,
e.g. via custom stacks or just by setting up
the "frontend" middleware stack.

The following methods are now deprecated:
- connectToDB()
- checkAlternativeIdMethods()
- initializeBackendUser()
- handleDataSubmission()
- setCSS()
- convPOSTCharset()

Additionally, there are some methods in TSFE
which have been marked as "internal" but had the
PHP visibility "public", which were now
migrated to "protected".

- getPageAndRootline()
- checkRootlineForIncludeSection()
- setSysPageWhereClause()
- checkAndSetAlias()
- getHash()
- getLockHash()
- setUrlIdToken()

Resolves: #84965
Releases: master
Change-Id: Ia8e29268189179061c09a204bb7275d231fea0dc
Reviewed-on: https://review.typo3.org/56916
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Cristian Buja <cristian.buja@intera.it>
Tested-by: Cristian Buja <cristian.buja@intera.it>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Various cleanups regarding comments and API calls 19/56919/3
Benni Mack [Fri, 11 May 2018 05:33:11 +0000 (07:33 +0200)]
[TASK] Various cleanups regarding comments and API calls

This patch is a small summary of clean ups in various
places of TYPO3 Core.

- EditDocumentController can be simplified to retrieve the closeUrl()
- Comment adaptions in GeneralUtility
- Comment adaptions and code simplification in ContentObjectRenderer
- HMENU debug option can be fetched from TSFE TypoScript directly
- TypoLinkBuilder can use "TSFE->initTemplate()" directly
  to instantiate the TemplateService, and should hand over
  proper values in the constructor.

Resolves: #84966
Releases: master
Change-Id: I145b99842eea2a2386742b1525b33a49022c9339
Reviewed-on: https://review.typo3.org/56919
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Migrate cObject to LoggerAwareTrait 20/56920/2
Benni Mack [Fri, 11 May 2018 07:03:27 +0000 (09:03 +0200)]
[BUGFIX] Migrate cObject to LoggerAwareTrait

TYPO3 Core supports PSR-3 through the LoggerAwareTrait and LoggerAwareInterface
since TYPO3 v9 in all available PHP classes via makeInstance() automatically.

However, during the migration, ContentObjectRenderer was not replaced.

Resolves: #84967
Releases: master
Change-Id: I5e3481273f60858fe9bf1d8fed30d27ad1cd5707
Reviewed-on: https://review.typo3.org/56920
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] No CORS Error in WS preview 43/56843/3
Alexander Opitz [Thu, 3 May 2018 10:35:30 +0000 (12:35 +0200)]
[BUGFIX] No CORS Error in WS preview

We should not manipulate document.domain in workspace preview as we need
to communicate with our parent master window.

Releases: master, 8.7
Resolves: #78401
Change-Id: Id3f581545a5547ca4ab8c46ee204b1c947ff6e56
Reviewed-on: https://review.typo3.org/56843
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Clean up TimeTracker usage in frontend requests 13/56913/2
Benni Mack [Thu, 10 May 2018 20:02:32 +0000 (22:02 +0200)]
[TASK] Clean up TimeTracker usage in frontend requests

For historical purposes, TimeTracker->push() is
called with an empty string in the second parameter,
however, as this parameter is optional and set to ''
by default as well, the code readability can be improved
by just using the first parameter when using
TimeTracker->push()

Resolves: #84964
Releases: master
Change-Id: I37a338268f9b2df9f2a98414075d207b63dc542e
Reviewed-on: https://review.typo3.org/56913
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Enforce int for timestamp on DateTime mapping 09/56909/2
Nicole Cordes [Thu, 10 May 2018 16:53:41 +0000 (18:53 +0200)]
[BUGFIX] Enforce int for timestamp on DateTime mapping

This patch ensures using an integer value for turning a timestamp
to a DateTime object as otherwise a PHP error is thrown.

Resolves: #84962
Releases: master, 8.7, 7.6
Change-Id: I18e82c8f91f42c29c4014985a1ad11671b5a31f4
Reviewed-on: https://review.typo3.org/56909
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[BUGFIX] Respect GFX/jpg_quality when cropping 79/56779/4
Guido Schmechel [Sat, 21 Apr 2018 21:50:11 +0000 (23:50 +0200)]
[BUGFIX] Respect GFX/jpg_quality when cropping

LocalCropScaleMaskHelper generates thumbnails with
imageMagickConvert and custom crop parameters. This
will overwrite the default settings.

Append the GFX/jpg_quality parameter to the convert command.

Resolves: #81796
Releases: master
Change-Id: Iaa09e8b9134659c9ffba1c2984ef06d2c8250580
Reviewed-on: https://review.typo3.org/56779
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Bernhard Kraft <kraftb@think-open.at>
Reviewed-by: Alessandro <alessandro.filira@pallino.it>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Unify language handling within TranslationStatusController 32/56432/3
Georg Ringer [Thu, 22 Mar 2018 13:45:48 +0000 (14:45 +0100)]
[BUGFIX] Unify language handling within TranslationStatusController

The localization overview within the info module should hide hidden
sys_language records as those are also not available to editors in
the page or list module.

Resolves: #82400
Releases: master, 8.7
Change-Id: I92cdf995c189187682c01beb1d5f5baff934d2cd
Reviewed-on: https://review.typo3.org/56432
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
11 months ago[TASK] Extract workspace preview uri generation 75/56875/4
Benni Mack [Sun, 6 May 2018 17:05:01 +0000 (19:05 +0200)]
[TASK] Extract workspace preview uri generation

All logic regarding generating preview links for workspaces has been
extracted into the "PreviewUriBuilder" method. Previously this was all
scattered between the WorkspaceService and the legacy "PreviewHook"
which was not used as a hook.

Separating this functionality allows to further split up the entry points
(Controllers / Handlers) and clean up concerns.

Resolves: #84940
Releases: master
Change-Id: I648fa12bab29ecb53ae319938d1086f95abfff58
Reviewed-on: https://review.typo3.org/56875
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[BUGFIX] Remove duplicate database indices 56/56856/3
Stefan Froemken [Fri, 4 May 2018 07:15:56 +0000 (09:15 +0200)]
[BUGFIX] Remove duplicate database indices

Percona toolkit found some duplicate
indices in some ext_tables.sql.
Remove or update the mentioned indices.

Resolves: #82671
Releases: master,8.7
Change-Id: Icdb60e2ee9f16cad097c0371e258e2c176c3b50c
Reviewed-on: https://review.typo3.org/56856
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Alessandro <alessandro.filira@pallino.it>
Tested-by: Alessandro <alessandro.filira@pallino.it>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Evaluate config.ftu earlier in a FE request 10/56910/2
Benni Mack [Thu, 10 May 2018 16:51:25 +0000 (18:51 +0200)]
[BUGFIX] Evaluate config.ftu earlier in a FE request

The TypoScript option config.ftu is used to transfer a
session via GET parameters.

However this option is - unlike other TypoScript settings
- evaluted later in a frontend request. This makes it
impossible to use the option during various hooks, where
redirect URLs are generated.

Moving this evaluation to the same place as other TypoScript
options solves the issue.

Resolves: #84963
Releases: master
Change-Id: Icfcc830d9299b362ac13105fa19dda1d418cacc5
Reviewed-on: https://review.typo3.org/56910
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Adapt a couple of broken test file namespaces 07/56907/2
Christian Kuhn [Thu, 10 May 2018 15:24:57 +0000 (17:24 +0200)]
[BUGFIX] Adapt a couple of broken test file namespaces

Resolves: #84960
Releases: master
Change-Id: I26d76f9e4a636bc47190244f8e388e1bd94c4d50
Reviewed-on: https://review.typo3.org/56907
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Cristian Buja <cristian.buja@intera.it>
Tested-by: Cristian Buja <cristian.buja@intera.it>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[TASK] Update composer installer package to v2.2.0 06/56906/2
Anja [Thu, 10 May 2018 15:18:17 +0000 (17:18 +0200)]
[TASK] Update composer installer package to v2.2.0

composer update typo3/cms-composer-installers

Change-Id: I23e4474adf0942fafacd0bc6e61bdf8f9831a704
Resolves: #84959
Releases: master
Reviewed-on: https://review.typo3.org/56906
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Cristian Buja <cristian.buja@intera.it>
Tested-by: Cristian Buja <cristian.buja@intera.it>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Massimiliano Fani <massimiliano.fani@gmail.com>
11 months ago[TASK] Update composer-dep nikic/php-parser to 4.0.1 28/56128/8
Stefan Neufeind [Mon, 19 Mar 2018 20:10:34 +0000 (21:10 +0100)]
[TASK] Update composer-dep nikic/php-parser to 4.0.1

Command used:
composer require nikic/php-parser ^4.0

Resolves: #84237
Releases: master
Change-Id: I7eed5bbc31f2be6084356d86b35231d93bc6ecb2
Reviewed-on: https://review.typo3.org/56128
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Enable localizationStateSelector for selectTreeElement 87/56487/2
Torben Hansen [Fri, 30 Mar 2018 05:33:20 +0000 (07:33 +0200)]
[BUGFIX] Enable localizationStateSelector for selectTreeElement

This patch enables the localizationStateSelector for the
selectTreeElement, so an editor can select the localization state
when allowLanguageSynchronization is enabled for the element.

Resolves: #84564
Releases: master, 8.7
Change-Id: I7b315bc19b165d7c9603c0a35ee11b03b7f77c4f
Reviewed-on: https://review.typo3.org/56487
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Cristian Buja <cristian.buja@intera.it>
Tested-by: Cristian Buja <cristian.buja@intera.it>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Consider `translationSource` for fetching localized records 94/56894/3
Andreas Fernandez [Wed, 9 May 2018 08:07:03 +0000 (10:07 +0200)]
[BUGFIX] Consider `translationSource` for fetching localized records

Using `transOrigPointerField` to fetch localized records does not work
for records that were copied into a different language via DataHandler's
`copyLanguage` command.

`BackendUtility::getRecordLocalization()` now takes `translationSource`
into consideration to fetch the appropriate localization of a record.

Resolves: #84951
Releases: master, 8.7
Change-Id: I8fc9ea3c1fdaf3e54110196c6a27411e0c66b366
Reviewed-on: https://review.typo3.org/56894
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[FEATURE] Add SEO fields to Pages TCA 69/56769/16
Tom Warwick [Fri, 20 Apr 2018 21:00:05 +0000 (23:00 +0200)]
[FEATURE] Add SEO fields to Pages TCA

This feature adds some new SEO fields to the Pages TCA. It also
introduces a new SEO tab containing all SEO related meta data. The
description field is moved to this tab. Other meta data that is not
important for SEO, is still on the Metadata tab.

Resolves: #84798
Releases: master
Change-Id: I75d47d2121d8cc40e10b8df926f2de6f68db6585
Reviewed-on: https://review.typo3.org/56769
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Gianluca Piccolo <gianluca.piccolo@pallino.it>
Tested-by: Gianluca Piccolo <gianluca.piccolo@pallino.it>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[FEATURE] Add metadata to filebrowser search 91/56891/4
Guido Schmechel [Tue, 8 May 2018 20:14:58 +0000 (22:14 +0200)]
[FEATURE] Add metadata to filebrowser search

Now also searching for metadata in the filebrowser is possible.
The corresponding files are then listed.

Resolves: #71644
Releases: master
Change-Id: Ibea04dfb716496247ded3c22e9fd326cce5427d8
Reviewed-on: https://review.typo3.org/56891
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Elena Bartolotti <bartolotti.elena@gmail.com>
Tested-by: Elena Bartolotti <bartolotti.elena@gmail.com>
Tested-by: Cristian Buja <cristian.buja@intera.it>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Do not move processed files to recycler folder 03/56503/20
Guido Schmechel [Sat, 31 Mar 2018 23:10:49 +0000 (01:10 +0200)]
[BUGFIX] Do not move processed files to recycler folder

When a file gets moved to the recycler folder on delete. The processed
files should not be moved to the recycler folder but directly deleted.

Resolves: #81836
Releases: master, 8.7
Change-Id: I7a53830ea5d96735243fd9ee89e8c5aa80d084c0
Reviewed-on: https://review.typo3.org/56503
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
11 months ago[BUGFIX] do not override forceTypeValue if no pageType is set 63/56863/3
Andreas Allacher [Sat, 5 May 2018 06:28:45 +0000 (08:28 +0200)]
[BUGFIX] do not override forceTypeValue if no pageType is set

If a link doesn't set a pageType and
there is no target that defines a pageType,
then forceTypeValue needs to be used instead of always
assuming a pageType of 0.

With this fix, it is possible to actually use
the TypoScript option config.forceTypeValue again.

Resolves: #84925
Releases: master, 8.7
Change-Id: Iae6ba57e943489e4d6a6c690a7668d6908d1623e
Reviewed-on: https://review.typo3.org/56863
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[TASK] Use variable argument-list ObjectManager and Container 02/56902/5
Alexander Schnitzler [Wed, 9 May 2018 15:12:36 +0000 (17:12 +0200)]
[TASK] Use variable argument-list ObjectManager and Container

Supported since PHP 5.6. This makes the code easier to read
and allows to properly document using phpdoc.

https://secure.php.net/manual/en/functions.arguments.php#functions.variable-arg-list

Releases: master
Resolves: #84956
Change-Id: I73256207c114ef3c35a64518dd039dac2e33976a
Reviewed-on: https://review.typo3.org/56902
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
11 months ago[BUGFIX] Drop undesired backslashes from Scheduler base tasks docs 87/56887/3
Mathias Brodala [Tue, 8 May 2018 09:57:39 +0000 (11:57 +0200)]
[BUGFIX] Drop undesired backslashes from Scheduler base tasks docs

Releases: master, 8.7, 7.6
Resolves: #84947
Change-Id: I4d81174497158b411c291ee51b331c1d3652e4a1
Reviewed-on: https://review.typo3.org/56887
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
11 months ago[TASK] Move redirect to shortcut and mount point to middleware 86/56886/2
Helmut Hummel [Tue, 1 May 2018 16:56:05 +0000 (18:56 +0200)]
[TASK] Move redirect to shortcut and mount point to middleware

Instead of using HttpUtility to redirect and exit the program
flow, we now return a proper redirect response in a middleware.

Resolves: #84946
Releases: master
Change-Id: I397790ea1d46ae46ef41bd9c2f03f3aac079d1a4
Reviewed-on: https://review.typo3.org/56886
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Upgrade phpunit 6 to 7 00/56900/5
Christian Kuhn [Wed, 9 May 2018 12:02:09 +0000 (14:02 +0200)]
[TASK] Upgrade phpunit 6 to 7

Our dependencies are meanwhile phpunit 7 compatible
so we can upgrade to it now. Some minor changes in
the tests are needed along the way.

composer update --with-dependencies \
typo3/testing-framework \
phpunit/phpunit \
codeception/codeception
composer require --dev fiunchinho/phpunit-randomizer:^4.0

Change-Id: I161d43a9063b048085f27c5a7ae9249df8d6a2a9
Resolves: #84958
Releases: master
Reviewed-on: https://review.typo3.org/56900
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
11 months ago[!!!][TASK] Use no-cookie domain for youtube by default 80/56880/9
Georg Ringer [Mon, 7 May 2018 12:44:15 +0000 (14:44 +0200)]
[!!!][TASK] Use no-cookie domain for youtube by default

Improve the privacy of users by using the no-cookie domain of youtube
by default and just use youtube.com if explicitly set.

Resolves: #84843
Releases: master, 8.7, 7.6
Change-Id: I01472f93e32c2011b5494c4670d07f29348016c3
Reviewed-on: https://review.typo3.org/56880
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
11 months ago[TASK] Replace static variable with class variable in FileInfo 67/56867/7
Anja Leichsenring [Sun, 6 May 2018 06:48:14 +0000 (08:48 +0200)]
[TASK] Replace static variable with class variable in FileInfo

By removing the graphicFunctions object from global scope, unit
tests are easier to add in this area.

Change-Id: I8ddf4e0282d42325ecb03c98bede91bf6e1b636c
Resolves: #84933
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56867
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[BUGFIX] Avoid calling frontend page preparations twice 98/56898/2
Helmut Hummel [Wed, 9 May 2018 09:49:07 +0000 (11:49 +0200)]
[BUGFIX] Avoid calling frontend page preparations twice

With the introduced cleanup, one removed condition was
essential to avoid calling page rendering preparations twice.

Resolves: #84945
Releases: master
Change-Id: Ic7b977b2d2c52dc619686f95e9001eed4202717b
Reviewed-on: https://review.typo3.org/56898
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[TASK] Remove two unneeded packages from composer.lock 97/56897/2
Christian Kuhn [Wed, 9 May 2018 08:22:28 +0000 (10:22 +0200)]
[TASK] Remove two unneeded packages from composer.lock

Two packages are defined in composer.lock that are no
dependents of any other package. Remove them:

composer remove symfony/polyfill-php54 gecko-packages/gecko-php-unit

Change-Id: I1051c78b8f7101e3aa07f543df275b2917a6dd44
Resolves: #84952
Releases: master
Reviewed-on: https://review.typo3.org/56897
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Add unit tests for ImageInfo 68/56868/4
Anja Leichsenring [Sun, 6 May 2018 07:33:09 +0000 (09:33 +0200)]
[TASK] Add unit tests for ImageInfo

Change-Id: I3d9ef96e3296de676d02aa84a5ebd926b10cae53
Resolves: #84934
Relates: #84583
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56868
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
11 months ago[TASK] Simplify frontend page generation code 84/56884/4
Helmut Hummel [Tue, 1 May 2018 16:57:06 +0000 (18:57 +0200)]
[TASK] Simplify frontend page generation code

The additional isINTincScript check stems from the time
where this code was in a separate file, which
was included two times and page generation should be
skipped for the second inclusion. As INT scripts are only generated
during page rendering (or when fetching the page from cache)
we can safely remove this condition now.

Additionally, we can now easily get rid of the elseif
and move the page rendering preparation directly
after the same condition is checked later in the code flow.

This is fine, because this code does not need to be
executed before the lock is released. Last but not least
we clean up admin panel messages to clearly distinguish
between page generation and rendering preparation.

As this is a pure non breaking cleanup, this can
safely go into 8.7 branch as well.

Resolves: #84945
Releases: master, 8.7
Change-Id: If12b82a549d4cc47619c46f73c5423df70621b1b
Reviewed-on: https://review.typo3.org/56884
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
11 months ago[TASK] Make failing acceptance tests after image update run again 85/56885/12
Anja Leichsenring [Sun, 6 May 2018 20:27:16 +0000 (22:27 +0200)]
[TASK] Make failing acceptance tests after image update run again

The agent update introduced a higher chromedriver version that
caused several acceptance tests to fail. Adjusting wait states
brings them back to green.

The bamboo plan update now uses a php.ini without xdebug and
simplifies the unit test runs in this area, too.

And we need a patch for typo3/testing-framework version 3.4.2:
composer update typo3/testing-framework

Change-Id: Icc7b6b062ad652db2c92ae7a7c5197477abf2b7d
Resolves: #84939
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/56885
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Set correct foreign parentkey when writing inline relations 96/46996/3
Philipp Wrann [Wed, 2 Mar 2016 12:46:39 +0000 (13:46 +0100)]
[BUGFIX] Set correct foreign parentkey when writing inline relations

When attaching or updating 1:N relations via extbase (INLINE) the
parents uid property was taken as parentKey for the relation entity.

This behaviour is inconsistant to the FormEngine resulting in
wrong weird rendering resconstitution of 1:N relations.

This patch sets the _localizedUid of the parent object (if set)
as parentKey to the parentKeyFieldColumn.

Resolves: #73726
Releases: master
Change-Id: I47fa0f05eb46353f5b893fff07f0123325a0d515
Reviewed-on: https://review.typo3.org/46996
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Timo Pfeffer <pfeffer.timo+typo3@gmail.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Migrate ContextMenu to TypeScript 65/56865/2
Andreas Fernandez [Sat, 5 May 2018 20:20:24 +0000 (22:20 +0200)]
[TASK] Migrate ContextMenu to TypeScript

Resolves: #82579
Releases: master
Change-Id: I58165fff637ca72e921057e9441f6bc73f175808
Reviewed-on: https://review.typo3.org/56865
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Make new toggle checkboxes keyboard accessible 71/56871/3
Carsten Dietrich [Sun, 6 May 2018 12:40:01 +0000 (14:40 +0200)]
[TASK] Make new toggle checkboxes keyboard accessible

Make the checkbox input field transparent, instead of hiding it completely,
so it can still be accessed via keyboard.

Use the :focus CSS pseudo-class to highlight the input label
with a box shadow, similar to current text input fields.

Resolves: #84936
Releases: master
Change-Id: I9e176cea1517617c978f05b63d881ab6af99380f
Reviewed-on: https://review.typo3.org/56871
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Make core/Tests/Unit/Package/ notice free 60/56760/2
Jan Helke [Fri, 20 Apr 2018 16:05:24 +0000 (18:05 +0200)]
[TASK] Make core/Tests/Unit/Package/ notice free

Releases: master
Resolves: #84817
Change-Id: Id3d2cc7c47c7ba3ff46b8689970a3c8490261802
Reviewed-on: https://review.typo3.org/56760
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
11 months ago[TASK] Have bamboo plan updates and minor ac test stabilization 83/56883/2
Christian Kuhn [Mon, 7 May 2018 17:09:11 +0000 (19:09 +0200)]
[TASK] Have bamboo plan updates and minor ac test stabilization

* bamboo composer environment is a9.3.0@dev
* Adapt a test result parsing to slightly changed git
  output in younger versions
* Raise a timeout when installing introduction package in ac
  tests for less false positives.

Resolves: #84944
Releases: master
Change-Id: I3f0ec103985a96d05d4a42fab8edd92fad219114
Reviewed-on: https://review.typo3.org/56883
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[TASK] Simplify fetching section labels in global settings 76/56876/5
Helmut Hummel [Sun, 6 May 2018 18:16:50 +0000 (20:16 +0200)]
[TASK] Simplify fetching section labels in global settings

Put labels into the configuration description file
to have everything in one place.

With that in place, we can put the description directly
into the configuration data that is prepared for the edit view.

If we do so, we can get rid of the view helper
and one method in the configuration service which only
returned the labels.

Resolves: #84938
Releases: master
Change-Id: I12e5cf1ce3873d41789a52e41e6bac87da86cf9e
Reviewed-on: https://review.typo3.org/56876
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
11 months ago[TASK] Cleanup workspaces backend AJAX calls 72/56872/2
Benni Mack [Sun, 6 May 2018 14:24:07 +0000 (16:24 +0200)]
[TASK] Cleanup workspaces backend AJAX calls

The AJAX endpoints for the workspaces backend module
on the PHP side still are 1:1 like the good old ExtJS times.

In order to abstract and separate concerns in this area,
and make the AJAX-based endpoints true PSR-7 compliant
requests and responses, some cleanups are necessary.

In this first step, the AbstractHandler is removed,
as some methods can be removed or simplified in the
child classes.

Resolves: #84937
Releases: master
Change-Id: If390d4b51d19059b18f579691371669c27a337d4
Reviewed-on: https://review.typo3.org/56872
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[FEATURE] Allow to sort subpages by nav title 66/56866/2
Benni Mack [Sat, 5 May 2018 20:50:40 +0000 (22:50 +0200)]
[FEATURE] Allow to sort subpages by nav title

The sort-subpages functionality available in the
context menu of a page now also allows to sort by
nav_title.

This also fixes a typo ("create" instead of "crdate") and
streamlines some templating functionality.

Resolves: #84932
Releases: master
Change-Id: I5a59745214c7cb1682e652efb865fcd949a0e413
Reviewed-on: https://review.typo3.org/56866
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
11 months ago[BUGFIX] Obsolete keywords in t3editor tokenizer 70/56870/2
Christian Kuhn [Sun, 6 May 2018 09:44:13 +0000 (11:44 +0200)]
[BUGFIX] Obsolete keywords in t3editor tokenizer

Some removed Page TSconfig related properties were
still found in the t3editor tokenizer keywords file.

Resolves: #84935
Releases: master
Change-Id: I89cf78cc3dc33fb6528bb1f4dad3943288a9b226
Reviewed-on: https://review.typo3.org/56870
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[TASK] Update composer-dep enm1989/chromedriver 29/56129/7
Stefan Neufeind [Tue, 13 Mar 2018 10:40:40 +0000 (11:40 +0100)]
[TASK] Update composer-dep enm1989/chromedriver

Minor-update 2.33 to 2.38

Command used:
composer update enm1989/chromedriver

Resolves: #84238
Releases: master, 8.7
Change-Id: Ic15ba59fb8706134c36b1ee36147272342440707
Reviewed-on: https://review.typo3.org/56129
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
11 months ago[BUGFIX] Do not copy icon of former EXT:lang during build 64/56864/2
Andreas Fernandez [Sat, 5 May 2018 14:37:48 +0000 (16:37 +0200)]
[BUGFIX] Do not copy icon of former EXT:lang during build

The `grunt build` command copies icons of the icon repository into
different locations. Since EXT:lang does not exist anymore, the icon of
the former extension must not be copied into the now invalid location.

The configuration is removed from the Gruntfile to avoid a re-creation of
the extension directory.

Resolves: #84931
Related: #84680
Releases: master
Change-Id: I8387528ab074fab0a1e8a9bb492e69fa67490dce
Reviewed-on: https://review.typo3.org/56864
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>