Packages/TYPO3.CMS.git
14 months ago[TASK] Deprecate property and method in DocumentTemplate 83/57783/3
Wouter Wolters [Thu, 2 Aug 2018 18:20:05 +0000 (20:20 +0200)]
[TASK] Deprecate property and method in DocumentTemplate

Method addStyleSheet and property $hasDocheader are marked as
deprecated.

Resolves: #85735
Releases: master
Change-Id: I69b5a35f006e9b77b87dd842ec636653829e8c96
Reviewed-on: https://review.typo3.org/57783
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[TASK] Set table cell alignment in Indexing Engine Statistics to top 07/57807/4
Michael Kersten [Sat, 4 Aug 2018 14:17:25 +0000 (16:17 +0200)]
[TASK] Set table cell alignment in Indexing Engine Statistics to top

Add CSS class "table-vertical-top" to table in template "Statistic"
for controller "Administration" in extension "indexed_search".

Resolves: #79549
Releases: master, 8.7
Change-Id: Iab6309a957340af7f1f0f2959b14da4c1eedc7a4
Reviewed-on: https://review.typo3.org/57807
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
14 months ago[TASK] Reactivate test in ConditionMatcherTest 03/57803/3
Anja [Sat, 4 Aug 2018 10:01:03 +0000 (12:01 +0200)]
[TASK] Reactivate test in ConditionMatcherTest

The test code has been fixed to actually do what the test name says.

Additionally, a comment has been added to the code being tested,
so the intention of the regex condition is clearer.

Change-Id: I7f78b913beffb026d7e5f9a3c6b10eb0083c542e
Resolves: #85755
Releases: master
Reviewed-on: https://review.typo3.org/57803
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[TASK] Reactivate former skipped test in RendererRegistryTest 97/57797/3
Anja [Sat, 4 Aug 2018 08:15:42 +0000 (10:15 +0200)]
[TASK] Reactivate former skipped test in RendererRegistryTest

The test has been skipped due to a bug in PHP > 7.0, so
for v9 the skip condition doesn't apply anymore.

Change-Id: I202d8a8df90d709b2d21b72e4598edf8b4bb9951
Resolves: #85751
Releases: master
Reviewed-on: https://review.typo3.org/57797
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[TASK] Switch some skipped conditions to annotations in GeneralUtilityTest 02/57802/5
Johannes Seipelt [Fri, 3 Aug 2018 17:05:16 +0000 (19:05 +0200)]
[TASK] Switch some skipped conditions to annotations in GeneralUtilityTest

Set requirements for some tests by annotation instead of conditions.

Resolves: #85747
Releases: master
Change-Id: Ic1c72bcf9757d2f6d0bb2294b445248479db9dd3
Reviewed-on: https://review.typo3.org/57802
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[TASK] Switch skip condition to annotations in PdoBackendTest 99/57799/2
Michael Kersten [Sat, 4 Aug 2018 08:31:46 +0000 (10:31 +0200)]
[TASK] Switch skip condition to annotations in PdoBackendTest

Use requires annotation for skipping test if php extension pdo_sqlite
is not loaded.

Resolves: #85752
Releases: master
Change-Id: I5bc418b9de553bd3ebf5be9cfa5d1497baa24cc2
Reviewed-on: https://review.typo3.org/57799
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[TASK] Switch skip condition to annotations in SemaphoreLockStrategyTest 01/57801/2
Michael Kersten [Sat, 4 Aug 2018 08:46:56 +0000 (10:46 +0200)]
[TASK] Switch skip condition to annotations in SemaphoreLockStrategyTest

Use requires annotation for skipping test if function sem_get does
not exists.

Resolves: #85754
Releases: master
Change-Id: Ic77d0687533b09bc4460394a183dd6c00930d856
Reviewed-on: https://review.typo3.org/57801
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[TASK] Switch skip condition to annotations in WincacheBackendTest 00/57800/2
Michael Kersten [Sat, 4 Aug 2018 08:38:43 +0000 (10:38 +0200)]
[TASK] Switch skip condition to annotations in WincacheBackendTest

Use requires annotation for skipping test if php extension wincache
is not loaded.

Resolves: #85753
Releases: master
Change-Id: Ifd53bdef148eac04ea4229c19c3ce018152d5eab
Reviewed-on: https://review.typo3.org/57800
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[TASK] Switch skip condition with annotations in RedisSessionBackendTest 96/57796/3
Michael Kersten [Sat, 4 Aug 2018 07:28:40 +0000 (09:28 +0200)]
[TASK] Switch skip condition with annotations in RedisSessionBackendTest

Use requires annotation for skipping test if php extension redis
is not loaded.

Resolves: #85749
Releases: master
Change-Id: Ib5d642eae057676c34516c83ed3ab8c7c6ee02bd
Reviewed-on: https://review.typo3.org/57796
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[TASK] Switch skip condition with annotations in RedisBackendTest 95/57795/3
Michael Kersten [Sat, 4 Aug 2018 07:19:43 +0000 (09:19 +0200)]
[TASK] Switch skip condition with annotations in RedisBackendTest

Use requires annotation for skipping test if php extension redis
is not loaded.

Resolves: #85748
Releases: master
Change-Id: I587d2e6f9928defef9417c44358cc6816345caf3
Reviewed-on: https://review.typo3.org/57795
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[BUGFIX] Properly access table TCA 'ctrl' section in getPrioritizedFieldNames 81/57781/6
Tymoteusz Motylewski [Thu, 2 Aug 2018 16:07:07 +0000 (18:07 +0200)]
[BUGFIX] Properly access table TCA 'ctrl' section in getPrioritizedFieldNames

A part with table name was missing when accessing TCA array.
It also fixes similar issue in the rst file.

Resolves: #85733
Related: #85195
Releases: master
Change-Id: I947fe223336bb184f24a3b7248c6d8d724addb11
Reviewed-on: https://review.typo3.org/57781
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[BUGFIX] Read page ID correctly when drag-dropping content 40/57640/4
Claus Due [Fri, 20 Jul 2018 12:04:55 +0000 (14:04 +0200)]
[BUGFIX] Read page ID correctly when drag-dropping content

Fixes an issue where drag and dropping a content element
would send the page title, not the page ID, as part of the
command map DataHandler receives.

The reason was an indiscriminate lookup in DOM for any
element which had any `data-page` attribute and assuming
that the first found object contained the integer value.

Using the drop target’s parent element instead will resolve
the value from the nearest relative place it can be found.

Effect is that DataHandler command hooks can once again
safely assume that the value of the “move” command is the
target page ID, not an arbitrary title on v9 and ID on v8.

Change-Id: I3b34bd099d50f6ef88fc6df1bbb647acbaa253d2
Releases: master
Resolves: #85603
Reviewed-on: https://review.typo3.org/57640
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[TASK] Replace default value with placeholder in external url link handler 34/57734/8
Joerg Boesche [Tue, 31 Jul 2018 06:48:50 +0000 (08:48 +0200)]
[TASK] Replace default value with placeholder in external url link handler

Use a placeholder attribute instead of a default value.

Resolves: #85689
Releases: master, 8.7
Change-Id: I99398125e16985ba78b3887150157da2b2c01905
Reviewed-on: https://review.typo3.org/57734
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Update Styleguide to 9.2.0 85/57785/10
Tymoteusz Motylewski [Fri, 3 Aug 2018 10:09:08 +0000 (12:09 +0200)]
[TASK] Update Styleguide to 9.2.0

This brings examples of the field descriptions
and DataHandler based creation of test data.

https://github.com/TYPO3/styleguide/compare/9.1.0...9.2.0

Command run for updating the Styleguide:
composer require --dev typo3/cms-styleguide:~9.2.0

Releases: master
Resolves: #85740
Change-Id: Ibb7275f4cda8a487bb1c6ec6c05632d6d645f164
Reviewed-on: https://review.typo3.org/57785
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[TASK] Remove ugly empty area when container element is empty 22/57422/7
Łukasz Uznański [Sat, 30 Jun 2018 14:27:01 +0000 (16:27 +0200)]
[TASK] Remove ugly empty area when container element is empty

Remove margin from container elements

Resolves: #85049
Releases: master
Change-Id: I87f315343d96087ca70ac73049d9c6bba92910d2
Reviewed-on: https://review.typo3.org/57422
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Tested-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Block web access to *.tsconfig files 88/57788/2
Stephan Großberndt [Fri, 3 Aug 2018 08:22:02 +0000 (10:22 +0200)]
[TASK] Block web access to *.tsconfig files

Resolves: #85738
Releases: master, 8.7
Change-Id: I824cdce7c08e5390eafb654e2066b8f61db3c0ac
Reviewed-on: https://review.typo3.org/57788
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
14 months ago[TASK] Use RootlineUtility in Site Finder 64/57764/9
Benni Mack [Wed, 1 Aug 2018 20:08:59 +0000 (22:08 +0200)]
[TASK] Use RootlineUtility in Site Finder

The SiteFinder uses a custom rootline traversal, but
since this is cleared up with the Context API and
the separation of RootlineUtility from PageRepository,
this can now be used directly - thus caching is
utilized by default.

Resolves: #85714
Releases: master
Change-Id: Ie60bc059e24058b1bd893ad4102b39363eba85d7
Reviewed-on: https://review.typo3.org/57764
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Move PageUriBuilder to EXT:core 84/57784/3
Frank Naegler [Thu, 2 Aug 2018 19:05:38 +0000 (21:05 +0200)]
[TASK] Move PageUriBuilder to EXT:core

The class PageUriBuilder is moved to the system extension EXT:core

A class alias is in place.

Resolves: #85736
Releases: master
Change-Id: Ib96dda9cf30131fc86bc44a2cbc38ac4fc86f9ae
Reviewed-on: https://review.typo3.org/57784
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[TASK] Move DatabaseIntegrityCheck to EXT:lowlevel 65/57765/4
Benni Mack [Wed, 1 Aug 2018 20:16:01 +0000 (22:16 +0200)]
[TASK] Move DatabaseIntegrityCheck to EXT:lowlevel

The class DatabaseIntegrityCheck is solely needed in
EXT:lowlevel, and is moved to the system extension
out of EXT:core.

Resolves: #85727
Releases: master
Change-Id: I86e3b359f4692746aa87ea153edf0b18c89cea30
Reviewed-on: https://review.typo3.org/57765
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[TASK] Move RecordHistory into DataHandling namespace 73/57773/3
Benni Mack [Thu, 2 Aug 2018 10:44:39 +0000 (12:44 +0200)]
[TASK] Move RecordHistory into DataHandling namespace

The newly created (internal) RecordHistory class is
moved to the DataHandling namespace as it is related
to all other logic (e.g. DataHandler).

Resolves: #85728
Releases: master
Change-Id: Ib3cf60541e638586f246d64542d0e19bef7f62e8
Reviewed-on: https://review.typo3.org/57773
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[TASK] Fix typo in rst file 79/57779/2
Georg Ringer [Thu, 2 Aug 2018 15:29:33 +0000 (17:29 +0200)]
[TASK] Fix typo in rst file

Instead of 'Important-85683-DoppedSaltedpasswordOptions.rst' the file should be
named 'Important-85683-DroppedSaltedpasswordOptions.rst'.

Resolves: #85732
Releases: master
Change-Id: Ie6a13739128818e23dbdc6e20732011905f80509
Reviewed-on: https://review.typo3.org/57779
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[BUGFIX] Avoid exception for int label column 76/57776/2
Stephan Großberndt [Thu, 2 Aug 2018 11:51:39 +0000 (13:51 +0200)]
[BUGFIX] Avoid exception for int label column

By casting the title column to string for the label of an TCA record an
exception caused by a strict type check is avoided when shortening the
title.

Resolves: #85729
Related: #79440
Releases: master, 8.7
Change-Id: Ie365b92ae73cd766c412d66ff7624eebbbfb3cf7
Reviewed-on: https://review.typo3.org/57776
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
14 months ago[TASK] Add SiteInterface to site handling 85/57085/5
Benni Mack [Tue, 29 May 2018 22:10:04 +0000 (00:10 +0200)]
[TASK] Add SiteInterface to site handling

In order to allow sites without configuration
(e.g. based on sys_domain records),  a site interface
is added which also allows to code against.

Resolves: #85717
Releases: master
Change-Id: Icc3c8f574855d2c54560d49320dda6de426977e5
Reviewed-on: https://review.typo3.org/57085
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[TASK] Deprecate methods in ModuleTemplate 50/57750/4
Wouter Wolters [Tue, 31 Jul 2018 19:25:20 +0000 (21:25 +0200)]
[TASK] Deprecate methods in ModuleTemplate

Two methods are marked as deprecated in the class ModuleTemplate.

Resolves: #85701
Releases: master
Change-Id: If17a0e40b4bcb31c1292d4fd97af35967427c621
Reviewed-on: https://review.typo3.org/57750
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[BUGFIX] Do not create default export of AjaxDataHandler class 49/57749/7
Andreas Fernandez [Tue, 31 Jul 2018 18:11:12 +0000 (20:11 +0200)]
[BUGFIX] Do not create default export of AjaxDataHandler class

Resolves: #85611
Related: #84168
Releases: master
Change-Id: If6003015d0c300566781856cc8351e2b60468573
Reviewed-on: https://review.typo3.org/57749
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Tested-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[TASK] Deprecate LoginFramesetController 56/57756/5
Benni Mack [Wed, 1 Aug 2018 15:10:10 +0000 (17:10 +0200)]
[TASK] Deprecate LoginFramesetController

The class LoginFramesetController just does a simple frameset and
has been replaced by using `index.php?loginRefresh=1` directly.

Resolves: #85707
Related: #84368
Releases: master
Change-Id: Iaa4457ed9617d47a1551326125ed2c737f3bd34a
Reviewed-on: https://review.typo3.org/57756
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[BUGFIX] LocalizationFactory use new trigger_error call 69/57769/2
Benni Mack [Thu, 2 Aug 2018 06:28:02 +0000 (08:28 +0200)]
[BUGFIX] LocalizationFactory use new trigger_error call

Seems like this one was forgotten, don't know how
this could ever happen.

Resolves: #85721
Releases: master
Change-Id: I1c6bef0433c4b7ecf169ce83da2dc44ca4e4ef70
Reviewed-on: https://review.typo3.org/57769
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Tested-by: Łukasz Uznański <l.uznanski@macopedia.pl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[BUGFIX] Cast config.noPageTitle to int before strict comparison 68/57768/3
Richard Haeser [Wed, 1 Aug 2018 21:49:10 +0000 (23:49 +0200)]
[BUGFIX] Cast config.noPageTitle to int before strict comparison

Resolves: #85720
Related: #83254
Releases: master
Change-Id: I3183e24e59e38eb7f384deecf2e8227a2c3da6de
Reviewed-on: https://review.typo3.org/57768
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] Update composer dependencies 65/57665/4
Wouter Wolters [Mon, 23 Jul 2018 19:41:36 +0000 (21:41 +0200)]
[TASK] Update composer dependencies

composer update guzzlehttp/guzzle
composer update nikic/php-parser
composer update symfony/polyfill-php70
composer update symfony/polyfill-php72
composer update enm1989/chromedriver
composer update typo3fluid/fluid
composer update symfony/expression-language
composer update symfony/browser-kit
composer update symfony/css-selector
composer update symfony/dom-crawler
composer update symfony/cache
composer update symfony/event-dispatcher
composer update symfony/process

Resolves: #85700
Releases: master
Change-Id: I3389aa9e8004c6aee079a026cbc6f0ddb8712263
Reviewed-on: https://review.typo3.org/57665
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Clean up tests from Context API refactoring 57/57757/3
Benni Mack [Wed, 1 Aug 2018 15:23:34 +0000 (17:23 +0200)]
[TASK] Clean up tests from Context API refactoring

Due to the Context API a lot less mocking needs to be done, and tests can be cleaned up.

On top, cObject receives a TSFE object as first parameter as DI, which can be used in
the code instead of global variables.

Resolves: #85708
Releases: master
Change-Id: I9d662b6735983d71e0b046548b747ac9b7f529db
Reviewed-on: https://review.typo3.org/57757
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[TASK] Separate sending from gathering HTTP headers 58/57758/4
Benni Mack [Wed, 1 Aug 2018 15:41:50 +0000 (17:41 +0200)]
[TASK] Separate sending from gathering HTTP headers

In order to streamline HTTP response output, the list compiling of
headers sent to the browser is separated from the actual sending
(PHP call "header()").

This is a pre-patch to allow further refactorings for
better PSR-7 support.

Resolves: #85709
Releases: master
Change-Id: Id1f7750fcdf6a40ed23d3529ae8552d0a85abd93
Reviewed-on: https://review.typo3.org/57758
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Use CLI and Composer Checks via Environment class 96/55996/20
Benni Mack [Sat, 3 Mar 2018 22:23:31 +0000 (23:23 +0100)]
[TASK] Use CLI and Composer Checks via Environment class

This patch removes the last occurrences of TYPO3_REQUESTTYPE_CLI
by using Environment::isCli().

A new "TYPO3/Testing" TYPO3_CONTEXT check ensures that the Frontend
Request is now always simulated in a non-CLI environment.

Used composer command:

  composer req typo3/testing-framework:~4.2.0 --dev

Resolves: #85712
Releases: master
Change-Id: I7472e86f2816fdabd025ad87014e64b25c3d1642
Reviewed-on: https://review.typo3.org/55996
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[BUGFIX] Correctly render language fields of sys_file_metadata 60/57760/2
Helmut Hummel [Wed, 1 Aug 2018 18:04:16 +0000 (20:04 +0200)]
[BUGFIX] Correctly render language fields of sys_file_metadata

This reverts commit 1a74c8c9d302958dd17b6a35c03e185f13811c4b
("[BUGFIX] Correctly reference sys_file_metadata.language in TCA"),
that replaced the rendering of sys_language_uid and l10n_parent
with the file language field, which was since then rendered twice.

We now correctly render the hidden language palette in the general tab
and remove the language tab, which was empty after the palette has been
hidden.

Resolves: #85711
Related: #84200
Related: #75040
Releases: master, 8.7
Change-Id: I18ab907bc48f81b257d3af42c4278d6688166b2f
Reviewed-on: https://review.typo3.org/57760
Reviewed-by: Moritz Ngo <moritz.ngo@p2media.de>
Tested-by: Moritz Ngo <moritz.ngo@p2media.de>
Reviewed-by: Dennis Oezet <dennisoezet@gmx.net>
Tested-by: Dennis Oezet <dennisoezet@gmx.net>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Volkmer <typo3@markusvolkmer.de>
Tested-by: Markus Volkmer <typo3@markusvolkmer.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
14 months ago[BUGFIX] Allow requirejs modules from wizards in RTE fields 53/57753/3
Helmut Hummel [Wed, 1 Aug 2018 10:42:47 +0000 (12:42 +0200)]
[BUGFIX] Allow requirejs modules from wizards in RTE fields

The RichTextElement must not unset "requireJsModules"
from the result array as this removes previously added
modules.

Resolves: #85705
Releases: master, 8.7
Change-Id: I495732f0a1f16db84b8ec6daa2fd028e4a3a9dee
Reviewed-on: https://review.typo3.org/57753
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
14 months ago[BUGFIX] Streamline deprecation messages 54/57754/2
Benni Mack [Wed, 1 Aug 2018 12:36:23 +0000 (14:36 +0200)]
[BUGFIX] Streamline deprecation messages

Some usages of trigger_error() used \E_USER_DEPRECATED or no 2nd parameter
(which falls back to E_USER_NOTICE) which resulted in some weird issues
with opcache fatal PHP errors.

Resolves: #85706
Releases: master
Change-Id: I0916cc000d6c5d5b7e436bf91285072ff66dd657
Reviewed-on: https://review.typo3.org/57754
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[TASK] Merge saltedpasswords felogin hook into felogin 52/57752/2
Christian Kuhn [Wed, 1 Aug 2018 08:59:24 +0000 (10:59 +0200)]
[TASK] Merge saltedpasswords felogin hook into felogin

Extension salted passwords hooks into felogin to hash a new
password before it is written to database if the user resets
his password using the 'forgot password' functionality.
Since salted passwords is a mandatory extension, this hook
usage is now removed and the hash creation is put into
felogin directly.
Note the hook method feloginForgotPasswordHook() had a type
hint to FrontendLoginController, is thus tailored for this
extension only and can't be abused by a different one. It is
safe to remove that method entirely.

Change-Id: I85d4ba59cecd3bd43b148008e70fe20f0f5dc0bc
Resolves: #85703
Releases: master
Reviewed-on: https://review.typo3.org/57752
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
14 months ago[BUGFIX] Send AJAX data in EXT:recycler as POST 45/57745/2
Stephan Großberndt [Tue, 31 Jul 2018 13:37:32 +0000 (15:37 +0200)]
[BUGFIX] Send AJAX data in EXT:recycler as POST

By sending the uids of the records to really delete or recover by POST
instead of GET an HTTP error "414 Request-URI too long" is avoided when
deleting many records at once.

Resolves: #85696
Releases: master, 8.7
Change-Id: Ia8b7d5330a281bdc7916001a6b29a857f91bb986
Reviewed-on: https://review.typo3.org/57745
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
14 months ago[FEATURE] Add TCA 'saltedPassword' eval for type=input 46/57746/5
Christian Kuhn [Tue, 31 Jul 2018 14:28:14 +0000 (16:28 +0200)]
[FEATURE] Add TCA 'saltedPassword' eval for type=input

The salted passwords extension did register a custom
field evaluation to hash a given password when editing users
in the backend through FormEngine.
This is now turned into a general eval 'saltedPassword'
and handled in the DataHandler directly. Note the existing
eval 'password' is not extended since 'password' eval
changes the display part to show '****', which should be
kept seperated from the salt evaluation.
The "Evaluation" classes are dropped directly without
substitution since they are totally saltedpasswords internal
and don't make sense to be used externally.

Change-Id: I93306eaf18222d14e141a3d612a419a2b7174341
Resolves: #85698
Releases: master
Reviewed-on: https://review.typo3.org/57746
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[BUGFIX] Use filename with extension for copy to temp test 89/57489/3
Jigal van Hemert [Fri, 6 Jul 2018 17:25:10 +0000 (19:25 +0200)]
[BUGFIX] Use filename with extension for copy to temp test

Since the extension will be added to the temporary file name there
will be an error in Windows if the file name has no extension.
Windows will not create files with a name ending with a dot.

Resolves: #85502
Releases: master, 8.7
Change-Id: I45beb47525681fff314c17f943d77cec55df35c0
Reviewed-on: https://review.typo3.org/57489
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[BUGFIX] Show thumbnail in list module for columns in palettes 21/56821/19
David Gurk [Fri, 27 Apr 2018 13:55:35 +0000 (15:55 +0200)]
[BUGFIX] Show thumbnail in list module for columns in palettes

By replacing the palettes in showitem of types with their content,
the following condition can consider the columns within the palettes.

Resolves: #84885
Related: #26753
Releases: master, 8.7
Change-Id: I6561fc862cb4ed569ee886e4d070e9fba6a1654b
Reviewed-on: https://review.typo3.org/56821
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
14 months ago[TASK] Drop salted passwords configuration options 25/57725/9
Christian Kuhn [Sun, 29 Jul 2018 21:26:23 +0000 (23:26 +0200)]
[TASK] Drop salted passwords configuration options

In order to prepare the saltedpasswords extension to be implemented
as a library into the core directly, a series of configuration
options is dropped from the extension:

* FE.forceSalted & BE.forceSalted (default 0)
  Setting this to 1 disabled upgrading non-salted user password
  to salted passwords and denied login. The option is dropped, but
  only passwords that have been upgraded from simple md5 or plaintext
  in v8 are allowed to login and will get their password upgraded.

* FE.updatePasswd & BE.updatePasswd (default 1)
  Setting this to 0 disabled upgrading one salted password to
  another. This is dropped: Passwords will now always be upgraded
  to the currently configured hash algorithm if the currently used
  algorithm does no match the configured one.

* FE.onlyAuthService & BE.onlyAuthService (default 0)
  Setting this to 1 allowed stopping the authentication chain if
  the salted passwords did not verify a password. This setting is
  pretty useless since it can be expected that any sane authentication
  provider kicks in before the native salted passwords authentication.
  We found not a single usage of that flag in TER.

* checkConfigurationFE & checkConfigurationFE2
  & checkConfigurationBE & checkConfigurationBE2
  These configuration user function have been responsible to check
  various combinations of valid and invalid salted passwords
  combinations. This is obsolete with removing the other options and the
  deprecated rsaauth extension. An install tool preset for sane options
  and according warnings will be set up to establish better usability
  from an administrator point of view as soon as this patch is done.

The only option left is the main "saltedPWHashingMethod". This will
be transferred to an install tool preset including best option selection
during installation in a next step.

Resolves: #85683
Releases: master
Change-Id: I7e8150ba9bc8b36f59d08ca5cadeb547e1301f67
Reviewed-on: https://review.typo3.org/57725
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[BUGFIX] Recycler: disable mass delete/recover if no record is selected 21/57721/3
Josef Glatz [Sun, 29 Jul 2018 20:22:56 +0000 (22:22 +0200)]
[BUGFIX] Recycler: disable mass delete/recover if no record is selected

This patch really disables the mass delete/recover button
functionality of the recycler.

Resolves: #85680
Releases: master, 8.7
Change-Id: I5a6ba4f555cc06b017f3d9ff8deef7d7deac03db
Reviewed-on: https://review.typo3.org/57721
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Allow Error\Error to be translated in form extension 22/57622/2
Daniel Siepmann [Wed, 18 Jul 2018 11:18:28 +0000 (13:18 +0200)]
[BUGFIX] Allow Error\Error to be translated in form extension

Some errors added while processing forms are of Type
TYPO3\CMS\Extbase\Error\Error instead of
TYPO3\CMS\Extbase\Validation\Error as they occur in different places.
E.g. the mime type check is handled inside the TypeConverter and file
uploads can be canceled due to file size.

These errors should not lead to errors when rendered in Fluid.

Resolves: #85586
Releases: master, 8.7
Change-Id: I02eafff4b7d56a661eb956ff107c0eb0476fd6a7
Reviewed-on: https://review.typo3.org/57622
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Deprecate RuntimeCacheWriter 26/57726/6
Susanne Moog [Mon, 30 Jul 2018 14:33:03 +0000 (16:33 +0200)]
[TASK] Deprecate RuntimeCacheWriter

The RuntimeCacheWriter was introduced for the AdminPanel,
but the concept has flaws and there are better and cleaner
ways to achieve the wanted behavior. Therefore, the
RuntimeCacheWriter has been deprecated.

see https://review.typo3.org/56828/

Resolves: #85687
Related: #84894
Related: #84044
Releases: master
Change-Id: Ib794ddebb8cdf6e1738b81396fa12703a1538119
Reviewed-on: https://review.typo3.org/57726
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[BUGFIX] Declare middleware dependencies of redirects 05/57705/5
Susanne Moog [Fri, 27 Jul 2018 18:53:18 +0000 (20:53 +0200)]
[BUGFIX] Declare middleware dependencies of redirects

Resolves: #85426
Releases: master
Change-Id: I9752b736282e658add439ca0c6db640004f18045
Reviewed-on: https://review.typo3.org/57705
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
14 months ago[BUGFIX] The form upgrade wizard must update all plugin settings 82/57582/14
Ralf Zimmermann [Thu, 12 Jul 2018 20:48:42 +0000 (22:48 +0200)]
[BUGFIX] The form upgrade wizard must update all plugin settings

The form definition renaming upgrade wizard renames the persistence
identifier within the form plugin flexform.
As a result, finisher overrides can no longer be properly assigned.
This patch adds an upgrade wizard which will be able to restore these
finisher overrides.

Resolves: #85544
Releases: master, 8.7
Change-Id: Idf1ffd8432fed88431b9a0feb407f42df3304401
Reviewed-on: https://review.typo3.org/57582
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
14 months ago[BUGFIX] Access global TYPO3 object correctly 30/57730/2
Andreas Fernandez [Mon, 30 Jul 2018 18:03:35 +0000 (20:03 +0200)]
[BUGFIX] Access global TYPO3 object correctly

The setting `TYPO3.settings.ShowItem.moduleUrl` does not exist in the
local scope in some cases. The `TYPO3` object of the global (`top`)
scope is now used instead.

Resolves: #85688
Releases: master
Change-Id: Idac7c2ea4d21b259dd0f3118a6fecc6bdaeadf70
Reviewed-on: https://review.typo3.org/57730
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
14 months ago[TASK] CGL: Streamline indentions in .htaccess file template 22/57722/3
Josef Glatz [Sun, 29 Jul 2018 20:44:07 +0000 (22:44 +0200)]
[TASK] CGL: Streamline indentions in .htaccess file template

This patch adds a proper .editorconfig configuration for
.htaccess and fixes wrong existing indentions.

Resolves: #85681
Releases: master
Change-Id: Id5baa6084f1a687c1f6f7ccdfb66f7e87af2ad47
Reviewed-on: https://review.typo3.org/57722
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[TASK] Update redirect html files to HTML5 23/57723/4
Josef Glatz [Sun, 29 Jul 2018 20:59:16 +0000 (22:59 +0200)]
[TASK] Update redirect html files to HTML5

This patch updates file templates from HTML 3.2
to HTML5 markup.

Resolves: #85682
Releases: master
Change-Id: I22fa9b6e4f0e84fbc94d8d282f82594ffd3d8be9
Reviewed-on: https://review.typo3.org/57723
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
14 months ago[TASK] Exclude TypeScript sources in exports 13/57713/5
Andreas Fernandez [Sun, 29 Jul 2018 11:25:00 +0000 (13:25 +0200)]
[TASK] Exclude TypeScript sources in exports

Since the TypeScript sources don't have any impact on the behavior of the
application and are just meant for development purpose, it's safe to
exclude these files in the packaging process.

Resolves: #85674
Releases: master
Change-Id: I599433d68834a3424e5cf7d77612d2478d46510e
Reviewed-on: https://review.typo3.org/57713
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Removed extension specific code in abstract module 19/57719/2
Susanne Moog [Sun, 29 Jul 2018 15:46:34 +0000 (17:46 +0200)]
[BUGFIX] Removed extension specific code in abstract module

The admin panels AbstractModule class is meant to be extended
by extension authors and should not contain code specific to
the core adminpanel extension. The specific code has been removed.

Resolves: #85677
Releases: master
Change-Id: I6ea835954a642b456a231c7952231a3fae0cc5b4
Reviewed-on: https://review.typo3.org/57719
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[TASK] Update swiftmailer/swiftmailer to 5.4.10 04/57704/3
Georg Ringer [Fri, 27 Jul 2018 18:29:24 +0000 (20:29 +0200)]
[TASK] Update swiftmailer/swiftmailer to 5.4.10

Update swiftmailer to 5.4.10 to support TLS 1.1 / 1.2.

composer update swiftmailer/swiftmailer

Resolves: #85667
Releases: master, 8.7
Change-Id: Ic4cf3736b3f2c23b6febb138c6405b67d9bd8e12
Reviewed-on: https://review.typo3.org/57704
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Stabilize / Solidify public API of adminPanel 14/57714/2
Susanne Moog [Sun, 29 Jul 2018 11:27:48 +0000 (13:27 +0200)]
[TASK] Stabilize / Solidify public API of adminPanel

* public service classes for extension authors have gotten tests
* exceptions in public API have been made more specific
* non-API has been defined as internal
* API has been cleaned up

Resolves: #85675
Releases: master
Change-Id: Icc9bab027eaca07fccd9368763350487959148a7
Reviewed-on: https://review.typo3.org/57714
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[TASK] Add form framework RequiredValidatorEditor test 12/57712/2
Oliver Hader [Sun, 29 Jul 2018 09:37:44 +0000 (11:37 +0200)]
[TASK] Add form framework RequiredValidatorEditor test

Resolves: #85673
Related: #85608
Releases: master, 8.7
Change-Id: If351dd316c628450e09e579d0cccbe7a7cefe213
Reviewed-on: https://review.typo3.org/57712
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Clean up install tool cardsAction 15/57715/2
Christian Kuhn [Sun, 29 Jul 2018 11:49:08 +0000 (13:49 +0200)]
[BUGFIX] Clean up install tool cardsAction

With the install tool "make all modals" rewrite in #84772,
the initial views are stupid and don't need fluid assignments
like tokens anymore: Card details are now handled in single
"getContent" actions per card.
Left over assignments are removed with the patch.
Furthermore, the core updater getContent action entirely missed
some fluid assignments and the "search in custom path" image
preset functionality is restored.

Resolves: #85676
Resolves: #85419
Related: #84772
Releases: master
Change-Id: I4b2054338b500d4f8d08f83f76a3efc66511a529
Reviewed-on: https://review.typo3.org/57715
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[TASK] Document integration of PharStreamWrapper 01/57701/5
Oliver Hader [Fri, 27 Jul 2018 12:28:02 +0000 (14:28 +0200)]
[TASK] Document integration of PharStreamWrapper

Resolves: #85658
Releases: master, 8.7, 7.6
Change-Id: I6acdc235dff4b3c0c84a8a6d762d497f8d9664cc
Reviewed-on: https://review.typo3.org/57701
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Allow "defaultValue" for select form elements 47/57647/8
Ralf Zimmermann [Fri, 20 Jul 2018 20:54:32 +0000 (22:54 +0200)]
[BUGFIX] Allow "defaultValue" for select form elements

Allows the form editor to save the property "defaultValue" for
"Inspector-PropertyGridEditor" inspector editors. This rules for the
form element types "SingleSelect", "RadioButton", "MultiCheckbox"
and "MultiSelect".

Besides that a flaw in JavaScript is solved that truncated values
by one character (e.g. having "propert" instead of "property"), as
well as having a correct representation of objects and arrays when
initializing them in JavaScript.

Resolves: #85608
Resolves: #85670
Releases: master, 8.7
Change-Id: Ia82ee236e6becb36db13fb15e96c7caceab370d1
Reviewed-on: https://review.typo3.org/57647
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Allow password change in user settings for non admin users 06/57706/3
Frank Naegler [Sat, 28 Jul 2018 12:15:31 +0000 (14:15 +0200)]
[BUGFIX] Allow password change in user settings for non admin users

This patch restores the possibility to change the password in user
settings for non admin users.

Resolves: #85672
Related: #85196
Releases: master
Change-Id: I775843b0bd62c3e1ecb3a62b850a773409d08c06
Reviewed-on: https://review.typo3.org/57706
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
14 months ago[TASK] Add scheduler package as suggested if used 03/57703/2
Georg Ringer [Fri, 27 Jul 2018 18:26:39 +0000 (20:26 +0200)]
[TASK] Add scheduler package as suggested if used

If a system extension uses the scheduler it should be added to the suggest section.

Resolves: #85671
Releases: master, 8.7
Change-Id: I2f0f8155c768eb140ef6a900640e2d18ac615d79
Reviewed-on: https://review.typo3.org/57703
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
14 months ago[FEATURE] Re-Design the AdminPanel 84/57084/38
Susanne Moog [Tue, 29 May 2018 21:52:24 +0000 (23:52 +0200)]
[FEATURE] Re-Design the AdminPanel

Major refactoring of the admin panel:

- Split content in modules and sub-modules
- Modules are indepent and pluggable
- Modernized design
- Better extensibility
- Clearer separation of page and module settings

For more information see .rst files.

Resolves: #84584
Releases: master
Change-Id: Iad4dfbc485e1c1280bbdb2e7fb0dcdc9f90bf537
Reviewed-on: https://review.typo3.org/57084
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] Deprecate TSFE->initTemplate 93/57693/3
Benni Mack [Thu, 26 Jul 2018 18:33:06 +0000 (20:33 +0200)]
[TASK] Deprecate TSFE->initTemplate

The method only does one line of code, and is now instantiated if needed.

Resolves: #85666
Releases: master
Change-Id: Id5df0ecb3f887743ea1167829c9cca69aef501e4
Reviewed-on: https://review.typo3.org/57693
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[BUGFIX] Determine default language as origin correctly 76/57676/2
Andreas Fernandez [Wed, 25 Jul 2018 06:53:42 +0000 (08:53 +0200)]
[BUGFIX] Determine default language as origin correctly

Resolves: #85638
Releases: master, 8.7
Change-Id: I98ecaef360d5a27e965cbb67c5719729054b9c37
Reviewed-on: https://review.typo3.org/57676
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
14 months ago[TASK] Improve usage of Backend RequestHandler 95/57695/3
Benni Mack [Thu, 26 Jul 2018 18:53:54 +0000 (20:53 +0200)]
[TASK] Improve usage of Backend RequestHandler

The backend request with the cli check is dead code
since a different application is used for cli.

Resolves: #85662
Releases: master
Change-Id: Icea2667e9369c4041094eaa53283c6c59b3e9dd7
Reviewed-on: https://review.typo3.org/57695
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[TASK] Use same ordering in page module for title and icons 73/57673/5
Georg Ringer [Tue, 24 Jul 2018 13:09:30 +0000 (15:09 +0200)]
[TASK] Use same ordering in page module for title and icons

Use same ordering for content elements in the page module for
the default language and translations.

Resolves: #85631
Releases: master
Change-Id: Ibbbb0dd813a5ad9211737bbc07ca84b766a2abfa
Reviewed-on: https://review.typo3.org/57673
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Remove usage of TSFE->sys_page 94/57694/3
Benni Mack [Thu, 26 Jul 2018 18:37:37 +0000 (20:37 +0200)]
[TASK] Remove usage of TSFE->sys_page

Due to the introduction of Context's, the FrontendRestrictionContainer
does not have a dependency on TSFE->sys_page anymore.

Resolves: #85661
Releases: master
Change-Id: Iea969090da31c81ccd419c87f3b9970b2634cf11
Reviewed-on: https://review.typo3.org/57694
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[BUGFIX] Use correct packageManager initializing 92/57692/3
Nicole Cordes [Thu, 26 Jul 2018 15:49:38 +0000 (17:49 +0200)]
[BUGFIX] Use correct packageManager initializing

As the PackageManager is a singleton class, you should call
GeneralUtility::makeInstance to retrieve the instance. The bootstrap
correctly initializes the first instance and registers it as singleton
already.

Resolves: #85659
Releases: master
Change-Id: I414a3fe4004044b0cdf6d2d8978f7e3463886018
Reviewed-on: https://review.typo3.org/57692
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[BUGFIX] Update class names in dynamicReturnTypeMeta.json 77/57677/3
Andreas Fernandez [Wed, 25 Jul 2018 07:49:48 +0000 (09:49 +0200)]
[BUGFIX] Update class names in dynamicReturnTypeMeta.json

Resolves: #85639
Releases: master, 8.7
Change-Id: Ie7bd2b7e446ea0b11386bd77acb38d94320a6d1e
Reviewed-on: https://review.typo3.org/57677
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Site module must show hidden root pages 96/57696/2
Georg Ringer [Thu, 26 Jul 2018 19:01:06 +0000 (21:01 +0200)]
[BUGFIX] Site module must show hidden root pages

Even if a root page is flagged as hidden it must be
shown in the site module.

Resolves: #85660
Releases: master
Change-Id: I22a0b1888511940e23cb073ef0477b1f0774b3d6
Reviewed-on: https://review.typo3.org/57696
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Provide record's uid to the suggest wizard 89/57689/3
Xavier Perseguers [Thu, 26 Jul 2018 10:20:53 +0000 (12:20 +0200)]
[TASK] Provide record's uid to the suggest wizard

In addition to the query string, having the uid of the record allows
more flexibility when implementing a custom suggest receiver.

Releases: master, 8.7
Resolves: #85655
Change-Id: I8dea34a26b845b0a49b5406880790b55e445d780
Reviewed-on: https://review.typo3.org/57689
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
14 months ago[BUGFIX] Recreate PackageStates in install tool if missing 90/57690/2
Christian Kuhn [Thu, 26 Jul 2018 11:08:18 +0000 (13:08 +0200)]
[BUGFIX] Recreate PackageStates in install tool if missing

v8 has a fallback if PackageStates.php vanished on a running instance
and the install tool is called, a default PackageStates file is
generated that comes with a minimal set of active packages that
allow login to the backend and activating further packages again.

This broke in v9 with the install tool refactoring and is fixed
with the patch: The install tool detects after successful login
if PackageStates.php misses and creates a new one. Note this
operation is not yet messaged to the user. This could be added
later if a true recovery procedure is added to the install tool.
For now, the sole purpose of the patch is to resurrect an instance.

Resolves: #85634
Releases: master
Change-Id: I0e72a9e8b4f828892838921d722c61520179af1d
Reviewed-on: https://review.typo3.org/57690
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
14 months ago[BUGFIX] Allow form definitions to be moved or put to recycle folder 53/57653/3
Oliver Hader [Mon, 23 Jul 2018 14:09:27 +0000 (16:09 +0200)]
[BUGFIX] Allow form definitions to be moved or put to recycle folder

After fixing the issue of TYPO3-CORE-SA-2018-003 file commands for
form definitions (those ending with new ".form.yaml" extension) has
been limited. Since the "move" command theoretically would allow to
move and rename a file, it has been denied as well. However, it is
okay to move those files around in case the file extension has not
been changed or when being moved to a recycle folder.

Resolves: #85570
Releases: master, 8.7
Change-Id: Ic1f40d061b330d62138a42be9e868fca77b17187
Reviewed-on: https://review.typo3.org/57653
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Deprecate signals during extension installation 71/57671/3
Nicole Cordes [Tue, 24 Jul 2018 09:41:04 +0000 (11:41 +0200)]
[TASK] Deprecate signals during extension installation

The database handling and comparison was streamlined with patch
https://review.typo3.org/57429/. The extension manager uses the
global database compare action after an extension was activated.
For that reason we do not have to maintain a couple of duplicated
signals anymore and can mark them as deprecated.

Resolves: #85462
Releases: master
Change-Id: I7f6d814c43b530bb51737b3457b89c8075c364e7
Reviewed-on: https://review.typo3.org/57671
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Deprecate eID registration with a script to a file 83/57683/7
Wouter Wolters [Wed, 25 Jul 2018 18:36:45 +0000 (20:36 +0200)]
[TASK] Deprecate eID registration with a script to a file

Resolves: #85646
Releases: master
Change-Id: Ib8d550acb922c02c240f09898e4a354708a729b7
Reviewed-on: https://review.typo3.org/57683
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Functional tests without phpunit process isolation 29/57129/19
Christian Kuhn [Tue, 5 Jun 2018 23:12:07 +0000 (01:12 +0200)]
[TASK] Functional tests without phpunit process isolation

We're finally able to manage our core internal framework state,
at least in the backend. This is a huge step. To proof this,
functional tests now execute without process isolation.

We need a couple of additional reset state methods. Those are
for now marked @internal to allow us changing this stuff if
needed later.

The SystemEnvironmentBuilder also needs a change to not
directly rely on PATH_thisScript anymore.

composer require --dev typo3/testing-framework ~4.1.0

Change-Id: I37fbee7e4cf6ccb2eec18d057b6b9671d6a85167
Resolves: #85649
Releases: master
Reviewed-on: https://review.typo3.org/57129
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[TASK] Add require() to php capable cache backend 86/57686/6
Christian Kuhn [Tue, 5 Jun 2018 23:12:07 +0000 (01:12 +0200)]
[TASK] Add require() to php capable cache backend

To allow loading php cache files more than once it is
necessary to add a require() method next to requireOnce()
to cache backends. This can be used if cache entries do
not execute one-time-per-process-only code, if they for
instance do not declare classes. This is needed to execute
for instance the functional test suite multiple times in
one process and to still make use of caching.
The cache_core php cache is affected by this: Those calls
are changed to require() instead of requireOnce() to make
them multi-loadable per request.
Note require() is not yet added to the PhpCapableBackendInterface
since that would be breaking, but marked as todo for v10.0

Resolves: #85648
Releases: master
Change-Id: Id711044e9554587dba38f976bd1c5bab23826de2
Reviewed-on: https://review.typo3.org/57686
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[TASK] Remove static cache in StorageRepository 84/57684/2
Christian Kuhn [Tue, 5 Jun 2018 23:12:07 +0000 (01:12 +0200)]
[TASK] Remove static cache in StorageRepository

Class StorageRepository parks static state in property
$storageRowCache. This is ugly and needs proper reset
functionality. However, the class is also a singleton through
AbstractRepository, so there is no need to make $storageRowCache
static in the first place. Just making the property non-static
keeps all the functionality, and removes the hard to
evict static state at the same time.

Resolves: #85647
Releases: master
Change-Id: I6c8dd489b05f80f2450e1d39051da5b8e53c55a0
Reviewed-on: https://review.typo3.org/57684
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[BUGFIX] Context User Aspect must deal with empty fe_user 74/57674/3
Benni Mack [Tue, 24 Jul 2018 14:56:20 +0000 (16:56 +0200)]
[BUGFIX] Context User Aspect must deal with empty fe_user

TSFE->fe_user is set to '' by default, but UserAspect
expects "null".

Extensions like solr set up their own TSFE object which
is fine, however they still access gr_list which is OK,
because it is deprecated. However, a deprecation
message must be thrown, and NOT a strict typing warning.

UserAspect expects either "null" or object of type
AbstractUserAuthentication, but TSFE delivers '' by
default.

Modifying '' would not be an option as this would be
(slightly but still) breaking.

Resolves: #85632
Releases: master
Change-Id: I2dbd46bee1c497f413ede8a1e55334ef954cf723
Reviewed-on: https://review.typo3.org/57674
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
14 months ago[TASK] Run tests with composer update --prefer-lowest 66/57666/14
Christian Kuhn [Mon, 23 Jul 2018 22:32:14 +0000 (00:32 +0200)]
[TASK] Run tests with composer update --prefer-lowest

Similar to recent 'composer update everything' to see
if youngest dependencies allowed by our composer.json
survive the test suite, a 'composer update --prefer-lowest'
now does the opposite: An additional nightly test stage
checks if our lower bounds survive testing.

We need younger minimum fluid to run through all tests:
composer require typo3fluid/fluid ^2.5.2

We need to restrict doctrine/dbal to a higher patch level:
composer require doctrine/dbal ~2.7.1

And a series of require-dev dependencies:
composer require --dev typo3/testing-framework ^4.0.2
composer require --dev codeception/codeception ^2.4.4
composer require --dev friendsofphp/php-cs-fixer ^2.12.2

Change-Id: I5c3fa8478acc9537acc2205711081dc51b1c417a
Resolves: #85626
Related: #85624
Releases: master
Reviewed-on: https://review.typo3.org/57666
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[BUGFIX] Decouple thumbnail generation from controllers 65/56765/14
Mathias Schreiber [Fri, 20 Apr 2018 19:23:35 +0000 (21:23 +0200)]
[BUGFIX] Decouple thumbnail generation from controllers

Deferred rendering of thumbnails via an external request speed up
the backend performance. This currently works in all places that use
BackendUtility::thumbsCode.

Resolves: #85605
Releases: master, 8.7
Change-Id: Id5635fc9cd340b8bcf21995cd457415aaa1a8926
Reviewed-on: https://review.typo3.org/56765
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[BUGFIX] Use correct hook name for mime type guessers 79/57679/2
Andreas Fernandez [Wed, 25 Jul 2018 08:52:01 +0000 (10:52 +0200)]
[BUGFIX] Use correct hook name for mime type guessers

Resolves: #85641
Related: #60019
Releases: master, 8.7, 7.6
Change-Id: If9c94c020da6991dc070fa6aa8395042686b2752
Reviewed-on: https://review.typo3.org/57679
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
14 months ago[TASK] Use RootlineUtility directly 90/57590/8
Benni Mack [Fri, 13 Jul 2018 18:53:44 +0000 (20:53 +0200)]
[TASK] Use RootlineUtility directly

Instead of calling PageRepository to fetch the rootline, RootlineUtility
can do that now directly.

However, all exceptions are more specific and caught specifically, for
each use-case.

Additionally, PageRepository->getRootline() is deprecated now. For this
reason, the deprecation for the argument $ignoreMPerrors is removed
again, as it does not make sense anymore.

Resolves: #85557
Releases: master
Change-Id: I5a9192311c5616f5a58e89a39c3869b593e97968
Reviewed-on: https://review.typo3.org/57590
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] Remove skipped test in DisjunctionValidatorTest 64/57664/3
Anja Leichsenring [Mon, 23 Jul 2018 19:05:21 +0000 (21:05 +0200)]
[TASK] Remove skipped test in DisjunctionValidatorTest

The functionality guarded by the test does not apply anymore.
After the test has been skipped since a long time already,
it is safe to just remove it.

Change-Id: I7757b57e7f7424d2631f67b736d927f525e01f0b
Resolves: #85625
Releases: master
Reviewed-on: https://review.typo3.org/57664
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Deprecate PageRepository->versioningWorkspaceId 92/57592/3
Benni Mack [Fri, 13 Jul 2018 18:56:31 +0000 (20:56 +0200)]
[TASK] Deprecate PageRepository->versioningWorkspaceId

The property does not need to be accessed from the outside anymore,
and can be marked as protected/deprecated, as this information is all
stored within the given context of the page repository.

Resolves: #85556
Releases: master
Change-Id: I36072c06b6ac5c5faa5ebce5b373e76530af7509
Reviewed-on: https://review.typo3.org/57592
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
14 months ago[TASK] Run test suite with composer update 63/57663/2
Christian Kuhn [Mon, 23 Jul 2018 13:23:58 +0000 (15:23 +0200)]
[TASK] Run test suite with composer update

We recently had an issue where a dependency released new versions
that break our build. Our composer.json definitions were not strict
enough and we did not find this issue before release.

The patch extends the bamboo nightly plan with a new stage that
does a full 'composer update --with-dependencies' before running
tests, additionally to the usual 'composer install' that loads
dependencies according to our composer.lock definitions.

This way, we should find depency releases that break our
system much quicker next time.

Resolves: #85624
Related: #85552
Releases: master
Change-Id: I1d10260cdfea4d10f54e6d77de3a837bc52632b7
Reviewed-on: https://review.typo3.org/57663
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] Update codeception to latest patch level 62/57662/2
Christian Kuhn [Mon, 23 Jul 2018 15:14:57 +0000 (17:14 +0200)]
[TASK] Update codeception to latest patch level

composer update codeception/codeception --with-dependencies

Updates codeception from 2.4.1 to 2.4.4 and brings
phpunit 7.1.4 to 7.1.5 along with some deeper dependencies.
The younger phpunit bundle seems to be a bit more picky on
string assertions, so we need to fix two unit tests that
silently used the bug before.

Resolves: #85623
Releases: master
Change-Id: Iceae98384b4e2e45a8b8958835b42faca9ee704a
Reviewed-on: https://review.typo3.org/57662
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] Update php-cs-fixer to latest minor 60/57660/3
Christian Kuhn [Mon, 23 Jul 2018 13:53:39 +0000 (15:53 +0200)]
[TASK] Update php-cs-fixer to latest minor

Updates friendsofphp/php-cs-fixer from 2.11.1 to 2.12.2
The 'no_unused_imports' scanner is a bit more picky and
finds another unused import fixed along with the update.

composer update friendsofphp/php-cs-fixer

Change-Id: I40a724371c35ae4202fd8e90f43eafcb1a70c0a9
Resolves: #85621
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/57660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Use new acceptance test splitter script 58/57658/5
Christian Kuhn [Mon, 23 Jul 2018 12:02:27 +0000 (14:02 +0200)]
[TASK] Use new acceptance test splitter script

The script to split acceptance tests into chunks has been
rewritten in typo3/testing-framework and is used in pre-merge
and nightly plan. It should lead to a more fair split into
single jobs so they end up with similar runtimes again.
One test file is additionally split into three to allow
better distribution.

composer update typo3/testing-framework

Resolves: #85618
Releases: master
Change-Id: Ic65c29c5d0e4813d3953d1e70bd0c746df2b8ff4
Reviewed-on: https://review.typo3.org/57658
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Remove unnecessary extbase test 49/57649/3
Anja Leichsenring [Sat, 21 Jul 2018 10:16:42 +0000 (12:16 +0200)]
[TASK] Remove unnecessary extbase test

The removed test was skipped for a long time, and its intended
guarding against the usage of objects in extbase requests does
not apply.

Resolves: #85610
Releases: master
Change-Id: Icf401ff50badba4d8d33405d86708ec7af157516
Reviewed-on: https://review.typo3.org/57649
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
14 months ago[TASK] Enable functional tests on microsoft sql server again 41/57641/10
Christian Kuhn [Fri, 20 Jul 2018 12:11:26 +0000 (14:11 +0200)]
[TASK] Enable functional tests on microsoft sql server again

Executing functional tests on mssql has been disabled a while
ago since the daemon crashed frequently: The server can not
run on tmpfs volumes that we usually use to speed up database
operations. sql server uses O_DIRECT i/o system calls which
tmpfs does not support. Find details at
https://github.com/Microsoft/mssql-docker/issues/12

We now run mssql tests on hard disks again, but enable them
only as nightly since they are too slow as pre-merge tests.

Change-Id: Iefc61670dcf74012fcdaada8e5b771538e7cf8c3
Resolves: #85614
Releases: master
Reviewed-on: https://review.typo3.org/57641
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Preserve order of finisher options in Form CE 20/57420/4
Ioulia Kondratovitch [Fri, 29 Jun 2018 19:30:59 +0000 (21:30 +0200)]
[BUGFIX] Preserve order of finisher options in Form CE

In content elements of form_formframework, the order of
finisher options offered for overriding will be
in accordance with the order defined in FormEditorSetup.yaml.

Resolves: #85435
Releases: master, 8.7
Change-Id: Ie506858bc363c62af02a123b27c84cb9754dbda3
Reviewed-on: https://review.typo3.org/57420
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
14 months ago[TASK] Refer to SimpleDataHandlerController instead of tce_db.php 36/57636/5
Tymoteusz Motylewski [Thu, 19 Jul 2018 21:07:00 +0000 (23:07 +0200)]
[TASK] Refer to SimpleDataHandlerController instead of tce_db.php

Update comments in the code not to mention tce_db.php.

The tce_db.php entry point is gone since v8.
The SimpleDataHandlerController is responsible for pushing data
from request to DataHandler.

Resolves: #85600
Releases: master, 8.7
Change-Id: I6d323a9aab77ab67ff811970ff3c0f47dbf84340
Reviewed-on: https://review.typo3.org/57636
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
14 months ago[TASK] Remove skipped test in extbase 52/57652/2
Anja Leichsenring [Sun, 22 Jul 2018 07:06:50 +0000 (09:06 +0200)]
[TASK] Remove skipped test in extbase

The test was skipped, its guarded functionality does not exist.

Change-Id: I683a3be8ace5556052e948ca9d35eedcadd79c29
Resolves: #85612
Releases: master
Reviewed-on: https://review.typo3.org/57652
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[TASK] Deprecate PageRepository->checkWorkspaceAccess 93/57593/7
Benni Mack [Fri, 13 Jul 2018 19:43:27 +0000 (21:43 +0200)]
[TASK] Deprecate PageRepository->checkWorkspaceAccess

An unused if() statement removes the last occurrence
of this method, so it can be deprecated.

Resolves: #85554
Releases: master
Change-Id: Ica80f66f7fdce4d72c8d97d0405360c307ca14dd
Reviewed-on: https://review.typo3.org/57593
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
14 months ago[TASK] Switch from git.typo3.org to github for testing 43/57643/3
Christian Kuhn [Fri, 20 Jul 2018 15:35:16 +0000 (17:35 +0200)]
[TASK] Switch from git.typo3.org to github for testing

typo3.org git/gerrit show flakiness lately. To not torture
the poor servers with our pesky testing so much we switch
the git clones to github/TYPO3/TYPO3.CMS and hope merges
are mirrored over there more quickly and they sustain our
testing load easily.

Resolves: #85606
Releases: master, 8.7, 7.6
Change-Id: I772d945a3bf697172cb26edb761f01e6cb8da4bf
Reviewed-on: https://review.typo3.org/57643
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Define "label" for tt_content form elements within form setup 16/57616/2
Ralf Zimmermann [Tue, 17 Jul 2018 06:55:18 +0000 (08:55 +0200)]
[BUGFIX] Define "label" for tt_content form elements within form setup

Define the "label" property for tt_content form elements within
the form setup to allow saving tt_content form elements.

Resolves: #85578
Releases: master, 8.7
Change-Id: I490a43692a9f54ef843e9362d0f700a9e5552106
Reviewed-on: https://review.typo3.org/57616
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
14 months ago[TASK] Deprecate enableConcatenateFiles 29/57629/4
Benni Mack [Thu, 19 Jul 2018 10:01:17 +0000 (12:01 +0200)]
[TASK] Deprecate enableConcatenateFiles

Also config.concatenateJsAndCss TypoScript is replaced
with concatenateCss and concatenateJs since TYPO3 v6.0,
and can now be deprecated.

Resolves: #65578
Releases: master
Change-Id: I23ee9637a3c880c67a93a6f9771a9bfab5ed6ac3
Reviewed-on: https://review.typo3.org/57629
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
14 months ago[TASK] Replace gettype calls type-specific checks 68/57468/4
Wouter Wolters [Wed, 4 Jul 2018 18:45:58 +0000 (20:45 +0200)]
[TASK] Replace gettype calls type-specific checks

Resolves: #85479
Releases: master
Change-Id: I576ab5fb6a7937016497a93d3b4dd025478e81bd
Reviewed-on: https://review.typo3.org/57468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[BUGFIX] Avoid SQL error in indexed search administration 34/57634/2
Benni Mack [Thu, 19 Jul 2018 15:58:51 +0000 (17:58 +0200)]
[BUGFIX] Avoid SQL error in indexed search administration

The field "uid" is never fetched, so no count() is possible
in the DB count query.

Resolves: #85252
Releases: master, 9.3
Change-Id: I9a3f1cb13bf20dcbe4bfb5451afd465e5981ecb4
Reviewed-on: https://review.typo3.org/57634
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[TASK] Deprecate cObj->enableFields() 98/57598/3
Benni Mack [Fri, 13 Jul 2018 21:04:09 +0000 (23:04 +0200)]
[TASK] Deprecate cObj->enableFields()

The method is just a wrapper for PageRepository->enableFields()
which should be used instead.

Resolves: #85558
Releases: master
Change-Id: I5fd18ef3e101325bc95f4d0147899d961f5898f6
Reviewed-on: https://review.typo3.org/57598
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
15 months ago[TASK] Enable acceptance tests again 35/57635/8
Christian Kuhn [Thu, 19 Jul 2018 18:46:33 +0000 (20:46 +0200)]
[TASK] Enable acceptance tests again

Bring back backend acceptance test execution as pre-merge
and nightly tests. They are hopefully more stable now and
we'll test if they survive the hard pre-merge load without
being too flaky..
The patch changes the bamboo plan specs accordingly but disables
a couple for FormEngine related detail tests that need further
investigation.
The patch also fetches a new patch level of testing-framework
to have proper ac path definition of the ac splitter script:

composer update typo3/testing-framework

Change-Id: Iffcfd60391ba60d5ab2196a00a5bd0a4a93fff7f
Resolves: #85599
Releases: master
Reviewed-on: https://review.typo3.org/57635
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>