Packages/TYPO3.CMS.git
23 months ago[BUGFIX] Prevent go back by submit on enter 82/54282/3
Frank Naegler [Wed, 4 Oct 2017 09:06:25 +0000 (11:06 +0200)]
[BUGFIX] Prevent go back by submit on enter

The first button of type=submit is used by the browser if
the user hint <enter> in a form field. A form should only contains
one submit button, which is fixed now with this patch.

Resolves: #82668
Releases: master, 8.7
Change-Id: I43323dd89be67d18a2818faf11359151223458f1
Reviewed-on: https://review.typo3.org/54282
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] RSA encryption: Stop submit handling if requested 45/53845/3
Andreas Fernandez [Thu, 31 Aug 2017 13:41:56 +0000 (15:41 +0200)]
[BUGFIX] RSA encryption: Stop submit handling if requested

If the submit event of a form using RSA encryption has `cancelBubble` set
to true (e.g. by jQuery's stopPropagation()), any processing is stopped
to prevent submitting the form.

Resolves: #82259
Releases: master, 8.7
Change-Id: Idb357dd2043cccb899ad7fa3fa325f7d3c003e40
Reviewed-on: https://review.typo3.org/53845
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Do not GROUP BY alias in WorkspaceService 81/54281/2
Susanne Moog [Wed, 4 Oct 2017 07:39:28 +0000 (09:39 +0200)]
[BUGFIX] Do not GROUP BY alias in WorkspaceService

GROUP BY statements are in general evaluated before
SELECT statements. If a DBMS does not implement additional
logic to resolve aliases defined in SELECTS before grouping
the statement will fail. Currently both MSSQL as well as ORACLE
lack these additional implementations. To be safe we should
group by the non-aliased columns.

Change-Id: I04698b2c31fbe2b0907fd345fbbf5e84dcebf164
Resolves: #82664
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54281
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Split `Storage` module 40/54240/6
Andreas Fernandez [Fri, 29 Sep 2017 20:16:33 +0000 (22:16 +0200)]
[TASK] Split `Storage` module

The `Storage` RequireJS module is split into `Storage/Client` and
`Storage/Persistent`. The `Storage` module itself is marked as deprecated
and any occurrence is migrated to use the new modules.

Resolves: #82603
Releases: master
Change-Id: Ie4bbb2ac3c1801b15531f0b71e35507c8ed03f06
Reviewed-on: https://review.typo3.org/54240
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[FEATURE] Make thumbnail size in file list configurable 06/51306/7
Alexander Schnitzler [Fri, 13 Jan 2017 14:18:44 +0000 (15:18 +0100)]
[FEATURE] Make thumbnail size in file list configurable

The size of thumbnails of the file list is hard coded to
64x64 px which might not be optimal in some cases. Thus,
the size should be configurable via UserTS.

Releases: master
Resolves: #73357
Change-Id: Ibd3bd43e55231212a410ee56b375e9be5d4354d2
Reviewed-on: https://review.typo3.org/51306
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Add main admin to system maintainers during first install 99/54099/5
Simon Praetorius [Sun, 10 Sep 2017 11:41:59 +0000 (13:41 +0200)]
[TASK] Add main admin to system maintainers during first install

Resolves: #82439
Related: #82319
Releases: master
Change-Id: Ieabaf1e7a230ce82206ffea30efded9ba821d50f
Reviewed-on: https://review.typo3.org/54099
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[FOLLOWUP][TASK] Disable UnitTest run on travis 04/54304/2
Susanne Moog [Thu, 5 Oct 2017 17:30:10 +0000 (19:30 +0200)]
[FOLLOWUP][TASK] Disable UnitTest run on travis

As bamboo already runs pre- and past-merge tests on
all configured branches we don't need travis to run
tests anymore.

Change-Id: I0c9fd4c6da5eb2b9ff1fa72c3ef05e91d9aeee95
Resolves: #82685
Releases: master
Reviewed-on: https://review.typo3.org/54304
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[TASK] Add sonarcloud analysis to travis 03/54303/3
Susanne Moog [Thu, 5 Oct 2017 15:35:09 +0000 (17:35 +0200)]
[TASK] Add sonarcloud analysis to travis

Add sonar-project.properties as basic configuration
and add travis configuration for running sonar analyis
on the core.

Resolves: #82685
Releases: master
Change-Id: I6c2886068c81e15e92b3562cf4200f3e80ff59db
Reviewed-on: https://review.typo3.org/54303
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[!!!][TASK] Remove option to generate PNGs limited to 64 colors 77/54277/4
Benni Mack [Wed, 4 Oct 2017 05:17:10 +0000 (07:17 +0200)]
[!!!][TASK] Remove option to generate PNGs limited to 64 colors

The global configuration "png_truecolor" which ensured that generated PNG
images only have 64 colors (instead of the max colors) came from the transition
12 years ago to keep a small file size for PNG images.

The option was turned on for new installations and existing installations,
and if not explicitly disabled, generated true-color PNG images at any time.

The option did not have any effect for FAL-related image resizing at all.

In order to generate PNGs with a limited color-space, it is still possible to do so with
additional "reduceColors" option, as well as adding additional parameters to
ImageMagick when needed.

However, having a global option for this feature seems to be not practical these
days anymore.

Resolves: #82680
Releases: master
Change-Id: I3e00cc1c37a5ed8287dcf7cad49d2a2ab10730e6
Reviewed-on: https://review.typo3.org/54277
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[TASK] bamboo: Execute deprecated unit tests 02/54302/3
Christian Kuhn [Thu, 5 Oct 2017 12:36:53 +0000 (14:36 +0200)]
[TASK] bamboo: Execute deprecated unit tests

Add execution of the deprecated unit tests to bamboo.

Change-Id: I5b15448250f3158fde6dad3ec2c3f2681edb0b49
Resolves: #82684
Related: #82438
Releases: master
Reviewed-on: https://review.typo3.org/54302
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Acceptance tests: chromedriver directly 00/54300/5
Christian Kuhn [Thu, 5 Oct 2017 10:14:27 +0000 (12:14 +0200)]
[TASK] Acceptance tests: chromedriver directly

Use chromedriver directly in acceptance tests instead of
routing through selenium-server.

Change-Id: I229032b1b1ec1b0e6f5e4c2eb5435e3ff0ae95df
Resolves: #82683
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54300
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Streamline BackendUtility::getPagesTSconfig 52/54152/8
Alexander Schnitzler [Sun, 17 Sep 2017 11:02:15 +0000 (13:02 +0200)]
[TASK] Streamline BackendUtility::getPagesTSconfig

BackendUtility::getPagesTSconfig does accumulate the PageTS
of a page, parses and returns it. That is the main purpose of
that method. But there are 2 method arguments that change the
behavior of that method. When setting $returnPartArray to true,
the PageTS will be returned non parsed. When providing a custom
$rootLine, that rootline will be used and the result is not
cached.

1.) There is just one method call in the core that makes use
    of the argument $returnPartArray, thus, fetching the non
    parsed PageTS is made available through a separate method
    called getRawPagesTSconfig(). Using the argument
    $returnPartArray is deprecated and will be removed.

2.) Providing a custom rootline via the $rootline method is
    also deprecated and will be removed. The core does not have
    the need to fetch the PageTS for a made up rootline, thus
    people can use getRawPagesTSconfig() with a custom
    rootline in the future and then parse that PageTS
    themselves. That way the result of getPagesTSconfig can
    always be cached in the future.

Resolves: #82497
Releases: master
Change-Id: I764324072d962e89e37bf514fa405e3cd93d2783
Reviewed-on: https://review.typo3.org/54152
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] bamboo-specs: Upgrade to 6.1 94/54294/5
Christian Kuhn [Wed, 4 Oct 2017 21:02:31 +0000 (23:02 +0200)]
[TASK] bamboo-specs: Upgrade to 6.1

The 6.0 to 6.1 upgrade allows us to specifiy last missing
pieces via bamboo specs: mostly job cleanups, plugin
configuration and plan permissions.

Change-Id: If26aeb45b1109ba9797f3807087201033ea1f368
Resolves: #82679
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54294
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[FOLLOWUP][TASK] Use native trigger_error and ErrorHandler for deprecations 97/54297/2
Benni Mack [Thu, 5 Oct 2017 06:14:22 +0000 (08:14 +0200)]
[FOLLOWUP][TASK] Use native trigger_error and ErrorHandler for deprecations

The patch added a superfluous switch/case entry which is unnecessary.

Resolves: #82438
Releases: master
Change-Id: Ib2ac2503fa3ccb8ce2605e95163a29062a71cb8a
Reviewed-on: https://review.typo3.org/54297
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Never load disabled domains in TSFE 74/54274/4
Markus Klein [Tue, 3 Oct 2017 16:18:26 +0000 (18:18 +0200)]
[BUGFIX] Never load disabled domains in TSFE

This fixes an inappropriate transformation of old enableFields
condition to doctrine.

This is a regression fix to #77400.

Resolves: #82661
Related: #77400
Releases: master, 8.7
Change-Id: Ic18c9e5f59b48f30651a988c5ec9d243c8b186e3
Reviewed-on: https://review.typo3.org/54274
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] t3editor: Load TS located in rootline 42/54242/7
Andreas Fernandez [Fri, 29 Sep 2017 21:24:08 +0000 (23:24 +0200)]
[BUGFIX] t3editor: Load TS located in rootline

Adding 'pid' to the form, t3editor now loads the TypoScript
that is placed in any page of the current rootline.

Resolves: #82623
Releases: master
Change-Id: I9364bb4a60d475be52bbcc5079b4c3a6e9cb42ec
Reviewed-on: https://review.typo3.org/54242
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[TASK] Migrate lowlevel command for workspace cleanup 65/54265/7
Benni Mack [Mon, 2 Oct 2017 23:01:55 +0000 (01:01 +0200)]
[TASK] Migrate lowlevel command for workspace cleanup

The workspace-related CLI command is moved to EXT:workspaces.

This way, an unneeded "isLoaded" check gets removed - and the command
only makes sense with workspaces enabled.

Resolves: #82653
Releases: master
Change-Id: Ifb1f069d8222d86be637bd2d182536310a88db3c
Reviewed-on: https://review.typo3.org/54265
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[!!!][TASK] Use native trigger_error and ErrorHandler for deprecations 15/54015/30
Benni Mack [Fri, 8 Sep 2017 12:14:44 +0000 (14:14 +0200)]
[!!!][TASK] Use native trigger_error and ErrorHandler for deprecations

The native PHP way of triggering deprecations by a framework or
applications is done via
`trigger_error($deprecationMessage, E_USER_DEPRECATED)`.

Previously, TYPO3 used `GeneralUtility::deprecationLog()` and
similar methods to generate a custom deprecation log, however it's
more flexible to use native logging through TYPO3's ErrorHandler.

This solution centralizes the way to configure the place if and
how deprecation logs should be written to various log destinations.

This also changes the way how deprecated methods, arguments and classes
are handled.

The new way to deprecate code in TYPO3 is done via
`trigger_error()`, the @deprecated annotation within a method only
exists now for IDE support, but is not reflected anymore for the
logging message.
That's why the @deprecated annotation does not contain
a description anymore.

The methods
GeneralUtility::logDeprecatedFunction()
GeneralUtility::deprecationLog()
GeneralUtility::getDeprecationLogFileName()
GeneralUtility::logDeprecatedViewHelperAttribute()

are marked as deprecated from now on.

The configuration option $TYPO3_CONF_VARS[SYS][enableDeprecationLog]
is removed.

Deprecation messages can now be activated by adding
the E_USER_DEPRECATED constant to the respective values in

$TYPO3_CONF_VARS[SYS][errorHandlerErrors]
 (so exceptions are handled by the TYPO3 error handler)
$TYPO3_CONF_VARS[SYS][syslogErrorReporting]
 (so exceptions are put into GeneralUtility::sysLog)
$TYPO3_CONF_VARS[SYS][belogErrorReporting]
 (so exceptions are put into sys_log DB table)
$TYPO3_CONF_VARS[SYS][exceptionalErrors]
 (so exceptions are thrown on a deprecation)

Deprecations will still go into GeneralUtility::devLog(),
if deprecations are activated via the "errorHandlerErrors" option.

Tests which test explicitly for deprecated code is moved into
Tests/UnitDeprecated, to ensure that the deprecated code is not
throwing an exception.

Resolves: #82438
Releases: master
Change-Id: I6ef9a642d179001f0484c4c7678e0bec12284faf
Reviewed-on: https://review.typo3.org/54015
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] TCA deprecations in functional test fixture extensions 92/54292/3
Benni Mack [Fri, 8 Sep 2017 12:14:44 +0000 (14:14 +0200)]
[BUGFIX] TCA deprecations in functional test fixture extensions

Change-Id: I136ee199ca80a9bc749de4f93950f84a10148a00
Resolves: #82676
Related: #82438
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54292
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Remove E_USER_DEPRECATED from exceptional errors 91/54291/4
Benni Mack [Wed, 4 Oct 2017 15:00:45 +0000 (17:00 +0200)]
[TASK] Remove E_USER_DEPRECATED from exceptional errors

Production and default settings should not throw on
E_USER_DEPRECATED errors.

Resolves: #82675
Releases: master
Change-Id: I3ba75abd91f1d847717a10386ee0fa2dde9b8727
Reviewed-on: https://review.typo3.org/54291
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[!!!][TASK] Remove deprecated ensureClassLoadingInformationExists() 83/54283/6
Christian Kuhn [Wed, 4 Oct 2017 10:31:15 +0000 (12:31 +0200)]
[!!!][TASK] Remove deprecated ensureClassLoadingInformationExists()

Change-Id: I0f83233c25e73cfe6194d005cde320542e65464f
Resolves: #82674
Related: #80700
Releases: master
Reviewed-on: https://review.typo3.org/54283
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] Update typo3/testing-framework to 1.1.5 84/54284/3
Christian Kuhn [Wed, 4 Oct 2017 13:32:36 +0000 (15:32 +0200)]
[TASK] Update typo3/testing-framework to 1.1.5

Brings a patch to dump class loading information
in functional and acceptance tests.

Change-Id: Ib44918666875100426f624cee2426d460e01d32a
Resolves: #82673
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54284
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Correct route to workspace module 79/54279/3
Susanne Moog [Wed, 4 Oct 2017 07:32:31 +0000 (09:32 +0200)]
[BUGFIX] Correct route to workspace module

Use correct route for generating split preview links
in WorkspaceService

Change-Id: I5cf83c435278b9c83c31e829f28f72dc61410da2
Resolves: #82663
Releases: master
Reviewed-on: https://review.typo3.org/54279
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
23 months ago[!!!][TASK] Always use logging in authentication processes 53/54253/7
Benni Mack [Mon, 2 Oct 2017 05:28:51 +0000 (07:28 +0200)]
[!!!][TASK] Always use logging in authentication processes

There are several checks within AuthenticationService, AbstractUserAuthentication
and AbstractService which can be dropped now that the Logging API is fully
configurable.

The following options have no effect anymore:
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['writeDevLog']
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['writeDevLogBE']
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['writeDevLogFE']
$GLOBALS['TYPO3_CONF_VARS']['SYS']['enable_DLOG']

The following public properties have no effect anymore and are removed:
* AbstractUserAuthentication->writeDevLog
* AbstractService->writeDevLog

Resolves: #82639
Relates: #52694
Releases: master
Change-Id: I01a1319bb4f34da03980ce04d8d30b6fe510eae2
Reviewed-on: https://review.typo3.org/54253
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[!!!][TASK] Remove inline localizationMode 96/52496/7
Christian Kuhn [Tue, 18 Apr 2017 22:04:13 +0000 (00:04 +0200)]
[!!!][TASK] Remove inline localizationMode

Drop the TCA inline releated localizationMode settings.
This one has been deprecated with v8 including an
automatic TCA migration.

Change-Id: Ibb73721b188368605dd3cd75a29d2b7a8986966e
Releases: master
Resolves: #82634
Related: #80700
Reviewed-on: https://review.typo3.org/52496
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[TASK] Cleanup inline JavaScript in Backend 54/54254/4
Benni Mack [Mon, 2 Oct 2017 07:39:01 +0000 (09:39 +0200)]
[TASK] Cleanup inline JavaScript in Backend

This patch removes the global "TS." JavaScript option, as well as
unused code in EditDocumentController, BackendController and
PreviewController.

Resolves: #82631
Releases: master
Change-Id: I5de0af0acbac798bc9a57875a0631766a8016fa8
Reviewed-on: https://review.typo3.org/54254
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Acceptance tests: chrome headless 72/54272/8
Christian Kuhn [Tue, 3 Oct 2017 12:13:55 +0000 (14:13 +0200)]
[TASK] Acceptance tests: chrome headless

Switch to chrome headless for acceptance tests. We
don't need xvfb and friends on bamboo anymore which
will be updated with another patch later.

Change-Id: Ieb78d3d198f7dd9dc882041d86b403099e0854c6
Resolves: #82659
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54272
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Update testing require-dev dependencies 70/54270/3
Christian Kuhn [Tue, 3 Oct 2017 10:54:42 +0000 (12:54 +0200)]
[TASK] Update testing require-dev dependencies

* se/selenium-server-standalone 3.4.0->3.5.3
* codeception/codeception 2.3.5->2.3.6
* enm1989/chromedriver 2.31->2.32

Minor additional change in one acceptance test to
stabilize that test a bit better.

Change-Id: Ic306d6bb04139097962219d6047ae6aa387a5c3c
Releases: master, 8.7
Resolves: #82656
Reviewed-on: https://review.typo3.org/54270
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Raise default jpg image quality to 85 67/54267/3
Benni Mack [Mon, 2 Oct 2017 23:28:20 +0000 (01:28 +0200)]
[TASK] Raise default jpg image quality to 85

DefaultConfiguration setting is 70 (default since 12 years), but the
FactoryConfiguration setting is set to "80" for new installations.

This change raises all image quality settings to "85" if not overridden
by any installation (= new installation in the last 10 years or not changed
via the install tool), as we don't have a big file size issue with JPGs anymore
and we don't have duplicates anymore
(due to FAL instead of uploads/pics/mypic_13.jpg) and the internet connections
got better.

Resolves: #82655
Releases: master
Change-Id: Ibcb38ece4038a414bfcae103463c727ed3cf65c0
Reviewed-on: https://review.typo3.org/54267
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[BUGFIX] Set content-length header to the end of output 68/54268/4
Benni Mack [Mon, 2 Oct 2017 23:34:02 +0000 (01:34 +0200)]
[BUGFIX] Set content-length header to the end of output

Resolves: #76100
Resolves: #65719
Releases: master, 8.7
Change-Id: I2e389dd6ecb497a164a457230f106a64373c1907
Reviewed-on: https://review.typo3.org/54268
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[TASK] Raise BE user session timeout to 8 hours 66/54266/2
Benni Mack [Mon, 2 Oct 2017 23:24:20 +0000 (01:24 +0200)]
[TASK] Raise BE user session timeout to 8 hours

The current limit of an inactive user of 1 hour is not practical for a regular
editor. Instead, a default value of 8 hours fits more to a current work day.

Resolves: #82654
Releases: master
Change-Id: I2b0911f72771ffee7bd76b14de055a8a8e3f280b
Reviewed-on: https://review.typo3.org/54266
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[TASK] Acceptance tests: Don't restart browser 62/54262/3
Christian Kuhn [Mon, 2 Oct 2017 21:12:41 +0000 (23:12 +0200)]
[TASK] Acceptance tests: Don't restart browser

To speed up acceptance tests a bit the browser is no
longer restarted between tests.

Change-Id: I03132905eed1dd6a4ccca137e0e8047b01aa6ca9
Resolves: #82652
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54262
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[FOLLOWUP][TASK] Remove migrated TYPO3_CONF_VARS/SYS/setDBinit 55/54255/4
Benni Mack [Mon, 2 Oct 2017 08:00:16 +0000 (10:00 +0200)]
[FOLLOWUP][TASK] Remove migrated TYPO3_CONF_VARS/SYS/setDBinit

This patch removes the obsolete "setDBinit" option which was migrated
in TYPO3 v8.

Resolves: #82421
Releases: master
Change-Id: I96477e4dd7e151bf74caeafa7bdc38a1cde2f484
Reviewed-on: https://review.typo3.org/54255
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[!!!][TASK] Cleanup global debug functions 56/54256/4
Benni Mack [Mon, 2 Oct 2017 08:10:28 +0000 (10:10 +0200)]
[!!!][TASK] Cleanup global debug functions

The global "xdebug()" function is removed, as it is a stub for "debug" nowadays.
This function exists since SVN days,  and no comment or change why this is
available.

Additionally, the global "debug()" function had 6 parameters - the last three
were not evaluated and thus, were removed.

Resolves: #82640
Releases: master
Change-Id: I3e583c06282842e3dcb14f4b68589fd706be2519
Reviewed-on: https://review.typo3.org/54256
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Stabilize flaky TimeTracker unit test 60/54260/2
Christian Kuhn [Mon, 2 Oct 2017 12:50:28 +0000 (14:50 +0200)]
[BUGFIX] Stabilize flaky TimeTracker unit test

The time tracker sometimes switches between two milliseconds
in its operation. Test a bit weaker to cope with that.

Change-Id: I20d58296749bf33b12ab2da72691ecf4853842eb
Resolves: #82635
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54260
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[!!!][TASK] Remove tce_db options "prErr" and "uPT" 44/54244/4
Benni Mack [Sat, 30 Sep 2017 20:15:52 +0000 (22:15 +0200)]
[!!!][TASK] Remove tce_db options "prErr" and "uPT"

The two GET/POST parameters "prErr" (Print Errors) and "uPT" (Update Pagetree)
are removed.

The GET/POST parameter "uPT" is there to explicitly request a refresh of
the page tree if visible on the next module load.

The GET/POST parameter "prErr" adds flash messages to the session queue
which should be a default behaviour anyway.

Please note that this only affects the SimpleDataHandlerController (BE module "tce_db") and no datahandler calls itself.

The first parameter of DataHandler->printLogErrorMessages() is removed
as it is unused.

Resolves: #82629
Releases: master
Change-Id: Ifc925e49b49f1537a65141810403a7758e0b448b
Reviewed-on: https://review.typo3.org/54244
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] CKEditor should not create uploads subfolder 58/54258/2
Benni Mack [Mon, 2 Oct 2017 08:43:11 +0000 (10:43 +0200)]
[BUGFIX] CKEditor should not create uploads subfolder

The system extension rte_ckeditor creates an upload folder which is always
empty and not in use by the extension or something else.

Resolves: #82633
Releases: master, 8.7
Change-Id: Ic4877a9cbdbb078e5a7745f609f81aeaa5c991c3
Reviewed-on: https://review.typo3.org/54258
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[!!!][TASK] Move EXT:info_pagetsconfig into EXT:info 32/53532/9
Georg Ringer [Sun, 16 Jul 2017 14:13:49 +0000 (16:13 +0200)]
[!!!][TASK] Move EXT:info_pagetsconfig into EXT:info

Migrate the extension info_pagetsconfig into the extension
info where also all other controllers are.

Resolves: #82505
Releases: master
Change-Id: I916d2ef6c00f6a5fa2cfca9c6b3f340aa4aefb44
Reviewed-on: https://review.typo3.org/53532
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Fix wrong matcher class name 57/54257/3
Benni Mack [Mon, 2 Oct 2017 08:33:27 +0000 (10:33 +0200)]
[BUGFIX] Fix wrong matcher class name

Resolves: #82632
Related: #82014
Releases: master
Change-Id: I987bdda0bdc5bc91c1422b7558bc220f516e79ea
Reviewed-on: https://review.typo3.org/54257
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
23 months ago[CLEANUP] Review comment of PageRepository::getPage() 78/52878/9
Elmar Hinz [Sat, 20 May 2017 14:09:58 +0000 (16:09 +0200)]
[CLEANUP] Review comment of PageRepository::getPage()

Note:

Type hints are not trivial to add to the signature. Although the
method always returns an array, there are unit tests that make use
of the assumption that the method is allowed to return null. Fixing
this goes beyond the goals of this ticket.

Releases: master, 8.7
Resolves: #81280
Change-Id: If47041fb6fc4835de879e9077b0359063083cbd2
Reviewed-on: https://review.typo3.org/52878
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[CLEANUP] Review comment of fetch_the_id 92/52892/7
Elmar Hinz [Sun, 21 May 2017 17:50:21 +0000 (19:50 +0200)]
[CLEANUP] Review comment of fetch_the_id

Change-Id: I590025affea93d84a616b92f9b51211448ec3280
Releases: master
Resolves: #81280
Reviewed-on: https://review.typo3.org/52892
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] EXT:form - open the ElementBrowser in modal window 15/54115/3
Ralf Zimmermann [Mon, 11 Sep 2017 11:50:23 +0000 (13:50 +0200)]
[BUGFIX] EXT:form - open the ElementBrowser in modal window

Migrate the JS ElementBrowser to the modal which was introduced with
issue #82427.

Resolves: #82443
Releases: master
Change-Id: Ib71a15a7ce9638de4eb423d896fefa47bfa15e96
Reviewed-on: https://review.typo3.org/54115
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[TASK] Merge EXT:cshmanual into EXT:documentation 80/53180/10
Georg Ringer [Fri, 9 Jun 2017 19:18:42 +0000 (21:18 +0200)]
[TASK] Merge EXT:cshmanual into EXT:documentation

To reduce the amount of system extensions the extension
cshmanual can be merged into EXT:documentation.

Resolves: #81574
Releases: master
Change-Id: I5cd728938ffd319f5c13bf0af4caeda48c08ee37
Reviewed-on: https://review.typo3.org/53180
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Bring RTE linkbrowser options back 81/53481/5
Frans Saris [Fri, 14 Jul 2017 18:57:32 +0000 (20:57 +0200)]
[BUGFIX] Bring RTE linkbrowser options back

The CKEditor link browser handled the configuration array still as a
TypoScript array with dots. But the parsed YAML config is a plain array
now.

This patch makes sure the BrowserLinkController handles this config like
a normal array. Further it fixes the missing JavaScript part to set the
link title based on selected css class.

Resolves: #81381
Releases: master, 8.7
Change-Id: Ie4749f820082e185208bf811aad7133bfc82d37a
Reviewed-on: https://review.typo3.org/53481
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Increase sequence if uid gets forced for PostgreSQL 19/51819/11
Manuel Selbach [Fri, 24 Feb 2017 09:03:54 +0000 (10:03 +0100)]
[BUGFIX] Increase sequence if uid gets forced for PostgreSQL

If a uid gets forcefully set during a insert into the database
MySQL will automatically update the auto_increment primary key.
Other databases might need post processing, i.e PostgreSQL as
it uses a sequence to generate auto increment uids. Sequences
do not get transparently updated on inserts.

Resolves: #79976
Releases: master, 8.7
Change-Id: I033deb63bf9bc2e072408885a534752573ba4c7c
Reviewed-on: https://review.typo3.org/51819
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] Avoid unnecessary I/O in GeneralUtility::createVersionNumberedFilename() 21/54221/3
Faton Haliti [Wed, 27 Sep 2017 07:56:13 +0000 (09:56 +0200)]
[BUGFIX] Avoid unnecessary I/O in GeneralUtility::createVersionNumberedFilename()

With this commit we prevent to check for existence of file
when we don't need to, because mode is not either 'embed' or
'querystring'

Resolves: #82565
Releases: master, 8.7
Change-Id: I829b8e87d951a6f170bc03d8b7836f671b51bdf4
Reviewed-on: https://review.typo3.org/54221
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] Remove hardcoded check on typo3/sysext/ 30/54230/3
Benni Mack [Thu, 28 Sep 2017 14:53:28 +0000 (16:53 +0200)]
[TASK] Remove hardcoded check on typo3/sysext/

When running TYPO3 with custom components (subtree), the typo3/sysext/
directory is not always necessary, and the hardcoded check is obsolete.

Resolves: #82622
Releases: master, 8.7
Change-Id: I3e939c80fff30d82dd4eb624c2f4bc5db1696809
Reviewed-on: https://review.typo3.org/54230
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Handle empty string icon-overlay identifier 12/54212/4
Romain Canon [Sat, 23 Sep 2017 13:07:02 +0000 (15:07 +0200)]
[BUGFIX] Handle empty string icon-overlay identifier

An overlay identifier can be an empty string, for instance when the icon API is
called with the Fluid icon view helper:

```
<core:icon identifier="tx-my-icon"
           overlay="{f:if(condition: myCondition, then: 'my-overlay-icon')}" />
```

In the example below, if the condition `myCondition` is `false`, an empty string
is used for the overlay parameter.

---

Previously, an empty string as overlay identifier would lead to the basic "not
found icon" being used as overlay.

With this commit, the behaviour for an empty string will now be the same as when
 `null` is used.

---

Resolves: #82547
Releases: master, 8.7
Change-Id: I6fb8207f302873e0188d71a210485bbf8565eff9
Reviewed-on: https://review.typo3.org/54212
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] Use HTML5 validation for Install Tool test email address 16/54216/6
Georg Ringer [Tue, 26 Sep 2017 05:56:23 +0000 (07:56 +0200)]
[TASK] Use HTML5 validation for Install Tool test email address

Let the browser do the validation for the test email address.

Resolves: #82562
Releases: master
Change-Id: I8932eab709cb89d669b8931872d7e1cbda4d0fb1
Reviewed-on: https://review.typo3.org/54216
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Fix handling of Storage.Client 29/54229/2
Andreas Fernandez [Thu, 28 Sep 2017 13:17:14 +0000 (15:17 +0200)]
[BUGFIX] Fix handling of Storage.Client

The "Storage" module gets the missing "unset" method to remove values
from localStorage. The "isset" method is fixed to determine whether
a value is really existing.

Resolves: #82613
Releases: master, 8.7
Change-Id: Icb4b862b380811a7ba7f897be3c4809b718d2810
Reviewed-on: https://review.typo3.org/54229
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[!!!][TASK] Remove RDCT redirect functionality 25/54225/5
Benni Mack [Thu, 28 Sep 2017 07:51:09 +0000 (09:51 +0200)]
[!!!][TASK] Remove RDCT redirect functionality

The very legacy RDCT code and the corresponding DB table
"cache_md5params" has been long superseeded and is be
completely moved into its own extension "RDCT" published
on GitHub https://github.com/FriendsOfTYPO3/rdct and in TER.

An upgrade wizard checks if the DB table is filled,
and then installs EXT:rdct.

Note #1: I decided to trigger the hard breaking way,
instead of deprecation as the whole logic (evalution,
static method call in GeneralUtility removed) is interconnected
and only makes sense if all places are there.

Note #2: This functionality has not been in use in the
TYPO3 Core since 4.x - at all, but is in place for
other extensions.

Resolves: #82572
Releases: master
Change-Id: I1514293500c385f7b8c1fff440cca3ab3845615b
Reviewed-on: https://review.typo3.org/54225
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] Update nikic/php-parser from v3.0.6 to v3.1.1 17/54217/3
Georg Ringer [Tue, 26 Sep 2017 07:49:30 +0000 (09:49 +0200)]
[TASK] Update nikic/php-parser from v3.0.6 to v3.1.1

Resolves: #82620
Releases: master
Change-Id: I50d8186fc84590e063bff5dabcf2e52ea4fb49a7
Reviewed-on: https://review.typo3.org/54217
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] EXT:form - explain initializeFormElement hook 34/54234/2
Ralf Zimmermann [Fri, 29 Sep 2017 11:32:16 +0000 (13:32 +0200)]
[TASK] EXT:form - explain initializeFormElement hook

Add more explanations about the initializeFormElement
hook into the docs.

Resolves: #82615
Releases: master, 8.7
Change-Id: I670625533f95b92a37f5536096eb2cc4211d33d9
Reviewed-on: https://review.typo3.org/54234
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Flexform support for type:passthrough 91/47491/15
Frank Naegler [Fri, 1 Apr 2016 14:05:31 +0000 (16:05 +0200)]
[TASK] Flexform support for type:passthrough

Resolves: #20705
Releases: master
Change-Id: I3476f6945b645a3b906e49efbdeaa385411c50ea
Reviewed-on: https://review.typo3.org/47491
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Fix broken reload of save+preview links 18/54218/9
Frank Naegler [Tue, 26 Sep 2017 10:43:14 +0000 (12:43 +0200)]
[BUGFIX] Fix broken reload of save+preview links

Resolves: #82456
Related: #81250
Releases: master
Change-Id: Idab208c3273adbd5800edab51bd9ca7bbec19af8
Reviewed-on: https://review.typo3.org/54218
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
23 months ago[BUGFIX] Allows setting extended search per default 25/51925/7
Dominik Winkelbauer [Thu, 2 Mar 2017 10:12:04 +0000 (11:12 +0100)]
[BUGFIX] Allows setting extended search per default

Makes it possible to enable extended search per default.

Change-Id: I793faa6d7f325661c193bf4661bfd924a6cfb69a
Resolves: #80091
Releases: master,8.7
Reviewed-on: https://review.typo3.org/51925
Reviewed-by: Christian Futterlieb <christian@futterlieb.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Ignore missing folders from psr-4 definitions 07/54207/6
Helmut Hummel [Fri, 22 Sep 2017 12:16:49 +0000 (14:16 +0200)]
[BUGFIX] Ignore missing folders from psr-4 definitions

Even when generating an optimized class map for psr-4
classes, Composer gracefully ignores folders defined
in psr-4 autoload section, if they do not exist.

TYPO3 however fails with an exception.

Also change the logic to always generate a class map
for improved class loading performance. This happened
anyway already when calling the autoload generation twice.

Resolves: #82542
Releases: master, 8.7
Change-Id: I4c3ab8ff7affeba25313d93e40e35f78bb78492d
Reviewed-on: https://review.typo3.org/54207
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
23 months ago[BUGFIX] Add backend authentication to Extbase CommandController 22/54222/8
Wolfgang Klinger [Wed, 27 Sep 2017 08:09:42 +0000 (10:09 +0200)]
[BUGFIX] Add backend authentication to Extbase CommandController

Ensure backwards compatibility with existing Extbase CommandControllers
by making sure the _cli_ user is always authenticated, so e.g. calls to
the DataHandler do not require explicit authentication in the extensions
CommandController.

Resolves: #82566
Releases: master, 8.7
Change-Id: Ice9b039558b68050c08a53f1c50dc726ec657522
Reviewed-on: https://review.typo3.org/54222
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Use localize command when translating page record 45/52945/6
Frans Saris [Fri, 26 May 2017 13:51:03 +0000 (15:51 +0200)]
[BUGFIX] Use localize command when translating page record

Currently, when using the dropdown to create a page translation within
the Page Module, DataHandler is called with just a simple "new" record
of type "pages_language_overlay".

However, a classic "localize" DataHandler command is more appropriate,
allowing to utilize several localization functionalities built in.

In order to achieve this, the option tags in the selector contain the full
URL to the DataHandler call, as well as the redirect to FormEngine (which
in turn redirects back to the current page module URL).

Resolves: #81345
Releases: master, 8.7
Change-Id: I740c2d1d11494963283bc14b1f534bd344d0764a
Reviewed-on: https://review.typo3.org/52945
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[CLEANUP] Remove invalid paths in PSR-4 section 11/54211/2
Georg Ringer [Fri, 22 Sep 2017 17:42:42 +0000 (19:42 +0200)]
[CLEANUP] Remove invalid paths in PSR-4 section

Remove not existing paths from root composer.json.
For 8.7 the path to context_help must be kept.

Resolves: #82546
Releases: master, 8.7
Change-Id: Iea32a481011d906ea7057072413e6ae01a2ce771
Reviewed-on: https://review.typo3.org/54211
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Do not ignore empty value in OptionViewHelper 22/54122/2
Raphael Graf [Mon, 11 Sep 2017 18:55:51 +0000 (20:55 +0200)]
[BUGFIX] Do not ignore empty value in OptionViewHelper

Resolves: #82457
Releases: master
Change-Id: I42a1fdb85e87db4601ceefdd52e0dd4f1722bd23
Reviewed-on: https://review.typo3.org/54122
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: David Hoeckele <hoeckele@netvertising.ch>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Sascha Rademacher <s.rademacher@neusta.de>
Tested-by: Sascha Rademacher <s.rademacher@neusta.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] Provide uid in ElementInformation popup 87/54187/3
Georg Ringer [Wed, 20 Sep 2017 18:39:19 +0000 (20:39 +0200)]
[TASK] Provide uid in ElementInformation popup

The uid of a record is an important information and should
be provided as well.

Resolves: #82526
Releases: master, 8.7
Change-Id: Ic44ca6a24e21c09ced78203ed4a73907906bf568
Reviewed-on: https://review.typo3.org/54187
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Sascha Rademacher <s.rademacher@neusta.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Disable install tool access in switch user mode 81/54181/6
Mona Muzaffar [Wed, 20 Sep 2017 11:45:09 +0000 (13:45 +0200)]
[BUGFIX] Disable install tool access in switch user mode

During switch user mode the install tool modules are never visible.

Resolves: #82517
Releases: master
Change-Id: Ie367cb7f0208a7414ada38d40f8cdd3ab287da52
Reviewed-on: https://review.typo3.org/54181
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Sascha Rademacher <s.rademacher@neusta.de>
Tested-by: Sascha Rademacher <s.rademacher@neusta.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
23 months ago[!!!][TASK] Deprecate GeneralUtility::devLog() 59/24559/29
Markus Klein [Sun, 10 Sep 2017 01:15:09 +0000 (03:15 +0200)]
[!!!][TASK] Deprecate GeneralUtility::devLog()

The core now directly logs to the Logging API.

Resolves: #52694
Releases: master
Change-Id: Ia3c8f1c3608aff540a990e9078132b233bbedde6
Reviewed-on: https://review.typo3.org/24559
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Fix broken redis tests 95/54195/2
Frank Naegler [Thu, 21 Sep 2017 10:09:19 +0000 (12:09 +0200)]
[BUGFIX] Fix broken redis tests

Resolves: #82533
Releases: master, 8.7, 7.6
Change-Id: Ia47f604b9cb7fa53d3707e6150554709cbfdb763
Reviewed-on: https://review.typo3.org/54195
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Do not recalculate PIDs for every query in BE search 30/53930/4
Susanne Moog [Wed, 6 Sep 2017 13:21:08 +0000 (15:21 +0200)]
[BUGFIX] Do not recalculate PIDs for every query in BE search

The backend search "Show all" link recalculated allowed PIDs for
the current user for all search operations resulting in an
exponentially increasing amount of sql queries depending on the
number of pages in an installation.

As the list of allowed pages for the user does not change during
the request, it is enough to calculate it once.

Change-Id: I9262a5d8425d04cb4ff1e35b2c3cc0ec96b8fa53
Resolves: #82083
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53930
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[BUGFIX] MenuProcessor: Allow sub keys of `addQueryString` 83/54183/2
Andreas Fernandez [Wed, 20 Sep 2017 12:20:55 +0000 (14:20 +0200)]
[BUGFIX] MenuProcessor: Allow sub keys of `addQueryString`

THis patch allows sub keys of `addQueryString`, e.g. `exclude`.

Resolves: #82520
Releases: master, 8.7
Change-Id: I8a6b5f924292cf56326cd18d8bb9b7887d095288
Reviewed-on: https://review.typo3.org/54183
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Fix undefined variable to evaluate `fileFolder_recursions` correctly 74/54174/4
Andreas Fernandez [Tue, 19 Sep 2017 14:24:38 +0000 (16:24 +0200)]
[BUGFIX] Fix undefined variable to evaluate `fileFolder_recursions` correctly

Resolves: #82512
Releases: master, 8.7
Change-Id: Ibfbd1a8e347f5b25871f5d073994bdb2af264051
Reviewed-on: https://review.typo3.org/54174
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] fix spelling of content-type http-header in response classes 00/54200/2
Stephan Jorek [Thu, 21 Sep 2017 14:51:48 +0000 (16:51 +0200)]
[BUGFIX] fix spelling of content-type http-header in response classes

In the constructors of the two new http-response classes ...

* TYPO3\CMS\Core\Http\HtmlResponse
* TYPO3\CMS\Core\Http\JsonResponse

... change the spelling of the value of the lowercased header-names
for the default/fallback 'Content-Type' header from 'Content-type'
to 'Content-Type'. Mind the capital 'T' in '...-Type'.

Resolves: #82537
Releases: master
Change-Id: Ib7b3d0f6c6de0a1490345e9e537d3545b80b4d82
Reviewed-on: https://review.typo3.org/54200
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix exception in FE when using predefined admPanel config 23/54123/2
Markus Klein [Mon, 11 Sep 2017 11:14:27 +0000 (13:14 +0200)]
[BUGFIX] Fix exception in FE when using predefined admPanel config

Enforcing the admPanel for users via user TSconfig is working again
without crashing the FE.

We make sure that when the admPanel configuration is fetched, we
do not fall back to the toplevel value if the requested sub-value
does not exist.

Resolves: #82460
Releases: master, 8.7, 7.6
Change-Id: Ibd288805aa6c91d74eee8a9c80ebcce62d1f860f
Reviewed-on: https://review.typo3.org/54123
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Change username from _cli_scheduler to _cli_ 88/54188/5
Raphael Graf [Wed, 20 Sep 2017 18:51:51 +0000 (20:51 +0200)]
[BUGFIX] Change username from _cli_scheduler to _cli_

and remove the whole paragraph about specific rights of the user.

Releases: master, 8.7
Resolves: #82527
Change-Id: Icd65ba13c7464fdd0290cec48f08de9d0934e796
Reviewed-on: https://review.typo3.org/54188
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Increase size of domain name field 86/54186/2
Georg Ringer [Wed, 20 Sep 2017 18:19:39 +0000 (20:19 +0200)]
[TASK] Increase size of domain name field

Allow 255 chars for a domain to be in sync with RFC 1035.

Resolves: #82515
Releases: master, 8.7, 7.6
Change-Id: I63916cb115b00e50c62c1926cf890e29bf89de77
Reviewed-on: https://review.typo3.org/54186
Reviewed-by: Patrik Karisch <p.karisch@pixelart.at>
Tested-by: Patrik Karisch <p.karisch@pixelart.at>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][FEATURE] EXT:form - add content element uid to the form identifier 25/54125/4
Ralf Zimmermann [Tue, 12 Sep 2017 10:39:47 +0000 (12:39 +0200)]
[!!!][FEATURE] EXT:form - add content element uid to the form identifier

Make it possible to use the same form multiple times on one page by
adding the content element uid to the form identifier.

Resolves: #81775
Releases: master
Change-Id: I001a654f8ffc47c91c984133d8475605f1b15b7a
Reviewed-on: https://review.typo3.org/54125
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Remove duplicate PageTS cache in Typo3DbBackend 51/54151/3
Alexander Schnitzler [Sun, 17 Sep 2017 10:02:11 +0000 (12:02 +0200)]
[BUGFIX] Remove duplicate PageTS cache in Typo3DbBackend

The Typo3DbBackend fetches PageTS via BackendUtility::getPagesTSconfig
and then stores a copy of it (for each page separately) in a static
property. This is a bug and leads to performance decreases because
the PageTS is already cached via BackendUtility::getPagesTSconfig
and it's done even better than in Typo3DbBackend because the backend
utility store a single cache entry for different pages with the same
PageTS. The Typo3DbBackend does create a copy of the PageTS for each
page.

Resolves: #82496
Releases: master, 8.7
Change-Id: I61bd6fa8eb3ba29baea355ae01a8d71f7ae7e963
Reviewed-on: https://review.typo3.org/54151
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Update ExtensionUtility::registerPlugin() icon parameter docs 87/53987/3
Mathias Brodala [Fri, 8 Sep 2017 08:40:08 +0000 (10:40 +0200)]
[BUGFIX] Update ExtensionUtility::registerPlugin() icon parameter docs

The icon parameter is passed through to TCA "select" items, thus aside
from an icon file path an icon identifier can be used here.

Resolves: #82351
Releases: master, 8.7
Change-Id: Ia84aa9c739c10372f1ad76c5b4dde9f0b1a62c99
Reviewed-on: https://review.typo3.org/53987
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Stabilize flaky acceptance test 80/54180/2
Christian Kuhn [Wed, 20 Sep 2017 11:41:15 +0000 (13:41 +0200)]
[BUGFIX] Stabilize flaky acceptance test

The initial view of the installer enables the 'proceed'
buttons on first step via JS. The ac test has to wait
until the buttons are rendered before proceeding.

Change-Id: I1426f1434d80124ac5036c1270668867c86fc2d6
Resolves: #82516
Related: #82504
Releases: master
Reviewed-on: https://review.typo3.org/54180
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Support target in fluid_styled_content menus 60/54160/4
Mats Svensson [Tue, 12 Sep 2017 13:06:22 +0000 (15:06 +0200)]
[BUGFIX] Support target in fluid_styled_content menus

Add condition and only render target attribute if set on page.

Resolves: #82464
Releases: master, 8.7
Change-Id: I14c561188f1e8a7389b145adf85c64918e61d461
Reviewed-on: https://review.typo3.org/54160
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Sascha Wilking <sascha.wilking@hmmh.de>
Tested-by: Sascha Wilking <sascha.wilking@hmmh.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Remove BackendUserRepository injection in NoteController 66/54166/5
Georg Ringer [Tue, 19 Sep 2017 10:06:54 +0000 (12:06 +0200)]
[TASK] Remove BackendUserRepository injection in NoteController

To improve the performance of sys_note rendering, the injection can
be skipped as the current user id can be used directly.

Resolves: #82506
Releases: master
Change-Id: I40b04ac725628f4dcfb3f1e5a280edf9c8e545f9
Reviewed-on: https://review.typo3.org/54166
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] EXT:form - allow validation translation for a field in all forms 88/53988/8
David Gurk [Fri, 8 Sep 2017 07:23:03 +0000 (09:23 +0200)]
[TASK] EXT:form - allow validation translation for a field in all forms

This allows to translate a form element validation messages without
a specific form definition identifier.

Resolves: #82366
Releases: master, 8.7
Change-Id: I1db756c7f3c84d599f5c3c2265d8a7ca07fc2205
Reviewed-on: https://review.typo3.org/53988
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Sonja Großewinkelmann <s.grossewinkelmann@neusta.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] EXT:form - fix documentation paths 32/54132/4
Ralf Zimmermann [Wed, 13 Sep 2017 11:10:16 +0000 (13:10 +0200)]
[TASK] EXT:form - fix documentation paths

Cleanup some leftovers from issue #82336 (review:53946) within
the EXT:form documentation. Basically, long file paths are shortened.

Resolves: #82472
Related: #82336
Releases: master
Change-Id: I6ecac403a91d195d0c35d99281ecbe665ca8ec54
Reviewed-on: https://review.typo3.org/54132
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Add &L=0 to Indexed Search results only when needed. 78/53978/5
Łukasz Uznański [Thu, 7 Sep 2017 20:44:21 +0000 (22:44 +0200)]
[BUGFIX] Add &L=0 to Indexed Search results only when needed.

L=0 is added to Indexed Search results links if current page language is
> 0.

Resolves: #81164
Related: #81994
Related: #81986
Releases: master, 8.7
Change-Id: Ia9738b4d64bdcf1f3b2d6fa91d446f2f22c8130b
Reviewed-on: https://review.typo3.org/53978
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Install tool: JS driven routing 28/54128/16
Christian Kuhn [Tue, 12 Sep 2017 22:27:21 +0000 (00:27 +0200)]
[TASK] Install tool: JS driven routing

The install tool suffered from three main issues since 6.2 rewrite:
* The "step" installer was re-used for recovery and installation
* The routing logic was server based and threw lots of redirects
  which lead to redirect loops
* The Controller/Action class structure was weird and hard to
  understand

The patch solves this with a rather huge rewrite:
* There are two request handlers: One for the Installer, one for
  the install tool.
* A simple list of controllers. One InstallerController for the
  step installer, the others for the main module points of the
  install tool and a Login and a Layout controller.
* Single action code is moved into controllers.
* Both tool and installer first load only a <head> section that
  contain JS references. All other calls are ajax based and the
  routing is done JS side.
* Installer and install tool no longer share controller code
  or templates, the installer can potentially be fully extracted
  from ext:install in another step.
* Installer.js is the "walk through installation" module of the
  installer.
* Router.js is the routing module for the install tool, all tool
  ajax requests get specific urls from this module and hand over
  errors to the Router.
* Error handling is handled on JS side: If for instance
  the login session expires and user clicks elsewhere, a 403
  response is returned which is handled by JS to route to login.
  This is also the place where a recovery can hook in later.
* The silent configuration updater is executed again which was
  removed during one of the previous master patches.
* The template structure is much easier.
* Various card content which has been calculated when loading
  the card layout is moved to the ajax code for single card
  content. That increases the performance of the main module
  points and makes them pretty snappy.

Change-Id: Ib40f40acba17bb47142c0da1bcfb389ab9b4b3a1
Resolves: #82504
Releases: master
Reviewed-on: https://review.typo3.org/54128
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FOLLOWUP][!!!][TASK] Replace GeneralUtility::sysLog() with Logging API 61/54161/2
Markus Klein [Mon, 18 Sep 2017 08:41:36 +0000 (10:41 +0200)]
[FOLLOWUP][!!!][TASK] Replace GeneralUtility::sysLog() with Logging API

Do not reference the logger inside a constructor as its injection
happens after the constructor has been executed.
Therefore create a dedicated instance for logging.

Resolves: #82430
Releases: master
Change-Id: Ic943ad53e4ae2abed3fabb55e24b17362de92e1c
Reviewed-on: https://review.typo3.org/54161
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Introduce command registry to aggregate console commands 20/54120/22
Alexander Schnitzler [Mon, 11 Sep 2017 16:52:08 +0000 (18:52 +0200)]
[TASK] Introduce command registry to aggregate console commands

This introduces an iterable command registry that
aggregates commands from Configuration/Commands.php files.
To speed things up for subsequent usage, a first level cache is used.

Resolves: #82455
Releases: master
Change-Id: Ibd123ef947d06939bc84f5ea609996fec85de6e8
Reviewed-on: https://review.typo3.org/54120
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
2 years ago[BUGFIX] Unify Extbase base command error 26/53926/7
Alexander Schnitzler [Wed, 6 Sep 2017 09:18:57 +0000 (11:18 +0200)]
[BUGFIX] Unify Extbase base command error

This changes the output of "typo3/sysext/core/bin/typo3 extbase"
to show the standard Symfony error message instead of
a misleading one.

Calling a Symfony base command outputs an error message
with a list of possible commands.

We change the command name of the core command to
get the same behavior for the Extbase base command.

Resolves: #81917
Releases: master, 8.7
Change-Id: I9ba05600a461aceb4180d3e2dd124a5ec3006e08
Reviewed-on: https://review.typo3.org/53926
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[!!!][TASK] Replace GeneralUtility::sysLog() with Logging API 90/54090/8
Markus Klein [Sat, 9 Sep 2017 23:49:27 +0000 (01:49 +0200)]
[!!!][TASK] Replace GeneralUtility::sysLog() with Logging API

The function GeneralUtility::sysLog() is deprecated and all calls
are replaced with direct calls to according Logging API methods.

The usual configuration options of the Logging API allows to
define all sorts of destinations for log entries, including
the syslog facility as well as file targets.

Resolves: #82430
Releases: master
Change-Id: Ief3f3f14fd10a3ae90b9df4a5e4e7456c2f7619c
Reviewed-on: https://review.typo3.org/54090
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix Fluid template path issues 58/53958/12
Helmut Hummel [Thu, 14 Sep 2017 10:53:23 +0000 (12:53 +0200)]
[BUGFIX] Fix Fluid template path issues

* Widget template override also works with legacy config option
* Runtime cache is removed
* TemplatePathsTests from https://github.com/helhum/fluid_test are
  integrated

Resolves: #82344
Resolves: #82181
Resolves: #73207
Related: #82407
Releases: master, 8.7
Change-Id: Icd0a8aa3f1646315c094ad8768e2ff0bb34033d9
Reviewed-on: https://review.typo3.org/53958
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[FOLLOWUP][TASK] Improve TCA cache 54/54154/2
Oliver Hader [Sun, 17 Sep 2017 18:19:57 +0000 (20:19 +0200)]
[FOLLOWUP][TASK] Improve TCA cache

Allowed classes in the options of unserialize invocation need to
be injected using the 'allowed_classes' array index - the current
implementation is casted to true which allows all classes.

Related: #82408
Releases: master, 8.7
Change-Id: I68fbd873a5a7057630a48586878c77547b532348
Reviewed-on: https://review.typo3.org/54154
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Revert "Improve performance of Fluid TemplatePaths" 47/54147/2
Benni Mack [Thu, 14 Sep 2017 14:52:08 +0000 (16:52 +0200)]
[BUGFIX] Revert "Improve performance of Fluid TemplatePaths"

This reverts commit 31310553bdfe724fd3be0d968cd2b4830bec24b0
due to side-effects introduced with this commit.

Change-Id: I67680820b0e139fea49cfcc0818cd97af3f6b9b9
Resolves: #82487
Reverts: #82232
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54147
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Revert "Remove runtime cache and early return from TemplatePaths" 44/54144/3
Benni Mack [Thu, 14 Sep 2017 13:13:22 +0000 (15:13 +0200)]
[TASK] Revert "Remove runtime cache and early return from TemplatePaths"

This reverts commit 30c467196034ffdedc35e4be205ab4acec28a8c6
due to several side effects.

Change-Id: I43586802a9838faa2723fdcaa2e9e15492003830
Resolves: #82487
Reverts: #82196
Reverts: #82181
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54144
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Remove system environment check for Soap 17/54117/3
Claus Due [Mon, 11 Sep 2017 14:26:28 +0000 (16:26 +0200)]
[TASK] Remove system environment check for Soap

TYPO3 no longer requires the Soap extension and
should not check for it in system environment checks.

This patch removes the check.

Change-Id: I3dc5715889af598054e2451c957a05c13f39b9fa
Resolves: #82452
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54117
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Use TCA to get `type` field instead of hardcoded fieldname 49/53749/8
Sascha Egerer [Mon, 21 Aug 2017 09:16:29 +0000 (11:16 +0200)]
[BUGFIX] Use TCA to get `type` field instead of hardcoded fieldname

The `type` field is configured via TCA and that configuration must
be used instead of hardcoding the fieldname.

Also change arrangement of the DataProvider load order to load
InitializeProcessedTca directly after ReturnUrl. This avoids the
need of accessing $GLOBALS['TCA'].

Resolves: #79954
Releases: master, 8.7
Change-Id: I67cbab00f6f0157c48c749cd8fbcd6cbc0ce1644
Reviewed-on: https://review.typo3.org/53749
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Install tool: Use standalone application in backend context 11/54111/4
Christian Kuhn [Mon, 11 Sep 2017 10:11:30 +0000 (12:11 +0200)]
[BUGFIX] Install tool: Use standalone application in backend context

With recent routing changes the install tool "backend context" has
been switched to a "normal" backend module loaded directly from
within the backend application. The standalone is an own application
with its own bootstrap.
This leads to various issues in the install tool since the backend
and standalone requests lead to different bootstrap states, for
instance TCA is initialized in BE context, but isn't in standalone.
Within backend, this won't change until the backend application can
bootstrap to different states depending on a controller.
To solve install tool related issues for now, the BackendModuleController
of the install tool called from within backend now starts a casual
install tool session and marks this session as "initiated from a
valid system maintainer". It then redirects to the standalone
application which omits login and enable install tool file check if
the session is marked as backend user session.

Change-Id: I352e6d04e7a91c56ccf2383f784ae94464c9aacd
Resolves: #82448
Related: #82306
Releases: master
Reviewed-on: https://review.typo3.org/54111
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Move flash message handling from DocumentTemplate to own class 00/53200/3
Georg Ringer [Tue, 13 Jun 2017 12:33:57 +0000 (14:33 +0200)]
[TASK] Move flash message handling from DocumentTemplate to own class

To simplify the class \TYPO3\CMS\Backend\Template\DocumentTemplate, the
AJAX based flash message handling is moved to an own class.

Adding a RST file will be added with other removals within DocumentTemplate.

Resolves: #81564
Releases: master
Change-Id: Icff696f2dc8a2a895711218b86ea529128506161
Reviewed-on: https://review.typo3.org/53200
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Improve TCA cache 62/54062/4
Helmut Hummel [Sat, 9 Sep 2017 12:32:20 +0000 (14:32 +0200)]
[TASK] Improve TCA cache

Currently TCA is cached as serialized string using
the core cache.

Simplify the cache retrieval by taking advantage of
the code cache by using requireOnce and previously
storing the cache as PHP file that returns an array.
This significantly improves performance
with opcode cache enabled.

The cache identifier is changed to avoid conflicts
with previously stored data.

Resolves: #82408
Releases: master, 8.7
Change-Id: I59210fa800d10c14d21aceb7416ea418988d6ca5
Reviewed-on: https://review.typo3.org/54062
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[FEATURE] Inject logger into newly created objects 01/54101/9
Markus Klein [Sun, 10 Sep 2017 12:06:11 +0000 (14:06 +0200)]
[FEATURE] Inject logger into newly created objects

Instantiating new objects with makeInstance or the ObjectManager
will automatically inject a logger into the new objects, if those
implement the LoggerAwareInterface.

Resolves: #82441
Releases: master
Change-Id: I38e1a4619857f3fc2d88b0b95a9721b289c679d3
Reviewed-on: https://review.typo3.org/54101
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[!!!][BUGFIX] EXT:form - FlexForm settings overrule TypoScript settings 71/54071/6
Łukasz Uznański [Sat, 9 Sep 2017 16:35:10 +0000 (18:35 +0200)]
[!!!][BUGFIX] EXT:form - FlexForm settings overrule TypoScript settings

Releases: master
Resolves: #82252
Change-Id: I5cddefe1fd3fbf97e2cdc1aea1f373ef2076da72
Reviewed-on: https://review.typo3.org/54071
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use Response objects directly in Install Tool actions 59/54059/6
Benni Mack [Sat, 9 Sep 2017 11:48:42 +0000 (13:48 +0200)]
[TASK] Use Response objects directly in Install Tool actions

The patch introduces three shorthand Response classes for output:
HtmlResponse, JsonResponse and RedirectResponse which are used
throughout all the actions inside the Install Tool.

Resolves: #82415
Releases: master
Change-Id: I9edc15c341084fcb59a3b1dc45b42a6f65d87e7f
Reviewed-on: https://review.typo3.org/54059
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fluid: Strict type checking when adding debug namespace 32/53832/3
Benni Mack [Wed, 30 Aug 2017 06:13:13 +0000 (08:13 +0200)]
[BUGFIX] Fluid: Strict type checking when adding debug namespace

The check on BE_USER->uc() in frontend context is cleaned up and more
strict, checking whether the object exists currently.

Additionally, the specific request type is used here.

Resolves: #82397
Releases: master, 8.7
Change-Id: Ibe0b533c23e1ba9c35ed2b6b9b0301e1a449c2e3
Reviewed-on: https://review.typo3.org/53832
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[!!!][TASK] Remove legacy entrypoint for Install Tool 93/54093/2
Benni Mack [Sun, 10 Sep 2017 09:27:23 +0000 (11:27 +0200)]
[!!!][TASK] Remove legacy entrypoint for Install Tool

The entrypoint located under "typo3/sysext/install/Start/Install.php" has been
removed, as the entrypoint "typo3/install.php" is the new way to access the install
tool. The legacy entrypoint "typo3/install/index.php" will still be kept, as it is
easy for existing users to get a simple redirect (still marked as deprecated).

Resolves: #82433
Releases: master
Change-Id: I36a165649c7ca5a988379b70328e570fc45285b0
Reviewed-on: https://review.typo3.org/54093
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>