Packages/TYPO3.CMS.git
22 months ago[BUGFIX] Prevent uncaught exception in Import/Export controller 82/53282/3
Nicole Cordes [Tue, 4 Apr 2017 13:26:43 +0000 (15:26 +0200)]
[BUGFIX] Prevent uncaught exception in Import/Export controller

Currently an error is thrown if no post data was sent to the
ImportExportController. This can easily happen if a t3d file should
be uploaded but is larger than the configured post_max_size of the
server. This patch checks the incoming information, sets the import
action as default and displays an information to the user that he/she
may have tried to upload a file that was too large.

Resolves: #80681
Releases: master, 8.7, 7.6
Change-Id: I561dbf6abd74acace3eff179a513b4f9128d792d
Reviewed-on: https://review.typo3.org/53282
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Select suitable distribution version in em 49/53249/6
Christian Kuhn [Sun, 18 Jun 2017 11:48:56 +0000 (13:48 +0200)]
[BUGFIX] Select suitable distribution version in em

The distribution installer selects current_version=1
extensons only and fails in core v7 since the current
introduction version is not compatible with v7 anymore.

The patch changes version selection a bit to first find
all distribution extensions, then filters those suitable
for given core version, then filters latest version of
the distribution extension.

Installing introduction package in 7.6 works again.

Change-Id: I11f2def2ea606ada5f7c3efd3043f59bd4be0452
Resolves: #81068
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/53249
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Remove possibly undefined constant from test bootstraps 39/53239/2
Anja Leichsenring [Sat, 17 Jun 2017 13:09:53 +0000 (15:09 +0200)]
[BUGFIX] Remove possibly undefined constant from test bootstraps

The constant LF might not be defined in functional and unit test
bootstrap by the time the script terminates with an error message.

Replacing the usage of this constant with the native value for a
linebreak causes the same result for the error message, but prevents
the additional and confusing messages about the not existing constant.

Change-Id: I66bd2092875e33fa8bb93a2a57c54daeaeb15ecf
Resolves: #81599
Releases: 7.6
Reviewed-on: https://review.typo3.org/53239
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Remove manually set database row 10/53210/2
Susanne Moog [Wed, 14 Jun 2017 08:49:55 +0000 (10:49 +0200)]
[BUGFIX] Remove manually set database row

databaseRow should not be set incompletely in a
FormDataProvider or controller as subsequent
processing may rely on the complete database
row being set (for example language fields).

Resolves: #80855
Related: #80100
Release: master, 8.7, 7.6
Change-Id: I139b426c6598a93a2012cae088e3cbece4e1a83b
Reviewed-on: https://review.typo3.org/53210
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Prefix single digit dates with 0 instead of whitespace 92/53192/3
Sascha Egerer [Mon, 12 Jun 2017 11:05:46 +0000 (13:05 +0200)]
[BUGFIX] Prefix single digit dates with 0 instead of whitespace

The backend query view, used for csv exports and lists, uses a date
format where single digit days of a date value are prefixed with a
whitespace instead of a 0.
This ends up in useless CSV exports that can not be interpreted by
tools like Excel.

Change-Id: Ie11c5f8a923eb412f014f06df528a2aa0101a0d4
Resolves: #81551
Releases: master,8.7,7.6
Reviewed-on: https://review.typo3.org/53192
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
22 months ago[BUGFIX] Wrong computed baseURL with FE editing RTE 42/52142/2
Jigal van Hemert [Fri, 24 Mar 2017 14:01:08 +0000 (15:01 +0100)]
[BUGFIX] Wrong computed baseURL with FE editing RTE

Frontend editing button for editing a content now
url encode the return URL. The HTMLAREA baseURL
computation now excludes query parameters and anchor
from the document URL.

Resolves: #79568
Related: #65705
Related: #65608
Releases: 7.6
Change-Id: I57ae5257ab62cff1398a0b2d088fe7ba3b126c76
Reviewed-on: https://review.typo3.org/52142
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Return http_code for HEAD requests in GeneralUtility::getUrl 94/51994/4
Nicole Cordes [Fri, 10 Mar 2017 00:07:49 +0000 (01:07 +0100)]
[BUGFIX] Return http_code for HEAD requests in GeneralUtility::getUrl

As there is no content available for a HEAD request
GeneralUtility::getUrl currently returns an error message for HEAD
requests instead of proper http_code information. This patch ensures
all information are available.

Resolves: #80220
Releases: 7.6
Change-Id: I64108a16846a294f0bbee07289afcb79474833ea
Reviewed-on: https://review.typo3.org/51994
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[BUGFIX] Detect upper limit of database server version 48/53148/4
Markus Klein [Wed, 7 Jun 2017 08:44:55 +0000 (10:44 +0200)]
[BUGFIX] Detect upper limit of database server version

Resolves: #81341
Releases: 7.6
Change-Id: Ia188901497d29ff2a2274a4bf220e7c58e665487
Reviewed-on: https://review.typo3.org/53148
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
22 months ago[BUGFIX] FormEngine: Show correct error message (render)Type is unknown 43/53143/2
Markus Klein [Tue, 6 Jun 2017 14:40:45 +0000 (16:40 +0200)]
[BUGFIX] FormEngine: Show correct error message (render)Type is unknown

Issue correct error message if the renderType (or the type) is unknown.
The message now includes also the renderType, if specified.

Releases: master, 8.7, 7.6
Resolves: #81485
Change-Id: I44e736a546fc27733a8c8df14089dd25dc172f2b
Reviewed-on: https://review.typo3.org/53143
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Add sitemap to sysext:core/Documentation 35/53135/2
Martin Bless [Tue, 6 Jun 2017 07:55:48 +0000 (09:55 +0200)]
[TASK] Add sitemap to sysext:core/Documentation

Resolves: #81477
Releases: master, 8.7, 7.6
Change-Id: Ie98fcc81c386fe5704c669f36220827f7cfbd2e5
Reviewed-on: https://review.typo3.org/53135
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[BUGFIX] Hide empty descriptions in textmedia in page module 95/53095/2
Jigal van Hemert [Sat, 3 Jun 2017 15:30:39 +0000 (17:30 +0200)]
[BUGFIX] Hide empty descriptions in textmedia in page module

In the Page module with textmedia content elements the descriptions
are shown below the thumbnails of linked media. If there is no
description an empty line is now suppressed.

Resolves: #81408
Releases: master, 8.7, 7.6
Change-Id: I9f342908f179550bcf2156328117c464bb8c672f
Reviewed-on: https://review.typo3.org/53095
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Avoid unnecessarily fetching file for processing 33/53033/2
Helmut Hummel [Sat, 20 May 2017 09:29:45 +0000 (11:29 +0200)]
[BUGFIX] Avoid unnecessarily fetching file for processing

Files that are not configured as images, won't be processed,
but are still unnecessarily fetched for processing.

To avoid this, we change the processing API, that fetching
only happens, if the file is then used by following code.

In addition we avoid showing a non descriptive thumb
in FileInfoElement, which is used when editing meta data of the file.

Resolves: #81279
Releases: master, 8.7, 7.6
Change-Id: Ie68aa02b1b6149ddb7fbda346ac312d3646e260c
Reviewed-on: https://review.typo3.org/53033
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Ensure correct URL generation with http_build_query() 66/52966/2
Markus Klein [Wed, 24 May 2017 12:09:42 +0000 (14:09 +0200)]
[BUGFIX] Ensure correct URL generation with http_build_query()

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
This does not seem appropriate for URLs generated by TYPO3.

Use the optional parameters of http_build_query() to get the desired
functionality.

Releases: master, 8.7, 7.6
Resolves: #81366
Change-Id: Ie2df9207b1967257d6327ff1103503e6a58d5cdf
Reviewed-on: https://review.typo3.org/52966
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[BUGFIX] DBAL: Assure all optional query array parameters are set 86/52386/4
Dan Untenzu [Fri, 7 Apr 2017 13:02:32 +0000 (15:02 +0200)]
[BUGFIX] DBAL: Assure all optional query array parameters are set

The method »exec_SELECT_queryArray« uses an incoming array and
passes all possible query array keys on to the »exec_SELECTquery« method.
If not all keys were set, then »NULL« is passed. It should pass an
empty string however.

To avoid exceptions thrown due to NULL values, the method
now provides a fallback for all optional array keys.

Resolves: #80749
Releases: 7.6
Change-Id: I8cad33503f752062f771a53bade1188b6351d56d
Reviewed-on: https://review.typo3.org/52386
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Use EXEC_TIME for sys_log entry instead of time() 40/52840/2
Helmut Hummel [Wed, 17 May 2017 12:11:04 +0000 (14:11 +0200)]
[BUGFIX] Use EXEC_TIME for sys_log entry instead of time()

DataHandler does a lookup in sys_log table after it performed
its operations to find relevant error entries for the current request.

It determines relevance by looking for entries with the same
timestamp as $GLOBALS['EXEC_TIME'].

However error log entries are written using time(). Now if the
DataHandler operations take longer than one second, or the log entry
is written directly before a next tick, it can happen, that errors
will not be detected during the lookup process.

Since such errors are exposed to the user, it can happen that an operation
fails, but the users will not be notified.

Fix this by using $GLOBALS['EXEC_TIME'] when writing the log entries.

Resolves: #81244
Releases: master, 8.7, 7.6
Change-Id: Ic22b5f51ba4e10991be4a59ae28cb1f77a91c71e
Reviewed-on: https://review.typo3.org/52833
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-on: https://review.typo3.org/52840
Tested-by: TYPO3com <no-reply@typo3.com>
23 months ago[BUGFIX] HtmlArea: Use getAttribute() directly 14/52814/2
Benni Mack [Wed, 17 May 2017 08:17:07 +0000 (10:17 +0200)]
[BUGFIX] HtmlArea: Use getAttribute() directly

RTE HtmlArea uses getAttributeNode() for gecko
browsers, however this is deprecated in current
Firefox versions.

To just get the value of an attribute getAttribute()
can be used instead:

See the usages here:
- https://www.w3schools.com/jsref/met_element_getattributenode.asp
- https://www.w3schools.com/jsref/met_element_getattribute.asp

Resolves: #80934
Releases: 7.6
Change-Id: Ic3962ad7339a56c8d0e7b94a8aaba27a56744bf8
Reviewed-on: https://review.typo3.org/52814
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] Unit test fails with recent PHP releases 19/52819/2
Christian Kuhn [Wed, 17 May 2017 10:24:18 +0000 (12:24 +0200)]
[TASK] Unit test fails with recent PHP releases

Recent PHP unit minor upgrades fixed a bug in DateTimeZone reflection
which is used as test object in our ObjectAccess reflection tests.
Make the test a bit less strict to cope with youngest and older
PHP versions at the same time.

Change-Id: Iaf2290872938f4c04a3307b0fe73c933ca7d69d8
Resolves: #81239
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/52819
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Unset current file in generic Content Object Renderer 12/52812/2
Benjamin Serfhos [Mon, 29 Aug 2016 08:38:22 +0000 (10:38 +0200)]
[BUGFIX] Unset current file in generic Content Object Renderer

When function is done, reset current file for further processing

Resolves: #77645
Releases: master, 8.7, 7.6
Change-Id: Ibae2e3221c51c8cb45f92b0bc7dbe395cc809605
Reviewed-on: https://review.typo3.org/52812
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Add UI blocker to prevent loading issues in FormEngine 77/52777/2
Frank Naegler [Wed, 26 Apr 2017 13:19:37 +0000 (15:19 +0200)]
[BUGFIX] Add UI blocker to prevent loading issues in FormEngine

Resolves: #80672
Releases: master, 8.7, 7.6
Change-Id: I52da6df109531f2a29acbb99b7871dc6227974b7
Reviewed-on: https://review.typo3.org/52777
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Throw explicit exception on missing link handler class 93/52793/2
Mathias Brodala [Fri, 12 May 2017 09:07:19 +0000 (11:07 +0200)]
[TASK] Throw explicit exception on missing link handler class

This adds the link handler identifier to the error message which
makes it easier to fix the missing class reference.

Resolves: #81205
Releases: master, 8.7, 7.6
Change-Id: I0ce610f7ec167704d5cbc5de20d43639c18e3fc1
Reviewed-on: https://review.typo3.org/52793
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] DBAL: Ensure correct mysqli resource for admin_get_tables query 06/52106/2
Nicole Cordes [Mon, 20 Mar 2017 18:01:34 +0000 (19:01 +0100)]
[BUGFIX] DBAL: Ensure correct mysqli resource for admin_get_tables query

The admin_get_tables method tries to fetch all available database tables
from the default connection. But using the native mode, the query is
executed with the $this->lastHandlerKey link which might not be the
default connection. This patch ensures the correct mysqli resource is
used to resolve the database queries.

Resolves: #80358
Releases: 7.6
Change-Id: I3b8224e5377aad64e556052bbea37dae39ca1bb7
Reviewed-on: https://review.typo3.org/52106
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Use renderType selectSingle for field t3_tables of sys_action 70/52770/2
Georg Ringer [Wed, 3 May 2017 03:48:50 +0000 (05:48 +0200)]
[BUGFIX] Use renderType selectSingle for field t3_tables of sys_action

The field t3_tables of sys_action must be rendered as a single
select field. This was also the behaviour before the regression
introduced with #69822.

Resolves: #81119
Releases: master, 8.7, 7.6
Change-Id: I2c885ea3494d7e2be22fad6df1b2a4791991551b
Reviewed-on: https://review.typo3.org/52770
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Reload page tree after deleting pages 00/52700/3
Gianluigi Martino [Mon, 9 May 2016 12:56:41 +0000 (14:56 +0200)]
[BUGFIX] Reload page tree after deleting pages

After deleting a subpage the page tree doesn't reload so you don't have
the delete button in context menu from the parent page. With this bugfix
the page tree reloads after deleting pages and deleting parent pages is
possible again.

Change-Id: I9450261052ce07155fc2eff550b4547564dbf880
Resolves: #75436
Releases: 7.6
Reviewed-on: https://review.typo3.org/52700
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] INCLUDE_TYPOSCRIPT condition use correct ConditionMatcher 61/52761/2
Andreas Allacher [Wed, 22 Mar 2017 07:25:35 +0000 (08:25 +0100)]
[BUGFIX] INCLUDE_TYPOSCRIPT condition use correct ConditionMatcher

In order to support all conditions correctly
whether one is in FE or BE the condition
has to be matched against the correct
ConditionMatcher instead of always
using the one for BE.

Releases: master, 8.7, 7.6
Resolves: #80385
Change-Id: Id5e216da40000b408f96822855d97799f254d0fb
Reviewed-on: https://review.typo3.org/52761
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
23 months ago[BUGFIX] Add missing SQL index for EM repository update 43/52743/2
Claus Due [Mon, 1 May 2017 15:29:51 +0000 (17:29 +0200)]
[BUGFIX] Add missing SQL index for EM repository update

Due to the large number of extensions, the query that
checks if an extension exists needs an index that
covers all of the columns used for joining/clauses.

Resolves: #81097
Releases: 7.6, 8.7, master
Change-Id: I73bd78a7d923a1e49594374b0dd8fee270fa30a3
Reviewed-on: https://review.typo3.org/52743
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Load PageTSconfig in localconf for LinkHandler 48/52648/3
Benni Mack [Fri, 28 Apr 2017 09:59:34 +0000 (11:59 +0200)]
[BUGFIX] Load PageTSconfig in localconf for LinkHandler

The pageTSconfig for LinkHandler is only loaded in ext_tables.php
which means it is only evaluated in the Frontend when a Backend User
is logged in.

However the functionality did work before, if a compiled pageTS was
available in the cache. This could have happened that the pageTS cache
was filled while a BE user was logged in, so it worked (but only in
random cases).

Resolves: #81057
Releases: master, 8.7, 7.6
Change-Id: Ib7cd62f82dff3a3b891dcb36e85c36b9a062142a
Reviewed-on: https://review.typo3.org/52648
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Marc Bastian Heinrichs <typo3@mbh-software.de>
Tested-by: Marc Bastian Heinrichs <typo3@mbh-software.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[BUGFIX] Add `config.contentObjectExceptionHandler` to tsref.xml 99/52699/2
Andreas Fernandez [Mon, 1 May 2017 09:41:28 +0000 (11:41 +0200)]
[BUGFIX] Add `config.contentObjectExceptionHandler` to tsref.xml

The TypoScript setting `config.contentObjectExceptionHandler` was
introduced in TYPO3 7.0 but is still missing in tsref.xml. This patch
adds the configuration.

Resolves: #81093
Releases: master, 8.7, 7.6
Change-Id: Ib46891699aca91329aef302d87e562ac317892f2
Reviewed-on: https://review.typo3.org/52699
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
23 months ago[TASK] Show copy and cut buttons in filelist options 88/52688/2
Gianluigi Martino [Thu, 20 Apr 2017 16:15:24 +0000 (18:15 +0200)]
[TASK] Show copy and cut buttons in filelist options

At the moment it is only possible to copy or cut files / folder over the
clickmenu. With this patch the copy and cut functions are also listed as
buttons in option list.

Resolves: #80920
Releases: master, 8.7, 7.6
Change-Id: I75d4b8666858b78c4ed01514d43af4471cef5c2e
Reviewed-on: https://review.typo3.org/52688
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Do not prefix FAL file links with absRefPrefix 15/52615/2
Helmut Hummel [Thu, 6 Apr 2017 20:31:36 +0000 (22:31 +0200)]
[BUGFIX] Do not prefix FAL file links with absRefPrefix

When using an external FAL storage the public URLs of files contain a scheme.
Check for the scheme before prefixing with absRefPrefix
in file link builder.

Resolves: #80740
Releases: 7.6, master
Change-Id: I98c1027931f6c4c05561e35d1d7938aefd66eda0
Reviewed-on: https://review.typo3.org/52615
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[TASK] Move CSV fixtures handling to FunctionalTestCase 09/52609/2
Tymoteusz Motylewski [Mon, 27 Feb 2017 08:45:03 +0000 (09:45 +0100)]
[TASK] Move CSV fixtures handling to FunctionalTestCase

Usage of CSV fixtures is now possible for all functional tests.
Previously it was available only for DataHandler tests.
This patch is backward compatible.

Resolves: #80007
Releases: master, 7.6
Change-Id: I6aa69825ac144b8c955b51a61060a822163511ca
Reviewed-on: https://review.typo3.org/52609
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Do not ask for current password if admin 57/52557/2
Markus Klein [Fri, 21 Apr 2017 20:29:43 +0000 (22:29 +0200)]
[BUGFIX] Do not ask for current password if admin

Hide the field for the current password, if the current user is
admin anyway. If the admin changes the password for someone else
he/she doesn't know the current password of this person anyway.

Besides that, a password can always be changed without providing
a current password by an admin using the BE users module.

Resolves: #80951
Releases: master, 8.7, 7.6
Change-Id: Ic9673197e651df5d1fe5886c4b6f6f76a303062f
Reviewed-on: https://review.typo3.org/52556
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-on: https://review.typo3.org/52557

2 years ago[BUGFIX] Use real BE user for logging user setting changes 55/52555/2
Markus Klein [Fri, 21 Apr 2017 19:14:52 +0000 (21:14 +0200)]
[BUGFIX] Use real BE user for logging user setting changes

When editing someone else's user settings as admin the log
should still show the editing user as responsible for the changes.

Resolves: #80947
Releases: master, 8.7, 7.6
Change-Id: I4d57826d65ae34325bea9efdfbd076e47fff0d6d
Reviewed-on: https://review.typo3.org/52555
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Set TYPO3 version to 7.6.19-dev 92/52492/2
TYPO3 Release Team [Tue, 18 Apr 2017 17:29:32 +0000 (19:29 +0200)]
[TASK] Set TYPO3 version to 7.6.19-dev

Change-Id: I9a931e059c314b94ab7503fa40c3cad5c0dce56a
Reviewed-on: https://review.typo3.org/52492
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 7.6.18 91/52491/2 7.6.18 TYPO3_7-6-18
TYPO3 Release Team [Tue, 18 Apr 2017 17:27:27 +0000 (19:27 +0200)]
[RELEASE] Release of TYPO3 7.6.18

Change-Id: I8fa37a25ec062e5289085002089464ba55974887
Reviewed-on: https://review.typo3.org/52491
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[TASK] Set TYPO3 version to 7.6.18-dev 87/52487/2
Oliver Hader [Tue, 18 Apr 2017 16:43:58 +0000 (18:43 +0200)]
[TASK] Set TYPO3 version to 7.6.18-dev

Change-Id: I5b932d80ec319a6d33f1455e215d34d11863b102
Reviewed-on: https://review.typo3.org/52487
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[RELEASE] Release of TYPO3 7.6.17 84/52484/2
TYPO3 Release Team [Tue, 18 Apr 2017 16:29:26 +0000 (18:29 +0200)]
[RELEASE] Release of TYPO3 7.6.17

Change-Id: I21120dbe9ded68bce004a24a6134ab18f0ce5f9a
Reviewed-on: https://review.typo3.org/52484
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[BUGFIX] Use correct value for EU flag in sys_language records 68/52468/2 7.6.17 TYPO3_7-6-17
Daniel Goerz [Thu, 13 Apr 2017 07:50:42 +0000 (09:50 +0200)]
[BUGFIX] Use correct value for EU flag in sys_language records

Change-Id: I6cb873b0013f8324f247a19de4f663ca2e4d4848
Resolves: #80834
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Correct view webpage link anchor in list module 91/52391/2
Gianluigi Martino [Mon, 3 Apr 2017 12:18:46 +0000 (14:18 +0200)]
[TASK] Correct view webpage link anchor in list module

Without this patch you land to the top of the page if you open the preview
of a content element in list module. Adding "c" as letter to the anchor
link the browser scroll to the desired content element.

Resolves: #80598
Releases: master, 7.6
Change-Id: Ief0c3764a57911f9dd46dd7b9e19be964b0e2671
Reviewed-on: https://review.typo3.org/52391
Reviewed-by: Elmar Hinz <t3elmar@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Allow file replace for editors 88/52388/3
Helmut Hummel [Thu, 6 Apr 2017 19:07:16 +0000 (21:07 +0200)]
[BUGFIX] Allow file replace for editors

When file extension permissions are configured, replacing
a file fails with an error message, because the file extension
is checked on the local path of the temporary file.

Remove this bogus check to allow file replace for editors.

Resolves: #77855
Releases: 6.2, 7.6, master
Change-Id: Icaf01252b3dbcfbdfb89349281389465f9e0ce9a
Reviewed-on: https://review.typo3.org/52388
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Avoid unused xpath when parsing locallang.xml 69/52369/2
Stephan Großberndt [Sat, 25 Feb 2017 11:30:09 +0000 (12:30 +0100)]
[TASK] Avoid unused xpath when parsing locallang.xml

Increased performance by avoiding an xpath query if the requested
element is not 'target'.

Releases: master, 7.6
Resolves: #80016
Change-Id: I509de5bfb79701efe966d16bc29aaae6a46050ef
Reviewed-on: https://review.typo3.org/52369
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Do not devlog bad code smells of core classes 54/52054/3
Markus Klein [Sun, 12 Mar 2017 15:58:51 +0000 (16:58 +0100)]
[BUGFIX] Do not devlog bad code smells of core classes

Releases: 7.6, 6.2
Resolves: #48544
Change-Id: If58f3a5c9c6a1003a0301bd2d68622ee8ccba843
Reviewed-on: https://review.typo3.org/52054
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Bruckmoser <dev@abavo.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Inline references are bound to versioned page 43/52343/2
Oliver Hader [Mon, 3 Apr 2017 16:25:59 +0000 (18:25 +0200)]
[BUGFIX] Inline references are bound to versioned page

When modifying inline child elements that belong to a page
as parent record in a workspace, the pid values of these
inline children are bound to the page version instead of
the according counterpart (real record or placeholder)
of the live workspace.

Change-Id: I113b5c36672e767d4151f8a41ff9c5fa20b11877
Resolves: #80663
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52343
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Fix check to determine RTEhtmlarea is in fullscreen mode 39/52339/2
Wouter Wolters [Mon, 3 Apr 2017 13:11:32 +0000 (15:11 +0200)]
[BUGFIX] Fix check to determine RTEhtmlarea is in fullscreen mode

Due to the implementation of routes the check fails. Check against
the route instead.

Resolves: #78731
Releases: 7.6
Change-Id: Ifef945aa076c36755bc7193bc4702651402181c7
Reviewed-on: https://review.typo3.org/52339
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Rudy Gnodde <rgn@windinternet.nl>
Tested-by: Rudy Gnodde <rgn@windinternet.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Use English labels if browser's preferred language is English 25/52325/2
Xavier Perseguers [Mon, 3 Apr 2017 09:13:01 +0000 (11:13 +0200)]
[BUGFIX] Use English labels if browser's preferred language is English

Change-Id: Ic9cb3f3e3e0547e4a0d34bf50f481e2f3844f610
Resolves: #80593
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52325
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update readme copyright date to 2017 27/52327/2
Dennis [Mon, 3 Apr 2017 08:02:54 +0000 (10:02 +0200)]
[TASK] Update readme copyright date to 2017

Releases: master,7.6
Resolves: #80645
Change-Id: I346a18f4f8983ee570bb5f0cae1e6635335f7d73
Reviewed-on: https://review.typo3.org/52327
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] MM relations of localizations not resolved in functional tests 18/52318/2
Oliver Hader [Sun, 2 Apr 2017 17:39:36 +0000 (19:39 +0200)]
[BUGFIX] MM relations of localizations not resolved in functional tests

* value of _ORIG_uid -> version record
* value of _LOCALIZED_UID -> localized record
* value of uid -> non-overlaid record

Change-Id: I35cc1e94b68a7725e71a469e557bc34f7c952a21
Resolves: #80638
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52318
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Fix scheduler task logging in case of an exception 92/52292/2
Christian Wolff [Fri, 31 Mar 2017 07:23:49 +0000 (09:23 +0200)]
[BUGFIX] Fix scheduler task logging in case of an exception

Correctly log the message if a Scheduler task throws an exception.
The exception code is now part of the logged message too.

Resolves: #80566
Releases: master, 7.6
Change-Id: Ic4eb25608094869733b4a23057d209fab1a1bccf
Reviewed-on: https://review.typo3.org/52292
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] FAL: Correctly iterate folder content with offset 87/52287/2
Markus Klein [Thu, 30 Mar 2017 22:06:58 +0000 (00:06 +0200)]
[BUGFIX] FAL: Correctly iterate folder content with offset

Whenever a list of files of a folder is queried with an offset
make sure we handle filtered files correctly by not taking them
into account when searching for the first eligible file for the
result.

A direct seek() to the start position is wrong as those first files
may contain files would be later on filtered.
The solution is to iterate the whole file list and only count
non-filtered elements to reach the correct starting point.

Releases: master, 7.6, 6.2
Resolves: #80589
Change-Id: I79a6d298599d31aa49c36fd51cc5bbe2cf2ccf3a
Reviewed-on: https://review.typo3.org/52287
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Coalesce hook calls in DataHandler::processRemapStack() 57/52257/2
Thomas Hohn [Mon, 6 Feb 2017 11:01:25 +0000 (12:01 +0100)]
[BUGFIX] Coalesce hook calls in DataHandler::processRemapStack()

DataHandler's hook processDatamap_afterDatabaseOperations is processed
in two ways. In case modifications do not contain any new relation that
just has been created, the hook is executed directly. If that's not the
case, executing this hook is deferred and will happen after the remap
stack has been processed.

Calling the hook directly happens exactly once for each modified record,
where invocations in DataHandler::processRemapStack() might happen more
than once, depending on the amount of relation fields that contain new
references and have been remapped.

This change coalesces these invocations which results that the hooks
processDatamap_afterDatabaseOperations is exactly called once for each
modified record - which is the expected behavior.

Change-Id: Ib7e65ce170c8f9ba8f7577b79073b1ed9213a0b9
Resolves: #79635
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51552
Reviewed-on: https://review.typo3.org/52257
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Integrate tests for DataHandler hook invocations 54/52254/3
Oliver Hader [Mon, 27 Mar 2017 16:28:02 +0000 (18:28 +0200)]
[TASK] Integrate tests for DataHandler hook invocations

Change-Id: I69beabad3e4b9419778d1ed7d1b181349089b139
Resolves: #80494
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52190
Reviewed-on: https://review.typo3.org/52254
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] JS: Fix FormEngine initialization 08/52208/4
Markus Klein [Mon, 27 Mar 2017 13:51:07 +0000 (15:51 +0200)]
[BUGFIX] JS: Fix FormEngine initialization

The FormEngine initialization process needs to be very careful
when the DOM is accessed.
This patch separates the routines and encapsulates those in
a DOMready handler, which are critical.

This solves a possible race condition when JS is executed faster
than DOM is built.

Releases: master, 7.6
Resolves: #80481
Resolves: #80366
Change-Id: I205aebc9f87a25f06942f923497f7f535fdb0c8f
Reviewed-on: https://review.typo3.org/52208
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Fix namespace declaration for checkboxes in plain form mails 29/52229/3
Ronny Sternecker [Wed, 29 Mar 2017 06:50:53 +0000 (08:50 +0200)]
[BUGFIX] Fix namespace declaration for checkboxes in plain form mails

In system extension form emails from form data are generated by a
PostProcessor. The partial for checkbox elements on plain text mails
missed a preliminary blancket in namespace declaration
(first character in this file). This bracket is added.

Resolves: #80518
Releases: 7.6
Change-Id: Ib3b4e27d645d86c4dc75a0da66c86ebb48f0242a
Reviewed-on: https://review.typo3.org/52229
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Check correct variable in BrowseLinksController 15/52215/2
Christer Vindberg [Tue, 28 Mar 2017 07:10:31 +0000 (09:10 +0200)]
[BUGFIX] Check correct variable in BrowseLinksController

Make sure to check the correct variable classesAnchorDefaultTitle
when fetching the title of anchors.

This affects CKeditor as well as htmlarea.

Resolves: #80209
Releases: master, 7.6
Change-Id: I1cdd760ee1fe2879ac53edff38f25515d656d706
Reviewed-on: https://review.typo3.org/52215
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] JS: Invert dependency definition for FormEngine and Validation 07/52207/3
Markus Klein [Mon, 27 Mar 2017 13:45:58 +0000 (15:45 +0200)]
[BUGFIX] JS: Invert dependency definition for FormEngine and Validation

FormEngineValidation is meant as integral part of FormEngine.
The current dependency definition is inverted, such that FormEngine
now depends on FormEngineValidation and not the other way around.
Note that FormEngineValidation does not need any other feature
of FormEngine, so this is safe.

This solves a possible race condition with other modules.

Releases: master, 7.6
Resolves: #80459
Change-Id: Ie2cb9dd90220b37a98bc8e3ca174fd074488cc8d
Reviewed-on: https://review.typo3.org/52207
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Avoid remapping empty value in checkValueForInline 71/52171/2
Claus Due [Wed, 21 Dec 2016 15:44:14 +0000 (16:44 +0100)]
[BUGFIX] Avoid remapping empty value in checkValueForInline

This change prevents checkValueForInline from processing
empty values. The existing check would process empty
values since one of the true matches is when value cannot
be interpreted as an integer.

Change-Id: Iacd38363bcc23453da9fcc2eea359680c6b91175
Resolves: #79063
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51015
Reviewed-on: https://review.typo3.org/52171
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Decrease z-index for disabled fields in FormEngine 65/52165/2
Andreas Fernandez [Sat, 25 Mar 2017 15:55:48 +0000 (16:55 +0100)]
[BUGFIX] Decrease z-index for disabled fields in FormEngine

The z-index for disabled input fields is decreased to a much lower value
to avoid overlaying the module header bar.

Resolves: #80428
Releases: master, 7.6
Change-Id: Ia6f861fc66269b843571720e31f4f935d5cc9614
Reviewed-on: https://review.typo3.org/52165
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Start click binding only after DOM is ready 43/52143/3
Frank Naegler [Thu, 23 Mar 2017 13:46:51 +0000 (14:46 +0100)]
[BUGFIX] Start click binding only after DOM is ready

This patch fixes a loading issue on poor internet connections.
In case of a slow internet connection the icons are not loaded and the
click binding does not work. A DOM ready check should solve the issue.

Resolves: #80416
Releases: master, 7.6
Change-Id: Ia79f14e9dbe0b44a22c5916073b4649211b0bd7b
Reviewed-on: https://review.typo3.org/52143
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Nägler <frank.naegler@typo3.org>
Tested-by: Frank Nägler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Ensure correct sorting of extension configuration 35/52135/2
Nicole Cordes [Tue, 7 Mar 2017 22:18:00 +0000 (23:18 +0100)]
[BUGFIX] Ensure correct sorting of extension configuration

If an extension uses a default subcategory for its configuration but does
not define a sorting order, using PHP >= 7 the order is reversed. This
patch ensures an previously introduced counter is used as identifier.

Resolves: #80180
Related: #76386
Releases: master, 7.6
Change-Id: Ib480632213ebe090688da5ba30c031ca116cf9a9
Reviewed-on: https://review.typo3.org/51980
Reviewed-on: https://review.typo3.org/52135
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Fix tooltip after changing permissions 28/52128/2
Josef Glatz [Wed, 22 Mar 2017 08:29:30 +0000 (09:29 +0100)]
[BUGFIX] Fix tooltip after changing permissions

Fix js tooltip after permission settings are changed
in the permissions backend module.

Resolves: #80387
Releases: master, 7.6
Change-Id: I6be57ff0a48b3245c5e2d1aabc4260720c480e5f
Reviewed-on: https://review.typo3.org/52128
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Add support for target attribute to form viewhelper 73/51973/2
Susanne Moog [Tue, 7 Mar 2017 07:48:48 +0000 (08:48 +0100)]
[BUGFIX] Add support for target attribute to form viewhelper

<f:form> now supports setting target="" as attribute.

Change-Id: Id6bd5f136b3ca6a4083f08780796b408ceaf0116
Releases: master,7.6
Resolves: #80159
Reviewed-on: https://review.typo3.org/51971
Reviewed-on: https://review.typo3.org/51973
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Check if install tool enable file exists before removing it 01/52101/2
Michael Stucki [Mon, 20 Mar 2017 13:04:43 +0000 (14:04 +0100)]
[BUGFIX] Check if install tool enable file exists before removing it

The is_file() check got lost during the refactoring in
d855b4707ba1198b6c1dbf856c4377e230da4c4b.

Change-Id: Ia1688099a7ccd32667562e8c7f83fd54bb669f4a
Resolves: #80354
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52101
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Escape dots of flexform field names 82/52082/2
Georg Ringer [Wed, 21 Dec 2016 11:47:06 +0000 (12:47 +0100)]
[BUGFIX] Escape dots of flexform field names

To make inline proper working in JS, the name of the field must be escaped
as it can contain dots.

Resolves: #78985
Releases: master, 7.6
Change-Id: I18c1d85906b9710c25b326b89e8104f3ea3c8a29
Reviewed-on: https://review.typo3.org/52082
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Return to content element after un-/hide 55/52055/2
Josef Glatz [Wed, 15 Mar 2017 12:26:46 +0000 (13:26 +0100)]
[TASK] Return to content element after un-/hide

Add the current content element as section to the un-/hide link.

Releases: master, 7.6
Resolves: #80274
Change-Id: I0d6ec4ea8274f82f6d4c66a4e9e77860819d4d15
Reviewed-on: https://review.typo3.org/52055
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Return to content element after closing 53/52053/2
Georg Ringer [Tue, 14 Mar 2017 13:28:30 +0000 (14:28 +0100)]
[TASK] Return to content element after closing

Add the current content element as section to the edit link.
Since #70074, the edit link in the header has been already
improved but other links have been missing.

Resolves: #80273
Releases: master, 7.6
Change-Id: Id7cc236819ccd3306d4638cb65e87aee011a35b3
Reviewed-on: https://review.typo3.org/52053
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Recordlist shows content of wrong folder 52/52052/2
Stefan Fruhen [Tue, 7 Mar 2017 13:21:03 +0000 (14:21 +0100)]
[BUGFIX] Recordlist shows content of wrong folder

Subfolder requires identifier when parent folder is expanded.

Resolves: #80166
Releases: master, 7.6
Change-Id: I5226f425951f9124dcaa3e9780b52354e266382d
Reviewed-on: https://review.typo3.org/52052
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Localize tt_content_defValues in new content element wizard 51/52051/2
Eric Chavaillaz [Mon, 30 Jan 2017 13:09:33 +0000 (14:09 +0100)]
[BUGFIX] Localize tt_content_defValues in new content element wizard

Resolves: #79551
Releases: master, 7.6
Change-Id: I76bf3996b3f76b18f9ff9cc95b70b2e41bbc4143
Reviewed-on: https://review.typo3.org/52051
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Do not overwrite inlineData in mergeResult 50/52050/2
Helmut Hummel [Wed, 8 Mar 2017 20:54:49 +0000 (21:54 +0100)]
[BUGFIX] Do not overwrite inlineData in mergeResult

Instead of merging different inlineData results, the
FormResultCompiler has one seemingly leftover line of code
which overwrites the inlineData, leading to the situation
that only the last inlineData is kept.

In the list module when editing multiple fields with IRRE relations,
this leads to the fact that children can only be added
to the last element.

For some reason the same code does not expose the bug to the end user,
most likely due to different handling of the context data.

Nevertheless this obviously wrong line should also be removed in 7.6.

Releases: master, 7.6
Resolves: #80181
Change-Id: I56cef1c56a36d1760a99c239130c6791869a1978
Reviewed-on: https://review.typo3.org/52050
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Missing max value for title in file reference TCA 47/52047/2
Torben Hansen [Fri, 3 Mar 2017 18:35:53 +0000 (19:35 +0100)]
[BUGFIX] Missing max value for title in file reference TCA

Add a max value of 255 chars for the field "title" and
increase size of field "alternative" in sys_file_reference to
the same size of "parent" field sys_file_metadata in db definition.

Resolves: #80122
Releases: master, 7.6
Change-Id: I9f1e4ef57fbd56e5d6a253409186e16a58c60e2b
Reviewed-on: https://review.typo3.org/52047
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] colPos_list gets respected in language view 44/52044/2
Tobias Kretschmann [Tue, 14 Mar 2017 13:55:23 +0000 (14:55 +0100)]
[BUGFIX] colPos_list gets respected in language view

mod.SHARED.colPos_list is now also respected in
Web > Page > Language View.

Since TYPO3 6.2 the setting was only respected in
Page > Columns View, but should also be taken
into account by the Language View as it is a
SHARED setting.

Releases: master, 7.6
Resolves: #80275
Change-Id: Ibdc90103208d5abbcfba1dbbfee3b87d045885f9
Reviewed-on: https://review.typo3.org/52044
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Bypass fetch of database record if already loaded 03/52003/5
Xavier Perseguers [Thu, 2 Mar 2017 14:51:38 +0000 (15:51 +0100)]
[TASK] Bypass fetch of database record if already loaded

Change-Id: I737f76e497ef4a9c2ce1439cfe09b0b1e75afd73
Resolves: #80100
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/52003
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Make InvalidXmlFileException for language files more verbose 02/52002/2
Andreas Fernandez [Fri, 10 Mar 2017 11:14:45 +0000 (12:14 +0100)]
[TASK] Make InvalidXmlFileException for language files more verbose

The message of the InvalidXmlFileException, thrown when parsing broken
language files now always shows the last occured error in libxml with
the affected file and line.

Resolves: #80224
Releases: master, 7.6
Change-Id: I49949119db73f0c09d997a3e2cf45bf86a9587c8
Reviewed-on: https://review.typo3.org/52002
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EM: Highlighting for insecure/outdated extensions 68/51968/2
Josef Glatz [Tue, 7 Mar 2017 07:22:18 +0000 (08:22 +0100)]
[BUGFIX] EM: Highlighting for insecure/outdated extensions

- Fix styles for extensions marked insecure or outdated
  within the TYPO3 extension manager list.
- Fix and update styles for the extension upload form.

Resolves: #80114
Releases: master, 7.6
Change-Id: If6b6fbf7331c292605c3e0b17aafbaea301825f7
Reviewed-on: https://review.typo3.org/51968
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Respect TypoScript code after not matched include 67/51967/2
Helmut Hummel [Mon, 6 Mar 2017 11:30:46 +0000 (12:30 +0100)]
[BUGFIX] Respect TypoScript code after not matched include

When parsing TypoScript with <INCLUDE which has a condition,
following TypoScript code which is not in an <INCLUDE statement
will be discarded.

Before early returning from a non matched condition, this
code needs to be added.

Resolves: #80150
Releases: master, 7.6
Change-Id: I4ea839012c57e5e7945dde3705aa96839afc58a0
Reviewed-on: https://review.typo3.org/51967
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Incorrect usages of string as array in QueryGenerator 44/51944/2
Christer Vindberg [Wed, 1 Mar 2017 11:46:47 +0000 (12:46 +0100)]
[BUGFIX] Incorrect usages of string as array in QueryGenerator

Changed so an empty $queryConfig is always an array.

$queryConfig is declared as an array but can be used as an array or
string, therefore in PHP 7.1 an exception was thrown.

Resolves: #80075
Releases: master, 7.6
Change-Id: Ifd8b89e0ccce4f93a6c7bee5afe10bf52fa73634
Reviewed-on: https://review.typo3.org/51944
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Felogin: Only wrap header/message if not empty 43/51943/2
Benni Mack [Fri, 3 Mar 2017 10:21:16 +0000 (11:21 +0100)]
[BUGFIX] Felogin: Only wrap header/message if not empty

When adding felogin template the wraps defined by default
of EXT:felogin are always outputted even though it just adds
an empty div/h3 tag around, which looks odd in most installations.

The patch adds a proper required tag to see if the value is actually not
empty.

Resolves: #80110
Releases: master, 7.6
Change-Id: Ia9e4c7d3dc294b30db3f10cdde96f95899aa18ef
Reviewed-on: https://review.typo3.org/51943
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Bind live search click event to search field container 30/51930/2
Andreas Fernandez [Thu, 2 Mar 2017 19:27:28 +0000 (20:27 +0100)]
[BUGFIX] Bind live search click event to search field container

To prevent issues with the click event of the live search which is also
triggered on any other dropdown menu of the topbar, the click event is now
bound to the container that holds the search field and the result list.

Change-Id: Ia5b459580fdc345c26d32fb0181e9005efa92c69
Resolves: #80099
Related: #79938
Releases: 7.6
Reviewed-on: https://review.typo3.org/51930
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Avoid stripping tags for generating diffs 33/51933/2
Georg Ringer [Mon, 9 Jan 2017 18:16:10 +0000 (19:16 +0100)]
[BUGFIX] Avoid stripping tags for generating diffs

Tags must not be stripped away for creating diffs as
those are essential for editors. Otherwise it is not
possible to see changed links or changing a header from
h1 to h2.

Resolves: #78767
Resolves: #79205
Releases: master, 7.6
Change-Id: Icb174f3522354fa8ef5d2b8ccca039e33ef472e7
Reviewed-on: https://review.typo3.org/51933
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Update autocomplete JS widget for BE 63/51763/10
Markus Klein [Mon, 20 Feb 2017 00:41:08 +0000 (01:41 +0100)]
[TASK] Update autocomplete JS widget for BE

Resolves: #79938
Releases: master, 7.6
Change-Id: I50e84f11595ea6e79280084bfbf94d75be646de1
Reviewed-on: https://review.typo3.org/51763
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Set file size to 0 instead to string in ImportExport 99/51899/2
Georg Ringer [Mon, 27 Feb 2017 19:28:55 +0000 (20:28 +0100)]
[BUGFIX] Set file size to 0 instead to string in ImportExport

To avoid errors with PHP 7.1 which is more strict regarding
strings and integers, the file size for soft refs must be
set to 0 instead of an empty string.

Resolves: #79644
Releases: master, 7.6
Change-Id: I246e5ac1599da50b97dac3bdb4fcc959af813ce9
Reviewed-on: https://review.typo3.org/51899
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Set TYPO3 version to 7.6.17-dev 95/51895/2
TYPO3 Release Team [Tue, 28 Feb 2017 10:43:54 +0000 (11:43 +0100)]
[TASK] Set TYPO3 version to 7.6.17-dev

Change-Id: I024470dc57502ab68a894bed56dec109325f5081
Reviewed-on: https://review.typo3.org/51895
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 7.6.16 94/51894/2 7.6.16 TYPO3_7-6-16
TYPO3 Release Team [Tue, 28 Feb 2017 10:42:32 +0000 (11:42 +0100)]
[RELEASE] Release of TYPO3 7.6.16

Change-Id: Id88f3ba69fb637beb3a0d8b1f70e49bbfb39040e
Reviewed-on: https://review.typo3.org/51894
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[SECURITY] Prevent possible XSS in Fluid templates 89/51889/2
Nicole Cordes [Tue, 28 Feb 2017 10:22:25 +0000 (11:22 +0100)]
[SECURITY] Prevent possible XSS in Fluid templates

This patch ensures proper encoding of the output of if-ViewHelpers when
using in inline notation.

The regular expression to find possibly affected usages is:
\{\s*f:if\s*\(.+,\s*(?:then|else):(?>\s*)[^']

Resolves: #79911
Releases: master, 7.6
Security-Commit: c187889fb52c6037abf9ffe033f65903c39f715a
Security-Bulletin: TYPO3-CORE-SA-2017-003
Change-Id: Ia509265b5ce9e0baecc62f33031789c08145df55
Reviewed-on: https://review.typo3.org/51889
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Multiple InlineCSS overrides each other 80/51780/5
Haco [Tue, 21 Feb 2017 12:01:09 +0000 (13:01 +0100)]
[BUGFIX] Multiple InlineCSS overrides each other

The 'Default CSS' (eg. from extensions) & 'Specific Page CSS'
(from TYPO3) can now be used together when "inlineStyle2TempFile = 0"
is set.

Resolves: #77534
Releases: master, 7.6
Change-Id: I22bb68938068a82691ce2132866ef191eac672fd
Reviewed-on: https://review.typo3.org/51780
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] EM: Add title attribute to showAllVersions links 71/51871/2
Josef Glatz [Mon, 27 Feb 2017 06:00:18 +0000 (07:00 +0100)]
[BUGFIX] EM: Add title attribute to showAllVersions links

Add meaningful title attributes to all links which leads to the
showAllVersions action.

Resolves: #80029
Releases: master, 7.6
Change-Id: I85b9ee21514fbffd84734c4149d67237abb19652
Reviewed-on: https://review.typo3.org/51871
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix parameter type in BackendModuleRequestHandler 68/51868/2
Benni Mack [Mon, 27 Feb 2017 05:37:18 +0000 (06:37 +0100)]
[BUGFIX] Fix parameter type in BackendModuleRequestHandler

The function
\TYPO3\CMS\Core\Authentication\BackendUserAuthentication
->getPagePermsClause accepts only an integer value as parameter,
but a boolean value is given in
TYPO3\CMS\Backend\Http\BackendModuleRequestHandler->dispatchModule

Resolves: #79949
Releases: master, 7.6
Change-Id: I6d0e6049ce2f68f361853f5c5ea50984c9448347
Reviewed-on: https://review.typo3.org/51868
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Prevent different constants marker in TS parsing 67/51867/2
Nicole Cordes [Tue, 4 Oct 2016 13:21:57 +0000 (15:21 +0200)]
[BUGFIX] Prevent different constants marker in TS parsing

Currently each time the TypoScript is parsed a new marker for constants,
which are replaces by their value, is generated. This prevents conditions
with replaced constants to be displayed as active. This patch ensures
markers are generated by constants values and therefore stay the same
in different requests.

Resolves: #78142
Related: #72413
Releases: master, 7.6
Change-Id: I4eea83908927ac48930abdd731e7412c04e529c1
Reviewed-on: https://review.typo3.org/51867
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] TCA: Make ###CURRENT_PID### work in foreign_table_where in IRRE 65/51865/2
Nicole Cordes [Mon, 12 Dec 2016 16:53:10 +0000 (17:53 +0100)]
[BUGFIX] TCA: Make ###CURRENT_PID### work in foreign_table_where in IRRE

The patch adds the current database row to the data passed to the select
field rendered by foreign_selector of IRRE.
This data is necessary to properly resolve the ###CURRENT_PID### marker
in a foreign_table_where clause.

Resolves: #78960
Releases: master, 7.6
Change-Id: I17f6b4a78d20c101ef7caab227d23c87f138e8ce
Reviewed-on: https://review.typo3.org/51865
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Extbase: correct handling of mm relations 75/51775/6
Markus Klein [Mon, 20 Feb 2017 23:52:23 +0000 (00:52 +0100)]
[BUGFIX] Extbase: correct handling of mm relations

Resolves: #79931
Releases: 7.6
Change-Id: I5c3aa875e9a083836f29f6af69365d91b99904fa
Reviewed-on: https://review.typo3.org/51775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Add button to reload static database data of an extension 64/51864/2
Nicole Cordes [Fri, 13 Jan 2017 19:16:20 +0000 (20:16 +0100)]
[TASK] Add button to reload static database data of an extension

This patch re-adds the possibility to manually trigger a reload of
static database data an extension might ships. In the EM list view, an
inconspicuous button is added for each extension which has an own
ext_tables_static+adt.sql file. Furthermore the import is changed, so
that a md5 hash of the file content is stored in the database. If the
extension is updated and the content if the file changes, a more visible
button is shown to indicate an update should be considered.

Resolves: #60748
Releases: master, 7.6
Change-Id: I8ccb01d7e1f98a4adfc70a4d1aa80db4e76bbc9d
Reviewed-on: https://review.typo3.org/51864
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[TASK] Update TYPO3 Icons to v1.1.0 47/51847/2
Josef Glatz [Thu, 9 Feb 2017 18:23:40 +0000 (19:23 +0100)]
[TASK] Update TYPO3 Icons to v1.1.0

Update bower dependency. Add 22 new icons via bower
copy task and register them in the IconRegistry.

Resolves: #79715
Releases: master
Change-Id: I76fa9090e5a26bdea01afc52c3edba281bac2771
Reviewed-on: https://review.typo3.org/51847
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Prevent installing incompatible extensions without confirmation 63/51863/2
Nicole Cordes [Fri, 24 Feb 2017 15:32:09 +0000 (16:32 +0100)]
[BUGFIX] Prevent installing incompatible extensions without confirmation

Currently it is possible to install incompatible extensions without
confirming the overlay popup. This patch prevents submitting the
overlay if the button is still disabled.

Resolves: #80005
Releases: master, 7.6
Change-Id: Ia68539cb9ce2a82f1e90aef3823f60cfadee2ce1
Reviewed-on: https://review.typo3.org/51863
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Fix non-302 redirects for PSR-7 response objects 15/51815/2
Benjamin Franzke [Tue, 20 Dec 2016 06:26:42 +0000 (07:26 +0100)]
[BUGFIX] Fix non-302 redirects for PSR-7 response objects

All redirect status codes (e.g. 201,301,303,307) are incorrectly
sent as 302.

We need to set the response code before setting the Location header,
as a call to header('Location: ...'); sets the response code
implicitly to 302 (unless it has already been set to 201 or 3xx) [1].
By settings the status code/header first, header('Location: ..') will
not change the status code, if the PSR-7 response object contains a
proper redirect status code.

[1] http://php.net/manual/en/function.header.php
    The second special case is the "Location:" header.
    Not only does it send this header back to the browser, but it also
    returns a REDIRECT (302) status code to the browser unless the 201
    or a 3xx status code has already been set.

Change-Id: Ifa076e6393c6ed42d93959fe8c3a5b79cee145a4
Fixes: #79043
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51815
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] InvalidXmlFileException for invalid locallang.xml 57/51857/2
Sascha Egerer [Sun, 19 Feb 2017 20:34:53 +0000 (21:34 +0100)]
[BUGFIX] InvalidXmlFileException for invalid locallang.xml

Throw a meaningful InvalidXmlFileException when an invalid locallang.xml
file is detected.

Resolves: #79908
Releases: master, 7.6
Change-Id: Idc5586166d2475edeaeef407128525ea57fb9a09
Reviewed-on: https://review.typo3.org/51857
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Correct handling of ObjectStorage objects in PaginateController 49/51849/2
Nicole Cordes [Mon, 30 Jan 2017 18:01:32 +0000 (19:01 +0100)]
[BUGFIX] Correct handling of ObjectStorage objects in PaginateController

The current implementation for getting paginated items from ObjectStorage
objects in TYPO3\CMS\Fluid\ViewHelpers\Widget\Controller\PaginateController
enforces null items if the count of objects is lower than the
itemsPerPage count. This patch calculates the correct count and returns
valid items only.

Resolves: #79559
Releases: master, 7.6
Change-Id: I5746d83120474d6246da949f67096459ed1076d7
Reviewed-on: https://review.typo3.org/51849
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Ignore invalid files in LocalDriver::getDirectoryItemList 45/51845/3
Nicole Cordes [Mon, 13 Feb 2017 13:22:39 +0000 (14:22 +0100)]
[BUGFIX] Ignore invalid files in LocalDriver::getDirectoryItemList

Due to some security changes in GeneralUtility::validPathStr some
wrongly encoded files are now returned as invalid. This breaks e.g. the
file list.
This patch adds a try/catch block to ignore invalid files and return the
valid ones.

Resolves: #79776
Releases: master, 7.6, 6.2
Change-Id: Iaa3697b04c123bba61a426fdf39ee3959f68b705
Reviewed-on: https://review.typo3.org/51845
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Fix append and prepend function of valuePicker 16/51816/2
Mona Muzaffar [Fri, 24 Feb 2017 08:09:58 +0000 (09:09 +0100)]
[BUGFIX] Fix append and prepend function of valuePicker

valuePicker appends and prepends now in the correct order.

Change-Id: Ic97b8a66469d43d9269f67f1de3f0cb40d1e8321
Resolves: #79937
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51816
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][BUGFIX] Hide language switcher if record has no default translation 05/51805/2
Sascha Nowak [Mon, 2 Jan 2017 10:59:58 +0000 (11:59 +0100)]
[FOLLOWUP][BUGFIX] Hide language switcher if record has no default translation

In the current implementation it is not possible to create a new translations outside
of the default translation. So we can readd the new translation option when the record
has a default translation.

Change-Id: I89c4200ff847dadfdeec03b5f43a6577f40702e3
Resolves: #72797
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/51092
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
(cherry picked from commit 00fa1cd5c876406952d655592b804f4333c42191)
Reviewed-on: https://review.typo3.org/51805

2 years ago[TASK] Include table name in TCA deprecation message for feInterface 89/51789/2
Xavier Perseguers [Wed, 22 Feb 2017 07:09:22 +0000 (08:09 +0100)]
[TASK] Include table name in TCA deprecation message for feInterface

Resolves: #79947
Releases: 7.6
Change-Id: I1caaa6d71070aeadc97b672660f280ef73727393
Reviewed-on: https://review.typo3.org/51789
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Remove ignored file from GIT index 58/51758/2
Markus Klein [Sun, 19 Feb 2017 18:17:26 +0000 (19:17 +0100)]
[CLEANUP] Remove ignored file from GIT index

The AcceptanceTester.php file is removed from GIT, as it is
listed in the .gitignore file.

Resolves: #79905
Releases: 7.6
Change-Id: I45f6d0b400a4da3a3c72587a087c40d13f5ad508
Reviewed-on: https://review.typo3.org/51758
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Thomas Hohn <thomas@hohn.dk>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix localization guard for "pages_language_overlay" 28/51728/2
Mathias Brodala [Thu, 16 Feb 2017 15:42:39 +0000 (16:42 +0100)]
[BUGFIX] Fix localization guard for "pages_language_overlay"

Resolves: #79859
Related: #78191
Releases: master, 7.6
Change-Id: Ia2a3ed9b1a793c1be554f73fa99362e3015313df
Reviewed-on: https://review.typo3.org/51728
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>