Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Catch exceptions while dumping a file 80/48080/5
Wouter Wolters [Wed, 11 May 2016 14:14:53 +0000 (16:14 +0200)]
[BUGFIX] Catch exceptions while dumping a file

While dumping a file in the frontend no exceptions are
caught. When a exception happens a 500 HTTP status is thrown.

Catch all exceptions to return the correct 404 HTTP status.

Releases: master,7.6,6.2
Resolves: #76153
Change-Id: Ice7097b6a41432ec580f99185d352307c5f55394
Reviewed-on: https://review.typo3.org/48080
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[TASK] Manual require_once of crawler removal 43/50643/4
Benni Mack [Sun, 13 Nov 2016 14:00:50 +0000 (15:00 +0100)]
[TASK] Manual require_once of crawler removal

The crawler is still included via a require_once in indexed_search,
even though the class loader since TYPO3 6.2 does that transparently.

So, the method is still called, which makes it impossible to
move EXT:crawler lib to a different location inside the extension.

The patch removes the call to the method, as the autoloader
fetches the file anyway.

It also deprecates the method call within EXT:indexed_search.

Resolves: #78679
Releases: master
Change-Id: I9654b89a520fe0aefd55a713613db794b8c88f72
Reviewed-on: https://review.typo3.org/50643
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Remove leftover code for PHP locallang files 44/50644/2
Wouter Wolters [Sun, 13 Nov 2016 14:58:34 +0000 (15:58 +0100)]
[TASK] Remove leftover code for PHP locallang files

The PHP parser is removed, so we can drop the value from the default
list of available file extensions.

We do not need to check for the php file anymore in the
AbstractFunctionModule class.

Resolves: #78681
Releases: master
Change-Id: I25ea50c7a615374849394298a8b87e7bbf50a8d3
Reviewed-on: https://review.typo3.org/50644
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Windloff <daniel.jc.windloff@googlemail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Remove empty else statement in AbstractRecordList 45/50645/2
Wouter Wolters [Sun, 13 Nov 2016 15:10:19 +0000 (16:10 +0100)]
[TASK] Remove empty else statement in AbstractRecordList

Remove the empty else statement in AbstractRecordList which is not
needed.

Resolves: #78682
Releases: master
Change-Id: I135fe879ee6f08be1234704836fa4f2f74a5e12b
Reviewed-on: https://review.typo3.org/50645
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Windloff <daniel.jc.windloff@googlemail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Deprecate TypoScript option config.mainScript 03/50603/4
Benni Mack [Sat, 12 Nov 2016 12:18:22 +0000 (13:18 +0100)]
[TASK] Deprecate TypoScript option config.mainScript

The TypoScript option config.mainScript allows to set the frontend
entrypoint from "index.php" to something else.

As this has some bigger conceptual flaws (e.g. if this option is
set, backend preview will not work, as the backend preview does not
know about the selected TypoScript in the frontend), the option
is removed in favor of creating custom extensions to e.g. hook
into the frontend rendering to replace index.php.

Resolves: #78668
Releases: master
Change-Id: Idecdbc93fba33d9b8fecfa39c064fbeea4986a8d
Reviewed-on: https://review.typo3.org/50603
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Tested-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] selectTree pageTsConfig addItems 65/50565/10
Frank Naegler [Thu, 10 Nov 2016 10:11:46 +0000 (11:11 +0100)]
[BUGFIX] selectTree pageTsConfig addItems

Adding items for type selectTree with pageTsConfig does not
work as documented. The TCA tree needs multi-root handling
to handle that. Additionally, some slight changes in the order
of elements when items are calculated are needed.

Resolves: #78628
Releases: master
Change-Id: Iecf0225c0eeaab8ea661997cad26e68d255d8460
Reviewed-on: https://review.typo3.org/50565
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add correct parameter phpDoc types in LocalizationRepository 40/50640/2
Wouter Wolters [Sun, 13 Nov 2016 13:46:13 +0000 (14:46 +0100)]
[TASK] Add correct parameter phpDoc types in LocalizationRepository

Add missing type information to phpDoc.

Resolves: #78678
Releases: master, 7.6
Change-Id: Id626c849bacc46f7a66c6936d34a71b1b2678f2f
Reviewed-on: https://review.typo3.org/50640
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[TASK] Cover t3_origuid in functional tests for Workspaces/Regular/PublishAll 73/50573/3
Tymoteusz Motylewski [Thu, 10 Nov 2016 12:01:53 +0000 (13:01 +0100)]
[TASK] Cover t3_origuid in functional tests for Workspaces/Regular/PublishAll

The t3_origuid field is now covered in functional tests for DataHandler
in workspaces module (Regular/PublishAll suite).

Releases: master, 7.6
Resolves: #78637
Change-Id: I6f10bc4973e86e559744021e1c0e0ca4c53105e8
Reviewed-on: https://review.typo3.org/50573
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Do not serialize variables for TransientMemoryBackend 00/50600/3
Claus Due [Fri, 11 Nov 2016 23:35:37 +0000 (00:35 +0100)]
[BUGFIX] Do not serialize variables for TransientMemoryBackend

This change switches the internal behavior of the VariableFrontend
when combined with the TransientMemoryBackend. Before this
patch the VariableFrontend was only capable of storing strings
and would serialize all variables it received, and unserialize all
variables it retrieves.

Rather than do this unnecessary serializing, a new contract is
implemented to indicate that the backend implementing the
contract is capable of storing non-string values, including
references to objects. When the VariableFrontend detects
this contract it skips the serialize/unserialize steps.

Change-Id: I255dbda2ae3791ad6325c5b4ad67c97e172e22f4
Releases: master, 7.6
Resolves: #78664
Reviewed-on: https://review.typo3.org/50600
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Let Extension Manager API also create folders 61/50561/3
Helmut Hummel [Wed, 9 Nov 2016 21:38:20 +0000 (21:38 +0000)]
[BUGFIX] Let Extension Manager API also create folders

The API method added in for #70606 does not
create extension folders, which makes the API
incomplete and more or less useless.

Move the method call to create the folder into the API method.
Although the creation is done later then, the code in question
didn't need the folders anyway.

Resolves: #78631
Related: #70606
Releases: master, 7.6
Change-Id: I17b3527cd2c26e0bb1bdfedcb68dc7ae6064500d
Reviewed-on: https://review.typo3.org/50561
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Use HTML5 input type number for backend pagination 45/50545/4
Georg Ringer [Tue, 8 Nov 2016 14:54:46 +0000 (15:54 +0100)]
[TASK] Use HTML5 input type number for backend pagination

Using the type number for the pagination page field improves the
usability.

Resolves: #78608
Releases: master, 7.6
Change-Id: I963bda892bb7a0ec72b2726f6086808dd421ac1c
Reviewed-on: https://review.typo3.org/50545
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Use semver for Symfony versions 65/49965/4
Patrik Karisch [Sun, 18 Sep 2016 12:45:24 +0000 (14:45 +0200)]
[TASK] Use semver for Symfony versions

Symfony has one of the best BC promises in the PHP world. Which means it
will be never a problem to allow all new minor versions of a supported
major release, even if there are deprecations. Deprecations don't infer
with existing code.

Resolves: #77983
Resolves: #76118
Related: #73517
Releases: master, 7.6
Change-Id: I221bb61674b3e4aaa7676d0929dae2ec18e01627
Reviewed-on: https://review.typo3.org/49965
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Resolves extension dependencies recursively 02/50602/7
Nicole Cordes [Sat, 12 Nov 2016 09:19:10 +0000 (10:19 +0100)]
[BUGFIX] Resolves extension dependencies recursively

Currently it is not possible to install an extension which has special
sub-dependencies (e.g. dependencies of sub-extensions). During the
installation of an extension, the download information is fetched too
early and might not contain all necessary downloads. Furthermore later
installation actions add new dependencies, which have to be resolved
before any other extension can be installed.

This patch ensures all dependencies and their sub-dependencies are
fetched before the first installation. All installation information is
now correctly ordered, as the last one added has to be the first one in
the installation queue.

Resolves: #78666
Relates: #66152
Releases: master, 7.6
Change-Id: Idd9242aa1e2ecac3deb542290627fdf9c5479edc
Reviewed-on: https://review.typo3.org/50602
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Remove GLOBAL variables from web_ts 26/50626/3
Benni Mack [Sun, 13 Nov 2016 00:09:08 +0000 (01:09 +0100)]
[TASK] Remove GLOBAL variables from web_ts

The system extension "tstemplate" still uses a
lot of $GLOBAL objects which are only used within
the classes itself.

These are solely related to the "web_ts" (Web => Template)
module.

The code is refactored by using protected object members.

Resolves: #78675
Releases: master
Change-Id: Ic9bbcd9dfd4d9d9f9d976bead46c5d03d887aec6
Reviewed-on: https://review.typo3.org/50626
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] EM must treat line breaks correctly in extension data 16/50516/5
Markus Klein [Mon, 7 Nov 2016 00:38:47 +0000 (01:38 +0100)]
[BUGFIX] EM must treat line breaks correctly in extension data

The XML push-parser now correctly collects the data for
description and upload comment. When the data contain line breaks
the characterData() method is called multiple times
for each line of data.

Resolves: #78306
Releases: master, 7.6
Change-Id: Ibfa446b92904572d1f4530b265e94228857a5f02
Reviewed-on: https://review.typo3.org/50516
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Bind the cHash to the id of the "real" page 84/50184/4
Helmut Hummel [Tue, 11 Oct 2016 13:05:17 +0000 (15:05 +0200)]
[BUGFIX] Bind the cHash to the id of the "real" page

If a link to a mount point or a shortcut is created,
the id argument in the url points to the id of the real page,
where the mount or the shortcut points to.

This is why we need to take the id of the final page
to be hashed and not the one used to generate the link.

We also need to move cHash calculation below shortcut resolving.

Resolves: #78238
Releases: master, 7.6, 6.2
Change-Id: I96c4305c6d769a5851c17d6fdcba3cd7584fc3ec
Reviewed-on: https://review.typo3.org/50184
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Do not add empty alert fieldChangeFunc to link browser URL 86/50586/2
Markus Klein [Thu, 10 Nov 2016 22:02:42 +0000 (23:02 +0100)]
[BUGFIX] Do not add empty alert fieldChangeFunc to link browser URL

Adding an empty alert message to the fieldChangeFunc array causes
the fieldChangeFunc_hash to mismatch when pagination or search
is used in the link browser popup.

Add a check for an empty value, which is already present in another
place in Core.

Resolves: #75743
Releases: master, 7.6
Change-Id: I1a15400960d577c1a2a0a905643b56533d957100
Reviewed-on: https://review.typo3.org/50586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[TASK] Close document by clicking "Save and create new one" 06/50506/5
Markus Hoelzle [Sat, 5 Nov 2016 11:29:16 +0000 (12:29 +0100)]
[TASK] Close document by clicking "Save and create new one"

Close the current document in 'Open documents' list by
clicking the "Save and create a new one" button.

Resolves: #78545
Releases: master, 7.6
Change-Id: Id401f6471132ef7b66ad35cae4b15c5f384b857e
Reviewed-on: https://review.typo3.org/50506
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Cleanup BackendUserAuthentication->unpack_uc() 95/50595/3
Benni Mack [Fri, 11 Nov 2016 14:25:18 +0000 (15:25 +0100)]
[TASK] Cleanup BackendUserAuthentication->unpack_uc()

The backendUser->uc() call is called with a default value,
which is unnecessary and "looks ugly" ;).

Additionally $BE_USER calls unpack_uc() itself, basically doing
a unserialize() before, even though unpack_uc() does the same
thing.

Resolves: #78658
Releases: master
Change-Id: I492326373b61dba5cba61f24e64b31fddf9a2142
Reviewed-on: https://review.typo3.org/50595
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Remove htmlspecialchars for values that are used in exceptions 98/50598/3
Wouter Wolters [Fri, 11 Nov 2016 20:30:46 +0000 (21:30 +0100)]
[TASK] Remove htmlspecialchars for values that are used in exceptions

Resolves: #78663
Releases: master
Change-Id: Ic7bcc67886d66d31d2062847568d800ab4e48717
Reviewed-on: https://review.typo3.org/50598
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[TASK] Remove undefined property iconFactory from EditFileController 97/50597/3
Wouter Wolters [Fri, 11 Nov 2016 18:57:29 +0000 (19:57 +0100)]
[TASK] Remove undefined property iconFactory from EditFileController

The property is not defined at all. We can retrieve the iconFactory
from the moduleTemplate.

Resolves: #78662
Releases: master
Change-Id: Id51ac702b9a9e57d731014e86e1637632aadcb38
Reviewed-on: https://review.typo3.org/50597
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Streamline and optimize JavaScript in install tool 53/50553/5
Frank Naegler [Wed, 9 Nov 2016 13:04:37 +0000 (14:04 +0100)]
[TASK] Streamline and optimize JavaScript in install tool

This patch optimize and streamline the JavaScript of Install.js
The following changes are part of the patch:

- Centralized FlashMessage handling
- Streamline server side and browser side severities
- Optimize performance, remove duplicate jQuery selector
- Remove console.debug calls
- Remove unused FlashMessage templates from views

Resolves: #78376
Releases: master, 7.6
Change-Id: I0652335e5d0bc4666896d5c7b6b528db445ee951
Reviewed-on: https://review.typo3.org/50553
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Remove typo3/.htaccess 81/50581/6
Markus Klein [Thu, 10 Nov 2016 17:22:56 +0000 (18:22 +0100)]
[TASK] Remove typo3/.htaccess

The current solution caused a lot of troubles with server configuration.
To avoid any nasty workarounds we simply create a real entry point again.

Resolves: #78645
Releases: master, 7.6
Change-Id: I9003ffe8308290a145fe36a1e9ff884016ea0523
Reviewed-on: https://review.typo3.org/50581
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Kiessling <andreas.kiessling@web.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
2 years ago[TASK] Update fluid engine dependency to 2.0.4 87/50587/2
Claus Due [Thu, 10 Nov 2016 22:54:53 +0000 (23:54 +0100)]
[TASK] Update fluid engine dependency to 2.0.4

Solves the following issue:

* CycleViewHelper produces incorrect output in compiled templates
   https://github.com/TYPO3/Fluid/pull/193

Change-Id: I3d9ab6a8a2df880c33eb595ca12678dea441dbb7
Releases: master
Resolves: #78649
Reviewed-on: https://review.typo3.org/50587
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix double escaping of icon and title in EXT:impexp 48/50548/2
Wouter Wolters [Tue, 8 Nov 2016 20:59:29 +0000 (21:59 +0100)]
[BUGFIX] Fix double escaping of icon and title in EXT:impexp

The title and icon are double escaped. This leads to HTML output
as readable code. Move translation into the controller.

Resolves: #76277
Releases: master,7.6
Change-Id: I5529e00788ea870475d4b46f2da9dd472d226a97
Reviewed-on: https://review.typo3.org/50548
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[!!!][TASK] Migrate Lowlevel "double_files" command to Symfony Console 58/50558/3
Benni Mack [Wed, 9 Nov 2016 16:38:32 +0000 (17:38 +0100)]
[!!!][TASK] Migrate Lowlevel "double_files" command to Symfony Console

The CLI command to find files that are referenced more than once
in TYPO3 is migrated to Symfony Console to better structure the
CLI command and get rid of dependencies of the old CLI command
line tools (non-extbase).

The command was previously available under
./typo3/cli_dispatch lowlevel_cleaner double_files

and is now called via
./typo3/sysext/core/bin/typo3 cleanup:multiplereferencedfiles

and allows the following options:
--dry-run - do not copy the files and update the references, but just print them
--update-refindex - update the reference index, do not ask the user

Resolves: #78627
Releases: master
Change-Id: I19039790227365ab951a954848565bcb0eb29c6b
Reviewed-on: https://review.typo3.org/50558
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Re-enable "default" option in Fluid Case ViewHelper 75/50575/2
Benni Mack [Thu, 10 Nov 2016 12:26:27 +0000 (13:26 +0100)]
[BUGFIX] Re-enable "default" option in Fluid Case ViewHelper

A bug, introduced with the registerArguments option does
not work properly anymore with the "default" option for the <f:case>
viewhelper.

Casting the argument let's the option be evaluated again.

Resolves: #78638
Releases: master
Change-Id: I5b245378db4fab430fc0670b3a4a77de6c3b863f
Reviewed-on: https://review.typo3.org/50575
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Use page uid instead of alias for cHash calculation 68/50468/2
Helmut Hummel [Mon, 31 Oct 2016 23:14:45 +0000 (00:14 +0100)]
[BUGFIX] Use page uid instead of alias for cHash calculation

To make cHash calculation work again, we need to use the page uid.
However the GET argument might contain a page alias and not the id.
Use the calculated id instead to avoid wrong cHash calculation.

Resolves: #78526
Releases: master, 7.6, 6.2
Change-Id: Iaa89b7a52a581bd5ac7c0b01049a7f9596258051
Reviewed-on: https://review.typo3.org/50468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[TASK] Extract per-connection concerns from SchemaMigrator 07/50007/11
Oliver Hader [Thu, 22 Sep 2016 18:24:06 +0000 (20:24 +0200)]
[TASK] Extract per-connection concerns from SchemaMigrator

Extract per-connection concerns from SchemaMigrator into new
ConnectionMigrator. This way, schema changes on connections
can be handled individually.

Resolves: #78046
Releases: master
Change-Id: Ic7ff27c2251e9dd9f2fed6366b0d4fcb2c5b41d2
Reviewed-on: https://review.typo3.org/50007
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[!!!][TASK] Migrate Lowlevel "missing_relations" command to Symfony Console 55/50555/4
Benni Mack [Wed, 9 Nov 2016 14:26:01 +0000 (15:26 +0100)]
[!!!][TASK] Migrate Lowlevel "missing_relations" command to Symfony Console

The CLI command to detect and (as far as possible) remove
relations to non-existing records, and offline version versions as
well as listing deleted records is migrated to Symfony Console
to better structure the CLI command and get rid of dependencies
of the old CLI command line tools (non-extbase).

The command was previously available under
./typo3/cli_dispatch lowlevel_cleaner missing_relations

and is now called via
./typo3/sysext/core/bin/typo3 cleanup:missingrelations

and allows the following options:
--dry-run - do not delete the references, but just print them
--update-refindex - update the reference index, do not ask the user

Resolves: #78623
Releases: master
Change-Id: Ia81a250deb0b238ed4e4dd09667b381f5cb53cfb
Reviewed-on: https://review.typo3.org/50555
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Use a cast to float instead of doubleval 49/50549/7
Wouter Wolters [Tue, 8 Nov 2016 22:14:07 +0000 (23:14 +0100)]
[TASK] Use a cast to float instead of doubleval

The method doubleval is an alias of floatval and
this could be used. But using a cast to float is
quicker.

Resolves: #78617
Releases: master
Change-Id: If5d6c39583534a1878bd94b41f37f3e523627d77
Reviewed-on: https://review.typo3.org/50549
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Refactor suggest wizard JS communication 44/50544/4
Christian Kuhn [Tue, 8 Nov 2016 13:12:49 +0000 (14:12 +0100)]
[TASK] Refactor suggest wizard JS communication

Transmitting the full $row in suggest wizard was introduced to
find the relevant flex form data structure in the ajax search action
to determine the suggest wizard field configuration

The patch adds the data structure identifier instead, the searchAction()
uses that to fetch the specified flex form data structure directly.

Additionally, field values relevant for the ajax call are now signed with
hmac and checked in searchAction().

Change-Id: Ibb5004d4d11487fe999072999c7ce2f847aac750
Resolves: #78616
Related: #78581
Releases: master
Reviewed-on: https://review.typo3.org/50544
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Remove styles.content.links.target 39/49839/4
Arnd Messer [Sat, 3 Sep 2016 13:40:55 +0000 (15:40 +0200)]
[BUGFIX] Remove styles.content.links.target

Remove styles.content.links.target from constants.txt and
lib.parseFunc.ts.

styles.content.links.target has as description in constants.txt pointing
the value is used for frames.

Since fluid_styled_content is focussing on HTML5, this value does not
make sense at all, since frames have been removed from the
specification.
styles.content.links.target should be removed from constants.txt in
fluid_styled_content including the use of this constant value in
lib.parseFunc.ts, the only place where it is used. The typolink
viewhelper does not take this into account also.

Resolves: #77830
Related: #36216
Releases: master
Change-Id: I16e8dc3f77595fde20d8c43d6ab16eb7d590e34b
Reviewed-on: https://review.typo3.org/49839
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Continue searching after empty result in suggest wizard 36/50536/2
Wouter Wolters [Mon, 7 Nov 2016 22:18:32 +0000 (23:18 +0100)]
[BUGFIX] Continue searching after empty result in suggest wizard

Apply the same fix as was done for the LiveSearch.

Resolves: #78457
Related: #77566
Releases: master,7.6
Change-Id: I861e6267b4804f8009d138e22520f1b95ba421b6
Reviewed-on: https://review.typo3.org/50536
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Replace beginsWith method with strpos to reduce execution time 34/50534/5
Wouter Wolters [Mon, 7 Nov 2016 20:20:57 +0000 (21:20 +0100)]
[TASK] Replace beginsWith method with strpos to reduce execution time

Use the native PHP method strpos instead of StringUtility::beginsWith
method. The beginsWith method runtime compared to a simple strpos check
is much higher.

Resolves: #78602
Releases: master
Change-Id: I608ed791ddd770a8de493e0796387a18b22ff2ce
Reviewed-on: https://review.typo3.org/50534
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Cover t3_origuid in functional tests for Wokspaces/Regular/Publish 33/50533/3
Tymoteusz Motylewski [Mon, 7 Nov 2016 20:46:41 +0000 (21:46 +0100)]
[TASK] Cover t3_origuid in functional tests for Wokspaces/Regular/Publish

The t3_origuid field is now covered in functional tests for DataHandler
in workspaces module (Regular/Publish suite).

Releases: master, 7.6
Resolves: #78597
Change-Id: I4caf9490866319470af48b9fb4f177c1c3a0b708
Reviewed-on: https://review.typo3.org/50533
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Support \ArrayAccess objects with getter methods in ObjectAccess 21/50521/6
Sascha Egerer [Mon, 7 Nov 2016 10:58:39 +0000 (11:58 +0100)]
[BUGFIX] Support \ArrayAccess objects with getter methods in ObjectAccess

In #66995 the extbase ObjectAccess has been cleaned up and introduced
a behavior where it is not possible anymore to call the getter of an
object that implements \ArrayAccess.
The problem is avoided by only using array-accessing if the offset
is found to exist. If not, the instance is handled as any other object.

Change-Id: Ie6b598d93fd7171d0b6c37259e424794861e31ed
Resolves: #78589
Related: #66995
Releases: master
Reviewed-on: https://review.typo3.org/50521
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Update Fluid engine dependency to 2.0.3 35/50535/2
Claus Due [Mon, 7 Nov 2016 21:10:17 +0000 (22:10 +0100)]
[TASK] Update Fluid engine dependency to 2.0.3

Solves this issue: https://github.com/TYPO3/Fluid/pull/228

Change-Id: Idc377dac0d074194b065448a0ce4b8641a94249a
Resolves: #78601
Releases: master
Reviewed-on: https://review.typo3.org/50535
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Hide language switcher if record has no default translation 98/50298/2
Christina Hauk [Tue, 11 Oct 2016 13:43:18 +0000 (15:43 +0200)]
[BUGFIX] Hide language switcher if record has no default translation

Disable further language menu options in free mode. If language record
doesn't have a record in the default language there are no more options
in the language menu needed.

Resolves: #72797
Releases: master, 7.6
Change-Id: Ic5211f99c3c53f3097057ba580e3394896b81170
Reviewed-on: https://review.typo3.org/50298
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Deprecate TYPO3_DB and Prepared Statement class 74/50174/7
Benni Mack [Mon, 10 Oct 2016 18:58:39 +0000 (20:58 +0200)]
[TASK] Deprecate TYPO3_DB and Prepared Statement class

Add deprecation docs and logging information to both PHP
classes.

Resolves: #78244
Releases: master
Change-Id: Iacc45588c61b6cd32b8239391176059c5afbf731
Reviewed-on: https://review.typo3.org/50174
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Flex form data structure refactoring 12/48212/33
Christian Kuhn [Wed, 18 May 2016 15:58:06 +0000 (17:58 +0200)]
[!!!][TASK] Flex form data structure refactoring

Method BackendUtility::getFlexFormDS() does two things at once:
It finds a data structure by given data (TCA, row, ...) and then
parses it.
This construct gives tons of headaches, since the methods never
exposes where a specific data structure came from and the lookup
mechanism is complex. Especially if a flex form is used in
combination with ajax requests later, the core has massive issues
since the location can not be found out later again.

To solve that, the patch splits getFlexFormDS() into two methods:
First method "FlexFormTools->getDataStructureIdentifier()" gets
TCA and row and locates a specific structure. It returns an
"identifier" that points to that unique data structure. This
identifier can be later hand around easily.
The second method "FlexFormTools->parseDataStructureByIdentifier()"
then gets this identifier again, fetches the data structure the
identifier points to, and parses it.

Change-Id: I38264e8a4a6f956c12e9e50f6039d3d09af0f03a
Resolves: #78581
Releases: master
Reviewed-on: https://review.typo3.org/48212
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Claus Due <claus@phpmind.net>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Remove Documentation/Settings.yml 24/50524/2
Christian Kuhn [Mon, 7 Nov 2016 14:41:43 +0000 (15:41 +0100)]
[TASK] Remove Documentation/Settings.yml

The files were substituted with "Settings.cfg" a while
ago and are now obsolete according to the docs team.

Change-Id: I43f2a6fca83f839359d5c1b0c1bb4f0cf967e253
Resolves: #78595
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/50524
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Reviewed-by: Martin Bless <m.bless@gmx.de>
Tested-by: Martin Bless <m.bless@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Listview: Display parent field of categories 74/50274/3
Michael Oehlhof [Wed, 19 Oct 2016 13:07:07 +0000 (15:07 +0200)]
[BUGFIX] Listview: Display parent field of categories

Resolves: #72311
Releases: master, 7.6
Change-Id: I47b19ccb5e74c5755630dba3626dad29b7b24fc7
Reviewed-on: https://review.typo3.org/50274
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Kurt Ludikovsky <kurt.ludikovsky@ludikovsky.at>
Tested-by: Kurt Ludikovsky <kurt.ludikovsky@ludikovsky.at>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Move toplevel index.php to frontend extension 90/46390/11
Mathias Brodala [Sat, 30 Jan 2016 11:36:00 +0000 (12:36 +0100)]
[TASK] Move toplevel index.php to frontend extension

This moves the toplevel "index.php" to the frontend extension
as "frontend.php". The toplevel "index.php" becomes a stub which
includes the "frontend.php".

This setup works in the following cases:

1) Package "typo3/cms" is the root package
2) The "index.php" is symlinked into the web-dir
3) The "index.php" is copied into the web-dir

In all of these cases "typo3" is a toplevel directory.

Resolves: #73027
Releases: master
Change-Id: I1c0653bcc4691105eb2ccfbea2bcc873ce6189da
Reviewed-on: https://review.typo3.org/46390
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Remove duplicate calls to substr in InfoPageTyposcriptConfigController 14/50514/2
Wouter Wolters [Sun, 6 Nov 2016 16:14:03 +0000 (17:14 +0100)]
[TASK] Remove duplicate calls to substr in InfoPageTyposcriptConfigController

substr is called 3 times with the same parameters, use one variable for this.

Resolves: #78583
Releases: master
Change-Id: Idc57e143c26cd190f8047d59f1e36cb745e9aaf8
Reviewed-on: https://review.typo3.org/50514
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Update Fluid engine dependency to 2.0.2 15/50515/2
Claus Due [Sun, 6 Nov 2016 23:05:11 +0000 (00:05 +0100)]
[TASK] Update Fluid engine dependency to 2.0.2

Solves the following issues:

* ViewHelpers using compiling traits would call incorrect method if renderStatic was inherited
  https://github.com/TYPO3/Fluid/pull/226
* f:format.raw would not use the "value" argument if it was specified, only renderChildren used
  https://github.com/TYPO3/Fluid/pull/217
* Some ViewHelpers using content argument trait would fail to render or render unexpected
  output in compiled/not-compiled rendering respectively
  https://github.com/TYPO3/Fluid/pull/210

Change-Id: Ie7bbe6e63f3379a2df9d9cc2fea94cddcf4c1320
Resolves: #78584
Releases: master
Reviewed-on: https://review.typo3.org/50515
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Drastically reduce TS re-parsing in TemplatePaths 10/50510/8
Claus Due [Sat, 5 Nov 2016 15:16:35 +0000 (16:16 +0100)]
[TASK] Drastically reduce TS re-parsing in TemplatePaths

This change implements a runtime cache which stores the view
configuration for extension keys. This
avoids calling removeDotsFromTS and other methods more
than one time per configuration.

Change-Id: I551fd8526d9a5576e22edaf45742ccb35c2f3aba
Fixes: #78580
Releases: master
Reviewed-on: https://review.typo3.org/50510
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] LiveSearch: Refactor use of queryBuilder to use prepared statements 07/50507/2
Manuel Selbach [Sat, 5 Nov 2016 13:23:58 +0000 (14:23 +0100)]
[TASK] LiveSearch: Refactor use of queryBuilder to use prepared statements

According to task #78437 queries should follow the prepared statement principle.
Thus the LiveSearch has to be refactored.

Change-Id: I301190314d6e2f86512d1f5c41bcf6991009258f
Resolves: #78578
Releases: master
Reviewed-on: https://review.typo3.org/50507
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP][TASK] Fluidification of Opendocs Toolbar (2nd try) 12/50512/2
Andreas Fernandez [Sat, 5 Nov 2016 18:07:57 +0000 (19:07 +0100)]
[FOLLOWUP][TASK] Fluidification of Opendocs Toolbar (2nd try)

`list($x, )` does not work on empty arrays, causing `$x` being null then.
The code now checks whether there are actually open docs and then does
the list() stuff.

Resolves: #78051
Releases: master
Change-Id: I73d2c3ca40bea8c3dce2ac1de0ec97e136bf228b
Reviewed-on: https://review.typo3.org/50512
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FEATURE] Enumeration constants getName methods 03/50503/7
Anja Leichsenring [Fri, 4 Nov 2016 16:20:19 +0000 (17:20 +0100)]
[FEATURE] Enumeration constants getName methods

It comes in handy to use the names of enumeration objects
sometimes. Two getName() functions provide the name
once unchanged, once human readable.

Resolves: #78575
Releases: master
Change-Id: Ibb0e06c7462835097f9980a854c79c8f90a61672
Reviewed-on: https://review.typo3.org/50503
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[FOLLOWUP][TASK] Fluidification of Opendocs Toolbar 11/50511/2
Andreas Fernandez [Sat, 5 Nov 2016 17:49:02 +0000 (18:49 +0100)]
[FOLLOWUP][TASK] Fluidification of Opendocs Toolbar

The properties `$openDocs` and `$recentDocs` are described and treated
as arrays, but initialized as null values. This patch changes the
declaration to array.

Resolves: #78051
Releases: master
Change-Id: I859c13478b17ddd9fbb7ab7686099f27b3c0e7ea
Reviewed-on: https://review.typo3.org/50511
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[!!!][TASK] Migrate MissingFilesCommand to Symfony Console 88/50488/4
Benni Mack [Thu, 3 Nov 2016 07:06:39 +0000 (08:06 +0100)]
[!!!][TASK] Migrate MissingFilesCommand to Symfony Console

The EXT:lowlevel command "Missing Files" searches through
the reference index and checks for references (and soft references)
that are linked to files that are missing in the file system.

The command was previously available under
./typo3/cli_dispatch lowlevel_cleaner missing_files

and is now called via
./typo3/sysext/core/bin/typo3 cleanup:missingfiles

and allows the following options:
--dry-run - do not delete the references, but just print them
--update-refindex - update the reference index, do not ask the user

Resolves: #78577
Releases: master
Change-Id: I97776fb43f5232740521a6c994c1e72af827ff15
Reviewed-on: https://review.typo3.org/50488
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Replace TCEmain with the new naming DataHandler 85/50485/5
Wouter Wolters [Wed, 2 Nov 2016 19:56:08 +0000 (20:56 +0100)]
[TASK] Replace TCEmain with the new naming DataHandler

The old class name is still in use in the core, replace them
with the new name DataHandler.

Resolves: #78550
Releases: master
Change-Id: I324e7b3037f8bf8df70d5c8db37d62a01ed710a4
Reviewed-on: https://review.typo3.org/50485
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[TASK] Fluidification of Opendocs Toolbar 29/50029/7
Michael Oehlhof [Mon, 26 Sep 2016 20:22:55 +0000 (22:22 +0200)]
[TASK] Fluidification of Opendocs Toolbar

Resolves: #78051
Releases: master
Change-Id: I579734bd47bd20cbc5d23d3bd4d8fe27426c248e
Reviewed-on: https://review.typo3.org/50029
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[DOC] Clarify phpdoc of SimpleFileBackend that lifetime is unsupported 08/50508/2
Markus Klein [Sat, 5 Nov 2016 14:11:16 +0000 (15:11 +0100)]
[DOC] Clarify phpdoc of SimpleFileBackend that lifetime is unsupported

Resolves: #78579
Releases: master, 7.6
Change-Id: I9260256630a6916bcc5b8cb8b93041f0a3bcf444
Reviewed-on: https://review.typo3.org/50508
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[!!!][TASK] Migrate LostFilesCommand to Symfony Console 87/50487/6
Benni Mack [Thu, 3 Nov 2016 06:13:26 +0000 (07:13 +0100)]
[!!!][TASK] Migrate LostFilesCommand to Symfony Console

The EXT:lowlevel command "LostFiles" searched through
uploads/* and checks if any files are not in use by TYPO3 by
checking against the reference index.

The command was previously available under
./typo3/cli_dispatch lowlevel_cleaner lost_files

and is now called via
./typo3/sysext/core/bin/typo3 cleanup:lostfiles

and allows the following options:
--dry-run - do not delete the files, but just print them
--exclude=uploads/pics/,uploads/downloads/ -- skip certain folders and files
--update-refindex - update the reference index, do not ask the user

Resolves: #78552
Releases: master
Change-Id: I1f20c4c2f47d1dd13f8f32433e7e0d0666518d5a
Reviewed-on: https://review.typo3.org/50487
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][TASK] Migrate OrphanRecords Command to Symfony Console 38/50438/7
Benni Mack [Sat, 29 Oct 2016 21:37:29 +0000 (23:37 +0200)]
[!!!][TASK] Migrate OrphanRecords Command to Symfony Console

The CLI cleaner command "orphan_records" in EXT:lowlevel is
migrated to a command based on Symfony Console.

Previoulsy it was called via
typo3/cli_dispatch.phpsh lowlevel_cleaner orphan_records -s -r

Now you use
typo3/sysext/core/bin/typo3 cleanup:orphanrecords
(optional via --dry-run)

Resolves: #78520
Releases: master
Change-Id: I1e1462ce45e76964d0b67bd782e5f216b3d2cf37
Reviewed-on: https://review.typo3.org/50438
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Remove unused main module language files 98/50498/2
Wouter Wolters [Thu, 3 Nov 2016 21:36:47 +0000 (22:36 +0100)]
[TASK] Remove unused main module language files

Files are unused since TYPO3 4.2

Resolves: #78565
Releases: master
Change-Id: I3cc145b056fd4479611c3f0ad8cb71da9907841a
Reviewed-on: https://review.typo3.org/50498
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Load ext_emconf information in extension installation 84/50484/3
Nicole Cordes [Wed, 2 Nov 2016 11:53:48 +0000 (12:53 +0100)]
[BUGFIX] Load ext_emconf information in extension installation

With patch https://review.typo3.org/50427/ TER information were not
loaded for extension information. Unfortunately this also skips loading
the dependencies which results in uninstalled dependencies. This patch
introduces a new function to only load needed (and available)
information from ext_emconf file for processing a correct extension
installation/activation.

Resolves: #78540
Releases: master, 7.6, 6.2
Change-Id: I16bddc91cb2523488cedc2293936eeb8aa2eb577
Reviewed-on: https://review.typo3.org/50484
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Remove unused locallang file for clearcache menu 97/50497/2
Wouter Wolters [Thu, 3 Nov 2016 20:35:48 +0000 (21:35 +0100)]
[TASK] Remove unused locallang file for clearcache menu

The locallang file is not used in the core anymore since 6.2

Resolves: #78564
Releases: master
Change-Id: I8b0cf2fd779e0a017de15c1c778518a6f7f14ed1
Reviewed-on: https://review.typo3.org/50497
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Upgrade Fluid engine to 2.0.1 96/50496/3
Claus Due [Thu, 3 Nov 2016 19:36:58 +0000 (20:36 +0100)]
[TASK] Upgrade Fluid engine to 2.0.1

Doing so solves the following issues:

* Cached files not correctly detected (CMS not affected, uses different backend)
   https://github.com/TYPO3/Fluid/commit/cbbe195635a06d5bbe24dfe4a5db638c779ef30d
* Output of `f:spaceless` was escaped and should not be
   https://github.com/TYPO3/Fluid/commit/f337dad28dcf05fee4979228f46e21757b8019bb
* Detect keys ending with a digit in array expressions
   https://github.com/TYPO3/Fluid/commit/52bf96a63e93c11f6f17bf8b7cc5a08c07fdf55f

Change-Id: I3b41f95af147632ac5ca28c69873e182f118fec3
Resolves: #78563
Releases: master
Reviewed-on: https://review.typo3.org/50496
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Delete unused iframepanel JavaScript code 80/50480/2
Wouter Wolters [Tue, 1 Nov 2016 22:37:05 +0000 (23:37 +0100)]
[TASK] Delete unused iframepanel JavaScript code

Since the new ViewPort setup the iframepanel JavaScript
code is unused. The new ViewPort code marked this code already
as a breaking change.

Resolves: #78536
Releases: master
Change-Id: I651dbcd99af76e20f36e8eb7d0c29cf22ddd304a
Reviewed-on: https://review.typo3.org/50480
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Load modulemenu as RequireJs module 82/50482/3
Wouter Wolters [Tue, 1 Nov 2016 23:16:10 +0000 (00:16 +0100)]
[TASK] Load modulemenu as RequireJs module

Rename the modulemenu JavaScript file to ModuleMenu.js
Load the module with RequireJS in the BackendController.

Resolves: #78538
Releases: master
Change-Id: I2da6a6fd2c3ecdb8cb0fa7267a079c8f6eba1a3d
Reviewed-on: https://review.typo3.org/50482
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Use correct path to JS resources 75/50475/2
Nicole Cordes [Tue, 1 Nov 2016 15:10:07 +0000 (16:10 +0100)]
[BUGFIX] Use correct path to JS resources

This problem is related to the change https://review.typo3.org/48915/.
The patch removed usage of ExtensionManagementUtility::extRelPath and
replaced it with other calls. While trying to resolve a relative path
in BackendController::loadResourcesForRegisteredNavigationComponents,
a wrong replacement was introduced. This patch ensures the old behaviour
to retrieve the relative path.

Resolves: #78490
Releases: master
Change-Id: I2c2edf6d1b02efd95b4485da88777eec0dd515c6
Reviewed-on: https://review.typo3.org/50475
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Malte Koitka <malte@cytrus.de>
Tested-by: Malte Koitka <malte@cytrus.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Update ext:styleguide to 8.0.5 83/50483/2
Christian Kuhn [Wed, 2 Nov 2016 02:28:55 +0000 (03:28 +0100)]
[TASK] Update ext:styleguide to 8.0.5

Change-Id: Ia94a213f81d45db978e7a95e857283d4d9c32848
Resolves: #78539
Releases: master
Reviewed-on: https://review.typo3.org/50483
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove not evaluated JavaScript property fsMod.currentMainLoaded 81/50481/2
Wouter Wolters [Tue, 1 Nov 2016 22:50:18 +0000 (23:50 +0100)]
[TASK] Remove not evaluated JavaScript property fsMod.currentMainLoaded

This property is unevaluated since TYPO3 6.1

Resolves: #78537
Releases: master
Change-Id: Id5decd6d06b05bfc2c13b35870a8576d4b461b52
Reviewed-on: https://review.typo3.org/50481
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove JavaScript setting consoleOverrideWithDebugPanel 79/50479/2
Wouter Wolters [Tue, 1 Nov 2016 22:29:32 +0000 (23:29 +0100)]
[TASK] Remove JavaScript setting consoleOverrideWithDebugPanel

No usage of the setting consoleOverrideWithDebugPanel is in the core.

Resolves: #78535
Releases: master
Change-Id: Ib02d98390794dc0d5e334127db1fb780d382b18c
Reviewed-on: https://review.typo3.org/50479
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove check for startInTaskCenter to set as startModule 78/50478/2
Wouter Wolters [Tue, 1 Nov 2016 22:05:41 +0000 (23:05 +0100)]
[TASK] Remove check for startInTaskCenter to set as startModule

The backend user setting has been removed already since TYPO3 4.3
We can safely drop this check.

Resolves: #78534
Releases: master
Change-Id: I45c68254c1ade2eae7aff29cb552b83d0db9a87c
Reviewed-on: https://review.typo3.org/50478
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Use new modal for not found page when using &edit as parameter 77/50477/2
Wouter Wolters [Tue, 1 Nov 2016 21:44:20 +0000 (22:44 +0100)]
[TASK] Use new modal for not found page when using &edit as parameter

When using &edit=123124312321 as extra parameter for the backend
an oldschool alert is shown.
Replace this with a nicer modal.

Resolves: #78533
Releases: master
Change-Id: I83d3c7bd358a0eced599a31ec51af6186089d723
Reviewed-on: https://review.typo3.org/50477
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Add page.target to external links in fluid_styled_content 49/50449/2
Michael Oehlhof [Mon, 31 Oct 2016 09:36:58 +0000 (10:36 +0100)]
[BUGFIX] Add page.target to external links in fluid_styled_content

Resolves: #78006
Releases: master
Change-Id: I1e1caf13e4b8da7ed1a6253c3004fe2b94593aa1
Reviewed-on: https://review.typo3.org/50449
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benjamin Kott <info@bk2k.info>
Tested-by: Benjamin Kott <info@bk2k.info>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Remove leftover page/branch versioning code 62/50462/8
Benni Mack [Mon, 31 Oct 2016 20:09:01 +0000 (21:09 +0100)]
[TASK] Remove leftover page/branch versioning code

There are several places within EXT:version and DataHandler
which try to do "pageVersionizing" but it's not possible
anymore (see removed code in "new" section of DataHandlerHook)
since TYPO3 v7.

This also means that the `versioning_followPages` option is removed
completely from the Core.

Resolves: #78524
Releases: master
Change-Id: I6166e198fc74922aa34e2ae49440e4c0fe4354a6
Reviewed-on: https://review.typo3.org/50462
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Allow multiple search words for file search 58/50458/2
Markus Klein [Mon, 31 Oct 2016 19:26:26 +0000 (20:26 +0100)]
[TASK] Allow multiple search words for file search

The file search must consider each word of the search text as
individual word and all of them must be present in the file name.

Search words can be bound together by quoting them with
double quotes.

Resolves: #78519
Releases: master, 7.6
Change-Id: I95dcdf3418bfc9090a16c4f199af60799437390e
Reviewed-on: https://review.typo3.org/50458
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Always log exception data if file handling fails 55/50455/2
Markus Klein [Mon, 31 Oct 2016 15:15:33 +0000 (16:15 +0100)]
[BUGFIX] Always log exception data if file handling fails

If file handling fails in ContentObjectRenderer the log message
must contain also the exception information, otherwise the
whole error message is useless.

Resolves: #78517
Releases: master, 7.6
Change-Id: I503f5bf17bba302326b9e9eb25faa58c00e35a36
Reviewed-on: https://review.typo3.org/50455
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Catch exception in Upgrade Wizard 69/50469/5
Frank Naegler [Tue, 1 Nov 2016 10:09:46 +0000 (11:09 +0100)]
[BUGFIX] Catch exception in Upgrade Wizard

Catch any StatementException and create an ErrorStatus
message containing the exception message.

Resolves: #78529
Related: #78235
Releases: master
Change-Id: I404976856a02f974fd7348dbaf019d21398a0a72
Reviewed-on: https://review.typo3.org/50469
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[!!!][TASK] Drop unused JavaScript from backend.js 24/50424/6
Wouter Wolters [Fri, 28 Oct 2016 19:10:58 +0000 (21:10 +0200)]
[!!!][TASK] Drop unused JavaScript from backend.js

Remove the following unused JavaScript methods from the core.

TYPO3._instances
TYPO3.addInstance
TYPO3.getInstance
TYPO3.helpers.split

Resolves: #78521
Releases: master
Change-Id: I244c80c9cb3081e43360d0d1b3a70346590a603f
Reviewed-on: https://review.typo3.org/50424
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove backend user option debugInWindow 64/50464/4
Wouter Wolters [Mon, 31 Oct 2016 20:17:41 +0000 (21:17 +0100)]
[!!!][TASK] Remove backend user option debugInWindow

The option is unused in the core and no usages are found in TER.

Resolves: #78522
Releases: master
Change-Id: Id3cb7fe790b9cf84d2e85595d784edb482f9a32d
Reviewed-on: https://review.typo3.org/50464
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove unused configuration options for JavaScript 63/50463/4
Wouter Wolters [Mon, 31 Oct 2016 20:09:04 +0000 (21:09 +0100)]
[!!!][TASK] Remove unused configuration options for JavaScript

Remove all options that are not used anymore from TYPO3.configuration
in JavaScript context.

Resolves: #78525
Releases: master
Change-Id: I69ee333e01d75ab4dc14b35f91a172df1ab20d62
Reviewed-on: https://review.typo3.org/50463
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make checks in localize compatible with new Localization Wizard 22/50022/10
Tymoteusz Motylewski [Sat, 29 Oct 2016 20:51:05 +0000 (22:51 +0200)]
[BUGFIX] Make checks in localize compatible with new Localization Wizard

The checks for language and localization-parent in DataHandler's localize
method are made compatible with the options which the new localization wizard
allows; more specifically allowing translations from other languages than the
default language (but still pointing to a default record).

This makes it also possible to make correct use of the localize command
instead of the copy command now when translating from other languages than
the default language.

Resolves: #78059
Releases: master, 7.6
Change-Id: I01647d759a745abbbf0fa34a16b20f3085ef91ea
Reviewed-on: https://review.typo3.org/50022
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Allow RTE transformations in palettes 01/49201/13
Johannes Schlier [Mon, 31 Oct 2016 09:33:47 +0000 (10:33 +0100)]
[BUGFIX]¬†Allow RTE transformations in palettes

When having an RTE inside a palette (e.g. sys_file_reference
description field changed to a RTE field) then the RTE configuration
is not taken into account, thus it's not possible to do proper
transformations. All links are not working then.

The patch allows to parse the fields inside palettes as well.

Resolves: #60399
Resolves: #76745
Releases: master, 7.6
Change-Id: I0c4efc0a03682cd766a2a164cf7b2fa14cd7c1b9
Reviewed-on: https://review.typo3.org/49201
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix path resolving for Default.css in EXT:rtehtmlarea 40/50440/3
Wouter Wolters [Sun, 30 Oct 2016 16:49:10 +0000 (17:49 +0100)]
[BUGFIX] Fix path resolving for Default.css in EXT:rtehtmlarea

Path calculation is missing the resolving of EXT: syntax.
Fix this by adding GeneralUtility::getFileAbsFileName.

Resolves: #78501
Releases: master
Change-Id: Ib377bdd13e002988c35515ad571df2b4a2262e17
Reviewed-on: https://review.typo3.org/50440
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Prevent adding a backend user without password 39/50439/3
Michael Oehlhof [Sat, 29 Oct 2016 22:12:24 +0000 (00:12 +0200)]
[BUGFIX] Prevent adding a backend user without password

Resolves: #78411
Releases: master, 7.6
Change-Id: I47273726595639621c988910a537b205f49be13c
Reviewed-on: https://review.typo3.org/50439
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Create missing directory in UnitTestsBootstrap 53/50453/2
Christian Kuhn [Mon, 31 Oct 2016 13:37:00 +0000 (14:37 +0100)]
[BUGFIX] Create missing directory in UnitTestsBootstrap

typo3temp/assets is needed by ExtensionCompatibilityTesterTest

Change-Id: Ia346f74fc36e402af4a06e28fa2b2961122a3f5a
Resolves: #78514
Releases: master
Reviewed-on: https://review.typo3.org/50453
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Add icon rendering for custom permissions options 67/48967/11
Benjamin Serfhos [Wed, 13 Jul 2016 21:06:14 +0000 (23:06 +0200)]
[BUGFIX] Add icon rendering for custom permissions options

The icon rendering of custom page options was lost during
refactoring of the ItemProviders.

Resolves: #77075
Releases: master, 7.6
Change-Id: Iae6415525d94fc56c48332de9e5bc3980344fbc2
Reviewed-on: https://review.typo3.org/48967
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] README.md Contribution Workflow Link 48/50448/3
Christian Kuhn [Mon, 31 Oct 2016 09:07:51 +0000 (10:07 +0100)]
[TASK] README.md Contribution Workflow Link

Link to docs.typo3.org instead of wiki.

Change-Id: Ib76f1fb11b9cc0e8069407528ab058f7ae2e984e
Resolves: #78510
Releases: master
Reviewed-on: https://review.typo3.org/50448
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[FOLLOWUP][BUGFIX] Fetching configuration-comments should require no comma 45/50445/2
Markus Klein [Mon, 31 Oct 2016 02:29:39 +0000 (03:29 +0100)]
[FOLLOWUP][BUGFIX] Fetching configuration-comments should require no comma

Fix regex to capture description correctly.

Resolves: #78333
Releases: master, 7.6
Change-Id: I8b731c2e1c2a4e9e3d1fdf01823bbefadee367fb
Reviewed-on: https://review.typo3.org/50445
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Cleanup .travis.yml 42/50442/3
Christian Kuhn [Sun, 30 Oct 2016 19:01:07 +0000 (20:01 +0100)]
[TASK] Cleanup .travis.yml

* Remove some acceptance test setup left overs
* Increase number of functional tests jobs again, sync with 7.6 setting

Change-Id: Ia894f19f89ccb027bdca0163a9e8bafc579ab6e3
Resolves: #78503
Releases: master
Reviewed-on: https://review.typo3.org/50442
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Enable curl on AppVeyor CI 41/50441/4
Wouter Wolters [Sun, 30 Oct 2016 18:19:19 +0000 (19:19 +0100)]
[BUGFIX] Enable curl on AppVeyor CI

Facebook Webdriver dependency needs curl enabled.

Resolves: #78502
Releases: master
Change-Id: I216b4c82fb4f648d1bc48ccaed0b2c365691544b
Reviewed-on: https://review.typo3.org/50441
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Dependencies between unit tests 35/50435/5
Christian Kuhn [Sat, 29 Oct 2016 20:42:44 +0000 (22:42 +0200)]
[BUGFIX] Dependencies between unit tests

Our unit tests have an annoying history of dependencies between
each other: There are tests that rely on global state changes from
other tests. Those are hard and time consuming to track down and
lead to erratic test results if not fixed.

The patch resolves the hopefully last occurences of those cross
dependencies, all of these issues were recently introduced:

* A bug in extbase DebuggerUtility lets a test in core DebugUtilityTest fail
* SchemaColumnDefinitionListenerTest is changed to cope with a possible
  global change by a different test that we can not prevent otherwise
* felogin FrontendLoginControllerTest properly handles registered
  global objects to prevent side effects on TemplateServiceTest

To prevent such issues in the future, the new require-dev dependency
"phpunit-randomizer" is added. It allows running tests in random order
to reveal cross dependencies:

./bin/phpunit-randomizer -c typo3/sysext/core/Build/UnitTests.xml --order rand

Each run echos out a specific seed that can be used to replay this specific
order of tests:

./bin/phpunit-randomizer -c typo3/sysext/core/Build/UnitTests.xml --order rand:1234

The randomizer will be added to the pre-merge tests with a couple of
runs to find those cross dependencies more quickly.

Change-Id: Id08eda19df98f1a8adf25259f852928020acd810
Resolves: #78499
Releases: master
Reviewed-on: https://review.typo3.org/50435
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Daniel Lorenz <daniel.lorenz@extco.de>
Tested-by: Daniel Lorenz <daniel.lorenz@extco.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Remove Firefox CSS loading hack in RTE editor 28/50428/2
Markus Klein [Fri, 28 Oct 2016 22:17:31 +0000 (00:17 +0200)]
[BUGFIX] Remove Firefox CSS loading hack in RTE editor

Remove a totally outdated Firefox hack for loading CSS files.

Resolves: #78492
Releases: master
Change-Id: I5dad91d01e212927d906b0548471d23137d58c29
Reviewed-on: https://review.typo3.org/50428
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Remove an erratic unit test 33/50433/3
Christian Kuhn [Sat, 29 Oct 2016 13:02:37 +0000 (15:02 +0200)]
[BUGFIX] Remove an erratic unit test

The permission tests tend to be erratic depending on the
environment. We can't control every detail and some of them
are skipped in various scenarios already.
They also don't provide *that* much value.

The patch removes one test that tends to fail depending on
access rights of parent directories.

Change-Id: I2406ea16f7f88867a9be21d6d561516bddcc2dec
Resolves: #78498
Releases: master
Reviewed-on: https://review.typo3.org/50433
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Prevent installation of incompatible extensions 27/50427/3
Nicole Cordes [Fri, 28 Oct 2016 22:16:58 +0000 (00:16 +0200)]
[BUGFIX] Prevent installation of incompatible extensions

If an extension is installed, all information are gathered from database.
Here also a check for possible update versions is triggered. In this
check potential dependency updates are marked which get installed during
the underlying extension installation.
This patch prevents gathering TER information during an installation
process to prevent any update information to be registered.

Resolves: #78494
Resolves: #76542
Releases: master, 7.6, 6.2
Change-Id: I0fb2b4632bef05912a329553b70f26d614a1ba9c
Reviewed-on: https://review.typo3.org/50427
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Make clickarea of cache clearing bigger 23/50423/2
Manuel Glauser [Fri, 28 Oct 2016 13:50:16 +0000 (15:50 +0200)]
[TASK] Make clickarea of cache clearing bigger

Make clear cache icons part of the clickable area.

Resolves: #78377
Releases: master
Change-Id: I058386c230ad59160afd7a1d55f9517f1824067c
Reviewed-on: https://review.typo3.org/50423
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update composer dependencies 79/50279/4
Markus Klein [Thu, 27 Oct 2016 21:59:46 +0000 (23:59 +0200)]
[TASK] Update composer dependencies

Resolves: #78483
Releases: master
Change-Id: I10b4fc4c8205291eee7570e57985a7a2fcbf3b28
Reviewed-on: https://review.typo3.org/50279
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fluidification of installed services report 61/50061/5
Michael Oehlhof [Wed, 28 Sep 2016 22:09:07 +0000 (00:09 +0200)]
[TASK] Fluidification of installed services report

Resolves: #78088
Releases: master
Change-Id: I975361c525c22c5fbc2b6e7ced4f0a4e5ac8d514
Reviewed-on: https://review.typo3.org/50061
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Optimize usability of new category tree toolbar 21/50421/4
Frank Naegler [Fri, 28 Oct 2016 13:26:14 +0000 (15:26 +0200)]
[TASK] Optimize usability of new category tree toolbar

This patch improves the usability of the category tree toolbar.

- Add a better icon for the toggle button
- Add a title for the toggle button
- Add tooltip for all buttons
- Group all filter button into one button group

Resolves: #78489
Releases: master
Change-Id: I5a6b30447dbb6b313a3ad00673267208236814be
Reviewed-on: https://review.typo3.org/50421
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Allow "0" as path segment in ArrayUtility 30/50430/8
Helmut Hummel [Fri, 28 Oct 2016 23:17:53 +0000 (01:17 +0200)]
[BUGFIX] Allow "0" as path segment in ArrayUtility

The empty() checks are too loose when checking for path segments
of an array, as "0" is a valid segment.
Instead we need to check for an empty string in the according places.

Also add a missing string check in getValueByPath.

Resolves: #78495
Releases: master, 7.6
Change-Id: I6b2a0c286c345aa94595a4a74da077bc8adea292
Reviewed-on: https://review.typo3.org/50430
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][TASK] Refactor use of queryBuilder to use prepared statements 25/50425/2
Markus Klein [Fri, 28 Oct 2016 21:30:56 +0000 (23:30 +0200)]
[FOLLOWUP][TASK] Refactor use of queryBuilder to use prepared statements

Fix mistakes.

Resolves: #78437
Releases: master
Change-Id: Iefe82b5c2ef0f3643c3c69cda82de0992a10dd00
Reviewed-on: https://review.typo3.org/50425
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Use correct content type for BE ajax requests 26/50426/2
Markus Klein [Fri, 28 Oct 2016 22:14:38 +0000 (00:14 +0200)]
[BUGFIX] Use correct content type for BE ajax requests

Fix invalid content type in toolbar items.

Resolves: #78493
Releases: master, 7.6
Change-Id: Ie4341136a9978e1c446f3871ba44602dd7d7f53d
Reviewed-on: https://review.typo3.org/50426
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Update bower components to latest versions 10/50410/4
Frank Naegler [Fri, 28 Oct 2016 11:39:32 +0000 (13:39 +0200)]
[TASK] Update bower components to latest versions

This patch updates the bower components to the latest version.
Also the version contraints in bower.json are updated to get the
latest and non breaking versions.

Only for jquery-ui we pinned the version to 1.11.4 for legacy reasons.

Resolves: #78484
Releases: master
Change-Id: Ic7b49449fac6d8e616fed969bdc770b34827edea
Reviewed-on: https://review.typo3.org/50410
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Merge all changes done by grunt build 09/50409/2
Wouter Wolters [Fri, 28 Oct 2016 11:06:41 +0000 (13:06 +0200)]
[TASK] Merge all changes done by grunt build

Make compiling with grunt clean again when executing.

Resolves: #78482
Releases: master
Change-Id: I716783c338d7247a64c9d37cc1f066f47ac3c40e
Reviewed-on: https://review.typo3.org/50409
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Robert van Kammen <rvkammen@hotmail.com>
Tested-by: Robert van Kammen <rvkammen@hotmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>