Packages/TYPO3.CMS.git
5 years ago[BUGFIX] Treat link handler links as internal URLs 80/27680/5
Alexander Stehlik [Tue, 18 Feb 2014 09:55:05 +0000 (10:55 +0100)]
[BUGFIX] Treat link handler links as internal URLs

The RteHtmlParser will now check if a scheme found by parse_url()
matches a configured typolinkLinkHandler. If this is the case the
link will be treated as internal.

Resolves: #49036
Releases: 6.3, 6.2, 6.1
Change-Id: Ie4e6bded7a1c4d0c61e4f1a20bc23115612c1519
Reviewed-on: https://review.typo3.org/27680
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] FollowUp to add support for having files outside the t3d/xml 55/30955/3
Marc Bastian Heinrichs [Fri, 20 Jun 2014 17:06:36 +0000 (19:06 +0200)]
[TASK] FollowUp to add support for having files outside the t3d/xml

Fix functional tests.

Resolves: #57379
Change-Id: Iafbf4e2b7e68dd27b488f20141f34680f57bc9c4
Reviewed-on: https://review.typo3.org/30955
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Remove not maintained ChangeLog in EXT:linkvalidator 60/30960/2
Wouter Wolters [Fri, 20 Jun 2014 18:19:23 +0000 (20:19 +0200)]
[TASK] Remove not maintained ChangeLog in EXT:linkvalidator

Resolves: #59738
Releases: 6.3
Change-Id: Idb08c3f7311ae97590495c77d180429baabefcda
Reviewed-on: https://review.typo3.org/30960
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[TASK] Add support for having files outside the t3d/xml in impexp 53/30453/3
Marc Bastian Heinrichs [Tue, 27 May 2014 19:42:42 +0000 (21:42 +0200)]
[TASK] Add support for having files outside the t3d/xml in impexp

Impexp files are blown up from the files that are included as base64.
This patch adds the possibility to have the files separated from the
 t3d/xml export file. They are saved to a folder beside the export file.

Resolves: #57379
Releases: 6.3, 6.2
Change-Id: Ib8bdc4336c64d2eae0e993132a5fce84eb01f766
Reviewed-on: https://review.typo3.org/30453
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] language condition does not match exact string 20/30920/3
Susanne Moog [Fri, 20 Jun 2014 11:58:35 +0000 (13:58 +0200)]
[BUGFIX] language condition does not match exact string

The documentation for conditions of type "language" states: "The values
must be a straight match with the value of getenv('HTTP_ACCEPT_LANGUAGE')
from PHP." (or you can use wildcards). Exact matches are actually
not working - and the unit test showing the problem was skipped.

Patch adds the feature as documented and adjusts the unit test.

Change-Id: I5691fff41c889476d8149d6f92c26731ad7bb1fd
Resolves: #59707
Releases: 6.3
Reviewed-on: https://review.typo3.org/30920
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Remove skipped FAL tests 40/30940/2
Susanne Moog [Fri, 20 Jun 2014 14:37:57 +0000 (16:37 +0200)]
[TASK] Remove skipped FAL tests

FAL includes some tests that are skipped ever since
FAL was merged. Most of them don't even have a
comment as to why and need to be completely rewritten
as the functionality changed.

We should remove these tests for now.

Change-Id: Ib75b4ea104a968019e06937974eaa1846cfe3a8a
Releases: 6.3
Resolves: #59728
Reviewed-on: https://review.typo3.org/30940
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Nested flexforms no longer throw exception 90/30590/7
Thomas Christiansen [Thu, 5 Jun 2014 13:33:53 +0000 (15:33 +0200)]
[BUGFIX] Nested flexforms no longer throw exception

This patch prevents nested flexforms from throwing
an exception on saving or opening the record.

Resolves: #59368
Releases: 6.2

Change-Id: Iadeeecc3aef92b8bcc4f7fe4e22882d924f10a50
Reviewed-on: https://review.typo3.org/30590
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[TASK] Raise recommended max nesting level 08/30608/4
Thomas Christiansen [Fri, 6 Jun 2014 13:37:06 +0000 (15:37 +0200)]
[TASK] Raise recommended max nesting level

Raise recommended max nesting level to 400 as
the current value of 250 does not suffice.

Resolves: #59391
Releases: 6.3, 6.2
Change-Id: Ibccb61991809e24baddb21bd46f190cd0b8d907d
Reviewed-on: https://review.typo3.org/30608
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Re-add unit tests for ExtensionCompatibilityTester 15/30915/3
Susanne Moog [Fri, 20 Jun 2014 10:23:21 +0000 (12:23 +0200)]
[TASK] Re-add unit tests for ExtensionCompatibilityTester

The tests for the ExtensionCompatibilityTester are currently skipped.
This patch removes the broken tests and leaves the working ones.

Releases: 6.3
Resolves: #59700

Change-Id: I10a49d0dddf2807bd50944837e31f0105374c8c9
Reviewed-on: https://review.typo3.org/30915
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Check for logged in user before showing cookie warning 23/30723/5
Tomita Militaru [Sat, 14 Jun 2014 11:52:38 +0000 (14:52 +0300)]
[BUGFIX] Check for logged in user before showing cookie warning

If a redirect for login error is setup, the warning cookie
message is displayed instead of redirecting.

Resolves: #59493
Releases: 6.3, 6.2
Change-Id: I2f63b6630863ece0704198f247980c4d6c08f65a
Reviewed-on: https://review.typo3.org/30723
Reviewed-by: Oliver Hader
Reviewed-by: Marc Wöhlken
Tested-by: Marc Wöhlken
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Make Functional tests work on fast machines 96/30696/7
Tymoteusz Motylewski [Thu, 12 Jun 2014 14:02:20 +0000 (16:02 +0200)]
[BUGFIX] Make Functional tests work on fast machines

Adds more entropy to the uniqid() call. So each call inside
foreach loop will generate unique value.
As uniqid() generates values based on current time,
subsequent calls may return the same value on a fast machine.

On Windows it's even worse, as uniqid()
has single-second-resolution out of the box.

Resolves: #59529
Relates: #58602
Releases: 6.3, 6,2
Change-Id: I7476f85961e906905acaca7fd816e37375c9817c
Reviewed-on: https://review.typo3.org/30696
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[TASK] Increase Extension Manager->showConfiguration input field width 04/30904/2
Felix Kopp [Fri, 20 Jun 2014 08:51:18 +0000 (10:51 +0200)]
[TASK] Increase Extension Manager->showConfiguration input field width

Increases the width of string input fields to 300 pixels.

Resolves: #59679
Releases: 6.2, 6.3
Change-Id: Ia415a6cdf81e4f6192a7e3fb93d8f01d8a749c6a
Reviewed-on: https://review.typo3.org/30904
Reviewed-by: Susanne Moog
Tested-by: Susanne Moog
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Get unit tests working again 89/30889/4
Markus Klein [Thu, 19 Jun 2014 18:10:15 +0000 (20:10 +0200)]
[BUGFIX] Get unit tests working again

Changed serialize behaviour in PHP triggers funny phpunit issues in
some tests. Switching to phpunit master for now and skipping some
tests makes travis-ci green again and gives us time for detail fixes.

Change-Id: I1c694c0c5dba98b31b9ef7c826fa6614ffa512df
Resolves: #59685
Releases: 6.3, 6.2
Reviewed-on: https://review.typo3.org/30889
Reviewed-by: Christian Mueller
Reviewed-by: Oliver Klee
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
5 years ago[BUGFIX] Pass field name variable to flexform DS utility 33/30633/6
Claus Due [Mon, 9 Jun 2014 21:30:37 +0000 (23:30 +0200)]
[BUGFIX] Pass field name variable to flexform DS utility

A field name parameter is not being passed from within
DataHandler when copying a record which has a FlexForm
DF associated with it. This causes dynamic FlexForm DS
definitions to not be able to depend on the field name,
in turn causing the problem that an incorrect DS may be
returned from the DS utility which makes TYPO3 process
the data value incorrectly (for example, not detecting
file fields and processing the values accordingly).

To solve this the $field parameter is passed.

Resolves: #59423
Releases: 6.3, 6.2, 6.1
Change-Id: Icfafd553f76e17ad5db651bb3f5dea52b140dcf7
Reviewed-on: https://review.typo3.org/30633
Reviewed-by: Cedric Ziel
Tested-by: Cedric Ziel
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Remove warnings in ImportExportController.php 81/29881/3
Nicole Cordes [Mon, 5 May 2014 20:21:49 +0000 (22:21 +0200)]
[BUGFIX] Remove warnings in ImportExportController.php

This patch adds cleanup to prevent warnings when accessing the
import/export module.

Resolves: #58534
Releases: 6.3, 6.2
Change-Id: I1e1afbea07b0c8e8c4bc29d25739882907c79b4b
Reviewed-on: https://review.typo3.org/29881
Reviewed-by: Susanne Moog
Reviewed-by: Wouter Wolters
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[FEATURE] Add uid to SysDomainCache 94/28794/3
Henrik Ziegenhain [Tue, 25 Mar 2014 18:11:25 +0000 (19:11 +0100)]
[FEATURE] Add uid to SysDomainCache

If you are building an extension, that outputs
data depending on a selected domain, it is easier
to compare the uid of sys_domain records
than the domainName itself.

Resolves: #57297
Releases: 6.3
Change-Id: Ic1efd3efe043f28ef7737f407d9a200b168d9685
Reviewed-on: https://review.typo3.org/28794
Reviewed-by: Markus Schubath
Tested-by: Markus Schubath
Reviewed-by: Krzysztof Adamczyk
Reviewed-by: Andrea Schmuttermair
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Extension manager: default sorting for Extensions 35/30735/4
Felix Kopp [Sun, 15 Jun 2014 09:13:17 +0000 (11:13 +0200)]
[TASK] Extension manager: default sorting for Extensions

EM "Get Extension" does not show the awesome extension culture
that lives in the TER. Change sorting basically with the primary goal
to order extensions by update.

Resolves: #59583
Releases: 6.3, 6.2
Change-Id: Ie8aebc13c41427e0603fa5313b794996d01fbc44
Reviewed-on: https://review.typo3.org/30735
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Robert van Kammen
Tested-by: Robert van Kammen
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Ensure that cli user is admin on extension install and uninstall 15/30715/4
Marc Bastian Heinrichs [Fri, 13 Jun 2014 14:24:57 +0000 (16:24 +0200)]
[TASK] Ensure that cli user is admin on extension install and uninstall

Extension install and uninstall is an admin task. Calling the belonging
CommandController on cli should ensure, that the user has admin
rights.

This adds API to the CommandController to avoid code duplication
in every controller to achieve this.

Distribution packages could be installed via cli without errors now.

Resolves: #59556
Releases: 6.3, 6.2
Change-Id: Icd1b6bf4379322c8bec07531a15d2171b103e076
Reviewed-on: https://review.typo3.org/30715
Reviewed-by: Ernesto Baschny
Tested-by: Ernesto Baschny
5 years ago[BUGFIX] Fix RTE file links migration 20/30820/2
Markus Klein [Wed, 18 Jun 2014 15:07:19 +0000 (17:07 +0200)]
[BUGFIX] Fix RTE file links migration

Links in RTE might be stored as <LINK or <link.
Currently the upgrade wizards lacks support for <LINK.
Add this to the regular expression.

Resolves: #51800
Releases: 6.3, 6.2
Change-Id: Ic22983db1144fb1317d6102907c792871e1eeaed
Reviewed-on: https://review.typo3.org/30820
Reviewed-by: Christian Kuhn
Tested-by: Christian Kuhn
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Wrong check for showing folder clickmenu 59/30759/3
Frans Saris [Mon, 16 Jun 2014 19:39:04 +0000 (21:39 +0200)]
[BUGFIX] Wrong check for showing folder clickmenu

This patch fixes a wrong check that prevents the clickmenu
from showing for folders in the filelist.

Resolves: #59568
Releases: 6.3, 6.2
Change-Id: Ic1e8bb28f64717631c4b57bc44221bd1132b876e
Reviewed-on: https://review.typo3.org/30759
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Typos in t3skin css files 29/30329/6
Markus Klein [Thu, 22 May 2014 14:10:21 +0000 (16:10 +0200)]
[BUGFIX] Typos in t3skin css files

Remove the lines as they have not been valid, nobody will miss them.

Resolves: #57716
Releases: 6.3, 6.2
Change-Id: I70625980ec49f6a8f76d695c4e2eb5d3c1548b36
Reviewed-on: https://review.typo3.org/30329
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Correctly align datepicker clear input and trigger icon 58/30758/3
Frans Saris [Mon, 16 Jun 2014 19:26:54 +0000 (21:26 +0200)]
[BUGFIX] Correctly align datepicker clear input and trigger icon

This patch fixed the alignment of the clear input icon in the
date input fields and the trigger icon outside the datepicker input
fields.

Resolves: #59615
Releases: 6.3, 6.2
Change-Id: I0943ea0a8c4157d46fc07ca055ac8c1ab67c9a5b
Reviewed-on: https://review.typo3.org/30758
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Set TYPO3 version to 6.3-dev 86/30786/2
Oliver Hader [Tue, 17 Jun 2014 16:48:49 +0000 (18:48 +0200)]
[TASK] Set TYPO3 version to 6.3-dev

Releases: 6.3
Change-Id: Ie6aef74f866ac9b93e752a777ce6313126d8a32f
Reviewed-on: https://review.typo3.org/30786
Reviewed-by: Christian Kuhn
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Undefined method in extension manager 77/30777/2
Oliver Hader [Tue, 17 Jun 2014 13:35:14 +0000 (15:35 +0200)]
[BUGFIX] Undefined method in extension manager

PHP fatal error due to the invalid call to non-existing method
ExtensionManagementService::resolveDependenciesAndInstall during
upgrading an existing extension to a newer version from TER.

Resolves: #59624
Releases: 6.2
Change-Id: I84ff3685a94625cbc94af1967ac65b61cf9f5e43
Reviewed-on: https://review.typo3.org/30777
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Page tree does not visualize move targets 73/30473/2
Oliver Hader [Wed, 28 May 2014 13:40:01 +0000 (15:40 +0200)]
[BUGFIX] Page tree does not visualize move targets

If moving an element to a different page, the page tree only
visualizes the change in the source page, but does not visualize
the target page.

The reason is that the move-pointer is used (t3ver_state=4)
instead of the move-placeholder (t3ver_state=3) in that case.

Resolves: #59114
Releases: 6.2
Change-Id: Iefa01e4c85e9fb753873d03e7638ac592c09a657
Reviewed-on: https://review.typo3.org/30473
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Define precedence of states in workspace module 67/30467/2
Oliver Hader [Wed, 28 May 2014 11:03:58 +0000 (13:03 +0200)]
[BUGFIX] Define precedence of states in workspace module

The workspace module defines several states:
edited, moved, created, hidden, unhidden, deleted

The states "hidden" and "unhidden" are currently applied
after the action states. This change only uses the hidden
states if a record has been modified.

Resolves: #59118
Releases: 6.2
Change-Id: I95981306d61df38939a47579cb320dd93d51ce5b
Reviewed-on: https://review.typo3.org/30467
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Preview of moved workspace elements on source page 74/30474/2
Oliver Hader [Wed, 28 May 2014 13:42:21 +0000 (15:42 +0200)]
[BUGFIX] Preview of moved workspace elements on source page

If e.g. a content element gets moved to a different page, the
workspace preview link opens the source page (which does not
contain the element anymore, because it was moved).

Since the elements are shown on the correct page in the
workspace backend module, using the target page in the preview
link for the frontend is just obvious.

Resolves: #59143
Releases: 6.2
Change-Id: Ib84e65766e825cc26a66cbda9ffa8132c3a3ec18
Reviewed-on: https://review.typo3.org/30474
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years agoRevert "[BUGFIX] Session cookie is not recreated on login" 53/30753/6
Helmut Hummel [Mon, 16 Jun 2014 14:36:12 +0000 (16:36 +0200)]
Revert "[BUGFIX] Session cookie is not recreated on login"

This reverts commit 76741dff7b967b88aa1d6e556500a77716c7a97a
(https://review.typo3.org/29626)

This change is not needed any more as the fix done
for #58713 also fixes the issues targeted with this fix.

This should be reverted not only because it is not needed
any more but especially because it "abuses" the property
->newSessionID which should only be set when really
a new ID has been generated and not to force the cookie
to be set again.

Releases: 6.2
Resolves: #59614
Reverts: #57751
Related: #58713
Change-Id: I5324769b0795bcc1b1f1e385c73fd085d7b3f571
Reviewed-on: https://review.typo3.org/30753
Reviewed-by: Markus Klein
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGIFX] Field labels not shown in workspaces history 13/30713/2
Oliver Hader [Fri, 13 Jun 2014 11:23:01 +0000 (13:23 +0200)]
[BUGIFX] Field labels not shown in workspaces history

Field labels are not shown if opening the history of an
element in the workspace module.

Resolves: #59546
Releases: 6.2
Change-Id: I3f522957dad8e36046b508dde658496f1cec6008
Reviewed-on: https://review.typo3.org/30713
Reviewed-by: Wouter Wolters
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Broken tests due to modified PostProcessor constructor 14/30714/2
Oliver Hader [Fri, 13 Jun 2014 13:03:49 +0000 (15:03 +0200)]
[BUGFIX] Broken tests due to modified PostProcessor constructor

Issue #31951 introduced a breaking change in changing the order
of constructor arguments in the form PostProcessor. This could
have been avoided since new TypoScriptFactory object is and was
a singleton.

Resolves: #59549
Releases: 6.2
Change-Id: I1134d4440437e9fe03129241e63c0f0004712176
Reviewed-on: https://review.typo3.org/30714
Reviewed-by: Marc Bastian Heinrichs
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Own Layout Breaks Mail Message 26/28526/9
Cornel Boppart [Wed, 19 Mar 2014 15:23:03 +0000 (16:23 +0100)]
[BUGFIX] Own Layout Breaks Mail Message

With this patch it is possible to configure custom layouts
for the form, confirmation, and each type of post processor.
The backward compatibility is given, because this does not override
or break already existing configurations but provides some more
options to configure specific steps of the form process independent
of each other.
Therefore it prevents from breaking the layout of the confirmation view
and the HTML mail.

Resolves: #31951
Releases: 6.2
Change-Id: I3c015b53cd6d6efbd070d16bdc2111c7d60671aa
Reviewed-on: https://review.typo3.org/28526
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Markus Klein
Reviewed-by: Dmitry Dulepov
Tested-by: Dmitry Dulepov
5 years ago[TASK] Restructure functional frontend tests 87/30687/4
Oliver Hader [Tue, 10 Jun 2014 09:53:05 +0000 (11:53 +0200)]
[TASK] Restructure functional frontend tests

In the scope of enabling Extbase frontend rendering during
functional test runs, the response object contains multiple
data values for TypoScript ("default") and the called Extbase
actions. Processing them all at once just has practical reasons
to avoid additional frontend requests for each aspect.
To decouple the actual testing structure from assertions
and constraints, a new Contraint namespace has been introduced.

The irre_tutorial extension has been enriched with an accordant
frontend rendering for Extbase context to return structured JSON
data like in the current frontend tests.

This change contains Extbase TypoScript which will be activated
in a separate bugfixing change.

Resolves: #59521
Releases: 6.2
Change-Id: I42c0bf8957d9c4c1e4389049695512851b436d14
Reviewed-on: https://review.typo3.org/30687
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Integrate functional DataHandler tests for FAL 16/30516/6
Oliver Hader [Wed, 11 Jun 2014 11:06:41 +0000 (13:06 +0200)]
[TASK] Integrate functional DataHandler tests for FAL

The functional frontend tests are extended with basic FAL
use-cases in the live workspaces, as well as for modifying,
publishing single records and publishing all records in a
particular workspaces scenario.

The frontend is tested by using the TypoScript FILES cObject.

Resolves: #59276
Releases: 6.2
Change-Id: I3a1e59f70015b1168e4f29458c8d6ff77c0b3dcf
Reviewed-on: https://review.typo3.org/30516
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Field size of t3ver_label too low 66/30466/2
Oliver Hader [Wed, 28 May 2014 09:28:04 +0000 (11:28 +0200)]
[BUGFIX] Field size of t3ver_label too low

During workspace move operations sometimes a warning like
this can be found:

  102: These fields are not properly updated in database:
  (t3ver_label) Probably value mismatch with fieldtype.

The reason is, that the t3ver_label field in almost every
record is limited to 30 characters in the SQL definition.
Besides that the error code "102" of the mentioned warning
is invalid and should just be "1" to be recognized by the
accordant functional tests as well.

Resolves: #59110
Releases: 6.2
Change-Id: Ia97a32dbefd1d27e33f186c19c5a6a495dcc194a
Reviewed-on: https://review.typo3.org/30466
Reviewed-by: Wouter Wolters
Reviewed-by: Krzysztof Adamczyk
Reviewed-by: Marcin Sągol
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] IRRE children's children are not moved with parent 63/30463/2
Oliver Hader [Wed, 28 May 2014 09:24:14 +0000 (11:24 +0200)]
[BUGFIX] IRRE children's children are not moved with parent

Having a parent-child structure spanning three levels, only the
first and second level elements are moved to a different page.
All child elements below the second level are not changed.

The reason is, that the move-placeholder is only created for
the first level of children.

Resolves: #59111
Releases: 6.2
Change-Id: Ia044a1241b8b1e4885cabbbc44b777f847b4c9e5
Reviewed-on: https://review.typo3.org/30463
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Missing "all workspaces" tab action for regular editors 67/30267/2
Oliver Hader [Wed, 21 May 2014 20:41:22 +0000 (22:41 +0200)]
[BUGFIX] Missing "all workspaces" tab action for regular editors

Clicking the "all workspaces" tab in the workspace backend
module as regular editor does not have any action and actually
misses the accordant action parameter "fullIndex".

Resolves: #59016
Releases: 6.2
Change-Id: I29d47cb82f1bbe1ea51f2a144f24964ab7328f7f
Reviewed-on: https://review.typo3.org/30267
Reviewed-by: Wouter Wolters
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[TASK] Reduce complexity in frontend functional tests 15/30515/5
Oliver Hader [Fri, 30 May 2014 15:56:06 +0000 (17:56 +0200)]
[TASK] Reduce complexity in frontend functional tests

Testing the frontend behavior in functional tests creates
currently an own PHP sub-request to execute TypoScript in
frontent context.
Several hooks collect called cObjects and try to find the
correct nesting levels. Albeit this is working for the
current tests, it is way too complex for extending the
tests for further scenarios like for FAL and Extbase.

The hook magic is resolved and explicit render functions,
called via TypoScript, collect the data an output aggregated
JSON data in the end. Besides that the PHP sub-request
execution now re-uses the PHPUnit utilities to determine
and run the accordant executables.

Resolves: #59487
Releases: 6.2
Change-Id: Ic9eeadee5471a3e0e40d2dffb69b38dec16a0aa1
Reviewed-on: https://review.typo3.org/30515
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
5 years ago[BUGFIX] Preview links are shown for deleted pages 71/30471/2
Oliver Hader [Wed, 28 May 2014 12:03:56 +0000 (14:03 +0200)]
[BUGFIX] Preview links are shown for deleted pages

Preview links should not be shown in the backend, if pages are
deleted in a workspace. Currently both page tree context menu
and workspaces module offer a preview for deleted pages which
results in a "broken rootline" error once being clicked.

Resolves: #59142
Releases: 6.2
Change-Id: Id398ace2deb7dc6f000c7960d23f940b694d6229
Reviewed-on: https://review.typo3.org/30471
Reviewed-by: Wouter Wolters
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Trigger events in DragUploader 76/28976/4
Stephan Schuler [Mon, 31 Mar 2014 12:56:50 +0000 (14:56 +0200)]
[TASK] Trigger events in DragUploader

The DragUploader implementation prevents most of its JavaScript
API to be interacted with from outside the module. Especially
there is no public event allowing interaction based on ajax
responses such as "uploadComplete" or "uploadError".

This patch adds a couple of events being triggered on the $trigger
property of the DragUploader module. That's meant to be the "add"
button in DragUploader context, so it's a mandatory DOM node.

The introduced events are:
* uploadStart
* uploadError
* updateProgress
* uploadComplete

Change-Id: I983d5528247f88d319c2385e3fb032cbd701fa33
Resolves: #57454
Releases: 6.2
Reviewed-on: https://review.typo3.org/28976
Reviewed-by: Stefan Neufeind
Reviewed-by: Helmut Hummel
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Frans Saris
Reviewed-by: Frans Saris
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] sys_news on login with twice hsc 42/30642/2
Alexander Opitz [Tue, 10 Jun 2014 12:10:02 +0000 (14:10 +0200)]
[BUGFIX] sys_news on login with twice hsc

Set RteHtmlParser in dontHSC_rte modus to fix garbled output.

Resolves: #25188
Releases: 6.2, 6.1
Change-Id: Ib01c3f6dcf1729b1979003c207aa622cc5c9b5c3
Reviewed-on: https://review.typo3.org/30642
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Unnecessary instantiation of objects in contentObjectRender 44/30644/4
Tomas Norre Mikkelsen [Tue, 10 Jun 2014 13:15:15 +0000 (15:15 +0200)]
[BUGFIX] Unnecessary instantiation of objects in contentObjectRender

Classes implementing the hook cObjTypeAndClass are instantiated each
time a contentObjectRender is created, even if they are not needed.

This patch introduces lazy loading.

Change-Id: Ifdae8c35fccc8d5070e8b7b30b5e275d9b26561d
Resolves: #59449
Releases: 6.2
Reviewed-on: https://review.typo3.org/30644
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Ritter
Reviewed-by: Fabien Udriot
Reviewed-by: Christian Zenker
Tested-by: Christian Zenker
Tested-by: Steffen Ritter
5 years ago[BUGFIX] AddQueryStringMethod overwrites parameters 11/25211/6
Klaas Johan Kooistra [Fri, 8 Nov 2013 12:41:14 +0000 (13:41 +0100)]
[BUGFIX] AddQueryStringMethod overwrites parameters

Uri parameters are overwritten when using both POST and GET parameters
with the addQueryStringMethod functionality of uri generation.

The problem is solved by using the method
GeneralUtility::array_merge_recursive_overrule() instead of array_merge
when merging the POST and GET parameters.

Resolves: #53450
Releases: 6.2
Change-Id: I39926ebbaa08f6810e440bad1f238aeb2af17e5b
Reviewed-on: https://review.typo3.org/25211
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Tested-by: Wolfgang Wagner
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Add a system check for external downloads 86/30486/3
Markus Klein [Thu, 29 May 2014 13:00:15 +0000 (15:00 +0200)]
[TASK] Add a system check for external downloads

This patch adds a check to the SystemEnvironment checks to test
whether any method for retrieving external files is available.
This involves allow_url_fopen PHP setting and the usage of curl.
Either of these two must be available otherwise any download
(e.g. from TER) fails.

Resolves: #58316
Releases: 6.2
Change-Id: I7dd7d2d7d2ce102723af3315f4ad4342610b4147
Reviewed-on: https://review.typo3.org/30486
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Fabien Udriot
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[FEATURE] Display loading mask in Extension Manager 64/30664/3
Zbigniew Jacko [Wed, 11 Jun 2014 15:28:50 +0000 (17:28 +0200)]
[FEATURE] Display loading mask in Extension Manager

Add a loading mask effect, whenever the User has clicked
on one of the two buttons of the compatibility check message
in the Extension Manager.

Resolves: #59498
Releases: 6.2
Change-Id: I5aed3bb5ffc4b2f0b490ec3da608b9cf33d22d06
Reviewed-on: https://review.typo3.org/30664
Reviewed-by: Fabien Udriot
Reviewed-by: Marcin Sągol
Reviewed-by: Nicole Cordes
Tested-by: Nicole Cordes
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] TS/EM constant categories cannot be localized 03/28903/7
Xavier Perseguers [Thu, 27 Mar 2014 10:40:51 +0000 (11:40 +0100)]
[BUGFIX] TS/EM constant categories cannot be localized

Constant categories may now be localized using a construct similar
to defining custom subcategories:

Fixes: #57369
Documentation: #57371
Releases: 6.2
Change-Id: I6bea094d98897756772a6f616c8a2f3ab5fe7844
Reviewed-on: https://review.typo3.org/28903
Reviewed-by: Wouter Wolters
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Tested-by: Wouter Wolters
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Fix PHP Warning on executing Database Analyzer without changes 70/30670/3
Stephan Großberndt [Wed, 11 Jun 2014 20:11:00 +0000 (22:11 +0200)]
[BUGFIX] Fix PHP Warning on executing Database Analyzer without changes

When running the Database Analyzers "Execute" without checking at least
one checkbox you get a PHP Warning "array_merge(): Argument #2 is not
an array" because instead of returning an array with a message only the
message string was returned.

Fix this by returning the correct variable, which is of type array.

Resolves: #59504
Releases: 6.2
Change-Id: Ifd73d617a4a97f07151fe0e6c6971bcd79c9709c
Reviewed-on: https://review.typo3.org/30670
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] FollowUp to "Invalid localization overlay of cObject FILES" 66/30666/4
Steffen Ritter [Wed, 11 Jun 2014 15:48:28 +0000 (17:48 +0200)]
[BUGFIX] FollowUp to "Invalid localization overlay of cObject FILES"

When fixing language overlay of cObject FILES, the mocking in the unit
test was not adapted.

Resolves: #58352
Resolves: #47869
Releases: 6.2
Change-Id: I8f939e31a13e437e437624dfccddf5f39526fb8b
Reviewed-on: https://review.typo3.org/30666
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[TASK] Add default TypoScript setting for extbase query cache 63/29763/4
Marc Bastian Heinrichs [Fri, 25 Apr 2014 11:54:40 +0000 (13:54 +0200)]
[TASK] Add default TypoScript setting for extbase query cache

The extbase query cache is enabled by default. This patch
adds a TypoScript setting to enable or disable the cache in general
and on a plugin level.

Resolves: #57280
Releases: 6.2
Change-Id: I620a3c4d2c4e508630d97731f12cc11c617aae75
Reviewed-on: https://review.typo3.org/29763
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Detect and import xml file as well as t3d on ext initialization 64/30464/2
Marc Bastian Heinrichs [Wed, 28 May 2014 07:50:15 +0000 (09:50 +0200)]
[TASK] Detect and import xml file as well as t3d on ext initialization

Whenever installing an extension, the file located at
EXT:ext_key/Initialisation/data.t3d is detected and its content imported.
This patch adds support for EXT:ext_key/Initialisation/data.xml file as
well.

Resolves: #59154
Releases: 6.2
Change-Id: Ie5cf843ed7fff24c0cc022892d68fa86ba14a674
Reviewed-on: https://review.typo3.org/30464
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Xavier Perseguers
Reviewed-by: Steffen Ritter
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Fix set_no_cache() log level severity 63/30663/2
Alexander Stehlik [Wed, 11 Jun 2014 14:40:00 +0000 (16:40 +0200)]
[BUGFIX] Fix set_no_cache() log level severity

The array key that is used to check if a Backend user is logged in
is fixed.

Resolves: #59495
Releases: 6.2
Change-Id: Ida6609c3bde998e17a0d9e9184adb48f227507f5
Reviewed-on: https://review.typo3.org/30663
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] Invalid localization overlay of cObject FILES 39/29739/9
Oliver Hader [Wed, 30 Apr 2014 07:44:01 +0000 (09:44 +0200)]
[BUGFIX] Invalid localization overlay of cObject FILES

The TypoScript cObject FILES does not consider localization
overlays and behavior correctly when it comes additional
translation table (e.g. for pages).

Concerning pages_language_overlay.media, there is no default
fallback to the values of the default language. This behavior
is the same to TYPO3 4.5. If the localization shall fallback
to the default language, the "mergeIfNotBlank" property needs
to be used for the accordant field.

For having the localization handling working properly the
FILES cObject section "references" must not set the properties
"table" and "uid" - otherwise the values will just be overriden
by those TypoScript settings.

Resolves: #58352
Resolves: #47869
Releases: 6.2
Change-Id: I8e915654e5ab1ed1eafe86411930f9fbfcc225ae
Reviewed-on: https://review.typo3.org/29739
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] EM: Add possibility to bypass system dependency checks 45/29845/18
Nicole Cordes [Sat, 3 May 2014 14:05:10 +0000 (16:05 +0200)]
[TASK] EM: Add possibility to bypass system dependency checks

This patch adds a new action to show all unresolved dependencies and
adds the possibility to bypass all system and version checks. Required
extensions are still tried to be fetched from TER.

Resolves: #54512
Releases: 6.2
Change-Id: I11cca622875d013ab6fd385d2c659477e803f6a2
Reviewed-on: https://review.typo3.org/29845
Reviewed-by: Markus Klein
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] PAGE_TSCONFIG_ID is not visible in TCA wizards 98/30498/5
Steffen Kamper [Sat, 31 May 2014 12:05:08 +0000 (14:05 +0200)]
[BUGFIX] PAGE_TSCONFIG_ID is not visible in TCA wizards

The placeholder PAGE_TSCONFIG_ID may be used in a foreign_table_where
TCA condition but is not available as parameter when using a wizard
to create new records. This patch fixes this issue.

Fixes: #59245
Releases: 6.2
Change-Id: I19ae9d72e14c047a08107fe6152093a4b04c27f6
Reviewed-on: https://review.typo3.org/30498
Reviewed-by: Wouter Wolters
Reviewed-by: Marcin Sągol
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Erroneous date sorting in File List 57/30657/2
Francois Suter [Wed, 11 Jun 2014 09:38:24 +0000 (11:38 +0200)]
[BUGFIX] Erroneous date sorting in File List

The sorting by date fails in the Filelist module when more
than 9 files with the same date are found since the numerical
suffix used to avoid overwriting existing entries in the
sorting array is not properly padded.

Fixes: #59458
Releases: 6.2
Change-Id: I2c80a00dd1692b0987da3d461cc5a21fcea4c97d
Reviewed-on: https://review.typo3.org/30657
Reviewed-by: Francois Suter
Tested-by: Francois Suter
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Activate 'Flush system caches' with Preset 'Development' 56/30656/4
Zbigniew Jacko [Wed, 11 Jun 2014 09:04:46 +0000 (11:04 +0200)]
[TASK] Activate 'Flush system caches' with Preset 'Development'

Add a new configuration in Install Tool (['SYS']['clearCacheSystem']).
If set, the toolbar of clearing system cache is visible (only for
admin users).

Add it also for Configuration Preset. For Production it is set to FALSE,
for Development it is set to TRUE.

Resolves: #57230
Releases: 6.2
Change-Id: Id45496c6bc1e64b4454ed7ff78e8db1179387b0f
Reviewed-on: https://review.typo3.org/30656
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] File Relations don't work with workspaces 12/29712/9
Benjamin Mack [Mon, 28 Apr 2014 13:28:53 +0000 (15:28 +0200)]
[BUGFIX] File Relations don't work with workspaces

The file repository used to resolve all sys_file_references
handles enable fields manually currently, which is bad because
it forgets to handle the workspace-related where clause.

The attached patch splits the behavior into frontend and
backend context. In backend the RelationHandler is capable
of automatically resolving IRRE structures. In frontend mode
the enableFiels and version preview settings are relevant to
show correct results.

Resolves: #43916
Releases: 6.2
Change-Id: I6c19e5d7b4cd7a2134921c669b82ab90b54844de
Reviewed-on: https://review.typo3.org/29712
Tested-by: Lorenz Ulrich
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Guard FAL API when called with invalid identifiers 26/30526/5
Helmut Hummel [Mon, 2 Jun 2014 18:16:07 +0000 (20:16 +0200)]
[BUGFIX] Guard FAL API when called with invalid identifiers

When calling ResourceFactory::getInstance()
->getFileObjectFromCombinedIdentifier($identifier)
with $identifier === NULL or $identifier === ''
an index entry is written for storage 0 which contains the
last path segment of PATH_site as identifier.

Guard the API in two places by throwing exceptions
when an invalid file identifier is given.

Resolves: #59295
Releases: 6.2
Change-Id: Ie2d6d811193ee21b865161984ddbac240388573b
Reviewed-on: https://review.typo3.org/30526
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[TASK] Improve styling of sys_action "Create Backend User" 46/30646/3
Lorenz Ulrich [Tue, 10 Jun 2014 15:38:51 +0000 (17:38 +0200)]
[TASK] Improve styling of sys_action "Create Backend User"

The styling of sys_action "Create Backend User" is outdated
and should be slightly improved to enhance usability of
this module.

Releases: 6.2
Resolves: #59338
Change-Id: Ifaba21a78687589af9ba0decad8bc2b9fdc4d29d
Reviewed-on: https://review.typo3.org/30646
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Add additional TS for contentRenderingTemplates loaded by file 44/30544/2
Marc Bastian Heinrichs [Tue, 3 Jun 2014 16:40:08 +0000 (18:40 +0200)]
[BUGFIX] Add additional TS for contentRenderingTemplates loaded by file

Loading extensions TS, that provide contentRenderingTemplates, like
css_styled_content, using INCLUDE_TYPOSCRIPT was fixed in
https://review.typo3.org/#/c/21679/.

Since making TS content templates more flexible in
https://review.typo3.org/#/c/27587/ the contentRenderingTemplates wasn't
added to "defaultTypoScript_setup." and "defaultTypoScript_constants."
arrays anymore and breaks the mentioned fix.

Solution is to check the required key in contentRenderingTemplates and
add the defaultContentRendering string now.

Resolves: #59318
Releases: 6.2
Change-Id: I8a367f462f304e07bbcec99fd26818bc98148eb4
Reviewed-on: https://review.typo3.org/30544
Reviewed-by: Benjamin Mack
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] IRRE children show no field values with useCombination 37/19337/3
Stefan Froemken [Wed, 27 Mar 2013 07:47:52 +0000 (08:47 +0100)]
[BUGFIX] IRRE children show no field values with useCombination

The IRRE option useCombination enables to use bi-directional
relations with IRRE items. This enables you to re-use IRRE
items multiple times (similar as FAL is working with IRRE).

To prevent the same child record from being used multiple
times, items already used are removed from the select box.
The code removing the item was written to remove an item
from a select box, but (accidentially) also targets a hidden
item which causes the JavaScript to break so that the field
values of the child objects are not filled on expanding.

By adding an additional check, this can be prevented.
For steps to reproduce refer to #46477.

Resolves: #46477
Releases: 6.2
Change-Id: Ie7fd89f6ef887b5d45c734dea8ec6ad9ac2a8d2c
Reviewed-on: https://review.typo3.org/19337
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[BUGFIX] Move TCA for fe_users and fe_groups into TCA/Overrides 20/30620/8
Anja Leichsenring [Sat, 7 Jun 2014 06:58:30 +0000 (08:58 +0200)]
[BUGFIX] Move TCA for fe_users and fe_groups into TCA/Overrides

TCA manipulation code must no longer reside in ext_tables.php, but
moved to Configuration/TCA/Overrides/<tablename>.php. Leftovers
in ext_tables might disturb loading order of TCA changes.

Change-Id: Ie919a856fbd8242d19110c8db8d01ff7865c913c
Resolves: #59397
Releases: 6.2
Reviewed-on: https://review.typo3.org/30620
Reviewed-by: Krzysztof Adamczyk
Tested-by: Krzysztof Adamczyk
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] Fetch RSA public key by Ajax before FE login 64/30364/11
Frans Saris [Fri, 23 May 2014 13:29:02 +0000 (15:29 +0200)]
[BUGFIX] Fetch RSA public key by Ajax before FE login

Instead of generating and saving the public/private keys for
an RSA enabled login form on rendering the form the keys are
fetched on submit. This resolves the issue with outdated keys
and the problem that the login box on first page doesn't work
anymore when a page in a second tab is opened.

Resolves: #59041
Releases: 6.2
Change-Id: I0ad13775f029a29f6f67e302a1a63f3860e902b5
Reviewed-on: https://review.typo3.org/30364
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Zbigniew Jacko
Tested-by: Zbigniew Jacko
Reviewed-by: Steffen Ritter
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] FollowUp to "Include suggest info into package metadata" 38/30638/2
Steffen Ritter [Tue, 10 Jun 2014 10:12:14 +0000 (12:12 +0200)]
[TASK] FollowUp to "Include suggest info into package metadata"

A small follow-up renaming the variable of the loop which
has not been renamed after copy and paste.

Resolves: #58701
Releases: 6.2
Change-Id: I70af6722200fda48b09734e21c6d90d3a4e9b868
Reviewed-on: https://review.typo3.org/30638
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Steffen Ritter
Tested-by: Steffen Ritter
5 years ago[BUGFIX] rtehtmlarea user settings are not shown in setup ext 06/30006/5
Markus Klein [Sat, 10 May 2014 23:54:25 +0000 (01:54 +0200)]
[BUGFIX] rtehtmlarea user settings are not shown in setup ext

Fix this by adding the suggestion already present in
the ext_emconf.php also to the composer.json.

Resolves: #58694
Releases: 6.2
Change-Id: I9ded17691ed91fce099638bdac4b4f425cb47ea6
Reviewed-on: https://review.typo3.org/30006
Reviewed-by: Loek Hilgersom
Tested-by: Loek Hilgersom
Reviewed-by: Jacco van der Post
Tested-by: Jacco van der Post
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Observe ext suggestions for ext loading order 05/30005/6
Markus Klein [Sat, 10 May 2014 23:48:32 +0000 (01:48 +0200)]
[TASK] Observe ext suggestions for ext loading order

Let the DependencyResolver take the suggest-part of the composer.json
or ext_emconf.php files into account. This solves issues where it is
necessary to ensure a certain loading order of extensions without
having a real dependency between those.

Resolves: #57825
Releases: 6.2
Change-Id: Ia771813b7945409e5ddaec3f19da27239be16e67
Reviewed-on: https://review.typo3.org/30005
Reviewed-by: Loek Hilgersom
Tested-by: Loek Hilgersom
Reviewed-by: Thomas Maroschik
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years ago[TASK] Include suggest info into package metadata 15/30015/3
Markus Klein [Sun, 11 May 2014 21:30:37 +0000 (23:30 +0200)]
[TASK] Include suggest info into package metadata

Enhance the Package metadata with information about suggested packages.
This information may be loaded from composer.json or ext_emconf.php.

Resolves: #58701
Releases: 6.2
Change-Id: Ie7415ebe60d2c6164ccc52976a666fe07fd4afe0
Reviewed-on: https://review.typo3.org/30015
Reviewed-by: Thomas Maroschik
Tested-by: Fabien Udriot
Reviewed-by: Fabien Udriot
Reviewed-by: Stefan Neufeind
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
5 years agoRevert "[TASK] Downgrade to PHPUnit 3.7.*" 23/30623/3
Helmut Hummel [Sat, 7 Jun 2014 15:45:54 +0000 (17:45 +0200)]
Revert "[TASK] Downgrade to PHPUnit 3.7.*"

We can revert this again as the issue has been resolved
upstream:
https://github.com/sebastianbergmann/phpunit-mock-objects/issues/172

We can now switch back to phpunit 4.1.* again.

This reverts commit 7a876ddcfc3d41521b39c073519bad286143508d

Change-Id: If08d3e7200103e5cab77fdc1e098efd2048bde4c
Reviewed-on: https://review.typo3.org/30623
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Use delayedImportElement after uploading files 09/30609/4
Frans Saris [Fri, 6 Jun 2014 14:10:42 +0000 (16:10 +0200)]
[BUGFIX] Use delayedImportElement after uploading files

When uploading multiple files in TCEForm the DrapUploader
adds all uploaded files directly to the inline element of the
form. But when a previous request isn't finished yet, it
breaks the processing of last request.

This patch changes the use of importElement to
delayedImportElement so the next element is only added
when the previous is processed.

Resolves: #58956
Resolves: #57472
Resolves: #57190
Releases: 6.2
Change-Id: Iccad2ee19a5462cb63ed749ad60cb685460eb66d
Reviewed-on: https://review.typo3.org/30609
Reviewed-by: Helmut Hummel
Tested-by: Marc Fell
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Downgrade to PHPUnit 3.7.* 16/30616/2
Helmut Hummel [Fri, 6 Jun 2014 19:00:08 +0000 (21:00 +0200)]
[TASK] Downgrade to PHPUnit 3.7.*

Suddenly build failures occurred on travis which seem
to be related to ReflectionClass::newInstanceWithoutConstructor
which is used by PHPUnit 4.1.* when available.

Downgrade to PHPUnit 3.7.* to have a green build again
as the failures are totally unrelated to our code.

Change-Id: I6c3c200d5eda372e92ee0fd4c39e7fe79183ecab
Reviewed-on: https://review.typo3.org/30616
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Fix command description 12/30612/2
Mathias Brodala [Fri, 6 Jun 2014 17:49:14 +0000 (19:49 +0200)]
[BUGFIX] Fix command description

Due to using array_pop instead of array_shift the last line
of the command description is dropped instead of the first.

Use array_shift instead to get the full description
annotated for the command method.

Resolves: #59324
Releases: 6.2, 6.1, 4.7
Change-Id: I4d7c320b0ef334adbd15997d15d8e7a56d5739c1
Reviewed-on: https://review.typo3.org/30612
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
5 years ago[BUGFIX] getIndpEnv('TYPO3_SSL') fails to detect reverseProxyIp 81/30581/4
Jan-Erik Revsbech [Thu, 5 Jun 2014 09:33:54 +0000 (11:33 +0200)]
[BUGFIX] getIndpEnv('TYPO3_SSL') fails to detect reverseProxyIp

When running TYPO3 behind a reverse proxy, which also handles SSL,
the setting reverseProxySSL should check if the site is requested
from one of the reverse proxies in order to determine whether
the site is using SSL.

It incorrectly does this check via getIndpEnv('REMOTE_ADDR') which has
already translated the proxy IP to the end-users IP, thus always
returning FALSE.

Resolves: #37467
Release: 6.2, 6.1
Change-Id: I95615b0fea94e0ef0222e958e4e0bba5e6e9f60a
Reviewed-on: https://review.typo3.org/30581
Reviewed-by: Wouter Wolters
Reviewed-by: Mattias Nilsson
Tested-by: Mattias Nilsson
Reviewed-by: Jan-Erik Revsbech
Tested-by: Jan-Erik Revsbech
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[TASK] Enhance resource storage hooks 25/30525/2
Alexander Stehlik [Mon, 2 Jun 2014 17:52:48 +0000 (19:52 +0200)]
[TASK] Enhance resource storage hooks

Emit postFileCreate and postFileSetContents signals and add
provide the original folder in the postFileMove and the
postFolderMove signals.

Resolves: #59294
Releases: 6.2
Change-Id: Ia4096b38671f3312a1488587972d4883368de05c
Reviewed-on: https://review.typo3.org/30525
Reviewed-by: Frans Saris
Tested-by: Frans Saris
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Unified maxitems default value for group fields 78/27378/4
Alexander Stehlik [Tue, 25 Mar 2014 16:18:22 +0000 (17:18 +0100)]
[BUGFIX] Unified maxitems default value for group fields

The maxitems value for a group field defaults to 1 instead of 100000 so
that it is consistent with the TCA reference and the validation in the
DataHandler.

Resolves: #55731
Releases: 6.2
Change-Id: I517e45a9227ab9d971a9e7bc4410498319192517
Reviewed-on: https://review.typo3.org/27378
Reviewed-by: Xavier Perseguers
Tested-by: Xavier Perseguers
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Admin panel extGetFeAdminValue() overrides are wrong 30/29730/2
Markus Klein [Tue, 29 Apr 2014 16:58:25 +0000 (18:58 +0200)]
[BUGFIX] Admin panel extGetFeAdminValue() overrides are wrong

The current check does not properly consider the override values.
If a override is set, then its value has to be taken.
The current check only considered overrides which had
boolean value TRUE.

Resolves: #58339
Releases: 6.2, 6.1
Change-Id: Ib714432044c6a88fc92dcb8f36a4e37eb3412378
Reviewed-on: https://review.typo3.org/29730
Reviewed-by: Gerrit Mohrmann
Tested-by: Gerrit Mohrmann
Reviewed-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Disabled backend users shown for workspace stage change 73/26773/3
Stefan Rotsch [Mon, 24 Mar 2014 14:14:40 +0000 (15:14 +0100)]
[BUGFIX] Disabled backend users shown for workspace stage change

On changing the stage of a workspace version, an accordant
dialog is shown with recipients to be informed about this
action. However, disabled backend users are shown in this
dialog as well.

Resolves: #54925
Releases: 6.2
Change-Id: Iefae9e35e9c680783769260e8c3e38180bde5703
Reviewed-on: https://review.typo3.org/26773
Reviewed-by: Oliver Hader
Tested-by: Oliver Hader
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Show images in preview of page module 98/30598/2
Frans Saris [Thu, 5 Jun 2014 19:32:38 +0000 (21:32 +0200)]
[BUGFIX] Show images in preview of page module

For custom content elements with image these are shown
as thumbs in the list module but not in the page module.

This patch also renders the images when present just
like the bodytext.

Resolves: #59375
Releases: 6.2
Change-Id: If39e8b22af6144e5d6990a741559bd7574ee5e09
Reviewed-on: https://review.typo3.org/30598
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[CLEANUP] Add missing PHP comments in class LogoView 96/30596/2
Fabien Udriot [Thu, 5 Jun 2014 18:30:47 +0000 (20:30 +0200)]
[CLEANUP] Add missing PHP comments in class LogoView

Change-Id: I13d428c7b8a3964e8c376ad2c8d2a4af8c0059f1
Releases: 6.2
Resolves: #59374
Reviewed-on: https://review.typo3.org/30596
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Improve the formatting of help of the CommandController 94/30594/3
Stefano Kowalke [Thu, 5 Jun 2014 17:21:30 +0000 (19:21 +0200)]
[BUGFIX] Improve the formatting of help of the CommandController

This aligns the description of the command line options.

Resolves: #59372
Releases: 6.2
Change-Id: I474f8415d3ed62d583553f915edc3caa8189a803
Reviewed-on: https://review.typo3.org/30594
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Illegal string offset 'uid' in TypoScriptFrontendController 88/30588/2
Robert Vock [Thu, 5 Jun 2014 11:54:58 +0000 (13:54 +0200)]
[BUGFIX] Illegal string offset 'uid' in TypoScriptFrontendController

Logoff sets user property to an empty string instead of NULL. This
leads to a PHP Warning in PHP 5.4

Change-Id: Ib0e1a31dbf2fd3fcbcf1e7afd972b53d60c3ab5d
Resolves: #59364
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/30588
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Warning in SearchController 12/30512/5
Christian Zenker [Mon, 2 Jun 2014 11:49:00 +0000 (13:49 +0200)]
[BUGFIX] Warning in SearchController

$this->sWArr is not defined SearchController.
Fix this to use the correct $this->searchWords variable.

Change-Id: Iba888f1a47dcc0952ffbbb1e3bb4413435c2a95e
Resolves: #59277
Releases: 6.2, 6.1
Reviewed-on: https://review.typo3.org/30512
Reviewed-by: Alexander Opitz
Reviewed-by: Christian Zenker
Tested-by: Christian Zenker
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Show content elements from hidden pages in preview 12/30212/3
Markus Klein [Wed, 21 May 2014 11:45:23 +0000 (13:45 +0200)]
[BUGFIX] Show content elements from hidden pages in preview

Content elements from hidden pages are no longer shown in previews.

Fix this by checking with a strong comparison in enableFields() whether
the $show_hidden parameter is set to the default value.

Fixes: #58148
Related: #57814
Releases: 6.2
Change-Id: I2e20db88a513adb1a4d7599591fd3affdb60f209
Reviewed-on: https://review.typo3.org/30212
Tested-by: Dirk Klimpel
Reviewed-by: Mario Rimann
Reviewed-by: David Hoeckele
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
5 years ago[BUGFIX] Fix frontend unit tests if executed standalone 60/30560/2
Helmut Hummel [Wed, 4 Jun 2014 14:23:07 +0000 (16:23 +0200)]
[BUGFIX] Fix frontend unit tests if executed standalone

* Allow HTTP_HOST access for all unit tests
* Remove allow all in data provider

The latter implicitly caused a global allow, as PHPUint parses
all data providers before any test is run, thus setting globals there
will cause them to be preserved (and restored when backup globals is true).

Releases: 6.2, 6.1, 6.0
Resolves: #59343
Change-Id: I646294bb472027e22d6edc0622068698fe9a88fc
Reviewed-on: https://review.typo3.org/30560
Reviewed-by: Marc Bastian Heinrichs
Tested-by: Marc Bastian Heinrichs
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Show storage and folder of file/folder 58/30558/4
Frans Saris [Wed, 4 Jun 2014 14:45:26 +0000 (16:45 +0200)]
[BUGFIX] Show storage and folder of file/folder

To make it possible for an editor to find the real
location of a used file, the storage and folder are
added to the ElementInformation view of a file and folder.

Resolves: #57798
Releases: 6.2
Change-Id: I7c8104809bad49a6df1ec625cf3463a96526ede2
Reviewed-on: https://review.typo3.org/30558
Reviewed-by: Einar Gislason
Tested-by: Einar Gislason
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Show file instead of file_reference info 51/29651/3
Frans Saris [Fri, 25 Apr 2014 06:53:56 +0000 (08:53 +0200)]
[BUGFIX] Show file instead of file_reference info

The irre elements of FAL items have an info icon which shows
some details info about the file_reference. But this is not
the info an editor is looking for he wants the file info.

This patch changes the link behind the info icon for FAL items
so it shows the file info.

Resolves: #57302
Resolves: #57832
Releases: 6.2
Change-Id: I3c4b867ceb5bc05e1cb62525450102784793fadc
Reviewed-on: https://review.typo3.org/29651
Reviewed-by: Stefan Froemken
Tested-by: Stefan Froemken
Reviewed-by: Sebastian Fischer
Tested-by: Nico de Haen
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] List module pagination broken 49/29949/3
Markus Klein [Thu, 8 May 2014 18:07:13 +0000 (20:07 +0200)]
[BUGFIX] List module pagination broken

A wrong formula is used to calculate the pointer
for the pages.
This patch also introduces a central function for
calculating the pointer to a page.

Resolves: #55320
Releases: 6.2
Change-Id: Ia4eec61f4f87b52d0d5e940e542998f9f82aa140
Reviewed-on: https://review.typo3.org/29949
Reviewed-by: Marcin Sągol
Tested-by: Marcin Sągol
Tested-by: Tymoteusz Motylewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Old TYPO3 logo still in use in ext:workspaces 48/30548/2
Wouter Wolters [Tue, 3 Jun 2014 21:38:05 +0000 (23:38 +0200)]
[BUGFIX] Old TYPO3 logo still in use in ext:workspaces

Replace old logo with the new logo.

Resolves: #59321
Releases: 6.2
Change-Id: I1b4386e0ee614096b4033f00d9fe9136d11a63c7
Reviewed-on: https://review.typo3.org/30548
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] DataHandler::log() must not return NULL 79/30479/3
Markus Klein [Wed, 28 May 2014 17:38:29 +0000 (19:38 +0200)]
[BUGFIX] DataHandler::log() must not return NULL

Ensure the DataHandler::log() function does return integers
in all cases as denoted in the doc header.

Resolves: #59185
Releases: 6.2, 6.1, 6.0
Change-Id: I2a6aa0415b7cc19f10b4a290e43bd20065e6c9e1
Reviewed-on: https://review.typo3.org/30479
Reviewed-by: Stefan Neufeind
Tested-by: Stefan Neufeind
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[TASK] Check and use current file hash and size on export 61/30061/3
Marc Bastian Heinrichs [Tue, 13 May 2014 14:26:11 +0000 (16:26 +0200)]
[TASK] Check and use current file hash and size on export

On creating exports the file hash and size is used from the
sys_file table. Since this could be not up-to-date in real live
projects, those files fail to be imported.

To prevent this, use the correct data for the export and show
an error to the user.

Resolves: #58761
Releases: 6.2
Change-Id: I7aacc6f00c52bc01c753af4ee32202a9219c02a1
Reviewed-on: https://review.typo3.org/30061
Reviewed-by: Bernd Niehues
Tested-by: Bernd Niehues
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Use created folder object for adding images in impexp 84/29984/2
Marc Bastian Heinrichs [Fri, 9 May 2014 16:04:34 +0000 (18:04 +0200)]
[BUGFIX] Use created folder object for adding images in impexp

A folder to be created could change the name by sanitizing. So
the name of the created folder could differ from the requested
name. For adding the image the returned folder object should be
used.

To avoid that sanitized ones should be created over and over again
a mapping is buffered.

Resolves: #58682
Releases: 6.2
Change-Id: Ia3443c36c6dda8531c8791c221d2a835b25b10b2
Reviewed-on: https://review.typo3.org/29984
Reviewed-by: Bernd Niehues
Tested-by: Bernd Niehues
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] ElementBrowser: correct link attributes 83/30483/3
Markus Klein [Thu, 29 May 2014 10:40:58 +0000 (12:40 +0200)]
[BUGFIX] ElementBrowser: correct link attributes

This is a regression fix for #55983, which introduced
additional urlencoding for title, class, ...

Remove the encoding again.

Resolves: #59199
Releases: 6.2
Change-Id: I28650676f4ae0b74256a770af12054750027cbfa
Reviewed-on: https://review.typo3.org/30483
Reviewed-by: Markus Bucher
Tested-by: Markus Bucher
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Fix wrong JS function name in RTE 31/30531/2
Markus Klein [Tue, 3 Jun 2014 10:02:04 +0000 (12:02 +0200)]
[BUGFIX] Fix wrong JS function name in RTE

RTE feature "userlinks" generates a wrong JS function
name due to the automatic replacement during the
namespace conversion.

Revert this line to use the correct JS function name.

Resolves: #59302
Releases: 6.2, 6.1, 6.0
Change-Id: Ia6b51e7e1b1dfa0e618106f4f039bd0774464a97
Reviewed-on: https://review.typo3.org/30531
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Canonicalize path before checking existence 32/30532/3
Nils Blattner [Tue, 3 Jun 2014 11:14:57 +0000 (13:14 +0200)]
[BUGFIX] Canonicalize path before checking existence

ResourceFactory fails to detect files in symlinked
scenarios, because the path is not canonicalized before
file existence is checked.

Solution is to canonicalize it and check then.

Resolves: #59303
Releases: 6.2
Change-Id: I4fd763f7076e909f2163af79ed2b7f8642da8ed7
Reviewed-on: https://review.typo3.org/30532
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Request update broken for select fields 44/30044/2
Francois Suter [Tue, 13 May 2014 11:09:32 +0000 (13:09 +0200)]
[BUGFIX] Request update broken for select fields

For select-type fields displayed as two side-by-side selectors
which are registered as "requestUpdate" fields, the form submission
happens before the value is copied to the left-hand selector.
The form is thus saved without value.

Full description in the bug report, which also contains a
test extension and steps to reproduce.

Resolves: #58755
Releases: 6.2
Change-Id: Ie94def723537202287655c650cee7dfa09815f4f
Reviewed-on: https://review.typo3.org/30044
Reviewed-by: Peter Foerger
Reviewed-by: Fabien Udriot
Tested-by: Fabien Udriot
Reviewed-by: Tomas Norre Mikkelsen
Reviewed-by: Lorenz Ulrich
Tested-by: Lorenz Ulrich
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] TCA maxitems for FAL permissions wrong 18/30518/2
Markus Klein [Mon, 2 Jun 2014 13:49:03 +0000 (15:49 +0200)]
[BUGFIX] TCA maxitems for FAL permissions wrong

The setting for maxitems in the TCA of be_users and be_groups for
FAL permissions are wrong.
Fix the value to match the number of available options.

Resolves: #59263
Releases: 6.2
Change-Id: Ib38aab8bbd1f5fe9287ff0523139f88520f27e37
Reviewed-on: https://review.typo3.org/30518
Reviewed-by: Frans Saris
Reviewed-by: Alexander Opitz
Tested-by: Alexander Opitz
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
5 years ago[BUGFIX] Make object access work with ObjectStorage 23/29923/6
Helmut Hummel [Wed, 7 May 2014 17:30:57 +0000 (19:30 +0200)]
[BUGFIX] Make object access work with ObjectStorage

ObjectAccess->getPropertyPath() does not work with
ObjectStorage and numerical indexes, but it should be
because without it form fluid fields cannot be
properly handled as the value is always null.

Fixing fetching objects from ObjectStorage by index
will also enable shorter access of single objects in Fluid.

Imagine you want to render the first image in your
template. Previously you had to write this:

<f:for each="{object.images}" as="image" iteration="iterator">
<f:if condition="{iterator.isFirst}">
<f:image image="{image}" alt="" width="50"/>
</f:if>
</f:for>

Now you can just write:

<f:image image="{object.images.0}" alt="" width="50"/>

Resolves: #37126
Related: #37000
Releases: 6.2
Change-Id: I45122bd145b5a179ad3e9e3894520f9a614906c8
Reviewed-on: https://review.typo3.org/29923
Reviewed-by: Markus Klein
Reviewed-by: Anja Leichsenring
Tested-by: Anja Leichsenring
Reviewed-by: Fabien Udriot
Reviewed-by: Tymoteusz Motylewski
Tested-by: Tymoteusz Motylewski
Reviewed-by: Georg Ringer
Tested-by: Georg Ringer
5 years ago[BUGFIX] Keep session cookie if session data is present 85/30485/5
Helmut Hummel [Sun, 1 Jun 2014 12:20:17 +0000 (14:20 +0200)]
[BUGFIX] Keep session cookie if session data is present

The AbstractUserAuthentication::checkAuthentication() method calls
the logoff() method on every failed login attempt.

Since a logoff also causes a removal of the cookie,
any (anonymous) session data will be left unaccessible.

Keep the cookie when session data is present.

Releases: 6.2
Resolves: #58713
Change-Id: I744456f62197a7278635d8564d4883564d954dd2
Reviewed-on: https://review.typo3.org/30485
Reviewed-by: Helmut Hummel
Tested-by: Helmut Hummel
Reviewed-by: Wouter Wolters
Reviewed-by: Stefan Neufeind
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Always add wrapping div if dividers2tabs is disabled 61/30461/3
Frans Saris [Wed, 28 May 2014 08:04:09 +0000 (10:04 +0200)]
[BUGFIX] Always add wrapping div if dividers2tabs is disabled

TCEforms is not wrapped in a div when dividers2tabs is disabled
and a inline-element form element is present. As a result there
is no background image/color shown.

This changes removes the check as the wrap is also needed when
inline-elements are present.

Resolves: #59163
Releases: 6.2
Change-Id: I8772fce0d99bacdf18692308c700c02c0a0defcf
Reviewed-on: https://review.typo3.org/30461
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
Reviewed-by: Kay Strobach
Tested-by: Kay Strobach
Reviewed-by: Frans Saris
Tested-by: Frans Saris
5 years ago[BUGFIX] Do not use self:: within closures 89/30489/2
Markus Klein [Thu, 29 May 2014 14:39:20 +0000 (16:39 +0200)]
[BUGFIX] Do not use self:: within closures

This is not possible in PHP 5.3.

Resolves: #59203
Releases: 6.2
Change-Id: I108578f7635c50493a3b5d7a7fc81c021805abf8
Reviewed-on: https://review.typo3.org/30489
Reviewed-by: Markus Klein
Tested-by: Markus Klein
5 years ago[BUGFIX] Flexform element title is cropped to hardcoded length 42/30242/3
Sebastian Michaelsen [Wed, 21 May 2014 07:53:52 +0000 (09:53 +0200)]
[BUGFIX] Flexform element title is cropped to hardcoded length

The title of a flexform element is cropped to maximum length of 30
characters. Instead it should obey the maximum title length in the user
settings.

Resolves: #58910
Releases: 6.2, 6.1
Change-Id: I28c6fc94b2d492217479bf014ff8f67463b4e98f
Reviewed-on: https://review.typo3.org/30242
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters
5 years ago[BUGFIX] Admin panel text selection 18/30118/5
Goran Medakovic [Wed, 14 May 2014 16:26:35 +0000 (18:26 +0200)]
[BUGFIX] Admin panel text selection

Fixes: #58485
Releases: 6.2
Change-Id: I9c3243b2cca9edb89d262a4d3f9cde17b906d440
Reviewed-on: https://review.typo3.org/30118
Reviewed-by: Markus Klein
Tested-by: Markus Klein
Reviewed-by: Tymoteusz Motylewski
Reviewed-by: Wouter Wolters
Tested-by: Wouter Wolters