Packages/TYPO3.CMS.git
6 months ago[!!!][TASK] Drop deprecated code from ScalableVectorGraphicsContentObject 77/59477/3
Christian Kuhn [Fri, 18 Jan 2019 11:40:11 +0000 (12:40 +0100)]
[!!!][TASK] Drop deprecated code from ScalableVectorGraphicsContentObject

Resolves: #87479
Releases: master
Change-Id: Icd23eb06690ff775ba0aff516e01553fd2f6271e
Reviewed-on: https://review.typo3.org/59477
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Remove deprecated code from Core/Cache 81/59481/2
Christian Kuhn [Fri, 18 Jan 2019 12:24:14 +0000 (13:24 +0100)]
[!!!][TASK] Remove deprecated code from Core/Cache

Resolves: #87481
Releases: master
Change-Id: I9d1fa4db56c2a7fe93a1d5e6a68fb7d42f623d63
Reviewed-on: https://review.typo3.org/59481
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Drop a "probably not required" method from routing 86/59486/2
Christian Kuhn [Fri, 18 Jan 2019 13:32:18 +0000 (14:32 +0100)]
[TASK] Drop a "probably not required" method from routing

Method addArguments() of Route class is marked as
'@deprecated Probably not required'. It looks like
a left over from the routing development. The method is
indeed unused and can be dropped without further
notice from this @internal marked class.

Change-Id: Iefaec031003b55571c5d2f0f658fed9b25132cbb
Resolves: #87488
Releases: master.
Reviewed-on: https://review.typo3.org/59486
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Drop some wrong deprecation annotations in extbase 83/59483/2
Christian Kuhn [Fri, 18 Jan 2019 13:11:30 +0000 (14:11 +0100)]
[TASK] Drop some wrong deprecation annotations in extbase

There are four @deprecated annotations in extbase query / persistence
area that have been marked as such in v6 and never removed. Those
methods are still used in extbase and needed. Remove the
deprecation notes for these methods.

Resolves: #87485
Releases: master
Change-Id: If47487792124909e736583819640133a135e090e
Reviewed-on: https://review.typo3.org/59483
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Drop invalid deprecation annotation in TSFE 84/59484/2
Christian Kuhn [Fri, 18 Jan 2019 13:21:02 +0000 (14:21 +0100)]
[TASK] Drop invalid deprecation annotation in TSFE

There is an "Deprecated stuff" comment in
TypoScriptFrontendController that is there since before 4.5
times. The code below is clearly needed. Drop that comment.

Resolves: #87486
Releases: master
Change-Id: Ie0362742c4e1eac2ba3160dece9ee128347106d7
Reviewed-on: https://review.typo3.org/59484
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Mark some places internal instead of deprecated 85/59485/2
Christian Kuhn [Fri, 18 Jan 2019 13:27:28 +0000 (14:27 +0100)]
[TASK] Mark some places internal instead of deprecated

Some methods in BasicFileUtility have been marked as
deprecated for various versions already but never removed
since they are still used within core.
Switch these to @internal to give core freedom to remove
these at will.

Resolves: #87487
Releases: master
Change-Id: I837dfbbfdc7069dd89f86133c75ad9b0fd45e046
Reviewed-on: https://review.typo3.org/59485
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Do not rely on global variables for ext_*.php files 00/59300/7
Benni Mack [Thu, 27 Dec 2018 19:13:50 +0000 (20:13 +0100)]
[!!!][TASK] Do not rely on global variables for ext_*.php files

ext_tables.php, ext_localconf.php and all Configuration/TCA/*.php
do not have global scope anymore.

Thus, it is necessary to use
$GLOBALS['TYPO3_CONF_VARS'] instead of $TYPO3_CONF_VARS

Also, $_EXTKEY and $_EXTCONF are gone in these files.

Resolves: #87483
Releases: master
Change-Id: I2c33c696151ace8596cbc9a59a43ef188de26b9c
Reviewed-on: https://review.typo3.org/59300
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Drop FILE content object 76/59476/2
Christian Kuhn [Fri, 18 Jan 2019 11:15:30 +0000 (12:15 +0100)]
[!!!][TASK] Drop FILE content object

Resolves: #87477
Releases: master
Change-Id: I0bffc072667c736195e002e4b3811055334cb633
Reviewed-on: https://review.typo3.org/59476
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Add `.nvmrc` file 66/59466/3
Andreas Fernandez [Wed, 16 Jan 2019 21:37:15 +0000 (22:37 +0100)]
[TASK] Add `.nvmrc` file

nvm (node version manager) is a tool to have multiple node versions
installed. Since TYPO3 relies on an older node version right now, we can
provide support for nvm by adding a .nvmrc file.

This still requires to have nvm installed and configured on the client.

Resolves: #87468
Releases: master, 9.5, 8.7
Change-Id: Ie16827594fbdebeff1004cd178c28c67a61d60d7
Reviewed-on: https://review.typo3.org/59466
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[BUGFIX] Harden CommandUtility invocations 48/59448/2
Oliver Hader [Mon, 10 Dec 2018 07:51:21 +0000 (08:51 +0100)]
[BUGFIX] Harden CommandUtility invocations

In order to harden CommandUtility API arguments used for invoking
system commands are escaped in addition. Since no insecure usages
have been identified in the TYPO3 core nor in public third party
extensions, this change is handled using a public workflow.

| In order to evaluate whether third party extensions open a
| potential attack vector, usages of CommandUtility::checkCommand(),
| CommandUtility::getCommand() and the registration of custom services
| ($GLOBALS[‘T3_SERVICES’]) concerning their ‘exec’ argument have to
| be checked.

Resolves: #87450
Releases: master, 9.5, 8.7
Security-Advisory: TYPO3-PSA-2019-001
Change-Id: If4f2a63045ac7b2473881992f9731a635a768d37
Reviewed-on: https://review.typo3.org/59448
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
6 months ago[!!!][TASK] Remove deprecated code from AbstractTreeView 62/59462/3
Christian Kuhn [Wed, 16 Jan 2019 19:40:59 +0000 (20:40 +0100)]
[!!!][TASK] Remove deprecated code from AbstractTreeView

Resolves: #87466
Releases: master
Change-Id: Ia6e4dc9441b559c2e6dbeaa6276cd03bee12d13a
Reviewed-on: https://review.typo3.org/59462
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[BUGFIX] Fix duplicate rendering of 'pages' id-attribute 65/59465/3
theline [Wed, 16 Jan 2019 20:06:25 +0000 (21:06 +0100)]
[BUGFIX] Fix duplicate rendering of 'pages' id-attribute

When translations and (sub-)pages are present at the same time the
'page' id-attribute will be rendered twice.
This ensures that translations and (sub-)pages are independently
collapsible.

Resolves: #87465
Releases: master, 9.5
Change-Id: I0fd6a8323d89b34ecda0be7fb005fe64adb05928
Reviewed-on: https://review.typo3.org/59465
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Remove deprecated code from PagePositionMap 57/59457/4
Christian Kuhn [Wed, 16 Jan 2019 18:52:12 +0000 (19:52 +0100)]
[!!!][TASK] Remove deprecated code from PagePositionMap

Resolves: #87460
Releases: master
Change-Id: Ib4df7ffc1e1b67ae1fcb7e5f68ccc4b89ac2baeb
Reviewed-on: https://review.typo3.org/59457
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Remove deprecated code from ModuleTemplate 63/59463/3
Christian Kuhn [Wed, 16 Jan 2019 19:52:15 +0000 (20:52 +0100)]
[!!!][TASK] Remove deprecated code from ModuleTemplate

Resolves: #87467
Releases: master
Change-Id: I51e3b25545ffe6e3789524980f06920b11f80437
Reviewed-on: https://review.typo3.org/59463
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Update Feature-84729-NewTCATypeSlug.rst 55/59455/4
Dmytro Nozdrin [Wed, 16 Jan 2019 14:42:55 +0000 (15:42 +0100)]
[TASK] Update Feature-84729-NewTCATypeSlug.rst

Fix code example for 'slug' TCA type according to this
https://docs.typo3.org/typo3cms/TCAReference/ColumnsConfig/Type/Slug.html

Releases: master, 9.5
Resolves: #87456
Change-Id: Ica3ebe037623ddc1fb679e362e041eca6e662b49
Reviewed-on: https://review.typo3.org/59455
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Remove deprecated code from TypoScriptParser 56/59456/3
Christian Kuhn [Wed, 16 Jan 2019 18:44:18 +0000 (19:44 +0100)]
[!!!][TASK] Remove deprecated code from TypoScriptParser

Resolves: #87459
Releases: master
Change-Id: Iae4bd1efc937b225437d49857674276e18d5422c
Reviewed-on: https://review.typo3.org/59456
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Remove deprecated code from DatabaseRowInitializeNew 60/59460/3
Christian Kuhn [Wed, 16 Jan 2019 19:22:28 +0000 (20:22 +0100)]
[!!!][TASK] Remove deprecated code from DatabaseRowInitializeNew

Resolves: #87463
Releases: master
Change-Id: I48cce7cea659036e58c1119fee4b4737df67ffbe
Reviewed-on: https://review.typo3.org/59460
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Drop entry point typo3/install/index.php 58/59458/3
Christian Kuhn [Wed, 16 Jan 2019 19:00:44 +0000 (20:00 +0100)]
[!!!][TASK] Drop entry point typo3/install/index.php

The old install tool entry point "typo3/install/index.php" which was
deprecated is removed now.

The entry point "typo3/install.php" is still available to access the
install tool in its standalone version.

Resolves: #87461
Releases: master
Change-Id: I545bfe7f02449c94464cf024f951ea36a584fcf7
Reviewed-on: https://review.typo3.org/59458
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Remove deprecated code from UserElement 61/59461/2
Christian Kuhn [Wed, 16 Jan 2019 19:26:40 +0000 (20:26 +0100)]
[!!!][TASK] Remove deprecated code from UserElement

Resolves: #87464
Releases: master
Change-Id: I20fac10c82f22c3e2dec0ed02e5f2a769866c966
Reviewed-on: https://review.typo3.org/59461
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[!!!][TASK] Remove deprecated code from ElementBrowserFolderTreeView 59/59459/2
Christian Kuhn [Wed, 16 Jan 2019 19:10:47 +0000 (20:10 +0100)]
[!!!][TASK] Remove deprecated code from ElementBrowserFolderTreeView

Resolves: #87462
Releases: master
Change-Id: Ia88bd74ce8710d93a8041242397901325094fd61
Reviewed-on: https://review.typo3.org/59459
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Drop core 7->8 auto TCA migrations 45/59445/4
Christian Kuhn [Tue, 15 Jan 2019 14:09:46 +0000 (15:09 +0100)]
[!!!][TASK] Drop core 7->8 auto TCA migrations

Auto TCA migrations are now handled identical to
core upgrade wizards: They are kept for two versions.
The patch thus removes all TCA auto migrations
that applied if upgrading from v7 to v8 in current
v10 master. Along other stuff, especially the old
TCA 'wizard' stuff is no longer migrated to the
new syntax.

Resolves: #87447
Related: #87335
Releases: master
Change-Id: I05d795ef5c2c36bae3654d81eab5b82b4d3a2fa0
Reviewed-on: https://review.typo3.org/59445
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[BUGFIX] Fix various "No pseudo-site found in root line of page" errors 29/59229/6
Benni Mack [Wed, 19 Dec 2018 20:52:14 +0000 (21:52 +0100)]
[BUGFIX] Fix various "No pseudo-site found in root line of page" errors

Fixes workspace resolving etc.

The !empty statement is wrong as a string value "0" would not expect the
right return. This fixes the detection of l10n_parent.
Also check for sys_language_uid, too, to get the pid of the record
instead of its parent.

This also fixes opening categories (sys_category) when using EXT:news,
which calls this condition in TCA:
'displayCond' => 'USER:' . \TYPO3\CMS\Core\Compatibility\
PseudoSiteTcaDisplayCondition::class . '->isInPseudoSite:pages:false',

Check array index exists in SiteResolving.

Resolves: #79606
Resolves: #86186
Resolves: #86622
Resolves: #86678
Resolves: #86684
Releases: master, 9.5
Change-Id: If3ddf5eead2dddd51db3bcf751d71d3bc362ef35
Reviewed-on: https://review.typo3.org/59229
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Do not handle 'uploadsfolder' in ext_emconf anymore 43/59443/6
Christian Kuhn [Tue, 15 Jan 2019 12:44:23 +0000 (13:44 +0100)]
[!!!][TASK] Do not handle 'uploadsfolder' in ext_emconf anymore

With TCA type=group with internal_type=file and
file_reference being dropped, the uploads/ folder
is unused and obsolete.
The patch drops further related code in this area,
especially the ext_emconf.php property uploadsfolder
is obsolete. It is dropped from all ext_emconf.php
files together with its handling in extensionmanager.

Change-Id: I93abc7d614b17adf4d0f2f896e346d3147c49472
Resolves: #87445
Releases: master
Reviewed-on: https://review.typo3.org/59443
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[!!!][TASK] Remove v7->v8 upgrade wizards 40/59440/3
Christian Kuhn [Tue, 15 Jan 2019 11:34:04 +0000 (12:34 +0100)]
[!!!][TASK] Remove v7->v8 upgrade wizards

Upgrade wizards created to upgrade from v7 to v8
are removed now. Note the DatabaseRowUpdater
mini-framework wizard does not register single
row updaters at the moment, is disabled but the
class is kept.

Resolves: #87440
Releases: master
Change-Id: If84dd1f0ce710f535e39516b984b94a9df2bccb2
Reviewed-on: https://review.typo3.org/59440
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Remove deprecated code from backend controllers 38/59438/4
Christian Kuhn [Tue, 15 Jan 2019 10:33:08 +0000 (11:33 +0100)]
[!!!][TASK] Remove deprecated code from backend controllers

Last set of deprecation trait removals from controllers
of the backend extension. This one comes with minor and
straight changes to improve code structure of some of the
simple controllers along the way.

Resolves: #87437
Releases: master
Change-Id: I4c6b453a3341ced072337896002fba250dd230a9
Reviewed-on: https://review.typo3.org/59438
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <noreply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Drop a unit test that relies on uploads folder 42/59442/4
Christian Kuhn [Tue, 15 Jan 2019 12:30:00 +0000 (13:30 +0100)]
[BUGFIX] Drop a unit test that relies on uploads folder

With the removal of type=group internal_type=file and
file_reference, the uploads folder is obsolete. The
patch drops a last unit test that relies on its
existance, so typo3/testing-framework no longer
needs to create that directory for tests.

Change-Id: I76984d4717112c63d0befa8faa708d4f5cf408eb
Resolves: #87441
Releases: master
Reviewed-on: https://review.typo3.org/59442
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[BUGFIX] Use correct variable to select a subfolder within folder selector 20/59420/3
Ioulia Kondratovitch [Fri, 11 Jan 2019 21:04:26 +0000 (22:04 +0100)]
[BUGFIX] Use correct variable to select a subfolder within folder selector

Use correct variable to select a subfolder within the folder selector
instead of using the variable for parent-folder identifier.

Resolves: #87415
Releases: master, 9.5
Change-Id: I8bb30f81aea2b17f0b3567b9272e239b2beaf772
Reviewed-on: https://review.typo3.org/59420
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Drop support for deprecated cache usage in ext_localconf 31/59231/10
Benjamin Franzke [Wed, 19 Dec 2018 09:44:58 +0000 (10:44 +0100)]
[!!!][TASK] Drop support for deprecated cache usage in ext_localconf

The initialization of the CacheManager has a design problem:

The *CacheManager* is used to create the core_cache. That core_cache
is used to read the (possibly) cached *CacheManager* configuration
(from ext_localconf.php), which is then used to (re)configure the
already-being-used *CacheManager* after ext_localconf.php has been
loaded. That means an extension can create a cache while it has
not been configured by a second extension. That behaviour was
deprecated in v9 and can therefore be dropped now.

We now create the core cache (and because of requirements
in core currently also the 'assets' cache) during early bootstrap
(independently from the CacheManager) and inject these early caches
into the CacheManager instance later on. The CacheManager instance is now
created during late bootstrap.
Looking forward to a Dependency Injection (DI) container, this change will
allow to move the CacheManager creation from bootstrap code into the DI
service providers (which will allow the CacheManager to be instantiated
on demand)

Releases: master
Resolves: #87245
Related: #86353
Change-Id: I984beabdbbd550c191de347fdc19166283452a88
Reviewed-on: https://review.typo3.org/59231
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASk] Remove deprecated code from controllers 39/59439/2
Christian Kuhn [Tue, 15 Jan 2019 11:19:28 +0000 (12:19 +0100)]
[!!!][TASk] Remove deprecated code from controllers

Last part of controller deprecation removals and
deprecation trait usages. Affects extensions
recordlist, reports and rte_ckeditor.

Change-Id: I88f7ea2e708629b889b09b279f09a7f82dcb8801
Resolves: #87439
Releases: master
Reviewed-on: https://review.typo3.org/59439
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated code from backend Controller/File 28/59428/3
Christian Kuhn [Mon, 14 Jan 2019 15:06:11 +0000 (16:06 +0100)]
[!!!][TASK] Remove deprecated code from backend Controller/File

Resolves: #87431
Releases: master
Change-Id: Idb7a87bce6d7edee409bc24348b185ea51c17de2
Reviewed-on: https://review.typo3.org/59428
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[!!!][TASK] Remove deprecated code from backend ContentElement 29/59429/2
Christian Kuhn [Mon, 14 Jan 2019 15:42:39 +0000 (16:42 +0100)]
[!!!][TASK] Remove deprecated code from backend ContentElement

Resolves: #87432
Releases: master
Change-Id: I9f27b0b59d34e7ae9ceb681db4f0225b55fcaec6
Reviewed-on: https://review.typo3.org/59429
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[BUGFIX] Use argument $tparams BackendUtility::thumbCode for FAL items 17/59417/2
Georg Ringer [Fri, 11 Jan 2019 19:59:20 +0000 (20:59 +0100)]
[BUGFIX] Use argument $tparams BackendUtility::thumbCode for FAL items

Add the argument $tparams to the image tag also for FAL items.

Resolves: #87410
Releases: master, 9.5
Change-Id: I4961a829e2497c747824a76ce5277a7dfe35c2d1
Reviewed-on: https://review.typo3.org/59417
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove internal_type=file/file_reference 61/59361/11
Benni Mack [Mon, 7 Jan 2019 18:40:30 +0000 (19:40 +0100)]
[!!!][TASK] Remove internal_type=file/file_reference

This drops TCA type=group with internal_type=file and
internal_type=file_reference handling.
This patch is rather huge since detail handling of this
stuff is spread throughout the core. Additionally, some
further methods become unused and oboselete along the way.
Most of them - except DataHandler->process_uploads() - have
been used internally only and can be safetly dropped,
while process_uploads() which has always been part of the
externally called API is substituted with a no-op method.

Resolves: #87428
Releases: master
Change-Id: Ia60b5d0e021b34adf4b4187a5f1fe4475b0070b4
Reviewed-on: https://review.typo3.org/59361
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[BUGFIX] Use proper typolink with clean TSFE for redirects 32/59032/6
Benni Mack [Tue, 4 Dec 2018 20:33:33 +0000 (21:33 +0100)]
[BUGFIX] Use proper typolink with clean TSFE for redirects

Instead of re-using $GLOBALS['TSFE'] with
an already set $id and $type query
params, a new instance is created depending
on the given site.

Resolves: #87070
Releases: master, 9.5
Change-Id: I65b0b5c7c89db69c99600232927a00575c15d231
Reviewed-on: https://review.typo3.org/59032
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated arguments from TranslateElementErrorViewHelper 77/59377/3
Georg Ringer [Tue, 8 Jan 2019 18:58:23 +0000 (19:58 +0100)]
[!!!][TASK] Remove deprecated arguments from TranslateElementErrorViewHelper

Resolves: #87371
Releases: master
Change-Id: Ie7df7b29f3a82a954856d1f7c922cd726f2a43b8
Reviewed-on: https://review.typo3.org/59377
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Check for unset font if text is set in GIFBUILDER 18/59418/3
Tom Novotny [Fri, 11 Jan 2019 20:44:49 +0000 (21:44 +0100)]
[BUGFIX] Check for unset font if text is set in GIFBUILDER

You can set a text without defining a font file to be used, explicitly.

Resolves: #87363
Releases: master, 9.5
Change-Id: I5cbb447da29cf49ad23f621261044edea12ccb7f
Reviewed-on: https://review.typo3.org/59418
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[FEATURE] Improve ClassSchema properties api 82/59382/9
Alexander Schnitzler [Wed, 9 Jan 2019 11:35:16 +0000 (12:35 +0100)]
[FEATURE] Improve ClassSchema properties api

This patch introduces a new Property class to have an
easier and more stable api to get information about class
properties from ClassSchema objects

The reflection data fetched and stored by/in the ClassSchema
objects is no longer publicly available as an array. Instead,
Property objects are returned for the following calls:

- getProperty
- getProperties

Releases: master
Resolves: #87377
Change-Id: Ica09e7f2df42638497cbde1aea35d62c42332d3f
Reviewed-on: https://review.typo3.org/59382
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Remove bottom margin of image content elements 13/59013/2
Jan Kiesewetter [Mon, 3 Dec 2018 08:45:05 +0000 (09:45 +0100)]
[BUGFIX] Remove bottom margin of image content elements

Resolves: #87059
Releases: master
Change-Id: I842fa15aa7bb8a01035299be1298f2a5d9480c98
Reviewed-on: https://review.typo3.org/59013
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Raphael Graf <r@undefined.ch>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Jonas Esser <info@jonas-esser.de>
Tested-by: Jonas Esser <info@jonas-esser.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Allow to access pages with "index.php?id=123" 14/59414/6
Michael Giek [Fri, 11 Jan 2019 15:22:24 +0000 (16:22 +0100)]
[BUGFIX] Allow to access pages with "index.php?id=123"

Currently, the SiteMatcher checks for "?id=123&L=123" for special
treatment when Site Handling is enabled.

However, it should be possible to only access
www.example.com/index.php?id=123, without the "L" parameter,
for pages with Site-handling.

Without the patch, the language is not resolved, and a redirect
to /fr/ (or whatever default language prefix is given) is made.

Tests are adapted so IDs with ?id=1000 are not redirected
anymore.

Resolves: #87412
Releases: master, 9.5
Change-Id: Ied3df51359346996c6a889576b95516c008b734f
Reviewed-on: https://review.typo3.org/59414
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Make nested slugs in rootpages possible 90/59390/4
Benni Mack [Wed, 9 Jan 2019 16:02:58 +0000 (17:02 +0100)]
[BUGFIX] Make nested slugs in rootpages possible

If there are nested sites, the rootpage of the
nested site cannot have the slug "/" as the uniqueInSite
evaluates against the parent page, and not the actual
page.

Instead of taking the PID of the parent page ID, the uid
of the localized record is used.

Resolves: #87404
Releases: master, 9.5
Change-Id: Idab821cae57fe72b01f5b4beef80341db4273fc8
Reviewed-on: https://review.typo3.org/59390
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Remove deprecated code from ext:info 13/59413/4
Christian Kuhn [Fri, 11 Jan 2019 15:07:25 +0000 (16:07 +0100)]
[!!!][TASK] Remove deprecated code from ext:info

Change-Id: I78d476d8cd6779882aca87ffff4bd9b8c8cdf431
Resolves: #87413
Releases: master
Reviewed-on: https://review.typo3.org/59413
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[FEATURE] Add properties default values in class schema 23/58923/7
Romain Canon [Wed, 21 Nov 2018 13:45:58 +0000 (14:45 +0100)]
[FEATURE] Add properties default values in class schema

Allows accessing the default values of a class property, without having
to use the reflection everytime it is needed.

The default value can be accessed with the key `defaultValue` in the
property schema.

Resolves: #86964
Releases: master
Change-Id: I17c1dfd3db9c26deaffd760270e480543521a9a4
Reviewed-on: https://review.typo3.org/58923
Reviewed-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <typo3@alexanderschnitzler.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Use constructor injection in DataMapFactory 05/59305/5
Alexander Schnitzler [Sun, 30 Dec 2018 13:20:03 +0000 (14:20 +0100)]
[TASK] Use constructor injection in DataMapFactory

Class DataMapFactory does no longer use setter injection but
constructor injection instead.

Releases: master
Resolves: #87306
Change-Id: Id6d2ff14862e96e39cf776fc6a9ed714ec6eb952
Reviewed-on: https://review.typo3.org/59305
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Use constructor injection in DataMapper 79/59279/6
Alexander Schnitzler [Sat, 22 Dec 2018 16:05:19 +0000 (17:05 +0100)]
[TASK] Use constructor injection in DataMapper

Class DataMapper does no longer use setter injection but
constructor injection instead.

Releases: master
Resolves: #87305
Change-Id: I88596a5e2e22deb8d11f6d83901c2c660b81bf0c
Reviewed-on: https://review.typo3.org/59279
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Remove check for posix_getegid returning -1 03/59403/3
Stefanos Karasavvidis [Fri, 11 Jan 2019 09:56:31 +0000 (11:56 +0200)]
[TASK] Remove check for posix_getegid returning -1

On MacOS posix_getegid does return a correct effective group id, so
the check can be removed. Windows systems are already excluded by
other checks.

Resolves: #87398
Releases: master, 9.5
Change-Id: Ic1bff8d11f9109806a61351d992bfd471ebd4a8d
Reviewed-on: https://review.typo3.org/59403
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Drop constant PATH_site 06/59406/4
Christian Kuhn [Fri, 11 Jan 2019 11:45:16 +0000 (12:45 +0100)]
[!!!][TASK] Drop constant PATH_site

Finally drops the last path related constant from
SystemEnvironmentBuilder. typo3/testing-framework
again needed some adaptions, so this is raised with
the patch as well.

composer require --dev typo3/testing-framework ~5.0.3

Change-Id: Ie8fc311ae8e5180885bc92e007a09f828f26b1e9
Resolves: #87405
Releases: master
Reviewed-on: https://review.typo3.org/59406
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Streamline creating text files in filelist module 03/59303/3
Oliver Hader [Fri, 28 Dec 2018 15:06:15 +0000 (16:06 +0100)]
[BUGFIX] Streamline creating text files in filelist module

The filelist module allows to create files and redirects to an
according editing view in case the file extension is configured
in $GLOBALS['TYPO3_CONF_VARS']['SYS']['textfile_ext']. However,
any file - except those in file-deny pattern - can be created,
but only text files can be edited directly.

Since this was kind of misleading, creating any file is still
possible, however there's no redirect anymore in case it's not
a text file. Wording in filelist module's view has been adjusted.

Resolves: #72404
Releases: master, 9.5, 8.7
Change-Id: Ibb48769aa571e880d0f5f58cfb650cade3cdb1e0
Reviewed-on: https://review.typo3.org/59303
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Tested-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Force log_data to be an array 51/59251/4
Ioulia Kondratovitch [Thu, 20 Dec 2018 21:42:19 +0000 (22:42 +0100)]
[BUGFIX] Force log_data to be an array

Ensure log_data is an array, in case it cannot be
unserialized or is not a serialized array when executing
SeparateSysHistoryFromSysLogUpdate upgrade wizard

Resolves: #87251
Releases: master, 9.5
Change-Id: I7ba7d1cb07052b236b3abb20f107c3f22210a7bf
Reviewed-on: https://review.typo3.org/59251
Reviewed-by: Martin Kutschker <martin.kutschker@ymail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Make single errors from FileSizeValidator translatable 96/58996/4
Marc Bastian Heinrichs [Thu, 29 Nov 2018 21:54:35 +0000 (22:54 +0100)]
[BUGFIX] Make single errors from FileSizeValidator translatable

Hand over the original error code from the validator instead of
setting a new one.

Resolves: #87042
Releases: master, 9.5
Change-Id: Ifbb023423934832fdea2550aa7d3a55507616e73
Reviewed-on: https://review.typo3.org/58996
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Remove rawurlencode from felogin reset password link 55/59155/2
Gerrit Mohrmann [Fri, 14 Dec 2018 11:59:42 +0000 (12:59 +0100)]
[BUGFIX] Remove rawurlencode from felogin reset password link

Link is encoded twice since #83334.
The patch removes the rawurlencode from FrontendLoginController

Resolves: #87153
Related: #83334
Releases: master, 9.5
Change-Id: I91a99e952300fb57cc1e9097738ab7f21ea6e9a4
Reviewed-on: https://review.typo3.org/59155
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
6 months ago[!!!][TASK] Remove deprecated code in services of EXT:install 79/59379/3
Georg Ringer [Tue, 8 Jan 2019 20:06:45 +0000 (21:06 +0100)]
[!!!][TASK] Remove deprecated code in services of EXT:install

Resolves: #87373
Releases: master
Change-Id: Iece81d84ec83e2427ab2ce4875d353f9e741a5a5
Reviewed-on: https://review.typo3.org/59379
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
6 months ago[TASK] Remove checks for CRYPT_MD5 and CRYPT_BLOWFISH availability 99/59399/3
Stefanos Karasavvidis [Fri, 11 Jan 2019 09:09:41 +0000 (11:09 +0200)]
[TASK] Remove checks for CRYPT_MD5 and CRYPT_BLOWFISH availability

According to crypt() documentation "As of PHP 5.3.0, PHP contains its
own implementation and will use that if the system lacks of support
for one or more of the algorithms.". So these checks are not
necessary anymore.

Resolves: #87396
Releases: master, 9.5
Change-Id: I6ddede477283a39349e4c4d8d5f464435c855b85
Reviewed-on: https://review.typo3.org/59399
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[FEATURE] Add a telephone (tel:) link handler 74/58674/5
Rune Piper [Tue, 23 Oct 2018 13:41:01 +0000 (15:41 +0200)]
[FEATURE] Add a telephone (tel:) link handler

The new link handler allows you to set links
in a new tab in the link browser to
phone numbers using the tel: protocol.

Resolves: #86629
Releases: master
Change-Id: I1a69fefbe16db9aaae51abfd80f154fa6aa8791a
Reviewed-on: https://review.typo3.org/58674
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Remove checks for vfsStream availability 01/59401/2
Stefanos Karasavvidis [Fri, 11 Jan 2019 09:26:38 +0000 (11:26 +0200)]
[TASK] Remove checks for vfsStream availability

vfsStream and it's classes and methods are required anyway
and thus there is no need to check for it's existence.

Resolves: #87397
Releases: master
Change-Id: I342c3690217823d138ab98a00692de055f8d7fe8
Reviewed-on: https://review.typo3.org/59401
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[BUGFIX] Create default site configuration on installation 91/59391/6
Benni Mack [Wed, 9 Jan 2019 20:33:54 +0000 (21:33 +0100)]
[BUGFIX] Create default site configuration on installation

When a new TYPO3 installation is set up, the user can choose
to "create a first site" (page with sys_template). In this step,
it should be important that a site configuration should be created
as well, in order to use site handling right out-of-the-box.

Therefore, this step in the installer now also creates a site
configuration (identifier "main") with one language english
to get started.

Resolves: #87383
Releases: master, 9.5
Change-Id: Ib8ef27c076d8ed24bfeb015aea52bdcf4ec0432c
Reviewed-on: https://review.typo3.org/59391
Reviewed-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Tested-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Fixing Extension Form Path 84/59384/2
Patrick Bloch [Wed, 9 Jan 2019 13:20:33 +0000 (14:20 +0100)]
[TASK] Fixing Extension Form Path

The Files defined at allowedExtensionPaths are not shown

Releases: master
Resolves: #87376
Change-Id: I7dc96f8cea4a434ee2946482268a2dee8a0952ca
Reviewed-on: https://review.typo3.org/59384
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
6 months ago[BUGFIX] Corrected tooltip for pages with nav_hide 70/59270/3
Guido Schmechel [Sat, 22 Dec 2018 12:23:13 +0000 (13:23 +0100)]
[BUGFIX] Corrected tooltip for pages with nav_hide

The inverted state of the nav_hide values is now considered.
For this purpose, the original label is supplemented again.

Resolves: #87256
Releases: master, 9.5
Change-Id: I8893a15744464af33d2147f1df42b25344d7de92
Reviewed-on: https://review.typo3.org/59270
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Tested-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
6 months ago[!!!][TASK] Drop PATH_thisScript constant 92/59392/10
Christian Kuhn [Wed, 9 Jan 2019 22:17:51 +0000 (23:17 +0100)]
[!!!][TASK] Drop PATH_thisScript constant

The patch removes the definition of constant PATH_thisScript.

* The main change in SystemEnvironmentBuilder splits method
definePaths() into two parts calculateScriptPath() and
calculateRootPath() since definePaths() formerly communicated
the script path using the PATH_thisScript constant to method
initializeEnvironment(), which has to fall now. Note
initializeEnvironment() is now protected, which is ok since
that usage was only internally for the testing framework which
is resolved now, too.

* A raise of the testing framework from 5.0.1 to 5.0.2 is needed.
It also defined that constant and triggered some different code
paths with this in SystemEnvironmentBuilder.
composer require --dev typo3/testing-framework ~5.0.2

* With the changes in SystemEnvironmentBuilder,
Environment::getCurrentScript() now returns '.../bin/phpunit' and
not '.../typo3/index.php' in unit tests, which is more correct. This
however has the side effect that various path related unit tests
need an adaption to properly set up the environment as needed.

Change-Id: I7d16c488a3039b3de689bb8b1b903d989d943c8d
Resolves: #87391
Releases: master
Reviewed-on: https://review.typo3.org/59392
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[TASK] Remove unit tests that do not test the subject 97/59397/2
Christian Kuhn [Thu, 10 Jan 2019 11:27:55 +0000 (12:27 +0100)]
[TASK] Remove unit tests that do not test the subject

Some tests in FrontendLoginControllerTest test only
GeneralUtility::getIndpEnv(), but not the system under
test FrontendLoginController. Remove those.

Resolves: #87389
Releases: master
Change-Id: I3ea71c15ad8eda16750bfec1367ee4cc439dee2f
Reviewed-on: https://review.typo3.org/59397
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[BUGFIX] Remove unused variable in DataHandler 93/59393/2
Christian Kuhn [Wed, 9 Jan 2019 22:20:18 +0000 (23:20 +0100)]
[BUGFIX] Remove unused variable in DataHandler

Resolves: #87384
Related: #87294
Releases: master
Change-Id: If9cba4db4efc8f1c8e1be5c501450e1a18d87235
Reviewed-on: https://review.typo3.org/59393
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Remove crop checkbox in TypoScript Object Browser 30/59130/9
Georg Ringer [Wed, 12 Dec 2018 23:14:42 +0000 (00:14 +0100)]
[TASK] Remove crop checkbox in TypoScript Object Browser

Simplfy the UI by removing the checkbox and do it with
CSS only

Resolves: #87141
Releases: master
Change-Id: I08488f5712148d87e2ce30c53f53fc35905392d9
Reviewed-on: https://review.typo3.org/59130
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Update copyright year in documentation to 2019 81/59381/3
Stefanos Karasavvidis [Wed, 9 Jan 2019 09:20:56 +0000 (11:20 +0200)]
[TASK] Update copyright year in documentation to 2019

Includes year change in Settings.cfg,  Index.rst files and also
README.md, INSTALL.md and SystemEnvironmentBuilder.php

Resolves: #87313
Releases: master, 9.5, 8.7
Change-Id: Ie056e9b7804af4003c2b67ee5e6d87ffd4eb96ba
Reviewed-on: https://review.typo3.org/59381
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated code from TYPO3\CMS\Info\Controller\TranslationStatusCo... 80/59380/2
Georg Ringer [Tue, 8 Jan 2019 20:21:31 +0000 (21:21 +0100)]
[!!!][TASK] Remove deprecated code from TYPO3\CMS\Info\Controller\TranslationStatusController

Resolves: #87374
Releases: master
Change-Id: I16e1f37d9bb402068d921cd7bbafd3716b264bfc
Reviewed-on: https://review.typo3.org/59380
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove t3ver_label database field 97/59297/6
Benni Mack [Tue, 25 Dec 2018 19:20:57 +0000 (20:20 +0100)]
[!!!][TASK] Remove t3ver_label database field

The versioning-related DB field "t3ver_label" has no special
use anymore in TYPO3 Core and Workspaces, as it was related
to static versioning and not workspace-workflows.

Resolves: #87294
Releases: master
Change-Id: I0573bc132c0151b437e557cf2c0f23c4a0d34352
Reviewed-on: https://review.typo3.org/59297
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Avoid fatal when flushed directory is a symlink 74/59374/3
Helmut Hummel [Tue, 8 Jan 2019 14:33:08 +0000 (15:33 +0100)]
[BUGFIX] Avoid fatal when flushed directory is a symlink

\TYPO3\CMS\Core\Utility\GeneralUtility::flushDirectory tries to
rename the given directory to be able to atomically flush the
contents of the directory. This however fails, when the given
folder is a symlink.

We now catch this case by checking whether the given directory
is a symlink and resolve it with realpath.

While this does not cover all possible cases, it improves the
case where the folder containing the symlink is also writable.

Resolves: #87367
Releases: master, 9.5, 8.7
Change-Id: Ic812a5eaa86cca4d81aee31b4a3fbdce052994a0
Reviewed-on: https://review.typo3.org/59374
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
6 months ago[TASK] Raise styleguide from 10.0.1 to 10.0.2 87/59387/2
Christian Kuhn [Wed, 9 Jan 2019 15:09:06 +0000 (16:09 +0100)]
[TASK] Raise styleguide from 10.0.1 to 10.0.2

Brings a patch that blocks a core patch due to a
deprecated field usage in styleguide.

composer require --dev typo3/cms-styleguide ~10.0.2

Resolves: #87381
Releases: master
Change-Id: Ic7e67b0ff5f0865bfdcff97d62a18b891bf959dc
Reviewed-on: https://review.typo3.org/59387
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Remove TYPO3\CMS\Core\TypoScript\ConfigurationForm 78/59378/3
Georg Ringer [Tue, 8 Jan 2019 19:04:25 +0000 (20:04 +0100)]
[!!!][TASK] Remove TYPO3\CMS\Core\TypoScript\ConfigurationForm

Resolves: #87372
Releases: master
Change-Id: I53efcec5649e062062014d7c271a84ada7c14ecc
Reviewed-on: https://review.typo3.org/59378
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Move entry path existance check in SystemEnvironmentBuilder 86/59386/3
Christian Kuhn [Wed, 9 Jan 2019 13:41:30 +0000 (14:41 +0100)]
[TASK] Move entry path existance check in SystemEnvironmentBuilder

As a preparation to further path related clean ups, the
file existance check of the determined scriptPath must
only be checked if PATH_thisScript is not defined. This
is an edge case that was triggered with my patch for
issue #87247 and fixes unit tests for extensions with
current testing-framework.
Note this is not the final state and more patches to
handle the path mess will follow later.

Resolves: #87378
Related: #87247
Releases: master
Change-Id: I8e3d8524a5d40fe66bdfdbda92a2f18540d9a0d8
Reviewed-on: https://review.typo3.org/59386
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <noreply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Install tool: Allow row updater as valid identifier 90/59290/2
Thorben Nissen [Sun, 23 Dec 2018 21:16:12 +0000 (22:16 +0100)]
[BUGFIX] Install tool: Allow row updater as valid identifier

In `UpgradeWizardService::assertIdentifierIsValid` check if the
identifier is a subclass of `RowUpdaterInterface` to avoid an exception
being thrown, when marking a row updater as undone.

Resolves: #87283
Releases: master, 9.5
Change-Id: I1b6a18437aa9d5a423c0a47595feac8b51c28bdb
Reviewed-on: https://review.typo3.org/59290
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Use `addOrderBy()` to support multiple orderings 56/59356/3
Andreas Fernandez [Mon, 7 Jan 2019 14:26:02 +0000 (15:26 +0100)]
[BUGFIX] Use `addOrderBy()` to support multiple orderings

`DatabaseRecordList::prepareQueryBuilder()` is able to handle multiple
order clauses defined in either `sortby` or `default_sortby`. However,
the wrong method for appending the order clause is used, which results in
overriding the previous set clause.

This patch changes the method to use `addOrderBy()` instead which appends
multiple order clauses properly.

Resolves: #87352
Releases: master, 9.5
Change-Id: I08f4248d4dc890079715efb9a48b1d270a6b1077
Reviewed-on: https://review.typo3.org/59356
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: featdd <dorndorf@featdd.de>
Tested-by: featdd <dorndorf@featdd.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated code from EXT:recordlist 57/59357/6
Andreas Fernandez [Mon, 7 Jan 2019 15:06:07 +0000 (16:06 +0100)]
[!!!][TASK] Remove deprecated code from EXT:recordlist

Resolves: #87354
Related: #87193
Releases: master
Change-Id: Ib1ccf6fdb7c69257716665c58e75b2295dc5f0b1
Reviewed-on: https://review.typo3.org/59357
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[BUGFIX] Add also the "/" slash to ROUTE_PATH_DELIMITERS array 23/59123/5
Ralf Merz [Wed, 12 Dec 2018 16:43:14 +0000 (17:43 +0100)]
[BUGFIX] Add also the "/" slash to ROUTE_PATH_DELIMITERS array

This is needed so that the PageType routeEnhancer is able to build URL
with a single trailing slash.
In other words, this fixes that a double trailing slash was created.

The functional test pageTypeDecoratorIsApplied gets extended with 2
instruction scenarios to set routeEnhancer PageTypeDecorator to
have a trailing slash instead of .html suffix tested, too.

Resolves: #86557
Releases: master, 9.5
Change-Id: If03bad8f054dc659f8870a98e064d9869597e8ba
Reviewed-on: https://review.typo3.org/59123
Reviewed-by: Michael Giek <michael.giek@web.de>
Tested-by: Michael Giek <michael.giek@web.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[BUGFIX] Replace removed alias for ViewHelperNode 71/59371/3
Stefanos Karasavvidis [Tue, 8 Jan 2019 09:07:39 +0000 (11:07 +0200)]
[BUGFIX] Replace removed alias for ViewHelperNode

Replaces the removed class alias
TYPO3\CMS\Fluid\Core\Parser\SyntaxTree\ViewHelperNode.

Resolves: #87362
Releases: master, 9.5
Change-Id: I21a3c35a0ce1b8cd7bf9de839dcc3e4bdba05bbb
Reviewed-on: https://review.typo3.org/59371
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Tested-by: Steffen Dietrich <Teilzeitphilosoph@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Set pageId in WorkspacePreview in InlineSettings 98/58998/4
Devid Messner [Fri, 30 Nov 2018 11:16:44 +0000 (12:16 +0100)]
[BUGFIX] Set pageId in WorkspacePreview in InlineSettings

The page ID is necessary for publishing and changing the stage.
Otherwise, the entire workspace is always published.

Resolves: #87047
Releases: master, 9.5
Change-Id: I4154810e79d776d41315d2d7029352fa86eff5d0
Reviewed-on: https://review.typo3.org/58998
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Achim Fritz <af@achimfritz.de>
Tested-by: Achim Fritz <af@achimfritz.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[!!!][TASK] Remove deprecated code from TableController 68/59368/3
Georg Ringer [Mon, 7 Jan 2019 20:47:57 +0000 (21:47 +0100)]
[!!!][TASK] Remove deprecated code from TableController

Resolves: #87360
Releases: master
Change-Id: Iaac2d1242fdc9d9fe71500f816096753266c40a5
Reviewed-on: https://review.typo3.org/59368
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Remove deprecated code from DocumentTemplate 69/59369/2
Georg Ringer [Mon, 7 Jan 2019 21:00:28 +0000 (22:00 +0100)]
[!!!][TASK] Remove deprecated code from DocumentTemplate

Resolves: #87361
Releases: master
Change-Id: I21ff5db9c8f2faf303e93a0c897aa44f20f663b4
Reviewed-on: https://review.typo3.org/59369
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Remove leftover deprecated hooks 64/59364/5
Benni Mack [Mon, 7 Jan 2019 20:14:34 +0000 (21:14 +0100)]
[!!!][TASK] Remove leftover deprecated hooks

Due to testing framework refactoring, the 2 leftover hooks
in Frontend middlewares can now be removed:

$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/class.tslib_fe.php']['initFEuser']
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['tslib/index_ts.php']['postBeUser']

Thus, Frontend Middleware stack is now free of hooks.

Resolves: #87357
Releases: master
Change-Id: I076d9f4aa556f4ba111196449eee6449ba8036db
Reviewed-on: https://review.typo3.org/59364
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[TASK] Activate link on numbers in filelist pagination 25/59325/3
Guido Schmechel [Thu, 3 Jan 2019 22:04:03 +0000 (23:04 +0100)]
[TASK] Activate link on numbers in filelist pagination

Because it is hard to hit only the arrow, now the numbers
in the filelist pagination are linked as well.

Resolves: #87317
Releases: master, 9.5
Change-Id: If8a00d603b0b0f474b7e23814ed0d075fa217a52
Reviewed-on: https://review.typo3.org/59325
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Tested-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[TASK] Raise typo3/testing-framework to ~5.0.1 63/59363/3
Christian Kuhn [Mon, 7 Jan 2019 19:51:32 +0000 (20:51 +0100)]
[TASK] Raise typo3/testing-framework to ~5.0.1

The new version no longer uses two deprecated frontend
hooks and switches to proper psr-15 middleware instead.
This unlocks the according hook removal for core in
a separate patch.

composer require --dev typo3/testing-framework ~5.0.1

Change-Id: Ia30704174d975df6a253b0bac66e037b5dc4987d
Resolves: #87358
Reviewed-on: https://review.typo3.org/59363
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Remove database field pages.alias 32/59232/7
Benni Mack [Thu, 20 Dec 2018 08:46:12 +0000 (09:46 +0100)]
[!!!][TASK] Remove database field pages.alias

This is a precursor for removing PseudoSiteHandling in general.

The database field "pages.alias" field is dropped, along with
the functionality to evalute if a frontend request "?id=acme"
is non-integer, as it now always has to be integer.

Existing links pointing to page aliases will stop working.

Resolves: #87356
Releases: master
Change-Id: I19134cc788e633e140b43497f716082ac96744e5
Reviewed-on: https://review.typo3.org/59232
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[FEATURE] Add scheduler information to system information toolbar 09/57609/19
Josef Glatz [Mon, 16 Jul 2018 09:21:43 +0000 (11:21 +0200)]
[FEATURE] Add scheduler information to system information toolbar

The system information toolbar now shows useful information
about the (automatic) execution/configuration of the TYPO3
scheduler if the system extension is activated and if there
are any tasks configured at all.

- Show a warning when the scheduler execution seems not
  to be configured correctly
- Show start date, start time, duration and execution type
  of the last sucessfully executed scheduler run
  - Highlight information if it was started manually

Releases: master
Resolves: #85569
Change-Id: Ic1b8a1c52678b60d40edcb77296f51f58ec01a4b
Reviewed-on: https://review.typo3.org/57609
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Tested-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated code in DataHandler 30/59330/3
Benni Mack [Fri, 4 Jan 2019 19:21:12 +0000 (20:21 +0100)]
[!!!][TASK] Remove deprecated code in DataHandler

The following methods / properties / TSconfig options are removed:

- DataHandler->updateModeL10NdiffData
- DataHandler->updateModeL10NdiffDataClear

- DataHandler->resorting()
- DataHandler->getTCEMAIN_TSconfig()
- DataHandler->newlog2()

- options.clearCache.system

Resolves: #87346
Releases: master
Change-Id: I0c21020528aef515f40067e2ee97fee8f78ca27c
Reviewed-on: https://review.typo3.org/59330
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[BUGFIX] Use correct language fallback settings in functional tests 52/59352/3
Oliver Hader [Mon, 7 Jan 2019 07:56:27 +0000 (08:56 +0100)]
[BUGFIX] Use correct language fallback settings in functional tests

Site configuration generators in functional tests produced wrong data
concerning language fallbacks. Since there have not been any test cases
making use of this particular feature, no tests had to be adjusted.

Resolves: #87344
Releases: master, 9.5
Change-Id: I66707bffc4ba1edce9de304fed897724b99ab81b
Reviewed-on: https://review.typo3.org/59352
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[TASK] Remove fuzzy extension scanner checks 53/59353/2
Benni Mack [Mon, 7 Jan 2019 08:29:21 +0000 (09:29 +0100)]
[TASK] Remove fuzzy extension scanner checks

The recently introduced addition to the
ExtensionScanner files for
GraphicalFunctions->init() is removed
as there are too many false positives
due to a badly named method name (init).

The check is removed again.

Related: #87342
Resolves: #87345
Releases: master
Change-Id: Iab775eed9a760cf3d5129476d69ccf9d561b47bf
Reviewed-on: https://review.typo3.org/59353
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Tested-by: Stefanos Karasavvidis <sk@karasavvidis.gr>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[FEATURE] Support feature toggle in expression language 79/58879/6
Frank Naegler [Wed, 7 Nov 2018 22:00:23 +0000 (23:00 +0100)]
[FEATURE] Support feature toggle in expression language

Change-Id: I018b19b2fc0962b45d052a7ae4a56396f002361c
Resolves: #86881
Releases: master, 9.5
Reviewed-on: https://review.typo3.org/58879
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
6 months ago[!!!][TASK] Remove deprecated function `launchView()` 51/59351/2
Andreas Fernandez [Mon, 7 Jan 2019 07:40:43 +0000 (08:40 +0100)]
[!!!][TASK] Remove deprecated function `launchView()`

Resolves: #87343
Related: #87193
Releases: master
Change-Id: Ia93afa94cd510debc0a37930f1dbf761d7d23267
Reviewed-on: https://review.typo3.org/59351
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Remove deprecated code in EXT:core 35/59335/3
Benni Mack [Fri, 4 Jan 2019 20:17:58 +0000 (21:17 +0100)]
[!!!][TASK] Remove deprecated code in EXT:core

The fallback in site configuration (during 9.3 and 9.4)
with all configuration within the subproperty
"site" is now removed.

- GraphicalFunctions->init()
- AbstractHierarchicalFilesystemDriver()->getCharsetConversion()
- FAL: FileExtensionFilter + Indexer - file extension + mimetype guessing
- ResourceStorage->dumpFileContents()
- AbstractService->devLog()

Resolves: #87342
Releases: master
Change-Id: I107544a129272ebace234e4e7e3ead0ff05a2e5c
Reviewed-on: https://review.typo3.org/59335
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated `TYPO3.Popover` object 47/59347/7
Andreas Fernandez [Sun, 6 Jan 2019 14:05:33 +0000 (15:05 +0100)]
[!!!][TASK] Remove deprecated `TYPO3.Popover` object

The global JavaScript object `TYPO3.Popover` has been removed.

Resolves: #87338
Related: #87193
Releases: master
Change-Id: I810711a01edd4d43820d714200a871271d4136b0
Reviewed-on: https://review.typo3.org/59347
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated `TYPO3.Utility` object 48/59348/4
Andreas Fernandez [Sun, 6 Jan 2019 14:15:43 +0000 (15:15 +0100)]
[!!!][TASK] Remove deprecated `TYPO3.Utility` object

The global JavaScript object `TYPO3.Utility` has been removed.

Resolves: #87339
Releases: master
Change-Id: I50a6cd465aa914780c825152b7172df9b92173f3
Reviewed-on: https://review.typo3.org/59348
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated code from EXT:install 95/59295/4
Wouter Wolters [Tue, 25 Dec 2018 12:08:21 +0000 (13:08 +0100)]
[!!!][TASK] Remove deprecated code from EXT:install

Resolves: #87292
Releases: master
Change-Id: I4ea3a115273e9b83fc7eabf0cd87440df05b0f86
Reviewed-on: https://review.typo3.org/59295
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated `TYPO3/CMS/Backend/Storage` 49/59349/2
Andreas Fernandez [Sun, 6 Jan 2019 14:26:08 +0000 (15:26 +0100)]
[!!!][TASK] Remove deprecated `TYPO3/CMS/Backend/Storage`

Resolves: #87340
Related: #87193
Releases: master
Change-Id: I2f41008e0e3827c52f5d5351a53898bd22f3748d
Reviewed-on: https://review.typo3.org/59349
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated code from RteHtmlParser 42/59342/3
Christian Kuhn [Sat, 5 Jan 2019 16:15:16 +0000 (17:15 +0100)]
[!!!][TASK] Remove deprecated code from RteHtmlParser

Resolves: #87336
Releases: master
Change-Id: I7835c2e328aac7bc154b9460abaec56a29fe8216
Reviewed-on: https://review.typo3.org/59342
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[BUGFIX] Show tooltips in the recordlist 36/59336/2
Guido Schmechel [Sat, 5 Jan 2019 07:52:29 +0000 (08:52 +0100)]
[BUGFIX] Show tooltips in the recordlist

If a recordlist title do not need to be converted for
output, then the original title will be taken for the
tooltip and added to a span tag.

Resolves: #87326
Releases: master, 9.5
Change-Id: I58fbf9ceadf191eaafc5430ce4d09adeb27c789f
Reviewed-on: https://review.typo3.org/59336
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Drop core 6->7 auto TCA migrations 41/59341/3
Christian Kuhn [Sat, 5 Jan 2019 15:07:29 +0000 (16:07 +0100)]
[!!!][TASK] Drop core 6->7 auto TCA migrations

The TcaMigration class to auto migrate existing TCA
to new specs before it is cached has been added with
core v7.
The patch now finally removes all migrations that
changed core v6 compatible TCA to core v7 compatible
TCA.

Resolves: #87335
Releases: master
Change-Id: Ie5734d4c0bcee83ce74591d6de39a50c12d4386a
Reviewed-on: https://review.typo3.org/59341
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[!!!][TASK] Remove deprecated functionality in RootlineUtility 32/59332/2
Benni Mack [Fri, 4 Jan 2019 19:36:20 +0000 (20:36 +0100)]
[!!!][TASK] Remove deprecated functionality in RootlineUtility

The constructor does not allow PageRepository anymore, but the new
Context object only (or null, as it is an optional argument).

Resolves: #87331
Releases: master
Change-Id: I4d103aee03b1b30ceab6f033ccc58b1af0626157
Reviewed-on: https://review.typo3.org/59332
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
6 months ago[TASK] Stop dangling containers in bamboo 38/59338/2
Christian Kuhn [Sat, 5 Jan 2019 13:51:43 +0000 (14:51 +0100)]
[TASK] Stop dangling containers in bamboo

In rare conditions a bamboo agent does not stop all
created sibling containers at the end of a job. These
dangling containers then make consecutive runs on this
agents fail due to container namespace collisions.
As a self-heal mechanism, all jobs that fiddle with
containers now simply stop any possibly dangling containers
as an early task before starting own ones.

Resolves: #87334
Releases: master, 9.5, 8.7
Change-Id: I80332da8f9b1013dc8d961e7e532faf59b3bd3b8
Reviewed-on: https://review.typo3.org/59338
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months agoRevert "[TASK] Remove COMPOSER_ROOT_VERSION from bamboo testing" 37/59337/2
Christian Kuhn [Sat, 5 Jan 2019 13:13:10 +0000 (14:13 +0100)]
Revert "[TASK] Remove COMPOSER_ROOT_VERSION from bamboo testing"

This reverts commit 4036d2ecf3c5cfc24fa4f0408633eac6fec72515.

The solution does not work out for not yet released
major versions like 10.*.

Reverts: #87170
Resolves: #87170
Releases: master
Change-Id: Ibb827acc97e48e5e44e4b8aec77501517afc762e
Reviewed-on: https://review.typo3.org/59337
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[!!!][TASK] Remove deprecated functionality within PageRenderer 10/59310/5
Benni Mack [Sun, 30 Dec 2018 19:25:41 +0000 (20:25 +0100)]
[!!!][TASK] Remove deprecated functionality within PageRenderer

Various jQuery and MetaTag API related methods within
PageRenderer have been removed.

Resolves: #87310
Releases: master
Change-Id: I309718b6576aca8ba6a5323d16f9395a752a0b0d
Reviewed-on: https://review.typo3.org/59310
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
6 months ago[BUGFIX] Invalidate cached PageTitleProvider 65/59265/3
Guido Schmechel [Sat, 22 Dec 2018 11:26:14 +0000 (12:26 +0100)]
[BUGFIX] Invalidate cached PageTitleProvider

After handling/saving a page the cache entry for pageTitle
is removed, too.

Resolves: #87257
Releases: master, 9.5
Change-Id: I5aac5563d49100ef1f82e6bbe22dad05969b6fdf
Reviewed-on: https://review.typo3.org/59265
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: JarvisH <jekorma+mytypo3@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
6 months ago[!!!][TASK] Remove deprecated code in ExtensionManagementUtility 11/59311/3
Benni Mack [Sun, 30 Dec 2018 19:38:27 +0000 (20:38 +0100)]
[!!!][TASK] Remove deprecated code in ExtensionManagementUtility

Various methods within ExtensionManagementUtility that was
previously deprecated have been removed.

Resolves: #87311
Releases: master
Change-Id: I38e557f46492cc2b3c14f97882266efa673d7349
Reviewed-on: https://review.typo3.org/59311
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>