Packages/TYPO3.CMS.git
15 months ago[BUGFIX] Fix timestamp handling in QueryGenerator 77/55877/2
Reiner Teubner [Fri, 2 Feb 2018 13:55:36 +0000 (14:55 +0100)]
[BUGFIX] Fix timestamp handling in QueryGenerator

Since https://review.typo3.org/c/51242/ all hidden
FormEngine fields work with ISO dates but the
QueryGenerator can only handle unix timestamp.
This patch fix the query building process for
timestamp record fields.

Resolves: #83675
Releases: master, 8.7
Change-Id: I79227762c4159984612d86dea640bdfd8b3a2784
Reviewed-on: https://review.typo3.org/55877
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Hide readonly elements in summary page and emails 37/55837/5
Ralf Zimmermann [Wed, 13 Sep 2017 10:51:37 +0000 (12:51 +0200)]
[BUGFIX] Hide readonly elements in summary page and emails

Hide readonly form elements within the summary page and emails.

Resolves: #82471
Releases: master, 8.7
Change-Id: I9c42754c935c0b2c62ff1a70f43e7a13d3594f82
Reviewed-on: https://review.typo3.org/55837
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Don't download language packs of not loaded extensions 63/55863/2
Christian Kuhn [Wed, 21 Feb 2018 23:05:49 +0000 (00:05 +0100)]
[BUGFIX] Don't download language packs of not loaded extensions

The backend language module struggles with downloading
language packs of existing, but not loaded extensions
and fetchess old (non core version specific) packs
for core extensions.
This is hard to solve on a bugfix level for v7 and v8,
and in general it does not make much sense to have
language packs of not loaded extensions lying around
in typo3conf/l10n.
The patch ignores fetching of language packs for
not loaded extensions, it easily applies to all
maintained core versions.

Change-Id: I9ad885012a572368f7946f1027d870ee09550034
Resolves: #83406
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55863
Reviewed-by: Michael Stucki <michael.stucki@typo3.org>
Tested-by: Michael Stucki <michael.stucki@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Snychronize form framework documentation 61/55861/2
Björn Jacob [Thu, 22 Feb 2018 08:28:07 +0000 (09:28 +0100)]
[TASK] Snychronize form framework documentation

This patch synchronizes the documentation of the form framework
for TYPO3 v8.

Resolves: #83967
Releases: 8.7
Change-Id: I71770385f951b7c84ab54e19aecb246b71ba4ea3
Reviewed-on: https://review.typo3.org/55861
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Rename /prototypes to /proto of form docs 51/55851/3
Björn Jacob [Wed, 21 Feb 2018 08:10:20 +0000 (09:10 +0100)]
[TASK] Rename /prototypes to /proto of form docs

The folder /prototypes of the form documentation is renamed to /proto.
This is a first step to synchronize the documentation of TYPO3 v8 and v9.

Resolves: #83988
Releases: 8.7
Change-Id: I6fa329a2d0971c89ef2c1416f07ff3fb284d30ef
Reviewed-on: https://review.typo3.org/55851
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Use sys_file as soft reference for formDefinitions 43/55843/2
Ralf Zimmermann [Tue, 20 Feb 2018 15:55:03 +0000 (16:55 +0100)]
[BUGFIX] Use sys_file as soft reference for formDefinitions

Register an embedded form definition as sys_file soft reference to show
the usage of the form definition within the file list module.

Resolves: #83502
Releases: master, 8.7
Change-Id: Ifdba760b8ebd45a9b83e97c5a20cf23ede6a74d7
Reviewed-on: https://review.typo3.org/55843
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Add placeholder to date picker form elements 41/55841/2
Ralf Zimmermann [Tue, 20 Feb 2018 17:20:01 +0000 (18:20 +0100)]
[BUGFIX] Add placeholder to date picker form elements

Add the possibility to define a placeholder html attribute for
date picker form elements.

Resolves: #82514
Releases: master, 8.7
Change-Id: I7bf272d4e1e9b0af1c15e6ceeb6e1b91afba327e
Reviewed-on: https://review.typo3.org/55841
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
15 months ago[BUGFIX] Refactor record querying in deep nested structures in recycler 42/55842/2
Andreas Fernandez [Sat, 27 Jan 2018 23:14:11 +0000 (00:14 +0100)]
[BUGFIX] Refactor record querying in deep nested structures in recycler

This patch refactors how the recycler queries records in deep page
structures.
Instead of resolving each level of the page tree on demand and executing
the complex logic of creating query builders and paging all over again,
a list of page ids is generated once and stored in the Caching Framework
for the current request. This list is then used in an multiple `IN()`
statements (depending on the DBMS engine used).

Also, some wrong type hints and a wrong language file reference are
fixed.

Resolves: #83702
Releases: master, 8.7
Change-Id: Ie3314b5a9209fb5585f95a70c16b35639951c197
Reviewed-on: https://review.typo3.org/55842
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Fix miscellaneous palette in pages table 39/55839/2
Armin Vieweg [Tue, 20 Feb 2018 11:30:15 +0000 (12:30 +0100)]
[BUGFIX] Fix miscellaneous palette in pages table

Removed unnecessary locallang reference for field "editlock"
in showitem string. This field has been moved to access tab.

Resolves: #83974
Branches: master, 8.7
Change-Id: I85201f552a67badca420386bb615bcc571a712db
Reviewed-on: https://review.typo3.org/55839
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] EXT:form - fix design glitches of new element modal 36/55836/2
Andreas Steiger [Tue, 20 Feb 2018 16:19:30 +0000 (17:19 +0100)]
[BUGFIX] EXT:form - fix design glitches of new element modal

Streamline the markup of the new element modal of the form editor and
fix some style glitches due to side effects with other extensions.

Resolves: #82444
Releases: master, 8.7
Change-Id: Ifceac76a70dd4744f52da3b08ca8baea5f4adb7d
Reviewed-on: https://review.typo3.org/55836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Ensures call of synchronizeFieldValues with valid arguments 25/55825/2
Joerg Kummer [Fri, 16 Feb 2018 18:05:16 +0000 (19:05 +0100)]
[BUGFIX] Ensures call of synchronizeFieldValues with valid arguments

Let 8.7 installtool upgrade wizard L10nModeUpdater ignore synchronization if parent entry of given translations is set to deleted

Resolves: #83940
Releases: master, 8.7
Change-Id: Ie240f71ecf42564c0547abd2dfa5c5efb23c6385
Reviewed-on: https://review.typo3.org/55825
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] EXT:form - Rename "Vendor" javascript folder to "Contrib" 21/55821/2
Ralf Zimmermann [Tue, 20 Feb 2018 06:50:42 +0000 (07:50 +0100)]
[TASK] EXT:form - Rename "Vendor" javascript folder to "Contrib"

Move folder typo3/sysext/form/Resources/Public/JavaScript/Backend/Vendor
to typo3/sysext/form/Resources/Public/JavaScript/Contrib.

Resolves: #83879
Releases: master, 8.7
Change-Id: I35cefa13bcfa621d4877273267d58ff4e26cd5bd
Reviewed-on: https://review.typo3.org/55821
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
15 months ago[TASK] Extend untangleFilesArray function test in RequestBuilder 10/55810/2
Joshua Westerheide [Sat, 11 Nov 2017 16:42:05 +0000 (17:42 +0100)]
[TASK] Extend untangleFilesArray function test in RequestBuilder

Check for cases where the files array is nested more complex or
keywords (e.g. "error") are used as field names.

Run `curl -F "d0[]=@d12.txt" -F "d0[d1][d2][d3]=@d12.txt"
-F "error=@error_file.txt" localhost:8080` against a custom
php script to generate the testing $_FILES array.

Resolves: #82976
Releases: master, 8.7, 7.6
Change-Id: I51fb9da7c87871b6bb1e8ac4de317973f307dd49
Reviewed-on: https://review.typo3.org/55810
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Fix source collection for GIFBUILDER 17/55817/2
Marco Huber [Mon, 22 Aug 2016 11:49:34 +0000 (13:49 +0200)]
[BUGFIX] Fix source collection for GIFBUILDER

If the file resource is a GIFBUILDER object, the dimension is set in the
properties XY, maxWidth or maxHeight.

Change-Id: Ic931760a966e6647042bca976c48e7bbaabdbb5a
Resolves: #77577
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55817
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] Change the label for scheduler "Save and create" 06/55806/2
Tomas Norre Mikkelsen [Thu, 15 Feb 2018 13:10:50 +0000 (14:10 +0100)]
[TASK] Change the label for scheduler "Save and create"

The label for the "Save and create new document" in the scheduler module,
will be change to a more appropriate label "Save and create new task"

Resolves: #83920
Releases: master, 8.7, 7.6
Change-Id: Ic4d6ad9d4598aafbc16c03b5bc50789451f6cdaf
Reviewed-on: https://review.typo3.org/55806
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] EXT:filelist Fixed exception when creating new text file 09/55809/2
Michael Oehlhof [Sun, 21 Jan 2018 11:50:51 +0000 (12:50 +0100)]
[BUGFIX] EXT:filelist Fixed exception when creating new text file

The exception does not occur with the LocalDriver.
For testing use the driver mentioned in the forge issue.

Resolves: #83627
Releases: master, 8.7
Change-Id: Iae5fef2cc1ca704998975aba4fb6f5e48aeec4b1
Reviewed-on: https://review.typo3.org/55809
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Handle empty string icon-overlay identifier 08/55808/2
Romain Canon [Sat, 23 Sep 2017 13:07:02 +0000 (15:07 +0200)]
[BUGFIX] Handle empty string icon-overlay identifier

An overlay identifier can be an empty string, for instance when the icon API is
called with the Fluid icon view helper:

```
<core:icon identifier="tx-my-icon"
           overlay="{f:if(condition: myCondition, then: 'my-overlay-icon')}" />
```

In the example below, if the condition `myCondition` is `false`, an empty string
is used for the overlay parameter.

---

Previously, an empty string as overlay identifier would lead to the basic "not
found icon" being used as overlay.

With this commit, the behaviour for an empty string will now be the same as when
 `null` is used.

---

Resolves: #82547
Releases: master, 8.7
Change-Id: I6fb8207f302873e0188d71a210485bbf8565eff9
Reviewed-on: https://review.typo3.org/55808
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Show all dropdown items of form finisher 97/55797/2
Andreas Steiger [Mon, 19 Feb 2018 15:09:59 +0000 (16:09 +0100)]
[BUGFIX] Show all dropdown items of form finisher

Show the entire content of a long finisher dropdown in form wizard.

Resolves: #83131
Releases: 8.7
Change-Id: I38a389476439968224f4dd57d38a513e6dde1c08
Reviewed-on: https://review.typo3.org/55797
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[TASK] Catch exception in record editing if current record is deleted 94/55794/2
Georg Ringer [Thu, 15 Feb 2018 07:08:29 +0000 (08:08 +0100)]
[TASK] Catch exception in record editing if current record is deleted

If an edit form is reloaded after the record has been deleted,
a message should be shown to the user instead of an exception.

Resolves: #83903
Releases: master, 8.7
Change-Id: Ib427ee8601a70c53d63f1afea7f1eacc71fd5da1
Reviewed-on: https://review.typo3.org/55794
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Remove "Set" button in belog extension 90/55790/2
Gianluigi Martino [Wed, 14 Feb 2018 15:09:48 +0000 (16:09 +0100)]
[TASK] Remove "Set" button in belog extension

The "Set" button is obsolete because the filter change automatically on dropdown select.

Resolves: #83895
Releases: master, 8.7
Change-Id: I0f0acf05a5c06395bb8710829d68e5add9462d94
(cherry picked from commit 96d3514f83d45be49d69f9c5bd39c917e9cf433c)
Reviewed-on: https://review.typo3.org/55790
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
15 months ago[BUGFIX] Show links to missing records in InputLink 89/55789/2
Alexander Opitz [Fri, 16 Feb 2018 10:10:21 +0000 (11:10 +0100)]
[BUGFIX] Show links to missing records in InputLink

If the linked record wasn't found (wrong uid, removed from database) we
check before trying to gather an icon for the non-existing record.

Resolves: #81804
Releases: master, 8.7
Change-Id: Ie06ec8a614650d8147f143cda8d8e6a9cb3e98e9
(cherry picked from commit aa4ce89d5263d5258ae8e35dc5daeb9eb9fae561)
Reviewed-on: https://review.typo3.org/55789
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
15 months ago[TASK] Add composer.json integrity check 88/55788/4
Mathias Schreiber [Sat, 17 Feb 2018 20:40:05 +0000 (21:40 +0100)]
[TASK] Add composer.json integrity check

Each composer.json file in a system extension now has its dependencies
checked against the root composer.json to avoid errors after the subtree split.

Resolves: #83957
Releases: master, 8.7
Change-Id: Ibf37bd56fd1534b14e714dfdfaaf6374a48978c4
Reviewed-on: https://review.typo3.org/55788
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Add CGL check for CSV fixtures 87/55787/5
Mathias Schreiber [Fri, 16 Feb 2018 18:25:49 +0000 (19:25 +0100)]
[TASK] Add CGL check for CSV fixtures

We now make sure that invalid CSV no longer gets merged
into TYPO3s core.

Resolves: #83943
Releases: master, 8.7
Change-Id: If8b6a20b3ccf9cbcdc3ffe0e74733dfd941c09d5
Reviewed-on: https://review.typo3.org/55787
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Fix CSV fixtures in core 86/55786/2
Anja Leichsenring [Sat, 17 Feb 2018 21:03:23 +0000 (22:03 +0100)]
[BUGFIX] Fix CSV fixtures in core

All CSV fixtures are now a proper CSV file with a proper column count.
This makes editing them with a picky CSV editor possible again.

Resolves: #83941
Releases: master
Change-Id: Ic5f59c49fd3fa6ad98036f5392e36d450633d501
Reviewed-on: https://review.typo3.org/55786
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Unify installation tests 84/55784/2
Anja Leichsenring [Sat, 17 Feb 2018 10:24:52 +0000 (11:24 +0100)]
[TASK] Unify installation tests

MySql receives a test to install the introduction package, PgSql gets
one for the blank page preset.
With this change, both install suites check both kind of setup the
instance.

Change-Id: Ic21091f5bc3a0aa14a49e9e9fa65a5f9db829cdb
Resolves: #83949
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55784
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Respect casing in CommandLineBackendUserRemovalUpdate 82/55782/2
Anja Leichsenring [Thu, 15 Feb 2018 19:27:13 +0000 (20:27 +0100)]
[BUGFIX] Respect casing in CommandLineBackendUserRemovalUpdate

System extensions used to create their _cli_* users lowercased.
The wizard queries only for uppercase varieties. Adding a LOWER
command to the where-clause catches now all casings.

Change-Id: I556f0181416067479ff579d2498389a564c6a5e3
Resolves: #83927
Relates: #79276
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55782
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Properly check for HTTPS 64/55764/2
Alexander Opitz [Fri, 16 Feb 2018 09:08:07 +0000 (10:08 +0100)]
[TASK] Properly check for HTTPS

Take into account empty and "off" values for the HTTPS request variable
to support ISAPI with IIS.

Resolves: #81837
Releases: master, 8.7
Change-Id: I5937c506d3e36a2009a8da6e66724728654b4001
Reviewed-on: https://review.typo3.org/55764
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Flacky acceptance test 68/55768/2
Christian Kuhn [Fri, 16 Feb 2018 20:08:19 +0000 (21:08 +0100)]
[BUGFIX] Flacky acceptance test

Better safeguard a BookmarkCest detail to
stabilize that patch again.

Change-Id: Ia873d1c8a04d0ef329c280ff5d4d7518c6b73e22
Resolves: #83947
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55768
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Unit tests call parent::tearDown() 62/55762/3
Christian Kuhn [Fri, 16 Feb 2018 18:25:12 +0000 (19:25 +0100)]
[BUGFIX] Unit tests call parent::tearDown()

For the memory garbage collection of UnitTestCase to kick in,
it is important that unit tests which implement tearDown()
call parent after their own job.

Fix some missing parent calls, refactor some other tests
slightly to live without tearDown() and activate two tests
that come with an invalid @depends annotation.

Change-Id: I51c7534ea3220ec63fd8c3efa94e8bf295590e68
Resolves: #83944
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55762
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Fix table markup in DragDropUploader 57/55757/2
Mathias Schreiber [Fri, 16 Feb 2018 15:33:52 +0000 (16:33 +0100)]
[BUGFIX] Fix table markup in DragDropUploader

Resolves: #83938
Releases: master, 8.7
Change-Id: I71ddeb358cea2b24a4db46545a35ca956c6bc320
Reviewed-on: https://review.typo3.org/55757
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[CLEANUP] Remove obsolete fixtures of Fluid unit tests 45/55745/2
Andreas Fernandez [Thu, 15 Feb 2018 19:46:33 +0000 (20:46 +0100)]
[CLEANUP] Remove obsolete fixtures of Fluid unit tests

Change-Id: I8a54c72090fc9e9d39fae1ddd13d8f72f691fcc0
Resolves: #83929
Related: #79972
Related: #77127
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55745
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Correct check for install tool requests in bootstrap 40/55740/2
Susanne Moog [Thu, 15 Feb 2018 18:32:49 +0000 (19:32 +0100)]
[BUGFIX] Correct check for install tool requests in bootstrap

Resolves: #83924
Releases: master, 8.7
Change-Id: If9f435c64addea63793586e131da19768749857c
Reviewed-on: https://review.typo3.org/55740
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] Let Bamboo check for clean TypeScript build 32/55732/3
Andreas Fernandez [Wed, 14 Feb 2018 14:18:39 +0000 (15:18 +0100)]
[TASK] Let Bamboo check for clean TypeScript build

To avoid having stale TypeScript builds, Bamboo now recompiles every
TypeScript via grunt and checks for unwanted modifications.

Change-Id: I1d96bb81eff4d5c42332d0a27cce0a98a7d27478
Resolves: #83914
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55732
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Hide "Group by page" if only one page is shown in EXT:belog 29/55729/2
Gianluigi Martino [Wed, 14 Feb 2018 15:14:49 +0000 (16:14 +0100)]
[TASK] Hide "Group by page" if only one page is shown in EXT:belog

It is unnecessary to show the "Group by page" checkbox if "This page" is
selected in the "Depth" dropdown.
Thus, the checkbox is hidden in that case.

Resolves: #83896
Releases: master, 8.7
Change-Id: Idd3e0252c6bb06d2442ed4db95056e1e6d292c6c
Reviewed-on: https://review.typo3.org/55729
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[TASK] Update typo3/testing-framework 09/55709/3
Christian Kuhn [Tue, 13 Feb 2018 21:59:38 +0000 (22:59 +0100)]
[TASK] Update typo3/testing-framework

Raise from 2.0.3 to 2.0.4 in master and
from 1.2.2 to 1.2.3 in v8. Brings a patch
to hopefully stabilize acceptance tests again.

composer command used:
composer update typo3/testing-framework

Change-Id: I87d5a65b52bca6eceae805c5edbb13c7eccd1010
Resolves: #83887
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55709
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Handle settings for report / check in linkvalidator 04/55704/2
Thorben Nissen [Thu, 27 Apr 2017 08:13:03 +0000 (10:13 +0200)]
[BUGFIX] Handle settings for report / check in linkvalidator

The level and link type checkmark options are now handled seperately
for the "Report" and "Check Links" tab. This way, the options can
be changed independantly on each tab.

Resolves: #81035
Releases: master, 8.7
Change-Id: I772f885940791a17269c413185d3bea46695ff19
Reviewed-on: https://review.typo3.org/55704
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Add missing htmlspecialchars() calls and cleanup in QueryView 98/55698/5
Stephan Großberndt [Sat, 16 Dec 2017 12:41:21 +0000 (13:41 +0100)]
[BUGFIX] Add missing htmlspecialchars() calls and cleanup in QueryView

Add missing htmlspecialchars() calls in
EXT:core/Classes/Database/QueryView.php and do cleanup.

Resolves: #83354
Releases: master, 8.7
Change-Id: I71c463e1a2912aa20535c7a1bbc0c690560f7e63
Reviewed-on: https://review.typo3.org/55698
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[TASK] Use hash_equals for timing-safe comparison of hash-values 98/55098/2
Stefan Neufeind [Fri, 15 Dec 2017 16:18:27 +0000 (17:18 +0100)]
[TASK] Use hash_equals for timing-safe comparison of hash-values

To prevent timing-attacks on hash-comparions it is advised
to use hash_equals.

Resolves: #83329
Releases: master, 8.7
Change-Id: I7539ed27538d7d81767bfce582d568cff09d1610
Reviewed-on: https://review.typo3.org/55098
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Fix backend user check in ProductionExceptionHandler 91/55691/2
Benjamin Franzke [Mon, 12 Feb 2018 20:49:40 +0000 (21:49 +0100)]
[BUGFIX] Fix backend user check in ProductionExceptionHandler

Uncaught Error: Call to a member function isBackendUserLoggedIn() on null
in […]/typo3/sysext/core/Classes/Error/ProductionExceptionHandler.php:103

Change-Id: I0052c2c1cd617282dbc65320933f8577038ab41c
Releases: master, 8.7
Resolves: #83867
Reviewed-on: https://review.typo3.org/55691
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[BUGFIX] Catch __PHP_Incomplete_Class classes 86/55686/2
Frank Naegler [Mon, 12 Feb 2018 18:08:11 +0000 (19:08 +0100)]
[BUGFIX] Catch __PHP_Incomplete_Class classes

Resolves: #66587
Releases: master, 8.7
Change-Id: I444c818e9f81d3595ca68513800c85d9f993f9b4
Reviewed-on: https://review.typo3.org/55686
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Show hidden translated record only once in clipboard 84/55684/2
Łukasz Uznański [Thu, 30 Nov 2017 10:23:25 +0000 (11:23 +0100)]
[BUGFIX] Show hidden translated record only once in clipboard

Right now, when user in workspace move element with translation
to the clipboard, translation is rendered twice in clipboard.
This bugfix prevents this behaviour.

Resolves: #82804
Releases: master, 8.7
Change-Id: I21a38800d2d5474650f8220340621841cb33f852
Reviewed-on: https://review.typo3.org/55684
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Updated class name in scheduler docs 83/55683/2
Michael Oehlhof [Sun, 17 Dec 2017 23:34:48 +0000 (00:34 +0100)]
[BUGFIX] Updated class name in scheduler docs

Resolves: #66587
Releases: master, 8.7
Change-Id: If5fbb4df430aeb08122cc0713167a8cc464e6d55
Reviewed-on: https://review.typo3.org/55683
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Use native array_replace_recursive implementation 80/55680/2
Ralf Zimmermann [Mon, 29 Jan 2018 13:56:45 +0000 (14:56 +0100)]
[TASK] Use native array_replace_recursive implementation

The custom implementation of array_replace_recursive in YamlSource
has been replaced with the native PHP version of the same method.

Resolves: #83860
Releases: master, 8.7
Change-Id: Ibc0c9ea55e7a510b84c39689890f51bfa01ebafa
Reviewed-on: https://review.typo3.org/55680
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
15 months ago[BUGFIX] Handle Guzzle exceptions in linkvalidator 78/55678/2
Sybille Peters [Sun, 11 Feb 2018 18:10:10 +0000 (19:10 +0100)]
[BUGFIX] Handle Guzzle exceptions in linkvalidator

* The Guzzle exceptions are handled in order to produce better,
  localized error messages in the Report
* Add a new language key for "Network error"

Resolves: #83611
Releases: master, 8.7
Change-Id: I6480c349cbc3325315f25187df56a4914922e463
Reviewed-on: https://review.typo3.org/55678
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Use `file.identifier` in search result of filelist 77/55677/2
Andreas Fernandez [Sun, 11 Feb 2018 18:49:08 +0000 (19:49 +0100)]
[BUGFIX] Use `file.identifier` in search result of filelist

The search results of the filelist access the property
`file.combinedIdentifier`. The property is not available anymore, so this
patch uses `file.identifier`, which maps to `FileFacade::identifier()`
and returns a handcrafted combined identifier.

Resolves: #83849
Releases: master, 8.7
Change-Id: I98bcd9e40c9fdebddf1079ad0240a1d3f6ac8d6e
Reviewed-on: https://review.typo3.org/55677
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Skip test for Yaml PHP extension if not loaded 76/55676/2
Susanne Moog [Mon, 12 Feb 2018 11:17:50 +0000 (12:17 +0100)]
[TASK] Skip test for Yaml PHP extension if not loaded

Resolves: #83861
Releases: master, 8.7
Change-Id: I235e5e37405b264ce071c8d6ecb2b0c13f64357c
Reviewed-on: https://review.typo3.org/55676
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Make it possible to translate selectMultipleSideBySide 74/55674/2
Manuel Selbach [Thu, 8 Feb 2018 17:51:43 +0000 (18:51 +0100)]
[BUGFIX] Make it possible to translate selectMultipleSideBySide

For the default language it was possible to view the field, but on
translating the dataset, the following exception is thrown:
'PHP Warning: Invalid argument supplied for foreach() in
backend/Classes/Form/Element/SelectMultipleSideBySideElement.php line 66'

As the defaultLanguageRow keeps to be "unparsed", the $selectedItems
could be a comma separated string within the method
TYPO3\CMS\Backend\Form\Element\SelectMultipleSideBySideElement::renderReadOnly
if the TCA configuration of a field is set to 'defaultAsReadonly'.

Resolves: #77155
Releases: master, 8.7, 7.6
Change-Id: Id9380fe3761e683352166565ed1a7e56f5e64190
Reviewed-on: https://review.typo3.org/55674
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] EXT:filelist Fixed exception when the base path does not exists 36/55636/2
Michael Oehlhof [Sun, 28 Jan 2018 16:26:30 +0000 (17:26 +0100)]
[BUGFIX] EXT:filelist Fixed exception when the base path does not exists

Resolves: #79785
Releases: master, 8.7
Change-Id: I50cf03273747b1fa32a1f8e4aac993a3fbc7b7f0
Reviewed-on: https://review.typo3.org/55636
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[BUGFIX] Set default values in TCA of sys_file_collection 65/55665/2
Andreas Fernandez [Fri, 9 Feb 2018 21:18:21 +0000 (22:18 +0100)]
[BUGFIX] Set default values in TCA of sys_file_collection

Resolves: #83838
Releases: master, 8.7
Change-Id: I3f27f3e610fd4eae7ac37349a0cf4ff03faa1189
Reviewed-on: https://review.typo3.org/55665
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
15 months ago[BUGFIX] HTML5: use self-closing tags only if allowed 64/55664/2
Esteban Marín [Wed, 30 Nov 2016 14:57:05 +0000 (15:57 +0100)]
[BUGFIX] HTML5: use self-closing tags only if allowed

For HTML5 only certain HTML tags are allowed to be self-closing
(e.g. <img src="..." />), so this needs to be checked when
parsing HTML.

Resolves: #78844
Releases: master, 8.7
Change-Id: If2a319fa83a4baf7d78559aa23ce34903d42d342
Reviewed-on: https://review.typo3.org/55664
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
15 months ago[BUGFIX] Fix quoting and cleanup in AdminPanelView 63/55663/2
Stephan Großberndt [Sat, 16 Dec 2017 13:03:13 +0000 (14:03 +0100)]
[BUGFIX] Fix quoting and cleanup in AdminPanelView

In EXT:frontend/Classes/View/AdminPanelView.php add missing
htmlspecialchars() calls, remove unnecessary ones, add quoteJSvalues()
and do cleanup.

Resolves: #83357
Releases: master, 8.7
Change-Id: Ib546bcfaebf5342e187f8b707a9091947a97ca72
Reviewed-on: https://review.typo3.org/55663
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] EXT:form - fix clicks on checkbox labels in IE/Edge 61/55661/2
Benni Mack [Sat, 10 Feb 2018 22:21:39 +0000 (23:21 +0100)]
[BUGFIX] EXT:form - fix clicks on checkbox labels in IE/Edge

Add the "for" attribute to help Internet Explorer and Edge to target
the actual checkbox field, not the hidden field in front of it.

Resolves: #83417
Releases: master, 8.7
Change-Id: I603f95fc18df57f64d5dde8aefe6338c47b29536
Reviewed-on: https://review.typo3.org/55661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] Fix flaky Acceptance Tests 60/55660/2
Anja Leichsenring [Fri, 9 Feb 2018 19:45:39 +0000 (20:45 +0100)]
[TASK] Fix flaky Acceptance Tests

The current default timeout to wait for elements is 10 seconds.
Turn up to 30 sec to stabilize the situation.

Resolves: #83836
Releases: master, 8.7
Change-Id: I2dd6cbe14a7d05cfe3cf6f7ad3437e0b235c96f1
Reviewed-on: https://review.typo3.org/55660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Respect TSconfig option showHistory 58/55658/3
Tymoteusz Motylewski [Sat, 10 Feb 2018 21:39:48 +0000 (22:39 +0100)]
[BUGFIX] Respect TSconfig option showHistory

The TSconfig `options.showHistory` is not respected inside the core.
Add checks for list view and context menu.

Inside EditDocumentController the "Record History"
button is being rendered twice but the TSconfig
condition is only checked once.

Resolves: #79128
Releases: master, 8.7
Change-Id: Ifa884be5882772e8c267a7eb8036c53cf987bcfb
Reviewed-on: https://review.typo3.org/55658
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
15 months ago[BUGFIX] Fix RTE CKEditor placements of dropdowns in Chrome 57/55657/2
Benjamin Franzke [Sat, 10 Feb 2018 12:26:50 +0000 (13:26 +0100)]
[BUGFIX] Fix RTE CKEditor placements of dropdowns in Chrome

When used with the Chrome browser, the RTE CKEditor misplaces the
position of its dropdowns/context menus (opened via right-click)
when the viewport is scrolled. CKEditor calculates the offset relative
to the <body> and assumes <body> is as long as the content and that
the scrollbar is placed on <html> (both browser defaults).
As the TYPO3 backend uses 'overflow:auto' on <body> and 'overflow: hidden'
on <html> these assumptions conflict: Once the calculated offset exceeds
the <body> height (due tue scrolling) the chrome browser scrols up.

We now move the vertical scollbar into .module-body which implicitly
fixes the CKEditor offset calculation: The calculated menu offsets are
now relative to <body> (as assumed by CKEditor) and the scroll issues
disappear as we removed the scroll bar from <body>.

Resolves: #80116
Resolves: #82780
Releases: master, 8.7
Change-Id: I0481d4aaac1068577c9bad39e607486533ad4b6c
Reviewed-on: https://review.typo3.org/55657
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
15 months ago[TASK] Update UC in recycler only once per action 55/55655/3
Andreas Fernandez [Fri, 9 Feb 2018 23:36:15 +0000 (00:36 +0100)]
[TASK] Update UC in recycler only once per action

The UC of a backend user is now updated only once per request, if there
are actual changes.

Resolves: #83839
Releases: master, 8.7
Change-Id: I859f8b2cc94b6254251ecf639222201cbf57f1ad
Reviewed-on: https://review.typo3.org/55655
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Correct horizontal scrolling in iframe on iOS browsers 53/55653/2
Benjamin Kott [Sat, 10 Feb 2018 15:49:31 +0000 (16:49 +0100)]
[BUGFIX] Correct horizontal scrolling in iframe on iOS browsers

Browsers on iOS are ignoring the width property for iframes,
this resulted in iframes beeing rendered too wide and prevented
scrolling on the horizontal axis.

Resolves: #83841
Releases: master, 8.7
Change-Id: I825d6f911959fdb588f1f164f0ec4bbbf5c067c0
Reviewed-on: https://review.typo3.org/55653
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
15 months ago[BUGFIX] Fix false icons widths in FormEngine IconSelect 48/55648/2
Mathias Schreiber [Sat, 10 Feb 2018 11:01:52 +0000 (12:01 +0100)]
[BUGFIX] Fix false icons widths in FormEngine IconSelect

The width of Icons in TCA selects adjusted in https://review.typo3.org/c/55568/
has been corrected to have Icons use their proper width (128px) again.

Resolves: #83840
Releases: master, 8.7
Change-Id: Ia1e6dee77012b772c3fd5cae7199b075c66389d7
Reviewed-on: https://review.typo3.org/55648
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
15 months ago[BUGFIX] Show active state for SelectIcons 40/55640/2
Georg Ringer [Tue, 6 Feb 2018 02:42:36 +0000 (03:42 +0100)]
[BUGFIX] Show active state for SelectIcons

Highlight the selected icon. This useful feature has been
removed with the FormEngine rewrite.

Resolves: #83781
Releases: master, 8.7
Change-Id: I06376b073585d39d14de6f40bd02172168425944
Reviewed-on: https://review.typo3.org/55640
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Fix typo in field description SYS:ddmmyy 33/55633/2
Reiner Teubner [Fri, 9 Feb 2018 18:35:25 +0000 (19:35 +0100)]
[BUGFIX] Fix typo in field description SYS:ddmmyy

'Date' should be 'Day'.

Resolves: #83829
Related: master, 8.7
Change-Id: If422279d147598b02e342a00f3ebcbb3d3f26723
Reviewed-on: https://review.typo3.org/55633
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[TASK] Resolve Todos in InheritancesResolverService 23/55623/2
rschueppel [Wed, 6 Dec 2017 16:44:00 +0000 (17:44 +0100)]
[TASK] Resolve Todos in InheritancesResolverService

Add some comments to understand InheritanceResolverService class.
Minor refactoring of duplicated code.
Add Test for the doc example.

Resolves: #83238
Releases: master, 8.7
Change-Id: I3aed06a76b609ef78641530a19e3379f202c84ec
Reviewed-on: https://review.typo3.org/55623
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Allow silent upgrade service to migrate old displayErrors setting 20/55620/3
Wouter Wolters [Thu, 8 Feb 2018 21:11:20 +0000 (22:11 +0100)]
[BUGFIX] Allow silent upgrade service to migrate old displayErrors setting

The bootstrap throws an exception when the setting SYS/displayErrors
is not set to "-1", "0" or "1". In the Install Tool TYPO3 should not crash.
Instead allow to silently migrate the value to -1

Resolves: #82782
Resolves: #83787
Releases: master,8.7
Change-Id: Ie0180b34a551a81667bb4ac32c6ab2699d9b3d4f
Reviewed-on: https://review.typo3.org/55620
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Allow workspace preview inside another rootline 13/55613/3
Alexander Opitz [Fri, 12 Jan 2018 16:08:07 +0000 (17:08 +0100)]
[BUGFIX] Allow workspace preview inside another rootline

The rootline for page view now depends on the webmounts of the workspace
the preview link was generated on and not the webmounts the beuser, who
generated the preview link, is at the moment of calling the preview
link.

Resolves: #83547
Releases: master, 8.7
Change-Id: I53c8d45260b79c4d5679f00084fe81b502668ee7
Reviewed-on: https://review.typo3.org/55613
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[TASK] Improve file overwriting dialog of the filelist module 09/55609/2
Gianluigi Martino [Fri, 22 Dec 2017 13:44:30 +0000 (14:44 +0100)]
[TASK] Improve file overwriting dialog of the filelist module

- Remove grey background box
- Move buttons on the same row
- Better position for alternatively actions
- Some margins for better positions

Resolves: #82838
Releases: master, 8.7
Change-Id: I2fc1323d8c9acdfbb2b99b3af36e10bd5ea8a7f6
Reviewed-on: https://review.typo3.org/55609
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[BUGFIX] Fix unset bits in options.alertPopup bitmask 04/55604/2
Mathias Brodala [Fri, 14 Oct 2016 08:29:27 +0000 (10:29 +0200)]
[BUGFIX] Fix unset bits in options.alertPopup bitmask

The validation in JsConfirmation did not allow for a value
based on JsConfirmation:ALL with some bits unset.

Change-Id: I74d43d59ee3cd06498bbebd6b7b7682ca1d79cd5
Resolves: #78240
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55604
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[TASK] Improve prevention of redirect loop 90/55590/2
Christoph Lehmann [Thu, 7 Sep 2017 20:24:17 +0000 (22:24 +0200)]
[TASK] Improve prevention of redirect loop

This prevents a redirect loop with realurl where an editor
doesn't see the pagetree of his login domain in his workspace
and opens his login domain in the FE. As result he sees the
requested page.

Resolves: #82297
Releases: master, 8.7
Change-Id: Ie948f6defa21e3e1d8766533f54a48769d2220c9
Reviewed-on: https://review.typo3.org/55590
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[TASK] Set TYPO3 version to 8.7.11-dev 72/55572/2
Oliver Hader [Tue, 6 Feb 2018 10:47:25 +0000 (11:47 +0100)]
[TASK] Set TYPO3 version to 8.7.11-dev

Change-Id: Iae0fa0d5726f831c0025aaad3cb21286e0d3c41b
Reviewed-on: https://review.typo3.org/55572
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[RELEASE] Release of TYPO3 8.7.10 71/55571/2 8.7.10 TYPO3_8-7-10 v8.7.10
Oliver Hader [Tue, 6 Feb 2018 10:45:45 +0000 (11:45 +0100)]
[RELEASE] Release of TYPO3 8.7.10

Change-Id: Idfb7eea72c6e2b825227c19211664e8b7d823201
Reviewed-on: https://review.typo3.org/55571
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Replace calls to the deprecated PHP function each() 69/55569/2
Reiner Teubner [Wed, 31 Jan 2018 14:30:21 +0000 (15:30 +0100)]
[BUGFIX] Replace calls to the deprecated PHP function each()

This patch replaces the calls to the PHP function each() as it is
marked as deprecated in PHP 7.2. Additionally it adds unit tests for
QueryGenerator::getSubscript().

Resolves: #83737
Releases: master, 8.7, 7.6
Change-Id: Ie61a6d44fcdbd4ce6105a6c185085a3a68866fd8
Reviewed-on: https://review.typo3.org/55569
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Prevent enforcing opened database connection with initCommands 58/55558/5
Nicole Cordes [Sun, 4 Feb 2018 11:20:05 +0000 (12:20 +0100)]
[BUGFIX] Prevent enforcing opened database connection with initCommands

This patch moves the execution of configured initCommands to the end
of connect function. This prevents a database connection from being
opened by default due to the execution of commands right after class
initialization and still ensures a connection is configured properly
before first command execution.

Furthermore this patch adds a new functional test for the ErrorHandler.
The test uses some predefined initCommands to enforce UTF8 support to be
set. This isn't necessary but uses initCommands in a safe way. Due to
the predefined initCommands the test failed before as the connection was
forced to be opened. For further information see the referenced forge
ticket.

Resolves: #83770
Releases: master, 8.7
Change-Id: I2287600959b3ec06d338e26373562850307ce0b1
Reviewed-on: https://review.typo3.org/55558
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
15 months ago[BUGFIX] Only scan package base paths if subdirectories exist 67/55567/3
Michael Oehlhof [Sun, 10 Dec 2017 21:58:46 +0000 (22:58 +0100)]
[BUGFIX] Only scan package base paths if subdirectories exist

Include possible package base paths only if subdirectories are available.
Otherwise no extension can be found in the base path anyway.

Resolves: #83070
Releases: master, 8.7
Change-Id: I503623c607554a60bd144c83e3f69e78fe5a7ea0
Reviewed-on: https://review.typo3.org/55567
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Add missing DOM ready checks in filelist 64/55564/3
Frank Naegler [Wed, 17 Jan 2018 22:43:50 +0000 (23:43 +0100)]
[BUGFIX] Add missing DOM ready checks in filelist

Some modules in the filelist are missing DOM ready checks.
This patch adds the missing checks to prevent loading issues.

Resolves: #78976
Releases: master, 8.7
Change-Id: Iee328808a89cf92f4fde1afd59167ae9fa7280be
Reviewed-on: https://review.typo3.org/55564
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
15 months ago[BUGFIX] Forward header in DebugUtility:debug to renderDump 66/55566/2
Georg Ringer [Sun, 28 Jan 2018 11:37:17 +0000 (12:37 +0100)]
[BUGFIX] Forward header in DebugUtility:debug to renderDump

Improve the debug output by forwarding the given title.

Resolves: #83688
Releases: master, 8.7
Change-Id: I160b5676c5ff70c056319446733c9549a663569a
Reviewed-on: https://review.typo3.org/55566
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] Allow dev branch install of subtree split packages 44/55444/3
Helmut Hummel [Wed, 24 Jan 2018 12:03:46 +0000 (13:03 +0100)]
[BUGFIX] Allow dev branch install of subtree split packages

To make it possible to require subtree split packages
as a dev 8.7.*@dev versions, we need to adapt the
dependencies of the packages.

For a release these dependencies will be set to
exact version numbers before tagging.

Branch aliases in the packages can be removed,
as the TYPO3_8-7 branch does not exist in the
splitted repos, but only a 8.7 branch.

Resolves: #83671
Releases: 8.7
Change-Id: I2784123f596409b720a090276c4314fd1a1c4a63
Reviewed-on: https://review.typo3.org/55444
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
15 months ago[BUGFIX] EXT:form - fix array overrules within YAML preprocessing 65/55565/2
Ralf Zimmermann [Mon, 29 Jan 2018 13:56:45 +0000 (14:56 +0100)]
[BUGFIX] EXT:form - fix array overrules within YAML preprocessing

If you use the "__inheritance" operator within an EXT:form configuration
file, configuration keys of the parent element can be deleted in the
child element by giving the configuration key in the child element
the value NULL.
See https://docs.typo3.org/typo3cms/extensions/form/latest/Concepts/
Configuration/Index.html#inheritances for further information.

Before the "__inheritance" operators are executed, all configuration
files are merged using
TYPO3\CMS\Core\Utility\ArrayUtility::mergeRecursiveWithOverrule().

However, this does not work if you are using several configuration files.

Let's assume the configuration key in the previous configuration file is
an array. mergeRecursiveWithOverrule() does not delete this
configuration key, if the configuration key in the overriding
configuration file is not an array (for example: NULL). This is simply
ignored by mergeRecursiveWithOverrule().

This patch fixes this issue by adding a variation of
array_merge_recursive().

Resolves: #82051
Releases: master, 8.7
Change-Id: Id9d256226a3eb82f6bc3fd03904f944719e525e7
Reviewed-on: https://review.typo3.org/55565
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Add language parameter to preview url in list module 52/55452/5
Gianluigi Martino [Mon, 3 Apr 2017 14:18:22 +0000 (16:18 +0200)]
[BUGFIX] Add language parameter to preview url in list module

The language parameter was not set if the "View webpage" button was used
within the context menu of an element in the page module or the
"View webpage" button in the record list of a desired language.

Resolves: #80599
Releases: master, 8.7
Change-Id: I40fb5749cbd56c0075a8aa2c5ec3b2d8dea66501
Reviewed-on: https://review.typo3.org/55452
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] EXT:form - add compatibility for issue #82210 06/55306/5
Ralf Zimmermann [Tue, 9 Jan 2018 13:07:14 +0000 (14:07 +0100)]
[BUGFIX] EXT:form - add compatibility for issue #82210

The fix for issue #82210 implies a breaking change within a minor
release (template changes) and was never documented.

This bugfix adds some compatibility code for integrators who are using
their own templates for RadioButton and/ or MultiCheckbox form elements.

In addition, a deprecation warning is thrown and the corresponding rst
file has been added.

A different patchset adds the appropriate breaking rst file for v9.

Resolves: #83403
Related: #82210
Releases: 8.7
Change-Id: I496886631b4506f2a370cc56473de414d4c3f359
Reviewed-on: https://review.typo3.org/55306
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] EXT:form - handle boolean finisher options 90/54990/8
Ralf Zimmermann [Thu, 28 Sep 2017 07:53:05 +0000 (09:53 +0200)]
[BUGFIX] EXT:form - handle boolean finisher options

Properly store boolean form definition values. Also
boolean finisher options are returned as boolean now.

Resolves: #82569
Releases: master, 8.7
Change-Id: I1eee0c6d8eaf07534d31622025f3c954d608627b
Reviewed-on: https://review.typo3.org/54990
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[TASK] Apply code formating for all JavaScript files 22/55522/6
Frank Naegler [Thu, 1 Feb 2018 14:49:17 +0000 (15:49 +0100)]
[TASK] Apply code formating for all JavaScript files

This is the first step for introduce CGL for JavaScript files.
The settings of the .editorconfig file is now applied to all
JavaScript files. This will prevent merge conflicts for the
next patches.

Resolves: #83752
Releases: master, 8.7
Change-Id: Ie84691e7f7f3a3974f3c62133895a62377b22f67
Reviewed-on: https://review.typo3.org/55522
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Page module: Respect connected mode during drag & drop 61/55561/2
Andreas Fernandez [Thu, 25 Jan 2018 09:20:11 +0000 (10:20 +0100)]
[BUGFIX] Page module: Respect connected mode during drag & drop

This patch adjusts the drag and drop handling on the page module.
Localized content element can't get moved anymore when they are in
connected mode. Languages without a `l18n_parent` may be freely
moved.

Resolves: #83470
Related: #66540
Releases: master, 8.7
Change-Id: I7dcb61279d4bfeb094dcb0e2fbffd416da9c787b
Reviewed-on: https://review.typo3.org/55561
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[TASK] Update typo3fluid/fluid to 2.5.0 55/55555/5
Christian Kuhn [Sun, 4 Feb 2018 20:09:20 +0000 (21:09 +0100)]
[TASK] Update typo3fluid/fluid to 2.5.0

Fixes various issues, brings PHP 7.2 compatibility
to v8 core branch of standalone fluid.

composer command used:
composer update typo3fluid/fluid

Change-Id: I52c3a97e7dc8dafd7b0dee1e07df5105f29cdbde
Resolves: #83774
Resolves: #82227
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55555
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] D3.js uses basic authentication credentials cached in browser 59/55559/4
Tymoteusz Motylewski [Fri, 2 Feb 2018 16:15:57 +0000 (17:15 +0100)]
[BUGFIX] D3.js uses basic authentication credentials cached in browser

Chrome 64 changed the behaviour regarding xhr.open() calls when passing
null values as password and username.
The d3.js file is manually patched.
Once PR https://github.com/d3/d3-request/pull/34/files is merged we can
use official d3.js version again.

Resolves: #83741
Releases: master, 8.7
Change-Id: I9b83d953ecd19afb9fa5039e1782d094111b0125
Reviewed-on: https://review.typo3.org/55559
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Marco Huber <mail@marco-huber.de>
Tested-by: Marco Huber <mail@marco-huber.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
15 months ago[BUGFIX] Add possibility to use session data in TS conditions 57/55557/2
Wolfgang Klinger [Tue, 9 Jan 2018 19:17:56 +0000 (20:17 +0100)]
[BUGFIX] Add possibility to use session data in TS conditions

Bring back the possibility to access FE session data in
TypoScript conditions:
[globalVar = TSFE:fe_user|sesData|some_key > 10]

Resolves: #83506
Releases: master, 8.7
Change-Id: I77f6bc73a6d9160b7074d39a948e94a59b51e521
Reviewed-on: https://review.typo3.org/55557
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
15 months ago[BUGFIX] Catch InvalidPathException for FileStorages 52/55552/3
Mathias Schreiber [Sun, 4 Feb 2018 16:06:12 +0000 (17:06 +0100)]
[BUGFIX] Catch InvalidPathException for FileStorages

Editing faulty FileStorages is possible again due to catching the
respective exception and piping it into a FlashMessage

Resolves: #83762
Releases: master, 8.7
Change-Id: I5081d86fd73076359b1d9eba954ba07c50bcb7b2
Reviewed-on: https://review.typo3.org/55552
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Re-apply colorspace to resulting image 54/55554/2
Stefan Neufeind [Mon, 28 Nov 2016 10:33:30 +0000 (11:33 +0100)]
[BUGFIX] Re-apply colorspace to resulting image

When using filters the colorspace is not always applied.
A quickfix is to add the colorspace-setting again before
writing the output-image.
Multiple colorspace-settings on the commandline will be
executed in order. For example the grayscale-filter uses
"-colorspace GRAY". The final output-image can then be
converted to "-colorspace sRGB" again so the brightness
appears correct (not too dark) again.

Resolves: #78816
Releases: master, 8.7
Change-Id: I3fcabf8fdbb8d43f15662532b881501ebb43b1dd
Reviewed-on: https://review.typo3.org/55554
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Provide Foldername in InaccessibleException 53/55553/2
Mathias Schreiber [Sat, 3 Feb 2018 22:17:37 +0000 (23:17 +0100)]
[BUGFIX] Provide Foldername in InaccessibleException

The central InsufficientFolderReadPermissionsException now
displays the name of the folder in question to ease tracing down
errors.

Resolves: #82342
Releases: master, 8.7
Change-Id: I968c74e6b2e210b07964f7ebb141155525c26ee5
Reviewed-on: https://review.typo3.org/55553
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
15 months ago[BUGFIX] Allow users without delete permissions to drag pages in page tree 65/54965/4
Tymoteusz Motylewski [Thu, 7 Dec 2017 13:46:48 +0000 (14:46 +0100)]
[BUGFIX] Allow users without delete permissions to drag pages in page tree

BE users without delete rights can now drag-drop pages in the page tree.
The drag - delete area is not shown.

Resolves: #25135
Releases: 8.7, 7.6
Change-Id: Icc82675a783f19ae72b6d00ac2809ad76b93dd67
Reviewed-on: https://review.typo3.org/54965
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Timo Pfeffer <pfeffer.timo+typo3@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
15 months ago[BUGFIX] Fix "Select & upload files" button for FAL in flexform 20/55520/2
Armin Vieweg [Thu, 1 Feb 2018 09:20:15 +0000 (10:20 +0100)]
[BUGFIX] Fix "Select & upload files" button for FAL in flexform

Fix regular expression in escapeCssSelector method, to convert
e.g. "." to "\.".

Resolves: #83747
Branches: master, 8.7
Change-Id: I0fe19fb3590e28cafce6e2fd0cbf9a63f4375954
Reviewed-on: https://review.typo3.org/55520
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
15 months ago[TASK] Show language mode in Page module 75/55475/2
Mathias Schreiber [Fri, 26 Jan 2018 18:43:23 +0000 (19:43 +0100)]
[TASK] Show language mode in Page module

Editors can now immediately see whether a page is in Free, Connected or
Mixed mode in a certain language.

Resolves: #83696
Releases: master, 8.7
Change-Id: I2985c2094e83535df636fa124aea962aa7ca105d
Reviewed-on: https://review.typo3.org/55475
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
15 months ago[FOLLOWUP][BUGFIX] Remove uglify of jquery-ui/sortable.js 18/55518/2
Frank Naegler [Thu, 1 Feb 2018 10:32:01 +0000 (11:32 +0100)]
[FOLLOWUP][BUGFIX] Remove uglify of jquery-ui/sortable.js

This patch removes the uglify task of jquery-ui/sortable.js.
With https://review.typo3.org/#/c/55389/ the lib was patched
and already uglified. This patch prevents a double uglify of the file.

Resolves: #83593
Releases: master, 8.7
Change-Id: I16edd94fc8d3165159b4dc0a47ac7365ff34e37f
Reviewed-on: https://review.typo3.org/55517
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-on: https://review.typo3.org/55518
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
15 months ago[BUGFIX] Change documentation of [BE][interfaces] 82/55482/2
Susanne Moog [Sun, 28 Jan 2018 18:14:04 +0000 (19:14 +0100)]
[BUGFIX] Change documentation of [BE][interfaces]

The order of the options given is irrelevant as
they will always be rendered in the same order.

The documentation was updated to reflect that fact.

Change-Id: I409e8a26a3b1186a12761cbb84a4f6afe94b464b
Resolves: #82431
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55482
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
15 months ago[BUGFIX] Fix example code for TCA "fieldControl" 02/55502/2
Stephan Großberndt [Tue, 30 Jan 2018 14:22:13 +0000 (15:22 +0100)]
[BUGFIX] Fix example code for TCA "fieldControl"

Resolves: #83732
Releases: master, 8.7
Change-Id: I7dccb42445dba584ed1c9a814f62525335d26ab1
Reviewed-on: https://review.typo3.org/55502
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
15 months ago[BUGFIX] Avoid JS error when using 'eval' => 'int,nospace' in TCA 03/55503/2
Stephan Großberndt [Tue, 30 Jan 2018 11:12:43 +0000 (12:12 +0100)]
[BUGFIX] Avoid JS error when using 'eval' => 'int,nospace' in TCA

By casting the JavaScript variable to string this patch avoids an error
if 'eval' => 'int,nospace' is used in a TCA column definition.

Resolves: #83731
Releases: master, 8.7
Change-Id: I5be79bf6cd748ac184505f0aa4bd97c7d934eebd
Reviewed-on: https://review.typo3.org/55503
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
15 months ago[BUGFIX] Invalid session token on creating content element in admin panel 89/55489/2
Oliver Hader [Mon, 29 Jan 2018 15:42:27 +0000 (16:42 +0100)]
[BUGFIX] Invalid session token on creating content element in admin panel

When creating a new content element in the frontend using the according
button in the "editing" section of the admin panel, the request to the
TYPO3 backend is rejected due to an invalid XSRF session token:

Validating the security token of this form has failed.
Please reload the form and submit it again.

The reason is, that the URL after issue #70055 looks like the following
"token=<hash>id=<id>" instead of "token=<hash>&id=<id>" - the id became
part of the XSRF session token.

Resolves: #83719
Releases: master, 8.7, 7.6
Change-Id: Ibdd252b2e59d9e8de78bb0be14a95e0789dc0d17
Reviewed-on: https://review.typo3.org/55489
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Properly check serialized_executions to avoid PHP 7.2 warnings 83/55483/3
Georg Ringer [Sun, 28 Jan 2018 11:42:17 +0000 (12:42 +0100)]
[BUGFIX] Properly check serialized_executions to avoid PHP 7.2 warnings

To avoid warnings with PHP 7.2, `serialized_executions` must be checked
for being not an empty value.

Resolves: #83691
Releases: master, 8.7, 7.6
Change-Id: I5855a03d6669ec0e82931cfc0110c2b7ca134ad4
Reviewed-on: https://review.typo3.org/55483
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
15 months ago[BUGFIX] Add missing htmlspecialchars() and cleanup in EXT:recordlist 19/55219/4
Stephan Großberndt [Thu, 28 Dec 2017 03:06:40 +0000 (04:06 +0100)]
[BUGFIX] Add missing htmlspecialchars() and cleanup in EXT:recordlist

Add missing htmlspecialchars() calls in EXT:recordlist and do cleanup.

Resolves: #83358
Releases: master, 8.7
Change-Id: If441da15bd0b37ca94121b3787457dddde9380bf
Reviewed-on: https://review.typo3.org/55219
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[TASK] Move changing preview processing config to processing service 70/55270/2
Helmut Hummel [Sun, 24 Dec 2017 14:21:49 +0000 (15:21 +0100)]
[TASK] Move changing preview processing config to processing service

Instead of complementing processing configuration in the file class,
move it to the processing service and LocalPreviewHelper class
to not have the code and logic duplicated and to ensure it is
always executed, not only when using the file API.

Resolves: #83421
Related: #81776
Related: #83242
Releases: master, 8.7, 7.6
Change-Id: I9b3f380625756137a56e7ad0ea55d21f47464ab8
Reviewed-on: https://review.typo3.org/55270
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
15 months ago[BUGFIX] Catch DatabaseRecordException when editing record with deleted relation 50/55450/3
Andreas Fernandez [Wed, 24 Jan 2018 15:50:17 +0000 (16:50 +0100)]
[BUGFIX] Catch DatabaseRecordException when editing record with deleted relation

Editing a record with a deleted related record leads to an uncaught
DatabaseRecordException. This patch catches the exception and
ignores such records, but logs a warning.

Due to possible errors occurring with certain DBMS (e.g. MySQL
strict) columns may require a default value now in TCA.

Resolves: #83412
Releases: master, 8.7
Change-Id: I5adaf385443350ce245dd83da6e5f1a16d9c9afb
Reviewed-on: https://review.typo3.org/55450
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
15 months ago[BUGFIX] Only reference existing locallang files 69/55469/2
Daniel Goerz [Fri, 26 Jan 2018 21:36:30 +0000 (22:36 +0100)]
[BUGFIX] Only reference existing locallang files

Resolves: #83698
Releases: master, 8.7
Change-Id: I7bfe3c32c5fec6e7098462dcbe0353afd9258900
Reviewed-on: https://review.typo3.org/55469
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
15 months ago[BUGFIX] Set correct PHPDoc hint for addPageTSConfig and addUserTSConfig 59/55459/2
Frans Saris [Fri, 26 Jan 2018 09:02:46 +0000 (10:02 +0100)]
[BUGFIX] Set correct PHPDoc hint for addPageTSConfig and addUserTSConfig

Resolves: #83687
Releases: master, 8.7
Change-Id: Ifa705340bc0523e914c688eea00dbb2812bbedd0
Reviewed-on: https://review.typo3.org/55459
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>