Benjamin Mack [Tue, 12 May 2015 07:07:10 +0000 (15:07 +0800)]
[BUGFIX] Wrong HTML in ModuleMenu main modules
There is one span too many in the module menu after the switch to sprite icons.
The change removes one span tag, but leaves it for the default span tag.
Resolves: #66908
Releases: master
Change-Id: I84f621c5fae4c6739acd1e0254da2702e58ee8b7
Reviewed-on: http://review.typo3.org/39477
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Wouter Wolters [Mon, 11 May 2015 19:30:04 +0000 (21:30 +0200)]
[BUGFIX] Don't use modulemenu classes in topbar
When the startModule setting is empty a strange behaviour
takes place. This happens because the module menu classes are
in use in the topbar too.
Fix this by adding a specific t3js-mainmodule class.
Resolves: #66893
Releases: master
Change-Id: I46768c1f81a2616bd279eacfa5b2e38c863b582e
Reviewed-on: http://review.typo3.org/39461
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Christian Kuhn [Mon, 11 May 2015 16:41:24 +0000 (18:41 +0200)]
[TASK] FormEngine: Simplify element name resolving
Data submitted by FormEngine to DataHandler is prefixed in four
different ways:
* data - Transferred data
* cmd - A dataHandler command to execute
* data_files - Contains uploaded files
* action[control] - Overwrite fields data for NULL handling
These four prefixes are given along from FormEngine to the
whole container and element structure and never change.
To simplify this stuff, the patch removes the prefixes and
hardcodes them, and introduces a new globalOptions
$elementBaseName that contains the stuff behind the prefixes.
Quite some methods can be simplified this way and become
more obvious. Usage of $elementBaseName will be extended
with the next patch.
Change-Id: I8103b1d2068382e0b01bbe5d9bd79aeba2d00b08
Resolves: #66894
Releases: master
Reviewed-on: http://review.typo3.org/39462
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Markus Klein [Mon, 11 May 2015 14:20:58 +0000 (16:20 +0200)]
[TASK] Sane index length for "uid_foreign_tablefield"
The index lengths for the fields "tablenames" and "fieldname"
of table "sys_category_record_mm" are way too big.
It suffices to have only few significant characters in the index.
We only take the first 40 characters of the tablename and the first
three characters of the fieldname as those should already be
distinctive enough to have a high quality index.
Assuming most table names are below 40 characters anyway and usually
only a few fields per table will be a category.
Resolves: #66773
Releases: master
Change-Id: Ib1f077c93425992c557fbc4457699d867521a3ba
Reviewed-on: http://review.typo3.org/39443
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Stefan Froemken <froemken@gmail.com>
Tested-by: Stefan Froemken <froemken@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Christoph Dörfel [Tue, 24 Feb 2015 07:23:28 +0000 (08:23 +0100)]
[BUGFIX] Allow closures in filters methods for directory items
Instead of checking if a given filter is callable a is_array check
is done. But the filter can also be a closure and a is_array would
fail then.
This patch changes the is_array check to is_callable.
Resolves: #65244
Releases: master, 6.2
Change-Id: I1a1e9ce0e789bd36a4fa36e91389e8b62c50116e
Reviewed-on: http://review.typo3.org/37153
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Wouter Wolters [Mon, 4 May 2015 17:00:13 +0000 (19:00 +0200)]
[TASK] Make condition ViewHelper compilable in ext:fluid
Resolves: #66714
Releases: master
Change-Id: If6c2355944405db04b5a6be3972158cc4ed23e05
Reviewed-on: http://review.typo3.org/39264
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Andreas Fernandez [Mon, 11 May 2015 10:44:07 +0000 (12:44 +0200)]
[BUGFIX] Proper use of UserSettingsController in ExtdirectTreeCommands
Use the correct object and it's process() method.
Resolves: #66880
Related: #66868
Releases: master
Change-Id: Ibdfd2734b01c7e4fee89dc66cae853d275b1d4bd
Reviewed-on: http://review.typo3.org/39430
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Georg Ringer [Sat, 9 May 2015 20:16:16 +0000 (22:16 +0200)]
[BUGFIX] Readonly fields must not render links to allowed tables
If a field is configured as readOnly, the allowed tables below
should not be linked to the Element Browser
Change-Id: Ibae0056cd681e0112c715488ea0ff3b13d11ab42
Resolves: #66870
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/39388
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Fabien Udriot [Thu, 5 Feb 2015 17:41:19 +0000 (18:41 +0100)]
[TASK] Display info about registered Extractors in Task "Metadata Extract"
In the context of the Scheduler, the task "Metadata Extract" will have no
effect if no Extractor is registered - which is the by default case.
This quite confusing for the End User since it would expect something
to happen upon running the task.
The solution is to display a message to the End User about the registered
Extractors in the Task itself. In case no Extractor is present, the
message will make it clear that the Task will have no effect.
Change-Id: Id2dff904ca90f3cc182189db57064cf2b6daa574
Resolves: #64884
Releases: master, 6.2
Reviewed-on: http://review.typo3.org/36675
Reviewed-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Tested-by: Fabien Udriot <fabien.udriot@ecodev.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Andreas Fernandez [Sun, 10 May 2015 15:01:49 +0000 (17:01 +0200)]
[TASK] Replace icon for secondary options in RecordList
Replace fa-cog with fa-ellipsis-h.
Resolves: #66875
Releases: master
Change-Id: I767c2f3dc47c99a704ba4de37e53acbf6faea016
Reviewed-on: http://review.typo3.org/39394
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Wouter Wolters [Wed, 6 May 2015 17:44:16 +0000 (19:44 +0200)]
[!!!][TASK] Move usage of BackendUserSettingsDataProvider
Move usage of BackendUserSettingsDataProvider to the new Storage.js
Resolves: #66868
Releases: master
Change-Id: Ibc6d57368ca8ebc8b4e5e026cbaaa5d80d428d1c
Reviewed-on: http://review.typo3.org/39311
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Benjamin Mack [Thu, 7 May 2015 04:49:25 +0000 (12:49 +0800)]
[FEATURE] Allow module menu items to use sprite icons
In the course of the 7.x development, the main modules (web / file etc.)
have received a hard-coded list of fontawesome sprite icons. This way
it is not (easily) possible to override the icons and to give a custom
main module its own custom sprite icon.
A new property in the module configuration "icon" allows now to
hand in a sprite icon instead of a path to png/gif file.
At the same time the property handling for the "icon" property
inside the module menu is now simplified as a string instead
of an array with all additional information as everything is already
compiled together in the BackendModuleRepository.
All main modules shipped with the core now have proper icons
mapped inside ext_tables.php in the core.
Resolves: #66822
Releases: master
Change-Id: If1a62528d9de56034a0330c0051dfcb66e59469c
Reviewed-on: http://review.typo3.org/39316
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Frank Nägler [Sat, 9 May 2015 14:03:51 +0000 (16:03 +0200)]
[TASK] Massive performance improvement for page tree
This patch improves the performance by removing delays.
A single click in the tree loads the page now significantly faster, however,
the page is now loaded also with a doubleclick.
With a tree implementation without ExtJS we can change this behavior again.
Resolves: #63591
Releases: master
Change-Id: I4e32013d2d904e1cc4f91f8c9fa9af165fc8c476
Reviewed-on: http://review.typo3.org/39382
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Andreas Fernandez [Fri, 8 May 2015 11:41:54 +0000 (13:41 +0200)]
[BUGFIX] Fix broken link to anchor
Due to wrong quoting, the links to anchors are broken.
Resolves: #66854
Releases: master, 6.2
Change-Id: I4a52dc6cead27fc499e93618dfaefd824ebd525c
Reviewed-on: http://review.typo3.org/39363
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Nico de Haen [Mon, 3 Mar 2014 13:55:06 +0000 (14:55 +0100)]
[BUGFIX] Show sectionIndex from referenced page
If a page is configured to show content from another pid the menu
of type sectionIndex has to fetch the content elements from the
referenced page instead of the page itself.
Thanks to Christian Finkemeyer for the patch.
Resolves: #46448
Releases: master, 6.2
Change-Id: Ia903cdc085dd665f89df5c90dad962cbc9f09535
Reviewed-on: http://review.typo3.org/27995
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Jan Helke [Sat, 9 May 2015 09:24:38 +0000 (11:24 +0200)]
[TASK] Makes sys_note/EditLinkViewHelper compilable
Resolves: #66867
Releases: master
Change-Id: I30ef465f92589d2fcbf379a32700959735b9a41a
Reviewed-on: http://review.typo3.org/39376
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Jan Helke [Sat, 9 May 2015 09:09:23 +0000 (11:09 +0200)]
[TASK] Makes sys_note/DeleteLinkViewHelper compilable
Resolves: #66866
Releases: master
Change-Id: Ib10e6cca908321d81b3a7aa1919cee0e962fc25e
Reviewed-on: http://review.typo3.org/39375
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Andreas Fernandez [Thu, 7 May 2015 12:27:27 +0000 (14:27 +0200)]
[TASK] Show edit icon on hovering the page title
If an user hovers the page title in "List" or in "Page" module,
show an edit icon next to the page title to indicate an action.
Resolves: #66836
Releases: master
Change-Id: I894c17d89afb30c1594dc20cac3bbdae1b0cfca5
Reviewed-on: http://review.typo3.org/39331
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Wouter Wolters [Thu, 7 May 2015 22:08:04 +0000 (00:08 +0200)]
[TASK] Remove dependency to tab.js in FormEngine
Resolves: #66849
Releases: master
Change-Id: Iad61ca580344c9794d8ad19721c11689fc5a2e16
Reviewed-on: http://review.typo3.org/39347
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Frank Nägler [Fri, 8 May 2015 22:25:21 +0000 (00:25 +0200)]
Revert "[TASK] Change if conditions in LocalizationUtility"
This reverts commit
217954659043ff6ed48a2d5f2e1f6c3207cb9b21.
LocalizationUtility patch breaks labels, see screenshots in
forge issue #66864
Resolves: #66864
Reverts: #63026
Releases: master
Change-Id: I5e5d2209767ef53909fccf0bef2f6fae5d3edafb
Reviewed-on: http://review.typo3.org/39374
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Christian Kuhn [Fri, 8 May 2015 13:26:26 +0000 (15:26 +0200)]
[TASK] FormEngine: Simplify placeholder and NULL handling
FormEngine / DataHandler have logic to distinguish between NULL and
empty strings as values written to the database. This is especially
used for FAL in inline relation together with the placeholder logic.
The patch moves the code around a bit, disentangles the logic and
adds comments to explain the details. The $globalOptions value
parameter "prependFormFieldNamesActive" becomes obsolete along the
way and is dropped.
Change-Id: I854a5733f9b597a28751ed31217858b223441247
Resolves: #66856
Releases: master
Reviewed-on: http://review.typo3.org/39365
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Stefan Froemken [Fri, 14 Nov 2014 18:32:29 +0000 (19:32 +0100)]
[TASK] Change if conditions in LocalizationUtility
With each call to translate we call isFirstPartOfString.
This method is really fast but in case of extensionmanager
it was called over 700 times. This results in 7
milliseconds.
I have changed the if calls to improve performance
Resolves: #63026
Releases: master
Change-Id: I7beff8c49c235aa791c2d08438e5ac92bd7dc883
Reviewed-on: http://review.typo3.org/34266
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Frans Saris [Sun, 29 Mar 2015 11:46:45 +0000 (13:46 +0200)]
[FEATURE] Add TemplateRootPaths support to cObject FLUIDTEMPLATE
cObject FLUIDTEMPLATE is extended with `templateRootPaths` and
`templateName`. Now you can set a template name and when rendering the
template this name is used together with the set format to find the
template in the given templateRootPaths with the same fallback logic as
layoutRootPath and partialRootPath.
Resolves: #66111
Releases: master
Change-Id: I30d7fa63f63f818b5da31194bad1dccce95929e2
Reviewed-on: http://review.typo3.org/38331
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Mathias Brodala [Fri, 17 Apr 2015 15:47:43 +0000 (17:47 +0200)]
[BUGFIX] Fix serializable object creation with PHP 5.6
This makes use of doctrine/instantiator to catch this and many
other PHP issues when instantiating objects without constructor.
Resolves: #66473
Releases: master, 6.2
Change-Id: Iaba0de638b8b555a811dad22a140d0348c168eb5
Reviewed-on: http://review.typo3.org/38765
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Morton Jonuschat [Mon, 27 Apr 2015 10:55:55 +0000 (12:55 +0200)]
[TASK] Add support for SPATIAL index type
Add support for "SPATIAL" keys to the SqlSchemaMigrationService.
Ignoring the subpart/key length for this type of index is required as
MySQL does not support specifying the length when creating/modifying
the index but reports this information when retrieving keys for a
table.
This change has been verified against MySQL 5.5.42 (Mac OS X) as well
as Percona Server 5.6.23 (Release 72.1, Linux).
Resolves: #65354
Releases: master
Change-Id: I2a2d0d1e7eddb6ff8fcfb50d88936669e64ea309
Reviewed-on: http://review.typo3.org/38953
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Jo Hasenau [Thu, 23 Apr 2015 10:07:43 +0000 (12:07 +0200)]
[BUGFIX] Make subheaders aware of possible default header layouts
Releases: master
Resolves: #40462
Change-Id: Iec9eb9886b3b4605054acf32d79d635cefcb0bfc
Reviewed-on: http://review.typo3.org/38868
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Andreas Allacher [Fri, 13 Mar 2015 06:44:20 +0000 (07:44 +0100)]
[BUGFIX] Avoid exception when validating FQCN
Strip the leading backslash of the fully qualified classname to avoid the
exception "
1420281366" when using @validate.
Change-Id: I80d7ec8904acfa4c309990fd397ec7a015af8d77
Resolves: #65709
Releases: master
Reviewed-on: http://review.typo3.org/37804
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Jo Hasenau [Thu, 23 Apr 2015 10:37:07 +0000 (12:37 +0200)]
[BUGFIX] Add required to classStdWrap to avoid broken class names
Releases: master
Resolves: #46304
Change-Id: I34e193bcb3db7f328e1f2aad494857c50efd16a5
Reviewed-on: http://review.typo3.org/38871
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Mathias Brodala [Thu, 9 Apr 2015 09:00:29 +0000 (11:00 +0200)]
[BUGFIX] Respect file create mask for PackageStates file
The PackagesStates file needs to respect the configured file create
mask upon creation.
Resolves: #66337
Releases: master, 6.2
Change-Id: I4f4ecb91caa58fb67e42429c4313c6e342bdea61
Reviewed-on: http://review.typo3.org/38574
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Jo Hasenau [Thu, 23 Apr 2015 10:15:50 +0000 (12:15 +0200)]
[BUGFIX] Add missing stdWrap to includeRecordsWithoutDefaultTranslation
Releases: master
Resolves: #57087
Change-Id: I83454c261dc4c23abcccb46661d8eb2dc3d56904
Reviewed-on: http://review.typo3.org/38870
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Stefan Neufeind [Sat, 13 Dec 2014 23:30:35 +0000 (00:30 +0100)]
[!!!][TASK] Remove some deprecated parts in Extbase Persistence
Change-Id: I22d1b9868ffd65785edd10ca0b75479e1774c046
Resolves: #63835
Releases: master
Reviewed-on: http://review.typo3.org/35403
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Tim Kandel [Thu, 30 Apr 2015 17:54:39 +0000 (19:54 +0200)]
[TASK] Remove dependency to $this->formEngine->RTEcounter
There is a global counter in PHP to handle the sequence of
RTE's in one form. This is given along a long everywhere
but fits no real purpose. Parameter and usages are removed
with the patch.
Resolves: #63891
Releases: master
Change-Id: If10be8773ff13e5965b594c3a94da210d1c0f782
Reviewed-on: http://review.typo3.org/39111
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Wouter Wolters [Thu, 7 May 2015 16:57:09 +0000 (18:57 +0200)]
[FOLLOWUP][TASK] Refactor debugger console
Remove unused JavaScript file
Resolves: #65956
Releases: master
Change-Id: I6e79a454d24cdc9b16e953ff1d24f4512a97e314
Reviewed-on: http://review.typo3.org/39342
Reviewed-by: Benjamin Mack <benni@typo3.org>
Tested-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Tested-by: Mathias Schreiber <mathias.schreiber@wmdb.de>
Xavier Perseguers [Thu, 7 May 2015 15:04:35 +0000 (17:04 +0200)]
[BUGFIX] DBAL: Permission error when saving a new record
Last generated ID is not stored and makes the authorization
check fail when the record is saved and edited.
Change-Id: I5b3da01219239c2ecb559f2caa492c460a310332
Releases: master, 6.2
Resolves: #66843
Related: #66680
Reviewed-on: http://review.typo3.org/39334
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Xavier Perseguers [Thu, 7 May 2015 10:29:01 +0000 (12:29 +0200)]
[BUGFIX] ADOdb: mssqlnative driver is not properly initialized
Problems:
- Empty username/password should use Windows Authentication
- Character set is not used when connecting
- Port is not properly passed as argument
Change-Id: I7d45949dfd3dc6f8fd74033e9d39c8df80029db5
Releases: master, 6.2
Resolves: #66830
Resolves: #63070
Reviewed-on: http://review.typo3.org/39324
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Andreas Fernandez [Thu, 7 May 2015 08:36:24 +0000 (10:36 +0200)]
[FOLLOWUP][BUGFIX] File list breaks with DBAL
Releases: master, 6.2
Resolves: #66825
Change-Id: I5c649ddea7d0d5a9b8cffca09844c86d321fa85e
Reviewed-on: http://review.typo3.org/39320
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Xavier Perseguers [Thu, 7 May 2015 07:42:53 +0000 (09:42 +0200)]
[BUGFIX] File list breaks with DBAL
Unsupported double quotes used in database statements.
Change-Id: I8461d1d3acc57a3d543dbdf1d6450d2513eb661d
Releases: master, 6.2
Resolves: #66825
Reviewed-on: http://review.typo3.org/39318
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Tested-by: Xavier Perseguers <xavier@typo3.org>
Mathias Brodala [Wed, 15 Apr 2015 09:29:59 +0000 (11:29 +0200)]
[!!!][TASK] Remove IdentityMap from persistence
The IdentityMap class has been deprecated since 6.1 and is removed
from the Extbase persistence.
Resolves: #66429
Releases: master
Change-Id: I150b86190bbe7d0c9431d5495c8460241681f439
Reviewed-on: http://review.typo3.org/38701
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Benjamin Mack [Thu, 7 May 2015 05:18:25 +0000 (13:18 +0800)]
[TASK] Deprecate configureModule in extbase ExtensionUtility
There is a duplicate function placed in EXT:extbase/ExtensionUtility
and in ExtensionManagementUtility in the core.
The extbase-reference can be deprecated and the core class can
be used instead.
Resolves: #66823
Releases: master
Change-Id: If02facd20d6276fe22feb7dc945902fe1ef34747
Reviewed-on: http://review.typo3.org/39317
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Michael Oehlhof [Wed, 25 Mar 2015 06:14:09 +0000 (07:14 +0100)]
[BUGFIX] Remove driver id from file move message
The file move message showed identifiers instead of file and folder names.
Resolves: #64840
Releases: master
Change-Id: I6733f1d066a2577ed23b4c3843c7d4a09649d594
Reviewed-on: http://review.typo3.org/38144
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Christian Weiske <typo3@cweiske.de>
Tested-by: Christian Weiske <typo3@cweiske.de>
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Christian Kuhn [Wed, 6 May 2015 11:19:36 +0000 (13:19 +0200)]
[TASK] Upgrade to phpunit 4.6
Resolves: #66816
Releases: master, 6.2
Change-Id: Ia89add5a1988292770034119f6f93d13045fd784
Reviewed-on: http://review.typo3.org/39299
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Stephan Großberndt [Tue, 9 Dec 2014 14:36:25 +0000 (15:36 +0100)]
[BUGFIX] Do not gather log info in DataHandler if logging is disabled
If DataHandler->enableLogging=FALSE is set, do not compile log
information instead of gathering and discarding it afterwards. This
greatly improves performance for bulk operations if logging is
disabled.
Resolves: #63680
Releases: master
Change-Id: I8fa204b1228fe1411155e1ad781af19c662c1cd2
Reviewed-on: http://review.typo3.org/35196
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Wouter Wolters [Tue, 5 May 2015 18:25:21 +0000 (20:25 +0200)]
[TASK] Remove not used ExtDirect component for ext:context_help
Resolves: #66811
Releases: master
Change-Id: Ibcb962d5596cbee34e551ff8a067ebcb91533b1a
Reviewed-on: http://review.typo3.org/39287
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Andreas Fernandez [Wed, 6 May 2015 07:22:24 +0000 (09:22 +0200)]
[TASK] Replace $TYPO3_CONF_VARS mentions EXT:install
The usage of $TYPO3_CONF_VARS is highly discouraged, replace the
mentions in the Install Tool with $GLOBALS['TYPO3_CONF_VARS'].
Resolves: #66812
Releases: master
Change-Id: I9e250e6c38d83e1adf21d7bdc2db17463ead5ee6
Reviewed-on: http://review.typo3.org/39289
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Christian Kuhn [Tue, 5 May 2015 17:11:07 +0000 (19:11 +0200)]
[BUGFIX] Install Tool: Avoid caching
Install Tool bootstrap initializes the cache system and sets
all caches to NullBackend for increased stability of the tool.
Install Tool submodules however, that later call a bootstrap method
to additionally load ext_tables and friends for some scenarios,
indirectly call a method to set caches to the default values
without NullBackend again. As result, Fluid views are sometimes
cached again.
The patch supresses this by opening further detail methods of
the Bootstrap and calls them directly without pushing a
cache configuration again.
Resolves: #66809
Releases: master
Change-Id: I64acf470eba939eb7ba246aedb2bbb0fdf83384f
Reviewed-on: http://review.typo3.org/39283
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Andreas Fernandez [Wed, 6 May 2015 06:50:54 +0000 (08:50 +0200)]
[FOLLOWUP][TASK] Make ViewHelpers compilable in ext:install
Resolves: #66757
Releases: master
Change-Id: Icba1a587b460618b65a93242c4f29260e1781d93
Reviewed-on: http://review.typo3.org/39288
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Andreas Fernandez [Sun, 3 May 2015 11:47:58 +0000 (13:47 +0200)]
[TASK] Drop index length from "uid_foreign_tablefield"
The index lengths for the fields "tablenames" and
"fieldname" are set to 255. The field lengths itself
are also set to 255. If an index length equals the
field length, the Sup_part of the index remains NULL,
the index length shows no effect then.
Resolves: #66773
Releases: master
Change-Id: I50b4c027797323efb833e5527de015ed0c37ad41
Reviewed-on: http://review.typo3.org/39235
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Andreas Fernandez [Tue, 5 May 2015 06:24:59 +0000 (08:24 +0200)]
[TASK] Add human readable sections names in Install Tool
For usability reasons, prepend human readable sections names
in the "All Configuration" site of the Install Tool.
Resolves: #22539
Releases: master
Change-Id: I06002f620b300b7431e87f7c70a18ebcf840bcd8
Reviewed-on: http://review.typo3.org/39273
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Wouter Wolters [Sat, 2 May 2015 18:52:51 +0000 (20:52 +0200)]
[TASK] Make ViewHelpers compilable in ext:install
Resolves: #66757
Releases: master
Change-Id: I0770af5009cccd65eb632a5d9c14d3d61cf8790f
Reviewed-on: http://review.typo3.org/39211
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Bernhard Kraft [Mon, 4 May 2015 13:21:49 +0000 (15:21 +0200)]
[CLEANUP] Replace deeply nested if structures by guard clauses
There are some deeply nested if-structures in the versioning
extension, which get replaced with guard clauses with early returns
in this commit.
Releases: master
Resolves: #66780
Change-Id: Ib26e1ccf79e0ad3938c5c995bc013545ace863a6
Reviewed-on: http://review.typo3.org/39257
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Markus Klein [Tue, 5 May 2015 12:29:20 +0000 (14:29 +0200)]
[BUGFIX] Simulate user: Hide CLI users
It does not make sense to define user settings for CLI users.
Hide those in the "simulate user" select box.
Resolves: #66801
Releases: master
Change-Id: Ifec2d3d5840560f46eb59cbaf7e0c4949bf9370e
Reviewed-on: http://review.typo3.org/39278
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Wouter Wolters [Mon, 4 May 2015 20:20:57 +0000 (22:20 +0200)]
[TASK] Make CropViewHelper compilable
Resolves: #66788
Releases: master
Change-Id: I2f6f909be1403e6935e6fa3ed7a83f79fea03382
Reviewed-on: http://review.typo3.org/39266
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Wouter Wolters [Mon, 4 May 2015 22:08:47 +0000 (00:08 +0200)]
[TASK] Make HtmlViewHelper compilable
Resolves: #66791
Releases: master
Change-Id: Ie0535597f64daf40a6c4282f27da5c1f5113c62f
Reviewed-on: http://review.typo3.org/39269
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Wouter Wolters [Tue, 5 May 2015 18:01:46 +0000 (20:01 +0200)]
[TASK] Shorten two missed namespaces in ext:info_pagetsconfig
Shorten the namespace for GeneralUtility
Resolves: #66810
Releases: master
Change-Id: I592a866bad973b3b03439aaef7eddc47051fdd3d
Reviewed-on: http://review.typo3.org/39286
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Wouter Wolters [Mon, 4 May 2015 21:43:07 +0000 (23:43 +0200)]
[TASK] Deprecate options in CshViewHelper
Deprecate two options in the CshViewHelper
* iconOnly
* styleAttributes
Resolves: #66789
Releases: master
Change-Id: I7748dc07ae1630a12bca20bd671d220a07cd1b1a
Reviewed-on: http://review.typo3.org/39267
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Christian Kuhn [Tue, 5 May 2015 16:17:39 +0000 (18:17 +0200)]
Revert "[!!!][TASK] Refactor property access in compiled fluid templates"
This reverts commit
3bebd954624564ea64ee5e49bbbadf0a407947eb.
The patch to optimize compiled fluid templates breaks too heavily
and is not stable enough. A different solution is on the horizon
and may be picked up later again.
Change-Id: I2d7b0a42f8e1aa4750893f041aa5e617c82eb127
Resolves: #66808
Reverts: #66758
Releases: master
Reviewed-on: http://review.typo3.org/39282
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Christian Kuhn [Tue, 5 May 2015 12:52:50 +0000 (14:52 +0200)]
[BUGFIX] Clean up message handling in install tool
The extension compatibility misuses the install tool message
system for its tests and hands over on-the-fly arrays instead
of proper message objects.
The patch moves the message creation to the controller and
hands them over to view instead.
Resolves: #66805
Releases: master
Change-Id: Icea9955e7e1206327f859abf4ec3bcada50a65e6
Reviewed-on: http://review.typo3.org/39279
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Nicole Cordes [Tue, 5 May 2015 10:18:05 +0000 (12:18 +0200)]
[BUGFIX] Streamline queue objects on dependency check
The data stored in different download queues mixes arrays and objects.
Therefore you cannot loop over all queues and call functions of extension
objects. This patch streamlines all objects and make sure always objects
are returned.
Releases: master, 6.2
Resolves: #66798
Change-Id: I6eedefb614145b8645c7c52ff5daa7ad6c9c38e7
Reviewed-on: http://review.typo3.org/39276
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Xavier Perseguers [Fri, 1 May 2015 12:22:02 +0000 (14:22 +0200)]
[TASK] composer.json should stick to explicit dependencies
Having non-strict version dependencies in composer.json makes packaging
of TYPO3 CMS unreliable since:
- Cannot prevent a faulty 3rd-party package being committed right before
the packaging script is run
- Cannot install TYPO3 CMS from git tags as a later point of time using
the exact same 3rd-party package list
Change-Id: I7418bb856fcc79257ddb9920608b1cd435cb616c
Releases: master
Resolves: #66703
Reviewed-on: http://review.typo3.org/39153
Reviewed-by: Benjamin Mack <benni@typo3.org>
Reviewed-by: Thomas Maroschik <tmaroschik@dfau.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Wouter Wolters [Mon, 30 Mar 2015 19:03:31 +0000 (21:03 +0200)]
[TASK] Move jquery.clearable.js to ext:backend
This also makes jquery.clearable a solid standalone
AMD module.
Resolves: #66161
Releases: master
Change-Id: Id0f01b36c7e4d5050a9b3099db44c760c2234e10
Reviewed-on: http://review.typo3.org/38360
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Markus Klein [Mon, 4 May 2015 21:46:58 +0000 (23:46 +0200)]
[BUGFIX] Properly set file permissions for FileLocks
The FileLockStrategy now calls fixPermissions() in order to keep
the lock file accessible if a lock is created by a different user.
(e.g. via CLI)
Resolves: #66790
Releases: master
Change-Id: I607e6f4f8546878db4f3ba4d90275ab6860b2537
Reviewed-on: http://review.typo3.org/39268
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Andreas Allacher <andreas.allacher@gmx.at>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Wouter Wolters [Sun, 3 May 2015 11:58:28 +0000 (13:58 +0200)]
[TASK] Make ViewHelpers compilable in ext:extensionmanager
Format/ImplodeViewHelper
InstallationStateCssClassViewHelper
TimeSinceLastUpdateViewHelper
Typo3DependencyViewHelper
Resolves: #66774
Releases: master
Change-Id: I5ed2bde90bc95f7c0cc71b001f565e024d403023
Reviewed-on: http://review.typo3.org/39236
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Wouter Wolters [Sun, 3 May 2015 12:27:40 +0000 (14:27 +0200)]
[TASK] Make ViewHelpers compilable in ext:beuser
Resolves: #66775
Releases: master
Change-Id: Icc97f6587097a0eab155edbd6eb12ef03f65d524
Reviewed-on: http://review.typo3.org/39237
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Andreas Fernandez [Thu, 30 Apr 2015 16:12:27 +0000 (18:12 +0200)]
[TASK] Hide "Remaining characters" below date fields
Resolves: #66694
Releases: master
Change-Id: Iade12b524b54a000419ff3dad0d4638d78f967cd
Reviewed-on: http://review.typo3.org/39107
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Frans Saris [Mon, 4 May 2015 07:38:13 +0000 (09:38 +0200)]
[FOLLOWUP] Add templateRootPaths support to StandaloneView
Removed the partly implemented $throwException parameter.
Resolves: #66709
Releases: master
Change-Id: I6624bf41a425b4ccb0bd38daeaf0222c58082c4a
Reviewed-on: http://review.typo3.org/39253
Reviewed-by: Cedric Ziel <cedric@cedric-ziel.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Nicole Cordes [Thu, 30 Apr 2015 16:32:20 +0000 (18:32 +0200)]
[BUGFIX] Prevent infinite loop in FAL access check
If you have a storage which defines the processed folder in another
storage an infinite loop occurs when accessing the file list as
non-admin user. This is because the function getProcessingFolders
is called within the access check and starts access check for the
processed folder as well. This patch creates folder objects without
any access check (because processed folders should be readable and
writeable for everyone). Furthermore the processed folders for a storage
are cached after first fetch.
Releases: master, 6.2
Resolves: #66695
Change-Id: I9dade448466160f8c66f6118622d074f52bff702
Reviewed-on: http://review.typo3.org/39109
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Frank Nägler [Sat, 4 Apr 2015 20:54:37 +0000 (22:54 +0200)]
[TASK] Refactor util.js to AMD module
Resolves: #66275
Releases: master
Change-Id: I7269002dc5a5a656f407273a3c0dc87752758a39
Reviewed-on: http://review.typo3.org/38486
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Nicole Cordes [Sun, 3 May 2015 08:54:25 +0000 (10:54 +0200)]
[BUGFIX] Activate runtimeActivatedPackages without cache clearing
Currently you have to clear all caches manually to use runtime activated
packages because they are not included in the building process of the
cache identifier. This patch defines the TYPO3_CONF_VARS setting per
default and includes it in the cache identifier. Furthermore runtime
activated packages are excluded from being disabled in EM.
Release: master, 6.2
Resolves: #66768
Resolves: #58874
Change-Id: Idbda3c4f1f3c827c2b26c6f7759a9121cc260068
Reviewed-on: http://review.typo3.org/39227
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Nicole Cordes [Sat, 2 May 2015 15:47:50 +0000 (17:47 +0200)]
[BUGFIX] Improve dependency check in extension manager
This patch solves multiple problems currently occurring
if you try to install an extension:
* check dependencies recursively and merge errors
* prevent download if dependency errors occur
* prevent downgrading an extension
* improve information and error messages
* catch exceptions and display flash message
Releases: master, 6.2
Resolves: #52051
Resolves: #65332
Resolves: #65479
Resolves: #65916
Resolves: #60777
Change-Id: I0e9715d920e2fb43adb77fd61fde52938229431a
Reviewed-on: http://review.typo3.org/39209
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Frans Saris [Fri, 1 May 2015 15:30:29 +0000 (17:30 +0200)]
[FEATURE] Add templateRootPaths support to StandaloneView
StandaloneView is extended with setTemplateRootPaths() and
setTemplate() so it supports the same template path fallback
support like the extbase controllers do.
Resolves: #66709
Releases: master
Change-Id: I64a6e4a8e81936233e9efec85181ce3849771cdb
Reviewed-on: http://review.typo3.org/39160
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Wouter Wolters [Sat, 2 May 2015 19:40:02 +0000 (21:40 +0200)]
[TASK] Make ViewHelpers compilable in ext:indexed_search
Resolves: #66759
Releases: master
Change-Id: I39087794f7ed18d12514f6331dfba6a9767188d7
Reviewed-on: http://review.typo3.org/39212
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Jan Helke [Sat, 2 May 2015 21:06:44 +0000 (23:06 +0200)]
[TASK] Makes beuser/EditRecordViewHelper compilable
Resolves: #66763
Releases: master
Change-Id: Ie7697c5d9eead20edfeb7c278d97a72f7598e394
Reviewed-on: http://review.typo3.org/39218
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
dirk_juettner [Sun, 3 May 2015 08:58:07 +0000 (10:58 +0200)]
[TASK] Make Link/TypolinkViewHelper compilable
Resolves: #66767
Releases: master
Change-Id: Ibbab38408b4c5bf16cf74ea57d8f62b86e62b9c4
Reviewed-on: http://review.typo3.org/39228
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Michael Oehlhof [Sun, 8 Mar 2015 21:32:13 +0000 (22:32 +0100)]
[CLEANUP] EXT:backend/Classes/Wizard/*.php
* declare missing class variable
* remove unused variables
* correct typos
* use === for comparison
* use getters instead of inline makeInstance()
* rename variables
Resolves: #65602
Releases: master
Change-Id: I782c11b4c963ade8b0ede24f18e338b5e9e590b3
Reviewed-on: http://review.typo3.org/37652
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Jan Helke [Sun, 3 May 2015 09:00:24 +0000 (11:00 +0200)]
[TASK] Makes beuser/RemoveUserViewHelper compilable
Resolves: #66769
Releases: master
Change-Id: I4b1f9f5d4727ce7a4dcbd557f1fd15c078933bdc
Reviewed-on: http://review.typo3.org/39229
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Andreas Fernandez [Sat, 2 May 2015 20:07:06 +0000 (22:07 +0200)]
[TASK] Enable session watcher in debug mode
Enable the session watcher when debugging is enabled
in the backend, as the session still times out anyway.
Resolves: #66761
Releases: master
Change-Id: I270c5745e0c1bf7f31768fd1818e9a9593ea70b7
Reviewed-on: http://review.typo3.org/39215
Reviewed-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Jan Helke [Sat, 2 May 2015 21:20:08 +0000 (23:20 +0200)]
[TASK] Makes beuser/IssueCommandViewHelper compilable
Resolves: #66764
Releases: master
Change-Id: I404c60a1a4a19f84abe3a85b3c42e9d34be77317
Reviewed-on: http://review.typo3.org/39220
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Jan Helke [Sun, 3 May 2015 09:12:52 +0000 (11:12 +0200)]
[TASK] Removes beuser/SectionViewHelper
As this ViewHelper is not needed anymore, no need to refactor.
Resolves: #66770
Releases: master
Change-Id: I3a797c330388dea0360ef369cce7a7281ea97ac6
Reviewed-on: http://review.typo3.org/39230
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Jan Helke [Sun, 3 May 2015 09:37:40 +0000 (11:37 +0200)]
[TASK] Makes beuser/SwitchUserViewHelper compilable
Resolves: #66772
Releases: master
Change-Id: Ia3d3f3dfe85353fb7ca6303a40f586a9df55d563
Reviewed-on: http://review.typo3.org/39232
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Jan Helke [Sat, 2 May 2015 20:30:42 +0000 (22:30 +0200)]
[TASK] Makes belog/HistoryEntryViewHelper compilable
Resolves: #66762
Releases: master
Change-Id: I81abbaefc6b5af6d3d6f28cc2edb341af5e4440a
Reviewed-on: http://review.typo3.org/39216
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Jan Helke [Sun, 3 May 2015 09:23:36 +0000 (11:23 +0200)]
[TASK] Makes beuser/SpriteIconForRecordViewHelper compilable
Resolves: #66771
Releases: master
Change-Id: Ie3e753257939922a38e70f1ce9acdf0cbaf8cdb2
Reviewed-on: http://review.typo3.org/39231
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
dirk_juettner [Sun, 3 May 2015 08:12:16 +0000 (10:12 +0200)]
[FOLLOWUP] Add missing CompilableInterface to PageViewhelper
Resolves: #66766
Releases: master
Change-Id: I7c1daace874ce73f202159058321d96059ca7539
Reviewed-on: http://review.typo3.org/39226
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Christian Müller [Fri, 1 May 2015 10:21:19 +0000 (12:21 +0200)]
[!!!][TASK] Refactor property access in compiled fluid templates
Using ObjectAccess::getPropertyInternal is pretty expensive if called
repeatedly as can happen in bigger templates. On rendering the compiled
template for the first time we can generate the used getter and/or array
access information and write that into the compiled template.
Subsequent usages of the compiled template will then have much faster
access to nested variables.
This change is breaking if you push mixed data to the template. For
example an array that contains both arrays and object and access those
with the same property path access. In this case the cached accessors
might be wrong.
Resolves: #66758
Releases: master
Change-Id: Icb368938e67725d3a30a2545a30b40f045199405
Reviewed-on: http://review.typo3.org/39148
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Frank Nägler [Sat, 2 May 2015 21:50:04 +0000 (23:50 +0200)]
[FOLLOWUP] Make FormatsViewHelper compilable
This patch is a follow-up to fix broken ExtensionManager.
Resolves: #66760
Releases: master
Change-Id: I2f4023e220acf683faf7188adea0e6e8010dce67
Reviewed-on: http://review.typo3.org/39222
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Nicole Cordes [Sat, 2 May 2015 21:31:32 +0000 (23:31 +0200)]
[FOLLOWUP] Reload classAliasMap after extension installation
Fix unit tests.
Releases: master, 6.2
Resolves: #66696
Related: #65141
Change-Id: Iab641bb9e64280bfd81d0c1ca43b78ee0a188b40
Reviewed-on: http://review.typo3.org/39221
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Nicole Cordes [Thu, 30 Apr 2015 19:48:04 +0000 (21:48 +0200)]
[BUGFIX] Reload classAliasMap after extension installation
If an extension is installed at least the system cache is cleared
which throws away all defined class aliases as well. Those are only
loaded by bootstrap at the very beginning of an request and need to
be reloaded by the install process manually. This patch adds the
necessary call to ClassLoader.
Releases: master, 6.2
Resolves: #66696
Related: #65141
Change-Id: I4ace91789c43855acba91ac356b2263171cc921a
Reviewed-on: http://review.typo3.org/39112
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Nicole Cordes [Fri, 1 May 2015 11:29:12 +0000 (13:29 +0200)]
[TASK] Add extension precedence
This patch re-adds the possibility to overwrite system or global
extensions with local ones from typoconf/ext.
Releases: master, 6.2
Resolves: #59147
Change-Id: I1f01677791db26d2be4e70c0a81d96e42ca5147c
Reviewed-on: http://review.typo3.org/39151
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>
Wouter Wolters [Sat, 2 May 2015 19:50:57 +0000 (21:50 +0200)]
[TASK] Make FormatsViewHelper compilable
Resolves: #66760
Releases: master
Change-Id: I4556adcd18955f2373a06e22c3f060c2a459c870
Reviewed-on: http://review.typo3.org/39213
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Nicole Cordes [Thu, 30 Apr 2015 13:15:05 +0000 (15:15 +0200)]
[BUGFIX] Prevent root folder listing for users
If a user hasn't any file mount defined or the defined file mounts
don't exist the root folder of the storage is shown. To prevent
disallowed listing of folders only admin users are allowed see and
browse root folder and editors get an information that no file mounts
are configured.
Releases: master, 6.2
Resolves: #66687
Change-Id: I301d05773f10885351034dae2b0bbd16ac20ac55
Reviewed-on: http://review.typo3.org/39089
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Wouter Wolters [Sat, 2 May 2015 16:14:15 +0000 (18:14 +0200)]
[TASK] Make ModuleLinkViewHelper compilable
Resolves: #66752
Releases: master
Change-Id: I974515fb8be762ef7105171956e1e7d053111a4e
Reviewed-on: http://review.typo3.org/39203
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Jan Helke [Fri, 1 May 2015 19:08:35 +0000 (21:08 +0200)]
[TASK] Makes DebugViewHelper compilable
Resolves: #66721
Releases: master
Change-Id: Ieae0a99500ef19bf428819906d05e9ed1643b6c0
Reviewed-on: http://review.typo3.org/39172
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Wouter Wolters [Sat, 2 May 2015 18:13:49 +0000 (20:13 +0200)]
[TASK] Make IconViewHelper compilable in ext:reports
Resolves: #66756
Releases: master
Change-Id: Ic14351320748987ba087abb8f2f34c8175d528d4
Reviewed-on: http://review.typo3.org/39210
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Anja Leichsenring [Sat, 2 May 2015 17:06:05 +0000 (19:06 +0200)]
[TASK] Remove initializeArguments method from IconViewHelper
The initializeArguments method does not play well with
renderStatic. Therefore the registered argument is merged into the
render method attributes list.
Resolves: #66755
Releases: master
Change-Id: Ib546f4ee5823d3bbdd9800f2887475c565434c24
Reviewed-on: http://review.typo3.org/39207
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Christian Müller [Sat, 2 May 2015 16:59:48 +0000 (18:59 +0200)]
[!!!][TASK] Remove RenderingContextAwareInterface
The RenderingContextAwareInterface was never used and should therefore
be removed as it introduces unnecessary overhead in property access of
Fluid. It also prevents further optmization of the template rendering
process.
This can potentially be breaking if your code implements the interface.
Resolves: #66754
Releases: master
Change-Id: I009049582d02a79e8ee084db5bf7010d7139fcb4
Reviewed-on: http://review.typo3.org/39206
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Xavier Perseguers [Fri, 1 May 2015 11:18:44 +0000 (13:18 +0200)]
[BUGFIX] DBAL backend module crashes when loading
Change-Id: Id15595133cbee22623538bb23896561df47413de
Releases: master
Resolves: #66642
Reviewed-on: http://review.typo3.org/39095
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Jan Helke [Fri, 1 May 2015 18:33:53 +0000 (20:33 +0200)]
[TASK] Makes Uri/TypolinkViewHelper compilable
Resolves: #66717
Releases: master
Change-Id: I55d6e21b0bf474b73f8c51bc07a6f4deaa417b23
Reviewed-on: http://review.typo3.org/39168
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Markus Sommer [Sat, 2 May 2015 15:52:29 +0000 (17:52 +0200)]
[TASK] Make \Be\Menus\ActionMenuItemViewHelper compilable
Implement CompilableInterface
getTagBuilder to get the TagBuilder for renderStatic function
Resolves: #66751
Releases: master
Change-Id: I57976c0b6c21bdc2be04f3e3224bcb28992f6611
Reviewed-on: http://review.typo3.org/39202
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Michael Oehlhof [Sat, 4 Apr 2015 22:35:38 +0000 (00:35 +0200)]
[FEATURE] Added ActionMenuItemGroupViewHelper
Using this ViewHelper we can use OptGroups in the backend selectfield
which controls which function selected.
Resolves: #62242
Releases: master
Change-Id: I7208691c305068764496c09b3f3d5ccc8f1b7665
Reviewed-on: http://review.typo3.org/38487
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Nägler <typo3@naegler.net>
Tested-by: Frank Nägler <typo3@naegler.net>
Frank Nägler [Sat, 2 May 2015 16:51:04 +0000 (18:51 +0200)]
[TASK] Cleanup usage of InfoboxViewHelper
In several places in the core, the InfoboxViewHelper was used in controller
context. This patch changes this and makes use of a StandaloneView.
Resolves: #66753
Related: #66723
Releases: master
Change-Id: I16044a4c663aad4eb0cffce0b11bbf63047118f5
Reviewed-on: http://review.typo3.org/39205
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Markus Klein [Fri, 1 May 2015 14:47:55 +0000 (16:47 +0200)]
[!!!][BUGFIX] Fix usage of issueCommand() and T3_THIS_LOCATION
Multiple usages of T3_THIS_LOCATION are removed as its usage
make only sense in JavaScript context.
issueCommand() takes care of properly quoting the URL when
using in JavaScript context.
Resolves: #66707
Releases: master
Change-Id: Ib0e89e9657fc83bd6514a2077013926f24434a37
Reviewed-on: http://review.typo3.org/39158
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Helmut Hummel <helmut.hummel@typo3.org>
Tested-by: Helmut Hummel <helmut.hummel@typo3.org>