Packages/TYPO3.CMS.git
9 months ago[BUGFIX] Streamline UX for File Upload module 75/59175/2
Benni Mack [Mon, 17 Dec 2018 08:08:40 +0000 (09:08 +0100)]
[BUGFIX] Streamline UX for File Upload module

When using the file upload module (called via File list), the dialog uses
non-bootstrap classes from historical times back in the day.

Using proper HTML makes the view look more like the rest of
TYPO3 Backend.

Resolves: #87178
Releases: master, 9.5
Change-Id: I4d6a4c8f96414d5fb776270db6ef8aa677e788b7
Reviewed-on: https://review.typo3.org/59175
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Add missing use statement in CObjectViewHelper 85/59185/3
Georg Ringer [Mon, 17 Dec 2018 18:53:49 +0000 (19:53 +0100)]
[BUGFIX] Add missing use statement in CObjectViewHelper

The use statement for TypoScriptFrontendController is added.

Resolves: #87186
Releases: master, 9.5
Change-Id: I2b758b3ac9bcd4002844160614ee1a9c7bc72585
Reviewed-on: https://review.typo3.org/59185
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Do not depend on global TSFE for link generation 36/59036/6
Benni Mack [Wed, 5 Dec 2018 10:41:42 +0000 (11:41 +0100)]
[BUGFIX] Do not depend on global TSFE for link generation

Handing in the dependency of TSFE into
AbstractLinkBuilder allows to use a custom TSFE
object, when working within middlewares (e.g. Redirects)
thus, not depending on global state directly.

As a drive-by-fix, using AbstractTypolinkBuilder now does not
generate a global TSFE anymore, which can have ugly side-effects.

Tests are now simplified because the original constructor can be
called directly instead of relying on $GLOBALS[TSFE].

Resolves: #87143
Releases: master, 9.5
Change-Id: I77f2da501d1a78f0579626ebb50ef47a0026f1f7
Reviewed-on: https://review.typo3.org/59036
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
9 months ago[TASK] Streamline dependencies in package.json 74/59174/3
Benni Mack [Mon, 17 Dec 2018 07:49:12 +0000 (08:49 +0100)]
[TASK] Streamline dependencies in package.json

Several changes to Build/package.json are
adapted:
- define compatible node/yarn versions
- adapt version and URL to typo3.org

Resolves: #87177
Releases: master, 9.5, 8.7
Change-Id: Ie812cd69913e2969dc88db8e8c52edbb6d482243
Reviewed-on: https://review.typo3.org/59174
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Matthias Stegmann <matthias.stegmann@b13.de>
Tested-by: Matthias Stegmann <matthias.stegmann@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Mark form as changed after using the image cropper 66/59166/3
Andreas Fernandez [Sun, 16 Dec 2018 11:24:45 +0000 (12:24 +0100)]
[BUGFIX] Mark form as changed after using the image cropper

The image cropper now marks the form as "changed" after saving new
cropping information.

Resolves: #86998
Releases: master, 9.5, 8.7
Change-Id: Ia6a6abeb88b1d9a590e76b50890ebcbac16f7472
Reviewed-on: https://review.typo3.org/59166
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] bamboo sends nightly build messages to intercept 68/59168/2
Christian Kuhn [Sun, 16 Dec 2018 14:46:54 +0000 (15:46 +0100)]
[TASK] bamboo sends nightly build messages to intercept

Resolves: #87171
Releases: master, 9.5, 8.7
Change-Id: Ia71eb5ce2824ff3c39dbc526ec3a3d93b4990eca
Reviewed-on: https://review.typo3.org/59168
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Remove COMPOSER_ROOT_VERSION from bamboo testing 65/59165/2
Christian Kuhn [Sat, 15 Dec 2018 12:14:10 +0000 (13:14 +0100)]
[TASK] Remove COMPOSER_ROOT_VERSION from bamboo testing

With latest changes in master and helper repositories, we do
not need the COMPOSER_ROOT_VERSION setting in tests anymore.
Remove that to have one detail less to maintain.

Resolves: #87170
Releases: master
Change-Id: Iea54bb6f17d0b08b4b248c40ad60691aa5cb0cb3
Reviewed-on: https://review.typo3.org/59165
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] composer update without progress in bamboo 63/59163/3
Christian Kuhn [Fri, 14 Dec 2018 20:05:18 +0000 (21:05 +0100)]
[TASK] composer update without progress in bamboo

To prevent garbled output in test logs, composer update
commands add --no-progress option.

Resolves: #87169
Releases: master, 9.5
Change-Id: I89f27fbf3fea44216f5a01fc3be20f6614dbe8d0
Reviewed-on: https://review.typo3.org/59163
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Disable ext:introduction installer ac test 62/59162/3
Christian Kuhn [Fri, 14 Dec 2018 19:42:10 +0000 (20:42 +0100)]
[TASK] Disable ext:introduction installer ac test

Core v10 compatible releases of ext:introduction and
ext:bootstrap_package will take time until the other day.
To not disable all install related tests, the
ext:introduction related ac tests are skipped for master
for the time being.

Resolves: #87168
Releases: master
Change-Id: I498a9962beca9b9d5e87f7c19fd02ea72db961ac
Reviewed-on: https://review.typo3.org/59162
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Update typo3/cms-styleguide from 9.2.2 to 10.0.0 61/59161/3
Christian Kuhn [Fri, 14 Dec 2018 18:35:56 +0000 (19:35 +0100)]
[TASK] Update typo3/cms-styleguide from 9.2.2 to 10.0.0

A first v10 core compatible styleguide

composer require --dev typo3/cms-styleguide:~10.0.0

Change-Id: I1c9ceb172c72cd52382e090f65c0e7a6a9914b03
Resolves: #87167
Releases: master
Reviewed-on: https://review.typo3.org/59161
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Update typo3/testing-framework from 4.11.1 to 5.0.0 58/59158/3
Christian Kuhn [Fri, 14 Dec 2018 17:03:09 +0000 (18:03 +0100)]
[TASK] Update typo3/testing-framework from 4.11.1 to 5.0.0

Version 5.0.0 of typo3/testing-framework brings core v10
compatibility. This fixes a 'requirements could not be resolved'
message from composer for core master branch.

composer require --dev typo3/testing-framework:~5.0.0

Resolves: #87164
Releases: master
Change-Id: I3dab9b83d872545eff71705a3f4da2a73c40e0da
Reviewed-on: https://review.typo3.org/59158
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Update TYPO3 version to 10.0.0-dev 50/59150/4
Benni Mack [Fri, 14 Dec 2018 08:58:05 +0000 (09:58 +0100)]
[TASK] Update TYPO3 version to 10.0.0-dev

In order to distinguish between v10-dev / dev-master,
and 9.5, all dependencies are updated to v10.0.0-dev.

For ext_emconf.php the fixed version 10.0.0 is used
as in all other branches.

Resolves: #87159
Releases: master
Change-Id: Ie1f135663527f8c7d1654e085b874d699b677529
Reviewed-on: https://review.typo3.org/59150
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Update URL to use HTTPS 28/59128/2
Ben Abbott [Wed, 12 Dec 2018 22:29:21 +0000 (23:29 +0100)]
[TASK] Update URL to use HTTPS

Releases: master
Resolves: #87140
Change-Id: I567b92746e26043b50f9cb735d89aa02f4ccda00
Reviewed-on: https://review.typo3.org/59128
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Set TYPO3 version to 9.5.4-dev 45/59145/3
Oliver Hader [Fri, 14 Dec 2018 07:29:45 +0000 (08:29 +0100)]
[TASK] Set TYPO3 version to 9.5.4-dev

Change-Id: I99d51f3836de8d062bc5503bcc58e05cdfacb83c
Reviewed-on: https://review.typo3.org/59145
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[RELEASE] Release of TYPO3 9.5.3 44/59144/2 v9.5.3
Oliver Hader [Fri, 14 Dec 2018 07:28:19 +0000 (08:28 +0100)]
[RELEASE] Release of TYPO3 9.5.3

Change-Id: Iee75e14be97ac5018cedf4f7f94664d8d4fe43f0
Reviewed-on: https://review.typo3.org/59144
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[DOC] Add ChangeLog index of 9.5.x 24/59124/3
Sybille Peters [Wed, 12 Dec 2018 18:17:18 +0000 (19:17 +0100)]
[DOC] Add ChangeLog index of 9.5.x

In order to get a rendered list of changes since the release of 9.5.0 an
additional index file is needed for the 9.5.x changes.

Resolves: #87135
Releases: master
Change-Id: I14713eace6493220852aea55ae431b1c4182ee80
Reviewed-on: https://review.typo3.org/59124
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix positioning of arrows in Element Browser 36/59136/2
Andreas Fernandez [Thu, 13 Dec 2018 16:18:09 +0000 (17:18 +0100)]
[BUGFIX] Fix positioning of arrows in Element Browser

The positioning of the collapse/expand arrows is changed to fix the break
in trees with very deep nesting.

Resolves: #86790
Releases: master, 8.7
Change-Id: Ie1a916da8220468c6fbb4034c1668675f379f588
Reviewed-on: https://review.typo3.org/59136
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Properly separate markup for modal windows in extension manager 35/59135/4
Oliver Hader [Thu, 13 Dec 2018 15:41:12 +0000 (16:41 +0100)]
[BUGFIX] Properly separate markup for modal windows in extension manager

Due to recent security releases and fixes against cross-site scripting
in central modal window component, templates are separated in order to
distinguish between (secure) HTML and attribute or text nodes.

Resolves: #87146
Releases: master, 8.7
Change-Id: I1264cbe9005e54d1fe30eaba23efbbad07937cb1
Reviewed-on: https://review.typo3.org/59135
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix HTML in modal of OnlineMedia.ts 20/59120/10
Georg Ringer [Tue, 11 Dec 2018 19:33:18 +0000 (20:33 +0100)]
[BUGFIX] Fix HTML in modal of OnlineMedia.ts

Allows to call the OnlineMedia modal box again.

This change also adapts the buttons within
a Modal to be text-only.
Resolves: #87144
Releases: master, 8.7
Change-Id: Id08356aad3eb319c59af1411a14131715c8159d0
Reviewed-on: https://review.typo3.org/59120
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix HTML in drag-title of PageTreeDragDrop.js 21/59121/4
Stefan Neufeind [Tue, 11 Dec 2018 20:56:41 +0000 (21:56 +0100)]
[BUGFIX] Fix HTML in drag-title of PageTreeDragDrop.js

Resolves: #87145
Releases: master
Change-Id: Ie3abd71840ca8fbd48150ae2b4f34efc5273ce63
Reviewed-on: https://review.typo3.org/59121
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] getTreeList inserts duplicate keys in cache_treelist 27/59127/6
Alexander Schnitzler [Wed, 12 Dec 2018 21:53:07 +0000 (22:53 +0100)]
[BUGFIX] getTreeList inserts duplicate keys in cache_treelist

Unfortunately https://review.typo3.org/58951/ did not actually
solve issues #86028 and #86491 for good.

There are two issues concerning the former approach:

1) The expiration time of all created caches was 0, which resulted
   in a permanent creation and deletion of cache entries. This
   behaviour cannot be called caching.

2) Number 1) increases the chance for race conditions where several
   parallel requests tried to create the same cache entry.

To fix this, the check for an existing cache entry will be reverted
to behave like before the regression, i.e. cache entries with an
expiration timestamp of 0 are considered valid again.

Also, new caches are created within a transaction, which prevents
duplicate key errors.

Releases: master, 8.7
Resolves: #87139
Change-Id: If9470f6e0f875c0ec4fe3c092c9bd0dfc059de2d
Reviewed-on: https://review.typo3.org/59127
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Revert bugfix Remove surrounding &nsbp; in the tables with ol or ul in CKEditor 37/59137/2
Benni Mack [Thu, 13 Dec 2018 16:35:50 +0000 (17:35 +0100)]
[BUGFIX] Revert bugfix Remove surrounding &nsbp; in the tables with ol or ul in CKEditor

This reverts commit c23b1e1970d44cb3fc836db697650be568788218
as now frontend rendering is different from 8.7.19 and 8.7.20.

Change-Id: Ia640ed3eda1619b0a34b5cd6afd07a665e372792
Resolves: #86819
Reverts: #83795
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/59137
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Do not rewind Generator in DebuggerUtility::var_dump() 32/59132/4
Mathias Brodala [Thu, 13 Dec 2018 14:21:15 +0000 (15:21 +0100)]
[BUGFIX] Do not rewind Generator in DebuggerUtility::var_dump()

Resolves: #87149
Releases: master, 8.7
Change-Id: I8cf2cfab94634276a67fd3d0dd36215c12ae5490
Reviewed-on: https://review.typo3.org/59132
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Ralf Merz <mail@merzilla.de>
Tested-by: Ralf Merz <mail@merzilla.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
9 months ago[TASK] Silence composer install progress in bamboo 25/59125/2
Christian Kuhn [Wed, 12 Dec 2018 19:43:07 +0000 (20:43 +0100)]
[TASK] Silence composer install progress in bamboo

Resolves: #87136
Releases: master, 8.7
Change-Id: Idbac64bf44b8f79ccd8a169f4abade462873e17d
Reviewed-on: https://review.typo3.org/59125
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Allow custom namespace in ExtbasePluginEnhancer 52/58952/3
Benni Mack [Mon, 26 Nov 2018 14:46:27 +0000 (15:46 +0100)]
[BUGFIX] Allow custom namespace in ExtbasePluginEnhancer

In Extbase, it is possible to configure a custom namespace for
plugin arguments:

plugin.tx_bennimack.view.pluginNamespace = bmack

This is now also respected in the Extbase Plugin Enhancer by omitting
"extension" and "plugin" properties and just using the "namespace"
property.

Resolves: #87005
Releases: master
Change-Id: I19c6338ec0d103837a5c5217ad7ba6643b6b6c54
Reviewed-on: https://review.typo3.org/58952
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jonas Eberle <flightvision@googlemail.com>
Tested-by: Jonas Eberle <flightvision@googlemail.com>
Reviewed-by: Aimeos <aimeos@aimeos.org>
Tested-by: Aimeos <aimeos@aimeos.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Remove @ in doc comment of TypoScriptParser 74/59074/3
Georg Ringer [Mon, 10 Dec 2018 11:17:57 +0000 (12:17 +0100)]
[BUGFIX] Remove @ in doc comment of TypoScriptParser

To avoid exceptions by the Doctrine annotations parser, the @ character
is removed from the doc comment.

Resolves: #87115
Releases: master
Change-Id: I779374e2b9894272087153860de525fa0ce02712
Reviewed-on: https://review.typo3.org/59074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Add filter for be_users and be_groups 70/59070/4
Guido Schmechel [Sun, 9 Dec 2018 20:26:34 +0000 (21:26 +0100)]
[TASK] Add filter for be_users and be_groups

Add textfield filter for select fields from type
"selectMultipleSideBySide" for system tables.

Affected system tables: be_groups, be_users

Resolves: #87112
Releases: master, 8.7
Change-Id: Iba8b837a9fc5f2ec64be7e5ad313b454c4373feb
Reviewed-on: https://review.typo3.org/59070
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Tomas Norre Mikkelsen <tomasnorre@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[TASK] Set TYPO3 version to 9.5.3-dev 16/59116/2
Oliver Hader [Tue, 11 Dec 2018 12:43:54 +0000 (13:43 +0100)]
[TASK] Set TYPO3 version to 9.5.3-dev

Change-Id: If92f54c5a28edba2dc330ca8e32e5dcfda817f6f
Reviewed-on: https://review.typo3.org/59116
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[RELEASE] Release of TYPO3 9.5.2 15/59115/2 v9.5.2
Oliver Hader [Tue, 11 Dec 2018 12:42:51 +0000 (13:42 +0100)]
[RELEASE] Release of TYPO3 9.5.2

Change-Id: Ib5214342439fd510cfd599d9880b1612ff9b4cc1
Reviewed-on: https://review.typo3.org/59115
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[BUGFIX] Adjust modal window processing and RequireJS loading 07/59107/5
Oliver Hader [Tue, 11 Dec 2018 11:46:40 +0000 (12:46 +0100)]
[BUGFIX] Adjust modal window processing and RequireJS loading

Resolves: #87123
Releases: master, 8.7, 7.6
Change-Id: Idceecb174682261b967ea284e12e1836bb7e7bea
Reviewed-on: https://review.typo3.org/59107
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Avoid DoS in Online Media Helper 05/59105/2
Oliver Hader [Tue, 11 Dec 2018 09:57:31 +0000 (10:57 +0100)]
[SECURITY] Avoid DoS in Online Media Helper

Using large media files (*.youtube, *.vimeo in the TYPO3 core)
might lead to denial of service scenarios. In order to avoid
that, media files are limited to have a content size of 2048
bytes as a maximum. Usually these files contain just the remote
identifier - thus, ~20 bytes should have been sufficient already.

Resolves: #85381
Releases: master, 8.7, 7.6
Security-Commit: 36c64c45461dee1c4018b7c72a989952d1e2dd45
Security-Bulletin: TYPO3-CORE-SA-2018-011
Change-Id: Ib54cd9ab822ee33a44170822cc0a3c4da4132c95
Reviewed-on: https://review.typo3.org/59105
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Remove TYPO3 version from installer 04/59104/2
Benni Mack [Tue, 11 Dec 2018 09:57:24 +0000 (10:57 +0100)]
[SECURITY] Remove TYPO3 version from installer

When installing TYPO3, the current version
is shown without any kind of authentication
provided (no FIRST_INSTALL). This information
disclosure is solved.

Resolves: #86254
Releases: master, 8.7, 7.6
Security-Commit: a69d09ab4eabd0474f0191f5daf525d91ebaa32f
Security-Bulletin: TYPO3-CORE-SA-2018-010
Change-Id: Ib8359937716dce4839d76b054b0d0d549bd4aa0c
Reviewed-on: https://review.typo3.org/59104
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Make InstallTool session cookie HTTP-only 03/59103/2
Andreas Wolf [Tue, 11 Dec 2018 09:57:18 +0000 (10:57 +0100)]
[SECURITY] Make InstallTool session cookie HTTP-only

Resolves: #86955
Releases: master, 8.7, 7.6
Security-Commit: d251175e031aaa9943f93f5e5297f5490b99e513
Security-Bulletin: TYPO3-CORE-SA-2018-009
Change-Id: Ia50cac61ee2d649e98cba2102162c1360487bb20
Reviewed-on: https://review.typo3.org/59103
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Prevent XSS with fe_users data in felogin/TSFE 02/59102/2
Benni Mack [Tue, 11 Dec 2018 09:57:11 +0000 (10:57 +0100)]
[SECURITY] Prevent XSS with fe_users data in felogin/TSFE

Two occurrences allow to render data of the currently logged in
frontend user that is not sanitized and thus allow XSS attacks
by frontend users.

1. EXT:fe_login adds ###FEUSER_{fieldname}### for each
field that exists in the fe_users DB table, which CAN be processed
by TypoScript but is insecure by default.

2. config.USERNAME_substToken = <!--###USERNAME###-->
sets the username dynamically, which is then insecure.

Adding htmlspecialchars as a default configuration
solves this problem.

Resolves: #87053
Releases: master, 8.7, 7.6
Security-Commit: 1cc57f4aa7dfb5b1e3e4db581c57aacd69dd4d9d
Security-Bulletin: TYPO3-CORE-SA-2018-008
Change-Id: I72a1a4ea60f23c81016b87cbbd1ba63161c52df0
Reviewed-on: https://review.typo3.org/59102
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Prevent XSS in modal component and PageTree 01/59101/2
Frank Naegler [Tue, 11 Dec 2018 09:57:05 +0000 (10:57 +0100)]
[SECURITY] Prevent XSS in modal component and PageTree

Resolves: #84190
Releases: master, 8.7, 7.6
Security-Commit: 0aaf266ae75d04efc6a943f9414448d5c2787309
Security-Bulletin: TYPO3-CORE-SA-2018-007
Change-Id: Ic5beb5217326d8f3d72445d4bf9cc7ace705a5a0
Reviewed-on: https://review.typo3.org/59101
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Properly escape videoId for YouTube/Vimeo 00/59100/2
Susanne Moog [Tue, 11 Dec 2018 09:56:58 +0000 (10:56 +0100)]
[SECURITY] Properly escape videoId for YouTube/Vimeo

Resolves: #83184
Releases: master, 8.7, 7.6
Security-Commit: c51313ed68970cd6d2f2172a0e3d74454cf05812
Security-Bulletin: TYPO3-CORE-SA-2018-006
Change-Id: Id982d4fc28e7817eeb88eb63f52dc3380365f3b1
Reviewed-on: https://review.typo3.org/59100
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[SECURITY] Update library CKEditor to 4.11.1 99/59099/2
Benni Mack [Tue, 11 Dec 2018 09:56:50 +0000 (10:56 +0100)]
[SECURITY] Update library CKEditor to 4.11.1

CKEditor 4.11 was released including a XSS fix where
an attacker could add invalid HTML markup by switching
to the Source mode of CKEditor and back.

Used commands:
  cd Build/
  yarn add ckeditor#4.11.1 --dev
  grunt build

Resolves: #84800
Releases: master, 8.7
Security-Commit: 4a44c536a4f80b1fbf4599070761368e7919980c
Security-Bulletin: TYPO3-CORE-SA-2018-005
Change-Id: I50412f24393c306a989dac448d7c0ee66a6760fb
Reviewed-on: https://review.typo3.org/59099
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[BUGFIX] Check for valid FrontendInterface for page title cache 82/59082/2
Richard Haeser [Mon, 10 Dec 2018 21:33:56 +0000 (22:33 +0100)]
[BUGFIX] Check for valid FrontendInterface for page title cache

The PageTitleProviderManager will now check if the page cache object
is an instance of FrontendInterface before getting the value from cache.

Resolves: #87116
Releases: master
Change-Id: I14838b41a7cba653d5f4e6c875c647f547673644
Reviewed-on: https://review.typo3.org/59082
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
9 months ago[BUGFIX] Respect GET parameters when generating canonicalized URLs 11/58611/22
Richard Haeser [Wed, 10 Oct 2018 21:49:03 +0000 (23:49 +0200)]
[BUGFIX] Respect GET parameters when generating canonicalized URLs

Add current query string to the generated canonicalized URL to make the
hreflang and canonical work with additional parameters as well.

Parameters that are excluded from cache hash generation and not included
in $GLOBALS['TYPO3_CONF_VARS']['FE']['additionalCanonicalizedUrlParameters'],
are excluded from the canonicalized URL.

Resolves: #86577
Resolves: #86866
Resolves: #86865
Releases: master
Change-Id: Ib574e2f6c7aa869b4ffa798c7122a60f4cf13f13
Reviewed-on: https://review.typo3.org/58611
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[TASK] Add default icon overlay fields to rootline 30/59030/4
Tim Karliczek [Tue, 4 Dec 2018 17:27:34 +0000 (18:27 +0100)]
[TASK] Add default icon overlay fields to rootline

Add fields, which modify page icon rendering,
to default field list of rootline page requests.
Ensures more detailed rendering of page status icons
in FLUID using ViewHelper core:iconForRecord

Resolves: #87076
Releases: master
Change-Id: I11adbaa627c77ceaaa23ca28229510cb19936ad3
Reviewed-on: https://review.typo3.org/59030
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Add proper scope for styling of DebugExceptionHandler 70/58870/4
Georg Ringer [Wed, 7 Nov 2018 22:35:16 +0000 (23:35 +0100)]
[BUGFIX] Add proper scope for styling of DebugExceptionHandler

The styling of the debug output is "namespaced" with `.exception-page`
to avoid influencing other CSS definitions.

Resolves: #86879
Releases: master
Change-Id: I5561b7995826abfd5e1ea53b2b31b30b19c2f208
Reviewed-on: https://review.typo3.org/58870
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Poerschke <markus@poerschke.nrw>
Tested-by: Markus Poerschke <markus@poerschke.nrw>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Accept Unicode characters in email spam protection 33/59033/8
Oliver Bartsch [Tue, 4 Dec 2018 22:50:50 +0000 (23:50 +0100)]
[BUGFIX] Accept Unicode characters in email spam protection

Use multibyte handling to properly process all Unicode characters for
the spam protection email address handling.

Resolves: #87071
Releases: master
Change-Id: I9fec60c000a202ae34927ec4917e29e2d0e64a5c
Reviewed-on: https://review.typo3.org/59033
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[TASK] Display exact error message of handlePageError() 26/59026/7
Peter Kraume [Tue, 4 Dec 2018 14:15:01 +0000 (15:15 +0100)]
[TASK] Display exact error message of handlePageError()

Show getUrl() error message when fetching content of error page.

Resolves: #87073
Releases: master
Change-Id: I9b2d548fc1d9a4bd07ea56c7d5776447c0c596d2
Reviewed-on: https://review.typo3.org/59026
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Ignore wizards with no upgrades in report 48/59048/2
Alexander Stehlik [Thu, 6 Dec 2018 21:57:39 +0000 (22:57 +0100)]
[BUGFIX] Ignore wizards with no upgrades in report

The reports module now ignores upgrade wizards that do
not have any necessary upgrades (shouldRenderWizard property
is false).

This makes the behavior fully consistent with the install tool
because there the wizards that should not be rendered are not
displayed either.

Resolves: #86632
Releases: master
Change-Id: I87caf45023a0ca4eca71418e029bc8ed7091c0e4
Reviewed-on: https://review.typo3.org/59048
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Remove composer max update from regular randomizer 60/59060/4
Anja Leichsenring [Sat, 8 Dec 2018 10:20:47 +0000 (11:20 +0100)]
[BUGFIX] Remove composer max update from regular randomizer

Fix a nightly test setup for a wrong composer dependency
in "main" stage. Disable the phpunit randomizer in
"composer update max" stage for now since young phpunit
collides with our current randomizer call.

Change-Id: I4a5d9cd3eea1686969fe0185433a2384aad87a90
Resolves: #87106
Releases: master
Reviewed-on: https://review.typo3.org/59060
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Simplify bamboo variable to label handling 63/59063/2
Christian Kuhn [Sat, 8 Dec 2018 13:52:56 +0000 (14:52 +0100)]
[TASK] Simplify bamboo variable to label handling

Intercept has been adapted, the variable to label handing
can be simplified a bit.

Resolves: #87109
Releases: master, 8.7, 7.6
Change-Id: I27255ef9f5eb515c89f5d89e7061fc473e2abec1
Reviewed-on: https://review.typo3.org/59063
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Do not resolve languageFilePath to absolutePath 24/59024/7
Achim Fritz [Tue, 4 Dec 2018 11:06:54 +0000 (12:06 +0100)]
[BUGFIX] Do not resolve languageFilePath to absolutePath

Resolving the path here breaks the localization Override
in the LocalizationFactory Class

Resolves: #86683
Releases: master
Change-Id: Ib7037bcfba0dd02cf46c1b31f98d7808e7974b3c
Reviewed-on: https://review.typo3.org/59024
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Avoid overwriting page context in TSFE->cObj by f:cObject 61/58661/11
Thorben Nissen [Fri, 19 Oct 2018 09:03:58 +0000 (11:03 +0200)]
[BUGFIX] Avoid overwriting page context in TSFE->cObj by f:cObject

Change `CObjectViewHelper::getContentObjectRenderer` to return a new
instance of `ContentObjectRenderer` instead of returning a reference to
`TSFE->cObj`.

Change unit test and add prepared instance of `ContentObjectRenderer`
to `GeneralUtility` via `addInstance` method.

Resolves: #86979
Releases: master
Change-Id: Ibdb8fd1d974a525f3583929a743447a8650ca1ab
Reviewed-on: https://review.typo3.org/58661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Swap mixed up labels in admin panel page cache info 80/58980/3
Nikita Hovratov [Thu, 29 Nov 2018 13:18:45 +0000 (14:18 +0100)]
[BUGFIX] Swap mixed up labels in admin panel page cache info

Due to the fact that the translation keys for the page cache info
were double negated (noCache_no = yes) they ended up being mixed up.
This patch just swaps the labels. In v10 the keys can be renamed to
prevent confusion.

Resolves: #87039
Releases: master
Change-Id: I34f4d3aa2c0d659eee5c99c8df092260bcef7f5b
Reviewed-on: https://review.typo3.org/58980
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Add full configuration to SiteLanguage::toArray 25/59025/4
Georg Ringer [Tue, 4 Dec 2018 12:28:19 +0000 (13:28 +0100)]
[TASK] Add full configuration to SiteLanguage::toArray

Make the full configuration of a SiteLanguage available. This is required
to get access to an extended site language configuration.

To be in sync to the Site object, the property attributes is renamed to
configuration.

Resolves: #87027
Releases: master
Change-Id: I8962c5f7cafb38398bf9ded77058af38828e7182
Reviewed-on: https://review.typo3.org/59025
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Fix nested arrays in conditions 35/58935/9
Wolfgang Klinger [Fri, 23 Nov 2018 12:23:25 +0000 (13:23 +0100)]
[BUGFIX] Fix nested arrays in conditions

The RequestWrapper::getParsedBody method must return an array,
otherwise the a condition like [request.getParsedBody()['foo'] == 1]
results in a silent exception if the body is empty.

ConditionMatcher::normalizeExpression is now using an advanced regex
to handle multiple [] parts correctly.

Resolves: #86915
Releases: master
Change-Id: Ia3f951d1a3994d545025691e35521ca05b97a39a
Reviewed-on: https://review.typo3.org/58935
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Raphael Graf <r@undefined.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Styling of TCA description text with custom css selector 51/59051/4
Joerg Boesche [Fri, 7 Dec 2018 12:09:11 +0000 (13:09 +0100)]
[BUGFIX] Styling of TCA description text with custom css selector

Resolves: #87097
Releases: master
Change-Id: I1a6415c5b43e478ac90bb5f2db4437fb498fc568
Reviewed-on: https://review.typo3.org/59051
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Florian Peters <fpeters1392@googlemail.com>
Tested-by: Florian Peters <fpeters1392@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Mark changes in `selectMultipleSideBySide` 56/59056/2
Andreas Fernandez [Fri, 7 Dec 2018 18:50:39 +0000 (19:50 +0100)]
[BUGFIX] Mark changes in `selectMultipleSideBySide`

A `selectMultipleSideBySide` field is now marked as "changed" when either
the order of items has changed or when an item has been removed.

Resolves: #87082
Releases: master, 8.7
Change-Id: I9f50576270db667751c14e3513d1a7cd31c1135e
Reviewed-on: https://review.typo3.org/59056
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Set active tab when DOM is ready 55/59055/2
Andreas Fernandez [Fri, 7 Dec 2018 18:01:27 +0000 (19:01 +0100)]
[BUGFIX] Set active tab when DOM is ready

The latest used tab must be set to active only when the DOM has been
loaded.

Resolves: #84027
Releases: master
Change-Id: I52c8c190c5e58f1793335470427fc18203e4c561
Reviewed-on: https://review.typo3.org/59055
Reviewed-by: Florian Peters <fpeters1392@googlemail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Florian Peters <fpeters1392@googlemail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Update package `doctrine/instantiator` 24/58924/3
Romain Canon [Wed, 21 Nov 2018 15:03:21 +0000 (16:03 +0100)]
[TASK] Update package `doctrine/instantiator`

In parallel to TYPO3, in order to require the package
`doctrine/orm:^2.6.0` (and further), the package `doctrine/instantiator`
must be required at least with version `1.1.0`.

Used composer command: `composer req doctrine/instantiator:^1.0`

Resolves: #86965
Releases: master
Change-Id: I473caa015bc1d6431654cbb889148cd396e7412b
Reviewed-on: https://review.typo3.org/58924
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Großberger <garfieldius67@gmail.com>
Tested-by: Georg Großberger <garfieldius67@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
9 months ago[BUGFIX] Prevent double pointer parameter in record list 54/58954/2
Vladimir Falcon Piva [Mon, 26 Nov 2018 14:59:06 +0000 (15:59 +0100)]
[BUGFIX] Prevent double pointer parameter in record list

This fix makes sure that the pointer parameter is added just once into
the record list pagination urls

Resolves: #87007
Releases: master, 8.7
Change-Id: I6db00dd0af0d09277aa9a005e561330acb386809
Reviewed-on: https://review.typo3.org/58954
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
9 months ago[BUGFIX] Revert UrlEncoding for GeneralUtility functions 56/58956/5
Anja Leichsenring [Mon, 26 Nov 2018 20:42:34 +0000 (21:42 +0100)]
[BUGFIX] Revert UrlEncoding for GeneralUtility functions

URLencoding applied to linkThisScript and linkThisUrl make
links fail that are only used and executed by Javascript.
Reverting to old behavior fixes the failure.

Change-Id: I992c9c362190bb7d4f6135bab059fd7ec058d2bb
Resolves: #87010
Relates: #83334
Releases: master
Reviewed-on: https://review.typo3.org/58956
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Preben Rather Sørensen <preben@rather.dk>
Tested-by: Tim Karliczek <tkarliczek@3pc.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Add missing translation value for Modals 48/58948/8
Preben Rather Sørensen [Sun, 25 Nov 2018 19:47:00 +0000 (20:47 +0100)]
[BUGFIX] Add missing translation value for Modals

Changes syntax for translation key and add default language value.

Resolves: #87001
Releases: master, 8.7
Change-Id: I5a634aff013f6d4af68f25b8288ed04bc340e823
Reviewed-on: https://review.typo3.org/58948
Reviewed-by: Preben Rather Sørensen <preben@rather.dk>
Tested-by: Preben Rather Sørensen <preben@rather.dk>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Disable file compression for external urls in js and css includes 67/58867/3
Benjamin Kott [Wed, 7 Nov 2018 16:45:19 +0000 (17:45 +0100)]
[BUGFIX] Disable file compression for external urls in js and css includes

Resolves: #53123
Releases: master, 8.7
Change-Id: I8030e434a27ae2f2c5934706eec6f64e64e31cd3
Reviewed-on: https://review.typo3.org/58867
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
9 months ago[BUGFIX] PageLayoutView - Keep copy settings if disabled 16/59016/7
André Schließer [Mon, 3 Dec 2018 12:37:27 +0000 (13:37 +0100)]
[BUGFIX] PageLayoutView - Keep copy settings if disabled

Disable copy option if setting mod.web_layout.localization.enableCopy = 0
in all cases.

As a newly translated page has no copies or translations this variable
will be false and this results in $allowCopy = true.
To disable the copy mode the initial setting $allowCopy
is taken into account.

Resolves: #76910
Releases: master
Change-Id: I38f16a11038885c1ba0d455d7913d729e9669817
Reviewed-on: https://review.typo3.org/59016
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[FEATURE] Allow replacing strings in slug 51/58851/16
Georg Ringer [Tue, 6 Nov 2018 06:46:33 +0000 (07:46 +0100)]
[FEATURE] Allow replacing strings in slug

The new setting `replacement` makes it possible to search and replace
strings inside a slug.

Resolves: #86740
Releases: master
Change-Id: Icc8fe167fcb5d48502ace2c43e0535884bc10341
Reviewed-on: https://review.typo3.org/58851
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
9 months ago[BUGFIX] Fix return type annotation in ResourceStorage::sanitizeFileName() 49/59049/3
Andreas Fernandez [Fri, 7 Dec 2018 10:53:08 +0000 (11:53 +0100)]
[BUGFIX] Fix return type annotation in ResourceStorage::sanitizeFileName()

Resolves: #87096
Releases: master, 8.7
Change-Id: I0a46420cb910d19223a8bb133d9e7457fbd29ee2
Reviewed-on: https://review.typo3.org/59049
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Add missing RsT about existing language update tasks 34/59034/2
Josef Glatz [Wed, 5 Dec 2018 05:24:50 +0000 (06:24 +0100)]
[TASK] Add missing RsT about existing language update tasks

Add info about the manual steps to remove an existing
and add a working language:update scheduler task which
is necessary after an upgrade to TYPO3 >= 9.2

Releases: master
Resolves: #87081
Change-Id: I0970011b972239d3ebab50d6d06b1f8e33e099f5
Reviewed-on: https://review.typo3.org/59034
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Peter Kraume <peter.kraume@gmx.de>
Tested-by: Peter Kraume <peter.kraume@gmx.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix date generation in AdminPanel preview 47/59047/2
Andreas Fernandez [Thu, 6 Dec 2018 15:24:28 +0000 (16:24 +0100)]
[BUGFIX] Fix date generation in AdminPanel preview

This patch fixes multiple issues when generating a date in AdminPanel's
preview module:

- The order of the date segements is changed to have a valid ISO format
- Months are 0-based in JavaScript (0 = January, 11 = December), for this
  reason, +1 is added to have a valid date string

Resolves: #87060
Releases: master
Change-Id: Ib6a86e65b962a21eb9c033801a8711cb4f12f193
Reviewed-on: https://review.typo3.org/59047
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
9 months ago[BUGFIX] Upgrade linkhandler syntax to new link syntax 64/58964/6
Johannes Kasberger [Tue, 27 Nov 2018 16:24:56 +0000 (17:24 +0100)]
[BUGFIX] Upgrade linkhandler syntax to new link syntax

The \TYPO3\CMS\Core\LinkHandling\RecordLinkHandler::asString method
expects the parameters to hold the identifier and uid as top-level
array elements.
The legacy syntax converter now ensures that this nesting is correct.

Besides that we now also upgrade the very old linkhandler syntax
with no identifier.

Therefore we accept
 - record:<identifier>:<table>:<uid>
 - record:<table>:<uid>

Resolves: #80806
Releases: master, 8.7
Change-Id: I01c3d525de43a56d610dc882ef406de631a8762e
Reviewed-on: https://review.typo3.org/58964
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Add missing ' in InstallTool and docs 45/59045/2
Georg Ringer [Thu, 6 Dec 2018 07:26:56 +0000 (08:26 +0100)]
[BUGFIX] Add missing ' in InstallTool and docs

Resolves: #87084
Releases: master
Change-Id: I2127e0cb08ed346230818050c0f32a70ab9d72d1
Reviewed-on: https://review.typo3.org/59045
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Fix name and location of demo .htaccess file in install tool 35/59035/4
Peter Kraume [Wed, 5 Dec 2018 07:43:30 +0000 (08:43 +0100)]
[BUGFIX] Fix name and location of demo .htaccess file in install tool

Resolves: #87083
Releases: master
Change-Id: I674fb3a93c0e399124bbee7dfc0280275116bdcc
Reviewed-on: https://review.typo3.org/59035
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Remove expired cache_treelist entries during runtime 51/58951/3
Alexander Schnitzler [Mon, 26 Nov 2018 09:58:48 +0000 (10:58 +0100)]
[BUGFIX] Remove expired cache_treelist entries during runtime

When \TYPO3\CMS\Frontend\ContentObject\ContentObjectRenderer::getTreeList
checked for an existing cache_treelist entry, the given md5hash and the
expiry timestamp had been compared. As caches do not expire at all by
default, there a very few cases when an entry is actually expired.

However, if a cache entry has been expired, the cache entry hasn't been
removed and therefore the creation of a new cache entry with the same
md5hash identifier resulted in a duplicate entry exception.

To solve this, the affected, expired entry will be removed during runtime.

Releases: master, 8.7
Resolves: #86028
Resolves: #86491
Change-Id: If1a907607db29f7edd0fa77a8bb47a69bdfc0df9
Reviewed-on: https://review.typo3.org/58951
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[BUGFIX] Add getter for tsfe->pageCacheTags 22/59022/3
Daniel Goerz [Tue, 4 Dec 2018 07:53:11 +0000 (08:53 +0100)]
[BUGFIX] Add getter for tsfe->pageCacheTags

Resolves: #87066
Releases: master, 8.7
Change-Id: I9ed1d82d03f3518018699402d5b3a93930e49457
Reviewed-on: https://review.typo3.org/59022
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Fix code examples in MetaTagManager docs 21/59021/3
Georg Ringer [Tue, 4 Dec 2018 07:11:43 +0000 (08:11 +0100)]
[TASK] Fix code examples in MetaTagManager docs

The code of the MetaTagManager changed with #85197 and the docs need to be
adopted.

Resolves: #86924
Releases: master
Change-Id: If69a7e1d349845d9d0caa351ed67dab6e693c3ac
Reviewed-on: https://review.typo3.org/59021
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Fix docs for site base variants to include protocol 20/59020/2
Benni Mack [Tue, 4 Dec 2018 06:19:01 +0000 (07:19 +0100)]
[BUGFIX] Fix docs for site base variants to include protocol

The introduction of base variants included wrong docs, as
the site base + base variants should always include the scheme
for the base URL as well.

Resolves: #87065
Releases: master
Change-Id: I5709761e0787a4753b57b28ccc421c279fd88b2c
Reviewed-on: https://review.typo3.org/59020
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Initialize language key in AbstractPlugin 18/59018/6
Georg Ringer [Mon, 3 Dec 2018 17:52:33 +0000 (18:52 +0100)]
[BUGFIX] Initialize language key in AbstractPlugin

The AbstractPlugin must check SiteLanguage first for
current language key and use the TypoScript only
as fallback.

Resolves: #87063
Releases: master
Change-Id: I4a4f60c2fb2c759bece2aacc4a287ba006a8165c
Reviewed-on: https://review.typo3.org/59018
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Allow accessing object from `ObjectStorage` with numeric value 72/58972/7
Romain Canon [Wed, 28 Nov 2018 16:52:38 +0000 (17:52 +0100)]
[BUGFIX] Allow accessing object from `ObjectStorage` with numeric value

The following code now works:

```php
$objectStorage = new \TYPO3\CMS\Extbase\Persistence\ObjectStorage();
$objectStorage->attach(new \stdClass());
$myObject = $objectStorage->offsetGet(0);
```

And more importantly, the following Fluid code works as well:

<f:image image="{myObject.resources.0}" alt="My image!" />

Resolves: #87028
Releases: master, 8.7
Change-Id: I15890a16540ff2e39a5e48ed83f96a1443bc98ac
Reviewed-on: https://review.typo3.org/58972
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Disable extension updates in Composer mode 21/58921/4
Nicole Cordes [Tue, 20 Nov 2018 22:17:15 +0000 (23:17 +0100)]
[BUGFIX] Disable extension updates in Composer mode

Resolves: #86958
Releases: master, 8.7
Change-Id: Ib0f51088d42ab3dba014efcbd4c702447d75f984
Reviewed-on: https://review.typo3.org/58921
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Support DateTimeInterface in DebuggerUtility 49/58949/2
Andreas Wolf [Mon, 26 Nov 2018 08:38:34 +0000 (09:38 +0100)]
[BUGFIX] Support DateTimeInterface in DebuggerUtility

Change-Id: Ib38107456acd0f0535dc51083006ee77c5a81c17
Resolves: #87002
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/58949
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Deprecate dependency injection with non public properties 81/58881/3
Alexander Schnitzler [Mon, 3 Dec 2018 12:48:24 +0000 (13:48 +0100)]
[BUGFIX] Deprecate dependency injection with non public properties

Using non public properties for dependency injection has been
deprecated. While dependency injection with public properties
still works, it is recommended to switch to constructor or
setter injection.

Releases: master
Resolves: #86907
Change-Id: I48b076cd4594cd94aeec7be4973b7102e1eab2f5
Reviewed-on: https://review.typo3.org/58881
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Give Record browser more UX space 84/58984/2
Benni Mack [Thu, 29 Nov 2018 16:04:59 +0000 (17:04 +0100)]
[BUGFIX] Give Record browser more UX space

The Record Browser (modal popups) wastes a
lot of space, and is not in line with the
rest of the TYPO3 Backend UX.

This patch fixes various issues regarding
- Trees do not have headlines anymore
- Filter box is simpler
- Icon is aligned with text next to it

Resolves: #87043
Releases: master
Change-Id: I9f7592912c4677e723e6662ccf0965940898083e
Reviewed-on: https://review.typo3.org/58984
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Only show pages of current language in XML sitemap 42/58942/7
Richard Haeser [Fri, 23 Nov 2018 20:48:58 +0000 (21:48 +0100)]
[BUGFIX] Only show pages of current language in XML sitemap

Because pages of other languages have the page id of the default language
as the parent id, we need to search for the default language only pages
to show up in the initial pagetree.

Resolves: #86961
Related: #87020
Releases: master
Change-Id: I631f900de3f11499568d4f33eec7eabfe760cb1c
Reviewed-on: https://review.typo3.org/58942
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[FEATURE] Allow to override htmlTag attributes 76/58976/3
Benni Mack [Thu, 29 Nov 2018 06:47:13 +0000 (07:47 +0100)]
[FEATURE] Allow to override htmlTag attributes

The new Site handling functionality should ideally avoid
TypoScript conditions as much as possible. However,
if someone wanted to add attributes via config.htmlTag_setParams
all language-dependant properties (e.g. dir and lang) which
are generated by the site configuration are gone, leading to the
way of having to workaround this issue by using stdWrap or conditions)

In order to re-implement this functionality but also build on a
more flexible level, a new TypoScript property
"config.htmlTag.attributes." is added, which is an array
for setting attributes to the <html> tag dynamically.

This superseds the previous config.htmlTag_setParams option
by providing a more flexible API to add attributes.

`config.htmlTag.attributes.class = no-js`

It is even possible to add attributes without a value:
`config.htmlTag.attributes.amp = `

would render `<html lang="en" amp>` - keeping the existing
parameters that are set by other TypoScript anyways.

Resolves: #87033
Releases: master
Change-Id: I6a18671fffbf97aab8d3dda938dc261706e4e6fd
Reviewed-on: https://review.typo3.org/58976
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Load AdditionalFactoryConfiguration.php again 77/58977/4
Mathias Brodala [Thu, 29 Nov 2018 09:34:22 +0000 (10:34 +0100)]
[BUGFIX] Load AdditionalFactoryConfiguration.php again

This file is placed in "typo3conf" just like the other configuration
files and must be loaded accordingly.

Resolves: #87035
Relates: #85560
Releases: master
Change-Id: I7db72a3c1b29f79fb242f1e5da21ec7d77614bfe
Reviewed-on: https://review.typo3.org/58977
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[TASK] Clean up comments in FAL 95/58995/2
Benni Mack [Thu, 29 Nov 2018 21:17:25 +0000 (22:17 +0100)]
[TASK] Clean up comments in FAL

Resolves: #87044
Releases: master
Change-Id: I755bbe42cd1a89369e17e06c1b836690a28b970e
Reviewed-on: https://review.typo3.org/58995
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Make meta data editable for non-writable storages 74/42874/9
Nicole Cordes [Tue, 25 Aug 2015 16:29:28 +0000 (18:29 +0200)]
[BUGFIX] Make meta data editable for non-writable storages

Decouple check for writable files/storage from permission
to edit meta data. Permission to edit meta data is now
only denied when users have only access to the file
via a readonly file mount.

Resolves: #65636
Resolves: #66507
Releases: master, 8.7
Change-Id: I25a0fbc9cf761898dbdb95dec1d3d39bb2f4b7fd
Reviewed-on: https://review.typo3.org/42874
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[BUGFIX] Catch exception in getData with invalid key for site configuration 47/58947/3
Georg Ringer [Sun, 25 Nov 2018 18:47:20 +0000 (19:47 +0100)]
[BUGFIX] Catch exception in getData with invalid key for site configuration

Catch the exception which is thrown if provided path does not exist in
site configuration. Especially if the site configuration is extended
and the desired configuration is not yet persisted the frontend must
be still available.

The exception is logged to be able to find the error.

Resolves: #86978
Releases: master
Change-Id: Iad70acc8a76e0f77875c2cfb6deb67e3afea584a
Reviewed-on: https://review.typo3.org/58947
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
9 months ago[TASK] Update bamboo to gerrit notification url 70/58970/3
Christian Kuhn [Wed, 28 Nov 2018 15:21:23 +0000 (16:21 +0100)]
[TASK] Update bamboo to gerrit notification url

Resolves: #87026
Releases: master, 8.7, 7.6
Change-Id: Idfbf4bbf0bab8a6e4bedc37e92903ed2c85af494
Reviewed-on: https://review.typo3.org/58970
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Allow `<s>` tag in RTE processing 57/58957/2
Andreas Fernandez [Tue, 27 Nov 2018 09:40:32 +0000 (10:40 +0100)]
[BUGFIX] Allow `<s>` tag in RTE processing

`lib.parseFunc` is now capable of handling the `<s>` tag by adding it to
`allowTags`. The list already contains `<strike>`, but this is a
non-valid tag in HTML5. For compatibility reasons, both tags exist now.

Resolves: #87012
Releases: master, 8.7
Change-Id: I113b7721c9483735dff0875f8c7bffb276f09e5b
Reviewed-on: https://review.typo3.org/58957
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
9 months ago[BUGFIX] Only fetch default language page for tree lists 67/58967/4
Benni Mack [Wed, 28 Nov 2018 07:03:05 +0000 (08:03 +0100)]
[BUGFIX] Only fetch default language page for tree lists

Due to the removal of pages_language_overlay the queries
for fetching trees have to work as before - mainly because the
concept of the "pid" (= storagePid) works the same - records on a
page have the pid of the default language, not of any translation.

Therefore, the used queries have to be built to check for
sys_language_uid=0.

Resolves: #87020
Related: #86961
Releases: master
Change-Id: Ie7740b6a32618a213d569362a58b9f8e5ed7824d
Reviewed-on: https://review.typo3.org/58967
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
9 months ago[BUGFIX] Correct label for aspect ratio 1.91:1 61/58961/2
Josef Glatz [Tue, 27 Nov 2018 13:33:13 +0000 (14:33 +0100)]
[BUGFIX] Correct label for aspect ratio 1.91:1

Releases: master
Resolves: #87017
Change-Id: I6af6cceab344cd54bace6547505e555ece81efe3
Reviewed-on: https://review.typo3.org/58961
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Drop GROUP BY clause in Info > PageTS Config 62/58962/5
Andreas Fernandez [Tue, 27 Nov 2018 15:18:22 +0000 (16:18 +0100)]
[BUGFIX] Drop GROUP BY clause in Info > PageTS Config

The GROUP BY clause used in InfoPageTypoScriptConfigController's
`getOverviewOfPagesUsingTSConfig()` is dropped, as grouping by
a unique value doesn't make any sense.

Resolves: #87019
Related: #76484
Releases: master, 8.7
Change-Id: I0054064fb6f0bba9b65737bf323db364377bb4e6
Reviewed-on: https://review.typo3.org/58962
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months ago[TASK] Log a warning if fluid-based preview template couldn't be rendered 60/58960/6
Josef Glatz [Tue, 27 Nov 2018 12:24:32 +0000 (13:24 +0100)]
[TASK] Log a warning if fluid-based preview template couldn't be rendered

A warning is logged if the fluid-based preview template for a
content element could not be rendered.

The logged warning includes
- the UID of the content element
- the resulting path to the template file
- and the exception message

Resolves: #87015
Releases: master, 8.7
Change-Id: I2cd100a5140a07845145b16259b7cbe3e5eed852
Reviewed-on: https://review.typo3.org/58960
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Grein <alexander.grein@gmail.com>
Tested-by: Alexander Grein <alexander.grein@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
9 months ago[BUGFIX] Enlarge scheduler object DB field 53/58953/2
Benni Mack [Mon, 26 Nov 2018 14:51:45 +0000 (15:51 +0100)]
[BUGFIX] Enlarge scheduler object DB field

The serialized PHP object is stored within the database field
"serialized_task_object". When serializing this could lead to several
issues.

One particular issue is that the object has lots of data or dependencies,
it cannot be stored at all in this database field.

Although we know that this implementation detail of scheduler is a rather
bad idea, we can only fix this by enlarging the field from "blob" to
"mediumblob" for now.

Resolves: #87006
Releases: master, 8.7
Change-Id: I2b335f258fe18b494033bde28eff76f2e67d34bb
Reviewed-on: https://review.typo3.org/58953
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
9 months agoRevert "[BUGFIX] Improve Performance for Inline Elements" 36/58936/3
Oliver Hader [Fri, 23 Nov 2018 12:38:31 +0000 (13:38 +0100)]
Revert "[BUGFIX] Improve Performance for Inline Elements"

This reverts commit be62d64d6b17b51b997cd88c5da7805587fc93db.

The fix introduced breaking behavior on for additional processings like
`label_userFunc` based on the expanded/collapsed state (which is stored
in the users `uc` blob).

Change-Id: I12a31391fd3f6e50946d0f98d21939a501a95eee
Releases: master
Related: #82100
Reviewed-on: https://review.typo3.org/58936
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Fix full example in `Feature-86826-RecursiveRecordSitemap` 29/58929/2
Andreas Fernandez [Wed, 21 Nov 2018 20:21:41 +0000 (21:21 +0100)]
[BUGFIX] Fix full example in `Feature-86826-RecursiveRecordSitemap`

Some missing TypoScript is added to the documentation file
`Feature-86826-RecursiveRecordSitemap.rst` to get an additional,
functional sitemap.

Resolves: #86971
Releases: master
Change-Id: I48711f176fdb7345d02946f1bc666a0c751a54cc
Reviewed-on: https://review.typo3.org/58929
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
10 months ago[BUGFIX] User Setup: Check if languages have been configured 27/58927/3
Andreas Fernandez [Wed, 21 Nov 2018 19:11:29 +0000 (20:11 +0100)]
[BUGFIX] User Setup: Check if languages have been configured

On a fresh installation of TYPO3, no system languages are configured
which breaks the "User Setup" module. An additional check for
`EXTCONF/lang/availableLanguages` is added to fix the issue.

Resolves: #86970
Related: #86796
Releases: master
Change-Id: I5ac39ce2b3a7705d29844ea1805a304af58d839f
Reviewed-on: https://review.typo3.org/58927
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
10 months ago[BUGFIX] Fix outdated link in docs 16/58916/3
Philipp Kitzberger [Tue, 20 Nov 2018 09:37:35 +0000 (10:37 +0100)]
[BUGFIX] Fix outdated link in docs

That linked resource is just not available under that URL anymore.

Releases: master, 8.7
Resolves: #86951
Change-Id: I22ca04e00d7ce74f5d3a7f072c27d20bbfd193a2
Reviewed-on: https://review.typo3.org/58916
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
10 months ago[BUGFIX] Remove unused `fieldChangeFunc` in GroupElement 10/58910/2
Andreas Fernandez [Sun, 18 Nov 2018 19:47:01 +0000 (20:47 +0100)]
[BUGFIX] Remove unused `fieldChangeFunc` in GroupElement

The class GroupElement defines a `fieldChangeFunc` which is unused in
this context. Since this never caused an issue, it's assumed to be save
to remove the change handler.

This allows further cleanup in the FormEngine JavaScript land, e.g.
deprecating `setFormValueManipulate()`.

Resolves: #86948
Releases: master
Change-Id: I51f8c0c6bf3cd383ba2e12e29f329ceb979a9799
Reviewed-on: https://review.typo3.org/58910
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Strip tags only from strings in ArrayUtility::stripTagsFromValuesRecursive 00/58900/8
Wolfgang Klinger [Thu, 15 Nov 2018 16:45:15 +0000 (17:45 +0100)]
[BUGFIX] Strip tags only from strings in ArrayUtility::stripTagsFromValuesRecursive

Prevent an implicit type cast to string through strip_tags.
Ignore any scalar values other than string,
but preserve the possibility of an object's __toString conversion.

Resolves: #86938
Releases: master, 8.7
Change-Id: I27cb7834dc9e838f60f0d1bda94ab2c4e4011043
Reviewed-on: https://review.typo3.org/58900
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer<strong style="color:red">x</strong> <georg.ringer@gmail.com>
Tested-by: Georg Ringer<strong style="color:red">x</strong> <georg.ringer@gmail.com>
10 months ago[TASK] Check number of file extensions 07/58907/3
Guido Schmechel [Fri, 16 Nov 2018 21:46:34 +0000 (22:46 +0100)]
[TASK] Check number of file extensions

Show the add media and text form only if at least
one file extension exists.

Resolves: #86925
Releases: master, 8.7
Change-Id: I37c23800f1ddda78b7f248c0de9e970a73976c4a
Reviewed-on: https://review.typo3.org/58907
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[TASK] Add searchFields in TCA for sys_news, sys_action and sys_note 05/58905/5
Wolfgang Klinger [Fri, 16 Nov 2018 17:06:02 +0000 (18:06 +0100)]
[TASK] Add searchFields in TCA for sys_news, sys_action and sys_note

Resolves: #86932
Releases: master, 8.7
Change-Id: Ic699b0af99fb73bfdb91e3dbbb3e6f3e41335b5b
Reviewed-on: https://review.typo3.org/58905
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] CSS selector in extension configuration modal too specific 99/58899/4
Jonas Eberle [Thu, 15 Nov 2018 15:10:44 +0000 (16:10 +0100)]
[BUGFIX] CSS selector in extension configuration modal too specific

The .typo3-install class is not present in the current modal. This
re-introduces the margin above the "save" button.

Resolves: #86893
Releases: master
Change-Id: I4b8c291742636dd19e48fcf259de0ab65f8a1b3b
Reviewed-on: https://review.typo3.org/58899
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
10 months ago[BUGFIX] Cast file resource pointer in UploadFileReferenceConverter 68/58868/3
Georg Ringer [Wed, 7 Nov 2018 21:39:40 +0000 (22:39 +0100)]
[BUGFIX] Cast file resource pointer in UploadFileReferenceConverter

The return value of the hmac check is a string and must be casted to
an integer as the method using the value requires an integer.

Resolves: #86878
Releases: master, 8.7
Change-Id: Ic6db911c213eb668141ba0c849ff8a627a6f94dc
Reviewed-on: https://review.typo3.org/58868
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>