Packages/TYPO3.CMS.git
8 months ago[BUGFIX] Set BackendUserAspect earlier to make it usable in TSConfig 75/58275/3
Frank Naegler [Fri, 14 Sep 2018 11:01:41 +0000 (13:01 +0200)]
[BUGFIX] Set BackendUserAspect earlier to make it usable in TSConfig

This patch fix broken TSConfig condition because of missing backend user aspect.

Resolves: #86229
Releases: master
Change-Id: I6528b5d48a5b5711cad8710d4bfcc6222f9fef9c
Reviewed-on: https://review.typo3.org/58275
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Correct condition in TemplateService 77/58277/3
Christian Kuhn [Fri, 14 Sep 2018 12:22:38 +0000 (14:22 +0200)]
[BUGFIX] Correct condition in TemplateService

Issue #85092 introduced a copy & paste bug in TemplateService.

Resolves: #86255
Related: #85092
Releases: master
Change-Id: If0d92e0886e625db8793991f264628030ccfdad4
Reviewed-on: https://review.typo3.org/58277
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[TASK] Use SiteFinder in EXT:felogin 57/58257/5
Georg Ringer [Wed, 12 Sep 2018 18:06:46 +0000 (20:06 +0200)]
[TASK] Use SiteFinder in EXT:felogin

Instead of only checking the sys_domains with a database query
the SiteFinder and PseudoSiteFinder should be used.

Resolves: #86219
Releases: master
Change-Id: I99f9367258f9b19ef3a1310cb2fd61076083333c
Reviewed-on: https://review.typo3.org/58257
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
8 months ago[TASK] Migrate extension install upgrade wizards to new API 33/58233/4
Susanne Moog [Wed, 5 Sep 2018 21:22:34 +0000 (23:22 +0200)]
[TASK] Migrate extension install upgrade wizards to new API

Migrates all upgrade wizards based on the
`AbstractDownloadExtensionUpdate` class to the new API.

Related: #86172
Resolves: #86199
Releases: master
Change-Id: I79ffa702a1448bb66324074ef2debf41922d95e8
Reviewed-on: https://review.typo3.org/58233
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
8 months ago[BUGFIX] Make JavaScript of SlugElement a real independent instance 73/58273/4
Andreas Fernandez [Fri, 14 Sep 2018 08:17:23 +0000 (10:17 +0200)]
[BUGFIX] Make JavaScript of SlugElement a real independent instance

The JavaScript for the SlugElement is partially designed to be a
independent instance for each slug field. However, this does not work for
mass editing the slug fields, as the `initialize()` method is always
called on the same instance.

This patch does multiple things:

- The JavaScript is converted to a TypeScript basis, which allows better
  handling of each instance
- The "Regenerate slug" button is disabled in case the "feeder" fields
  are not available to avoid getting bogus values

Resolves: #86221
Releases: master
Change-Id: I458247beb597c77407e94ce633314ae2e2d7095a
Reviewed-on: https://review.typo3.org/58273
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
8 months ago[TASK] Make hreflang links absolute 62/58262/5
Richard Haeser [Wed, 12 Sep 2018 20:51:46 +0000 (22:51 +0200)]
[TASK] Make hreflang links absolute

Create absolute URL's for the hreflang links by using the configuration
of the current site.

Resolves: #86224
Releases: master
Change-Id: Id3196542875862b20145418956fcfdfcc3834241
Reviewed-on: https://review.typo3.org/58262
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: Kevin Appelt <kevin.appelt@icloud.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
8 months ago[BUGFIX] Do not show wizards marked as done in install tool 70/58270/3
Susanne Moog [Thu, 13 Sep 2018 16:56:29 +0000 (18:56 +0200)]
[BUGFIX] Do not show wizards marked as done in install tool

Wizards marked as done are no longer displayed as executable
in the install tool, the missing state check has been included.

Resolves: #86246
Releases: master
Change-Id: Ic86910379f3bc2994f87a8408e81e32d5f28729a
Reviewed-on: https://review.typo3.org/58270
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Use correct language in l18n_cfg checks 67/58267/8
Daniel Goerz [Thu, 13 Sep 2018 13:12:25 +0000 (15:12 +0200)]
[BUGFIX] Use correct language in l18n_cfg checks

The check for pages.l18n_cfg is wrong now, as this is
always done against pages.sys_language_uid=0 records (as
"resolvePage" is called right before).

So, these if-statements have to go further south.

On top, the getPageOverlay call needs to be done - on top.

resolvePage -> get default language of page
getPageOverlay -> put the wanted translation on top

A fix for pages.alias has to be in place, as DataHandler
cannot handle pages.alias yet.

Resolves: #86242
Releases: master
Change-Id: Ief99e5f934f6e9d31973b9543cb9a6e599d2d33c
Reviewed-on: https://review.typo3.org/58267
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Use class name to mark upgrade wizards done 97/58197/4
Helmut Hummel [Thu, 6 Sep 2018 10:15:24 +0000 (12:15 +0200)]
[BUGFIX] Use class name to mark upgrade wizards done

To make the registry for done wizards consistent and stay backwards
compatible once all upgrade wizards are converted to use the
new interface, always store the class name of the wizard
instead of its identifier in the registry.

Additionally we now add checks for valid identifiers
to all API methods that receive one.

Releases: master
Resolves: #86165
Change-Id: I402852c90f5a8d3d0a05bacbd961a4bb4cb86d1e
Reviewed-on: https://review.typo3.org/58197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Adapt view related install tool details 69/58269/6
Christian Kuhn [Thu, 13 Sep 2018 14:35:42 +0000 (16:35 +0200)]
[BUGFIX] Adapt view related install tool details

With the install tool move to modals, various details on CSS
level broke: The modal HTML is on top level in backend and thus
not within the content-iframe, so styles defined in install.css
loaded in the iframe do not kick in. Since the standalone install
tool does not use iframes, there are various differences on view
level between standalone and embedded-in-backend version, usually
with the embedded version looking more ugly than standalone.

The install.css is not very different from backend.css anyway,
so we resolve various details with the patch, kick install.css
entirely and rely soley on backend.css, even for the installer.

Details:
* <hr> shows a border again in modals in embedded, broken since
  modal patch
* image processing view has borders and other details again in
  embedded verision, broken since modal patch
* removed 'fixed save button location' for 'all configuration' code.
  This broke with the modal patch, the code does not do anything
  useful at the moment. A solution needs a change of the modal js
  to render the buttons to modal-footer instead. This is too complex
  for this patch and may be done with another patch.
* A couple of classes to easily limit styles to installer and
  maintenance parts
* Remove left overs from old install-tool menu approach that
  have not been cleanup up, yet.

Resolves: #86245
Related: #84772
Releases: master
Change-Id: I4d21677331112a48f84b0cf48a574999128a15b7
Reviewed-on: https://review.typo3.org/58269
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Add postProcessMirrorUrl to language updater again 65/58265/2
Christian Kuhn [Thu, 13 Sep 2018 11:25:41 +0000 (13:25 +0200)]
[BUGFIX] Add postProcessMirrorUrl to language updater again

With moving the language pack updater to the install tool, a
signal got lost that allowed overriding the base download url
of language packs per extension.
The patch introduces this signal again.

Resolves: #84691
Related: #84131
Releases: master
Change-Id: I659a8829b292d9c268ee3ee9df851d971ba5ddd7
Reviewed-on: https://review.typo3.org/58265
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Delius <me@jandelius.eu>
Tested-by: Jan Delius <me@jandelius.eu>
Reviewed-by: Rico Drexler <rico.drexler@gmx.de>
Tested-by: Rico Drexler <rico.drexler@gmx.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Use SiteFinder for fetching related domain in page tree 93/58193/11
Georg Ringer [Wed, 5 Sep 2018 18:16:23 +0000 (20:16 +0200)]
[TASK] Use SiteFinder for fetching related domain in page tree

The SiteFinder retrieves the correct domain for root pages
also for pages having a site configuration.

Resolves: #86158
Releases: master
Change-Id: If99da2deea08ca7bbe05c13f37472a070ffc6d62
Reviewed-on: https://review.typo3.org/58193
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
8 months ago[BUGFIX] Evaluate config.defaultGetVars in middleware 66/58266/3
Benni Mack [Thu, 13 Sep 2018 11:41:29 +0000 (13:41 +0200)]
[BUGFIX] Evaluate config.defaultGetVars in middleware

The config.defaultGetVars is executed and $_GET is modified,
but not the middleware where this method is called.

In order to also modify the middleware's request object, the
option config.defaultGetVars is also evaluted again in the PSR-15
middleware.

Resolves: #86241
Related: #86046
Releases: master
Change-Id: I2238d93b4974a40b2228c099cef7c8a04bd6cf74
Reviewed-on: https://review.typo3.org/58266
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Sattler <sattler@b13.de>
Tested-by: Daniel Sattler <sattler@b13.de>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Allow recycler page in rootline in BE 43/58243/5
Susanne Moog [Wed, 12 Sep 2018 16:15:25 +0000 (18:15 +0200)]
[BUGFIX] Allow recycler page in rootline in BE

The recycler doktype should be allowed in rootline in BE.

Resolves: #86209
Releases: master
Change-Id: I173c2deca5cd395d566a6fd9d6499538ef20d2e6
Reviewed-on: https://review.typo3.org/58243
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Bring back the exception code in exception messages 60/58260/4
Anja Leichsenring [Wed, 12 Sep 2018 18:38:46 +0000 (20:38 +0200)]
[TASK] Bring back the exception code in exception messages

If an exception identifies itself with a code, display it
next to the Exception title.

Change-Id: Ib24b7ce4e0bef426dd4e0f4b7f25c4f5338e02c6
Resolves: #86238
Releases: master
Reviewed-on: https://review.typo3.org/58260
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Bring back the paths in exception messages 58/58258/6
Susanne Moog [Wed, 12 Sep 2018 18:14:19 +0000 (20:14 +0200)]
[TASK] Bring back the paths in exception messages

Resolves: #86237
Releases: master
Change-Id: Id139dcabb6367b03fb5584a6c7d4a673595eb88e
Reviewed-on: https://review.typo3.org/58258
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[BUGFIX] Fix undefined variable $applicationContext in Bootstrap.php 56/58256/2
Tymoteusz Motylewski [Wed, 12 Sep 2018 15:13:55 +0000 (17:13 +0200)]
[BUGFIX] Fix undefined variable $applicationContext in Bootstrap.php

Resolves: #86235
Releases: master
Change-Id: I1e75309abd8bc1aa38d861dae4a48a958b9750dd
Reviewed-on: https://review.typo3.org/58256
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Fix code formatting changelog rst files 54/58254/4
Tymoteusz Motylewski [Wed, 12 Sep 2018 11:32:55 +0000 (13:32 +0200)]
[TASK] Fix code formatting changelog rst files

Double backticks are now replace with single ones,
fixed some typos like missing colon.

Resolves: #86233
Releases: master
Change-Id: I5889a285a5b9a7d65b8bcf7931801298d539e9df
Reviewed-on: https://review.typo3.org/58254
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Deprecate BaseScriptClass and AbstractFunctionModule 49/58249/3
Christian Kuhn [Mon, 10 Sep 2018 21:48:19 +0000 (23:48 +0200)]
[TASK] Deprecate BaseScriptClass and AbstractFunctionModule

With latest refactorings, the good old backend module classes
BaseScriptClass (t3lib_SCbase) and AbstractFunctionModule
(t3lib_extobjbase) are finally unused.
These spaghetti classes have been a hindrance to refactor
modules that used them for a long time already due to their
hard to follow code flow, bad method namings, global variable
usages and having everything declared public.
It's time to get rid of them to unlock refactoring of controllers
and allow dropping of various global variables in v10.

Resolves: #86225
Releases: master
Change-Id: I3b5bb35b693c7991052f4e0855c2aae4e39f02a1
Reviewed-on: https://review.typo3.org/58249
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Deprecate @internal annotation in extbase commands 39/58039/7
Alexander Schnitzler [Sat, 25 Aug 2018 15:35:38 +0000 (17:35 +0200)]
[TASK] Deprecate @internal annotation in extbase commands

The @internal annotation – which is a regular phpDocumentor annotation
that is used to denote that associated structural elements are elements
internal to the application or library, has been misused by extbase to
tell if a command is internal and thus should not be exposed through
help texts, user documentation etc. – is deprecated without any
replacement.

TYPO3 does no longer support the use of the @internal annotation to
influence the behaviour of the code.

Releases: master
Resolves: #85980
Change-Id: I7f3b998b56e270b30e5193d494d35329f5608603
Reviewed-on: https://review.typo3.org/58039
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Catch non existing directories for import syntax 51/58251/2
Georg Ringer [Tue, 11 Sep 2018 17:27:05 +0000 (19:27 +0200)]
[BUGFIX] Catch non existing directories for import syntax

Catch exceptions for non existing directories which are imported using
the @import syntax for TypoScript and return those as warning in the
template module.

Resolves: #86230
Releases: master
Change-Id: Ie4a6376407eeeaa7a717cb01ede5cabefa8a443f
Reviewed-on: https://review.typo3.org/58251
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Add method getBase to SiteInterface 50/58250/2
Georg Ringer [Tue, 11 Sep 2018 05:53:06 +0000 (07:53 +0200)]
[TASK] Add method getBase to SiteInterface

Resolves: #86226
Releases: master
Change-Id: Idcffc65e6e040ab4f09e352f268aa4919c2abc59
Reviewed-on: https://review.typo3.org/58250
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Readd missing initialisation of $tsfe 52/58252/2
Georg Ringer [Tue, 11 Sep 2018 17:39:04 +0000 (19:39 +0200)]
[BUGFIX] Readd missing initialisation of $tsfe

During the refactoring of #85543 a line too much has been removed.
Readd the initialisation of $tsfe.

Resolves: #86223
Releases: master
Change-Id: Icd7bf93fe1d04e845b4a8cc497f171c7429d0d55
Reviewed-on: https://review.typo3.org/58252
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[FEATURE] Use utf8mb4 on mysql for new instances 40/56440/10
Lienhart Woitok [Fri, 23 Mar 2018 12:54:40 +0000 (13:54 +0100)]
[FEATURE] Use utf8mb4 on mysql for new instances

If installing a new TYPO3 instance on mysql, utf8mb4 is now used as
default charset for the database connection and as default collation.

Upgraders may change LocalConfiguration to use utf8mb4, too. They
however need to take care of changing their collations and setting
according table detaults on their own.

A reports status check verifies there is no mixed collation.

Resolves: #80398
Resolves: #82080
Resolves: #82551
Releases: master
Change-Id: I6bf464a22c6ed74631bf5aacff9c2cfe670077da
Reviewed-on: https://review.typo3.org/56440
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Lienhart Woitok <lienhart.woitok@netlogix.de>
Tested-by: Lienhart Woitok <lienhart.woitok@netlogix.de>
Reviewed-by: Georg Großberger <garfieldius67@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
8 months ago[TASK] Deprecate cObject FILE 28/58028/5
Benni Mack [Fri, 24 Aug 2018 16:14:04 +0000 (18:14 +0200)]
[TASK] Deprecate cObject FILE

The cObject FILE has a strange behaviour, and rather became low-level since
Fluid's rise in rendering Frontend.

FILE shows an image if the file is jpg,jpeg,gif,png (but not SVG), and if has a
different file ending, it will check if the file is less than 1MB, it will get its contents
and output that. If the file is 1 byte bigger, nothing is done.

This _magic_ is sketchy, and obsolete, as Fluid offers more flexibility nowadays.

Thus, cObject FILE will be removed from TYPO3 Core in v10.0, however due
to the flexibility of custom cObject, an extension author could just re-implement
the functionality in a custom extension within minutes.

Resolves: #85970
Releases: master
Change-Id: I792ec89486e29051da478c5ec0855d2f9cf913a1
Reviewed-on: https://review.typo3.org/58028
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Add functional tests for copying a record into another language 46/58246/7
Oliver Hader [Mon, 10 Sep 2018 14:40:21 +0000 (16:40 +0200)]
[TASK] Add functional tests for copying a record into another language

The expected behavior is that the copied record is not synchronized
when modifying the language parent record (since it is not in connected
mode).

Resolves: #86215
Releases: master, 8.7
Change-Id: Ibf58dd6daf877b172aea5c31ead8ea1277834bfc
Reviewed-on: https://review.typo3.org/58246
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Protect info extension 41/58241/2
Christian Kuhn [Sun, 9 Sep 2018 19:04:16 +0000 (21:04 +0200)]
[TASK] Protect info extension

Last patch in the protect controller patch series. This time the
Web->Info module controller no longer extends BaseScriptClass and
the single sub controller classed don't extend AbstractFunctionModule
anymore. The patch sets as much as possible to protected to allow
further refactoring of these classes in v10.

Resolves: #86210
Releases: master
Change-Id: I5c474e6cc0bc093c58b2e939e408b47020547a6b
Reviewed-on: https://review.typo3.org/58241
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Protect tstemplate extension 40/58240/2
Christian Kuhn [Sun, 9 Sep 2018 15:42:23 +0000 (17:42 +0200)]
[TASK] Protect tstemplate extension

The patch disentangles the tstemplate extension controller
classes. The main controller class no longer extends
BaseScriptClass and the sub controllers no longer extend
AbstractFunctionModule. The classes set as many properties
and methods to protected to allow further refactoring of this
module in v10.

Resolves: #86207
Releases: master
Change-Id: If9ad462a423be5f0e370e0894ebb848b822ee66b
Reviewed-on: https://review.typo3.org/58240
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Protect TaskModuleController Part 2 39/58239/3
Christian Kuhn [Sun, 9 Sep 2018 11:06:22 +0000 (13:06 +0200)]
[TASK] Protect TaskModuleController Part 2

TaskModuleController no longer extends BaseScriptClass. Properties
and methods are copied over to the controller and most of them are
set to protected. An instance of the controller class is given
to single class that fetch and set the one or the other information,
so not everything can be made protected. The patch should still
allow us to have more refactoring freedom in v10 in this area.

Resolves: #86204
Related: #86182
Releases: master
Change-Id: I171b22ddbcee67205234b6ca23acf9c95da6ac1b
Reviewed-on: https://review.typo3.org/58239
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Use 403 header instead of 401 header 99/57399/3
Markus Klein [Wed, 27 Jun 2018 17:00:12 +0000 (19:00 +0200)]
[BUGFIX] Use 403 header instead of 401 header

The usage of a 401 header must be accompanied by a valid
www-authenticate header, which does not support form-based logins.

Resolves: #85411
Releases: master, 8.7
Change-Id: I71062c58a7d846214f1fec41e78cce4ae72955f3
Reviewed-on: https://review.typo3.org/57399
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[BUGFIX] Prevent fatal error in DebugExceptionHandler 42/58242/2
Nicole Cordes [Sun, 9 Sep 2018 20:42:58 +0000 (22:42 +0200)]
[BUGFIX] Prevent fatal error in DebugExceptionHandler

This patch fixes an error if no argument was given for a trace step.

Resolves: #86211
Releases: master
Change-Id: Iee26940df2c463fc0badde245f9da92e73f6740e
Reviewed-on: https://review.typo3.org/58242
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Protect ImportExportController 28/58228/3
Christian Kuhn [Sat, 8 Sep 2018 12:04:16 +0000 (14:04 +0200)]
[TASK] Protect ImportExportController

To gain freedom in v10 refactoring this controller, the class
no longer extends BaseScriptClass, copies over properties and
methods from the base class and sets them to protected.

Resolves: #85031
Releases: master
Change-Id: I3c71ede5f2e00e93b5dc5cd0c9c540540d7e5058
Reviewed-on: https://review.typo3.org/58228
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Protect RecordListController 31/58231/2
Christian Kuhn [Sat, 8 Sep 2018 13:55:32 +0000 (15:55 +0200)]
[TASK] Protect RecordListController

Protect properties and methods of RecordListController. The two
hooks 'drawHeaderHook' and 'drawFooterHook' now receive an instance
of the PSR-7 request, handing over the parent object is deprecated
and will be removed in v10.
The sys_notes hooks are adapted accordingly and used as a migration
example in the .rst file.

Resolves: #86198
Releases: master
Change-Id: Idee82d2e675eefaee1ead7435bc17cfc3a48356b
Reviewed-on: https://review.typo3.org/58231
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Protect methods in AbstractLinkBrowserController 23/58223/2
Christian Kuhn [Fri, 7 Sep 2018 17:47:43 +0000 (19:47 +0200)]
[TASK] Protect methods in AbstractLinkBrowserController

Some public -> protected changes for AbstractLinkBrowserController
and BrowseLinksController

Resolves: #86193
Releases: master
Change-Id: I349dd5961ac2d90ede36a17c4d4ca550171e315e
Reviewed-on: https://review.typo3.org/58223
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Protect FileListController 26/58226/3
Christian Kuhn [Sat, 8 Sep 2018 09:50:26 +0000 (11:50 +0200)]
[TASK] Protect FileListController

Resolves: #86197
Releases: master
Change-Id: I3ad96b95e6e631adfe67ec83db60b8b9d5ec2045
Reviewed-on: https://review.typo3.org/58226
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Protect methods in ElementBrowserController 22/58222/2
Christian Kuhn [Fri, 7 Sep 2018 17:04:28 +0000 (19:04 +0200)]
[TASK] Protect methods in ElementBrowserController

Resolves: #86192
Releases: master
Change-Id: Id7076427c911af750748e47902e87c1c48b2d2d7
Reviewed-on: https://review.typo3.org/58222
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Deprecate second controller action argument 90/58190/5
Christian Kuhn [Wed, 5 Sep 2018 12:42:22 +0000 (14:42 +0200)]
[TASK] Deprecate second controller action argument

Core eid and backend dispatching uses only the $request object as
argument, but not the prepared $response object anymore. This was
a misconception in the first place.

The patch deprecates the second argument and logs deprecations
by reflecting the target action at runtime. This can be supressed
with a new feature toggle.

Resolves: #84196
Releases: master
Change-Id: I003aba6010957cd82e6910fb718ef531116296be
Reviewed-on: https://review.typo3.org/58190
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Deprecate ElementBrowserFramesetController 08/58208/2
Christian Kuhn [Fri, 7 Sep 2018 09:03:43 +0000 (11:03 +0200)]
[TASK] Deprecate ElementBrowserFramesetController

As far as I could find out, the 'browser' route target class
ElementBrowserFramesetController is unused for a while already.
I think it is unused since element browser and modal works in
v7 and v8, the FormEngine JS browserUrl route target is
always wizard_element_browser and searching for other things
like the bparams argument reveals no usages, either.
The patch deprecates the route and the controller.

Resolves: #86178
Releases: master
Change-Id: Ifed2e9210ef04f95944ddc2371e1ad616c73715f
Reviewed-on: https://review.typo3.org/58208
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Use ServerRequestInterface in PermissionAjaxController 07/58207/3
Christian Kuhn [Fri, 7 Sep 2018 07:48:51 +0000 (09:48 +0200)]
[TASK] Use ServerRequestInterface in PermissionAjaxController

Resolves: #86177
Releases: master
Change-Id: Idc357c62b4040165d3a5d04f291b84c69313402e
Reviewed-on: https://review.typo3.org/58207
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Prevent notice in InstallStatusReport 15/58215/5
Roland Golla [Fri, 7 Sep 2018 13:21:14 +0000 (15:21 +0200)]
[TASK] Prevent notice in InstallStatusReport

Add isset check before use is_array.
This will prevent a notice if the
array key does not exist.

Resolves: #86187
Releases: master
Change-Id: I6f74f2200981802ffe2d9ca527ed7230c0d75b27
Reviewed-on: https://review.typo3.org/58215
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Rework pseudo-site backend preview url generation 82/58182/5
Benjamin Franzke [Tue, 4 Sep 2018 09:25:43 +0000 (11:25 +0200)]
[TASK] Rework pseudo-site backend preview url generation

When there is no site configuration, no TCEMAN.preview
configuration and no sys_domain record available, the host
URL needs to be derived from TYPO3_SITE_URL.

This recently broke (and was fixed). Due to wrong logic
the protocol was added twice, resulting in URLs like:

http://http://hostname.tld/

It initially broke due to the site handling features, probably
with https://review.typo3.org/57949
A condition became dead, due to $domain being always set,
when it was null before that change (if a sys_domain record
could not be found).

The bug was fixed by adding an additional condition (without
removing the dead "else" condition) in https://review.typo3.org/c/58177/

This patch tries to clean this up by removing the new condition
(introduced in #58177) and rather restructure the code.

To circumvent those bugs and to avoid confusion what $domain
actually refers to (now always including the protocol) the
code is refactored to not re-assign $domain over and over again.

Change-Id: I155db1b91357bb6345da1ef469d32b0125344b16
Releases: master
Resolves: #86140
Reviewed-on: https://review.typo3.org/58182
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Deprecate TCA type=user without renderType 98/58198/3
Christian Kuhn [Thu, 6 Sep 2018 10:17:49 +0000 (12:17 +0200)]
[TASK] Deprecate TCA type=user without renderType

Using a custom renderType instead of a userFunc for
type=user TCA elements is much more flexible and suits
better into the overall FormEngine node construct.

The patch deprecates userFunc and outlines details on
how existing ones can be migrated over to custom renderTypes
without much hassle.

Resolves: #86163
Related: #86109
Releases: master
Change-Id: I2bad5f79dab5643efe7f8dc959e788b9426bfdd6
Reviewed-on: https://review.typo3.org/58198
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Protect methods in TaskModuleController 12/58212/3
Christian Kuhn [Fri, 7 Sep 2018 11:14:31 +0000 (13:14 +0200)]
[TASK] Protect methods in TaskModuleController

Resolves: #86182
Releases: master
Change-Id: I80b8b519ad530d5d98e284e0666cd6c2eb3f5603
Reviewed-on: https://review.typo3.org/58212
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Protected methods in ReportController 14/58214/3
Christian Kuhn [Fri, 7 Sep 2018 12:51:23 +0000 (14:51 +0200)]
[TASK] Protected methods in ReportController

There are only two methods in the report controller, calling
them via call_user_function() does not make much sense.
The patch simplifies the dispatcher logic and sets the two
actions to protected.
Note this does not affect the extendability of the reports
module itself.

Resolves: #86184
Related: #84231
Releases: master
Change-Id: Ia329b7de7251825028a5587899be3f6c694873e5
Reviewed-on: https://review.typo3.org/58214
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Adjust table field type to varchar 10/58210/3
Anja [Fri, 7 Sep 2018 10:01:21 +0000 (12:01 +0200)]
[BUGFIX] Adjust table field type to varchar

In order to create workspace stage records, the parenttable field
must not be a tinytext, else the not null restriction fails on
SQlite.

Change-Id: I38cb8fca0eb293100ab7d73433cc284307eb1d0d
Resolves: #85405
Releases: master
Reviewed-on: https://review.typo3.org/58210
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Do not let sites module render rootpages in workspaces 02/58202/3
Andreas Fernandez [Thu, 6 Sep 2018 14:26:14 +0000 (16:26 +0200)]
[BUGFIX] Do not let sites module render rootpages in workspaces

If root pages are configured in workspaces, such pages must not get
rendered in the sites module. The BackendWorkspaceRestriction is added
to prevent fetching such pages in the LIVE workspace.

Resolves: #86174
Releases: master
Change-Id: I35a614d41125516a65cd1d2bce917c04f6af57ac
Reviewed-on: https://review.typo3.org/58202
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Joerg Kummer <typo3@enobe.de>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Show unassigned sites in site module 92/58192/2
Georg Ringer [Wed, 5 Sep 2018 17:52:49 +0000 (19:52 +0200)]
[TASK] Show unassigned sites in site module

The site module displays now also sites with no valid related page anymore.
This can happen if the page is being removed.

Resolves: #86150
Releases: master
Change-Id: If75a33e6c2d189abd42746b52d0b828b7a7b38cb
Reviewed-on: https://review.typo3.org/58192
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Timo Hund <timo.hund@yahoo.com>
Tested-by: Timo Hund <timo.hund@yahoo.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Trigger `change` event after calculating slug 18/58218/3
Andreas Fernandez [Fri, 7 Sep 2018 14:43:09 +0000 (16:43 +0200)]
[BUGFIX] Trigger `change` event after calculating slug

When the slug is calculated by using the according button, the `event` is
now triggered to let the user know that the field value has changes and
to invoke the "You have unsaved changes" modal when closing the form.

Resolves: #86190
Related: #86077
Releases: master
Change-Id: I6eb4e11252562f53e637e3a1abdd7b02a8f73a5a
Reviewed-on: https://review.typo3.org/58218
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Use updated typo3/phar-stream-wrapper version 20/58220/2
Oliver Hader [Fri, 7 Sep 2018 15:22:59 +0000 (17:22 +0200)]
[TASK] Use updated typo3/phar-stream-wrapper version

Resolves: #86191
Releases: master
Change-Id: Ie65dac040f720c313835603bd2446a15e6670c14
Reviewed-on: https://review.typo3.org/58220
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Prevent crash in DatabaseIntegrityCheck 01/58201/3
Christian Kuhn [Thu, 6 Sep 2018 13:57:50 +0000 (15:57 +0200)]
[BUGFIX] Prevent crash in DatabaseIntegrityCheck

If a relation field (select / group) does not exist in db for
whatever reason, System -> DB check -> Database relations
crashes.

Resolves: #86167
Releases: master, 8.7
Change-Id: Id6a502d56b985f6410f40a1f547fe7b923e9d982
Reviewed-on: https://review.typo3.org/58201
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Protect methods in SetupModuleController 11/58211/2
Christian Kuhn [Fri, 7 Sep 2018 10:12:01 +0000 (12:12 +0200)]
[TASK] Protect methods in SetupModuleController

Resolves: #86180
Releases: master
Change-Id: I6277be526cb11d1c6120f13e763d47405aac84d0
Reviewed-on: https://review.typo3.org/58211
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Protect render() method in BackendController 09/58209/2
Christian Kuhn [Fri, 7 Sep 2018 09:41:02 +0000 (11:41 +0200)]
[TASK] Protect render() method in BackendController

Resolves: #86179
Releases: master
Change-Id: Ie61ab04889e36b5290a0d8f4fc1fb68dd95a87ac
Reviewed-on: https://review.typo3.org/58209
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Hide page alias in pagetree overview with sites 04/58204/3
Christian Kuhn [Thu, 6 Sep 2018 15:42:46 +0000 (17:42 +0200)]
[TASK] Hide page alias in pagetree overview with sites

If rendering page trees in Info -> Pagetree overview that has
a full Site configuration, hide the "alias" field - it is not
shown in FormEngine, either.
If rendering a PseudoSite (no site configuration), hide the
slug field.

Resolves: #86175
Releases: master
Change-Id: I46ccb150184e4b76799ab8636ac280eda269c76b
Reviewed-on: https://review.typo3.org/58204
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Use updated typo3/phar-stream-wrapper version 19/58219/2
Oliver Hader [Fri, 7 Sep 2018 14:42:53 +0000 (16:42 +0200)]
[TASK] Use updated typo3/phar-stream-wrapper version

Resolves: #86191
Releases: master
Change-Id: I45d265cd6866dff1ab8fc0a058973c24471ac357
Reviewed-on: https://review.typo3.org/58219
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[TASK] Deprecate old TypoScript condition syntax 09/58109/10
Frank Naegler [Fri, 31 Aug 2018 20:19:21 +0000 (22:19 +0200)]
[TASK] Deprecate old TypoScript condition syntax

Since the symfony expression language is available for TypoScript
conditions, the old condition syntax is being deprecated.

Resolves: #86068
Releases: master
Change-Id: Iae1f4b6e400afbab233561af54c98bc4a4a40792
Reviewed-on: https://review.typo3.org/58109
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
8 months ago[BUGFIX] Fix fatal in ReportsModule with upgrade wizards 13/58213/3
Christian Kuhn [Fri, 7 Sep 2018 12:39:46 +0000 (14:39 +0200)]
[BUGFIX] Fix fatal in ReportsModule with upgrade wizards

With the new upgrade wizard API the InstallStatusReport
has to be adapted a bit to prevent a fatal calling
shouldRenderWizard() on wizards that don't have this
method.

Resolves: #86183
Releases: master
Change-Id: I0551c0a823a0a6f670c0ca079a1f2f4475ccf583
Reviewed-on: https://review.typo3.org/58213
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Reviewed-by: rolandgolla <rolandgolla@gmail.com>
Tested-by: rolandgolla <rolandgolla@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Clean up UpgradeWizardsService API 99/58199/2
Helmut Hummel [Thu, 6 Sep 2018 10:44:16 +0000 (12:44 +0200)]
[TASK] Clean up UpgradeWizardsService API

Remove implementation details from public API methods

Releases: master
Resolves: #86166
Change-Id: I3605132946d4fa1e92eccfa91498290dab4762c2
Reviewed-on: https://review.typo3.org/58199
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Use ServerRequestInterface in RecyclerAjaxController 85/58185/3
Anja [Tue, 4 Sep 2018 14:26:39 +0000 (16:26 +0200)]
[TASK] Use ServerRequestInterface in RecyclerAjaxController

All values are available in the request object, no need to touch the
globals. The constructor of the controller is empty after the
replacement, so it can be removed.

Change-Id: Ieb0d714965716638d51a982a858341938700572f
Resolves: #86146
Releases: master
Reviewed-on: https://review.typo3.org/58185
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Ensure connection can be established multiple times 89/58189/3
Nicole Cordes [Wed, 5 Sep 2018 11:45:02 +0000 (13:45 +0200)]
[BUGFIX] Ensure connection can be established multiple times

This patch ensures a connection can be established multiple times
and is initialized correctly using the init commands on each fresh
connection call.

Resolves: #86154
Releases: master, 8.7
Change-Id: Ief2fb0855715333b124e8315c5f794008a5fb3d5
Reviewed-on: https://review.typo3.org/58189
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Trim search value in live search 88/58188/2
Georg Ringer [Wed, 5 Sep 2018 08:49:09 +0000 (10:49 +0200)]
[BUGFIX] Trim search value in live search

The query parameter of the live search should be trimmed.
The same behaviour is already used in the regular search in the list module which is
available in the live search by clicking on the button "show all".

Resolves: #86149
Releases: master, 8.7
Change-Id: I3ec2ac03f67fa8c0daaa11aaf3e4351d05949b83
Reviewed-on: https://review.typo3.org/58188
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Only add pages to XML sitemap with no_index = 0 91/58191/2
Richard Haeser [Wed, 5 Sep 2018 14:27:37 +0000 (16:27 +0200)]
[BUGFIX] Only add pages to XML sitemap with no_index = 0

Pages with no_index, follow shouldn't show up in XML sitemap. Only pages
that needs to be indexed.

Resolves: #86157
Releases: master
Change-Id: I609b321d8cd256ceac6599b6a0516c8b3994928b
Reviewed-on: https://review.typo3.org/58191
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Improve TCA of site_errorhandling 87/58187/2
Georg Ringer [Wed, 5 Sep 2018 06:11:23 +0000 (08:11 +0200)]
[TASK] Improve TCA of site_errorhandling

- Localize labels
- Use label_alt to show not only errorCode but also errorHandler

Resolves: #86148
Releases: master
Change-Id: I699117be14d5b2c14f6d9325f7a3f4ecabd1382c
Reviewed-on: https://review.typo3.org/58187
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Reveal usage as controller of TaskStatus::class 83/58183/5
Anja [Tue, 4 Sep 2018 12:27:10 +0000 (14:27 +0200)]
[TASK] Reveal usage as controller of TaskStatus::class

The class is called by two ajax routes and is therefore to be named,
placed and handled as the controller that it is.

Change-Id: I5106f5310041d3f0a993c2bf7ebe03ac51454cad
Resolves: #86142
Releases: master
Reviewed-on: https://review.typo3.org/58183
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Tested-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Deprecate FrontendEditingController 67/58067/11
Benni Mack [Wed, 29 Aug 2018 07:59:57 +0000 (09:59 +0200)]
[TASK] Deprecate FrontendEditingController

The class is not in use anymore, only feedit instantiates the class for legacy reasons.

Also FrontendBackendUserAuthentication->frontendEdit which holds an instance of
that, is deprecated.

Resolves: #86110
Releases: master
Change-Id: I3ff2ae529dd920d2abf9908f2ae94ae4c2bf9c15
Reviewed-on: https://review.typo3.org/58067
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Set TYPO3 version to 9.5.0-dev 81/58181/2
Oliver Hader [Tue, 4 Sep 2018 12:09:35 +0000 (14:09 +0200)]
[TASK] Set TYPO3 version to 9.5.0-dev

Change-Id: I96b70e192770b6955f82a8106db386f2044e738b
Reviewed-on: https://review.typo3.org/58181
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[RELEASE] Release of TYPO3 9.4.0 80/58180/2 v9.4.0
Oliver Hader [Tue, 4 Sep 2018 12:07:49 +0000 (14:07 +0200)]
[RELEASE] Release of TYPO3 9.4.0

Change-Id: I10cf279d74af2cfc2964704ba31c6ce2b7be3493
Reviewed-on: https://review.typo3.org/58180
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Avoid insufficient workspace version constraint 60/58160/4
Oliver Hader [Mon, 3 Sep 2018 19:56:40 +0000 (21:56 +0200)]
[BUGFIX] Avoid insufficient workspace version constraint

Resolves: #86126
Releases: master
Change-Id: I7724cb1415742861a0c6496f4e3888787e6467d4
Reviewed-on: https://review.typo3.org/58160
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Resolve version move placeholder in RootlineUtility 78/58178/5
Oliver Hader [Tue, 4 Sep 2018 10:04:24 +0000 (12:04 +0200)]
[BUGFIX] Resolve version move placeholder in RootlineUtility

In order to correctly work with rootlines (e.g. when resolving
according sites and pseudo-sites for URL resolving and generation)
possible version move placeholders have to be resolved.

Resolves: #86137
Releases: master
Change-Id: Ief9841f7592018292c034c03c45343363cf79248
Reviewed-on: https://review.typo3.org/58178
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Move documentation files into 9.4 folder - part 3 66/58166/7
Anja [Mon, 3 Sep 2018 21:07:47 +0000 (23:07 +0200)]
[TASK] Move documentation files into 9.4 folder - part 3

The change also contains some documentation related improvements
in some code files, where the need occured.

Change-Id: I346fd70e20bd0765ac4cc663dc7e3fd73d02651b
Resolves: #86075
Releases: master
Reviewed-on: https://review.typo3.org/58166
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Do not double-prepend the URL scheme on preview URLs 77/58177/2
Benni Mack [Tue, 4 Sep 2018 09:19:15 +0000 (11:19 +0200)]
[BUGFIX] Do not double-prepend the URL scheme on preview URLs

When having a pseudo-site the view functionality is broken
due to some different handling how to deal with protocols.

Resolves: #86134
Releases: master
Change-Id: Ia3b08ce968ecfdce631ce9c7ff9c973cfb25eef5
Reviewed-on: https://review.typo3.org/58177
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Wrap error UnknownElement with proper HTML 73/58173/3
Georg Ringer [Tue, 4 Sep 2018 05:41:27 +0000 (07:41 +0200)]
[TASK] Wrap error UnknownElement with proper HTML

Show the error with a proper markup. Also hightlight type and
render type as code.

Resolves: #86133
Releases: master, 8.7
Change-Id: I79323aaff834c47e6ff875f8a584b2c88f42c51d
Reviewed-on: https://review.typo3.org/58173
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Allow getPagesTSconfig to be called without BE_USER 74/58174/2
Benni Mack [Tue, 4 Sep 2018 07:08:19 +0000 (09:08 +0200)]
[BUGFIX] Allow getPagesTSconfig to be called without BE_USER

Due to refactorings lately in BackendUtility::getPagesTSconfig() with
which results in a fatal error when clearing page cache while persisting an
extbase object.

The patch adds a test without a Backend User, and encapsulates this
with a simple if() statement. However, this also shows that some
other areas that are touched are not fully notice-free / strict, which
are tackled as well.

Resolves: #85310
Releases: master
Change-Id: I0f1318d395451e704e1783e841d96583efe2a560
Reviewed-on: https://review.typo3.org/58174
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[BUGFIX] Abort `nodeSelectedAfter` on unchecked nodes 36/57836/4
Andreas Fernandez [Wed, 8 Aug 2018 20:39:41 +0000 (22:39 +0200)]
[BUGFIX] Abort `nodeSelectedAfter` on unchecked nodes

If a node in the page tree is clicked, the `nodeSelectedAfter` event is
triggered for any active node that is being deactivated.

The event listener is now aborted if the event is called on a unchecked
node.

Resolves: #85787
Releases: master
Change-Id: I4fa5bbc4290b5ffd2ecb77a901dceb042dff3d27
Reviewed-on: https://review.typo3.org/57836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Tested-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
8 months ago[BUGFIX] Template module must respect workspaces 71/58171/2
Andreas Fernandez [Mon, 3 Sep 2018 21:50:12 +0000 (23:50 +0200)]
[BUGFIX] Template module must respect workspaces

The template module now respects the workspace constraint of the current
backend user and the stored sys_template records.

Resolves: #86131
Releases: master, 8.7
Change-Id: I0463844c4222957aede4b4ca749a3368cb399f81
Reviewed-on: https://review.typo3.org/58171
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Make debug exceptions scrollable in backend context 72/58172/2
Benjamin Kott [Mon, 3 Sep 2018 22:02:40 +0000 (00:02 +0200)]
[BUGFIX] Make debug exceptions scrollable in backend context

Resolves: #86132
Releases: master
Change-Id: I34a09ec83491b0f08e0a094680fbd93057ad76a4
Reviewed-on: https://review.typo3.org/58172
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[BUGFIX] Use same height for tree bar as for the right module 67/58167/3
Georg Ringer [Mon, 3 Sep 2018 21:17:10 +0000 (23:17 +0200)]
[BUGFIX] Use same height for tree bar as for the right module

Fix 1px off error in page tree toolbar.

Resolves: #86098
Releases: master
Change-Id: Ia1476d57b935159fc32e40a9134c7c7a1e9a6ef3
Reviewed-on: https://review.typo3.org/58167
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] use gmmktime in checkConditionMatcherForDateFunction unit test 65/58165/2
Jigal van Hemert [Mon, 3 Sep 2018 20:58:40 +0000 (22:58 +0200)]
[BUGFIX] use gmmktime in checkConditionMatcherForDateFunction unit test

The arguments are now treated as parts of a UTC date/time and
prevents different results depending on the system date.timezone
settings.

Releases: master
Resolves: #86128
Change-Id: Ieb336ea43eb246ec0e0c5a7db8194c03a0801f83
Reviewed-on: https://review.typo3.org/58165
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[BUGFIX] Ensure slug update wizard uses proper sorting 53/58153/2
Benni Mack [Mon, 3 Sep 2018 19:06:22 +0000 (21:06 +0200)]
[BUGFIX] Ensure slug update wizard uses proper sorting

If two subpages share the same name, it is important, that the first
page gets a proper name, and the second one follows the uniqueInSite pattern.

Also, sorting by workspaces (live first), PID and then sorting seems to be
just logical. I wonder why I did not add this before.

Resolves: #86120
Releases: master
Change-Id: I53f279034c2c61a31b50fc973721827f0c2685ba
Reviewed-on: https://review.typo3.org/58153
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Ensure version placeholders get updated on slug changes 50/58150/3
Oliver Hader [Mon, 3 Sep 2018 18:46:26 +0000 (20:46 +0200)]
[TASK] Ensure version placeholders get updated on slug changes

This change ensures that workspace version placeholders are kept
in sync when slug values (TCA type 'slug') are modified in their
specific workspace version. This is done implicitly without the
requirement to define shadowColumnsForNewPlaceholders in TCA.

Resolves: #86117
Releases: master
Change-Id: I11baab1e2154b5f3a043a29c08617c0ad360226a
Reviewed-on: https://review.typo3.org/58150
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Resolve workspace records for template module overview 82/57982/5
Oliver Hader [Tue, 21 Aug 2018 10:45:20 +0000 (12:45 +0200)]
[BUGFIX] Resolve workspace records for template module overview

BackendWorkspaceRestriction automatically resolves specific records
already for a given workspace. In most cases this seems to be fine to
omit the usual workspace overlay processing. However, especially when
dealing with references and page tree assignments, it just contains
wrong information.

For instance all workspace versions have the `pid` column set to -1
which of course cannot be resolved as valid page then.

Resolves: #85917
Releases: master, 8.7
Change-Id: Ibe20037b25770bea8f58d1a8bba785ca43ac26cb
Reviewed-on: https://review.typo3.org/57982
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Create root page with slug field filled on installation 62/58162/2
Benni Mack [Mon, 3 Sep 2018 20:19:43 +0000 (22:19 +0200)]
[BUGFIX] Create root page with slug field filled on installation

The root page should contain as best practice the "/" as slug,
after a successful installation.

Resolves: #86125
Releases: master
Change-Id: I2dced238f3482564f4c23fae6c191b68fc500b8e
Reviewed-on: https://review.typo3.org/58162
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Remove console.log() on wizard execution 63/58163/2
Andreas Fernandez [Mon, 3 Sep 2018 20:43:01 +0000 (22:43 +0200)]
[BUGFIX] Remove console.log() on wizard execution

Resolves: #86127
Releases: master
Change-Id: I2b900305cb505c52886b012d7d9a3303f6a0a233
Reviewed-on: https://review.typo3.org/58163
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[BUGFIX] Create proper FE links in Web->View module 57/58157/7
Christian Kuhn [Mon, 3 Sep 2018 19:40:11 +0000 (21:40 +0200)]
[BUGFIX] Create proper FE links in Web->View module

Resolves: #86124
Releases: master
Change-Id: Icb706e585af8e0c0acd993f15d17276024bc5503
Reviewed-on: https://review.typo3.org/58157
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Declare strict types in SlugEnricher 51/58151/2
Andreas Fernandez [Mon, 3 Sep 2018 19:03:57 +0000 (21:03 +0200)]
[BUGFIX] Declare strict types in SlugEnricher

Resolves: #86118
Related: #85937
Releases: master
Change-Id: Id913e98e360d06f8db61bbde8c49a131715f2240
Reviewed-on: https://review.typo3.org/58151
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Auto-generate slug when invalid characters are given 55/58155/2
Benni Mack [Mon, 3 Sep 2018 19:14:45 +0000 (21:14 +0200)]
[BUGFIX] Auto-generate slug when invalid characters are given

If a page title is like "!!!" this currently results in an invalid slug.

The generator now auto-generates something with "default-hashXYZ"
in order to always be unique on creation time.

Resolves: #86122
Releases: master
Change-Id: I453e2155c29f1bde4d05d481e0ae43913bc5ad8b
Reviewed-on: https://review.typo3.org/58155
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Cast return value of getLivePageUid to int 52/58152/2
Susanne Moog [Mon, 3 Sep 2018 19:02:47 +0000 (21:02 +0200)]
[BUGFIX] Cast return value of getLivePageUid to int

On database systems like sqlite fields like uid or
t3ver_oid are returned as string and need to be casted.

This casting has been added in PreviewUriBuilder
->getLivePageUid.

Resolves: #86119
Releases: master
Change-Id: I7fec760b0aee749e72a640488e1021681471c9ec
Reviewed-on: https://review.typo3.org/58152
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
8 months ago[TASK] Deprecate class AltPageTitleProvider 54/58154/3
Richard Haeser [Mon, 3 Sep 2018 19:13:05 +0000 (21:13 +0200)]
[TASK] Deprecate class AltPageTitleProvider

Because the usage of $GLOBALS['TSFE']->altPageTitle is deprecated
since version 9 and will be removed in version 10, the whole class
can be deprecated.

Resolves: #86121
Releases: master
Change-Id: Ifc846550d1132ac15e35fcd7e0357a45c015ee53
Reviewed-on: https://review.typo3.org/58154
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
8 months ago[TASK] Cleanup PageTitle API 56/58156/2
Richard Haeser [Mon, 3 Sep 2018 19:18:27 +0000 (21:18 +0200)]
[TASK] Cleanup PageTitle API

Some small indentation fixes.

Resolves: #86123
Releases: master
Change-Id: Idd5cc7f9cb206516930e5a888449d1204ee9ae11
Reviewed-on: https://review.typo3.org/58156
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
8 months ago[BUGFIX] Avoid database upgrade failures when adding slug field 46/58146/5
Oliver Hader [Mon, 3 Sep 2018 17:19:04 +0000 (19:19 +0200)]
[BUGFIX] Avoid database upgrade failures when adding slug field

When upgrading with e.g. MSSQL it should be noted, that the
pages.slug DB field should be a varchar database field (instead of
"text"), which can be null, allowing the field to be created when
upgrading an instance, without having the upgrade wizard run yet.

So all slug fields are set to null, and can be ommitted correctly.

Resolves: #86116
Releases: master
Change-Id: Iedf62d1a145c25d0ecbc9e25c163255173cdb2d7
Reviewed-on: https://review.typo3.org/58146
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[TASK] Revert "Move LocalConfiguration* files to config folder" 47/58147/4
Benni Mack [Mon, 3 Sep 2018 17:36:42 +0000 (19:36 +0200)]
[TASK] Revert "Move LocalConfiguration* files to config folder"

This reverts commit 277c677a967fcca5a158042465bfe35da9a3fa15.

This change was meant as a pre-cursor to the new config handling,
which needs some more thoughts on how to deal with AdditionalConfiguration.php
in the future, and is reverted for the time being.

Resolves: #86115
Reverts: #84623
Releases: master
Change-Id: Ib46666856b3ed797f574f10f2af024d29bdad956
Reviewed-on: https://review.typo3.org/58147
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
8 months ago[TASK] Switch UserStorageCapabilityService to a renderType 41/58141/4
Christian Kuhn [Mon, 3 Sep 2018 14:16:34 +0000 (16:16 +0200)]
[TASK] Switch UserStorageCapabilityService to a renderType

Using a TCA type=user with a custom renderType is much more
elegant since the registered element can then fully access
$this->data and has control of node expansion and all the
other goodies that come with own renderType in comparison
to the shabby limited type=user with userFunc.
The patch switches the 'is_public' type=user userFunc to
a proper renderType and fixes the incomplete HTML of this
field along the way.
Note a type=check with own renderType is not possible in
this case since the config has no items array.

Resolves: #86109
Releases: master
Change-Id: I72507a4660fc64e5c2df60768564a788a4c38a05
Reviewed-on: https://review.typo3.org/58141
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Use SiteLanguage in forms 69/57969/5
Julian Wundrak [Mon, 3 Sep 2018 07:27:26 +0000 (09:27 +0200)]
[BUGFIX] Use SiteLanguage in forms

TranslationService of forms only respect language sets in TypoScript.
Use SiteLanguage is the leading configuration and TypoScript as
fallback.

Resolves: #85909
Releases: master
Change-Id: I961161434e38916e8885af883523eff98f0b467c
Reviewed-on: https://review.typo3.org/57969
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Julian Wundrak <julian@wundrak.net>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Ensure that slugs are always calculated in DataHandler 98/58098/14
Oliver Hader [Sun, 2 Sep 2018 21:19:52 +0000 (23:19 +0200)]
[BUGFIX] Ensure that slugs are always calculated in DataHandler

When NOT using FormEngine to create a new page (e.g. in the pagetree
or via the "Create multiple pages" wizard), so just using DataHandler
magic is uttermost critical that a slug is always created, to ensure
the "uniqueInSite" functionality, and to access a page, even though
the page was created after the upgrade wizard has run.

Resolves: #86050
Resolves: #85937
Releases: master
Change-Id: I9eff3385c369a04a6f5a33d0b840b6a2b698891c
Reviewed-on: https://review.typo3.org/58098
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Only unlock records in BE user log off functionality 45/58145/5
Benni Mack [Mon, 3 Sep 2018 16:53:04 +0000 (18:53 +0200)]
[BUGFIX] Only unlock records in BE user log off functionality

The database table `sys_lockedrecords` should only be cleared via
the BackendUtility when a Backend user is logging off. Currently, this
is also called for Frontend Users, which actually removes everything
from the currently logged-in backend users with the same uid.

As this is very bad code design on many levels (lockRecords for
unlocking, no context for the authentication user object etc), this
should be encapsulated within the BackendUser object directly anyway.

For further abstractions, this could also be a hook or something else,
to be even cleaner.

Resolves: #86113
Releases: master, 8.7
Change-Id: I44d91064edb6ec9ef4c148e48b67bdf22da38869
Reviewed-on: https://review.typo3.org/58145
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[BUGFIX] Avoid suffixing base slug again 44/58144/4
Oliver Hader [Mon, 3 Sep 2018 16:51:35 +0000 (18:51 +0200)]
[BUGFIX] Avoid suffixing base slug again

When invoking slug generation on an empty or base slug (`/`), the
slug will become `//` - which is invalid and has to be avoided.

Resolves: #86114
Releases: master
Change-Id: I66aac94ec9be7992376806d59b7c3ef1bd0e142a
Reviewed-on: https://review.typo3.org/58144
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Suffix all interfaces with Interface 43/58143/3
Benni Mack [Mon, 3 Sep 2018 15:54:38 +0000 (17:54 +0200)]
[BUGFIX] Suffix all interfaces with Interface

The patch introducing interfaces for upgrade wizards had some mixed
namings, which are now corrected.

Resolves: #86112
Releases: master
Change-Id: I5ada026d00f9482b1c89fed63cb40a9ba6fb790e
Reviewed-on: https://review.typo3.org/58143
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Add missing documentation for typolink.language 42/58142/4
Benni Mack [Mon, 3 Sep 2018 15:19:41 +0000 (17:19 +0200)]
[TASK] Add missing documentation for typolink.language

The newly added functionality for typolink.language
within TypoScript receives a documentation file.

Resolves: #86057
Releases: master
Change-Id: I87031125f879950f926e118bf4b4bcc5a068f39f
Reviewed-on: https://review.typo3.org/58142
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Adjust LinkGeneratorTest for non-site scenario 40/58140/6
Oliver Hader [Mon, 3 Sep 2018 10:34:20 +0000 (12:34 +0200)]
[TASK] Adjust LinkGeneratorTest for non-site scenario

When using a Site according "slug" values have to be given in order to
have complete routing information. There won't be pages in sites that
explicitly have empty slugs.

Test cases for sites having slugs are available in
SlugLinkGeneratorTest.  In order to test legacy behavior without having
sites and slugs, the scenario of LinkGeneratorTest has been adjusted
accordingly.

Resolves: #86104
Releases: master
Change-Id: Iea57e62311fc663df772c12530a0c4d4c84aee0f
Reviewed-on: https://review.typo3.org/58140
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Add details to message for existing record localization 86/57586/5
Mathias Brodala [Fri, 13 Jul 2018 13:30:38 +0000 (15:30 +0200)]
[TASK] Add details to message for existing record localization

Resolves: #85549
Releases: master
Change-Id: I8a98da8842c6d15175debed5513bbc4bc2bb0a2c
Reviewed-on: https://review.typo3.org/57586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Fix migration docs for "language:update" command 39/58139/2
Mathias Brodala [Mon, 3 Sep 2018 12:31:15 +0000 (14:31 +0200)]
[BUGFIX] Fix migration docs for "language:update" command

Also add an example how to pass in multiple language ISO codes
which was done using commas back then and now using spaces.

Resolves: #85694
Related: #82315
Releases: master
Change-Id: I4088b6d313c90e5d882db243ea134250690808cf
Reviewed-on: https://review.typo3.org/58139
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>