Packages/TYPO3.CMS.git
8 months ago[BUGFIX] Avoid prev/next arrows if only 1 system news is shown 75/57275/2
Georg Ringer [Wed, 20 Jun 2018 17:15:30 +0000 (19:15 +0200)]
[BUGFIX] Avoid prev/next arrows if only 1 system news is shown

If only one system news is shown, it makes no sense to render arrows
to switch to other news records. Therefore those should only be
shown if there are at least 2 records.

Resolves: #85322
Releases: master, 8.7
Change-Id: I636b90121729bb2f12c2313a3cb7e8b858367970
Reviewed-on: https://review.typo3.org/57275
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Guido Schmechel <guido.schmechel@brandung.de>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
8 months ago[BUGFIX] Allow redirect from typo3/install again 62/57262/2
Benni Mack [Mon, 18 Jun 2018 16:16:37 +0000 (18:16 +0200)]
[BUGFIX] Allow redirect from typo3/install again

Due to refactorings of constants, Environment:isCli()
needs to be initialized now. This breaks the
existing redirect from typo3/install/ to
typo3/install.php, due to non-initialized Environment
API.

In this case, the environment is initialized.

Resolves: #85306
Releases: master
Change-Id: I20a86f4a304951b7b075a3eec7142c4e1c99d06c
Reviewed-on: https://review.typo3.org/57262
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
8 months ago[TASK] Show infobox for records which are set to readOnly 53/57253/2
Georg Ringer [Sun, 17 Jun 2018 18:44:00 +0000 (20:44 +0200)]
[TASK] Show infobox for records which are set to readOnly

Records can be set to readOnly by setting 'readOnly` in the TCA ctrl section.
Inform editors by rendering an infobox above the record.

Additionally improve the code of the record note rendering.

Resolves: #85244
Releases: master, 8.7
Change-Id: I46c84f18b22332c5691f7fb41836a0b97f8dafa2
Reviewed-on: https://review.typo3.org/57253
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
8 months ago[BUGFIX] Cast database result uid to int 47/57247/2
Susanne Moog [Sun, 17 Jun 2018 14:45:10 +0000 (16:45 +0200)]
[BUGFIX] Cast database result uid to int

As the OrphanRecordsCommand is using strict types
the results in row['uid'] has been casted to int
before usage in further methods as it is returned
as string from the database.

Resolves: #85288
Releases: master
Change-Id: Ia7a8f0f2be37b4b35a246f95049e20d717cbf767
Reviewed-on: https://review.typo3.org/57247
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
8 months ago[BUGFIX] Cast uid from database to int in TableWizard 50/57250/2
Susanne Moog [Sun, 17 Jun 2018 15:12:38 +0000 (17:12 +0200)]
[BUGFIX] Cast uid from database to int in TableWizard

Resolves: #85294
Releases: master
Change-Id: Id15a7dc0896a7031272ef5dde41606aaebaaec9c
Reviewed-on: https://review.typo3.org/57250
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Merge str_replace calls when applied to a variable sequentially 46/57246/3
Wouter Wolters [Sun, 17 Jun 2018 14:44:59 +0000 (16:44 +0200)]
[TASK] Merge str_replace calls when applied to a variable sequentially

Resolves: #85291
Releases: master
Change-Id: Ia8db330043ccd2d123be8d6257189774969a951c
Reviewed-on: https://review.typo3.org/57246
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Bürk <stefan.buerk@pure-metal.de>
Tested-by: Stefan Bürk <stefan.buerk@pure-metal.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Replace array_push with normal array assignment 45/57245/2
Wouter Wolters [Sun, 17 Jun 2018 14:39:05 +0000 (16:39 +0200)]
[TASK] Replace array_push with normal array assignment

Direct array assignment works faster than invoking php functions

Resolves: #85290
Releases: master
Change-Id: I607b11ddd96114e14a04988887f3b3139d4ae06a
Reviewed-on: https://review.typo3.org/57245
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Fix wrong strlen check in DoubleMetaPhoneUtility 52/57252/2
Wouter Wolters [Sun, 17 Jun 2018 17:23:41 +0000 (19:23 +0200)]
[BUGFIX] Fix wrong strlen check in DoubleMetaPhoneUtility

while (strlen($this->primary) < 4 || strlen($this->secondary < 4)) {

should be

while (strlen($this->primary) < 4 || strlen($this->secondary) < 4) {

Resolves: #85296
Releases: master,8.7
Change-Id: I1820218410538c095f3e3c907190726f8e970410
Reviewed-on: https://review.typo3.org/57252
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Drop child methods that are exactly the same 44/57244/3
Wouter Wolters [Sun, 17 Jun 2018 14:30:10 +0000 (16:30 +0200)]
[TASK] Drop child methods that are exactly the same

Resolves: #85289
Releases: master
Change-Id: Ia35e8e36f4d9d97924ff105c549b26d851f5df40
Reviewed-on: https://review.typo3.org/57244
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Replace last occurrences of PATH_site with Environment API 41/57241/3
Benni Mack [Fri, 15 Jun 2018 19:54:03 +0000 (21:54 +0200)]
[TASK] Replace last occurrences of PATH_site with Environment API

Resolves: #85285
Releases: master
Change-Id: I4d12f7add6f536b3a412e554c8a6c4d64fd677e4
Reviewed-on: https://review.typo3.org/57241
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Use Environment API instead of PATH_site in core 40/57240/11
Christian Kuhn [Fri, 15 Jun 2018 16:45:41 +0000 (18:45 +0200)]
[TASK] Use Environment API instead of PATH_site in core

First batch taking care of "easy" places.

Resolves: #85283
Releases: master
Change-Id: I68fa5a0559aae6191858aba7690ba72918bdf507
Reviewed-on: https://review.typo3.org/57240
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
8 months ago[TASK] Streamline imports in PHP cache classes 19/57219/3
Benni Mack [Thu, 14 Jun 2018 21:08:07 +0000 (23:08 +0200)]
[TASK] Streamline imports in PHP cache classes

Most Cache classes haven't been streamlined since their inception,
some unnecessary imports.

The patch organizes the files so their are all imported the same way.

Resolves: #85261
Releases: master
Change-Id: I814bb88562711ccdf509262b7846ceb625674fe1
Reviewed-on: https://review.typo3.org/57219
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Use Environment API instead of PATH_site in em 38/57238/3
Christian Kuhn [Fri, 15 Jun 2018 16:07:38 +0000 (18:07 +0200)]
[TASK] Use Environment API instead of PATH_site in em

Resolves: #85281
Releases: master
Change-Id: I8313d9f9b564d8f6ab0f9a91ebbe93aa9c337e31
Reviewed-on: https://review.typo3.org/57238
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Use Environment API in documentation extension 39/57239/3
Christian Kuhn [Fri, 15 Jun 2018 16:19:03 +0000 (18:19 +0200)]
[TASK] Use Environment API in documentation extension

Resolves: #85282
Releases: master
Change-Id: If54517105217a1dfba424c46ec0edbe4c5775f15
Reviewed-on: https://review.typo3.org/57239
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Use Environment API instead of PATH_site in install 37/57237/2
Christian Kuhn [Fri, 15 Jun 2018 15:40:44 +0000 (17:40 +0200)]
[TASK] Use Environment API instead of PATH_site in install

Resolves: #85280
Releases: master
Change-Id: Id8330e1fda17557284ab5ffd6081433226c74083
Reviewed-on: https://review.typo3.org/57237
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Use Environment API in scheduler 36/57236/2
Benni Mack [Fri, 15 Jun 2018 15:36:52 +0000 (17:36 +0200)]
[TASK] Use Environment API in scheduler

Resolves: #85279
Releases: master
Change-Id: I2d63540be1883fb2faea763d72a875800eae1cfa
Reviewed-on: https://review.typo3.org/57236
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Replace PATH_site with Environment API in various exts 35/57235/2
Benni Mack [Fri, 15 Jun 2018 15:06:28 +0000 (17:06 +0200)]
[TASK] Replace PATH_site with Environment API in various exts

Resolves: #85278
Releases: master
Change-Id: Ibfcad90bad0486f7571ea60edd6aba33cab0c32c
Reviewed-on: https://review.typo3.org/57235
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Use Environment API instead of PATH_site in t3editor 32/57232/2
Christian Kuhn [Fri, 15 Jun 2018 14:15:51 +0000 (16:15 +0200)]
[TASK] Use Environment API instead of PATH_site in t3editor

Resolves: #85275
Releases: master
Change-Id: Ib0a5a773387252609f01c07a441bdb183f5142c0
Reviewed-on: https://review.typo3.org/57232
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Use Environment API instead of PATH_site in impexp 34/57234/2
Christian Kuhn [Fri, 15 Jun 2018 14:44:27 +0000 (16:44 +0200)]
[TASK] Use Environment API instead of PATH_site in impexp

Resolves: #85277
Releases: master
Change-Id: I6510ae323051a01e3b0e3bbdf7b347adeb46880c
Reviewed-on: https://review.typo3.org/57234
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
8 months ago[TASK] Use Environment API instead of PATH_site in EXT:backend 29/57229/5
Benni Mack [Fri, 15 Jun 2018 13:31:30 +0000 (15:31 +0200)]
[TASK] Use Environment API instead of PATH_site in EXT:backend

Several places of the PATH_site constant in EXT:backend are replaced
by the new Environment API.

Resolves: #85272
Releases: master
Change-Id: I992b07a5bde377f9a65798eaf9ec797433eb9ce4
Reviewed-on: https://review.typo3.org/57229
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
8 months ago[TASK] Use Environment API instead of PATH_site in indexed_search 31/57231/2
Christian Kuhn [Fri, 15 Jun 2018 13:54:42 +0000 (15:54 +0200)]
[TASK] Use Environment API instead of PATH_site in indexed_search

Resolves: #85273
Releases: master
Change-Id: If2a643843532d14f2b7263c66b22ad1bc0402c33
Reviewed-on: https://review.typo3.org/57231
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
8 months ago[TASK] Replace PATH_site with Environment API in EXT:frontend 33/57233/2
Benni Mack [Fri, 15 Jun 2018 14:42:13 +0000 (16:42 +0200)]
[TASK] Replace PATH_site with Environment API in EXT:frontend

Resolves: #85276
Releases: master
Change-Id: Id85d7538000ce05addaa5c3d4e3607e2ff20d42e
Reviewed-on: https://review.typo3.org/57233
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
8 months ago[BUGFIX] Do not use named parameter for list of orphan records ids 13/57213/2
Sascha Egerer [Wed, 13 Jun 2018 19:18:30 +0000 (21:18 +0200)]
[BUGFIX] Do not use named parameter for list of orphan records ids

The OrphanRecordsCommand fetches records by a list of ids.
This list can get very big so the database will fail if the
number of placesholders exceeds its limit.

Resolves: #85257
Related: #80875
Releases: master, 8.7
Change-Id: Ia6b9398f4e54157301abb57fac5adb7f51130907
Reviewed-on: https://review.typo3.org/57213
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Thomas Rawiel <thomas.rawiel@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[FEATURE] Load merged JS files asynchronous 30/57130/7
Rune Piper [Wed, 6 Jun 2018 07:22:21 +0000 (09:22 +0200)]
[FEATURE] Load merged JS files asynchronous

The async attribute is now assigned to the script tag of the concatenated
JS files if all files have the async attribute enabled in TypoScript.

Resolves: #83476
Releases: master
Change-Id: If4d5f03cac5920cf0bcccefb2e91cc229f9b9e77
Reviewed-on: https://review.typo3.org/57130
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Make extbase/Tests/Unit/Mvc/Web/RequestBuilderTest.php notice free 22/57222/5
Jan Helke [Fri, 15 Jun 2018 10:03:00 +0000 (12:03 +0200)]
[TASK] Make extbase/Tests/Unit/Mvc/Web/RequestBuilderTest.php notice free

Releases: master
Resolves: #85265
Change-Id: Ie4d13083c256a31987097d2e0990d6e5207bef13
Reviewed-on: https://review.typo3.org/57222
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Make typo3/sysext/frontend/Tests/Unit/ContentObject notice free 20/57220/5
Jan Helke [Fri, 15 Jun 2018 09:50:40 +0000 (11:50 +0200)]
[TASK] Make typo3/sysext/frontend/Tests/Unit/ContentObject notice free

Releases: master
Resolves: #85263
Change-Id: I19e7a26ddf41d7b55dfd1890163364ffd2479e13
Reviewed-on: https://review.typo3.org/57220
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Use CLI and Composer Checks via Environment class 27/57227/3
Christian Kuhn [Fri, 15 Jun 2018 11:13:33 +0000 (13:13 +0200)]
[TASK] Use CLI and Composer Checks via Environment class

Use Environment::isCli() instead of constant munging
in various places. Usages in extbase are left out for
the time being since those give headaches with functional
frontend tests at the moment. Those will be sorted out
with further patches.

Resolves: #85271
Releases: master
Change-Id: I7391bb393eec69bf04fab0e6d31c8a579dc79493
Reviewed-on: https://review.typo3.org/57227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Make Persistence/Generic/PersistenceManagerTest.php notice free 25/57225/4
Jan Helke [Fri, 15 Jun 2018 10:32:45 +0000 (12:32 +0200)]
[TASK] Make Persistence/Generic/PersistenceManagerTest.php notice free

Releases: master
Resolves: #85268
Change-Id: I80a1df3e39cafb86788b1434ed0043cc0e7372c3
Reviewed-on: https://review.typo3.org/57225
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
8 months ago[TASK] Update tslint 5.9.1 ❯ 5.10.0 78/57178/4
Frank Naegler [Tue, 12 Jun 2018 15:25:44 +0000 (17:25 +0200)]
[TASK] Update tslint 5.9.1 ❯ 5.10.0

yarn upgrade tslint@^5.10.0

Resolves: #85222
Releases: master
Change-Id: I6964d4a2d7cf1d9eefb5e19468b4fca8876c055a
Reviewed-on: https://review.typo3.org/57178
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Make UnitDeprecated/ notice free 68/57068/4
Christian Kuhn [Fri, 15 Jun 2018 10:37:02 +0000 (12:37 +0200)]
[TASK] Make UnitDeprecated/ notice free

Releases: master
Resolves: #85097
Change-Id: I1eb8cb056350badf057e58fe4c0d5c22b3568133
Reviewed-on: https://review.typo3.org/57068
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
8 months ago[BUGFIX] Respect query constraints in suggest receiver count 92/57192/4
Alexander Stehlik [Mon, 11 Jun 2018 18:51:17 +0000 (20:51 +0200)]
[BUGFIX] Respect query constraints in suggest receiver count

The query builder that fetches the results in the suggest
receiver is re-used to get the correct count of available
results.

Resolves: #85228
Relates: #78129
Releases: master
Change-Id: I2df36d4668cdde616242912e7f0d53bcded18021
Reviewed-on: https://review.typo3.org/57192
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Add proper replaces for merged core extensions 08/57208/6
Helmut Hummel [Wed, 13 Jun 2018 11:46:36 +0000 (13:46 +0200)]
[TASK] Add proper replaces for merged core extensions

If we merge a core extension into another one, it means
that the remaining extension technically replaces the
removed one.

To ease upgrades for composer based installations, we now
declare these replacements properly.

Resolves: #85250
Related: #81225
Related: #81787
Related: #81768
Related: #82896
Related: #82505
Related: #84680
Related: #81735
Related: #83631
Releases: master
Change-Id: I977a008de8b13fe61b5a7c091ad8d12cd45f6e4d
Reviewed-on: https://review.typo3.org/57208
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
8 months ago[TASK] Migrate PATH_site usages to Environment API - Part 1 63/57163/4
Benni Mack [Sat, 9 Jun 2018 19:04:22 +0000 (21:04 +0200)]
[TASK] Migrate PATH_site usages to Environment API - Part 1

Use Environment::getPublicPath() and Environment::getProjectPath()
respectively, depending on the use-case instead of PATH_site.

Resolves: #85259
Releases: master
Change-Id: I7debc10332232f3b8a29c9b8def268f389d71b88
Reviewed-on: https://review.typo3.org/57163
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Update grunt components 80/57180/4
Frank Naegler [Tue, 12 Jun 2018 15:27:34 +0000 (17:27 +0200)]
[TASK] Update grunt components

yarn upgrade grunt
yarn upgrade grunt-contrib-watch
yarn upgrade grunt-tslint

Resolves: #85224
Releases: master
Change-Id: I31ccdc090fa6fdf800c1bf1c62f7d409bb36e4a4
Reviewed-on: https://review.typo3.org/57180
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Rename $sortRow to $sortColumn in DataHandler 14/57214/2
Tymoteusz Motylewski [Wed, 13 Jun 2018 20:27:49 +0000 (22:27 +0200)]
[TASK] Rename $sortRow to $sortColumn in DataHandler

The new name makes the code easier to understand, as the variable
contains the column name configured in ['ctrl']['sortby'].

Resolves: #85258
Releases: master
Change-Id: I0237809c9029a634a50753a6978f74831ae8c14f
Reviewed-on: https://review.typo3.org/57214
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Add confirmation modal to delete a site configuration 70/57170/6
Georg Ringer [Sun, 10 Jun 2018 18:50:34 +0000 (20:50 +0200)]
[TASK] Add confirmation modal to delete a site configuration

Improve usability by adding a modal to require a second click.

Resolves: #85143
Releases: master
Change-Id: I310a655711aa730feca0b96e157c19eac8b7fcb0
Reviewed-on: https://review.typo3.org/57170
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[FEATURE] Enable SQLite in installation process 63/55563/12
Benni Mack [Mon, 5 Feb 2018 12:26:50 +0000 (13:26 +0100)]
[FEATURE] Enable SQLite in installation process

The patch adds SQLite as new DBMS platform to the TYPO3
instance installer if pdo_sqlite is available.

* sqlite has no database name and user / password restriction
  but stores the database in a single file.

* the filename contains a random string so it can't be easily
  guessed if the config directory is within web document root
  and the web server is configured to deliver .sqlite files.

* the feature .rst file mentions possible security risks comes
  with having a database within document root and documents
  how to prevent those.

* similar to mysql and postgres, an acceptance test verifies
  the system can be successfully installed using a blank
  installation and using the introduction package.

* bamboo plan spec is adapted to execute the sqlite installer suite

* testing-framework is raised to 3.8.1 supporting the ac test:
  composer update typo3/testing-framework

Resolves: #85256
Releases: master
Change-Id: I91a8c98f868b5e29bee4ad7dedd3cc8c50346452
Reviewed-on: https://review.typo3.org/55563
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[FEATURE] Add trait to detect public deprecated methods 56/57156/8
Benni Mack [Sat, 9 Jun 2018 13:24:26 +0000 (15:24 +0200)]
[FEATURE] Add trait to detect public deprecated methods

The patch adds a new trait similar to the existing one for
propreties to allow setting public methods to protected in
a backwards compatible way.

Resolves: #85247
Related: #81330
Releases: master
Change-Id: Iaf6d7f328f7b5685e179f4a4b8f78fbeb419fb14
Reviewed-on: https://review.typo3.org/57156
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Close file handle only if unused in FileWriter 04/57204/8
Susanne Moog [Tue, 12 Jun 2018 14:19:57 +0000 (16:19 +0200)]
[BUGFIX] Close file handle only if unused in FileWriter

Keep track of open file handles for resources across instances and
close the handle only on destructing the last known instance using it.

Resolves: #85245
Releases: master
Change-Id: I896f630521136474f843a271b5bd7c752a2efdaf
Reviewed-on: https://review.typo3.org/57204
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[BUGFIX] Fix namespace of validation error in form 11/57211/3
Justus Moroni [Wed, 13 Jun 2018 18:42:31 +0000 (20:42 +0200)]
[BUGFIX] Fix namespace of validation error in form

The FormElementHooks now uses the correct namespace
for the generated error.

The TranslateElementErrorViewHelper requires the submitted
error to be an instance of TYPO3\CMS\Extbase\Validation\Error.
The error was an instance of TYPO3\CMS\Extbase\Error\Error.
As the instance was wrong, an exception was thrown.

Resolves: #85255
Releases: master, 8.7
Change-Id: I6ccce5fb6370d2bf34f494141d73cc602eb923ce
Reviewed-on: https://review.typo3.org/57211
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
8 months ago[TASK] Handle some sqlite details 09/57209/7
Christian Kuhn [Wed, 13 Jun 2018 11:47:48 +0000 (13:47 +0200)]
[TASK] Handle some sqlite details

* Similar to postgresql, sqlite index names must be unique
  within the entire database. The patch adds a hash of the
  table name in front of indexes to make them unique.

* SELECT'ing rows from a table and UPDATE'ing them while the
  select query is still running is not safe in sqlite, single
  rows may appear over and over again in the select() result
  set. The patch switches a query combination to a fetchAll()
  on sqlite platform to prevent this.

Change-Id: Ib35ab4f46bbce7867ff9e4624e545b505c4f5e57
Resolves: #85253
Releases: master
Reviewed-on: https://review.typo3.org/57209
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Use Environment API instead of PATH_site for Cache Backends 61/57161/5
Benni Mack [Sat, 9 Jun 2018 15:58:40 +0000 (17:58 +0200)]
[TASK] Use Environment API instead of PATH_site for Cache Backends

The new Environment API is now used to define hashes or base paths
in cache backend classes.

Resolves: #85200
Releases: master
Change-Id: I08f770bf959274995e7983b800d8a569aee7cd47
Reviewed-on: https://review.typo3.org/57161
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
8 months ago[TASK] Update karma components 76/57176/2
Frank Naegler [Mon, 11 Jun 2018 12:03:29 +0000 (14:03 +0200)]
[TASK] Update karma components

yarn upgrade karma-coverage@1.1.2
yarn upgrade karma-jasmine@1.1.2

Resolves: #85220
Releases: master
Change-Id: I44019f08df4e2ab4f104236c055656f72f4d7015
Reviewed-on: https://review.typo3.org/57176
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Repair failing acceptance test 68/57168/2
Anja Leichsenring [Sun, 10 Jun 2018 16:13:37 +0000 (18:13 +0200)]
[TASK] Repair failing acceptance test

The test uses now a method to check on the element that takes the
DOM into consideration, and not the visibility on the interface.

Not the backend changed anything, but the testing methods of
codeception cause this failure. Using the correct testing method
solves the problem.

Resolves: #85208
Releases: master, 8.7
Change-Id: I349a555de2ab04c9f6181e5d71e4602fa9552df3
Reviewed-on: https://review.typo3.org/57168
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
8 months ago[TASK] Use current request object in Maintenance middleware 02/57202/2
Benni Mack [Tue, 12 Jun 2018 12:26:59 +0000 (14:26 +0200)]
[TASK] Use current request object in Maintenance middleware

The property `$GLOBALS['TYPO3_REQUEST']` is not needed when inside
a middleware, as the current PSR-7 request object is already available.

Resolves: #85242
Releases: master
Change-Id: Ib5062725dd74990c6a6003b6fcd8a82afb158c0b
Reviewed-on: https://review.typo3.org/57202
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Update chosen-js 1.8.3 ❯ 1.8.5 77/57177/2
Frank Naegler [Mon, 11 Jun 2018 12:08:15 +0000 (14:08 +0200)]
[TASK] Update chosen-js 1.8.3 ❯ 1.8.5

yarn upgrade chosen-js@1.8.5

Resolves: #85221
Releases: master
Change-Id: Ic97a68ead2145183ef3739584af8556b8a6cc139
Reviewed-on: https://review.typo3.org/57177
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Update @types definitions 75/57175/3
Frank Naegler [Mon, 11 Jun 2018 11:57:03 +0000 (13:57 +0200)]
[TASK] Update @types definitions

yarn upgrade @types/bootstrap@3.3.39
yarn upgrade @types/jasmine@2.8.8

Resolves: #85219
Releases: master
Change-Id: I33d30853ca6d631ae262047daf221c978d548c93
Reviewed-on: https://review.typo3.org/57175
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Remove mis-usage of TemplateService->fileHash 97/57197/3
Benni Mack [Tue, 12 Jun 2018 09:09:56 +0000 (11:09 +0200)]
[TASK] Remove mis-usage of TemplateService->fileHash

The fileHash property acts as an internal cache for
TemplateService->getFileName() and was misued since TYPO3 6.0 for
FAL-related information of processed images.

As this is a purely runtime-based cache (and internal), the usages here
are dropped.

Resolves: #85235
Releases: master
Change-Id: I96e8630cb8c45be009385aa5eccc01e3875e2d2b
Reviewed-on: https://review.typo3.org/57197
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Remove PHP bug workaround in GIFBUILDER 96/57196/3
Benni Mack [Tue, 12 Jun 2018 08:29:25 +0000 (10:29 +0200)]
[TASK] Remove PHP bug workaround in GIFBUILDER

TYPO3 has a bound box calculation workaround due to a PHP bug,
which was fixed in PHP 7.0.12 / 7.1, which can now safely be
removed.

Resolves: #85232
Releases: master
Change-Id: I72e9ea925ae7e91eea244b89a20b1bec2408ca78
Reviewed-on: https://review.typo3.org/57196
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Check in images which are marked as changed without changes 82/57182/4
Frank Naegler [Mon, 11 Jun 2018 12:52:24 +0000 (14:52 +0200)]
[BUGFIX] Check in images which are marked as changed without changes

Looks like a different file encoding of the images results
in marking these icons as changed on OS X.

Resolves: #85240
Releases: master
Change-Id: I37293134347e9aa16fe05671073e74f8621736d3
Reviewed-on: https://review.typo3.org/57182
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
8 months ago[TASK] Change label of Sites Module to "Sites" 99/57199/2
Mathias Schreiber [Tue, 12 Jun 2018 11:07:32 +0000 (13:07 +0200)]
[TASK] Change label of Sites Module to "Sites"

In order to make finding the module more straightforward, its tab label
has been set to “Sites” which should be more intuitive.

Releases: master
Resolves: #85239
Change-Id: I3d6d546f8439e4e107bf932efdc2d41ce65b4c75
Reviewed-on: https://review.typo3.org/57199
Reviewed-by: Riny van Tiggelen <info@online-gamer.nl>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Fix comments in various places 95/57195/4
Benni Mack [Tue, 12 Jun 2018 08:21:15 +0000 (10:21 +0200)]
[BUGFIX] Fix comments in various places

There are some places where phpdoc comments and return types are wrong,
(an IDE shows this ASAP to you if you open up the file).

The patch fixes the small glitches.

Resolves: #85231
Releases: master, 8.7
Change-Id: I3550e7631b31144989d09feee79d1c96da3079db
Reviewed-on: https://review.typo3.org/57195
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Deprecate methods in ReflectionService 96/56896/13
Alexander Schnitzler [Wed, 9 May 2018 08:13:29 +0000 (10:13 +0200)]
[TASK] Deprecate methods in ReflectionService

As the ReflectionService class is only a wrapper to call
methods on ClassSchema instances, all wrapper methods
should be deprecated and removed to make space for
a new, superior api.

Releases: master
Resolves: #85004
Change-Id: I7daabe1ab09c1c8a95b2b6dad2227c8859929dc0
Reviewed-on: https://review.typo3.org/56896
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
8 months ago[TASK] Set TYPO3 version to 9.4.0-dev 87/57187/2
Oliver Hader [Mon, 11 Jun 2018 17:16:36 +0000 (19:16 +0200)]
[TASK] Set TYPO3 version to 9.4.0-dev

Change-Id: I0281fd494612837d46966c4cdcbda5ee11c63809
Reviewed-on: https://review.typo3.org/57187
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[RELEASE] Release of TYPO3 9.3.0 86/57186/2 v9.3.0
Oliver Hader [Mon, 11 Jun 2018 17:14:21 +0000 (19:14 +0200)]
[RELEASE] Release of TYPO3 9.3.0

Change-Id: I4adf71f27e40df89bc77825e6771d5b249cf1ffd
Reviewed-on: https://review.typo3.org/57186
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
8 months ago[BUGFIX] Don’t cut urls in link browser 83/57183/3
Frank Naegler [Mon, 11 Jun 2018 13:31:27 +0000 (15:31 +0200)]
[BUGFIX] Don’t cut urls in link browser

Using the second parameter of TBE_EDITOR.rawurlencode cuts the input to
200 characters for any input value. The parameter is rather useless and
its usage can be simply removed to allow URLs with more than 200
characters.

Resolves: #85226
Releases: master, 8.7
Change-Id: I8391488d6fb21ede9280041dd41e3feb7e19dbd1
Reviewed-on: https://review.typo3.org/57183
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[BUGFIX] Remove postcss config for EXT:frontend 81/57181/2
Frank Naegler [Mon, 11 Jun 2018 12:49:01 +0000 (14:49 +0200)]
[BUGFIX] Remove postcss config for EXT:frontend

Since EXT:frontend does not have CSS files anymore, the
postcss config for Grunt is not necessary anymore.

Resolves: #85225
Releases: master
Change-Id: Ibdecf246c2841e383d745dfdfbf7f3a7181be19b
Reviewed-on: https://review.typo3.org/57181
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Fix broken ?? checks by adding required brackets 74/57174/4
Frank Naegler [Mon, 11 Jun 2018 09:11:53 +0000 (11:11 +0200)]
[BUGFIX] Fix broken ?? checks by adding required brackets

Resolves: #85213
Related: #84993
Releases: master
Change-Id: Ib8cd46951cb5032a7554042e2d8a7a052102788b
Reviewed-on: https://review.typo3.org/57174
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Have EM only evaluate current ext_tables.sql on installation 73/57173/4
Benni Mack [Mon, 11 Jun 2018 06:34:19 +0000 (08:34 +0200)]
[TASK] Have EM only evaluate current ext_tables.sql on installation

The EM changes due to the new automatic DB fields addition for TCA-based
tables come with a small side-effect, namely that all extensions are
now evaluated when doing the SQL create queries.

The introduced changes now only do execute "safe" DB updates, but not
limited to an extension, but for all installed extensions.
Thus, non-safe DB operations are not taken into account for an extension
installation/upgrade anymore.

The patch reverts the changes to the original behaviour, so that a
follow-up patch can introduce the following behaviour:
- Install extension
- Do _safe_ DB updates for the whole system
- Do breaking DB updates for the extensions to be installed/upgraded
- Execute ext_tables_*adt.sql files + imports

Resolves: #85215
Releases: master
Change-Id: Ief1118319eb0afcd586efdff506cf44d00e02fb7
Reviewed-on: https://review.typo3.org/57173
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
8 months ago[TASK] Disallow access to .sqlite files in MS IIS demo config 53/57153/2
Christian Kuhn [Sat, 9 Jun 2018 10:15:31 +0000 (12:15 +0200)]
[TASK] Disallow access to .sqlite files in MS IIS demo config

Resolves: #85190
Related: #85188
Releases: master
Change-Id: Ia77e74753fcca2c13b0e32b2dce186723c457775
Reviewed-on: https://review.typo3.org/57153
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Properly reset unit test singletons 69/57169/11
Christian Kuhn [Sun, 10 Jun 2018 17:30:14 +0000 (19:30 +0200)]
[TASK] Properly reset unit test singletons

typo3/testing-framework since version 3.8.0 can reset
singletons created by makeInstance automatically
if $this->$resetSingletonInstances is set to true.

This version additionally checks for left over singletons
in case that property has not been set and lets tests
fail in this case.

composer require --dev typo3/testing-framework:^3.8

As advantage, a manual backup of singleton instances
within tests is not needed anymore.

The patch comes with a set of test case adaptions to
cope with this new situation.

Change-Id: Ib5f278145e385e32d543541872cf5e1f208fad47
Resolves: #85209
Releases: master
Reviewed-on: https://review.typo3.org/57169
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Fix generation of create action URLs in backend user module 72/57172/3
Andreas Fernandez [Sun, 10 Jun 2018 19:09:20 +0000 (21:09 +0200)]
[BUGFIX] Fix generation of create action URLs in backend user module

The URLs to the create actions for backend users and backend groups were
built in a strange way which required some quirks to be fully functional.

This patch removes the unnecessary `explodeUrl2Array()` call, which also
renders the `rawurlencode()` obsolete.

Resolves: #85211
Releases: master
Change-Id: I3b8f5864fc398b9a4f8f2c0de5d72a38cb8a471b
Reviewed-on: https://review.typo3.org/57172
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
8 months ago[BUGFIX] Use proper import statement in ErrorController 71/57171/4
Benni Mack [Sun, 10 Jun 2018 19:02:23 +0000 (21:02 +0200)]
[BUGFIX] Use proper import statement in ErrorController

Due to moving a class name the import statement
in ErrorController was wrong.

Resolves: #85210
Related: #85101
Releases: master
Change-Id: I17cd062868ca3d0686218abd469a72cbdd08018b
Reviewed-on: https://review.typo3.org/57171
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Move documentation files from master into 9.3 folder 58/57158/8
Anja Leichsenring [Sat, 9 Jun 2018 10:04:41 +0000 (12:04 +0200)]
[TASK] Move documentation files from master into 9.3 folder

Resolves: #85202
Releases: master
Change-Id: I6f61db1d2c29a3b9d4794e33cbaf2c6e634e14c7
Reviewed-on: https://review.typo3.org/57158
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Remove static method variables 67/57167/5
Christian Kuhn [Sun, 10 Jun 2018 12:49:01 +0000 (14:49 +0200)]
[TASK] Remove static method variables

Static method variables are even more pita than static class
variables, especially if their state is created from db rows
or path information: It is nearly impossible to get rid of
this state at a later point again, even reflection does not
help here.

The patch abandons all 'static $foo' method variables from
the system, using these strategies:

* Remove some entirely which were used as first level cache
  and only cache-away simple non db related code structures.
* Switch some to use cache framework cache_runtime instead
  which can be evicted easily.
* Use class properties in some cases instead.

Change-Id: Ic699846a2c6ec661ee1124ace50df1aa04a1954b
Resolves: #85206
Releases: master
Reviewed-on: https://review.typo3.org/57167
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[BUGFIX] Documentation: use FQCN in Table Garbage Collection Tasks 66/57166/3
Michael Schams [Sun, 10 Jun 2018 10:01:47 +0000 (20:01 +1000)]
[BUGFIX] Documentation: use FQCN in Table Garbage Collection Tasks

The fully qualified class name of class `TableGarbageCollectionTask`
must be used to configure database tables, which should be cleaned up
(inactive or deleted records removed from the system).

This change replaces `tx_scheduler_TableGarbageCollection` with the
correct class name in the documentation:
\TYPO3\CMS\Scheduler\Task\TableGarbageCollectionTask::class

Releases: master
Resolves: #85205
Change-Id: I13434bf6bc13dd987263605d845f8b59b69e0796
Reviewed-on: https://review.typo3.org/57166
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Make Tests/Unit/TypoScript/ notice free 63/57063/7
Jan Helke [Mon, 28 May 2018 11:50:57 +0000 (13:50 +0200)]
[TASK] Make Tests/Unit/TypoScript/ notice free

Releases: master
Resolves: #85092
Change-Id: I29bb5a3d0546d790d9c8d05c52f448ecefbc8564
Reviewed-on: https://review.typo3.org/57063
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Fix broken additional fields for garbarge collection task 36/57136/4
Frank Naegler [Thu, 7 Jun 2018 09:41:17 +0000 (11:41 +0200)]
[BUGFIX] Fix broken additional fields for garbarge collection task

The new IpAnonymizationAdditionalFieldProvider introduced the same
JavaScript variable which breaks the garbage collection task.
The JavaScript initialization has been removed and the field provider
simplified.

Resolves: #85068
Releases: master, 8.7, 7.6
Change-Id: Ibb307ee37d6fea33a721373bdc50bbbd3fee1453
Reviewed-on: https://review.typo3.org/57136
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Prepare documentation move before release 52/57152/3
Anja Leichsenring [Sat, 9 Jun 2018 09:30:58 +0000 (11:30 +0200)]
[TASK] Prepare documentation move before release

New folder and includes to render the changelog for
the upcomming version.

Change-Id: I0440dcfdaf5541da5e8dbe8b8b681a477951fc14
Resolves: #85202
Releases: master
Reviewed-on: https://review.typo3.org/57152
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Move MetaTagManagers of OpenGraph and Twitter to EXT:seo 62/57162/2
Benni Mack [Sat, 9 Jun 2018 18:04:46 +0000 (20:04 +0200)]
[TASK] Move MetaTagManagers of OpenGraph and Twitter to EXT:seo

The new SEO extension handles opengraph and twitter (seo-relevant),
thus do not need to stay in EXT:core, as they are only for sites which
need SEO relevant information to be processed.

Resolves: #85201
Releases: master
Change-Id: Ib0bf503bb939b47747dc32209f78f8e7ce8622c1
Reviewed-on: https://review.typo3.org/57162
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Make core/Tests/Unit/Service/ notice free 59/57059/6
Jan Helke [Mon, 28 May 2018 11:38:33 +0000 (13:38 +0200)]
[TASK] Make core/Tests/Unit/Service/ notice free

Releases: master
Resolves: #85088
Change-Id: Ibd443902f6c89e16946d3d8d2cc39a8e2091054e
Reviewed-on: https://review.typo3.org/57059
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Make core/Tests/Unit/Configuration notice free 59/56659/8
Jan Helke [Sat, 14 Apr 2018 14:23:35 +0000 (16:23 +0200)]
[TASK] Make core/Tests/Unit/Configuration notice free

Releases: master
Resolves: #84722
Change-Id: I0edb98c7713f5c6520cbbc33e3f85ab1b3f4946f
Reviewed-on: https://review.typo3.org/56659
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[BUGFIX] Remove TypoScript dependency of AdminPanelInitiator 47/57147/3
Susanne Moog [Fri, 8 Jun 2018 08:14:17 +0000 (10:14 +0200)]
[BUGFIX] Remove TypoScript dependency of AdminPanelInitiator

The admin panel initialization is done via middleware before the
TypoScript is fully initialized, therefor it cannot have dependencies
to parsed TypoScript (and it cannot be initialized at a later state
because of cross-dependencies with TSFE).

Before #85104 the checks did not include TypoScript - that state has
been restored and the dependency has been removed.

Resolves: #85193
Releases: master
Change-Id: Ic576b02a68ddc20f52b4b1647b0e38c51e1b7df8
Reviewed-on: https://review.typo3.org/57147
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
8 months ago[TASK] Add functional test for exbase validation caching 07/49307/15
Alexander Stehlik [Sat, 9 Jun 2018 16:50:11 +0000 (18:50 +0200)]
[TASK] Add functional test for exbase validation caching

The tests demonstrate the issue described in the ticket
is not present anymore.

Resolves: #77338
Releases: master
Change-Id: I7002b9754f556f23850fda5026861c742f70bcdc
Reviewed-on: https://review.typo3.org/49307
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Make HtmlParserTest notice free 63/56663/8
Jan Helke [Sun, 15 Apr 2018 06:14:02 +0000 (08:14 +0200)]
[TASK] Make HtmlParserTest notice free

Releases: master
Resolves: #84724
Change-Id: I92a7ccbc88463d3fb3925185247331acf2977e40
Reviewed-on: https://review.typo3.org/56663
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Make core/Tests/Unit/Configuration/ notice free 65/57065/5
Jan Helke [Mon, 28 May 2018 11:55:01 +0000 (13:55 +0200)]
[TASK] Make core/Tests/Unit/Configuration/ notice free

Releases: master
Resolves: #85094
Change-Id: I7fe8e2dd15fa797eef9b153bf2935187181149ae
Reviewed-on: https://review.typo3.org/57065
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Make core/Tests/Unit/Migrations/ notice free 59/56759/2
Jan Helke [Fri, 20 Apr 2018 15:53:37 +0000 (17:53 +0200)]
[TASK] Make core/Tests/Unit/Migrations/ notice free

Releases: master
Resolves: #84816
Change-Id: I3f0bb5ab96743762977177cad1e6f125b9f23c73
Reviewed-on: https://review.typo3.org/56759
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Make core/Tests/Unit/Mail/ notice free 51/56751/5
Jan Helke [Fri, 20 Apr 2018 09:56:26 +0000 (11:56 +0200)]
[TASK] Make core/Tests/Unit/Mail/ notice free

Releases: master
Resolves: #84808
Change-Id: Ia520395c0d4cb3a8efd6529a23a0f65d1fa9247a
Reviewed-on: https://review.typo3.org/56751
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Make core/Tests/Unit/Resource/Driver/ notice free 69/57069/5
Jan Helke [Mon, 28 May 2018 15:05:54 +0000 (17:05 +0200)]
[TASK] Make core/Tests/Unit/Resource/Driver/ notice free

Releases: master
Resolves: #85098
Change-Id: Id2b5c7efbf2672b4731a9bd4b238a0f4be25cd5c
Reviewed-on: https://review.typo3.org/57069
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Make NormalizeCommandTest.php notice free 66/57066/4
Jan Helke [Mon, 28 May 2018 11:56:49 +0000 (13:56 +0200)]
[TASK] Make NormalizeCommandTest.php notice free

Releases: master
Resolves: #85095
Change-Id: Iacfffe50c29a47c197c9887610bc0874007f7eec
Reviewed-on: https://review.typo3.org/57066
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Make CategoryRegistryTest.php notice free 55/56655/4
Tymoteusz Motylewski [Thu, 31 May 2018 08:54:39 +0000 (10:54 +0200)]
[TASK] Make CategoryRegistryTest.php notice free

Releases: master
Resolves: #84721
Change-Id: I4aca40a0225a84a5af7925b34fc578f28d78b9bc
Reviewed-on: https://review.typo3.org/56655
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Clean up MetaTagManager API 57/57157/10
Benni Mack [Sat, 9 Jun 2018 13:41:43 +0000 (15:41 +0200)]
[TASK] Clean up MetaTagManager API

Both the MetaTagManagerRegistry and the MetaTagManager are
singletons via TYPO3's SingletonInterface, thus, there is no
need for having a getInstance() within the API itself,
nor in any abstract / generic base classes.

Resolves: #85197
Releases: master
Change-Id: I9aa925a1646a4482313dd740ecc3ae45780c9432
Reviewed-on: https://review.typo3.org/57157
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
8 months ago[TASK] Store legacy deprecation file in generic log folder 60/57160/3
Benni Mack [Sat, 9 Jun 2018 15:10:34 +0000 (17:10 +0200)]
[TASK] Store legacy deprecation file in generic log folder

The deprecation log file that was used prior to v9.0, was previously
stored in typo3conf/deprecation_* which is still used for extensions
still using the old API, is now put into var/log/ where all other
log files reside.

For installations using the environment concept with
"$_ENV['TYPO3_PATH_APP']" - e.g. all installations in composer mode -
the file is now created at that place, for installations having
everything in the public web root, the file is now in
"typo3temp/var/log/deprecation_...log".

Resolves: #85198
Releases: master
Change-Id: I0fc23d9fec6cfa45241c041f64333deb90d44950
Reviewed-on: https://review.typo3.org/57160
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Remove extra check for pageNotFoundHandling 74/57074/6
Benni Mack [Mon, 28 May 2018 19:53:11 +0000 (21:53 +0200)]
[TASK] Remove extra check for pageNotFoundHandling

This fixes a functional test in EXT:workspaces,
allowing for getting rid of an extra check in the
frontend request workflow.

Resolves: #85199
Releases: master
Change-Id: I642fca3a2873f0fe758164fca3f9261480dbc4da
Reviewed-on: https://review.typo3.org/57074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Store only valid icon markup into local storage 46/57146/2
Frank Naegler [Fri, 8 Jun 2018 08:02:18 +0000 (10:02 +0200)]
[TASK] Store only valid icon markup into local storage

This patch prevent putting invalid data into localStorage in the rare
case that the AJAX call does not provide icon markup.

Resolves: #85184
Releases: master
Change-Id: Icddd88232bf9ac5f77e08ed7fbac475af8b469eb
Reviewed-on: https://review.typo3.org/57146
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] Ensure dynamically added TCA DB fields are added first 55/57155/4
Benni Mack [Sat, 9 Jun 2018 13:02:46 +0000 (15:02 +0200)]
[BUGFIX] Ensure dynamically added TCA DB fields are added first

The new functionality introduced in #85160 adds TCA control
database fields dynamically.
However, newly created extensions add these fields (except "uid"
which is a primary column) at the end after the content-related
fields.

The patch re-orders the columns to be added to move them to the
very beginning.

Resolves: #85195
Related: #85160
Releases: master
Change-Id: Ibcf77ae3fea41f067dca0f247bef50d00bdd014f
Reviewed-on: https://review.typo3.org/57155
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[TASK] Move new SEO fields to separate system extension 48/57148/17
Richard Haeser [Fri, 8 Jun 2018 09:05:36 +0000 (11:05 +0200)]
[TASK] Move new SEO fields to separate system extension

Move the new SEO fields to EXT:seo and prepare the extension for some
basic SEO features.

Resolves: #85194
Releases: master
Change-Id: I6ec087928080e217ce1824b2e9ad5cf0ca0606c8
Reviewed-on: https://review.typo3.org/57148
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
8 months ago[TASK] Remove FileStreamWrapperTest 54/57154/2
Christian Kuhn [Sat, 9 Jun 2018 11:27:34 +0000 (13:27 +0200)]
[TASK] Remove FileStreamWrapperTest

TYPO3\TestingFramework\Core\FileStreamWrapper belongs to the
testing-framework package. The unit test case has been moved
to it an can be removed from core.

Resolves: #85192
Related: #85096
Releases: master
Change-Id: I4d83f92275e34fdad3eac2550db4d3895b141f36
Reviewed-on: https://review.typo3.org/57154
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
8 months ago[TASK] Add test coverage for RouteDispatcher 95/56095/4
Christian Kuhn [Sun, 11 Mar 2018 09:31:05 +0000 (10:31 +0100)]
[TASK] Add test coverage for RouteDispatcher

The backend route dispatcher with its different controller
incarnations benefits from a basic code coverage.

Resolves: #85191
Related: #84196
Releases: master
Change-Id: I0ff1efae64c41e7fbeba8fb3569c5601cb005669
Reviewed-on: https://review.typo3.org/56095
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
8 months ago[TASK] Exclude tests from Composer packages 91/57091/2
Mathias Brodala [Wed, 30 May 2018 14:29:42 +0000 (16:29 +0200)]
[TASK] Exclude tests from Composer packages

Resolves: #85119
Releases: master, 8.7
Change-Id: If9c00379c1ac671bd6bb622ace47864866c34446
Reviewed-on: https://review.typo3.org/57091
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
8 months ago[TASK] Disallow access to .sqlite files 50/57150/3
Christian Kuhn [Fri, 8 Jun 2018 13:51:56 +0000 (15:51 +0200)]
[TASK] Disallow access to .sqlite files

With an upcoming feature to run TYPO3 on sqlite, the
database may end up within Web folder depending on
system setup. It may later come with additional checks to
prevent a direct database download, but it's a good
step to deny web access to .sqlite files via default
.htaccess already.

Resolves: #85188
Releases: master
Change-Id: Id382082f13fbce750b7cb3db98ddb1bc41b10f1e
Reviewed-on: https://review.typo3.org/57150
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
8 months ago[TASK] Execute functional tests on sqlite db platform 37/57137/17
Christian Kuhn [Thu, 7 Jun 2018 09:50:54 +0000 (11:50 +0200)]
[TASK] Execute functional tests on sqlite db platform

typo3/testing-framework 3.7.0 supports sqlite db platform
for functional tests. The patch updates the dependency and
adds sqlite functional tests in bamboo pre-merge and nightly.

composer update typo3/testing-framework

typo3DatabaseDriver=pdo_sqlite bin/phpunit -c \
 vendor/typo3/testing-framework/Resources/Core/Build/FunctionalTests.xml

There are some know issues already, especially the database
schema analyzer of the install tool behaves weird. However,
this patch is a first step towards sqlite support in the core.

Change-Id: I8e8474dabdf4015a32d3c938adc576fba9b5a5bd
Resolves: #85187
Releases: master
Reviewed-on: https://review.typo3.org/57137
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[BUGFIX] l10n_diffsource field can handle empty string and null value 49/57149/2
Christian Kuhn [Thu, 7 Jun 2018 09:50:54 +0000 (11:50 +0200)]
[BUGFIX] l10n_diffsource field can handle empty string and null value

Depending on DB platform, empty LOB fields can be returned
as NULL value (sqlite) or as empty string (mysql, our postgres
setup, mssql).

The patch adapts a minor detail in DataHandler since isset(null)
is false, but isset('') is true, it uses an array_key_exists()
instead for diff check on transOrigDiffSourceField / l10n_diffsource
field to align these two possible different db return values.

Resolves: #85186
Releases: master
Change-Id: I56c87fa519a0c787515eff403d48ac84e513300d
Reviewed-on: https://review.typo3.org/57149
Reviewed-by: Daniel Siepmann <daniel.siepmann@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Daniel Siepmann <daniel.siepmann@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
8 months ago[TASK] Move property merge behavior 45/57045/2
Ralf Zimmermann [Thu, 24 May 2018 07:13:44 +0000 (09:13 +0200)]
[TASK] Move property merge behavior

Move the property merge behavior from setOptions() into the related
methods (setRenderingOption(), setProperty(), setDefaultValue()).

Releases: master
Resolves: #85072
Change-Id: I1c002aeb8d889af68d6147d5c588709cd89ebf3c
Reviewed-on: https://review.typo3.org/57045
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
8 months ago[BUGFIX] Make styleguide a require-dev dependency 45/57145/3
Christian Kuhn [Fri, 8 Jun 2018 00:07:25 +0000 (02:07 +0200)]
[BUGFIX] Make styleguide a require-dev dependency

typo3/cms-styleguide has accidently been made a
require instead of a require-dev dependency
in composer.json

composer require --dev typo3/cms-styleguide ^9.1

Resolves: #85181
Related: #85180
Releases: master
Change-Id: Id109894e862ce5ac55a5533eccb8e25a9d8a6049
Reviewed-on: https://review.typo3.org/57145
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Update typo3/cms-styleguide 44/57144/3
Christian Kuhn [Thu, 7 Jun 2018 23:46:16 +0000 (01:46 +0200)]
[TASK] Update typo3/cms-styleguide

Brings a set of new adaptions to new core functionality.
Uses new core feature 'auto-create db fields' to reduce
ext_tables.sql.

composer require typo3/cms-styleguide ^9.1

Change-Id: I386eec9da50bd3ce7eb5ebb9af8957d3b1c8d9ac
Resolves: #85180
Releases: master
Reviewed-on: https://review.typo3.org/57144
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
8 months ago[TASK] Modernize category collection functional tests 43/57143/5
Christian Kuhn [Thu, 7 Jun 2018 21:15:51 +0000 (23:15 +0200)]
[TASK] Modernize category collection functional tests

Use a dummy extension and .csv imports from the
functional test framework instead of creating
tables and records on the fly.

Resolves: #85179
Releases: master
Change-Id: Ia8f077984e588a2bb142a0e516aad198f914bec9
Reviewed-on: https://review.typo3.org/57143
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[BUGFIX] Allow global RTE config again by PageTSConfig 38/57138/4
Frank Naegler [Thu, 7 Jun 2018 11:23:53 +0000 (13:23 +0200)]
[BUGFIX] Allow global RTE config again by PageTSConfig

With #85016 the PageTSConfig handling has been changed which
broke overloading RTE config by PageTSConfig.
This patch removes the obsolete 'properties' check to fix the problem.

Resolves: #85173
Related: #85016
Releases: master
Change-Id: I85e6d5d9d656ee578451e54f2e226e37cb101fc6
Reviewed-on: https://review.typo3.org/57138
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Align impexp functional export tests between db engines 41/57141/7
Christian Kuhn [Thu, 7 Jun 2018 17:37:23 +0000 (19:37 +0200)]
[TASK] Align impexp functional export tests between db engines

The ext:impexp related functional export tests compare
with different target .xml file exports depending on
the used db engine. This is ugly and pain to maintain.

The patch aligns last differences between the generated
exports by fixing sorting bugs in fixture db rows and adding
an explicit order by at test preparation stage.
Additionally, a column type bug in irre_tutorial fixture
extension got resolved.

The different .xml export file comparison fixtures per
db engine are then merged into one and the split logic
within tests removed.

Change-Id: I429d5127e09c3e3714edae938cb0bf796b3274fd
Resolves: #85178
Releases: master
Reviewed-on: https://review.typo3.org/57141
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
8 months ago[TASK] Force string values in impexp exports 40/57140/9
Christian Kuhn [Thu, 7 Jun 2018 13:34:59 +0000 (15:34 +0200)]
[TASK] Force string values in impexp exports

Method BackendUtility::getRecord() returns strings or integer
values for number columns like int / bigint. This detail depends
on the underlying driver, for instance mysqli returns integers
for those fields, while native pdo_mysql and our pdo_pgsql setup
return strings for everything.

This leads to different xml files when exporting records depending
on driver, since GeneralUtility::array2xml() may add type="integer".
That's especially nasty for the functional export tests and is one
reason we have to maintain dedicated xml fixture files per db driver.

During import, the type value does not matter, it needs to be able
to cope with both variants anyway.

The patch now just forces strings for all to-be-exported row values.

Resolves: #85175
Releases: master
Change-Id: Ic132d8abd906b34c59279ce025c0bdd65e954672
Reviewed-on: https://review.typo3.org/57140
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>