Packages/TYPO3.CMS.git
2 years ago[BUGFIX] Fix syntax errors in ext_tables.sql files 75/49675/3
Morton Jonuschat [Wed, 31 Aug 2016 07:58:15 +0000 (09:58 +0200)]
[BUGFIX] Fix syntax errors in ext_tables.sql files

Fix syntax errors by removing commas in excess after the last column/
key definition, add commas missing after column/key definitions and
removing default values for auto_increment columns.

Change-Id: Ica2dd1689211e56f6d9b01f7992867262cac3b5d
Resolves: #77706
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/49675
Tested-by: Bamboo TYPO3com <info@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Check if mount page exist before fetching icon 73/49673/2
Georg Ringer [Tue, 30 Aug 2016 22:35:13 +0000 (00:35 +0200)]
[BUGFIX] Check if mount page exist before fetching icon

To avoid fatal errors it must be checked if the mount pages
really exist before fetching its icon.

Resolves: #77663
Releases: master, 7.6
Change-Id: Icdb6009c6304096078e7b5bdba733f997a75e9f2
Reviewed-on: https://review.typo3.org/49673
Tested-by: Bamboo TYPO3com <info@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Exclude uid '0' from any editing action in Info > Pagetree Overview 59/49659/2
Andreas Fernandez [Mon, 29 Aug 2016 19:34:28 +0000 (21:34 +0200)]
[BUGFIX] Exclude uid '0' from any editing action in Info > Pagetree Overview

The module Info > Pagetree Overview offers the possibility to edit the
root page (uid 0) which is impossible as this is no real page.

The edit button for the row in the table representing the root page is
removed. The mass edit buttons in the table header don't allow to edit
that page anymore, too.

Resolves: #77678
Releases: master, 7.6
Change-Id: I7083c83372ad619ea8e8ffd2f53822bcd939d768
Reviewed-on: https://review.typo3.org/49659
Tested-by: Bamboo TYPO3com <info@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] EXT:sys_note: Button order 64/49664/2
Daniel Windloff [Tue, 30 Aug 2016 11:44:32 +0000 (13:44 +0200)]
[TASK] EXT:sys_note: Button order

In order to be consistent with list module,
change the order of the buttons to (edit,remove).

Resolves: #77690
Releases: master, 7.6
Change-Id: I6d9edb79c0533020713bcf075ee2df281dbc0136
Reviewed-on: https://review.typo3.org/49664
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Migrate to short array syntax 60/49660/3
Wouter Wolters [Tue, 30 Aug 2016 14:56:00 +0000 (16:56 +0200)]
[TASK] Migrate to short array syntax

As decided during T3ACME we will use the short
array syntax in master. The 7.6 branch will also be done
to make backporting easier.

Resolves: #77692
Releases: master,7.6
Change-Id: I37e9484b1012fc9161148257a842054c24d162ba
Reviewed-on: https://review.typo3.org/49660
Tested-by: Bamboo TYPO3com <info@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Load ClickMenu JavaScript in "Backend users" module 58/49658/2
Andreas Fernandez [Mon, 29 Aug 2016 20:25:05 +0000 (22:25 +0200)]
[BUGFIX] Load ClickMenu JavaScript in "Backend users" module

This patch adds the ClickMenu JavaScript to enable the click menu after
clicking the avatars.

Resolves: #77680
Releases: master, 7.6
Change-Id: I50025e97649957ffdc13abe974c5ce6f6df5f198
Reviewed-on: https://review.typo3.org/49658
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Add returnUrl to records opened by EXT:opendocs 57/49657/2
Andreas Fernandez [Mon, 29 Aug 2016 15:35:00 +0000 (17:35 +0200)]
[BUGFIX] Add returnUrl to records opened by EXT:opendocs

If a record that was opened by the opendocs menu gets closed, the user
now gets the record list of the record's pid.

Resolves: #77675
Releases: master, 7.6
Change-Id: I90014ea639ce191ad0ee2d1a1cd650d2aaaebc52
Reviewed-on: https://review.typo3.org/49657
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Make IconRegistry::getAllRegisteredIconIdentifiers() public API 50/49650/2
Frank Naegler [Tue, 30 Aug 2016 12:21:13 +0000 (14:21 +0200)]
[TASK] Make IconRegistry::getAllRegisteredIconIdentifiers() public API

The method IconRegistry::getAllRegisteredIconIdentifiers() was introduced
as a public function with an internal scope, but there is not reason to keep
this useful method "private" anymore.

Resolves: #77691
Related: #69054
Releases: master, 7.6
Change-Id: Ic98cc1f6a1f44926b6fd64a05b3678dcd638ddbf
Reviewed-on: https://review.typo3.org/49650
Tested-by: Bamboo TYPO3com <info@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[BUGFIX] Extbase cannot persist to datetime fields 46/47846/3
Andreas Wolf [Sun, 6 Mar 2016 12:46:35 +0000 (13:46 +0100)]
[BUGFIX] Extbase cannot persist to datetime fields

This patch adds missing column configuration to DataMapper call.

Resolves: #74376
Releases: master, 7.6
Change-Id: I505a5e9f05338fde48fad9f49391095e47523409
Reviewed-on: https://review.typo3.org/47846
Tested-by: Bamboo TYPO3com <info@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Build proper Bootstrap markup in Info > Localization Overview 31/49631/2
Andreas Fernandez [Mon, 29 Aug 2016 19:43:57 +0000 (21:43 +0200)]
[BUGFIX] Build proper Bootstrap markup in Info > Localization Overview

Table columns can't have the class `btn-group`. This patch generates a
proper markup by using `<div>`.

Resolves: #77679
Releases: master, 7.6
Change-Id: Iad7bb77017a8f9e007ece752a16e5f1fe98c774f
Reviewed-on: https://review.typo3.org/49631
Reviewed-by: Philipp Gampe <philipp.gampe@typo3.org>
Tested-by: Philipp Gampe <philipp.gampe@typo3.org>
2 years ago[BUGFIX] Enforce RSA encryption for re-login modal 78/49478/4
Helmut Hummel [Sun, 14 Aug 2016 13:06:24 +0000 (15:06 +0200)]
[BUGFIX] Enforce RSA encryption for re-login modal

The RsaEncryption and the LoginRefresh module are loaded
independently by requireJS, which means they are loaded
asynchronous. This means that either one of those modules
is initialized first.

However the RsaEncryption module scans the DOM for form elements
and the LoginRefresh inserts a form. This means if the RsaEncryption
is initialized first, then the form created by LoginRefresh
will not be intercepted, leading to the (heisen-)bug described.

This change enforces the loading order by adding the RsaEncryption
as dependency to LoginRefresh and registering the form manually,
to make sure it will be intercepted and passwords
will transmitted encrypted.

Resolves: #75911
Releases: 7.6, master
Change-Id: Ib4aba70b3545f163a16a4eee62bed9e5a48b2fe7
Reviewed-on: https://review.typo3.org/49478
Tested-by: Bamboo TYPO3com <info@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Use correct history icon in EditDocumentController 90/49590/2
Georg Ringer [Thu, 25 Aug 2016 05:26:18 +0000 (07:26 +0200)]
[TASK] Use correct history icon in EditDocumentController

Use the same icon in the edit form of a record as in the clickmenu
and in the list module.

Resolves: #77628
Releases: master, 7.6
Change-Id: I977d7064067bcca2a924e3aa676b893f1f5c8525
Reviewed-on: https://review.typo3.org/49590
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years agoRevert "[TASK] Remove locale-workaround for PHP before 5.5" 70/49570/3
Frans Saris [Fri, 19 Aug 2016 13:20:10 +0000 (15:20 +0200)]
Revert "[TASK] Remove locale-workaround for PHP before 5.5"

This reverts commit 23b588c584f485f10ae265bf30e15d231f428f1e.

The change is reverted as str_* methods are locale aware
and turkish has no upper case I. Class autoloading and other
checks depending on case changing break with turkish locale LC_CTYPE.

Change-Id: Ie4fb92411eeb2552972b92b3f2bcfdb47afcdd54
Resolves: #77551
Reverts: #63288
Releases: master,7.6
Reviewed-on: https://review.typo3.org/49570
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[BUGFIX] FilesReplacePermissionUpdate wrong where clause 79/49479/2
Christian Kuhn [Sun, 14 Aug 2016 15:23:23 +0000 (17:23 +0200)]
[BUGFIX] FilesReplacePermissionUpdate wrong where clause

The where clause to check for updates should select
records that have writeFile set, but not replaceFile.

Change-Id: I048909d6b722d1c9ae23c5815a05a7f93fcdc956
Resolves: #77500
Releases: 7.6
Reviewed-on: https://review.typo3.org/49479
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Provide full url as origin for embedded Youtube videos 72/49572/2
Sebastian Michaelsen [Mon, 8 Aug 2016 07:45:37 +0000 (09:45 +0200)]
[BUGFIX] Provide full url as origin for embedded Youtube videos

To use the javascript API for embedded Youtube videos the documentation
recommends to provide the "full website url" as origin parameter

Change-Id: I318083b4c67b48c7eb708e54b11cd8dd1c69d646
Resolves: #77409
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/49572
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Prevent console warning in jsfunc.evalfield.js 69/49569/2
Wouter Wolters [Tue, 23 Aug 2016 20:13:00 +0000 (22:13 +0200)]
[TASK] Prevent console warning in jsfunc.evalfield.js

Remove the unreachable code to prevent a warning on the console.

Resolves: #77539
Releases: master,7.6
Change-Id: I679a13456ac5e22b2522d8273a4253a93d9fdc2d
Reviewed-on: https://review.typo3.org/49569
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[BUGFIX] Fix wrong configuration documentation for onlineMediaHelpers 66/49566/2
Wouter Wolters [Tue, 23 Aug 2016 20:22:40 +0000 (22:22 +0200)]
[BUGFIX] Fix wrong configuration documentation for onlineMediaHelpers

['SYS']['OnlineMediaHelpers'] must be ['SYS']['fal']['onlineMediaHelpers']

Resolves: #77567
Releases: 7.6
Change-Id: Ie8f23a82d63ec1e02a956c17dbabfdb72d24262f
Reviewed-on: https://review.typo3.org/49566
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix sql error in EXT:linkvalidator 63/49563/2
Daniel Windloff [Tue, 23 Aug 2016 05:56:24 +0000 (07:56 +0200)]
[BUGFIX] Fix sql error in EXT:linkvalidator

If no page is selected, skip sql queries in LinkAnalyzer
getLinkStatistics.

Resolves: #77588
Releases: master, 7.6, 6.2
Change-Id: I3b45cbad6962c5327d860b182e61255018bf0e53
Reviewed-on: https://review.typo3.org/49563
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Continue searching after empty result 62/49562/2
Alexander Jahn [Mon, 22 Aug 2016 07:09:00 +0000 (09:09 +0200)]
[BUGFIX] Continue searching after empty result

Change the default behaviour of jQuery autocomplete to continue
searching for characters even if the search already returned nothing.

The standard behaviour of autocomplete is to stop searching after
no results were found.
However, this made it impossible to use commands.
Searching for '#content:12345' did not work when '#con' could not
be found. Search was not executed for subsequent characters.

The parameter 'preventBadQueries: false' is used to force
searching for every character entered.

Resolves: #77566
Releases: master, 7.6
Change-Id: I423df51ae34ae258c42a418040d24cd91886872a
Reviewed-on: https://review.typo3.org/49562
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Keep configuration of extbase table column cache 52/49552/2
Christian Kuhn [Tue, 23 Aug 2016 11:54:37 +0000 (13:54 +0200)]
[BUGFIX] Keep configuration of extbase table column cache

To mitigate the possible impact of the removal of table column
cache for extensions in 7.6, the cache configuration is kept
but the backend set to NullBackend.

Change-Id: Ida1b6b27d34b1703aca148f726d5ba051faaa3d1
Resolves: #77604
Related: #77411
Releases: 7.6
Reviewed-on: https://review.typo3.org/49552
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move reload button in recycler to right 42/49542/2
Georg Ringer [Mon, 22 Aug 2016 17:48:29 +0000 (19:48 +0200)]
[TASK] Move reload button in recycler to right

To be in sync with all other modules, the recycler
button in the toolbar is moved to the right.

Resolves: #77570
Releases: master, 7.6
Change-Id: I6d681239d1d9dc10be356b576c0ac9cb1315a187
Reviewed-on: https://review.typo3.org/49542
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Improve media of pages_language_overlay 35/49535/2
Georg Ringer [Mon, 22 Aug 2016 05:31:50 +0000 (07:31 +0200)]
[TASK] Improve media of pages_language_overlay

FAL relations in translated pages must have the same
properties as in regular pages which includes link fields and the
cropping editor.

Resolves: #77541
Releases: master, 7.6
Change-Id: Ice77cd6c752e46ee048d07ca60c9b76cfc5509e8
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
(cherry picked from commit bd4ad2448d5ec1d3afc98636c1cba70e3a482778)
Reviewed-on: https://review.typo3.org/49535
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Fix column "note" to be compatible with MySQL strict mode 34/49534/3
Wouter Wolters [Mon, 22 Aug 2016 07:48:03 +0000 (09:48 +0200)]
[BUGFIX] Fix column "note" to be compatible with MySQL strict mode

Resolves: #77568
Releases: master,7.6
Change-Id: Ie056cd7fc1d12149b534c6669cb8fe33f83ce667
(cherry picked from commit a346467cd71bb40d7c4d96f2a1460dadbd03dd08)
Reviewed-on: https://review.typo3.org/49534
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Fix unsafe URL removal in EXT:felogin 24/49524/2
Georg Ringer [Thu, 28 Jul 2016 16:01:48 +0000 (18:01 +0200)]
[BUGFIX] Fix unsafe URL removal in EXT:felogin

A comma can be a valid char inside a url and must not used as
delimiter.

Resolves: #75915
Releases: master, 7.6
Change-Id: I0eb3c6389b5d28e96b981217d09c2fef5dbf331d
Reviewed-on: https://review.typo3.org/49524
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix message "Translate to" 22/49522/2
Georg Ringer [Tue, 16 Aug 2016 17:55:38 +0000 (19:55 +0200)]
[BUGFIX] Fix message "Translate to"

Reset the variable to be able to set the text "Translate to" for
multiple fields.

Resolves: #77506
Releases: master, 7.6
Change-Id: I6b18f30ece04ae5cf5710617dbbc5ea2c0855ad6
Reviewed-on: https://review.typo3.org/49522
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Allow URL path segments like "typo3" 09/49509/2
Mathias Brodala [Mon, 4 Jul 2016 14:16:37 +0000 (16:16 +0200)]
[BUGFIX] Allow URL path segments like "typo3"

Tighten the RewriteRule for static resource passthrough to allow for
speaking URL path segments like "typo3", "fileadmin", etc. instead of
causing a 404 error.

This issue was introduced with https://review.typo3.org/39254/

Resolves: #76928
Releases: master, 7.6, 6.2
Change-Id: I9815b7626d6a33677a3f971f452c0600141632b4
Reviewed-on: https://review.typo3.org/49509
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Felogin form with default layout is not visible 07/49507/2
Michiel Roos [Tue, 19 Apr 2016 10:38:34 +0000 (12:38 +0200)]
[BUGFIX] Felogin form with default layout is not visible

Updated felogin documentation to explain you need to manually
add a TypoScript constant for the template if you run felogin
on TYPO3 6.2 with css_styled_content v4.5.

Change-Id: I7ad6f0722e218c285055360af07f1147f9b89abf
Resolves: #67894
Releases: master, 7.6, 6.2
Reviewed-on: https://review.typo3.org/49507
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] PHP 7.1: Non-numeric value encountered 06/49506/2
Christian Kuhn [Tue, 5 Jul 2016 21:29:44 +0000 (23:29 +0200)]
[BUGFIX] PHP 7.1: Non-numeric value encountered

$foo = 1 + 'aString'; in PHP 7.1 throws:
PHP Warning: A non-numeric value encountered in ...

Fix this by removing a test that tests this language
construct only instead of the test subject.

Change-Id: I74117cfd003bb525b0a7a674df4aae45d8f92299
Resolves: #76948
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/49506
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Update contribution walkthrough link 05/49505/2
Christian Kuhn [Fri, 5 Aug 2016 21:47:40 +0000 (23:47 +0200)]
[TASK] Update contribution walkthrough link

The contribution walkthrough has been moved from the
wiki to docs.typo3.org

Change-Id: I683bfad410aa75a1dab7fee91b7f0b3cee60070d
Resolves: #77423
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/49505
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[BUGFIX] Use special treatment for language field in RelationHandler 85/49485/3
Esteban Marín [Tue, 2 Aug 2016 09:21:52 +0000 (11:21 +0200)]
[BUGFIX] Use special treatment for language field in RelationHandler

This fixes saving the default language in BE user group permissions.

Fixes: #75998
Releases: master,7.6
Change-Id: Iace9a0e04b57a7306a529402c7a44b777f494290
Reviewed-on: https://review.typo3.org/49485
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Handle l10n_parent if field is no select-type 77/49477/2
Markus Klein [Fri, 29 Jul 2016 09:31:39 +0000 (11:31 +0200)]
[BUGFIX] Handle l10n_parent if field is no select-type

The value of l10n_parent is not necessarily an array.
It may as well be a string from a group-type or simple
input.
Adjust the condition for overlay detection accordingly.

Resolves: #77301
Releases: master, 7.6
Change-Id: I9119dfc0a55d623f037f15ddf1e11f132cf38c0b
Reviewed-on: https://review.typo3.org/49477
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Search in Install Tool must find input values 30/49430/2
Frank Naegler [Fri, 5 Aug 2016 13:47:03 +0000 (15:47 +0200)]
[BUGFIX] Search in Install Tool must find input values

Resolves: #77356
Releases: master, 7.6
Change-Id: I6127c03de37eb5b60dc13217e1f7528a4b628fa4
Reviewed-on: https://review.typo3.org/49430
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix broken language flags via IconUtility::getSpriteIcon 61/49161/4
Frank Naegler [Fri, 22 Jul 2016 08:03:10 +0000 (10:03 +0200)]
[BUGFIX] Fix broken language flags via IconUtility::getSpriteIcon

With #70477 the SpriteIcon stuff has been marked as deprecated.
The patch removed the flags support. This patch fix the problem by checking
the IconRegisty and return the icon by using the IconFactory.

Resolves: #76996
Related: #70477
Releases: 7.6
Change-Id: I0323c6bc132eb9a8049294ee66ac3cf37d10f9fd
Reviewed-on: https://review.typo3.org/49161
Reviewed-by: Thomas Mayer <thomas.mayer@2bis10.de>
Tested-by: Thomas Mayer <thomas.mayer@2bis10.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Check opendir result in fixPermissions 07/49407/2
Tomita Militaru [Wed, 11 May 2016 08:55:48 +0000 (10:55 +0200)]
[BUGFIX] Check opendir result in fixPermissions

Checks opendir result if it is a resource before passing it
to readdir.

Resolves: #47981
Releases: master, 7.6
Change-Id: I45ca844c7ab353a28dc7002ec206bcb054b01c96
Reviewed-on: https://review.typo3.org/49407
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] 'eval' => 'null' field stays disabled 03/49403/2
Frank Naegler [Fri, 5 Aug 2016 19:50:38 +0000 (21:50 +0200)]
[BUGFIX] 'eval' => 'null' field stays disabled

This is a regression fix, introduced with #75397

Resolves: #77287
Related: #75397
Releases: master, 7.6
Change-Id: I405646aee0acc6a67753c79ae4b3d3c5f8de1bed
Reviewed-on: https://review.typo3.org/49403
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[TASK] Remove extbase table column cache 96/49396/3
Benni Mack [Thu, 4 Aug 2016 15:17:04 +0000 (17:17 +0200)]
[TASK] Remove extbase table column cache

The extbase table column cache "extbase_typo3dbbackend_tablecolumns"
stores all DB fields of all DB tables to detect if the TCA table contains
a field named "pid".

However, if a DB table has a TCA definition but no PID, then it fails
at so many places. No need to execute a admin_get_fields call on every
method call.
(Which caches this information - ironically - in the database by default)

The cache can be removed without substitution as the superfluous
check on the DB field "pid" is removed.

Resolves: #77411
Releases: master, 7.6
Change-Id: Ib4dca4e5f895f0e4334c26482423b833dcb773ca
Reviewed-on: https://review.typo3.org/49396
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make EXT:filemetadata work with MySQL strict mode 91/49391/2
Benni Mack [Fri, 5 Aug 2016 13:14:24 +0000 (15:14 +0200)]
[BUGFIX] Make EXT:filemetadata work with MySQL strict mode

EXT:filemetadata delivers a lot of sys_file_metadata fields
with NOT NULL in it, which does not make sense.

MySQL strict mode does not work with this SQL definition.

Resolves: #77418
Releases: master, 7.6
Change-Id: Ia93c3fd88066ba148b26eb8044fa297d8572c86f
Reviewed-on: https://review.typo3.org/49391
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] EXT:sysext: enlarge column field in sys_refindex to 64 chars 71/49371/2
Jörg Bösche [Wed, 3 Aug 2016 21:21:08 +0000 (23:21 +0200)]
[TASK] EXT:sysext: enlarge column field in sys_refindex to 64 chars

Concern extension "sysext".

Additional field names in the database tables, which are greater than
40 characters are not completely saved. Often new columns have an
extension prefix and a name.
e.g. tx_myextension_model_tags_customFieldName
Since MySQL 5.5+ it is possible to define database table name
columns with 64 characters.

The fix is for the master branch and backporting the version 7.6 LTS.
Version 7.6 LTS requires MySQL version 5.5+.

Resolves: #77323
Releases: master, 7.6
Change-Id: Ia163599c37c53275b0e36443f4f9f4c52919800a
Reviewed-on: https://review.typo3.org/49371
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] EXT:form - Update documentation 70/49370/2
Björn Jacob [Tue, 28 Jun 2016 06:26:26 +0000 (08:26 +0200)]
[TASK] EXT:form - Update documentation

Added new screenshots. Removed documentation for obsolete "breakOnError"
configuration. Corrected grammar and typos.

Resolves: #70087
Releases: master, 7.6
Change-Id: Iaa1e58e0583f8293eb2d26c65fbf35f87ae4e017
Reviewed-on: https://review.typo3.org/48699
Tested-by: Bamboo TYPO3com <info@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-on: https://review.typo3.org/49370

2 years ago[BUGFIX] Opposite MM relation between both new entities not created 52/49352/2
Oliver Hader [Tue, 2 Aug 2016 22:32:11 +0000 (00:32 +0200)]
[BUGFIX] Opposite MM relation between both new entities not created

Scenario:
* usage in a workspace
* tt_content and sys_category records are created at the same time
  with defining an MM relation
* sys_category.items (group/db field, with MM and opposite usage
  defined) is filled with accordant tt_content record

Problem:
* the remap-stack in DataHandler does not consider references that
  are defined in a group/db field
* thus, these kind of relations are just not set, since the opposite
  reference uid cannot be resolved

Solution:
* process group/db relations with new record uids in remap-stack

Resolves: #77374
Releases: master, 7.6
Change-Id: If5e6589e2a0995dc4fce3ff49bd309f2fdb6eb24
Reviewed-on: https://review.typo3.org/49337
Reviewed-on: https://review.typo3.org/49352
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[TASK] Add functional tests for versioned MM references 51/49351/2
Oliver Hader [Wed, 3 Aug 2016 14:03:05 +0000 (16:03 +0200)]
[TASK] Add functional tests for versioned MM references

Functional tests are integrated to simulate editing MM references
in a workspace context, however with submitting the live uids of
the accordant entities to be referenced.

Resolves: #77384
Releases: master, 7.6
Change-Id: I207f20ff4ac7d041a353e5d250f9283b0e62e591
Reviewed-on: https://review.typo3.org/49351
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Allow array of paths in psr-4 autoload definition 36/49336/2
Helmut Hummel [Tue, 2 Aug 2016 19:28:56 +0000 (21:28 +0200)]
[BUGFIX] Allow array of paths in psr-4 autoload definition

When defining a namespace prefix for psr-4 autoload in composer.json,
it is possible to specify multiple paths as array.

Thus, we must handle the array case properly and not falsely assume
that there is only a path string.

Resolves: #77365
Releases: 7.6, master
Change-Id: If96f4ce9eb3f4466e8cc620025b1848681b56011
Reviewed-on: https://review.typo3.org/49336
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Fix executable permissions on files 33/49333/2
Wouter Wolters [Tue, 2 Aug 2016 19:47:23 +0000 (21:47 +0200)]
[BUGFIX] Fix executable permissions on files

Exclude:

typo3/sysext/core/Build/Scripts/xlfcheck.sh
typo3/cli_dispatch.phpsh

Resolves: #77363
Releases: 7.6
Change-Id: I70871c4ebfb964f396e087ba4bbb1205a4fd8fab
Reviewed-on: https://review.typo3.org/49333
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Semaphore test: release system resources 30/49330/2
Markus Klein [Tue, 2 Aug 2016 17:41:39 +0000 (19:41 +0200)]
[BUGFIX] Semaphore test: release system resources

The tests now properly destroy occupied system resources.

Resolves: #77364
Releases: master, 7.6
Change-Id: I54bd86385f9418ba9e7f3cba3bae440d1fd82d2d
Reviewed-on: https://review.typo3.org/49330
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Update "workspaces" documentation 26/49326/2
Francois Suter [Tue, 2 Aug 2016 17:05:36 +0000 (19:05 +0200)]
[TASK] Update "workspaces" documentation

Update documentation of extension "workspaces".
Move all TSconfig related options here (over from TSconfig reference).
Update rendering configuration (for docs.typo3.org).

Resolves: #76799
Releases: 7.6, master
Change-Id: I1e219edbc7d2c25cfd090ab54e7f0144f03c1608
Reviewed-on: https://review.typo3.org/49326
Reviewed-by: Francois Suter <francois@typo3.org>
Tested-by: Francois Suter <francois@typo3.org>
2 years ago[BUGFIX] backend_layout TCA references invalid field 21/49321/2
Benni Mack [Tue, 2 Aug 2016 13:17:47 +0000 (15:17 +0200)]
[BUGFIX] backend_layout TCA references invalid field

The TCA definition of backend_layout defines "thumbnail=resources"
however the resources field does not exist at all in TYPO3.

The definition should be removed.

Resolves: #77353
Releases: master, 7.6
Change-Id: I76e82becfde1fbefbffc3d3b0d65b05bdc1a52cb
Reviewed-on: https://review.typo3.org/49321
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update fluid image viewhelper documentation 19/49319/2
Henry Singleton [Tue, 2 Aug 2016 01:51:02 +0000 (11:51 +1000)]
[TASK] Update fluid image viewhelper documentation

Adds PDF file example to the fluid "image" viewhelper documentation.
This demonstrates a capability of the image viewhelper that isn't currently
explained in the documentation.

Change-Id: Ice82c005ec66173c19d0f29efe069d23b3f46fdc
Resolves: #77348
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/49319
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Fix auto width in extension icon in EM 15/49315/2
Benni Mack [Tue, 2 Aug 2016 14:24:23 +0000 (16:24 +0200)]
[BUGFIX] Fix auto width in extension icon in EM

If an extension is using a svg icon with no explicit height/width obviously,
then the extension manager shows the icon on the full width of the
table column, making it not only inconsistent but impossible to read the
extension text.

The patch removes the "width: auto" style in CSS.

Resolves: #76381
Releases: master, 7.6
Change-Id: Idb9cfa9bd5720920f67b35d2dada6b21a469a1db
Reviewed-on: https://review.typo3.org/49315
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] EXT:form - Handle values of CHECKBOX and RADIO correctly 90/49290/2
Björn Jacob [Mon, 1 Aug 2016 16:24:47 +0000 (18:24 +0200)]
[BUGFIX] EXT:form - Handle values of CHECKBOX and RADIO correctly

Show values of CHECKBOX and RADIO elements on confirmation page.
Send values in HTML and plain text mails.

Change-Id: I59e6ed255d70902567812a9f7d9c6550c72f5a2d
Resolves: #76866
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/49290
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Fix undefined Tree error in FolderBrowser 12/49312/2
Wouter Wolters [Wed, 27 Jul 2016 09:48:02 +0000 (11:48 +0200)]
[BUGFIX] Fix undefined Tree error in FolderBrowser

Add the missing LegacyTree initialization to FolderBrowser.

Resolves: #76868
Resolves: #72369
Releases: master,7.6
Change-Id: I47494087e46ae63e100e38ff5345b230030c8b7d
Reviewed-on: https://review.typo3.org/49312
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][BUGFIX] Rename configuration for confirmation view 05/49305/4
Ralf Zimmermann [Tue, 2 Aug 2016 12:33:09 +0000 (14:33 +0200)]
[!!!][BUGFIX] Rename configuration for confirmation view

The configuration key for the confirmation layout has been renamed
from confirmation.layout to confirmationView.layout.

Resolves: #77344
Releases: 7.6
Change-Id: I6dad180d58143abd1da4a9930ca36cb0dbfbc9c7
Reviewed-on: https://review.typo3.org/49305
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Markus Hölzle <typo3@markus-hoelzle.de>
Tested-by: Markus Hölzle <typo3@markus-hoelzle.de>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
2 years ago[TASK] Suggest TCA overrides for FSC content elements 59/49259/2
Mathias Brodala [Mon, 25 Jul 2016 09:52:46 +0000 (11:52 +0200)]
[TASK] Suggest TCA overrides for FSC content elements

Resolves: #77236
Releases: master, 7.6
Change-Id: I7806e9626826a06415f9b09de072ace89fb49059
Reviewed-on: https://review.typo3.org/49259
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix condition for USERDEF2 in procesItemState 57/49257/2
Stefan Bürk [Thu, 28 Jul 2016 10:21:27 +0000 (12:21 +0200)]
[BUGFIX] Fix condition for USERDEF2 in procesItemState

Fix a wrong condition in the procesItemState method for MENU handling
for the USERDEF2 itemstate, so it would not be ignored anymore.

Initializing the USERDEF2conf was never done, even if one or more
USERDEF2 item states was found, because the condition was checking
for NULL === TRUE, which will never be TRUE.

Resolves: #77284
Releases: master, 7.6
Change-Id: I16c1d21f03c9aa3565744cae90b7f0cb487ec009
Reviewed-on: https://review.typo3.org/49257
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Suggest "fileinfo" PHP extension 50/49250/2
Mathias Brodala [Tue, 19 Jul 2016 09:08:04 +0000 (11:08 +0200)]
[TASK] Suggest "fileinfo" PHP extension

While not exactly mandatory this extension is essential for a fully
working TYPO3 installation, thus recommend to install it.

Resolves: #77153
Releases: master, 7.6
Change-Id: Ifa88653e36a86771b7549f953a019d2cee0bd367
Reviewed-on: https://review.typo3.org/49250
Reviewed-by: Frederic Gaus <frederic.gaus@flagbit.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix blacklist in DebuggerUtility::var_dump 58/49258/2
Wouter Wolters [Wed, 27 Jul 2016 13:57:50 +0000 (15:57 +0200)]
[BUGFIX] Fix blacklist in DebuggerUtility::var_dump

Wrong usage of strpos leads to not respecting the given blacklist.
Use in_array instead to solve the problem.

Resolves: #72407
Releases: master,7.6
Change-Id: I774bb7c4c9c2bd1c32b2955368b5d9033256100b
Reviewed-on: https://review.typo3.org/49258
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Raise version of ext:compatibility6 in upgrade wizard 53/49253/2
Wouter Wolters [Thu, 28 Jul 2016 14:11:01 +0000 (16:11 +0200)]
[TASK] Raise version of ext:compatibility6 in upgrade wizard

Use 7.6.3 as version instead of the first released version.

Resolves: #77292
Releases: 7.6
Change-Id: I9f00fa4ef5586524ed799bf31ca0f6370e005cc0
Reviewed-on: https://review.typo3.org/49253
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Show DataHandler table in log message 27/49227/2
Benni Mack [Thu, 30 Jun 2016 10:21:53 +0000 (12:21 +0200)]
[BUGFIX] Show DataHandler table in log message

When copying a record without permission, the log message
does not show which table was affected.

The patch adds the information to the log message and also
sets the right log information to the logger.

Resolves: #76885
Releases: master, 7.6
Change-Id: Ieb60bf90ac8062b9eb6e856d3b588e397af4dbfe
Reviewed-on: https://review.typo3.org/49227
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Correct record title escaping 85/49185/3
Nicole Cordes [Sat, 2 Jul 2016 17:26:08 +0000 (19:26 +0200)]
[BUGFIX] Correct record title escaping

This patch removes default record title escaping in resolved DataProvider
data and adds proper escaping where html output is generated.

Resolves: #76399
Resolves: #76668
Resolves: #76900
Releases: master, 7.6
Change-Id: I03cf41c5200e920088116d1a67a2e342e46142d3
Reviewed-on: https://review.typo3.org/49185
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Make base test classes always available 59/49159/3
Helmut Hummel [Wed, 1 Jun 2016 17:03:13 +0000 (19:03 +0200)]
[TASK] Make base test classes always available

To ease the usage of the core with extensions,
we move the base test classes into a different place
to be able to make them available when typo3/cms is pulled in
as dependency, e.g. for testing extensions or in projects.

This is a non breaking change, as the classes will be available
in any case after that.

By doing so, we can nicely cleanup the .gitattributes file

Resolves: #76425
Releases: master, 7.6
Change-Id: I639f08a4e3e5dd73aa47570d326b72c64452acaf
Reviewed-on: https://review.typo3.org/49159
Reviewed-by: Peter Foerger <pfoerger@mac.com>
Tested-by: Peter Foerger <pfoerger@mac.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Timo Hund <timo.hund@yahoo.com>
Tested-by: Timo Hund <timo.hund@yahoo.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Fix link to edit file metadata in full window 25/49225/2
Wouter Wolters [Fri, 24 Jun 2016 09:48:29 +0000 (11:48 +0200)]
[BUGFIX] Fix link to edit file metadata in full window

When opening a window with a file reference in a full window
it is not possible to click the edit metadata button.

Use a normal href to avoid the issue with choosing the correct frame.

Resolves: #76729
Releases: master,7.6
Change-Id: Iaa140f28104782870c50ef0d876e472067a09fed
Reviewed-on: https://review.typo3.org/49225
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] RTE: Correct behavior on empty textfield in Firefox 09/49209/2
Andreas Fernandez [Thu, 21 Jul 2016 12:14:31 +0000 (14:14 +0200)]
[BUGFIX] RTE: Correct behavior on empty textfield in Firefox

With Firefox, the RTE produces several JavaScript errors if the textfield
is empty. The issue is that on Firefox it's tried to access the parent
node of the html tag which is nonsense.

Some regular expressions and an additional 'undefined' check are added
to fix this wrong behavior.

Resolves: #77191
Releases: master, 7.6
Change-Id: I617bdb6415c0468894aee08101c9d26cb790a077
Reviewed-on: https://review.typo3.org/49209
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[BUGFIX] Fix double encoding in VersionModuleController 76/49176/2
Wouter Wolters [Thu, 21 Jul 2016 11:02:40 +0000 (13:02 +0200)]
[BUGFIX] Fix double encoding in VersionModuleController

The function getRecordTitle does htmlspecialchars when
3rd parameter is set to true. Remove the surrounding
htmlspecialchars to prevent double encoding.

Resolves: #77192
Releases: master,7.6
Change-Id: Ic973c127dd6b5134ab74f89df7061144e5d03068
Reviewed-on: https://review.typo3.org/49176
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Do not throw away active session 65/48865/2
Helmut Hummel [Sat, 28 May 2016 21:02:09 +0000 (23:02 +0200)]
[BUGFIX] Do not throw away active session

Previously an active and valid session was dismissed, if login
credentials are sent again.

Now we do not start the user authentication if we have a valid session.

This also fixes weird side effects during backend login, when
it says that token is not valid.

Resolves: #76995
Releases: master, 7.6
Change-Id: Ia070493eb99ff395c67e0ac40e85b5e8fe7debd3
Reviewed-on: https://review.typo3.org/48865
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Respect language in Section menu 73/49173/2
Tim Spiekerkötter [Fri, 22 Jul 2016 09:15:14 +0000 (11:15 +0200)]
[BUGFIX] Respect language in Section menu

Fix a typo inside the query configuration with
causes that there was no languageField key
inside the query configuration. By fixing the typo
the section menu can now render translated records
in the default langauge again.

Resolves: #77210
Releases: master, 7.6
Change-Id: Ibeece79e6aa5e4dbd29b2d613275ac2225d4098f
Reviewed-on: https://review.typo3.org/49173
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Make ViewHelperBaseTestcase always available 60/49160/4
Mark Watney [Thu, 21 Jul 2016 22:50:54 +0000 (00:50 +0200)]
[BUGFIX] Make ViewHelperBaseTestcase always available

This is a follow-up commit to f648cdc.

To ease the usage of the core with extensions, with f648cdc we moved the
base test classes into a different place to be able to make them available
when typo3/cms is pulled in as dependency, e.g. for testing extensions or
in projects.

The current .gitattributes file causes that this class was not available
when typo3/cms is pulled in as dependency, e.g. for testing extensions or
in projects.

This is a non breaking change, as the classes will be available in any
case after that.

Resolves: #77205
Releases: master, 7.6
Change-Id: I6f00ac1cb8c48cf2faea8bae666af691d8a1f7c2
Reviewed-on: https://review.typo3.org/49160
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Return to content element after closing 23/49123/3
K J Kooistra [Wed, 20 Jul 2016 08:39:37 +0000 (10:39 +0200)]
[BUGFIX] Return to content element after closing

When editing a content element in the page module and (saving and)
closing it the view will now jump back to the content element.
This is especially useful for pages with a lot of content.

Resolves: #70074
Releases: master,7.6
Change-Id: Ica27bb561f3b3c19c56b38d211a75e22e018e090
Reviewed-on: https://review.typo3.org/49123
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Allow overriding of image manipulation crop ratios 22/49122/2
Benni Mack [Tue, 19 Jul 2016 20:39:19 +0000 (22:39 +0200)]
[BUGFIX] Allow overriding of image manipulation crop ratios

It is not possible to change or override crop ratios via TSconfig
for sys_file_reference (e.g. for a specific user or page tree branch),
thus making the cropping functionality a pain for bigger sites.

Setting a FormEngine option as expected like
  TCEFORM.sys_file_reference.crop.config.ratios.2\.15 = Widescreen
does now work.

Resolves: #77159
Releases: master, 7.6
Change-Id: I9b1366ed4339150c366fc36a814a251cc407afaa
Reviewed-on: https://review.typo3.org/49122
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Allow deletion of File Recycler in fileadmin 13/49113/2
Steven Cardoso [Tue, 19 Jul 2016 13:31:59 +0000 (15:31 +0200)]
[BUGFIX] Allow deletion of File Recycler in fileadmin

This patch deletes a file recycler instead of trying to move it into
itself by renaming. The patch respects the user settings for recursive
deletion.

Resolves: #77091
Releases: master, 7.6
Change-Id: Iaf045f322c8fac661e1d0fa9bed2ae6e7a6ccc18
Reviewed-on: https://review.typo3.org/49113
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Prepend current path to versionNumberInFilename RewriteRule 11/49111/2
Marco Huber [Thu, 14 Jul 2016 15:39:15 +0000 (17:39 +0200)]
[BUGFIX] Prepend current path to versionNumberInFilename RewriteRule

For Apache 2.2 the current location is needed in the RewriteRule for the
versionNumberInFilename feature.

Resolves: #77098
Releases: master, 7.6, 6.2
Change-Id: I94fea70473d7598a00cfcf8b9ed4f464661c369b
Reviewed-on: https://review.typo3.org/49111
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[FOLLOWUP][BUGFIX] Throw empty table name exception in TCE GroupElement 10/49110/2
Wouter Wolters [Tue, 19 Jul 2016 17:06:19 +0000 (19:06 +0200)]
[FOLLOWUP][BUGFIX] Throw empty table name exception in TCE GroupElement

Fix unit test.

Resolves: #76232
Releases: 7.6
Change-Id: Ic60a3af12ea6144625110033de019c01746b2183
Reviewed-on: https://review.typo3.org/49110
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Throw empty table name exception in TCE GroupElement 91/49091/2
Petra Arentzen [Fri, 1 Jul 2016 09:16:21 +0000 (11:16 +0200)]
[BUGFIX] Throw empty table name exception in TCE GroupElement

Throw an exception if table name is empty after parsing the value
by BackendUtility::splitTable_Uid(). It avoids calling
IconFactory::getIconForRecord() with the invalid parameter $row
and throwing a less specific exception then. Only fields with
TCA Configuration type='group', internal_type='db' and
show_thumbs=TRUE are concerned.

Resolves: #76232
Releases: master, 7.6
Change-Id: I44c52f6ebfdbcfbbd2209890b0458b8126cbeccd
Reviewed-on: https://review.typo3.org/49091
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Set TYPO3 version to 7.6.11-dev 86/49086/2
TYPO3 Release Team [Tue, 19 Jul 2016 10:38:32 +0000 (12:38 +0200)]
[TASK] Set TYPO3 version to 7.6.11-dev

Change-Id: I0a602e621718e77fd13210e3ddb760b07fa2cb43
Reviewed-on: https://review.typo3.org/49086
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[RELEASE] Release of TYPO3 7.6.10 85/49085/2 7.6.10 TYPO3_7-6-10
TYPO3 Release Team [Tue, 19 Jul 2016 10:37:16 +0000 (12:37 +0200)]
[RELEASE] Release of TYPO3 7.6.10

Change-Id: Ia4baefaa69d4c2099369d4543210d156ca4e303e
Reviewed-on: https://review.typo3.org/49085
Reviewed-by: TYPO3 Release Team <typo3cms@typo3.org>
Tested-by: TYPO3 Release Team <typo3cms@typo3.org>
2 years ago[SECURITY] Link fields accept Javascript code when using URI Data Scheme 70/49070/2
Valentin Despa [Tue, 19 Jul 2016 10:16:43 +0000 (12:16 +0200)]
[SECURITY] Link fields accept Javascript code when using URI Data Scheme

JavaScript can be submitted for every link field and will be
rendered in the frontend passed through typolink. To circumvent that,
the URI scheme and prefix "data:" will be disallowed.

Resolves: #76358
Releases: master,7.6,6.2
Security-Commit: 872e3e0dd290c61b3ec43c43531c1b2e60ee6e2d
Security-Bulletins: TYPO3-CORE-SA-2016-014, 015, 016, 017, 018
Change-Id: Ia66178567bf7b64cc70c1c2994f442b13bcd62cd
Reviewed-on: https://review.typo3.org/49070
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] Prevent persistent username in filesystem 69/49069/2
Wouter Wolters [Tue, 19 Jul 2016 10:16:35 +0000 (12:16 +0200)]
[SECURITY] Prevent persistent username in filesystem

The language label for the refresh login popup contains the
username already and is persisted to the filesystem. Use
TYPO3.configuration.username and replace it with JavaScript
instead to prevent the information disclosure.

Resolves: #75933
Releases: master, 7.6, 6.2
Security-Commit: a0f0e8ef937ced52bd6d2ca8a8b00e82e3ba689d
Security-Bulletins: TYPO3-CORE-SA-2016-014, 015, 016, 017, 018
Change-Id: I5e65e746bccbc29ed4fc0355a118c8657648b0f8
Reviewed-on: https://review.typo3.org/49069
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] SQLi in AuthenticationService 68/49068/2
Andreas Fernandez [Tue, 19 Jul 2016 10:16:23 +0000 (12:16 +0200)]
[SECURITY] SQLi in AuthenticationService

The environment variable `HTTP_HOST` is used in SQL statements
but is not properly escaped, leading to an SQL injection
vulnerability.

Resolves: #75740
Releases: 7.6, 6.2
Security-Commit: 137f240450524afedb3f341305c65ab798004e98
Security-Bulletins: TYPO3-CORE-SA-2016-014, 015, 016, 017, 018
Change-Id: I73554a1503a3a408bbbd8ff60b5196a429579b4e
Reviewed-on: https://review.typo3.org/49068
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY][FEATURE] Disable import module for non admin users 67/49067/2
Christian Kuhn [Tue, 19 Jul 2016 10:16:09 +0000 (12:16 +0200)]
[SECURITY][FEATURE] Disable import module for non admin users

To mitigate a potential insecure unserialize issue in the core:
Disable the import module of extension impexp for non admin users
if the module is not explicitely enabled for this user or group.

Introduce userTsConfig option
options.impexp.enableImportForNonAdminUser

Create a hook in page tree context menu to handle the item removal.

The v8 series is not directly affected by the underlying security
issue, but 7.6 and 6.2 are.

Resolves: #73461
Releases: master, 7.6, 6.2
Security-Commit: 294416360b57bddba70ffee67e5cb6c44d471fc8
Security-Bulletins: TYPO3-CORE-SA-2016-014, 015, 016, 017, 018
Change-Id: I62b33dc1de60283467e1276a9c03920887999cc0
Reviewed-on: https://review.typo3.org/49067
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] Prevent XSS in IRRE elements 66/49066/2
Nicole Cordes [Tue, 19 Jul 2016 10:16:00 +0000 (12:16 +0200)]
[SECURITY] Prevent XSS in IRRE elements

This patch changes a JavaScript function to use text() instead of html()
to prevent JavaScript execution.

Resolves: #76922
Releases: master, 7.6, 6.2
Security-Commit: d7a59c7dfeb86948f229b6530bdf283178e9ca06
Security-Bulletins: TYPO3-CORE-SA-2016-014, 015, 016, 017, 018
Change-Id: I6ac713596831ccbb69dc2930357dbdf4603b8baa
Reviewed-on: https://review.typo3.org/49066
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] Escape the link text in EmailViewHelper 65/49065/2
Wouter Wolters [Tue, 19 Jul 2016 10:15:53 +0000 (12:15 +0200)]
[SECURITY] Escape the link text in EmailViewHelper

The content of the email link is not escaped correctly.
This leads to XSS in the EmailViewHelper.

Resolves: #76344
Releases: master,7.6,6.2
Security-Commit: a775018a6bfceae85297460c1134c2ec431edbcf
Security-Bulletins: TYPO3-CORE-SA-2016-014, 015, 016, 017, 018
Change-Id: I7f06b1aefc33fc59fdc9d5cb477c1824acf1e07c
Reviewed-on: https://review.typo3.org/49065
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[SECURITY] Prevent XSS in ContentObjectRenderer 64/49064/2
Benni Mack [Tue, 19 Jul 2016 10:15:47 +0000 (12:15 +0200)]
[SECURITY] Prevent XSS in ContentObjectRenderer

Properly escape various parameters.

Resolves: #31244
Releases: master, 7.6, 6.2
Security-Commit: 582106e4a9a1244c5f8a51ce8e1d2cd7686cbf1e
Security-Bulletins: TYPO3-CORE-SA-2016-014, 015, 016, 017, 018
Change-Id: I90bbe66c5ee61223ddcb92133e28ab1653e276c8
Reviewed-on: https://review.typo3.org/49064
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Use correct paste-into icons in file, list and page module 97/48997/2
Frans Saris [Fri, 8 Jul 2016 07:15:59 +0000 (09:15 +0200)]
[BUGFIX] Use correct paste-into icons in file, list and page module

This patch changes the paste icons from paste-after to paste into in the
docheader and table/column headers of the file, list and page module.

Resolves: #76988
Releases: master, 7.6
Change-Id: I665528976de8ec81db5afd46efc8dbfa1bbd562b
Reviewed-on: https://review.typo3.org/48997
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Fix composer branch alias for 7.6 branch 96/48996/4
Helmut Hummel [Sat, 16 Jul 2016 13:17:09 +0000 (15:17 +0200)]
[TASK] Fix composer branch alias for 7.6 branch

The composer.json file wrongly configures the master branch
to be aliased to 7.x-dev
Fix it by aliasing our TYPO3_7-6 branch to 7.x-dev

Resolves: #77123
Releases: 7.6
Change-Id: I8407ca0583719977b06c8580d4e9c6d5c7199242
Reviewed-on: https://review.typo3.org/48996
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Better preview image quality for youtube videos 72/48972/5
Raphael Graf [Thu, 14 Jul 2016 12:02:51 +0000 (14:02 +0200)]
[TASK] Better preview image quality for youtube videos

Resolves: #77085
Releases: master, 7.6
Change-Id: Id5e5067b226431bff136339d14b9592d2aa3fdf6
Reviewed-on: https://review.typo3.org/48972
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Clean preview of collapsed flexform section 69/48969/2
Jigal van Hemert [Tue, 12 Jul 2016 22:13:26 +0000 (00:13 +0200)]
[BUGFIX] Clean preview of collapsed flexform section

The preview state of a collapsed flexform section is cleaned from
HTML tags and the length of each part is limited.

Resolves: #76616
Releases: master, 7.6
Change-Id: Ie896db0863120b452eff80b607c7bf5c58a8879e
Reviewed-on: https://review.typo3.org/48969
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Remove call to not existing function 00/48900/2
Anja Leichsenring [Mon, 11 Jul 2016 13:57:18 +0000 (15:57 +0200)]
[BUGFIX] Remove call to not existing function

Resolves: #77029
Relates: #70729
Releases: 7.6
Change-Id: I04a63712d271e70957b08b4a2d7348ac384c9ab9
Reviewed-on: https://review.typo3.org/48900
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[BUGFIX] Index all file mounts in FAL indexer scheduler task 87/48887/2
Hannes Bochmann [Mon, 13 Jun 2016 07:58:48 +0000 (09:58 +0200)]
[BUGFIX] Index all file mounts in FAL indexer scheduler task

This patch makes sure all file mounts are indexed instead of only the
first if the CLI user has multiple file mounts.

Resolves: #76441
Releases: master, 7.6, 6.2
Change-Id: I92b1c11c46e6f2a7b5927d2f9013404681e0e8ad
Reviewed-on: https://review.typo3.org/48887
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years ago[TASK] Move CompilableInterface to each condition ViewHelper 25/48725/2
Claus Due [Wed, 29 Jun 2016 15:47:30 +0000 (17:47 +0200)]
[TASK] Move CompilableInterface to each condition ViewHelper

This change moves the CompilableInterface away from the abstract
condition ViewHelper class, over to each of the implementations.
This is done in order to prevent incompatible third party
ViewHelpers from incorrectly evaluating conditions - instead,
such ViewHelpers will now be uncompilable but function correctly.

Any third party ViewHelper can opt-in to being compilable by
implementing the CompilableInterface and ensuring that the
``evaluateCondition`` method is available (and is at least of
``protected`` visibility).

Change-Id: If2dac75debe2ce5872a79d8e54037bb338240f27
Resolves: #73565
Releases: 7.6
Reviewed-on: https://review.typo3.org/48725
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
2 years ago[BUGFIX] Adjust signature of PageTreeView::wrapIcon 84/48884/2
Elmar Hinz [Fri, 20 May 2016 08:59:42 +0000 (10:59 +0200)]
[BUGFIX] Adjust signature of PageTreeView::wrapIcon

Adjust the signature to match the parent class.

Resolves: #76246
Releases: master, 7.6
Change-Id: I5646cbc660be23b5490f3b31708e3c41c1cfa891
Reviewed-on: https://review.typo3.org/48884
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Remove direct usage of mb_ methods in the core 63/48863/2
Georg Ringer [Thu, 7 Jul 2016 17:38:23 +0000 (19:38 +0200)]
[TASK] Remove direct usage of mb_ methods in the core

As mbstring is not a requirement, remove the usage of its
methods in the core.

Resolves: #76990
Releases: master, 7.6
Change-Id: Icdf60ae0c977b66daaa8b64c470bbe83e59955f4
Reviewed-on: https://review.typo3.org/48863
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Enforce processing folder generation 38/48838/2
Nicole Cordes [Fri, 6 May 2016 18:18:22 +0000 (20:18 +0200)]
[BUGFIX] Enforce processing folder generation

If the processing folder of a storage was deleted and the current user
isn't allowed to create new folders, an exception is thrown. This patch
turns off the access check to allow generation of the processing folder.

Resolves: #76067
Releases: master, 7.6
Change-Id: Idd096b44753ab438916d45ff2d6f085118ab2bcf
Reviewed-on: https://review.typo3.org/48838
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years agoRevert "[TASK] Update mso/idna-convert to 1.1.0" 48/48848/3
Morton Jonuschat [Fri, 8 Jul 2016 05:20:49 +0000 (07:20 +0200)]
Revert "[TASK] Update mso/idna-convert to 1.1.0"

This reverts commit 2b4c58865de3ad98f91f77ad17dfb34e485babcd.

mso/idna-convert >= 1.0.0 requires PHP >= 5.6.0. As TYPO3 CMS 7.6
supports PHP 5.5-7.0 we can't use the newer idna-convert versions
and must stay at v0.9.1.

Change-Id: I7e899349220056a18e50de2c4d7d36e62c35155c
Related: #76790
Releases: 7.6
Reviewed-on: https://review.typo3.org/48848
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[TASK] Update mso/idna-convert to 1.1.0 16/48816/2
Wouter Wolters [Fri, 24 Jun 2016 15:01:37 +0000 (17:01 +0200)]
[TASK] Update mso/idna-convert to 1.1.0

Resolves: #76790
Releases: master,7.6
Change-Id: Ib477526a6e5df8275b4fff55a3742811fc20237e
Reviewed-on: https://review.typo3.org/48816
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
2 years ago[BUGFIX] Unsupported declare 'strict_types' 44/48844/2
Christian Kuhn [Thu, 7 Jul 2016 13:28:43 +0000 (15:28 +0200)]
[BUGFIX] Unsupported declare 'strict_types'

CMS 7.6 supports PHP 5.5 and 5.6 - a declare (strict_types = 1);
slipped in with a master backport - remove it.

Change-Id: I36381cc0c5b65dfa9d712420ddb5bf32b4b92db5
Resolves: #76984
Related: #76147
Releases: 7.6
Reviewed-on: https://review.typo3.org/48844
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] PHP 7.1 unit tests 43/48843/2
Christian Kuhn [Thu, 7 Jul 2016 11:20:20 +0000 (13:20 +0200)]
[BUGFIX] PHP 7.1 unit tests

Fix a couple of unit tests that fail with PHP 7.1:

* The phpunit mock builder seems to have minor issues mocking
mysqli correctly. This leads so slightly different method
signatures and PHP 7.1 is a bit more picky about those details.
Switching to prophecy on affected tests solves the issue.

* $tsfe->config is initialized as string, calling
$tsfe->config['foo']['bar'] = 'baz'; raises an error
"Error: Cannot use assign-op operators with string offsets".
Cleaning the assignment solves the issue.

Change-Id: I81f3a75e5b682064c6a43f989f0cf862e2d1bc6e
Resolves: #76980
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48843
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Replace ###CURRENT_PID### with value from DB within FlexForms 30/48830/2
Steffen Müller [Thu, 30 Jun 2016 11:05:36 +0000 (13:05 +0200)]
[BUGFIX] Replace ###CURRENT_PID### with value from DB within FlexForms

Replace ###CURRENT_PID### in FlexForm context with values from
database. Within FlexForm context these values need to be
retrieved from the key flexParentDatabaseRow.

Resolves: #76888
Releases: master, 7.6
Change-Id: I5fd3cb0a18e41ae0d15cbb44556d05d88506a093
Reviewed-on: https://review.typo3.org/48830
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Reset SYS/exceptionalErrors in live preset 24/48824/2
Benni Mack [Wed, 6 Jul 2016 12:56:27 +0000 (14:56 +0200)]
[BUGFIX] Reset SYS/exceptionalErrors in live preset

Resolves: #76901
Releases: master, 7.6, 6.2
Change-Id: I50167e4d64ef9cda8d39e9f2e03fc08e3de646b1
Reviewed-on: https://review.typo3.org/48824
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
2 years ago[BUGFIX] Define 0 as a valid page id in Ext.ux.state.TreePanel 20/48820/2
Andreas Fernandez [Sat, 2 Jul 2016 10:35:03 +0000 (12:35 +0200)]
[BUGFIX] Define 0 as a valid page id in Ext.ux.state.TreePanel

According to the ExtJS TreePanel, -1 and 0 are invalid page ids. However,
having bookmarks linking to pid=0 causes problems, as 0 is detected as
invalid and the user gets redirected to the first available node.

This patch defines 0 as a valid page id.

Resolves: #76480
Releases: master, 7.6
Change-Id: Idbe6590d910078a971046e47f0d436af183d68ce
Reviewed-on: https://review.typo3.org/48820
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Prevent click event on IRRE localize/synchronize 14/48814/2
Benni Mack [Tue, 5 Jul 2016 12:16:45 +0000 (14:16 +0200)]
[BUGFIX] Prevent click event on IRRE localize/synchronize

When clicking on localize all/synchronize inside a long
Form Engine element with IRRE elements, the page jumps to top
since the anchor is executed instead of returning false.

Resolves: #76941
Releases: master, 7.6
Change-Id: I350964e4bbd9447af54933c0859ef92e6898652c
Reviewed-on: https://review.typo3.org/48814
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Adodb: PHP 7.1 compatibility 12/48812/2
Christian Kuhn [Tue, 5 Jul 2016 19:26:55 +0000 (21:26 +0200)]
[BUGFIX] Adodb: PHP 7.1 compatibility

unset($this) throws a fatal if linting with PHP 7.1.
According to php.net/unset the construct isn't allowed since
PHP 5. Now the linter stumbles upon that, too.
Solution is to drop these calls, the according files and
classes from adodb are not used by our dbal integration anyway.
A pull request to upstream is pending for this, too, but we
never know when it will be merged. Should be safe to do that
locally in our adapted version.

Change-Id: Ieeffee67c82dc9c7c9fef519ffea59685e48b37b
Resolves: #76947
Releases: master, 7.6
Reviewed-on: https://review.typo3.org/48812
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Prevent double escaping in quickedit menu 09/48809/2
Benni Mack [Tue, 5 Jul 2016 16:14:51 +0000 (18:14 +0200)]
[BUGFIX] Prevent double escaping in quickedit menu

As the menu is generated in fluid templates, the item labels are already
escaped there. There is no need to escaping titles in build time.

Resolves: #76481
Releases: master, 7.6
Change-Id: I91c2e5aae12b2d91d6c8a4eefba26b630261395f
Reviewed-on: https://review.typo3.org/48809
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>