Packages/TYPO3.CMS.git
4 months ago[TASK] Add return type declaration to FileDumpController::dumpAction 74/58574/2
Benjamin Franzke [Wed, 3 Oct 2018 20:42:28 +0000 (22:42 +0200)]
[TASK] Add return type declaration to FileDumpController::dumpAction

For historical reasons FileDumpController::dumpAction was allowed to
return null. It didn't specify a nullable return type declaration because
it was not yed decided whether v9 will require php 7.2 or not.
With https://review.typo3.org/55585 FileDumpController was adapted to
return a PSR-7 Response but missed to update the function signature.
The nullable annotation is therefore removed now and the explicit
return type declaration is added.

Change-Id: I10e2cc60ab8e1f023c1beb6cf467bee1800971c8
Releases: master
Resolves: #86564
Reviewed-on: https://review.typo3.org/58574
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Set COMPOSER_ROOT_VERSION=9.5.0 in bamboo 69/58569/2
Christian Kuhn [Wed, 3 Oct 2018 14:50:33 +0000 (16:50 +0200)]
[TASK] Set COMPOSER_ROOT_VERSION=9.5.0 in bamboo

Resolves: #86559
Releases: master
Change-Id: Ic691f77adaa521f1b5d3d7457fa9cfb81ef47663
Reviewed-on: https://review.typo3.org/58569
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[TASK] Update typo3/class-alias-loader from 1.0.0 to 1.0.1 66/58566/2
Christian Kuhn [Wed, 3 Oct 2018 13:11:15 +0000 (15:11 +0200)]
[TASK] Update typo3/class-alias-loader from 1.0.0 to 1.0.1

Tiny patch level release with cosmetical fixes.

composer update typo3/class-alias-loader

Resolves: #86555
Releases: master, 8.7, 7.6
Change-Id: Ib949e1aa961ea9aede1eeaebd5da9995a2a65bc0
Reviewed-on: https://review.typo3.org/58566
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[BUGFIX] Use chr(10) instead of LF in functional test data provider 63/58563/2
Christian Kuhn [Wed, 3 Oct 2018 10:04:18 +0000 (12:04 +0200)]
[BUGFIX] Use chr(10) instead of LF in functional test data provider

The functional test splitter script does not define LF and various
other constants, but loads test data providers to find out how
many tests they produce. Those data provider should not use LF,
the splitter throws PHP warnings otherwise.

Resolves: #86552
Releases: master
Change-Id: I89c0748ce595f1f7caee2934f4431b103f60471b
Reviewed-on: https://review.typo3.org/58563
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[BUGFIX] Adjust conditions for Symfony Expressions in RST-files 57/58557/4
Stefan Neufeind [Tue, 2 Oct 2018 08:35:50 +0000 (10:35 +0200)]
[BUGFIX] Adjust conditions for Symfony Expressions in RST-files

Since the original introduction of some new features the syntax used
for the expression was adjusted globally in TYPO3, leading to
examples no longer up-to-date in the documentation shipped as RSTs.

Resolves: #86541
Releases: master
Change-Id: I3c8b78fe05263a6cca5afa52d61f5ea5afe940a4
Reviewed-on: https://review.typo3.org/58557
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Update installation acceptance tests 59/58559/6
Mathias Brodala [Tue, 2 Oct 2018 13:28:18 +0000 (15:28 +0200)]
[BUGFIX] Update installation acceptance tests

The introduction package was revamped which brought us some text
changes, thus update the installation acceptance tests accordingly.

To mitigate an issue with certain databases causing a wrong casing of
column names, the DefaultTcaSchema now always quotes all column names
with backticks.

Resolves: #86544
Releases: master
Change-Id: Ic91368817bb775379302e904496c35537aaaa13c
Reviewed-on: https://review.typo3.org/58559
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Set TYPO3 version to 9.5.1-dev 56/58556/2
Oliver Hader [Tue, 2 Oct 2018 08:11:35 +0000 (10:11 +0200)]
[TASK] Set TYPO3 version to 9.5.1-dev

Change-Id: If916407e7a7d9d54777ecee641bee5a604885ce2
Reviewed-on: https://review.typo3.org/58556
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[RELEASE] Release of TYPO3 9.5.0 55/58555/2 v9.5.0
Oliver Hader [Tue, 2 Oct 2018 08:10:15 +0000 (10:10 +0200)]
[RELEASE] Release of TYPO3 9.5.0

Change-Id: Ibacf4ce5d6c2a2e3f7aafb2c17536ab89dff1c15
Reviewed-on: https://review.typo3.org/58555
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Ensure that requirements in RouteEnhancers are optional 54/58554/2
Benni Mack [Tue, 2 Oct 2018 07:39:29 +0000 (09:39 +0200)]
[BUGFIX] Ensure that requirements in RouteEnhancers are optional

Resolves: #86539
Releases: master
Change-Id: Ia0a53b713382ae5cbbc9f5b57c82a532ba8f601b
Reviewed-on: https://review.typo3.org/58554
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Streamline PageTypeDecorator handling 53/58553/2
Oliver Hader [Tue, 2 Oct 2018 06:47:36 +0000 (08:47 +0200)]
[BUGFIX] Streamline PageTypeDecorator handling

* uses '&type=xyz' argument value of query in case no PageType decorator
  has been configured or if no value could be resolved (not defined in
  'map' nor as 'default' value)
* allows using 'default' value without having it defined in 'map' (values
  always should be explicit, however this is a fallback handling)

Resolves: #86538
Releases: master
Change-Id: I32ddbaebba916f875f6cd76609fce6b4172eee4d
Reviewed-on: https://review.typo3.org/58553
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
4 months ago[BUGFIX] Do not append slashes on slug importer 52/58552/3
Benni Mack [Tue, 2 Oct 2018 06:17:55 +0000 (08:17 +0200)]
[BUGFIX] Do not append slashes on slug importer

When importing from page_path of RealURL,
a slash is appended for all imported URLs,
however TYPO3 Core does not add slashes at the
end for new pages - which leads to a bad UX, having
mixed values.

However, with route enhancers, it is possible to add slashes
to the very end of a link, so it's useful to NOT have them
anymore inside the database.

Resolves: #86536
Releases: master
Change-Id: I50e941ec97a70654d9974757a6191b416aa40c29
Reviewed-on: https://review.typo3.org/58552
Reviewed-by: Kevin Appelt <kevin.appelt@icloud.com>
Reviewed-by: Willi Wehmeier <wwwehmeier@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Improve changelog docs 51/58551/2
Daniel Siepmann [Tue, 2 Oct 2018 06:07:28 +0000 (08:07 +0200)]
[TASK] Improve changelog docs

* Fix wrong indentation level in example.
* Adjust sorting of paragraphs for explanation to match order of
  configuration options in example above.
* Keep example consistent. Remove single quotes around two keys in a
  single line, not used in other lines.
* Add syntax highlighting to SiteConfiguration syntax for environment
  variables.

Releases: master
Resolves: #86365, #86409
Change-Id: Ic7923bf7a3215f86637d3a8e20776f74666daf3f
Reviewed-on: https://review.typo3.org/58551
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[BUGFIX] Ensure LoadTcaService loads ext_tables.php 50/58550/2
Benni Mack [Tue, 2 Oct 2018 06:12:39 +0000 (08:12 +0200)]
[BUGFIX] Ensure LoadTcaService loads ext_tables.php

During deprecation of TYPO3_LOADED_EXT,
ext_tables.php is not loaded in "Check TCA in ext_tables.php"
anymore.

The fix loads the file correctly.

Resolves: #86534
Releases: master
Change-Id: If4ab1183704862bed7e2c6f657f8d80d9338d9f4
Reviewed-on: https://review.typo3.org/58550
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 months ago[BUGFIX] Reduce amount of false positives of extension scanner 49/58549/5
Georg Ringer [Mon, 1 Oct 2018 22:18:57 +0000 (00:18 +0200)]
[BUGFIX] Reduce amount of false positives of extension scanner

Reduce amount of false positives introduced with #86366 as methods
like 'getTitle()' are used too often.

Resolves: #86533
Releases: master
Change-Id: I97e7406cb5f134042fabf96ea3435c5c2f7ad665
Reviewed-on: https://review.typo3.org/58549
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 months ago[BUGFIX] Do not expand pseudo element `:after` to 100% in modals 47/58547/2
Andreas Fernandez [Mon, 1 Oct 2018 21:18:32 +0000 (23:18 +0200)]
[BUGFIX] Do not expand pseudo element `:after` to 100% in modals

This patch removes the unnecessary `width: 100%` definition. This fixes
the glitch in the image cropper.

Resolves: #86530
Related: #86445
Releases: master
Change-Id: Iaaf6e7f2f69bc526e245ec4b79ece00977c5c5d6
Reviewed-on: https://review.typo3.org/58547
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Move documentation files into 9.5 folder - part 2 45/58545/3
Anja [Mon, 1 Oct 2018 19:50:09 +0000 (21:50 +0200)]
[TASK] Move documentation files into 9.5 folder - part 2

Change-Id: Ic2ad05680c072f901c200b05810be958204825db
Releases: master
Resolves: #86434
Reviewed-on: https://review.typo3.org/58545
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[BUGFIX] Fix decrementing of AJAX requests in extension scanner 39/58539/5
Andreas Fernandez [Mon, 1 Oct 2018 17:55:00 +0000 (19:55 +0200)]
[BUGFIX] Fix decrementing of AJAX requests in extension scanner

The queueing of AJAX requests in the extension scanner has some flaws
which causes the scanner to refuse another scan request.

The counter of pending requests is now always decremented, not only if
the amount of requests equals the threshold. Also, it's now checked if
there is any item in the request queue before shifting.

Instead of overriding the `success` and `error` callback, only `complete`
is now overridden, as this callback is executed on any return state.

To make the queueing part better maintainable and reusable, the code has
been moved into a separate module.

Resolves: #86523
Related: #86436
Releases: master
Change-Id: Ifa26ad7ce3bd81497c43b8606b902d467bdd1dda
Reviewed-on: https://review.typo3.org/58539
Reviewed-by: Richard Haeser <richard@maxserv.com>
Tested-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 months ago[BUGFIX] XmlSitemapRenderer should use TSFE->type for page-type 40/58540/2
Stefan Neufeind [Mon, 1 Oct 2018 19:19:36 +0000 (21:19 +0200)]
[BUGFIX] XmlSitemapRenderer should use TSFE->type for page-type

When the new PageTypeEnhancer resolved type from a URL it is
not part of getQueryParams() but needs to be fetched from TSFE.

Resolves: #86527
Releases: master
Change-Id: I5041b042f1246f2ecc8adc8fa6cba123abfccf5b
Reviewed-on: https://review.typo3.org/58540
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Update INSTALL.md and README.md 88/58388/10
Josef Glatz [Tue, 25 Sep 2018 11:55:17 +0000 (13:55 +0200)]
[TASK] Update INSTALL.md and README.md

The main goal of this patch is to update the neglected
INSTALL.md and README.md to represent the current
state of the requirements and to improve the overall
content of the two "entry" documentation files.

The install.md has been massively shortened and links to
the official guides were added to finally be able to have
one source of truth.

Resolves: #86487
Releases: master
Change-Id: Id61abf86a4113d25c940c63f1423fa341aa7e702
Reviewed-on: https://review.typo3.org/58388
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[BUGFIX] Fix EXT:core/bin/typo3 entry point in composer-mode 31/58531/7
Benjamin Franzke [Mon, 1 Oct 2018 11:49:03 +0000 (13:49 +0200)]
[BUGFIX] Fix EXT:core/bin/typo3 entry point in composer-mode

typo3/sysext/core/bin/typo3 does not work in composer mode
currently. Composer-based installations need to use the binary from
the composer "bin-dir", which is fine from a composer-usage point
of view – but hard for documentation.
Additionally the path to "typo3/sysext/core/bin/typo3" is hardcoded
in some places (e.g. scheduler).
We now make sure this binary works in composer mode as well,
using the same entry point strategy as for "typo3/index.php"
and "typo3/install.php".

Change-Id: I400ccd3a2bba4496c5d4ec9482e624cf8270a462
Releases: master
Resolves: #86513
Reviewed-on: https://review.typo3.org/58531
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[BUGFIX] Ensure most site related exceptions are handled 37/58537/6
Markus Klein [Mon, 1 Oct 2018 16:47:53 +0000 (18:47 +0200)]
[BUGFIX] Ensure most site related exceptions are handled

Make sure that in most places any site related exception is handled
in a graceful way to avoid negative UX.

Resolves: #86522
Releases: master
Change-Id: I3b0d7f9ce63351f8dd7bb6b4988704fc8a3d0a9f
Reviewed-on: https://review.typo3.org/58537
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Richard Haeser <richard@maxserv.com>
Reviewed-by: Jurian Janssen <jurian.janssen@gmail.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Tested-by: Richard Haeser <richard@maxserv.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Resolve slashed values in PageTypeDecorator correctly 12/58512/15
Oliver Hader [Sun, 30 Sep 2018 22:52:13 +0000 (00:52 +0200)]
[BUGFIX] Resolve slashed values in PageTypeDecorator correctly

* slashed values are not resolved correctly concerning their
  dynamic '/' prefix in route paths
* adjusting route path and parameters might cause side effects
  when dealing with multiple decorating enhancers
* test cases for resolving and generating URIs using new
  PageTypeDecorator enhancer are added

Resolves: #86506
Releases: master
Change-Id: I3757933c47ea0f06d88bb27a635c2077e8f673b1
Reviewed-on: https://review.typo3.org/58512
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[BUGFIX] Make redirect sources with Query matchable 22/58522/6
Daniel Goerz [Mon, 1 Oct 2018 11:26:33 +0000 (13:26 +0200)]
[BUGFIX] Make redirect sources with Query matchable

Resolves: #86503
Releases: master
Change-Id: Iaf924b9f851bd25cb2d16ab5e5656703603a669b
Reviewed-on: https://review.typo3.org/58522
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Streamline phpdoc annotations in EXT:extbase 35/58535/2
Benni Mack [Mon, 1 Oct 2018 16:03:21 +0000 (18:03 +0200)]
[TASK] Streamline phpdoc annotations in EXT:extbase

EXT:extbase uses @api and @internal phpDoc annotations. Going with a cleaner
approach with marking code as just @internal, and everything not annotated
as @internal is public, is the way to go, also the way PSR-5 is heading.

For EXT:extbase: Every PHP class that had nothing marked, is now @internal,
everything that was @api is now implicitly part of TYPO3 Core API.

On top, all license headers and @license annotations have been streamlined.

This means:
- TYPO3 Core's PHP classes area all public API by default
   unless marked as @internal or an extension class
- @api is not allowed anymore and will be restricted in
   the future from adding.
- @internal should be used for everything that should
   not be explicitly exposed as public API in the future.
- Everything under Tests/ is not part of TYPO3's Public API

Resolves: #86521
Releases: master
Change-Id: I83c5a27d9af001929142d2620600668ad0a84c92
Reviewed-on: https://review.typo3.org/58535
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] Ensure Uri->getQuery() always returns a string 34/58534/2
Daniel Goerz [Mon, 1 Oct 2018 14:47:47 +0000 (16:47 +0200)]
[BUGFIX] Ensure Uri->getQuery() always returns a string

As stated in the Interface:
If no query string is present, this method MUST return an empty string.

Resolves: #86520
Releases: master, 8.7
Change-Id: I9869af08c84262443e503c34a2c608fbc5ba4bc2
Reviewed-on: https://review.typo3.org/58534
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[BUGFIX] Add user authentication to activate extension command 36/58536/2
Susanne Moog [Mon, 1 Oct 2018 16:24:39 +0000 (18:24 +0200)]
[BUGFIX] Add user authentication to activate extension command

As extensions might contain data to import the activate extension
command needs to initialize the user authentication so the data
handler may import data.

The backend user authentication initialization has been added to
the activate extension command.

Resolves: #86161
Releases: master
Change-Id: Id25c45bdfc8ac1cb930c9ed6adb49c39c17d7952
Reviewed-on: https://review.typo3.org/58536
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Mark various parts with phpdoc internal - part 4 32/58532/2
Benni Mack [Mon, 1 Oct 2018 14:07:10 +0000 (16:07 +0200)]
[TASK] Mark various parts with phpdoc internal - part 4

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:core
- EXT:extensionmanager
- EXT:install

All @api annotations have been removed.

Resolves: #86517
Releases: master
Change-Id: I7869d8e3b6e8a4365529cc7c98b99cde7ca1495f
Reviewed-on: https://review.typo3.org/58532
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[TASK] Send uid of sys_redirect in Response Header 23/58523/6
Daniel Goerz [Mon, 1 Oct 2018 11:28:22 +0000 (13:28 +0200)]
[TASK] Send uid of sys_redirect in Response Header

Resolves: #86504
Releases: master
Change-Id: I115d1fcce00142b5e0eb34dbb840c785cf1b59f4
Reviewed-on: https://review.typo3.org/58523
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Mark various parts with phpdoc internal - part 3 30/58530/2
Benni Mack [Mon, 1 Oct 2018 12:55:55 +0000 (14:55 +0200)]
[TASK] Mark various parts with phpdoc internal - part 3

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:indexed_search
- EXT:info
- EXT:linkvalidator
- EXT:lowlevel
- EXT:opendocs
- EXT:recordlist
- EXT:recycler
- EXT:redirects
- EXT:reports
- EXT:scheduler

All @api annotations have been removed.

Resolves: #86511
Releases: master
Change-Id: I80de460142266305c1af3ad437f939b7e4448676
Reviewed-on: https://review.typo3.org/58530
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Streamline phpdoc annotations in EXT:fluid 25/58525/3
Benni Mack [Mon, 1 Oct 2018 11:59:15 +0000 (13:59 +0200)]
[TASK] Streamline phpdoc annotations in EXT:fluid

EXT:fluid uses @api and @internal phpDoc annotations. Going with a cleaner
approach with marking code as just @internal, and everything not annotated
as @internal is public, is the way to go, also the way PSR-5 is heading.

For EXT:fluid: Every PHP class that had nothing marked, is now @internal,
everything that was @api is now implicitly part of TYPO3 Core API.

Other areas will follow so the API for TYPO3 v9 LTS is clearer than ever.

Resolves: #86507
Releases: master
Change-Id: I5deba0ba2b868743e7eda8f0e32cda40ef008046
Reviewed-on: https://review.typo3.org/58525
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Fix log module bootstrap 16/58516/5
Susanne Moog [Mon, 1 Oct 2018 09:31:34 +0000 (11:31 +0200)]
[BUGFIX] Fix log module bootstrap

Resolves: #86498
Releases: master
Change-Id: I8605215706406a0a7826a1fe401ccd11d46ead73
Reviewed-on: https://review.typo3.org/58516
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Mark various parts with phpdoc internal - part 2 29/58529/2
Benni Mack [Mon, 1 Oct 2018 12:36:07 +0000 (14:36 +0200)]
[TASK] Mark various parts with phpdoc internal - part 2

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:seo
- EXT:setup
- EXT:rte_ckeditor
- EXT:workspaces
- EXT:viewpage
- EXT:tstemplate
- EXT:taskcenter
- EXT:t3editor
- EXT:sys_action
- EXT:sys_note

All leftover @api methods have been removed.

Resolves: #86509
Releases: master
Change-Id: I6e5ee2302055de9ea4c124ca913e4677d62721fe
Reviewed-on: https://review.typo3.org/58529
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[TASK] Add proper exception handling to RouterInterface logic 19/58519/3
Benni Mack [Mon, 1 Oct 2018 10:42:06 +0000 (12:42 +0200)]
[TASK] Add proper exception handling to RouterInterface logic

Two new Exceptions are now thrown when routing does not
work, one being thrown when a URL is generated but could
not be generated, and one when a URL could not be resolved.

This is much cleaner than the distinction of a nullable return type,
so the new interface is adapted as well.

As a drive-by fix, the Backend routing exception now inherits from
this new exception.

Resolves: #86500
Releases: master
Change-Id: Ifaf7b61422dfd49df18399c3bcbdf735bc522cba
Reviewed-on: https://review.typo3.org/58519
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[TASK] Improve code to avoid Scrutinizer warnings 05/58505/5
Markus Klein [Sun, 30 Sep 2018 16:23:40 +0000 (18:23 +0200)]
[TASK] Improve code to avoid Scrutinizer warnings

Releases: master
Resolves: #86481
Change-Id: I87b9a07b6cc10c4379a6bf3e1c0e1695354b574a
Reviewed-on: https://review.typo3.org/58505
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months agoRevert "[FEATURE] Add stdWrap to config.additionalHeaders" 17/58517/11
Markus Klein [Mon, 1 Oct 2018 09:37:52 +0000 (11:37 +0200)]
Revert "[FEATURE] Add stdWrap to config.additionalHeaders"

This reverts commit 2124bba49f68f5c35705c5c499abe6a0ee95a6cf.

The feature is reverted as the functionality can't be provided
in a fully working manner to work in all possible cases the FE
may be called.

Change-Id: Ia7caf3770b12737fd195da9d9f66bdc179981de8
Resolves: #86492
Reverts: #23494
Releases: master
Reviewed-on: https://review.typo3.org/58517
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
4 months ago[TASK] Add icons for install tool modules 28/58528/3
Benjamin Kott [Mon, 1 Oct 2018 12:35:28 +0000 (14:35 +0200)]
[TASK] Add icons for install tool modules

Resolves: #86510
Releases: master
Change-Id: I80692b806c3a7b51de3fad4947102e34956114a2
Reviewed-on: https://review.typo3.org/58528
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
4 months ago[TASK] Mark various parts with phpdoc internal 27/58527/2
Benni Mack [Mon, 1 Oct 2018 12:13:51 +0000 (14:13 +0200)]
[TASK] Mark various parts with phpdoc internal

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:felogin
- EXT:feedit
- EXT:filelist
- EXT:frontend
- EXT:fluid_styled_content
- EXT:impexp

All leftover @api methods have been removed.

Resolves: #86508
Releases: master
Change-Id: I97a6964a5f77dc9ee3d90365e9fda3d7d7be6266
Reviewed-on: https://review.typo3.org/58527
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[TASK] Mark various obvious code as @internal 24/58524/2
Benni Mack [Mon, 1 Oct 2018 11:41:20 +0000 (13:41 +0200)]
[TASK] Mark various obvious code as @internal

All specific controllers for specific Backend actions, Backend-module related modules,
all hook implementations (where the core uses hooks by itself), and module-specific
ViewHelpers are now marked as @internal to ensure developers what is
part of the public TYPO3 Core API.

within
- EXT:backend (except ViewHelpers)
- EXT:beuser
- EXT:about
- EXT:belog

All @api methods have been removed.

Resolves: #86505
Releases: master
Change-Id: I1fd1e16f7885e81fb994999e5873a1a3a1aa6c3b
Reviewed-on: https://review.typo3.org/58524
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Update CKEditor icon to meet the new CKEditor CD 20/58520/2
Josef Glatz [Mon, 1 Oct 2018 11:15:45 +0000 (13:15 +0200)]
[TASK] Update CKEditor icon to meet the new CKEditor CD

This patch adds the newly added CKEditor v4 icon (via #86499)
to ext:rte_ckeditor as new extension icon.

`yarn && yarn build` was used to copy the file to the final location.

Releases: master
Resolves: #86501
Change-Id: I5225805f195eb2efe29a5deac6bb5426c313b604
Reviewed-on: https://review.typo3.org/58520
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Tested-by: Jan Stockfisch <typo3@jan-stockfisch.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
4 months ago[TASK] Streamline phpdoc annotations in EXT:form 21/58521/2
Benni Mack [Mon, 1 Oct 2018 11:22:15 +0000 (13:22 +0200)]
[TASK] Streamline phpdoc annotations in EXT:form

EXT:form uses @api and @internal phpDoc annotations. Going with a cleaner
approach with marking code as just @internal, and everything not annotated
as @internal is public, is the way to go, also the way PSR-5 is heading.

For EXT:form: Every PHP class that had nothing marked, is now @internal,
everything that was @api is now implicitly part of TYPO3 Core API.

Other areas will follow so the API for TYPO3 v9 LTS is clearer than ever.

Resolves: #86502
Releases: master
Change-Id: I2c1efdd11f0fbaa992315a90049eb109e2620c76
Reviewed-on: https://review.typo3.org/58521
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
4 months ago[TASK] Update typo3/icons from 1.7.0 to 1.8.0 18/58518/2
Benjamin Kott [Mon, 1 Oct 2018 10:21:29 +0000 (12:21 +0200)]
[TASK] Update typo3/icons from 1.7.0 to 1.8.0

Following commands were used to update the external package
and copy the files/folders to the final location:
`yarn upgrade @typo3/icons@1.8.0 && yarn build`

Resolves: #86499
Releases: master
Change-Id: I87b571234257d82b1f2f09f523817c2eea2b26d2
Reviewed-on: https://review.typo3.org/58518
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
4 months ago[TASK] Adjust rst syntax for proper yaml and ts highlighting 15/58515/2
Daniel Siepmann [Mon, 1 Oct 2018 09:10:12 +0000 (11:10 +0200)]
[TASK] Adjust rst syntax for proper yaml and ts highlighting

Use proper code highlighting syntax for yaml and typoscript within 86160
changelog entry.

Resolves: #86160
Releases: master
Change-Id: I791956413885cabdfdf5693e9d0ad6c4be41a29d
Reviewed-on: https://review.typo3.org/58515
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[TASK] Adjust rst syntax for proper yaml highlighting 14/58514/2
Daniel Siepmann [Mon, 1 Oct 2018 07:55:18 +0000 (09:55 +0200)]
[TASK] Adjust rst syntax for proper yaml highlighting

Define default highlighting for 86365 changelog entry to be yaml. Adjust
all yaml occurrences within this entry to use default highlighting.

Releases: master
Resolves: #86365
Change-Id: I9063311830330d55ae051c8a0d38da78a2a91831
Reviewed-on: https://review.typo3.org/58514
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[BUGFIX] Improve performance of extension scanner 10/58510/3
Frank Naegler [Sun, 30 Sep 2018 21:45:56 +0000 (23:45 +0200)]
[BUGFIX] Improve performance of extension scanner

This patch adds a request queue for the massive amount of AJAX calls
in the extension scanner. This patch mitigates the problem of massive
server load in case the amount of files to be scanned is very high.

This patch mitigates the problem by allowing a maximum of 10 concurrent
requests. After the release of TYPO3 v9 LTS, this scanner module should
be refactored further.

Resolves: #86436
Releases: master
Change-Id: I824dfb74aae46d6b00690e7ca6553305c4221f0f
Reviewed-on: https://review.typo3.org/58510
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 months ago[FEATURE] Introduce PageTypeEnhancer 78/58478/14
Benni Mack [Sat, 29 Sep 2018 22:27:04 +0000 (00:27 +0200)]
[FEATURE] Introduce PageTypeEnhancer

A new PageTypeEnhancer is added to map the internal TYPO3
GET parameter `type` to a speaking URL suffix.

The PageTypeEnhancer only does suffixes, if other

You can configure it like this:

routeEnhancers:
  PageType:
    type: PageType
    default: ''
    map:
      '.html': 1
      'menu.json': 13

Resolves: #86160
Releases: master
Change-Id: Ie4b387963012946272568a69c9581e8d345dbe4c
Reviewed-on: https://review.typo3.org/58478
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[TASK] Rename RouteResult to SiteRouteResult 11/58511/2
Benni Mack [Sun, 30 Sep 2018 21:57:42 +0000 (23:57 +0200)]
[TASK] Rename RouteResult to SiteRouteResult

Resolves: #86489
Releases: master
Change-Id: I721c89b8afdc248b040a5e82cfd8c209dc84dbab
Reviewed-on: https://review.typo3.org/58511
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[BUGFIX] Streamline trigger_error messages 94/58494/4
Benni Mack [Sun, 30 Sep 2018 12:03:15 +0000 (14:03 +0200)]
[BUGFIX] Streamline trigger_error messages

This patch streamlines all deprecation messages and follow the
following rules.

1. All @deprecated should contain
@deprecated since TYPO3 xx, will be removed in TYPO3 v10.0 (not "core v10" or just "v10"

2. trigger_error()
- All trigger_error() messages MUST end with a "." (dot).
- Never use "This method" but the method name (enjoy the logs otherwise)
- "has been deprecated" can be spared - we KNOW it's deprecated once its in the deprecation log. Instead "Will be removed in TYPO3 v10.0" SHOULD be in the log file.
- Do not use "__METHOD__" or some other "magic".

Resolves: #86488
Releases: master
Change-Id: I6a34593ff89ecafe649366d60d725daa3aa6676c
Reviewed-on: https://review.typo3.org/58494
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
4 months ago[TASK] Add HTTP headers to Frontend Response object 99/58499/10
Benni Mack [Sun, 30 Sep 2018 13:23:28 +0000 (15:23 +0200)]
[TASK] Add HTTP headers to Frontend Response object

HTTP Headers are added to the PSR-7 response object now
within TSFE.

They are then sent at the very end of the request process.

A bw compat layer is added as well.

Resolves: #86486
Releases: master
Change-Id: Ifdeaab26868d0cf60dd87d52046a2565c4971488
Reviewed-on: https://review.typo3.org/58499
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Remove hardcoded index.php indexed search links 87/58387/3
Frank Naegler [Tue, 25 Sep 2018 10:53:18 +0000 (12:53 +0200)]
[BUGFIX] Remove hardcoded index.php indexed search links

Resolves: #86326
Releases: master
Change-Id: Ifbe8c5067c5a7e47188ea89f4e6df3db9192ac61
Reviewed-on: https://review.typo3.org/58387
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[TASK] Reintroduce tooltips for new SVG Pagetree 81/58481/6
Nikita Hovratov [Sun, 30 Sep 2018 00:06:06 +0000 (02:06 +0200)]
[TASK] Reintroduce tooltips for new SVG Pagetree

When hovering over a page-icon in the pagetree, a tooltip with the
id and status is now shown instead of a browser default title tooltip.

Resolves: #86314
Releases: master
Change-Id: I7d39841fa5085ea5bedb138e1d3e0eb036a3f402
Reviewed-on: https://review.typo3.org/58481
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[TASK] Adapt FAL dumpFile to use PSR-7 response objects 85/55585/15
Benjamin Franzke [Wed, 2 Aug 2017 14:06:54 +0000 (16:06 +0200)]
[TASK] Adapt FAL dumpFile to use PSR-7 response objects

A new driver method streamFile() is added (specified
in a new, internal StreamableDriverInterface).
streamFile() returns a PSR-7 response which serves
the contents of the file.

Once this interface will be marked as public, third party drivers
will be allowed to return an own response (e.g. containing a redirect
to a CDN), providing full controls to headers. It also opens
possibilties for optimizations like X-SendFile (apache) or
X-Accell-Redirect (nginx) to be used by drivers.

We also add SelfEmittableStreamInterface (marked as internal) to support
the same fast file sending using readfile() – the interface provides
a hook which is called by the AbstractApplication in sendResponse.
That means that file contents do not need to be read into memory, stored
into a stream, and then read again, but can be piped to stdout by php
directly.

For all existing drivers backward compatibility is provided by
wrapping their dumpFileContents() method into a decorator stream which
calls dumpFileContents *when* the response is sent.
That means middlewares are able to prevent/stop/enhance
the response, but the driver method dumpFileContents is still used –
it's delayed until Application::sendResponse.

The dumpFileContents method of the ResourceStorage class
is now deprecated. ResourceStorage->streamFile() should be used instead.

Change-Id: I64e707c1f8350e409ff2505b98531b92b2936e02
Releases: master
Resolves: #83793
Reviewed-on: https://review.typo3.org/55585
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[BUGFIX] Do not trigger tooltip automatically after hide/unhide 79/58479/2
Nikita Hovratov [Sat, 29 Sep 2018 22:47:02 +0000 (00:47 +0200)]
[BUGFIX] Do not trigger tooltip automatically after hide/unhide

The tooltip is not shown now, when you move the cursor away, while the
spinning icon is active. The new label still updates, if you keep the
cursor the whole time on the button.

Resolves: #85319
Releases: master, 8.7
Change-Id: Id653a9f6d43c1ca1f6a24112edde18b50286843f
Reviewed-on: https://review.typo3.org/58479
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[TASK] Use PageRepository in indexed search menu generation 92/58492/2
Benni Mack [Sun, 30 Sep 2018 11:33:26 +0000 (13:33 +0200)]
[TASK] Use PageRepository in indexed search menu generation

Use your own instance of PageRepository instead of depending
on TSFE, and use the menu by using the global context
and restrictions by using PageRepository instead of custom
DB queries.

Resolves: #86472
Releases: master
Change-Id: Ia480caace4d7415a8b43abc36b7dda5e314c0712
Reviewed-on: https://review.typo3.org/58492
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[TASK] Streamline labels of site configuration 08/58508/2
Susanne Moog [Sun, 30 Sep 2018 19:18:54 +0000 (21:18 +0200)]
[TASK] Streamline labels of site configuration

Labels have been rewritten to consequently use
title case. Additionally, the layout of the
main site tab has been adjusted.

Resolves: #86485
Releases: master
Change-Id: I5186c3a4506d546dc61ef8e4e9e41491b123ace4
Reviewed-on: https://review.typo3.org/58508
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Migrate BackendWorkspaceRestriction to Context API 84/58484/5
Benni Mack [Sun, 30 Sep 2018 09:50:44 +0000 (11:50 +0200)]
[TASK] Migrate BackendWorkspaceRestriction to Context API

This patch also streamlines the Context API usage of
Workspaces in the main AbstractDataHandlerActionTestCase
class.

Resolves: #86465
Releases: master
Change-Id: I99e2a379e745494f9c23cca40ca4ad7ee1fc887f
Reviewed-on: https://review.typo3.org/58484
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Ensure deleted scheduler tasks are never run 39/58439/5
Benni Mack [Sun, 30 Sep 2018 16:03:24 +0000 (18:03 +0200)]
[BUGFIX] Ensure deleted scheduler tasks are never run

In #79777 a new "tx_scheduler_task.deleted" field was
added, but is not always considered when tasks are run.

Resolves: #86420
Related: #79777
Releases: master
Change-Id: Ide025bda13504bd56dc5f9cc090f5e7e54da6695
Reviewed-on: https://review.typo3.org/58439
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[TASK] Streamline Page Argument merge strategies 07/58507/2
Benni Mack [Sun, 30 Sep 2018 17:36:18 +0000 (19:36 +0200)]
[TASK] Streamline Page Argument merge strategies

PageArguments are fetched and added on top of PSR-7 request
queryParams right after they are validated from the PageRouter.

They are also re-populated after config.defaultGetVars has
modified global state.

But they do not need to be set to TSFE again within the
the PageArgumentValidator middleware.

Resolves: #86483
Releases: master
Change-Id: I03df4223832845038d4207417cfcab7cbcc687dc
Reviewed-on: https://review.typo3.org/58507
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Installer should use 50% of its space 06/58506/5
Benni Mack [Sun, 30 Sep 2018 16:52:33 +0000 (18:52 +0200)]
[BUGFIX] Installer should use 50% of its space

The Installer uses a full grid which is a lot of white space if not needed.

So, the whole layout is put into a col-md-6 grid with a col-md-offset-3
offset.

Resolves: #86482
Releases: master
Change-Id: If2e409deae98c0cf23eb7606a6cf35b950834874
Reviewed-on: https://review.typo3.org/58506
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[BUGFIX] Fix panel-collapse and modal-body padding-bottom in firefox 60/58460/2
Nikita Hovratov [Sat, 29 Sep 2018 15:55:29 +0000 (17:55 +0200)]
[BUGFIX] Fix panel-collapse and modal-body padding-bottom in firefox

* The last item in panel-collapse has now proper padding to its bottom.
* With a different behaviour of firefox a container having overflow-y
  ignores padding-bottom. A workaround is a pseudo-element reserving
  the same space as the padding attribute would have.

Resolves: #86445
Releases: master
Change-Id: I55b6318f1b59ceda65857726828deab5bc8a306f
Reviewed-on: https://review.typo3.org/58460
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 months ago[BUGFIX] Skip special doktype parent pages in slug generation 73/58473/4
Benni Mack [Sat, 29 Sep 2018 18:57:24 +0000 (20:57 +0200)]
[BUGFIX] Skip special doktype parent pages in slug generation

When checking the parent page for an existing slug, the parent page
should not be used if the parent page is a sys folder, spacer or
recycler (pages.doktype), but the traversal goes up.

This makes it a bit easier for editors to work with better-speaking
URLs and keep the rootline traversal as best practice.

Resolves: #86456
Releases: master
Change-Id: I2c46d096e41fb3a325fd42bf86b8968b79d6305b
Reviewed-on: https://review.typo3.org/58473
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[BUGFIX] Ensure workspace preview works with Site Handling 02/58502/3
Benni Mack [Sun, 30 Sep 2018 15:23:02 +0000 (17:23 +0200)]
[BUGFIX] Ensure workspace preview works with Site Handling

While introducing Page URL handling, the workspace functionality
still built the URL with `/index.php` although the Router should
take care of that now.

As drive-by fix, the BackendUtility preview URL hook now works again
due to some refactoring back in TYPO3 9.2.

Another drive-by fix allows to register the middleware at the
right place to render the workspace preview in general.

Resolves: #86480
Releases: master
Change-Id: Icfa5a5eee304c27db39cf25903b9a14452c81168
Reviewed-on: https://review.typo3.org/58502
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Daniel Goerz <daniel.goerz@posteo.de>
Tested-by: Daniel Goerz <daniel.goerz@posteo.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Avoid double slashes in slug generation 03/58503/2
Oliver Hader [Sun, 30 Sep 2018 15:34:58 +0000 (17:34 +0200)]
[BUGFIX] Avoid double slashes in slug generation

When generating slugs it might happen, that double slashes
are generated. This basically results from both prepending
and appending slashes at the same time.

Resolves: #86479
Releases: master
Change-Id: I441fee333cd0b3fbad3dde1a130eb08356bd4c2d
Reviewed-on: https://review.typo3.org/58503
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
4 months ago[TASK] Improve processing of mappable aspects 83/58483/3
Oliver Hader [Sun, 30 Sep 2018 08:40:21 +0000 (10:40 +0200)]
[TASK] Improve processing of mappable aspects

Improve processing by deferring those mappers that invoke persistence
the latest possible time. In case mappers do not match the processing
is stopped earlier to avoid superfluous checks and invocations.

Resolves: #86464
Releases: master
Change-Id: I4f9ec66611e84b49a54223f77aee824033a2fb7a
Reviewed-on: https://review.typo3.org/58483
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[TASK] Shorten the extend class in all unit tests 01/58501/2
Wouter Wolters [Sun, 30 Sep 2018 14:28:57 +0000 (16:28 +0200)]
[TASK] Shorten the extend class in all unit tests

Shorten \TYPO3\TestingFramework\Core\Unit\UnitTestCase to UnitTestCase

Resolves: #86478
Releases: master
Change-Id: I5dc7704fb2776cff26f1bbf89b35e28fecd9a79e
Reviewed-on: https://review.typo3.org/58501
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[BUGFIX] Display correct original state when invertStateDisplay is true 38/58238/4
Jigal van Hemert [Sun, 9 Sep 2018 11:01:24 +0000 (13:01 +0200)]
[BUGFIX] Display correct original state when invertStateDisplay is true

In the fieldWizard defaultLanguageDifferences the opposite value must be
displayed if invertStateDisplay is active in fields of type "check".

Resolves: #86205
Releases: master
Change-Id: Iac8fa73406b076b3d26a6ed3aed7e21b79220750
Reviewed-on: https://review.typo3.org/58238
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Jan Helke <typo3@helke.de>
Tested-by: Jan Helke <typo3@helke.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 months ago[BUGFIX] Remove unreachable return statement 98/58498/2
Christian Kuhn [Sun, 30 Sep 2018 13:20:22 +0000 (15:20 +0200)]
[BUGFIX] Remove unreachable return statement

Resolves: #86476
Releases: master
Change-Id: I182bd77895744d13ba535b43e46b802def49cb45
Reviewed-on: https://review.typo3.org/58498
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Avoid count() in test conditions 96/58496/3
Christian Kuhn [Sun, 30 Sep 2018 13:15:30 +0000 (15:15 +0200)]
[TASK] Avoid count() in test conditions

Resolves: #86474
Releases: master
Change-Id: I2265e9167dc0604f8d2605121028c029fe3eebfc
Reviewed-on: https://review.typo3.org/58496
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Add rule to prevent the @access annotation entering the core 97/58497/4
Wouter Wolters [Sun, 30 Sep 2018 13:19:14 +0000 (15:19 +0200)]
[TASK] Add rule to prevent the @access annotation entering the core

Add the phpdoc_no_access rule to the php-cs-fixer configuration to
prevent the @access annotation from entering the core again.

Resolves: #86475
Related: #86446
Releases: master
Change-Id: I9db729ae1375434bea49f92468f7d490a554b4fb
Reviewed-on: https://review.typo3.org/58497
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Fix sprintf argument mismatch in FormManagerController 00/58500/2
Wouter Wolters [Sun, 30 Sep 2018 13:28:50 +0000 (15:28 +0200)]
[BUGFIX] Fix sprintf argument mismatch in FormManagerController

Resolves: #86477
Releases: master
Change-Id: I9595a1f1a4d90566d732dcf3c3f8b883a08a6bbe
Reviewed-on: https://review.typo3.org/58500
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 months ago[BUGFIX] Make Extbase translation handling consistent with TypoScript 74/53974/116
Tymoteusz Motylewski [Mon, 16 Jul 2018 16:02:09 +0000 (18:02 +0200)]
[BUGFIX] Make Extbase translation handling consistent with TypoScript

Make Extbase fetch records in the same way as in TypoScript rendering,
making QuerySettings options mean the same as corresponding settings
from TypoScript.

This change allows e.g. to filter and sort by translated values
of the aggregate root.

To make upgrades easier a feature switch is introduced which
enables the new behavior. It can be disabled with TypoScript if
somebody relies on the old behavior.

The feature switch is enabled by default in v9 and will be gone in v10
so in version 10 the fixed way will be the only way to fetch records
in Extbase.

Releases: master
Resolves: #82363
Resolves: #84011
Change-Id: I58d0a24c1f73debc6b9251efea9c28c9cf09d6d0
Reviewed-on: https://review.typo3.org/53974
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
4 months ago[BUGFIX] Remove nested form-group class 68/58468/2
Georg Ringer [Sat, 29 Sep 2018 17:54:05 +0000 (19:54 +0200)]
[BUGFIX] Remove nested form-group class

Remove nested class "form-group" in backend user module form

Resolves: #86450
Releases: master
Change-Id: I15a46b772d55ee8c0ea6fe9de00ef5a3cf53f27e
Reviewed-on: https://review.typo3.org/58468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Mark various TypoScript parsing functionality as internal 77/58477/6
Benni Mack [Sat, 29 Sep 2018 22:02:54 +0000 (00:02 +0200)]
[TASK] Mark various TypoScript parsing functionality as internal

The TypoScript Parser has been around since PHP 4 and hasn't
been touched much since 12ys. In order to speed up TypoScript
processing in the future, it is important to first streamline
all usages and mark internal functionality as "protected" instead
of "public".

Some other parts for sys_template rendering has been
marked as internal as well.

Resolves: #86461
Releases: master
Change-Id: I4ab0852bc0fb386aa9016b8845f7f8f15a7c3166
Reviewed-on: https://review.typo3.org/58477
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
4 months ago[BUGFIX] Install typo3db_legacy v1.1.1 to use new API 95/58495/2
Benni Mack [Sun, 30 Sep 2018 12:13:48 +0000 (14:13 +0200)]
[BUGFIX] Install typo3db_legacy v1.1.1 to use new API

The extracted extension should use the new DB API.

Resolves: #86373
Releases: master
Change-Id: Ibcb58f3c795cc888285b61bc7f3e2251f15cd328
Reviewed-on: https://review.typo3.org/58495
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Do not depend on a database connection in CLI authentication 27/58427/5
Benjamin Franzke [Wed, 26 Sep 2018 20:54:22 +0000 (22:54 +0200)]
[BUGFIX] Do not depend on a database connection in CLI authentication

Neither the backend user authentication should try to perform
database queries, nor the extbase services.

As a side effect this allows to run the cli tool when
LocalConfiguration.php or PackageStates.php are missing,
which allows to run commands like `dumpautoload` in that case.
Note: *Only* in that case, not if a database connection
is configured, but not available – for that usecase failsafe
booting will be needed, as proposed in https://review.typo3.org/c/58298/
and/or https://review.typo3.org/c/58300/

As a drive-by we also add a null coalescing operator to
IconRegistry::registerModuleIcons() which is currently
required because ext_tables.php files are loaded in
incorrect order if PackageStates.php is missing (reported
in another bug: #86408). Although this workaround will
not be strictly required when that bug is fixed, that functions
should still properly handle that case.

Change-Id: I7d339e21160d25b5aee5dd0e2f25491a22ec83e9
Releases: master
Resolves: #86416
Related: #86408
Reviewed-on: https://review.typo3.org/58427
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[BUGFIX] Minor adjustments to wordings, variables and docs 93/58493/3
Benni Mack [Sun, 30 Sep 2018 11:57:50 +0000 (13:57 +0200)]
[BUGFIX] Minor adjustments to wordings, variables and docs

Resolves: #86473
Releases: master
Change-Id: I19f499533636b6a187adde51f2a4ca96149cc45f
Reviewed-on: https://review.typo3.org/58493
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Clean up FormEngine fields for Site Handling 89/58489/2
Benni Mack [Sun, 30 Sep 2018 11:14:34 +0000 (13:14 +0200)]
[TASK] Clean up FormEngine fields for Site Handling

The descriptions and listings of site language in FormEngine
hasn't been worked on since its introduction.

This is now streamlined in terms of wording and grouping,
to help people find things in a better way.

Resolves: #86470
Releases: master
Change-Id: I3692b8466c779b32d8a52d58469e5b87874643fa
Reviewed-on: https://review.typo3.org/58489
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] Replace class property caching with runtime cache 53/51953/11
Claus Due [Sat, 4 Mar 2017 16:00:19 +0000 (17:00 +0100)]
[BUGFIX] Replace class property caching with runtime cache

PageRepository is now used independantly from TSFE
most of the time, and a new instance is created each time a
content element gets rendered. This means that the current
cache strategy using class properties gets flushed repeatedly
and multiple identical SQL requests to be sent to the DB.

By replacing the class property caching with runtime cache
which survives across instances, the problem is solved.

On some sites this represents a reduction of several hundred
SQL requests.

Change-Id: Ib606ada46c3c262fd9004a12166b79d80bbc5edb
Resolves: #80138
Releases: master
Reviewed-on: https://review.typo3.org/51953
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[BUGFIX] Respect mountpoint variable in cObj menu runtime cache 32/57532/5
Sascha Egerer [Wed, 11 Jul 2018 14:59:22 +0000 (16:59 +0200)]
[BUGFIX] Respect mountpoint variable in cObj menu runtime cache

The mountpoint variable must be respected in the key used for the
menu runtime cache. Without that part in the key all links generated
to a mount-point sub-page will link to the first mount target page
in the menu.

Resolves: #80970
Resolves: #62248
Releases: master, 8.7, 7.6
Change-Id: I8ccfebabd515d6da9f78388de51d24603e9fe532
Reviewed-on: https://review.typo3.org/57532
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[BUGFIX] Adjust broken extension scanner config 88/58488/2
Christian Kuhn [Sun, 30 Sep 2018 11:01:23 +0000 (13:01 +0200)]
[BUGFIX] Adjust broken extension scanner config

Resolves: #86469
Related: #86441
Releases: master
Change-Id: Iff35a1be7c436ff3aceab7b9eb82af773278b363
Reviewed-on: https://review.typo3.org/58488
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Tag .rst file 86440 with PHP-API 87/58487/2
Christian Kuhn [Sun, 30 Sep 2018 10:55:07 +0000 (12:55 +0200)]
[TASK] Tag .rst file 86440 with PHP-API

Resolves: #86468
Related: #86440
Releases: master
Change-Id: I1e0cf65d487b8ea95edb7acdad50c671da3277a5
Reviewed-on: https://review.typo3.org/58487
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Mark .rst file 86439 FullyScanned 86/58486/2
Christian Kuhn [Sun, 30 Sep 2018 10:52:59 +0000 (12:52 +0200)]
[TASK] Mark .rst file 86439 FullyScanned

Resolves: #86467
Related: #86439
Releases: master
Change-Id: If14e53972535458ec493454d8e42c48eb67dc35c
Reviewed-on: https://review.typo3.org/58486
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[TASK] Deprecate AbstractUserAuthentication->fetchUserRecord 85/58485/3
Christian Kuhn [Sun, 30 Sep 2018 10:34:52 +0000 (12:34 +0200)]
[TASK] Deprecate AbstractUserAuthentication->fetchUserRecord

To untie authentication services from user authentication a bit better,
the fetchUserRecord() method of AbstractAuthenticationService now
implements fetchUserRecord() on its own instead of calling the method
with the same name of $pObj.
AbstractUserAuthentication->fetchUserRecord() is then unused and can
be deprecated.

Resolves: #86466
Releases: master
Change-Id: Ia144ea2dfb8a7c7462ed12875ee35caab9763ba2
Reviewed-on: https://review.typo3.org/58485
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
4 months ago[BUGFIX] synchronize flags in registry with TCA 76/58476/2
Jigal van Hemert [Sat, 29 Sep 2018 20:54:16 +0000 (22:54 +0200)]
[BUGFIX] synchronize flags in registry with TCA

Flag icons that come with core, the flags that are registered in the icon
registry, the lists in sys_language and site_language are now in sync again.

Releases: master
Resolves: #86460
Change-Id: I1e274b3e274b305486b6e37d600a915177ef484c
Reviewed-on: https://review.typo3.org/58476
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[TASK] Remove leftover .htaccess files in Resources/Private folders 82/58482/2
Josef Glatz [Sun, 30 Sep 2018 06:26:55 +0000 (08:26 +0200)]
[TASK] Remove leftover .htaccess files in Resources/Private folders

Leftover .htaccess files were savedly removed, as the root
.htaccess (for Apache webserver) / .web.config (for IIS webserver)
already takes care of access rules.

Resolves: #86463
Releases: master
Change-Id: I1186a5cdd068c2052d3d6ab2a4210d931d8684cd
Reviewed-on: https://review.typo3.org/58482
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
4 months ago[BUGFIX] EvaluteDisplayCondition should throw proper error message 80/58480/3
Benni Mack [Sat, 29 Sep 2018 23:42:41 +0000 (01:42 +0200)]
[BUGFIX] EvaluteDisplayCondition should throw proper error message

When an extension author writes a display condition in TCA and
by incident uses a wrong format for the displayCondition (see ticket)
the strtoupper fails due to the lack of an associative array
because it's a numeric-key array.

An additional check fixes the issue.

Resolves: #79692
Releases: master, 8.7
Change-Id: I4455bdc908e0be1a373f86680e718e876aa5ddd7
Reviewed-on: https://review.typo3.org/58480
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 months ago[TASK] Remove comments mentioning "branch versioning" 61/57261/3
Tymoteusz Motylewski [Mon, 18 Jun 2018 16:11:38 +0000 (18:11 +0200)]
[TASK] Remove comments mentioning "branch versioning"

Resolves: #85305
Releases: master
Change-Id: I01c62adede04f5f74c506c15e28d471ad3185593
Reviewed-on: https://review.typo3.org/57261
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[FEATURE] Make prepending slash in TCA slug configurable 74/58474/3
Benni Mack [Sat, 29 Sep 2018 19:05:45 +0000 (21:05 +0200)]
[FEATURE] Make prepending slash in TCA slug configurable

A new TCA option for TCA type "slug" is added, called "prependSlash",
which adds a "/" in front of the field. For pages (pages.slug),
this is mandatory and cannot be configured, as the slug field
has to be filled and set to "/" as a base for the root page.

For other database fields, this is optional (and disabled by default),
and can be enabled via "prependSlash" in TCA config.

This option is mostly useful for recursive records, like categories,
but for most "flat" structures like "news" or "events", this is not
suitable. For pages, it is hard-coded and cannot be (un-)set.

Resolves: #86457
Releases: master
Change-Id: I997908ed74af7ca21873b0793674e9185cc581ce
Reviewed-on: https://review.typo3.org/58474
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Jörg Bösche <typo3@joergboesche.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
4 months ago[TASK] Add functional test for route enhanced link handling 61/58461/7
Oliver Hader [Sat, 29 Sep 2018 15:44:42 +0000 (17:44 +0200)]
[TASK] Add functional test for route enhanced link handling

* adds test cases for resolving and generating enhanced links
* fixes locale issues when dealing with persisted mappers
* removes PersistedAliasMapper.valueFieldName and uses TCA
  'uid' field per default, which is required for proper
  language based resolving as well
* introduces language based resolving to PersistedAliasMapper
  and PersistedPatternMapper

Resolves: #86444
Releases: master
Change-Id: Ib9c9ea8efc25a8a5adb727f8402a2b6b1e6a1602
Reviewed-on: https://review.typo3.org/58461
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Remove @internal on new UpgradeWizard interfaces 66/58466/2
Susanne Moog [Sat, 29 Sep 2018 17:28:52 +0000 (19:28 +0200)]
[TASK] Remove @internal on new UpgradeWizard interfaces

To allow others to use the new upgrade wizard API the
interfaces are no longer marked as @internal.

Resolves: #86448
Releases: master
Change-Id: I2e146e6d27c5aaed922a004054b3df2bbea88cb8
Reviewed-on: https://review.typo3.org/58466
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] Merge PSR-7 request and _GET/_POST parameters 43/58443/4
Benni Mack [Fri, 28 Sep 2018 20:24:53 +0000 (22:24 +0200)]
[TASK] Merge PSR-7 request and _GET/_POST parameters

When hooks modify _GET or _POST parameters,
it is important that these changes reflect the PSR-7 request
for now, as long as TYPO3 access the _GET/_POST parameters
via GeneralUtility::_GP().

In order to move away from global access, we still want to avoid
places where it is unclear to use $_GET/$_POST vs.
$GLOBALS['TYPO3_REQUEST'] until all parts are completely
"global-scope free" for GET/POST parameters.

The change adds the initial GET/POST parameters to the
request object in the very first middleware of the frontend.

If these have been modified when the RequestHandler builds
up the content, they are added on top of the PSR-7 request object.

Additionally, if the PSR-7 request object has been modified,
these changes are put back in the global scope to reliably use
_GPmerged within Extbase and

Additionally, if _GET/_POST have been modified, a warning will
be shown in the TimeTracker to find out that there have been
modifications.

Until then, it is safe to continue to access _GET/_POST within
Hooks and Frontend, however it is highly discouraged to *modify*
_GET/_POST directly as this functionality will be breaking in TYPO3 v10.0.

Bottom line: This safety net can now trigger deprecation warnings
if _GET/_POST have been modified during PSR-15 middleware hooks.

Bottom line 2: If these have been modified, they are put inside the
current request object.

Bottom line 3: If the request object has been modified, global state
will be modified ONCE in one place to ensure that we work with
the same object during the request phase.

Bottom line 4: We cannot get away from the current state of
running a TYPO3 Frontend Request from another source, and
we try to maintain compatibilty for legacy scripts for now. However,
this will be breaking in TYPO3 v10.0.

Resolves: #86458
Releases: master
Change-Id: Ic8f4f123bb5ea0d660e500494cf06a965dea03c4
Reviewed-on: https://review.typo3.org/58443
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
4 months ago[TASK] Mark several parts within RteHtmlParser as internal 57/58457/4
Benni Mack [Sat, 29 Sep 2018 14:23:06 +0000 (16:23 +0200)]
[TASK] Mark several parts within RteHtmlParser as internal

RteHtmlParser has never received a good clean up, that's
because it was there since PHP 4 ages.

In order to rename, reorder code, all internal methods
and properties are now declared as protected.

Resolves: #86440
Releases: master
Change-Id: I204efa8156abcf9ae07a607fa03fa04fbb269885
Reviewed-on: https://review.typo3.org/58457
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
4 months ago[TASK] CKEditor RTE: Re-add the wordcount functionality 05/58405/6
Josef Glatz [Wed, 26 Sep 2018 17:36:17 +0000 (19:36 +0200)]
[TASK] CKEditor RTE: Re-add the wordcount functionality

This patch re-adds a missing functionality to CKEditor.

Due to the move from htmlArea to CKEditor, the well-known
wordcount information was gone.

The wordcount information is added to all existing CKEditor presets
per default. In addition, it is now possible to customize the displayed
information below the editor.

- It's possible to switch paragraph-, word- and/or character count.
- You can define if spaces are counted as charactars.
- You can define if HTML tags are taken into account.
- You can define if linebreaks are taken into account.

Beside that, the used plugin enables also setting up maximum
values for word- and/or character count. This can be easily used
for custom RTE presets. The fact that the global configuration is
located in the Base.yaml makes it possible to overwrite settings
partially or completely in any inherited RTE preset. With that it is
easy possible to realize word/character limits.

Following commands were used to add the external package as
a dependency and copy the plugin files/folders to the final location:
`yarn add --dev ckeditor-wordcount-plugin && yarn build`

Resolves: #86395
Releases: master
Change-Id: I2c76d7bfebc9a5a57c1f105788af206bdffb00f2
Reviewed-on: https://review.typo3.org/58405
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use NormalizedParams with simplified arguments 71/58471/4
Benni Mack [Sat, 29 Sep 2018 18:32:46 +0000 (20:32 +0200)]
[TASK] Use NormalizedParams with simplified arguments

Normalized Params only needs serverParams and
$TYPO3_CONF_VARS[SYS] to work with, so the object is modified
in order to simplify further work on the object.

Resolves: #86454
Releases: master
Change-Id: I30f2c6195468b275e61570c1de67b39f281bb494
Reviewed-on: https://review.typo3.org/58471
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
4 months ago[BUGFIX] Remove tooltip over delete button when it's clicked 63/58463/3
Nikita Hovratov [Sat, 29 Sep 2018 17:11:46 +0000 (19:11 +0200)]
[BUGFIX] Remove tooltip over delete button when it's clicked

The tooltip has to be removed at that point, because as soon as any data
is deleted the row disappears and it's not possible to trigger the
mouseout event manually.

Resolves: #81856
Releases: master, 8.7
Change-Id: I2f7388b6a278de9ba19e81ec20ed3ae0052b1698
Reviewed-on: https://review.typo3.org/58463
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
4 months ago[TASK] Sort extensions in Install Tool module by name 70/58470/2
Georg Ringer [Sat, 29 Sep 2018 18:27:55 +0000 (20:27 +0200)]
[TASK] Sort extensions in Install Tool module by name

Sort the extension settings by the extension key.

Resolves: #86452
Releases: master
Change-Id: I6fb0110820d4a8406f01b617b3279640be9aa743
Reviewed-on: https://review.typo3.org/58470
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
4 months ago[TASK] Deprecate PageRenderer->loadJQuery() 55/58455/11
Benni Mack [Sat, 29 Sep 2018 13:11:00 +0000 (15:11 +0200)]
[TASK] Deprecate PageRenderer->loadJQuery()

Instead of explicitly call loadJQuery() this should be handled
by requireJS or - even better - use vanilla JavaScript instead.

Resolves: #86438
Releases: master
Change-Id: Iecc2ceb7fa01578b00a63262f393bd1b92fa13e1
Reviewed-on: https://review.typo3.org/58455
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
4 months ago[TASK] Mark several methods within TemplateService as internal 56/58456/8
Benni Mack [Sat, 29 Sep 2018 14:06:31 +0000 (16:06 +0200)]
[TASK] Mark several methods within TemplateService as internal

The following methods will trigger a deprecation warning if
they are called from the outside:

- TemplateService->prependStaticExtra()
- TemplateService->versionOL()
- TemplateService->processIncludes()
- TemplateService->mergeConstantsFromPageTSconfig()
- TemplateService->flattenSetup()
- TemplateService->substituteConstants()

Several other methods have been marked as internal.

Resolves: #86439
Releases: master
Change-Id: Ifabbda8048449e6919d054da4111f01065a5eeab
Reviewed-on: https://review.typo3.org/58456
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
4 months ago[TASK] Use PSR-15 RequestHandler in Install Tool 69/58469/3
Benni Mack [Sat, 29 Sep 2018 18:13:30 +0000 (20:13 +0200)]
[TASK] Use PSR-15 RequestHandler in Install Tool

Install Tool still uses TYPO3's own RequestHandler interface which
exists since TYPO3 v7, but is superseded with PSR-15's
RequestHandler concept.

Install Tool now uses PSR-15 and the old interface in order
to still use the priority concept.

In a further step, both RequestHandlers should be migrated to
Middleware+RequestHandler concept.

Resolves: #86451
Releases: master
Change-Id: I55cf31a2b803951491ba072969a4cff68ef2c2ac
Reviewed-on: https://review.typo3.org/58469
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] phpDoc: replace @access private with @internal 62/58462/4
Benni Mack [Sat, 29 Sep 2018 17:12:19 +0000 (19:12 +0200)]
[TASK] phpDoc: replace @access private with @internal

The phpDoc comment "@internal" is used in most places
during the development of TYPO3 v7, TYPO3 v8 and TYPO3 v9
and denotes that this specific method, class or property is not
part of the Public API, and does not even need any notice if it
is removed.

However, we still have/had various places in TYPO3 core
where "@access private" was used. This is now migrated to
"@internal". "@access public" is not needed and is removed.

Resolves: #86446
Releases: master
Change-Id: Iaef206b04aee13c280d62b107dd7eac04a38c700
Reviewed-on: https://review.typo3.org/58462
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
4 months ago[TASK] Fix spelling of 'analyze' 54/58454/3
Susanne Moog [Sat, 29 Sep 2018 12:32:35 +0000 (14:32 +0200)]
[TASK] Fix spelling of 'analyze'

As the core uses American English, 'analyze' should be
spelled with a `z`. This looked especially strange in the
install tool, where both spellings were mixed on one card.

Resolves: #86447
Releases: master
Change-Id: I484f75a05d3cf988baaebf91df30cd936f454eac
Reviewed-on: https://review.typo3.org/58454
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>