Packages/TYPO3.CMS.git
19 months ago[TASK] Decouple Bootstrap and Application engaging a PSR-11 container 73/55773/51
Benjamin Franzke [Thu, 8 Feb 2018 20:21:05 +0000 (21:21 +0100)]
[TASK] Decouple Bootstrap and Application engaging a PSR-11 container

In order to avoid global state and to support full-application
subrequests (later on), bootstraping, application initialization
and application execution needs to be decoupled.
(To be able to initialize a frontend Application in backend
Application context, the frontend Application may not re-execute
bootstraping code.)

That means from now on:
 * Bootstrap is limited to stateless bootstrapping
   => setting up package manager and configuration
 * A (new) Container (PSR-11) performs class initialization
   => e.g. `new Frontend/Http/Application()`
 * Application performs execution
   => checking possible (application specific) redirects
   => offloading work to the request handler

This commit transforms Bootstrap into a (static) bootstrap utility
that returns a container (minimal, static PSR-11 implementation).
The entry-point scripts execute the bootstraper and use
the returned container to initialize and run the application.

This commit acts as a starting point for a broader PSR-11 container
support in TYPO3. We do – on purpose – use an own, very limited, anonymous
and static there is no configuration) PSR-11 implemententation for now.
This interim container implementation will be replaced by whatever
PSR-11 supporting container solution we use later on.
That keeps the necessary Bootstrap refactoring seperate from the
introduction of a full dependency injection container implementation.

All existing bootstrap methods keep working as before but the non-static
method invocation should be deprecated at some point.

typo3/cms-cli is adapted for the changed entry point script with:
https://github.com/TYPO3/cms-cli/pull/1

typo3/testing-framework is adapted in
https://github.com/TYPO3/testing-framework/pull/55

This patch brings one important behavioral change:

The install tool redirect (if essential configuration is missing) is
perfomed during application execution – after the configuration has been
loaded (falling back to failsafe mode if missing) – now. Previously the
application performed the redirect before it would call Bootstraps
configure() method. Now that the Application is decoupled from bootstrap,
the bootstrapper ensures it can always create an Application class, in
order for the application to be in charge of the decision what should
happen if essential configuration is missing.

Dependency changes:

composer require psr/container:^1.0
composer require typo3/cms-cli:^2.0
composer require typo3/testing-framework:^3.2 --dev

Change-Id: Idc59665dfcf7250a8a42b3d908a5a2376067700c
Releases: master
Resolves: #83951
Reviewed-on: https://review.typo3.org/55773
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Assign elementErrorClassAttribute to ImageUpload and FileUpload element 63/56063/3
Benjamin Kott [Thu, 8 Mar 2018 15:16:21 +0000 (16:16 +0100)]
[BUGFIX] Assign elementErrorClassAttribute to ImageUpload and FileUpload element

Resolves: #84181
Releases: master, 8.7
Change-Id: If55767b54071809e9622f9c29829bf4a76c66409
Reviewed-on: https://review.typo3.org/56063
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Allow empty date/time in strict database modes 62/56062/3
Oliver Hader [Thu, 8 Mar 2018 14:57:53 +0000 (15:57 +0100)]
[BUGFIX] Allow empty date/time in strict database modes

Empty date/time values are represented by the FormEngine as empty
string (''). Trying to persist this value in database management systems
using strict mode (which is enabled per default in MySQL 5.7),
will cause an SQL error since field types do not match.

Since it's known for the TYPO3 core which field types are used in
particular database tables, it's also possible to enforce this
type to be casted to integer values. This is done by using the
according TCA evaluation function 'int'.

Resolves: #82756
Releases: master, 8.7
Change-Id: I487caae785a3943916bceebc0c484d58e900a841
Reviewed-on: https://review.typo3.org/56062
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[BUGFIX] Allow range options to work for date/time fields 20/56020/7
Jigal van Hemert [Tue, 6 Mar 2018 10:22:35 +0000 (11:22 +0100)]
[BUGFIX] Allow range options to work for date/time fields

Date and time fields can contain ISO-8601 values. To apply lower and
upper limits the value must first be converted to a UNIX timestamp.

Resolves: #83240
Releases: master, 8.7
Change-Id: Ic15e9486cf7a4bcdf557c8a197d957ad88302b61
Reviewed-on: https://review.typo3.org/56020
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Recycler selectall feature has wrong data in rst file 59/56059/2
Oskar Dydo [Thu, 8 Mar 2018 13:15:05 +0000 (14:15 +0100)]
[BUGFIX] Recycler selectall feature has wrong data in rst file

Feature #81310 has wrong .rst file. The file should be corresponding to forge id not review id.

Resolves: #84176
Related: #81310
Releases: master
Change-Id: Iefddf9ba82534cb978d8ec3915d5fc34085646f3
Reviewed-on: https://review.typo3.org/56059
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[TASK] Migrate ModuleMenu to TypeScript 00/56000/6
Andreas Fernandez [Sun, 4 Mar 2018 16:56:47 +0000 (17:56 +0100)]
[TASK] Migrate ModuleMenu to TypeScript

This commit migrates the ModuleMenu to TypeScript. The following changes
are additionally done with with patch:

- NavigationComponentInterface requires a `initialize()` method
- Storage/Persistent.set() accepts objects as value
- ModuleMenu.App.ensurePageInTreeSelected is broken since #82426
  and has been removed

Resolves: #82597
Releases: master
Change-Id: I1dc8a79f7953a1e2504b0e7fd978c2e841ec93f4
Reviewed-on: https://review.typo3.org/56000
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Remove a duplicate ReST file 55/56055/2
Christian Kuhn [Thu, 8 Mar 2018 10:37:24 +0000 (11:37 +0100)]
[BUGFIX] Remove a duplicate ReST file

ReST file back ported to v8 should be added to 8.7.x/ folder in
core master branch only. Patch for issue #82093 copied the file
to master/ folder, this dupe is removed again.

https://docs.typo3.org/typo3cms/extensions/core/latest/Changelog/Howto.html
for more details on this.

Resolves: #84175
Related: #82093
Releases: master
Change-Id: Ibcd26da62b2c5d7a270a54c5fbe0d72964da6675
Reviewed-on: https://review.typo3.org/56055
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Change getUrl() $report['content_type'] to string 43/56043/3
Felix Buenemann [Thu, 8 Mar 2018 08:18:34 +0000 (09:18 +0100)]
[BUGFIX] Change getUrl() $report['content_type'] to string

In the conversion of \TYPO3\CMS\Core\Utility\GeneralUtility::getUrl()
from cURL to GuzzleHttp the type of the $report['content_type'] field
was changed from a string to an array of strings.

This changes the field back to a string.

Also updated ErrorController getUrl test double to reflect the changes.

Resolves: #84173
Related: #84167
Releases: master, 8.7
Change-Id: Ia0eb60c42e920d66ce63afd0bd659c4b56d6d05b
Reviewed-on: https://review.typo3.org/56043
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Catch all exceptions in page module of form framework 33/55833/5
Ralf Zimmermann [Tue, 20 Feb 2018 16:40:22 +0000 (17:40 +0100)]
[BUGFIX] Catch all exceptions in page module of form framework

Catch the toplevel \Exception within the preview renderer hook. This
prevents that the page module shows an exception stacktrace if a
formDefinition - which is referenced within a form plugin - is moved
manually to a different location.
The problem occurs because the TYPO3\CMS\Core\Resource\Driver\LocalDriver
throws some top level exceptions (e.g. within getFileInfoByIdentifier()).

Resolves: #83777
Releases: master, 8.7
Change-Id: I686adb9e38b6f1b0bcb9830fe71d318ba0199a75
Reviewed-on: https://review.typo3.org/55833
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Fix a little grammar issue. 52/56052/2
Robert Wildling [Thu, 8 Mar 2018 09:40:05 +0000 (10:40 +0100)]
[TASK] Fix a little grammar issue.

Releases: master
Resolves: #84174
Change-Id: Ic762fbff61a4d7d932c9bc534706bb55fb369f5a
Reviewed-on: https://review.typo3.org/56052
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[!!!][BUGFIX] Fix wrong error path of validation 50/54150/8
Daniel Siepmann [Fri, 15 Sep 2017 22:55:34 +0000 (00:55 +0200)]
[!!!][BUGFIX] Fix wrong error path of validation

Add the form name as top level property to the validation results to let
the form field viewhelper attribute "errorClass" work.

Releases: master, 8.7
Resolves: #82093
Change-Id: I2d1c0845c5ab15d68393d5b491bf26db8f3f17c0
Reviewed-on: https://review.typo3.org/54150
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
19 months ago[BUGFIX] Convert URLs to punycode 58/55858/14
Sybille Peters [Wed, 21 Feb 2018 20:15:42 +0000 (21:15 +0100)]
[BUGFIX] Convert URLs to punycode

Resolves: #55155
Releases: master, 8.7
Change-Id: If7c099647a73d25f86ac38bdda67935deb4930e0
Reviewed-on: https://review.typo3.org/55858
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Pass original extbase response object to form framework finishers 49/55849/2
Benjamin Franzke [Wed, 21 Feb 2018 00:21:50 +0000 (01:21 +0100)]
[BUGFIX] Pass original extbase response object to form framework finishers

The original extbase response was passed as second parameter
to ObjectManager->get() – that did effectively nothing. The second get()
parameter is not a fallback parameter (as probably supposed by the author)
but the first constructor argument (but Response has no constructor).
Now, rather use a coalesce operator to use the original response or create
an own, if required.

Also handle the StopActionException in case no extbase response
is available (e.g. when rendered through FluidTemplateContentObject).

Due to this fixes the redirect finisher can be adapted to stop echo'ing
the response content on it's own. Directly echo'ing the response content
caused wrong Content-Length headers to be generated as the core didn't
know that content has been echo'ed. (The redirect response contains both a
header based redirect and html meta redirect; due to early echo that meta
redirect is prepended to the regular html output, and is missing in the
Content-Length calculation.)
That casused certain server environments (e.g. gzip, keep-alive,
proxy) and browsers (e.g. Android, Opera desktop) to display gzip
compressed data as garbage in the browser.

Resolves: #83822
Releases: master, 8.7
Change-Id: I4cb56e7626ea786d4b5265782b5940e60e3d2ec0
Reviewed-on: https://review.typo3.org/55849
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joonas Kauhanen <joonas.kauhanen@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Treat empty responses as error in GeneralUtility::getUrl 39/56039/5
Felix Buenemann [Wed, 7 Mar 2018 20:51:52 +0000 (21:51 +0100)]
[BUGFIX] Treat empty responses as error in GeneralUtility::getUrl

This fixes a negation bug introduced when the GeneralUtility::getUrl
code was converted to use GuzzleHttp instead of cURL.

Also updated ErrorController test doubles that where asserting the
wrong behavior.

Resolves: #84167
Releases: master, 8.7
Change-Id: I9b8982dc34f8a4ac22769beb7f837f090ce73f23
Reviewed-on: https://review.typo3.org/56039
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Merge the package DependencyResolver into the PackageManager 77/55977/16
Benjamin Franzke [Thu, 1 Mar 2018 18:19:21 +0000 (19:19 +0100)]
[TASK] Merge the package DependencyResolver into the PackageManager

The DependencyResolver and the PackageManager have a cyclic dependency to
each other which is currently resolved using GeneralUtility::makeInstance.
As the DependencyResolver is actually only used for the
PackageManager – and relies on it – it can be merged, saving a lot of
hassle.

The DependencyResolver class is not marked @internal and is therefore
deprecated.

Releases: master
Resolves: #84109
Change-Id: I71adccec3f13eb6de859f065937fbcde369758fe
Reviewed-on: https://review.typo3.org/55977
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Revert "[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths" 35/56035/2
Benjamin Franzke [Wed, 7 Mar 2018 12:06:28 +0000 (13:06 +0100)]
[BUGFIX] Revert "[BUGFIX] Fix recursive FLUIDTEMPLATE cObj's that use layoutRootPaths"

This reverts commit 5c048a4c8017e4d50ab5f2343970a0fd33e4aaed
as introduced in https://review.typo3.org/54416

That workaround for a fluid bug had side effects when DataProviders
expected a ConfigurationManager instance to be available. That is
nothing officially supported but broke some (bad behaving) DataProviders.
As the fluid bug has been fixed in https://github.com/TYPO3/Fluid/pull/342
(contained in release 2.5.2) we can revert the workaround now.

The functional test that was introduced next to the bugfix is not reverted,
as do want to keep that obviously.

Resolves: #84071
Releases: master, 8.7
Change-Id: Ie6f5541f0f217fee7e85df954bb964a32fd27367
Reviewed-on: https://review.typo3.org/56035
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Manuel Selbach <manuel_selbach@yahoo.de>
Tested-by: Manuel Selbach <manuel_selbach@yahoo.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[FEATURE] Extract admin panel to own extension 30/56030/6
Susanne Moog [Wed, 7 Mar 2018 10:58:26 +0000 (11:58 +0100)]
[FEATURE] Extract admin panel to own extension

Extract all admin panel code to an own extension to
reduce cross-dependencies and allow clearer scoping.

See Epic / Initiative for background.

Related: #84044
Resolves: #84159
Releases: master
Change-Id: I0f6e2643746c94f0e10b87146ca7e86cbf8bc112
Reviewed-on: https://review.typo3.org/56030
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
19 months ago[BUGFIX] Avoid E_NOTICE reporting in ArrayUtility 32/56032/3
Ralf Zimmermann [Wed, 7 Mar 2018 12:08:44 +0000 (13:08 +0100)]
[BUGFIX] Avoid E_NOTICE reporting in ArrayUtility

In case of exception 1371758436, the dynamic exception message parts
must be converted to strings.

Releases: master
Resolves: #84161
Change-Id: Ibf3df93fef6c51945b21d6db8647419c41598e5d
Reviewed-on: https://review.typo3.org/56032
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Show icon in the page tree when page is edited by other user 33/56033/3
Tymoteusz Motylewski [Wed, 7 Mar 2018 12:11:22 +0000 (13:11 +0100)]
[BUGFIX] Show icon in the page tree when page is edited by other user

When a page is edited by other user it is "locked".
In this case an icon is shown in front of the page title.

Resolves: #84089
Releases: master
Change-Id: I4f3ab9266549212f66f26230e8d4bba4478878fa
Reviewed-on: https://review.typo3.org/56033
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[BUGFIX] Use the real page id for doesPageHaveUnallowedTables check 87/53687/5
Wolfgang Klinger [Sat, 12 Aug 2017 18:53:00 +0000 (20:53 +0200)]
[BUGFIX] Use the real page id for doesPageHaveUnallowedTables check

In case of handling a translated page record, use the according
proper uid value of the containing page of default language.

Resolves: #82053
Releases: master, 8.7
Change-Id: I0d0b5a268f4b87ef44d892f046ef474624b18058
Reviewed-on: https://review.typo3.org/53687
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[TASK] Update TYPO3 Icons to 1.6.0 36/56036/2
Susanne Moog [Wed, 7 Mar 2018 14:01:40 +0000 (15:01 +0100)]
[TASK] Update TYPO3 Icons to 1.6.0

New icons:
- content/content-clock.svg
- content/content-map.svg
- content/content-marker.svg
- content/content-menu-card.svg
- content/content-store.svg
- content/content-target.svg
- mimetypes/mimetypes-x-sys_redirect.svg

Resolves: #84162
Releases: master
Change-Id: Ic500110e48f221ae5c69d9ca85280da96f769114
Reviewed-on: https://review.typo3.org/56036
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
19 months ago[TASK] Update Fluid dependency to 2.5.2 31/56031/2
Claus Due [Wed, 7 Mar 2018 12:01:51 +0000 (13:01 +0100)]
[TASK] Update Fluid dependency to 2.5.2

This patch updates the Fluid dependency, to solve:

* Array keys now preserved when using reverse=1 on
   f:for - https://github.com/TYPO3/Fluid/commit/227a05a322bf584254544ef1c948d63e1af7bbd4
* TemplatePaths cache is made non-static -
   https://github.com/TYPO3/Fluid/commit/fa1b8aaeb957729478c958e495623dd7de1d14a1

Change-Id: Id10a80455f47300bfd29d734c83d9add87e17640
Releases: master, 8.7
Resolves: #84160
Reviewed-on: https://review.typo3.org/56031
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Avoid E_NOTICE reporting in ArrayUtility 29/56029/3
Ralf Zimmermann [Wed, 7 Mar 2018 08:29:11 +0000 (09:29 +0100)]
[BUGFIX] Avoid E_NOTICE reporting in ArrayUtility

In case of exception 1341397869, the dynamic exception message parts
must be converted to strings.

Releases: master, 8.7
Resolves: #84156
Change-Id: I3b86758495f9481a21691feaddd6000d484e2a5e
Reviewed-on: https://review.typo3.org/56029
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[FEATURE] Introduce an Environment API class 60/55960/6
Benni Mack [Thu, 1 Mar 2018 07:07:22 +0000 (08:07 +0100)]
[FEATURE] Introduce an Environment API class

A new class Environment is added, which is initialized right at the very
beginning of any TYPO3-based request.

The class contains a static list of properties commonly used throughout the
core to access paths, constants or global variables. The class also contains
methods that are relevant for ALL kind of PHP requests, CLI and web requests.

In order to avoid constants, and global variables, this is centralized in one
place, which allows to "re-define" values for testing purposes, making functional
tests a lot simpler.

This would better be stored in a dependency injection container and injected
as dependency/parameter into the respective classes that need the information.
We're not at that point to use dependency injection for every class, therefore
this class provides a static interface as a long-term interim solution.

Additionally, it adds a new functionality, basically finally allowing to move
code outside of the PATH_site constant with a proper API.

If the environment variable "TYPO3_PATH_APP" is set, this acts as a root path
for the project, which can be the same as PATH_site, or (usually) one level
up.
All typical new composer-based installations have this folder structure set up
automatically. Non-composer mode installations can set this environment variable
to make TYPO3 aware of non-public-accessable folders.

The following changes apply (with further patches):
- When TYPO3_PATH_APP is set, all logs / sessions / cache files are moved into $PROJECT_ROOT/var/.
- Same applies to typo3conf/l10n/, effectively moving this into a semi-writable
place, the same place where logs should be placed.
- LocalConfiguration.php, PackageStates.php and AdditionalConfiguration.php
  are now located at $PROJECT_ROOT/config/

The folder typo3conf then only contains code related to extensions.

The long-term goal until 9 LTS is that TYPO3 Core does not use any constants
anymore, which have been superseded by this class right now.

Resolves: #84153
Releases: master
Change-Id: I7ca35f752493d7e0d1c21c83a9ffbfb6a40eb463
Reviewed-on: https://review.typo3.org/55960
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
19 months ago[!!!][TASK] Remove language related JavaScript files 23/56023/5
Andreas Fernandez [Tue, 6 Mar 2018 14:15:54 +0000 (15:15 +0100)]
[!!!][TASK] Remove language related JavaScript files

The "language" extension has two JavaScript files left:

- Typo3Lang.js, was required for ExtJS, which has been removed
some time ago.
- Lang.js, is a RequireJS module that mimics the behavior of Typo3Lang.

As the desired functionality may be achieved with plain PHP, the module
is rendered obsolete and gets removed.

Resolves: #84148
Releases: master
Change-Id: Ice3df96195bb435da8df1004d1e9304ec7601d26
Reviewed-on: https://review.typo3.org/56023
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Migrate LiveSearch to TypeScript 99/55999/4
Andreas Fernandez [Sun, 4 Mar 2018 15:04:10 +0000 (16:04 +0100)]
[TASK] Migrate LiveSearch to TypeScript

Resolves: #82592
Releases: master
Change-Id: I1d07106cf79d552b62b4e9dedd61d4d1f7de007f
Reviewed-on: https://review.typo3.org/55999
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Call only clickOnLabel() in SVG based trees 27/56027/3
Andreas Fernandez [Tue, 6 Mar 2018 20:12:48 +0000 (21:12 +0100)]
[BUGFIX] Call only clickOnLabel() in SVG based trees

SVG based trees have a method called `clickOnLabel()`, which internally
calls `selectNode()` and also triggers a click event in `nodeBgEvents()`.

However, the latter two calls are repeated after `clickOnLabel()` is
called, causing issues like asking "Do you want to quit without saving?"
twice.

The calls are superfluous and are removed.

Resolves: #84152
Releases: master
Change-Id: Iabcb4ee5bfd0b7094cc52946f4e3be23f4372885
Reviewed-on: https://review.typo3.org/56027
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Tested-by: Paweł Rogowicz <rogowicz.pawel@gmail.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
19 months ago[BUGFIX] Avoid associative array to be used in LocalizationUtility 24/56024/2
Oliver Hader [Tue, 6 Mar 2018 15:17:46 +0000 (16:17 +0100)]
[BUGFIX] Avoid associative array to be used in LocalizationUtility

On using associative array in LocalizationUtility which is e.g. used
by Fluid's TranslateViewHelper, the error Cannot unpack array with
string keys is thrown. The reason is that sprintf($value, ...$arguments)
cannot be used with $arguments being an associative array.

Resolves: #84149
Releases: master
Change-Id: Ifb60338bcf9095954969221cf08bd7e3d141ecc2
Reviewed-on: https://review.typo3.org/56024
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
19 months ago[TASK] Use correct issue reference in allowLanguageSynchronization documentation 25/56025/3
Oliver Hader [Tue, 6 Mar 2018 15:42:51 +0000 (16:42 +0100)]
[TASK] Use correct issue reference in allowLanguageSynchronization documentation

Replace the Gerrit review ID by the related Forge ticket number.

Resolves: #84150
Releases: master, 8.7
Change-Id: I53fe0699e74949b4c64020a955294b3a1ef3f726
Reviewed-on: https://review.typo3.org/56025
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
19 months ago[BUGFIX] Upgrade Wizard must work also on records marked as deleted 39/52539/6
Christian Toffolo [Fri, 21 Apr 2017 05:36:58 +0000 (07:36 +0200)]
[BUGFIX] Upgrade Wizard must work also on records marked as deleted

Deleted records can be restored using the recycler, therefore the
wizards should check deleted records as well.

Resolves: #80836
Releases: master,8.7
Change-Id: I56a27c9dab4433c47c536edaa9649c5ebc73faad
Reviewed-on: https://review.typo3.org/52539
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[BUGFIX] RootlineUtility only resolves defined relation fields 15/56015/7
Benni Mack [Mon, 5 Mar 2018 18:49:50 +0000 (19:49 +0100)]
[BUGFIX] RootlineUtility only resolves defined relation fields

The RootlineUtility first selects all fields, which have been added
via the config option "addRootLineFields". After that, it iterates
over all(!) columns that are defined as relation.

The change modifies the loop so that only relations are resolved for
field pages.media (predefined) and those fields that have been added
to $GLOBALS[TYPO3_CONF_VARS][FE][addRootLineFields].

Resolves: #84144
Releases: master, 8.7
Change-Id: I3150f7cdd14aff3f25d5070f4ce190d510ba3614
Reviewed-on: https://review.typo3.org/56015
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
19 months ago[FEATURE] Add button to select all records 49/54849/18
Łukasz Uznański [Wed, 29 Nov 2017 09:37:15 +0000 (10:37 +0100)]
[FEATURE] Add button to select all records

Add and handle button to select all records from all pages in recycler.
Right now, there is pagination, which means that you can select 50 records max.

Resolves: #81310
Releases: master
Change-Id: Icfc0c93e5cff5cd9573a6a39b615ce0c6e1d273c
Reviewed-on: https://review.typo3.org/54849
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Steffen Frese <steffenf14@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
19 months ago[TASK] Remove unused folder tree view option 16/56016/5
Christian Kuhn [Mon, 5 Mar 2018 19:57:20 +0000 (20:57 +0100)]
[TASK] Remove unused folder tree view option

Option ext_noTempRecyclerDirs is circularily used
and always false. It can be removed without harm
and ext_isLinkable() deprecated along the way.

Resolves: #84145
Releases: master
Change-Id: Ibeb949ddb81c919087f894c2839e9bf88c6eb290
Reviewed-on: https://review.typo3.org/56016
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] bamboo: Hard kill php web server processes 13/56013/2
Christian Kuhn [Mon, 5 Mar 2018 15:39:40 +0000 (16:39 +0100)]
[TASK] bamboo: Hard kill php web server processes

bamboo acceptance test shut down sometimes fails to stop
the 'php -S' web server process for unknown reasons.
A next job on the same agent then fails to bind to the
port, leading to broken builds.
Switch from SIGTERM to SIGKILL during test shut down
to see if that improves the situation.

Resolves: #84143
Releases: master, 8.7
Change-Id: I838a2341f1f8e25fa461b8747337406391b52241
Reviewed-on: https://review.typo3.org/56013
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Set COMPOSER_ROOT_VERSION to 9.2.0@dev for bamboo 65/55965/2
Benjamin Franzke [Thu, 1 Mar 2018 10:45:24 +0000 (11:45 +0100)]
[TASK] Set COMPOSER_ROOT_VERSION to 9.2.0@dev for bamboo

If typo3/testing-framework needs to be synced with changes
in core it needs to require the dev branch of the upcoming
release as the compatibility to previous releases needs to
be dropped.
Therefore it has to define a dependency in composer.json like:
  "typo3/cms-core": "^9.2@dev"

If composer install is executed with COMPOSER_ROOT_VERSION
set to 9.1.0 that produces a conflict, therefore we raise
the version to 9.2.0@dev. That actually aligns the setting
with the branch alias (9.2.x-dev) set in composer.json.

Releases: master
Resolves: #84102
Change-Id: Ib9a6f1027cd738bcc1ecf00ef4e059ad179fc7c0
Reviewed-on: https://review.typo3.org/55965
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Do not reinitialize cache and package manager in clearAllCache 88/55988/3
Benjamin Franzke [Fri, 2 Mar 2018 13:01:11 +0000 (14:01 +0100)]
[TASK] Do not reinitialize cache and package manager in clearAllCache

Those (re)initializations originate from https://review.typo3.org/19605
were reinitializeClassLoaderAndCachesAndPackageManagement()
was used to "Reinitialize the class loader during clear cache actions"
(according to phpdoc).

Then with the changes in https://review.typo3.org/29811
reinitializeClassLoaderAndCachesAndPackageManagement()
was dropped and splitted into unregisterClassLoader(),
flagCachingFrameworkForReinitialization().
initializeCachingFramework() and initializePackageManagement().
(just historical info, still all good)

Then http://review.typo3.org/39827 came and dropped unregisterClassLoader
but left the CacheManager and PackageManager reinitialization in place
superfluously. It's superfluous as the original usecase was to
reinitialize the class loader which is no longer required.

Note: InstallTool uses the FailsafePackageManager, although it's called
failsafe it still loads _all_ packages defined in PackageStates.php
into $GLOBALS['TYPO3_LOADED_EXT'] and therefore there is no requirement
for a new PackageManager instance to load ext_localconf.php from all
active extensions.

Change-Id: I844b0e3d8a63e64437ac57a716646e4902256e89
Releases: master
Resolves: #84117
Reviewed-on: https://review.typo3.org/55988
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Synchronize RST files 10/56010/2
Christian Kuhn [Mon, 5 Mar 2018 12:39:09 +0000 (13:39 +0100)]
[TASK] Synchronize RST files

* Various .rst file index fixes, NotScanned usually does not make
  sense on Important- and Feature- files.
* Add a missing extension scanner config
* Sync 7* and 8* folders to other core branches

Resolves: #84141
Releases: master, 8.7, 7.6
Change-Id: Ifc19d774d45395cb30bd51f50d9121af409f48bb
Reviewed-on: https://review.typo3.org/56010
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Access trigger element in modal correctly 07/56007/2
Andreas Fernandez [Mon, 5 Mar 2018 08:20:02 +0000 (09:20 +0100)]
[BUGFIX] Access trigger element in modal correctly

$(this) does not work in TypeScript, as this is bound to the class or the
method, but never to the element. Thus, the target element is fetched
from the event.

Resolves: #84138
Releases: master
Change-Id: I05545d19f5cb10adc3678fa81d81e3b181047bc4
Reviewed-on: https://review.typo3.org/56007
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[!!!][TASK] Make language module part of install extension 98/55998/19
Christian Kuhn [Sat, 3 Mar 2018 13:33:14 +0000 (14:33 +0100)]
[!!!][TASK] Make language module part of install extension

The language module changes configuration files and basic
instance system files and thus belongs to the install extension.

The patch moves the "Admin Tools" -> "Language" module to
"Maintenance" -> "Manage language packs" and comes with a
series of advantages:
* UX improvements and better overview
* Overall language pack update progress is much quicker
* Just a fraction of code needed
* No dependency to extension manager anymore
* Documentation extension has no hidden dependency to lang anymore

Change-Id: Ibcb9659dfacb5fda7c00ab2f39160f095e0cd154
Resolves: #84131
Releases: master
Reviewed-on: https://review.typo3.org/55998
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Remove double encoding of upgrade wizard. 87/55987/4
Georg Ringer [Fri, 2 Mar 2018 12:35:13 +0000 (13:35 +0100)]
[BUGFIX] Remove double encoding of upgrade wizard.

Replace the <br>-Tags with a LF char and render the linebreak
using CSS.

Resolves: #83875
Releases: master
Change-Id: I4429d2929104f922d5f9c0e5c048617848e805e5
Reviewed-on: https://review.typo3.org/55987
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[TASK] Cleanup code imports for all workspaces classes 06/56006/2
Benni Mack [Mon, 5 Mar 2018 06:42:35 +0000 (07:42 +0100)]
[TASK] Cleanup code imports for all workspaces classes

The system extension workspaces was never touched in terms of
checking if actually methods are needed, and a lot of code still uses
FQDN instead of the "use" keyword for a PHP class.

Some unused dependencies (e.g. to Extbase's objectmanager) are
removed as well.

Resolves: #84136
Releases: master
Change-Id: Ifa71ce9dddb6d0e68e09ee969d217d1514105a1a
Reviewed-on: https://review.typo3.org/56006
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[BUGFIX] Allow multi-byte characters in live search 97/55997/2
Sven Burkert [Sat, 3 Mar 2018 23:12:40 +0000 (00:12 +0100)]
[BUGFIX] Allow multi-byte characters in live search

Resolves: #83539
Releases: master, 8.7
Change-Id: I4d589d0654ab7ee091b664957fbb8c6d101be663
Reviewed-on: https://review.typo3.org/55997
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[TASK] Migrate Toolbar/ShortcutMenu to TypeScript 04/56004/2
Andreas Fernandez [Sun, 4 Mar 2018 18:21:13 +0000 (19:21 +0100)]
[TASK] Migrate Toolbar/ShortcutMenu to TypeScript

Resolves: #84128
Releases: master
Change-Id: I1bb613a5662071ef1003ee030389527904c771fb
Reviewed-on: https://review.typo3.org/56004
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Localize preview boxes 08/55108/14
Stephan Großberndt [Sat, 16 Dec 2017 10:45:18 +0000 (11:45 +0100)]
[TASK] Localize preview boxes

* Make the box shown when previewing in Frontend either a hidden page or
  an unpublished version in a workspace use translated labels
* Add missing htmlspecialchars() calls
* Restore the link to stop the preview
* Use translation of LanguageService to use the language of the current
  backend user

Resolves: #83352
Releases: master
Change-Id: I4a00965d02e549f4953d0a9b891e2469a7ff9a64
Reviewed-on: https://review.typo3.org/55108
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Migrate ValueSlider to TypeScript 75/55975/2
Andreas Fernandez [Thu, 1 Mar 2018 18:24:37 +0000 (19:24 +0100)]
[TASK] Migrate ValueSlider to TypeScript

Change-Id: Ibb233ab281052eba4a5cab267130cd50269fd0b2
Resolves: #82610
Releases: master
Reviewed-on: https://review.typo3.org/55975
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Migrate Toolbar/SystemInformationMenu to TypeScript 03/56003/2
Andreas Fernandez [Sun, 4 Mar 2018 17:50:26 +0000 (18:50 +0100)]
[TASK] Migrate Toolbar/SystemInformationMenu to TypeScript

Resolves: #84129
Releases: master
Change-Id: Ifafd271ff12de3bfab1ff57fcf51d178ddac0a2a
Reviewed-on: https://review.typo3.org/56003
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Migrate Toolbar/ClearCacheMenu to TypeScript 02/56002/2
Andreas Fernandez [Sun, 4 Mar 2018 17:35:45 +0000 (18:35 +0100)]
[TASK] Migrate Toolbar/ClearCacheMenu to TypeScript

Resolves: #84127
Releases: master
Change-Id: I60ee74644a04354e6939aa8e5acc452004e1f582
Reviewed-on: https://review.typo3.org/56002
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Refactor AdminPanelView - remove module specifics 85/55985/5
Susanne Moog [Fri, 2 Mar 2018 09:21:17 +0000 (10:21 +0100)]
[TASK] Refactor AdminPanelView - remove module specifics

This is the second step in the AdminPanelView refactoring. It
extracts module specific code and uses a more generic API to
initialize, configure and display admin panel modules.

Resolves: #84118
Releases: master
Change-Id: I85a1e11dfd7d9397fabbfbd7d5cf658387056644
Reviewed-on: https://review.typo3.org/55985
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[FEATURE] Make position of sys notes configurable 76/55976/8
Georg Ringer [Thu, 1 Mar 2018 18:30:44 +0000 (19:30 +0100)]
[FEATURE] Make position of sys notes configurable

Add a new field "position" to allow editors to define where the
sys_note record is rendered.

Resolves: #83965
Releases: master
Change-Id: I22c6b5c66ce5ab58a112f844fd763a18788552f9
Reviewed-on: https://review.typo3.org/55976
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Guido Schmechel <littlegee@web.de>
Tested-by: Guido Schmechel <littlegee@web.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Have extractFileInformation extract atime only once 93/55993/5
Guido Schmechel [Sat, 3 Mar 2018 09:25:57 +0000 (10:25 +0100)]
[BUGFIX] Have extractFileInformation extract atime only once

Remove duplicate "atime" entry to prevent duplicate
call of "atime" property extraction.

Resolves: #83992
Releases: master, 8.7
Change-Id: I2e09bc07b12b07eb89bd6fb247d0fed4431c8ef6
Reviewed-on: https://review.typo3.org/55993
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
19 months ago[TASK] Remove comments that contain v4 or FLOW information 94/55994/2
Benjamin Franzke [Sat, 3 Mar 2018 11:08:04 +0000 (12:08 +0100)]
[TASK] Remove comments that contain v4 or FLOW information

Whether a class or functionality is not available or available
differently in v4 or FLOW is not relevant for TYPO3 CMS.
Remove them.

Occurrences have been searched using:
git grep "TYPO3 4"
git grep " v4"
git grep -l "FLOW" | grep php$

Change-Id: I1e690c2b8eee2af0ade831600ee9a3e1cfe6437a
Releases: master
Resolves: #84126
Reviewed-on: https://review.typo3.org/55994
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[FEATURE] Add absolute option to typolink VHs 90/55990/3
Benni Mack [Fri, 2 Mar 2018 15:36:44 +0000 (16:36 +0100)]
[FEATURE] Add absolute option to typolink VHs

In order to generate absolute URLs through the
Typolink ViewHelpers of TYPO3 Fluid, a new
fluid parameter "absolute" is added to the following
ViewHelpers.

* <f:link.typolink>
* <f:uri.typolink>

As typolink() is allowing this option, the generation
of absolute URLs behaves the same way as typolink()
itself does it.

Use it like this:

The ViewHelper code:
- <f:link.typolink parameter="23">Link To My Page</f:link.typolink>
generates:
- <a href="index.php?id=23">Link to My Page</a>

The ViewHelper code:
- <f:link.typolink parameter="23" absolute="true">Link To My Page</f:link.typolink>
generates:
- <a href="https://www.mydomain.com/index.php?id=23">Link to My Page</a>

The ViewHelper code:
- <f:uri.typolink parameter="23" />
generates:
- "index.php?id=23"

The ViewHelper code:
- <f:uri.typolink parameter="23" absolute="true" />
generates:
- "https://www.mydomain.com/index.php?id=23"

Resolves: #84120
Releases: master
Change-Id: I6b6df0ebc8a7c257ab854959e5425debd0cadd5e
Reviewed-on: https://review.typo3.org/55990
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[TASK] Remove unnecessary parentheses 91/55991/2
Frank Naegler [Fri, 2 Mar 2018 15:43:07 +0000 (16:43 +0100)]
[TASK] Remove unnecessary parentheses

The first patch https://review.typo3.org/#/c/55952/
missed two places because of a rebase issue.

Resolves: #84092
Releases: master
Change-Id: Ie646cdfdb4900a3a7b969b4745852f7c76139df5
Reviewed-on: https://review.typo3.org/55991
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
19 months ago[TASK] Add missing license headers to new PHP files 92/55992/2
Benni Mack [Fri, 2 Mar 2018 17:47:03 +0000 (18:47 +0100)]
[TASK] Add missing license headers to new PHP files

Resolves: #84121
Releases: master
Change-Id: Idf51b84880d56db4d54cbad2e556bccbcf888ba1
Reviewed-on: https://review.typo3.org/55992
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
19 months ago[TASK] Don't mark ConnectionPool::getConnectionByName() as internal 86/55986/4
Georg Ringer [Fri, 2 Mar 2018 12:18:22 +0000 (13:18 +0100)]
[TASK] Don't mark ConnectionPool::getConnectionByName() as internal

The method ConnectionPool::getConnectionByName() is no longer flagged
as internal as it is useful for extensions creating connections
to external databases.

Resolves: #84100
Releases: master, 8.7
Change-Id: I9bbf524905c436097264c465e92d8b689994c253
Reviewed-on: https://review.typo3.org/55986
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Use correct variables of sys_note records 84/55984/2
Georg Ringer [Fri, 2 Mar 2018 09:37:05 +0000 (10:37 +0100)]
[BUGFIX] Use correct variables of sys_note records

Since the removal of the models the field names of the database
must be used.

Resolves: #84113
Releases: master
Change-Id: I2d472b27455fdf37e418e9135dee81eeb8f125b0
Reviewed-on: https://review.typo3.org/55984
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Goerz <ervaude@gmail.com>
Tested-by: Daniel Goerz <ervaude@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Improve TranslateViewHelper compiling 83/55983/3
Mathias Brodala [Fri, 2 Mar 2018 08:21:42 +0000 (09:21 +0100)]
[TASK] Improve TranslateViewHelper compiling

Simplify string interpolation with positional arguments.

Resolves: #82454
Releases: master
Change-Id: If2bb56be5bba183ff5decbbb4a8f61eb01c61792
Reviewed-on: https://review.typo3.org/55983
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Remove unnecessary parentheses 52/55952/6
Wouter Wolters [Wed, 28 Feb 2018 20:34:17 +0000 (21:34 +0100)]
[TASK] Remove unnecessary parentheses

These parentheses are redundant and may be safely removed.

Resolves: #84092
Releases: master
Change-Id: I59f2b7454316ecd05f57d28e344f03a65d13e5c5
Reviewed-on: https://review.typo3.org/55952
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Add feature switch "unifiedPageTranslationHandling" 46/55446/8
Benni Mack [Wed, 24 Jan 2018 13:21:17 +0000 (14:21 +0100)]
[TASK] Add feature switch "unifiedPageTranslationHandling"

The feature switch "unifiedPageTranslationHandling" is active for all new
installations, but not active for existing installations.

It does the following when active:
- All DB schema migrations decide to drop "pages_language_overlay"
- TCA migration no longer throws a deprecation info (but still unsets "pages_language_overlay")

Once the Update Wizard for migrating pages_language_overlay records is done,
the feature is enabled.

Resolves: #83711
Releases: master
Change-Id: I478c8d5d745309889fa38b44b5eaab7226afdfc4
Reviewed-on: https://review.typo3.org/55446
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Improve LocalizationUtility logic and feedback 18/54118/6
Claus Due [Mon, 11 Sep 2017 14:43:19 +0000 (16:43 +0200)]
[TASK] Improve LocalizationUtility logic and feedback

This patch does two things to improve the translation
flow in LocalizationUtility::translate:

* Early return null on empty $key (would cause null anyway)
* Feedback message on failure to sprintf

In order to provide failure feedback for formatted
strings, vsprintf had to be replaced with sprintf and
array unrolling, since vsprintf does not return false
on errors and sprintf does. The error is returned as
translation result so even if an unexpected failure
occurs, at least a partially meaningful text is shown.

Change-Id: I568be30b701f0c374289ed44fc5b31b13f492483
Resolves: #82453
Releases: master
Reviewed-on: https://review.typo3.org/54118
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Improve TranslateViewHelper compiling 19/54119/9
Claus Due [Mon, 11 Sep 2017 15:03:37 +0000 (17:03 +0200)]
[TASK] Improve TranslateViewHelper compiling

This patch improves the TranslateViewHelper by letting
it be compiled to a single line of null-coalescing code
in the Fluidtemplate. Since the ViewHelper is one of the
most frequently used, saving method calls and condition
checks here gives a nice result.

Removes the need to load the VH class if all templates
are compiled, further saving some calls and checks.

Change-Id: Ifd3b051305d3cb631d3e8413bac40b4766136aef
Resolves: #82454
Releases: master
Reviewed-on: https://review.typo3.org/54119
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Add +repage option when cropping images 69/55269/3
Frans Saris [Thu, 4 Jan 2018 20:16:07 +0000 (21:16 +0100)]
[BUGFIX] Add +repage option when cropping images

To be sure the image (especialy gif format) is correctly repaged after
cropping it the +repage option needs to be added to the full command.

This patch adds the option for the LocalCropScaleMaskHelper and the
ImageBuilder cropscaling `crs` option.

Resolves: #83407
Releases: master, 8.7
Change-Id: I27b471d33acdc76c7af28ca0f114be72de91fcb9
Reviewed-on: https://review.typo3.org/55269
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Fix imagemagick commands when setting stripProfile to "0" 90/51990/5
Paul Golmann [Thu, 9 Mar 2017 11:12:50 +0000 (12:12 +0100)]
[BUGFIX] Fix imagemagick commands when setting stripProfile to "0"

Remove the ###SkipStripProfile### flag from command parameters added
by e.g. stripProfile in TypoScript if
GFX[processor_stripColorProfileByDefault] is disabled in global
configuration to prevent erroneous imagemagick commands.

Resolves: #80208
Releases: master, 8.7
Change-Id: I0860744ad4b27e44f1d9f7bb6da5dd646f4a1fc4
Reviewed-on: https://review.typo3.org/51990
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Properly append/prepend with "addRecord" wizard 26/55826/5
Mathias Brodala [Tue, 20 Feb 2018 14:47:59 +0000 (15:47 +0100)]
[BUGFIX] Properly append/prepend with "addRecord" wizard

For relations the internal field value contains a list of UIDs instead
of full related records.

Resolves: #82461
Releases: master, 8.7
Change-Id: Iec2a74fbc8d17636dd8751911984c337d4e99b63
Reviewed-on: https://review.typo3.org/55826
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Tested-by: Kevin Ditscheid <kevinditscheid@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Stop monkey patching CacheManager configuration in InstallTool 71/55971/2
Benjamin Franzke [Thu, 1 Mar 2018 15:51:27 +0000 (16:51 +0100)]
[TASK] Stop monkey patching CacheManager configuration in InstallTool

Instead of creating the cacheManager and then disabling all cache
confiurations afterwards, the desired state is enforced inside the
CacheManager now (controlled through a constructor parameter).

Releases: master
Resolves: #84107
Change-Id: Ia3623a96246d97b74ee48eb2022ba35d5bcfcc04
Reviewed-on: https://review.typo3.org/55971
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Put commit hooks into Build/git-hooks directory 12/55712/26
Sybille Peters [Wed, 14 Feb 2018 09:41:20 +0000 (10:41 +0100)]
[TASK] Put commit hooks into Build/git-hooks directory

* commit-msg hook: change wiki link to link to official contribution guide
* commit-msg hook: rebase with original source
* commit-msg hook: add Change-Id on last line after footer
* pre-commit hook: check if staged php files conform to coding guidelines
* Build/Scripts/cglFixMyCommit.sh: extended
  parameters to be used by new pre-commit hook

Resolves: #83891
Releases: master, 8.7, 7.6
Change-Id: I6d00aa32ef3f9517d88e90c40059c7f73d7f6cfe
Reviewed-on: https://review.typo3.org/55712
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Update typo3fluid/fluid to 2.5.1 56/55956/2
Markus Klein [Wed, 28 Feb 2018 22:04:45 +0000 (23:04 +0100)]
[TASK] Update typo3fluid/fluid to 2.5.1

- Allows any protocol or wrapper for template sources
- Ignores empty path specifications

composer command used:
composer update typo3fluid/fluid

Resolves: #84095
Releases: master, 8.7
Change-Id: I52380fe465b112df73ab86c570f6a12d2eedf4d3
Reviewed-on: https://review.typo3.org/55956
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Rename an 'important...rst' to 'Important...rst' 70/55970/2
Christian Kuhn [Thu, 1 Mar 2018 15:43:36 +0000 (16:43 +0100)]
[BUGFIX] Rename an 'important...rst' to 'Important...rst'

Change-Id: Iddf30ed9c58bf94fe24021fd5b08ef2aed366eec
Resolves: #84106
Related: #84086
Releases: master
Reviewed-on: https://review.typo3.org/55970
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Remove undocumented values from Soft Reference Index data 39/55939/2
Markus Klein [Wed, 28 Feb 2018 14:28:06 +0000 (15:28 +0100)]
[BUGFIX] Remove undocumented values from Soft Reference Index data

The fix for #80991 introduced new data in the data structure returned
by the SoftReferenceIndex class' methods.
This new data stems from LinkHandlers, which may provide arbitrary
data. This causes side effects for consumers of the SoftReferenceIndex
like the reference index and the export functionality.

By removing this extra data - which is not used anywhere at all - the
returned data is again conforming to what is documented and keeps
the interface to the SoftReferenceIndex clean.

Resolves: #84080
Releases: master, 8.7
Change-Id: Ic39a8b593cb239aca698e857d1ee602bdeaf229f
Reviewed-on: https://review.typo3.org/55939
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Move Page ID resolving to PSR-15 middleware 61/55961/6
Benni Mack [Thu, 1 Mar 2018 07:29:09 +0000 (08:29 +0100)]
[TASK] Move Page ID resolving to PSR-15 middleware

The next PSR-15 middleware is introduced that was previously part of the
Frontend Request Handler. It defines the actual (current) implementation
to determine the Page ID and GET/POST parameters handled in TSFE.

A possible alternative could be a Router doing the same process at this
very position currently.

Resolves: #84096
Releases: master
Change-Id: I6aa9b5f35183034a8ebb93258d085acafb93862a
Reviewed-on: https://review.typo3.org/55961
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Franzke <bfr@qbus.de>
Tested-by: Benjamin Franzke <bfr@qbus.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Fix linktype selection in Linkvalidator report 72/55872/5
Sybille Peters [Thu, 22 Feb 2018 13:46:42 +0000 (14:46 +0100)]
[BUGFIX] Fix linktype selection in Linkvalidator report

* handle uninitialized values
* do not show all results in report if no linktypes checked

Resolves: #84010
Releases: master, 8.7
Change-Id: Id04d2eed1b1390f2cbf67fd971d7cc4d61539f15
Reviewed-on: https://review.typo3.org/55872
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
19 months ago[TASK] Decouple SystemEnvironmentBuilder from Bootstrap 63/55963/6
Benjamin Franzke [Thu, 1 Mar 2018 10:04:43 +0000 (11:04 +0100)]
[TASK] Decouple SystemEnvironmentBuilder from Bootstrap

Do not rely on defined constants or methods from Bootstrap
to be usable on it own (later).
This is a preparatory refactoring to make the Application/Bootstrap
unaware of the entryPointLevel handling.

Releases: master
Resolves: #84099
Change-Id: Ia2b3b47062db87139e446c928faee75890ffec08
Reviewed-on: https://review.typo3.org/55963
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Make stateless Bootstrap methods static 75/55775/11
Benjamin Franzke [Sat, 17 Feb 2018 15:00:58 +0000 (16:00 +0100)]
[TASK] Make stateless Bootstrap methods static

Methods that do not use $this but mainly act as utility
may be used statically.
The previous non-static chainable behaviour is preserved
by returning static::$instance. (Invoking a static method
non statically does not trigger E_NOTICE or alike.)

The motivation for this change is to deprecate the
Bootstrap instanciated usage at some (later) point
in order to reduce global state.

The following methods are affected:
 * initializeLanguageObject
 * initializeBackendAuthentication
 * initializeBackendUser
 * initializeBackendRouter
 * loadExtTables
 * loadBaseTca
 * loadTypo3LoadedExtAndExtLocalconf
 * unsetReservedGlobalVariables
 * startOutputBuffering
 * disableCoreCache

Releases: master
Resolves: #83952
Change-Id: I59d3027c5d10326d7bab2ae02e6ff0eb836f23e4
Reviewed-on: https://review.typo3.org/55775
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[TASK] Use null comparison instead of is_null 50/55950/3
Wouter Wolters [Wed, 28 Feb 2018 20:25:50 +0000 (21:25 +0100)]
[TASK] Use null comparison instead of is_null

Resolves: #84091
Releases: master
Change-Id: I61c24937b919ec54c6547c07d1c4460186725c96
Reviewed-on: https://review.typo3.org/55950
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Remove implement statement if parent already implements the interface 55/55955/6
Wouter Wolters [Wed, 28 Feb 2018 20:46:37 +0000 (21:46 +0100)]
[TASK] Remove implement statement if parent already implements the interface

Resolves: #84094
Releases: master
Change-Id: I0fff99f75287fd5a43093b5df540cea040420d21
Reviewed-on: https://review.typo3.org/55955
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Remove unused use statements 49/55949/4
Wouter Wolters [Wed, 28 Feb 2018 20:05:50 +0000 (21:05 +0100)]
[TASK] Remove unused use statements

Resolves: #84090
Releases: master
Change-Id: Ia2a34856b3b8066906125d7efed593e9291f476c
Reviewed-on: https://review.typo3.org/55949
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[TASK] Migrate OnlineMedia to TypeScript 54/55954/3
Andreas Fernandez [Wed, 28 Feb 2018 20:40:03 +0000 (21:40 +0100)]
[TASK] Migrate OnlineMedia to TypeScript

Resolves: #82600
Releases: master
Change-Id: Ie7b86399f0a75706b1072a3c41e162ab2992a8b0
Reviewed-on: https://review.typo3.org/55954
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Migrate ContextMenuActions to TypeScript 74/55874/4
Andreas Fernandez [Fri, 23 Feb 2018 13:46:29 +0000 (14:46 +0100)]
[TASK] Migrate ContextMenuActions to TypeScript

Change-Id: If8a9b89295256491eb8bcc0e9afb1f37849050fc
Resolves: #82581
Releases: master
Reviewed-on: https://review.typo3.org/55874
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Migrate AjaxDataHandler to TypeScript 08/55908/3
Andreas Fernandez [Mon, 26 Feb 2018 19:11:24 +0000 (20:11 +0100)]
[TASK] Migrate AjaxDataHandler to TypeScript

Change-Id: I151598e90487811217dfa685dcb83081848f2bb6
Resolves: #82578
Releases: master
Reviewed-on: https://review.typo3.org/55908
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Clean up workspace preview top bar 31/55931/7
Benni Mack [Tue, 27 Feb 2018 20:11:20 +0000 (21:11 +0100)]
[TASK] Clean up workspace preview top bar

The preview controller is now not attached to the backend module anymore,
as the Preview functionality ("Split Bar on top") is technically a completely
separate backend preview and completely unrelated to the workspaces
Backend Module.

This change also removes several hacks to generate Backend URLs.

Resolves: #84074
Releases: master
Change-Id: Id0ce7093f6d3ac94c8e4a9cfecd78027d26d45df
Reviewed-on: https://review.typo3.org/55931
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
19 months ago[BUGFIX] Finalize rowDescription for sys_file_collection 53/55953/2
Josef Glatz [Wed, 28 Feb 2018 20:33:22 +0000 (21:33 +0100)]
[BUGFIX] Finalize rowDescription for sys_file_collection

Add missing TCA configuration for descriptionColumn in
sys_file_collection records. The database column already
exists in ext_tables.sql.

Change-Id: I696e982145604114181240bef321683569187bcd
Resolves: #84093
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55953
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[BUGFIX] Return correct query part in ContentObjectRenderer::searchWhere 14/55914/2
Georg Ringer [Tue, 27 Feb 2018 06:44:11 +0000 (07:44 +0100)]
[BUGFIX] Return correct query part in ContentObjectRenderer::searchWhere

Avoid using a prepared statement to return the final query part.

Resolves: #84022
Releases: master, 8.7
Change-Id: I31c44172221962c1dbb3d97d02f6cfa61449d20a
Reviewed-on: https://review.typo3.org/55914
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Sven Juergens <typo3@blue-side.de>
Tested-by: Sven Juergens <typo3@blue-side.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Add space in lockedRecords messages for translated languages 48/55948/3
Josef Glatz [Wed, 28 Feb 2018 19:03:55 +0000 (20:03 +0100)]
[BUGFIX] Add space in lockedRecords messages for translated languages

The space between the time amount and time unit must be
added directly in the code, as it's not possible to add a leading
space character in a localized string on our translation server.

- use GeneralUtility::trimExplode() for localized label parameter
- add space directly in the code instead of the LLL string

Already translated strings must not be adopted.

Change-Id: Iefeb1a4ed202a4110535fe62d13ce8691a10a80d
Resolves: #84088
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55948
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[TASK] Notification change for chrome is Important, not Breaking 45/55945/2
Christian Kuhn [Wed, 28 Feb 2018 16:30:34 +0000 (17:30 +0100)]
[TASK] Notification change for chrome is Important, not Breaking

Patch for issue #83971 is only an Important change, not
a breaking change and belongs to the 8.7.x documentation
folder to stay in sync with v8

Change-Id: I1314eda5dbf90af5e61b940ad1431b82bd28b0de
Resolves: #84086
Related: #83971
Releases: master
Reviewed-on: https://review.typo3.org/55945
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Consistently retrieve ApplicationContext from GeneralUtility 40/55940/4
Benjamin Franzke [Sun, 25 Feb 2018 12:34:58 +0000 (13:34 +0100)]
[TASK] Consistently retrieve ApplicationContext from GeneralUtility

As documented in Bootstrap code, GeneralUtility should be
used instead of Bootstrap to retrieve the ApplicationContext.

Therefore ClassLoadingInformation is adapted to read the
ApplicationContext from GeneralUtility. Bootstrap now pushes the
ApplicationContext early to GeneralUtility to be available for
ClassLoadingInformation during bootstrap.

Change-Id: I119ac944dd49c7d063b0f1e05f23e48f664ce2bc
Releases: master
Resolves: #84083
Reviewed-on: https://review.typo3.org/55940
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[!!!][BUGFIX] Allow browser notifications only on encrypted connection 16/55916/7
Frank Naegler [Tue, 27 Feb 2018 09:36:36 +0000 (10:36 +0100)]
[!!!][BUGFIX] Allow browser notifications only on encrypted connection

Google Chrome deprecated the browser notification API for unencrypted
origins. For this reason we now use an additional check to prevent
deprecation warnings in the console and disable this feature for
instances without SSL/TLS.

Resolves: #83971
Releases: master, 8.7
Change-Id: I9721842159e7ad3da9e5f4ee93a9bce3eaf5d0eb
Reviewed-on: https://review.typo3.org/55916
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Sascha Egerer <sascha@sascha-egerer.de>
Tested-by: Sascha Egerer <sascha@sascha-egerer.de>
Reviewed-by: Josef Glatz <josef.glatz@typo3.org>
Tested-by: Josef Glatz <josef.glatz@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Inject requestId into LogRecords 38/55938/3
Benjamin Franzke [Sun, 18 Feb 2018 20:11:21 +0000 (21:11 +0100)]
[TASK] Inject requestId into LogRecords

Do not use global state from Bootstrap::getInstance(), rather pass
the requestId from LogManager through the Logger to the LogRecord.

We do not have a core object container yet, therefore Bootstrap now
creates a LogManager, injects the requestId and stores that instance
as singleton in the GeneralUtility singleton storage.

Change-Id: Ia9af3c3a0e029a3748045fcf73e92f874f4a37ba
Releases: master
Resolves: #84082
Reviewed-on: https://review.typo3.org/55938
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[!!!][TASK] Remove request type specific code in Bootstrap 92/55692/8
Benjamin Franzke [Mon, 12 Feb 2018 18:00:56 +0000 (19:00 +0100)]
[!!!][TASK] Remove request type specific code in Bootstrap

As all request type specific initialization has been
refactored to the Application classes, request type
specific code in Bootstrap is unused [1] and can
be removed.

[1] redirectToInstallTool() is actually still in use, but moved
into the frontend and backend Application classes with this change.
(Also make their parent class abstract as drive-by change.)

Change-Id: Ieded3603c2936d83d3d4701abef6c3884b558e31
Releases: master
Resolves: #83869
Reviewed-on: https://review.typo3.org/55692
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Avoid renumbering array keys on writing configuration 36/55936/2
Helmut Hummel [Wed, 28 Feb 2018 12:41:49 +0000 (13:41 +0100)]
[BUGFIX] Avoid renumbering array keys on writing configuration

Renumbering array keys, even if all keys are integer
is a destructive operation.
Doing so at least breaks our logging configuration,
which uses LogLevel constants as array keys and these constants
are defined as integer.

Therefore this pure visual optimization is removed
when writing LocalConfiguration.php

At a later point we might consider deprecating this
method, which at least has a wrong method name
(mentions "numeric", while it meanwhile uses "int" checks).
As this method performs a destructive operation,
its usefulness is limited.

Resolves: #82304
Releases: master, 8.7, 7.6
Change-Id: I8d252428f3e27379e4377d30af0fdfd5e5d8719d
Reviewed-on: https://review.typo3.org/55936
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
19 months ago[TASK] Improve strictness of resource access blocking in _.htaccess 37/55937/3
Markus Klein [Wed, 28 Feb 2018 12:50:53 +0000 (13:50 +0100)]
[TASK] Improve strictness of resource access blocking in _.htaccess

For Apache HTTP versions 2.3+ there is a better way to avoid conflicts
in priority of sections. Since the `if` condition has been introduced
it is ranked the highest priority, hence it is most suitable for
rules to protect sensitive data.

Resolves: #81849
Releases: master, 8.7
Change-Id: I3f6edf1e3af55dc3ce901080045c8d353eb89ef9
Reviewed-on: https://review.typo3.org/55937
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[!!!][TASK] Migrate sys_notes away from extbase 04/55804/6
Georg Ringer [Mon, 19 Feb 2018 18:32:24 +0000 (19:32 +0100)]
[!!!][TASK] Migrate sys_notes away from extbase

Simplify the sys_note handling by removing extbase from it

Resolves: #84055
Releases: master
Change-Id: Ib41d5e88c7ec9d79ee23dc913c3dc1ee0184c372
Reviewed-on: https://review.typo3.org/55804
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
19 months ago[TASK] Log warning if a custom BE login image couldn't be resolved 11/55911/15
Tobias Kretschmann [Wed, 28 Feb 2018 11:11:36 +0000 (12:11 +0100)]
[TASK] Log warning if a custom BE login image couldn't be resolved

Log a warning message if the configured TYPO3 backend login
- logo or
- background image
can't get resolved.

Change-Id: I782a9b08650d9b2f9cfb3cefb9c4ba18577d5a7d
Resolves: #84050
Releases: master
Reviewed-on: https://review.typo3.org/55911
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[FEATURE] Provide VH to render icons for resources 59/55759/13
Georg Ringer [Fri, 16 Feb 2018 18:19:06 +0000 (19:19 +0100)]
[FEATURE] Provide VH to render icons for resources

Provide a ViewHelper to render the markup to show
an icon for files and folders.

Resolves: #83942
Releases: master
Change-Id: I44a99f3e06dc35b98b3e29f509432a8575c29807
Reviewed-on: https://review.typo3.org/55759
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
19 months ago[BUGFIX] Initiate correct storage of processed file during reconstitution 27/55927/3
Frans Saris [Tue, 27 Feb 2018 16:07:25 +0000 (17:07 +0100)]
[BUGFIX] Initiate correct storage of processed file during reconstitution

Releases: master, 8.7
Resolves: #84069
Change-Id: Idd642770341ddd5513c650e5ae230bcb5e7e6824
Reviewed-on: https://review.typo3.org/55927
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
19 months ago[BUGFIX] Make sure that mass actions actually process all changes 33/55933/6
Benedikt Huß [Wed, 28 Feb 2018 08:37:12 +0000 (09:37 +0100)]
[BUGFIX] Make sure that mass actions actually process all changes

Evaluate number of total items and trigger subsequent requests to
process the remaining items, so that all changes are actually
processed.

Resolves: #84037
Releases: master, 8.7
Change-Id: I92f388b50328320973abcc290de52083f05655dd
Reviewed-on: https://review.typo3.org/55933
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Stephan Großberndt <stephan.grossberndt@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Remove unused workspace_preview DB field 71/55871/7
Benni Mack [Fri, 23 Feb 2018 10:24:25 +0000 (11:24 +0100)]
[TASK] Remove unused workspace_preview DB field

The unused BE_USER method setWorkspacePreview()
updates a DB field called "workspace_preview_id" which just
does not exist at all. It would lead to an SQL error if called.

However, since this method is never called, nor evaluated since TYPO3 6.2,
all functionality should be removed. Previewing a workspace is handled
via `be_users.workspace_id` anyway.

Resolves: #84021
Releases: master
Change-Id: I706e893aef1faaccf6e43f0e66ac28bff79190d8
Reviewed-on: https://review.typo3.org/55871
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Migrate Viewport to TypeScript 94/55894/7
Andreas Fernandez [Sun, 25 Feb 2018 16:42:19 +0000 (17:42 +0100)]
[TASK] Migrate Viewport to TypeScript

Change-Id: Iafb5d62329d70704aac0dc73f8a6254e2745ffea
Resolves: #82611
Releases: master
Reviewed-on: https://review.typo3.org/55894
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Update jQuery 3.2.1 ❯ 3.3.1 21/55921/8
Frank Naegler [Tue, 27 Feb 2018 12:06:35 +0000 (13:06 +0100)]
[TASK] Update jQuery 3.2.1 ❯ 3.3.1

Needs a typo3/testing-framework raise, too.

Commands:
yarn upgrade jquery
composer update typo3/testing-framework

Updates:
- jquery@3.3.1

Resolves: #84063
Releases: master
Change-Id: Iec4e821ebeb42c46da7d379ea081f3c0f25cc112
Reviewed-on: https://review.typo3.org/55921
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[BUGFIX] Trigger 404 for subpage shortcuts w/o subpages 05/50805/6
Claus Due [Tue, 29 Nov 2016 13:41:30 +0000 (14:41 +0100)]
[BUGFIX] Trigger 404 for subpage shortcuts w/o subpages

This patch adds a try/catch around the call in TSFE to get
page and rootline with domain and makes getPageShortcut
function set $this->pageNotFound code, then throw error.

Change-Id: Id6aae04d7b4c2a8b267b0d949c056471c3a6b01b
Releases: master
Resolves: #78831
Reviewed-on: https://review.typo3.org/50805
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christer V <cvi@systime.dk>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Tobi Kretschmann <tobi@tobishome.de>
Tested-by: Tobi Kretschmann <tobi@tobishome.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
19 months ago[TASK] Upgrade grunt-contrib-uglify 2.0.0 ❯ 3.3.0 32/55932/4
Andreas Fernandez [Wed, 28 Feb 2018 06:48:52 +0000 (07:48 +0100)]
[TASK] Upgrade grunt-contrib-uglify 2.0.0 ❯ 3.3.0

Commands:
yarn upgrade grunt-contrib-uglify --latest

Upgrades:
uglify-js 2.7.5 > 3.3.12

Change-Id: I082a92d87ef1616488c0d8ddcf3801617a37eb50
Resolves: #84075
Releases: master
Reviewed-on: https://review.typo3.org/55932
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>