Packages/TYPO3.CMS.git
23 months ago[BUGFIX] Better error messages for FLUIDTEMPLATE object 73/37273/7
Georg Ringer [Wed, 20 Sep 2017 19:23:35 +0000 (21:23 +0200)]
[BUGFIX] Better error messages for FLUIDTEMPLATE object

When using FLUIDTEMPLATE with Typoscript "template.file = filename",
it will fail silently if filename does not point to a file.

Also check for template source when using Typoscript
"file = filename" in FLUIDTEMPLATE object.

Resolves: #65340
Releases: master
Change-Id: Id6aa148408cad14e49b65c0a9f4c7887cfb3fa16
Reviewed-on: https://review.typo3.org/37273
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[FOLLOWUP][BUGFIX] IRRE: Check if TCA['ctrl']['languageField'] is set 71/54171/11
Nicole Cordes [Tue, 19 Sep 2017 13:15:47 +0000 (15:15 +0200)]
[FOLLOWUP][BUGFIX] IRRE: Check if TCA['ctrl']['languageField'] is set

This patch adds missing functional tests for
\TYPO3\CMS\Backend\Controller\FormInlineAjaxController::createAction

Related: #82330
Releases: master, 8.7, 7.6
Change-Id: I61c8c07dd0d2c6a92bb445d7f2b6baee23251f5d
Reviewed-on: https://review.typo3.org/54171
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Context menu is not completely visible in filelist with scrollbar 90/54390/2
Gianluigi Martino [Fri, 13 Oct 2017 06:31:56 +0000 (08:31 +0200)]
[BUGFIX] Context menu is not completely visible in filelist with scrollbar

If the foldertree in filelist is to long, the rightclick context menu on
the bottom of the window is not completly visible. With this patch the
position of the menu is calculated based on the windows width and height
and so completly visible.

Resolves: #82732
Releases: master, 8.7
Change-Id: Ied9204371491059efda61143e9ca9c2f3c8a9b9d
Reviewed-on: https://review.typo3.org/54390
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Tested-by: Wittkiel Gruppe <ts@wittkiel-gruppe.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] cast systemMaintainer values to int 83/54383/3
Frank Naegler [Thu, 12 Oct 2017 17:35:10 +0000 (19:35 +0200)]
[BUGFIX] cast systemMaintainer values to int

Resolves: #82751
Releases: master
Change-Id: Ie87cccc2d890ffaf93fe8558f2a67da82ee8c495
Reviewed-on: https://review.typo3.org/54383
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] Resolve label in title attribute of ClearCacheToolbarItemSingle 82/54382/3
Loek Hilgersom [Thu, 12 Oct 2017 16:38:35 +0000 (18:38 +0200)]
[BUGFIX] Resolve label in title attribute of ClearCacheToolbarItemSingle

Resolves: #82749
Releases: master, 8.7
Change-Id: I1de1157ca8e28da3a9fd3ffb3783bb73b1f8e845
Reviewed-on: https://review.typo3.org/54382
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Clean up ext:lowlevel ConfigurationController 89/54389/2
Christian Kuhn [Thu, 12 Oct 2017 23:40:18 +0000 (01:40 +0200)]
[TASK] Clean up ext:lowlevel ConfigurationController

Modernize the code base of the lowlevel ConfigurationController:
* No more _GP usages
* Get rid of MOD_SETTINGS and friends
* Don't use BackendUtility::funcModule and other crude helpers
* Get and apply changes to be_user->uc directly
* Move last html pieces to view

Change-Id: I24af6c53b9c55c82e0e1fc1ee79de97768fd9b2c
Resolves: #82754
Releases: master
Reviewed-on: https://review.typo3.org/54389
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[TASK] Migrate EXT:backend Tabs.js to TypeScript 67/54367/3
Frank Naegler [Tue, 10 Oct 2017 22:18:45 +0000 (00:18 +0200)]
[TASK] Migrate EXT:backend Tabs.js to TypeScript

Resolves: #82604
Releases: master
Change-Id: I9b9ff38c635902f2713602955ad9a3d04734ec88
Reviewed-on: https://review.typo3.org/54367
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Use strict flag in signalslot dispatcher 72/54372/3
Georg Ringer [Thu, 12 Oct 2017 07:03:30 +0000 (09:03 +0200)]
[BUGFIX] Use strict flag in signalslot dispatcher

To avoid exceptions with complex structures, the strict flag
must be used in the in_array check.

Resolves: #82736
Releases: master, 8.7, 7.6
Change-Id: I3ecf859e3e3cc70ab40b10ef9052d46e8b486957
Reviewed-on: https://review.typo3.org/54372
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Configuration->"Use regular expression" 77/54377/2
Christian Kuhn [Thu, 12 Oct 2017 12:43:20 +0000 (14:43 +0200)]
[BUGFIX] Configuration->"Use regular expression"

Setting / unsetting the checkbox "Use regular expression"
fails with JavaScript error "jumpToUrl is not defined".
Add that to the document body.

Change-Id: I0a5928e008972493d070a35d1219a0acca579ce8
Resolves: #82746
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54377
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] Rename ext:lowlevel/View to ext:lowlevel/Controller 75/54375/2
Christian Kuhn [Thu, 12 Oct 2017 11:11:02 +0000 (13:11 +0200)]
[TASK] Rename ext:lowlevel/View to ext:lowlevel/Controller

The two "view" classes are clearly controllers and are
renamed with this patch accordingly.

Change-Id: Ic1cdc405ae24b87aa6224cda79b7226ce5eeec64
Resolves: #82744
Releases: master
Reviewed-on: https://review.typo3.org/54375
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[TASK] SchedulerModuleController: Don't extend BaseScriptClass 64/54364/4
Christian Kuhn [Tue, 10 Oct 2017 20:14:13 +0000 (22:14 +0200)]
[TASK] SchedulerModuleController: Don't extend BaseScriptClass

To further phase out BaseScriptTask "SOBE", the scheduler
controller class no longer extends it and copies left over
usages to itself.

A general cleanup is applied along with this patch:
* Hard code some general variables like "moduleName"
* Remove some duplicate class attributes
* Additional namespace usages

Change-Id: I937b66e0b59d65591547144763026dbbd2d6c5f0
Resolves: #82727
Releases: master
Reviewed-on: https://review.typo3.org/54364
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] ConfigurationView: Don't extend BaseScriptClass 65/54365/3
Christian Kuhn [Tue, 10 Oct 2017 20:43:53 +0000 (22:43 +0200)]
[TASK] ConfigurationView: Don't extend BaseScriptClass

To reduce BaseScriptClass "SOBE" usages, the lowlevel
controller "ConfigurationView" no longer extends this class
and inlines some of the detail methods into routing
target "mainAction".

Change-Id: Icc284f5a3b4f0f9d50482a9f8865b0d7d1c16f4f
Resolves: #82728
Releases: master
Reviewed-on: https://review.typo3.org/54365
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[TASK] DatabaseIntegrityView: Don't extend BaseScriptClass 66/54366/2
Christian Kuhn [Tue, 10 Oct 2017 21:18:15 +0000 (23:18 +0200)]
[TASK] DatabaseIntegrityView: Don't extend BaseScriptClass

To reduce BaseScriptClass "SOBE" usages, the lowlevel
controller "DatabaseIntegrityView" no longer extends this class
and inlines some of the detail methods into routing
target "mainAction".

Change-Id: I67b0bae5848607166d19988cb005c91301754413
Resolves: #82729
Releases: master
Reviewed-on: https://review.typo3.org/54366
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Properly detect record link dialog tab 69/54369/4
Stanislas Rolland [Wed, 11 Oct 2017 19:00:03 +0000 (15:00 -0400)]
[BUGFIX] Properly detect record link dialog tab

RecordLinkHandler->canHandleLink should check record identifier,
otherwise the element browser may open the wrong tab when multiple
record identifiers are configured.

Resolves: #82737
Releases: master, 8.7
Change-Id: Ie12c6d7484bdb51577dfe02a653e80fe1d7b63ea
Reviewed-on: https://review.typo3.org/54369
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[TASK] Deprecate ConfigurationForm 62/54362/5
Christian Kuhn [Tue, 10 Oct 2017 17:38:01 +0000 (19:38 +0200)]
[TASK] Deprecate ConfigurationForm

The call tree of the extension manager "configuration form"
ext_conf_template.txt parser is a mess:
The ext:extensionmanager ConfigurationUtility calls ext:core
ConfigurationForm which is a class that extends ExtendedTemplateService
which extends TemplateService. The "TypoScript" a-like parsing then uses
class TypoScriptParser. This compiles to a huge list of dependencies.

The patch compiles this mess down to a series of methods within
ConfigurationUtility directly, effectively adding needed parts
of TypoScriptParser and ConfigurationForm as protected methods.
The class ends up with way less direct and indirect dependencies.

The various detail parsing methods are still messy and hard to follow,
but rewriting the parser heart does not really make sense since the
ext_conf_template.txt format will bite the dust sooner or later anyway
and having all in one place is already much better than before.
So putting some days of energy into rewriting these specific parts
of the TypoScript parsing did not seem to be worth it, even if it in
the end could probably solved with 1/4 of code.

Class ConfigurationForm is deprecated but could also be removed
as breaking patch later if anyone wants to refactor the remaining
ExtendedTemplateService and TemplateService classes in v9.

Note this patch is an intermediate step before the ConfigurationUtility
class form ext:em is moved into the install tool.

Change-Id: I62d9fafb6444d954e17c980358e6367a83b033b8
Resolves: #82725
Releases: master
Reviewed-on: https://review.typo3.org/54362
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Update codemirror to 5.30 and drop codemirror-minified again 46/54346/4
Andreas Fernandez [Tue, 10 Oct 2017 06:17:59 +0000 (08:17 +0200)]
[TASK] Update codemirror to 5.30 and drop codemirror-minified again

The package `codemirror-minified` used as a drop-in replacement of
`codemirror` is not maintained well and is replaced with the original
package again. To still get the benefits of page loading speed, at least
the JavaScript files are compressed by our own toolchain now.

CSS can't get compressed now as the original copyright gets replaced by
our own "banner".

Resolves: #82713
Releases: master
Change-Id: Ic12a7e9e70c63f2c0ae322e470453fe056c99155
Reviewed-on: https://review.typo3.org/54346
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Record list: Fix condition for unlimited records 41/54341/4
Andreas Fernandez [Mon, 9 Oct 2017 13:36:31 +0000 (15:36 +0200)]
[BUGFIX] Record list: Fix condition for unlimited records

This patch fixes a condition that fails when a CSV export in the record
list is requested. The maximum limit of records is set, if `$iLimit` is
larger than 0 to avoid a `LIMIT 0` query.

Resolves: #82710
Related: #81651
Releases: master
Change-Id: I49779e4fa4b31e44d5457f90939e6f96a41e497b
Reviewed-on: https://review.typo3.org/54341
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Correct fixture for metadata in impexp functional tests 52/54352/3
Tymoteusz Motylewski [Tue, 10 Oct 2017 14:23:28 +0000 (16:23 +0200)]
[BUGFIX] Correct fixture for metadata in impexp functional tests

Resolves: #82726
Releases: master, 8.7
Change-Id: I779dbf4cdecf931cae4f2734f561aa1c9eab4efb
Reviewed-on: https://review.typo3.org/54352
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
23 months ago[BUGFIX] Avoid corrupted session when IP changes 47/54347/3
Markus Klein [Mon, 9 Oct 2017 11:45:41 +0000 (13:45 +0200)]
[BUGFIX] Avoid corrupted session when IP changes

If the IP of the client changes and is not within the
lockIP range anymore a new session is now created.

Resolves: #82490
Releases: master, 8.7
Change-Id: I7dc5033318fa9eb1efc929af126b38cc9840e964
Reviewed-on: https://review.typo3.org/54347
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Franz Holzinger <franz@ttproducts.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Set correct image dimensions in impexp fixture data 50/54350/2
Tymoteusz Motylewski [Tue, 10 Oct 2017 12:13:50 +0000 (14:13 +0200)]
[BUGFIX] Set correct image dimensions in impexp fixture data

Fixture data for functional tests in impexp contains correct height
for one image now.

Resolves: #82722
Releases: master, 8.7
Change-Id: I3fea831a5a030eb525fabe9bbb6e891a3a722fd7
Reviewed-on: https://review.typo3.org/54350
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[!!!][TASK] Workspaces: Always consider references 19/54319/5
Benni Mack [Sun, 8 Oct 2017 12:33:06 +0000 (14:33 +0200)]
[!!!][TASK] Workspaces: Always consider references

Previously, it was possible to disable the handling
of references / child-parent relations in workspaces
on publishing, due to legacy functionality this was
an option introduced back in v4.

The behaviour (option switch via TSconfig) was
enabled by default on all installations.

It automatically resolves dependencies
(= publishing dependencies in relations automatically),
having this option disabled could lead to side effects
in the past.

Resolves: #82701
Releases: master
Change-Id: I4f152fd337e4c405eaa0f1386601629a688a05d4
Reviewed-on: https://review.typo3.org/54319
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[BUGFIX] Only access FAL security checks when in Backend 15/54315/2
Benni Mack [Fri, 6 Oct 2017 15:34:52 +0000 (17:34 +0200)]
[BUGFIX] Only access FAL security checks when in Backend

The FAL security checks which adds additional checks for Backend Users
are currently placed within TYPO3_MODE === BE which applies to CLI as well.

In order to even use the FAL API via CLI, a user has to be authenticated (just for
browsing files). Therefore, the check needs to be handled via TYPO3_REQUEST_TYPE
which excludes symfony commands on CLI basis.

Additionally, the REQUEST TYPE checks are handled within the Slot and not
when to register the hook (see other cleanup patch as well).

Resolves: #82691
Releases: master, 8.7
Change-Id: I7b895a119a17ea166331eb1dbcb75e57fffbd388
Reviewed-on: https://review.typo3.org/54315
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[!!!][TASK] IRRE: Always consider "localizeChildrenAtParentLocalization" 26/54326/11
Benni Mack [Sun, 8 Oct 2017 15:59:23 +0000 (17:59 +0200)]
[!!!][TASK] IRRE: Always consider "localizeChildrenAtParentLocalization"

The TCA Inline behaviour option "localizeChildrenAtParentLocalization" is dropped.
This functionality is now always enabled.

A TCA migration wizard is removing the option.

On a side note, the removed functional tests when removing
"localizationMode=select" were re-added.

Resolves: #82709
Releases: master
Change-Id: Idad3443417bf08fc4c93fa6475079ac2fd779c1e
Reviewed-on: https://review.typo3.org/54326
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] Popup content element id on the right side of "Record selector" 40/54340/2
Gianluigi Martino [Mon, 9 Oct 2017 12:53:49 +0000 (14:53 +0200)]
[TASK] Popup content element id on the right side of "Record selector"

On the left side of the "Record selector" window a popup with the content
element id is showing hovering the content element icon. With this patch
it works also on the right lower side icons in the same window.

Resolves: #82708
Releases: master, 8.7
Change-Id: Ib091f61b13923d787e94cb93e85257c39978dbb5
Reviewed-on: https://review.typo3.org/54340
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Raphael Graf <graf@netvertising.ch>
Tested-by: Raphael Graf <graf@netvertising.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[TASK] Deprecate second argument of GeneralUtility::mkdir_deep() 23/54323/6
Benni Mack [Sun, 8 Oct 2017 13:16:10 +0000 (15:16 +0200)]
[TASK] Deprecate second argument of GeneralUtility::mkdir_deep()

The syntax is very confusing, and the second argument is not necessarily
needed - most of the TYPO3 Core code uses only the first argument.

In order to streamline the API the second method argument is deprecated
but still works as before.

Resolves: #82702
Releases: master
Change-Id: Ib2238ff90edf932f9410cf87c214e23d0a1c4826
Reviewed-on: https://review.typo3.org/54323
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[BUGFIX] Correct an always-true if statement in GeneralUtility::mkdir_deep 17/54317/3
Joshua Westerheide [Sat, 7 Oct 2017 18:45:53 +0000 (20:45 +0200)]
[BUGFIX] Correct an always-true if statement in GeneralUtility::mkdir_deep

Resolves: #82697
Releases: master, 8.7, 7.6
Change-Id: I64bf51d5efd0394f4d3269965820281cbaf2de90
Reviewed-on: https://review.typo3.org/54317
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Add title tag to anchor in Fluid Styled Content uploads 98/54298/2
Benni Mack [Thu, 5 Oct 2017 06:48:36 +0000 (08:48 +0200)]
[BUGFIX] Add title tag to anchor in Fluid Styled Content uploads

Resolves: #81990
Releases: master, 8.7
Change-Id: Id52849587f3ad438d65f48d01a8930a646829dd4
Reviewed-on: https://review.typo3.org/54298
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] Clean up unused option in Install Tool 24/54324/2
Benni Mack [Sun, 8 Oct 2017 13:17:07 +0000 (15:17 +0200)]
[TASK] Clean up unused option in Install Tool

This option was renamed and is set in init() of
GraphicalFunctions anyway, so the call can be
removed (and also, does not create a PHP notice).

Resolves: #82700
Releases: master, 8.7
Change-Id: Ib2328676eaf123755b97ae09fd070f6e82250c92
Reviewed-on: https://review.typo3.org/54324
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Clean up INSTALL.md 20/54320/2
Benni Mack [Sun, 8 Oct 2017 12:39:16 +0000 (14:39 +0200)]
[TASK] Clean up INSTALL.md

The document references files that do not exist anymore, also CONTRIBUTING.md
is missing.

* ChangeLog => gone
* GPL.txt => LICENSE.txt
* NEWS.txt => gone

Resolves: #82698
Releases: master, 8.7
Change-Id: Idb5890f789632a342d1d640febd4ac1b9fa7497b
Reviewed-on: https://review.typo3.org/54320
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] JS: Init SelectTreeElement after document.ready 10/54310/2
Anke Altintop [Tue, 19 Sep 2017 15:56:27 +0000 (17:56 +0200)]
[BUGFIX] JS: Init SelectTreeElement after document.ready

Add document.ready, so SelectTree is initialized even
with slow internet connection.

Resolves: #81891
Releases: master, 8.7
Change-Id: I5489d37821107310f99fbccffc00fd183e2e3786
Reviewed-on: https://review.typo3.org/54310
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[BUGFIX] Add support for t3:// syntax to FileCollector 50/54250/3
Jigal van Hemert [Sun, 1 Oct 2017 11:08:52 +0000 (13:08 +0200)]
[BUGFIX] Add support for t3:// syntax to FileCollector

FileCollector::addFilesFromFolder now supports the t3://folder URN as
identifier for a folder. This allows the FILES cObj and the
FilesProcessor data processing to use that syntax.

Resolves: #82627
Releases: master, 8.7
Change-Id: I31376169f5868c6f7c52cf2b6ca98fe41bb1e111
Reviewed-on: https://review.typo3.org/54250
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[!!!][TASK] Deprecate ext:backend class AbstractModule 12/54312/5
Christian Kuhn [Fri, 6 Oct 2017 13:58:43 +0000 (15:58 +0200)]
[!!!][TASK] Deprecate ext:backend class AbstractModule

The internal / experimental class ext:backend/Module/AbstractModule
doesn't do much useful stuff: It only instantiates ModuleTemplate
in it's constructor which forces all inheriting classes to call
parent::__construct(). The processRequest() method with its
dispatcher code is never used in core, but superseeded by routing
configuration via Configuration/Backend/Routes.php.

The patch removes given AbstractModule usages and markes the
class as deprecated. The patch is slightly breaking in cases
an extension extends AbstractWizardController and additionally
uses the initialized moduleTemplate property.

Change-Id: Iee36e1787a6dc2a1affb3625983ccb6450589481
Resolves: #82689
Releases: master
Reviewed-on: https://review.typo3.org/54312
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Fix handling of ClosureFinisher 13/54213/5
Andreas Fernandez [Mon, 25 Sep 2017 08:40:38 +0000 (10:40 +0200)]
[BUGFIX] Fix handling of ClosureFinisher

Check if the incoming optionValue is a closure and return early in such
case.

Resolves: #82550
Releases: master, 8.7
Change-Id: I0f6b12b8ed777906bfe7bc6849841b246e95bbd3
Reviewed-on: https://review.typo3.org/54213
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] Prevent go back by submit on enter 82/54282/3
Frank Naegler [Wed, 4 Oct 2017 09:06:25 +0000 (11:06 +0200)]
[BUGFIX] Prevent go back by submit on enter

The first button of type=submit is used by the browser if
the user hint <enter> in a form field. A form should only contains
one submit button, which is fixed now with this patch.

Resolves: #82668
Releases: master, 8.7
Change-Id: I43323dd89be67d18a2818faf11359151223458f1
Reviewed-on: https://review.typo3.org/54282
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] RSA encryption: Stop submit handling if requested 45/53845/3
Andreas Fernandez [Thu, 31 Aug 2017 13:41:56 +0000 (15:41 +0200)]
[BUGFIX] RSA encryption: Stop submit handling if requested

If the submit event of a form using RSA encryption has `cancelBubble` set
to true (e.g. by jQuery's stopPropagation()), any processing is stopped
to prevent submitting the form.

Resolves: #82259
Releases: master, 8.7
Change-Id: Idb357dd2043cccb899ad7fa3fa325f7d3c003e40
Reviewed-on: https://review.typo3.org/53845
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Do not GROUP BY alias in WorkspaceService 81/54281/2
Susanne Moog [Wed, 4 Oct 2017 07:39:28 +0000 (09:39 +0200)]
[BUGFIX] Do not GROUP BY alias in WorkspaceService

GROUP BY statements are in general evaluated before
SELECT statements. If a DBMS does not implement additional
logic to resolve aliases defined in SELECTS before grouping
the statement will fail. Currently both MSSQL as well as ORACLE
lack these additional implementations. To be safe we should
group by the non-aliased columns.

Change-Id: I04698b2c31fbe2b0907fd345fbbf5e84dcebf164
Resolves: #82664
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54281
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Split `Storage` module 40/54240/6
Andreas Fernandez [Fri, 29 Sep 2017 20:16:33 +0000 (22:16 +0200)]
[TASK] Split `Storage` module

The `Storage` RequireJS module is split into `Storage/Client` and
`Storage/Persistent`. The `Storage` module itself is marked as deprecated
and any occurrence is migrated to use the new modules.

Resolves: #82603
Releases: master
Change-Id: Ie4bbb2ac3c1801b15531f0b71e35507c8ed03f06
Reviewed-on: https://review.typo3.org/54240
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[FEATURE] Make thumbnail size in file list configurable 06/51306/7
Alexander Schnitzler [Fri, 13 Jan 2017 14:18:44 +0000 (15:18 +0100)]
[FEATURE] Make thumbnail size in file list configurable

The size of thumbnails of the file list is hard coded to
64x64 px which might not be optimal in some cases. Thus,
the size should be configurable via UserTS.

Releases: master
Resolves: #73357
Change-Id: Ibd3bd43e55231212a410ee56b375e9be5d4354d2
Reviewed-on: https://review.typo3.org/51306
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Add main admin to system maintainers during first install 99/54099/5
Simon Praetorius [Sun, 10 Sep 2017 11:41:59 +0000 (13:41 +0200)]
[TASK] Add main admin to system maintainers during first install

Resolves: #82439
Related: #82319
Releases: master
Change-Id: Ieabaf1e7a230ce82206ffea30efded9ba821d50f
Reviewed-on: https://review.typo3.org/54099
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[FOLLOWUP][TASK] Disable UnitTest run on travis 04/54304/2
Susanne Moog [Thu, 5 Oct 2017 17:30:10 +0000 (19:30 +0200)]
[FOLLOWUP][TASK] Disable UnitTest run on travis

As bamboo already runs pre- and past-merge tests on
all configured branches we don't need travis to run
tests anymore.

Change-Id: I0c9fd4c6da5eb2b9ff1fa72c3ef05e91d9aeee95
Resolves: #82685
Releases: master
Reviewed-on: https://review.typo3.org/54304
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[TASK] Add sonarcloud analysis to travis 03/54303/3
Susanne Moog [Thu, 5 Oct 2017 15:35:09 +0000 (17:35 +0200)]
[TASK] Add sonarcloud analysis to travis

Add sonar-project.properties as basic configuration
and add travis configuration for running sonar analyis
on the core.

Resolves: #82685
Releases: master
Change-Id: I6c2886068c81e15e92b3562cf4200f3e80ff59db
Reviewed-on: https://review.typo3.org/54303
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[!!!][TASK] Remove option to generate PNGs limited to 64 colors 77/54277/4
Benni Mack [Wed, 4 Oct 2017 05:17:10 +0000 (07:17 +0200)]
[!!!][TASK] Remove option to generate PNGs limited to 64 colors

The global configuration "png_truecolor" which ensured that generated PNG
images only have 64 colors (instead of the max colors) came from the transition
12 years ago to keep a small file size for PNG images.

The option was turned on for new installations and existing installations,
and if not explicitly disabled, generated true-color PNG images at any time.

The option did not have any effect for FAL-related image resizing at all.

In order to generate PNGs with a limited color-space, it is still possible to do so with
additional "reduceColors" option, as well as adding additional parameters to
ImageMagick when needed.

However, having a global option for this feature seems to be not practical these
days anymore.

Resolves: #82680
Releases: master
Change-Id: I3e00cc1c37a5ed8287dcf7cad49d2a2ab10730e6
Reviewed-on: https://review.typo3.org/54277
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[TASK] bamboo: Execute deprecated unit tests 02/54302/3
Christian Kuhn [Thu, 5 Oct 2017 12:36:53 +0000 (14:36 +0200)]
[TASK] bamboo: Execute deprecated unit tests

Add execution of the deprecated unit tests to bamboo.

Change-Id: I5b15448250f3158fde6dad3ec2c3f2681edb0b49
Resolves: #82684
Related: #82438
Releases: master
Reviewed-on: https://review.typo3.org/54302
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Acceptance tests: chromedriver directly 00/54300/5
Christian Kuhn [Thu, 5 Oct 2017 10:14:27 +0000 (12:14 +0200)]
[TASK] Acceptance tests: chromedriver directly

Use chromedriver directly in acceptance tests instead of
routing through selenium-server.

Change-Id: I229032b1b1ec1b0e6f5e4c2eb5435e3ff0ae95df
Resolves: #82683
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54300
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Streamline BackendUtility::getPagesTSconfig 52/54152/8
Alexander Schnitzler [Sun, 17 Sep 2017 11:02:15 +0000 (13:02 +0200)]
[TASK] Streamline BackendUtility::getPagesTSconfig

BackendUtility::getPagesTSconfig does accumulate the PageTS
of a page, parses and returns it. That is the main purpose of
that method. But there are 2 method arguments that change the
behavior of that method. When setting $returnPartArray to true,
the PageTS will be returned non parsed. When providing a custom
$rootLine, that rootline will be used and the result is not
cached.

1.) There is just one method call in the core that makes use
    of the argument $returnPartArray, thus, fetching the non
    parsed PageTS is made available through a separate method
    called getRawPagesTSconfig(). Using the argument
    $returnPartArray is deprecated and will be removed.

2.) Providing a custom rootline via the $rootline method is
    also deprecated and will be removed. The core does not have
    the need to fetch the PageTS for a made up rootline, thus
    people can use getRawPagesTSconfig() with a custom
    rootline in the future and then parse that PageTS
    themselves. That way the result of getPagesTSconfig can
    always be cached in the future.

Resolves: #82497
Releases: master
Change-Id: I764324072d962e89e37bf514fa405e3cd93d2783
Reviewed-on: https://review.typo3.org/54152
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] bamboo-specs: Upgrade to 6.1 94/54294/5
Christian Kuhn [Wed, 4 Oct 2017 21:02:31 +0000 (23:02 +0200)]
[TASK] bamboo-specs: Upgrade to 6.1

The 6.0 to 6.1 upgrade allows us to specifiy last missing
pieces via bamboo specs: mostly job cleanups, plugin
configuration and plan permissions.

Change-Id: If26aeb45b1109ba9797f3807087201033ea1f368
Resolves: #82679
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/54294
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[FOLLOWUP][TASK] Use native trigger_error and ErrorHandler for deprecations 97/54297/2
Benni Mack [Thu, 5 Oct 2017 06:14:22 +0000 (08:14 +0200)]
[FOLLOWUP][TASK] Use native trigger_error and ErrorHandler for deprecations

The patch added a superfluous switch/case entry which is unnecessary.

Resolves: #82438
Releases: master
Change-Id: Ib2ac2503fa3ccb8ce2605e95163a29062a71cb8a
Reviewed-on: https://review.typo3.org/54297
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Never load disabled domains in TSFE 74/54274/4
Markus Klein [Tue, 3 Oct 2017 16:18:26 +0000 (18:18 +0200)]
[BUGFIX] Never load disabled domains in TSFE

This fixes an inappropriate transformation of old enableFields
condition to doctrine.

This is a regression fix to #77400.

Resolves: #82661
Related: #77400
Releases: master, 8.7
Change-Id: Ic18c9e5f59b48f30651a988c5ec9d243c8b186e3
Reviewed-on: https://review.typo3.org/54274
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Johannes Kasberger <johannes.kasberger@reelworx.at>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] t3editor: Load TS located in rootline 42/54242/7
Andreas Fernandez [Fri, 29 Sep 2017 21:24:08 +0000 (23:24 +0200)]
[BUGFIX] t3editor: Load TS located in rootline

Adding 'pid' to the form, t3editor now loads the TypoScript
that is placed in any page of the current rootline.

Resolves: #82623
Releases: master
Change-Id: I9364bb4a60d475be52bbcc5079b4c3a6e9cb42ec
Reviewed-on: https://review.typo3.org/54242
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[TASK] Migrate lowlevel command for workspace cleanup 65/54265/7
Benni Mack [Mon, 2 Oct 2017 23:01:55 +0000 (01:01 +0200)]
[TASK] Migrate lowlevel command for workspace cleanup

The workspace-related CLI command is moved to EXT:workspaces.

This way, an unneeded "isLoaded" check gets removed - and the command
only makes sense with workspaces enabled.

Resolves: #82653
Releases: master
Change-Id: Ifb1f069d8222d86be637bd2d182536310a88db3c
Reviewed-on: https://review.typo3.org/54265
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[!!!][TASK] Use native trigger_error and ErrorHandler for deprecations 15/54015/30
Benni Mack [Fri, 8 Sep 2017 12:14:44 +0000 (14:14 +0200)]
[!!!][TASK] Use native trigger_error and ErrorHandler for deprecations

The native PHP way of triggering deprecations by a framework or
applications is done via
`trigger_error($deprecationMessage, E_USER_DEPRECATED)`.

Previously, TYPO3 used `GeneralUtility::deprecationLog()` and
similar methods to generate a custom deprecation log, however it's
more flexible to use native logging through TYPO3's ErrorHandler.

This solution centralizes the way to configure the place if and
how deprecation logs should be written to various log destinations.

This also changes the way how deprecated methods, arguments and classes
are handled.

The new way to deprecate code in TYPO3 is done via
`trigger_error()`, the @deprecated annotation within a method only
exists now for IDE support, but is not reflected anymore for the
logging message.
That's why the @deprecated annotation does not contain
a description anymore.

The methods
GeneralUtility::logDeprecatedFunction()
GeneralUtility::deprecationLog()
GeneralUtility::getDeprecationLogFileName()
GeneralUtility::logDeprecatedViewHelperAttribute()

are marked as deprecated from now on.

The configuration option $TYPO3_CONF_VARS[SYS][enableDeprecationLog]
is removed.

Deprecation messages can now be activated by adding
the E_USER_DEPRECATED constant to the respective values in

$TYPO3_CONF_VARS[SYS][errorHandlerErrors]
 (so exceptions are handled by the TYPO3 error handler)
$TYPO3_CONF_VARS[SYS][syslogErrorReporting]
 (so exceptions are put into GeneralUtility::sysLog)
$TYPO3_CONF_VARS[SYS][belogErrorReporting]
 (so exceptions are put into sys_log DB table)
$TYPO3_CONF_VARS[SYS][exceptionalErrors]
 (so exceptions are thrown on a deprecation)

Deprecations will still go into GeneralUtility::devLog(),
if deprecations are activated via the "errorHandlerErrors" option.

Tests which test explicitly for deprecated code is moved into
Tests/UnitDeprecated, to ensure that the deprecated code is not
throwing an exception.

Resolves: #82438
Releases: master
Change-Id: I6ef9a642d179001f0484c4c7678e0bec12284faf
Reviewed-on: https://review.typo3.org/54015
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] TCA deprecations in functional test fixture extensions 92/54292/3
Benni Mack [Fri, 8 Sep 2017 12:14:44 +0000 (14:14 +0200)]
[BUGFIX] TCA deprecations in functional test fixture extensions

Change-Id: I136ee199ca80a9bc749de4f93950f84a10148a00
Resolves: #82676
Related: #82438
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54292
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Remove E_USER_DEPRECATED from exceptional errors 91/54291/4
Benni Mack [Wed, 4 Oct 2017 15:00:45 +0000 (17:00 +0200)]
[TASK] Remove E_USER_DEPRECATED from exceptional errors

Production and default settings should not throw on
E_USER_DEPRECATED errors.

Resolves: #82675
Releases: master
Change-Id: I3ba75abd91f1d847717a10386ee0fa2dde9b8727
Reviewed-on: https://review.typo3.org/54291
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[!!!][TASK] Remove deprecated ensureClassLoadingInformationExists() 83/54283/6
Christian Kuhn [Wed, 4 Oct 2017 10:31:15 +0000 (12:31 +0200)]
[!!!][TASK] Remove deprecated ensureClassLoadingInformationExists()

Change-Id: I0f83233c25e73cfe6194d005cde320542e65464f
Resolves: #82674
Related: #80700
Releases: master
Reviewed-on: https://review.typo3.org/54283
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[TASK] Update typo3/testing-framework to 1.1.5 84/54284/3
Christian Kuhn [Wed, 4 Oct 2017 13:32:36 +0000 (15:32 +0200)]
[TASK] Update typo3/testing-framework to 1.1.5

Brings a patch to dump class loading information
in functional and acceptance tests.

Change-Id: Ib44918666875100426f624cee2426d460e01d32a
Resolves: #82673
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54284
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Correct route to workspace module 79/54279/3
Susanne Moog [Wed, 4 Oct 2017 07:32:31 +0000 (09:32 +0200)]
[BUGFIX] Correct route to workspace module

Use correct route for generating split preview links
in WorkspaceService

Change-Id: I5cf83c435278b9c83c31e829f28f72dc61410da2
Resolves: #82663
Releases: master
Reviewed-on: https://review.typo3.org/54279
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
23 months ago[!!!][TASK] Always use logging in authentication processes 53/54253/7
Benni Mack [Mon, 2 Oct 2017 05:28:51 +0000 (07:28 +0200)]
[!!!][TASK] Always use logging in authentication processes

There are several checks within AuthenticationService, AbstractUserAuthentication
and AbstractService which can be dropped now that the Logging API is fully
configurable.

The following options have no effect anymore:
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['writeDevLog']
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['writeDevLogBE']
$GLOBALS['TYPO3_CONF_VARS']['SC_OPTIONS']['t3lib/class.t3lib_userauth.php']['writeDevLogFE']
$GLOBALS['TYPO3_CONF_VARS']['SYS']['enable_DLOG']

The following public properties have no effect anymore and are removed:
* AbstractUserAuthentication->writeDevLog
* AbstractService->writeDevLog

Resolves: #82639
Relates: #52694
Releases: master
Change-Id: I01a1319bb4f34da03980ce04d8d30b6fe510eae2
Reviewed-on: https://review.typo3.org/54253
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[!!!][TASK] Remove inline localizationMode 96/52496/7
Christian Kuhn [Tue, 18 Apr 2017 22:04:13 +0000 (00:04 +0200)]
[!!!][TASK] Remove inline localizationMode

Drop the TCA inline releated localizationMode settings.
This one has been deprecated with v8 including an
automatic TCA migration.

Change-Id: Ibb73721b188368605dd3cd75a29d2b7a8986966e
Releases: master
Resolves: #82634
Related: #80700
Reviewed-on: https://review.typo3.org/52496
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
23 months ago[TASK] Cleanup inline JavaScript in Backend 54/54254/4
Benni Mack [Mon, 2 Oct 2017 07:39:01 +0000 (09:39 +0200)]
[TASK] Cleanup inline JavaScript in Backend

This patch removes the global "TS." JavaScript option, as well as
unused code in EditDocumentController, BackendController and
PreviewController.

Resolves: #82631
Releases: master
Change-Id: I5de0af0acbac798bc9a57875a0631766a8016fa8
Reviewed-on: https://review.typo3.org/54254
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Acceptance tests: chrome headless 72/54272/8
Christian Kuhn [Tue, 3 Oct 2017 12:13:55 +0000 (14:13 +0200)]
[TASK] Acceptance tests: chrome headless

Switch to chrome headless for acceptance tests. We
don't need xvfb and friends on bamboo anymore which
will be updated with another patch later.

Change-Id: Ieb78d3d198f7dd9dc882041d86b403099e0854c6
Resolves: #82659
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54272
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Update testing require-dev dependencies 70/54270/3
Christian Kuhn [Tue, 3 Oct 2017 10:54:42 +0000 (12:54 +0200)]
[TASK] Update testing require-dev dependencies

* se/selenium-server-standalone 3.4.0->3.5.3
* codeception/codeception 2.3.5->2.3.6
* enm1989/chromedriver 2.31->2.32

Minor additional change in one acceptance test to
stabilize that test a bit better.

Change-Id: Ic306d6bb04139097962219d6047ae6aa387a5c3c
Releases: master, 8.7
Resolves: #82656
Reviewed-on: https://review.typo3.org/54270
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Raise default jpg image quality to 85 67/54267/3
Benni Mack [Mon, 2 Oct 2017 23:28:20 +0000 (01:28 +0200)]
[TASK] Raise default jpg image quality to 85

DefaultConfiguration setting is 70 (default since 12 years), but the
FactoryConfiguration setting is set to "80" for new installations.

This change raises all image quality settings to "85" if not overridden
by any installation (= new installation in the last 10 years or not changed
via the install tool), as we don't have a big file size issue with JPGs anymore
and we don't have duplicates anymore
(due to FAL instead of uploads/pics/mypic_13.jpg) and the internet connections
got better.

Resolves: #82655
Releases: master
Change-Id: Ibcb38ece4038a414bfcae103463c727ed3cf65c0
Reviewed-on: https://review.typo3.org/54267
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[BUGFIX] Set content-length header to the end of output 68/54268/4
Benni Mack [Mon, 2 Oct 2017 23:34:02 +0000 (01:34 +0200)]
[BUGFIX] Set content-length header to the end of output

Resolves: #76100
Resolves: #65719
Releases: master, 8.7
Change-Id: I2e389dd6ecb497a164a457230f106a64373c1907
Reviewed-on: https://review.typo3.org/54268
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[TASK] Raise BE user session timeout to 8 hours 66/54266/2
Benni Mack [Mon, 2 Oct 2017 23:24:20 +0000 (01:24 +0200)]
[TASK] Raise BE user session timeout to 8 hours

The current limit of an inactive user of 1 hour is not practical for a regular
editor. Instead, a default value of 8 hours fits more to a current work day.

Resolves: #82654
Releases: master
Change-Id: I2b0911f72771ffee7bd76b14de055a8a8e3f280b
Reviewed-on: https://review.typo3.org/54266
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
23 months ago[TASK] Acceptance tests: Don't restart browser 62/54262/3
Christian Kuhn [Mon, 2 Oct 2017 21:12:41 +0000 (23:12 +0200)]
[TASK] Acceptance tests: Don't restart browser

To speed up acceptance tests a bit the browser is no
longer restarted between tests.

Change-Id: I03132905eed1dd6a4ccca137e0e8047b01aa6ca9
Resolves: #82652
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54262
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[FOLLOWUP][TASK] Remove migrated TYPO3_CONF_VARS/SYS/setDBinit 55/54255/4
Benni Mack [Mon, 2 Oct 2017 08:00:16 +0000 (10:00 +0200)]
[FOLLOWUP][TASK] Remove migrated TYPO3_CONF_VARS/SYS/setDBinit

This patch removes the obsolete "setDBinit" option which was migrated
in TYPO3 v8.

Resolves: #82421
Releases: master
Change-Id: I96477e4dd7e151bf74caeafa7bdc38a1cde2f484
Reviewed-on: https://review.typo3.org/54255
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[!!!][TASK] Cleanup global debug functions 56/54256/4
Benni Mack [Mon, 2 Oct 2017 08:10:28 +0000 (10:10 +0200)]
[!!!][TASK] Cleanup global debug functions

The global "xdebug()" function is removed, as it is a stub for "debug" nowadays.
This function exists since SVN days,  and no comment or change why this is
available.

Additionally, the global "debug()" function had 6 parameters - the last three
were not evaluated and thus, were removed.

Resolves: #82640
Releases: master
Change-Id: I3e583c06282842e3dcb14f4b68589fd706be2519
Reviewed-on: https://review.typo3.org/54256
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Stabilize flaky TimeTracker unit test 60/54260/2
Christian Kuhn [Mon, 2 Oct 2017 12:50:28 +0000 (14:50 +0200)]
[BUGFIX] Stabilize flaky TimeTracker unit test

The time tracker sometimes switches between two milliseconds
in its operation. Test a bit weaker to cope with that.

Change-Id: I20d58296749bf33b12ab2da72691ecf4853842eb
Resolves: #82635
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54260
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[!!!][TASK] Remove tce_db options "prErr" and "uPT" 44/54244/4
Benni Mack [Sat, 30 Sep 2017 20:15:52 +0000 (22:15 +0200)]
[!!!][TASK] Remove tce_db options "prErr" and "uPT"

The two GET/POST parameters "prErr" (Print Errors) and "uPT" (Update Pagetree)
are removed.

The GET/POST parameter "uPT" is there to explicitly request a refresh of
the page tree if visible on the next module load.

The GET/POST parameter "prErr" adds flash messages to the session queue
which should be a default behaviour anyway.

Please note that this only affects the SimpleDataHandlerController (BE module "tce_db") and no datahandler calls itself.

The first parameter of DataHandler->printLogErrorMessages() is removed
as it is unused.

Resolves: #82629
Releases: master
Change-Id: Ifc925e49b49f1537a65141810403a7758e0b448b
Reviewed-on: https://review.typo3.org/54244
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] CKEditor should not create uploads subfolder 58/54258/2
Benni Mack [Mon, 2 Oct 2017 08:43:11 +0000 (10:43 +0200)]
[BUGFIX] CKEditor should not create uploads subfolder

The system extension rte_ckeditor creates an upload folder which is always
empty and not in use by the extension or something else.

Resolves: #82633
Releases: master, 8.7
Change-Id: Ic4877a9cbdbb078e5a7745f609f81aeaa5c991c3
Reviewed-on: https://review.typo3.org/54258
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
23 months ago[!!!][TASK] Move EXT:info_pagetsconfig into EXT:info 32/53532/9
Georg Ringer [Sun, 16 Jul 2017 14:13:49 +0000 (16:13 +0200)]
[!!!][TASK] Move EXT:info_pagetsconfig into EXT:info

Migrate the extension info_pagetsconfig into the extension
info where also all other controllers are.

Resolves: #82505
Releases: master
Change-Id: I916d2ef6c00f6a5fa2cfca9c6b3f340aa4aefb44
Reviewed-on: https://review.typo3.org/53532
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Fix wrong matcher class name 57/54257/3
Benni Mack [Mon, 2 Oct 2017 08:33:27 +0000 (10:33 +0200)]
[BUGFIX] Fix wrong matcher class name

Resolves: #82632
Related: #82014
Releases: master
Change-Id: I987bdda0bdc5bc91c1422b7558bc220f516e79ea
Reviewed-on: https://review.typo3.org/54257
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
23 months ago[CLEANUP] Review comment of PageRepository::getPage() 78/52878/9
Elmar Hinz [Sat, 20 May 2017 14:09:58 +0000 (16:09 +0200)]
[CLEANUP] Review comment of PageRepository::getPage()

Note:

Type hints are not trivial to add to the signature. Although the
method always returns an array, there are unit tests that make use
of the assumption that the method is allowed to return null. Fixing
this goes beyond the goals of this ticket.

Releases: master, 8.7
Resolves: #81280
Change-Id: If47041fb6fc4835de879e9077b0359063083cbd2
Reviewed-on: https://review.typo3.org/52878
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[CLEANUP] Review comment of fetch_the_id 92/52892/7
Elmar Hinz [Sun, 21 May 2017 17:50:21 +0000 (19:50 +0200)]
[CLEANUP] Review comment of fetch_the_id

Change-Id: I590025affea93d84a616b92f9b51211448ec3280
Releases: master
Resolves: #81280
Reviewed-on: https://review.typo3.org/52892
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] EXT:form - open the ElementBrowser in modal window 15/54115/3
Ralf Zimmermann [Mon, 11 Sep 2017 11:50:23 +0000 (13:50 +0200)]
[BUGFIX] EXT:form - open the ElementBrowser in modal window

Migrate the JS ElementBrowser to the modal which was introduced with
issue #82427.

Resolves: #82443
Releases: master
Change-Id: Ib71a15a7ce9638de4eb423d896fefa47bfa15e96
Reviewed-on: https://review.typo3.org/54115
Reviewed-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[TASK] Merge EXT:cshmanual into EXT:documentation 80/53180/10
Georg Ringer [Fri, 9 Jun 2017 19:18:42 +0000 (21:18 +0200)]
[TASK] Merge EXT:cshmanual into EXT:documentation

To reduce the amount of system extensions the extension
cshmanual can be merged into EXT:documentation.

Resolves: #81574
Releases: master
Change-Id: I5cd728938ffd319f5c13bf0af4caeda48c08ee37
Reviewed-on: https://review.typo3.org/53180
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Bring RTE linkbrowser options back 81/53481/5
Frans Saris [Fri, 14 Jul 2017 18:57:32 +0000 (20:57 +0200)]
[BUGFIX] Bring RTE linkbrowser options back

The CKEditor link browser handled the configuration array still as a
TypoScript array with dots. But the parsed YAML config is a plain array
now.

This patch makes sure the BrowserLinkController handles this config like
a normal array. Further it fixes the missing JavaScript part to set the
link title based on selected css class.

Resolves: #81381
Releases: master, 8.7
Change-Id: Ie4749f820082e185208bf811aad7133bfc82d37a
Reviewed-on: https://review.typo3.org/53481
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Increase sequence if uid gets forced for PostgreSQL 19/51819/11
Manuel Selbach [Fri, 24 Feb 2017 09:03:54 +0000 (10:03 +0100)]
[BUGFIX] Increase sequence if uid gets forced for PostgreSQL

If a uid gets forcefully set during a insert into the database
MySQL will automatically update the auto_increment primary key.
Other databases might need post processing, i.e PostgreSQL as
it uses a sequence to generate auto increment uids. Sequences
do not get transparently updated on inserts.

Resolves: #79976
Releases: master, 8.7
Change-Id: I033deb63bf9bc2e072408885a534752573ba4c7c
Reviewed-on: https://review.typo3.org/51819
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
23 months ago[BUGFIX] Avoid unnecessary I/O in GeneralUtility::createVersionNumberedFilename() 21/54221/3
Faton Haliti [Wed, 27 Sep 2017 07:56:13 +0000 (09:56 +0200)]
[BUGFIX] Avoid unnecessary I/O in GeneralUtility::createVersionNumberedFilename()

With this commit we prevent to check for existence of file
when we don't need to, because mode is not either 'embed' or
'querystring'

Resolves: #82565
Releases: master, 8.7
Change-Id: I829b8e87d951a6f170bc03d8b7836f671b51bdf4
Reviewed-on: https://review.typo3.org/54221
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Anders Kostending <aha@systime.dk>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] Remove hardcoded check on typo3/sysext/ 30/54230/3
Benni Mack [Thu, 28 Sep 2017 14:53:28 +0000 (16:53 +0200)]
[TASK] Remove hardcoded check on typo3/sysext/

When running TYPO3 with custom components (subtree), the typo3/sysext/
directory is not always necessary, and the hardcoded check is obsolete.

Resolves: #82622
Releases: master, 8.7
Change-Id: I3e939c80fff30d82dd4eb624c2f4bc5db1696809
Reviewed-on: https://review.typo3.org/54230
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Handle empty string icon-overlay identifier 12/54212/4
Romain Canon [Sat, 23 Sep 2017 13:07:02 +0000 (15:07 +0200)]
[BUGFIX] Handle empty string icon-overlay identifier

An overlay identifier can be an empty string, for instance when the icon API is
called with the Fluid icon view helper:

```
<core:icon identifier="tx-my-icon"
           overlay="{f:if(condition: myCondition, then: 'my-overlay-icon')}" />
```

In the example below, if the condition `myCondition` is `false`, an empty string
is used for the overlay parameter.

---

Previously, an empty string as overlay identifier would lead to the basic "not
found icon" being used as overlay.

With this commit, the behaviour for an empty string will now be the same as when
 `null` is used.

---

Resolves: #82547
Releases: master, 8.7
Change-Id: I6fb8207f302873e0188d71a210485bbf8565eff9
Reviewed-on: https://review.typo3.org/54212
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Romain Canon <romain.hydrocanon@gmail.com>
Tested-by: Romain Canon <romain.hydrocanon@gmail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] Use HTML5 validation for Install Tool test email address 16/54216/6
Georg Ringer [Tue, 26 Sep 2017 05:56:23 +0000 (07:56 +0200)]
[TASK] Use HTML5 validation for Install Tool test email address

Let the browser do the validation for the test email address.

Resolves: #82562
Releases: master
Change-Id: I8932eab709cb89d669b8931872d7e1cbda4d0fb1
Reviewed-on: https://review.typo3.org/54216
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Fix handling of Storage.Client 29/54229/2
Andreas Fernandez [Thu, 28 Sep 2017 13:17:14 +0000 (15:17 +0200)]
[BUGFIX] Fix handling of Storage.Client

The "Storage" module gets the missing "unset" method to remove values
from localStorage. The "isset" method is fixed to determine whether
a value is really existing.

Resolves: #82613
Releases: master, 8.7
Change-Id: Icb4b862b380811a7ba7f897be3c4809b718d2810
Reviewed-on: https://review.typo3.org/54229
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[!!!][TASK] Remove RDCT redirect functionality 25/54225/5
Benni Mack [Thu, 28 Sep 2017 07:51:09 +0000 (09:51 +0200)]
[!!!][TASK] Remove RDCT redirect functionality

The very legacy RDCT code and the corresponding DB table
"cache_md5params" has been long superseeded and is be
completely moved into its own extension "RDCT" published
on GitHub https://github.com/FriendsOfTYPO3/rdct and in TER.

An upgrade wizard checks if the DB table is filled,
and then installs EXT:rdct.

Note #1: I decided to trigger the hard breaking way,
instead of deprecation as the whole logic (evalution,
static method call in GeneralUtility removed) is interconnected
and only makes sense if all places are there.

Note #2: This functionality has not been in use in the
TYPO3 Core since 4.x - at all, but is in place for
other extensions.

Resolves: #82572
Releases: master
Change-Id: I1514293500c385f7b8c1fff440cca3ab3845615b
Reviewed-on: https://review.typo3.org/54225
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] Update nikic/php-parser from v3.0.6 to v3.1.1 17/54217/3
Georg Ringer [Tue, 26 Sep 2017 07:49:30 +0000 (09:49 +0200)]
[TASK] Update nikic/php-parser from v3.0.6 to v3.1.1

Resolves: #82620
Releases: master
Change-Id: I50d8186fc84590e063bff5dabcf2e52ea4fb49a7
Reviewed-on: https://review.typo3.org/54217
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] EXT:form - explain initializeFormElement hook 34/54234/2
Ralf Zimmermann [Fri, 29 Sep 2017 11:32:16 +0000 (13:32 +0200)]
[TASK] EXT:form - explain initializeFormElement hook

Add more explanations about the initializeFormElement
hook into the docs.

Resolves: #82615
Releases: master, 8.7
Change-Id: I670625533f95b92a37f5536096eb2cc4211d33d9
Reviewed-on: https://review.typo3.org/54234
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[TASK] Flexform support for type:passthrough 91/47491/15
Frank Naegler [Fri, 1 Apr 2016 14:05:31 +0000 (16:05 +0200)]
[TASK] Flexform support for type:passthrough

Resolves: #20705
Releases: master
Change-Id: I3476f6945b645a3b906e49efbdeaa385411c50ea
Reviewed-on: https://review.typo3.org/47491
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Fix broken reload of save+preview links 18/54218/9
Frank Naegler [Tue, 26 Sep 2017 10:43:14 +0000 (12:43 +0200)]
[BUGFIX] Fix broken reload of save+preview links

Resolves: #82456
Related: #81250
Releases: master
Change-Id: Idab208c3273adbd5800edab51bd9ca7bbec19af8
Reviewed-on: https://review.typo3.org/54218
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
23 months ago[BUGFIX] Allows setting extended search per default 25/51925/7
Dominik Winkelbauer [Thu, 2 Mar 2017 10:12:04 +0000 (11:12 +0100)]
[BUGFIX] Allows setting extended search per default

Makes it possible to enable extended search per default.

Change-Id: I793faa6d7f325661c193bf4661bfd924a6cfb69a
Resolves: #80091
Releases: master,8.7
Reviewed-on: https://review.typo3.org/51925
Reviewed-by: Christian Futterlieb <christian@futterlieb.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Ignore missing folders from psr-4 definitions 07/54207/6
Helmut Hummel [Fri, 22 Sep 2017 12:16:49 +0000 (14:16 +0200)]
[BUGFIX] Ignore missing folders from psr-4 definitions

Even when generating an optimized class map for psr-4
classes, Composer gracefully ignores folders defined
in psr-4 autoload section, if they do not exist.

TYPO3 however fails with an exception.

Also change the logic to always generate a class map
for improved class loading performance. This happened
anyway already when calling the autoload generation twice.

Resolves: #82542
Releases: master, 8.7
Change-Id: I4c3ab8ff7affeba25313d93e40e35f78bb78492d
Reviewed-on: https://review.typo3.org/54207
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
23 months ago[BUGFIX] Add backend authentication to Extbase CommandController 22/54222/8
Wolfgang Klinger [Wed, 27 Sep 2017 08:09:42 +0000 (10:09 +0200)]
[BUGFIX] Add backend authentication to Extbase CommandController

Ensure backwards compatibility with existing Extbase CommandControllers
by making sure the _cli_ user is always authenticated, so e.g. calls to
the DataHandler do not require explicit authentication in the extensions
CommandController.

Resolves: #82566
Releases: master, 8.7
Change-Id: Ice9b039558b68050c08a53f1c50dc726ec657522
Reviewed-on: https://review.typo3.org/54222
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Stephan Großberndt <stephan@grossberndt.de>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Use localize command when translating page record 45/52945/6
Frans Saris [Fri, 26 May 2017 13:51:03 +0000 (15:51 +0200)]
[BUGFIX] Use localize command when translating page record

Currently, when using the dropdown to create a page translation within
the Page Module, DataHandler is called with just a simple "new" record
of type "pages_language_overlay".

However, a classic "localize" DataHandler command is more appropriate,
allowing to utilize several localization functionalities built in.

In order to achieve this, the option tags in the selector contain the full
URL to the DataHandler call, as well as the redirect to FormEngine (which
in turn redirects back to the current page module URL).

Resolves: #81345
Releases: master, 8.7
Change-Id: I740c2d1d11494963283bc14b1f534bd344d0764a
Reviewed-on: https://review.typo3.org/52945
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
23 months ago[CLEANUP] Remove invalid paths in PSR-4 section 11/54211/2
Georg Ringer [Fri, 22 Sep 2017 17:42:42 +0000 (19:42 +0200)]
[CLEANUP] Remove invalid paths in PSR-4 section

Remove not existing paths from root composer.json.
For 8.7 the path to context_help must be kept.

Resolves: #82546
Releases: master, 8.7
Change-Id: Iea32a481011d906ea7057072413e6ae01a2ce771
Reviewed-on: https://review.typo3.org/54211
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[BUGFIX] Do not ignore empty value in OptionViewHelper 22/54122/2
Raphael Graf [Mon, 11 Sep 2017 18:55:51 +0000 (20:55 +0200)]
[BUGFIX] Do not ignore empty value in OptionViewHelper

Resolves: #82457
Releases: master
Change-Id: I42a1fdb85e87db4601ceefdd52e0dd4f1722bd23
Reviewed-on: https://review.typo3.org/54122
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: David Hoeckele <hoeckele@netvertising.ch>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Sascha Rademacher <s.rademacher@neusta.de>
Tested-by: Sascha Rademacher <s.rademacher@neusta.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
23 months ago[TASK] Provide uid in ElementInformation popup 87/54187/3
Georg Ringer [Wed, 20 Sep 2017 18:39:19 +0000 (20:39 +0200)]
[TASK] Provide uid in ElementInformation popup

The uid of a record is an important information and should
be provided as well.

Resolves: #82526
Releases: master, 8.7
Change-Id: Ic44ca6a24e21c09ced78203ed4a73907906bf568
Reviewed-on: https://review.typo3.org/54187
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Sascha Rademacher <s.rademacher@neusta.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Disable install tool access in switch user mode 81/54181/6
Mona Muzaffar [Wed, 20 Sep 2017 11:45:09 +0000 (13:45 +0200)]
[BUGFIX] Disable install tool access in switch user mode

During switch user mode the install tool modules are never visible.

Resolves: #82517
Releases: master
Change-Id: Ie367cb7f0208a7414ada38d40f8cdd3ab287da52
Reviewed-on: https://review.typo3.org/54181
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Tested-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Sascha Rademacher <s.rademacher@neusta.de>
Tested-by: Sascha Rademacher <s.rademacher@neusta.de>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
23 months ago[!!!][TASK] Deprecate GeneralUtility::devLog() 59/24559/29
Markus Klein [Sun, 10 Sep 2017 01:15:09 +0000 (03:15 +0200)]
[!!!][TASK] Deprecate GeneralUtility::devLog()

The core now directly logs to the Logging API.

Resolves: #52694
Releases: master
Change-Id: Ia3c8f1c3608aff540a990e9078132b233bbedde6
Reviewed-on: https://review.typo3.org/24559
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
23 months ago[BUGFIX] Fix broken redis tests 95/54195/2
Frank Naegler [Thu, 21 Sep 2017 10:09:19 +0000 (12:09 +0200)]
[BUGFIX] Fix broken redis tests

Resolves: #82533
Releases: master, 8.7, 7.6
Change-Id: Ia47f604b9cb7fa53d3707e6150554709cbfdb763
Reviewed-on: https://review.typo3.org/54195
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
23 months ago[BUGFIX] Do not recalculate PIDs for every query in BE search 30/53930/4
Susanne Moog [Wed, 6 Sep 2017 13:21:08 +0000 (15:21 +0200)]
[BUGFIX] Do not recalculate PIDs for every query in BE search

The backend search "Show all" link recalculated allowed PIDs for
the current user for all search operations resulting in an
exponentially increasing amount of sql queries depending on the
number of pages in an installation.

As the list of allowed pages for the user does not change during
the request, it is enough to calculate it once.

Change-Id: I9262a5d8425d04cb4ff1e35b2c3cc0ec96b8fa53
Resolves: #82083
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53930
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
23 months ago[BUGFIX] MenuProcessor: Allow sub keys of `addQueryString` 83/54183/2
Andreas Fernandez [Wed, 20 Sep 2017 12:20:55 +0000 (14:20 +0200)]
[BUGFIX] MenuProcessor: Allow sub keys of `addQueryString`

THis patch allows sub keys of `addQueryString`, e.g. `exclude`.

Resolves: #82520
Releases: master, 8.7
Change-Id: I8a6b5f924292cf56326cd18d8bb9b7887d095288
Reviewed-on: https://review.typo3.org/54183
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>