Packages/TYPO3.CMS.git
13 months ago[BUGFIX] Use the real page id for doesPageHaveUnallowedTables check 72/54672/4
Wolfgang Klinger [Sat, 12 Aug 2017 18:53:00 +0000 (20:53 +0200)]
[BUGFIX] Use the real page id for doesPageHaveUnallowedTables check

In case of handling a translated page record, use the according
proper uid value of the containing page of default language.

Resolves: #82053
Releases: master, 8.7
Change-Id: I0d0b5a268f4b87ef44d892f046ef474624b18058
Reviewed-on: https://review.typo3.org/54672
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[BUGFIX] Remove trailing tab char on rst snippet 38/56038/3
Mathias Schreiber [Wed, 7 Mar 2018 17:16:59 +0000 (18:16 +0100)]
[BUGFIX] Remove trailing tab char on rst snippet

Resolves: #84166
Releases: 8.7
Change-Id: Iae8d1908d45304f8c5da09fe1beff079c44c9f12
Reviewed-on: https://review.typo3.org/56038
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Access element in Viewport cleanup correctly 37/56037/2
Andreas Fernandez [Wed, 7 Mar 2018 15:27:38 +0000 (16:27 +0100)]
[BUGFIX] Access element in Viewport cleanup correctly

Resolves: #84164
Releases: 8.7
Change-Id: I5b4efcd3abb1d7f516ac89ba0f37f6857de8e5ee
Reviewed-on: https://review.typo3.org/56037
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[TASK] Update Fluid dependency to 2.5.2 34/56034/2
Claus Due [Wed, 7 Mar 2018 12:01:51 +0000 (13:01 +0100)]
[TASK] Update Fluid dependency to 2.5.2

This patch updates the Fluid dependency, to solve:

* Array keys now preserved when using reverse=1 on
   f:for - https://github.com/TYPO3/Fluid/commit/227a05a322bf584254544ef1c948d63e1af7bbd4
* TemplatePaths cache is made non-static -
   https://github.com/TYPO3/Fluid/commit/fa1b8aaeb957729478c958e495623dd7de1d14a1

Change-Id: Id10a80455f47300bfd29d734c83d9add87e17640
Releases: master, 8.7
Resolves: #84160
Reviewed-on: https://review.typo3.org/56034
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Use correct issue reference in allowLanguageSynchronization documentation 26/56026/2
Oliver Hader [Tue, 6 Mar 2018 15:42:51 +0000 (16:42 +0100)]
[TASK] Use correct issue reference in allowLanguageSynchronization documentation

Replace the Gerrit review ID by the related Forge ticket number.

Resolves: #84150
Releases: master, 8.7
Change-Id: I53fe0699e74949b4c64020a955294b3a1ef3f726
Reviewed-on: https://review.typo3.org/56026
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[BUGFIX] Unset internal properties of processed file on delete 05/53505/4
Helmut Hummel [Mon, 20 Mar 2017 18:28:12 +0000 (19:28 +0100)]
[BUGFIX] Unset internal properties of processed file on delete

When a processed file is deleted because it needs reprocessing, set the
internal deleted property to true and unset its properties as well, as
they are stale anyway.

This is important as in the later processing it is checked whether the
current object is persisted (which it is not anymore) and an SQL update
is triggered, which then fails leading to another processing run in
subsequent requests.

When unsetting the internal properties a new row will be inserted
in the same request.

Resolves: #80359
Releases: 7.6, 8.7, master
Change-Id: I39eec59ed4ac071883ff97eab7018d1ede92fb95
Reviewed-on: https://review.typo3.org/53505
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
13 months ago[BUGFIX] RootlineUtility only resolves defined relation fields 19/56019/3
Benni Mack [Mon, 5 Mar 2018 18:49:50 +0000 (19:49 +0100)]
[BUGFIX] RootlineUtility only resolves defined relation fields

The RootlineUtility first selects all fields, which have been added
via the config option "addRootLineFields". After that, it iterates
over all(!) columns that are defined as relation.

The change modifies the loop so that only relations are resolved for
field pages.media (predefined) and those fields that have been added
to $GLOBALS[TYPO3_CONF_VARS][FE][addRootLineFields].

Resolves: #84144
Releases: master, 8.7
Change-Id: I3150f7cdd14aff3f25d5070f4ce190d510ba3614
Reviewed-on: https://review.typo3.org/56019
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
13 months ago[BUGIFX] MediaceExtractionUpdate in Install Tool always requiring an update 84/55884/4
Joshua Westerheide [Sat, 24 Feb 2018 10:30:06 +0000 (11:30 +0100)]
[BUGIFX] MediaceExtractionUpdate in Install Tool always requiring an update

Due to recent refactoring to use the Doctrine Query Builder the
`checkForUpdate()` method of MediaceExtractionUpdate broke.
`\Doctrine\DBAL\Driver\ResultStatement::fetchColumn` may return
a string depending on used db driver.

Fixes changes made by I77dd213b75acbb129954ccdcf70a3722bf1a6675.

Resolves: #84029
Releases: 8.7
Change-Id: I379de745a26dfb58d04429f13bbe5009f15fb659
Reviewed-on: https://review.typo3.org/55884
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] bamboo: Hard kill php web server processes 14/56014/2
Christian Kuhn [Mon, 5 Mar 2018 15:39:40 +0000 (16:39 +0100)]
[TASK] bamboo: Hard kill php web server processes

bamboo acceptance test shut down sometimes fails to stop
the 'php -S' web server process for unknown reasons.
A next job on the same agent then fails to bind to the
port, leading to broken builds.
Switch from SIGTERM to SIGKILL during test shut down
to see if that improves the situation.

Resolves: #84143
Releases: master, 8.7
Change-Id: I838a2341f1f8e25fa461b8747337406391b52241
Reviewed-on: https://review.typo3.org/56014
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Synchronize RST files 11/56011/2
Christian Kuhn [Mon, 5 Mar 2018 12:43:25 +0000 (13:43 +0100)]
[TASK] Synchronize RST files

* Various .rst file index fixes, NotScanned usually does not make
  sense on Important- and Feature- files.
* Add a missing extension scanner config
* Sync 7* and 8* folders to other core branches

Resolves: #84141
Releases: master, 8.7, 7.6
Change-Id: Ifc19d774d45395cb30bd51f50d9121af409f48bb
Reviewed-on: https://review.typo3.org/56011
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Allow multi-byte characters in live search 08/56008/2
Sven Burkert [Sat, 3 Mar 2018 23:12:40 +0000 (00:12 +0100)]
[BUGFIX] Allow multi-byte characters in live search

Resolves: #83539
Releases: master, 8.7
Change-Id: I4d589d0654ab7ee091b664957fbb8c6d101be663
Reviewed-on: https://review.typo3.org/56008
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Replace star icon properly after saving shortcut 05/56005/2
Andreas Fernandez [Sun, 4 Mar 2018 18:28:10 +0000 (19:28 +0100)]
[BUGFIX] Replace star icon properly after saving shortcut

Resolves: #84130
Releases: 8.7
Change-Id: If501bcf839a66d5eebe5432a959d207a1fede7e6
Reviewed-on: https://review.typo3.org/56005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Have extractFileInformation extract atime only once 95/55995/2
Guido Schmechel [Sat, 3 Mar 2018 09:25:57 +0000 (10:25 +0100)]
[BUGFIX] Have extractFileInformation extract atime only once

Remove duplicate "atime" entry to prevent duplicate
call of "atime" property extraction.

Resolves: #83992
Releases: master, 8.7
Change-Id: I2e09bc07b12b07eb89bd6fb247d0fed4431c8ef6
Reviewed-on: https://review.typo3.org/55995
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
13 months ago[TASK] Don't mark ConnectionPool::getConnectionByName() as internal 89/55989/2
Georg Ringer [Fri, 2 Mar 2018 12:18:22 +0000 (13:18 +0100)]
[TASK] Don't mark ConnectionPool::getConnectionByName() as internal

The method ConnectionPool::getConnectionByName() is no longer flagged
as internal as it is useful for extensions creating connections
to external databases.

Resolves: #84100
Releases: master, 8.7
Change-Id: I9bbf524905c436097264c465e92d8b689994c253
Reviewed-on: https://review.typo3.org/55989
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Add +repage option when cropping images 80/55980/2
Frans Saris [Thu, 4 Jan 2018 20:16:07 +0000 (21:16 +0100)]
[BUGFIX] Add +repage option when cropping images

To be sure the image (especialy gif format) is correctly repaged after
cropping it the +repage option needs to be added to the full command.

This patch adds the option for the LocalCropScaleMaskHelper and the
ImageBuilder cropscaling `crs` option.

Resolves: #83407
Releases: master, 8.7
Change-Id: I27b471d33acdc76c7af28ca0f114be72de91fcb9
Reviewed-on: https://review.typo3.org/55980
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Fix imagemagick commands when setting stripProfile to "0" 79/55979/2
Paul Golmann [Thu, 9 Mar 2017 11:12:50 +0000 (12:12 +0100)]
[BUGFIX] Fix imagemagick commands when setting stripProfile to "0"

Remove the ###SkipStripProfile### flag from command parameters added
by e.g. stripProfile in TypoScript if
GFX[processor_stripColorProfileByDefault] is disabled in global
configuration to prevent erroneous imagemagick commands.

Resolves: #80208
Releases: master, 8.7
Change-Id: I0860744ad4b27e44f1d9f7bb6da5dd646f4a1fc4
Reviewed-on: https://review.typo3.org/55979
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Properly append/prepend with "addRecord" wizard 78/55978/2
Mathias Brodala [Tue, 20 Feb 2018 14:47:59 +0000 (15:47 +0100)]
[BUGFIX] Properly append/prepend with "addRecord" wizard

For relations the internal field value contains a list of UIDs instead
of full related records.

Resolves: #82461
Releases: master, 8.7
Change-Id: Iec2a74fbc8d17636dd8751911984c337d4e99b63
Reviewed-on: https://review.typo3.org/55978
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Put commit hooks into Build/git-hooks directory 73/55973/2
Sybille Peters [Wed, 14 Feb 2018 09:41:20 +0000 (10:41 +0100)]
[TASK] Put commit hooks into Build/git-hooks directory

* commit-msg hook: change wiki link to link to official contribution guide
* commit-msg hook: rebase with original source
* commit-msg hook: add Change-Id on last line after footer
* pre-commit hook: check if staged php files conform to coding guidelines
* Build/Scripts/cglFixMyCommit.sh: extended
  parameters to be used by new pre-commit hook

Resolves: #83891
Releases: master, 8.7, 7.6
Change-Id: I6d00aa32ef3f9517d88e90c40059c7f73d7f6cfe
Reviewed-on: https://review.typo3.org/55973
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Update typo3fluid/fluid to 2.5.1 72/55972/2
Markus Klein [Wed, 28 Feb 2018 22:04:45 +0000 (23:04 +0100)]
[TASK] Update typo3fluid/fluid to 2.5.1

- Allows any protocol or wrapper for template sources
- Ignores empty path specifications

composer command used:
composer update typo3fluid/fluid

Resolves: #84095
Releases: master, 8.7
Change-Id: I52380fe465b112df73ab86c570f6a12d2eedf4d3
Reviewed-on: https://review.typo3.org/55972
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Remove undocumented values from Soft Reference Index data 69/55969/2
Markus Klein [Wed, 28 Feb 2018 14:28:06 +0000 (15:28 +0100)]
[BUGFIX] Remove undocumented values from Soft Reference Index data

The fix for #80991 introduced new data in the data structure returned
by the SoftReferenceIndex class' methods.
This new data stems from LinkHandlers, which may provide arbitrary
data. This causes side effects for consumers of the SoftReferenceIndex
like the reference index and the export functionality.

By removing this extra data - which is not used anywhere at all - the
returned data is again conforming to what is documented and keeps
the interface to the SoftReferenceIndex clean.

Resolves: #84080
Releases: master, 8.7
Change-Id: Ic39a8b593cb239aca698e857d1ee602bdeaf229f
Reviewed-on: https://review.typo3.org/55969
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Fix linktype selection in Linkvalidator report 66/55966/5
Sybille Peters [Thu, 22 Feb 2018 13:46:42 +0000 (14:46 +0100)]
[BUGFIX] Fix linktype selection in Linkvalidator report

* handle uninitialized values
* do not show all results in report if no linktypes checked

Resolves: #84010
Releases: master, 8.7
Change-Id: Id04d2eed1b1390f2cbf67fd971d7cc4d61539f15
Reviewed-on: https://review.typo3.org/55966
Reviewed-by: Sybille Peters <sypets@gmx.de>
Tested-by: Sybille Peters <sypets@gmx.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Respect "recursive" flag when restoring records in recycler 47/55947/2
Benjamin Kluge [Wed, 28 Feb 2018 19:00:29 +0000 (20:00 +0100)]
[BUGFIX] Respect "recursive" flag when restoring records in recycler

Resolves: #81214
Releases: master, 8.7
Change-Id: I45129dd0ff91fc339f520e8e5d9a65ece4a701a8
Reviewed-on: https://review.typo3.org/55947
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Finalize rowDescription for sys_file_collection 59/55959/2
Josef Glatz [Wed, 28 Feb 2018 20:33:22 +0000 (21:33 +0100)]
[BUGFIX] Finalize rowDescription for sys_file_collection

Add missing TCA configuration for descriptionColumn in
sys_file_collection records. The database column already
exists in ext_tables.sql.

Change-Id: I696e982145604114181240bef321683569187bcd
Resolves: #84093
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55959
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Return correct query part in ContentObjectRenderer::searchWhere 57/55957/2
Georg Ringer [Tue, 27 Feb 2018 06:44:11 +0000 (07:44 +0100)]
[BUGFIX] Return correct query part in ContentObjectRenderer::searchWhere

Avoid using a prepared statement to return the final query part.

Resolves: #84022
Releases: master, 8.7
Change-Id: I31c44172221962c1dbb3d97d02f6cfa61449d20a
Reviewed-on: https://review.typo3.org/55957
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Add space in lockedRecords messages for translated languages 51/55951/2
Josef Glatz [Wed, 28 Feb 2018 19:03:55 +0000 (20:03 +0100)]
[BUGFIX] Add space in lockedRecords messages for translated languages

The space between the time amount and time unit must be
added directly in the code, as it's not possible to add a leading
space character in a localized string on our translation server.

- use GeneralUtility::trimExplode() for localized label parameter
- add space directly in the code instead of the LLL string

Already translated strings must not be adopted.

Change-Id: Iefeb1a4ed202a4110535fe62d13ce8691a10a80d
Resolves: #84088
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55951
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Allow browser notifications only on encrypted connection 46/55946/2
Frank Naegler [Tue, 27 Feb 2018 09:36:36 +0000 (10:36 +0100)]
[BUGFIX] Allow browser notifications only on encrypted connection

Google Chrome deprecated the browser notification API for unencrypted
origins. For this reason we now use an additional check to prevent
deprecation warnings in the console and disable this feature for
instances without SSL/TLS.

Resolves: #83971
Releases: master, 8.7
Change-Id: I9721842159e7ad3da9e5f4ee93a9bce3eaf5d0eb
Reviewed-on: https://review.typo3.org/55946
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Improve strictness of resource access blocking in _.htaccess 42/55942/2
Markus Klein [Wed, 28 Feb 2018 12:50:53 +0000 (13:50 +0100)]
[TASK] Improve strictness of resource access blocking in _.htaccess

For Apache HTTP versions 2.3+ there is a better way to avoid conflicts
in priority of sections. Since the `if` condition has been introduced
it is ranked the highest priority, hence it is most suitable for
rules to protect sensitive data.

Resolves: #81849
Releases: master, 8.7
Change-Id: I3f6edf1e3af55dc3ce901080045c8d353eb89ef9
Reviewed-on: https://review.typo3.org/55942
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Avoid renumbering array keys on writing configuration 43/55943/2
Helmut Hummel [Wed, 28 Feb 2018 12:41:49 +0000 (13:41 +0100)]
[BUGFIX] Avoid renumbering array keys on writing configuration

Renumbering array keys, even if all keys are integer
is a destructive operation.
Doing so at least breaks our logging configuration,
which uses LogLevel constants as array keys and these constants
are defined as integer.

Therefore this pure visual optimization is removed
when writing LocalConfiguration.php

At a later point we might consider deprecating this
method, which at least has a wrong method name
(mentions "numeric", while it meanwhile uses "int" checks).
As this method performs a destructive operation,
its usefulness is limited.

Resolves: #82304
Releases: master, 8.7, 7.6
Change-Id: I8d252428f3e27379e4377d30af0fdfd5e5d8719d
Reviewed-on: https://review.typo3.org/55943
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Initiate correct storage of processed file during reconstitution 35/55935/2
Frans Saris [Tue, 27 Feb 2018 16:07:25 +0000 (17:07 +0100)]
[BUGFIX] Initiate correct storage of processed file during reconstitution

Releases: master, 8.7
Resolves: #84069
Change-Id: Idd642770341ddd5513c650e5ae230bcb5e7e6824
Reviewed-on: https://review.typo3.org/55935
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Make sure that mass actions actually process all changes 96/55896/3
Benedikt Huß [Wed, 28 Feb 2018 08:37:12 +0000 (09:37 +0100)]
[BUGFIX] Make sure that mass actions actually process all changes

Evaluate number of total items and trigger subsequent requests to
process the remaining items, so that all changes are actually
processed.

Resolves: #84037
Releases: master, 8.7
Change-Id: I92f388b50328320973abcc290de52083f05655dd
Reviewed-on: https://review.typo3.org/55896
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Avoid PHP warnings within DatePickerViewHelper 34/55934/2
Ralf Zimmermann [Tue, 27 Feb 2018 13:47:58 +0000 (14:47 +0100)]
[BUGFIX] Avoid PHP warnings within DatePickerViewHelper

Avoid PHP warnings within ext:form DatePickerViewHelper if the property
properties.additionalAttributes.placeholder is not defined within
the form definition.

Releases: master, 8.7
Resolves: #84065
Change-Id: I49e0bb3a9548f0be402e1a4794c60c1b42744fac
Reviewed-on: https://review.typo3.org/55934
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Correctly handle identical arrays in arrayDiffAssocRecursive 24/55924/2
Markus Klein [Tue, 27 Feb 2018 14:57:58 +0000 (15:57 +0100)]
[BUGFIX] Correctly handle identical arrays in arrayDiffAssocRecursive

Add a new test to make sure that identical input arrays also deliver
an empty result as difference.

Resolves: #84067
Releases: master, 8.7, 7.6
Change-Id: Ia16ca9560094c4ae42eb69cac9e09cd4bef7dc4e
Reviewed-on: https://review.typo3.org/55924
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
13 months ago[BUGFIX] Show error message when hiding page from context menu 03/55903/2
Tymoteusz Motylewski [Mon, 26 Feb 2018 12:51:58 +0000 (13:51 +0100)]
[BUGFIX] Show error message when hiding page from context menu

Renamed key in the response to match what is expected
in actions.js evaluateResponse method.

Releases: 8.7, 7.6
Resolves: #82282
Change-Id: I4528963aded3a8203ab144c8353fc0509aa8a1e7
Reviewed-on: https://review.typo3.org/55903
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Update readme copyright date to 2018 97/55897/3
Guido Schmechel [Sat, 24 Feb 2018 08:35:34 +0000 (09:35 +0100)]
[TASK] Update readme copyright date to 2018

Releases: master, 8.7, 7.6
Resolves: #84028
Change-Id: Ia6094c57c976ecf6e89b1d99aca0a1b12684e0b2
Reviewed-on: https://review.typo3.org/55897
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Use Icon API for date picker icons 79/55879/2
Frank Naegler [Fri, 23 Feb 2018 13:45:48 +0000 (14:45 +0100)]
[BUGFIX] Use Icon API for date picker icons

In the scheduler edit task view, a FontAwesome icon for the
date picker was used. This patch uses the IconViewHelper to
use the same icon as everywhere in the backend.

Resolves: #84024
Releases: master, 8.7
Change-Id: Ie1e8846ba8e3fc2eee4134cd2d97b43345b3c0e6
Reviewed-on: https://review.typo3.org/55879
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Show workspace preview text again 93/55893/2
Benni Mack [Sat, 24 Feb 2018 10:24:57 +0000 (11:24 +0100)]
[BUGFIX] Show workspace preview text again

Due to refactorings in various places, a simple copy/paste
mistake was done when showing the preview text of a
workspace. Due to the bug, previewing a workspace
only showed "PREVIEW", instead of "Preview of Workspace
XYZ" and the logout button.

Resolves: #84030
Related: #38735
Related: #83158
Releases: master, 8.7
Change-Id: Id4dacd7e5608d75ad52216729011a5234f57fb7a
Reviewed-on: https://review.typo3.org/55893
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
13 months ago[BUGFIX] Append pageId variable to string properly 73/55873/2
Andreas Fernandez [Fri, 23 Feb 2018 13:29:48 +0000 (14:29 +0100)]
[BUGFIX] Append pageId variable to string properly

Resolves: #84023
Releases: 8.7
Change-Id: I15c717b3087d18151a2a696e608ede481f7543f2
Reviewed-on: https://review.typo3.org/55873
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[TASK] Add data attributes in backend toolbar and menu components 76/55876/2
Thomas Deuling [Mon, 27 Mar 2017 20:18:44 +0000 (22:18 +0200)]
[TASK] Add data attributes in backend toolbar and menu components

Add data attributes in backend toolbar and backend menu components,
to have general identifier for binding guided tours popover and
more features that can be based on this.

Resolves: #80500
Releases: master, 8.7
Change-Id: I2add8b8c28ecd37967b7b23f71392aa71f209da5
Reviewed-on: https://review.typo3.org/55876
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Fix timestamp handling in QueryGenerator 77/55877/2
Reiner Teubner [Fri, 2 Feb 2018 13:55:36 +0000 (14:55 +0100)]
[BUGFIX] Fix timestamp handling in QueryGenerator

Since https://review.typo3.org/c/51242/ all hidden
FormEngine fields work with ISO dates but the
QueryGenerator can only handle unix timestamp.
This patch fix the query building process for
timestamp record fields.

Resolves: #83675
Releases: master, 8.7
Change-Id: I79227762c4159984612d86dea640bdfd8b3a2784
Reviewed-on: https://review.typo3.org/55877
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] Hide readonly elements in summary page and emails 37/55837/5
Ralf Zimmermann [Wed, 13 Sep 2017 10:51:37 +0000 (12:51 +0200)]
[BUGFIX] Hide readonly elements in summary page and emails

Hide readonly form elements within the summary page and emails.

Resolves: #82471
Releases: master, 8.7
Change-Id: I9c42754c935c0b2c62ff1a70f43e7a13d3594f82
Reviewed-on: https://review.typo3.org/55837
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Tested-by: Ralf Zimmermann <ralf.zimmermann@tritum.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[BUGFIX] Don't download language packs of not loaded extensions 63/55863/2
Christian Kuhn [Wed, 21 Feb 2018 23:05:49 +0000 (00:05 +0100)]
[BUGFIX] Don't download language packs of not loaded extensions

The backend language module struggles with downloading
language packs of existing, but not loaded extensions
and fetchess old (non core version specific) packs
for core extensions.
This is hard to solve on a bugfix level for v7 and v8,
and in general it does not make much sense to have
language packs of not loaded extensions lying around
in typo3conf/l10n.
The patch ignores fetching of language packs for
not loaded extensions, it easily applies to all
maintained core versions.

Change-Id: I9ad885012a572368f7946f1027d870ee09550034
Resolves: #83406
Releases: master, 8.7, 7.6
Reviewed-on: https://review.typo3.org/55863
Reviewed-by: Michael Stucki <michael.stucki@typo3.org>
Tested-by: Michael Stucki <michael.stucki@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Snychronize form framework documentation 61/55861/2
Björn Jacob [Thu, 22 Feb 2018 08:28:07 +0000 (09:28 +0100)]
[TASK] Snychronize form framework documentation

This patch synchronizes the documentation of the form framework
for TYPO3 v8.

Resolves: #83967
Releases: 8.7
Change-Id: I71770385f951b7c84ab54e19aecb246b71ba4ea3
Reviewed-on: https://review.typo3.org/55861
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Rename /prototypes to /proto of form docs 51/55851/3
Björn Jacob [Wed, 21 Feb 2018 08:10:20 +0000 (09:10 +0100)]
[TASK] Rename /prototypes to /proto of form docs

The folder /prototypes of the form documentation is renamed to /proto.
This is a first step to synchronize the documentation of TYPO3 v8 and v9.

Resolves: #83988
Releases: 8.7
Change-Id: I6fa329a2d0971c89ef2c1416f07ff3fb284d30ef
Reviewed-on: https://review.typo3.org/55851
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Use sys_file as soft reference for formDefinitions 43/55843/2
Ralf Zimmermann [Tue, 20 Feb 2018 15:55:03 +0000 (16:55 +0100)]
[BUGFIX] Use sys_file as soft reference for formDefinitions

Register an embedded form definition as sys_file soft reference to show
the usage of the form definition within the file list module.

Resolves: #83502
Releases: master, 8.7
Change-Id: Ifdba760b8ebd45a9b83e97c5a20cf23ede6a74d7
Reviewed-on: https://review.typo3.org/55843
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Add placeholder to date picker form elements 41/55841/2
Ralf Zimmermann [Tue, 20 Feb 2018 17:20:01 +0000 (18:20 +0100)]
[BUGFIX] Add placeholder to date picker form elements

Add the possibility to define a placeholder html attribute for
date picker form elements.

Resolves: #82514
Releases: master, 8.7
Change-Id: I7bf272d4e1e9b0af1c15e6ceeb6e1b91afba327e
Reviewed-on: https://review.typo3.org/55841
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
13 months ago[BUGFIX] Refactor record querying in deep nested structures in recycler 42/55842/2
Andreas Fernandez [Sat, 27 Jan 2018 23:14:11 +0000 (00:14 +0100)]
[BUGFIX] Refactor record querying in deep nested structures in recycler

This patch refactors how the recycler queries records in deep page
structures.
Instead of resolving each level of the page tree on demand and executing
the complex logic of creating query builders and paging all over again,
a list of page ids is generated once and stored in the Caching Framework
for the current request. This list is then used in an multiple `IN()`
statements (depending on the DBMS engine used).

Also, some wrong type hints and a wrong language file reference are
fixed.

Resolves: #83702
Releases: master, 8.7
Change-Id: Ie3314b5a9209fb5585f95a70c16b35639951c197
Reviewed-on: https://review.typo3.org/55842
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Fix miscellaneous palette in pages table 39/55839/2
Armin Vieweg [Tue, 20 Feb 2018 11:30:15 +0000 (12:30 +0100)]
[BUGFIX] Fix miscellaneous palette in pages table

Removed unnecessary locallang reference for field "editlock"
in showitem string. This field has been moved to access tab.

Resolves: #83974
Branches: master, 8.7
Change-Id: I85201f552a67badca420386bb615bcc571a712db
Reviewed-on: https://review.typo3.org/55839
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] EXT:form - fix design glitches of new element modal 36/55836/2
Andreas Steiger [Tue, 20 Feb 2018 16:19:30 +0000 (17:19 +0100)]
[BUGFIX] EXT:form - fix design glitches of new element modal

Streamline the markup of the new element modal of the form editor and
fix some style glitches due to side effects with other extensions.

Resolves: #82444
Releases: master, 8.7
Change-Id: Ifceac76a70dd4744f52da3b08ca8baea5f4adb7d
Reviewed-on: https://review.typo3.org/55836
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
13 months ago[BUGFIX] Ensures call of synchronizeFieldValues with valid arguments 25/55825/2
Joerg Kummer [Fri, 16 Feb 2018 18:05:16 +0000 (19:05 +0100)]
[BUGFIX] Ensures call of synchronizeFieldValues with valid arguments

Let 8.7 installtool upgrade wizard L10nModeUpdater ignore synchronization if parent entry of given translations is set to deleted

Resolves: #83940
Releases: master, 8.7
Change-Id: Ie240f71ecf42564c0547abd2dfa5c5efb23c6385
Reviewed-on: https://review.typo3.org/55825
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[TASK] EXT:form - Rename "Vendor" javascript folder to "Contrib" 21/55821/2
Ralf Zimmermann [Tue, 20 Feb 2018 06:50:42 +0000 (07:50 +0100)]
[TASK] EXT:form - Rename "Vendor" javascript folder to "Contrib"

Move folder typo3/sysext/form/Resources/Public/JavaScript/Backend/Vendor
to typo3/sysext/form/Resources/Public/JavaScript/Contrib.

Resolves: #83879
Releases: master, 8.7
Change-Id: I35cefa13bcfa621d4877273267d58ff4e26cd5bd
Reviewed-on: https://review.typo3.org/55821
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
13 months ago[TASK] Extend untangleFilesArray function test in RequestBuilder 10/55810/2
Joshua Westerheide [Sat, 11 Nov 2017 16:42:05 +0000 (17:42 +0100)]
[TASK] Extend untangleFilesArray function test in RequestBuilder

Check for cases where the files array is nested more complex or
keywords (e.g. "error") are used as field names.

Run `curl -F "d0[]=@d12.txt" -F "d0[d1][d2][d3]=@d12.txt"
-F "error=@error_file.txt" localhost:8080` against a custom
php script to generate the testing $_FILES array.

Resolves: #82976
Releases: master, 8.7, 7.6
Change-Id: I51fb9da7c87871b6bb1e8ac4de317973f307dd49
Reviewed-on: https://review.typo3.org/55810
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[BUGFIX] Fix source collection for GIFBUILDER 17/55817/2
Marco Huber [Mon, 22 Aug 2016 11:49:34 +0000 (13:49 +0200)]
[BUGFIX] Fix source collection for GIFBUILDER

If the file resource is a GIFBUILDER object, the dimension is set in the
properties XY, maxWidth or maxHeight.

Change-Id: Ic931760a966e6647042bca976c48e7bbaabdbb5a
Resolves: #77577
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55817
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
13 months ago[TASK] Change the label for scheduler "Save and create" 06/55806/2
Tomas Norre Mikkelsen [Thu, 15 Feb 2018 13:10:50 +0000 (14:10 +0100)]
[TASK] Change the label for scheduler "Save and create"

The label for the "Save and create new document" in the scheduler module,
will be change to a more appropriate label "Save and create new task"

Resolves: #83920
Releases: master, 8.7, 7.6
Change-Id: Ic4d6ad9d4598aafbc16c03b5bc50789451f6cdaf
Reviewed-on: https://review.typo3.org/55806
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[BUGFIX] EXT:filelist Fixed exception when creating new text file 09/55809/2
Michael Oehlhof [Sun, 21 Jan 2018 11:50:51 +0000 (12:50 +0100)]
[BUGFIX] EXT:filelist Fixed exception when creating new text file

The exception does not occur with the LocalDriver.
For testing use the driver mentioned in the forge issue.

Resolves: #83627
Releases: master, 8.7
Change-Id: Iae5fef2cc1ca704998975aba4fb6f5e48aeec4b1
Reviewed-on: https://review.typo3.org/55809
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
13 months ago[BUGFIX] Handle empty string icon-overlay identifier 08/55808/2
Romain Canon [Sat, 23 Sep 2017 13:07:02 +0000 (15:07 +0200)]
[BUGFIX] Handle empty string icon-overlay identifier

An overlay identifier can be an empty string, for instance when the icon API is
called with the Fluid icon view helper:

```
<core:icon identifier="tx-my-icon"
           overlay="{f:if(condition: myCondition, then: 'my-overlay-icon')}" />
```

In the example below, if the condition `myCondition` is `false`, an empty string
is used for the overlay parameter.

---

Previously, an empty string as overlay identifier would lead to the basic "not
found icon" being used as overlay.

With this commit, the behaviour for an empty string will now be the same as when
 `null` is used.

---

Resolves: #82547
Releases: master, 8.7
Change-Id: I6fb8207f302873e0188d71a210485bbf8565eff9
Reviewed-on: https://review.typo3.org/55808
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
13 months ago[BUGFIX] Show all dropdown items of form finisher 97/55797/2
Andreas Steiger [Mon, 19 Feb 2018 15:09:59 +0000 (16:09 +0100)]
[BUGFIX] Show all dropdown items of form finisher

Show the entire content of a long finisher dropdown in form wizard.

Resolves: #83131
Releases: 8.7
Change-Id: I38a389476439968224f4dd57d38a513e6dde1c08
Reviewed-on: https://review.typo3.org/55797
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Björn Jacob <bjoern.jacob@tritum.de>
Tested-by: Björn Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
13 months ago[TASK] Catch exception in record editing if current record is deleted 94/55794/2
Georg Ringer [Thu, 15 Feb 2018 07:08:29 +0000 (08:08 +0100)]
[TASK] Catch exception in record editing if current record is deleted

If an edit form is reloaded after the record has been deleted,
a message should be shown to the user instead of an exception.

Resolves: #83903
Releases: master, 8.7
Change-Id: Ib427ee8601a70c53d63f1afea7f1eacc71fd5da1
Reviewed-on: https://review.typo3.org/55794
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Remove "Set" button in belog extension 90/55790/2
Gianluigi Martino [Wed, 14 Feb 2018 15:09:48 +0000 (16:09 +0100)]
[TASK] Remove "Set" button in belog extension

The "Set" button is obsolete because the filter change automatically on dropdown select.

Resolves: #83895
Releases: master, 8.7
Change-Id: I0f0acf05a5c06395bb8710829d68e5add9462d94
(cherry picked from commit 96d3514f83d45be49d69f9c5bd39c917e9cf433c)
Reviewed-on: https://review.typo3.org/55790
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
13 months ago[BUGFIX] Show links to missing records in InputLink 89/55789/2
Alexander Opitz [Fri, 16 Feb 2018 10:10:21 +0000 (11:10 +0100)]
[BUGFIX] Show links to missing records in InputLink

If the linked record wasn't found (wrong uid, removed from database) we
check before trying to gather an icon for the non-existing record.

Resolves: #81804
Releases: master, 8.7
Change-Id: Ie06ec8a614650d8147f143cda8d8e6a9cb3e98e9
(cherry picked from commit aa4ce89d5263d5258ae8e35dc5daeb9eb9fae561)
Reviewed-on: https://review.typo3.org/55789
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Tested-by: Andreas Wolf <andreas.wolf@typo3.org>
13 months ago[TASK] Add composer.json integrity check 88/55788/4
Mathias Schreiber [Sat, 17 Feb 2018 20:40:05 +0000 (21:40 +0100)]
[TASK] Add composer.json integrity check

Each composer.json file in a system extension now has its dependencies
checked against the root composer.json to avoid errors after the subtree split.

Resolves: #83957
Releases: master, 8.7
Change-Id: Ibf37bd56fd1534b14e714dfdfaaf6374a48978c4
Reviewed-on: https://review.typo3.org/55788
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Add CGL check for CSV fixtures 87/55787/5
Mathias Schreiber [Fri, 16 Feb 2018 18:25:49 +0000 (19:25 +0100)]
[TASK] Add CGL check for CSV fixtures

We now make sure that invalid CSV no longer gets merged
into TYPO3s core.

Resolves: #83943
Releases: master, 8.7
Change-Id: If8b6a20b3ccf9cbcdc3ffe0e74733dfd941c09d5
Reviewed-on: https://review.typo3.org/55787
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Fix CSV fixtures in core 86/55786/2
Anja Leichsenring [Sat, 17 Feb 2018 21:03:23 +0000 (22:03 +0100)]
[BUGFIX] Fix CSV fixtures in core

All CSV fixtures are now a proper CSV file with a proper column count.
This makes editing them with a picky CSV editor possible again.

Resolves: #83941
Releases: master
Change-Id: Ic5f59c49fd3fa6ad98036f5392e36d450633d501
Reviewed-on: https://review.typo3.org/55786
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Unify installation tests 84/55784/2
Anja Leichsenring [Sat, 17 Feb 2018 10:24:52 +0000 (11:24 +0100)]
[TASK] Unify installation tests

MySql receives a test to install the introduction package, PgSql gets
one for the blank page preset.
With this change, both install suites check both kind of setup the
instance.

Change-Id: Ic21091f5bc3a0aa14a49e9e9fa65a5f9db829cdb
Resolves: #83949
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55784
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Respect casing in CommandLineBackendUserRemovalUpdate 82/55782/2
Anja Leichsenring [Thu, 15 Feb 2018 19:27:13 +0000 (20:27 +0100)]
[BUGFIX] Respect casing in CommandLineBackendUserRemovalUpdate

System extensions used to create their _cli_* users lowercased.
The wizard queries only for uppercase varieties. Adding a LOWER
command to the where-clause catches now all casings.

Change-Id: I556f0181416067479ff579d2498389a564c6a5e3
Resolves: #83927
Relates: #79276
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55782
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[TASK] Properly check for HTTPS 64/55764/2
Alexander Opitz [Fri, 16 Feb 2018 09:08:07 +0000 (10:08 +0100)]
[TASK] Properly check for HTTPS

Take into account empty and "off" values for the HTTPS request variable
to support ISAPI with IIS.

Resolves: #81837
Releases: master, 8.7
Change-Id: I5937c506d3e36a2009a8da6e66724728654b4001
Reviewed-on: https://review.typo3.org/55764
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Flacky acceptance test 68/55768/2
Christian Kuhn [Fri, 16 Feb 2018 20:08:19 +0000 (21:08 +0100)]
[BUGFIX] Flacky acceptance test

Better safeguard a BookmarkCest detail to
stabilize that patch again.

Change-Id: Ia873d1c8a04d0ef329c280ff5d4d7518c6b73e22
Resolves: #83947
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55768
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Unit tests call parent::tearDown() 62/55762/3
Christian Kuhn [Fri, 16 Feb 2018 18:25:12 +0000 (19:25 +0100)]
[BUGFIX] Unit tests call parent::tearDown()

For the memory garbage collection of UnitTestCase to kick in,
it is important that unit tests which implement tearDown()
call parent after their own job.

Fix some missing parent calls, refactor some other tests
slightly to live without tearDown() and activate two tests
that come with an invalid @depends annotation.

Change-Id: I51c7534ea3220ec63fd8c3efa94e8bf295590e68
Resolves: #83944
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55762
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
13 months ago[BUGFIX] Fix table markup in DragDropUploader 57/55757/2
Mathias Schreiber [Fri, 16 Feb 2018 15:33:52 +0000 (16:33 +0100)]
[BUGFIX] Fix table markup in DragDropUploader

Resolves: #83938
Releases: master, 8.7
Change-Id: I71ddeb358cea2b24a4db46545a35ca956c6bc320
Reviewed-on: https://review.typo3.org/55757
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
14 months ago[CLEANUP] Remove obsolete fixtures of Fluid unit tests 45/55745/2
Andreas Fernandez [Thu, 15 Feb 2018 19:46:33 +0000 (20:46 +0100)]
[CLEANUP] Remove obsolete fixtures of Fluid unit tests

Change-Id: I8a54c72090fc9e9d39fae1ddd13d8f72f691fcc0
Resolves: #83929
Related: #79972
Related: #77127
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55745
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Correct check for install tool requests in bootstrap 40/55740/2
Susanne Moog [Thu, 15 Feb 2018 18:32:49 +0000 (19:32 +0100)]
[BUGFIX] Correct check for install tool requests in bootstrap

Resolves: #83924
Releases: master, 8.7
Change-Id: If9f435c64addea63793586e131da19768749857c
Reviewed-on: https://review.typo3.org/55740
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] Let Bamboo check for clean TypeScript build 32/55732/3
Andreas Fernandez [Wed, 14 Feb 2018 14:18:39 +0000 (15:18 +0100)]
[TASK] Let Bamboo check for clean TypeScript build

To avoid having stale TypeScript builds, Bamboo now recompiles every
TypeScript via grunt and checks for unwanted modifications.

Change-Id: I1d96bb81eff4d5c42332d0a27cce0a98a7d27478
Resolves: #83914
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55732
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Hide "Group by page" if only one page is shown in EXT:belog 29/55729/2
Gianluigi Martino [Wed, 14 Feb 2018 15:14:49 +0000 (16:14 +0100)]
[TASK] Hide "Group by page" if only one page is shown in EXT:belog

It is unnecessary to show the "Group by page" checkbox if "This page" is
selected in the "Depth" dropdown.
Thus, the checkbox is hidden in that case.

Resolves: #83896
Releases: master, 8.7
Change-Id: Idd3e0252c6bb06d2442ed4db95056e1e6d292c6c
Reviewed-on: https://review.typo3.org/55729
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
14 months ago[TASK] Update typo3/testing-framework 09/55709/3
Christian Kuhn [Tue, 13 Feb 2018 21:59:38 +0000 (22:59 +0100)]
[TASK] Update typo3/testing-framework

Raise from 2.0.3 to 2.0.4 in master and
from 1.2.2 to 1.2.3 in v8. Brings a patch
to hopefully stabilize acceptance tests again.

composer command used:
composer update typo3/testing-framework

Change-Id: I87d5a65b52bca6eceae805c5edbb13c7eccd1010
Resolves: #83887
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/55709
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Handle settings for report / check in linkvalidator 04/55704/2
Thorben Nissen [Thu, 27 Apr 2017 08:13:03 +0000 (10:13 +0200)]
[BUGFIX] Handle settings for report / check in linkvalidator

The level and link type checkmark options are now handled seperately
for the "Report" and "Check Links" tab. This way, the options can
be changed independantly on each tab.

Resolves: #81035
Releases: master, 8.7
Change-Id: I772f885940791a17269c413185d3bea46695ff19
Reviewed-on: https://review.typo3.org/55704
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[BUGFIX] Add missing htmlspecialchars() calls and cleanup in QueryView 98/55698/5
Stephan Großberndt [Sat, 16 Dec 2017 12:41:21 +0000 (13:41 +0100)]
[BUGFIX] Add missing htmlspecialchars() calls and cleanup in QueryView

Add missing htmlspecialchars() calls in
EXT:core/Classes/Database/QueryView.php and do cleanup.

Resolves: #83354
Releases: master, 8.7
Change-Id: I71c463e1a2912aa20535c7a1bbc0c690560f7e63
Reviewed-on: https://review.typo3.org/55698
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[TASK] Use hash_equals for timing-safe comparison of hash-values 98/55098/2
Stefan Neufeind [Fri, 15 Dec 2017 16:18:27 +0000 (17:18 +0100)]
[TASK] Use hash_equals for timing-safe comparison of hash-values

To prevent timing-attacks on hash-comparions it is advised
to use hash_equals.

Resolves: #83329
Releases: master, 8.7
Change-Id: I7539ed27538d7d81767bfce582d568cff09d1610
Reviewed-on: https://review.typo3.org/55098
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Stephan Großberndt <stephan@grossberndt.de>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
14 months ago[BUGFIX] Fix backend user check in ProductionExceptionHandler 91/55691/2
Benjamin Franzke [Mon, 12 Feb 2018 20:49:40 +0000 (21:49 +0100)]
[BUGFIX] Fix backend user check in ProductionExceptionHandler

Uncaught Error: Call to a member function isBackendUserLoggedIn() on null
in […]/typo3/sysext/core/Classes/Error/ProductionExceptionHandler.php:103

Change-Id: I0052c2c1cd617282dbc65320933f8577038ab41c
Releases: master, 8.7
Resolves: #83867
Reviewed-on: https://review.typo3.org/55691
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
14 months ago[BUGFIX] Catch __PHP_Incomplete_Class classes 86/55686/2
Frank Naegler [Mon, 12 Feb 2018 18:08:11 +0000 (19:08 +0100)]
[BUGFIX] Catch __PHP_Incomplete_Class classes

Resolves: #66587
Releases: master, 8.7
Change-Id: I444c818e9f81d3595ca68513800c85d9f993f9b4
Reviewed-on: https://review.typo3.org/55686
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Show hidden translated record only once in clipboard 84/55684/2
Łukasz Uznański [Thu, 30 Nov 2017 10:23:25 +0000 (11:23 +0100)]
[BUGFIX] Show hidden translated record only once in clipboard

Right now, when user in workspace move element with translation
to the clipboard, translation is rendered twice in clipboard.
This bugfix prevents this behaviour.

Resolves: #82804
Releases: master, 8.7
Change-Id: I21a38800d2d5474650f8220340621841cb33f852
Reviewed-on: https://review.typo3.org/55684
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Updated class name in scheduler docs 83/55683/2
Michael Oehlhof [Sun, 17 Dec 2017 23:34:48 +0000 (00:34 +0100)]
[BUGFIX] Updated class name in scheduler docs

Resolves: #66587
Releases: master, 8.7
Change-Id: If5fbb4df430aeb08122cc0713167a8cc464e6d55
Reviewed-on: https://review.typo3.org/55683
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Use native array_replace_recursive implementation 80/55680/2
Ralf Zimmermann [Mon, 29 Jan 2018 13:56:45 +0000 (14:56 +0100)]
[TASK] Use native array_replace_recursive implementation

The custom implementation of array_replace_recursive in YamlSource
has been replaced with the native PHP version of the same method.

Resolves: #83860
Releases: master, 8.7
Change-Id: Ibc0c9ea55e7a510b84c39689890f51bfa01ebafa
Reviewed-on: https://review.typo3.org/55680
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
14 months ago[BUGFIX] Handle Guzzle exceptions in linkvalidator 78/55678/2
Sybille Peters [Sun, 11 Feb 2018 18:10:10 +0000 (19:10 +0100)]
[BUGFIX] Handle Guzzle exceptions in linkvalidator

* The Guzzle exceptions are handled in order to produce better,
  localized error messages in the Report
* Add a new language key for "Network error"

Resolves: #83611
Releases: master, 8.7
Change-Id: I6480c349cbc3325315f25187df56a4914922e463
Reviewed-on: https://review.typo3.org/55678
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Use `file.identifier` in search result of filelist 77/55677/2
Andreas Fernandez [Sun, 11 Feb 2018 18:49:08 +0000 (19:49 +0100)]
[BUGFIX] Use `file.identifier` in search result of filelist

The search results of the filelist access the property
`file.combinedIdentifier`. The property is not available anymore, so this
patch uses `file.identifier`, which maps to `FileFacade::identifier()`
and returns a handcrafted combined identifier.

Resolves: #83849
Releases: master, 8.7
Change-Id: I98bcd9e40c9fdebddf1079ad0240a1d3f6ac8d6e
Reviewed-on: https://review.typo3.org/55677
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[TASK] Skip test for Yaml PHP extension if not loaded 76/55676/2
Susanne Moog [Mon, 12 Feb 2018 11:17:50 +0000 (12:17 +0100)]
[TASK] Skip test for Yaml PHP extension if not loaded

Resolves: #83861
Releases: master, 8.7
Change-Id: I235e5e37405b264ce071c8d6ecb2b0c13f64357c
Reviewed-on: https://review.typo3.org/55676
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Make it possible to translate selectMultipleSideBySide 74/55674/2
Manuel Selbach [Thu, 8 Feb 2018 17:51:43 +0000 (18:51 +0100)]
[BUGFIX] Make it possible to translate selectMultipleSideBySide

For the default language it was possible to view the field, but on
translating the dataset, the following exception is thrown:
'PHP Warning: Invalid argument supplied for foreach() in
backend/Classes/Form/Element/SelectMultipleSideBySideElement.php line 66'

As the defaultLanguageRow keeps to be "unparsed", the $selectedItems
could be a comma separated string within the method
TYPO3\CMS\Backend\Form\Element\SelectMultipleSideBySideElement::renderReadOnly
if the TCA configuration of a field is set to 'defaultAsReadonly'.

Resolves: #77155
Releases: master, 8.7, 7.6
Change-Id: Id9380fe3761e683352166565ed1a7e56f5e64190
Reviewed-on: https://review.typo3.org/55674
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] EXT:filelist Fixed exception when the base path does not exists 36/55636/2
Michael Oehlhof [Sun, 28 Jan 2018 16:26:30 +0000 (17:26 +0100)]
[BUGFIX] EXT:filelist Fixed exception when the base path does not exists

Resolves: #79785
Releases: master, 8.7
Change-Id: I50cf03273747b1fa32a1f8e4aac993a3fbc7b7f0
Reviewed-on: https://review.typo3.org/55636
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Tested-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
14 months ago[BUGFIX] Set default values in TCA of sys_file_collection 65/55665/2
Andreas Fernandez [Fri, 9 Feb 2018 21:18:21 +0000 (22:18 +0100)]
[BUGFIX] Set default values in TCA of sys_file_collection

Resolves: #83838
Releases: master, 8.7
Change-Id: I3f27f3e610fd4eae7ac37349a0cf4ff03faa1189
Reviewed-on: https://review.typo3.org/55665
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
14 months ago[BUGFIX] HTML5: use self-closing tags only if allowed 64/55664/2
Esteban Marín [Wed, 30 Nov 2016 14:57:05 +0000 (15:57 +0100)]
[BUGFIX] HTML5: use self-closing tags only if allowed

For HTML5 only certain HTML tags are allowed to be self-closing
(e.g. <img src="..." />), so this needs to be checked when
parsing HTML.

Resolves: #78844
Releases: master, 8.7
Change-Id: If2a319fa83a4baf7d78559aa23ce34903d42d342
Reviewed-on: https://review.typo3.org/55664
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
14 months ago[BUGFIX] Fix quoting and cleanup in AdminPanelView 63/55663/2
Stephan Großberndt [Sat, 16 Dec 2017 13:03:13 +0000 (14:03 +0100)]
[BUGFIX] Fix quoting and cleanup in AdminPanelView

In EXT:frontend/Classes/View/AdminPanelView.php add missing
htmlspecialchars() calls, remove unnecessary ones, add quoteJSvalues()
and do cleanup.

Resolves: #83357
Releases: master, 8.7
Change-Id: Ib546bcfaebf5342e187f8b707a9091947a97ca72
Reviewed-on: https://review.typo3.org/55663
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[BUGFIX] EXT:form - fix clicks on checkbox labels in IE/Edge 61/55661/2
Benni Mack [Sat, 10 Feb 2018 22:21:39 +0000 (23:21 +0100)]
[BUGFIX] EXT:form - fix clicks on checkbox labels in IE/Edge

Add the "for" attribute to help Internet Explorer and Edge to target
the actual checkbox field, not the hidden field in front of it.

Resolves: #83417
Releases: master, 8.7
Change-Id: I603f95fc18df57f64d5dde8aefe6338c47b29536
Reviewed-on: https://review.typo3.org/55661
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[TASK] Fix flaky Acceptance Tests 60/55660/2
Anja Leichsenring [Fri, 9 Feb 2018 19:45:39 +0000 (20:45 +0100)]
[TASK] Fix flaky Acceptance Tests

The current default timeout to wait for elements is 10 seconds.
Turn up to 30 sec to stabilize the situation.

Resolves: #83836
Releases: master, 8.7
Change-Id: I2dd6cbe14a7d05cfe3cf6f7ad3437e0b235c96f1
Reviewed-on: https://review.typo3.org/55660
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
14 months ago[BUGFIX] Respect TSconfig option showHistory 58/55658/3
Tymoteusz Motylewski [Sat, 10 Feb 2018 21:39:48 +0000 (22:39 +0100)]
[BUGFIX] Respect TSconfig option showHistory

The TSconfig `options.showHistory` is not respected inside the core.
Add checks for list view and context menu.

Inside EditDocumentController the "Record History"
button is being rendered twice but the TSconfig
condition is only checked once.

Resolves: #79128
Releases: master, 8.7
Change-Id: Ifa884be5882772e8c267a7eb8036c53cf987bcfb
Reviewed-on: https://review.typo3.org/55658
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
14 months ago[BUGFIX] Fix RTE CKEditor placements of dropdowns in Chrome 57/55657/2
Benjamin Franzke [Sat, 10 Feb 2018 12:26:50 +0000 (13:26 +0100)]
[BUGFIX] Fix RTE CKEditor placements of dropdowns in Chrome

When used with the Chrome browser, the RTE CKEditor misplaces the
position of its dropdowns/context menus (opened via right-click)
when the viewport is scrolled. CKEditor calculates the offset relative
to the <body> and assumes <body> is as long as the content and that
the scrollbar is placed on <html> (both browser defaults).
As the TYPO3 backend uses 'overflow:auto' on <body> and 'overflow: hidden'
on <html> these assumptions conflict: Once the calculated offset exceeds
the <body> height (due tue scrolling) the chrome browser scrols up.

We now move the vertical scollbar into .module-body which implicitly
fixes the CKEditor offset calculation: The calculated menu offsets are
now relative to <body> (as assumed by CKEditor) and the scroll issues
disappear as we removed the scroll bar from <body>.

Resolves: #80116
Resolves: #82780
Releases: master, 8.7
Change-Id: I0481d4aaac1068577c9bad39e607486533ad4b6c
Reviewed-on: https://review.typo3.org/55657
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
14 months ago[TASK] Update UC in recycler only once per action 55/55655/3
Andreas Fernandez [Fri, 9 Feb 2018 23:36:15 +0000 (00:36 +0100)]
[TASK] Update UC in recycler only once per action

The UC of a backend user is now updated only once per request, if there
are actual changes.

Resolves: #83839
Releases: master, 8.7
Change-Id: I859f8b2cc94b6254251ecf639222201cbf57f1ad
Reviewed-on: https://review.typo3.org/55655
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
14 months ago[BUGFIX] Correct horizontal scrolling in iframe on iOS browsers 53/55653/2
Benjamin Kott [Sat, 10 Feb 2018 15:49:31 +0000 (16:49 +0100)]
[BUGFIX] Correct horizontal scrolling in iframe on iOS browsers

Browsers on iOS are ignoring the width property for iframes,
this resulted in iframes beeing rendered too wide and prevented
scrolling on the horizontal axis.

Resolves: #83841
Releases: master, 8.7
Change-Id: I825d6f911959fdb588f1f164f0ec4bbbf5c067c0
Reviewed-on: https://review.typo3.org/55653
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
14 months ago[BUGFIX] Fix false icons widths in FormEngine IconSelect 48/55648/2
Mathias Schreiber [Sat, 10 Feb 2018 11:01:52 +0000 (12:01 +0100)]
[BUGFIX] Fix false icons widths in FormEngine IconSelect

The width of Icons in TCA selects adjusted in https://review.typo3.org/c/55568/
has been corrected to have Icons use their proper width (128px) again.

Resolves: #83840
Releases: master, 8.7
Change-Id: Ia1e6dee77012b772c3fd5cae7199b075c66389d7
Reviewed-on: https://review.typo3.org/55648
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
14 months ago[BUGFIX] Show active state for SelectIcons 40/55640/2
Georg Ringer [Tue, 6 Feb 2018 02:42:36 +0000 (03:42 +0100)]
[BUGFIX] Show active state for SelectIcons

Highlight the selected icon. This useful feature has been
removed with the FormEngine rewrite.

Resolves: #83781
Releases: master, 8.7
Change-Id: I06376b073585d39d14de6f40bd02172168425944
Reviewed-on: https://review.typo3.org/55640
Reviewed-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: Andreas Fernandez <a.fernandez@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
14 months ago[BUGFIX] Fix typo in field description SYS:ddmmyy 33/55633/2
Reiner Teubner [Fri, 9 Feb 2018 18:35:25 +0000 (19:35 +0100)]
[BUGFIX] Fix typo in field description SYS:ddmmyy

'Date' should be 'Day'.

Resolves: #83829
Related: master, 8.7
Change-Id: If422279d147598b02e342a00f3ebcbb3d3f26723
Reviewed-on: https://review.typo3.org/55633
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Reiner Teubner <rteubner@me.com>
Tested-by: Reiner Teubner <rteubner@me.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
14 months ago[TASK] Resolve Todos in InheritancesResolverService 23/55623/2
rschueppel [Wed, 6 Dec 2017 16:44:00 +0000 (17:44 +0100)]
[TASK] Resolve Todos in InheritancesResolverService

Add some comments to understand InheritanceResolverService class.
Minor refactoring of duplicated code.
Add Test for the doc example.

Resolves: #83238
Releases: master, 8.7
Change-Id: I3aed06a76b609ef78641530a19e3379f202c84ec
Reviewed-on: https://review.typo3.org/55623
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
14 months ago[BUGFIX] Allow silent upgrade service to migrate old displayErrors setting 20/55620/3
Wouter Wolters [Thu, 8 Feb 2018 21:11:20 +0000 (22:11 +0100)]
[BUGFIX] Allow silent upgrade service to migrate old displayErrors setting

The bootstrap throws an exception when the setting SYS/displayErrors
is not set to "-1", "0" or "1". In the Install Tool TYPO3 should not crash.
Instead allow to silently migrate the value to -1

Resolves: #82782
Resolves: #83787
Releases: master,8.7
Change-Id: Ie0180b34a551a81667bb4ac32c6ab2699d9b3d4f
Reviewed-on: https://review.typo3.org/55620
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>