Packages/TYPO3.CMS.git
21 months ago[BUGFIX] Avoid redundant SQL queries in ReferenceIndex 71/53271/2
Claus Due [Thu, 10 Nov 2016 10:50:20 +0000 (11:50 +0100)]
[BUGFIX] Avoid redundant SQL queries in ReferenceIndex

Change methods inside ReferenceIndex to allow them to receive an
existing record as array rather than a UID to avoid each method loading
it from the database again to read record or record fields.

For a copy operation on 25 pages with ~100 content elements total there
are 1,500 SQL queries less leading to a ~40% time reduction and
~10% memory reduction.

Change-Id: I0ed05478dfbc0535efc8d1d29b6a8298d475fb6b
Releases: master, 8.7
Resolves: #78634
Reviewed-on: https://review.typo3.org/53271
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
21 months ago[BUGFIX] Fix wrong parameter type 61/53261/2
Henrik Elsner [Mon, 19 Jun 2017 10:56:00 +0000 (12:56 +0200)]
[BUGFIX] Fix wrong parameter type

The quoting parameter constants \PDO::PARAM_* are in fact integers. The
annotation shipped with doctrine says string, and the strict type
processing in core leads to a wrong parameter error.
Changing the strict type to int, as would be correct, solves the problem.

Releases: master, 8.7
Resolves: #81613
Change-Id: Ic327b2d761b74868cc46d781acab1f4fd9e6cfdb
Reviewed-on: https://review.typo3.org/53261
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[BUGFIX] FormEngine creating section container in new record 57/53257/2
Christian Kuhn [Wed, 14 Jun 2017 18:55:23 +0000 (20:55 +0200)]
[BUGFIX] FormEngine creating section container in new record

If a records has not been persisted and a flex section container
is added, the form compiler needs the "NEW123" uid of parent to
prefix form fields correctly.

Change-Id: Iab3945efa93d2becf636c5cf4f8596bc696cd2e0
Resolves: #80825
Related: #80100
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53215
Reviewed-on: https://review.typo3.org/53257
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[BUGFIX] rte_ckeditor triggers has-change on change 47/53247/2
Ralf Hettinger [Mon, 29 May 2017 20:38:43 +0000 (22:38 +0200)]
[BUGFIX] rte_ckeditor triggers has-change on change

CKEditor fields now triggers FormEngine.Validation.markFieldAsChanged
therefore a warning of unsaved changes on closing the form is raised
based on changes within these CKEditor fields.

Resolves: #68955
Releases: master, 8.7
Change-Id: I0da98c2204b20b0f6cd27a53b66f2df3d369a145
Reviewed-on: https://review.typo3.org/53247
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[FOLLOWUP][BUGFIX] Use mb_* methods directly instead of CharsetConverter 46/53246/2
Benni Mack [Sat, 17 Jun 2017 19:33:07 +0000 (21:33 +0200)]
[FOLLOWUP][BUGFIX] Use mb_* methods directly instead of CharsetConverter

Fixing one issue with the wrong variable name.

Resolves: #81575
Releases: master, 8.7
Change-Id: I820a3bcfc9a250a35ca2bec69b71a40fc7c8d01a
Reviewed-on: https://review.typo3.org/53246
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
22 months ago[BUGFIX] Use the correct named parameter type in Extbase queries 44/53244/2
Christian Toffolo [Sun, 14 May 2017 12:24:25 +0000 (14:24 +0200)]
[BUGFIX] Use the correct named parameter type in Extbase queries

In Extbase query expressions the second operand is converted to a plain
value which is either an integer or a string. This type must also be
specified when creating a named parameter in the query.

Resolves: #79473
Resolves: #80978
Resolves: #81487
Resolves: #81019
Resolves: #81056
Releases: master, 8.7
Change-Id: I835643653e03b98bfcd5a8b35b5de750641ecb79
Reviewed-on: https://review.typo3.org/53244
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Fix DB error handling in FrontendUserImageUpdateWizard 43/53243/2
Morton Jonuschat [Tue, 6 Jun 2017 03:45:19 +0000 (20:45 -0700)]
[BUGFIX] Fix DB error handling in FrontendUserImageUpdateWizard

The errorCode() method returns a string representation of the error that happened.
Comparing this to an integer value to determine is not reliable. In addition Doctrine
throws Exceptions when database statements fail so this part of the code could not be
reached.
Catch the DBALException, extract the error message and let the re-raised extension
bubble up to show the actual error message to the user.

Change-Id: I042b94329e3d52f9520ded812247ee78a73ea402
Resolves: #79870
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53243
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[BUGFIX] Respect selected page in recursive record list search 42/53242/2
Sascha Egerer [Sat, 20 May 2017 06:56:15 +0000 (08:56 +0200)]
[BUGFIX] Respect selected page in recursive record list search

The backend list view must respect the selected pages even if the search
level is set to infinite. This bug was introduced by the Doctrine
migration.

Resolves: #81278
Releases: master,8.7
Change-Id: I6ab0e93a019a001f9df08e00c01f7525a6621284
Reviewed-on: https://review.typo3.org/53242
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[BUGFIX] Remove superfluous extbase TS option 41/53241/2
Benni Mack [Fri, 16 Jun 2017 11:03:46 +0000 (13:03 +0200)]
[BUGFIX] Remove superfluous extbase TS option

When removing the extbase query cache in 8.3, the TypoScript option
was not removed which has no effect anymore since then.

Resolves: #77460
Releases: master, 8.7
Change-Id: I72d3907fd1c3aa302a03cc1f41bfe28b97020216
Reviewed-on: https://review.typo3.org/53241
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
22 months ago[BUGFIX] Streamline bool arguments throughout the core 40/53240/2
Benni Mack [Fri, 16 Jun 2017 11:10:03 +0000 (13:10 +0200)]
[BUGFIX] Streamline bool arguments throughout the core

There are still places left in TYPO3 where methods are called with
integers as parameters, although they are marked as boolean.

These places are changed to the correct and necessary value.

Resolves: #81595
Releases: master, 8.7
Change-Id: I1664e7d5e3962f0d2cf59ba6148812291d0b803b
Reviewed-on: https://review.typo3.org/53240
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[BUGFIX] AdminPanel: Change fields for simulate time 38/53238/2
Thorben Nissen [Fri, 16 Jun 2017 06:32:19 +0000 (08:32 +0200)]
[BUGFIX] AdminPanel: Change fields for simulate time

When entering a date string in the admin panel to simulate a certain
date/time and clicking the "update" button an exception it thrown. Due to
the names and ordering of the fields, the timestamp from the hidden field
gets overridden by the date string.

Move the hidden timestamp field after the human readable date string field
to avoid the timestamp being overridden by the date string. Add a comment
to explain the ordering and avoid future changes.

Resolves: #81174
Releases: master, 8.7
Change-Id: I87236c9b8ef84dabb3ec63e0530f14582ecbe6fe
Reviewed-on: https://review.typo3.org/53238
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Add missing format.case capitalWords mode 34/53234/2
Benni Mack [Thu, 15 Jun 2017 14:26:37 +0000 (16:26 +0200)]
[BUGFIX] Add missing format.case capitalWords mode

The mode "capitalWords" was just a todo statement that indicated a
missing implementation.
The implementation is now added.

Resolves: #81588
Releases: master, 8.7
Change-Id: I12b733da703de34568c6b79c083031f0333cdb92
Reviewed-on: https://review.typo3.org/53234
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Use mb_* methods directly instead of CharsetConverter 33/53233/2
Benni Mack [Wed, 14 Jun 2017 12:11:47 +0000 (14:11 +0200)]
[BUGFIX] Use mb_* methods directly instead of CharsetConverter

There are several places where mb_* methods are still not used, although
they are even better to use instead of the $csConv->parseCharset() method
for instance, as it has more aliases defined already.

Same goes for "entities_to_utf8" which is a PHP user-space implementation
of html_entity_decode() dated back to Kaspers' change in 2003.

Using native PHP methods should also increase performance marginally.

Resolves: #81575
Releases: master, 8.7
Change-Id: I5e97881cc7107883a5ff53d534161a7ec17e1ee5
Reviewed-on: https://review.typo3.org/53208
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Tested-by: Anja Leichsenring <aleichsenring@ab-softlab.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-on: https://review.typo3.org/53233

22 months ago[BUGFIX] Extbase: Remove invalid class ObjectManagerException 32/53232/2
Benni Mack [Fri, 16 Jun 2017 08:23:33 +0000 (10:23 +0200)]
[BUGFIX] Extbase: Remove invalid class ObjectManagerException

There is a class called "ObjectManagerException" which was
introduced very early with Extbase and was a clone of
the (now further developed) object manager.

It was originally used in the wrong place in workspaces
and then changed in workspaces to the real object manager
but the class was kept.

This class was then wrongly renamed in TYPO3 6.0 with the
change to namespaces and called "Exception" which it is
definitively NOT and thus, plain wrong in the place as it
is.

The class (and the interface) should be removed as it
is not just plain useless and a hard mistake we carried on
for 7 years now.

Resolves: #52825
Releases: master, 8.7
Change-Id: I615caaa9d297631a338ca6488bfe8e5c29594e3b
Reviewed-on: https://review.typo3.org/53232
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
22 months ago[BUGFIX] Include RSA JS in FE with relative URL 26/53226/2
Markus Klein [Tue, 21 Mar 2017 18:41:50 +0000 (19:41 +0100)]
[BUGFIX] Include RSA JS in FE with relative URL

Releases: master, 8.7
Resolves: #80952
Change-Id: I94a5124a16c9ad9893c1c2346967089fd16ad142
Reviewed-on: https://review.typo3.org/53226
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Better documentation of cObject viewhelper 20/53220/2
Markus Klein [Mon, 12 Jun 2017 09:26:15 +0000 (11:26 +0200)]
[BUGFIX] Better documentation of cObject viewhelper

Add more information about the table argument and when it should
be set.

Resolves: #81545
Releases: master, 8.7
Change-Id: Ic95794869b384e0932d59747df545f15afe2825f
Reviewed-on: https://review.typo3.org/53220
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[BUGFIX] Linkvalidator: Links (from rte) not detected correctly 19/53219/2
Thorben Nissen [Tue, 25 Apr 2017 07:15:11 +0000 (09:15 +0200)]
[BUGFIX] Linkvalidator: Links (from rte) not detected correctly

Due to the changed link syntax ("t3://...") instead of "<link ...>" the
links to files and internal pages are not recognised anymore. Furthermore
are external links now written with <a href="..."> and are therefore also
not recognized anymore.

Rewrite code for detecting "typolink_tags" correctly. When recognizing
urls, e.g. from "external url" pages or plain urls in texts, include https
and not only http and ftp.

Change-Id: I00b8236d9d1f8c136506cee08224564c8f6cd1fa
Resolves: #80991
Resolves: #80988
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53219
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Fix wrong markup of download icon in extension manager 18/53218/2
Georg Ringer [Wed, 14 Jun 2017 19:03:55 +0000 (21:03 +0200)]
[BUGFIX] Fix wrong markup of download icon in extension manager

Apply the classes 'btn btn-default' directly to the a tag instead
to have the full button area clickable.

Resolves: #81579
Releases: master, 8.7
Change-Id: Ib296d8e8e56c45d5d879cb7cb7a749b1c7141b2f
Reviewed-on: https://review.typo3.org/53218
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[FOLLOWUP][BUGFIX] Allow processing of multiple new record localizations 14/53214/2
Oliver Hader [Wed, 14 Jun 2017 16:28:59 +0000 (18:28 +0200)]
[FOLLOWUP][BUGFIX] Allow processing of multiple new record localizations

Complete data-map for a table is handed over in $idValues to
DataMapProcessor::fetchDependencies(string $tableName, array $ids),
but should only contain the id-values - either integer or string.

Resolves: #80239
Releases: master, 8.7
Change-Id: If12562dad839687b7d60855fa99d9ffc21bc1167
Reviewed-on: https://review.typo3.org/53214
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
22 months ago[BUGFIX] Check for enabled devlog inside devLog() 07/53207/2
Benni Mack [Fri, 19 May 2017 12:24:24 +0000 (14:24 +0200)]
[BUGFIX] Check for enabled devlog inside devLog()

Calling GeneralUtility::devLog() can be called but
the method itself should check whether the devlog
is enabled, instead of having third-party code
rely on checking the option with an if statement.

This effectively removes the need for checks on
if (TYPO3_DLOG) and the other two constants TYPO3_ERROR_DLOG
and TYPO3_EXCEPTION_DLOG in all callers' code.

Resolves: #80289
Releases: master, 8.7
Change-Id: Ibaeeca6300bdb37a513a07fb46c2616cfc51c7f2
Reviewed-on: https://review.typo3.org/53207
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Allow processing of multiple new record localizations 11/53211/2
Oliver Hader [Tue, 13 Jun 2017 15:40:05 +0000 (17:40 +0200)]
[BUGFIX] Allow processing of multiple new record localizations

The current implementation of DataMapProcessor to determine the necessity
of synchronizing record localizations is too strict since it expects real
persisted database records and cannot resolve new records that have been
handed with the very same data-map to the DataHandler.

This mentioned constraint is resolved. Besides that, an additional value
processing for internal fields is added. This method resolves new record
ids to their real persisted UIDs using the famous remap stack. This only
is executed, if these fields have not been processed in a relation-aware
context and have a meaning to TYPO3 data-structures - for instance this
is the case for 'l10n_source' field defined as TCA type 'passthrough'.

Change-Id: Id1291910d85b3d314af7203314b8696a337fe364
Resolves: #80239
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52871
Reviewed-on: https://review.typo3.org/53211
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
22 months ago[BUGFIX] Remove manually set database row 09/53209/2
Susanne Moog [Wed, 14 Jun 2017 08:49:55 +0000 (10:49 +0200)]
[BUGFIX] Remove manually set database row

databaseRow should not be set incompletely in a
FormDataProvider or controller as subsequent
processing may rely on the complete database
row being set (for example language fields).

Resolves: #80855
Related: #80100
Release: master, 8.7, 7.6
Change-Id: I139b426c6598a93a2012cae088e3cbece4e1a83b
Reviewed-on: https://review.typo3.org/53209
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Correct overflow behavior for iframes in modal windows 03/53203/2
Benjamin Kott [Sun, 11 Jun 2017 12:19:09 +0000 (14:19 +0200)]
[BUGFIX] Correct overflow behavior for iframes in modal windows

Resolves: #81539
Releases: master, 8.7
Change-Id: I0ff0c79b41d40674c4e377a5be37e9484a85808a
Reviewed-on: https://review.typo3.org/53203
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
22 months ago[BUGFIX] Throw proper exception when parsing Yaml files 01/53201/2
Benni Mack [Tue, 13 Jun 2017 05:50:12 +0000 (07:50 +0200)]
[BUGFIX] Throw proper exception when parsing Yaml files

When having an empty Yaml file, the error that is thrown isn't
helpful for the developer, and in case of RTE, the RTE is not shown
at all.

Resolves: #81557
Releases: master, 8.7
Change-Id: Ie435b9f42623962637a9ead0243be6cde15c82c6
Reviewed-on: https://review.typo3.org/53201
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[TASK] Update CKEDITOR to 4.7.0 96/53196/2
Anders Kostending [Tue, 6 Jun 2017 13:21:42 +0000 (15:21 +0200)]
[TASK] Update CKEDITOR to 4.7.0

Updates the version of CKEditor to 4.7.

This update fixes 30+ bugs, that can be seen here:
http://ckeditor.com/release/CKEditor-4.7.0

In addition there will be simpler tables, better
support for CSP, better paste from Excel and
Word and so on.

Added one fix to the typo3link plugin.

Resolves: #81483
Releases: master, 8.7
Change-Id: Id5a023e5bf9ad9bfac5e7c9c103670978ef95d8f
Reviewed-on: https://review.typo3.org/53196
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Prefix single digit dates with 0 instead of whitespace 91/53191/2
Sascha Egerer [Mon, 12 Jun 2017 11:05:46 +0000 (13:05 +0200)]
[BUGFIX] Prefix single digit dates with 0 instead of whitespace

The backend query view, used for csv exports and lists, uses a date
format where single digit days of a date value are prefixed with a
whitespace instead of a 0.
This ends up in useless CSV exports that can not be interpreted by
tools like Excel.

Change-Id: Ie11c5f8a923eb412f014f06df528a2aa0101a0d4
Resolves: #81551
Releases: master,8.7
Reviewed-on: https://review.typo3.org/53191
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Allow RTE yml presets in LocalConfiguration 90/53190/2
Christian Kuhn [Fri, 9 Jun 2017 21:36:13 +0000 (23:36 +0200)]
[BUGFIX] Allow RTE yml presets in LocalConfiguration

ext:rte_ckeditor declares the default config yml preset pointers
of TYPO3_CONF_VARS['RTE'] in its ext_localconf.php file.
This file is loaded after LocalConfiguration.php.
The patch wraps the declarations in guards to ensure any
previously set pointers are not blindly reset.

Change-Id: Ic945d988f436aab7453b7f7fba8694bbf3580b1d
Resolves: #81537
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53190
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[TASK] change intval() to (int) 87/53187/2
DanielRuf [Sat, 10 Jun 2017 21:58:51 +0000 (23:58 +0200)]
[TASK] change intval() to (int)

Typecasting with (int) is about 2-3 times faster than using intval().

Change-Id: Ifddcaaf9bf5c1fa77c632df10cba62c82d4614d1
Resolves: #81544
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53187
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[TASK] Register stylesSet in Editor/Base.yaml 82/53182/2
Frans Saris [Wed, 7 Jun 2017 12:11:05 +0000 (14:11 +0200)]
[TASK] Register stylesSet in Editor/Base.yaml

Resolves: #81499
Release: master, 8.7
Change-Id: I14fbb369de466cc1884bb164bbd3a16ba051e9b0
Reviewed-on: https://review.typo3.org/53182
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[TASK] Add alias for grunt tasks 77/53177/2
Markus Sommer [Tue, 6 Jun 2017 20:34:57 +0000 (22:34 +0200)]
[TASK] Add alias for grunt tasks

After this patch you need no local grunt-cli
you can run all task with npm like `npm run build-css`

Resolves: #81491
Releases: master, 8.7
Change-Id: I112ec3f2102c23ecfa8a715933905d03ef35e55f
Reviewed-on: https://review.typo3.org/53177
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Remove CSH of ancient form wizard 78/53178/2
Georg Ringer [Wed, 7 Jun 2017 14:31:39 +0000 (16:31 +0200)]
[TASK] Remove CSH of ancient form wizard

The first form wizard is not there anymore, therefore the
CSH must be removed as well.

Resolves: #81505
Releases: master, 8.7
Change-Id: If1f37fa26576c85ba1a756cc20b19c23d023054a
Reviewed-on: https://review.typo3.org/53178
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Remove double escaping in warning in DatabaseRecordList 76/53176/2
Georg Ringer [Wed, 7 Jun 2017 05:47:31 +0000 (07:47 +0200)]
[BUGFIX] Remove double escaping in warning in DatabaseRecordList

As the flash message's title and text are escaped already, remove the
htmlspecialchars in DatabaseRecordList.

Additionally remove the text "Warning:" from the text as this is already
expressed by the flash message itself.

Resolves: #81494
Releases: master, 8.7
Change-Id: I557dfb6f1422d2194dcdf83bbbc156a99efb290e
Reviewed-on: https://review.typo3.org/53176
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[BUGFIX] Limit shown user groups in the permission module 75/53175/2
Georg Ringer [Wed, 7 Jun 2017 14:03:51 +0000 (16:03 +0200)]
[BUGFIX] Limit shown user groups in the permission module

The usergroup selection in the overview view of the permission
module must respect the field 'hide_in_lists' as done in the
detail view of a page selected in the permission module.

Resolves: #81504
Releases: master, 8.7
Change-Id: I23c821af7abd5bdce16d780814d928e956333bb0
Reviewed-on: https://review.typo3.org/53175
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Make date/time fields working again 66/53166/3
Markus Klein [Wed, 7 Jun 2017 13:47:46 +0000 (15:47 +0200)]
[BUGFIX] Make date/time fields working again

This patch solves an issue with time-fields and a couple of
inconsistencies for time(sec), date and datetime fields in BE:

- BackendUtility::time() is superfluous as gmdate() can be used
- Ensure stored data is identical to TYPO3 7
- Only use ISO dates in UTC timezone to communicate with JS
  (time fields use 1970-01-01 as date)
- Only write ISO dates in UTC back to hidden FormEngine fields
- Do that for all date/time fields to simplify JS code
- Take care of necessary timezone conversion for date(time) fields
- Correctly handle manual input
- Fix record titles if a date field is the label field
- Fix wrong Acceptance tests
- Fix wrong Unit tests
- Remove superfluous data-date-offset attribute for DateTimePicker
- Streamline FormEngineValidation date handling code
- Refactor DateTimePicker: fix code duplication, work in UTC only

Resolves: #79249
Releases: master, 8.7
Change-Id: I12ef6b6f59f0843182e093f8f274989161820894
Reviewed-on: https://review.typo3.org/53166
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Default value for native datetime fields must not be 0 74/53174/2
Sascha Egerer [Thu, 12 Jan 2017 21:14:41 +0000 (22:14 +0100)]
[BUGFIX] Default value for native datetime fields must not be 0

The default database value for native fields of type datetime
must not be 0 but NULL.

Resolves: #79304
Releases: master, 8.7
Change-Id: I823a85be2a01ccd8df4997ab2969b2c95ed78cd1
Reviewed-on: https://review.typo3.org/53174
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Dim not selected crop area again 59/53159/2
Helmut Hummel [Wed, 7 Jun 2017 13:50:26 +0000 (15:50 +0200)]
[BUGFIX] Dim not selected crop area again

While cleanup css with #79998 the background was accidentally removed.
Add it again to make the selected crop area more prominent again.

Resolves: #81503
Releases: master, 8.7
Change-Id: I197d6c4bb9b7be7d2b9a443ce1b60ab3b4d82bcd
Reviewed-on: https://review.typo3.org/53159
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
22 months ago[BUGFIX] mssql: ext:impexp test fixes 55/53155/2
Christian Kuhn [Mon, 22 May 2017 13:39:09 +0000 (15:39 +0200)]
[BUGFIX] mssql: ext:impexp test fixes

The patch adds fixture comparison files
for mssql platform on ext:impexp functional
tests.

Change-Id: I2ff9048b9f6395c555f72a68b16684e9bf22de84
Resolves: #81501
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53155
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
22 months ago[BUGFIX] mssql: Proper types inserting / updating rows 52/53152/2
Christian Kuhn [Mon, 22 May 2017 13:39:09 +0000 (15:39 +0200)]
[BUGFIX] mssql: Proper types inserting / updating rows

MS SQL server is more picky about types than postgres and
mysql. This is especially true for LOB columns - even empty
strings need a proper cast and specific handling.

Various parts of the core deal with arbitrary tables and
don't know if a column is int, text or lob, or whatever.
Those are blindly updated / inserted, resulting in mssql
saying "no".

Solution is to fetch column schema and to set proper types
based on that schema. This is expensive. We will have to
refactor that again, and we will probably end up with a
(cache?) entry that knows the entire table schema of an
instance.

Solving that in a good way would also fix various mysql strict
issues we still have in the core. However, this needs more work.

Goal of the current patch is to bring mssql to a working state.
The solution must be seen as hacky, but is restricted to that
platform only and can be relaxed and improved as soon as we
take the next steps with schema handling in the TYPO3 core.

Change-Id: I9b582a9bde7461cfbcc2414192518fb7b7b1341d
Resolves: #81498
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53152
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[BUGFIX] mssql: ExpressionBuilder inSet() support 47/53147/2
Christian Kuhn [Tue, 6 Jun 2017 15:57:15 +0000 (17:57 +0200)]
[BUGFIX] mssql: ExpressionBuilder inSet() support

mssql does not support FIND_IN_SET(). The patch adds a
solution based on LIKE.
Since the query fiddling in this area is a bit tricky,
this area is now supported by a bunch of functional tests.
A postgres bug those new functional tests reveal is fixed
along the way.

Change-Id: I5e94ad8df7a37a680b457eff1b5b16a0c14dba39
Resolves: #81488
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53147
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
22 months ago[BUGFIX] Use correct database connection for table in ReferenceIndex 44/53144/2
Morton Jonuschat [Tue, 6 Jun 2017 03:55:38 +0000 (20:55 -0700)]
[BUGFIX] Use correct database connection for table in ReferenceIndex

Reusing the connection object for the sys_refindex table can fail
if the table that is being indexed is actually on another connection.
Select the proper connection before attempting to execute the query.

Change-Id: I4c031428f7405031aea6ef652c8b6f488f921228
Resolves: #81049
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53144
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] FormEngine: Show correct error message (render)Type is unknown 42/53142/2
Markus Klein [Tue, 6 Jun 2017 14:40:45 +0000 (16:40 +0200)]
[BUGFIX] FormEngine: Show correct error message (render)Type is unknown

Issue correct error message if the renderType (or the type) is unknown.
The message now includes also the renderType, if specified.

Releases: master, 8.7, 7.6
Resolves: #81485
Change-Id: I44e736a546fc27733a8c8df14089dd25dc172f2b
Reviewed-on: https://review.typo3.org/53142
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Prevent exception in ImageCropUpdater 23/53123/3
Nicole Cordes [Mon, 5 Jun 2017 12:18:51 +0000 (14:18 +0200)]
[BUGFIX] Prevent exception in ImageCropUpdater

The ImageCropUpdater throws an exception if a non-existing file is tried
to be processed. This happens because deleted rows are updated. The patch
checks the returned file object before further processing is executed.

Resolves: #81470
Releases: master, 8.7
Change-Id: I488994b1ad842e28d928f3b4a2db1c8c007afe3c
Reviewed-on: https://review.typo3.org/53123
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[TASK] Add sitemap to sysext:core/Documentation 34/53134/2
Martin Bless [Tue, 6 Jun 2017 07:55:48 +0000 (09:55 +0200)]
[TASK] Add sitemap to sysext:core/Documentation

Resolves: #81477
Releases: master, 8.7, 7.6
Change-Id: Ie98fcc81c386fe5704c669f36220827f7cfbd2e5
Reviewed-on: https://review.typo3.org/53134
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[BUGFIX] Use correct variable when throwing exception in PageRepository 26/53126/2
Wouter Wolters [Mon, 5 Jun 2017 14:08:55 +0000 (16:08 +0200)]
[BUGFIX] Use correct variable when throwing exception in PageRepository

The wrong variable is used in a hook exception. Use the correct variable
to prevent fatal errors.

Resolves: #81472
Releases: master,8.7
Change-Id: I8cf84c2ac84c09bbeecc2111eb6128fdc71be3c7
Reviewed-on: https://review.typo3.org/53126
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[TASK] Avoid overflow of page titles in several tables 25/53125/2
Jasmina Liessmann [Sat, 3 Jun 2017 21:31:29 +0000 (23:31 +0200)]
[TASK] Avoid overflow of page titles in several tables

Page titles are used within several table views. This patch avoids
page titles from being displayed outside their columns.

Resolves: #81456
Releases: master, 8.7
Change-Id: I38d773ff8b3300027ef815b4f792cc45b0a66aff
Reviewed-on: https://review.typo3.org/53125
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[TASK] Restructure position of help icons in 'Pagetree overview' 24/53124/2
Jasmina Liessmann [Sat, 3 Jun 2017 12:30:01 +0000 (14:30 +0200)]
[TASK] Restructure position of help icons in 'Pagetree overview'

Move general CSH for 'Pagetree overview' next to form fields.

Resolves: #81453
Releases: master, 8.7
Change-Id: I8e5c3a4257d569277f837bee2c641cd1a95dd9a5
Reviewed-on: https://review.typo3.org/53124
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
22 months ago[BUGFIX] mssql: Identifier quoting and return types 18/53118/2
Christian Kuhn [Sun, 4 Jun 2017 12:46:49 +0000 (14:46 +0200)]
[BUGFIX] mssql: Identifier quoting and return types

Microsoft sql server field & columns quotes quotes identifiers as
[anIdentifier] in comparison to mysql and postgres which quote
with a character that is identical left and right.
The patch adapts some quoting methods to cope with that and
adapts a return type hint where the mssql doctrine driver returns
more precise value types than other platform drivers.

Change-Id: I8db6109d5a92ff43f3503f245c5d131b96201096
Resolves: #79297
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53118
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[BUGFIX] Fix getTemplatePathAndFilename on StandaloneView 14/53114/2
Claus Due [Thu, 22 Dec 2016 12:28:46 +0000 (13:28 +0100)]
[BUGFIX] Fix getTemplatePathAndFilename on StandaloneView

This patch avoids calling a non-existing method and instead calls
upon TemplatePaths to resolve the template file - which is closer
to the original behavior.

Change-Id: Ib2669056e59bf1a6524e35e02e1f677226a5efa5
Resolves: #79073
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53114
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Fix height of the modal content 13/53113/2
Jasmina Liessmann [Fri, 2 Jun 2017 10:15:47 +0000 (12:15 +0200)]
[BUGFIX] Fix height of the modal content

Fix height of the modal content to avoid misbehavior in IE11.

Resolves: #81232
Releases: master, 8.7
Change-Id: I302915e1efcd2040f78db8052dc2e09e06f1dfe4
Reviewed-on: https://review.typo3.org/53113
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Make TemplatePaths->fillDefaultsByPackageName sort paths 12/53112/2
Claus Due [Wed, 24 May 2017 15:41:14 +0000 (17:41 +0200)]
[BUGFIX] Make TemplatePaths->fillDefaultsByPackageName sort paths

Due to the sequence of methods being called from this method,
it is necessary to sort TS-configured paths right when they are
resolved instead of passing the unsorted array further down.

Patch also sorts methods protected below public; true diff is
one line. Toggle this line between before/after and run the test
to see the problem demonstrated.

See issue description for a more detailed reasoning.

Change-Id: I0317c4ee683c2fac2c7def7c6d79f947afc4b078
Resolves: #81340
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53112
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Prevent thumbnail generation for non image files 11/53111/2
maikh [Sat, 3 Jun 2017 21:33:01 +0000 (23:33 +0200)]
[TASK] Prevent thumbnail generation for non image files

Check files if they are image files before thumbnail generation.

Change-Id: I7dae2ccbb5ab93e582d21efe8f7d29cf7006a1c3
Resolves: #81147
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53111
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] mssql: A series of functional test fixes 04/53104/3
Christian Kuhn [Mon, 22 May 2017 13:39:09 +0000 (15:39 +0200)]
[TASK] mssql: A series of functional test fixes

A couple of straight patches withis functional test cases
for mssql compatibility:
* Set identity where records with uids are inserted
* Quote LOB fields correctly
* A change to cope with [] encapsulated field and table names

Change-Id: I103021550fbe5c62f15e82454c766d67fc0dc63f
Resolves: #81465
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53104
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Remove bower and update Gruntfile.js 98/53098/2
Johannes Goslar [Sat, 3 Jun 2017 13:23:25 +0000 (15:23 +0200)]
[TASK] Remove bower and update Gruntfile.js

Resolves: #81459
Releases: 8.7
Change-Id: I213c8d52d8c5ed0d027c1c6e7d01e9bec49ce506
Reviewed-on: https://review.typo3.org/53098
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Move bower dependencies to npm 97/53097/2
Johannes Goslar [Fri, 2 Jun 2017 22:18:01 +0000 (00:18 +0200)]
[TASK] Move bower dependencies to npm

Resolves: #81448
Resolves: #81449
Resolves: #81450
Releases: 8.7
Change-Id: Ic87b62f09d607e7f37491ebec2ea4619bc1aff70
Reviewed-on: https://review.typo3.org/53097
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Resolve grunt build errors 96/53096/2
Markus Sommer [Fri, 7 Apr 2017 11:59:37 +0000 (13:59 +0200)]
[TASK] Resolve grunt build errors

* Remove /* @end */ comments
* Add missing line end line
* Remove unnessasery blank lines
* Add chosen to git

Resolves: #80748
Releases: 8.7
Change-Id: Ifc75b31894f1daa2f27f100819a5ffdd77eff062
Reviewed-on: https://review.typo3.org/53096
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Hide empty descriptions in textmedia in page module 93/53093/2
Jigal van Hemert [Sat, 3 Jun 2017 15:30:39 +0000 (17:30 +0200)]
[BUGFIX] Hide empty descriptions in textmedia in page module

In the Page module with textmedia content elements the descriptions
are shown below the thumbnails of linked media. If there is no
description an empty line is now suppressed.

Resolves: #81408
Releases: master, 8.7, 7.6
Change-Id: I9f342908f179550bcf2156328117c464bb8c672f
Reviewed-on: https://review.typo3.org/53093
Reviewed-by: Jo Hasenau <info@cybercraft.de>
Tested-by: Jo Hasenau <info@cybercraft.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[FOLLOWUP][BUGFIX] Exchange flag icons from SVG to PNG 90/53090/2
Marco Christian Krenn [Fri, 2 Jun 2017 09:27:01 +0000 (11:27 +0200)]
[FOLLOWUP][BUGFIX] Exchange flag icons from SVG to PNG

Remove flag SVG's from grunt and bower.

Resolves: #76291
Releases: master
Change-Id: I5698c5b23e74848a0330f080845d1d471ac37523
Reviewed-on: https://review.typo3.org/53090
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] DocumentEditController save with translation broken 88/53088/2
Markus Sommer [Fri, 5 May 2017 11:48:09 +0000 (13:48 +0200)]
[BUGFIX] DocumentEditController save with translation broken

With changing the input type=image to input type=submit,
the x/y values are no longer transferred the
EditDocumentController checked for, and content is no
longer saved. Adapt the controller code for the new parameters.

Resolves: #76649
Releases: 8.7, master

Change-Id: I921b92f1086e142592fc84083656c4baecd43aa7
Reviewed-on: https://review.typo3.org/53088
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Show hidden sub group items in be_groups records 87/53087/2
Markus Sommer [Sat, 3 Jun 2017 12:26:25 +0000 (14:26 +0200)]
[TASK] Show hidden sub group items in be_groups records

Show hidden records in the subgroup list of be_group
records, too.

Change-Id: Iaca85f22bdf8a4c308b59fd37bd75b4a913614a0
Resolves: #81452
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53087
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Prohibit editing of uneditable labels in pagetree 80/53080/2
Johannes Goslar [Fri, 2 Jun 2017 20:15:16 +0000 (22:15 +0200)]
[BUGFIX] Prohibit editing of uneditable labels in pagetree

Resolves: #81445
Releases: master, 8.7
Change-Id: Ie88eb7ce2fdaf7429377062e86996847f7e9bfa9
Reviewed-on: https://review.typo3.org/53080
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Avoid jumping of form fields on focus 81/53081/2
Jasmina Liessmann [Fri, 2 Jun 2017 22:20:30 +0000 (00:20 +0200)]
[BUGFIX] Avoid jumping of form fields on focus

Use absolute position for hints of remaining
characters to prevent form fields from being
moved down.

Resolves: #81447
Related: #77069
Releases: master, 8.7
Change-Id: I8df8cd25955a6ed44bfa5ee727f439856960167f
Reviewed-on: https://review.typo3.org/53081
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] CSH on popup window - more link leads to non-existent page 74/53074/2
Oliver Hader [Fri, 2 Jun 2017 21:13:38 +0000 (23:13 +0200)]
[BUGFIX] CSH on popup window - more link leads to non-existent page

Opening CSH help popups from another popup (e.g. add/edit wizard) fails
since the resolved CSH URI is not valid.

Resolves: #80665
Releases: master, 8.7
Change-Id: I16f4dcd037cdb7ab210c083272d0941c979da205
Reviewed-on: https://review.typo3.org/53074
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
22 months ago[TASK] Add type hints and fix PHPDoc in extbase DataMapFactory 48/53048/2
Stephan Großberndt [Wed, 24 May 2017 13:56:34 +0000 (15:56 +0200)]
[TASK] Add type hints and fix PHPDoc in extbase DataMapFactory

While this is technically a breaking change it only affects internal API.

Releases: master, 8.7
Resolves: #81336
Change-Id: I700caafcfe7f889bba90c03ae7f7010d8228c64a
Reviewed-on: https://review.typo3.org/53048
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mona Muzaffar <mona.muzaffar@gmx.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Move jquery to npm 71/53071/2
Johannes Goslar [Fri, 2 Jun 2017 22:02:01 +0000 (00:02 +0200)]
[TASK] Move jquery to npm

Resolves: #81446
Change-Id: I10fd5950636d2e4b992e1a03f1720759d9e7c55d
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53071
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Use reference for label 'bodytext' in CType 'textpic' 67/53067/2
Jasmina Liessmann [Fri, 2 Jun 2017 21:08:14 +0000 (23:08 +0200)]
[TASK] Use reference for label 'bodytext' in CType 'textpic'

Resolves: #81352
Releases: master, 8.7
Change-Id: I7f55e6998ebde5d8d90e7b6bcd05f4550f6ce09a
Reviewed-on: https://review.typo3.org/53067
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] npm script for grunt css build 60/53060/2
Christian Kuhn [Fri, 2 Jun 2017 17:37:45 +0000 (19:37 +0200)]
[TASK] npm script for grunt css build

Execute with "npm run build-css"

Change-Id: Ib5d57df2c6b1281baa245b36ba466524f8db65c0
Resolves: #81442
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53060
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Raise styleguide to 8.0.12 58/53058/2
Christian Kuhn [Fri, 2 Jun 2017 15:39:08 +0000 (17:39 +0200)]
[TASK] Raise styleguide to 8.0.12

A series of bug fixes and most TCA example records
are now multi language aware and the generator creates
multi language data records.

Change-Id: I5fca90642fde64269d08c9fc9f41ad5f949ed8ef
Resolves: #81441
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53058
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Add visual difference for elapsed endtime 55/53055/2
Markus Sommer [Fri, 2 Jun 2017 10:33:45 +0000 (12:33 +0200)]
[TASK] Add visual difference for elapsed endtime

Add an icon which indicates that the time is ahead of the endtime of the
record.

Change-Id: I04b3fcd48b554a6a15606ec580f38b2470f0327c
Resolves: #3464
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53055
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jasmina Ließmann <code@frauliessmann.de>
Tested-by: Jasmina Ließmann <code@frauliessmann.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Update TYPO3 Icons and add to icon registry 52/53052/2
maikh [Fri, 2 Jun 2017 15:03:44 +0000 (17:03 +0200)]
[TASK] Update TYPO3 Icons and add to icon registry

Change-Id: Ibc94a1f0434db96f09ee421cf64867c5779290e7
Resolves: #81426
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53052
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Update display of table in log module 45/53045/2
Jasmina Liessmann [Fri, 2 Jun 2017 12:57:18 +0000 (14:57 +0200)]
[TASK] Update display of table in log module

Add the possibility to scroll the table respecting the viewport,
wrap words in the column 'Details' on desktops

Resolves: #80994
Releases: master, 8.7
Change-Id: Ib684d1747979390b7fa83b30846139bbc17879b8
Reviewed-on: https://review.typo3.org/53045
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Disable a series of functional tests with mssql 46/53046/2
Christian Kuhn [Fri, 2 Jun 2017 13:44:37 +0000 (15:44 +0200)]
[TASK] Disable a series of functional tests with mssql

Disable mysql specific tests for mssql. This list is
nearly identical to the postgres skipped tests.
Only a couple of additional skips are added in extbase where
extbase relies on non standard query constructs that postgres
and mysql support, but mssql doesn't. This will need a more
intrusive change later, but can't be solved easily now.

Change-Id: I0db8f8f094498ff47255c6cd08c03644b58ff4ca
Resolves: #81424
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53042
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-on: https://review.typo3.org/53046

22 months ago[BUGFIX] Editing all records after deleting one throws exception 41/53041/2
Oliver Hader [Fri, 2 Jun 2017 11:55:40 +0000 (13:55 +0200)]
[BUGFIX] Editing all records after deleting one throws exception

If some record has been removed in the list module and after that
the "edit marked" button is clicked, an exception is thrown concerning
the just removed record.

The list of records to be edited is now determined from the visible
elements of the list.

Resolves: #75966
Releases: master, 8.7
Change-Id: I2c77dd2d92cda038a1009c318a2ee6650bd82963
Reviewed-on: https://review.typo3.org/53041
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Raise testing-framework to 1.0.7 35/53035/2
Christian Kuhn [Fri, 2 Jun 2017 12:35:50 +0000 (14:35 +0200)]
[TASK] Raise testing-framework to 1.0.7

A couple of bug fixes and preparations for mssql support.

Change-Id: Ia8f874d03a37250d739e6939e36bb04455a85fc4
Resolves: #81419
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53035
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Do not show hidden tables in LiveSearch 32/53032/2
Susanne Moog [Fri, 2 Jun 2017 10:20:37 +0000 (12:20 +0200)]
[BUGFIX] Do not show hidden tables in LiveSearch

LiveSearch did not check whether the tables were
allowed to be shown (via TCA ctrl hideTable) and
displayed results that were not available after
clicking 'show all'.

Change-Id: I90f61e1156c446cd399c0f26b96bbd30c747554d
Releases: master, 8.7
Resolves: #75651
Reviewed-on: https://review.typo3.org/53032
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Remove disabled button in inline records 29/53029/2
Johannes Schlier [Tue, 30 May 2017 15:23:24 +0000 (17:23 +0200)]
[BUGFIX] Remove disabled button in inline records

If the info icon is disabled it is now removed completely.
Previously the logic for new records was not caught correctly, so that
the case for the enabled icon with a new record was executed.
Disabling the icon should remove it completely,
as a disabled non-clickable icon is not helpful and confusing for editors.
This is now done, and the case for the enabled icon with new records is
also correctly caught.

Resolves: #81380
Releases: master, 8.7
Change-Id: I1c78a99a83efa3c88e3a6337df9cd0c8a959ea7b
Reviewed-on: https://review.typo3.org/53029
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Add background-color to Link Wizard Attribute Container 28/53028/2
Marco Christian Krenn [Thu, 1 Jun 2017 12:55:33 +0000 (14:55 +0200)]
[BUGFIX] Add background-color to Link Wizard Attribute Container

Background color was added to the Link Wizard Attribute Container,
to fit with the leading tab navigation.

Releases: master, 8.7
Resolves: #81404
Change-Id: Idcc009ec2b02da367a1ed749e3a5c746fed43717
Reviewed-on: https://review.typo3.org/53028
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Fixed broken links in file reference list 24/53024/2
Christer Vindberg [Mon, 29 May 2017 08:49:01 +0000 (10:49 +0200)]
[BUGFIX] Fixed broken links in file reference list

Changed so file reference list icon and title links don't throw an
exception

The fluid template used a url as a pageUid, which caused typo3 to
throw an exception.

Resolves: #81357
Releases: master, 8.7
Change-Id: Ibbb8d7d51d1b65e9178082f59e34fdfbb501d2fa
Reviewed-on: https://review.typo3.org/53024
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Use Fluid standalone TagBuilder object 25/53025/2
Benni Mack [Fri, 26 May 2017 15:43:43 +0000 (17:43 +0200)]
[BUGFIX] Use Fluid standalone TagBuilder object

When instantiating the tag-based viewhelpers and
extbase is in the game, the class alias map is not
taken place, because there is a class expected
which is only in the class alias map, but not
existing anymore.

Instead, the Fluid standalone's TagBuilder object
should be used.

Resolves: #81350
Releases: master, 8.7
Change-Id: I1d3d73a65b4948474dd68c42f43ead454c842ecb
Reviewed-on: https://review.typo3.org/53025
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Raise required PCRE version 22/53022/2
Stephan Großberndt [Wed, 24 May 2017 14:09:18 +0000 (16:09 +0200)]
[BUGFIX] Raise required PCRE version

Warn about an outdated PCRE version which is not compatible to PHP 7.0
in the Install Tool to make aware of possible PHP crashes in the TYPO3
backend.

Releases: master, 8.7
Resolves: #81335
Change-Id: I0db145146eb02bcab81a83195f375c87ae85f3e4
Reviewed-on: https://review.typo3.org/53022
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Klee <typo3-coding@oliverklee.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Avoid jumping of form fields on focus 20/53020/2
Jasmina Liessmann [Thu, 1 Jun 2017 14:11:43 +0000 (16:11 +0200)]
[BUGFIX] Avoid jumping of form fields on focus

Use absolute position for hints of remaining
characters to prevent form fields from being
moved down.

Resolves: #77069
Releases: master, 8.7
Change-Id: Iacba62543b036309e17828ab86f1986eb65f36a0
Reviewed-on: https://review.typo3.org/53020
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] SystemInformationMenu: Automatically refresh counter badge 18/53018/2
Johannes Goslar [Thu, 1 Jun 2017 16:22:31 +0000 (18:22 +0200)]
[TASK] SystemInformationMenu: Automatically refresh counter badge

Automatically reload the SystemInformation every 5 minutes.

Resolves: #68920
Releases: master, 8.7
Change-Id: Ie21d345d6bcbbae30f0fd77f084c22b1b2a0f6f2
Reviewed-on: https://review.typo3.org/53018
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Change order of preferred extension icons 17/53017/2
Georg Ringer [Thu, 1 Jun 2017 16:56:49 +0000 (18:56 +0200)]
[TASK] Change order of preferred extension icons

Prefer svg over png icons.

Resolves: #81396
Releases: master, 8.7
Change-Id: Ide44eb1f0c841c788516424fbff01bd319c79104
Reviewed-on: https://review.typo3.org/53017
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Exchange flag icons from SVG to PNG 16/53016/2
Marco Christian Krenn [Thu, 1 Jun 2017 20:53:05 +0000 (22:53 +0200)]
[BUGFIX] Exchange flag icons from SVG to PNG

All flag icons are exchanged to PNG to reduce file size and
fix viewport rendering problem in IE11.

Moved following flag icons from IconRegistry to registerFlags

* flag-an
* flag-cs
* flag-qc

Removed icon 'flag-fam', this was the famfamfam flag and has no use

Remove US states flags

Releases: master, 8.7
Resolves: #76291
Change-Id: I3d45b76901c2584680c8fcaa49aa0fed308405fc
Reviewed-on: https://review.typo3.org/53016
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Avoid unnecessarily fetching file for processing 15/53015/3
Helmut Hummel [Sat, 20 May 2017 09:29:45 +0000 (11:29 +0200)]
[BUGFIX] Avoid unnecessarily fetching file for processing

Files that are not configured as images, won't be processed,
but are still unnecessarily fetched for processing.

To avoid this, we change the processing API, that fetching
only happens, if the file is then used by following code.

In addition we avoid showing a non descriptive thumb
in FileInfoElement, which is used when editing meta data of the file.

Resolves: #81279
Releases: master, 8.7, 7.6
Change-Id: Ie68aa02b1b6149ddb7fbda346ac312d3646e260c
Reviewed-on: https://review.typo3.org/53015
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months agoRevert "[BUGFIX] Avoid duplicates if ReferenceIndex is unable to finish" 14/53014/3
Christian Kuhn [Tue, 23 May 2017 20:39:31 +0000 (22:39 +0200)]
Revert "[BUGFIX] Avoid duplicates if ReferenceIndex is unable to finish"

This reverts commit c2a9726c4efb23d76c084e3319b29f74c14ccdce
from review https://review.typo3.org/#/c/50803/
due to regression in #81320

Change-Id: I496e13ce9efe743a5607e12b46a3fdc90e2f17c2
Resolves: #81320
Reverts: #78829
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53014
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Combine lint task for ci integration and correct code violations 13/53013/3
Benjamin Kott [Thu, 1 Jun 2017 19:05:19 +0000 (21:05 +0200)]
[TASK] Combine lint task for ci integration and correct code violations

Resolves: #81411
Releases: master, 8.7
Change-Id: I2b0f848ee6db870e78d8d102ef48ba2b417f91d7
Reviewed-on: https://review.typo3.org/53013
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Module menu clicks with slow connections opens standalone module 10/53010/2
Oliver Hader [Thu, 1 Jun 2017 13:57:50 +0000 (15:57 +0200)]
[BUGFIX] Module menu clicks with slow connections opens standalone module

If loading the backend using a slow internet connection an early click on
any item in the module menu on the left side causes the link to be opened
directly. The reason is, that JavaScript and thus click handlers are not
completely loaded yet. Thus, the regular DOM behavior of anchor tags is
executed.

To circumvent this behavior, href-arguments have to be disabled and the
module URL moved to a dedicated new data-attribute. As a result all items
that trigger a module change have to be adjusted as well.

Resolves: #80565
Releases: master, 8.7
Change-Id: I4687e6594eb539acc0d299dc8fc02e6820019911
Reviewed-on: https://review.typo3.org/53010
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Require bower and have node build scripts 05/53005/2
Christian Kuhn [Thu, 1 Jun 2017 17:06:43 +0000 (19:06 +0200)]
[TASK] Require bower and have node build scripts

In preperation of a scss linter and typescript linter
we require bower as root dev dependency and register
some happy little scripts.

Change-Id: I425fd848a4012065fc7d955be0ae961f0f2ee8c4
Resolves: #81410
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53005
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Add NPM package lock file 04/53004/2
Christian Kuhn [Thu, 1 Jun 2017 17:13:20 +0000 (19:13 +0200)]
[TASK] Add NPM package lock file

The file describes the exact tree that was generated, such that
subsequent installs are able to generate identical trees, regardless
of intermediate dependency updates.

https://docs.npmjs.com/files/package-lock.json

Resolves: #81406
Releases: master, 8.7
Change-Id: I8c2f0d7a8d6a1d0cd7434d8e753a32d387b32f8f
Reviewed-on: https://review.typo3.org/53004
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] trigger Backend.doLayout() on window resize 94/52994/2
Johannes Goslar [Thu, 1 Jun 2017 12:26:47 +0000 (14:26 +0200)]
[BUGFIX] trigger Backend.doLayout() on window resize

Resolves: #78464
Releases: master, 8.7
Change-Id: I8d861df1e047213a355d145e05a9131386c7439f
Reviewed-on: https://review.typo3.org/52991
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
(cherry picked from commit 194bdeaae53cbf4301c8743edcb819547c262a91)
Reviewed-on: https://review.typo3.org/52994

22 months ago[TASK] Functionals: Rename "@group mysql" to "@group not-postgres" 85/52985/2
Christian Kuhn [Wed, 31 May 2017 20:28:12 +0000 (22:28 +0200)]
[TASK] Functionals: Rename "@group mysql" to "@group not-postgres"

Functional tests annotated with "@group mysql" are currently ignored
if running tests on postgres via "--exclude-group mysql" argument.
With mssql we have some tests that run fine with mysql and postgres,
but not with mssql.
To improve handling, "@group mysql" annotation is renamed
to "@group not-postgres". Tests not available on postgres and mssql
will then later have a second annotation "@group not-mssql".
This way its easier to keep track which tests go red on which DBMS.

Change-Id: I2522b00352f1a7d61479588a22cdd9ea5d454ca3
Resolves: #81394
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52985
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[CLEANUP] Reduce cache gets in MarkerBasedTemplateService 82/52982/2
Claus Due [Tue, 30 May 2017 22:42:10 +0000 (00:42 +0200)]
[CLEANUP] Reduce cache gets in MarkerBasedTemplateService

Multiple calls to get() from cache can be condensed to one.

Change-Id: I1d949fcbc0c91afdbfb2d0e2bc3d9c1b4dfd475a
Resolves: #81385
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52982
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[TASK] Refactor ext:impexp functional tests 81/52981/2
Christian Kuhn [Wed, 31 May 2017 15:18:15 +0000 (17:18 +0200)]
[TASK] Refactor ext:impexp functional tests

The ext:impexp functional tests are rather hard to read and
follow. The patch untangles them to make them better maintainable:

* Combine the two different import / export abstract classes into 1 class
* Don't inherit from AbstractDataHandlerActionTestCase anymore
* Give single test cases better file names and do not hide them in sub dirs
* Move all fixtures to Fixtures/ dir
* Use less helper methods to import and test things
* File paths are more straight and with less helper magic

Change-Id: Iae36771b94045f99444f394129cbcf183168b584
Resolves: #81393
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52981
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[TASK] Fix typos in upgrade wizards of Install Tool 79/52979/2
Georg Ringer [Tue, 30 May 2017 19:57:46 +0000 (21:57 +0200)]
[TASK] Fix typos in upgrade wizards of Install Tool

Use the term "Upgrade wizard" instead of "Update wizard"
for the buttons of the single steps as the main menu item
is also called "Upgrade wizard".

Resolves: #81383
Releases: master, 8.7
Change-Id: I8047ae45101533a67fa4488af7040acc49af563f
Reviewed-on: https://review.typo3.org/52979
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
22 months ago[FOLLOWUP][TASK] Squeeze every bit of performance from CGL fixer 65/52965/2
Elmar Hinz [Wed, 24 May 2017 16:10:23 +0000 (18:10 +0200)]
[FOLLOWUP][TASK] Squeeze every bit of performance from CGL fixer

Support case sensitve file systems again.

Releases: master, 8.7
Resolves: #80814
Change-Id: I82274b328e9cfa75fb35360145d7a668d1270dc3
Reviewed-on: https://review.typo3.org/52965
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
22 months ago[BUGFIX] Extbase: Pass parameter to real raw queries 62/52962/2
Daniel Goerz [Fri, 19 May 2017 12:02:56 +0000 (14:02 +0200)]
[BUGFIX] Extbase: Pass parameter to real raw queries

Resolves: #81272
Releases: master, 8.7
Change-Id: Iac3d486697b8c52fbace185ab1a55c514847db07
Reviewed-on: https://review.typo3.org/52962
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
22 months ago[BUGFIX] Ensure correct URL generation with http_build_query() 64/52964/2
Markus Klein [Wed, 24 May 2017 12:09:42 +0000 (14:09 +0200)]
[BUGFIX] Ensure correct URL generation with http_build_query()

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
This does not seem appropriate for URLs generated by TYPO3.

Use the optional parameters of http_build_query() to get the desired
functionality.

Releases: master, 8.7, 7.6
Resolves: #81366
Change-Id: Ie2df9207b1967257d6327ff1103503e6a58d5cdf
Reviewed-on: https://review.typo3.org/52964
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
22 months ago[BUGFIX] Properly escape <> in Install Tool Check. 44/52944/2
Georg Ringer [Wed, 24 May 2017 05:47:12 +0000 (07:47 +0200)]
[BUGFIX] Properly escape <> in Install Tool Check.

Escape the < > in the check of the Windows Apache ThreadStackSize.

Resolves: #81134
Releases: master, 8.7
Change-Id: Iaa73e61438766f413ba7aeeaebac0fcbf41f1a99
Reviewed-on: https://review.typo3.org/52944
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
22 months ago[BUGFIX] Make encoding of parameters for cHash independent of PHP settings 23/52923/2
Markus Klein [Tue, 23 May 2017 20:51:35 +0000 (22:51 +0200)]
[BUGFIX] Make encoding of parameters for cHash independent of PHP settings

http_build_query() internally uses the PHP setting arg-separator.output
to identify the URL parameter separator.
Our code relies on having a simple ampersand as this character.
If the PHP is set to a different configuration the code will fail.

This is fixed by enforcing the ampersand. Moreover we force RFC3986
encoding to ensure that decoding with rawurldecode() does the right
thing.

Change-Id: I92f9b877201c634303a2e387d9aad49106151f63
Releases: master, 8.7
Resolves: #81293
Reviewed-on: https://review.typo3.org/52923
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
22 months ago[BUGFIX] Explicit cast to string for VersionState object 17/52917/2
Christian Kuhn [Mon, 22 May 2017 21:12:31 +0000 (23:12 +0200)]
[BUGFIX] Explicit cast to string for VersionState object

Some DB drivers are picky on their arguments not being
objects. Add an explicit cast to string for a VersionState
object just before it's fed to a query as argument.

Change-Id: I81c8f9dded7068ad7bf817e034aa67a29f28290c
Resolves: #81309
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/52917
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>