Packages/TYPO3.CMS.git
2 years ago[TASK] Update typo3/cms-composer-installers 70/54570/3
Alexander Opitz [Mon, 6 Nov 2017 12:05:21 +0000 (13:05 +0100)]
[TASK] Update typo3/cms-composer-installers

Update the lock file to pull in the latest (1.4.5) release.
This version is marked as PHP 7.2 compatible.
composer command: composer update typo3/cms-composer-installers

Releases: 8.7, master
Resolves: #82898
Change-Id: I6c491ae7e93f656c01a9ef12d88969057b182ba7
Reviewed-on: https://review.typo3.org/54570
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[TASK] EXT:form - cache merged YAML settings 06/54106/7
Ralf Zimmermann [Sun, 10 Sep 2017 16:51:35 +0000 (18:51 +0200)]
[TASK] EXT:form - cache merged YAML settings

Cache the merged YAML settings into the assets cache to improve the
performance.

Resolves: #82373
Releases: master, 8.7
Change-Id: I601364d5957f26f1b369b513534936820f72b78e
Reviewed-on: https://review.typo3.org/54106
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Tested-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Reduce PHP queries of pagetree SQL 74/54574/13
Benni Mack [Tue, 7 Nov 2017 06:36:31 +0000 (07:36 +0100)]
[TASK] Reduce PHP queries of pagetree SQL

The TYPO3 Backend PageTree, built in TYPO3 4.5, has
some strange quirks resolving DB records, doing
a lot of queries for fetching a single page multiple
times. This is unnecessary because this can be fetched
with one query, which happens anyway. Additionally,
the WSOL should only happen when a workspace is selected.

Explicitly querying for "-1" pid etc. should be handled
via SQL, and not explicitly implemented by the page tree.

Bottom line: Remove one SQL-query per page which is loaded.

As most of the PHP classes will be restructured with the upcoming
ExtJS / ExtDirect removal, the removed methods will be part
of the breaking change of ExtJS removal.

Resolves: #82945
Releases: master
Change-Id: I7b1d79b40d0e9212cc0884c9440e5725e4f74d8e
Reviewed-on: https://review.typo3.org/54574
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Properly encode text in JS in install tool 86/54586/4
Susanne Moog [Wed, 8 Nov 2017 14:30:11 +0000 (15:30 +0100)]
[BUGFIX] Properly encode text in JS in install tool

Several times the install tool was using html()
instead of text(). Use text() whenever possible.

Resolves: #82949
Releases: master
Change-Id: I9a199d33f233a3b6c6b82965d4bc169999a3452a
Reviewed-on: https://review.typo3.org/54586
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Michael Oehlhof <typo3@oehlhof.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Update ext:styleguide to 9.0.0 92/54592/4
Christian Kuhn [Wed, 8 Nov 2017 14:54:06 +0000 (15:54 +0100)]
[TASK] Update ext:styleguide to 9.0.0

The v9/master branch of styleguide generates correct
page localizations of styleguide demo data pages in
table pages instead of pages_language_overlay.

Change-Id: I1186f421cb4c5f05e508d19e60b9a580a7c3d5dc
Resolves: #82952
Related: #82445
Releases: master
Reviewed-on: https://review.typo3.org/54592
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update ext:styleguide to 8.0.13 88/54588/3
Christian Kuhn [Wed, 8 Nov 2017 13:03:51 +0000 (14:03 +0100)]
[TASK] Update ext:styleguide to 8.0.13

This is probably the last version with v8 and v9
in sync before branching off styleguide v8.

Styleguide introduced a new table with 8.0.13, one
of the acceptance tests that uses a rather hard coded
xpath now needs a slightly different selector to cope
with that.

Change-Id: I7ef4f840807963e6a93a90bda394657b8c36c6a0
Resolves: #82951
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54588
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][FEATURE] Load new content element wizard via modal instead of new page 87/54587/3
Andreas Fernandez [Wed, 8 Nov 2017 12:31:17 +0000 (13:31 +0100)]
[FOLLOWUP][FEATURE] Load new content element wizard via modal instead of new page

Ensure that jQuery is available in NewRecordController.

Resolves: #75676
Releases: master
Change-Id: Idf437554fb136e8e4ae18ce0d229d6b3ed8a58e4
Reviewed-on: https://review.typo3.org/54587
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[FEATURE] Load new content element wizard via modal instead of new page 99/52999/40
Cybercraft [Thu, 1 Jun 2017 16:22:40 +0000 (18:22 +0200)]
[FEATURE] Load new content element wizard via modal instead of new page

Instead of having the new content element wizard in a separate module page
it will be opened in a modal now.

Resolves: #75676
Releases: master
Change-Id: If117fe3f2d55a4163bcb5c153b47938953050348
Reviewed-on: https://review.typo3.org/52999
Tested-by: Bjoern Jacob <bjoern.jacob@tritum.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[!!!][TASK] Migrate pages_language_overlay into pages 72/51272/88
Benni Mack [Thu, 2 Nov 2017 11:29:51 +0000 (12:29 +0100)]
[!!!][TASK] Migrate pages_language_overlay into pages

The patch migrates all data from pages_language_overlay into pages,
and moves all API calls to overlay pages.

The following restrictions are set:
* Backend is always showing pages only for "sys_language_uid=0"
  for the page tree, element browser (e.g. "linking to default
  language page"), except where explicitly requested like the Page
  Module => Languages view.
* pid and sorting are always the same for all translations and
  their default language page
* Elements on a page are always keeping the field "pid" to the
  default language page (no change)
* Permission checks for Backend users are always made against
  the default language page (perms_* fields and webmounts)

Resolves: #82445
Releases: master
Change-Id: I62536e21d7110fa434c75fbd4470a3f53b79d260
Reviewed-on: https://review.typo3.org/51272
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[!!!][TASK] Remove sys_domain.forced database field 40/54540/8
Benni Mack [Fri, 3 Nov 2017 10:43:48 +0000 (11:43 +0100)]
[!!!][TASK] Remove sys_domain.forced database field

The DB setting "sys_domain.forced" is confusing and does not make sense
nowadays, especially with nested domain records - where the rootline is now
correctly traversed with the RootLine utility.

Resolves: #82926
Releases: master
Change-Id: I874c54aeb03c0b62c9a1cebc9d629cee7550ec0b
Reviewed-on: https://review.typo3.org/54540
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Daniel Gorges <daniel.gorges@b13.de>
Tested-by: Daniel Gorges <daniel.gorges@b13.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Add workspace overlay for translated page title 83/54583/2
Georg Ringer [Tue, 7 Nov 2017 19:40:29 +0000 (20:40 +0100)]
[BUGFIX] Add workspace overlay for translated page title

The title of a translated page must be overlayed with the
workspace version.

Resolves: #65607
Releases: master, 8.7, 7.6
Change-Id: If10260f196776a16a53968b78542827ecbc145fe
Reviewed-on: https://review.typo3.org/54583
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] TcaMigration should not skip on existing overrideChildTca 93/52693/5
Malte Koitka [Wed, 3 May 2017 07:42:16 +0000 (09:42 +0200)]
[BUGFIX] TcaMigration should not skip on existing overrideChildTca

If an overideChildTca key is already added by a TYPO3 core
function like ExtensionManagementUtility::getFileFieldTCAConfig()
the TCA migration should not be skipped. Otherwise the config will
be incomplete and result in missing fields.

The migration is changed that old "foreign_types",
"foreign_selector_fieldTcaOverride" and "foreign_record_defaults"
are merged into new "overrideChildTca", but the new settings
are keps (take precedence) if given.

Resolves: #80719
Resolves: #81045
Releases: master, 8.7
Change-Id: Ic8a0338e0a9882b3b1e7abcd3123fbd7aa2b3505
Reviewed-on: https://review.typo3.org/52693
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Unify Backend module registration for Extbase modules 31/54531/13
Benni Mack [Thu, 2 Nov 2017 14:03:23 +0000 (15:03 +0100)]
[TASK] Unify Backend module registration for Extbase modules

This patch unifies the Backend module registration for Extbase modules
like it has already been done for all other Backend modules using PSR-7
entry-points. This way backend route dispatching and module registration
has been simplified.

The entrypoint for Extbase Backend modules is now
\TYPO3\CMS\Extbase\Core\Bootstrap->handleBackendRequest()
which returns a PSR-7 response object.

The following functionality has been marked as deprecated as it was
solely built to handle Extbase modules when conf.php and index.php were
still in style:

ExtensionManagementUtility::configureModule()
$GLOBALS['TBE_MODULES']['_configuration'][$name]['configureModuleFunction']

Releases: master
Resolves: #82902
Related: #58621
Change-Id: I7956b350d650ed52bc7b5d83db20df386d79eb65
Reviewed-on: https://review.typo3.org/54531
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Filter duplicate cache commands from CacheQueue 69/54569/2
Benjamin Rannow [Mon, 6 Nov 2017 11:58:49 +0000 (12:58 +0100)]
[TASK] Filter duplicate cache commands from CacheQueue

under the right condition multiple duplicate cache commands are executed

for Example: save a record in Backend can course multiple 'pages'
commands will be executed, if the record has inline records.

flushing '20' times the 'pages' cache is unnecessary.

Resolves: #82930
Releases: master, 8.7
Change-Id: I69e581cb7f12acbd8172b2ca88e89f93ebfbe4b4
Reviewed-on: https://review.typo3.org/54569
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Apply JS CGL on SvgTree files 72/54572/2
Tymoteusz Motylewski [Mon, 6 Nov 2017 21:59:23 +0000 (22:59 +0100)]
[TASK] Apply JS CGL on SvgTree files

In order to make page tree smaller and easier to review,
this patch applies new JS CGLs on SvgTree related files.

Releases: master
Resolves: #82935
Change-Id: I5c9b8b889b21e77b4bcd7add2236eb849d204356
Reviewed-on: https://review.typo3.org/54572
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Add Fluid expressions and pre-processors global config 95/54395/4
Claus Due [Sat, 14 Oct 2017 12:19:49 +0000 (14:19 +0200)]
[TASK] Add Fluid expressions and pre-processors global config

This patch moves a previously hardcoded list of Fluid
implementations from the RenderingContext constructor,
to TYPO3_CONF_VARS. Extensions and site administrators
can then add their own implementations to this array and
have them be used in every RenderingContext.

See included RST file for further information on usage.

Change-Id: I6190ceb410e1121ea935a31237cb8bcd0b2f0417
Resolves: #82763
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54395
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mattias Nilsson <tollepjaer@gmail.com>
Tested-by: Mattias Nilsson <tollepjaer@gmail.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Jan Stockfisch <jan.stockfisch@googlemail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[BUGFIX] Element file browser respects allowedExtensions 20/54520/2
Christian Kuhn [Wed, 1 Nov 2017 13:05:33 +0000 (14:05 +0100)]
[BUGFIX] Element file browser respects allowedExtensions

The type=input, renderType=inputLink field control has an option
"allowedExtensions" to restrict the file element browser to specific
file endings. This option is now correctly considered in file browser.

Change-Id: Ic42bd0de06002f308d7db4098c704ca2574e4018
Resolves: #82861
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54520
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Fix path to language file in SelectTreeElement 71/54571/2
Tymoteusz Motylewski [Mon, 6 Nov 2017 20:38:21 +0000 (21:38 +0100)]
[BUGFIX] Fix path to language file in SelectTreeElement

Fixes missing labels in the svg category tree toolbar.

Releases: master
Resolves: #82934
Change-Id: Iac29bc35b40894630599b3fbec48daf870a8777a
Reviewed-on: https://review.typo3.org/54571
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[TASK] Updated Examples for Usage 46/54546/2
Dandy Umlauft [Fri, 3 Nov 2017 16:49:12 +0000 (17:49 +0100)]
[TASK] Updated Examples for Usage

Added default and inline usage for the optional attribute "allowedTags"

Maybe you have to think about the name, cause in
http://php.net/manual/de/function.strip-tags.php the second parameter is
called "allowableTags", and not "allowedTags" This can lead to a quick
overlooked error ;)

Releases: master
Resolves: #82912
Change-Id: Icc3cab9a931790e621f5593ea487c9b23b779e30
Reviewed-on: https://review.typo3.org/54546
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[TASK] Update typo3/cms-composer-installers 68/54568/2
Helmut Hummel [Mon, 6 Nov 2017 11:03:16 +0000 (12:03 +0100)]
[TASK] Update typo3/cms-composer-installers

Update the lock file to pull in the latest release.
composer command: composer update typo3/cms-composer-installers

Releases: 8.7, master
Resolves: #82898
Change-Id: Idde56a61ce718da2d06cc70fc0e53b834ac44981
Reviewed-on: https://review.typo3.org/54568
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
2 years ago[!!!][TASK] Remove hardly used pagetree related TS options 60/54560/3
Benni Mack [Sun, 5 Nov 2017 15:37:11 +0000 (16:37 +0100)]
[!!!][TASK] Remove hardly used pagetree related TS options

The following pageTSconfig options are removed:

- options.pageTree.excludeDoktypes
No doktypes are exclueded anymore in search.

- options.pageTree.disableIconLinkToContextmenu
Icon Links are always selected (option had no effect anymore).

- options.pageTree.searchInAlias
Alias is now always searched for.

- options.pageTree.hideFilter
The filter is always shown, this feature should not be available
on a per-user basis.

Resolves: #82919
Releases: master
Change-Id: Ie0031fef9948bf758e880b04662210d74e27688b
Reviewed-on: https://review.typo3.org/54560
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Eugene Kenah Djomo <kdeugene@yahoo.fr>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Add parameter gclid to excludedParameters for cHash generation 62/54562/2
Georg Ringer [Mon, 6 Nov 2017 08:27:02 +0000 (09:27 +0100)]
[TASK] Add parameter gclid to excludedParameters for cHash generation

The parameter 'gclid' is used as click identifier for Google AdWords
and must not be used during the cHash generation.

Resolves: #82927
Releases: master, 8.7
Change-Id: Id279238738550cfbd0b86e6decf94a86230535ee
Reviewed-on: https://review.typo3.org/54562
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Fix PHP Notices in cached ext_localconf.php 57/54557/2
Tymoteusz Motylewski [Sat, 4 Nov 2017 20:05:16 +0000 (21:05 +0100)]
[BUGFIX] Fix PHP Notices in cached ext_localconf.php

Resolves: #82920
Releases: master, 8.7
Change-Id: I7a533f56ec68a119c19aad6c87de9dfc2e59dc6a
Reviewed-on: https://review.typo3.org/54557
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[BUGFIX] Replace forgotten back button to new button API 22/53722/2
Wouter Wolters [Thu, 17 Aug 2017 12:36:55 +0000 (14:36 +0200)]
[BUGFIX] Replace forgotten back button to new button API

With #69884 the new button API was introduced but the back button
in DatabaseRecordList was forgotten. The button is now done with
the new API.

Resolves: #82056
Releases: master
Change-Id: Icc6480af3a1b4a04e7222dc92cdb58bf9549007d
Reviewed-on: https://review.typo3.org/53722
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Georg Tiefenbrunn <georg.tiefenbrunn@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[!!!][TASK] Remove TS option page.stylesheet 49/54549/2
Georg Ringer [Fri, 3 Nov 2017 18:49:01 +0000 (19:49 +0100)]
[!!!][TASK] Remove TS option page.stylesheet

Remove the TypoScript option 'page.stylesheet' in favor of
using `page.includeCSS`.

Resolves: #82915
Releases: master
Change-Id: If8bb68a1520c23096ab0729caba681031c6a5401
Reviewed-on: https://review.typo3.org/54549
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[!!!][TASK] Remove the TS option page.bodyTagMargins 48/54548/2
Georg Ringer [Fri, 3 Nov 2017 17:39:37 +0000 (18:39 +0100)]
[!!!][TASK] Remove the TS option page.bodyTagMargins

The option 'page.bodyTagMargins' is rarly used and can be removed.
Any style information should be placed in a CSS file.

Resolves: #82914
Releases: master
Change-Id: Ib34ae835d0e50653b70f7ecf9573f42fbcca83a6
Reviewed-on: https://review.typo3.org/54548
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Tested-by: Frans Saris <franssaris@gmail.com>
2 years agoRevert "[BUGFIX] Set _localizedUid in OriginColumnName" 51/54551/4
Helmut Hummel [Sat, 4 Nov 2017 00:59:24 +0000 (02:59 +0200)]
Revert "[BUGFIX] Set _localizedUid in OriginColumnName"

This reverts commit 68e8530319faea18fbc61eee55fc00298582e8de.

The patch needs to be reverted due to wrong implementation.
The desired goal is not achievable at all with the current code base.

Reverts: #66535
Releases: master, 8.7
Change-Id: Ibd8eb7c4023d1b9f0e0de8b75d66193d66b89147
Reviewed-on: https://review.typo3.org/54551
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Nicole Cordes <typo3@cordes.co>
Tested-by: Nicole Cordes <typo3@cordes.co>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[FOLLOWUP][FEATURE] Add MetaTag API 54/54554/2
Mathias Schreiber [Sat, 4 Nov 2017 14:28:40 +0000 (15:28 +0100)]
[FOLLOWUP][FEATURE] Add MetaTag API

Bring back the meta generator which got lost in the original patch

Resolves: #81464
Releases: master
Change-Id: I5c68e35bdab953c8ff3df3afd85099439ed42787
Reviewed-on: https://review.typo3.org/54554
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Refactor implementation of PaginateWidget 76/53376/2
Claus Due [Sun, 2 Jul 2017 00:04:07 +0000 (02:04 +0200)]
[TASK] Refactor implementation of PaginateWidget

Refactors templates to minimise the impact of using the
uncompilable PaginateWidget. By moving the Widget to
a separate partial and the body rendered by the Widget
to another partial the impact is reduced to a minimum,
because the uncompilable template has just two nodes.

Change-Id: I6f1d528ed0c45d776c4952596ac5a8828d04f477
Resolves: #81766
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/53376
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[FEATURE] Add Meta Tag API 10/53110/23
Mathias Schreiber [Sun, 4 Jun 2017 07:50:28 +0000 (09:50 +0200)]
[FEATURE] Add Meta Tag API

TYPO3 now allows to set, get and unset meta tags with an clear and
concise API. This API allows it to set any meta tag via an extension
while having the possibility to get the current content of a given meta
tag.
Unsetting meta tags allows to remove unwanted tags from 3rd party code.

Resolves: #81464
Resolves: #22992
Resolves: #52471

Releases: master
Change-Id: I31c2c29e29242ad9c2fadf2b625ae04288cc3bb5
Reviewed-on: https://review.typo3.org/53110
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[FEATURE] Add possibility to get a label in a specific language 67/53967/4
Markus Hoelzle [Thu, 7 Sep 2017 14:45:39 +0000 (16:45 +0200)]
[FEATURE] Add possibility to get a label in a specific language

Add possibility to get a label in a specific language in
LocalizationUtility::translate() and the TranslateViewHelper

Change-Id: I8589e2b155e57eed3124ed48b0d859fe7796ff3b
Resolves: #82354
Related: #81834
Releases: master
Reviewed-on: https://review.typo3.org/53967
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Joerg Kummer <typo3@enobe.de>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[!!!][FEATURE] Added deleted field for scheduler task 56/51656/7
Pascal Rinker [Mon, 13 Feb 2017 12:57:30 +0000 (13:57 +0100)]
[!!!][FEATURE] Added deleted field for scheduler task

Add a deleted flag to database table "tx_scheduler_task".
Any task execution will also consider this field.

Resolves: #79777
Releases: master
Change-Id: I9f96ae9b255042ebf4ba3c812726cbf5ba4fa41c
Reviewed-on: https://review.typo3.org/51656
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Remove TypoScript option config.typolinkCheckRootline 45/54545/3
Benni Mack [Fri, 3 Nov 2017 14:52:51 +0000 (15:52 +0100)]
[TASK] Remove TypoScript option config.typolinkCheckRootline

The TypoScript option 'config.typolinkCheckRootline' was introduced
back in TYPO3 v4.x when there was no proper rootline cache or sys_domain
cache in place, in order to resolve the proper domain.

This now has changed, and this option can be removed in order to simplify
page link generation.

When in a multi-site setup, this option MUST be active otherwise it will
result in ugly and hard-to-debug side-effects.

For a single-site setup having this option disabled will result in a marginal
performance decrease (one SQL query more) when linking to a page with a
sys_domain record available.

A deprecation notice is thrown if your TypoScript setup still includes this option.

Resolves: #82909
Releases: master
Change-Id: I36abcdd1e2eabe2da66d8edd720a5a27ec306ede
Reviewed-on: https://review.typo3.org/54545
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] FormEngine: returnUrl handling in inline 43/54543/3
Christian Kuhn [Fri, 3 Nov 2017 11:42:09 +0000 (12:42 +0100)]
[BUGFIX] FormEngine: returnUrl handling in inline

If an inline child, opened via ajax request, generates links leaving
the current records and opening a different one, on closing that
record the returnUrl is wrong and points to the url of the inline
ajax request.
The original return url of the main record is lost in the compile chain.
The returnUrl data provider sets $data['returnUrl'] to current url if not
otherwise given.
The patch hands over the original return url to the inline ajax controller
and lets it 'sink down' in the data compile chain to inline children so
the original return url is available when container or elements generate urls.
Additionally some broken 'returnURL' handling in InlineRecordContainer
and jsfunc.inline.js is cleaned up and removed.

Change-Id: Ia47dc8cee068fc9c4d1c5e16c1960b1a58fcb2f5
Resolves: #82525
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54543
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Kjeld Schumacher <k.schumacher@familie-redlich.de>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Set JS .editorconfig indent style to 2 spaces 34/54534/3
Tymoteusz Motylewski [Thu, 2 Nov 2017 15:23:25 +0000 (16:23 +0100)]
[TASK] Set JS .editorconfig indent style to 2 spaces

Resolves: #82900
Releases: master
Change-Id: I9e80f662981dc107d5bcd1e4fc28bcf9d2ff3b4a
Reviewed-on: https://review.typo3.org/54534
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Remove unused ExtJS inclusion in System->Log 42/54542/2
Benni Mack [Fri, 3 Nov 2017 11:04:19 +0000 (12:04 +0100)]
[BUGFIX] Remove unused ExtJS inclusion in System->Log

Resolves: #82908
Releases: master
Change-Id: I96d661e294a737e36a084d4fa7423cc9257d1578
Reviewed-on: https://review.typo3.org/54542
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[TASK] Deprecate ClientUtility 38/54538/4
Georg Ringer [Thu, 2 Nov 2017 19:37:19 +0000 (20:37 +0100)]
[TASK] Deprecate ClientUtility

The class ClientUtility is outdated and not used anymore and can be
deprecated.

Resolves: #82903
Releases: master
Change-Id: I616b4518bfebac8239ecca0b48cad1b037c0ba6d
Reviewed-on: https://review.typo3.org/54538
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Make SVG category tree use JS Icon API 68/54468/7
Tymoteusz Motylewski [Tue, 24 Oct 2017 11:27:08 +0000 (13:27 +0200)]
[TASK] Make SVG category tree use JS Icon API

This change make SVG tree expect icon identifier instead of icon source
in JSON node data.
Tree fetches icon source via JS Icon API only once per icon type.
This makes JSON response few times smaller.

Resolves: #82849
Releases: master
Change-Id: I8954837f68cee3bcc316bc56e30788e0d16c81d6
Reviewed-on: https://review.typo3.org/54468
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Ensure cache tags are strings in workspaces 35/54535/2
Susanne Moog [Thu, 2 Nov 2017 15:24:33 +0000 (16:24 +0100)]
[BUGFIX] Ensure cache tags are strings in workspaces

On SQLServer you cannot insert integers in varchar
columns therefore the workspaces module ajax requests
are failing and you cannot use the module.

Cast the workspaceId to a string before using it as a
cache tag.

Change-Id: I0827dd6dddd9203fb7846934a034b826a515cdf3
Resolves: #82901
Releases: master
Reviewed-on: https://review.typo3.org/54535
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[!!!][TASK] Streamline ExtensionManagementUtility 23/54523/5
Benni Mack [Thu, 2 Nov 2017 05:54:47 +0000 (06:54 +0100)]
[!!!][TASK] Streamline ExtensionManagementUtility

The following functionality within this API class is marked as deprecated:
- siteRelPath()
- getExtensionKeyByPrefix()
- removeCacheFiles()
- second parameter of isLoaded()

Additionally, the following more strict rules apply now:
- addNavigationComponent() always requires an $extensionKey
- First parameter of addLLrefForTCAdescr() must not be empty
- addService() requires $serviceType and $info to be non-empty
- addPlugin() always requires an $extensionKey
- addStaticFile() throws exceptions if no extension key or path is set
- addTypoScript() expects $type to be either "setup" or "constants"

This is meant for extension developers using the current API more properly
than before.

Resolves: #82899
Releases: master
Change-Id: Ie5beddd4787da25f05f76ff37c6ec55a92257001
Reviewed-on: https://review.typo3.org/54523
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Add checks to ReflectionService to have correct return values 10/54510/6
Markus Klein [Tue, 31 Oct 2017 06:51:35 +0000 (07:51 +0100)]
[BUGFIX] Add checks to ReflectionService to have correct return values

Resolves: #82885
Releases: master, 8.7
Change-Id: I422f920187186fe83b6043f806fc1be9a16c8a25
Reviewed-on: https://review.typo3.org/54510
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Tested-by: Alexander Schnitzler <review.typo3.org@alexanderschnitzler.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][TASK] Migrate EXT:version into EXT:workspaces 14/54514/8
Benni Mack [Tue, 31 Oct 2017 20:24:43 +0000 (21:24 +0100)]
[!!!][TASK] Migrate EXT:version into EXT:workspaces

The concept of versioning records based on how it is
integrated into TYPO3 only makes sense in conjunction
with workspaces / stages. All other methods are not
supported. Thus, the logic of versioning of records
is moved into EXT:workspaces, making EXT:version
obsolete.

Checks against EXT:version is now handled against
"workspaces" throughout the core, with a fallback
within ExtensionManagementUtility::isLoaded().

Resolves: #82896
Releases: master
Change-Id: I8887b868892c8aa6c36db7d2841f6edf5476d6f7
Reviewed-on: https://review.typo3.org/54514
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[CLEANUP] Minor argument and comment cleanup 24/54524/2
Benni Mack [Thu, 2 Nov 2017 06:16:55 +0000 (07:16 +0100)]
[CLEANUP] Minor argument and comment cleanup

Some methods are called with default arguments, which can be omitted
when calling the methods.

Additionally, some PHPdoc comments was wrongly defined, which were
modified.

No change of behaviour.

Resolves: #82897
Releases: master
Change-Id: I1a22e7e3c4aff74f32c67bacb406a6a97d96b0d0
Reviewed-on: https://review.typo3.org/54524
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Handle returnUrl for access module 04/54504/2
Markus Klein [Mon, 30 Oct 2017 19:56:30 +0000 (20:56 +0100)]
[BUGFIX] Handle returnUrl for access module

With this fix the access module again returns to the correct
page the user expects it to return to.

Resolves: #82883
Releases: master, 8.7, 7.6
Change-Id: I76953aa1547365db6fbbea772d786e1ad9bfc184
Reviewed-on: https://review.typo3.org/54504
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Access module preselects owner/group when changed via AJAX 07/54507/2
Markus Klein [Mon, 30 Oct 2017 20:42:05 +0000 (21:42 +0100)]
[BUGFIX] Access module preselects owner/group when changed via AJAX

Resolves: #79915
Releases: master, 8.7, 7.6
Change-Id: Ie3b573857ff011295be198633a0f6868b1ff55b6
Reviewed-on: https://review.typo3.org/54507
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[!!!][TASK] Remove global variable PARSETIME_START 17/54517/3
Benni Mack [Wed, 1 Nov 2017 11:34:37 +0000 (12:34 +0100)]
[!!!][TASK] Remove global variable PARSETIME_START

The global variable $GLOBALS['PARSETIME_START'] is removed,
as it has been superseded by $GLOBALS['TYPO3_MISC']['microtime_start']
for a long time already.

Resolves: #82893
Releases: master
Change-Id: Ic738ebb1ae4dd19aff426fcd32b8f7a3594ca2e4
Reviewed-on: https://review.typo3.org/54517
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Show allowed media sources in "Add media by URL" modal 37/54437/10
Gianluigi Martino [Wed, 18 Oct 2017 15:16:52 +0000 (17:16 +0200)]
[TASK] Show allowed media sources in "Add media by URL" modal

In the modal view of "Add media by URL" the possible sources from where
media can be embedded are now shown.

Resolves: #82545
Releases: master, 8.7
Change-Id: I07ffedcf074b6af1e03113375f3d110916e3b034
Reviewed-on: https://review.typo3.org/54437
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
2 years ago[TASK] Unify spelling of "YAML" throughout the core 16/54516/3
Riccardo De Contardi [Wed, 1 Nov 2017 10:54:46 +0000 (11:54 +0100)]
[TASK] Unify spelling of "YAML" throughout the core

The correct spelling of the abbreviation is "YAML".
Standardized throughout the comments.

Resolves: #82459
Releases: master
Change-Id: I60847674b5dd8fc6222ae18c226f8ab584e3be84
Reviewed-on: https://review.typo3.org/54516
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
2 years ago[BUGFIX] Set _localizedUid in OriginColumnName 76/54376/5
Alexander Opitz [Tue, 7 Jul 2015 12:28:10 +0000 (14:28 +0200)]
[BUGFIX] Set _localizedUid in OriginColumnName

While saving an object the _localizedUid will be saved into the DB
column which is defined in TranslationOriginalColumnName.

Resolves: #66535
Releases: master,8.7
Change-Id: Ib23b97f90e805bd1107a3aac5b199f010ab231b3
Reviewed-on: https://review.typo3.org/54376
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[TASK] Remove obsolete IE6 condition in debug exception handler 15/54515/3
Benni Mack [Tue, 31 Oct 2017 20:40:55 +0000 (21:40 +0100)]
[TASK] Remove obsolete IE6 condition in debug exception handler

Some very lonesome IE6 check can be removed for
debugging purposes now, since IE6 support has been dropped
for a long time, and for debugging purposes especially this
use-case does not exist anymore.

Resolves: #82891
Releases: master
Change-Id: I166d5becea3b1c6a53e1a1e50dcb1731332229e6
Reviewed-on: https://review.typo3.org/54515
Reviewed-by: Riccardo De Contardi <erredeco@gmail.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[FOLLOWUP][BUGFIX] Ensure absolute paths for &eID=dumpFile 89/53789/5
Helmut Hummel [Wed, 23 Aug 2017 11:01:36 +0000 (13:01 +0200)]
[FOLLOWUP][BUGFIX] Ensure absolute paths for &eID=dumpFile

This follow-up patch ensures the link is properly generated when
generating it from a Backend context, e.g., when embedding an image
within CKEditor and when TYPO3 is within a subdirectory.

Change-Id: I9783344c70c8cdfd6660a69dff72b251b2964c16
Resolves: #81486
Releases: master
Reviewed-on: https://review.typo3.org/53789
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Frans Saris <franssaris@gmail.com>
Reviewed-by: Xavier Perseguers <xavier@typo3.org>
Reviewed-by: Alexander Opitz <opitz.alexander@googlemail.com>
Tested-by: Alexander Opitz <opitz.alexander@googlemail.com>
2 years ago[BUGFIX] Move doctrine initalization to connect() method 32/54432/4
Alexander Stehlik [Wed, 18 Oct 2017 02:40:16 +0000 (04:40 +0200)]
[BUGFIX] Move doctrine initalization to connect() method

The event and custom type initalization of doctrine is moved
to an overwritten connect() method in the Connection class.

This prevents a premature establishment of a database connection
by calls to getDatabasePlatform().

This fixes the page unavailable during the connectToDB() in
the Frontend request handling.

Change-Id: Id6087002c7cbb9ed3938c4627d63b77515a7108f
Releases: master, 8.7
Resolves: #82795
Reviewed-on: https://review.typo3.org/54432
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Tested-by: Morton Jonuschat <m.jonuschat@mojocode.de>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
2 years ago[FOLLOWUP][!!!][TASK] Replace ClassInfo with ClassSchema 82/54482/2
Alexander Schnitzler [Fri, 27 Oct 2017 10:23:36 +0000 (12:23 +0200)]
[FOLLOWUP][!!!][TASK] Replace ClassInfo with ClassSchema

Increase test coverage of ClassSchema and ReflectionService

Releases: master
Resolves: #57594
Resolves: #55654
Change-Id: If413dc0b428f94dffef13e1875e3a7af4f9939b7
Reviewed-on: https://review.typo3.org/54482
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] EXT:form - really disable records overview in redirect finisher 35/54435/2
Mathias Brodala [Wed, 18 Oct 2017 07:38:42 +0000 (09:38 +0200)]
[BUGFIX] EXT:form - really disable records overview in redirect finisher

Resolves: #82786
Releases: master, 8.7
Change-Id: I9cdfbcd5e0f25b832ea546f1b8c70a9f544b31aa
Reviewed-on: https://review.typo3.org/54435
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Catch UnknownLinkHandlerException in InputLinkElement 69/54469/4
Georg Ringer [Tue, 24 Oct 2017 14:37:27 +0000 (16:37 +0200)]
[BUGFIX] Catch UnknownLinkHandlerException in InputLinkElement

Catch another exception to avoid a breaking backend.

Resolves: #82850
Releases: master, 8.7
Change-Id: I349aae21932beb5d45c1cec1b1211d3400d1d969
Reviewed-on: https://review.typo3.org/54469
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Fix foreign_table_where GROUP BY handling 73/54473/5
Wolfgang Klinger [Wed, 25 Oct 2017 10:39:31 +0000 (12:39 +0200)]
[BUGFIX] Fix foreign_table_where GROUP BY handling

Unpack the array elements before passing them on

Resolves: #82159
Releases: master, 8.7
Change-Id: I6a094927f595d42fc15bb96a9dbc1d313a7808b0
Reviewed-on: https://review.typo3.org/54473
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Show default site name in installation wizard 90/54490/2
Nicole Cordes [Sat, 28 Oct 2017 10:44:33 +0000 (12:44 +0200)]
[BUGFIX] Show default site name in installation wizard

Currently in step 4 the input box for the site name is empty. This patch
re-adds the default site name from FactoryConfiguration.php as initial
value.

Resolves: #82876
Releases: master
Change-Id: I391254cf7ae6e5f8aa45003035aebaf513e733d3
Reviewed-on: https://review.typo3.org/54490
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[!!!][BUGFIX] Throw exception on invalid charset 71/54471/3
Mathias Brodala [Wed, 25 Oct 2017 07:45:08 +0000 (09:45 +0200)]
[!!!][BUGFIX] Throw exception on invalid charset

This gives users a clear hint if e.g. config.metaCharset contains
an invalid value instead of showing a blank page.

Change-Id: I9cdb37cc7e61af10e2d1985ef43f488e53b17a48
Resolves: #82852
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54471
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Wolfgang Klinger <wolfgang@wazum.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
2 years ago[BUGFIX] Ensure correct page is selected in page tree 91/54491/3
Helmut Hummel [Sat, 28 Oct 2017 10:35:24 +0000 (12:35 +0200)]
[BUGFIX] Ensure correct page is selected in page tree

There are several actions in the backend that should
trigger a certain page to be selected in the tree.

Among others these are: open documents toolbar, live search,
favorites.

Fix every scenario in which these actions are triggered
(e.g. page tree was already initialized or not), make
sure the desired page will always be selected and
properly store the selection in the various states
so that the selection persists tree refreshes.

In addition we ensure that the content frame will
be called with the correct id, if the module uses
the page tree as navigation component.

Releases: master, 8.7
Resolves: #82877
Change-Id: I1904c02b2246f01202c6607a9b718aebe0e33341
Reviewed-on: https://review.typo3.org/54491
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Tested-by: Jigal van Hemert <jigal.van.hemert@typo3.org>
Reviewed-by: Helmut Hummel <typo3@helhum.io>
Tested-by: Helmut Hummel <typo3@helhum.io>
2 years ago[BUGFIX] Fix usages of config.additionalHeaders 85/54485/4
Markus Klein [Fri, 27 Oct 2017 13:49:00 +0000 (15:49 +0200)]
[BUGFIX] Fix usages of config.additionalHeaders

Update some internal usages of config.additionalHeaders in tests
and other places to use the correct new syntax.

Resolves: #82871
Releases: master, 8.7
Change-Id: I44868a736751647c3aa62bd5dc29f0bce5588c10
Reviewed-on: https://review.typo3.org/54485
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Add .tsconfig files to .editorconfig 93/54493/3
Peter Kraume [Sun, 29 Oct 2017 12:06:28 +0000 (13:06 +0100)]
[TASK] Add .tsconfig files to .editorconfig

Add definition for new TSConfig filetype .tsconfig to .editorconfig
file.

Change-Id: I3fd87abc8a8fe554692f61e548e37d4d02f74fa4
Resolves: #82879
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54493
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Flexform Form ID should not contain brackets 71/52771/7
Benjamin Serfhos [Thu, 11 May 2017 12:30:15 +0000 (14:30 +0200)]
[BUGFIX] Flexform Form ID should not contain brackets

Using brackets in flexform elements caused the javascript to be disabled
for the element.
While using a custom form id that can be used as HTML id="" this is
bypassed and fixes all javascript interaction.

Releases: master, 8.7
Resolves: #80908
Change-Id: I91f39b2fed61076b7139603fedc7b268546d64cd
Reviewed-on: https://review.typo3.org/52771
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
Tested-by: Tymoteusz Motylewski <t.motylewski@gmail.com>
2 years ago[!!!][TASK] Remove DB field pages.no_cache 89/54489/4
Benni Mack [Fri, 27 Oct 2017 19:22:21 +0000 (21:22 +0200)]
[!!!][TASK] Remove DB field pages.no_cache

Having an option to completely disable the page rendering
cache available per page for editors is a real risk. This
option is largely hard to understand for an editor,
or an admin.

Integrators can still use `config.no_cache = 1` in
TypoScript on a condition basis to achieve the same
result.

Resolves: #82878
Releases: master
Change-Id: Ie6989acc0044a75e711253e4304f9b2b9d96a7e1
Reviewed-on: https://review.typo3.org/54489
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Only fetch fileReferences from localized table if column exist 79/54479/5
Benjamin Kott [Thu, 26 Oct 2017 15:54:56 +0000 (17:54 +0200)]
[BUGFIX] Only fetch fileReferences from localized table if column exist

Only if a localized table also contains the requested column for file
references it will overlay the previous generated resultset.

Resolves: #82860, #67741
Releases: master, 8.7
Change-Id: I21fd60454123488ea312d6c6241f2622eab3f14c
Reviewed-on: https://review.typo3.org/54479
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Do not turn E_USER_DEPRECATED errors into exceptions 67/54467/2
Markus Klein [Mon, 23 Oct 2017 16:12:35 +0000 (18:12 +0200)]
[BUGFIX] Do not turn E_USER_DEPRECATED errors into exceptions

Also use the silent upgrade wizard to correct existing settings.

Resolves: #82721
Releases: master
Change-Id: I8d163799cf0d1acfaaa9c2589a70b932144b6dc6
Reviewed-on: https://review.typo3.org/54467
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Claus Due <claus@phpmind.net>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Avoid race condition in JS Icon API 70/54470/3
Tymoteusz Motylewski [Tue, 24 Oct 2017 19:46:44 +0000 (21:46 +0200)]
[BUGFIX] Avoid race condition in JS Icon API

Now promise is cached instead of promise result, to avoid race condition
when requesting the same icon multiple times.
Now API will do just one ajax call per icon, even if the other API call
is made before the first one finishes.

Resolves: #82851
Releases: master, 8.7
Change-Id: I4110f84d32c7f1856c1664a02d3c9a2ba59168a6
Reviewed-on: https://review.typo3.org/54470
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Wolf <andreas.wolf@typo3.org>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Tested-by: Frank Naegler <frank.naegler@typo3.org>
2 years ago[BUGFIX] Allow multiline strings in foreign_table_where 74/54474/3
Wolfgang Klinger [Wed, 25 Oct 2017 11:48:15 +0000 (13:48 +0200)]
[BUGFIX] Allow multiline strings in foreign_table_where

Add the ’s’ (PCRE_DOTALL) modifier to regular expressions.

Resolves: #82854
Releases: master, 8.7
Change-Id: Ib5feaba0272e45dce1bc0b4cfedb11f5eb0b10c2
Reviewed-on: https://review.typo3.org/54474
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[FOLLOWUP][BUGFIX] Allow longer file-endings in typoscript directory includes 60/54460/2
Benni Mack [Fri, 20 Oct 2017 14:10:52 +0000 (16:10 +0200)]
[FOLLOWUP][BUGFIX] Allow longer file-endings in typoscript directory includes

Adds missing unit tests for this change.

Resolves: #82543
Releases: master, 8.7
Change-Id: Ica7f5c2f99dd991042e3c1166f7806534bf24421
Reviewed-on: https://review.typo3.org/54460
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Henning Liebe <h.liebe@neusta.de>
Tested-by: Henning Liebe <h.liebe@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Do not force content_fallback to default page language 26/54426/7
Benni Mack [Tue, 17 Oct 2017 22:06:21 +0000 (00:06 +0200)]
[BUGFIX] Do not force content_fallback to default page language

If a page translation is not available, the TypoScript option
`config.sys_language_mode` has the option
`content_fallback;listofuids` to define to which other language
translations should be fallen back.

However, if NONE of the defined page translations are available,
a fallback to the DEFAULT language is made (because the
foreach just does not apply) which can not be stopped at all.

To define an explicit 404 when a translated page NOR its
fallbacks are available the special keyword "pageNotFound" is added,
which can be added to
`config.sys_language_mode = content_fallback;3,2,pageNotFound`
and if none of 3,2 are available, a page not found message
is thrown.

Resolves: #82794
Releases: master, 8.7
Change-Id: I90af4e9f9685ffc7db8c562207e3df08786c0ca9
Reviewed-on: https://review.typo3.org/54426
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Sascha Rademacher <sascha.rademacher+typo3@gmail.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] MenuProcessor doesn't accept necessary sub keys 44/54444/2
Thorben Nissen [Thu, 19 Oct 2017 08:28:43 +0000 (10:28 +0200)]
[BUGFIX] MenuProcessor doesn't accept necessary sub keys

Adds subproperty keys for levels, expandAll, includeSpacer and
titleField to $allowedConfigurationKeys.
Adds the subproperty keys also $removeConfigurationKeysForHmenu.

Resolves: #82810
Releases: master, 8.7
Change-Id: Idd2e50b0b7a203ce0a0ecc490199bdf5305bef47
Reviewed-on: https://review.typo3.org/54444
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[FEATURE] Introduce new @import syntax for TS includes 46/54446/6
Benni Mack [Thu, 19 Oct 2017 14:27:16 +0000 (16:27 +0200)]
[FEATURE] Introduce new @import syntax for TS includes

The original '<INCLUDE_TYPOSCRIPT...>' syntax is hard to understand,
error-prone and overloaded with features.

This patch introduces a new way to include files based on SymfonyFinder
and simple logic to allow to include files or folders:

The following syntax (leaned towards SASS imports) is added:
Imports one file:

- @import 'EXT:myext/Configuration/TypoScript/myfile.typoscript'

Imports all files in a folder (always sorted by name):
- @import 'EXT:myext/Configuration/TypoScript/*'
- @import 'EXT:myext/Configuration/TypoScript/'

Imports all files ending with ".typoscript":
- @import 'EXT:myext/Configuration/TypoScript/*.typoscript'

Automatically adds '.typoscript' file ending and includes setup.typoscript
- @import 'EXT:myext/Configuration/TypoScript/setup'

This is all done with Symfony Finder to find the files.

Resolves: #82812
Releases: master
Change-Id: I4b64a087ef8c6aa85063c19c1882c9ed3448d9b5
Reviewed-on: https://review.typo3.org/54446
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[FEATURE] TCA: Allow label in palette array 49/54449/3
Christian Kuhn [Thu, 19 Oct 2017 22:34:20 +0000 (00:34 +0200)]
[FEATURE] TCA: Allow label in palette array

Allow 'label' within the 'palettes' array in TCA next
to 'showitem'. This defines a default label rendered as
the palette label in FormEngine if not overridden in
a 'types' definition like '--palette--;labelReference;thePalette'.

The patch introduces this feature in PaletteAndSingleContainer
of FormEngine code and adapts core TCA definitions to introduce
the default labels for palettes.

This makes the 'types' definitions shorter and much better readable
and gives the core an opportunity to steer the labels for palettes
which are often re-used by extension authors.

Change-Id: I185340d4e037d713eebbb6cd676287e6fe85705b
Resolves: #82826
Releases: master
Reviewed-on: https://review.typo3.org/54449
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Allow longer file-endings in typoscript directory includes 43/54443/3
Mathias Schreiber [Wed, 18 Oct 2017 23:13:52 +0000 (01:13 +0200)]
[BUGFIX] Allow longer file-endings in typoscript directory includes

Directory includes now allow more liberal substrings to include files
not only based on their extension (*.typoscript) but based on the last
part of their filename (*.setup.typoscript).

Resolves: #82543
Releases: master, 8.7
Change-Id: Ic2111b98a6e3935b542addfd712f4256aa40f888
Reviewed-on: https://review.typo3.org/54443
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[!!!][TASK] Scheduler: Drop "use atd" based execution 55/54455/2
Christian Kuhn [Fri, 20 Oct 2017 11:05:12 +0000 (13:05 +0200)]
[!!!][TASK] Scheduler: Drop "use atd" based execution

The feature to execute scheduler tasks via the "at daemon"
on unix found extremely little use in the wild and is
dropped from the core.

The implementation is rather clumsy, too, so we take
the opportunity to just drop this feature.

Change-Id: Ia3786953c41580ef6ea3b3c3ee21c1a82cab3dcd
Resolves: #82832
Releases: master
Reviewed-on: https://review.typo3.org/54455
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Tested-by: Stefan Neufeind <typo3.neufeind@speedpartner.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Fix adding avatars to user profile 51/54451/2
Susanne Moog [Fri, 20 Oct 2017 10:07:05 +0000 (12:07 +0200)]
[BUGFIX] Fix adding avatars to user profile

Check opener for null before usage.

Change-Id: I1ed9ac13bab5b76ef5ed8a24c04b07f9dd6d7f85
Resolves: #82829
Releases: master
Reviewed-on: https://review.typo3.org/54451
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Markus Sommer <markus.sommer@typo3.org>
Tested-by: Markus Sommer <markus.sommer@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Show upload files button in filelist options if folder 45/54345/4
Gianluigi Martino [Tue, 10 Oct 2017 06:24:27 +0000 (08:24 +0200)]
[TASK] Show upload files button in filelist options if folder

At the moment there is only a clickmenu entry to upload files
without entering the folder. With this patch the uploads files button is
also listed as button in option list.

Resolves: #82711
Releases: master, 8.7
Change-Id: Ice84d96a8ee5fad8dbcb9dbc728312ebb63df720
Reviewed-on: https://review.typo3.org/54345
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Gianluigi Martino <gmartino27@gmail.com>
Tested-by: Gianluigi Martino <gmartino27@gmail.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Install tool extension scanner .rst file core version 50/54450/2
Christian Kuhn [Fri, 20 Oct 2017 09:58:13 +0000 (11:58 +0200)]
[BUGFIX] Install tool extension scanner .rst file core version

The core version indicator in the extension scanner of the install
tool on reST files is broken on windows OS since path is split by
/ instead of \. Use DIRECTORY_SEPARATOR to fix this.

Change-Id: I57928468c1a4cae2a439bd55b00874d13f3569dc
Resolves: #82830
Releases: master
Reviewed-on: https://review.typo3.org/54450
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[BUGFIX] Add renderType to select 47/54447/2
Susanne Moog [Thu, 19 Oct 2017 21:24:20 +0000 (23:24 +0200)]
[BUGFIX] Add renderType to select

Add missing renderType for select box in form
flexform.

Change-Id: I58ade2720cf763cf26fc1d1e74457044ddfa054f
Resolves: #82825
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54447
Tested-by: TYPO3com <no-reply@typo3.com>
Tested-by: Riccardo De Contardi <erredeco@gmail.com>
Reviewed-by: Benni Mack <benni@typo3.org>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Mathias Brodala <mbrodala@pagemachine.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Update friendsofphp/php-cs-fixer to latest version 42/54442/3
Wouter Wolters [Wed, 18 Oct 2017 21:13:46 +0000 (23:13 +0200)]
[TASK] Update friendsofphp/php-cs-fixer to latest version

Resolves: #82806
Releases: master,8.7
Change-Id: I071c114db90b292936f5c3fd76c7ac74fd52bd60
Reviewed-on: https://review.typo3.org/54442
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
2 years ago[TASK] Extend WorkspaceServiceTests for fetchPagesWithVersionsInTable 45/54445/4
Susanne Moog [Thu, 19 Oct 2017 12:49:50 +0000 (14:49 +0200)]
[TASK] Extend WorkspaceServiceTests for fetchPagesWithVersionsInTable

Add new tests for fetchPagesWithVersionsInTable and correct comments.

Change-Id: I2fe08656ecddf3f7391e6012bb969dd85c2cfb24
Resolves: #82811
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54445
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Delete unavailable "recently switched to" users from UC 33/54433/7
Andreas Fernandez [Wed, 18 Oct 2017 06:57:41 +0000 (08:57 +0200)]
[BUGFIX] Delete unavailable "recently switched to" users from UC

If a user who appears in the "Recently switched to" list became
unavailable for some reason, only the placeholder avatar was rendered,
giving a slight hint of life in the past.

Such users are now deleted from UC and do not appear in the list anymore.
Furthermore, the section label was slightly modified to be more
understandable.

For performance reasons, only one query is triggered now and sorting is
done based on the array of UIDs stored in UC.

Resolves: #82796
Related: #80581
Releases: master
Change-Id: Ieff8a779639f277de1c0cb7feaa0fe2b82bd97c5
Reviewed-on: https://review.typo3.org/54433
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Remove "content_doktypes" 38/54438/4
Benni Mack [Wed, 18 Oct 2017 18:41:21 +0000 (20:41 +0200)]
[!!!][TASK] Remove "content_doktypes"

The global option "content_doktypes" is
1. outdated (still contains doktypes 2 which was removed in 4.x)
2. only in use for Workspace Preview Links and Frontend Editing to query page trees

However, the idea was to disallow content editing (QuickEdit) and skip
search of other doktypes for simple DB search (removed in TYPO3 v7)

This is not the case anymore and nowadays a hidden feature which is only
10% implemented, and just another tedious option bloating the system.

The option has been removed and also cleaned via SilentConfigurationUpgradeService.

Resolves: #82803
Releases: master
Change-Id: I4ca868f721142d2ac9f1de0c1a7bccc33086989b
Reviewed-on: https://review.typo3.org/54438
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Move AjaxLoginHandler to AjaxLoginController 41/54441/2
Benni Mack [Wed, 18 Oct 2017 21:02:19 +0000 (23:02 +0200)]
[TASK] Move AjaxLoginHandler to AjaxLoginController

The AjaxLoginHandler which does AJAX logic for login timeouts is be moved
to the proper location, as it is a controller.

A class alias is in place.

Resolves: #82805
Releases: master
Change-Id: I6a9fed6236d6d82150dec2ac7c2ce61bd194b8ec
Reviewed-on: https://review.typo3.org/54441
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] Remove style attribute in LiveSearch 39/54439/2
Andreas Fernandez [Wed, 18 Oct 2017 19:49:36 +0000 (21:49 +0200)]
[BUGFIX] Remove style attribute in LiveSearch

Currently, `beforeRender` removes some inline CSS so adjust the layout
of the suggest list. If the first search has no result, the layout is
broken because `beforeRender` is not called in case there are no results.

This patch removes the style attribute as early as possible.

Resolves: #82757
Releases: master, 8.7
Change-Id: I844b81aca43bd469dfdbb46516366f4786d0935f
Reviewed-on: https://review.typo3.org/54439
Reviewed-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: Mathias Schreiber <mathias.schreiber@typo3.com>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
2 years ago[BUGFIX] CKEditor: Make link editable 15/54415/3
Christoph Lehmann [Tue, 17 Oct 2017 14:37:06 +0000 (16:37 +0200)]
[BUGFIX] CKEditor: Make link editable

Fixes the TypeError

htmlspecialchars() expects parameter 1 to be string, null given

Resolves: #82787
Releases: master,8.7
Change-Id: I38a689022ed45c34a8ae78c046abe51803eb0f4c
Reviewed-on: https://review.typo3.org/54415
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Henrik Elsner <helsner@dfau.de>
Tested-by: Henrik Elsner <helsner@dfau.de>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Tested-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] Allow setting translateToMessage to empty 29/54429/3
Susanne Moog [Tue, 17 Oct 2017 23:06:30 +0000 (01:06 +0200)]
[BUGFIX] Allow setting translateToMessage to empty

Unsetting TCEMAIN.translateToMessage was not possible
due to a default fallback to a hardcoded string in
data handler.

This patch sets the default via PageTSConfig and
simplifies the condition / fallback logic.

Change-Id: Ie06410126a83de0e158c43cbfd6ee3d45176c363
Resolves: #82523
Releases: master
Reviewed-on: https://review.typo3.org/54429
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
2 years ago[BUGFIX] EXT:indexed_search: Dont add stat record for empty search 96/53396/3
Daniel Goerz [Tue, 4 Jul 2017 12:07:24 +0000 (14:07 +0200)]
[BUGFIX] EXT:indexed_search: Dont add stat record for empty search

Resolves: #81786
Releases: master, 8.7
Change-Id: I1bc5e93fdfb3a1068a09ae37c47e51b1811d58b5
Reviewed-on: https://review.typo3.org/53396
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Sascha Rademacher <s.rademacher@neusta.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[BUGFIX] Update tstamp on inline relation addition 23/54423/2
Susanne Moog [Tue, 17 Oct 2017 21:05:45 +0000 (23:05 +0200)]
[BUGFIX] Update tstamp on inline relation addition

If in a record with an inline relation a new relation
is added and nothing else is changed the timestamp
was not updated.

The logic to update the timestamp has now been added
to the remapStack processing.

Change-Id: I2eae7d1fb54b21dddc6e3609b1585ba484980b06
Resolves: #82576
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54423
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Oliver Hader <oliver.hader@typo3.org>
Tested-by: Oliver Hader <oliver.hader@typo3.org>
2 years ago[BUGFIX] Localization State does not properly sanitize and enrich 22/54422/3
Oliver Hader [Tue, 17 Oct 2017 20:59:31 +0000 (22:59 +0200)]
[BUGFIX] Localization State does not properly sanitize and enrich

The Localization State object has an incomplete assignment in the
constructor - sanitize processing is overridden by enrich processing,
however both should be combined instead.

The current side-effects were, that
* localization state could contain fields that were not defined in TCA
  having support for the `allowLanguageSynchronization` setting
* state values different than `custom`, `source` or `parent` have not
  been overridden by the default `parent` value

Resolves: #82793
Releases: 8.7, master
Change-Id: I25e794736df216b17a5b8de3bc5203bd18ee9694
Reviewed-on: https://review.typo3.org/54422
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] EXT:form - "label" is not set for the FormDefinition class 27/54227/2
Ralf Zimmermann [Thu, 28 Sep 2017 08:09:57 +0000 (10:09 +0200)]
[BUGFIX] EXT:form - "label" is not set for the FormDefinition class

Set the "label" property for the root form element
TYPO3\CMS\Form\Domain\Model\FormDefinition

Resolves: #82573
Releases: master,8.7
Change-Id: I57c45765e4af91da6094f8f7a469a1df2f6da1f5
Reviewed-on: https://review.typo3.org/54227
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Frank Naegler <frank.naegler@typo3.org>
Reviewed-by: Sonja Großewinkelmann <s.grossewinkelmann@neusta.de>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Make ReferenceIndex caching optional 84/53384/5
Benni Mack [Mon, 3 Jul 2017 13:21:03 +0000 (15:21 +0200)]
[BUGFIX] Make ReferenceIndex caching optional

The runtime caches used in the ReferenceIndex class
added in TYPO3 8.7.2 should not be added by default
but included on a per-runtime basis when extensions
would use the ReferenceIndex. Otherwise this issue
might lead to side-effects.

For master/9.0 the caches are enabled by default.

Relates: #78634
Resolves: #81771
Releases: master, 8.7
Change-Id: If7ca173d93c05658bce5f57c38842555a439d2ea
Reviewed-on: https://review.typo3.org/53384
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
2 years ago[BUGFIX] Add parseFunc handling to pre tags 19/54419/2
Susanne Moog [Tue, 17 Oct 2017 18:22:54 +0000 (20:22 +0200)]
[BUGFIX] Add parseFunc handling to pre tags

Pre tags are currently not passed through parseFunc
resulting in non-parsed t3:// links in the frontend.

As <pre> tags allow links (and other tags) inside, we
should parse them, too.

Change-Id: I5647f02b0d93b05ecaed8297c794b91255ea6d54
Resolves: #82789
Releases: master, 8.7
Reviewed-on: https://review.typo3.org/54419
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Benjamin Kott <benjamin.kott@outlook.com>
Tested-by: Benjamin Kott <benjamin.kott@outlook.com>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[BUGFIX] Refresh iconElement after its content has been replaced 58/53258/5
Nikita Hovratov [Sun, 18 Jun 2017 22:46:57 +0000 (23:46 +0100)]
[BUGFIX] Refresh iconElement after its content has been replaced

The variable iconElement refers now correctly to the original jQuery
object and is really reverted to the old class as the comment implies.

Resolves: #82624
Releases: master, 8.7
Change-Id: I13615bbee6d5148fe940bac49b72c2766c0a1de7
Reviewed-on: https://review.typo3.org/53258
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Joerg Boesche <typo3@joergboesche.de>
Reviewed-by: Andreas Fernandez <typo3@scripting-base.de>
Tested-by: Andreas Fernandez <typo3@scripting-base.de>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[!!!][TASK] Replace ClassInfo with ClassSchema 81/54381/23
Alexander Schnitzler [Thu, 12 Oct 2017 14:58:33 +0000 (16:58 +0200)]
[!!!][TASK] Replace ClassInfo with ClassSchema

Extbase came along with two main caches for reflection data.
extbase_reflection and extbase_object. The latter mostly stored
information that were relevant to the dependency injection, like
inject methods and properties and constructor parameters. The
information was gathered by actual reflection and by analysing
doc blocks of properties and methods.

extbase_reflection stored similar reflection and doc block data
about objects but mainly for the parts outside dependency injection.
For example, the validation resolver used it to identify @validate
tags, the ActionController used it to identity which properties not
to validate. The ORM also used it a lot to find annotated types via
@var and so on.

There were a few issues with these two approaches:

- A lot of redundant data was fetched
- Data was fetched multiple times at different locations
- The extbase_reflection cache was stored each plugin seperately,
  resulting in a lot of redundant cache data for each plugin cache
- At a lot of places, the reflection service was used to reflect
  objects, but the data wasn't cached or taken from a cache resulting
  in performance drawbacks

This patch solves these issues with several approaches:

- The extbase_object cache has been removed completely and all
  necessary information about objects, mainly @inject stuff, is
  now fetched from the ReflectionService as well.
- The ReflectionService does still create ClassSchema instances
  but these were improved a lot. All necessary information is now
  gathered during the instantiation of ClassSchema instances. That
  means that all necessary data is fetched once and then it can be
  used everywhere making any further reflection superfluous.
- As runtime reflection has been removed completey, along with it
  several reflection classes, that analyzed doc blocks, have been
  removed as well. These are no longer necessary.
- The extbase_reflection cache is no longer plugin based and will
  no longer be stored in the database in the first place. Serialized
  ClassSchema instances will stored in typo3temp.

Releases: master
Resolves: #57594
Resolves: #55654
Change-Id: I93b905c85c4f28775f014ca8b585347bf6f1e7d3
Reviewed-on: https://review.typo3.org/54381
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Use BE_USER->isAdmin() 14/54414/2
Benni Mack [Tue, 17 Oct 2017 11:02:48 +0000 (13:02 +0200)]
[TASK] Use BE_USER->isAdmin()

TYPO3 Core does not use isAdmin() API of BackendUsers
consistently, as there are some places where a direct
access to $BE_USER->[admin].

Resolves: #82783
Releases: master
Change-Id: I5ae42a79826a3512be8755aabb32b910f4f6c826
Reviewed-on: https://review.typo3.org/54414
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[TASK] Move BackendController addInlineSettings calls to _construct 13/54413/3
Tymoteusz Motylewski [Tue, 17 Oct 2017 08:59:21 +0000 (10:59 +0200)]
[TASK] Move BackendController addInlineSettings calls to _construct

Move calls to addInlineSettings out of the foreach loop, and place them
together with other similar calls.

Resolves: #82781
Releases: master
Change-Id: Ia2269833f7649559a1552a9290773984bebcc102
Reviewed-on: https://review.typo3.org/54413
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Tested-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Georg Ringer <georg.ringer@gmail.com>
Tested-by: Georg Ringer <georg.ringer@gmail.com>
2 years ago[TASK] Use LanguageService inside TSFE 99/52799/9
Benni Mack [Thu, 7 Sep 2017 08:06:31 +0000 (10:06 +0200)]
[TASK] Use LanguageService inside TSFE

TSFE does the same logic as $GLOBALS['LANG'] (= LanguageService) for
fetching labels and language files, but with a different language key.

However, LanguageService is not a singleton, so it _can_ be used
multiple times at the same request, so why not use the LanguageService
for labels based on config.sys_language, and the $GLOBALS['LANG'] record
based on the current backend user.

So, TSFE only acts as a wrapper for LanguageService instead of having
duplicate code.

A few now useless internal properties are dropped, some other
methods are deprecated:

- TSFE->LL_files_cache
- TSFE->LL_labels_cache

- TSFE->readLLfile()
- TSFE->getLLL()
- TSFE->initLLvars()

Resolves: #81217
Releases: master
Change-Id: Iae85ac2eda4d7f77960de2d66b9069f6017c31d8
Reviewed-on: https://review.typo3.org/52799
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Reviewed-by: Wouter Wolters <typo3@wouterwolters.nl>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
2 years ago[TASK] Cleanup DataHandler - again and again 08/54408/4
Benni Mack [Mon, 16 Oct 2017 16:24:53 +0000 (18:24 +0200)]
[TASK] Cleanup DataHandler - again and again

This patch straightens several areas to use proper API calls,
and separates bigger methods into smaller methods.

Resolves: #82778
Releases: master
Change-Id: Ibfa80589a026966f4cbd0f2e6e7e4062033b3ab8
Reviewed-on: https://review.typo3.org/54408
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
2 years ago[CLEANUP] Code cleanup in ModuleMenu.js 06/54406/3
Tymoteusz Motylewski [Mon, 16 Oct 2017 15:13:04 +0000 (17:13 +0200)]
[CLEANUP] Code cleanup in ModuleMenu.js

Adds some JS doc and renames few properties to make code more readable.

Resolves: #82775
Releases: master
Change-Id: I8cb66ee1d52be00ea6e556d369607aecc7e4e2fb
Reviewed-on: https://review.typo3.org/54406
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Markus Klein <markus.klein@typo3.org>
Tested-by: Markus Klein <markus.klein@typo3.org>
Reviewed-by: Sebastian Fischer <typo3@evoweb.de>
Reviewed-by: Benni Mack <benni@typo3.org>
Tested-by: Benni Mack <benni@typo3.org>
2 years ago[TASK] Enable backendlayouts/ tsConfig on doktype menu separator 10/53810/7
Riccardo De Contardi [Sat, 26 Aug 2017 15:54:02 +0000 (17:54 +0200)]
[TASK] Enable backendlayouts/ tsConfig on doktype menu separator

Adds to page with doktype=199 (spacer) the tab "Appereance" with palette
"backend layout" and the tab "Resources" with palette "TSConfig".

Resolves: #77892
Releases: master
Change-Id: I3c5a47fcc551858bc889a7fe127d241b0f961faf
Reviewed-on: https://review.typo3.org/53810
Reviewed-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: Christian Kuhn <lolli@schwarzbu.ch>
Tested-by: TYPO3com <no-reply@typo3.com>
Reviewed-by: Susanne Moog <susanne.moog@typo3.org>
Tested-by: Susanne Moog <susanne.moog@typo3.org>